⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 31, 2013:

10:13 PM Changeset in webkit [158425] by oliver@apple.com
  • 8 edits in trunk

JavaScript parser bug
​https://bugs.webkit.org/show_bug.cgi?id=123506

Reviewed by Mark Lam.

Source/JavaScriptCore:

Add ParserState as an abstraction and use that to save and restore
the parser state around nested functions (We'll need to use this in
more places in future). Also fix a minor error typo this testcases
hit.

  • parser/Parser.cpp:

(JSC::::parseFunctionInfo):
(JSC::::parseAssignmentExpression):

  • parser/Parser.h:

(JSC::Parser::saveState):
(JSC::Parser::restoreState):

LayoutTests:

Update and add tests

  • js/dom/assign-expected.txt:
  • js/function-toString-parentheses-expected.txt:
  • js/parser-syntax-check-expected.txt:
  • js/script-tests/parser-syntax-check.js:
8:28 PM Changeset in webkit [158424] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Update the test expectations for the bug 121452.

fast/frames/lots-of-objects.html and lots-of-iframes.html are timing out everywhere on Mac.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
7:47 PM Changeset in webkit [158423] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Update the Mac test expectation for the mac-future.

  • platform/mac/TestExpectations:
7:32 PM Changeset in webkit [158422] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit

Windows build fix attempt after r158421.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
7:05 PM Changeset in webkit [158421] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

Web Inspector: Clean up a few Inspector interfaces
​https://bugs.webkit.org/show_bug.cgi?id=123594

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-31
Reviewed by Timothy Hatcher.

  • WebCore.exp.in:
  • inspector/InjectedScriptHost.cpp:
  • inspector/InspectorBaseAgent.h:

(WebCore::InspectorBaseAgentInterface::name):

  • inspector/InspectorConsoleAgent.cpp:
  • inspector/InspectorConsoleAgent.h:

(WebCore::InspectorConsoleAgent::enabled):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::profilerEnabled):

  • inspector/InspectorController.h:
  • inspector/InspectorDebuggerAgent.cpp:
  • inspector/InspectorDebuggerAgent.h:

(WebCore::InspectorDebuggerAgent::enabled):

  • inspector/InspectorRuntimeAgent.h:

(WebCore::InspectorRuntimeAgent::enabled):

6:45 PM Changeset in webkit [158420] by Lucas Forschler
  • 5 edits in branches/safari-537.73-branch/Source

Versioning.

6:42 PM Changeset in webkit [158419] by Lucas Forschler
  • 1 copy in tags/Safari-537.73.2

New Tag.

6:27 PM Changeset in webkit [158418] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix a typo/review comment from Dan, in ​http://trac.webkit.org/changeset/158413

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:
6:16 PM Changeset in webkit [158417] by timothy_horton@apple.com
  • 11 edits in trunk/Source

Remote Layer Tree: Vend layer contents via IOSurfaces
​https://bugs.webkit.org/show_bug.cgi?id=123600

Reviewed by Anders Carlsson.

  • Configurations/WebKit2.xcconfig:

Link WebKit2 against IOSurface.

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::dumpChangedLayers):
Dump the size of the backing store instead of the pointer of its
SharedBitmap, because that's slightly more useful.

  • UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::commit):
If a layer's backing store uses accelerated drawing, hand the IOSurface
to the CALayer for display.

  • WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::PlatformCALayerRemote):
Initialize contentsScale to 1 to match CA. Other properties will follow.

(PlatformCALayerRemote::ensureBackingStore):
Instead of replacing the RemoteLayerBackingStore when its properties
change, allow it to update them on the fly. Replacing them caused
us to throw away repaint rects when the accelerated drawing
flag was flipped.

(PlatformCALayerRemote::acceleratesDrawing):
(PlatformCALayerRemote::setAcceleratesDrawing):
Store the accelerated drawing flag and mark it dirty when it changes.

  • WebProcess/WebPage/mac/PlatformCALayerRemote.h:
  • WebProcess/WebPage/mac/RemoteLayerBackingStore.h:

(WebKit::RemoteLayerBackingStore::image):
Rename bitmap() to image() and have it create a CGImageRef from
the ShareableBitmap, ready for direct application to a CALayer.

(WebKit::RemoteLayerBackingStore::surface):
Return a IOSurface ready for direct application to a CALayer.

(WebKit::RemoteLayerBackingStore::acceleratesDrawing):
(WebKit::RemoteLayerBackingStore::hasFrontBuffer):
Return whether or not we have a front buffer/surface.

  • WebProcess/WebPage/mac/RemoteLayerBackingStore.mm:

Forward-declare some CGIOSurface SPI.

(RemoteLayerBackingStore::RemoteLayerBackingStore):
(RemoteLayerBackingStore::ensureBackingStore):
Throw away our front image and reset flags if needed.

(RemoteLayerBackingStore::encode):
(RemoteLayerBackingStore::decode):
En/decode the front surface instead of the ShareableBitmap if needed,
using CoreIPC::MachPort. Destroy the port on receipt.

(createIOSurfaceContext):
Create a CGIOSurfaceContext from an IOSurface.

(createIOSurface):
Create an IOSurface of the given size.

(RemoteLayerBackingStore::image):
Return a CGImageRef, if we're not using accelerated drawing.
Moved from the header.

(RemoteLayerBackingStore::display):
(RemoteLayerBackingStore::drawInContext):
If using accelerated drawing, create and paint into an IOSurface.
Reorganize some code to make the copying-from-the-front-image code
work for both software and IOSurfaces.
Flush the context when completed, to ensure that any asynchronous
painting is complete before we vend the surface to the UI process.

  • WebCore.exp.in:

Export sRGBColorSpaceRef.

  • WebCore.xcodeproj/project.pbxproj:

Expose GraphicsContextCG.h.

6:11 PM Changeset in webkit [158416] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove unused Page::setDebuggerForAllPages
​https://bugs.webkit.org/show_bug.cgi?id=123602

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-31
Reviewed by Timothy Hatcher.

  • page/Page.cpp:
  • page/Page.h:
6:07 PM Changeset in webkit [158415] by commit-queue@webkit.org
  • 75 edits
    3 deletes in trunk/Source

Web Inspector: Remove InspectorState
​https://bugs.webkit.org/show_bug.cgi?id=123547

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-31
Reviewed by Timothy Hatcher.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::InspectorAgent):

  • inspector/InspectorAgent.h:

(WebCore::InspectorAgent::create):

  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):

  • inspector/InspectorApplicationCacheAgent.h:

(WebCore::InspectorApplicationCacheAgent::create):

  • inspector/InspectorBaseAgent.cpp:

(WebCore::InspectorBaseAgentInterface::InspectorBaseAgentInterface):

  • inspector/InspectorBaseAgent.h:

(WebCore::InspectorBaseAgent::InspectorBaseAgent):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::InspectorCSSAgent):

  • inspector/InspectorCSSAgent.h:

(WebCore::InspectorCSSAgent::create):

  • inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::InspectorCanvasAgent):

  • inspector/InspectorCanvasAgent.h:

(WebCore::InspectorCanvasAgent::create):

  • inspector/InspectorClient.h:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):

  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):

  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):

  • inspector/InspectorDOMAgent.h:

(WebCore::InspectorDOMAgent::create):

  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::create):
(WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):

  • inspector/InspectorDOMDebuggerAgent.h:
  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):

  • inspector/InspectorDOMStorageAgent.h:

(WebCore::InspectorDOMStorageAgent::create):

  • inspector/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):

  • inspector/InspectorDatabaseAgent.h:

(WebCore::InspectorDatabaseAgent::create):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorHeapProfilerAgent.cpp:

(WebCore::InspectorHeapProfilerAgent::create):
(WebCore::InspectorHeapProfilerAgent::InspectorHeapProfilerAgent):

  • inspector/InspectorHeapProfilerAgent.h:
  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore::InspectorIndexedDBAgent::InspectorIndexedDBAgent):

  • inspector/InspectorIndexedDBAgent.h:

(WebCore::InspectorIndexedDBAgent::create):

  • inspector/InspectorInputAgent.cpp:

(WebCore::InspectorInputAgent::InspectorInputAgent):

  • inspector/InspectorInputAgent.h:

(WebCore::InspectorInputAgent::create):

  • inspector/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::InspectorLayerTreeAgent):

  • inspector/InspectorLayerTreeAgent.h:

(WebCore::InspectorLayerTreeAgent::create):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
(WebCore::InspectorMemoryAgent::create):

  • inspector/InspectorMemoryAgent.h:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::create):
(WebCore::InspectorPageAgent::InspectorPageAgent):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::PageProfilerAgent::PageProfilerAgent):
(WebCore::InspectorProfilerAgent::create):
(WebCore::WorkerProfilerAgent::WorkerProfilerAgent):
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):

  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::InspectorResourceAgent):

  • inspector/InspectorResourceAgent.h:

(WebCore::InspectorResourceAgent::create):

  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):

  • inspector/InspectorRuntimeAgent.h:
  • inspector/InspectorState.cpp: Removed.
  • inspector/InspectorState.h: Removed.
  • inspector/InspectorStateClient.h: Removed.
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):

  • inspector/InspectorTimelineAgent.h:

(WebCore::InspectorTimelineAgent::create):

  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::create):
(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):

  • inspector/InspectorWorkerAgent.h:
  • inspector/PageConsoleAgent.cpp:

(WebCore::PageConsoleAgent::PageConsoleAgent):

  • inspector/PageConsoleAgent.h:

(WebCore::PageConsoleAgent::create):

  • inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::create):
(WebCore::PageDebuggerAgent::PageDebuggerAgent):

  • inspector/PageDebuggerAgent.h:
  • inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::PageRuntimeAgent):

  • inspector/PageRuntimeAgent.h:

(WebCore::PageRuntimeAgent::create):

  • inspector/WorkerConsoleAgent.cpp:

(WebCore::WorkerConsoleAgent::WorkerConsoleAgent):

  • inspector/WorkerConsoleAgent.h:

(WebCore::WorkerConsoleAgent::create):

  • inspector/WorkerDebuggerAgent.cpp:

(WebCore::WorkerDebuggerAgent::create):
(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):

  • inspector/WorkerDebuggerAgent.h:
  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::connectFrontend):
(WebCore::WorkerInspectorController::disconnectFrontend):

  • inspector/WorkerInspectorController.h:
  • inspector/WorkerRuntimeAgent.cpp:

(WebCore::WorkerRuntimeAgent::WorkerRuntimeAgent):

  • inspector/WorkerRuntimeAgent.h:

(WebCore::WorkerRuntimeAgent::create):

  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::postMessageToPageInspector):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::postMessageToPageInspector):

  • workers/WorkerMessagingProxy.h:
  • workers/WorkerReportingProxy.h:

Source/WebKit/blackberry:

  • WebCoreSupport/InspectorClientBlackBerry.cpp:
  • WebCoreSupport/InspectorClientBlackBerry.h:
6:01 PM Changeset in webkit [158414] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Compile fix for VS2012.
​https://bugs.webkit.org/show_bug.cgi?id=123599

Patch by Alex Christensen <​achristensen@webkit.org> on 2013-10-31
Reviewed by Brent Fulgham.

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::WebFramePolicyListenerPrivate::WebFramePolicyListenerPrivate):
(WebFrameLoaderClient::cancelPolicyCheck):
(WebFrameLoaderClient::receivedPolicyDecision):
Use nullptr instead of 0 for m_policyFunction, which is a std::function.

5:48 PM Changeset in webkit [158413] by andersca@apple.com
  • 4 edits
    3 adds in trunk/Source/WebKit2

Begin stubbing out the WKRemoteObjectCoder NSCoder subclass
​https://bugs.webkit.org/show_bug.cgi?id=123596

Reviewed by Tim Horton.

  • Shared/API/Cocoa/WKRemoteObject.mm:

(-[WKRemoteObject forwardInvocation:]):
Call through to the WKRemoteObjectRegistry.

  • Shared/API/Cocoa/WKRemoteObjectCoder.h: Added.
  • Shared/API/Cocoa/WKRemoteObjectCoder.mm: Added.

(-[WKRemoteObjectEncoder init]):
Create a root WKDictionary.

(-[WKRemoteObjectEncoder dealloc]):
Assert that the current dictionary is the root dictionary; that we're back where we started.

(-[WKRemoteObjectEncoder allowsKeyedCoding]):
Return YES.

(-[WKRemoteObjectEncoder encodeObject:forKey:]):
Check that the object is valid and then encode it.

(-[WKRemoteObjectEncoder _encodeInvocation:forKey:]):
Encode the method type string and invocation selector.

(-[WKRemoteObjectEncoder encodeBytes:length:forKey:]):
Create a WKDataRef and add it to the dictionary.

(-[WKRemoteObjectEncoder _encodeObjectForKey:usingBlock:]):
Create a new dictionary and call the block.

  • Shared/API/Cocoa/WKRemoteObjectRegistry.mm:

(-[WKRemoteObjectRegistry _sendInvocation:interface:]):
Create an encoder and encode the invocation and interface.

  • Shared/API/Cocoa/WKRemoteObjectRegistryInternal.h: Added.

Add IPI header.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

5:45 PM Changeset in webkit [158412] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

FTL Int32ToDouble should handle the forward type check case where you need a recovery
​https://bugs.webkit.org/show_bug.cgi?id=123605

Reviewed by Mark Hahnenberg.

If you have a Int32ToDouble that needs to do a type check and it's required to do a
forward exit, then it needs to manually pass in a value recovery for itself in the
OSR exit - since this is one of those forward-exiting nodes that doesn't have a
preceding MovHint.

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileInt32ToDouble):
(JSC::FTL::LowerDFGToLLVM::forwardTypeCheck):

5:35 PM Changeset in webkit [158411] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-537.73-branch

Merged r157183. <rdar://problem/15333287>

5:31 PM Changeset in webkit [158410] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Address review comments.

  • Shared/API/Cocoa/WKRemoteObject.h:
  • Shared/API/Cocoa/WKRemoteObject.mm:

(-[WKRemoteObject conformsToProtocol:]):

5:05 PM Changeset in webkit [158409] by beidson@apple.com
  • 5 edits
    1 add in trunk/Source/WebCore

Split PendingDeleteCall into its own header
​https://bugs.webkit.org/show_bug.cgi?id=123597

Reviewed by Beth “Okay I guess so, bro” Dakin.

  • GNUmakefile.list.am:
  • WebCore.xcodeproj/project.pbxproj:
  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::deleteDatabase):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:
  • Modules/indexeddb/IDBPendingDeleteCall.h: Added.

(WebCore::IDBPendingDeleteCall::create):
(WebCore::IDBPendingDeleteCall::callbacks):
(WebCore::IDBPendingDeleteCall::IDBPendingDeleteCall):

5:01 PM Changeset in webkit [158408] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Convert some InspectorObject member variables to HashSet/HashMap
​https://bugs.webkit.org/show_bug.cgi?id=123579

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-31
Reviewed by Timothy Hatcher.

  • inspector/InspectorDOMDebuggerAgent.h:
  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
(WebCore::InspectorDOMDebuggerAgent::setBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorDOMDebuggerAgent::setXHRBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeXHRBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
Make m_eventListenerBreakpoints and m_xhrBreakpoints HashSet.

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::disable):
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDebuggerAgent::didParseSource):
Make m_javaScriptBreakpoints a HashMap.

4:56 PM Changeset in webkit [158407] by andersca@apple.com
  • 6 edits
    1 copy
    1 add in trunk

Add a WKRemoteObject class
​https://bugs.webkit.org/show_bug.cgi?id=123586

Reviewed by Dan Bernstein.

Source/WebKit2:

  • Shared/API/Cocoa/WKRemoteObject.h: Added.
  • Shared/API/Cocoa/WKRemoteObject.mm: Added.

(-[WKRemoteObject _initWithObjectRegistry:interface:]):
Add designated initializer.

(-[WKRemoteObject conformsToProtocol:]):
Check if the interface protocol conforms to our protocol.

(methodArgumentTypeEncodingForSelector):
Helper function that looks up a method in a given protocol and returns its type encoding.

(-[WKRemoteObject methodSignatureForSelector:]):
Try to find the method argument type encoding for the given selector and return its NSMethodSignature.

(-[WKRemoteObject forwardInvocation:]):
Add stub.

  • Shared/API/Cocoa/WKRemoteObjectInterface.mm:

Remove a newline.

  • Shared/API/Cocoa/WKRemoteObjectRegistry.mm:

(-[WKRemoteObjectRegistry remoteObjectProxyWithInterface:]):
Establish a mapping between interface identifiers and remote object proxies.

  • WebKit2.xcodeproj/project.pbxproj:

Tools:

  • TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:

(TestWebKitAPI::TEST):
Add a conformsToProtocol: test.

4:30 PM Changeset in webkit [158406] by Lucas Forschler
  • 19 edits
    9 copies in tags/Safari-538.4

Rollout r158288, r158291, r158295, r158311, r158318.

4:23 PM Changeset in webkit [158405] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Correct the elapsedTime calculation in SVG animations
​https://bugs.webkit.org/show_bug.cgi?id=119289

Patch by Youenn Fablet <​youennf@gmail.com> on 2013-10-31
Reviewed by Brent Fulgham.

Merged from Blink: ​https://chromium.googlesource.com/chromium/blink/+/338f9badca7fb7880abdb0cecd5f02493c1f7d2e

Source/WebCore:

Test: svg/animations/getCurrentTime-pause-unpause.html

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::SMILTimeContainer):
(WebCore::SMILTimeContainer::elapsed):
(WebCore::SMILTimeContainer::begin):
(WebCore::SMILTimeContainer::pause):
(WebCore::SMILTimeContainer::resume):
(WebCore::SMILTimeContainer::setElapsed):

  • svg/animation/SMILTimeContainer.h:

LayoutTests:

  • svg/animations/getCurrentTime-pause-unpause-expected.txt: Added.
  • svg/animations/getCurrentTime-pause-unpause.html: Added.
4:12 PM Changeset in webkit [158404] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Breakpoints in auto-formatted JavaScript editors are not working
​https://bugs.webkit.org/show_bug.cgi?id=123589

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-31
Reviewed by Timothy Hatcher.

The internal this._ignoreCodeMirrorContentDidChangeEvent flag was being used
in two places that could be nested, meaning the flag was deleted while it
was still expected to be set. Change it instead to a counter, to handle nesting.

  • UserInterface/TextEditor.js:

(WebInspector.TextEditor):
(WebInspector.TextEditor.prototype.set string):
(WebInspector.TextEditor.prototype.set formatted):
(WebInspector.TextEditor.prototype._contentChanged):

3:57 PM Changeset in webkit [158403] by Lucas Forschler
  • 3 edits in tags/Safari-538.4/Source/WebCore

Merged r158391. <rdar://problem/15246606>

3:49 PM Changeset in webkit [158402] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

FTL should implement InvalidationPoint in terms of llvm.stackmap
​https://bugs.webkit.org/show_bug.cgi?id=113647

Reviewed by Mark Hahnenberg.

This is pretty straightforward now that InvalidationPoint has exactly the semantics
that agree with llvm.stackmap.

  • ftl/FTLCompile.cpp:

(JSC::FTL::fixFunctionBasedOnStackMaps):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileInvalidationPoint):
(JSC::FTL::LowerDFGToLLVM::emitOSRExitCall):
(JSC::FTL::LowerDFGToLLVM::buildExitArguments):
(JSC::FTL::LowerDFGToLLVM::callStackmap):

  • ftl/FTLOSRExitCompilationInfo.h:

(JSC::FTL::OSRExitCompilationInfo::OSRExitCompilationInfo):

3:38 PM Changeset in webkit [158401] by oliver@apple.com
  • 9 edits in trunk

Source/JavaScriptCore: Implement basic ES6 Math functions
​https://bugs.webkit.org/show_bug.cgi?id=123536

Reviewed by Michael Saboff.

Fairly trivial patch to implement the core ES6 Math functions.

This doesn't implement Math.hypot as it is not a trivial function.
I've also skipped Math.sign as I am yet to be convinced the spec
behaviour is good. Everything else is trivial.

  • runtime/MathObject.cpp:

(JSC::MathObject::finishCreation):
(JSC::mathProtoFuncACosh):
(JSC::mathProtoFuncASinh):
(JSC::mathProtoFuncATanh):
(JSC::mathProtoFuncCbrt):
(JSC::mathProtoFuncCosh):
(JSC::mathProtoFuncExpm1):
(JSC::mathProtoFuncFround):
(JSC::mathProtoFuncLog1p):
(JSC::mathProtoFuncLog10):
(JSC::mathProtoFuncLog2):
(JSC::mathProtoFuncSinh):
(JSC::mathProtoFuncTanh):
(JSC::mathProtoFuncTrunc):

Source/WTF: Implement basic ES6 Math functions
​https://bugs.webkit.org/show_bug.cgi?id=123536

Reviewed by Michael Saboff.

Add basic implementations of necessary methods to MathExtras to
deal with MSVC not supplying them

  • wtf/MathExtras.h:

(asinh):
(acosh):
(atanh):
(expm1):
(log1p):
(cbrt):

LayoutTests: Implement ES6 Math functions
​https://bugs.webkit.org/show_bug.cgi?id=123536

Reviewed by Michael Saboff.

Add tests for new math functions

  • js/Object-getOwnPropertyNames-expected.txt:
  • js/math-expected.txt:
  • js/script-tests/Object-getOwnPropertyNames.js:
  • js/script-tests/math.js:
3:29 PM Changeset in webkit [158400] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

FTL::Location::restoreInto() doesn't handle stack-related registers correctly if you're using it after pushing a new stack frame
​https://bugs.webkit.org/show_bug.cgi?id=123591

Reviewed by Mark Hahnenberg.

This gets us to pass more tests with ftlUsesStackmaps.

  • ftl/FTLLocation.cpp:

(JSC::FTL::Location::restoreInto):

  • ftl/FTLLocation.h:
  • ftl/FTLThunks.cpp:

(JSC::FTL::osrExitGenerationWithStackMapThunkGenerator):

3:21 PM Changeset in webkit [158399] by Lucas Forschler
  • 8 edits in branches/safari-537.73-branch/Source

Merged r157056. <rdar://problem/15357230>

2:59 PM Changeset in webkit [158398] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Manage line-grid RootInlineBox with unique_ptr.
<​https://webkit.org/b/123583>

Use smart pointers for the RenderBlockFlow's optional line-grid box
instead of manual new/delete.

Reviewed by Antti Koivisto.

2:50 PM Changeset in webkit [158397] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI

Merged r156481. <rdar://problem/15168249>

2:50 PM Changeset in webkit [158396] by ap@apple.com
  • 18 edits
    19 moves
    3 adds in trunk

Enable WebCrypto on Mac
​https://bugs.webkit.org/show_bug.cgi?id=123587

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig: Do it.

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig: Enable it.
  • bindings/js/JSCryptoAlgorithmDictionary.cpp: Build fix.
  • crypto/CryptoAlgorithmRegistry.cpp: (WebCore::CryptoAlgorithmRegistry::getIdentifierForName):

Special case empty keys to avoid upsetting HashMap.

  • crypto/algorithms/CryptoAlgorithmSHA1.cpp: (WebCore::CryptoAlgorithmSHA1::create):

Build fix. Can't use make_unique, because constructor is private.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig: Do it.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig: Do it.

LayoutTests:

  • TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:

Only skipping on specific platforms now.

  • crypto: Added.
  • crypto/crypto-gc-expected.txt: Copied from LayoutTests/security/crypto-gc-expected.txt.
  • crypto/crypto-gc.html: Copied from LayoutTests/security/crypto-gc.html.
  • crypto/crypto-random-values-expected.txt: Copied from LayoutTests/security/crypto-random-values-expected.txt.
  • crypto/crypto-random-values-limits-expected.txt: Copied from LayoutTests/security/crypto-random-values-limits-expected.txt.
  • crypto/crypto-random-values-limits.html: Copied from LayoutTests/security/crypto-random-values-limits.html.
  • crypto/crypto-random-values-types-expected.txt: Copied from LayoutTests/security/crypto-random-values-types-expected.txt.
  • crypto/crypto-random-values-types.html: Copied from LayoutTests/security/crypto-random-values-types.html.
  • crypto/crypto-random-values.html: Copied from LayoutTests/security/crypto-random-values.html.
  • crypto/subtle: Added.
  • crypto/subtle/argument-conversion-expected.txt: Copied from LayoutTests/security/crypto-subtle-arguments-expected.txt.
  • crypto/subtle/argument-conversion.html: Copied from LayoutTests/security/crypto-subtle-arguments.html.
  • crypto/subtle/gc-2-expected.txt: Copied from LayoutTests/security/crypto-subtle-gc-2-expected.txt.
  • crypto/subtle/gc-2.html: Copied from LayoutTests/security/crypto-subtle-gc-2.html.
  • crypto/subtle/gc-3-expected.txt: Copied from LayoutTests/security/crypto-subtle-gc-3-expected.txt.
  • crypto/subtle/gc-3.html: Copied from LayoutTests/security/crypto-subtle-gc-3.html.
  • crypto/subtle/gc-expected.txt: Copied from LayoutTests/security/crypto-subtle-gc-expected.txt.
  • crypto/subtle/gc.html: Copied from LayoutTests/security/crypto-subtle-gc.html.
  • crypto/subtle/resources: Added.
  • crypto/subtle/resources/common.js: Copied from LayoutTests/security/resources/common.js.
  • crypto/subtle/sha-1-expected.txt: Copied from LayoutTests/security/crypto-subtle-sha1-expected.txt.
  • crypto/subtle/sha-1.html: Copied from LayoutTests/security/crypto-subtle-sha1.html.
  • security/crypto-gc-expected.txt: Removed.
  • security/crypto-gc.html: Removed.
  • security/crypto-random-values-expected.txt: Removed.
  • security/crypto-random-values-limits-expected.txt: Removed.
  • security/crypto-random-values-limits.html: Removed.
  • security/crypto-random-values-types-expected.txt: Removed.
  • security/crypto-random-values-types.html: Removed.
  • security/crypto-random-values.html: Removed.
  • security/crypto-subtle-arguments-expected.txt: Removed.
  • security/crypto-subtle-arguments.html: Removed.
  • security/crypto-subtle-gc-2-expected.txt: Removed.
  • security/crypto-subtle-gc-2.html: Removed.
  • security/crypto-subtle-gc-3-expected.txt: Removed.
  • security/crypto-subtle-gc-3.html: Removed.
  • security/crypto-subtle-gc-expected.txt: Removed.
  • security/crypto-subtle-gc.html: Removed.
  • security/crypto-subtle-sha1-expected.txt: Removed.
  • security/crypto-subtle-sha1.html: Removed.
  • security/resources/common.js: Removed.

Moved tests from security/ to crypto/.

2:29 PM Changeset in webkit [158395] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI

Merged r154897. <rdar://problem/15168237>

2:24 PM Changeset in webkit [158394] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI

Merged r153087. <rdar://problem/15168237>

2:15 PM Changeset in webkit [158393] by rniwa@webkit.org
  • 2 edits
    2 adds in trunk/Tools

build.webkit.org should have a clean build button
​https://bugs.webkit.org/show_bug.cgi?id=123559

Reviewed by Darin Adler.

Add a new "clean" forced scheduler. When a build was created by this scheduler, CleanBuildIfScheduled
step executes clean-build script that removes the WebKitBuild directory.

Also added make-passwords-json.py which creates a fake passwords.json from config.json for testing purposes.

  • BuildSlaveSupport/build.webkit.org-config/make-passwords-json.py: Added.
  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(CleanBuildIfScheduled): Added.
(CleanBuildIfScheduled.start): Added. Don't do a clean build if if this build wasn't schecueld by
the clean build scheduler.
(DeleteStaleBuildFiles): Added.
(DeleteStaleBuildFiles.start): Added. Don't delete stale build files if this build was scheduled by
the clean build scheduler since everything in the WebKitBuild directory had already been removed.
(Factory.init): Always add CleanBuildIfScheduled. The step itself checks whether to run
clean-build script or hide itself.
(loadBuilderConfig): Added the new clean build scheduler. Also make ForceScheduler future proof; in newer
versions of buildbot, builderNames needs to be a list of regular strings.

  • BuildSlaveSupport/clean-build: Added.
2:14 PM Changeset in webkit [158392] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Underline bounds cannot be queried before underline itself is drawn
​https://bugs.webkit.org/show_bug.cgi?id=123310

Patch by Myles C. Maxfield <​mmaxfield@apple.com> on 2013-10-31
Reviewed by Dean Jackson.

GraphicsContext's drawLineForText function is used to draw underlines,
strikethroughs, and overlines. Before drawing the line, this function
modifies the bounds given to it in order to make underlines crisp. However,
this means that it is impossible to know where an underline will be drawn
before drawing it. This patch pulls out this adjustment computation into
GraphicsContext::computeLineBoundsForText, then passes the result to
drawLineForText

Because there should be no observable difference, no tests need to be updated.

  • platform/graphics/GraphicsContext.h: Signature of new computeLineBoundsForText

function

  • platform/graphics/blackberry/PathBlackBerry.cpp:

(WebCore::GraphicsContext::computeLineBoundsForText): Implement new function

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::computeLineBoundsForText): Ditto
(WebCore::GraphicsContext::drawLineForText): Use computeLineBoundsForText

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::computeLineBoundsAndAntialiasingModeForText): Static function that
performs the actual bounds computation
(WebCore::GraphicsContext::computeLineBoundsForText): Calls
computeLineBoundsAndAntialiasingModeForText
(WebCore::GraphicsContext::drawLineForText): Use new function

  • platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::GraphicsContext::computeLineBoundsForText): Implement new function

2:03 PM Changeset in webkit [158391] by Beth Dakin
  • 3 edits in trunk/Source/WebCore

Repro scrolling crash with scrollbars that use setPresentationValue on the
scrolling thread
​https://bugs.webkit.org/show_bug.cgi?id=123549
-and corresponding-
<rdar://problem/15246606>

Reviewed by Brady Eidson.

Here's another speculative fix. If a scrollbar was removed, we would not properly
inform the scrolling thread. Instead of checking supportsUpdateOnSecondaryThread()
before calling setScrollbarPaintersFromScrollbars(), check it from within
setScrollbarPaintersFromScrollbars(), and this will allow the ScrollbarPainter to
be properly updated.

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::frameViewLayoutUpdated):

  • page/scrolling/mac/ScrollingStateScrollingNodeMac.mm:

(WebCore::ScrollingStateScrollingNode::setScrollbarPaintersFromScrollbars):

1:13 PM Changeset in webkit [158390] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed typo fix after 158386. (buildfix after r158365)

  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::callSuccessHandler):

1:11 PM Changeset in webkit [158389] by commit-queue@webkit.org
  • 30 edits
    4 adds in trunk

Move CSS3 text decoration implementation behind ENABLE(CSS3_TEXT_DECORATION)
​https://bugs.webkit.org/show_bug.cgi?id=123541

Patch by Myles C. Maxfield <​mmaxfield@apple.com> on 2013-10-31
Reviewed by Tim Horton.

Source/WebCore:

Enabled CSS3 text decoration tests

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::renderTextDecorationStyleFlagsToCSSValue): Mapping internal
representation to a CSSValue
(WebCore::ComputedStyleExtractor::propertyValue): Ditto

  • css/CSSParser.cpp: Moving parsing functions behind new flag

(WebCore::isColorPropertyID):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::addTextDecorationProperty):
(WebCore::CSSParser::parseTextDecorationSkip):
(WebCore::CSSParser::parseTextUnderlinePosition):

  • css/CSSParser.h:
  • css/CSSPrimitiveValueMappings.h:
  • css/CSSPropertyNames.in: Marking the new properties behind new flag
  • css/CSSValueKeywords.in: Marking new values behind new flag
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):

  • css/StylePropertyShorthand.cpp:

(WebCore::shorthandForProperty): Move text decoration shorthand
(WebCore::matchingShorthandsForLonghand):

  • css/StylePropertyShorthand.h:
  • css/StyleResolver.cpp:

(WebCore::isValidVisitedLinkProperty):
(WebCore::StyleResolver::applyProperty):

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::setPlatformStrokeStyle):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawLine):

  • platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::createPen):

  • rendering/InlineFlowBox.cpp:
  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp:

(WebCore::textDecorationStyleToStrokeStyle):
(WebCore::computeUnderlineOffset):
(WebCore::InlineTextBox::paintDecoration):

  • rendering/RenderObject.cpp:

(WebCore::decorationColor):

  • rendering/RootInlineBox.cpp:
  • rendering/RootInlineBox.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresRepaintIfTextOrBorderOrOutline):
(WebCore::RenderStyle::colorIncludingFallback):
(WebCore::RenderStyle::visitedDependentColor):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

  • platform/mac/TestExpectations: Enable CSS3 text decoration tests

(since CSS3_TEXT_DECORATION is enabled by default)

12:50 PM Changeset in webkit [158388] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebKit2

[WK2] Convert SeccompFilters to using unique_ptr instead of OwnPtr/PassOwnPtr
​https://bugs.webkit.org/show_bug.cgi?id=122883

Patch by Sergio Correia <Sergio Correia> on 2013-10-31
Reviewed by Darin Adler.

  • Shared/linux/SeccompFilters/OpenSyscall.cpp:

(WebKit::OpenSyscall::createFromOpenatContext):
(WebKit::OpenSyscall::createFromCreatContext):
(WebKit::OpenSyscall::execute):

  • Shared/linux/SeccompFilters/OpenSyscall.h:
  • Shared/linux/SeccompFilters/SeccompBroker.cpp:

(WebKit::SIGSYSHandler):
(WebKit::SeccompBrokerClient::dispatch):
(WebKit::SeccompBroker::runLoop):

  • Shared/linux/SeccompFilters/SigactionSyscall.cpp:

(WebKit::SigactionSyscall::createFromContext):

  • Shared/linux/SeccompFilters/SigactionSyscall.h:
  • Shared/linux/SeccompFilters/SigprocmaskSyscall.cpp:

(WebKit::SigprocmaskSyscall::createFromContext):

  • Shared/linux/SeccompFilters/SigprocmaskSyscall.h:
  • Shared/linux/SeccompFilters/Syscall.cpp:

(WebKit::Syscall::createFromContext):
(WebKit::Syscall::createFromDecoder):
(WebKit::SyscallResult::createFromDecoder):

  • Shared/linux/SeccompFilters/Syscall.h:
  • Shared/linux/SeccompFilters/SyscallPolicy.cpp:
12:31 PM Changeset in webkit [158387] by ap@apple.com
  • 7 edits
    9 adds in trunk

[WebCrypto] Add SHA-1
​https://bugs.webkit.org/show_bug.cgi?id=123582

Reviewed by Anders Carlsson.

Source/WebCore:

Tests: security/crypto-subtle-arguments.html

security/crypto-subtle-sha1.html

  • WebCore.xcodeproj/project.pbxproj: Added new files.
  • bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::createAlgorithmFromJSValue):
(WebCore::sequenceOfCryptoOperationDataFromJSValue):
(WebCore::JSSubtleCrypto::digest):

  • crypto/SubtleCrypto.idl:

Added bindings for crypto.digest.

  • crypto/algorithms: Added.
  • crypto/algorithms/CryptoAlgorithmSHA1.cpp: Added.
  • crypto/algorithms/CryptoAlgorithmSHA1.h: Added.
  • crypto/mac/CryptoAlgorithmRegistryMac.cpp:

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms): Register SHA-1.

  • crypto/mac/CryptoAlgorithmSHA1Mac.cpp: Added.

(WebCore::CryptoAlgorithmSHA1::digest): Performs the work synchronously, because
otherwise we'd have to copy the data first, which is crazy for something as simple
as hashing. We can change to a dispatch queue later if we find that it's actually
better to copy and do the work asynchronously.

LayoutTests:

  • security/resources/common.js: Added from Blink.

(importTestKeys):
(asciiToArrayBuffer):
(printRejectedResult):
(printAcceptedResult):
(failAndFinishJSTest):

  • security/crypto-subtle-arguments-expected.txt: Added.
  • security/crypto-subtle-arguments.html: Added.

Added tests for how bindings treat crazy arguments. Heavily based on a test from Blink.

  • security/crypto-subtle-sha1-expected.txt: Added.
  • security/crypto-subtle-sha1.html: Added.

Test that SHA-1 works.

12:22 PM Changeset in webkit [158386] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

One more speculative buildfix after r158365.

  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::callSuccessHandler):

12:20 PM Changeset in webkit [158385] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, really remove CachedTranscendentalFunction.h.

12:19 PM Changeset in webkit [158384] by fpizlo@apple.com
  • 22 edits
    6 adds
    1 delete in trunk

Remove CachedTranscendentalFunction because caching math functions is an ugly idea
​https://bugs.webkit.org/show_bug.cgi?id=123574

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

This is performance-neutral because I also make Math.cos/sin intrinsic. This means that
we gain the "overhead" of actually computing sin and cos but we lose the overhead of
going through the native call thunks.

Caching transcendental functions is a really ugly idea. It works for SunSpider because
that benchmark makes very predictable calls into Math.sin. But I don't believe that this
is representative of any kind of reality, and so for sensible uses of Math.sin/cos all
that this was doing was adding more call overhead and some hashing overhead.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

  • dfg/DFGBackwardsPropagationPhase.cpp:

(JSC::DFG::BackwardsPropagationPhase::propagate):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsic):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNodeType.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::doDoubleVoting):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITOperations.h:
  • runtime/CachedTranscendentalFunction.h: Removed.
  • runtime/DateInstanceCache.h:
  • runtime/Intrinsic.h:
  • runtime/MathObject.cpp:

(JSC::MathObject::finishCreation):
(JSC::mathProtoFuncCos):
(JSC::mathProtoFuncSin):

  • runtime/VM.h:

Tools:

Reviewed by Mark Hahnenberg.

Make it easier to see that a test doesn't have an -expected file.

  • Scripts/run-jsc-stress-tests:

LayoutTests:

Reviewed by Mark Hahnenberg.

  • js/dfg-cos-constant-expected.txt: Added.
  • js/dfg-cos-constant.html: Added.
  • js/dfg-sin-constant-expected.txt: Added.
  • js/dfg-sin-constant.html: Added.
  • js/script-tests/dfg-cos-constant.js: Added.

(foo):

  • js/script-tests/dfg-sin-constant.js: Added.

(foo):

12:17 PM Changeset in webkit [158383] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r158348): Breaks Debug build
​https://bugs.webkit.org/show_bug.cgi?id=123562

Patch by Sudarsana Nagineni <​sudarsana.nagineni@intel.com> on 2013-10-31
Reviewed by Brady Eidson.

Remove an unnecessary check that cause compilation failure.

No new tests since this just fixes the build failure.

  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:

(WebCore::IDBBackingStoreLevelDB::updateIDBDatabaseVersion):

12:16 PM Changeset in webkit [158382] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

One more speculative buildfix after r158365.

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::didAddRemoteStream):

12:08 PM Changeset in webkit [158381] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebCore

Speculative buildfix after r158365.

  • Modules/mediastream/VideoStreamTrack.cpp:

(WebCore::VideoStreamTrack::create):
(WebCore::VideoStreamTrack::VideoStreamTrack):

  • Modules/mediastream/VideoStreamTrack.h:
12:08 PM Changeset in webkit [158380] by Lucas Forschler
  • 2 edits in tags/Safari-538.4/Source/WebCore

Merged r158375. <rdar://problem/15246606>

11:47 AM Changeset in webkit [158379] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Decorated text sometimes does not draw its decorations
​https://bugs.webkit.org/show_bug.cgi?id=123539

Patch by Myles C. Maxfield <​mmaxfield@apple.com> on 2013-10-31
Reviewed by Antti Koivisto.

Decorated text should opt-out of the simple line layout, because
SimpleLineLayout::paintFlow doesn't draw decorations

Fixes fast/css3-text/css3-text-decoration/text-decoration-color.html

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

11:40 AM Changeset in webkit [158378] by Lucas Forschler
  • 4 edits in tags/Safari-538.4/Source/JavaScriptCore

Merged r158341. <rdar://problem/15356238>

11:33 AM Changeset in webkit [158377] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

Web Inspector: Remove last member variable uses of InspectorState from Agents
​https://bugs.webkit.org/show_bug.cgi?id=123540

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-31
Reviewed by Timothy Hatcher.

  • inspector/InspectorDOMDebuggerAgent.h:
  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
(WebCore::InspectorDOMDebuggerAgent::setBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorDOMDebuggerAgent::setXHRBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeXHRBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
DOMDebuggerAgentState::eventListenerBreakpoints -> m_eventListenerBreakpoints.
DOMDebuggerAgentState::xhrBreakpoints -> m_xhrBreakpoints.

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::disable):
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDebuggerAgent::didParseSource):
DebuggerAgentState::javaScriptBreakpoints -> m_javaScriptBreakpoints.

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::addScriptToEvaluateOnLoad):
(WebCore::InspectorPageAgent::removeScriptToEvaluateOnLoad):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
PageAgentState::pageAgentScriptsToEvaluateOnLoad -> m_scriptsToEvaluateOnLoad.
This is a lazily created InspectorObject member variable.

  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::disable):
(WebCore::InspectorResourceAgent::setExtraHTTPHeaders):
ResourceAgentState::extraRequestHeaders -> m_extraRequestHeaders.
This is a lazily created InspectorObject member variable.

11:29 AM Changeset in webkit [158376] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

Unreviewed, one more build fix after r158365.

  • Modules/webaudio/MediaStreamAudioDestinationNode.cpp:

(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):

11:26 AM Changeset in webkit [158375] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Repro scrolling crash with scrollbars that use setPresentationValue on the
scrolling thread
​https://bugs.webkit.org/show_bug.cgi?id=123549
-and corresponding-
<rdar://problem/15246606>

Reviewed by Darin Adler.

Speculative fix. I think if we retain the ScrollbarPainters, we should avoid this
crash.

  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:
11:18 AM Changeset in webkit [158374] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

Unreviewed, MediaStream build fix after r158365.

  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::clone):

11:13 AM Changeset in webkit [158373] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

Run tests as if they are expected to pass when --force is given.
​https://bugs.webkit.org/show_bug.cgi?id=112890

Patch by Tamas Gergely <​gertom@inf.u-szeged.hu> on 2013-10-31
Reviewed by Ryosuke Niwa.

The --force switch of new-run-webkit-tests is now forces all tests to
be run with 'PASS' as expected result.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.run):

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations.init):
(TestExpectations._add_expectations):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):
(_set_up_derived_options):

11:05 AM Changeset in webkit [158372] by barraclough@apple.com
  • 12 edits in trunk/Source/WebKit2

Change WebPage, WebPageProxy, WebPageCreationParameters to use ViewState
​https://bugs.webkit.org/show_bug.cgi?id=123379

Reviewed by Darin Adler.

Visibility state of the Page should be stored and communicated consistently.

Remove individual visibility flags from WebPageProxy, WebPageCreationParameters,
and replace them with a ViewState, and add a ViewState member to WebPage.
Merge together all messages that convey and individual aspect of the ViewState.

Restructure WebPageProxy::viewStateDidChange to break the operation down into
three steps: 1) update m_viewState, 2) send the new ViewState to the WebProcess,
and 3) perform any further work necessary in the UIProcess.

This patch fixes a problem that if the web process crashes m_isVisible &
m_isInWindow in WebPageProxy were not updated, and could have held stale values
on reattach.

In WebPage, add a new message to update the entire ViewState - diff the prior
value against the new one to detect changes, call existing methods accordingly.

  • Shared/ViewState.h:
    • Add constants 'Reset', 'AllFlags'
  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
    • Removed boolean visibility flags, added viewState.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):

  • Constructor calls updateViewState to initialize m_viewState.

(WebKit::WebPageProxy::reattachToWebProcess):

  • ViewStaet is not updated while detatched; recalculate.

(WebKit::WebPageProxy::initializeWebPage):

  • m_isVisible -> isViewVisible()

(WebKit::WebPageProxy::updateViewState):

  • Added, update m_viewState by querying the page client.

(WebKit::WebPageProxy::viewStateDidChange):

  • Restructured to use m_viewState, reordered to combine messages.

(WebKit::WebPageProxy::creationParameters):

  • Removed boolean visibility flags, added viewState.
  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::isInWindow):
(WebKit::WebPageProxy::isViewVisible):

  • Removed boolean visibility flags, added viewState.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

  • initial state now passed as a ViewState.

(WebKit::WebPage::setIsInWindow):

  • Remove code to send reply (this is handled by setViewState).

(WebKit::WebPage::setViewState):

  • Set m_viewState - diff from prior & call methods to update.
  • WebProcess/WebPage/WebPage.h:
    • Added setViewState, m_viewState.
  • WebProcess/WebPage/WebPage.messages.in:
    • Add SetViewState, remove individual messages.
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):

  • initial state now passed as a ViewState.
11:03 AM Changeset in webkit [158371] by ggaren@apple.com
  • 2 edits in trunk/Tools

2013-10-31 Geoffrey Garen <​ggaren@apple.com>

Added Mark Lam as a reviewer.

Unreviewed.

  • Scripts/webkitpy/common/config/contributors.json:
11:02 AM Changeset in webkit [158370] by Patrick Gansterer
  • 4 edits in trunk/Source/WebKit/win

[WIN] Make WebHistory compile without USE(CF)
​https://bugs.webkit.org/show_bug.cgi?id=122010

Reviewed by Brent Fulgham.

Add an alternative code path for !USE(CF) to be able to
compile WebHistory without the CoreFoundation library.

  • COMVariantSetter.h: Add support for setting a Vector.
  • WebHistory.cpp:

(createUserInfoFromArray):
(createUserInfoFromHistoryItem):
(WebHistory::removeAllItems):
(WebHistory::removeItem):
(WebHistory::addItem):
(WebHistory::visitedURL):

  • WebHistory.h:
10:48 AM Changeset in webkit [158369] by barraclough@apple.com
  • 4 edits
    2 adds in trunk

WebPageCreationParameters should be consistent in Window.open
​https://bugs.webkit.org/show_bug.cgi?id=123557

Reviewed by Sam Weinig.

When Window.open in called in WebKit2 the WebProcess sends a synchronous request to open
a page (WebPageProxy::createNewPage). The UIProcess creates a WebpageProxy, and responds
with instructions to the WebProcess to create the WebPage. The initial creation state of
the WebPage is communicated to the WebProcess via two routes (firstly an asynchronous
WebProcess::CreateWebPage message, and secondly in the synchronous response from
WebPageProxy::createNewPage). Unfortunately these responses are inconsistent with each
other. The creationParameters() for the page are calculated twice, and since the WKView
will be added to a window between the async message being sent and the synchronous reply
being returned the visibility state of the page can change.

To fix the inconsistency we can set the creation parameters at the point that the
WebPageProxy is instantiated. This will result in a functional change that is web
visible, since the page will initially be opened in a hidden/blurred state, and may
later become visible/focussed. This change is consistent with the direction we want to
evolve in. Whilst we will still probably require a synchronous message from the
WebProcess to the UIProcess on Window.open, we'll probably make this return much earlier
– having just created the WebPageProxy, but avoiding blocking the WebProcess over the
client delegate callback that opens the new window.

This fix results in a layout test result change, due to the change in behavior (page is
created blurred, and becomes focussed, resulting in a focus event being fired – rather
than the window opening directly into a focussed state). This is reported as a
progression (test is broken in WebKit1, fixed in WebKit2 after this change). In reality
the test is actually slightly broken in DRT/test-runner – the test runs differently than
in browser, since there is is no visible main window. In-browser this patch results in
no change in behavior on dom/Window/mozilla-focus-blur.html (the affected test).

Source/WebKit2:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeWebPage):

  • call initializeCreationParameters

(WebKit::WebPageProxy::initializeCreationParameters):

  • calculate m_creationParameters
  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::creationParameters):

  • Added m_creationParameters, initializeCreationParameters, creationParameters returns m_creationParameters

LayoutTests:

  • platform/mac-wk2/fast/dom/Window: Added.
  • platform/mac-wk2/fast/dom/Window/mozilla-focus-blur-expected.txt: Added.
    • This test now reports a pass on WebKit2
10:41 AM Changeset in webkit [158368] by weinig@apple.com
  • 4 edits in trunk/Source/WebCore

Pass an Element by reference to the PseudoElement constructor
​https://bugs.webkit.org/show_bug.cgi?id=123576

Reviewed by Andreas Kling.

  • dom/Element.cpp:

(WebCore::Element::createPseudoElementIfNeeded):

  • dom/PseudoElement.cpp:

(WebCore::PseudoElement::PseudoElement):

  • dom/PseudoElement.h:
10:39 AM Changeset in webkit [158367] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Fix a mis-merge.

  • WebCore.xcodeproj/project.pbxproj: Remove duplicate CryptoAlgorithmRegistryMac.cpp.
10:33 AM Changeset in webkit [158366] by ap@apple.com
  • 3 edits
    4 adds in trunk/Source/WebCore

Add bindings code for crypto algorithm dictionaries
​https://bugs.webkit.org/show_bug.cgi?id=123476

Reviewed by Sam Weinig.

JSCryptoAlgorithmDictionary reads the Algorithm, much like JSDictionary does in
simpler cases. We should see about bringing them closer together (perhaps replacing
with autogenerated code).

  • crypto/parameters: Added.
  • crypto/parameters/CryptoAlgorithmHmacKeyParams.h: Added.
  • crypto/parameters/CryptoAlgorithmHmacParams.h: Added.

Added a couple specific dictionaries as an example.

  • WebCore.xcodeproj/project.pbxproj: Added JSCryptoAlgorithmDictionary.
  • bindings/js/JSCryptoAlgorithmDictionary.cpp: Added.

(WebCore::JSCryptoAlgorithmDictionary::getAlgorithmIdentifier):
(WebCore::getHashAlgorithm):
(WebCore::createHmacParams):
(WebCore::createHmacKeyParams):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForSign):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForVerify):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDigest):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey):

  • bindings/js/JSCryptoAlgorithmDictionary.h: Added.
10:26 AM Changeset in webkit [158365] by weinig@apple.com
  • 49 edits in trunk/Source/WebCore

Pass ScriptExecutionContext by reference to from the bindings constructors
​https://bugs.webkit.org/show_bug.cgi?id=123575

Reviewed by Andreas Kling.

Since we null check the ScriptExecutionContext before creating the c++ class,
we should be passing by reference.

10:17 AM Changeset in webkit [158364] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Paint the input tag of range type on WinCE port.
​https://bugs.webkit.org/show_bug.cgi?id=123199

Patch by Zhuang Zhigang <​zhuangzg@cn.fujitsu.com> on 2013-10-31
Reviewed by Brent Fulgham.

  • rendering/RenderThemeWinCE.cpp:

(WebCore::RenderThemeWinCE::paintSliderTrack):
(WebCore::RenderThemeWinCE::paintSliderThumb):

10:13 AM Changeset in webkit [158363] by ap@apple.com
  • 2 edits
    7 adds in trunk/Source/WebCore

Add a crypto algorithm abstraction
​https://bugs.webkit.org/show_bug.cgi?id=123474

Reviewed by Sam Weinig.

This works slightly differently than WebCrypto implies. We have separate classes
for algorithm and its parameters, while WebCrypto puts them in the same dictionary.

  • WebCore.xcodeproj/project.pbxproj: Added new files.
  • crypto/CryptoAlgorithm.cpp: Added. As most algorithms don't implement most

operations, default implementations just raise an exception.

  • crypto/CryptoAlgorithm.h: Added.
  • crypto/CryptoAlgorithmParameters.h: Added. Base class for numerous future parameter

dictionaries, such as HmacParams or HmacKeyParams.

  • crypto/CryptoAlgorithmRegistry.cpp: Added.
  • crypto/CryptoAlgorithmRegistry.h: Added.

The registry decouples universal bindings code from algorithms that may or may not
be implemented on each platform.

  • crypto/mac: Added.
  • crypto/mac/CryptoAlgorithmRegistryMac.cpp: Added.

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms): Algorithms implemented
on Mac will be registered by this function.

9:50 AM Changeset in webkit [158362] by ap@apple.com
  • 7 edits in trunk

REGRESSION(r158333): http/tests/xmlhttprequest/response-encoding.html and xmlhttprequest-overridemimetype-content-type-header.html are failing
​https://bugs.webkit.org/show_bug.cgi?id=123548

Reviewed by Brady Eidson.

Source/WebCore:

We had code that made sure that cached 200 responses weren't used for conditional
requests. But it didn't work the other way - cached 304 responses got reused for
subsequent unconditional requests!

Adding the test uncovered this bug.

  • loader/cache/CachedRawResource.cpp: (WebCore::shouldIgnoreHeaderForCacheReuse):

Should never ignore conditional headers. Code in determineRevalidationPolicy
was already undoing this for conditional requests, but we also shouldn't use
WebCore cache if it holds a 304 response to conditional request.

  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::determineRevalidationPolicy):

Even though the changed code is only for raw resources, I think that we can never
get a conditional request here any more.

LayoutTests:

  • TestExpectations: Unskip tests that used to be affected by response-empty-arraybuffer.html
  • http/tests/xmlhttprequest/response-empty-arraybuffer-expected.txt:
  • http/tests/xmlhttprequest/response-empty-arraybuffer.html:

Fix a stupid typo. This test actually fully passes.

9:28 AM Changeset in webkit [158361] by ap@apple.com
  • 4 edits in trunk/Source/WebCore

CryptoAlgorithmDescriptionBuilder should support producing nested algorithms
​https://bugs.webkit.org/show_bug.cgi?id=123461

Reviewed by Darin Adler.

To add a nested algorithm, clone a builder with createEmptyClone(), fill it,
and add it using add().

  • bindings/js/JSCryptoAlgorithmBuilder.h:
  • crypto/CryptoAlgorithmDescriptionBuilder.h:
  • bindings/js/JSCryptoAlgorithmBuilder.cpp:

(WebCore::JSCryptoAlgorithmBuilder::createEmptyClone):
(WebCore::JSCryptoAlgorithmBuilder::add): Keep VM in a local variable for marginally
better performance.

8:35 AM Changeset in webkit [158360] by Philippe Normand
  • 12 edits in trunk/Source

[WK2][GTK] enable-media-stream Setting
​https://bugs.webkit.org/show_bug.cgi?id=123145

Reviewed by Anders Carlsson.

Source/WebCore:

  • page/Settings.in: new mediaStreamEnabled setting.

Source/WebKit2:

  • Shared/WebPreferencesStore.h: New MediaStreamEnabled boolean preference.
  • UIProcess/API/C/WKPreferences.cpp: MediaStreamEnabled getter and

setter functions.
(WKPreferencesSetMediaStreamEnabled):
(WKPreferencesGetMediaStreamEnabled):

  • UIProcess/API/C/WKPreferences.h:
  • UIProcess/API/gtk/WebKitSettings.cpp: Add a enable-media-stream

property to the GTK WebKitSettings class. It will act as a facade
to the MediaStreamEnabled preference.
(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_enable_media_stream):
(webkit_settings_set_enable_media_stream):

  • UIProcess/API/gtk/WebKitSettings.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Test enable-media-stream websetting.

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
Allow WKTR to override the MediaStreamEnabled preference.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Update MediaStreamEnabled
along with the other settings.

8:29 AM Changeset in webkit [158359] by zandobersek@gmail.com
  • 10 edits in trunk/Source/WebCore

Manage SVGPathByteStream through std::unique_ptr
​https://bugs.webkit.org/show_bug.cgi?id=123467

Reviewed by Anders Carlsson.

Manage SVGPathByteStream objects through std::unique_ptr. Constructors for the class are made public
so std::make_unique can be used with the class.

  • svg/SVGAnimatedPath.cpp:

(WebCore::SVGAnimatedPathAnimator::constructFromString):
(WebCore::SVGAnimatedPathAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedPathAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::createPath):

  • svg/SVGAnimatedType.h:
  • svg/SVGPathByteStream.h:

(WebCore::SVGPathByteStream::SVGPathByteStream): Takes a const Data object that's then copied.
(WebCore::SVGPathByteStream::copy): Made const.

  • svg/SVGPathByteStreamBuilder.cpp: Remove an unnecessary include.
  • svg/SVGPathByteStreamBuilder.h: Ditto.
  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::SVGPathElement):

  • svg/SVGPathElement.h:
  • svg/SVGPathUtilities.cpp:

(WebCore::appendSVGPathByteStreamFromSVGPathSeg):
(WebCore::addToSVGPathByteStream):

8:29 AM Changeset in webkit [158358] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL] Rebaselining after r158186
​https://bugs.webkit.org/show_bug.cgi?id=123571

Unreviewed gardening.

Patch by Krzysztof Wolanski <​k.wolanski@samsung.com> on 2013-10-31

  • platform/efl/editing/deleting/smart-delete-003-expected.txt: Rebaselining after r158186.
  • platform/efl/editing/deleting/smart-delete-004-expected.txt: Rebaselining after r158186.
  • platform/efl/editing/selection/after-line-wrap-expected.txt: Rebaselining after r157851.
7:07 AM Changeset in webkit [158357] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Removing m_maxDeadCapacity condition in fast path in MemoryCache::prune().
​https://bugs.webkit.org/show_bug.cgi?id=115631

Patch by Marcin Bychawski <​m.bychawski@samsung.com> on 2013-10-31
Reviewed by Brent Fulgham.

If the m_maxDeadSize and m_deadSize are both 0, the method unnecessairly tries to prune resources.

No new tests, covered by existing ones.

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::prune):

5:02 AM Changeset in webkit [158356] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Web Inspector: Remove stale optional native memory instrumentation protocol params
​https://bugs.webkit.org/show_bug.cgi?id=123552

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-31
Reviewed by Timothy Hatcher.

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::start):

  • inspector/InspectorTimelineAgent.h:

Source/WebInspectorUI:

  • UserInterface/InspectorBackendCommands.js:
2:14 AM Changeset in webkit [158355] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

[GTK] Undefined references to RenderObject::style() when disabling video support
​https://bugs.webkit.org/show_bug.cgi?id=123492

Reviewed by Carlos Garcia Campos.

  • platform/gtk/RenderThemeGtk2.cpp: Disabling video support removes indirect inclusion of the RenderElement.h

header, causing undefined references to RenderObject::style(). The RenderElement.h header should be included
instead of RenderObject.h as the former defines the RenderObject::style() inline and also includes the latter.

  • platform/gtk/RenderThemeGtk3.cpp: Ditto.
1:55 AM Changeset in webkit [158354] by g.czajkowski@samsung.com
  • 1 edit
    4 adds in trunk/LayoutTests

[EFL] Add baselines for spelling tests added in r157900.

Unreviewed gardening.

  • platform/efl/editing/spelling/centering-misspelling-dots-expected.png: Added.
  • platform/efl/editing/spelling/centering-misspelling-dots-expected.txt: Added.
  • platform/efl/editing/spelling/misspelling-dots-dont-extend-beyond-words-expected.png: Added.
  • platform/efl/editing/spelling/misspelling-dots-dont-extend-beyond-words-expected.txt: Added.
1:44 AM Changeset in webkit [158353] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening. Add 5 printing tests to EFL TestExpectations.
EFL port doesn't fully support printing functionality yet.

  • platform/efl/TestExpectations:
1:38 AM Changeset in webkit [158352] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL] accessibility/textbox-role-reports-selection.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=112017

Patch by Robert Plociennik <​r.plociennik@samsung.com> on 2013-10-31
Reviewed by Mario Sanchez Prada.

Source/WebCore:

getSelectionOffsetsForObject() now returns proper start/end offsets for
selections "touching" the object's front border.

No new tests, covered by existing ones.

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(getSelectionOffsetsForObject):

LayoutTests:

Removed failure expectations.

  • platform/efl-wk1/TestExpectations: The test is no longer failing.
  • platform/efl-wk2/TestExpectations: The test is no longer failing.
12:11 AM Changeset in webkit [158351] by ryuan.choi@samsung.com
  • 8 edits in trunk

.: [EFL][GLES] OpenGL should be an optional
​https://bugs.webkit.org/show_bug.cgi?id=123399

Reviewed by Noam Rosenthal.

  • Source/cmake/OptionsEfl.cmake:

Refactor the check routine of GL dependencies to use OpenGL as optional.

Source/WebCore: [EFL][GLES] OpenGL should be optional
​https://bugs.webkit.org/show_bug.cgi?id=123399

Reviewed by Noam Rosenthal.

  • CMakeLists.txt: Make OpenGL dependencies as optional.
  • PlatformEfl.cmake:

Move OpenGL macro to OptionsEfl.cmake and make Xcomposite and XRender as optional.

  • platform/graphics/OpenGLESShims.h:

Removed GL_COLOR_ATTACHMENT0_EXT because it was added to gl2ext.h since r153064

  • platform/graphics/surfaces/GraphicsSurfaceToken.h:

Removed wrong GLX guard.
(WebCore::GraphicsSurfaceToken::GraphicsSurfaceToken):
(WebCore::GraphicsSurfaceToken::operator!=):
(WebCore::GraphicsSurfaceToken::isValid):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

Removed unnecessary OpenGLShims.h

Oct 30, 2013:

11:41 PM Changeset in webkit [158350] by commit-queue@webkit.org
  • 30 edits in trunk/Source/WebCore

[webcore/editing] remove extra header includes from cpp files.
​https://bugs.webkit.org/show_bug.cgi?id=123524

Patch by Santosh Mahto <​santosh.ma@samsung.com> on 2013-10-30
Reviewed by Ryosuke Niwa.

Removing redundant header files.

  • editing/AlternativeTextController.cpp:
  • editing/ApplyBlockElementCommand.cpp:
  • editing/ApplyStyleCommand.cpp:
  • editing/BreakBlockquoteCommand.cpp:
  • editing/DeleteButton.cpp:
  • editing/DeleteButtonController.cpp:
  • editing/DeleteSelectionCommand.cpp:
  • editing/DictationCommand.cpp:
  • editing/EditCommand.cpp:
  • editing/EditingStyle.cpp:
  • editing/EditorCommand.cpp:
  • editing/FrameSelection.cpp:
  • editing/IndentOutdentCommand.cpp:
  • editing/InsertLineBreakCommand.cpp:
  • editing/InsertParagraphSeparatorCommand.cpp:
  • editing/MarkupAccumulator.h:
  • editing/RemoveFormatCommand.cpp:
  • editing/RenderedPosition.cpp:
  • editing/ReplaceSelectionCommand.cpp:
  • editing/SpellChecker.cpp:
  • editing/SpellingCorrectionCommand.cpp:
  • editing/SurroundingText.cpp:
  • editing/TextCheckingHelper.cpp:
  • editing/TextIterator.cpp:
  • editing/TypingCommand.cpp:
  • editing/VisibleSelection.cpp:
  • editing/VisibleUnits.cpp:
  • editing/WrapContentsInDummySpanCommand.cpp:
  • editing/htmlediting.cpp:
11:32 PM Changeset in webkit [158349] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Unreviewed, rolling out r158299.
​http://trac.webkit.org/changeset/158299
​https://bugs.webkit.org/show_bug.cgi?id=123558

caused assertion failures in fast/canvas/canvas-color-
serialization.html and fast/forms/input-text-paste-
maxlength.html (Requested by rniwa on #webkit).

  • wtf/text/StringStatics.cpp:

(WTF::StringImpl::empty):

11:27 PM Changeset in webkit [158348] by beidson@apple.com
  • 16 edits in trunk/Source

IDB Database versions are uint64_t, not int64_t
​https://bugs.webkit.org/show_bug.cgi?id=123556

Reviewed by Alexey Proskuryakov.

Source/WebCore:

  • Modules/indexeddb/IDBBackingStoreInterface.h:
  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::openConnection):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:
  • Modules/indexeddb/IDBFactoryBackendInterface.h:
  • Modules/indexeddb/IDBPendingOpenCall.h:

(WebCore::IDBPendingOpenCall::create):
(WebCore::IDBPendingOpenCall::version):
(WebCore::IDBPendingOpenCall::IDBPendingOpenCall):

  • Modules/indexeddb/IDBTransactionBackendOperations.cpp:

(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::perform):

  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:

(WebCore::IDBBackingStoreLevelDB::updateIDBDatabaseVersion):

  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:

(WebCore::IDBFactoryBackendLevelDB::open):

  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:

Source/WebKit2:

  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:

(WebKit::WebIDBFactoryBackend::open):

  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
  • WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.cpp:

(WebKit::WebProcessIDBDatabaseBackend::openConnection):

  • WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.h:
11:25 PM Changeset in webkit [158347] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Gtk] Build is failing after r158317
​https://bugs.webkit.org/show_bug.cgi?id=123544

Patch by Brendan Long <​b.long@cablelabs.com> on 2013-10-30
Reviewed by Alexey Proskuryakov.

No new tests since this just fixes the build.

  • GNUmakefile.list.am: Add JSCryptoKey.cpp and JSCryptoKey.h
10:51 PM Changeset in webkit [158346] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Manage EllipsisBox objects with unique_ptr.
<​https://webkit.org/b/123554>

Use smart pointers to store ellipsis boxes instead of new/delete.

Reviewed by Anders Carlsson.

10:37 PM Changeset in webkit [158345] by ap@apple.com
  • 2 edits
    2 adds in trunk/Source/WebCore

[Gtk] Build is failing after r158317
​https://bugs.webkit.org/show_bug.cgi?id=123544

Use a correct style for JSC includes.

  • ForwardingHeaders/runtime/JSPromise.h: Added.
  • ForwardingHeaders/runtime/JSPromiseResolver.h: Added.
  • bindings/js/JSDOMPromise.h:
10:02 PM Changeset in webkit [158344] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add two crash expectations per bug 123555.

9:15 PM Changeset in webkit [158343] by akling@apple.com
  • 15 edits in trunk/Source/WebCore

Replace InlineBox::destroy() with regular virtual destruction.
<​https://webkit.org/b/123550>

Move logic out of destroy() and its overloads into good ol' virtual
destructors instead.

Reviewed by Anders Carlsson.

9:11 PM Changeset in webkit [158342] by ap@apple.com
  • 3 edits in trunk/Tools

Teach the style checker about ENUM_CLASS
​https://bugs.webkit.org/show_bug.cgi?id=123528

Reviewed by Andy Estes.

  • Scripts/webkitpy/style/checkers/cpp.py:

(_EnumState.process_clean_line): Make content of an ENUM_CLASS declaration
equivalent to enum content for checking.
(check_braces): Allow semicolon at the end.

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(NoNonVirtualDestructorsTest.test_enum_casing):
(NoNonVirtualDestructorsTest.test_enum_trailing_semicolon):
(WebKitStyleTest.test_braces):
Test it.

8:52 PM Changeset in webkit [158341] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Assertion failure in js/dom/global-constructors-attributes-dedicated-worker.html
​https://bugs.webkit.org/show_bug.cgi?id=123551
<rdar://problem/15356238>

Reviewed by Mark Hahnenberg.

WatchpointSets have always had this "fire everything on deletion" policy because it
seemed like a good fail-safe at the time I first implemented WatchpointSets. But
it's actually causing bugs rather than providing safety:

  • Everyone who registers Watchpoints with WatchpointSets have separate mechanisms for either keeping the WatchpointSets alive or noticing when they are collected. So this wasn't actually providing any safety.


One example of this is Structures, where:


  • CodeBlocks that register Watchpoints on Structure's WatchpointSet will also register weak references to the Structure, and the GC will jettison a CodeBlock if the Structure(s) it cares about dies.


  • StructureStubInfos that register Watchpoints on Structure's WatchpointSet will also be cleared by GC if the Structures die.


  • The WatchpointSet destructor would get invoked from finalization/destruction. This would then cause CodeBlock::jettison() to be called on a CodeBlock, but that method requires doing things that access heap objects. This would usually cause problems on VM destruction, since then the CodeBlocks would still be alive but the whole heap would be destroyed.


This also ensures that CodeBlock::jettison() cannot cause a GC. This is safe since
that method doesn't really allocate objects, and it is likely necessary because
jettison() may be called from deep in the stack.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::jettison):

  • bytecode/Watchpoint.cpp:

(JSC::WatchpointSet::~WatchpointSet):

  • bytecode/Watchpoint.h:
8:37 PM Changeset in webkit [158340] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Fixed a potential race condition around the initializtion of WKObject’s target.

Reviewed by Mark Rowe.

  • Shared/Cocoa/WKObject.mm:

(initializeTargetIfNeeded): Removed the early return if _target is non-nil. As Mark pointed
out, when stores are reordered relative to other stores, it is possible for the early return
to occur while the object _target is pointing to is not yet valid.

8:07 PM Changeset in webkit [158339] by rniwa@webkit.org
  • 2 edits in trunk/Tools

kill-old-processes should kill Web Socket script
​https://bugs.webkit.org/show_bug.cgi?id=123546

Reviewed by Benjamin Poulain.

  • BuildSlaveSupport/kill-old-processes:

(main):

7:36 PM Changeset in webkit [158338] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION(r158333): http/tests/xmlhttprequest/response-encoding.html and
xmlhttprequest-overridemimetype-content-type-header.html are failing
​https://bugs.webkit.org/show_bug.cgi?id=123548

Add the failing test expectation.

6:15 PM Changeset in webkit [158337] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Simplifying MediaStream and MediStreamDescriptor creation
​https://bugs.webkit.org/show_bug.cgi?id=123443

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-10-30
Reviewed by Eric Carlson.

The internal process of creating a MediaStream and MediaStreamDescriptor was quite confusing and spread.
We can take advantage of the platform implementation of MediaStreamTrack (aka MediaStreamTrackPrivate)
and simplify the whole process.
A new constructor that receives vectors of MediaStreamTrackPrivate objects were added, then the check
if a source already exists or if the tracks are all ended are now made in MediaStreamDescriptor.

No new tests needed.

  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::create): Removed unnecessary variables in one create method and using new
MediaStreamDescriptor::create method that receives vector of MediaStreamTrackPrivate objects as parameter.

  • Modules/webaudio/MediaStreamAudioDestinationNode.cpp:

(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode): Removed passing flag to
MediaStreamDescriptor create.

  • platform/mediastream/MediaStreamDescriptor.cpp:

(WebCore::MediaStreamDescriptor::create): Removed EndedAtCreationFlag parameter, because this is being
handled inside constructor by analyzing the tracks or sources passed.
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor): Adding new constructor that receives vector of
MediaStreamTrackPrivate as parameter.

(WebCore::MediaStreamDescriptor::addTrack): Changed to store the track's source in the object.

(WebCore::MediaStreamDescriptor::removeTrack):

  • platform/mediastream/MediaStreamDescriptor.h:

(WebCore::MediaStreamDescriptor::numberOfAudioTracks):
(WebCore::MediaStreamDescriptor::audioTracks):
(WebCore::MediaStreamDescriptor::numberOfVideoTracks):
(WebCore::MediaStreamDescriptor::videoTracks):

  • platform/mock/MockMediaStreamCenter.cpp:

(WebCore::MockMediaStreamCenter::createMediaStream): Removing flag that is being passed to
MediaStreamDescriptor's create method.

6:07 PM Changeset in webkit [158336] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

6:04 PM Changeset in webkit [158335] by Lucas Forschler
  • 1 copy in tags/Safari-538.4

New Tag.

5:50 PM Changeset in webkit [158334] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Win] Legible Output callbacks should happen on notification queue
​https://bugs.webkit.org/show_bug.cgi?id=123545

Reviewed by Eric Carlson.

Modify the callback creation for Legible Output items so that they
are made on our notification queue. The use of the main queue was a
holdover from some temporary code used during earlier development.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::AVFWrapper::AVFWrapper): Assert this happens on the main thread.
(WebCore::AVFWrapper::~AVFWrapper): Ditto.
(WebCore::destroyAVFWrapper): Ditto.
(WebCore::AVFWrapper::createPlayer): Ditto.
(WebCore::AVFWrapper::createPlayerItem): Ditto.
Also, instruct LegibleOutput callbacks to happen on our notification
queue, rather than the main thread.
(WebCore::AVFWrapper::createAVCFVideoLayer): Assert this happens on the main thread.
(WebCore::AVFWrapper::destroyVideoLayer): Ditto.
(WebCore::AVFWrapper::createImageGenerator): Ditto.
(WebCore::AVFWrapper::destroyImageGenerator): Ditto.

5:32 PM Changeset in webkit [158333] by ap@apple.com
  • 3 edits
    2 adds in trunk

XHR.response is null when requesting empty file as arraybuffer
​https://bugs.webkit.org/show_bug.cgi?id=123457

Source/WebCore:

Reviewed by Sam Weinig.

Test: http/tests/xmlhttprequest/response-empty-arraybuffer.html

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseArrayBuffer): Don't do this.

LayoutTests:

Based on a Blink test by ​yusukesuzuki@chromium.org.

Reviewed by Sam Weinig.

Failures in expected results appear to mean that Blink caches XHR responses in more
cases. It's not directly related to the patch.

  • http/tests/xmlhttprequest/response-empty-arraybuffer-expected.txt: Added.
  • http/tests/xmlhttprequest/response-empty-arraybuffer.html: Added.
5:31 PM Changeset in webkit [158332] by Samuel White
  • 3 edits
    2 adds in trunk

AX: AXFocused not exposed on ARIA menuitems
​https://bugs.webkit.org/show_bug.cgi?id=123494

Reviewed by Chris Fleizach.

Source/WebCore:

ARIA menuitems should expose AXFocused accessibility attribute.

Test: platform/mac/accessibility/aria-menuitem-focus.html

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):

LayoutTests:

Adding test to make sure ARIA menuitems expose each piece of their focus state correctly.

  • platform/mac/accessibility/aria-menuitem-focus-expected.txt: Added.
  • platform/mac/accessibility/aria-menuitem-focus.html: Added.
5:26 PM Changeset in webkit [158331] by commit-queue@webkit.org
  • 32 edits in trunk/Source/WebCore

Web Inspector: Remove basic uses of InspectorState from agents
​https://bugs.webkit.org/show_bug.cgi?id=123534

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-30
Reviewed by Timothy Hatcher.

  • inspector/InspectorAgent.h:
  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::enable):
(WebCore::InspectorAgent::disable):
(WebCore::InspectorAgent::evaluateForTestInFrontend):
(WebCore::InspectorAgent::inspect):
InspectorAgentState::inspectorAgentEnabled -> m_enabled.

  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::enable):
Remove unused state.

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::enable):
(WebCore::InspectorCSSAgent::disable):
(WebCore::InspectorCSSAgent::startSelectorProfiler):
(WebCore::InspectorCSSAgent::stopSelectorProfilerImpl):
Remove unused states. Make CSSAgentState::isSelectorProfiling check profile object exists or not.

  • inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::enable):
(WebCore::InspectorCanvasAgent::disable):
Remove unused state, member variable already existed.

  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::enable):
(WebCore::InspectorConsoleAgent::disable):
(WebCore::InspectorConsoleAgent::didFinishXHRLoading):
(WebCore::InspectorConsoleAgent::setMonitoringXHREnabled):
ConsoleAgentState::consoleMessagesEnabled already had m_enabled.
ConsoleAgentState::monitoringXHR -> m_monitoringXHREnabled.

  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::clearFrontend):
(WebCore::InspectorDOMAgent::setDocument):
(WebCore::InspectorDOMAgent::getDocument):
(WebCore::InspectorDOMAgent::mainFrameDOMContentLoaded):
DOMAgentState::documentRequested -> m_documentRequested.

  • inspector/InspectorDOMDebuggerAgent.h:
  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
(WebCore::InspectorDOMDebuggerAgent::setXHRBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeXHRBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
DOMDebuggerAgentState::pauseOnAllXHRs -> m_pauseOnAllXHRsEnabled.

  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::enable):
(WebCore::InspectorDOMStorageAgent::disable):
(WebCore::InspectorDOMStorageAgent::didDispatchDOMStorageEvent):
DOMStorageAgentState::domStorageAgentEnabled -> m_enabled.

  • inspector/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::enable):
(WebCore::InspectorDatabaseAgent::disable):
Remove unused state, m_enabled already existed.

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::enable):
(WebCore::InspectorDebuggerAgent::disable):
(WebCore::InspectorDebuggerAgent::enabled):
(WebCore::InspectorDebuggerAgent::clearFrontend):
(WebCore::InspectorDebuggerAgent::setPauseOnExceptionsImpl):
DebuggerAgentState::pauseOnExceptionsState removed, never read.
DebuggerAgentState::debuggerEnabled -> m_enabled.

  • inspector/InspectorHeapProfilerAgent.h:
  • inspector/InspectorHeapProfilerAgent.cpp:

(WebCore::InspectorHeapProfilerAgent::InspectorHeapProfilerAgent):
(WebCore::InspectorHeapProfilerAgent::resetFrontendProfiles):
(WebCore::InspectorHeapProfilerAgent::clearFrontend):
(WebCore::InspectorHeapProfilerAgent::getProfileHeaders):
HeapProfilerAgentState::profileHeadersRequested -> m_profileHeadersRequested.

  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore::InspectorIndexedDBAgent::enable):
(WebCore::InspectorIndexedDBAgent::disable):
Remove unused state, never read.

  • inspector/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::enable):
(WebCore::InspectorLayerTreeAgent::disable):
Remove unused state, did not need to be read.

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::webViewResized):
(WebCore::InspectorPageAgent::enable):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::setDeviceMetricsOverride):
(WebCore::InspectorPageAgent::deviceMetricsChanged):
(WebCore::InspectorPageAgent::setShowPaintRects):
(WebCore::InspectorPageAgent::setShowDebugBorders):
(WebCore::InspectorPageAgent::setShowFPSCounter):
(WebCore::InspectorPageAgent::setContinuousPaintingEnabled):
(WebCore::InspectorPageAgent::setScriptExecutionDisabled):
(WebCore::InspectorPageAgent::applyScreenWidthOverride):
(WebCore::InspectorPageAgent::applyScreenHeightOverride):
(WebCore::InspectorPageAgent::didPaint):
(WebCore::InspectorPageAgent::didLayout):
(WebCore::InspectorPageAgent::updateTouchEventEmulationInPage):
(WebCore::InspectorPageAgent::setTouchEmulationEnabled):
(WebCore::InspectorPageAgent::setEmulatedMedia):
(WebCore::InspectorPageAgent::applyEmulatedMedia):
PageAgentState::pageAgentScreenWidthOverride -> m_screenWidthOverride.
PageAgentState::pageAgentScreenHeightOverride -> m_screenHeightOverride.
PageAgentState::pageAgentFontScaleFactorOverride -> m_fontScaleFactorOverride.
PageAgentState::pageAgentFitWindow -> m_fitWindowOverride.
PageAgentState::pageAgentShowPaintRects -> m_showPaintRects.
PageAgentState::pageAgentEmulatedMedia -> m_emulatedMedia.
Remove other unused states.

  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::addProfile):
(WebCore::InspectorProfilerAgent::enable):
(WebCore::InspectorProfilerAgent::disable):
(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore::InspectorProfilerAgent::resetFrontendProfiles):
(WebCore::InspectorProfilerAgent::start):
(WebCore::InspectorProfilerAgent::stop):
(WebCore::InspectorProfilerAgent::enabled):
ProfilerAgentState::profileHeadersRequested -> m_profileHeadersRequested.
Remove other unused states.

  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::~InspectorResourceAgent):
(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::applyUserAgentOverride):
(WebCore::InspectorResourceAgent::enable):
(WebCore::InspectorResourceAgent::disable):
(WebCore::InspectorResourceAgent::setUserAgentOverride):
(WebCore::InspectorResourceAgent::setCacheDisabled):
(WebCore::InspectorResourceAgent::mainFrameNavigated):
(WebCore::InspectorResourceAgent::InspectorResourceAgent):
ResourceAgentState::resourceAgentEnabled -> m_enabled.
ResourceAgentState::cacheDisabled -> m_cacheDisabled.
ResourceAgentState::userAgentOverride -> m_userAgentOverride (this already existed and was unused).

  • inspector/InspectorTimelineAgent.h:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::stop):
(WebCore::InspectorTimelineAgent::setDOMCounters):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
TimelineAgentState::timelineAgentEnabled -> m_enabled.
TimelineAgentState::includeDomCounters -> m_includeDOMCounters.
Remove other unused states.

  • inspector/InspectorWorkerAgent.h:
  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::clearFrontend):
(WebCore::InspectorWorkerAgent::enable):
(WebCore::InspectorWorkerAgent::disable):
(WebCore::InspectorWorkerAgent::setAutoconnectToWorkers):
(WebCore::InspectorWorkerAgent::shouldPauseDedicatedWorkerOnStart):
(WebCore::InspectorWorkerAgent::didStartWorkerGlobalScope):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannel):
WorkerAgentState::workerInspectionEnabled -> m_enabled.
WorkerAgentState::autoconnectToWorkers -> m_shouldPauseDedicatedWorkerOnStart.

  • inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::enable):
(WebCore::PageRuntimeAgent::disable):
Remove unused state, not read.

5:14 PM Changeset in webkit [158330] by rniwa@webkit.org
  • 24 edits in trunk/Source

Remove code for Mac Lion
​https://bugs.webkit.org/show_bug.cgi?id=123542

Reviewed by Anders Carlsson.

Source/WebCore:

Removed the code for Mac OS X 10.7.

  • platform/graphics/ImageBuffer.h:
  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::context):
(WebCore::ImageBuffer::flushContext):

  • platform/graphics/cg/ImageBufferDataCG.h:
  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::imageSourceOptions):

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::scrollAnimationEnabledForSystem):

  • platform/mac/ScrollElasticityController.mm:

(WebCore::reboundDeltaForElasticDelta):

  • platform/mac/ThemeMac.mm:

(WebCore::updateStates):
(WebCore::paintCheckbox):
(WebCore::paintRadio):
(WebCore::paintButton):

  • platform/mac/WebCoreNSCellExtras.h:
  • platform/mac/WebCoreNSCellExtras.m:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintTextField):
(WebCore::RenderThemeMac::paintMenuList):
(WebCore::RenderThemeMac::setPopupButtonCellState):
(WebCore::RenderThemeMac::textField):

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

(-[WebHTMLView attachRootLayer:]):

  • WebView/WebView.mm:

Source/WebKit2:

  • NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
  • UIProcess/API/mac/WKView.mm:

(-[WKView viewWillMoveToWindow:]):

  • WebProcess/com.apple.WebProcess.sb.in:

Source/WTF:

  • wtf/Platform.h:
4:59 PM Changeset in webkit [158329] by ap@apple.com
  • 5 edits in trunk/Tools

Set svn:ignore for .pyc files created for test-webkitpy.

  • Scripts/webkitpy/layout_tests/reftests: Added property svn:ignore.
  • Scripts/webkitpy/performance_tests: Added property svn:ignore.
  • Scripts/webkitpy/to_be_moved: Added property svn:ignore.
  • Scripts/webkitpy/w3c: Added property svn:ignore.
4:50 PM Changeset in webkit [158328] by rniwa@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

Delete the expected results for Lion.

Rubber-stamped by Anders Carlsson.

  • platform/mac-lion: Removed.
4:48 PM Changeset in webkit [158327] by aestes@apple.com
  • 5 edits
    63 adds in trunk/Source/WebKit

[iOS] Upstream Source/WebKit/ios/
​https://bugs.webkit.org/show_bug.cgi?id=123470

Reviewed by Sam Weinig.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/ios:

  • DefaultDelegates/WebDefaultFormDelegate.h: Added.
  • DefaultDelegates/WebDefaultFormDelegate.m: Added.
  • DefaultDelegates/WebDefaultFrameLoadDelegate.h: Added.
  • DefaultDelegates/WebDefaultFrameLoadDelegate.m: Added.
  • DefaultDelegates/WebDefaultResourceLoadDelegate.h: Added.
  • DefaultDelegates/WebDefaultResourceLoadDelegate.m: Added.
  • DefaultDelegates/WebDefaultUIKitDelegate.h: Added.
  • DefaultDelegates/WebDefaultUIKitDelegate.m: Added.
  • Misc/EmojiFallbackFontSelector.cpp: Added.
  • Misc/EmojiFallbackFontSelector.h: Added.
  • Misc/MemoryMeasure.h: Added.
  • Misc/MemoryMeasure.mm: Added.
  • Misc/WebGeolocationCoreLocationProvider.h: Added.
  • Misc/WebGeolocationCoreLocationProvider.mm: Added.
  • Misc/WebGeolocationProviderIOS.h: Added.
  • Misc/WebGeolocationProviderIOS.mm: Added.
  • Misc/WebNSStringDrawing.h: Added.
  • Misc/WebNSStringDrawing.mm: Added.
  • Misc/WebNSStringExtrasIOS.h: Added.
  • Misc/WebNSStringExtrasIOS.m: Added.
  • Misc/WebNSStringExtrasIPhone.h: Added.
  • Misc/WebUIKitSupport.h: Added.
  • Misc/WebUIKitSupport.mm: Added.
  • Storage/WebSQLiteDatabaseTrackerClient.h: Added.
  • Storage/WebSQLiteDatabaseTrackerClient.mm: Added.
  • WebCoreSupport/PopupMenuIOS.h: Added.
  • WebCoreSupport/PopupMenuIOS.mm: Added.
  • WebCoreSupport/SearchPopupMenuIOS.cpp: Added.
  • WebCoreSupport/SearchPopupMenuIOS.h: Added.
  • WebCoreSupport/WebCaretChangeListener.h: Added.
  • WebCoreSupport/WebChromeClientIOS.h: Added.
  • WebCoreSupport/WebChromeClientIOS.mm: Added.
  • WebCoreSupport/WebFixedPositionContent.h: Added.
  • WebCoreSupport/WebFixedPositionContent.mm: Added.
  • WebCoreSupport/WebFixedPositionContentInternal.h: Added.
  • WebCoreSupport/WebFrameIOS.h: Added.
  • WebCoreSupport/WebFrameIOS.mm: Added.
  • WebCoreSupport/WebFrameIPhone.h: Added.
  • WebCoreSupport/WebGeolocation.mm: Added.
  • WebCoreSupport/WebGeolocationInternal.h: Added.
  • WebCoreSupport/WebGeolocationPrivate.h: Added.
  • WebCoreSupport/WebMIMETypeRegistry.h: Added.
  • WebCoreSupport/WebMIMETypeRegistry.mm: Added.
  • WebCoreSupport/WebSelectionRect.h: Added.
  • WebCoreSupport/WebSelectionRect.m: Added.
  • WebCoreSupport/WebVisiblePosition.h: Added.
  • WebCoreSupport/WebVisiblePosition.mm: Added.
  • WebCoreSupport/WebVisiblePositionInternal.h: Added.
  • WebKit.iOS.exp: Added.
  • WebView/WebFrameViewWAKCompatibility.m: Added.
  • WebView/WebMailDelegate.h: Added.
  • WebView/WebPDFViewIOS.h: Added.
  • WebView/WebPDFViewIOS.mm: Added.
  • WebView/WebPDFViewIPhone.h: Added.
  • WebView/WebPDFViewPlaceholder.h: Added.
  • WebView/WebPDFViewPlaceholder.mm: Added.
  • WebView/WebPlainWhiteView.h: Added.
  • WebView/WebPlainWhiteView.mm: Added.
  • WebView/WebUIKitDelegate.h: Added.

Source/WebKit/mac:

  • Configurations/WebKit.xcconfig: Excluded some iOS files from the Mac build.
4:43 PM Changeset in webkit [158326] by ap@apple.com
  • 7 edits in trunk

85 inspector tests asserting in DrawingAreaProxyImpl::updateAcceleratedCompositingMode()
when there is a stale WebKitTestRunner preference
​https://bugs.webkit.org/show_bug.cgi?id=115115

Reviewed by Darin Adler.

Source/WebCore:

  • page/Settings.cpp:

(WebCore::Settings::setMockScrollbarsEnabled):
(WebCore::Settings::setUsesOverlayScrollbars):
Added FIXMEs.

Tools:

Delete stale preferences on launch.

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize): Now that we don't have preferences stored from
the previous run, we need th reinstate them before creating a WKView. Not all preferences
can be applied to an existing view retroactively.
(WTR::TestController::resetPreferencesToConsistentValues): Split out of resetStateToConsistentValues,
because there is no injected bundle yet when calling this function from initialize().

  • WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting): Delete

the preferences.

  • WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):

Added some FIXMEs.

4:13 PM Changeset in webkit [158325] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix the !WK_API_ENABLED Mac build.

  • Shared/Cocoa/APIObject.mm:
3:49 PM Changeset in webkit [158324] by mitz@apple.com
  • 13 edits
    7 adds
    2 deletes in trunk/Source/WebKit2

[Cocoa] Make all API objects have Cocoa wrappers, and delegate refcounting to those wrappers
​https://bugs.webkit.org/show_bug.cgi?id=123394

Reviewed by Darin Adler.

All wrappers conform to a new WKObject protocol and contain the wrapped object inline.
APIObject-derived classes override operator new to call newObject, which allocates the
wrapper and returns a pointer to the inline API object.

There are three kinds of wrapper classes: (a) classes that inherit directly from NSObject
and implement their API by calling the wrapped object (example: WKBackForwardList),
(b) internal classes that inherit from a class cluster, and implement the primitive methods
of the class cluster by calling the wrapped object (example: WKNSArray), and (c) internal
classes that inerit from the new WKObject class, and proxy to an object of some public type,
which is created from the wrapped object (example: WKNSURL).

  • Shared/APIObject.h:

(WebKit::APIObject::wrapper): Added this getter.
(WebKit::TypedAPIObject::operator new): Added override that calls newObject.

  • Shared/Cocoa/APIObject.mm: Added.

(WebKit::APIObject::ref): Retains the wrapper.
(WebKit::APIObject::deref): Releases the wrapper. When the wrapper is deallocated, it calls
the API object destructor.
(WebKit::APIObject::newObject): Allocates the wrapper and returns a pointer to the API
object inside the wrapper.

  • Shared/Cocoa/WKNSArray.h:

(WebKit::wrapper): Added. Returns an ImmutableArray’s wrapper as an NSArray.
Replaced the RefPtr<ImmutableArray> ivar with space for an ImmutableArray to live inside
the wrapper.
(-[WKNSArray dealloc]): Calls the ImmutableArray destructor.
(-[WKNSArray count]): Updated for ivar change.
(-[WKNSArray objectAtIndex:]): Ditto.
(-[WKNSArray _apiObject]): Returns the wrapped ImmutableArray.

  • Shared/Cocoa/WKNSObjectExtras.h: Removed.
  • Shared/Cocoa/WKNSObjectExtras.mm: Removed.
  • Shared/Cocoa/WKNSString.h: Added.
  • Shared/Cocoa/WKNSString.mm: Added.

(-[WKNSString _web_createTarget]): Override this WKObject method to create an NSString from
the WebString.
(-[WKNSString copyWithZone:]): Retains self.

  • Shared/Cocoa/WKNSURL.h: Added.
  • Shared/Cocoa/WKNSURL.mm: Added.

(-[WKNSURL _web_createTarget]): Override this WKObject method to create an NSURL from
the WebURL.
(-[WKNSURL copyWithZone:]): Retains self.

  • Shared/Cocoa/WKObject.h: Added.
  • Shared/Cocoa/WKObject.mm: Added.

(-[WKObject dealloc]): Calls the destructor of the wrapped object and releases the target
object.
(initializeTargetIfNeeded): Helper function. Tries to create the target exactly once.
(-[WKObject isEqual:]): NSObject override that creates and compares to the target
object if necessary.
(-[WKObject hash]): NSObject override that creates and hashes the target object if
there is one.
(-[WKObject isKindOfClass:]): NSObject override that delegates to the target object.
(-[WKObject isMemberOfClass:]): Ditto.
(-[WKObject respondsToSelector:]): NSObject override that creates the target object if
necessary and returns whether it or self responds to the selector.
(-[WKObject conformsToProtocol:]): Similarly for protocols.
(-[WKObject forwardingTargetForSelector:]): NSObject override that creates the target object
if necessary and returns it as the target.
(-[WKObject description]): NSObject override that creates the target object if necessary and
forwards to it.
(-[WKObject _web_createTarget]): Added. The base implementation returns nil.
(-[WKObject _apiObject]): Returns the wrapped object.

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController backForwardList]): Changed to return the existing wrapper.
(didChangeBackForwardList): Changed to use existing wrappers.

Replaced the RefPtr<WebBackForwardList> ivar with space for a WebBackForwardList to live
inside the wrapper.
(-[WKBackForwardList dealloc]): Call the WebBackForwardList destructor.
(toWKBackForwardListItem): Changed to us the existing wrapper.
(-[WKBackForwardList currentItem]): Updated for ivar change.
(-[WKBackForwardList backItem]): Ditto.
(-[WKBackForwardList forwardItem]): Ditto.
(-[WKBackForwardList itemAtIndex:]): Ditto.
(-[WKBackForwardList backListCount]): Ditto.
(-[WKBackForwardList forwardListCount]): Ditto,
(-[WKBackForwardList backListWithLimit:]): Ditto, and also changed to use the
ImmutableArray’s existing wrapper.
(-[WKBackForwardList forwardListWithLimit:]): Ditto.
(-[WKBackForwardList _apiObject]): Returns the WebBackForwardListItem.

  • UIProcess/Cocoa/WKBackForwardListInternal.h:

(WebKit::wrapper): Added. Returns a WebBackForwardList’s wrapper as a WKBackForwardList.

  • UIProcess/Cocoa/WKBackForwardListItem.mm:

Replaced the RefPtr<WebBackForwardListItem> ivar with space for a WebBackForwardListItem to
live inside the wrapper.
(-[WKBackForwardListItem dealloc]): Call the WebBackForwardListItem destructor.
(-[WKBackForwardListItem URL]): Updated for ivar change, and changed to make an NSURL
directly instead of going through a wrapper.
(-[WKBackForwardListItem title]): Updated for ivar change, and changed to use
String’s operator NSString*.
(-[WKBackForwardListItem originalURL]): Updated for ivar change, and changed to make an
NSURL directly instead of going through a wrapper.
(-[WKBackForwardListItem _apiObject]): Returns the WebBackForwardListItem.
(-[WKBackForwardListItem _item]): Ditto.

  • UIProcess/Cocoa/WKBackForwardListItemInternal.h:

(WebKit::wrapper): Added. Returns a WebBackForwardListItem’s wrapper as a
WKBackForwardListItem.

  • UIProcess/WebColorPickerResultListenerProxy.h: Changed into a TypedAPIObject.
  • UIProcess/WebFormSubmissionListenerProxy.h:

(WebKit::WebFormSubmissionListenerProxy::operator new): Override to call newObject.

  • UIProcess/WebFramePolicyListenerProxy.h:

(WebKit::WebFramePolicyListenerProxy::operator new): Ditto.

  • WebKit2.xcodeproj/project.pbxproj: Updated for file additions and removals.
3:47 PM Changeset in webkit [158323] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, fix C Loop LLINT build.

  • bytecode/CodeBlockJettisoningWatchpoint.cpp:

(JSC::CodeBlockJettisoningWatchpoint::fireInternal):

  • bytecode/ProfiledCodeBlockJettisoningWatchpoint.cpp:

(JSC::ProfiledCodeBlockJettisoningWatchpoint::fireInternal):

3:34 PM Changeset in webkit [158322] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, fix FTL build.

  • ftl/FTLAbstractHeapRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):

3:27 PM Changeset in webkit [158321] by akling@apple.com
  • 24 edits in trunk/Source/WebCore

Take line boxes out of the arena.
<​https://webkit.org/b/123533>

Stop arena-allocating line boxes so we can move forward on improving
render tree memory management. This will also allow more rendering
code to take advantage of malloc optimizations.

This will likely regress performance on some micro-benchmarks, but
it's something we want to do sooner rather than later so we have time
to restabilize it. All improvements to the simple line layout's
coverage will help with recouping whatever is regressed.

BiDi runs are the only remaining user of the arena now.

Reviewed by Antti Koivisto

3:17 PM Changeset in webkit [158320] by commit-queue@webkit.org
  • 39 edits in trunk/Source/WebCore

Web Inspector: Remove InspectorAgent::restore functionality
​https://bugs.webkit.org/show_bug.cgi?id=123525

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-30
Reviewed by Timothy Hatcher.

Remove unused InspectorAgent restore functionality.

  • inspector/InspectorApplicationCacheAgent.cpp:
  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorBaseAgent.cpp:
  • inspector/InspectorBaseAgent.h:
  • inspector/InspectorCSSAgent.cpp:
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorCanvasAgent.cpp:
  • inspector/InspectorCanvasAgent.h:
  • inspector/InspectorConsoleAgent.cpp:
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorController.cpp:
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDatabaseAgent.cpp:
  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorDebuggerAgent.cpp:
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorHeapProfilerAgent.cpp:
  • inspector/InspectorHeapProfilerAgent.h:
  • inspector/InspectorIndexedDBAgent.cpp:
  • inspector/InspectorIndexedDBAgent.h:
  • inspector/InspectorLayerTreeAgent.cpp:
  • inspector/InspectorLayerTreeAgent.h:
  • inspector/InspectorPageAgent.cpp:
  • inspector/InspectorPageAgent.h:
  • inspector/InspectorProfilerAgent.cpp:
  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorResourceAgent.cpp:
  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorTimelineAgent.cpp:
  • inspector/InspectorTimelineAgent.h:
  • inspector/InspectorWorkerAgent.cpp:
  • inspector/InspectorWorkerAgent.h:
  • inspector/PageRuntimeAgent.cpp:
  • inspector/PageRuntimeAgent.h:
  • inspector/WorkerInspectorController.cpp:
  • inspector/WorkerInspectorController.h:
3:12 PM Changeset in webkit [158319] by andersca@apple.com
  • 3 edits in trunk/Tools

Try to fix the 32-bit build.

  • TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
  • TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
3:07 PM Changeset in webkit [158318] by jer.noble@apple.com
  • 4 edits in trunk

REGRESSION(r158288): media/media-can-play-mpeg4-video.html fails
​https://bugs.webkit.org/show_bug.cgi?id=123530

Reviewed by Eric Carlson.

Source/WebCore:

Lower case the mime type before passing it along to MediaPlayer.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::canPlayType):
(WebCore::HTMLMediaElement::selectNextSourceChild):

LayoutTests:

3:05 PM Changeset in webkit [158317] by ap@apple.com
  • 10 edits
    1 copy
    1 add in trunk/Source

Add a way to fulfill promises from DOM code
​https://bugs.webkit.org/show_bug.cgi?id=123466

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • JavaScriptCore.xcodeproj/project.pbxproj: Make JSPromise.h and JSPromiseResolver.h

private headers for WebCore to use.

  • runtime/JSPromise.h:
  • runtime/JSPromiseResolver.h:

Export functions that JSDOMPromise will use.

Source/WebCore:

This is not perfect, as it strongly ties DOM code to JavaScript. In the future, we
can make it better e.g. by subclassing, so that only a base interface would be exposed.

  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • bindings/js/JSBindingsAllInOne.cpp:
  • WebCore.xcodeproj/project.pbxproj:

Added JSDOMPromise.

  • bindings/js/JSDOMPromise.cpp: Added.
  • bindings/js/JSDOMPromise.h: Added.

(WebCore::PromiseWrapper::create):
(WebCore::PromiseWrapper::fulfill): A random set of specializations that I needed
in WebCrypto code so far.
(WebCore::PromiseWrapper::reject): Ditto.

2:51 PM Changeset in webkit [158316] by andersca@apple.com
  • 7 edits
    3 copies
    1 add in trunk

Begin fleshing out an API test for WKRemoteObjectRegistry
​https://bugs.webkit.org/show_bug.cgi?id=123531

Reviewed by Andreas Kling.

Source/WebKit2:

  • Shared/API/Cocoa/WKRemoteObjectInterface.h:

Add WK_API_CLASS annotation.

  • Shared/API/Cocoa/WKRemoteObjectRegistry.h:

Add WK_API_CLASS annotation.

  • Shared/API/Cocoa/WKRemoteObjectRegistry.mm:

Add a WebConnection ivar.

(-[WKRemoteObjectRegistry _initWithConnectionRef:]):
Add SPI to create an WKRemoteObjectRegistry object with an existing WKConnectionRef.

(-[WKRemoteObjectRegistry _handleMessageWithName:body:]):
Add SPI that will be used to process incoming messages from an existing WKConnectionRef.

  • Shared/API/Cocoa/WKRemoteObjectRegistryPrivate.h: Added.

Add SPI header.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

Tools:

Add a very simple test that doesn't really test anything for now.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm: Added.
  • TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm: Added.
  • TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h: Added.
2:26 PM Changeset in webkit [158315] by mark.lam@apple.com
  • 23 edits in trunk/Source/JavaScriptCore

Adjust CallFrameHeader's ReturnPC and CallFrame locations to match the native ABI .
​https://bugs.webkit.org/show_bug.cgi?id=123444.

Reviewed by Geoffrey Garen.

  • Introduced an explicit CallerFrameAndPC struct.
  • A CallFrame is expected to start with a CallerFrameAndPC struct.
  • The Register class no longer supports CallFrame* and Instruction*.

These hides the differences between JSVALUE32_64 and JSVALUE64 in
terms of managing the callerFrame() and returnPC() values.

  • Convert all uses of JSStack::CallerFrame and JSStack::ReturnPC to go through CallFrame to access the appropriate values and offsets. CallFrame, in turn, will access the callerFrame and returnPC via the CallerFrameAndPC struct.
  • InlineCallFrame will provide offsets for its callerFrame and returnPC. It will make use of CallFrame::callerFrameOffset() and CallerFrame::returnPCOffset() to compute these.
  • bytecode/CodeOrigin.h:

(JSC::InlineCallFrame::callerFrameOffset):
(JSC::InlineCallFrame::returnPCOffset):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileExceptionHandlers):

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::reifyInlinedCallFrames):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::calleeFrameSlot):
(JSC::DFG::SpeculativeJIT::calleeArgumentSlot):
(JSC::DFG::SpeculativeJIT::calleeFrameTagSlot):
(JSC::DFG::SpeculativeJIT::calleeFramePayloadSlot):
(JSC::DFG::SpeculativeJIT::calleeArgumentTagSlot):
(JSC::DFG::SpeculativeJIT::calleeArgumentPayloadSlot):

  • Prefixed all the above with callee since they apply to the callee frame.

(JSC::DFG::SpeculativeJIT::calleeFrameCallerFrame):

  • Added to set the callerFrame pointer in the callee frame.
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLLink.cpp:

(JSC::FTL::compileEntry):
(JSC::FTL::link):

  • interpreter/CallFrame.h:

(JSC::ExecState::callerFrame):
(JSC::ExecState::callerFrameOffset):
(JSC::ExecState::returnPC):
(JSC::ExecState::hasReturnPC):
(JSC::ExecState::clearReturnPC):
(JSC::ExecState::returnPCOffset):
(JSC::ExecState::setCallerFrame):
(JSC::ExecState::setReturnPC):
(JSC::ExecState::callerFrameAndPC):

  • interpreter/JSStack.h:
  • interpreter/Register.h:
  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::emitPutToCallFrameHeader):

  • Convert to using storePtr() here and simplify the code.

(JSC::AssemblyHelpers::emitGetCallerFrameFromCallFrameHeaderPtr):
(JSC::AssemblyHelpers::emitPutCallerFrameToCallFrameHeader):
(JSC::AssemblyHelpers::emitGetReturnPCFromCallFrameHeaderPtr):
(JSC::AssemblyHelpers::emitPutReturnPCToCallFrameHeader):

  • Helpers to emit gets/puts of the callerFrame and returnPC.

(JSC::AssemblyHelpers::addressForByteOffset):

  • jit/JIT.cpp:

(JSC::JIT::JIT):
(JSC::JIT::privateCompile):
(JSC::JIT::privateCompileExceptionHandlers):

  • jit/JITCall.cpp:

(JSC::JIT::compileCallEval):
(JSC::JIT::compileOpCall):

  • jit/JITCall32_64.cpp:

(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_ret_object_or_this):
(JSC::JIT::compileCallEval):
(JSC::JIT::compileOpCall):

  • jit/JITInlines.h:

(JSC::JIT::unmap):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_end):
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_ret_object_or_this):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_end):

  • jit/JITOperations.cpp:
  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::returnJSValue):
(JSC::SpecializedThunkJIT::returnDouble):
(JSC::SpecializedThunkJIT::returnInt32):
(JSC::SpecializedThunkJIT::returnJSCell):

  • jit/ThunkGenerators.cpp:

(JSC::throwExceptionFromCallSlowPathGenerator):
(JSC::slowPathFor):
(JSC::nativeForGenerator):

  • llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

  • llint/LowLevelInterpreter.asm:
  • Updated offsets and asserts to match the new CallFrame layout.
2:16 PM Changeset in webkit [158314] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

contentEditable deleting lists when list items are block level
​https://bugs.webkit.org/show_bug.cgi?id=122602

Patch by Santosh Mahto <​santosh.ma@samsung.com> on 2013-10-30
Reviewed by Ryosuke Niwa.

Source/WebCore:

When listitems are styled with display:block/float then inserting paragraph
twice at end of listitem delete entire list. Generally when listitem is empty
then we delete the listitem on inserting paragraph. In this issue, on inserting
first paragraph one empty listitem is created, and on inserting second paragraph
we try to delete that empty listitem. but it misbehave becasue of incomplete
definition of htmlediting::isLisItem() and entire list is deleted.

htmlediting::isListItem() check only render object to decide whether it is
list or not, so if any LI element is block level then isListItem return false.
Now after this patch if parent of current node is list element then node is
treated as listItem.

Test: editing/execCommand/hit-enter-twice-atendof-block-styled-listitem.html

  • editing/htmlediting.cpp:

(WebCore::isListItem): Modified condition to check if parent node is list;

LayoutTests:

Testcase: When listitem is styled with display:block then inserting
paragraph twice at the end of listitem should not remove entire list.

  • editing/execCommand/hit-enter-twice-atendof-block-styled-listitem-expected.txt: Added.
  • editing/execCommand/hit-enter-twice-atendof-block-styled-listitem.html: Added.

TestCase: When listitem is made of custom tag(<item>) and css(display:list-item)
then inserting paragraph twice at the end of listitem should not remove entire list.

  • editing/execCommand/hit-enter-twice-atendof-custom-listitem-expected.txt: Added.
  • editing/execCommand/hit-enter-twice-atendof-custom-listitem.html: Added.
1:59 PM Changeset in webkit [158313] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix Mac.

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::RegisterAllocationOffset::checkOffsets):
(JSC::AbstractMacroAssembler::checkRegisterAllocationAgainstBranchRange):

1:57 PM Changeset in webkit [158312] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Add a failing test expectation on media/media-can-play-mpeg4-video.html after r158288.
The failure is tracked by the bug 123530.

Also rebaseline Mountain Lion results.

  • TestExpectations:
  • platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt:
1:51 PM Changeset in webkit [158311] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebCore

Unreviewed. Update NEWS and Versions.m4 for 2.3.1 release.

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-10-29

  • Source/autotools/Versions.m4: Bump version numbers.
1:40 PM Changeset in webkit [158310] by akling@apple.com
  • 7 edits in trunk/Source

Let Page::renderTreeSize() be the number of renderers.
<​https://webkit.org/b/123518>
<rdar://problem/15348679>

The old metric was "number of bytes allocated in RenderArena" and
that was heading towards obsolescence, fast.

Instead, keep a count of RenderObjects instantiated on RenderView.
While a bit ugly, this lets us move forward with rendering memory
model improvements without breaking features.

Reviewed by Beth Dakin.

1:32 PM Changeset in webkit [158309] by commit-queue@webkit.org
  • 8 edits in trunk/Source

WebKit/win/WebKitGraphics.h:void WebDrawText(WebTextRenderInfo*); is never called
​https://bugs.webkit.org/show_bug.cgi?id=123485

Patch by Myles C. Maxfield <​mmaxfield@apple.com> on 2013-10-30
Reviewed by Brent Fulgham.

Source/WebCore:

WebDrawText is the only caller of WebCoreDrawTextAtPoint, so we can
delete that as well.

Because there is no behavior difference, no new tests are necessary.

  • platform/win/WebCoreTextRenderer.cpp:
  • platform/win/WebCoreTextRenderer.h:

Source/WebKit:

Deleting the function

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

Removed unused WebDrawText implementation.

  • WebKitGraphics.cpp:
  • WebKitGraphics.h:
1:22 PM Changeset in webkit [158308] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix Windows.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::jettison):

1:14 PM Changeset in webkit [158307] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix Windows.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::addFrequentExitSite):

1:13 PM Changeset in webkit [158306] by fpizlo@apple.com
  • 2 edits in trunk/Tools

Remove unnecessary touch

Rubber stamped by Mark Hahnenberg.

  • Scripts/run-jsc-stress-tests:
1:03 PM Changeset in webkit [158305] by Samuel White
  • 3 edits in trunk/Tools

AX: Add Samuel White to accessibility watchlist cc rules
​https://bugs.webkit.org/show_bug.cgi?id=123515

Reviewed by Chris Fleizach.

Adding myself and ​jcraig@apple.com (per his request) to the accessibility watchlist. Also
updating contributors.json with permission from ​bweinstein@apple.com to make this possible.

  • Scripts/webkitpy/common/config/contributors.json:
  • Scripts/webkitpy/common/config/watchlist:
12:58 PM Changeset in webkit [158304] by fpizlo@apple.com
  • 35 edits
    10 adds
    2 deletes in trunk/Source/JavaScriptCore

Add InvalidationPoints to the DFG and use them for all watchpoints
​https://bugs.webkit.org/show_bug.cgi?id=123472

Reviewed by Mark Hahnenberg.

This makes a fundamental change to how watchpoints work in the DFG.

Previously, a watchpoint was an instruction whose execution semantics were something
like:

if (watchpoint->invalidated)

exit


We would implement this without any branch by using jump replacement.

This is a very good optimization. But it's a bit awkward once you get a lot of
watchpoints: semantically we will have lots of these branches in the code, which the
compiler needs to reason about even though they don't actually result in any emitted
code.

Separately, we also had a mechanism for jettisoning a CodeBlock. This mechanism would
be invoked if a CodeBlock exited a lot. It would ensure that a CodeBlock wouldn't be
called into again, but it would do nothing for CodeBlocks that were already on the
stack.

This change flips jettisoning and watchpoint invalidation on their heads. Now, the jump
replacement has nothing to do with watchpoints; instead it's something that happens if
you ever jettison a CodeBlock. Jump replacement is now an all-or-nothing operation over
all of the potential call-return safe-exit-points in a CodeBlock. We call these
"InvalidationPoint"s. A watchpoint instruction is now "lowered" by having the DFG
collect all of the watchpoint sets that the CodeBlock cares about, and then registering
a CodeBlockJettisoningWatchpoint with all of them. That is, if the watchpoint fires, it
jettisons the CodeBlock, which in turn ensures that the CodeBlock can't be called into
(because the entrypoint now points to baseline code) and can't be returned into
(because returning exits to baseline before the next bytecode instruction).

This will allow for a sensible lowering of watchpoints to LLVM IR. It will also allow
for jettison() to be used effectively for things like breakpointing and single-stepping
in the debugger.

Well, basically, this mechanism just takes us into the HotSpot-style world where anyone
can, at any time and for any reason, request that an optimized CodeBlock is rendered
immediately invalid. You can use this for many cool things, I'm sure.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/AbstractMacroAssembler.h:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::jettison):

  • bytecode/CodeBlock.h:
  • bytecode/CodeBlockJettisoningWatchpoint.cpp: Added.

(JSC::CodeBlockJettisoningWatchpoint::fireInternal):

  • bytecode/CodeBlockJettisoningWatchpoint.h: Added.

(JSC::CodeBlockJettisoningWatchpoint::CodeBlockJettisoningWatchpoint):

  • bytecode/ExitKind.cpp:

(JSC::exitKindToString):

  • bytecode/ExitKind.h:
  • bytecode/ProfiledCodeBlockJettisoningWatchpoint.cpp: Added.

(JSC::ProfiledCodeBlockJettisoningWatchpoint::fireInternal):

  • bytecode/ProfiledCodeBlockJettisoningWatchpoint.h: Added.

(JSC::ProfiledCodeBlockJettisoningWatchpoint::ProfiledCodeBlockJettisoningWatchpoint):

  • dfg/DFGAbstractHeap.h:
  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

  • dfg/DFGClobberize.cpp:

(JSC::DFG::writesOverlap):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):
(JSC::DFG::AbstractHeapOverlaps::AbstractHeapOverlaps):
(JSC::DFG::AbstractHeapOverlaps::operator()):
(JSC::DFG::AbstractHeapOverlaps::result):

  • dfg/DFGCommonData.cpp:

(JSC::DFG::CommonData::invalidate):

  • dfg/DFGCommonData.h:

(JSC::DFG::CommonData::CommonData):

  • dfg/DFGDesiredWatchpoints.cpp:

(JSC::DFG::DesiredWatchpoints::addLazily):
(JSC::DFG::DesiredWatchpoints::reallyAdd):

  • dfg/DFGDesiredWatchpoints.h:

(JSC::DFG::WatchpointForGenericWatchpointSet::WatchpointForGenericWatchpointSet):
(JSC::DFG::GenericDesiredWatchpoints::addLazily):
(JSC::DFG::GenericDesiredWatchpoints::reallyAdd):
(JSC::DFG::GenericDesiredWatchpoints::areStillValid):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGInvalidationPointInjectionPhase.cpp: Added.

(JSC::DFG::InvalidationPointInjectionPhase::InvalidationPointInjectionPhase):
(JSC::DFG::InvalidationPointInjectionPhase::run):
(JSC::DFG::InvalidationPointInjectionPhase::handle):
(JSC::DFG::InvalidationPointInjectionPhase::insertInvalidationCheck):
(JSC::DFG::performInvalidationPointInjection):

  • dfg/DFGInvalidationPointInjectionPhase.h: Added.
  • dfg/DFGJITCode.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):

  • dfg/DFGJITCompiler.h:
  • dfg/DFGJumpReplacement.cpp: Added.

(JSC::DFG::JumpReplacement::fire):

  • dfg/DFGJumpReplacement.h: Added.

(JSC::DFG::JumpReplacement::JumpReplacement):

  • dfg/DFGNodeType.h:
  • dfg/DFGOSRExitCompilationInfo.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):
(JSC::DFG::Plan::reallyAdd):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::emitInvalidationPoint):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::masqueradesAsUndefinedWatchpointIsStillValid):
(JSC::DFG::SpeculativeJIT::speculateStringObjectForStructure):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGWatchpointCollectionPhase.cpp: Added.

(JSC::DFG::WatchpointCollectionPhase::WatchpointCollectionPhase):
(JSC::DFG::WatchpointCollectionPhase::run):
(JSC::DFG::WatchpointCollectionPhase::handle):
(JSC::DFG::WatchpointCollectionPhase::handleEdge):
(JSC::DFG::WatchpointCollectionPhase::handleMasqueradesAsUndefined):
(JSC::DFG::WatchpointCollectionPhase::handleStringGetByVal):
(JSC::DFG::WatchpointCollectionPhase::addLazily):
(JSC::DFG::WatchpointCollectionPhase::globalObject):
(JSC::DFG::performWatchpointCollection):

  • dfg/DFGWatchpointCollectionPhase.h: Added.
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileStructureTransitionWatchpoint):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::compileGlobalVarWatchpoint):
(JSC::FTL::LowerDFGToLLVM::compileCompareEqConstant):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEqConstant):
(JSC::FTL::LowerDFGToLLVM::compileInvalidationPoint):
(JSC::FTL::LowerDFGToLLVM::equalNullOrUndefined):
(JSC::FTL::LowerDFGToLLVM::speculateNonNullObject):

  • jit/JITOperations.cpp:
  • jit/JumpReplacementWatchpoint.cpp: Removed.
  • jit/JumpReplacementWatchpoint.h: Removed.
12:16 PM Changeset in webkit [158303] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebCore

URTBF after r158289.

  • CMakeLists.txt:
  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:

(WebCore::IDBFactoryBackendLevelDB::createCursorBackend):

12:10 PM Changeset in webkit [158302] by Patrick Gansterer
  • 3 edits in trunk/Tools

[WIN] Add executable entry points to DRT and WinLauncher
​https://bugs.webkit.org/show_bug.cgi?id=121837

Reviewed by Brent Fulgham.

This allows to compile and run the executables without DLLLauncher.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(main):
(dllLauncherEntryPoint):

  • WinLauncher/WinLauncher.cpp:

(wWinMain):
(dllLauncherEntryPoint):

12:10 PM Changeset in webkit [158301] by fpizlo@apple.com
  • 2 edits in trunk/Tools

run-jsc-stress-tests should handle ".." in paths and "slow!" in cmd's
​https://bugs.webkit.org/show_bug.cgi?id=123521

Reviewed by Mark Hahnenberg.

  • Scripts/run-jsc-stress-tests:
12:07 PM Changeset in webkit [158300] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fails with EGLConfigSelector.cpp when OpenGL ES is not used
​https://bugs.webkit.org/show_bug.cgi?id=119037

Patch by Dong-Gwan Kim <​donggwan.kim@samsung.com> on 2013-10-30
Reviewed by Brent Fulgham.

Build fix for EGLConfigSelector.cpp

No new tests, no behavior change.

  • platform/graphics/surfaces/egl/EGLConfigSelector.cpp:

(WebCore::EGLConfigSelector::createConfig):

12:03 PM Changeset in webkit [158299] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Remove PCRE workaround.
​https://bugs.webkit.org/show_bug.cgi?id=123265

Patch by Peter Molnar <​pmolnar.u-szeged@partner.samsung.com> on 2013-10-30
Reviewed by Brent Fulgham.

  • wtf/text/StringStatics.cpp:

(WTF::StringImpl::empty):

12:02 PM Changeset in webkit [158298] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add a flaky test expectation to media/track/track-in-band-legacy-api.html
The failure is tracked by the bug 123522.

  • platform/mac/TestExpectations:
11:59 AM Changeset in webkit [158297] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Remote Layer Tree: Lots of ASSERT(m_children.isEmpty()); on Poster Circle
​https://bugs.webkit.org/show_bug.cgi?id=123517

Reviewed by Simon Fraser.

  • WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::setSublayers):
When setting our list of sublayers, remove all of the new layers from
their parents first.

11:56 AM Changeset in webkit [158296] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Explicitly initialize base class in MediStreamTrackPrivate copy constructor
​https://bugs.webkit.org/show_bug.cgi?id=123473

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-10-30
Reviewed by Eric Carlson.

No new tests needed.

Ports that enable -Werror=extra must do that to compile.

  • platform/mediastream/MediaStreamTrackPrivate.cpp:

(WebCore::MediaStreamTrackPrivate::MediaStreamTrackPrivate):

11:52 AM Changeset in webkit [158295] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Mac build fix after r158291.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::canPlayType):

11:49 AM Changeset in webkit [158294] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Unreviewed, rolling out r158243.
​http://trac.webkit.org/changeset/158243
​https://bugs.webkit.org/show_bug.cgi?id=123520

Change was wrong (Requested by smfr on #webkit).

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/blackberry/PathBlackBerry.cpp:

(WebCore::GraphicsContext::drawLineForText):

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawLineForText):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawLineForText):

  • platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::GraphicsContext::drawLineForText):

  • platform/win/WebCoreTextRenderer.cpp:

(WebCore::doDrawTextAtPoint):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintCompositionUnderline):

11:31 AM Changeset in webkit [158293] by alex.christensen@flexsim.com
  • 2 edits in trunk/Source/WebKit

[Windows] Unreviewed build fix.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Added missing 32-bit and 64-bit linker symbols.

11:22 AM Changeset in webkit [158292] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Favicons are flipped in vertical direction in WinCairo builds.
​https://bugs.webkit.org/show_bug.cgi?id=102077

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-10-30
Reviewed by Brent Fulgham.

  • platform/graphics/win/ImageCairoWin.cpp:

(WebCore::BitmapImage::getHBITMAPOfSize):

11:18 AM Changeset in webkit [158291] by jer.noble@apple.com
  • 9 edits in trunk/Source/WebCore

[MSE] Add MediaSource compatable loading functions to MediaPlayer
​https://bugs.webkit.org/show_bug.cgi?id=123353

Reviewed by Eric Carlson.

Add methods to MediaPlayer to allow it to select the correct MediaPlayerFactory
when attempting to load a MediaSource URL.

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::addSourceBuffer):
(WebCore::MediaSource::isTypeSupported):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::canPlayType):
(WebCore::HTMLMediaElement::selectNextSourceChild):

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::load):
(WebCore::MediaPlayer::supportsType):

  • platform/graphics/MediaPlayer.h:
  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):

Remove the isSupportedMediaSourceMIMEType() method:

  • platform/MIMETypeRegistry.h:
  • platform/efl/MIMETypeRegistryEfl.cpp:
  • platform/mac/MIMETypeRegistryMac.mm:
11:04 AM Changeset in webkit [158290] by ap@apple.com
  • 2 edits in trunk/Tools

Mavericks: 128 tests are failing due to pixel differences
​https://bugs.webkit.org/show_bug.cgi?id=123488

Reviewed by Simon Fraser.

Apple font preferences cannot be fully reset after they've been read, so we
need to set them using CFPreferences before initializing NSApplication.

In theory, this should be an issue on WebKit2 as well, but somehow it doesn't
appear to be. I guess we can figure out the reasons for this difference when/if
any observable problems start to occur.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(setDefaultsToConsistentValuesForTesting): Only set defaults here, move other work
to prepareConsistentTestingEnvironment().
(main): Call setDefaultsToConsistentValuesForTesting before [NSApplication sharedApplication]
(which is unnecessary anyway since NSUserDefaults will implicitly call it, but seems
useful to keep in case we change out approach to defaults again).

11:02 AM Changeset in webkit [158289] by beidson@apple.com
  • 7 edits
    2 moves in trunk/Source/WebCore

Unreviewed. Update NEWS and Versions.m4 for 2.3.1 release.

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-10-29

  • Source/autotools/Versions.m4: Bump version numbers.
11:01 AM Changeset in webkit [158288] by jer.noble@apple.com
  • 10 edits
    9 deletes in trunk

[MSE] Remove legacy Media Source APIs (WebKitMediaSource, WebKitSourceBuffer, WebKitSourceBufferList)
​https://bugs.webkit.org/show_bug.cgi?id=123463

Reviewed by Eric Carlson.

Source/WebCore:

No new tests; updated test results.

Remove all reference to WebKitMediaSource, WebKitSourceBuffer, and WebKitSourceBufferList.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • Modules/mediasource/DOMURLMediaSource.idl:
  • Modules/mediasource/WebKitMediaSource.cpp: Removed.
  • Modules/mediasource/WebKitMediaSource.h: Removed.
  • Modules/mediasource/WebKitMediaSource.idl: Removed.
  • Modules/mediasource/WebKitSourceBuffer.cpp: Removed.
  • Modules/mediasource/WebKitSourceBuffer.h: Removed.
  • Modules/mediasource/WebKitSourceBuffer.idl: Removed.
  • Modules/mediasource/WebKitSourceBufferList.cpp: Removed.
  • Modules/mediasource/WebKitSourceBufferList.h: Removed.
  • Modules/mediasource/WebKitSourceBufferList.idl: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • dom/EventTargetFactory.in:

LayoutTests:

  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
10:58 AM Changeset in webkit [158287] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Fix PrettyPrinting Tool Load from Saved URL

Reviewed by Timothy Hatcher.

  • Tools/PrettyPrinting/index.html:
10:58 AM Changeset in webkit [158286] by mhahnenberg@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

JSExport doesn't support constructors
​https://bugs.webkit.org/show_bug.cgi?id=123380

Reviewed by Geoffrey Garen.

Support for constructor-style callbacks for the Objective-C API to JSC is currently limited to
Objective-C blocks. Any clients who try to call the constructor of a JSExport-ed Objective-C class
are met with a type error stating that it cannot be called as a constructor.

It would be nice to expand JSExport's functionality to support this idiom. It is a natural
extension to JSExport and would increase the expressiveness and simplicity in both Objective-C and
JavaScript client code.

The way we'll do this is to expand the capabilities of ObjCCallbackFunction and associated classes.
Instead of constructing a normal C API object for the constructor, we'll instead allocate a full-blown
ObjCCallbackFunction object which can already properly handle being invoked as a constructor.

  • API/JSWrapperMap.mm:

(copyMethodsToObject):
(allocateConstructorForCustomClass):
(-[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:]):
(tryUnwrapObjcObject):

  • API/ObjCCallbackFunction.h:

(JSC::ObjCCallbackFunction::impl):

  • API/ObjCCallbackFunction.mm:

(JSC::ObjCCallbackFunctionImpl::ObjCCallbackFunctionImpl):
(JSC::ObjCCallbackFunctionImpl::wrappedConstructor):
(JSC::ObjCCallbackFunctionImpl::isConstructible):
(JSC::ObjCCallbackFunction::getConstructData):
(JSC::ObjCCallbackFunctionImpl::name):
(JSC::ObjCCallbackFunctionImpl::call):
(objCCallbackFunctionForInvocation):
(objCCallbackFunctionForInit):
(tryUnwrapConstructor):

  • API/tests/testapi.mm:

(-[TextXYZ initWithString:]):
(-[ClassA initWithA:]):
(-[ClassB initWithA:b:]):
(-[ClassC initWithA:]):
(-[ClassC initWithA:b:]):

10:55 AM Changeset in webkit [158285] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Unbreak the release build.

  • rendering/SimpleLineLayoutFunctions.cpp:
10:54 AM Changeset in webkit [158284] by Simon Fraser
  • 2 edits in trunk/LayoutTests

A WebGL test times out sometimes.

  • platform/mac/TestExpectations:
10:53 AM Changeset in webkit [158283] by aestes@apple.com
  • 3 edits in trunk/Tools

Teach the style checker how to handle Objective-C categories and NS_ENUM
​https://bugs.webkit.org/show_bug.cgi?id=123482

Reviewed by Dan Bernstein.

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_spacing_for_function_call): Allow a space before '(' in a line
starting with @interface or @implementation, since this is defining an
Objective-C category rather than a function.
(check_braces): The opening brace of an NS_ENUM should not be on its
own line.

  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Added unit tests.
10:49 AM Changeset in webkit [158282] by commit-queue@webkit.org
  • 10 edits
    1 add in trunk/Source

[Win] Compile errors when enabling DFG JIT.
​https://bugs.webkit.org/show_bug.cgi?id=120998

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-10-30
Reviewed by Brent Fulgham.

Source/JavaScriptCore:

  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Added files.
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Ditto.
  • dfg/DFGAllocator.h: Removed scope.
  • dfg/DFGWorklist.cpp: Use new ThreadingOnce class instead of pthread_once.

(JSC::DFG::globalWorklist):

  • heap/DeferGC.h: Link fix, member needs to be public.
  • jit/JITOperationWrappers.h: Added required assembler macros.

Source/WTF:

  • wtf/CompilationThread.cpp: Use new ThreadingOnce class instead of pthread_once.

(WTF::initializeCompilationThreads):

  • wtf/ThreadingOnce.h: Added ThreadingOnce class encapsulating pthread_once functionality.

(WTF::ThreadingOnce::ThreadingOnce):
(WTF::ThreadingOnce::~ThreadingOnce):
(WTF::ThreadingOnce::callOnce):

  • wtf/text/CString.h: Export needed symbols.
10:47 AM Changeset in webkit [158281] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Add result caching for Math.cos
​https://bugs.webkit.org/show_bug.cgi?id=123255

Patch by Iago Toral Quiroga <​itoral@igalia.com> on 2013-10-30
Reviewed by Brent Fulgham.

  • runtime/MathObject.cpp:

(JSC::mathProtoFuncCos):

  • runtime/VM.h:
10:44 AM Changeset in webkit [158280] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix memory leaks in platform/image-encoders/JPEGImageEncoder.cpp
​https://bugs.webkit.org/show_bug.cgi?id=118781

Patch by Liangjun Zeng <​lizeng@blackberry.com> on 2013-10-30
Reviewed by Brent Fulgham.

We can find the function "jpeg_finish_compress" call the function "jpeg_abort" at the end.
And the comments of "jpeg_abort" is "Abort processing of a JPEG compression operation,
but don't destroy the object itself". (We can find these in the "jcapimin.c" of jpeg)
So the compression object destroy need be called.
No new tests because this doesn't change functionality.

  • platform/image-encoders/JPEGImageEncoder.cpp:

(WebCore::compressRGBABigEndianToJPEG):

10:40 AM Changeset in webkit [158279] by Antti Koivisto
  • 10 edits in trunk/Source

Add debug settings for simple line layout
​https://bugs.webkit.org/show_bug.cgi?id=123514

Source/WebCore:

Reviewed by Andreas Kling.

  • WebCore.exp.in:
  • page/Settings.in:


Add simpleLineLayoutEnabled and simpleLineLayoutDebugBordersEnabled.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

  • rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::paintDebugBorders):
(WebCore::SimpleLineLayout::paintFlow):

Source/WebKit2:

Reviewed by Andreas Kling.

Expose debug settings.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetSimpleLineLayoutEnabled):
(WKPreferencesGetSimpleLineLayoutEnabled):
(WKPreferencesSetSimpleLineLayoutDebugBordersEnabled):
(WKPreferencesGetSimpleLineLayoutDebugBordersEnabled):

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

10:33 AM Changeset in webkit [158278] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/win

[WIN] Add missing USE(CFNETWORK) to WebError.h
​https://bugs.webkit.org/show_bug.cgi?id=121834

Reviewed by Brent Fulgham.

WebError.cpp uses USE(CFNETWORK), so add it to the header too.

  • WebError.h:
10:31 AM Changeset in webkit [158277] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Curl] Cookies are sometimes not set in download request.
​https://bugs.webkit.org/show_bug.cgi?id=123445

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-10-30
Reviewed by Brent Fulgham.

Sometimes cookies are not set in the download request because the cookie file cannot be opened,
it's already been opened by the ResourceHandleManager for writing.
This can be fixed by getting the cookie list from the share handle in ResourceHandleManager instead.
This will also improve performance, as there is no need to read and parse the cookie file for each download.

  • platform/network/curl/CurlDownload.cpp:

(WebCore::CurlDownload::init): Use share handle to get cookie list.

10:29 AM Changeset in webkit [158276] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/win

[Curl][Win] Suggested filename of download is not url decoded.
​https://bugs.webkit.org/show_bug.cgi?id=123511

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-10-30
Reviewed by Brent Fulgham.

  • WebDownloadCurl.cpp:

(WebDownload::didReceiveResponse): Url decode suggested filename.

10:21 AM Changeset in webkit [158275] by ChangSeok Oh
  • 3 edits in trunk/Source/WebCore

Unguard Element::childShouldCreateRenderer
​https://bugs.webkit.org/show_bug.cgi?id=123496

Reviewed by Andreas Kling.

Make Element::childShouldCreateRenderer normally accessible. Guarding it with flags
just leaves potential build issues.

No new tests since no functionality changed.

  • dom/Element.cpp:

(WebCore::Element::childShouldCreateRenderer):

  • dom/Element.h:
9:44 AM Changeset in webkit [158274] by andersca@apple.com
  • 2 edits
    4 adds in trunk/Source/WebKit2

Add stubbed out WKRemoteObjectRegistry class
​https://bugs.webkit.org/show_bug.cgi?id=123512

Reviewed by Andreas Kling.

Also add a WKRemoteObjectInterface class that represents a remote object interface.

  • Shared/API/Cocoa/WKRemoteObjectInterface.h: Added.
  • Shared/API/Cocoa/WKRemoteObjectInterface.mm: Added.

(-[WKRemoteObjectInterface initWithProtocol:identifier:]):
(+[WKRemoteObjectInterface remoteObjectInterfaceWithProtocol:]):

  • Shared/API/Cocoa/WKRemoteObjectRegistry.h: Added.
  • Shared/API/Cocoa/WKRemoteObjectRegistry.mm: Added.

(-[WKRemoteObjectRegistry registerExportedObject:interface:]):
(-[WKRemoteObjectRegistry unregisterExportedObject:interface:]):
(-[WKRemoteObjectRegistry remoteObjectProxyWithInterface:]):

  • WebKit2.xcodeproj/project.pbxproj:
9:06 AM Changeset in webkit [158273] by commit-queue@webkit.org
  • 6 edits in trunk

[EFL] accessibility/textarea-selected-text-range.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=112016

Patch by Robert Plociennik <​r.plociennik@samsung.com> on 2013-10-30
Reviewed by Mario Sanchez Prada.

Tools:

Provided implementation for AccessibilityUIElement::selectedTextRange() and
AccessibilityUIElement::setSelectedTextRange().

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::selectedTextRange): Implemented.
(AccessibilityUIElement::setSelectedTextRange): Implemented

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::selectedTextRange): Implemented.
(WTR::AccessibilityUIElement::setSelectedTextRange): Implemented.

LayoutTests:

Removed failure expectations.

  • platform/efl-wk1/TestExpectations: The test is no longer failing.
  • platform/efl-wk2/TestExpectations: The test is no longer failing.
9:05 AM Changeset in webkit [158272] by alex.christensen@flexsim.com
  • 6 edits in trunk/Source

Disabled JIT on Win64.
​https://bugs.webkit.org/show_bug.cgi?id=122472

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Disabled building JITStubsMSVC64.

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Added missing 64-bit linker symbol.

Source/WTF:

  • wtf/Platform.h:

Disabled JIT on Win64.

9:01 AM Changeset in webkit [158271] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/LayoutTests

[EFL] accessibility/svg-remote-element.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=112013

Unreviewed EFL gardening. Passes after r158267.

Patch by Robert Plociennik <​r.plociennik@samsung.com> on 2013-10-30

  • platform/efl-wk1/TestExpectations: The test is no longer failing.
  • platform/efl-wk2/TestExpectations: The test is no longer failing.
  • platform/efl/accessibility/svg-remote-element-expected.txt: Added.
8:53 AM Changeset in webkit [158270] by jer.noble@apple.com
  • 12 edits in trunk/Source/WebCore

[MSE] Make MediaSourcePrivate, SourceBufferPrivate classes RefCounted.
​https://bugs.webkit.org/show_bug.cgi?id=123350

Reviewed by Darin Adler.

Make the MediaSourcePrivate and SourceBufferPrivate classes RefCounted so that
they can be referenced both by MediaSource/SourceBuffer, and by the MediaPlayerPrivate
which creates them.

Change OwnPtr -> RefPtr everywhere:

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::addSourceBuffer):

  • Modules/mediasource/MediaSourceBase.cpp:

(WebCore::MediaSourceBase::setPrivateAndOpen):
(WebCore::MediaSourceBase::createSourceBufferPrivate):

  • Modules/mediasource/MediaSourceBase.h:
  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::create):
(WebCore::SourceBuffer::SourceBuffer):

  • Modules/mediasource/SourceBuffer.h:
  • Modules/mediasource/WebKitMediaSource.cpp:

(WebCore::WebKitMediaSource::addSourceBuffer):

  • Modules/mediasource/WebKitSourceBuffer.cpp:

(WebCore::WebKitSourceBuffer::create):
(WebCore::WebKitSourceBuffer::WebKitSourceBuffer):

  • Modules/mediasource/WebKitSourceBuffer.h:
  • html/HTMLMediaSource.h:
  • platform/graphics/MediaSourcePrivate.h:
  • platform/graphics/SourceBufferPrivate.h:

(WebCore::SourceBufferPrivate::SourceBufferPrivate):

8:50 AM Changeset in webkit [158269] by allan.jensen@digia.com
  • 3 edits in trunk/Source/WebCore

Remove unused runtime enabled
​https://bugs.webkit.org/show_bug.cgi?id=123509

Reviewed by Anders Carlsson.

Some of the runtime enabled features were only ever used by the V8 bindings
and can be removed as no WebKit code sets or reads them.

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):

  • bindings/generic/RuntimeEnabledFeatures.h:
7:12 AM Changeset in webkit [158268] by Antti Koivisto
  • 7 edits in trunk/Source/WebCore

Make SimpleLineLayout::Layout a class
​https://bugs.webkit.org/show_bug.cgi?id=123508

Reviewed by Mario Sanchez Prada.

Improve encapsulation.

5:34 AM Changeset in webkit [158267] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk

[GTK] accessibility/svg-remote-element.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=101185

Patch by Robert Plociennik <​r.plociennik@samsung.com> on 2013-10-30
Reviewed by Chris Fleizach.

Tools:

Implemented missing methods by mimicing existing functionality in
AccessibilityObject::clickPoint() using available ATK API.

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::clickPointX): Implemented.
(AccessibilityUIElement::clickPointY): Implemented.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::clickPointX): Implemented.
(WTR::AccessibilityUIElement::clickPointY): Implemented.

LayoutTests:

Provided new test expectations since resulting discrepancies are believed to be
platform related.

  • platform/gtk-wk2/TestExpectations: The test is no longer failing.
  • platform/gtk/accessibility/svg-remote-element-expected.txt: Added.
  • platform/gtk/TestExpectations: The test is no longer failing.
4:31 AM Changeset in webkit [158266] by commit-queue@webkit.org
  • 11 edits
    8 deletes in trunk/Tools

Removed Windows platform configurations from WebKitTestRunner.
​https://bugs.webkit.org/show_bug.cgi?id=123152

Patch by Tamas Gergely <​gertom@inf.u-szeged.hu> on 2013-10-30
Reviewed by Csaba Osztrogonác.

Removed Windows specific parts from the source files, Windows specific
subdirectory (win) and Visual Studio property files from the WebKitTestRunner,
as the platform is no longer supported by this tool.

  • WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Removed.
  • WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Removed.
  • WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Removed.
  • WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Removed.
  • WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Removed.
  • WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Removed.
  • WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
  • WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:

(WTR::AccessibilityController::rootElement):
(WTR::AccessibilityController::focusedElement):

  • WebKitTestRunner/InjectedBundle/AccessibilityController.h:
  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
  • WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/PlatformWebView.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::createWKURL):

  • WebKitTestRunner/cg/TestInvocationCG.cpp:
  • WebKitTestRunner/config.h:
  • WebKitTestRunner/win/InjectedBundle.vcproj: Removed.
  • WebKitTestRunner/win/InjectedBundleDebug.vsprops: Removed.
  • WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Removed.
  • WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Removed.
  • WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Removed.
  • WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Removed.
  • WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Removed.
  • WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Removed.
  • WebKitTestRunner/win/InjectedBundleProduction.vsprops: Removed.
  • WebKitTestRunner/win/InjectedBundleRelease.vsprops: Removed.
  • WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Removed.
  • WebKitTestRunner/win/PlatformWebViewWin.cpp: Removed.
  • WebKitTestRunner/win/TestControllerWin.cpp: Removed.
  • WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
  • WebKitTestRunner/win/WebKitTestRunner.vcproj: Removed.
  • WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Removed.
  • WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Removed.
  • WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Removed.
  • WebKitTestRunner/win/WebKitTestRunnerLauncher.vcproj: Removed.
  • WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Removed.
  • WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Removed.
  • WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Removed.
  • WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Removed.
  • WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Removed.
  • WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Removed.
  • WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Removed.
  • WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Removed.
  • WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Removed.
  • WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Removed.
  • WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Removed.
  • WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Removed.
  • WebKitTestRunner/win/build-generated-files.sh: Removed.
  • WebKitTestRunner/win/main.cpp: Removed.
4:16 AM Changeset in webkit [158265] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

REGRESSION(r158214): It made zillion tests crash on GTK and EFL
​https://bugs.webkit.org/show_bug.cgi?id=123505

  • rendering/SimpleLineLayout.h: Add WTF_MAKE_FAST_ALLOCATED
3:39 AM Changeset in webkit [158264] by commit-queue@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

[EFL] Remove efl/accessibility/image-map1-expected.txt after r158104
​https://bugs.webkit.org/show_bug.cgi?id=123504

Unreviewed EFL gardening.

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-10-30

  • platform/efl/accessibility/image-map1-expected.txt: Removed.
1:50 AM Changeset in webkit [158263] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Revert r158259 for EFL and GTK+. They're still failing everywhere according to the flakiness dashboard.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
1:45 AM Changeset in webkit [158262] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Revert r158259 for Mac. They're definitely failing on Mac.

  • platform/mac/TestExpectations:
1:40 AM Changeset in webkit [158261] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Add more test expectations for the bug 121452.

fast/frames/lots-of-objects.html is failing on Mavericks WebKit2 builders in addition to Debug builders.

fast/frames/lots-of-iframes.html is also failing on the exactly same set of builders.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
1:31 AM Changeset in webkit [158260] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] webkit_web_context_allow_tls_certificate_for_host doc is missing Since tag
​https://bugs.webkit.org/show_bug.cgi?id=123499

Reviewed by Philippe Normand.

  • UIProcess/API/gtk/WebKitWebContext.cpp: Add Since: 2.4.
1:17 AM Changeset in webkit [158259] by svillar@igalia.com
  • 4 edits in trunk/LayoutTests

Unreviewed. Removed some grid layout tests that are passing now.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
1:04 AM Changeset in webkit [158258] by Philippe Normand
  • 4 edits in trunk/Source/WebCore

[GStreamer] Store video-sink in a bin
​https://bugs.webkit.org/show_bug.cgi?id=122831

Reviewed by Gustavo Noronha Silva.

For the upcoming mediastream playback support the player will
handle a non-playbin-based pipeline that will require a slightly
different video rendering chain. This patch generalizes the
encapsulation of the video sink in a bin, just like the audio sink
case.

No new tests, no change in functionality.

Note: See TracTimeline for information about the timeline view.