Context Navigation

← Previous Period
Next Period →

Timeline

Nov 2, 2013:

11:58 PM Changeset in webkit [158526] by ap@apple.com

17 edits
2 copies
4 adds in trunk

Implement generateKey for HMAC and AES-CBC
https://bugs.webkit.org/show_bug.cgi?id=123669

Reviewed by Dan Bernstein.

Source/WebCore:

Tests: crypto/subtle/aes-cbc-generate-key.html

crypto/subtle/hmac-generate-key.html

WebCore.xcodeproj/project.pbxproj: Added new files.

bindings/js/JSCryptoAlgorithmDictionary.cpp:

(WebCore::createAesKeyGenParams): Added bindings for AesKeyGenParams.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForGenerateKey): Handle
algorithms that generate AES and HMAC keys.

bindings/js/JSSubtleCryptoCustom.cpp: (WebCore::JSSubtleCrypto::generateKey): Added.

crypto/CryptoAlgorithmAesKeyGenParams.h: Added.

crypto/CryptoKey.cpp: (WebCore::CryptoKey::randomData):
crypto/CryptoKey.h:
crypto/CryptoKeyMac.cpp: Added

Expose a function that produces random data for symmetric crypto keys. Cross-platform
implementation uses ARC4 code from WTF, while Mac uses a system function that
provides a FIPS validated random number generator.

crypto/CryptoKeyAES.cpp: (WebCore::CryptoKeyAES::generate):
crypto/CryptoKeyAES.h:

Added a function that creates AES keys.

crypto/SubtleCrypto.idl: Added generateKey.

crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:

(WebCore::CryptoAlgorithmAES_CBC::generateKey): Added.

crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::generateKey): Added.

crypto/keys/CryptoKeyHMAC.cpp: (WebCore::CryptoKeyHMAC::generate):
crypto/keys/CryptoKeyHMAC.h:

Added a function that creates HMAC keys.

crypto/mac/CryptoAlgorithmAES_CBCMac.cpp: Removed generateKey stub, the implementation

ended up in cross-platform file.

crypto/mac/CryptoAlgorithmHMACMac.cpp: Ditto.

LayoutTests:

crypto/subtle/aes-cbc-generate-key-expected.txt: Added.
crypto/subtle/aes-cbc-generate-key.html: Added.
crypto/subtle/hmac-generate-key-expected.txt: Added.
crypto/subtle/hmac-generate-key.html: Added.

crypto/subtle/sha-1-expected.txt: Now that crypto.webkitSubtle.generateKey exists,

a different exception is raised.

11:50 PM Changeset in webkit [158525] by akling@apple.com

1 edit
35 moves
2 adds
39 deletes in trunk/LayoutTests

Optimize baselines: css3

Unreviewed; run "webkit-patch optimize-baselines css3"

css3/images/cross-fade-background-size-expected.txt: Renamed from LayoutTests/platform/efl/css3/images/cross-fade-background-size-expected.txt.
css3/images/cross-fade-blending-expected.png: Renamed from LayoutTests/platform/efl/css3/images/cross-fade-blending-expected.png.
css3/images/cross-fade-blending-expected.txt: Renamed from LayoutTests/platform/efl/css3/images/cross-fade-blending-expected.txt.
css3/images/cross-fade-invalidation-expected.txt: Renamed from LayoutTests/platform/efl/css3/images/cross-fade-invalidation-expected.txt.
css3/images/cross-fade-simple-expected.txt: Renamed from LayoutTests/platform/efl/css3/images/cross-fade-simple-expected.txt.
css3/images/cross-fade-sizing-expected.txt: Renamed from LayoutTests/platform/efl/css3/images/cross-fade-sizing-expected.txt.
css3/images/cross-fade-tiled-expected.txt: Renamed from LayoutTests/platform/efl/css3/images/cross-fade-tiled-expected.txt.
css3/selectors3/html/css3-modsel-17-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-17-expected.png.
css3/selectors3/html/css3-modsel-177a-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-177a-expected.png.
css3/selectors3/html/css3-modsel-18c-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-18c-expected.png.
css3/selectors3/html/css3-modsel-27a-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-27a-expected.png.
css3/selectors3/html/css3-modsel-27b-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-27b-expected.png.
css3/selectors3/html/css3-modsel-61-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-61-expected.png.
css3/selectors3/xhtml/css3-modsel-123b-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-123b-expected.png.
css3/selectors3/xhtml/css3-modsel-17-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-17-expected.png.
css3/selectors3/xhtml/css3-modsel-177a-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-177a-expected.png.
css3/selectors3/xhtml/css3-modsel-18c-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-18c-expected.png.
css3/selectors3/xhtml/css3-modsel-27a-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-27a-expected.png.
css3/selectors3/xhtml/css3-modsel-27b-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-27b-expected.png.
css3/selectors3/xhtml/css3-modsel-61-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-61-expected.png.
css3/selectors3/xhtml/css3-modsel-91-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-91-expected.png.
css3/selectors3/xhtml/css3-modsel-92-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-92-expected.png.
css3/selectors3/xml/css3-modsel-123b-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-123b-expected.png.
css3/selectors3/xml/css3-modsel-167-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-167-expected.png.
css3/selectors3/xml/css3-modsel-167a-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-167a-expected.png.
css3/selectors3/xml/css3-modsel-17-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-17-expected.png.
css3/selectors3/xml/css3-modsel-177a-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-177a-expected.png.
css3/selectors3/xml/css3-modsel-18c-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-18c-expected.png.
css3/selectors3/xml/css3-modsel-27a-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-27a-expected.png.
css3/selectors3/xml/css3-modsel-27b-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-27b-expected.png.
css3/selectors3/xml/css3-modsel-61-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-61-expected.png.
css3/selectors3/xml/css3-modsel-91-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-91-expected.png.
css3/selectors3/xml/css3-modsel-92-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-92-expected.png.
platform/efl-wk1/css3/flexbox/flexbox-baseline-expected.png: Renamed from LayoutTests/platform/efl/css3/flexbox/flexbox-baseline-expected.png.
platform/efl-wk1/css3/flexbox/flexbox-baseline-expected.txt: Renamed from LayoutTests/platform/efl/css3/flexbox/flexbox-baseline-expected.txt.
platform/gtk/css3/images/cross-fade-blending-expected.png: Removed.
platform/gtk/css3/images/cross-fade-blending-expected.txt: Removed.
platform/gtk/css3/images/cross-fade-invalidation-expected.txt: Removed.
platform/gtk/css3/images/cross-fade-simple-expected.txt: Removed.
platform/gtk/css3/images/cross-fade-sizing-expected.txt: Removed.
platform/gtk/css3/images/cross-fade-tiled-expected.txt: Removed.
platform/gtk/css3/selectors3/html/css3-modsel-17-expected.png: Removed.
platform/gtk/css3/selectors3/html/css3-modsel-177a-expected.png: Removed.
platform/gtk/css3/selectors3/html/css3-modsel-18c-expected.png: Removed.
platform/gtk/css3/selectors3/html/css3-modsel-27a-expected.png: Removed.
platform/gtk/css3/selectors3/html/css3-modsel-27b-expected.png: Removed.
platform/gtk/css3/selectors3/html/css3-modsel-61-expected.png: Removed.
platform/gtk/css3/selectors3/xhtml/css3-modsel-123b-expected.png: Removed.
platform/gtk/css3/selectors3/xhtml/css3-modsel-17-expected.png: Removed.
platform/gtk/css3/selectors3/xhtml/css3-modsel-177a-expected.png: Removed.
platform/gtk/css3/selectors3/xhtml/css3-modsel-18c-expected.png: Removed.
platform/gtk/css3/selectors3/xhtml/css3-modsel-27a-expected.png: Removed.
platform/gtk/css3/selectors3/xhtml/css3-modsel-27b-expected.png: Removed.
platform/gtk/css3/selectors3/xhtml/css3-modsel-61-expected.png: Removed.
platform/gtk/css3/selectors3/xhtml/css3-modsel-91-expected.png: Removed.
platform/gtk/css3/selectors3/xhtml/css3-modsel-92-expected.png: Removed.
platform/gtk/css3/selectors3/xml/css3-modsel-123b-expected.png: Removed.
platform/gtk/css3/selectors3/xml/css3-modsel-167-expected.png: Removed.
platform/gtk/css3/selectors3/xml/css3-modsel-167a-expected.png: Removed.
platform/gtk/css3/selectors3/xml/css3-modsel-17-expected.png: Removed.
platform/gtk/css3/selectors3/xml/css3-modsel-177a-expected.png: Removed.
platform/gtk/css3/selectors3/xml/css3-modsel-18c-expected.png: Removed.
platform/gtk/css3/selectors3/xml/css3-modsel-27a-expected.png: Removed.
platform/gtk/css3/selectors3/xml/css3-modsel-27b-expected.png: Removed.
platform/gtk/css3/selectors3/xml/css3-modsel-61-expected.png: Removed.
platform/gtk/css3/selectors3/xml/css3-modsel-91-expected.png: Removed.
platform/gtk/css3/selectors3/xml/css3-modsel-92-expected.png: Removed.
platform/mac/css3/images/cross-fade-background-size-expected.txt: Removed.
platform/mac/css3/images/cross-fade-blending-expected.txt: Removed.
platform/mac/css3/images/cross-fade-invalidation-expected.txt: Removed.
platform/mac/css3/images/cross-fade-simple-expected.txt: Removed.
platform/mac/css3/images/cross-fade-sizing-expected.txt: Removed.
platform/mac/css3/images/cross-fade-tiled-expected.txt: Removed.
platform/win/css3/filters/effect-reference-expected.txt: Removed.
platform/win/css3/filters/effect-reference-hw-expected.txt: Removed.

11:25 PM Changeset in webkit [158524] by akling@apple.com

1 edit
72 moves
73 deletes in trunk/LayoutTests

Optimize baselines: css2.1

Unreviewed; run "webkit-patch optimize-baselines css2.1"

css2.1/20110323/absolute-replaced-height-036-expected.png: Renamed from LayoutTests/platform/efl/css2.1/20110323/absolute-replaced-height-036-expected.png.
css2.1/20110323/block-non-replaced-height-011-expected.png: Renamed from LayoutTests/platform/efl/css2.1/20110323/block-non-replaced-height-011-expected.png.
css2.1/20110323/block-non-replaced-height-013-expected.png: Renamed from LayoutTests/platform/efl/css2.1/20110323/block-non-replaced-height-013-expected.png.
css2.1/20110323/empty-inline-001-expected.png: Renamed from LayoutTests/platform/efl/css2.1/20110323/empty-inline-001-expected.png.
css2.1/20110323/replaced-intrinsic-002-expected.png: Renamed from LayoutTests/platform/efl/css2.1/20110323/replaced-intrinsic-002-expected.png.
css2.1/20110323/replaced-intrinsic-002-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/replaced-intrinsic-002-expected.txt.
css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt.
css2.1/t040105-atkeyw-00-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atkeyw-00-b-expected.png.
css2.1/t040105-atkeyw-01-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atkeyw-01-b-expected.png.
css2.1/t040105-atkeyw-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atkeyw-02-b-expected.png.
css2.1/t040105-atrule-00-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atrule-00-b-expected.png.
css2.1/t040105-atrule-01-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atrule-01-b-expected.png.
css2.1/t040105-atrule-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atrule-02-b-expected.png.
css2.1/t040105-atrule-03-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atrule-03-b-expected.png.
css2.1/t040105-atrule-04-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atrule-04-b-expected.png.
css2.1/t040105-import-00-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-import-00-b-expected.png.
css2.1/t040105-import-01-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-import-01-b-expected.png.
css2.1/t040105-import-10-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-import-10-b-expected.png.
css2.1/t0402-syntax-01-f-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0402-syntax-01-f-expected.png.
css2.1/t0402-syntax-02-f-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0402-syntax-02-f-expected.png.
css2.1/t0402-syntax-03-f-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0402-syntax-03-f-expected.png.
css2.1/t0402-syntax-04-f-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0402-syntax-04-f-expected.png.
css2.1/t0402-syntax-05-f-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0402-syntax-05-f-expected.png.
css2.1/t0402-syntax-06-f-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0402-syntax-06-f-expected.png.
css2.1/t040307-syntax-01-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040307-syntax-01-b-expected.png.
css2.1/t0505-c16-descendant-02-e-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0505-c16-descendant-02-e-expected.png.
css2.1/t0509-id-sel-syntax-01-f-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0509-id-sel-syntax-01-f-expected.png.
css2.1/t0509-id-sel-syntax-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0509-id-sel-syntax-02-b-expected.png.
css2.1/t0511-c21-pseud-link-00-e-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0511-c21-pseud-link-00-e-expected.png.
css2.1/t0511-c21-pseud-link-01-e-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0511-c21-pseud-link-01-e-expected.png.
css2.1/t0511-c21-pseud-link-02-e-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0511-c21-pseud-link-02-e-expected.png.
css2.1/t0511-c21-pseud-link-03-e-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0511-c21-pseud-link-03-e-expected.png.
css2.1/t051103-c21-focus-ln-00-e-i-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t051103-c21-focus-ln-00-e-i-expected.png.
css2.1/t051103-c21-hover-ln-00-e-i-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t051103-c21-hover-ln-00-e-i-expected.png.
css2.1/t0803-c5504-mrgn-l-02-c-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0803-c5504-mrgn-l-02-c-expected.png.
css2.1/t0805-c5511-brdr-tw-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5511-brdr-tw-02-b-expected.png.
css2.1/t0805-c5512-brdr-rw-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5512-brdr-rw-02-b-expected.png.
css2.1/t0805-c5513-brdr-bw-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5513-brdr-bw-02-b-expected.png.
css2.1/t0805-c5514-brdr-lw-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5514-brdr-lw-02-b-expected.png.
css2.1/t0805-c5515-brdr-w-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5515-brdr-w-02-b-expected.png.
css2.1/t1001-abs-pos-cb-01-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-01-b-expected.png.
css2.1/t1001-abs-pos-cb-01-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-01-b-expected.txt.
css2.1/t1001-abs-pos-cb-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-02-b-expected.png.
css2.1/t1001-abs-pos-cb-02-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-02-b-expected.txt.
css2.1/t1001-abs-pos-cb-03-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-03-b-expected.png.
css2.1/t1001-abs-pos-cb-03-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-03-b-expected.txt.
css2.1/t1001-abs-pos-cb-04-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-04-b-expected.png.
css2.1/t1001-abs-pos-cb-04-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-04-b-expected.txt.
css2.1/t1001-abs-pos-cb-05-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-05-b-expected.png.
css2.1/t1001-abs-pos-cb-05-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-05-b-expected.txt.
css2.1/t1001-abs-pos-cb-06-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-06-b-expected.png.
css2.1/t1001-abs-pos-cb-06-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-06-b-expected.txt.
css2.1/t1001-abs-pos-cb-07-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-07-b-expected.png.
css2.1/t1001-abs-pos-cb-07-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-07-b-expected.txt.
css2.1/t1001-abs-pos-cb-08-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-08-b-expected.png.
css2.1/t1001-abs-pos-cb-08-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-08-b-expected.txt.
css2.1/t1001-abs-pos-cb-09-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-09-b-expected.png.
css2.1/t1001-abs-pos-cb-09-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-09-b-expected.txt.
css2.1/t1205-c566-list-stl-01-c-g-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1205-c566-list-stl-01-c-g-expected.txt.
css2.1/t140201-c532-bgcolor-01-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t140201-c532-bgcolor-01-b-expected.png.
css2.1/t140201-c533-bgimage-01-b-g-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t140201-c533-bgimage-01-b-g-expected.png.
css2.1/t140201-c536-bgpos-01-b-ag-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t140201-c536-bgpos-01-b-ag-expected.png.
css2.1/t1508-c527-font-00-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-00-b-expected.txt.
css2.1/t1508-c527-font-01-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-01-b-expected.txt.
css2.1/t1508-c527-font-02-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-02-b-expected.txt.
css2.1/t1508-c527-font-03-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-03-b-expected.txt.
css2.1/t1508-c527-font-04-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-04-b-expected.txt.
css2.1/t1508-c527-font-05-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-05-b-expected.txt.
css2.1/t1508-c527-font-07-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-07-b-expected.txt.
css2.1/t1508-c527-font-08-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-08-b-expected.txt.
css2.1/t1508-c527-font-09-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-09-b-expected.txt.
css2.1/t1508-c527-font-10-c-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-10-c-expected.txt.
platform/gtk/css2.1/20110323/absolute-replaced-height-036-expected.png: Removed.
platform/gtk/css2.1/20110323/block-non-replaced-height-011-expected.png: Removed.
platform/gtk/css2.1/20110323/block-non-replaced-height-013-expected.png: Removed.
platform/gtk/css2.1/20110323/empty-inline-001-expected.png: Removed.
platform/gtk/css2.1/20110323/replaced-intrinsic-002-expected.png: Removed.
platform/gtk/css2.1/20110323/replaced-intrinsic-002-expected.txt: Removed.
platform/gtk/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt: Removed.
platform/gtk/css2.1/t040105-atkeyw-00-b-expected.png: Removed.
platform/gtk/css2.1/t040105-atkeyw-01-b-expected.png: Removed.
platform/gtk/css2.1/t040105-atkeyw-02-b-expected.png: Removed.
platform/gtk/css2.1/t040105-atrule-00-b-expected.png: Removed.
platform/gtk/css2.1/t040105-atrule-01-b-expected.png: Removed.
platform/gtk/css2.1/t040105-atrule-02-b-expected.png: Removed.
platform/gtk/css2.1/t040105-atrule-03-b-expected.png: Removed.
platform/gtk/css2.1/t040105-atrule-04-b-expected.png: Removed.
platform/gtk/css2.1/t040105-import-00-b-expected.png: Removed.
platform/gtk/css2.1/t040105-import-01-b-expected.png: Removed.
platform/gtk/css2.1/t040105-import-10-b-expected.png: Removed.
platform/gtk/css2.1/t0402-syntax-01-f-expected.png: Removed.
platform/gtk/css2.1/t0402-syntax-02-f-expected.png: Removed.
platform/gtk/css2.1/t0402-syntax-03-f-expected.png: Removed.
platform/gtk/css2.1/t0402-syntax-04-f-expected.png: Removed.
platform/gtk/css2.1/t0402-syntax-05-f-expected.png: Removed.
platform/gtk/css2.1/t0402-syntax-06-f-expected.png: Removed.
platform/gtk/css2.1/t040307-syntax-01-b-expected.png: Removed.
platform/gtk/css2.1/t0505-c16-descendant-02-e-expected.png: Removed.
platform/gtk/css2.1/t0509-id-sel-syntax-01-f-expected.png: Removed.
platform/gtk/css2.1/t0509-id-sel-syntax-02-b-expected.png: Removed.
platform/gtk/css2.1/t0511-c21-pseud-link-00-e-expected.png: Removed.
platform/gtk/css2.1/t0511-c21-pseud-link-01-e-expected.png: Removed.
platform/gtk/css2.1/t0511-c21-pseud-link-02-e-expected.png: Removed.
platform/gtk/css2.1/t0511-c21-pseud-link-03-e-expected.png: Removed.
platform/gtk/css2.1/t051103-c21-focus-ln-00-e-i-expected.png: Removed.
platform/gtk/css2.1/t051103-c21-hover-ln-00-e-i-expected.png: Removed.
platform/gtk/css2.1/t0803-c5504-mrgn-l-02-c-expected.png: Removed.
platform/gtk/css2.1/t0805-c5511-brdr-tw-02-b-expected.png: Removed.
platform/gtk/css2.1/t0805-c5512-brdr-rw-02-b-expected.png: Removed.
platform/gtk/css2.1/t0805-c5513-brdr-bw-02-b-expected.png: Removed.
platform/gtk/css2.1/t0805-c5514-brdr-lw-02-b-expected.png: Removed.
platform/gtk/css2.1/t0805-c5515-brdr-w-02-b-expected.png: Removed.
platform/gtk/css2.1/t1001-abs-pos-cb-01-b-expected.png: Removed.
platform/gtk/css2.1/t1001-abs-pos-cb-01-b-expected.txt: Removed.
platform/gtk/css2.1/t1001-abs-pos-cb-02-b-expected.png: Removed.
platform/gtk/css2.1/t1001-abs-pos-cb-02-b-expected.txt: Removed.
platform/gtk/css2.1/t1001-abs-pos-cb-03-b-expected.png: Removed.
platform/gtk/css2.1/t1001-abs-pos-cb-03-b-expected.txt: Removed.
platform/gtk/css2.1/t1001-abs-pos-cb-04-b-expected.png: Removed.
platform/gtk/css2.1/t1001-abs-pos-cb-04-b-expected.txt: Removed.
platform/gtk/css2.1/t1001-abs-pos-cb-05-b-expected.png: Removed.
platform/gtk/css2.1/t1001-abs-pos-cb-05-b-expected.txt: Removed.
platform/gtk/css2.1/t1001-abs-pos-cb-06-b-expected.png: Removed.
platform/gtk/css2.1/t1001-abs-pos-cb-06-b-expected.txt: Removed.
platform/gtk/css2.1/t1001-abs-pos-cb-07-b-expected.png: Removed.
platform/gtk/css2.1/t1001-abs-pos-cb-07-b-expected.txt: Removed.
platform/gtk/css2.1/t1001-abs-pos-cb-08-b-expected.png: Removed.
platform/gtk/css2.1/t1001-abs-pos-cb-08-b-expected.txt: Removed.
platform/gtk/css2.1/t1001-abs-pos-cb-09-b-expected.png: Removed.
platform/gtk/css2.1/t1001-abs-pos-cb-09-b-expected.txt: Removed.
platform/gtk/css2.1/t1205-c566-list-stl-01-c-g-expected.txt: Removed.
platform/gtk/css2.1/t140201-c532-bgcolor-01-b-expected.png: Removed.
platform/gtk/css2.1/t140201-c533-bgimage-01-b-g-expected.png: Removed.
platform/gtk/css2.1/t140201-c536-bgpos-01-b-ag-expected.png: Removed.
platform/gtk/css2.1/t1508-c527-font-00-b-expected.txt: Removed.
platform/gtk/css2.1/t1508-c527-font-01-b-expected.txt: Removed.
platform/gtk/css2.1/t1508-c527-font-02-b-expected.txt: Removed.
platform/gtk/css2.1/t1508-c527-font-03-b-expected.txt: Removed.
platform/gtk/css2.1/t1508-c527-font-04-b-expected.txt: Removed.
platform/gtk/css2.1/t1508-c527-font-05-b-expected.txt: Removed.
platform/gtk/css2.1/t1508-c527-font-07-b-expected.txt: Removed.
platform/gtk/css2.1/t1508-c527-font-08-b-expected.txt: Removed.
platform/gtk/css2.1/t1508-c527-font-09-b-expected.txt: Removed.
platform/gtk/css2.1/t1508-c527-font-10-c-expected.txt: Removed.
platform/mac/css2.1/t1508-c527-font-00-b-expected.txt: Removed.

11:04 PM Changeset in webkit [158523] by akling@apple.com

1 edit
14 moves
2 adds
12 deletes in trunk/LayoutTests

Optimize baselines: fast/dom

Unreviewed; run "webkit-patch optimize-baselines fast/dom"

fast/dom/HTMLHeadElement/textInHead1-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLHeadElement/textInHead1-expected.txt.
fast/dom/HTMLHeadElement/textInHead2-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLHeadElement/textInHead2-expected.txt.
fast/dom/HTMLHeadElement/textInHead3-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLHeadElement/textInHead3-expected.txt.
fast/dom/HTMLHeadElement/textInHead4-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLHeadElement/textInHead4-expected.txt.
fast/dom/HTMLHeadElement/textInHead5-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLHeadElement/textInHead5-expected.txt.
fast/dom/HTMLMeterElement/meter-element-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLMeterElement/meter-element-expected.txt.
fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt.
fast/dom/anchor-text-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/anchor-text-expected.txt.
fast/dom/comment-not-documentElement-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/comment-not-documentElement-expected.txt.
fast/dom/delete-contents-expected.png: Renamed from LayoutTests/platform/efl/fast/dom/delete-contents-expected.png.
fast/dom/scroll-reveal-left-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/scroll-reveal-left-overflow-expected.txt.
fast/dom/scroll-reveal-top-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/scroll-reveal-top-overflow-expected.txt.
platform/gtk/fast/dom/HTMLHeadElement/textInHead1-expected.txt: Removed.
platform/gtk/fast/dom/HTMLHeadElement/textInHead2-expected.txt: Removed.
platform/gtk/fast/dom/HTMLHeadElement/textInHead3-expected.txt: Removed.
platform/gtk/fast/dom/HTMLHeadElement/textInHead4-expected.txt: Removed.
platform/gtk/fast/dom/HTMLHeadElement/textInHead5-expected.txt: Removed.
platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: Removed.
platform/gtk/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Removed.
platform/gtk/fast/dom/anchor-text-expected.txt: Removed.
platform/gtk/fast/dom/comment-not-documentElement-expected.txt: Removed.
platform/gtk/fast/dom/delete-contents-expected.png: Removed.
platform/gtk/fast/dom/scroll-reveal-left-overflow-expected.txt: Removed.
platform/gtk/fast/dom/scroll-reveal-top-overflow-expected.txt: Removed.
platform/win-7sp0/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Renamed from LayoutTests/platform/win/fast/dom/horizontal-scrollbar-in-rtl-expected.txt.
platform/win-7sp0/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Renamed from LayoutTests/platform/win/fast/dom/vertical-scrollbar-in-rtl-expected.txt.

10:35 PM Changeset in webkit [158522] by gyuyoung.kim@samsung.com

2 edits in trunk/LayoutTests

Unreviewed, EFL gardening. Add missing baselines to EFL wk1 TestExpectation.

platform/efl-wk1/TestExpectations: Need to add new baseline since upgrading base OS.

9:13 PM Changeset in webkit [158521] by ch.dumez@samsung.com

13 edits in trunk

EnforceRange doesn't enforce range of a short
https://bugs.webkit.org/show_bug.cgi?id=123661

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Handle Web IDL short / unsigned short types as per the
specification:

Specifically, we used to treat short / unsigned short as 32bit
integers, which was wrong. We now properly handle them as 16bit
integers.

No new tests, added test cases to js/dom/webidl-type-mapping.html.

WebCore.exp.in:
bindings/js/JSDOMBinding.cpp:

(WebCore::toSmallerInt):
(WebCore::toSmallerUInt):
(WebCore::toInt8):
(WebCore::toUInt8):
(WebCore::toInt16):
(WebCore::toUInt16):

bindings/js/JSDOMBinding.h:
bindings/scripts/CodeGeneratorJS.pm:

(JSValueToNative):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjShortAttr):
(WebCore::setJSTestObjUnsignedShortAttr):

testing/TypeConversions.h:

(WebCore::TypeConversions::testShort):
(WebCore::TypeConversions::setTestShort):
(WebCore::TypeConversions::testEnforceRangeShort):
(WebCore::TypeConversions::setTestEnforceRangeShort):
(WebCore::TypeConversions::testUnsignedShort):
(WebCore::TypeConversions::setTestUnsignedShort):
(WebCore::TypeConversions::testEnforceRangeUnsignedShort):
(WebCore::TypeConversions::setTestEnforceRangeUnsignedShort):

testing/TypeConversions.idl:

Source/WebKit:

Export symbols to fix Windows build.

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

LayoutTests:

Extend js/dom/webidl-type-mapping.html layout test to validate
Web IDL type mapping for short / unsigned short.

js/dom/webidl-type-mapping-expected.txt:
js/dom/webidl-type-mapping.html:

8:25 PM Changeset in webkit [158520] by Patrick Gansterer

2 edits in trunk/Source/WTF

Fix compilation of DateMath.cpp with MSVC
https://bugs.webkit.org/show_bug.cgi?id=123680

Reviewed by Darin Adler.

wtf/DateMath.cpp:

(WTF::appendTwoDigitNumber): Help the compiler finding the
correct overload by casting the characters to LChar.

8:24 PM Changeset in webkit [158519] by Patrick Gansterer

6 edits in trunk/Source/WebCore

Cleanup OpenTypeUtilities
https://bugs.webkit.org/show_bug.cgi?id=123686

Reviewed by Darin Adler.

Merge the WinCE specific code into the general Windows code to
make the compilation of WinCE port on WinNT easier.

platform/graphics/opentype/OpenTypeUtilities.cpp:

(WebCore::renameFont):
(WebCore::renameAndActivateFont):

platform/graphics/opentype/OpenTypeUtilities.h:
platform/graphics/win/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData):

platform/graphics/win/FontCustomPlatformDataCairo.cpp:

(WebCore::createFontCustomPlatformData):

platform/graphics/wince/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData):

8:19 PM Changeset in webkit [158518] by Patrick Gansterer

2 edits in trunk/Source/JavaScriptCore

Add missing getHostCallReturnValue() for MSVC ARM
https://bugs.webkit.org/show_bug.cgi?id=123685

Reviewed by Darin Adler.

jit/JITStubsARM.h:

8:18 PM Changeset in webkit [158517] by akling@apple.com

1 edit
26 moves
34 deletes in trunk/LayoutTests

Optimize baselines: fast/css

Unreviewed; run "webkit-patch optimize-baselines fast/css"

fast/css/background-image-with-baseurl-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/background-image-with-baseurl-expected.txt.
fast/css/caption-width-absolute-position-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/caption-width-absolute-position-expected.txt.
fast/css/caption-width-absolute-position-offset-top-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/caption-width-absolute-position-offset-top-expected.txt.
fast/css/caption-width-fixed-position-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/caption-width-fixed-position-expected.txt.
fast/css/caption-width-fixed-position-offset-top-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/caption-width-fixed-position-offset-top-expected.txt.
fast/css/caption-width-relative-position-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/caption-width-relative-position-expected.txt.
fast/css/caption-width-relative-position-offset-top-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/caption-width-relative-position-offset-top-expected.txt.
fast/css/font-face-default-font-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/font-face-default-font-expected.txt.
fast/css/font-face-in-media-rule-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/font-face-in-media-rule-expected.txt.
fast/css/font-size-negative-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/font-size-negative-expected.txt.
fast/css/imageTileOpacity-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/imageTileOpacity-expected.txt.
fast/css/import_with_baseurl-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/import_with_baseurl-expected.txt.
fast/css/line-height-determined-by-primary-font-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/line-height-determined-by-primary-font-expected.txt.
fast/css/line-height-font-order-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/line-height-font-order-expected.txt.
fast/css/line-height-negative-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/line-height-negative-expected.txt.
fast/css/max-height-none-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/max-height-none-expected.txt.
fast/css/min-width-with-spanned-cell-expected.png: Renamed from LayoutTests/platform/efl/fast/css/min-width-with-spanned-cell-expected.png.
fast/css/min-width-with-spanned-cell-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/min-width-with-spanned-cell-expected.txt.
fast/css/min-width-with-spanned-cell-fixed-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/min-width-with-spanned-cell-fixed-expected.txt.
fast/css/pseudo-first-line-border-width-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/pseudo-first-line-border-width-expected.txt.
fast/css/replaced-element-implicit-size-expected.png: Renamed from LayoutTests/platform/efl/fast/css/replaced-element-implicit-size-expected.png.
fast/css/vertical-align-lengths-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/vertical-align-lengths-expected.txt.
fast/css/visibility-hit-test-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/visibility-hit-test-expected.txt.
platform/efl-wk2/fast/css/font-smoothing-expected.png: Renamed from LayoutTests/platform/efl/fast/css/font-smoothing-expected.png.
platform/efl-wk2/fast/css/font-weight-1-expected.png: Renamed from LayoutTests/platform/efl/fast/css/font-weight-1-expected.png.
platform/efl-wk2/fast/css/input-search-padding-expected.png: Renamed from LayoutTests/platform/efl/fast/css/input-search-padding-expected.png.
platform/gtk/fast/css/background-image-with-baseurl-expected.txt: Removed.
platform/gtk/fast/css/caption-width-absolute-position-expected.txt: Removed.
platform/gtk/fast/css/caption-width-absolute-position-offset-top-expected.txt: Removed.
platform/gtk/fast/css/caption-width-fixed-position-expected.txt: Removed.
platform/gtk/fast/css/caption-width-fixed-position-offset-top-expected.txt: Removed.
platform/gtk/fast/css/caption-width-relative-position-expected.txt: Removed.
platform/gtk/fast/css/caption-width-relative-position-offset-top-expected.txt: Removed.
platform/gtk/fast/css/font-face-in-media-rule-expected.txt: Removed.
platform/gtk/fast/css/font-size-negative-expected.txt: Removed.
platform/gtk/fast/css/imageTileOpacity-expected.txt: Removed.
platform/gtk/fast/css/import_with_baseurl-expected.txt: Removed.
platform/gtk/fast/css/line-height-determined-by-primary-font-expected.txt: Removed.
platform/gtk/fast/css/line-height-font-order-expected.txt: Removed.
platform/gtk/fast/css/line-height-negative-expected.txt: Removed.
platform/gtk/fast/css/max-height-none-expected.txt: Removed.
platform/gtk/fast/css/min-width-with-spanned-cell-expected.png: Removed.
platform/gtk/fast/css/min-width-with-spanned-cell-expected.txt: Removed.
platform/gtk/fast/css/min-width-with-spanned-cell-fixed-expected.txt: Removed.
platform/gtk/fast/css/pseudo-first-line-border-width-expected.txt: Removed.
platform/gtk/fast/css/replaced-element-implicit-size-expected.png: Removed.
platform/gtk/fast/css/vertical-align-lengths-expected.txt: Removed.
platform/gtk/fast/css/visibility-hit-test-expected.txt: Removed.
platform/mac/fast/css/caption-width-absolute-position-expected.txt: Removed.
platform/mac/fast/css/caption-width-absolute-position-offset-top-expected.txt: Removed.
platform/mac/fast/css/caption-width-fixed-position-expected.txt: Removed.
platform/mac/fast/css/caption-width-fixed-position-offset-top-expected.txt: Removed.
platform/mac/fast/css/caption-width-relative-position-expected.txt: Removed.
platform/mac/fast/css/caption-width-relative-position-offset-top-expected.txt: Removed.
platform/mac/fast/css/font-face-default-font-expected.txt: Removed.
platform/mac/fast/css/font-face-in-media-rule-expected.txt: Removed.
platform/mac/fast/css/min-width-with-spanned-cell-expected.txt: Removed.
platform/mac/fast/css/min-width-with-spanned-cell-fixed-expected.txt: Removed.
platform/mac/fast/css/pseudo-first-line-border-width-expected.txt: Removed.
platform/win/fast/css/zoom-body-scroll-expected.txt: Removed.

8:16 PM Changeset in webkit [158516] by Patrick Gansterer

2 edits in trunk/Source/JavaScriptCore

Fix MSVC warning about unary minus operator
https://bugs.webkit.org/show_bug.cgi?id=123674

Reviewed by Darin Adler.

Change some static_cast<> to silence the following warning of Microsoft compiler:
warning C4146: unary minus operator applied to unsigned type, result still unsigned

jit/Repatch.cpp:

(JSC::emitPutTransitionStub):

7:36 PM Changeset in webkit [158515] by akling@apple.com

7 edits in trunk/Source/WebCore

CSSFontFaceSrcValue constructors should return PassRef.
<https://webkit.org/b/123692>

Make functions that return non-null CSSFontFaceSrcValues return
PassRef instead of PassRefPtr. Tweak some call sites to be
slightly more efficient.

Reviewed by Anders Carlsson.

7:33 PM Changeset in webkit [158514] by akling@apple.com

17 edits in trunk/Source/WebCore

CSSStyleSheet::contents() should return a reference.
<https://webkit.org/b/123689>

Make CSSStyleSheet::contents() return a StyleSheetContents& instead
of a pointer. The object was already stored in a Ref.

Reviewed by Anders Carlsson.

7:14 PM Changeset in webkit [158513] by akling@apple.com

3 edits in trunk/Source/WebCore

CSSReflectValue constructor should return PassRef.
<https://webkit.org/b/123963>

Make CSSReflectValue::create() return a PassRef. Tweak one call
site to be slightly more efficient.

Reviewed by Anders Carlsson.

7:12 PM Changeset in webkit [158512] by akling@apple.com

3 edits in trunk/Source/WebCore

CSSFontFeatureValue constructor should return PassRef.
<https://webkit.org/b/123691>

Make CSSFontFeatureValue::create() return PassRef, since it never
returns null. Tweak one call site to be slightly more efficient.

Reviewed by Anders Carlsson.

7:04 PM Changeset in webkit [158511] by akling@apple.com

4 edits in trunk/Source/WebCore

Tighten typing in SVGResources::buildCachedResources().
<https://webkit.org/b/123690>

Make this function take a RenderElement&/SVGRenderStyle& pair instead
of a RenderObject*/SVGRenderStyle* pair. Also tweaked the code a bit,
removing ampersands and asserts as appropriate.

Reviewed by Anders Carlsson.

6:47 PM Changeset in webkit [158510] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Disable LLVM's pretty stack traces, which involve intercepting fatal signals
https://bugs.webkit.org/show_bug.cgi?id=123681

Reviewed by Geoffrey Garen.

llvm/library/LLVMExports.cpp:

(initializeAndGetJSCLLVMAPI):

6:33 PM Changeset in webkit [158509] by fpizlo@apple.com

10 edits
1 add in trunk

LLVM assertion failures should funnel into WTF's crash handling
https://bugs.webkit.org/show_bug.cgi?id=123682

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Inside llvmForJSC, we override assertion-related functions and funnel them
into g_llvmTrapCallback(). We also now register a fatal error handler inside
the library and funnel that into g_llvmTrapCallback, and have
initializeAndGetJSCLLVMAPI() take such a callback as an argument.

Inside JSC, we no longer call LLVMInstallFatalErrorHandler() but instead we
pass WTFLogAlwaysAndCrash() as the trap callback for llvmForJSC.

llvm/InitializeLLVM.cpp:

(JSC::initializeLLVM):

llvm/InitializeLLVMPOSIX.cpp:

(JSC::initializeLLVMPOSIX):

llvm/library/LLVMExports.cpp:

(llvmCrash):
(initializeAndGetJSCLLVMAPI):

llvm/library/LLVMOverrides.cpp:

(raise):
(assert_rtn):
(abort):

llvm/library/LLVMTrapCallback.h: Added.

Source/WTF:

Reviewed by Geoffrey Garen.

Give JSC some new toys to play with for crash handling.

wtf/Assertions.cpp:
wtf/Assertions.h:

Tools:

Reviewed by Geoffrey Garen.

Need to disable LLVM's crash overrides so that we can do our own crash overrides.

Scripts/configure-llvm:

6:30 PM Changeset in webkit [158508] by fpizlo@apple.com

3 edits in trunk/WebKitLibraries

Unreviewed, update binary drops.

These include my LLVMDisablePrettyStackTrace() fix and are built with --enable-crash-overrides=no

LLVMIncludesMountainLion.tar.bz2:
LLVMLibrariesMountainLion.tar.bz2:

5:32 PM Changeset in webkit [158507] by fpizlo@apple.com

4 edits in trunk/Source/JavaScriptCore

CodeBlock::jettison() shouldn't call baselineVersion()
https://bugs.webkit.org/show_bug.cgi?id=123675

Reviewed by Geoffrey Garen.

Fix more uses of baselineVersion().

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::jettison):

bytecode/CodeBlock.h:
bytecode/ProfiledCodeBlockJettisoningWatchpoint.cpp:

(JSC::ProfiledCodeBlockJettisoningWatchpoint::fireInternal):

5:29 PM Changeset in webkit [158506] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

LLVM asserts in internal-js-tests.yaml/Octane/stress-tests/mandreel.js
https://bugs.webkit.org/show_bug.cgi?id=123535

Reviewed by Geoffrey Garen.

Use double comparisons for doubles.

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::doubleToInt32):

4:56 PM Changeset in webkit [158505] by akling@apple.com

6 edits in trunk/Source/WebCore

CSSImageValue constructors should return PassRef.
<https://webkit.org/b/123688>

Make the CSSImageValue::create() helpers return PassRef.
Tightened call sites to avoid null checks and destructor calls.

Reviewed by Anders Carlsson.

3:17 PM Changeset in webkit [158504] by Patrick Gansterer

2 edits in trunk/Source/WebCore

Fix compilation of SynchronousLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=123676

Reviewed by Darin Adler.

Assign a ResourceRequest varibale an empty ResourceRequest instead of 0.
The current solution only works for ports which can create a
ResourceRequest from a pointer, which might not be true for all ports.

platform/network/SynchronousLoaderClient.cpp:

(WebCore::SynchronousLoaderClient::willSendRequest):

2:59 PM Changeset in webkit [158503] by Patrick Gansterer

2 edits in trunk

[WINCE] Disable export macros
https://bugs.webkit.org/show_bug.cgi?id=123679

Reviewed by Darin Adler.

Avoid useless exports by turning of the export macros
since the WinCE port works as a static library only.

Source/cmake/OptionsWinCE.cmake:

2:58 PM Changeset in webkit [158502] by Patrick Gansterer

3 edits in trunk/Source/WebCore

Port LoggingWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=123678

Reviewed by Darin Adler.

This makes it easier to use a common list of files
for the different Windows ports later.

PlatformWin.cmake:
platform/win/LoggingWin.cpp:

(WebCore::logLevelString):

2:56 PM Changeset in webkit [158501] by Patrick Gansterer

14 edits in trunk/Source/WebKit/wince

Add OVERRIDE keyword to WebCoreSupport classes
https://bugs.webkit.org/show_bug.cgi?id=123672

Reviewed by Darin Adler.

Also align the function parameters with the base classes
and remove useless functions.

WebCoreSupport/ChromeClientWinCE.cpp:
WebCoreSupport/ChromeClientWinCE.h:
WebCoreSupport/ContextMenuClientWinCE.cpp:
WebCoreSupport/ContextMenuClientWinCE.h:
WebCoreSupport/DragClientWinCE.cpp:

(WebKit::DragClientWinCE::willPerformDragDestinationAction):
(WebKit::DragClientWinCE::willPerformDragSourceAction):
(WebKit::DragClientWinCE::actionMaskForDrag):
(WebKit::DragClientWinCE::startDrag):

WebCoreSupport/DragClientWinCE.h:
WebCoreSupport/EditorClientWinCE.h:
WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForResponse):
(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNewWindowAction):
(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNavigationAction):
(WebKit::FrameLoaderClientWinCE::dispatchWillSubmitForm):

WebCoreSupport/FrameLoaderClientWinCE.h:
WebCoreSupport/FrameNetworkingContextWinCE.h:
WebCoreSupport/InspectorClientWinCE.cpp:
WebCoreSupport/InspectorClientWinCE.h:
WebCoreSupport/PlatformStrategiesWinCE.h:

2:56 PM Changeset in webkit [158500] by mitz@apple.com

4 edits in trunk/Source/WebKit2

[Cocoa] Wrappers mishandle NULL values in arrays and dictionaries
https://bugs.webkit.org/show_bug.cgi?id=123671

Reviewed by Darin Adler.

Shared/Cocoa/WKNSArray.mm:

(-[WKNSArray objectAtIndex:]): Represent a NULL object as NSNull.

Shared/Cocoa/WKNSDictionary.mm:

(-[WKNSDictionary objectForKey:]): Represent a NULL value as NSNull.

Shared/ImmutableDictionary.h:

(WebKit::ImmutableDictionary::get): Added this overload that returns whether the key exists.

2:47 PM Changeset in webkit [158499] by Patrick Gansterer

8 edits in trunk/Source

Fix UnicodeWchar after r157330.
https://bugs.webkit.org/show_bug.cgi?id=123668

Reviewed by Darin Adler.

Source/WebCore:

editing/TextIterator.cpp:

(WebCore::SearchBuffer::append):

platform/graphics/wince/FontWinCE.cpp:

(WebCore::generateComponents):

platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::GraphicsContext::drawText):

platform/text/wchar/TextBreakIteratorWchar.cpp:

(WebCore::isCharStop):
(WebCore::isLineStop):
(WebCore::isSentenceStop):
(WebCore::WordBreakIterator::next):
(WebCore::WordBreakIterator::previous):

Source/WTF:

wtf/unicode/wchar/UnicodeWchar.cpp:

(unorm_normalize):
(u_strFoldCase):
(u_strToLower):
(u_strToUpper):

wtf/unicode/wchar/UnicodeWchar.h:

(u_foldCase):
(u_isprint):
(u_isspace):

2:18 PM Changeset in webkit [158498] by akling@apple.com

7 edits in trunk/Source

Make remaining StringImpl functions return PassRef.
<https://webkit.org/b/123683>

Okay, this seems to work well! Let's go all in and convert the
remaining StringImpl functions to return PassRef<StringImpl> instead
of PassRefPtr where we know that null is never returned.

Reviewed by Anders Carlsson.

2:18 PM Changeset in webkit [158497] by akling@apple.com

8 edits in trunk/Source/WebCore

Use RenderChildIterator in a couple of places.
<https://webkit.org/b/123684>

Added isRendererOfType() for RenderBox and RenderBlock and switch
some loops over to using childrenOfType<>. Also sprinkled const
and references on touched code.

Reviewed by Antti Koivisto.

2:03 PM Changeset in webkit [158496] by zandobersek@gmail.com

3 edits in trunk/Source/WebCore

Manage FileReaderLoader through std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=123666

Reviewed by Anders Carlsson.

Construct FileReaderLoader objects through std::make_unique and store them in std::unique_ptr.

fileapi/FileReader.cpp:

(WebCore::FileReader::readInternal):

fileapi/FileReader.h:

12:51 PM Changeset in webkit [158495] by akling@apple.com

10 edits
2 adds in trunk/Source/WebCore

Add a child renderer iterator.
<https://webkit.org/b/123662>

Introduce an ElementIterator-style iterator for renderers and put
it to use in a childrenOfType() implementation.

It's used just like the Element iterators:

auto sections = childrenOfType<RenderTableSection>(*this);
for (auto section = sections.begin(), section = sections.end(); section != sections.end(); ++section)

section->thisOrThat();

Just like the DOM counterpart, it relies on a templatized helper:

bool isRendererOfType<T>(const RenderObject&)

This patch puts the iterator to use in a couple of random places.

Reviewed by Antti Koivisto.

11:19 AM Changeset in webkit [158494] by ap@apple.com

4 edits
12 copies
8 adds in trunk

Implement remaining SHA variations for WebCrypto
https://bugs.webkit.org/show_bug.cgi?id=123659

Reviewed by Anders Carlsson.

Source/WebCore:

Tests: crypto/subtle/sha-224.html

crypto/subtle/sha-256.html
crypto/subtle/sha-384.html
crypto/subtle/sha-512.html

WebCore.xcodeproj/project.pbxproj:
crypto/algorithms/CryptoAlgorithmSHA224.cpp: Added.

(WebCore::CryptoAlgorithmSHA224::CryptoAlgorithmSHA224):
(WebCore::CryptoAlgorithmSHA224::~CryptoAlgorithmSHA224):
(WebCore::CryptoAlgorithmSHA224::create):
(WebCore::CryptoAlgorithmSHA224::identifier):

crypto/algorithms/CryptoAlgorithmSHA224.h: Added.
crypto/algorithms/CryptoAlgorithmSHA256.cpp: Added.

(WebCore::CryptoAlgorithmSHA256::CryptoAlgorithmSHA256):
(WebCore::CryptoAlgorithmSHA256::~CryptoAlgorithmSHA256):
(WebCore::CryptoAlgorithmSHA256::create):
(WebCore::CryptoAlgorithmSHA256::identifier):

crypto/algorithms/CryptoAlgorithmSHA256.h: Added.
crypto/algorithms/CryptoAlgorithmSHA384.cpp: Added.

(WebCore::CryptoAlgorithmSHA384::CryptoAlgorithmSHA384):
(WebCore::CryptoAlgorithmSHA384::~CryptoAlgorithmSHA384):
(WebCore::CryptoAlgorithmSHA384::create):
(WebCore::CryptoAlgorithmSHA384::identifier):

crypto/algorithms/CryptoAlgorithmSHA384.h: Added.
crypto/algorithms/CryptoAlgorithmSHA512.cpp: Added.

(WebCore::CryptoAlgorithmSHA512::CryptoAlgorithmSHA512):
(WebCore::CryptoAlgorithmSHA512::~CryptoAlgorithmSHA512):
(WebCore::CryptoAlgorithmSHA512::create):
(WebCore::CryptoAlgorithmSHA512::identifier):

crypto/algorithms/CryptoAlgorithmSHA512.h: Added.
crypto/mac/CryptoAlgorithmRegistryMac.cpp:

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):

crypto/mac/CryptoAlgorithmSHA224Mac.cpp: Added.

(WebCore::CryptoAlgorithmSHA224::digest):

crypto/mac/CryptoAlgorithmSHA256Mac.cpp: Added.

(WebCore::CryptoAlgorithmSHA256::digest):

crypto/mac/CryptoAlgorithmSHA384Mac.cpp: Added.

(WebCore::CryptoAlgorithmSHA384::digest):

crypto/mac/CryptoAlgorithmSHA512Mac.cpp: Added.

(WebCore::CryptoAlgorithmSHA512::digest):

LayoutTests:

crypto/subtle/sha-224-expected.txt: Added.
crypto/subtle/sha-224.html: Added.
crypto/subtle/sha-256-expected.txt: Added.
crypto/subtle/sha-256.html: Added.
crypto/subtle/sha-384-expected.txt: Added.
crypto/subtle/sha-384.html: Added.
crypto/subtle/sha-512-expected.txt: Added.
crypto/subtle/sha-512.html: Added.

10:54 AM Changeset in webkit [158493] by mitz@apple.com

2 edits in trunk/Source/WebKit2

Fixed release builds.

Shared/Cocoa/WKNSDictionary.mm:

(-[WKNSDictionary initWithObjects:forKeys:count:]):

10:33 AM Changeset in webkit [158492] by Patrick Gansterer

12 edits in trunk/Source

Various small WinCE build fixes

Source/JavaScriptCore:

jsc.cpp:

(main):

Source/WebCore:

editing/TextIterator.cpp:

(WebCore::SearchBuffer::append):

platform/graphics/BitmapImage.h:
platform/graphics/wince/ImageWinCE.cpp:

(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):

platform/graphics/wince/PlatformPathWinCE.h:
platform/win/PopupMenuWin.h:
rendering/RenderThemeWinCE.cpp:

(WebCore::RenderThemeWinCE::adjustMenuListButtonStyle):

Source/WebKit/wince:

WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::transitionToCommittedForNewPage):

WebView.cpp:

10:26 AM Changeset in webkit [158491] by Patrick Gansterer

2 edits in trunk/Source/JavaScriptCore

Fix MSVC ARM build after r157581.

jit/JITStubsARM.h:

9:59 AM Changeset in webkit [158490] by akling@apple.com

3 edits in trunk/Source/WTF

StringImpl::upper() should return PassRef.
<https://webkit.org/b/123655>

Make upper() return PassRef<StringImpl>. Spotted and removed some
ref churning in implementations.

Reviewed by Darin Adler.

9:42 AM Changeset in webkit [158489] by mitz@apple.com

3 edits
2 adds in trunk/Source/WebKit2

[Cocoa] Add WKNSDictionary
https://bugs.webkit.org/show_bug.cgi?id=123660

Reviewed by Anders Carlsson.

Shared/Cocoa/APIObject.mm:

(WebKit::APIObject::newObject): Allocate a WKNSDictionary if the APIObject is a dictionary.

Shared/Cocoa/WKNSDictionary.h: Added.

(WebKit::wrapper): Added. Returns an ImmutableDictionary’s wrapper as an NSDictionary.

Shared/Cocoa/WKNSDictionary.mm: Added.

(-[WKNSDictionary dealloc]): Calls the ImmutableDictionary destructor.
(-[WKNSDictionary count]): Added.
(-[WKNSDictionary objectForKey:]): Added.
(-[WKNSDictionary keyEnumerator]): Added.
(-[WKNSDictionary copyWithZone:]): Retains self.
(-[WKNSDictionary _apiObject]): Returns the wrapped ImmutableDictionary.

WebKit2.xcodeproj/project.pbxproj: Added references to new files.

9:04 AM Changeset in webkit [158488] by timothy_horton@apple.com

3 edits in trunk/Source/WebKit2

Address some review comments noted in r158463
https://bugs.webkit.org/show_bug.cgi?id=123646

Reviewed by Darin Adler.

Shared/mac/RemoteLayerBackingStore.mm:

Put our has_include ifs all on one line.

(createIOSurface):
IOSurfaceAlignProperty returns size_t, not unsigned long.

(RemoteLayerBackingStore::display):
(RemoteLayerBackingStore::drawInContext):
Create the frontImage in display() and hand it to drawInContext().

Use the GraphicsContext API instead of CG itself for clearRect().

When using ShareableBitmap, replace m_frontBuffer instead of
having a backBuffer local; the CGImageRef will retain the
ShareableBitmap it references.

Duplicate our drawInContext() calls so we don't have to allocate
a GraphicsContext on the heap in the IOSurface case.

Don't bother clearing frontContext; it'll happen for us at
the appropriate time. Instead, assert that it's still alive after
we drop our reference to the frontImage created from it.

7:34 AM Changeset in webkit [158487] by zandobersek@gmail.com

2 edits in trunk/Source/WebKit2

[GTK] invalid use of incomplete type 'class WTF::PassOwnPtr<WTF::Vector<unsigned char> >'
https://bugs.webkit.org/show_bug.cgi?id=123601

Reviewed by Carlos Garcia Campos.

WebProcess/Plugins/Netscape/NetscapePluginStream.cpp: Explicitly include the PassOwnPtr.h header

as certain configurations on the GTK port don't ensure that the header is included indirectly.

3:10 AM Changeset in webkit [158486] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[GTK] invalid application of 'sizeof' to incomplete type
https://bugs.webkit.org/show_bug.cgi?id=123502

Patch by Vitaly Katunin <vkatunin@luxoft.com> on 2013-11-02
Reviewed by Carlos Garcia Campos.

Shared/WebCoreArgumentCoders.cpp:

Nov 1, 2013:

11:59 PM Changeset in webkit [158485] by ap@apple.com

17 edits
6 copies
14 adds in trunk

Add WebCrypto AES-CBC
https://bugs.webkit.org/show_bug.cgi?id=123647

Reviewed by Anders Carlsson.

Source/WebCore:

Tests: crypto/subtle/aes-cbc-192-encrypt-decrypt.html

crypto/subtle/aes-cbc-256-encrypt-decrypt.html
crypto/subtle/aes-cbc-encrypt-decrypt-with-padding.html
crypto/subtle/aes-cbc-encrypt-decrypt.html
crypto/subtle/aes-cbc-invalid-length.html
crypto/subtle/aes-cbc-wrong-key-class.html

WebCore.xcodeproj/project.pbxproj: Added new files.
bindings/js/JSCryptoAlgorithmDictionary.cpp:

(WebCore::getProperty): Factored out a function to get a property as JSValue.
(WebCore::getHashAlgorithm): Use it.
(WebCore::createAesCbcParams): Added converter for AesCbcParams.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForEncrypt): Support AES_CBC.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDecrypt): Ditto.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey): Support all
algorithms, all the new ones just have trivial dictionaries.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForExportKey): Ditto.

bindings/js/JSCryptoOperationData.cpp: Added.

(WebCore::sequenceOfCryptoOperationDataFromJSValue):
(WebCore::cryptoOperationDataFromJSValue):

bindings/js/JSCryptoOperationData.h: Added.

Moved CryptoOperationData bindings out of JSSubtleCryptoCustom.cpp, so that we
could use them in JSCryptoAlgorithmDictionary.cpp.

bindings/js/JSDOMPromise.h: (WebCore::PromiseWrapper::reject): Added a specialization

to reject with null result. The spec doesn't actually say how algorithms fail.

bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::JSSubtleCrypto::encrypt): Added.
(WebCore::JSSubtleCrypto::decrypt): Ditto.
(WebCore::JSSubtleCrypto::sign): Style fix.

crypto/CryptoAlgorithmAesCbcParams.h: Added.

crypto/CryptoKey.h:

(WebCore::CryptoKeyClass):

crypto/keys/CryptoKeyHMAC.h:

(WebCore::asCryptoKeyHMAC):
Added poor man's RTTI, so that we can safely upcast Keys passed fro JavaScript code.

crypto/CryptoKeyAES.cpp: Added.

(WebCore::CryptoKeyAES::CryptoKeyAES):
(WebCore::CryptoKeyAES::~CryptoKeyAES):
(WebCore::CryptoKeyAES::buildAlgorithmDescription):

crypto/CryptoKeyAES.h: Added.

(WebCore::asCryptoKeyAES):
AES keys are the same for all algorithms, but they still need to remember the algorithm.

crypto/SubtleCrypto.idl: Added encrypt/decrypt.

crypto/algorithms/CryptoAlgorithmAES_CBC.cpp: Added.

(WebCore::CryptoAlgorithmAES_CBC::CryptoAlgorithmAES_CBC):
(WebCore::CryptoAlgorithmAES_CBC::~CryptoAlgorithmAES_CBC):
(WebCore::CryptoAlgorithmAES_CBC::create):
(WebCore::CryptoAlgorithmAES_CBC::identifier):
(WebCore::CryptoAlgorithmAES_CBC::importKey):
(WebCore::CryptoAlgorithmAES_CBC::exportKey):

crypto/algorithms/CryptoAlgorithmAES_CBC.h: Added.
crypto/mac/CryptoAlgorithmAES_CBCMac.cpp: Added.

(WebCore::transformAES_CBC):
(WebCore::CryptoAlgorithmAES_CBC::encrypt):
(WebCore::CryptoAlgorithmAES_CBC::decrypt):
(WebCore::CryptoAlgorithmAES_CBC::generateKey):
Added.

crypto/mac/CryptoAlgorithmHMACMac.cpp:

(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):
Check key class before casting it to CryptoKeyHMAC.

crypto/mac/CryptoAlgorithmRegistryMac.cpp:

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms): Register AES-CBC
on Mac, so that it can be used.

Source/WTF:

wtf/FixedArray.h: (WTF::FixedArray::data): Added a const version of the function.

wtf/Vector.h: Added a comment to Vector constructor about how it is different

from std::vector.

LayoutTests:

Part of aes-cbc-encrypt-decrypt.html test was taken from Blink.

crypto/subtle/aes-cbc-192-encrypt-decrypt-expected.txt: Added.
crypto/subtle/aes-cbc-192-encrypt-decrypt.html: Added.
crypto/subtle/aes-cbc-256-encrypt-decrypt-expected.txt: Added.
crypto/subtle/aes-cbc-256-encrypt-decrypt.html: Added.
crypto/subtle/aes-cbc-encrypt-decrypt-expected.txt: Added.
crypto/subtle/aes-cbc-encrypt-decrypt-with-padding-expected.txt: Added.
crypto/subtle/aes-cbc-encrypt-decrypt-with-padding.html: Added.
crypto/subtle/aes-cbc-encrypt-decrypt.html: Added.
crypto/subtle/aes-cbc-invalid-length-expected.txt: Added.
crypto/subtle/aes-cbc-invalid-length.html: Added.
crypto/subtle/aes-cbc-wrong-key-class-expected.txt: Added.
crypto/subtle/aes-cbc-wrong-key-class.html: Added.

crypto/subtle/hmac-sign-verify-expected.txt:
crypto/subtle/hmac-sign-verify.html:

Corrected a description.

crypto/subtle/resources/common.js: (hexToArrayBuffer): Added a helper.

10:01 PM Changeset in webkit [158484] by akling@apple.com

36 edits in trunk/Source/WebCore

SVGRenderStyle accessors should return references.
<https://webkit.org/b/123656>

RenderStyle::svgStyle() and accessSVGStyle() never return null,
so make them return references instead.

This flushed out a myriad of pointless null checks and assertions.

Reviewed by Anders Carlsson.

7:28 PM Changeset in webkit [158483] by ljaehun.lim@samsung.com

4 edits in trunk/LayoutTests

Update layout test results after CSS calc() simplification
https://bugs.webkit.org/show_bug.cgi?id=123654

Reviewed by Andreas Kling.

r156586 simplified CSS calc expressions.
Update layout test results for calc().

fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-expected.txt:
fast/css3-text/css3-text-indent/getComputedStyle/script-tests/getComputedStyle-text-indent.js:

(valueSettingTest):

platform/efl/TestExpectations: gardening

7:24 PM Changeset in webkit [158482] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

FTL should use a simple optimization pipeline by default
https://bugs.webkit.org/show_bug.cgi?id=123638

Reviewed by Geoffrey Garen.

20% speed-up on imagine-gaussian-blur, when combined with --ftlUsesStackmaps=true.

ftl/FTLCompile.cpp:

(JSC::FTL::compile):

runtime/Options.h:

7:23 PM Changeset in webkit [158481] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Remote Layer Tree: Crashes allocating incredibly large backing store for tiled backing layers
https://bugs.webkit.org/show_bug.cgi?id=123651

Reviewed by Simon Fraser.

Shared/mac/RemoteLayerBackingStore.mm:

(RemoteLayerBackingStore::display):
(RemoteLayerBackingStore::drawInContext):
We can't dirty the whole layer if we have no existing front buffer if
we have no paints, because that will lead to layers which were never
setNeedsDisplay()'d getting backing store. Added back an assertion
that will catch this, too.

7:13 PM Changeset in webkit [158480] by commit-queue@webkit.org

13 edits in trunk/Source

Removing MediaStreamTrackVector and MediaStreamSourceVector typedefs
https://bugs.webkit.org/show_bug.cgi?id=123648

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-01
Reviewed by Eric Carlson.

Source/WebCore:

No new tests needed.

Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::create):
(WebCore::MediaStream::clone):
(WebCore::MediaStream::cloneMediaStreamTrackVector):
(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::removeTrack):
(WebCore::MediaStream::haveTrackWithSource):
(WebCore::MediaStream::getTrackById):
(WebCore::MediaStream::trackVectorForType):

Modules/mediastream/MediaStream.h:
Modules/mediastream/MediaStreamTrack.h:
Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::callSuccessHandler):

Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createMediaStreamSource):

Modules/webaudio/MediaStreamAudioDestinationNode.cpp:

(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):

platform/mediastream/MediaStreamDescriptor.cpp:

(WebCore::MediaStreamDescriptor::create):
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):

platform/mediastream/MediaStreamDescriptor.h:
platform/mediastream/MediaStreamSource.h:

Source/WebKit/blackberry:

WebCoreSupport/UserMediaClientImpl.cpp:

(WebCore::toMediaStreamDescriptor):
(WebCore::UserMediaClientImpl::requestUserMedia):

WebCoreSupport/UserMediaClientImpl.h:

7:09 PM Changeset in webkit [158479] by Joseph Pecoraro

4 edits in trunk/Source/WTF

Unreviewed extended attempt at Windows build fix after r158471.

wtf/text/cf/AtomicStringCF.cpp:
wtf/text/cf/StringCF.cpp:
wtf/text/cf/StringImplCF.cpp:

6:53 PM Changeset in webkit [158478] by akling@apple.com

2 edits in trunk/Source/WebCore

createFontFaceValue() should be smarter about overgrown cache.
<https://webkit.org/b/123643>

Instead of clearing the whole font-face value cache when it passes
128 entries, just delete one entry at random.

Reviewed by Geoffrey Garen.

6:51 PM Changeset in webkit [158477] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fixing mac code to use new MediaStreamDescriptor create method
https://bugs.webkit.org/show_bug.cgi?id=123653

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-01
Reviewed by Eric Carlson.

No new tests needed.

platform/mediastream/mac/MediaStreamCenterMac.cpp:

(WebCore::MediaStreamCenterMac::createMediaStream):

6:50 PM Changeset in webkit [158476] by akling@apple.com

2 edits in trunk/Source/WebCore

Re-use existing RenderStyle local in textWidth().
<https://webkit.org/b/123392>

We already have the RenderStyle cached in a local here, so avoid
getting it from RenderText since that has to go via the parent.

Reviewed by Antti Koivisto.

6:49 PM Changeset in webkit [158475] by Joseph Pecoraro

4 edits in trunk/Source/WTF

Unreviewed attempt at Windows build fix after r158471.

wtf/text/cf/AtomicStringCF.cpp:
wtf/text/cf/StringCF.cpp:
wtf/text/cf/StringImplCF.cpp:

6:45 PM Changeset in webkit [158474] by akling@apple.com

6 edits in trunk/Source

Make more StringImpl construction helpers return PassRef.
<https://webkit.org/b/123652>

Tweak another handful of StringImpl constructor functions to return
PassRef<StringImpl> instead of PassRefPtr.

Reviewed by Anders Carlsson.

6:38 PM Changeset in webkit [158473] by akling@apple.com

6 edits in trunk/Source

Neuter WTF_MAKE_FAST_ALLOCATED in GLOBAL_FASTMALLOC_NEW builds.
<https://webkit.org/b/123639>

Source/JavaScriptCore:

JSC::ParserArenaRefCounted really needed to have the new/delete
operators overridden, in order for JSC::ScopeNode to be able to
choose that "operator new" out of the two it inherits.

Reviewed by Anders Carlsson.

Source/WebCore:

WebCore::TimerBase really needed to have the new/delete operators
overridden, in order for WebCore::SuspendableTimer to be able to
choose that "operator new" out of the two it inherits.

Reviewed by Anders Carlsson.

Source/WTF:

When building with GLOBAL_FASTMALLOC_NEW, we don't need to expand
operator new/delete overrides in every class.

This change makes allocations group up nicely in Instruments,
instead of being split between "WTF::fastMalloc" and "operator new"
depending on whether the class had WTF_MAKE_FAST_ALLOCATED.

Reviewed by Anders Carlsson.

6:23 PM Changeset in webkit [158472] by akling@apple.com

2 edits in trunk/Source/WebCore

CSSCanvasValue construction helper should return PassRef.
<https://webkit.org/b/123650>

Return PassRef instead of PassRefPtr from functions that return
ownership-passing pointers that are known to be non-null.

Reviewed by Anders Carlsson.

6:22 PM Changeset in webkit [158471] by commit-queue@webkit.org

11 edits
5 moves
2 adds in trunk/Source

Move CF/Mac WTF String implementations down into WTF
https://bugs.webkit.org/show_bug.cgi?id=123635

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-11-01
Reviewed by Sam Weinig.

Source/WebCore:

WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:

Source/WTF:

WTF.vcxproj/WTF.vcxproj:
WTF.vcxproj/WTF.vcxproj.filters:
WTF.xcodeproj/project.pbxproj:
wtf/text/AtomicString.h:
wtf/text/StringImpl.h:
wtf/text/WTFString.h:
wtf/text/cf/AtomicStringCF.cpp: Renamed from Source/WebCore/platform/text/cf/AtomicStringCF.cpp.

(WTF::AtomicString::add):

wtf/text/cf/StringCF.cpp: Renamed from Source/WebCore/platform/text/cf/StringCF.cpp.

(WTF::String::String):
(WTF::String::createCFString):

wtf/text/cf/StringImplCF.cpp: Renamed from Source/WebCore/platform/text/cf/StringImplCF.cpp.

(garbageCollectionEnabled):
(WTF::StringWrapperCFAllocator::retain):
(WTF::StringWrapperCFAllocator::release):
(WTF::StringWrapperCFAllocator::copyDescription):
(WTF::StringWrapperCFAllocator::allocate):
(WTF::StringWrapperCFAllocator::reallocate):
(WTF::StringWrapperCFAllocator::deallocateOnMainThread):
(WTF::StringWrapperCFAllocator::deallocate):
(WTF::StringWrapperCFAllocator::preferredSize):
(WTF::StringWrapperCFAllocator::create):
(WTF::StringWrapperCFAllocator::allocator):
(WTF::StringImpl::createCFString):

wtf/text/mac/StringImplMac.mm: Renamed from Source/WebCore/platform/text/mac/StringImplMac.mm.

(WTF::StringImpl::operator NSString *):

wtf/text/mac/StringMac.mm: Renamed from Source/WebCore/platform/text/mac/StringMac.mm.

(WTF::String::String):

6:20 PM Changeset in webkit [158470] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Removing unnecessary early returns in addTrack, removeTrack and removeRemoteSource methods
https://bugs.webkit.org/show_bug.cgi?id=123644

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-01
Reviewed by Eric Carlson.

No new tests needed.

Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::removeTrack):
(WebCore::MediaStream::removeRemoteSource):
(WebCore::MediaStream::trackVectorForType):

Modules/mediastream/MediaStream.h:

6:03 PM Changeset in webkit [158469] by akling@apple.com

2 edits in trunk/Source/WebCore

CSSAspectRatioValue construction helper should return PassRef.
<https://webkit.org/b/123645>

Return PassRef instead of PassRefPtr from functions that return
ownership-passing pointers that are known to be non-null.

Reviewed by Darin Adler.

5:55 PM Changeset in webkit [158468] by Brent Fulgham

16 edits
8 adds in branches/safari-537.73-branch

Merge r157070

Source/WebCore:

2013-10-04 Ojan Vafai <ojan@chromium.org> and Martin Robinson <mrobinson@igalia.com>

[MathML] Remove RenderTree modification during layout and refactor the StretchyOp code
https://bugs.webkit.org/show_bug.cgi?id=121416

Reviewed by David Hyatt.

Tests: mathml/presentation/mo-minus.html

mathml/presentation/mo-stacked-glyphs.html
mathml/presentation/mo-stretchy-vertical-bar.html
mathml/very-large-stretchy-operators.html

MathML stretched operators by both modifying the width of the operator
and adding children to the operator node in the render tree.

Instead we make the operator width equal to the widest glyph possible that we use
to represent the operator. Additionally instead of rendering stretchy glyphs via
stacked operator pieces in separate render tree nodes, keep only one node for the
glyph, and use a custom paint method to paint the stacked representation.

With this patch, rendering seems roughly equivalent on Mac and markedly better
on Linux.

css/mathml.css: Not sure what this line-height:0 was here for, but it caused bugs with the new code

mathml/MathMLTextElement.cpp: (WebCore::MathMLTextElement::attach): (WebCore): (WebCore::MathMLTextElement::childrenChanged): Need to update the anonymous render tree below <mo> elements when their children change or when the renderer is first attached.

mathml/MathMLTextElement.h: (MathMLTextElement):
rendering/mathml/RenderMathMLBlock.cpp: (WebCore::RenderMathMLBlock::RenderMathMLBlock):
rendering/mathml/RenderMathMLBlock.h: Now that the preferred width doesn't depend on the height, we don't need to override computePreferredLogicalWidths at all.

rendering/mathml/RenderMathMLFenced.cpp: (WebCore::RenderMathMLFenced::makeFences): (WebCore::RenderMathMLFenced::styleDidChange): Need to update the anonymous renderers for the anonymous RenderMathMLOperators.

rendering/mathml/RenderMathMLOperator.cpp: (WebCore::RenderMathMLOperator::expandedStretchHeight): Store the non-expanded stretch height so that we can detect when the height actually changed.

(WebCore::RenderMathMLOperator::stretchToHeight):
Only update the style on the anonymous render tree since this is called
from RenderMathMLRow::layout

(WebCore::RenderMathMLOperator::styleDidChange):
(WebCore::RenderMathMLOperator::glyphBoundsForCharacter): A helper to get glyph boundaries.
(WebCore::RenderMathMLOperator::glyphHeightForCharacter): Ditto for glyph width.
(WebCore::RenderMathMLOperator::advanceForCharacter): The advance is different from the width,
and we want the width of the operator to be the advance instead of the tight bounding width.
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths): Use the max of all possible glyphs
we can use to render this operator.
(WebCore::RenderMathMLOperator::computeLogicalHeight): Return the stretched operator height, if appropriate.
(WebCore::RenderMathMLOperator::updateFromElement): We add a child for rendering the non-scaled
version of the glyph.
(WebCore::RenderMathMLOperator::firstCharacterForStretching): Helper to figure out what character
is the character used for stretching operations.
(WebCore::RenderMathMLOperator::findAcceptableStretchyCharacter): Helper to find an acceptable set
of glyph pieces for stretching characters.
(WebCore::RenderMathMLOperator::updateStyle): Resize the operator to the appropriate height and hide
the child if we are using the stretchy style.
(WebCore::RenderMathMLOperator::firstLineBoxBaseline):
(WebCore::RenderMathMLOperator::paintCharacter): Helper to paint a single character component of the
stretchy glyph.
(WebCore::RenderMathMLOperator::fillWithExtensionGlyph): Helper to paint the extender glue between
features of the stretchy glyph.
(WebCore::RenderMathMLOperator::paint): Properly paint stretchy glyphs.

rendering/mathml/RenderMathMLOperator.h: Update method declarations.

LayoutTests:

2013-10-04 Frédéric Wang <fred.wang@free.fr>

[MathML] Remove RenderTree modification during layout and refactor the StretchyOp code
https://bugs.webkit.org/show_bug.cgi?id=121416

Reviewed by David Hyatt.

Add some reftests for stretchy operators.

TestExpectations: The remaining MathML pixel tests are broken by this patch.
LayoutTests/platform/gtk/TestExpectations:
LayoutTests/platform/mac/TestExpectations:
LayoutTests/platform/win/TestExpectations:
mathml/presentation/mo-minus.html: Added.
mathml/presentation/mo-minus-expected.html: Added.
mathml/presentation/mo-stacked-glyphs-expected.html: Added.
mathml/presentation/mo-stacked-glyphs.html: Added.
mathml/presentation/mo-stretchy-vertical-bar-expected-mismatch.html: Added.
mathml/presentation/mo-stretchy-vertical-bar.html: Added.
mathml/very-large-stretchy-operators-expected.txt: Added.
mathml/very-large-stretchy-operators.html: Added.

4:46 PM Changeset in webkit [158467] by commit-queue@webkit.org

6 edits
2 adds in trunk

Initial implementation of text-decoration-skip ink
https://bugs.webkit.org/show_bug.cgi?id=121806

Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-11-01
Reviewed by Darin Adler.

Source/WebCore:

text-decoration-skip: ink is implemented by the following steps:

Before drawing any decorations, figure out the bounding box for the decorations that will be drawn
Create an ImageBuffer with these dimensions
Draw text into this ImageBuffer with a thicker stroke
Apply the ImageBuffer as a mask to the context
Draw decorations like normal
Clean up

Test: fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink.html

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::computeLineBoundsAndAntialiasingModeForText): Don't call GraphicsContext::roundToDevicePixels
when painting is disabled

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint): Pass the TextPainter to paintDecoration
(WebCore::computeUnderlineOffset): Small cleanup
(WebCore::getWavyStrokeControlPointDistance): Pulling out of strokeWavyTextDecoration()
(WebCore::getWavyStrokeStep): Ditto
(WebCore::strokeWavyTextDecoration): Use the previous 2 functions
(WebCore::getSingleDecorationBoundingBox): Pulling out repeated code into a function
(WebCore::getDecorationBoundingBox): Compute the bounding box for an underline which
hasn't been drawn yet
(WebCore::InlineTextBox::paintDecoration): Construct a mask and apply it to the GraphicsContext

rendering/InlineTextBox.h: paintDecoration needs the TextPainter
rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresRepaintIfTextOrBorderOrOutline): Redraw the underline when
text-decoration-skip changes

LayoutTests:

Adding a test which draws a very large "p" with text-decoration-skip:ink. The
viewport is restricted to be just hugging the place where an underline would
intersect the descender of the "p". This should look the same as if there was
no underline at all (because of the skipping underline).

fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-expected.html: Added.
fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink.html: Added.

4:38 PM Changeset in webkit [158466] by hmuller@adobe.com

2 edits in trunk/LayoutTests

[CSS Shapes] Fix typo in simple-polygon.js LayoutTest helper
https://bugs.webkit.org/show_bug.cgi?id=123595

Reviewed by Darin Adler.

fast/shapes/resources/simple-polygon.js:

(generatePolygonContentString): Fixed a typo: the lineHeight parameter generatePolygonContentString() is now lineHeight.

4:34 PM Changeset in webkit [158465] by akling@apple.com

4 edits in trunk/Source/WebCore

CSS 'initial' and 'inherit' value constructors should return PassRef.
<https://webkit.org/b/123641>

Make the helpers involved in constructing CSS{Initial,Inherited}Value
all return PassRef instead of PassRefPtr. This avoids generating
pointless null checks at the call sites.

Reviewed by Darin Adler.

4:29 PM Changeset in webkit [158464] by Lucas Forschler

2 edits in branches/safari-537.73-branch/Source/WebCore

Merged r158334. <rdar://problem/15359442>

4:24 PM Changeset in webkit [158463] by timothy_horton@apple.com

2 edits
2 moves in trunk/Source/WebKit2

Remote Layer Tree: Move RemoteLayerBackingStore to Shared/
https://bugs.webkit.org/show_bug.cgi?id=123646

Reviewed by Darin Adler.

Move RemoteLayerBackingStore to Shared/, since it is
used on both the UI and Web process side of things.

Shared/mac/RemoteLayerBackingStore.h: Renamed from Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerBackingStore.h.
Shared/mac/RemoteLayerBackingStore.mm: Renamed from Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerBackingStore.mm.
WebKit2.xcodeproj/project.pbxproj:

4:24 PM Changeset in webkit [158462] by Lucas Forschler

2 edits in branches/safari-537.60-branch/Source/WebCore

Merged r158334. <rdar://problem/15359450>

3:22 PM Changeset in webkit [158461] by akling@apple.com

25 edits
4 deletes in trunk/Source/WebCore

Kill RenderArena.
<https://webkit.org/b/123634>

There are no remaining users of the RenderArena allocator.

Reviewed by Geoffrey Garen.

3:14 PM Changeset in webkit [158460] by mitz@apple.com

2 edits in trunk/Source/WebKit2

[Cocoa] WKObject seems to be initializing its target in a thread-safe manner, but really is not
https://bugs.webkit.org/show_bug.cgi?id=123640

Reviewed by Darin Adler.

Shared/Cocoa/WKObject.mm:

(initializeTargetIfNeeded): Removed misleading incorrect code.

3:10 PM Changeset in webkit [158459] by fpizlo@apple.com

8 edits in trunk/Source/JavaScriptCore

OSR exit profiling should be robust against all code being cleared
https://bugs.webkit.org/show_bug.cgi?id=123629
<rdar://problem/15365476>

Reviewed by Michael Saboff.

The problem here is two-fold:

1) A watchpoint (i.e. ProfiledCodeBlockJettisoningWatchpoint) may be fired after we
have cleared the CodeBlock for all or some Executables. This means that doing
codeBlock->baselineVersion() would either crash or return a bogus CodeBlock, since
there wasn't a baseline code block reachable from the Executable anymore. The
solution is that we shouldn't be asking for the baseline code block reachable from
the owning executable (what baselineVersion did), but instead we should be asking
for the baseline version reachable from the code block being watchpointed (basically
what CodeBlock::alternative() did).

2) If dealing with inlined code, baselienCodeBlockForOriginAndBaselineCodeBlock()
may return null, for the same reason as above - we might have cleared the baseline
codeblock for the executable that was inlined. The solution is to just not do
profiling if there isn't a baseline code block anymore.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::baselineAlternative):
(JSC::CodeBlock::baselineVersion):
(JSC::CodeBlock::jettison):

bytecode/CodeBlock.h:
bytecode/CodeBlockJettisoningWatchpoint.cpp:

(JSC::CodeBlockJettisoningWatchpoint::fireInternal):

bytecode/ProfiledCodeBlockJettisoningWatchpoint.cpp:

(JSC::ProfiledCodeBlockJettisoningWatchpoint::fireInternal):

dfg/DFGOSRExitBase.cpp:

(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSiteSlow):

jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::AssemblyHelpers):

runtime/Executable.cpp:

(JSC::FunctionExecutable::baselineCodeBlockFor):

2:29 PM Changeset in webkit [158458] by aestes@apple.com

2 edits in trunk/Tools

Teach check-for-webkit-framework-include-consistency to ignore stale iOS Private headers that might exist in build directories due to r158443
https://bugs.webkit.org/show_bug.cgi?id=123636

Reviewed by Andreas Kling.

Scripts/check-for-webkit-framework-include-consistency:

2:28 PM Changeset in webkit [158457] by benjamin@webkit.org

2 edits in trunk/Source/WebKit2

[WK2] Create a unique identifier for WebPageGroup if the input name is empty
https://bugs.webkit.org/show_bug.cgi?id=123606

Reviewed by Andreas Kling.

Strengthen the "public" API of page group.
If someone uses WKBrowsingContextGroup with a nil or empty string, the related WKString
would be empty, and all the WKBrowsingContextGroup end up with the same identifier.

UIProcess/WebPageGroup.cpp:

(WebKit::WebPageGroup::WebPageGroup):

2:26 PM Changeset in webkit [158456] by mitz@apple.com

2 edits
2 moves in trunk/Source/WebKit2

[Cocoa] Avoid some double-wrapping of strings and URLs
https://bugs.webkit.org/show_bug.cgi?id=123632

Reviewed by Anders Carlsson.

Shared/API/c/cf/WKStringCF.cpp: Removed.
Shared/API/c/cf/WKStringCF.mm: Copied from Source/WebKit2/Shared/API/c/cf/WKStringCF.cpp.

(wkNSStringClass): Added this helper.
(WKStringCreateWithCFString): If the passed-in CFString is already wrapping a WebString,
then retain it and return it.

Shared/API/c/cf/WKURLCF.cpp: Removed.
Shared/API/c/cf/WKURLCF.mm: Copied from Source/WebKit2/Shared/API/c/cf/WKURLCF.cpp.

(wkNSURLClass): Added this helper.
(WKURLCreateWithCFURL): If the passed-in CFURL is already wrapping a WebURL, then retain it
and return it.

WebKit2.xcodeproj/project.pbxproj: Updated for renames.

2:23 PM Changeset in webkit [158455] by commit-queue@webkit.org

5 edits in trunk

AX: Regression: media controls are no longer accessible
https://bugs.webkit.org/show_bug.cgi?id=121990

Patch by James Craig <jcraig@apple.com> on 2013-11-01
Reviewed by Jer Noble.

Source/WebCore:

Updated existing test coverage.
Added ARIA roles, attrs, and labels to the new media controls shadow DOM.
Localization will be handled in http://webkit.org/b/120956

Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.UIString):
(Controller.prototype.createControls):
(Controller.prototype.handleLoadStart):
(Controller.prototype.handleError):
(Controller.prototype.handleAbort):
(Controller.prototype.handleSuspend):
(Controller.prototype.handleStalled):
(Controller.prototype.handleWaiting):
(Controller.prototype.handleFullscreenChange):
(Controller.prototype.handleMuteButtonClicked):
(Controller.prototype.handleMinButtonClicked):
(Controller.prototype.handleMaxButtonClicked):
(Controller.prototype.handleVolumeSliderChange):
(Controller.prototype.updatePlaying):

LayoutTests:

Removed failure expectation and updated expected render dump output.

platform/mac/TestExpectations:
platform/mac/accessibility/media-element-expected.txt:

2:06 PM Changeset in webkit [158454] by aestes@apple.com

4 edits in trunk/Source/WebKit

[iOS] Make some headers Private
https://bugs.webkit.org/show_bug.cgi?id=123626

Reviewed by Andreas Kling.

Source/WebKit:

WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Configurations/WebKit.xcconfig: Exclude iOS Private headers from the Mac build.

2:04 PM Changeset in webkit [158453] by akling@apple.com

7 edits in trunk/Source/WebCore

Take BidiRuns out of the arena.
<https://webkit.org/b/123630>

Stop arena-allocating BidiRun objects and use regular new/delete.

With this, there are no remaining clients of RenderArena.
It will be removed in a subsequent patch.

Reviewed by Anders Carlsson.

2:00 PM Changeset in webkit [158452] by andersca@apple.com

7 edits in trunk

Begin work on encoding argument types
https://bugs.webkit.org/show_bug.cgi?id=123631

Reviewed by Dan Bernstein.

Source/WebKit2:

Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(-[WKRemoteObjectEncoder _encodeInvocation:forKey:]):
Encode argument types in an array.

(-[WKRemoteObjectEncoder _encodedObjectUsingBlock:]):
Add new helper method that encodes an object and returns the dictionary.

(-[WKRemoteObjectEncoder _encodeObjectForKey:usingBlock:]):
Implement this in terms of _encodedObjectUsingBlock:.

Shared/MutableArray.cpp:

(WebKit::MutableArray::append):

Shared/MutableArray.h:

Change append to take a PassRefPtr.

Tools:

Add another test method.

TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h:

1:42 PM Changeset in webkit [158451] by barraclough@apple.com

9 edits in trunk/Source/WebKit2

Rename InWindowState -> ViewState
https://bugs.webkit.org/show_bug.cgi?id=123584

Rubber stamped by Sam Weinig.

WebPageProxy::setViewState offers the option to wait for a reply. Previously this option
was only available via setIsInWindow, hence the mechanism to wait to the update has
'InWindowState' in method and variable names (i.e.
'WebPageProxy::waitForDidUpdateInWindowState'). Since the mechanism is now applicable to
all ViewState changes, rename to reflect this.

UIProcess/API/mac/WKView.mm:

(-[WKView endDeferringViewInWindowChangesSync]):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::waitForDidUpdateViewState):
(WebKit::WebPageProxy::resetStateAfterProcessExited):

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::didUpdateViewState):

UIProcess/WebPageProxy.messages.in:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::didUpdateViewStateTimerFired):
(WebKit::WebPage::setViewState):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::didUpdateViewStateTimerFired):

1:15 PM Changeset in webkit [158450] by commit-queue@webkit.org

21 edits in trunk

Expose setApplicationCacheOriginQuota via window.internals
https://bugs.webkit.org/show_bug.cgi?id=87838

Patch by Afonso R. Costa Jr. <afonso.costa@samsung.com> on 2013-11-01
Reviewed by Joseph Pecoraro.

Source/WebCore:

Also reset the default origin quota in resetToConsistentState().

testing/Internals.cpp: Add setApplicationCacheOriginQuota.

(WebCore::Internals::resetToConsistentState): Reset the default origin
quota.
(WebCore::Internals::setApplicationCacheOriginQuota): Added.

testing/Internals.h: Add setApplicationCacheOriginQuota.
testing/Internals.idl: Ditto.

Source/WebKit:

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add

symbols for setApplicationCacheOriginQuota from Internals.

Tools:

DumpRenderTree/TestRunner.cpp: Move setApplicationCacheOriginQuota

to window.internals
(TestRunner::staticFunctions):

DumpRenderTree/TestRunner.h: Ditto.
DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setApplicationCacheOriginQuota.
DumpRenderTree/efl/TestRunnerEfl.cpp: Ditto.
DumpRenderTree/gtk/TestRunnerGtk.cpp: Ditto.
DumpRenderTree/mac/TestRunnerMac.mm: Ditto.
DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Ditto.
WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.

LayoutTests:

http/tests/appcache/origin-quota-continued-download-multiple-manifests.html: Updated

to use setApplicationCacheOriginQuota from window.internals

http/tests/appcache/origin-quota-continued-download.html: Ditto.
http/tests/appcache/origin-quota.html: Ditto.

12:46 PM Changeset in webkit [158449] by timothy_horton@apple.com

3 edits in trunk/Source/WebKit2

Remote Layer Tree: Vend layer contents via IOSurfaces
https://bugs.webkit.org/show_bug.cgi?id=123600

Reviewed by Anders Carlsson.

Address some review comments from Darin (and subsequently Anders).

WebProcess/WebPage/mac/RemoteLayerBackingStore.h:

(WebKit::RemoteLayerBackingStore::surface):
No need for .get() here.

WebProcess/WebPage/mac/RemoteLayerBackingStore.mm:

(RemoteLayerBackingStore::ensureBackingStore):
All on one line for readability.

(createIOSurfaceContext):
This 'if' is meaningless.

(createIOSurface):
No need for a RetainPtr here, the dictionary is autoreleased.

(RemoteLayerBackingStore::display):
Snuggle 'context' up next to the other declarations.

12:35 PM Changeset in webkit [158448] by andersca@apple.com

5 edits in trunk/Source/WebKit2

Don't use the C API in WKRemoteObjectCoder
https://bugs.webkit.org/show_bug.cgi?id=123627

Reviewed by Dan Bernstein.

Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(-[WKRemoteObjectEncoder init]):
(-[WKRemoteObjectEncoder encodeBytes:length:forKey:]):
(-[WKRemoteObjectEncoder _encodeObjectForKey:usingBlock:]):

Shared/ImmutableDictionary.h:
Shared/MutableDictionary.cpp:

(WebKit::MutableDictionary::add):
(WebKit::MutableDictionary::set):

Shared/MutableDictionary.h:

12:18 PM Changeset in webkit [158447] by mark.lam@apple.com

16 edits in trunk

REGRESSION: Crashes in -[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:].
https://bugs.webkit.org/show_bug.cgi?id=123383.

Reviewed by Geoffrey Garen.

Tools:

Removed an inappropriate assertion in DumpRenderTree/mac/UIDelegate.mm and
added 2 attributes (databaseDefaultQuota and databaseMaxQuota) to allow
tests to set appropriate quota settings to exercise quota expansion tests
when needed.

DumpRenderTree/TestRunner.cpp:

(TestRunner::TestRunner):
(getDatabaseDefaultQuotaCallback):
(getDatabaseMaxQuotaCallback):
(setDatabaseDefaultQuotaCallback):
(setDatabaseMaxQuotaCallback):
(TestRunner::staticValues):

DumpRenderTree/TestRunner.h:

(TestRunner::databaseDefaultQuota):
(TestRunner::setDatabaseDefaultQuota):
(TestRunner::databaseMaxQuota):
(TestRunner::setDatabaseMaxQuota):

DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::exceededDatabaseQuota):

DumpRenderTree/efl/DumpRenderTreeView.cpp:

(onExceededDatabaseQuota):

DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):

DumpRenderTree/win/UIDelegate.cpp:

(UIDelegate::exceededDatabaseQuota):

WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didExceedDatabaseQuota):

WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::TestRunner):

WebKitTestRunner/InjectedBundle/TestRunner.h:

(WTR::TestRunner::databaseDefaultQuota):
(WTR::TestRunner::setDatabaseDefaultQuota):
(WTR::TestRunner::databaseMaxQuota):
(WTR::TestRunner::setDatabaseMaxQuota):

WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
(WTR::TestController::createWebViewWithOptions):

LayoutTests:

storage/websql/open-database-expand-quota.html:
Set databaseDefaultQuota and databaseMaxQuota as needed for this test.
storage/websql/open-database-over-quota-expected.txt:
storage/websql/open-database-over-quota.html:
Revert the change from r157874 which is no longer needed for this test.

12:10 PM Changeset in webkit [158446] by aestes@apple.com

2 edits in trunk/Source/WebKit

Reverted r158443. It broke the build.

WebKit.xcodeproj/project.pbxproj:

11:59 AM Changeset in webkit [158445] by commit-queue@webkit.org

3 edits in trunk/Source/WTF

HPPA build fixes
https://bugs.webkit.org/show_bug.cgi?id=123625

Original patch from John David Anglin <dave.anglin@bell.net>

Patch by Emilio Pozuelo Monfort <pochu27@gmail.com> on 2013-11-01
Reviewed by Darin Adler.

wtf/Platform.h:
wtf/dtoa/utils.h:

11:48 AM Changeset in webkit [158444] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

Fix build on non-linux platforms
https://bugs.webkit.org/show_bug.cgi?id=123622

Patch by Emilio Pozuelo Monfort <pochu27@gmail.com> on 2013-11-01
Reviewed by Darin Adler.

UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

11:37 AM Changeset in webkit [158443] by aestes@apple.com

2 edits in trunk/Source/WebKit

[iOS] Make some headers Private
https://bugs.webkit.org/show_bug.cgi?id=123626

Reviewed by Sam Weinig.

WebKit.xcodeproj/project.pbxproj:

11:30 AM Changeset in webkit [158442] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Explicitly initialize RefCounted base class in MediaStreamTrack's constructors
https://bugs.webkit.org/show_bug.cgi?id=123620

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-01
Reviewed by Andreas Kling.

No new tests needed.

Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::MediaStreamTrack):

11:17 AM Changeset in webkit [158441] by Bem Jones-Bey

54 edits in trunk/LayoutTests

[css shapes] Pull in upstream fixes to shape-outside margin and clipping tests
https://bugs.webkit.org/show_bug.cgi?id=123588

Reviewed by Alexandru Chiculita.

Fix some typos in the tests, add better explanation, and generally
make the tests clearer.

csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001-expected.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003-expected.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-004.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-005.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-006.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-000-expected.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-001-expected.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-002-expected.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-002.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-003-expected.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-003.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-004-expected.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-004.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-005-expected.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-005.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-006-expected.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-006.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-007-expected.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-007.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-008-expected.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-008.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-009-expected.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-009.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-010-expected.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-010.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-011-expected.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-011.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-012-expected.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-012.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-013-expected.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-013.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-014-expected.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-014.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-015-expected.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-015.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-016-expected.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-016.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-017-expected.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-017.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-018-expected.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-018.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-019-expected.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-019.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-020-expected.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-020.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-021-expected.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-021.html:
csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:

11:13 AM Changeset in webkit [158440] by Antoine Quint

2 edits in trunk/Source/WebInspectorUI

Remove custom Function.prototype.bind() in favor of native version
https://bugs.webkit.org/show_bug.cgi?id=123608

Reviewed by Joseph Pecoraro.

UserInterface/Utilities.js:

11:06 AM Changeset in webkit [158439] by Antoine Quint

2 edits in trunk/Source/WebInspectorUI

Error trying to serialize a color created without an alpha component to RGBA or HSLA
https://bugs.webkit.org/show_bug.cgi?id=123623

Reviewed by Joseph Pecoraro.

Check whether we have .rgba and .hsla ivars before trying to retrieve them to serialize
the color to RGBA or HSLA format.

UserInterface/Color.js:

(WebInspector.Color.prototype.toString):

11:03 AM Changeset in webkit [158438] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

Adding addRemoteTrack and removeRemoteTrack functions to MediaStreamDescriptor and MediaStream
https://bugs.webkit.org/show_bug.cgi?id=123477

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-01
Reviewed by Eric Carlson.

When the backend report that a remote track has been added or removed by a remote peer, we must be able to add
it to its MediaStream

No new tests needed.

Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::addTrack): Splitted in two parts that can be used by old addTrack and new addRemoteTrack.
(WebCore::MediaStream::removeTrack): Splitted in two parts that can be used by old removeTrack and new
removeRemoteTrack.
(WebCore::MediaStream::addRemoteSource): Reusing code in new addTrack method.
(WebCore::MediaStream::removeRemoteSource): Refactored.
(WebCore::MediaStream::addRemoteTrack): Added.
(WebCore::MediaStream::removeRemoteTrack): Added.
(WebCore::MediaStream::getTrackVectorForType): Helper method that returns a vector of tracks according to
track's type (Audio or Video).

Modules/mediastream/MediaStream.h:
Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::MediaStreamTrack):

platform/mediastream/MediaStreamDescriptor.cpp:

(WebCore::MediaStreamDescriptor::addRemoteTrack): Added.
(WebCore::MediaStreamDescriptor::removeRemoteTrack): Added.

platform/mediastream/MediaStreamDescriptor.h:

10:44 AM Changeset in webkit [158437] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[GTK] [WK2] Crash in webkitWebViewLoadFailedWithTLSErrors
https://bugs.webkit.org/show_bug.cgi?id=123618

Patch by Brian Holt <brian.holt@samsung.com> on 2013-11-01
Reviewed by Mario Sanchez Prada.

The GOwnPtrSoup header was not included which meant that the
specialization for GOwnPtr<SoupURI> was not used and instead the
default freeOwnedGPtr which calls g_free is used and crashes.

UIProcess/API/gtk/WebKitWebView.cpp:

9:30 AM Changeset in webkit [158436] by commit-queue@webkit.org

30 edits
6 copies
1 move
19 adds in trunk

[GStreamer] Support audio and video tracks
https://bugs.webkit.org/show_bug.cgi?id=117039

Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-01
Reviewed by Philippe Normand.

Source/WebCore:

Tests: media/track/audio/audio-track-mkv-vorbis-addtrack.html

media/track/audio/audio-track-mkv-vorbis-enabled.html
media/track/audio/audio-track-mkv-vorbis-language.html
media/track/in-band/track-in-band-kate-ogg-addtrack.html
media/track/in-band/track-in-band-srt-mkv-addtrack.html
media/track/video/video-track-mkv-theora-addtrack.html
media/track/video/video-track-mkv-theora-language.html
media/track/video/video-track-mkv-theora-selected.html

GNUmakefile.list.am: Add audio and video track files.
PlatformEfl.cmake: Same.
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::audioTrackEnabledChanged): Schedule "change" event.
(WebCore::HTMLMediaElement::videoTrackSelectedChanged): Same.

html/track/AudioTrack.cpp:

(WebCore::AudioTrack::setEnabled): Call m_private->setEnabled
(WebCore::AudioTrack::enabledChanged): Added callback.
(WebCore::AudioTrack::labelChanged): Same.
(WebCore::AudioTrack::languageChanged): Same.
(WebCore::AudioTrack::willRemoveAudioTrackPrivate): Use ASSERT_UNUSED for consistence.

html/track/AudioTrack.h: Add new enabled, label and language callbacks.
html/track/VideoTrack.cpp:

(WebCore::VideoTrack::setSelected): Call m_private->setEnabled
(WebCore::VideoTrack::selectedChanged): Added callback.
(WebCore::VideoTrack::labelChanged): Same.
(WebCore::VideoTrack::languageChanged): Same.
(WebCore::VideoTrack::willRemoveVideoTrackPrivate): Use ASSERT_UNUSED for consistence.

html/track/VideoTrack.h: Add new selected, label and language callbacks.
platform/graphics/AudioTrackPrivate.h:

(WebCore::AudioTrackPrivate::setEnabled): Call m_client->enabledChanged

platform/graphics/VideoTrackPrivate.h:

(WebCore::VideoTrackPrivate::setSelected): Call m_client->selectedChanged

platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:

(WebCore::InbandTextTrackPrivateGStreamer::InbandTextTrackPrivateGStreamer): Add ASSERT(m_pad)
(WebCore::InbandTextTrackPrivateGStreamer::notifyTrackOfTagsChanged): Look at all tag events instead of just the first one.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::mediaPlayerPrivateVideoSinkCapsChangedCallback): Separated callback when caps change from callback when number of videos change.
(WebCore::mediaPlayerPrivateVideoCapsChangeTimeoutCallback): Same.
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer): Initialize m_videoCapsTimerHandler.
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer): Disconnect audio and video tracks and remove callbacks.
(WebCore::MediaPlayerPrivateGStreamer::videoCapsChanged): Separated callback when caps change from callback when number of videos change.
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo): Create video tracks for each stream.
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideoCaps): Separated callback when caps change from callback when number of videos change.
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio): Create audio tracks for each stream.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Add audio and video tracks, and a pointer to keep track of the default audio stream.
platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp: Added.
platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h: Added.
platform/graphics/gstreamer/GRefPtrGStreamer.cpp: Add GRefPtr<GstTagList>
platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp: Added, handles tags and "active" property of audio and video tracks.
platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h: Added.
platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp: Added.
platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h: Added.

LayoutTests:

media/content/two-audio-and-video-tracks.mkv: Added.
media/in-band-tracks.js: Renamed from LayoutTests/media/in-band-cues.js.

(testAddTrack): Tests addtrack events.
(testAttribute): Added "type" parameter so we can use this for audio and video tracks.
(testTextTrackMode): Renamed to make it clear that this only applies to text tracks.
(testCueStyle): Same.
(testTextTrackOrder): Same.

media/track/audio/audio-track-mkv-vorbis-addtrack-expected.txt: Added.
media/track/audio/audio-track-mkv-vorbis-addtrack.html: Copied from LayoutTests/media/track/in-band/track-in-band-srt-mkv-track-order.html.
media/track/audio/audio-track-mkv-vorbis-enabled-expected.txt: Added.
media/track/audio/audio-track-mkv-vorbis-enabled.html: Added.
media/track/audio/audio-track-mkv-vorbis-language-expected.txt: Added.
media/track/audio/audio-track-mkv-vorbis-language.html: Copied from LayoutTests/media/track/in-band/track-in-band-kate-ogg-track-order.html.
media/track/in-band/track-in-band-kate-ogg-addtrack-expected.txt: Added.
media/track/in-band/track-in-band-kate-ogg-addtrack.html: Copied from LayoutTests/media/track/in-band/track-in-band-srt-mkv-track-order.html.
media/track/in-band/track-in-band-kate-ogg-cues-added-once.html: Added.
media/track/in-band/track-in-band-kate-ogg-kind.html: Added.
media/track/in-band/track-in-band-kate-ogg-language.html: Added.
media/track/in-band/track-in-band-kate-ogg-mode.html: Added.
media/track/in-band/track-in-band-kate-ogg-style.html: Added.
media/track/in-band/track-in-band-kate-ogg-track-order.html: Added.
media/track/in-band/track-in-band-srt-mkv-addtrack-expected.txt: Added.
media/track/in-band/track-in-band-srt-mkv-addtrack.html: Copied from LayoutTests/media/track/in-band/track-in-band-srt-mkv-track-order.html.
media/track/in-band/track-in-band-srt-mkv-cues-added-once.html: Added.
media/track/in-band/track-in-band-srt-mkv-kind.html: Added.
media/track/in-band/track-in-band-srt-mkv-language.html: Added.
media/track/in-band/track-in-band-srt-mkv-mode.html: Added.
media/track/in-band/track-in-band-srt-mkv-style.html: Added.
media/track/in-band/track-in-band-srt-mkv-track-order.html: Added.
media/track/video/video-track-mkv-theora-addtrack-expected.txt: Added.
media/track/video/video-track-mkv-theora-addtrack.html: Copied from LayoutTests/media/track/in-band/track-in-band-srt-mkv-track-order.html.
media/track/video/video-track-mkv-theora-language-expected.txt: Added.
media/track/video/video-track-mkv-theora-language.html: Copied from LayoutTests/media/track/in-band/track-in-band-kate-ogg-track-order.html.
media/track/video/video-track-mkv-theora-selected-expected.txt: Added.
media/track/video/video-track-mkv-theora-selected.html: Added.
platform/mac/TestExpectations: Ignore audio and video track tests on mac.

7:40 AM Changeset in webkit [158435] by Antoine Quint

2 edits in trunk/Source/WebInspectorUI

Remove custom Element.prototype.remove() in favor of native version
https://bugs.webkit.org/show_bug.cgi?id=123607

Reviewed by Timothy Hatcher.

UserInterface/Utilities.js:

7:09 AM Changeset in webkit [158434] by Patrick Gansterer

3 edits in trunk/Source/WebKit/win

[WIN] Reduce usage of CFSTR() in WebPreferences
https://bugs.webkit.org/show_bug.cgi?id=121827

Reviewed by Brent Fulgham.

This moved the dependency on CF to a few functions only
and is a first step to make it compile without CF.

WebPreferences.cpp:
WebPreferences.h:

6:57 AM Changeset in webkit [158433] by Patrick Gansterer

2 edits in trunk/Source/WTF

Buildfix for !USE(ICU_UNICODE) after 156968.

wtf/unicode/CollatorDefault.cpp:

(WTF::Collator::userDefault):

5:48 AM Changeset in webkit [158432] by Patrick Gansterer

2 edits in trunk/Source/WebCore

Buildfix for !ENABLE(INSPECTOR) after 157288.

inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::willDispatchEvent):

5:43 AM Changeset in webkit [158431] by gyuyoung.kim@samsung.com

2 edits in trunk/LayoutTests

Unreviewed, EFL gardening. Skip webgl tests because EFL port doesn't fully support webgl yet.

platform/efl/TestExpectations:

5:09 AM Changeset in webkit [158430] by gyuyoung.kim@samsung.com

2 edits in trunk/LayoutTests

Unreviewed, EFL gardening. css3 text tests are failing since r158389

platform/efl/TestExpectations: Add failure tests.

4:54 AM Changeset in webkit [158429] by mario@webkit.org

3 edits in trunk/LayoutTests

Unreviewed GTK gardening. Tests passing after r158273 and r158352
and rebaseline needed after r158195.

platform/gtk/TestExpectations: Removed tests now passing.
platform/gtk/accessibility/media-element-expected.txt: Rebaseline.

3:59 AM Changeset in webkit [158428] by mario@webkit.org

13 edits in trunk

[ATK] Avoid explicit traversal of text controls and the render tree in AtkText implementation
https://bugs.webkit.org/show_bug.cgi?id=123153

Reviewed by Chris Fleizach.

Source/WebCore:

Remove functions from the AtkText implementation that manually
walk the render tree to compose the text for a exposed objects in
certain cases (e.g. anonymous blocks, text controls).

The reason for this change is that the current implementation
follows an error-prone approach, since by doing things like
manually walking the render tree from here we are not properly
considering all the possible scenarios that might happen when
traversing text. This, however, is a task that is better suited
for the TextIterator, which is already written to consider all
those cases and to emit the proper character in every single
situation: text nodes, replaced objects and so on.

So, by removing all that too specific code (textForObject() and
textForRenderer() mainly) from WebKitAccessibleInterfaceText.cpp
and relying in AccessibilityObject::textUnderElement(), which it
ends up using the TextIterator for certain cases, we have a much
better and robust method of retrieving the text associated with an
instance of AtkObject implementing the AtkText interface.

accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(webkitAccessibleTextGetText): Removed call to textForObject(), now that
we have just removed that function, together with textForRenderer().

Make AccessibilityRenderObject::textUnderElement() able to deal with
anonymous blocks directly, by creating a range based in the boundaries
defined by the first and last child renderers for that block. This will
make possible to treat an anonymous block as a whole instead of having
to rely in the concatenation of each of its children, as it does now.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textUnderElement): Added a new code
path to deal with anonymous blocks for text renderers, or when including
all the children is explicitly requested.

Modified TextIterator so text for children of replaced objects are
ignored if we are emmiting the special character for those objects.

editing/TextIterator.cpp:

(WebCore::TextIterator::handleReplacedElement): Make sure no children are
handled a replaced object if m_emitsObjectReplacementCharacters is set.

editing/TextIterator.h: Updated m_emitsObjectReplacementCharacters

description to reflect the new behavior.

LayoutTests:

Updated test expectations to properly reflect the new reality when it
comes to exposing replaced objects and anymous blocks.

platform/gtk/accessibility/table-with-rules-expected.txt: Updated to

print <\n> explicitly for the two instances of <BR> that are present in the
test, that will be included as part of an anonymous block.

platform/efl/accessibility/table-with-rules-expected.txt: Ditto.
platform/efl-wk2/accessibility/table-with-rules-expected.txt: Ditto.

platform/efl/accessibility/deleting-iframe-destroys-axcache-expected.txt: Updated

expectations not to expect the text of a button to be shown.

platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt: Ditto.
platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt: Ditto.

platform/gtk/TestExpectations: Removed replaced-objects-in-anonymous-blocks.html

from the list of expected failures, as it's now being properly exposed.

12:15 AM Changeset in webkit [158427] by ap@apple.com

6 edits
4 copies
4 adds in trunk

Add a Mac WebCrypto implementation of HMAC importKey/sign/verify
https://bugs.webkit.org/show_bug.cgi?id=123598

Reviewed by Anders Carlsson.

Source/WebCore:

Test: crypto/subtle/hmac-sign-verify.html

WebCore.xcodeproj/project.pbxproj:
bindings/js/JSSubtleCryptoCustom.cpp: Added property svn:eol-style.

(WebCore::createAlgorithmFromJSValue):
(WebCore::cryptoOperationDataFromJSValue):
(WebCore::cryptoKeyFormatFromJSValue):
(WebCore::cryptoKeyUsagesFromJSValue):
(WebCore::JSSubtleCrypto::sign):
(WebCore::JSSubtleCrypto::verify):
(WebCore::JSSubtleCrypto::digest):
(WebCore::JSSubtleCrypto::importKey):

crypto/SubtleCrypto.idl:
crypto/algorithms/CryptoAlgorithmHMAC.cpp: Added.

(WebCore::CryptoAlgorithmHMAC::CryptoAlgorithmHMAC):
(WebCore::CryptoAlgorithmHMAC::~CryptoAlgorithmHMAC):
(WebCore::CryptoAlgorithmHMAC::create):
(WebCore::CryptoAlgorithmHMAC::identifier):
(WebCore::CryptoAlgorithmHMAC::importKey):
(WebCore::CryptoAlgorithmHMAC::exportKey):

crypto/algorithms/CryptoAlgorithmHMAC.h: Added.
crypto/keys: Added.
crypto/keys/CryptoKeyHMAC.cpp: Added.

(WebCore::CryptoKeyHMAC::CryptoKeyHMAC):
(WebCore::CryptoKeyHMAC::~CryptoKeyHMAC):
(WebCore::CryptoKeyHMAC::buildAlgorithmDescription):

crypto/keys/CryptoKeyHMAC.h: Added.
crypto/mac/CryptoAlgorithmHMACMac.cpp: Added.

(WebCore::getCommonCryptoAlgorithm):
(WebCore::calculateSignature):
(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):
(WebCore::CryptoAlgorithmHMAC::generateKey):

crypto/mac/CryptoAlgorithmRegistryMac.cpp:

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):

LayoutTests:

crypto/subtle/hmac-sign-verify-expected.txt: Added.
crypto/subtle/hmac-sign-verify.html: Added.

12:15 AM Changeset in webkit [158426] by ryuan.choi@samsung.com

2 edits in trunk/Source/WebKit/efl

[EFL][WK1] Rendering is broken when scrolled ewk_view_single repeatedly
https://bugs.webkit.org/show_bug.cgi?id=123609

Reviewed by Gyuyoung Kim.

ewk_view_single adds wrong updateRects except last one in scrolls_process,
because previous updateRects are not considered accumulated scrollOffsets.

ewk/ewk_view_single.cpp:

(_ewk_view_single_smart_scrolls_process):
Merged scrollOffsets to calculate updateRects once.
It will also reduce unnecessary memory copy operations.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed