Timeline
Nov 4, 2013:
- 11:55 PM Changeset in webkit [158654] by
-
- 21 edits2 copies4 adds in trunk/Source
IDB: Split backend Cursors and Transactions into their own files
https://bugs.webkit.org/show_bug.cgi?id=123789
Reviewed by Alexey Proskuryakov.
Source/WebCore:
No new tests (Rename, no change in behavior).
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IDBBackingStoreCursorInterface.h:
(WebCore::IDBBackingStoreCursorInterface::~IDBBackingStoreCursorInterface):
- Modules/indexeddb/IDBBackingStoreInterface.h:
- Modules/indexeddb/IDBBackingStoreTransactionInterface.h: Added.
(WebCore::IDBBackingStoreTransactionInterface::~IDBBackingStoreTransactionInterface):
- Modules/indexeddb/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
- Modules/indexeddb/IDBCursorBackendImpl.h:
(WebCore::IDBCursorBackendImpl::create):
- Modules/indexeddb/IDBFactoryBackendInterface.h:
- Modules/indexeddb/IDBIndexWriter.cpp:
(WebCore::IDBIndexWriter::writeIndexKeys):
(WebCore::IDBIndexWriter::verifyIndexKeys):
(WebCore::IDBIndexWriter::addingKeyAllowed):
- Modules/indexeddb/IDBIndexWriter.h:
- Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::createCursorBackend):
- Modules/indexeddb/IDBTransactionBackendImpl.h:
- Modules/indexeddb/IDBTransactionBackendInterface.h:
- Modules/indexeddb/IDBTransactionBackendOperations.cpp:
(WebCore::GetOperation::perform):
(WebCore::OpenCursorOperation::perform):
(WebCore::CountOperation::perform):
(WebCore::DeleteRangeOperation::perform):
- Modules/indexeddb/leveldb/IDBBackingStoreCursorLevelDB.cpp: Added.
(WebCore::IDBBackingStoreCursorLevelDB::IDBBackingStoreCursorLevelDB):
(WebCore::IDBBackingStoreCursorLevelDB::firstSeek):
(WebCore::IDBBackingStoreCursorLevelDB::advance):
(WebCore::IDBBackingStoreCursorLevelDB::continueFunction):
(WebCore::IDBBackingStoreCursorLevelDB::haveEnteredRange):
(WebCore::IDBBackingStoreCursorLevelDB::isPastBounds):
- Modules/indexeddb/leveldb/IDBBackingStoreCursorLevelDB.h: Added.
(WebCore::IDBBackingStoreCursorLevelDB::~IDBBackingStoreCursorLevelDB):
(WebCore::IDBBackingStoreCursorLevelDB::IDBBackingStoreCursorLevelDB):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::compareIndexKeys):
(WebCore::IDBBackingStoreLevelDB::updateIDBDatabaseVersion):
(WebCore::IDBBackingStoreLevelDB::createObjectStore):
(WebCore::IDBBackingStoreLevelDB::deleteObjectStore):
(WebCore::IDBBackingStoreLevelDB::getRecord):
(WebCore::IDBBackingStoreLevelDB::putRecord):
(WebCore::IDBBackingStoreLevelDB::clearObjectStore):
(WebCore::IDBBackingStoreLevelDB::deleteRecord):
(WebCore::IDBBackingStoreLevelDB::getKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStoreLevelDB::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStoreLevelDB::keyExistsInObjectStore):
(WebCore::IDBBackingStoreLevelDB::createIndex):
(WebCore::IDBBackingStoreLevelDB::deleteIndex):
(WebCore::IDBBackingStoreLevelDB::putIndexDataForRecord):
(WebCore::findGreatestKeyLessThanOrEqual):
(WebCore::IDBBackingStoreLevelDB::findKeyInIndex):
(WebCore::IDBBackingStoreLevelDB::getPrimaryKeyViaIndex):
(WebCore::IDBBackingStoreLevelDB::keyExistsInIndex):
(WebCore::ObjectStoreKeyCursorImpl::create):
(WebCore::ObjectStoreKeyCursorImpl::clone):
(WebCore::ObjectStoreKeyCursorImpl::ObjectStoreKeyCursorImpl):
(WebCore::ObjectStoreCursorImpl::create):
(WebCore::ObjectStoreCursorImpl::clone):
(WebCore::ObjectStoreCursorImpl::ObjectStoreCursorImpl):
(WebCore::objectStoreCursorOptions):
(WebCore::indexCursorOptions):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreCursor):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexCursor):
(WebCore::IDBBackingStoreLevelDB::createBackingStoreTransaction):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
- Modules/indexeddb/leveldb/IDBBackingStoreTransactionLevelDB.cpp: Added.
(WebCore::IDBBackingStoreTransactionLevelDB::IDBBackingStoreTransactionLevelDB):
(WebCore::IDBBackingStoreTransactionLevelDB::begin):
(WebCore::IDBBackingStoreTransactionLevelDB::commit):
(WebCore::IDBBackingStoreTransactionLevelDB::rollback):
- Modules/indexeddb/leveldb/IDBBackingStoreTransactionLevelDB.h:
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
(WebCore::IDBFactoryBackendLevelDB::createCursorBackend):
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:
Source/WebKit2:
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
(WebKit::WebIDBFactoryBackend::createCursorBackend):
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
- 11:09 PM Changeset in webkit [158653] by
-
- 2 edits in trunk/Source/JavaScriptCore
internal-js-tests.yaml/Octane/stress-tests/pdfjs.js.default: ASSERTION FAILED: m_state.forNode(child).m_futurePossibleStructure.isSubsetOf(StructureSet(structure)) at DFGConstantFoldingPhase.cpp:249
https://bugs.webkit.org/show_bug.cgi?id=123778
Unreviewed, remove the other such assertion.
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- 11:05 PM Changeset in webkit [158652] by
-
- 7 edits in trunk
DumpRenderTree should reset its preferences file on launch
https://bugs.webkit.org/show_bug.cgi?id=29751
Reviewed by Dan Bernstein.
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView _retrieveKeyboardUIModeFromPreferences:]):
Further fix reading of AppleKeyboardUIMode - reading it from kCFPreferencesAnyApplication
domain meant that current application's domain was explcitly ignored, and the only
way to override the setting in DRT was through argument domain.
Source/WebKit2:
- UIProcess/mac/WKFullKeyboardAccessWatcher.mm:
(-[WKFullKeyboardAccessWatcher retrieveKeyboardUIModeFromPreferences:]):
Further fix reading of AppleKeyboardUIMode - reading it from kCFPreferencesAnyApplication
domain meant that current application's domain was explcitly ignored, and the only
way to override the setting in WTR was through argument domain.
Tools:
Using NSArgumentDomain was not a good idea. While it works with NSUserDefaults
and CFPreferencesCopyAppValue family of functions, it doesn't work with
CFPreferencesCopyValue(..., kCFPreferencesCurrentApplication, ...).
So, now we'll just set defaults in the current application.
- DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
- Delete the defaults.
- Removed CFPreferencesSetAppValue calls, as -setValuesForKeysWithDictionary: does the same.
- The comment about [NSUserDefaults standardUserDefaults] indirectly initializing NSApplication was incorrect.
- WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting):
Switched to -setValuesForKeysWithDictionary for consistency.
- 11:04 PM Changeset in webkit [158651] by
-
- 2 edits in trunk/Source/WebCore
Do not call setFrameRect on Widget unless its boundaries changed.
https://bugs.webkit.org/show_bug.cgi?id=123781
Reviewed by Andreas Kling.
Call Widget:setFrameRect only when the frame's rect actually changes. It also
cleans up the related weak reference code a bit.
Covered by existing tests.
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry):
- 10:50 PM Changeset in webkit [158650] by
-
- 77 edits in trunk/Source/WebCore
[webcore/html] remove extra header includes from cpp files.
https://bugs.webkit.org/show_bug.cgi?id=123740
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-11-04
Reviewed by Darin Adler.
Removing redundant headers.
- html/BaseDateAndTimeInputType.cpp:
- html/ColorInputType.cpp:
- html/DOMFormData.cpp:
- html/DOMURL.cpp:
- html/DateInputType.cpp:
- html/DateTimeInputType.cpp:
- html/DateTimeLocalInputType.cpp:
- html/FTPDirectoryDocument.cpp:
- html/FileInputType.cpp:
- html/FormController.cpp:
- html/HTMLAnchorElement.cpp:
- html/HTMLAreaElement.cpp:
- html/HTMLCanvasElement.cpp:
- html/HTMLCollection.cpp:
- html/HTMLDetailsElement.cpp:
- html/HTMLDocument.cpp:
- html/HTMLElement.cpp:
- html/HTMLFormControlsCollection.cpp:
- html/HTMLFormElement.cpp:
- html/HTMLImageElement.cpp:
- html/HTMLInputElement.cpp:
- html/HTMLLegendElement.cpp:
- html/HTMLMapElement.cpp:
- html/HTMLMediaElement.cpp:
- html/HTMLOptionElement.cpp:
- html/HTMLOptionsCollection.cpp:
- html/HTMLPlugInImageElement.cpp:
- html/HTMLProgressElement.cpp:
- html/HTMLSummaryElement.cpp:
- html/HTMLTemplateElement.cpp:
- html/HTMLVideoElement.cpp:
- html/HTMLViewSourceDocument.cpp:
- html/MediaController.cpp:
- html/MediaKeyEvent.cpp:
- html/MonthInputType.cpp:
- html/RangeInputType.cpp:
- html/StepRange.cpp:
- html/TextFieldInputType.cpp:
- html/TimeInputType.cpp:
- html/WeekInputType.cpp:
- html/canvas/CanvasRenderingContext.cpp:
- html/canvas/CanvasRenderingContext2D.cpp:
- html/canvas/CanvasStyle.cpp:
- html/canvas/OESVertexArrayObject.cpp:
- html/parser/BackgroundHTMLParser.cpp:
- html/parser/CSSPreloadScanner.cpp:
- html/parser/CompactHTMLToken.cpp:
- html/parser/HTMLConstructionSite.cpp:
- html/parser/HTMLDocumentParser.cpp:
- html/parser/HTMLElementStack.cpp:
- html/parser/HTMLFormattingElementList.cpp:
- html/parser/HTMLMetaCharsetParser.cpp:
- html/parser/HTMLParserIdioms.cpp:
- html/parser/HTMLPreloadScanner.cpp:
- html/parser/HTMLTokenizer.cpp:
- html/parser/HTMLTreeBuilder.cpp:
- html/parser/HTMLTreeBuilderSimulator.cpp:
- html/parser/HTMLViewSourceParser.cpp:
- html/parser/TextDocumentParser.cpp:
- html/parser/XSSAuditor.cpp:
- html/shadow/ContentDistributor.cpp:
- html/shadow/InsertionPoint.cpp:
- html/shadow/MediaControlElements.cpp:
- html/shadow/MediaControlsApple.cpp:
- html/shadow/MediaControlsBlackBerry.cpp:
- html/shadow/MediaControlsGtk.cpp:
- html/shadow/SliderThumbElement.cpp:
- html/track/AudioTrack.cpp:
- html/track/InbandGenericTextTrack.cpp:
- html/track/InbandTextTrack.cpp:
- html/track/InbandWebVTTTextTrack.cpp:
- html/track/TextTrack.cpp:
- html/track/TextTrackCueGeneric.cpp:
- html/track/TextTrackList.cpp:
- html/track/TextTrackRegion.cpp:
- html/track/TrackListBase.cpp:
- html/track/VideoTrack.cpp:
- html/track/WebVTTParser.cpp:
- 10:16 PM Changeset in webkit [158649] by
-
- 6 edits in trunk/Source/WebCore
IDB: deleteDatabase() interface should be asynchronous
https://bugs.webkit.org/show_bug.cgi?id=123787
Reviewed by Tim Horton.
No new tests (No behavior change for a tested port).
deleteDatabase now has no return value, but calls back to a bool function:
- Modules/indexeddb/IDBBackingStoreInterface.h:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::deleteDatabase):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
Refactor to account for the new async deleteDatabase:
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::deleteDatabase):
(WebCore::IDBDatabaseBackendImpl::deleteDatabaseAsync):
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
- 10:06 PM Changeset in webkit [158648] by
-
- 5 edits in trunk
REGRESSION(r158586): plugins/refcount-leaks.html fails
https://bugs.webkit.org/show_bug.cgi?id=123765
Source/JavaScriptCore:
We were leaving a hole of one slot above a new frame when pushing the new frame on
the stack with pushFrame(). This unused slot can contain residual values that will
be marked during GC.
Reviewed by Filip Pizlo.
- interpreter/JSStackInlines.h:
(JSC::JSStack::pushFrame):
LayoutTests:
Reviewed by Filip Pizlo.
Reverted the test expectation changes after fixing the underlying issue.
- TestExpectations:
- platform/wk2/TestExpectations:
- 9:52 PM Changeset in webkit [158647] by
-
- 11 edits2 adds in trunk/Source/WebKit2
Remote Layer Tree: Make LayerTypeCustom remote-host CALayers from the Web process
https://bugs.webkit.org/show_bug.cgi?id=123766
Reviewed by Anders Carlsson.
Put each LayerTypeCustom layer into a CAContext, so that we can
host small CALayer trees (for video, plugins, etc.) from the Web process
to the UI process without proxying their (more complex) content.
- Shared/mac/RemoteLayerTreeTransaction.h:
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::decode):
(WebKit::RemoteLayerTreeTransaction::dump):
Store, encode, and dump the CAContext ID of custom layers.
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::createLayer):
Create a CALayerHost with the CAContext ID from the Web process.
- WebKit2.xcodeproj/project.pbxproj:
Add PlatformCALayerRemoteCustom.
- WebProcess/WebPage/mac/GraphicsLayerCARemote.cpp:
(WebKit::GraphicsLayerCARemote::createPlatformCALayer):
Call the newly-added custom-layer constructor.
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::create):
(PlatformCALayerRemote::PlatformCALayerRemote):
Move the call to layerWasCreated() out to ::create(), so that all of
the constructors for this class and all subclasses have completed
before we call it (so that layerWasCreated() can store the context ID
in the created layer properties object).
(WebKit::PlatformCALayerRemote::hostingContextID):
Should never be reached on the base class, only PlatformCALayerRemoteCustom.
- WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.cpp: Added.
(PlatformCALayerRemoteCustom::PlatformCALayerRemoteCustom):
(PlatformCALayerRemoteCustom::~PlatformCALayerRemoteCustom):
(PlatformCALayerRemoteCustom::hostingContextID):
- WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h: Added.
Add PlatformCALayerRemoteCustom, which owns a LayerHostingContext
which it will use to share a custom CALayer tree with the UI process.
- WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.cpp:
Drive-by remove an unnecessary include.
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::layerWasCreated):
Store the CAContext ID with the layer creation properties so it can
be used to create a CALayerHost upon commit in the UI process.
- 9:41 PM Changeset in webkit [158646] by
-
- 2 edits in trunk/Source/JavaScriptCore
internal-js-tests.yaml/Octane/stress-tests/pdfjs.js.default: ASSERTION FAILED: m_state.forNode(child).m_futurePossibleStructure.isSubsetOf(StructureSet(structure)) at DFGConstantFoldingPhase.cpp:249
https://bugs.webkit.org/show_bug.cgi?id=123778
Reviewed by Geoffrey Garen.
This assertion was just wrong: ee do an execute() above the assertion. The assertion
is asserting that if we need a watchpoint (i.e. the best proven structure was not the
current structure) then it must be the future possible structure. But while that may
have been true before execute(), it won't be true after if the PutById was a
transition. Of course, this can only happen in the concurrent JIT in which case the
code would be invalidated anyway since we would only transform the code in a way that
leveraged the lack of a transition if we inserted a watchpoint, in which case we
would realize that the watchpoint had been fired during compilation.
Since this requires concurrent JIT awesomeness, I don't know how to test it.
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- 9:41 PM Changeset in webkit [158645] by
-
- 2 edits in trunk/Source/WebCore
Add Modules/indexeddb/leveldb to the WebCore.xcodeproj
Rubberstamped by Andreas Kling.
This will make hacking on IDB much easier for Mac developers as they won’t have
to constantly add and then subtract the leveldb subdirectory.
The USE(LEVELDB) flag is still disabled so these files won’t actually build by default.
- WebCore.xcodeproj/project.pbxproj:
- 9:39 PM Changeset in webkit [158644] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG CheckArray(String) should just be a Phantom(String:)
https://bugs.webkit.org/show_bug.cgi?id=123779
Reviewed by Geoffrey Garen.
This should be a speed-up since Phantom(String:) is smart enough to use the string
structure. It should also be a simplification since CheckArray(String) was totally
redundant.
Also FixupPhase was assuming that it may see CheckArray's. That's wrong. It can
create CheckArray's but it won't see them as input since no previous phase can
create them.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArray):
- 9:38 PM Changeset in webkit [158643] by
-
- 2 edits in trunk/Tools
Running FTL tests shouldn't reduce coverage on DFG tests
https://bugs.webkit.org/show_bug.cgi?id=123780
Reviewed by Geoffrey Garen.
- Scripts/run-jsc-stress-tests:
- 9:20 PM Changeset in webkit [158642] by
-
- 2 edits in trunk/Source/WebCore
Address review feedback I forgot to commit in r158641
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::processPendingOpenCalls):
- 9:08 PM Changeset in webkit [158641] by
-
- 6 edits in trunk/Source/WebCore
IDB: Make opening/establishing a database asynchronous.
https://bugs.webkit.org/show_bug.cgi?id=123775
Reviewed by Andreas Kling.
No new tests (No behavior change for a tested port).
- Modules/indexeddb/IDBBackingStoreInterface.h: Add getOrEstablishIDBDatabaseMetadata with a callback, removing getIDBDatabaseMetaData, getObjectStores, and createIDBDatabaseMetaData in the process.
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::getOrEstablishIDBDatabaseMetadata): Adapted from getIDBDatabaseMetaData,
implement the asynchronous interface in terms of other LevelDB methods, always calling back synchronously.
(WebCore::IDBBackingStoreLevelDB::createIDBDatabaseMetaData):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::create):
(WebCore::IDBDatabaseBackendImpl::openInternalAsync): Broken off from openInternal.
(WebCore::IDBDatabaseBackendImpl::didOpenInternalAsync): Broken off from openInternal.
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::processPendingOpenCalls): Broken off to allow didOpenInternalAsync
to perform open callbacks in the failure case.
(WebCore::IDBDatabaseBackendImpl::openConnection): Always queue open connection calls, then immediately processPendingCalls.
(WebCore::IDBDatabaseBackendImpl::openConnectionInternal): Actually perform open connection calls.
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
- 9:04 PM Changeset in webkit [158640] by
-
- 2 edits in trunk/Websites/test-results
Build fix. Update is_flaky when it's NULL.
- public/include/test-results.php:
- 8:12 PM Changeset in webkit [158639] by
-
- 5 edits in branches/safari-537.73-branch/Source
Versioning.
- 8:11 PM Changeset in webkit [158638] by
-
- 1 copy in tags/Safari-537.73.3
New Tag.
- 8:05 PM Changeset in webkit [158637] by
-
- 3 edits in trunk/Websites/test-results
JSON generation on new flakiness dashboard is still too slow
https://bugs.webkit.org/show_bug.cgi?id=123776
Reviewed by Mark Rowe.
- init-database.sql: Added a constraint that result is unique for each (build, test) pair.
- public/include/test-results.php:
(ResultsJSONGenerator::generate): Don't sort results by latest_revision_time since that's done
in the client side anyway.
(update_flakiness_for_build): Don't update is_flaky flag if it's already set to the right value.
- 7:46 PM Changeset in webkit [158636] by
-
- 2 edits in branches/safari-537.60-branch/Tools
Merged r157995. <rdar://problem/15390113>
- 7:45 PM Changeset in webkit [158635] by
-
- 3 edits in branches/safari-537.60-branch/Tools
Merged r157815. <rdar://problem/15390113>
- 7:43 PM Changeset in webkit [158634] by
-
- 3 edits in branches/safari-537.60-branch/Tools
Merged r157687. <rdar://problem/15390113>
- 7:42 PM Changeset in webkit [158633] by
-
- 3 edits in branches/safari-537.60-branch/Tools
Merged r157553. <rdar://problem/15390113>
- 7:38 PM Changeset in webkit [158632] by
-
- 5 edits in branches/safari-537.60-branch/Tools
Merged r154450. <rdar://problem/15390113>
- 7:31 PM Changeset in webkit [158631] by
-
- 5 edits in trunk/Source/WebCore
CTTE: RenderFrameBase's widget is always a FrameView.
<https://webkit.org/b/123771>
Delete widget() from RenderFrameBase and supplant a childView()
that returns FrameView*. Strip away unnecessary casts and asserts.
Reviewed by Antti Koivisto.
- 6:34 PM Changeset in webkit [158630] by
-
- 3 edits2 adds in trunk
[CSS Regions][CSS Shapes] Content in region doesn't respect shape-outside after initial layout pass
<https://webkit.org/b/114829>
Source/WebCore:
Although we set the size of a shape for shape-outside in RenderBlockFlow::insertFloatingObject based on the
float's size, the actual height of the float is not always resolved at that point. (Look at cases when the shape
has percentage based height or percentage based radius.) ShapeInfo::setShapeSize triggers a layout for 0 height
value, which will be overriden later, when RenderBlockFlow::positionNewFloats sets the actual size of the float (shape).
Thus it doesn't make sense to set the shape's size in insertFloatingObject and run those extra unnecessary layout passes,
since it'll be overriden anyways. I moved the shape size setting logic into RenderBlockFlow::positionNewFloats.
The problem showed up when we had a shape-outside ellipse with percentage based radius, and we inserted the content
with JavaScript into a region flow. The content has been layed out based on the 0 border radius, and relayout hasn't been
triggered when it flew into the flow. This change sets the shape size only when we already have the height of the float,
so the radius(es) can be resolved correctly, thus no unnecessary layout passes will happen and the layout will be correct as well.
Reviewed by David Hyatt.
Test: fast/shapes/shape-outside-floats/shape-outside-floats-layout-after-initial-layout-pass.html
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::insertFloatingObject): Remove setting the size of the shape.
(WebCore::RenderBlockFlow::positionNewFloats): Set the size of the shape here.
LayoutTests:
Reviewed by David Hyatt.
- fast/shapes/shape-outside-floats/shape-outside-floats-layout-after-initial-layout-pass-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-layout-after-initial-layout-pass.html: Added.
- 6:14 PM Changeset in webkit [158629] by
-
- 2 edits in trunk/Source/WebCore
AX: AXShowMenu doesn't always work.
https://bugs.webkit.org/show_bug.cgi?id=123649
Reviewed by Chris Fleizach.
No new tests, the change occurs in a code path that forces the context menu to show which
locks up DRT if we try to test it (platform menu is shown). The change itself gives the mouse
event handler a chance to handle our platform mouse event BEFORE the event ends up in the show
context menu machinery. This is necessary because without it, the element will not become
focused. Without focus, accessibility shows different/less menu items than a mouse click. The
end result is that context menus shown via accessibility are consistent with menus shown via click.
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::showContextMenuAt):
- 5:45 PM Changeset in webkit [158628] by
-
- 3 edits in trunk/Source/WTF
Implement base64url encoding from RFC 4648
https://bugs.webkit.org/show_bug.cgi?id=123767
Reviewed by Sam Weinig.
No tests yet, will be covered by JWK tests for WebCrypto.
- wtf/text/Base64.cpp:
(WTF::base64EncodeInternal):
(WTF::base64Encode):
(WTF::base64URLEncode):
(WTF::base64DecodeInternal):
(WTF::base64Decode):
(WTF::base64URLDecode):
- wtf/text/Base64.h:
(WTF::base64URLEncode):
- 5:45 PM Changeset in webkit [158627] by
-
- 4 edits2 adds in trunk
SMIL timers can still fire after the containing document has been torn down
<https://webkit.org/b/123291>
Reviewed by Darin Adler.
Source/WebCore:
Ensure that the timers get paused when the document is preparing to be torn down.
Test: svg/animations/smil-timers-not-disabled-crash.html
- dom/Document.cpp:
(WebCore::Document::dropChildren):
(WebCore::Document::commonTeardown):
(WebCore::Document::prepareForDestruction):
- dom/Document.h:
LayoutTests:
Add a test that triggers the crash; unfortunately it triggers it after
the test is done, causing the next test to time out or crash.
- svg/animations/smil-timers-not-disabled-crash-expected.txt: Added.
- svg/animations/smil-timers-not-disabled-crash.html: Added.
- 5:37 PM Changeset in webkit [158626] by
-
- 19 edits1 copy in trunk/Source/WebCore
Move duplicate code in TrackPrivate classes to a common base class
https://bugs.webkit.org/show_bug.cgi?id=123619
Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-04
Reviewed by Darin Adler.
No new tests because this is just refactoring.
- GNUmakefile.list.am: Add TrackPrivateBase.
- WebCore.vcxproj/WebCore.vcxproj: Same.
- WebCore.vcxproj/WebCore.vcxproj.filters: Same.
- WebCore.xcodeproj/project.pbxproj: Same.
- html/track/AudioTrack.cpp:
(WebCore::AudioTrack::inbandTrackIndex): Renamed audioTrackIndex() to trackIndex().
(WebCore::AudioTrack::labelChanged): First argument is now a TrackPrivateBase*.
(WebCore::AudioTrack::languageChanged): Same.
(WebCore::AudioTrack::willRemove): Same.
- html/track/AudioTrack.h: Update TrackPrivateBaseClient function signatures.
- html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::inbandTrackIndex): Renamed textTrackIndex() to trackIndex().
(WebCore::InbandTextTrack::labelChanged): First argument is now a TrackPrivateBase*.
(WebCore::InbandTextTrack::languageChanged): Same.
(WebCore::InbandTextTrack::willRemove): Same.
- html/track/InbandTextTrack.h: Update TrackPrivateBaseClient function signatures.
- html/track/VideoTrack.cpp:
(WebCore::VideoTrack::inbandTrackIndex): Renamed videoTrackIndex() to trackIndex().
(WebCore::VideoTrack::labelChanged): First argument is now a TrackPrivateBase*.
(WebCore::VideoTrack::languageChanged): Same.
(WebCore::VideoTrack::willRemove): Same.
- html/track/VideoTrack.h: Update TrackPrivateBaseClient function signatures.
- platform/graphics/AudioTrackPrivate.h: Remove code that was moved to TrackPrivateBase.
- platform/graphics/InbandTextTrackPrivate.h: Same.
- platform/graphics/InbandTextTrackPrivateClient.h: Same.
- platform/graphics/VideoTrackPrivate.h: Same.
- platform/graphics/TrackPrivateBase.h: Refactored out duplicate code in AudioTrackPrivate, InbandTextTrackPrivate and VideoTrackPrivate.
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h: Renamed textTrackIndex() to trackIndex().
- platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h: Same.
- platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h: Renamed audioTrackIndex() to trackIndex().
- platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h: Renamed videoTrackIndex() to trackIndex90.
- 5:33 PM Changeset in webkit [158625] by
-
- 2 edits in trunk/Source/WebCore
FrameView destructor is worried about being retained by a renderer.
<https://webkit.org/b/123763>
There's no way we can be in ~FrameView() while also being owned by
a RenderWidget. Remove some overly paranoid code that was making sure
the renderer didn't have a reference on us.
Reviewed by Anders Carlsson.
- 5:33 PM Changeset in webkit [158624] by
-
- 4 edits in trunk
REGRESSION(r158311): media/media-fragments/TC0054.html and TC0061.html hit assertions
https://bugs.webkit.org/show_bug.cgi?id=123555
Reviewed by Darin Adler.
Source/WebCore:
No new tests, covered by existing tests.
- html/MediaFragmentURIParser.cpp:
(WebCore::MediaFragmentURIParser::parseFragments): Don't add a fragment with empty key or value as
they will not processed.
(WebCore::MediaFragmentURIParser::parseNPTFragment): Remove excess whitespace.
LayoutTests:
- TestExpectations: Remove media/media-fragments/TC0054.html and media/media-fragments/TC0061.html.
- 5:31 PM Changeset in webkit [158623] by
-
- 13 edits in trunk/Source/WebCore
Remove code duplications in createFontCustomPlatformData()
https://bugs.webkit.org/show_bug.cgi?id=123706
Reviewed by Darin Adler.
Move OpenTypeSanitizer and WOFF handling from the port specific
implementations in createFontCustomPlatformData() into the only
caller of this function CachedFont::ensureCustomFontData().
Also change the parameter passing the SharedBuffer from a
pointer to a reference since it is never null.
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::ensureCustomFontData):
- platform/graphics/blackberry/FontCustomPlatformData.h:
- platform/graphics/blackberry/FontCustomPlatformDataBlackBerry.cpp:
(WebCore::FontCustomPlatformData::FontCustomPlatformData):
(WebCore::createFontCustomPlatformData):
- platform/graphics/cairo/FontCustomPlatformData.h:
- platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
(WebCore::FontCustomPlatformData::FontCustomPlatformData):
(WebCore::createFontCustomPlatformData):
- platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData):
- platform/graphics/mac/FontCustomPlatformData.h:
- platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData):
- platform/graphics/win/FontCustomPlatformData.h:
- platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::createFontCustomPlatformData):
- platform/graphics/wince/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData):
- platform/graphics/wince/FontCustomPlatformData.h:
- 5:31 PM Changeset in webkit [158622] by
-
- 5 edits in branches/safari-537.60-branch/Source
Versioning.
- 5:28 PM Changeset in webkit [158621] by
-
- 1 copy in tags/Safari-537.60.5
New Tag.
- 5:26 PM Changeset in webkit [158620] by
-
- 2 edits in trunk/Source/WebCore
Fixing MediaStreamDescriptor addSource and addTrack methods
https://bugs.webkit.org/show_bug.cgi?id=123755
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-04
Reviewed by Eric Carlson.
We must store the track and source that is passed as parameter in a RefPtr,
otherwise we will refer to a null pointer.
No new tests needed.
- platform/mediastream/MediaStreamDescriptor.cpp:
(WebCore::MediaStreamDescriptor::addSource):
(WebCore::MediaStreamDescriptor::addTrack):
- 5:23 PM Changeset in webkit [158619] by
-
- 7 edits in trunk/Source
Remove PlatformCALayer::playerLayer
https://bugs.webkit.org/show_bug.cgi?id=123764
Reviewed by Sam Weinig.
Source/WebCore:
- platform/graphics/ca/PlatformCALayer.h:
- platform/graphics/ca/mac/PlatformCALayerMac.h:
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::clone):
Remove playerLayer(), fold it into clone().
Source/WebKit2:
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
Remove playerLayer().
- 5:12 PM Changeset in webkit [158618] by
-
- 5 edits in branches/safari-537.73-branch/Source/WebCore
Merged r155130. <rdar://problem/15109454>
- 4:47 PM Changeset in webkit [158617] by
-
- 17 edits4 adds in trunk
AX: Mail attachments at the start of an email are not output by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=123697
Reviewed by Ryosuke Niwa.
Source/WebCore:
VoiceOver is expecting that "replaced elements" (attachments in a Mail message in this case) to be
represented by the replacement character when asking for a stringForRange.
However, when that replaced element is at the beginning of the document, the logic does not work because
there is a few code places that will take that first Position and advance it forward, not accounting for replaced elements.
When using the TextIterator normally, it does account for these, so that's why it's only affecting as at the beginning of the document.
Also a "replaced element" can be more than just renderer->isReplaced(), hence the externing of the isRendererReplacedElement method
and using that it in pertinent places.
Tests: platform/mac/accessibility/object-replacement-with-no-rendered-children-at-node-start.html
platform/mac/accessibility/object-replacement-with-rendered-children-at-node-start.html
- accessibility/AccessibilityObject.cpp:
(WebCore::replacedNodeNeedsCharacter):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(nsStringForReplacedNode):
- dom/Position.cpp:
(WebCore::Position::isCandidate):
- dom/PositionIterator.cpp:
- dom/Range.cpp:
(WebCore::Range::firstNode):
- editing/TextIterator.cpp:
(WebCore::isRendererReplacedElement):
- editing/TextIterator.h:
LayoutTests:
Add two flavors of this. One where the replaced element has rendered children and one where it does not,
which go down two different code paths.
- platform/mac/accessibility/object-replacement-with-no-rendered-children-at-node-start-expected.txt: Added.
- platform/mac/accessibility/object-replacement-with-no-rendered-children-at-node-start.html: Added.
- platform/mac/accessibility/object-replacement-with-rendered-children-at-node-start-expected.txt: Added.
- platform/mac/accessibility/object-replacement-with-rendered-children-at-node-start.html: Added.
- 4:46 PM Changeset in webkit [158616] by
-
- 4 edits in trunk/Source/WebKit/wince
Change structure of frame tree in WINCE port.
https://bugs.webkit.org/show_bug.cgi?id=121079
Patch by Zhuang Zhigang <zhuangzg@cn.fujitsu.com> on 2013-11-04
Reviewed by Darin Adler.
- WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit::FrameLoaderClientWinCE::createFrame):
- WebView.cpp:
(WebView::createFrame):
- WebView.h:
- 4:46 PM Changeset in webkit [158615] by
-
- 2 edits in branches/safari-537.60-branch/Source/WebCore
Merged r154180. <rdar://problem/15387843>
- 4:41 PM Changeset in webkit [158614] by
-
- 3 edits in trunk/LayoutTests
REGRESSION(r158586): plugins/refcount-leaks.html fails
https://bugs.webkit.org/show_bug.cgi?id=123765
Add the test expectation.
- TestExpectations:
- platform/wk2/TestExpectations:
- 4:33 PM Changeset in webkit [158613] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebKit2
Merge change for <rdar://problem/15374298>.
- 4:15 PM Changeset in webkit [158612] by
-
- 6 edits in branches/safari-537.60-branch/Source/WebCore
Merged r157773. <rdar://problem/15387840>
- 4:12 PM Changeset in webkit [158611] by
-
- 7 edits in trunk/Source/WebCore
Use RenderAncestorIterator in a couple of places.
<https://webkit.org/b/123725>
Take the ancestorsOfType<RenderMoo>() thingy out for a spin.
Found a bunch of parent chain walking loops that were really just
looking for the first ancestor renderer of a certain type.
They were a perfect fit for this pattern:
if (auto svgRoot = ancestorsOfType<RenderSVGRoot>(renderer).first())
svgRoot->shakeMoneyMaker();
Quite a bit clearer than the previous:
for (auto ancestor = renderer.parent(); ancestor; ancestor = ancestor->parent()) {
if (ancestor->isSVGRoot())
toRenderSVGRoot(ancestor)->makeMoneyShaker();
}
Reviewed by Antti Koivisto.
- 4:09 PM Changeset in webkit [158610] by
-
- 2 edits in trunk/Source/WebKit2
WKRemoteObjectEncoder should escape keys
https://bugs.webkit.org/show_bug.cgi?id=123761
Reviewed by Tim Horton.
Keys that start with $ will be reserved for use by the coder, so prepend an extra
$ to keys that already start with $ to avoid clashes.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(escapeKey):
(-[WKRemoteObjectEncoder encodeBytes:length:forKey:]):
(-[WKRemoteObjectEncoder _encodeObjectForKey:usingBlock:]):
- 4:05 PM Changeset in webkit [158609] by
-
- 7 edits in branches/safari-537.73-branch/Source/WebCore
Merge r157773
- 4:05 PM Changeset in webkit [158608] by
-
- 3 edits6 adds in trunk
DFG NewArray/NewArrayBuffer shouldn't be constructing with negative indexing
https://bugs.webkit.org/show_bug.cgi?id=123760
<rdar://problem/15356705>
Reviewed by Mark Hahnenberg and Oliver Hunt.
Source/JavaScriptCore:
- dfg/DFGOperations.cpp:
LayoutTests:
- js/dfg-new-array-buffer-while-having-a-bad-time-expected.txt: Added.
- js/dfg-new-array-buffer-while-having-a-bad-time.html: Added.
- js/dfg-new-array-while-having-a-bad-time-expected.txt: Added.
- js/dfg-new-array-while-having-a-bad-time.html: Added.
- js/script-tests/dfg-new-array-buffer-while-having-a-bad-time.js: Added.
(foo):
- js/script-tests/dfg-new-array-while-having-a-bad-time.js: Added.
(foo):
- 3:59 PM Changeset in webkit [158607] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r154180. <rdar://problem/15387809>
- 3:52 PM Changeset in webkit [158606] by
-
- 5 edits1 add in trunk/Source/WebCore
[MSE] Add a SourceBufferPrivateClient interface for platform -> html communication.
https://bugs.webkit.org/show_bug.cgi?id=123373
Reviewed by Eric Carlson.
To enable communication between SourceBuffer and SourceBufferPrivate without introducing
layering violations, add a new interface class SourceBufferPrivateInterface from which
SourceBuffer will inherit.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::SourceBuffer): Set the private's client.
(WebCore::SourceBuffer::~SourceBuffer): Clear the private's client.
(WebCore::SourceBuffer::sourceBufferPrivateDidEndStream): Added stub.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment): Hinno.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): Ditto.
(WebCore::SourceBuffer::sourceBufferPrivateHasAudio): Ditto.
(WebCore::SourceBuffer::sourceBufferPrivateHasVideo): Ditto.
- Modules/mediasource/SourceBuffer.h:
- WebCore.xcodeproj/project.pbxproj: Add new files to project.
- platform/graphics/SourceBufferPrivate.h:
- platform/graphics/SourceBufferPrivateClient.h: Added.
(WebCore::SourceBufferPrivateClient::~SourceBufferPrivateClient): Empty destructor.
- 3:47 PM Changeset in webkit [158605] by
-
- 8 edits in branches/safari-537.73-branch
Merge r157299
<rdar://problem/15292359>
- 3:44 PM Changeset in webkit [158604] by
-
- 4 edits in branches/safari-537.73-branch/Source
Merged r158602. <rdar://problem/15388203>
- 3:37 PM Changeset in webkit [158603] by
-
- 4 edits in branches/safari-537.60-branch/Source
Merged r158602. <rdar://problem/15373550>
- 3:26 PM Changeset in webkit [158602] by
-
- 4 edits in trunk/Source
../WebKit: [Win] Use VersionStamper for official builds
https://bugs.webkit.org/show_bug.cgi?id=123758
Reviewed by Tim Horton.
- WebKit.vcxproj/WebKit/WebKitPostBuild.cmd: Restore command to
call VersionStamper on final stage of build.
../WTF: [Win] User VersionStamper for official builds
https://bugs.webkit.org/show_bug.cgi?id=123758
Reviewed by Tim Horton.
- WTF.vcxproj/WTFPostBuild.cmd: Add missing command to run VersionStamper.exe.
- 3:15 PM Changeset in webkit [158601] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI
Merge fixes for <rdar://problem/15168240>.
- 3:03 PM Changeset in webkit [158600] by
-
- 5 edits in trunk/Source/WebKit2
[WK2] Update WebGeolocationManager to support multiple WebContent processes
https://bugs.webkit.org/show_bug.cgi?id=123658
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-11-04
Reviewed by Anders Carlsson.
Change WebGeolocationManagerProxy to track which WebProcessProxy needs geolocation.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::disconnectProcess):
WebContext::disconnectProcess does not handle ContextSupplement yet when using multiple
WebContent processes. Add an explicit call for WebGeolocationManagerProxy as a temporary
solution.
- UIProcess/WebGeolocationManagerProxy.cpp:
(WebKit::WebGeolocationManagerProxy::WebGeolocationManagerProxy):
(WebKit::WebGeolocationManagerProxy::contextDestroyed):
(WebKit::WebGeolocationManagerProxy::processDidClose):
(WebKit::WebGeolocationManagerProxy::startUpdating):
(WebKit::WebGeolocationManagerProxy::stopUpdating):
(WebKit::WebGeolocationManagerProxy::removeRequester):
- UIProcess/WebGeolocationManagerProxy.h:
- UIProcess/WebGeolocationManagerProxy.messages.in:
- 2:53 PM Changeset in webkit [158599] by
-
- 27 edits in trunk/Source
[PluginProxy] Add a setting to disable video plugin proxy support in HTMLMediaElement.
https://bugs.webkit.org/show_bug.cgi?id=123621
Reviewed by Eric Carlson.
Source/WebCore:
Add a new Setting which will disable the video plugin proxy. Enable support for AVFoundation
in iOS (which requries fixing a few compile errors resulting from classes and methods which
are not available on iOS.
- WebCore.exp.in: Export wkAVAssetResolvedURL.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement): Make conditional upon
new isVideoPluginProxyEnabled() setting.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute): Ditto.
- html/HTMLMediaElement.h:
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::createRenderer): Ditto.
(WebCore::HTMLVideoElement::attach): Ditto.
(WebCore::HTMLVideoElement::parseAttribute): Ditto.
(HTMLVideoElement::setDisplayMode): Ditto.
- html/HTMLVideoElement.h:
- page/Settings.cpp:
(WebCore::Settings::setVideoPluginProxyEnabled): Simple setter.
- page/Settings.h:
(WebCore::Settings::isVideoPluginProxyEnabled): Simple getter.
- platform/graphics/MediaPlayer.cpp:
(WebCore::installedMediaEngines): Conditionally add MediaPlayerPrivateIOS and always add
MediaPlayerPriateAVFoundationObjC.
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::deliverNotification): Add default implementation.
(WebCore::MediaPlayerPrivateInterface::setMediaPlayerProxy): Ditto.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Use new
HAS_ and USE_ macros instead of MAC_OS_MIN_VERNSION_REQUIRED.
(WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasContextRenderer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createContextVideoRenderer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyContextVideoRenderer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): Use cachedCGColor instead
of CGColorGetConstantColor.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput): Use CVPixelBuffer pixel
format constant instead of QuickDraw constant.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createPixelBuffer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput): Draw to intermediary
CGImage on iOS.
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
- platform/ios/WebCoreSystemInterfaceIOS.mm:
- platform/mac/WebCoreSystemInterface.h:
Source/WebKit/mac:
Add a new isVideoPluginProxyEnabled setting.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Set isVideoPluginProxyEnabled preference.
(-[WebPreferences isVideoPluginProxyEnabled]): Pass through to Settings.
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Set isVideoPluginProxyEnabled preference.
Source/WebKit2:
Add WebKit2 functions for setting then new isVideoPluginProxyEnabled preference.
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetVideoPluginProxyEnabled):
(WKPreferencesGetVideoPluginProxyEnabled):
- UIProcess/API/C/WKPreferences.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Source/WTF:
Enable WTF_USE_AVFOUNDATION and add some HAVE_AVFOUNDATION_* defines
to replace the existing MAC_OS_X_VERSION_MIN_REQUIRED macros in
MediaPlayerPrivateAVFoundationObjC.mm.
- wtf/Platform.h:
- 2:50 PM Changeset in webkit [158598] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r158561): fast/block/float/float-append-child-crash.html asserting.
The non-const ancestor iterator was walking siblings, not ancestors.
Rubber-stamped by Antti Koivisto.
- 2:49 PM Changeset in webkit [158597] by
-
- 6 edits in trunk/Source/WebCore
[MSE] [Mac] Disclaim support for MSE in AVFoundation and QTKit engines
https://bugs.webkit.org/show_bug.cgi?id=123593
Reviewed by Eric Carlson.
Immediately fail if asked to load a Media Source in engines which do not support
them.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::load):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType):
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::load):
(WebCore::MediaPlayerPrivateQTKit::supportsType):
- 2:39 PM Changeset in webkit [158596] by
-
- 3 edits2 adds in trunk
[CSS Shapes] image valued shape element margin can cause an ASSERT fail
https://bugs.webkit.org/show_bug.cgi?id=123743
Reviewed by Andreas Kling.
Source/WebCore:
When margin-top is specified for a shape's element, the Y coordinates passed
to RasterShapeIntervals::getExcludedIntervals() may be negative. This is
because the incoming logical coordinates are relative to the content or
padding box, depending on the box-sizing property. The RasterShape::getExcludedIntervals()
method now clips the incoming Y coordinates to the shape's bounds before
accessing the shape's intervals.
Test: fast/shapes/shape-outside-floats/shape-outside-floats-margin-crash.html
- rendering/shapes/RasterShape.cpp:
(WebCore::RasterShapeIntervals::getExcludedIntervals):
LayoutTests:
Verify that an element with an image valued shape and a non-negative margin
does not cause an assertion failure.
- fast/shapes/shape-outside-floats/shape-outside-floats-margin-crash-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-margin-crash.html: Added.
- 2:30 PM Changeset in webkit [158595] by
-
- 7 edits in trunk
More WKRemoteObjectRegistry work
https://bugs.webkit.org/show_bug.cgi?id=123754
Reviewed by Dan Bernstein.
Source/WebKit2:
- Shared/API/Cocoa/WKRemoteObjectCoder.h:
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(-[WKRemoteObjectEncoder rootObjectDictionary]):
Add a getter for the root object dictionary.
- Shared/API/Cocoa/WKRemoteObjectRegistry.mm:
(-[WKRemoteObjectRegistry _sendInvocation:interface:]):
Call _sendMessageWithBody:.
(-[WKRemoteObjectRegistry _sendMessageWithBody:]):
Call WebConnection::postMessage.
Tools:
- TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
(TestWebKitAPI::TEST):
Use the correct bundle test name. Call Util::run.
- TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
(-[BundleObject sayHello]):
(-[BundleObject testMethodWithString:double:integer:]):
Add BundleObject implementation. Register the bundle object with
the remote object registry. Call _handleMessageWithName:body: on the incoming message.
- 1:56 PM Changeset in webkit [158594] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI
Merged r158404. <rdar://problem/15371809>
- 1:53 PM Changeset in webkit [158593] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI
Merged r158061. <rdar://problem/15333281>
- 1:50 PM Changeset in webkit [158592] by
-
- 3 edits2 copies in branches/safari-537.73-branch
Merged r157436. <rdar://problem/15357233>
- 1:46 PM Changeset in webkit [158591] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI
Merged r154897. <rdar://problem/15168237>
- 1:44 PM Changeset in webkit [158590] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI
Merged r154851. <rdar://problem/15366090>
- 1:41 PM Changeset in webkit [158589] by
-
- 3 edits2 copies in branches/safari-537.73-branch/Source/WebInspectorUI
Merged r153087. <rdar://problem/15366093>
- 1:38 PM Changeset in webkit [158588] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI
Merged r154851.
- 1:31 PM Changeset in webkit [158587] by
-
- 11 edits in trunk/Source/WebCore
Make LiveNodeListBase use Elements instead of Nodes
https://bugs.webkit.org/show_bug.cgi?id=123745
Reviewed by Anders Carlsson.
- WebCore.exp.in:
- dom/Element.cpp:
(WebCore::Element::firstElementChild):
(WebCore::Element::lastElementChild):
Switch to correct calls. ElementTraversal::previous and previousChild are no longer equivalent.
- dom/ElementTraversal.h:
(WebCore::::lastWithinTemplate):
(WebCore::::previousTemplate):
Fix ElementTraversal::lastWithin and previous. They had no real clients and didn't work correctly.
With LiveNodeListBase starting to use these they get excellent test coverage.
- dom/LiveNodeList.cpp:
(WebCore::LiveNodeListBase::invalidateCache):
- dom/LiveNodeList.h:
(WebCore::LiveNodeListBase::LiveNodeListBase):
(WebCore::LiveNodeListBase::isElementCacheValid):
(WebCore::LiveNodeListBase::cachedElement):
(WebCore::LiveNodeListBase::cachedElementOffset):
(WebCore::LiveNodeListBase::setCachedElement):
Make the cache Element based.
Switch to Elements in all helpers.
Rename item -> element for clarity.
- dom/NodeIterator.cpp:
(WebCore::NodeIterator::NodePointer::moveToPrevious):
(WebCore::NodeIterator::updateForNodeRemoval):
This code expected the old inconsistent NodeTraversal::previous behavior where the traversal includes
the root as the last item. Drop the stayWithin parameter and handle the one case where it is needed here.
- dom/NodeTraversal.cpp:
(WebCore::NodeTraversal::last):
(WebCore::NodeTraversal::deepLastChild):
- dom/NodeTraversal.h:
Support ElementTraversal::previous/lastWithin.
(WebCore::NodeTraversal::previous):
This was slightly wrong too.
- html/HTMLCollection.cpp:
(WebCore::previousElement):
(WebCore::lastElement):
(WebCore::LiveNodeListBase::iterateForPreviousElement):
(WebCore::LiveNodeListBase::itemBefore):
(WebCore::LiveNodeListBase::isLastItemCloserThanLastOrCachedItem):
(WebCore::LiveNodeListBase::isFirstItemCloserThanCachedItem):
(WebCore::LiveNodeListBase::setCachedElement):
(WebCore::LiveNodeListBase::item):
(WebCore::LiveNodeListBase::elementBeforeOrAfterCachedElement):
- html/HTMLCollection.h:
(WebCore::HTMLCollection::isEmpty):
(WebCore::HTMLCollection::hasExactlyOneItem):
- 1:28 PM Changeset in webkit [158586] by
-
- 28 edits in trunk/Source
Eliminate HostCall bit from JSC Stack CallerFrame
https://bugs.webkit.org/show_bug.cgi?id=123642
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Replace the HostCallFrame bit or'ed to the CallerFrame value in a CallFrame with
a VM entry sentinel CallFrame. Logically, the VM entry sentinel call frame is
pushed on the stack before the callee frame when calling from native to JavaScript
code. The callee frame's CallerFrame points at the VM entry sentinel call frame
and the VM entry sentinel call frame's CallerFrame points to the real caller.
The VM entry sentinel call frame has a sentinel (1) in the CodeBlock to indicate
its a VM entry sentinel call frame. It's ScopeChain has vm.topCallFrame at the
time of the call. This allows for a complete stack walk as well as walking just
the contiguous JS frames.
The VM entry sentinel call frame and callee frame are currently allocated and
initialized in ExecState::init(), but this initialization will be moved to
ctiTrampoline when we actually move onto the native stack.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::noticeIncomingCall):
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::callerFrame):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileExceptionHandlers):
- interpreter/CallFrame.h:
(JSC::ExecState::frameExtent):
(JSC::ExecState::currentVPC):
(JSC::ExecState::setCurrentVPC):
(JSC::ExecState::init):
(JSC::ExecState::noCaller):
(JSC::ExecState::isVMEntrySentinel):
(JSC::ExecState::vmEntrySentinelCallerFrame):
(JSC::ExecState::initializeVMEntrySentinelFrame):
(JSC::ExecState::callerFrameSkippingVMEntrySentinel):
(JSC::ExecState::vmEntrySentinelCodeBlock):
- interpreter/Interpreter.cpp:
(JSC::unwindCallFrame):
(JSC::Interpreter::getStackTrace):
- interpreter/Interpreter.h:
(JSC::TopCallFrameSetter::TopCallFrameSetter):
(JSC::TopCallFrameSetter::~TopCallFrameSetter):
(JSC::NativeCallFrameTracer::NativeCallFrameTracer):
- interpreter/JSStack.cpp:
(JSC::JSStack::~JSStack):
- interpreter/JSStackInlines.h:
(JSC::JSStack::getStartOfFrame):
(JSC::JSStack::pushFrame):
(JSC::JSStack::popFrame):
- interpreter/Register.h:
(JSC::Register::operator=):
(JSC::Register::callFrame):
- interpreter/StackVisitor.cpp:
(JSC::StackVisitor::readFrame):
(JSC::StackVisitor::readNonInlinedFrame):
(JSC::StackVisitor::readInlinedFrame):
(JSC::StackVisitor::Frame::print):
- interpreter/VMInspector.cpp:
(JSC::VMInspector::countFrames):
- jit/JIT.cpp:
(JSC::JIT::privateCompileExceptionHandlers):
- jit/JITOperations.cpp:
- jit/JITStubsARM.h:
(JSC::ctiTrampoline):
- jit/JITStubsARM64.h:
- jit/JITStubsARMv7.h:
(JSC::ctiTrampoline):
- jit/JITStubsMIPS.h:
- jit/JITStubsMSVC64.asm:
- jit/JITStubsSH4.h:
- jit/JITStubsX86.h:
- jit/JITStubsX86_64.h:
- jsc.cpp:
(functionDumpCallFrame):
- llint/LowLevelInterpreter.cpp:
(JSC::CLoop::execute):
- runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::throwException):
Source/WebCore:
Updated JavaScript stack walking as a result of the corresponding changes made in
JavaScriptCore.
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::shouldBypassMainWorldContentSecurityPolicy):
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::stepOutOfFunction):
(WebCore::ScriptDebugServer::returnEvent):
(WebCore::ScriptDebugServer::didExecuteProgram):
- 12:15 PM Changeset in webkit [158585] by
-
- 3 edits in trunk/Websites/test-results
Build fixes. In particular, we were missing the code to generate JSONs in report.php :(
- public/api/report.php:
- public/include/test-results.php:
- 12:12 PM Changeset in webkit [158584] by
-
- 41 edits in trunk
[css shapes] Fix support for shape-outside on a float with padding
https://bugs.webkit.org/show_bug.cgi?id=123590
Reviewed by Alexandru Chiculita.
Source/WebCore:
The line top was being improperly converted to the coordinates of the
shape, causing the shape to be positioned incorrectly when the float
had padding. This fixes that problem.
No new tests, covered by updates to existing ones.
- rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::updateDeltasForContainingBlockLine):
LayoutTests:
Fix existing tests that depended on the incorrect behavior so that
they are now testing the proper thing. Also fix up the tests to make
them clearer and more robust.
- csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-000-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-000.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-000-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-000.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-001-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-001.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-002-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-002.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-003-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-003.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-004-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-004.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-005-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-005.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-006-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-006.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-007-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-007.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-008-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-008.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-009-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-009.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-border-000-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-border-000.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:
- 11:52 AM Changeset in webkit [158583] by
-
- 8 edits3 adds in trunk
JSArrayBufferViews of length 0 allocate 0 CopiedSpace bytes, which is invalid
https://bugs.webkit.org/show_bug.cgi?id=123746
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
This patch disallows clients from allocating 0 bytes in CopiedSpace. We enforce this invariant
with an ASSERT in C++ code and a breakpoint in JIT code. Clients who care about 0-byte
allocations (like JSArrayBufferViews) must handle that case themselves, but we don't punish
anybody else for the rare case that somebody decides to allocate a 0-length typed array.
It also makes the allocation and copying cases consistent for CopiedSpace: no 0-byte allocations,
no 0-byte copying.
Also added a check so that JSArrayBufferViews don't try to copy their m_vector backing store when
their length is 0. Also sprinkled several ASSERTs throughout the JSArrayBufferView code to make sure that
when length is 0 m_vector is null.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileNewTypedArray):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::emitAllocateBasicStorage):
- heap/CopiedSpaceInlines.h:
(JSC::CopiedSpace::tryAllocate):
- runtime/ArrayBuffer.h:
(JSC::ArrayBuffer::create):
- runtime/JSArrayBufferView.cpp:
(JSC::JSArrayBufferView::ConstructionContext::ConstructionContext):
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::::visitChildren):
(JSC::::copyBackingStore):
(JSC::::slowDownAndWasteMemory):
LayoutTests:
Added a test to make sure that we don't crash when allocating a typed array with 0 length.
- js/script-tests/typedarray-zero-size.js: Added.
(foo):
- js/typedarray-zero-size-expected.txt: Added.
- js/typedarray-zero-size.html: Added.
- 10:45 AM Changeset in webkit [158582] by
-
- 17 edits6 copies in trunk
Implement generateKey for HMAC and AES-CBC
https://bugs.webkit.org/show_bug.cgi?id=123669
Reviewed by Dan Bernstein.
Source/WebCore:
Tests: crypto/subtle/aes-cbc-generate-key.html
crypto/subtle/hmac-generate-key.html
- WebCore.xcodeproj/project.pbxproj: Added new files.
- bindings/js/JSCryptoAlgorithmDictionary.cpp:
(WebCore::createAesKeyGenParams): Added bindings for AesKeyGenParams.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForGenerateKey): Handle
algorithms that generate AES and HMAC keys.
- bindings/js/JSSubtleCryptoCustom.cpp: (WebCore::JSSubtleCrypto::generateKey): Added.
- crypto/CryptoAlgorithmAesKeyGenParams.h: Added.
- crypto/CryptoKey.cpp: (WebCore::CryptoKey::randomData):
- crypto/CryptoKey.h:
- crypto/CryptoKeyMac.cpp: Added
Expose a function that produces random data for symmetric crypto keys. Cross-platform
implementation uses ARC4 code from WTF, while Mac uses a system function that
provides a FIPS validated random number generator.
- crypto/CryptoKeyAES.cpp: (WebCore::CryptoKeyAES::generate):
- crypto/CryptoKeyAES.h:
Added a function that creates AES keys.
- crypto/SubtleCrypto.idl: Added generateKey.
- crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
(WebCore::CryptoAlgorithmAES_CBC::generateKey): Added.
- crypto/algorithms/CryptoAlgorithmHMAC.cpp:
(WebCore::CryptoAlgorithmHMAC::generateKey): Added.
- crypto/keys/CryptoKeyHMAC.cpp: (WebCore::CryptoKeyHMAC::generate):
- crypto/keys/CryptoKeyHMAC.h:
Added a function that creates HMAC keys.
- crypto/mac/CryptoAlgorithmAES_CBCMac.cpp: Removed generateKey stub, the implementation
ended up in cross-platform file.
- crypto/mac/CryptoAlgorithmHMACMac.cpp: Ditto.
LayoutTests:
- crypto/subtle/aes-cbc-generate-key-expected.txt: Added.
- crypto/subtle/aes-cbc-generate-key.html: Added.
- crypto/subtle/hmac-generate-key-expected.txt: Added.
- crypto/subtle/hmac-generate-key.html: Added.
- crypto/subtle/sha-1-expected.txt: Now that crypto.webkitSubtle.generateKey exists,
a different exception is raised.
- 10:42 AM Changeset in webkit [158581] by
-
- 4 edits in trunk/Source/WebCore
Revert SetCGFontRenderingMode() build fix for Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=123633
Reviewed by Darin Adler.
Reverts <http://trac.webkit.org/changeset/134380>, which
was a Chromium Mac build fix for <http://trac.webkit.org/changeset/134348>
(https://bugs.webkit.org/show_bug.cgi?id=101787). Chromium doesn't
build against top-of-tree WebKit.
- platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- 10:21 AM Changeset in webkit [158580] by
-
- 3 edits in trunk/Source/JavaScriptCore
[sh4] Refactor jumps in baseline JIT to return label after the jump.
https://bugs.webkit.org/show_bug.cgi?id=123734
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-04
Reviewed by Michael Saboff.
Current implementation of jumps in sh4 baseline JIT returns a label on the jump itself
and not after it. This is not correct and leads to issues like infinite loop the DFG
(https://bugs.webkit.org/show_bug.cgi?id=122597 for instance). This refactor fixes this
and also simplifies the link and relink procedures for sh4 jumps.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::branchDouble):
(JSC::MacroAssemblerSH4::branchTrue):
(JSC::MacroAssemblerSH4::branchFalse):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::jmp):
(JSC::SH4Assembler::extraInstrForBranch):
(JSC::SH4Assembler::jne):
(JSC::SH4Assembler::je):
(JSC::SH4Assembler::bra):
(JSC::SH4Assembler::linkJump):
(JSC::SH4Assembler::relinkJump):
- 10:03 AM Changeset in webkit [158579] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK][WK1] Enable CSS Regions if feature flag is set to TRUE
https://bugs.webkit.org/show_bug.cgi?id=123739
Reviewed by Martin Robinson.
In WK1 CSS Regions were always disabled even if you set the feature flag
ENABLE_CSS_REGIONS to TRUE. Enabling CSS Regions support in that case.
- webkit/webkitwebview.cpp:
(webkit_web_view_update_settings): Enable CSS Regions if feautre flag is
set to TRUE.
- 9:37 AM Changeset in webkit [158578] by
-
- 17 edits6 deletes in trunk
Unreviewed, rolling out r158526.
http://trac.webkit.org/changeset/158526
https://bugs.webkit.org/show_bug.cgi?id=123744
it broke the build (Requested by jessieberlin on #webkit).
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCryptoAlgorithmDictionary.cpp:
(WebCore::createAesCbcParams):
(WebCore::createHmacParams):
(WebCore::createHmacKeyParams):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForGenerateKey):
- bindings/js/JSSubtleCryptoCustom.cpp:
- crypto/CryptoAlgorithmAesKeyGenParams.h: Removed.
- crypto/CryptoKey.cpp:
- crypto/CryptoKey.h:
- crypto/CryptoKeyAES.cpp:
- crypto/CryptoKeyAES.h:
- crypto/CryptoKeyMac.cpp: Removed.
- crypto/SubtleCrypto.idl:
- crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
- crypto/algorithms/CryptoAlgorithmHMAC.cpp:
- crypto/keys/CryptoKeyHMAC.cpp:
- crypto/keys/CryptoKeyHMAC.h:
- crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:
(WebCore::CryptoAlgorithmAES_CBC::generateKey):
- crypto/mac/CryptoAlgorithmHMACMac.cpp:
(WebCore::CryptoAlgorithmHMAC::generateKey):
LayoutTests:
- crypto/subtle/aes-cbc-generate-key-expected.txt: Removed.
- crypto/subtle/aes-cbc-generate-key.html: Removed.
- crypto/subtle/hmac-generate-key-expected.txt: Removed.
- crypto/subtle/hmac-generate-key.html: Removed.
- crypto/subtle/sha-1-expected.txt:
- 8:08 AM Changeset in webkit [158577] by
-
- 2 edits in trunk/Tools
[EFL] Change ATK version to 2.10.0
https://bugs.webkit.org/show_bug.cgi?id=123727
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-04
Reviewed by Mario Sanchez Prada.
Provided new API to retrieve text at a given offset.
- efl/jhbuild.modules:
- 8:04 AM Changeset in webkit [158576] by
-
- 6 edits in trunk
[EFL] accessibility/textarea-line-for-index.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112015
Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-11-04
Reviewed by Mario Sanchez Prada.
Tools:
Provided implementation for AccessibilityUIElement::lineForIndex().
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::lineForIndex): Implemented.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::lineForIndex): Implemented.
LayoutTests:
Removed failure expectations.
- platform/efl-wk1/TestExpectations: The test is no longer failing.
- platform/efl-wk2/TestExpectations: The test is no longer failing.
- 7:02 AM Changeset in webkit [158575] by
-
- 6 edits in trunk
[EFL] accessibility/button-press-action.html
https://bugs.webkit.org/show_bug.cgi?id=111993
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-04
Reviewed by Mario Sanchez Prada.
Tools:
Provided an implementation for AccessibilityUIElement::isPressActionSupported.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::isPressActionSupported):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::isPressActionSupported):
LayoutTests:
Removed failure expectations.
- platform/efl-wk1/TestExpectations:
- platform/efl-wk2/TestExpectations:
- 6:58 AM Changeset in webkit [158574] by
-
- 2 edits in trunk/Source/WebCore
[Texmap] Remove redundant calls in CoordinatedGraphicsScene
https://bugs.webkit.org/show_bug.cgi?id=123737
Patch by Przemyslaw Szymanski <p.szymanski3@samsung.com> on 2013-11-04
Reviewed by Noam Rosenthal.
Removing unused code left after few refactoring patches.
No new tests. Covered by existing ones.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext):
- 5:01 AM Changeset in webkit [158573] by
-
- 4 edits in trunk/Source/WebCore
CSSPrimitiveValue color constructors should return PassRef.
<https://webkit.org/b/123728>
Make CSSPrimitiveValue::createColor() and the corresponding
CSSValuePool helper functions return PassRef<CSSPrimitiveValue>.
Also made CSSValuePool slightly less stupid when hitting the upper
size limit on the color value cache: instead of throwing out cache
and rebuilding it from scratch, just remove one value at random.
Reviewed by Antti Koivisto.
- 4:55 AM Changeset in webkit [158572] by
-
- 3 edits in trunk/Source/WebCore
Some more RenderChildIterator deployment.
<https://webkit.org/b/123735>
Convert another handful of loops to use childrenOfType<RenderFoo>
iterators, mostly for skipping over uninteresting text renderers.
Reviewed by Antti Koivisto.
- 4:43 AM Changeset in webkit [158571] by
-
- 3 edits in trunk/Source/WebCore
LabelsNodeList always is always rooted at a LabelableElement.
<https://webkit.org/b/123730>
Tighten up LabelsNodeList by enforcing that it's only rooted to
a LabelableElement. Also marked the class FINAL and made its
create() helper return PassRef.
Reviewed by Antti Koivisto.
- 4:40 AM Changeset in webkit [158570] by
-
- 3 edits2 adds in trunk
REGRESSION: RenderStyle is leaked when not creating renderer for display:none
<https://webkit.org/b/123726>
Source/WebCore:
Explicitly drop the RenderStyle reference in RenderElement::createFor
if we decide to not create any renderer.
Reviewed by Antti Koivisto.
Test: fast/css/renderstyle-leak-with-display-none.html
- rendering/RenderElement.cpp:
(WebCore::RenderElement::createFor):
LayoutTests:
Reviewed by Antti Koivisto.
- fast/css/renderstyle-leak-with-display-none-expected.txt: Added.
- fast/css/renderstyle-leak-with-display-none.html: Added.
- 4:25 AM Changeset in webkit [158569] by
-
- 65 edits in trunk/Source/WebCore
[webcore/dom] Remove extra header includes from cpp files.
https://bugs.webkit.org/show_bug.cgi?id=123720
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-11-04
Reviewed by Andreas Kling.
Removing redundant headers from dom related cpp files.
- dom/Attr.cpp:
- dom/CharacterData.cpp:
- dom/ChildListMutationScope.cpp:
- dom/ChildNodeList.cpp:
- dom/ContainerNode.cpp:
- dom/ContainerNodeAlgorithms.cpp:
- dom/DOMNamedFlowCollection.cpp:
- dom/DatasetDOMStringMap.cpp:
- dom/Document.cpp:
- dom/DocumentEventQueue.cpp:
- dom/DocumentMarkerController.cpp:
- dom/DocumentOrderedMap.cpp:
- dom/DocumentStyleSheetCollection.cpp:
- dom/Element.cpp:
- dom/ElementRareData.cpp:
- dom/Event.cpp:
- dom/EventContext.cpp:
- dom/EventDispatcher.cpp:
- dom/EventTarget.cpp:
- dom/ExceptionBase.cpp:
- dom/FocusEvent.cpp:
- dom/InlineStyleSheetOwner.cpp:
- dom/KeyboardEvent.cpp:
- dom/LiveNodeList.cpp:
- dom/MessageEvent.cpp:
- dom/MessagePort.cpp:
- dom/MouseRelatedEvent.cpp:
- dom/MutationEvent.cpp:
- dom/MutationObserver.cpp:
- dom/MutationObserverInterestGroup.cpp:
- dom/MutationObserverRegistration.cpp:
- dom/MutationRecord.cpp:
- dom/NameNodeList.cpp:
- dom/NamedFlowCollection.cpp:
- dom/NamedNodeMap.cpp:
- dom/Node.cpp:
- dom/NodeIterator.cpp:
- dom/NodeTraversal.cpp:
- dom/PositionIterator.cpp:
- dom/ProcessingInstruction.cpp:
- dom/Range.cpp:
- dom/RegisteredEventListener.cpp:
- dom/ScopedEventQueue.cpp:
- dom/ScriptElement.cpp:
- dom/ScriptRunner.cpp:
- dom/SelectorQuery.cpp:
- dom/ShadowRoot.cpp:
- dom/StyledElement.cpp:
- dom/TagNodeList.cpp:
- dom/Text.cpp:
- dom/TextEvent.cpp:
- dom/TouchEvent.cpp:
- dom/TreeScope.cpp:
- dom/TreeScopeAdopter.cpp:
- dom/TreeWalker.cpp:
- dom/UIEvent.cpp:
- dom/UserActionElementSet.cpp:
- dom/UserTypingGestureIndicator.cpp:
- dom/VisitedLinkState.cpp:
- dom/WebKitNamedFlow.cpp:
- 4:22 AM Changeset in webkit [158568] by
-
- 3 edits in trunk/Source/WebCore
HTMLAllCollection is always rooted at a Document.
<https://webkit.org/b/123724>
Tighten up HTMLAllCollection by making the constructor take a
Document& instead of a ContainerNode&. Drive-by application of
FINAL and PassRef also happened.
Reviewed by Antti Koivisto.
- 4:21 AM Changeset in webkit [158567] by
-
- 10 edits in trunk/Source/WebCore
Make more CSSValue subclass constructors return PassRef.
<https://webkit.org/b/123731>
Make the constructor helpers for the following classes return
PassRef instead of PassRefPtr:
- CSSFontValue
- CSSImageSetValue
- CSSUnicodeRangeValue
- WebKitCSSArrayFunctionValue
- WebKitCSSFilterValue
- WebKitCSSMatFunctionValue
- WebKitCSSMixFunctionValue
- WebKitCSSShaderValue
- WebKitCSSTransformValue
Reviewed by Antti Koivisto.
- 4:16 AM Changeset in webkit [158566] by
-
- 2 edits in trunk/Source/WebCore
Buildfix after r158182 for GCC 4.6
https://bugs.webkit.org/show_bug.cgi?id=123442
Patch by Jozsef Berta <jberta@inf.u-szeged.hu> on 2013-11-04
Reviewed by Csaba Osztrogonác.
Added explicit "friend class", because GCC 4.6 doesn't support extended friend declaration (c++11)
- dom/ScopedEventQueue.h:
- 1:16 AM Changeset in webkit [158565] by
-
- 7 edits in trunk/Websites/test-results
Fix JSON generations on new flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=123723
Reviewed by Andreas Kling.
Add is_flaky column on results table so that this column can be used to find flaky tests on a given builder
efficiently without having to through results for all tests in PHP. This column is updated in report.php
when a new build is added. Because is_flaky depends on the preceding and succeeding results, we must update
is_flaky flag on results for builds immediately before and after the new build as well.
To see why, suppose we had two consecutive results [PASS] [PASS]. If we were to insert [FAIL] result between
the two, those two results may also turn into flaky results if they were surrounded by [FAIL]. Similarly,
if we had [PASS] [FAIL] and the second result was marked flaky, inserting new [FAIL] must unmark it.
- init-database.sql: Added is_flaky column to results table with an index. Also added an index on
build_revisions.time as many queries filter results by this quantity. Also set the work_mem to 50MB avoid
disk thrashing while sorting results in various queries.
- public/api/failing-tests.php: Handle builder ids as well as names. Call generate() with failure types.
No longer generates *-failing.json since it's a subset of *-wrongexpectations.json to save time.
- public/api/report.php: Rewritten. Calls update_flakiness_after_inserting_build to update is_flaky flags
on the newly added results.
(store_results): Added.
(main): Added.
- public/include/test-results.php:
(ResultsJSONWriter):
(ResultsJSONWriter::add_results_for_test): Renamed from add_results_for_test_if_matches.
(ResultsJSONGenerator::generate): Takes the failure type. Instead of generating JSONs for all failure types
at once, generate one JSON for the specified type. We generate the list of test ids based on the failure type
and query results based on that. This dramatically cuts down the time spent in PHP.
(ResultsJSONGenerator::latest_build): Added.
(ResultsJSONGenerator::write_jsons): Takes single writer now.
(update_flakiness_for_build): Added.
(update_flakiness_after_inserting_build): Added.
- public/index.html:
(TestResultsView._populateBuilderPane): Emulate *-failing.json upon *-wrongexpectations.json.
(TestResultsView.fetchFailingTestsForBuilder): Ditto.
- public/main.css: Minor style tweaks.
(.testResults): Extend the border that wraps the test results as needed.
(.tooltip): Don't wrap text inside tooltips.
- 12:53 AM Changeset in webkit [158564] by
-
- 4 edits in trunk/Source/WebCore
HTMLTableRowsCollection is always rooted at a HTMLTableElement.
<https://webkit.org/b/123721>
Tighten up HTMLTableRowsCollection by making the create() helper
take a HTMLTableElement& and adding a HTMLSelectElement& getter.
Reviewed by Antti Koivisto.
- 12:51 AM Changeset in webkit [158563] by
-
- 4 edits in trunk/Source/WebCore
HTMLNameCollection and friends are always rooted at a Document.
<https://webkit.org/b/123722>
Tighten WindowNameCollection and DocumentNameCollection by making
their constructors take a Document&, and add a slightly better
document() than the one we inherit from LiveNodeListBase.
Also marked the classes FINAL and made create() helpers return
PassRef instead of PassRefPtr.
Reviewed by Antti Koivisto.
- 12:49 AM Changeset in webkit [158562] by
-
- 1 edit11 moves12 deletes in trunk/LayoutTests
Optimize baselines: svg/zoom
Unreviewed; run "webkit-patch optimize-baselines svg/zoom"
- platform/gtk/svg/zoom/page/zoom-background-images-expected.txt: Removed.
- platform/gtk/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Removed.
- platform/gtk/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Removed.
- platform/gtk/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Removed.
- platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
- platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Removed.
- platform/gtk/svg/zoom/page/zoom-svg-as-image-expected.png: Removed.
- platform/gtk/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Removed.
- platform/gtk/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Removed.
- platform/gtk/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Removed.
- platform/gtk/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Removed.
- svg/zoom/page/zoom-background-images-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-background-images-expected.txt.
- svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt.
- svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt.
- svg/zoom/page/zoom-mask-with-percentages-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-mask-with-percentages-expected.txt.
- svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt.
- svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt.
- svg/zoom/page/zoom-svg-as-image-expected.png: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-svg-as-image-expected.png.
- svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-svg-float-border-padding-expected.txt.
- svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
- svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt.
- svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt.
- svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/text/zoom-svg-float-border-padding-expected.txt.
- 12:46 AM Changeset in webkit [158561] by
-
- 13 edits1 add in trunk/Source/WebCore
Add an ancestor renderer iterator.
<https://webkit.org/b/123718>
Add ancestor iterators for renderers, analogous to element ancestor
iterators. They walk the chain of parent renderers, stopping at each
ancestor of a certain type.
Just like child renderer iterators, this requires isRendererOfType()
to be implemented for the targeted renderer class.
You use them like this:
auto frameSets = ancestorsOfType<RenderFrameSet>(*this);
for (auto frameSet = frameSets.begin(), end = frameSets.end(); frameSet != end; ++frameSet)
frameSet->thisOrThat();
To complete the patch, I put them to use in a couple of random places.
Reviewed by Antti Koivisto.
- 12:40 AM Changeset in webkit [158560] by
-
- 2 edits14 moves2 adds11 deletes in trunk/LayoutTests
Optimize baselines: fast/images
Unreviewed; run "webkit-patch optimize-baselines fast/images"
- fast/images/crossfade-client-not-removed-crash-expected.txt:
- fast/images/embed-image-expected.png: Renamed from LayoutTests/platform/efl/fast/images/embed-image-expected.png.
- fast/images/exif-orientation-css-expected.txt: Renamed from LayoutTests/platform/efl/fast/images/exif-orientation-css-expected.txt.
- fast/images/exif-orientation-expected.txt: Renamed from LayoutTests/platform/efl/fast/images/exif-orientation-expected.txt.
- fast/images/icon-decoding-expected.txt: Renamed from LayoutTests/platform/efl/fast/images/icon-decoding-expected.txt.
- fast/images/image-in-map-expected.png: Renamed from LayoutTests/platform/efl/fast/images/image-in-map-expected.png.
- fast/images/image-in-map-expected.txt: Renamed from LayoutTests/platform/efl/fast/images/image-in-map-expected.txt.
- fast/images/imagemap-focus-ring-zoom-expected.txt: Renamed from LayoutTests/platform/efl/fast/images/imagemap-focus-ring-zoom-expected.txt.
- fast/images/support-broken-image-delegate-expected.txt: Renamed from LayoutTests/platform/gtk/fast/images/support-broken-image-delegate-expected.txt.
- platform/efl-wk2/fast/images/imagemap-circle-focus-ring-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-circle-focus-ring-expected.png.
- platform/efl-wk2/fast/images/imagemap-focus-ring-outline-color-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-focus-ring-outline-color-expected.png.
- platform/efl-wk2/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png.
- platform/efl-wk2/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png.
- platform/efl-wk2/fast/images/imagemap-polygon-focus-ring-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-polygon-focus-ring-expected.png.
- platform/efl/fast/images/crossfade-client-not-removed-crash-expected.txt: Removed.
- platform/gtk/fast/images/crossfade-client-not-removed-crash-expected.txt: Removed.
- platform/gtk/fast/images/embed-image-expected.png: Removed.
- platform/gtk/fast/images/exif-orientation-css-expected.txt: Removed.
- platform/gtk/fast/images/icon-decoding-expected.txt: Removed.
- platform/gtk/fast/images/image-in-map-expected.png: Removed.
- platform/gtk/fast/images/image-in-map-expected.txt: Removed.
- platform/gtk/fast/images/imagemap-focus-ring-zoom-expected.txt: Removed.
- platform/mac/fast/images/crossfade-client-not-removed-crash-expected.txt: Removed.
- platform/mac/fast/images/exif-orientation-css-expected.txt: Removed.
- platform/mac/fast/images/exif-orientation-expected.txt: Removed.
- platform/win-7sp0/fast/images/support-broken-image-delegate-expected.txt: Renamed from LayoutTests/platform/win/fast/images/support-broken-image-delegate-expected.txt.
- 12:28 AM Changeset in webkit [158559] by
-
- 7 edits in trunk/Source/WebCore
[CSSRegions] Use auto keyword to clean-up for loops
https://bugs.webkit.org/show_bug.cgi?id=123699
Reviewed by Anders Carlsson.
Start using auto keyword for loops.
Also, since region breaks (forced breaks) can be added only on boxes,
i changed RenderFlowThread::addForcedRegionBreak to use a RenderBox* instead of RenderObject*.
No change in functionality, no new tests.
- dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::firstEmptyRegionIndex):
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::ensureRenderFlowThreadWithName):
(WebCore::FlowThreadController::styleDidChange):
(WebCore::FlowThreadController::layoutRenderNamedFlowThreads):
(WebCore::FlowThreadController::updateFlowThreadsChainIfNecessary):
(WebCore::FlowThreadController::updateFlowThreadsNeedingLayout):
(WebCore::FlowThreadController::updateFlowThreadsNeedingTwoStepLayout):
(WebCore::FlowThreadController::resetFlowThreadsWithAutoHeightRegions):
(WebCore::FlowThreadController::updateFlowThreadsIntoConstrainedPhase):
(WebCore::FlowThreadController::updateFlowThreadsIntoOverflowPhase):
(WebCore::FlowThreadController::updateFlowThreadsIntoMeasureContentPhase):
(WebCore::FlowThreadController::updateFlowThreadsIntoFinalPhase):
(WebCore::FlowThreadController::updateRenderFlowThreadLayersIfNeeded):
(WebCore::FlowThreadController::collectFixedPositionedLayers):
(WebCore::FlowThreadController::isAutoLogicalHeightRegionsCountConsistent):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::validateRegions):
(WebCore::RenderFlowThread::hasCompositingRegionDescendant):
(WebCore::RenderFlowThread::getLayerListForRegion):
(WebCore::RenderFlowThread::updateLayerToRegionMappings):
(WebCore::RenderFlowThread::updateLogicalWidth):
(WebCore::RenderFlowThread::computeLogicalHeight):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
(WebCore::RenderFlowThread::logicalWidthChangedInRegionsForBlock):
(WebCore::RenderFlowThread::clearRenderObjectCustomStyle):
(WebCore::RenderFlowThread::clearRenderBoxRegionInfoAndCustomStyle):
(WebCore::RenderFlowThread::setRegionRangeForBox):
(WebCore::RenderFlowThread::getRegionRangeForBox):
(WebCore::RenderFlowThread::regionInRange):
(WebCore::RenderFlowThread::checkRegionsWithStyling):
(WebCore::RenderFlowThread::objectInFlowRegion):
(WebCore::RenderFlowThread::isAutoLogicalHeightRegionsCountConsistent):
(WebCore::RenderFlowThread::initializeRegionsComputedAutoHeight):
(WebCore::RenderFlowThread::markAutoLogicalHeightRegionsForLayout):
(WebCore::RenderFlowThread::markRegionsForOverflowLayoutIfNeeded):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::addForcedRegionBreak):
(WebCore::RenderFlowThread::collectLayerFragments):
(WebCore::RenderFlowThread::fragmentsBoundingBox):
(WebCore::RenderFlowThread::addRegionsVisualEffectOverflow):
(WebCore::RenderFlowThread::addRegionsVisualOverflowFromTheme):
(WebCore::RenderFlowThread::addRegionsOverflowFromChild):
(WebCore::RenderFlowThread::addRegionsLayoutOverflow):
(WebCore::RenderFlowThread::clearRegionsOverflow):
- rendering/RenderFlowThread.h:
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::nextRendererForNode):
(WebCore::RenderNamedFlowThread::previousRendererForNode):
(WebCore::RenderNamedFlowThread::dependsOn):
(WebCore::addRegionToList):
(WebCore::RenderNamedFlowThread::computeOversetStateForRegions):
(WebCore::RenderNamedFlowThread::checkInvalidRegions):
(WebCore::RenderNamedFlowThread::pushDependencies):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::setRegionObjectsRegionStyle):
(WebCore::RenderRegion::restoreRegionObjectsOriginalStyle):
(WebCore::RenderRegion::computeChildrenStyleInRegion):
- 12:12 AM GStreamer/GStreamerOnMac edited by
- (diff)
Nov 3, 2013:
- 11:10 PM Changeset in webkit [158558] by
-
- 3 edits in trunk/Source/WebCore
PingLoader objects unnecessarily pass through OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=122942
Reviewed by Darin Adler.
There's no need to store new PingLoader objects into an OwnPtr just to leak them out a few lines later
into an unused variable. New objects are created through a new helper method and then left unmanaged as
they're guaranteed to destroy themselves when they receive a response of any kind.
- loader/PingLoader.cpp:
(WebCore::PingLoader::loadImage): Call the new createPingLoader method to spawn the PingLoader.
(WebCore::PingLoader::sendPing): Ditto.
(WebCore::PingLoader::sendViolationReport): Ditto.
(WebCore::PingLoader::createPingLoader): A helper method that creates a new PingLoader object
- loader/PingLoader.h: Declare the new PingLoader::createPingLoader method.
- 11:02 PM MathML 3 testsuite results edited by
- updating msqrt tests 6,7,8 to reflect progress. (diff)
- 10:55 PM MathML 3 testsuite results edited by
- updating mrow test 2 to reflect progress. (diff)
- 10:54 PM Changeset in webkit [158557] by
-
- 7 edits in trunk/Source/WebCore
HTMLOptionsCollection is always rooted at a HTMLSelectElement.
<https://webkit.org/b/123719>
Tighten up HTMLOptionsCollection by making the constructor take
a HTMLSelectElement& and adding a HTMLSelectElement& getter instead
of casting all over the place. Removed now-pointless assertions.
Reviewed by Sam Weinig.
- 10:53 PM MathML 3 testsuite results edited by
- Updated test results for mover 7,8,10,11,12 to reflect progress. (diff)
- 10:50 PM MathML 3 testsuite results edited by
- Updated test results for mover 1-5 to reflect progress. (diff)
- 9:55 PM MathML 3 testsuite results edited by
- Updated mfrac results for tests 2,3, and 4. (diff)
- 8:24 PM Changeset in webkit [158556] by
-
- 3 edits3 adds in trunk
Generated color wheel displays incorrectly (regressed in r155567)
https://bugs.webkit.org/show_bug.cgi?id=123664
Source/JavaScriptCore:
Reviewed by Andreas Kling.
Interestingly, r155567 just "un-broke" the attempt to constant-fold ArithMod, but
that constant folding was just wrong to begin with. There is no evidence that this
constant folding rule is profitable. I'm removing it instead of trying to think
about what it means for it to be correct.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
LayoutTests:
Reviewed by Andreas Kling.
- js/dfg-mod-1-expected.txt: Added.
- js/dfg-mod-1.html: Added.
- js/script-tests/dfg-mod-1.js: Added.
(foo):
- 8:12 PM Changeset in webkit [158555] by
-
- 1 edit66 moves70 deletes in trunk/LayoutTests
Optimize baselines: fast/repaint
Unreviewed; run "webkit-patch optimize-baselines fast/repaint"
- fast/repaint/4774354-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/4774354-expected.txt.
- fast/repaint/absolute-position-changed-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/absolute-position-changed-expected.png.
- fast/repaint/block-selection-gap-stale-cache-2-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/block-selection-gap-stale-cache-2-expected.png.
- fast/repaint/block-selection-gap-stale-cache-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/block-selection-gap-stale-cache-expected.png.
- fast/repaint/box-shadow-inset-repaint-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/box-shadow-inset-repaint-expected.txt.
- fast/repaint/button-spurious-layout-hint-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/button-spurious-layout-hint-expected.png.
- fast/repaint/canvas-putImageData-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/canvas-putImageData-expected.png.
- fast/repaint/clip-with-layout-delta-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/clip-with-layout-delta-expected.txt.
- fast/repaint/content-into-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/content-into-overflow-expected.png.
- fast/repaint/erase-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/erase-overflow-expected.png.
- fast/repaint/fixed-after-scroll-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-after-scroll-expected.png.
- fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-and-absolute-position-scrolled-expected.png.
- fast/repaint/fixed-position-transparency-with-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-position-transparency-with-overflow-expected.png.
- fast/repaint/fixed-scale-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-scale-expected.png.
- fast/repaint/fixed-scroll-simple-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-scroll-simple-expected.png.
- fast/repaint/fixed-table-cell-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-table-cell-expected.png.
- fast/repaint/fixed-table-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-table-overflow-expected.png.
- fast/repaint/fixed-table-overflow-zindex-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-table-overflow-zindex-expected.png.
- fast/repaint/fixed-tranformed-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-tranformed-expected.png.
- fast/repaint/float-in-new-block-with-layout-delta-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/float-in-new-block-with-layout-delta-expected.png.
- fast/repaint/float-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/float-overflow-expected.txt.
- fast/repaint/float-overflow-right-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/float-overflow-right-expected.txt.
- fast/repaint/inline-block-resize-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/inline-block-resize-expected.png.
- fast/repaint/inline-horizontal-bt-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/inline-horizontal-bt-overflow-expected.txt.
- fast/repaint/inline-vertical-lr-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/inline-vertical-lr-overflow-expected.png.
- fast/repaint/inline-vertical-lr-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/inline-vertical-lr-overflow-expected.txt.
- fast/repaint/inline-vertical-rl-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/inline-vertical-rl-overflow-expected.png.
- fast/repaint/inline-vertical-rl-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/inline-vertical-rl-overflow-expected.txt.
- fast/repaint/intermediate-layout-position-clip-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/intermediate-layout-position-clip-expected.png.
- fast/repaint/japanese-rl-selection-clear-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/japanese-rl-selection-clear-expected.txt.
- fast/repaint/japanese-rl-selection-repaint-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/japanese-rl-selection-repaint-expected.txt.
- fast/repaint/layer-hide-when-needs-layout-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/layer-hide-when-needs-layout-expected.png.
- fast/repaint/layer-visibility-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/layer-visibility-expected.png.
- fast/repaint/line-in-scrolled-clipped-block-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/line-in-scrolled-clipped-block-expected.txt.
- fast/repaint/moving-shadow-on-path-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/moving-shadow-on-path-expected.txt.
- fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png.
- fast/repaint/overflow-clip-subtree-layout-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/overflow-clip-subtree-layout-expected.png.
- fast/repaint/overflow-into-content-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/overflow-into-content-expected.png.
- fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png.
- fast/repaint/reflection-repaint-test-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/reflection-repaint-test-expected.txt.
- fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.txt.
- fast/repaint/repaint-during-scroll-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/repaint-during-scroll-expected.png.
- fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/repaint-during-scroll-with-zoom-expected.txt.
- fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/scroll-absolute-layer-with-reflection-expected.png.
- fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png.
- fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/scroll-fixed-layer-with-reflection-expected.png.
- fast/repaint/scroll-fixed-reflected-layer-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/scroll-fixed-reflected-layer-expected.png.
- fast/repaint/scroll-in-clipped-layer-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/scroll-in-clipped-layer-expected.png.
- fast/repaint/scroll-in-fixed-layer-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/scroll-in-fixed-layer-expected.png.
- fast/repaint/subtree-root-clip-2-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/subtree-root-clip-2-expected.png.
- fast/repaint/subtree-root-clip-3-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/subtree-root-clip-3-expected.png.
- fast/repaint/subtree-root-clip-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/subtree-root-clip-expected.png.
- fast/repaint/table-cell-vertical-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/table-cell-vertical-overflow-expected.txt.
- fast/repaint/table-col-background-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/table-col-background-expected.png.
- fast/repaint/table-outer-border-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/table-outer-border-expected.png.
- fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png.
- fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png.
- fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png.
- fast/repaint/table-row-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/table-row-expected.png.
- fast/repaint/table-section-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/table-section-overflow-expected.png.
- fast/repaint/transform-layout-repaint-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/transform-layout-repaint-expected.txt.
- fast/repaint/view-background-from-body-1-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/view-background-from-body-1-expected.png.
- fast/repaint/view-background-from-body-2-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/view-background-from-body-2-expected.png.
- platform/efl-wk2/fast/repaint/selection-after-delete-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/selection-after-delete-expected.png.
- platform/efl-wk2/fast/repaint/selection-after-remove-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/selection-after-remove-expected.png.
- platform/efl-wk2/fast/repaint/selection-gap-overflow-scroll-2-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/selection-gap-overflow-scroll-2-expected.png.
- platform/gtk/fast/repaint/4774354-expected.txt: Removed.
- platform/gtk/fast/repaint/absolute-position-changed-expected.png: Removed.
- platform/gtk/fast/repaint/block-selection-gap-stale-cache-2-expected.png: Removed.
- platform/gtk/fast/repaint/block-selection-gap-stale-cache-expected.png: Removed.
- platform/gtk/fast/repaint/box-shadow-inset-repaint-expected.txt: Removed.
- platform/gtk/fast/repaint/button-spurious-layout-hint-expected.png: Removed.
- platform/gtk/fast/repaint/canvas-putImageData-expected.png: Removed.
- platform/gtk/fast/repaint/clip-with-layout-delta-expected.txt: Removed.
- platform/gtk/fast/repaint/content-into-overflow-expected.png: Removed.
- platform/gtk/fast/repaint/erase-overflow-expected.png: Removed.
- platform/gtk/fast/repaint/fixed-after-scroll-expected.png: Removed.
- platform/gtk/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Removed.
- platform/gtk/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Removed.
- platform/gtk/fast/repaint/fixed-scale-expected.png: Removed.
- platform/gtk/fast/repaint/fixed-scroll-simple-expected.png: Removed.
- platform/gtk/fast/repaint/fixed-table-cell-expected.png: Removed.
- platform/gtk/fast/repaint/fixed-table-overflow-expected.png: Removed.
- platform/gtk/fast/repaint/fixed-table-overflow-zindex-expected.png: Removed.
- platform/gtk/fast/repaint/fixed-tranformed-expected.png: Removed.
- platform/gtk/fast/repaint/float-in-new-block-with-layout-delta-expected.png: Removed.
- platform/gtk/fast/repaint/inline-block-resize-expected.png: Removed.
- platform/gtk/fast/repaint/inline-horizontal-bt-overflow-expected.txt: Removed.
- platform/gtk/fast/repaint/inline-vertical-lr-overflow-expected.png: Removed.
- platform/gtk/fast/repaint/inline-vertical-lr-overflow-expected.txt: Removed.
- platform/gtk/fast/repaint/inline-vertical-rl-overflow-expected.png: Removed.
- platform/gtk/fast/repaint/inline-vertical-rl-overflow-expected.txt: Removed.
- platform/gtk/fast/repaint/intermediate-layout-position-clip-expected.png: Removed.
- platform/gtk/fast/repaint/japanese-rl-selection-clear-expected.txt: Removed.
- platform/gtk/fast/repaint/japanese-rl-selection-repaint-expected.txt: Removed.
- platform/gtk/fast/repaint/layer-hide-when-needs-layout-expected.png: Removed.
- platform/gtk/fast/repaint/layer-visibility-expected.png: Removed.
- platform/gtk/fast/repaint/line-in-scrolled-clipped-block-expected.txt: Removed.
- platform/gtk/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
- platform/gtk/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Removed.
- platform/gtk/fast/repaint/overflow-clip-subtree-layout-expected.png: Removed.
- platform/gtk/fast/repaint/overflow-into-content-expected.png: Removed.
- platform/gtk/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Removed.
- platform/gtk/fast/repaint/reflection-repaint-test-expected.txt: Removed.
- platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Removed.
- platform/gtk/fast/repaint/repaint-during-scroll-expected.png: Removed.
- platform/gtk/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Removed.
- platform/gtk/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Removed.
- platform/gtk/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Removed.
- platform/gtk/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Removed.
- platform/gtk/fast/repaint/scroll-fixed-reflected-layer-expected.png: Removed.
- platform/gtk/fast/repaint/scroll-in-clipped-layer-expected.png: Removed.
- platform/gtk/fast/repaint/scroll-in-fixed-layer-expected.png: Removed.
- platform/gtk/fast/repaint/subtree-root-clip-2-expected.png: Removed.
- platform/gtk/fast/repaint/subtree-root-clip-3-expected.png: Removed.
- platform/gtk/fast/repaint/subtree-root-clip-expected.png: Removed.
- platform/gtk/fast/repaint/table-cell-vertical-overflow-expected.txt: Removed.
- platform/gtk/fast/repaint/table-col-background-expected.png: Removed.
- platform/gtk/fast/repaint/table-outer-border-expected.png: Removed.
- platform/gtk/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Removed.
- platform/gtk/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Removed.
- platform/gtk/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Removed.
- platform/gtk/fast/repaint/table-row-expected.png: Removed.
- platform/gtk/fast/repaint/table-section-overflow-expected.png: Removed.
- platform/gtk/fast/repaint/transform-layout-repaint-expected.txt: Removed.
- platform/gtk/fast/repaint/view-background-from-body-1-expected.png: Removed.
- platform/gtk/fast/repaint/view-background-from-body-2-expected.png: Removed.
- platform/mac-wk2/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Removed.
- platform/mac/fast/repaint/box-shadow-inset-repaint-expected.txt: Removed.
- platform/mac/fast/repaint/float-overflow-expected.txt: Removed.
- platform/mac/fast/repaint/float-overflow-right-expected.txt: Removed.
- platform/mac/fast/repaint/inline-horizontal-bt-overflow-expected.txt: Removed.
- platform/mac/fast/repaint/inline-vertical-lr-overflow-expected.txt: Removed.
- platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.txt: Removed.
- platform/mac/fast/repaint/table-cell-vertical-overflow-expected.txt: Removed.
- platform/win/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Removed.
- 7:21 PM Changeset in webkit [158554] by
-
- 5 edits in trunk
Source/JavaScriptCore: Unreviewed, it is no longer necessary to call DisablePrettyStackTrace.
- llvm/library/LLVMExports.cpp:
(initializeAndGetJSCLLVMAPI):
WebKitLibraries: Update binary drops to a version that includes my pretty stack trace changes.
- LLVMIncludesMountainLion.tar.bz2:
- LLVMLibrariesMountainLion.tar.bz2:
- 7:01 PM Changeset in webkit [158553] by
-
- 4 edits in trunk/Source/WebKit2
[Cocoa] Wrappers' -copyWithZone: should copy if the collection is mutable
https://bugs.webkit.org/show_bug.cgi?id=123707
Reviewed by Geoff Garen and Anders Carlsson.
- Shared/Cocoa/WKNSArray.mm:
(-[WKNSArray copyWithZone:]): If the array is mutable, make a copy.
- Shared/Cocoa/WKNSDictionary.mm:
(-[WKNSDictionary copyWithZone:]): If the dictionary is mutable, make a copy.
- Shared/ImmutableArray.h:
(WebKit::ImmutableArray::entries): Added this accessor.
- 6:57 PM Changeset in webkit [158552] by
-
- 4 edits in trunk/Source/WebKit2
Reverted r158538.
- Shared/Cocoa/WKNSArray.mm:
(-[WKNSArray copyWithZone:]):
- Shared/Cocoa/WKNSDictionary.mm:
(-[WKNSDictionary copyWithZone:]):
- Shared/ImmutableArray.h:
- 4:39 PM Changeset in webkit [158551] by
-
- 5 edits in trunk/Source/WebCore
RenderTextFragment: Tighten first-letter logic.
<https://webkit.org/b/123714>
Reviewed by Antti Koivisto.
- editing/TextIterator.cpp:
(WebCore::firstRenderTextInFirstLetter):
Use iterator helper to find first RenderText child.
(WebCore::TextIterator::handleTextNodeFirstLetter):
Tightening through type inference.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetterStyle):
(WebCore::RenderBlock::createFirstLetterRenderer):
- rendering/RenderTextFragment.h:
The first letter renderer is always a RenderBoxModelObject,
so make the code deal in that instead of RenderObject.
- rendering/RenderChildIterator.h:
(WebCore::RenderChildIteratorAdapter::first):
(WebCore::RenderChildIteratorAdapter::last):
Remove excess ampersands that were keeping this from building.
- 4:35 PM Changeset in webkit [158550] by
-
- 2 edits2 copies12 moves2 adds13 deletes in trunk/LayoutTests
Optimize baselines: fast/forms
Unreviewed; run "webkit-patch optimize-baselines fast/forms"
- fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt:
- fast/forms/fieldset-with-float-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/fieldset-with-float-expected.txt.
- fast/forms/input-no-renderer-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/input-no-renderer-expected.txt.
- fast/forms/label/labelable-elements-expected.txt: Renamed from LayoutTests/platform/gtk/fast/forms/label/labelable-elements-expected.txt.
- fast/forms/range/slider-thumb-stylability-expected.png: Renamed from LayoutTests/platform/efl/fast/forms/range/slider-thumb-stylability-expected.png.
- fast/forms/select-listbox-multiple-no-focusring-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/select-listbox-multiple-no-focusring-expected.txt.
- fast/forms/select-overflow-scroll-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/select-overflow-scroll-expected.txt.
- fast/forms/select-overflow-scroll-inherited-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/select-overflow-scroll-inherited-expected.txt.
- fast/forms/textfield-overflow-by-value-update-expected.png: Renamed from LayoutTests/platform/efl/fast/forms/textfield-overflow-by-value-update-expected.png.
- fast/forms/textfield-overflow-by-value-update-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/textfield-overflow-by-value-update-expected.txt.
- platform/efl-wk2/fast/forms/validation-message-appearance-expected.png: Renamed from LayoutTests/platform/efl/fast/forms/validation-message-appearance-expected.png.
- platform/gtk/fast/forms/fieldset-with-float-expected.txt: Removed.
- platform/gtk/fast/forms/input-no-renderer-expected.txt: Removed.
- platform/gtk/fast/forms/range/slider-thumb-stylability-expected.png: Removed.
- platform/gtk/fast/forms/select-listbox-multiple-no-focusring-expected.txt: Removed.
- platform/gtk/fast/forms/select-overflow-scroll-expected.txt: Removed.
- platform/gtk/fast/forms/select-overflow-scroll-inherited-expected.txt: Removed.
- platform/gtk/fast/forms/textfield-overflow-by-value-update-expected.png: Removed.
- platform/mac/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Removed.
- platform/mac/fast/forms/label/labelable-elements-expected.txt: Removed.
- platform/mac/fast/forms/textfield-overflow-by-value-update-expected.txt: Removed.
- platform/win-7sp0/fast/forms/cursor-at-editable-content-boundary-expected.txt: Renamed from LayoutTests/platform/win/fast/forms/cursor-at-editable-content-boundary-expected.txt.
- platform/win-7sp0/fast/forms/implicit-submission-expected.txt: Renamed from LayoutTests/platform/win/fast/forms/implicit-submission-expected.txt.
- platform/win-7sp0/fast/forms/range/slider-mouse-events-expected.txt: Renamed from LayoutTests/platform/win/fast/forms/range/slider-mouse-events-expected.txt.
- platform/win-7sp0/fast/forms/select-popup-pagekeys-expected.txt: Renamed from LayoutTests/platform/win/fast/forms/select-popup-pagekeys-expected.txt.
- platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Removed.
- 4:15 PM Changeset in webkit [158549] by
-
- 4 edits in trunk/Source/WebCore
CSSPrimitiveValue identifier constructors should return PassRef.
<https://webkit.org/b/123712>
Make CSSPrimitiveValue::createIdentifier() and the corresponding
CSSValuePool helper return PassRef<CSSPrimitiveValue>.
Reviewed by Antti Koivisto.
- 4:13 PM Changeset in webkit [158548] by
-
- 4 edits in trunk/Source/WebCore
Use RenderChildIterator in two more loops.
<https://webkit.org/b/123713>
Switch two more renderer child traversal loops to childrenOfType.
Reviewed by Antti Koivisto.
- 3:43 PM Changeset in webkit [158547] by
-
- 2 edits36 moves2 adds36 deletes in trunk/LayoutTests
Optimize baselines: editing
Unreviewed; run "webkit-patch optimize-baselines editing"
- editing/deleting/delete-3775172-fix-expected.png: Renamed from LayoutTests/platform/efl/editing/deleting/delete-3775172-fix-expected.png.
- editing/deleting/delete-after-span-ws-001-expected.txt: Renamed from LayoutTests/platform/efl/editing/deleting/delete-after-span-ws-001-expected.txt.
- editing/deleting/delete-after-span-ws-002-expected.txt: Renamed from LayoutTests/platform/efl/editing/deleting/delete-after-span-ws-002-expected.txt.
- editing/deleting/delete-after-span-ws-003-expected.txt: Renamed from LayoutTests/platform/efl/editing/deleting/delete-after-span-ws-003-expected.txt.
- editing/deleting/delete-at-start-or-end-expected.txt: Renamed from LayoutTests/platform/efl/editing/deleting/delete-at-start-or-end-expected.txt.
- editing/deleting/delete-br-002-expected.txt: Renamed from LayoutTests/platform/mac/editing/deleting/delete-br-002-expected.txt.
- editing/deleting/delete-br-004-expected.txt: Renamed from LayoutTests/platform/mac/editing/deleting/delete-br-004-expected.txt.
- editing/deleting/delete-br-005-expected.txt: Renamed from LayoutTests/platform/mac/editing/deleting/delete-br-005-expected.txt.
- editing/deleting/delete-br-006-expected.txt: Renamed from LayoutTests/platform/mac/editing/deleting/delete-br-006-expected.txt.
- editing/deleting/delete-line-end-ws-001-expected.txt: Renamed from LayoutTests/platform/efl/editing/deleting/delete-line-end-ws-001-expected.txt.
- editing/deleting/delete-line-end-ws-002-expected.txt: Renamed from LayoutTests/platform/efl/editing/deleting/delete-line-end-ws-002-expected.txt.
- editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt:
- editing/inserting/insert-3851164-fix-expected.png: Renamed from LayoutTests/platform/efl/editing/inserting/insert-3851164-fix-expected.png.
- editing/selection/5195166-1-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/5195166-1-expected.txt.
- editing/selection/editable-links-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/editable-links-expected.txt.
- editing/selection/focus-body-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/focus-body-expected.txt.
- editing/selection/select-all-001-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/select-all-001-expected.txt.
- editing/selection/select-all-002-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/select-all-002-expected.txt.
- editing/selection/select-all-003-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/select-all-003-expected.txt.
- editing/selection/select-all-004-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/select-all-004-expected.txt.
- editing/selection/unrendered-001-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/unrendered-001-expected.txt.
- editing/selection/unrendered-002-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/unrendered-002-expected.txt.
- editing/selection/unrendered-003-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/unrendered-003-expected.txt.
- editing/selection/unrendered-004-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/unrendered-004-expected.txt.
- editing/selection/unrendered-005-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/unrendered-005-expected.txt.
- editing/undo/5378473-expected.txt: Renamed from LayoutTests/platform/efl/editing/undo/5378473-expected.txt.
- editing/undo/undo-misspellings-expected.txt: Renamed from LayoutTests/platform/efl/editing/undo/undo-misspellings-expected.txt.
- editing/unsupported-content/table-delete-001-expected.txt: Renamed from LayoutTests/platform/efl/editing/unsupported-content/table-delete-001-expected.txt.
- editing/unsupported-content/table-delete-003-expected.png: Renamed from LayoutTests/platform/efl/editing/unsupported-content/table-delete-003-expected.png.
- editing/unsupported-content/table-delete-003-expected.txt: Renamed from LayoutTests/platform/efl/editing/unsupported-content/table-delete-003-expected.txt.
- platform/efl-wk2/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Renamed from LayoutTests/platform/efl/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt.
- platform/efl/editing/caret/caret-color-expected.txt: Renamed from LayoutTests/editing/caret/caret-color-expected.txt.
- platform/efl/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-3775172-fix-expected.png: Removed.
- platform/gtk/editing/deleting/delete-after-span-ws-001-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-after-span-ws-002-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-after-span-ws-003-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-line-end-ws-001-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-line-end-ws-002-expected.txt: Removed.
- platform/gtk/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Removed.
- platform/gtk/editing/inserting/insert-3851164-fix-expected.png: Removed.
- platform/gtk/editing/selection/editable-links-expected.txt: Removed.
- platform/gtk/editing/selection/focus-body-expected.txt: Removed.
- platform/gtk/editing/selection/select-all-001-expected.txt: Removed.
- platform/gtk/editing/selection/select-all-002-expected.txt: Removed.
- platform/gtk/editing/selection/select-all-003-expected.txt: Removed.
- platform/gtk/editing/selection/select-all-004-expected.txt: Removed.
- platform/gtk/editing/selection/unrendered-001-expected.txt: Removed.
- platform/gtk/editing/selection/unrendered-002-expected.txt: Removed.
- platform/gtk/editing/selection/unrendered-003-expected.txt: Removed.
- platform/gtk/editing/selection/unrendered-004-expected.txt: Removed.
- platform/gtk/editing/selection/unrendered-005-expected.txt: Removed.
- platform/mac/editing/deleting/delete-at-start-or-end-expected.txt: Removed.
- platform/mac/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Removed.
- platform/mac/editing/inserting/insert-div-010-expected.txt: Renamed from LayoutTests/editing/inserting/insert-div-010-expected.txt.
- platform/mac/editing/selection/5195166-1-expected.txt: Removed.
- platform/mac/editing/style/unbold-in-bold-expected.txt: Renamed from LayoutTests/editing/style/unbold-in-bold-expected.txt.
- platform/mac/editing/undo/5378473-expected.txt: Removed.
- platform/mac/editing/undo/undo-misspellings-expected.txt: Removed.
- platform/mac/editing/unsupported-content/table-delete-001-expected.txt: Removed.
- platform/mac/editing/unsupported-content/table-delete-003-expected.png: Removed.
- platform/mac/editing/unsupported-content/table-delete-003-expected.txt: Removed.
- platform/win-7sp0/editing/selection/collapse-selection-in-bidi-expected.txt: Renamed from LayoutTests/platform/win/editing/selection/collapse-selection-in-bidi-expected.txt.
- platform/win-7sp0/editing/selection/drag-text-delay-expected.txt: Renamed from LayoutTests/platform/win/editing/selection/drag-text-delay-expected.txt.
- platform/win-7sp0/editing/selection/extend-selection-home-end-expected.txt: Renamed from LayoutTests/platform/win/editing/selection/extend-selection-home-end-expected.txt.
- platform/win/editing/deleting/delete-br-002-expected.txt: Removed.
- platform/win/editing/deleting/delete-br-004-expected.txt: Removed.
- platform/win/editing/deleting/delete-br-005-expected.txt: Removed.
- platform/win/editing/deleting/delete-br-006-expected.txt: Removed.
- platform/win/editing/deleting/delete-br-009-expected.txt: Removed.
- platform/win/editing/inserting/insert-3800346-fix-expected.txt: Removed.
- platform/win/editing/selection/anchor-focus2-expected.txt: Removed.
- platform/win/editing/selection/anchor-focus3-expected.txt: Removed.
- 3:32 PM Changeset in webkit [158546] by
-
- 3 edits55 moves2 adds80 deletes in trunk/LayoutTests
Optimize baselines: tables
Unreviewed; run "webkit-patch optimize-baselines tables"
- platform/gtk/tables/mozilla/bugs/adforce_imgis_com-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug102145-1-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug102145-2-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug102145-3-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug102145-4-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug10269-1-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug10296-2-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug103533-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug11321-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug12908-2-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug13105-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug14159-3-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug149275-2-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug1818-6-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug196870-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug222336-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug222467-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug23072-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug23151-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug23994-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug26553-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug269566-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug27038-3-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug275625-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug277062-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug2886-2-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug28933-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug3037-1-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug3037-2-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug32447-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug34538-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug56405-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug641-2-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug75250-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug8032-2-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug8361-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug9024-expected.png: Removed.
- platform/gtk/tables/mozilla/core/col_widths_fix_autoFixPer-expected.png: Removed.
- platform/gtk/tables/mozilla/marvin/table_overflow_hidden_td-expected.txt: Removed.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug128876-expected.png: Removed.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug178855-expected.png: Removed.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3517-expected.png: Removed.
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.png: Removed.
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt: Removed.
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt: Removed.
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt: Removed.
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt: Removed.
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug120107-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug1271-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug12908-2-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug12910-2-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug131020-2-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug13169-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug137388-1-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug137388-2-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug137388-3-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug157890-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug1818-3-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug1818-6-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug196870-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug222336-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug222467-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug269566-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug277062-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug28933-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug29314-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug2954-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug50695-2-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug56201-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug8032-2-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug9024-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug92647-2-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/core/col_widths_fix_autoFixPer-expected.txt: Removed.
- platform/mac/tables/mozilla/bugs/bug27038-3-expected.txt: Removed.
- platform/mac/tables/mozilla/core/row_span-expected.txt: Removed.
- platform/mac/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt: Removed.
- platform/win-future/tables/mozilla/core/bloomberg-expected.txt: Renamed from LayoutTests/tables/mozilla/core/bloomberg-expected.txt.
- platform/win-future/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt: Renamed from LayoutTests/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt.
- platform/win/tables/mozilla/bugs/bug133756-1-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug133756-2-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug220536-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug8858-expected.txt: Removed.
- platform/win/tables/mozilla/core/row_span-expected.txt: Removed.
- platform/win/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt: Removed.
- platform/win/tables/mozilla_expected_failures/bugs/bug65372-expected.txt: Removed.
- tables/mozilla/bugs/adforce_imgis_com-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/adforce_imgis_com-expected.txt.
- tables/mozilla/bugs/bug102145-1-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug102145-1-expected.png.
- tables/mozilla/bugs/bug102145-2-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug102145-2-expected.png.
- tables/mozilla/bugs/bug102145-3-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug102145-3-expected.png.
- tables/mozilla/bugs/bug102145-4-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug102145-4-expected.png.
- tables/mozilla/bugs/bug10269-1-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug10269-1-expected.png.
- tables/mozilla/bugs/bug10296-2-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug10296-2-expected.png.
- tables/mozilla/bugs/bug103533-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug103533-expected.png.
- tables/mozilla/bugs/bug11321-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug11321-expected.png.
- tables/mozilla/bugs/bug12908-2-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug12908-2-expected.png.
- tables/mozilla/bugs/bug13105-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug13105-expected.png.
- tables/mozilla/bugs/bug133756-1-expected.txt: Renamed from LayoutTests/platform/mac/tables/mozilla/bugs/bug133756-1-expected.txt.
- tables/mozilla/bugs/bug133756-2-expected.txt: Renamed from LayoutTests/platform/mac/tables/mozilla/bugs/bug133756-2-expected.txt.
- tables/mozilla/bugs/bug14159-3-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug14159-3-expected.png.
- tables/mozilla/bugs/bug149275-2-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug149275-2-expected.txt.
- tables/mozilla/bugs/bug1818-6-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug1818-6-expected.png.
- tables/mozilla/bugs/bug196870-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug196870-expected.png.
- tables/mozilla/bugs/bug220536-expected.txt: Renamed from LayoutTests/platform/mac/tables/mozilla/bugs/bug220536-expected.txt.
- tables/mozilla/bugs/bug222336-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug222336-expected.png.
- tables/mozilla/bugs/bug222467-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug222467-expected.png.
- tables/mozilla/bugs/bug23072-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug23072-expected.png.
- tables/mozilla/bugs/bug23151-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug23151-expected.txt.
- tables/mozilla/bugs/bug23994-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug23994-expected.png.
- tables/mozilla/bugs/bug26553-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug26553-expected.txt.
- tables/mozilla/bugs/bug269566-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug269566-expected.png.
- tables/mozilla/bugs/bug27038-3-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug27038-3-expected.txt.
- tables/mozilla/bugs/bug275625-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug275625-expected.png.
- tables/mozilla/bugs/bug277062-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug277062-expected.png.
- tables/mozilla/bugs/bug2886-2-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug2886-2-expected.txt.
- tables/mozilla/bugs/bug28933-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug28933-expected.png.
- tables/mozilla/bugs/bug3037-1-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug3037-1-expected.png.
- tables/mozilla/bugs/bug3037-2-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug3037-2-expected.png.
- tables/mozilla/bugs/bug32447-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug32447-expected.png.
- tables/mozilla/bugs/bug34538-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug34538-expected.png.
- tables/mozilla/bugs/bug56405-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug56405-expected.png.
- tables/mozilla/bugs/bug641-2-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug641-2-expected.png.
- tables/mozilla/bugs/bug75250-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug75250-expected.png.
- tables/mozilla/bugs/bug8032-2-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug8032-2-expected.png.
- tables/mozilla/bugs/bug8361-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug8361-expected.png.
- tables/mozilla/bugs/bug8858-expected.txt: Renamed from LayoutTests/platform/mac/tables/mozilla/bugs/bug8858-expected.txt.
- tables/mozilla/bugs/bug9024-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug9024-expected.png.
- tables/mozilla/core/col_widths_fix_autoFixPer-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/core/col_widths_fix_autoFixPer-expected.png.
- tables/mozilla/core/row_span-expected.txt:
- tables/mozilla/marvin/table_overflow_hidden_td-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/table_overflow_hidden_td-expected.txt.
- tables/mozilla_expected_failures/bugs/bug128876-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/bugs/bug128876-expected.png.
- tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
- tables/mozilla_expected_failures/bugs/bug178855-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/bugs/bug178855-expected.png.
- tables/mozilla_expected_failures/bugs/bug3517-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/bugs/bug3517-expected.png.
- tables/mozilla_expected_failures/bugs/bug65372-expected.txt: Renamed from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug65372-expected.txt.
- tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.png.
- tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt.
- tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt.
- tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt.
- tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt.
- tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt.
- 2:26 PM Changeset in webkit [158545] by
-
- 3 edits in trunk/LayoutTests
Precision errors in Math.cbrt() on GTK, EFL
https://bugs.webkit.org/show_bug.cgi?id=123624
Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-11-03
Reviewed by Csaba Osztrogonác.
Calculate cube roots of 8 and -8, expecting 2 and -2, respectively. Cube roots of those two
numbers don't contain precision errors on the GTK and EFL ports as is the case with 27 and -27.
- js/math-expected.txt:
- js/script-tests/math.js:
- 2:18 PM Changeset in webkit [158544] by
-
- 3 edits in trunk/Source/WebCore
CSSShadowValue constructor should return PassRef.
<https://webkit.org/b/123711>
Make CSSShadowValue::create() return a PassRef since it will never
return null.
Reviewed by Sam Weinig.
- 2:17 PM Changeset in webkit [158543] by
-
- 3 edits in trunk/Source/WebCore
CSSLineBoxContainValue constructor should return PassRef.
<https://webkit.org/b/123710>
Make CSSLineBoxContainValue::create() return a PassRef since it
will never return null.
Reviewed by Sam Weinig.
- 2:17 PM Changeset in webkit [158542] by
-
- 1 edit5 moves5 deletes in trunk/LayoutTests
Optimize baselines: fast/frames
Unreviewed; run "webkit-patch optimize-baselines fast/frames"
- fast/frames/002-expected.png: Renamed from LayoutTests/platform/efl/fast/frames/002-expected.png.
- fast/frames/empty-cols-attribute-expected.png: Renamed from LayoutTests/platform/efl/fast/frames/empty-cols-attribute-expected.png.
- fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Renamed from LayoutTests/platform/efl/fast/frames/flattening/frameset-flattening-subframesets-expected.txt.
- fast/frames/frame-set-whitespace-attributes-expected.png: Renamed from LayoutTests/platform/efl/fast/frames/frame-set-whitespace-attributes-expected.png.
- fast/frames/no-frame-borders-expected.png: Renamed from LayoutTests/platform/efl/fast/frames/no-frame-borders-expected.png.
- platform/gtk/fast/frames/002-expected.png: Removed.
- platform/gtk/fast/frames/empty-cols-attribute-expected.png: Removed.
- platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Removed.
- platform/gtk/fast/frames/frame-set-whitespace-attributes-expected.png: Removed.
- platform/gtk/fast/frames/no-frame-borders-expected.png: Removed.
- 1:52 PM Changeset in webkit [158541] by
-
- 4 edits in trunk/Source/JavaScriptCore
Assertion failure in non-JIT'ed LLInt on ARM Thumb.
https://bugs.webkit.org/show_bug.cgi?id=97569.
Reviewed by Geoffrey Garen.
- assembler/MacroAssemblerCodeRef.h:
- Thumb2 alignment assertions do not apply to the C Loop LLINT because the arguments passed to those assertions are actually OpcodeIDs masquerading as addresses.
- llint/LLIntOfflineAsmConfig.h:
- Some of the #defines belong in the !ENABLE(LLINT_C_LOOP) section. Moving them there.
- llint/LowLevelInterpreter.cpp:
- Keep the compiler happy from some unreferenced C Loop labels.
- 1:32 PM Changeset in webkit [158540] by
-
- 29 edits in trunk/Source/WebCore
LiveNodeLists should have non-null ContainerNode as root
https://bugs.webkit.org/show_bug.cgi?id=123709
Reviewed by Andreas Kling.
After moving ChildNodeList off from LiveNodeList the root is now always at least a ContainerNode.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::getElementsByTagName):
(WebCore::ContainerNode::getElementsByTagNameNS):
(WebCore::ContainerNode::getElementsByName):
(WebCore::ContainerNode::getElementsByClassName):
(WebCore::ContainerNode::radioNodeList):
Also these move from Node to ContainerNode to make tighter typing work.
- 1:08 PM Changeset in webkit [158539] by
-
- 1 edit21 moves24 deletes in trunk/LayoutTests
Optimize baselines: fast/table
Unreviewed; run "webkit-patch optimize-baselines fast/table"
- fast/table/022-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/022-expected.txt.
- fast/table/024-expected.png: Renamed from LayoutTests/platform/efl/fast/table/024-expected.png.
- fast/table/031-expected.png: Renamed from LayoutTests/platform/efl/fast/table/031-expected.png.
- fast/table/032-expected.png: Renamed from LayoutTests/platform/efl/fast/table/032-expected.png.
- fast/table/034-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/034-expected.txt.
- fast/table/auto-100-percent-width-expected.png: Renamed from LayoutTests/platform/efl/fast/table/auto-100-percent-width-expected.png.
- fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.png: Renamed from LayoutTests/platform/efl/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.png.
- fast/table/div-as-col-span-expected.png: Renamed from LayoutTests/platform/efl/fast/table/div-as-col-span-expected.png.
- fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt.
- fast/table/giantCellspacing-expected.png: Renamed from LayoutTests/platform/efl/fast/table/giantCellspacing-expected.png.
- fast/table/giantCellspacing-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/giantCellspacing-expected.txt.
- fast/table/giantRowspan-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/giantRowspan-expected.txt.
- fast/table/giantRowspan2-expected.txt: Renamed from LayoutTests/platform/mac/fast/table/giantRowspan2-expected.txt.
- fast/table/percent-widths-stretch-vertical-expected.png: Renamed from LayoutTests/platform/efl/fast/table/percent-widths-stretch-vertical-expected.png.
- fast/table/table-before-child-style-update-expected.png: Renamed from LayoutTests/platform/efl/fast/table/table-before-child-style-update-expected.png.
- fast/table/table-row-before-child-style-update-expected.png: Renamed from LayoutTests/platform/efl/fast/table/table-row-before-child-style-update-expected.png.
- fast/table/table-row-style-not-updated-expected.png: Renamed from LayoutTests/platform/efl/fast/table/table-row-style-not-updated-expected.png.
- fast/table/table-row-style-not-updated-with-after-content-expected.png: Renamed from LayoutTests/platform/efl/fast/table/table-row-style-not-updated-with-after-content-expected.png.
- fast/table/table-row-style-not-updated-with-before-content-expected.png: Renamed from LayoutTests/platform/efl/fast/table/table-row-style-not-updated-with-before-content-expected.png.
- fast/table/table-style-not-updated-expected.png: Renamed from LayoutTests/platform/efl/fast/table/table-style-not-updated-expected.png.
- fast/table/vertical-align-baseline-readjust-expected.png: Renamed from LayoutTests/platform/efl/fast/table/vertical-align-baseline-readjust-expected.png.
- platform/gtk/fast/table/022-expected.txt: Removed.
- platform/gtk/fast/table/024-expected.png: Removed.
- platform/gtk/fast/table/031-expected.png: Removed.
- platform/gtk/fast/table/032-expected.png: Removed.
- platform/gtk/fast/table/034-expected.txt: Removed.
- platform/gtk/fast/table/auto-100-percent-width-expected.png: Removed.
- platform/gtk/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.png: Removed.
- platform/gtk/fast/table/div-as-col-span-expected.png: Removed.
- platform/gtk/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt: Removed.
- platform/gtk/fast/table/giantCellspacing-expected.png: Removed.
- platform/gtk/fast/table/giantCellspacing-expected.txt: Removed.
- platform/gtk/fast/table/giantRowspan-expected.txt: Removed.
- platform/gtk/fast/table/percent-widths-stretch-vertical-expected.png: Removed.
- platform/gtk/fast/table/table-before-child-style-update-expected.png: Removed.
- platform/gtk/fast/table/table-row-before-child-style-update-expected.png: Removed.
- platform/gtk/fast/table/table-row-style-not-updated-expected.png: Removed.
- platform/gtk/fast/table/table-row-style-not-updated-with-after-content-expected.png: Removed.
- platform/gtk/fast/table/table-row-style-not-updated-with-before-content-expected.png: Removed.
- platform/gtk/fast/table/table-style-not-updated-expected.png: Removed.
- platform/gtk/fast/table/vertical-align-baseline-readjust-expected.png: Removed.
- platform/mac/fast/table/022-expected.txt: Removed.
- platform/mac/fast/table/giantCellspacing-expected.txt: Removed.
- platform/mac/fast/table/giantRowspan-expected.txt: Removed.
- platform/win/fast/table/giantRowspan-expected.txt: Removed.
- platform/win/fast/table/giantRowspan2-expected.txt: Removed.
- 12:41 PM Changeset in webkit [158538] by
-
- 4 edits in trunk/Source/WebKit2
[Cocoa] Wrappers' -copyWithZone: should copy if the collection is mutable
https://bugs.webkit.org/show_bug.cgi?id=123707
Reviewed by Geoff Garen.
- Shared/Cocoa/WKNSArray.mm:
(-[WKNSArray copyWithZone:]): If the array is mutable, make a copy.
- Shared/Cocoa/WKNSDictionary.mm:
(-[WKNSDictionary copyWithZone:]): If the dictionary is mutable, make a copy.
- Shared/ImmutableArray.h:
(WebKit::ImmutableArray::entries): Added this accessor.
- 12:19 PM Changeset in webkit [158537] by
-
- 5 edits in trunk/Source/WebCore
Switch createContextualFragment to element iterator
https://bugs.webkit.org/show_bug.cgi?id=123704
Reviewed by Andreas Kling.
- editing/FrameSelection.cpp:
(WebCore::scanForForm):
Use type helpers instead of hasTagName
- editing/markup.cpp:
(WebCore::collectElementsToRemoveFromFragment):
(WebCore::removeElementFromFragmentPreservingChildren):
(WebCore::createContextualFragment):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::formElementIndex):
Use type helpers instead of hasTagName
- html/HTMLTagNames.in:
Generate type helpers for <html>.
- 11:52 AM Changeset in webkit [158536] by
-
- 11 edits in trunk/Source/WebCore
ChildNodeList should not be LiveNodeList
https://bugs.webkit.org/show_bug.cgi?id=123708
Reviewed by Sam Weinig.
ChildNodeList is a poor fit to be a LiveNodeList. It is heavily special-cased. It is also
the only subtype that returns non-Elements thus preventing tightening.
- bindings/js/JSNodeListCustom.cpp:
(WebCore::JSNodeListOwner::isReachableFromOpaqueRoots):
Support new types.
- dom/ChildNodeList.cpp:
(WebCore::EmptyNodeList::~EmptyNodeList):
(WebCore::ChildNodeList::ChildNodeList):
(WebCore::ChildNodeList::~ChildNodeList):
(WebCore::ChildNodeList::length):
(WebCore::childFromFirst):
(WebCore::childFromLast):
(WebCore::ChildNodeList::nodeBeforeCached):
(WebCore::ChildNodeList::nodeAfterCached):
(WebCore::ChildNodeList::item):
(WebCore::ChildNodeList::namedItem):
(WebCore::ChildNodeList::invalidateCache):
Implement the same caching optimizations as LiveNodeList with tighter, less generic code.
- dom/ChildNodeList.h:
Inherit ChildNodeList directly from NodeList.
Add new EmptyNodeList type. This is only ever used if NodeList is requested for a non-container node.
It allows tighter typing in ChildNodeList.
- dom/LiveNodeList.cpp:
(WebCore::LiveNodeList::namedItem):
- dom/LiveNodeList.h:
(WebCore::LiveNodeListBase::LiveNodeListBase):
(WebCore::LiveNodeListBase::~LiveNodeListBase):
(WebCore::LiveNodeList::LiveNodeList):
Remove ChildNodeList specific code and branches.
- dom/Node.cpp:
(WebCore::Node::childNodes):
Return EmptyNodeList for non-containers.
- dom/NodeList.h:
(WebCore::NodeList::~NodeList):
(WebCore::NodeList::isLiveNodeList):
(WebCore::NodeList::isChildNodeList):
(WebCore::NodeList::isEmptyNodeList):
For isReachableFromOpaqueRoots.
- dom/NodeRareData.h:
(WebCore::NodeListsNodeData::ensureChildNodeList):
(WebCore::NodeListsNodeData::removeChildNodeList):
(WebCore::NodeListsNodeData::ensureEmptyChildNodeList):
(WebCore::NodeListsNodeData::removeEmptyChildNodeList):
(WebCore::NodeListsNodeData::NodeListsNodeData):
(WebCore::NodeListsNodeData::deleteThisAndUpdateNodeRareDataIfAboutToRemoveLastList):
EmptyNodeList support.
- html/CollectionType.h:
- html/HTMLCollection.cpp:
(WebCore::shouldOnlyIncludeDirectChildren):
(WebCore::rootTypeFromCollectionType):
(WebCore::invalidationTypeExcludingIdAndNameAttributes):
(WebCore::isMatchingElement):
(WebCore::LiveNodeListBase::itemBefore):
(WebCore::LiveNodeListBase::traverseLiveNodeListFirstElement):
(WebCore::LiveNodeListBase::traverseLiveNodeListForwardToOffset):
(WebCore::LiveNodeListBase::item):
(WebCore::LiveNodeListBase::itemBeforeOrAfterCachedItem):
Remove ChildNodeList specific code and branches.
- 10:24 AM Changeset in webkit [158535] by
-
- 14 edits in trunk/Source/JavaScriptCore
FTL should use LLVM intrinsics for OSR exit, watchpoints, inline caches, and stack layout
https://bugs.webkit.org/show_bug.cgi?id=122318
Reviewed by Geoffrey Garen.
This all now works. This patch just updates our implementation to work with LLVM trunk,
and removes all of the old code that tried to do OSR exits and heap accesses without
the benefit of those intrinsics.
In particular:
- StackMaps parsing now uses the new, less compact, but more future-proof, format.
- Remove the ftlUsesStackmaps() option and hard-code ftlUsesStackmaps = true. Remove all code for ftlUsesStackmaps = false, since that was only there for back when we didn't have the intrinsics.
- Remove the other experimental OSR options (useLLVMOSRExitIntrinsic, ftlTrapsOnOSRExit, and FTLOSRExitOmitsMarshalling).
- Remove LowerDFGToLLVM's use of the ExitThunkGenerator since we don't need to generate the exit thunks until after we parse the stackmaps.
- Remove all of the exit thunk and compiler code for the no-stackmaps case.
- dfg/DFGDriver.cpp:
(JSC::DFG::compileImpl):
- ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):
- ftl/FTLExitThunkGenerator.cpp:
(JSC::FTL::ExitThunkGenerator::emitThunk):
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLocation.cpp:
(JSC::FTL::Location::forStackmaps):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::compileGetById):
(JSC::FTL::LowerDFGToLLVM::compileInvalidationPoint):
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::emitOSRExitCall):
(JSC::FTL::LowerDFGToLLVM::callStackmap):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):
- ftl/FTLOSRExitCompilationInfo.h:
(JSC::FTL::OSRExitCompilationInfo::OSRExitCompilationInfo):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
(JSC::FTL::compileFTLOSRExit):
- ftl/FTLStackMaps.cpp:
(JSC::FTL::StackMaps::Location::parse):
(JSC::FTL::StackMaps::parse):
(WTF::printInternal):
- ftl/FTLStackMaps.h:
- ftl/FTLThunks.cpp:
(JSC::FTL::osrExitGenerationThunkGenerator):
- ftl/FTLThunks.h:
(JSC::FTL::Thunks::getOSRExitGenerationThunk):
- runtime/Options.h:
- 9:51 AM Changeset in webkit [158534] by
-
- 2 edits in trunk/Tools
Add test for ListHashSet::removeLast()
https://bugs.webkit.org/show_bug.cgi?id=121810
Reviewed by Anders Carlsson.
- TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
(TestWebKitAPI::TEST):
- 9:48 AM Changeset in webkit [158533] by
-
- 10 edits in trunk/Source
[WINCE] Replace OwnPtr with GDIObject
https://bugs.webkit.org/show_bug.cgi?id=123670
Reviewed by Anders Carlsson.
Source/WebCore:
- page/win/FrameGdiWin.cpp:
(WebCore::imageFromRect):
- platform/graphics/wince/FontPlatformData.cpp:
(WebCore::FixedSizeFontData::create):
(WebCore::FontPlatformData::hfont):
(WebCore::FontPlatformData::getScaledFontHandle):
- platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::createPen):
(WebCore::createBrush):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::drawRoundCorner):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::drawText):
- platform/graphics/wince/ImageWinCE.cpp:
(WebCore::BitmapImage::getHBITMAPOfSize):
- platform/graphics/wince/SharedBitmap.cpp:
(WebCore::SharedBitmap::createHandle):
(WebCore::SharedBitmap::draw):
(WebCore::SharedBitmap::clipBitmap):
(WebCore::drawPatternSimple):
(WebCore::SharedBitmap::drawPattern):
(WebCore::SharedBitmap::DCProvider::getDC):
- platform/graphics/wince/SharedBitmap.h:
Source/WebKit/wince:
- WebView.cpp:
(WebView::paint):
(WebView::handlePaint):
- WebView.h:
- 6:55 AM Changeset in webkit [158532] by
-
- 2 edits in trunk/LayoutTests
[EFL][WK1] Some tests of editing/selection fail to render properly
https://bugs.webkit.org/show_bug.cgi?id=117574
Unreviewed, EFL gardening.
These tests are passed in wk1(and wk2), but skipped in wk1.
These tests have been reviewed since those are added.
Now these tests are operating properly, so those need to update the test expectations.
Also 'editing/selection/caret-and-focus-ring.html' is already changed a reason of failure by Bug no.123696
Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-11-03
- platform/efl-wk1/TestExpectations:
- 3:19 AM Changeset in webkit [158531] by
-
- 1 edit36 moves30 deletes in trunk/LayoutTests
Optimize baselines: fast/text
Unreviewed; run "webkit-patch optimize-baselines fast/text"
- fast/text/decorations-transformed-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/decorations-transformed-expected.txt.
- fast/text/fixed-pitch-control-characters-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/fixed-pitch-control-characters-expected.txt.
- fast/text/international/001-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/international/001-expected.txt.
- fast/text/international/vertical-text-glyph-test-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/international/vertical-text-glyph-test-expected.txt.
- fast/text/international/vertical-text-metrics-test-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/international/vertical-text-metrics-test-expected.txt.
- fast/text/international/wrap-CJK-001-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/international/wrap-CJK-001-expected.txt.
- fast/text/justify-ideograph-complex-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/justify-ideograph-complex-expected.txt.
- fast/text/justify-ideograph-simple-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/justify-ideograph-simple-expected.txt.
- fast/text/justify-ideograph-vertical-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/justify-ideograph-vertical-expected.txt.
- fast/text/selection-painted-separately-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/selection-painted-separately-expected.txt.
- fast/text/soft-hyphen-2-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/soft-hyphen-2-expected.txt.
- fast/text/soft-hyphen-3-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/soft-hyphen-3-expected.txt.
- fast/text/stripNullFromText-expected.png: Renamed from LayoutTests/platform/efl/fast/text/stripNullFromText-expected.png.
- fast/text/updateNewFont-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/updateNewFont-expected.txt.
- fast/text/whitespace/001-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/whitespace/001-expected.txt.
- fast/text/whitespace/013-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/whitespace/013-expected.txt.
- fast/text/whitespace/014-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/whitespace/014-expected.txt.
- fast/text/whitespace/017-expected.png: Renamed from LayoutTests/platform/efl/fast/text/whitespace/017-expected.png.
- fast/text/whitespace/017-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/whitespace/017-expected.txt.
- fast/text/whitespace/029-expected.png: Renamed from LayoutTests/platform/efl/fast/text/whitespace/029-expected.png.
- fast/text/whitespace/029-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/whitespace/029-expected.txt.
- fast/text/whitespace/pre-newline-box-test-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/whitespace/pre-newline-box-test-expected.txt.
- fast/text/whitespace/tab-character-basics-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/whitespace/tab-character-basics-expected.txt.
- platform/efl-wk1/fast/text/complex-text-opacity-expected.png: Renamed from LayoutTests/platform/efl/fast/text/complex-text-opacity-expected.png.
- platform/efl-wk1/fast/text/complex-text-opacity-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/complex-text-opacity-expected.txt.
- platform/efl-wk1/fast/text/international/bidi-layout-across-linebreak-expected.png: Renamed from LayoutTests/platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.png.
- platform/efl-wk1/fast/text/international/bidi-layout-across-linebreak-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.txt.
- platform/efl-wk2/fast/text/atsui-pointtooffset-calls-cg-expected.png: Renamed from LayoutTests/platform/efl/fast/text/atsui-pointtooffset-calls-cg-expected.png.
- platform/efl-wk2/fast/text/atsui-rtl-override-selection-expected.png: Renamed from LayoutTests/platform/efl/fast/text/atsui-rtl-override-selection-expected.png.
- platform/efl-wk2/fast/text/atsui-small-caps-punctuation-size-expected.png: Renamed from LayoutTests/platform/efl/fast/text/atsui-small-caps-punctuation-size-expected.png.
- platform/efl-wk2/fast/text/hyphenate-character-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphenate-character-expected.png.
- platform/efl-wk2/fast/text/hyphenate-first-word-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphenate-first-word-expected.png.
- platform/efl-wk2/fast/text/hyphenate-limit-before-after-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphenate-limit-before-after-expected.png.
- platform/efl-wk2/fast/text/hyphenate-limit-lines-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphenate-limit-lines-expected.png.
- platform/efl-wk2/fast/text/hyphens-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphens-expected.png.
- platform/efl-wk2/fast/text/midword-break-before-surrogate-pair-2-expected.png: Renamed from LayoutTests/platform/efl/fast/text/midword-break-before-surrogate-pair-2-expected.png.
- platform/gtk/fast/text/decorations-transformed-expected.txt: Removed.
- platform/gtk/fast/text/fixed-pitch-control-characters-expected.txt: Removed.
- platform/gtk/fast/text/international/001-expected.txt: Removed.
- platform/gtk/fast/text/international/vertical-text-glyph-test-expected.txt: Removed.
- platform/gtk/fast/text/international/vertical-text-metrics-test-expected.txt: Removed.
- platform/gtk/fast/text/international/wrap-CJK-001-expected.txt: Removed.
- platform/gtk/fast/text/justify-ideograph-complex-expected.txt: Removed.
- platform/gtk/fast/text/justify-ideograph-simple-expected.txt: Removed.
- platform/gtk/fast/text/justify-ideograph-vertical-expected.txt: Removed.
- platform/gtk/fast/text/selection-painted-separately-expected.txt: Removed.
- platform/gtk/fast/text/soft-hyphen-2-expected.txt: Removed.
- platform/gtk/fast/text/soft-hyphen-3-expected.txt: Removed.
- platform/gtk/fast/text/stripNullFromText-expected.png: Removed.
- platform/gtk/fast/text/updateNewFont-expected.txt: Removed.
- platform/gtk/fast/text/whitespace/001-expected.txt: Removed.
- platform/gtk/fast/text/whitespace/017-expected.png: Removed.
- platform/gtk/fast/text/whitespace/017-expected.txt: Removed.
- platform/gtk/fast/text/whitespace/029-expected.png: Removed.
- platform/gtk/fast/text/whitespace/029-expected.txt: Removed.
- platform/gtk/fast/text/whitespace/pre-newline-box-test-expected.txt: Removed.
- platform/gtk/fast/text/whitespace/tab-character-basics-expected.txt: Removed.
- platform/mac/fast/text/decorations-transformed-expected.txt: Removed.
- platform/mac/fast/text/fixed-pitch-control-characters-expected.txt: Removed.
- platform/mac/fast/text/selection-painted-separately-expected.txt: Removed.
- platform/mac/fast/text/soft-hyphen-2-expected.txt: Removed.
- platform/mac/fast/text/soft-hyphen-3-expected.txt: Removed.
- platform/mac/fast/text/whitespace/001-expected.txt: Removed.
- platform/mac/fast/text/whitespace/013-expected.txt: Removed.
- platform/mac/fast/text/whitespace/014-expected.txt: Removed.
- platform/mac/fast/text/whitespace/017-expected.txt: Removed.
- 3:13 AM Changeset in webkit [158530] by
-
- 5 edits in trunk/Source/WebCore
Add helpers for partial descendant traversal to element iterators
https://bugs.webkit.org/show_bug.cgi?id=123703
Reviewed by Andreas Kling.
- dom/ElementAncestorIterator.h:
(WebCore::lineageOfType):
lineageOfType definition didn't match the declaration.
- dom/ElementDescendantIterator.h:
(WebCore::::find):
(WebCore::::from):
Add find and from for getting begin iterator for partial traversals.
- editing/FrameSelection.cpp:
(WebCore::scanForForm):
(WebCore::FrameSelection::currentForm):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::formElementIndex):
(WebCore::HTMLFormElement::findClosestFormAncestor):
Use them in a few places.
- 1:54 AM Changeset in webkit [158529] by
-
- 3 edits in trunk/Source/WebCore
Inline RenderStyle functions for getting/setting pseudo style bits.
<https://webkit.org/b/123702>
hasPseudoStyle() actually shows up on html5-full-render.html,
and it's pretty crazy to eat the cost of a function call just
to do some basic bit twiddling.
Reviewed by Antti Koivisto.
- 1:41 AM Changeset in webkit [158528] by
-
- 1 edit8 moves1 add5 deletes in trunk/LayoutTests
Optimize baselines: fast/canvas
Unreviewed; run "webkit-patch optimize-baselines fast/canvas"
- fast/canvas/canvas-empty-image-pattern-expected.png: Renamed from LayoutTests/platform/efl/fast/canvas/canvas-empty-image-pattern-expected.png.
- fast/canvas/canvas-incremental-repaint-2-expected.png: Renamed from LayoutTests/platform/efl/fast/canvas/canvas-incremental-repaint-2-expected.png.
- fast/canvas/canvas-render-layer-expected.png: Renamed from LayoutTests/platform/efl/fast/canvas/canvas-render-layer-expected.png.
- fast/canvas/set-colors-expected.txt: Renamed from LayoutTests/platform/efl/fast/canvas/set-colors-expected.txt.
- platform/gtk/fast/canvas/canvas-empty-image-pattern-expected.png: Removed.
- platform/gtk/fast/canvas/canvas-incremental-repaint-2-expected.png: Removed.
- platform/gtk/fast/canvas/canvas-render-layer-expected.png: Removed.
- platform/gtk/fast/canvas/set-colors-expected.txt: Removed.
- platform/win-7sp0/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Renamed from LayoutTests/platform/win/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt.
- platform/win-7sp0/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Renamed from LayoutTests/platform/win/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt.
- platform/win-7sp0/fast/canvas/canvas-render-layer-expected.txt: Renamed from LayoutTests/platform/win/fast/canvas/canvas-render-layer-expected.txt.
- platform/win-7sp0/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Renamed from LayoutTests/platform/win/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt.
- platform/win-xp/fast/canvas/set-colors-expected.txt: Removed.
- 1:30 AM Changeset in webkit [158527] by
-
- 77 edits2 deletes in trunk
Remove HTMLMediaElement.initialTime
https://bugs.webkit.org/show_bug.cgi?id=123572
Reviewed by Eric Carlson.
Source/WebCore:
Patch based on one by: philipj@opera.com
Blink review URL: https://codereview.chromium.org/35033002
initialTime has been removed from the HTMLMediaElement.
- bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_html_media_element_get_initial_time):
- bindings/gobject/WebKitDOMCustom.h:
- bindings/gobject/WebKitDOMCustom.symbols: Added phony function.
- html/HTMLMediaElement.cpp:
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl: Removed HTMLMediaElement::initialTime.
LayoutTests:
Blink review URL: https://codereview.chromium.org/35033002
Removed presence of initialTime in the tests.
- media/media-fragments/TC0001-expected.txt:
- media/media-fragments/TC0002-expected.txt:
- media/media-fragments/TC0003-expected.txt:
- media/media-fragments/TC0004-expected.txt:
- media/media-fragments/TC0005-expected.txt:
- media/media-fragments/TC0006-expected.txt:
- media/media-fragments/TC0009-expected.txt:
- media/media-fragments/TC0011-expected.txt:
- media/media-fragments/TC0012-expected.txt:
- media/media-fragments/TC0014-expected.txt:
- media/media-fragments/TC0015-expected.txt:
- media/media-fragments/TC0017-expected.txt:
- media/media-fragments/TC0024-expected.txt:
- media/media-fragments/TC0027-expected.txt:
- media/media-fragments/TC0028-expected.txt:
- media/media-fragments/TC0029-expected.txt:
- media/media-fragments/TC0030-expected.txt:
- media/media-fragments/TC0031-expected.txt:
- media/media-fragments/TC0032-expected.txt:
- media/media-fragments/TC0033-expected.txt:
- media/media-fragments/TC0034-expected.txt:
- media/media-fragments/TC0035-expected.txt:
- media/media-fragments/TC0036-expected.txt:
- media/media-fragments/TC0037-expected.txt:
- media/media-fragments/TC0038-expected.txt:
- media/media-fragments/TC0039-expected.txt:
- media/media-fragments/TC0044-expected.txt:
- media/media-fragments/TC0051-expected.txt:
- media/media-fragments/TC0052-expected.txt:
- media/media-fragments/TC0053-expected.txt:
- media/media-fragments/TC0054-expected.txt:
- media/media-fragments/TC0055-expected.txt:
- media/media-fragments/TC0058-expected.txt:
- media/media-fragments/TC0059-expected.txt:
- media/media-fragments/TC0061-expected.txt:
- media/media-fragments/TC0062-expected.txt:
- media/media-fragments/TC0063-expected.txt:
- media/media-fragments/TC0064-expected.txt:
- media/media-fragments/TC0065-expected.txt:
- media/media-fragments/TC0066-expected.txt:
- media/media-fragments/TC0067-expected.txt:
- media/media-fragments/TC0068-expected.txt:
- media/media-fragments/TC0069-expected.txt:
- media/media-fragments/TC0070-expected.txt:
- media/media-fragments/TC0071-expected.txt:
- media/media-fragments/TC0072-expected.txt:
- media/media-fragments/TC0073-expected.txt:
- media/media-fragments/TC0074-expected.txt:
- media/media-fragments/TC0075-expected.txt:
- media/media-fragments/TC0076-expected.txt:
- media/media-fragments/TC0077-expected.txt:
- media/media-fragments/TC0078-expected.txt:
- media/media-fragments/TC0079-expected.txt:
- media/media-fragments/TC0080-expected.txt:
- media/media-fragments/TC0081-expected.txt:
- media/media-fragments/TC0082-expected.txt:
- media/media-fragments/TC0083-expected.txt:
- media/media-fragments/TC0084-expected.txt:
- media/media-fragments/TC0085-expected.txt:
- media/media-fragments/TC0086-expected.txt:
- media/media-fragments/TC0087-expected.txt:
- media/media-fragments/TC0088-expected.txt:
- media/media-fragments/TC0089-expected.txt:
- media/media-fragments/TC0090-expected.txt:
- media/media-fragments/TC0091-expected.txt:
- media/media-fragments/TC0092-expected.txt:
- media/media-fragments/TC0093-expected.txt:
- media/media-fragments/TC0094-expected.txt:
- media/media-fragments/media-fragments.js:
(canplaythrough): Removed check for initialTime
- media/media-initialTime-expected.txt: Removed.
- media/media-initialTime.html: Removed.
