Context Navigation

← Previous Period
Next Period →

Timeline

Nov 9, 2013:

11:28 PM Changeset in webkit [159018] by akling@apple.com

3 edits in trunk/Source/WebCore

CSSValuePool::createFontFamilyValue() should return PassRef.
<https://webkit.org/b/124114>

Unlike createFontFaceValue(), createFontFamilyValue() can never
fail to return an object and thus should return PassRef.

Reviewed by Anders Carlsson.

11:26 PM Changeset in webkit [159017] by akling@apple.com

371 edits in trunk

RenderIFrame should display its name correctly in DRT output.
<https://webkit.org/b/124117>

Source/WebCore:

Nuke an age-old FIXME about making RenderIFrame show its true name
in DRT output. No more "RenderPartObject {IFRAME}"!

Reviewed by Anders Carlsson.

LayoutTests:

Rebaseline results now that RenderIFrame correctly dumps its name
as "RenderIFrame".

Reviewed by Anders Carlsson.

compositing/iframes/composited-iframe-scroll-expected.txt:
compositing/iframes/iframe-content-flipping-expected.txt:
compositing/iframes/nested-iframe-scrolling-expected.txt:
fast/css/replaced-element-implicit-size-expected.txt:
fast/css/resize-corner-tracking-expected.txt:
fast/dom/attr_dead_doc-expected.txt:
fast/frames/content-opacity-1-expected.txt:
fast/frames/content-opacity-2-expected.txt:
fast/frames/iframe-scaling-with-scroll-expected.txt:
fast/frames/iframe-text-contents-expected.txt:
fast/frames/paint-iframe-background-expected.txt:
fast/repaint/4774354-expected.txt:
fast/repaint/iframe-scroll-repaint-expected.txt:
fast/repaint/repaint-during-scroll-with-zoom-expected.txt:
fast/replaced/percent-height-in-anonymous-block-expected.txt:
http/tests/misc/acid3-expected.txt:
media/media-document-audio-repaint-expected.txt:
platform/efl/compositing/iframes/composited-iframe-alignment-expected.txt:
platform/efl/compositing/iframes/iframe-copy-on-scroll-expected.txt:
platform/efl/compositing/iframes/iframe-in-composited-layer-expected.txt:
platform/efl/css2.1/20110323/absolute-replaced-height-004-expected.txt:
platform/efl/css2.1/20110323/absolute-replaced-height-005-expected.txt:
platform/efl/css2.1/20110323/absolute-replaced-height-007-expected.txt:
platform/efl/css2.1/20110323/absolute-replaced-height-011-expected.txt:
platform/efl/css2.1/20110323/absolute-replaced-height-012-expected.txt:
platform/efl/css2.1/20110323/absolute-replaced-height-014-expected.txt:
platform/efl/css2.1/20110323/absolute-replaced-height-018-expected.txt:
platform/efl/css2.1/20110323/absolute-replaced-height-019-expected.txt:
platform/efl/css2.1/20110323/absolute-replaced-height-021-expected.txt:
platform/efl/css2.1/20110323/absolute-replaced-height-025-expected.txt:
platform/efl/css2.1/20110323/absolute-replaced-height-026-expected.txt:
platform/efl/css2.1/20110323/absolute-replaced-height-028-expected.txt:
platform/efl/css2.1/20110323/absolute-replaced-height-032-expected.txt:
platform/efl/css2.1/20110323/absolute-replaced-height-033-expected.txt:
platform/efl/css2.1/20110323/absolute-replaced-height-035-expected.txt:
platform/efl/css2.1/20110323/block-replaced-height-004-expected.txt:
platform/efl/css2.1/20110323/block-replaced-height-005-expected.txt:
platform/efl/css2.1/20110323/block-replaced-height-007-expected.txt:
platform/efl/css2.1/20110323/float-replaced-height-004-expected.txt:
platform/efl/css2.1/20110323/float-replaced-height-005-expected.txt:
platform/efl/css2.1/20110323/float-replaced-height-007-expected.txt:
platform/efl/css2.1/20110323/inline-block-replaced-height-004-expected.txt:
platform/efl/css2.1/20110323/inline-block-replaced-height-005-expected.txt:
platform/efl/css2.1/20110323/inline-block-replaced-height-007-expected.txt:
platform/efl/css2.1/20110323/inline-replaced-height-004-expected.txt:
platform/efl/css2.1/20110323/inline-replaced-height-005-expected.txt:
platform/efl/css2.1/20110323/inline-replaced-height-007-expected.txt:
platform/efl/editing/pasteboard/4631972-expected.txt:
platform/efl/editing/selection/4776665-expected.txt:
platform/efl/editing/selection/4960137-expected.txt:
platform/efl/editing/selection/4975120-expected.txt:
platform/efl/editing/selection/drag-in-iframe-expected.txt:
platform/efl/editing/selection/drag-to-contenteditable-iframe-expected.txt:
platform/efl/editing/selection/iframe-expected.txt:
platform/efl/editing/selection/select-all-iframe-expected.txt:
platform/efl/fast/block/basic/013-expected.txt:
platform/efl/fast/block/positioning/window-height-change-expected.txt:
platform/efl/fast/css/line-height-overflow-expected.txt:
platform/efl/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt:
platform/efl/fast/dom/Window/open-existing-pop-up-blocking-expected.txt:
platform/efl/fast/flexbox/016-expected.txt:
platform/efl/fast/forms/basic-textareas-expected.txt:
platform/efl/fast/forms/tabbing-input-iframe-expected.txt:
platform/efl/fast/forms/targeted-frame-submission-expected.txt:
platform/efl/fast/frames/001-expected.txt:
platform/efl/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
platform/efl/fast/frames/flattening/iframe-flattening-nested-expected.txt:
platform/efl/fast/frames/flattening/iframe-flattening-offscreen-expected.txt:
platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt:
platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt:
platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt:
platform/efl/fast/frames/flattening/iframe-flattening-simple-expected.txt:
platform/efl/fast/frames/frameElement-iframe-expected.txt:
platform/efl/fast/frames/iframe-option-crash-expected.txt:
platform/efl/fast/frames/iframe-scrolling-attribute-expected.txt:
platform/efl/fast/frames/iframe-with-frameborder-expected.txt:
platform/efl/fast/frames/onlyCommentInIFrame-expected.txt:
platform/efl/fast/frames/take-focus-from-iframe-expected.txt:
platform/efl/fast/frames/viewsource-attribute-expected.txt:
platform/efl/fast/frames/viewsource-on-image-file-expected.txt:
platform/efl/fast/images/favicon-as-image-expected.txt:
platform/efl/fast/overflow/scrollRevealButton-expected.txt:
platform/efl/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
platform/efl/fast/repaint/line-flow-with-floats-1-expected.txt:
platform/efl/fast/repaint/line-flow-with-floats-10-expected.txt:
platform/efl/fast/repaint/line-flow-with-floats-2-expected.txt:
platform/efl/fast/repaint/line-flow-with-floats-3-expected.txt:
platform/efl/fast/repaint/line-flow-with-floats-4-expected.txt:
platform/efl/fast/repaint/line-flow-with-floats-5-expected.txt:
platform/efl/fast/repaint/line-flow-with-floats-6-expected.txt:
platform/efl/fast/repaint/line-flow-with-floats-7-expected.txt:
platform/efl/fast/repaint/line-flow-with-floats-8-expected.txt:
platform/efl/fast/repaint/line-flow-with-floats-9-expected.txt:
platform/efl/fast/repaint/text-selection-rect-in-overflow-2-expected.txt:
platform/efl/fast/replaced/007-expected.txt:
platform/efl/fast/replaced/border-radius-clip-expected.txt:
platform/efl/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
platform/efl/fast/replaced/replaced-breaking-expected.txt:
platform/efl/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt:
platform/efl/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.txt:
platform/efl/fast/table/quote-text-around-iframe-expected.txt:
platform/efl/fast/text/selection-hard-linebreak-expected.txt:
platform/efl/http/tests/loading/simple-subframe-expected.txt:
platform/efl/http/tests/local/file-url-sent-as-referer-expected.txt:
platform/efl/http/tests/misc/acid3-expected.txt:
platform/efl/http/tests/misc/favicon-as-image-expected.txt:
platform/efl/http/tests/misc/frame-access-during-load-expected.txt:
platform/efl/http/tests/misc/iframe404-expected.txt:
platform/efl/http/tests/misc/location-replace-crossdomain-expected.txt:
platform/efl/http/tests/multipart/invalid-image-data-standalone-expected.txt:
platform/efl/media/media-document-audio-repaint-expected.txt:
platform/efl/svg/hixie/rendering-model/003-expected.txt:
platform/efl/svg/in-html/by-reference-expected.txt:
platform/efl/tables/mozilla/bugs/bug131020-expected.txt:
platform/efl/tables/mozilla/bugs/bug38916-expected.txt:
platform/efl/tables/mozilla/bugs/bug4527-expected.txt:
platform/gtk-wk1/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt:
platform/gtk-wk1/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt:
platform/gtk/css2.1/20110323/absolute-replaced-height-004-expected.txt:
platform/gtk/css2.1/20110323/absolute-replaced-height-005-expected.txt:
platform/gtk/css2.1/20110323/absolute-replaced-height-007-expected.txt:
platform/gtk/css2.1/20110323/absolute-replaced-height-011-expected.txt:
platform/gtk/css2.1/20110323/absolute-replaced-height-012-expected.txt:
platform/gtk/css2.1/20110323/absolute-replaced-height-014-expected.txt:
platform/gtk/css2.1/20110323/absolute-replaced-height-018-expected.txt:
platform/gtk/css2.1/20110323/absolute-replaced-height-019-expected.txt:
platform/gtk/css2.1/20110323/absolute-replaced-height-021-expected.txt:
platform/gtk/css2.1/20110323/absolute-replaced-height-025-expected.txt:
platform/gtk/css2.1/20110323/absolute-replaced-height-026-expected.txt:
platform/gtk/css2.1/20110323/absolute-replaced-height-028-expected.txt:
platform/gtk/css2.1/20110323/absolute-replaced-height-032-expected.txt:
platform/gtk/css2.1/20110323/absolute-replaced-height-033-expected.txt:
platform/gtk/css2.1/20110323/absolute-replaced-height-035-expected.txt:
platform/gtk/css2.1/20110323/block-replaced-height-004-expected.txt:
platform/gtk/css2.1/20110323/block-replaced-height-005-expected.txt:
platform/gtk/css2.1/20110323/block-replaced-height-007-expected.txt:
platform/gtk/css2.1/20110323/float-replaced-height-004-expected.txt:
platform/gtk/css2.1/20110323/float-replaced-height-005-expected.txt:
platform/gtk/css2.1/20110323/float-replaced-height-007-expected.txt:
platform/gtk/css2.1/20110323/inline-block-replaced-height-004-expected.txt:
platform/gtk/css2.1/20110323/inline-block-replaced-height-005-expected.txt:
platform/gtk/css2.1/20110323/inline-block-replaced-height-007-expected.txt:
platform/gtk/css2.1/20110323/inline-replaced-height-004-expected.txt:
platform/gtk/css2.1/20110323/inline-replaced-height-005-expected.txt:
platform/gtk/css2.1/20110323/inline-replaced-height-007-expected.txt:
platform/gtk/editing/execCommand/find-after-replace-expected.txt:
platform/gtk/editing/execCommand/paste-1-expected.txt:
platform/gtk/editing/pasteboard/4631972-expected.txt:
platform/gtk/editing/pasteboard/copy-standalone-image-expected.txt:
platform/gtk/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
platform/gtk/editing/pasteboard/paste-2-expected.txt:
platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
platform/gtk/editing/selection/4776665-expected.txt:
platform/gtk/editing/selection/4960137-expected.txt:
platform/gtk/editing/selection/4975120-expected.txt:
platform/gtk/editing/selection/drag-in-iframe-expected.txt:
platform/gtk/editing/selection/drag-to-contenteditable-iframe-expected.txt:
platform/gtk/editing/selection/iframe-expected.txt:
platform/gtk/editing/selection/select-all-iframe-expected.txt:
platform/gtk/fast/block/basic/013-expected.txt:
platform/gtk/fast/block/positioning/window-height-change-expected.txt:
platform/gtk/fast/css/line-height-overflow-expected.txt:
platform/gtk/fast/css/resize-corner-tracking-expected.txt:
platform/gtk/fast/css/resize-corner-tracking-transformed-iframe-expected.txt:
platform/gtk/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt:
platform/gtk/fast/dom/Window/open-existing-pop-up-blocking-expected.txt:
platform/gtk/fast/flexbox/016-expected.txt:
platform/gtk/fast/forms/basic-textareas-expected.txt:
platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
platform/gtk/fast/forms/targeted-frame-submission-expected.txt:
platform/gtk/fast/frames/001-expected.txt:
platform/gtk/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
platform/gtk/fast/frames/flattening/iframe-flattening-nested-expected.txt:
platform/gtk/fast/frames/flattening/iframe-flattening-offscreen-expected.txt:
platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt:
platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt:
platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt:
platform/gtk/fast/frames/flattening/iframe-flattening-simple-expected.txt:
platform/gtk/fast/frames/frameElement-iframe-expected.txt:
platform/gtk/fast/frames/iframe-option-crash-expected.txt:
platform/gtk/fast/frames/iframe-scrolling-attribute-expected.txt:
platform/gtk/fast/frames/iframe-with-frameborder-expected.txt:
platform/gtk/fast/frames/onlyCommentInIFrame-expected.txt:
platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.txt:
platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
platform/gtk/fast/frames/viewsource-attribute-expected.txt:
platform/gtk/fast/frames/viewsource-on-image-file-expected.txt:
platform/gtk/fast/images/favicon-as-image-expected.txt:
platform/gtk/fast/overflow/scrollRevealButton-expected.txt:
platform/gtk/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
platform/gtk/fast/repaint/iframe-scroll-repaint-expected.txt:
platform/gtk/fast/repaint/line-flow-with-floats-1-expected.txt:
platform/gtk/fast/repaint/line-flow-with-floats-10-expected.txt:
platform/gtk/fast/repaint/line-flow-with-floats-2-expected.txt:
platform/gtk/fast/repaint/line-flow-with-floats-3-expected.txt:
platform/gtk/fast/repaint/line-flow-with-floats-4-expected.txt:
platform/gtk/fast/repaint/line-flow-with-floats-5-expected.txt:
platform/gtk/fast/repaint/line-flow-with-floats-6-expected.txt:
platform/gtk/fast/repaint/line-flow-with-floats-7-expected.txt:
platform/gtk/fast/repaint/line-flow-with-floats-8-expected.txt:
platform/gtk/fast/repaint/line-flow-with-floats-9-expected.txt:
platform/gtk/fast/repaint/text-selection-rect-in-overflow-2-expected.txt:
platform/gtk/fast/replaced/007-expected.txt:
platform/gtk/fast/replaced/border-radius-clip-expected.txt:
platform/gtk/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
platform/gtk/fast/replaced/replaced-breaking-expected.txt:
platform/gtk/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt:
platform/gtk/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.txt:
platform/gtk/fast/table/quote-text-around-iframe-expected.txt:
platform/gtk/fast/text/selection-hard-linebreak-expected.txt:
platform/gtk/http/tests/loading/simple-subframe-expected.txt:
platform/gtk/http/tests/local/file-url-sent-as-referer-expected.txt:
platform/gtk/http/tests/misc/favicon-as-image-expected.txt:
platform/gtk/http/tests/misc/frame-access-during-load-expected.txt:
platform/gtk/http/tests/misc/iframe404-expected.txt:
platform/gtk/http/tests/misc/location-replace-crossdomain-expected.txt:
platform/gtk/http/tests/multipart/invalid-image-data-standalone-expected.txt:
platform/gtk/media/media-document-audio-repaint-expected.txt:
platform/gtk/plugins/iframe-plugin-bgcolor-expected.txt:
platform/gtk/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt:
platform/gtk/svg/custom/embedding-external-svgs-expected.txt:
platform/gtk/svg/hixie/rendering-model/003-expected.txt:
platform/gtk/svg/in-html/by-reference-expected.txt:
platform/gtk/tables/mozilla/bugs/bug131020-expected.txt:
platform/gtk/tables/mozilla/bugs/bug38916-expected.txt:
platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
platform/iphone-simulator/text-autosizing/contenteditable-expected.txt:
platform/mac-mountainlion/editing/selection/4975120-expected.txt:
platform/mac-mountainlion/fast/forms/basic-textareas-expected.txt:
platform/mac-mountainlion/fast/forms/tabbing-input-iframe-expected.txt:
platform/mac-mountainlion/fast/frames/take-focus-from-iframe-expected.txt:
platform/mac-mountainlion/fast/replaced/replaced-breaking-expected.txt:
platform/mac-mountainlion/tables/mozilla/bugs/bug4527-expected.txt:
platform/mac-wk2/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
platform/mac/compositing/iframes/composited-iframe-alignment-expected.txt:
platform/mac/compositing/iframes/iframe-copy-on-scroll-expected.txt:
platform/mac/compositing/iframes/iframe-in-composited-layer-expected.txt:
platform/mac/css2.1/20110323/absolute-replaced-height-004-expected.txt:
platform/mac/css2.1/20110323/absolute-replaced-height-005-expected.txt:
platform/mac/css2.1/20110323/absolute-replaced-height-007-expected.txt:
platform/mac/css2.1/20110323/absolute-replaced-height-011-expected.txt:
platform/mac/css2.1/20110323/absolute-replaced-height-012-expected.txt:
platform/mac/css2.1/20110323/absolute-replaced-height-014-expected.txt:
platform/mac/css2.1/20110323/absolute-replaced-height-018-expected.txt:
platform/mac/css2.1/20110323/absolute-replaced-height-019-expected.txt:
platform/mac/css2.1/20110323/absolute-replaced-height-021-expected.txt:
platform/mac/css2.1/20110323/absolute-replaced-height-025-expected.txt:
platform/mac/css2.1/20110323/absolute-replaced-height-026-expected.txt:
platform/mac/css2.1/20110323/absolute-replaced-height-028-expected.txt:
platform/mac/css2.1/20110323/absolute-replaced-height-032-expected.txt:
platform/mac/css2.1/20110323/absolute-replaced-height-033-expected.txt:
platform/mac/css2.1/20110323/absolute-replaced-height-035-expected.txt:
platform/mac/css2.1/20110323/block-replaced-height-004-expected.txt:
platform/mac/css2.1/20110323/block-replaced-height-005-expected.txt:
platform/mac/css2.1/20110323/block-replaced-height-007-expected.txt:
platform/mac/css2.1/20110323/float-replaced-height-004-expected.txt:
platform/mac/css2.1/20110323/float-replaced-height-005-expected.txt:
platform/mac/css2.1/20110323/float-replaced-height-007-expected.txt:
platform/mac/css2.1/20110323/inline-block-replaced-height-004-expected.txt:
platform/mac/css2.1/20110323/inline-block-replaced-height-005-expected.txt:
platform/mac/css2.1/20110323/inline-block-replaced-height-007-expected.txt:
platform/mac/css2.1/20110323/inline-replaced-height-004-expected.txt:
platform/mac/css2.1/20110323/inline-replaced-height-005-expected.txt:
platform/mac/css2.1/20110323/inline-replaced-height-007-expected.txt:
platform/mac/editing/execCommand/find-after-replace-expected.txt:
platform/mac/editing/execCommand/paste-1-expected.txt:
platform/mac/editing/pasteboard/4631972-expected.txt:
platform/mac/editing/pasteboard/copy-standalone-image-expected.txt:
platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
platform/mac/editing/pasteboard/paste-2-expected.txt:
platform/mac/editing/pasteboard/subframe-dragndrop-1-expected.txt:
platform/mac/editing/selection/4776665-expected.txt:
platform/mac/editing/selection/4960137-expected.txt:
platform/mac/editing/selection/4975120-expected.txt:
platform/mac/editing/selection/drag-in-iframe-expected.txt:
platform/mac/editing/selection/drag-to-contenteditable-iframe-expected.txt:
platform/mac/editing/selection/iframe-expected.txt:
platform/mac/editing/selection/select-all-iframe-expected.txt:
platform/mac/fast/block/basic/013-expected.txt:
platform/mac/fast/block/positioning/window-height-change-expected.txt:
platform/mac/fast/css/line-height-overflow-expected.txt:
platform/mac/fast/css/resize-corner-tracking-transformed-iframe-expected.txt:
platform/mac/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt:
platform/mac/fast/dom/Window/open-existing-pop-up-blocking-expected.txt:
platform/mac/fast/flexbox/016-expected.txt:
platform/mac/fast/forms/basic-textareas-expected.txt:
platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
platform/mac/fast/forms/targeted-frame-submission-expected.txt:
platform/mac/fast/frames/001-expected.txt:
platform/mac/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
platform/mac/fast/frames/flattening/iframe-flattening-nested-expected.txt:
platform/mac/fast/frames/flattening/iframe-flattening-offscreen-expected.txt:
platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt:
platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt:
platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt:
platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.txt:
platform/mac/fast/frames/frameElement-iframe-expected.txt:
platform/mac/fast/frames/iframe-option-crash-expected.txt:
platform/mac/fast/frames/iframe-scrolling-attribute-expected.txt:
platform/mac/fast/frames/iframe-with-frameborder-expected.txt:
platform/mac/fast/frames/onlyCommentInIFrame-expected.txt:
platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
platform/mac/fast/frames/viewsource-attribute-expected.txt:
platform/mac/fast/frames/viewsource-on-image-file-expected.txt:
platform/mac/fast/images/favicon-as-image-expected.txt:
platform/mac/fast/overflow/scrollRevealButton-expected.txt:
platform/mac/fast/repaint/4774354-expected.txt:
platform/mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
platform/mac/fast/repaint/line-flow-with-floats-1-expected.txt:
platform/mac/fast/repaint/line-flow-with-floats-10-expected.txt:
platform/mac/fast/repaint/line-flow-with-floats-2-expected.txt:
platform/mac/fast/repaint/line-flow-with-floats-3-expected.txt:
platform/mac/fast/repaint/line-flow-with-floats-4-expected.txt:
platform/mac/fast/repaint/line-flow-with-floats-5-expected.txt:
platform/mac/fast/repaint/line-flow-with-floats-6-expected.txt:
platform/mac/fast/repaint/line-flow-with-floats-7-expected.txt:
platform/mac/fast/repaint/line-flow-with-floats-8-expected.txt:
platform/mac/fast/repaint/line-flow-with-floats-9-expected.txt:
platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
platform/mac/fast/repaint/repaint-during-scroll-with-zoom-expected.txt:
platform/mac/fast/repaint/text-selection-rect-in-overflow-2-expected.txt:
platform/mac/fast/replaced/007-expected.txt:
platform/mac/fast/replaced/border-radius-clip-expected.txt:
platform/mac/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
platform/mac/fast/replaced/replaced-breaking-expected.txt:
platform/mac/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt:
platform/mac/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.txt:
platform/mac/fast/table/quote-text-around-iframe-expected.txt:
platform/mac/fast/text/selection-hard-linebreak-expected.txt:
platform/mac/http/tests/loading/simple-subframe-expected.txt:
platform/mac/http/tests/local/file-url-sent-as-referer-expected.txt:
platform/mac/http/tests/misc/acid3-expected.txt:
platform/mac/http/tests/misc/favicon-as-image-expected.txt:
platform/mac/http/tests/misc/frame-access-during-load-expected.txt:
platform/mac/http/tests/misc/iframe404-expected.txt:
platform/mac/http/tests/misc/location-replace-crossdomain-expected.txt:
platform/mac/http/tests/multipart/invalid-image-data-standalone-expected.txt:
platform/mac/plugins/update-widget-from-style-recalc-expected.txt:
platform/mac/plugins/update-widget-from-style-recalc.html:
platform/mac/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt:
platform/mac/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt:
platform/mac/svg/custom/embedding-external-svgs-expected.txt:
platform/mac/svg/hixie/rendering-model/003-expected.txt:
platform/mac/svg/in-html/by-reference-expected.txt:
platform/mac/tables/mozilla/bugs/bug131020-expected.txt:
platform/mac/tables/mozilla/bugs/bug38916-expected.txt:
platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
platform/mac/webarchive/loading/cache-expired-subresource-expected.txt:
platform/win-xp/media/media-document-audio-repaint-expected.txt:
platform/win/http/tests/misc/acid3-expected.txt:
plugins/iframe-plugin-bgcolor-expected.txt:
printing/iframe-print-expected.txt:
scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt:
scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt:
svg/as-object/svg-embedded-in-html-in-iframe-expected.txt:
tables/mozilla/bugs/bug137388-1-expected.txt:
tables/mozilla/bugs/bug137388-2-expected.txt:
tables/mozilla/bugs/bug137388-3-expected.txt:
tables/mozilla/bugs/bug50695-2-expected.txt:

10:49 PM Changeset in webkit [159016] by mitz@apple.com

6 edits
2 adds in trunk/Source/WebKit2

Use createCFURLFromBuffer when converting a String to a CFURL
https://bugs.webkit.org/show_bug.cgi?id=124113

Reviewed by Anders Carlsson.

Shared/API/c/cf/WKURLCF.mm:

(WKURLCopyCFURL): Replaced some code with a call to createCFURLFromBuffer(), which does the
same thing.

Shared/Cocoa/WKNSURLExtras.h: Added.
Shared/Cocoa/WKNSURLExtras.mm: Added.

(+[NSURL _web_URLWithWTFString:relativeToURL:]): Added. Returns nil for the null String,
otherwise returns the result of createCFURLFromBuffer().

UIProcess/API/Cocoa/WKBackForwardListItem.mm:

(-[WKBackForwardListItem URL]): Changed to use +_web_URLWithWTFString:relativeToURL:.
(-[WKBackForwardListItem originalURL]): Ditto.

UIProcess/API/Cocoa/WKNavigationData.mm:

(-[WKNavigationData destinationURL]): Ditto.

UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController unreachableURL]): Ditto.

WebKit2.xcodeproj/project.pbxproj: Added references to new files.

10:45 PM Changeset in webkit [159015] by akling@apple.com

3 edits
2 copies
9 moves
1 add
13 deletes in trunk/LayoutTests

Optimize baselines: svg/W3C-SVG-1.1-SE

Unreviewed; run "webkit-patch optimize-baselines svg/W3C-SVG-1.1-SE"

platform/efl/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Removed.
platform/efl/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Removed.
platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Removed.
platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Removed.
platform/gtk/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Removed.
platform/gtk/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Removed.
platform/gtk/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Removed.
platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Removed.
platform/gtk/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Removed.
platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Removed.
platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Removed.
platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Removed.
platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Removed.
platform/win-future/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Copied from LayoutTests/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt.
platform/win-future/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Copied from LayoutTests/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt.
svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt.
svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt.
svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt.
svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt.
svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt.
svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt.
svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt.
svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt.
svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt.
svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:

10:42 PM Changeset in webkit [159014] by akling@apple.com

1 edit
9 moves
9 deletes in trunk/LayoutTests

Optimize baselines: svg/carto.net

Unreviewed; run "webkit-patch optimize-baselines svg/carto.net"

platform/gtk/svg/carto.net/button-expected.txt: Removed.
platform/gtk/svg/carto.net/colourpicker-expected.txt: Removed.
platform/gtk/svg/carto.net/combobox-expected.txt: Removed.
platform/gtk/svg/carto.net/scrollbar-expected.txt: Removed.
platform/gtk/svg/carto.net/selectionlist-expected.txt: Removed.
platform/gtk/svg/carto.net/slider-expected.txt: Removed.
platform/gtk/svg/carto.net/tabgroup-expected.txt: Removed.
platform/gtk/svg/carto.net/textbox-expected.txt: Removed.
platform/gtk/svg/carto.net/window-expected.txt: Removed.
svg/carto.net/button-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/button-expected.txt.
svg/carto.net/colourpicker-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/colourpicker-expected.txt.
svg/carto.net/combobox-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/combobox-expected.txt.
svg/carto.net/scrollbar-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/scrollbar-expected.txt.
svg/carto.net/selectionlist-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/selectionlist-expected.txt.
svg/carto.net/slider-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/slider-expected.txt.
svg/carto.net/tabgroup-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/tabgroup-expected.txt.
svg/carto.net/textbox-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/textbox-expected.txt.
svg/carto.net/window-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/window-expected.txt.

10:39 PM Changeset in webkit [159013] by akling@apple.com

1 edit
10 moves
10 deletes in trunk/LayoutTests

Optimize baselines: svg/css

Unreviewed; run "webkit-patch optimize-baselines svg/css"

platform/gtk/svg/css/circle-in-mask-with-shadow-expected.png: Removed.
platform/gtk/svg/css/clippath-with-shadow-expected.png: Removed.
platform/gtk/svg/css/group-with-shadow-expected.txt: Removed.
platform/gtk/svg/css/path-with-shadow-expected.png: Removed.
platform/gtk/svg/css/shadow-with-large-radius-expected.png: Removed.
platform/gtk/svg/css/shadow-with-negative-offset-expected.png: Removed.
platform/gtk/svg/css/stars-with-shadow-expected.txt: Removed.
platform/gtk/svg/css/text-gradient-shadow-expected.txt: Removed.
platform/mac/svg/css/composite-shadow-example-expected.txt: Removed.
platform/mac/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
svg/css/circle-in-mask-with-shadow-expected.png: Renamed from LayoutTests/platform/efl-wk1/svg/css/circle-in-mask-with-shadow-expected.png.
svg/css/clippath-with-shadow-expected.png: Renamed from LayoutTests/platform/efl/svg/css/clippath-with-shadow-expected.png.
svg/css/composite-shadow-example-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/composite-shadow-example-expected.txt.
svg/css/composite-shadow-with-opacity-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/composite-shadow-with-opacity-expected.txt.
svg/css/group-with-shadow-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/group-with-shadow-expected.txt.
svg/css/path-with-shadow-expected.png: Renamed from LayoutTests/platform/efl-wk1/svg/css/path-with-shadow-expected.png.
svg/css/shadow-with-large-radius-expected.png: Renamed from LayoutTests/platform/efl-wk1/svg/css/shadow-with-large-radius-expected.png.
svg/css/shadow-with-negative-offset-expected.png: Renamed from LayoutTests/platform/efl-wk1/svg/css/shadow-with-negative-offset-expected.png.
svg/css/stars-with-shadow-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/stars-with-shadow-expected.txt.
svg/css/text-gradient-shadow-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/text-gradient-shadow-expected.txt.

10:37 PM Changeset in webkit [159012] by akling@apple.com

3 edits in trunk/Source/WebCore

SVGTextMetricsBuilder::walkTree() should take a RenderElement.
<https://webkit.org/b/124105>

Make walkTree() take a RenderElement so we can use the non-virtual
firstChild() internally. All call sites had pointers to compatible
objects already.

Reviewed by Anders Carlsson.

9:48 PM Changeset in webkit [159011] by akling@apple.com

3 edits in trunk/Source/WebCore

RenderMathMLFenced should pass around operators in tighter types.
<https://webkit.org/b/124115>

Store operator renderers in RenderMathMLOperator pointers instead
of passing them around as RenderObject.

Reviewed by Martin Robinson.

9:47 PM Changeset in webkit [159010] by akling@apple.com

6 edits in trunk/Source/WebCore

Use RENDER_OBJECT_TYPE_CASTS for more types.
<https://webkit.org/b/124112>

Generate toRenderFoo() type casting helpers for these classes:

RenderCombineText
RenderDetailsMarker
RenderListMarker
RenderVideo
RenderView

Reviewed by Anders Carlsson.

9:08 PM Changeset in webkit [159009] by akling@apple.com

13 edits in trunk/Source/WebCore

Move MathML type checking virtuals to RenderObject.
<https://webkit.org/b/124111>

Previously, checking the type of a MathML renderer would require
that you first check if it's a RenderMathMLBlock, and then casting
to that type to access the check you really wanted.

This change moves all the isRenderMathMLFoo() virtual functions
to RenderObject. I also made sure all the overloads were private
and marked them OVERRIDE/FINAL as appropriate.

Finally I replaced all the hand-written casting functions with
autogenerated ones using RENDER_OBJECT_TYPE_CASTS.

Reviewed by Anders Carlsson.

8:20 PM Changeset in webkit [159008] by oliver@apple.com

12 edits
3 moves
6 adds in trunk

Add Map Iterators
https://bugs.webkit.org/show_bug.cgi?id=124109

Reviewed by Andreas Kling.

Source/JavaScriptCore:

Added new Map iterator implementation. This is a mostly boilerplate patch
however there's a a little bit of additional logic added to the MapData iterator
to deal with the possibility of map mutation between creation of the iterator
and use of it. We'll be able to improve the performance of this substantially
by using intrinsics, however I'm pondering coming up with a better way to define
these thunks without requiring so much duplicated logic.

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:
runtime/CommonIdentifiers.h:
runtime/JSGlobalObject.cpp:
runtime/JSGlobalObject.h:
runtime/JSMapIterator.cpp: Added.

(JSC::JSMapIterator::finishCreation):
(JSC::JSMapIterator::visitChildren):
(JSC::JSMapIterator::createPair):

runtime/JSMapIterator.h: Added.

(JSC::JSMapIterator::createStructure):
(JSC::JSMapIterator::create):
(JSC::JSMapIterator::next):
(JSC::JSMapIterator::JSMapIterator):

runtime/MapData.h:

(JSC::MapData::const_iterator::ensureSlot):

runtime/MapIteratorConstructor.cpp: Added.

(JSC::MapIteratorConstructor::finishCreation):

runtime/MapIteratorConstructor.h: Added.

(JSC::MapIteratorConstructor::create):
(JSC::MapIteratorConstructor::createStructure):
(JSC::MapIteratorConstructor::MapIteratorConstructor):

runtime/MapIteratorPrototype.cpp: Added.

(JSC::MapIteratorPrototype::finishCreation):
(JSC::MapIteratorPrototypeFuncIterator):
(JSC::MapIteratorPrototypeFuncNext):

runtime/MapIteratorPrototype.h: Added.

(JSC::MapIteratorPrototype::create):
(JSC::MapIteratorPrototype::createStructure):
(JSC::MapIteratorPrototype::MapIteratorPrototype):

runtime/MapPrototype.cpp:

(JSC::MapPrototype::finishCreation):
(JSC::mapProtoFuncValues):
(JSC::mapProtoFuncEntries):
(JSC::mapProtoFuncKeys):

LayoutTests:

Moved map tests to a more sensible location, and added new iteration tests.

js/basic-map-expected.txt: Renamed from LayoutTests/js/dom/basic-map-expected.txt.
js/basic-map.html: Renamed from LayoutTests/js/dom/basic-map.html.
js/script-tests/basic-map.js: Renamed from LayoutTests/js/dom/script-tests/basic-map.js.

(set shouldBe):
(set var):

7:39 PM Changeset in webkit [159007] by Martin Robinson

7 edits in trunk

[MathML] Poor spacing around delimiters in MathML Torture Test 14
https://bugs.webkit.org/show_bug.cgi?id=122837

Reviewed by Brent Fulgham.

Instead of stretching the vertical bar with the stretchable version, just repeat
the normal vertical bar. This follows what Gecko does when rendering tall vertical
bars and also works around an issue with STIX fonts leading to poor spacing in
formulas.

Source/WebCore:

rendering/mathml/RenderMathMLOperator.cpp: Stretch the vertical bar with the

normal variant.

LayoutTests:

platform/gtk/mathml/presentation/mo-stretch-expected.png: Update to reflect new results.
platform/gtk/mathml/presentation/mo-stretch-expected.txt: Ditto.
platform/mac/mathml/presentation/mo-stretch-expected.png: Ditto.
platform/mac/mathml/presentation/mo-stretch-expected.txt: Ditto.

7:36 PM Changeset in webkit [159006] by akling@apple.com

2 edits
1 copy
20 moves
1 add
22 deletes in trunk/LayoutTests

Optimize baselines: svg/clip-path

Unreviewed; run "webkit-patch optimize-baselines svg/clip-path"

platform/efl/svg/clip-path/clip-path-pixelation-expected.txt: Removed.
platform/gtk/svg/clip-path/clip-in-clip-expected.png: Removed.
platform/gtk/svg/clip-path/clip-path-clipped-no-content-expected.png: Removed.
platform/gtk/svg/clip-path/clip-path-pixelation-expected.txt: Removed.
platform/gtk/svg/clip-path/clip-path-recursive-call-by-child-expected.png: Removed.
platform/gtk/svg/clip-path/clip-path-recursive-call-expected.png: Removed.
platform/gtk/svg/clip-path/clip-path-text-and-shape-expected.txt: Removed.
platform/gtk/svg/clip-path/clip-path-text-and-stroke-expected.txt: Removed.
platform/gtk/svg/clip-path/clip-path-text-expected.txt: Removed.
platform/gtk/svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Removed.
platform/gtk/svg/clip-path/clip-path-use-as-child2-expected.png: Removed.
platform/gtk/svg/clip-path/clip-path-use-as-child3-expected.png: Removed.
platform/gtk/svg/clip-path/clip-path-use-as-child4-expected.png: Removed.
platform/gtk/svg/clip-path/clip-path-use-as-child5-expected.png: Removed.
platform/gtk/svg/clip-path/clip-path-with-container-expected.png: Removed.
platform/gtk/svg/clip-path/clip-path-with-different-unittypes-expected.png: Removed.
platform/gtk/svg/clip-path/clip-path-with-different-unittypes2-expected.png: Removed.
platform/gtk/svg/clip-path/clip-path-with-invisibile-child-expected.png: Removed.
platform/gtk/svg/clip-path/clip-path-with-text-clipped-expected.txt: Removed.
platform/gtk/svg/clip-path/clipper-placement-issue-expected.png: Removed.
platform/gtk/svg/clip-path/deep-nested-clip-in-mask-expected.txt: Removed.
platform/gtk/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Removed.
platform/win-future/svg/clip-path/clip-path-pixelation-expected.txt: Copied from LayoutTests/svg/clip-path/clip-path-pixelation-expected.txt.
svg/clip-path/clip-in-clip-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-in-clip-expected.png.
svg/clip-path/clip-path-clipped-no-content-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-clipped-no-content-expected.png.
svg/clip-path/clip-path-pixelation-expected.txt:
svg/clip-path/clip-path-recursive-call-by-child-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-recursive-call-by-child-expected.png.
svg/clip-path/clip-path-recursive-call-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-recursive-call-expected.png.
svg/clip-path/clip-path-text-and-shape-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-text-and-shape-expected.txt.
svg/clip-path/clip-path-text-and-stroke-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-text-and-stroke-expected.txt.
svg/clip-path/clip-path-text-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-text-expected.txt.
svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-tspan-and-stroke-expected.txt.
svg/clip-path/clip-path-use-as-child2-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-use-as-child2-expected.png.
svg/clip-path/clip-path-use-as-child3-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-use-as-child3-expected.png.
svg/clip-path/clip-path-use-as-child4-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-use-as-child4-expected.png.
svg/clip-path/clip-path-use-as-child5-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-use-as-child5-expected.png.
svg/clip-path/clip-path-with-container-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-container-expected.png.
svg/clip-path/clip-path-with-different-unittypes-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-different-unittypes-expected.png.
svg/clip-path/clip-path-with-different-unittypes2-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-different-unittypes2-expected.png.
svg/clip-path/clip-path-with-invisibile-child-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-invisibile-child-expected.png.
svg/clip-path/clip-path-with-text-clipped-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-text-clipped-expected.txt.
svg/clip-path/clipper-placement-issue-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clipper-placement-issue-expected.png.
svg/clip-path/deep-nested-clip-in-mask-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/deep-nested-clip-in-mask-expected.txt.
svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt.

7:32 PM Changeset in webkit [159005] by akling@apple.com

2 edits
5 copies
48 moves
2 adds
57 deletes in trunk/LayoutTests

Optimize baselines: svg/hixie

Unreviewed; run "webkit-patch optimize-baselines svg/hixie"

platform/efl/svg/hixie/perf/007-expected.txt: Removed.
platform/gtk/svg/hixie/dynamic/002-expected.png: Removed.
platform/gtk/svg/hixie/dynamic/003-expected.png: Removed.
platform/gtk/svg/hixie/dynamic/004-expected.png: Removed.
platform/gtk/svg/hixie/dynamic/005-expected.png: Removed.
platform/gtk/svg/hixie/dynamic/006-expected.png: Removed.
platform/gtk/svg/hixie/error/001-expected.png: Removed.
platform/gtk/svg/hixie/error/002-expected.png: Removed.
platform/gtk/svg/hixie/error/002-expected.txt: Removed.
platform/gtk/svg/hixie/error/003-expected.txt: Removed.
platform/gtk/svg/hixie/error/006-expected.png: Removed.
platform/gtk/svg/hixie/error/007-expected.png: Removed.
platform/gtk/svg/hixie/error/008-expected.png: Removed.
platform/gtk/svg/hixie/error/009-expected.png: Removed.
platform/gtk/svg/hixie/error/010-expected.png: Removed.
platform/gtk/svg/hixie/error/010-expected.txt: Removed.
platform/gtk/svg/hixie/error/011-expected.png: Removed.
platform/gtk/svg/hixie/error/011-expected.txt: Removed.
platform/gtk/svg/hixie/error/014-expected.png: Removed.
platform/gtk/svg/hixie/error/014-test-expected.png: Removed.
platform/gtk/svg/hixie/error/015-expected.png: Removed.
platform/gtk/svg/hixie/error/016-expected.png: Removed.
platform/gtk/svg/hixie/error/017-expected.txt: Removed.
platform/gtk/svg/hixie/intrinsic/001-expected.png: Removed.
platform/gtk/svg/hixie/intrinsic/001-expected.txt: Removed.
platform/gtk/svg/hixie/intrinsic/002-expected.png: Removed.
platform/gtk/svg/hixie/intrinsic/002-expected.txt: Removed.
platform/gtk/svg/hixie/links/002-expected.png: Removed.
platform/gtk/svg/hixie/links/002-expected.txt: Removed.
platform/gtk/svg/hixie/mixed/007-expected.png: Removed.
platform/gtk/svg/hixie/painting/001-expected.png: Removed.
platform/gtk/svg/hixie/perf/001-expected.txt: Removed.
platform/gtk/svg/hixie/perf/002-expected.txt: Removed.
platform/gtk/svg/hixie/perf/003-expected.txt: Removed.
platform/gtk/svg/hixie/perf/004-expected.txt: Removed.
platform/gtk/svg/hixie/perf/005-expected.txt: Removed.
platform/gtk/svg/hixie/perf/006-expected.txt: Removed.
platform/gtk/svg/hixie/perf/007-expected.txt: Removed.
platform/gtk/svg/hixie/processing-model/003-expected.png: Removed.
platform/gtk/svg/hixie/processing-model/004-expected.png: Removed.
platform/gtk/svg/hixie/processing-model/005-expected.png: Removed.
platform/gtk/svg/hixie/rendering-model/003a-expected.png: Removed.
platform/gtk/svg/hixie/shapes/path/001-expected.txt: Removed.
platform/gtk/svg/hixie/text/002-expected.txt: Removed.
platform/gtk/svg/hixie/text/003a-expected.txt: Removed.
platform/gtk/svg/hixie/text/003b-expected.txt: Removed.
platform/gtk/svg/hixie/use/001-expected.png: Removed.
platform/gtk/svg/hixie/use/002-expected.png: Removed.
platform/gtk/svg/hixie/use/002-test-expected.png: Removed.
platform/gtk/svg/hixie/viewbox/001-expected.png: Removed.
platform/gtk/svg/hixie/viewbox/004-expected.png: Removed.
platform/gtk/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Removed.
platform/gtk/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Removed.
platform/mac/svg/hixie/cascade/002-expected.txt: Removed.
platform/mac/svg/hixie/perf/004-expected.txt: Removed.
platform/mac/svg/hixie/perf/005-expected.txt: Removed.
platform/mac/svg/hixie/perf/006-expected.txt: Removed.
platform/win-future/svg/hixie/perf/007-expected.txt: Copied from LayoutTests/svg/hixie/perf/007-expected.txt.
svg/hixie/cascade/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/cascade/002-expected.txt.
svg/hixie/dynamic/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/002-expected.png.
svg/hixie/dynamic/003-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/003-expected.png.
svg/hixie/dynamic/004-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/004-expected.png.
svg/hixie/dynamic/005-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/005-expected.png.
svg/hixie/dynamic/006-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/006-expected.png.
svg/hixie/error/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/001-expected.png.
svg/hixie/error/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/002-expected.png.
svg/hixie/error/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/002-expected.txt.
svg/hixie/error/003-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/003-expected.txt.
svg/hixie/error/006-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/006-expected.png.
svg/hixie/error/007-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/007-expected.png.
svg/hixie/error/008-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/008-expected.png.
svg/hixie/error/009-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/009-expected.png.
svg/hixie/error/010-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/010-expected.png.
svg/hixie/error/010-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/010-expected.txt.
svg/hixie/error/011-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/011-expected.png.
svg/hixie/error/011-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/011-expected.txt.
svg/hixie/error/014-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/014-expected.png.
svg/hixie/error/014-test-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/014-test-expected.png.
svg/hixie/error/015-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/015-expected.png.
svg/hixie/error/016-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/016-expected.png.
svg/hixie/error/017-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/017-expected.txt.
svg/hixie/intrinsic/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/intrinsic/001-expected.png.
svg/hixie/intrinsic/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/intrinsic/001-expected.txt.
svg/hixie/intrinsic/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/intrinsic/002-expected.png.
svg/hixie/intrinsic/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/intrinsic/002-expected.txt.
svg/hixie/links/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/links/002-expected.png.
svg/hixie/links/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/links/002-expected.txt.
svg/hixie/mixed/007-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/mixed/007-expected.png.
svg/hixie/painting/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/painting/001-expected.png.
svg/hixie/perf/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/001-expected.txt.
svg/hixie/perf/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/002-expected.txt.
svg/hixie/perf/003-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/003-expected.txt.
svg/hixie/perf/004-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/004-expected.txt.
svg/hixie/perf/005-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/005-expected.txt.
svg/hixie/perf/006-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/006-expected.txt.
svg/hixie/perf/007-expected.txt:
svg/hixie/processing-model/003-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/processing-model/003-expected.png.
svg/hixie/processing-model/004-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/processing-model/004-expected.png.
svg/hixie/processing-model/005-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/processing-model/005-expected.png.
svg/hixie/rendering-model/003a-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/rendering-model/003a-expected.png.
svg/hixie/shapes/path/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/shapes/path/001-expected.txt.
svg/hixie/text/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/text/002-expected.txt.
svg/hixie/text/003a-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/text/003a-expected.txt.
svg/hixie/text/003b-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/text/003b-expected.txt.
svg/hixie/use/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/use/001-expected.png.
svg/hixie/use/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/use/002-expected.png.
svg/hixie/use/002-test-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/use/002-test-expected.png.
svg/hixie/viewbox/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/viewbox/001-expected.png.
svg/hixie/viewbox/004-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/viewbox/004-expected.png.
svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt.
svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt.

5:27 PM Changeset in webkit [159004] by andersca@apple.com

7 edits in trunk/Source

Encode form data using the KeyedEncoder
https://bugs.webkit.org/show_bug.cgi?id=124107

Reviewed by Sam Weinig.

Source/WebCore:

platform/KeyedCoding.h:

(WebCore::KeyedEncoder::encodeEnum):

platform/network/FormData.cpp:

(WebCore::encodeElement):
(WebCore::FormData::encode):

platform/network/FormData.h:

Source/WebKit2:

Shared/cf/KeyedEncoder.cpp:

(WebKit::KeyedEncoder::encodeBool):
(WebKit::KeyedEncoder::encodeDouble):

Shared/cf/KeyedEncoder.h:

3:26 PM Changeset in webkit [159003] by andersca@apple.com

1 edit
1 delete in trunk/Source/WebKit2

Remove an unused file.

Rubber-stamped by Andreas Kling.

WebProcess/WebPage/gtk/ChunkedUpdateDrawingAreaGtk.cpp: Removed.

1:41 PM Changeset in webkit [159002] by weinig@apple.com

2 edits in trunk/Source/WebCore

Modernize CanvasObserverProxy
https://bugs.webkit.org/show_bug.cgi?id=124106

Reviewed by Anders Carlsson.

css/CSSCanvasValue.h:

12:59 PM Changeset in webkit [159001] by Patrick Gansterer

101 edits
7 moves
1 add in trunk/Source

Move RunLoop from WebCore to WTF
https://bugs.webkit.org/show_bug.cgi?id=116606

Reviewed by Anders Carlsson.

Source/WebCore:

CMakeLists.txt:
GNUmakefile.list.am:
PlatformBlackBerry.cmake:
PlatformEfl.cmake:
PlatformGTK.cmake:
PlatformWin.cmake:
WebCore.exp.in:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:

Source/WebKit/mac:

Carbon/CarbonWindowAdapter.mm:

(+[CarbonWindowAdapter initialize]):

History/WebBackForwardList.mm:

(+[WebBackForwardList initialize]):

History/WebHistoryItem.mm:

(+[WebHistoryItem initialize]):

Misc/WebCache.mm:

(+[WebCache initialize]):

Misc/WebElementDictionary.mm:

(+[WebElementDictionary initialize]):

Misc/WebIconDatabase.mm:

(+[WebIconDatabase initialize]):

Plugins/Hosted/WebHostedNetscapePluginView.mm:

(+[WebHostedNetscapePluginView initialize]):

Plugins/WebBaseNetscapePluginView.mm:
Plugins/WebBasePluginPackage.mm:
Plugins/WebNetscapePluginView.mm:

(+[WebNetscapePluginView initialize]):

WebCoreSupport/WebEditorClient.mm:

(+[WebUndoStep initialize]):

WebCoreSupport/WebFrameLoaderClient.mm:
WebView/WebArchive.mm:

(+[WebArchivePrivate initialize]):

WebView/WebDataSource.mm:

(+[WebDataSource initialize]):

WebView/WebHTMLView.mm:

(+[WebHTMLViewPrivate initialize]):
(+[WebHTMLView initialize]):

WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

WebView/WebResource.mm:

(+[WebResourcePrivate initialize]):

WebView/WebTextIterator.mm:

(+[WebTextIteratorPrivate initialize]):

WebView/WebView.mm:

(+[WebView initialize]):

WebView/WebViewData.mm:

(+[WebViewPrivate initialize]):

Source/WebKit2:

DatabaseProcess/DatabaseProcess.cpp:
DatabaseProcess/DatabaseToWebProcessConnection.cpp:
NetworkProcess/NetworkConnectionToWebProcess.cpp:
NetworkProcess/NetworkProcess.cpp:
NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkResourceLoader.h:
NetworkProcess/mac/DiskCacheMonitor.h:
NetworkProcess/unix/NetworkProcessMainUnix.cpp:
Platform/CoreIPC/Connection.cpp:
Platform/CoreIPC/Connection.h:
Platform/CoreIPC/mac/ConnectionMac.cpp:
PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:
PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm:
PluginProcess/PluginControllerProxy.h:
PluginProcess/PluginProcess.cpp:
PluginProcess/PluginProcess.h:
PluginProcess/WebProcessConnection.cpp:
PluginProcess/unix/PluginProcessMainUnix.cpp:
Shared/ChildProcess.cpp:
Shared/ChildProcess.h:
Shared/ChildProcessProxy.cpp:
Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.h:
Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.mm:
Shared/Plugins/NPObjectProxy.cpp:
Shared/WebKit2Initialize.cpp:

(WebKit::InitializeWebKit2):

UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
UIProcess/API/mac/FindIndicatorWindow.h:
UIProcess/API/mac/WKPrintingView.mm:
UIProcess/API/mac/WKView.mm:
UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h:
UIProcess/DrawingAreaProxyImpl.h:
UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
UIProcess/Launcher/mac/ProcessLauncherMac.mm:
UIProcess/Network/NetworkProcessProxy.cpp:
UIProcess/Plugins/PluginProcessProxy.cpp:
UIProcess/ResponsivenessTimer.cpp:
UIProcess/ResponsivenessTimer.h:
UIProcess/VisitedLinkProvider.h:
UIProcess/WebContext.cpp:
UIProcess/WebProcessProxy.cpp:
WebProcess/Databases/WebToDatabaseProcessConnection.cpp:
WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
WebProcess/Network/WebResourceLoadScheduler.h:
WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
WebProcess/Plugins/Netscape/NetscapePlugin.h:
WebProcess/Plugins/Netscape/NetscapePluginStream.h:
WebProcess/Plugins/PluginView.h:
WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:
WebProcess/WebPage/DrawingAreaImpl.h:
WebProcess/WebPage/EventDispatcher.cpp:
WebProcess/WebPage/PageOverlay.h:
WebProcess/WebPage/WebPage.cpp:
WebProcess/WebPage/WebPage.h:
WebProcess/WebProcess.cpp:
WebProcess/efl/WebProcessMainEfl.cpp:
WebProcess/gtk/WebProcessMainGtk.cpp:

Source/WTF:

With this change RunLoop can be used in JavaScriptCore too.

GNUmakefile.list.am:
WTF.vcxproj/WTF.vcxproj:
WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/PlatformBlackBerry.cmake:
wtf/PlatformEfl.cmake:
wtf/PlatformGTK.cmake:
wtf/PlatformWin.cmake:
wtf/RunLoop.cpp: Renamed from Source/WebCore/platform/RunLoop.cpp.

(WTF::RunLoop::Holder::Holder):
(WTF::RunLoop::Holder::runLoop):
(WTF::RunLoop::initializeMainRunLoop):
(WTF::RunLoop::current):
(WTF::RunLoop::main):
(WTF::RunLoop::isMain):
(WTF::RunLoop::performWork):
(WTF::RunLoop::dispatch):

wtf/RunLoop.h: Renamed from Source/WebCore/platform/RunLoop.h.

(WTF::RunLoop::TimerBase::startRepeating):
(WTF::RunLoop::TimerBase::startOneShot):
(WTF::RunLoop::TimerBase::isRepeating):
(WTF::RunLoop::Timer::Timer):
(WTF::RunLoop::Timer::fired):

wtf/blackberry/RunLoopBlackBerry.cpp: Renamed from Source/WebCore/platform/blackberry/RunLoopBlackBerry.cpp.

(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::wakeUp):

wtf/cf/RunLoopCF.cpp: Renamed from Source/WebCore/platform/cf/RunLoopCF.cpp.

(WTF::RunLoop::performWork):
(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::runForDuration):
(WTF::RunLoop::wakeUp):
(WTF::RunLoop::run):
(WTF::RunLoop::stop):
(WTF::RunLoop::TimerBase::timerFired):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::~TimerBase):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):

wtf/efl/RunLoopEfl.cpp: Renamed from Source/WebCore/platform/efl/RunLoopEfl.cpp.

(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::run):
(WTF::RunLoop::stop):
(WTF::RunLoop::wakeUpEvent):
(WTF::RunLoop::wakeUp):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::~TimerBase):
(WTF::RunLoop::TimerBase::timerFired):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):

wtf/gtk/RunLoopGtk.cpp: Renamed from Source/WebCore/platform/gtk/RunLoopGtk.cpp.

(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::run):
(WTF::RunLoop::innermostLoop):
(WTF::RunLoop::pushNestedMainLoop):
(WTF::RunLoop::popNestedMainLoop):
(WTF::RunLoop::stop):
(WTF::RunLoop::queueWork):
(WTF::RunLoop::wakeUp):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::~TimerBase):
(WTF::RunLoop::TimerBase::clearTimerSource):
(WTF::RunLoop::TimerBase::timerFiredCallback):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):

wtf/win/RunLoopWin.cpp: Renamed from Source/WebCore/platform/win/RunLoopWin.cpp.

(WTF::RunLoop::RunLoopWndProc):
(WTF::RunLoop::wndProc):
(WTF::RunLoop::run):
(WTF::RunLoop::stop):
(WTF::RunLoop::registerRunLoopMessageWindowClass):
(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::wakeUp):
(WTF::RunLoop::TimerBase::timerFired):
(WTF::generateTimerID):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::~TimerBase):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):

8:11 AM Changeset in webkit [159000] by akling@apple.com

4 edits in trunk/Source/WebCore

Tighten typing in SVGResourcesCycleSolver a bit.
<https://webkit.org/b/124104>

Make the SVGResourcesCycleSolver constructor take a RenderElement&
and a SVGResources&.

While I was in the neighborhood, also converted one loop to use a
renderer iterator instead of walking siblings manually.

Finally used "auto" to clean up some overly wordy loops.

Reviewed by Anders Carlsson.

3:32 AM Changeset in webkit [158999] by akling@apple.com

18 edits in trunk/Source/WebCore

Beat SVGRenderSupport with the RenderElement stick.
<https://webkit.org/b/124102>

Tighten up all the SVGRenderSupport helper functions by making them
take const RenderElements references instead of raw RenderObject
pointers as much as possible.

This tunes up a bunch of branchy style() calls.

The patch looks big but it's mostly mechanical. I just changed the
signatures and then worked backwards until everything built again.

Reviewed by Antti Koivisto.

3:17 AM Changeset in webkit [158998] by akling@apple.com

10 edits in trunk/Source/WebCore

SVGTextLayoutAttributes always has a RenderSVGInlineText.
<https://webkit.org/b/124101>

No SVGTextLayoutAttributes object is without a RenderSVGInlineText
"context" so make context() return a reference.

Reviewed by Antti Koivisto.

3:16 AM Changeset in webkit [158997] by akling@apple.com

13 edits
2 deletes in trunk/Source/WebCore

Move BindingSecurity stuff under JSDOMBinding umbrella.
<https://webkit.org/b/124099>

We are hitting shouldAllowAccessToDOMWindow() pretty hard on the
demo here: <http://www.jasondavies.com/maps/rotate/>

Putting it together with the rest of the JSDOMBinding code takes
CPU time spent in there from 8.7% to 6.5%. The abstraction was
only used to support alternate JS engines in the past.

Reviewed by Antti Koivisto.

3:14 AM Changeset in webkit [158996] by Antti Koivisto

2 edits in trunk/PerformanceTests

Add subtest for word-break:break-all to Layout/line-layout-simple.html
https://bugs.webkit.org/show_bug.cgi?id=124103

Reviewed by Andreas Kling.

Layout/line-layout-simple.html:

Combination "white-space:pre-wrap; word-break:break-all" is common for pure text.

Nov 8, 2013:

11:57 PM Changeset in webkit [158995] by zandobersek@gmail.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed GTK build fix.

GNUmakefile.list.am: Remove redundant build targets.

10:55 PM Changeset in webkit [158994] by fpizlo@apple.com

4 edits
2 deletes in trunk/Source/JavaScriptCore

Remove dead FTL C ABI support
https://bugs.webkit.org/show_bug.cgi?id=124100

Reviewed by Jer Noble.

JavaScriptCore.xcodeproj/project.pbxproj:
ftl/FTLCArgumentGetter.cpp: Removed.
ftl/FTLCArgumentGetter.h: Removed.
ftl/FTLOSRExitCompiler.cpp:
jit/FPRInfo.h:

10:53 PM Changeset in webkit [158993] by fpizlo@apple.com

3 edits in trunk/WebKitLibraries

Update binary drops to a version that includes new stackmap fixes and exposes the new calling conventions.

LLVMIncludesMountainLion.tar.bz2:
LLVMLibrariesMountainLion.tar.bz2:

10:27 PM Changeset in webkit [158992] by beidson@apple.com

39 edits
2 moves
1 delete in trunk/Source

Merge IDBDatabaseBackendInterface and IDBDatabaseBackendImpl
https://bugs.webkit.org/show_bug.cgi?id=124088

Source/WebCore:

Reviewed by Tim Horton.

Source/WebKit2:

Reviewed by Tim Horton.

This abstraction is no longer meaningful in its current form in WebCore.
The current groundwork for the WK2 DatabaseProcess relied on this abstraction,
but that will be reworked in a future patch.

DatabaseProcess/IndexedDB/DatabaseProcessIDBDatabaseBackend.h:

WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:

(WebKit::WebIDBFactoryBackend::maybeCreateTransactionBackend):
(WebKit::WebIDBFactoryBackend::createCursorBackend):

WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:

WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.cpp:

(WebKit::WebProcessIDBDatabaseBackend::put):
(WebKit::WebProcessIDBDatabaseBackend::openCursor):

WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.h:

10:00 PM Changeset in webkit [158991] by commit-queue@webkit.org

12 edits in trunk/LayoutTests

Updating LayoutTests that depend on RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=124097

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-08
Reviewed by Eric Carlson.

Needed to do not throw unwanted exception

fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
fast/mediastream/RTCPeerConnection-createAnswer.html:
fast/mediastream/RTCPeerConnection-createOffer.html:
fast/mediastream/RTCPeerConnection-datachannel.html:
fast/mediastream/RTCPeerConnection-dtmf.html:
fast/mediastream/RTCPeerConnection-events.html:
fast/mediastream/RTCPeerConnection-ice.html:
fast/mediastream/RTCPeerConnection-localDescription.html:
fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
fast/mediastream/RTCPeerConnection-remoteDescription.html:
fast/mediastream/RTCPeerConnection-state.html:

8:40 PM Changeset in webkit [158990] by ljaehun.lim@samsung.com

2 edits in trunk/Source/WebKit2

Unreviewed build fix after r158984.

No needs to include "KeyedEncoder.h".
WebKit/Source/WebKit2/WebProcess/WebPage/WebBackForwardListProxy.cpp:31:26: fatal error: KeyedEncoder.h: No such file or directory

WebProcess/WebPage/WebBackForwardListProxy.cpp: Removed #include line.

8:24 PM Changeset in webkit [158989] by fpizlo@apple.com

4 edits in trunk/Source/JavaScriptCore

FTL should support Phantom(FinalObject:)
https://bugs.webkit.org/show_bug.cgi?id=124092

Reviewed by Oliver Hunt.

ftl/FTLAbstractHeapRepository.h:
ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::isType):
(JSC::FTL::LowerDFGToLLVM::isNotType):
(JSC::FTL::LowerDFGToLLVM::speculateFinalObject):

8:20 PM Changeset in webkit [158988] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

Get rid of the FTL tail call APIs since they are unused
https://bugs.webkit.org/show_bug.cgi?id=124093

Reviewed by Oliver Hunt.

ftl/FTLAbbreviations.h:

(JSC::FTL::buildCall):

ftl/FTLOutput.h:

8:17 PM Changeset in webkit [158987] by commit-queue@webkit.org

25 edits in trunk/LayoutTests

Improving readability of LayoutTests in fast/mediastream
https://bugs.webkit.org/show_bug.cgi?id=124095

Adding some indentation

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-08
Reviewed by Eric Carlson.

fast/mediastream/MediaStream-add-remove-tracks.html:
fast/mediastream/MediaStream-onended.html:
fast/mediastream/MediaStreamConstructor.html:
fast/mediastream/RTCIceCandidate.html:
fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
fast/mediastream/RTCPeerConnection-createAnswer.html:
fast/mediastream/RTCPeerConnection-createOffer.html:
fast/mediastream/RTCPeerConnection-datachannel.html:
fast/mediastream/RTCPeerConnection-dtmf.html:
fast/mediastream/RTCPeerConnection-events.html:
fast/mediastream/RTCPeerConnection-ice.html:
fast/mediastream/RTCPeerConnection-localDescription.html:
fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
fast/mediastream/RTCPeerConnection-remoteDescription.html:
fast/mediastream/RTCPeerConnection-state.html:
fast/mediastream/RTCPeerConnection-stats.html:
fast/mediastream/RTCPeerConnection-statsSelector.html:
fast/mediastream/RTCPeerConnection.html:
fast/mediastream/RTCSessionDescription.html:
fast/mediastream/argument-types.html:
fast/mediastream/constructors.html:
fast/mediastream/enabled.html:
fast/mediastream/getusermedia.html:
fast/mediastream/no-interface-object.html:

7:40 PM Changeset in webkit [158986] by akling@apple.com

2 edits in trunk/Source/WebCore

Reindent JSDOMBinding.h (finally.)

Rubber-stamped by Sam Weinig.

7:24 PM Changeset in webkit [158985] by weinig@apple.com

64 edits in trunk/Source/WebCore

Change collectStyleForPresentationAttribute and related functions to take a MutableStylePropertySet by reference
https://bugs.webkit.org/show_bug.cgi?id=124096

Reviewed by Andreas Kling.

Pass MutableStylePropertySet by reference. It is never null.

5:51 PM Changeset in webkit [158984] by andersca@apple.com

7 edits in trunk/Source

Implement encoding of arrays of objects
https://bugs.webkit.org/show_bug.cgi?id=124091

Reviewed by Beth Dakin.

Source/WebCore:

history/HistoryItem.cpp:

(WebCore::HistoryItem::encodeBackForwardTreeNode):
Encode the rest of the members.

platform/KeyedCoding.h:

(WebCore::KeyedEncoder::encodeObjects):
Call beginArray, then beginArrayElement/endArrayElement for every element and lastly endArray.

Source/WebKit2:

Add a new array stack and push and pop from it accordingly.

Shared/cf/KeyedEncoder.cpp:

(WebKit::KeyedEncoder::~KeyedEncoder):
(WebKit::KeyedEncoder::encodeBytes):
(WebKit::KeyedEncoder::encodeUInt32):
(WebKit::KeyedEncoder::encodeInt32):
(WebKit::KeyedEncoder::encodeInt64):
(WebKit::KeyedEncoder::encodeFloat):
(WebKit::KeyedEncoder::beginArray):
(WebKit::KeyedEncoder::beginArrayElement):
(WebKit::KeyedEncoder::endArrayElement):
(WebKit::KeyedEncoder::endArray):

Shared/cf/KeyedEncoder.h:

5:44 PM Changeset in webkit [158983] by fpizlo@apple.com

5 edits in trunk/Source/JavaScriptCore

FTL should support AllocatePropertyStorage
https://bugs.webkit.org/show_bug.cgi?id=124086

Reviewed by Oliver Hunt.

Also rationalized some offsets in the DFG.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLIntrinsicRepository.h:
ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileAllocatePropertyStorage):

5:43 PM Changeset in webkit [158982] by timothy_horton@apple.com

13 edits in trunk/Source

Remote Layer Tree: RemoteLayerBackingStore partial repaint is broken for the tile cache
https://bugs.webkit.org/show_bug.cgi?id=123944

Reviewed by Simon Fraser.

Ensure that the tile cache retrieves repaint rects from the tile layer,
not from the tiled backing layer.

Rework RemoteLayerBackingStore painting to fix some rounding issues
that would cause pixel cracks upon repaint, and to speed it up a bit.

Shared/mac/RemoteLayerBackingStore.h:

Redefine RepaintRectList because we can't include WebLayer.h here yet.
Remove createBackingStore, which was never implemented.
Remove mapToContentCoordinates, because we don't need it on Mac.

(WebKit::RemoteLayerBackingStore::paintingRects): Added.

Shared/mac/RemoteLayerBackingStore.mm:

(RemoteLayerBackingStore::setNeedsDisplay):
(RemoteLayerBackingStore::display):
Stop using mapToContentCoordinates.

(RemoteLayerBackingStore::drawInContext):
Use clipping instead of painting the image multiple times.
Never repaint more than the dirty region's bounds.
Don't waste time with all of the drawNativeImage code, just use CG.
Unindent the switch's cases.
Store the rects we're painting so that enumerateRectsBeingDrawn can get them.
Pixel-snap the rects we're painting.
Clip the context before going to paint.

WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::enumerateRectsBeingDrawn):

WebProcess/WebPage/mac/PlatformCALayerRemote.h:

Retrieve the rects currently being painted from our backing store, and
transform them (mostly) according to the CTM, to match the transformation
that will have occurred underneath wkCALayerEnumerateRectsBeingDrawnWithBlock.

platform/graphics/ca/PlatformCALayer.h:
platform/graphics/ca/mac/PlatformCALayerMac.h:
platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayerMac::enumerateRectsBeingDrawn):
Allow the PlatformCALayer to decide how to enumerate rects to paint.

WebCore.exp.in:
platform/graphics/mac/WebLayer.h:

Add RepaintRectList, remove some unnecessary WebCore::s.

platform/graphics/mac/WebLayer.mm:

(WebCore::collectRectsToPaint):
Factor collectRectsToPaint out; it just grabs the rects from
the layer and makes the decision whether to repaint the bounds
of the dirty region or just the subregions.

Move calls to collectRectsToPaint() to callers of drawLayerContents(),
so that TileController can collect rects from the appropriate source
(the Tile layer) and other layers just continue grabbing them from
their relevant layers.

Make sure that the list that comes from collectRectsToPaint() always
has at least one rect in it (appending the clip bounds if we don't
want to repaint subregions) so we can simplify logic in drawLayerContents.

(WebCore::drawLayerContents):
Remove code to support CompositingCoordinatesBottomUp, as it's only
used on Windows, so this Mac-specific code doesn't need to support it.

Simplify logic given that dirtyRects will always be non-empty.

(-[WebLayer drawInContext:]):
(-[WebSimpleLayer setNeedsDisplayInRect:]):

platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::platformCALayerPaintContents):
Adopt collectRectsToPaint.

5:29 PM Changeset in webkit [158981] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

Get rid of the bizarre Darwin/x86-only MacroAssembler::shouldBlindForSpecificArch(uintptr_t) overload
https://bugs.webkit.org/show_bug.cgi?id=124087

Reviewed by Michael Saboff.

assembler/MacroAssembler.h:

(JSC::MacroAssembler::shouldBlindPointerForSpecificArch):
(JSC::MacroAssembler::shouldBlind):

assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::shouldBlindForSpecificArch):

5:16 PM Changeset in webkit [158980] by andersca@apple.com

7 edits in trunk/Source

Implement more KeyedEncoder functionality
https://bugs.webkit.org/show_bug.cgi?id=124089

Reviewed by Beth Dakin.

Source/WebCore:

bindings/js/SerializedScriptValue.h:
history/HistoryItem.cpp:

(WebCore::HistoryItem::encodeBackForwardTreeNode):

platform/KeyedCoding.h:

(WebCore::KeyedEncoder::encodeConditionalObject):

Source/WebKit2:

Shared/cf/KeyedEncoder.cpp:

(WebKit::KeyedEncoder::encodeBytes):
(WebKit::KeyedEncoder::encodeInt32):
(WebKit::KeyedEncoder::encodeFloat):

Shared/cf/KeyedEncoder.h:

5:13 PM Changeset in webkit [158979] by eric.carlson@apple.com

3 edits
2 adds in trunk

getCueAsHTML() on an empty cue should return a document fragment
https://bugs.webkit.org/show_bug.cgi?id=124084

Reviewed by Darin Adler.

Source/WebCore:

Test: media/track/track-cue-empty-cue-text.html

html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::createDocumentFragmentFromCueText): Don't return early when the

passed an empty string.

LayoutTests:

media/track/track-cue-empty-cue-text-expected.txt: Added.
media/track/track-cue-empty-cue-text.html: Added.

4:51 PM Changeset in webkit [158978] by andersca@apple.com

7 edits in trunk/Source

KeyedEncoder should be able to encoder objects
https://bugs.webkit.org/show_bug.cgi?id=124085

Reviewed by Sam Weinig.

Source/WebCore:

history/HistoryItem.cpp:

(WebCore::HistoryItem::encodeBackForwardTree):
Encode the root object.

(WebCore::HistoryItem::encodeBackForwardTreeNode):
Encode the target.

history/HistoryItem.h:

Add new members.

platform/KeyedCoding.h:

(WebCore::KeyedEncoder::encodeObject):
Call beginObject, call the functor and then call endObject().

Source/WebKit2:

Add a dictionary stack to KeyedEncoder that's pushed and popped by
beginObject/endObject.

Shared/cf/KeyedEncoder.cpp:

(WebKit::KeyedEncoder::KeyedEncoder):
(WebKit::KeyedEncoder::~KeyedEncoder):
(WebKit::KeyedEncoder::encodeUInt32):
(WebKit::KeyedEncoder::encodeString):
(WebKit::KeyedEncoder::beginObject):
(WebKit::KeyedEncoder::endObject):

Shared/cf/KeyedEncoder.h:

4:42 PM Changeset in webkit [158977] by fpizlo@apple.com

6 edits in trunk/Source/JavaScriptCore

FTL should support NewArrayBuffer
https://bugs.webkit.org/show_bug.cgi?id=124067

Reviewed by Michael Saboff.

This expanded coverage and revealed some bugs.

This revealed a bug in FTL::OSRExitCompiler where it was assuming that it could save
the framePointer in regT3 even though DFG::reifyInlinedCallFrames() would clobber it.
It turns out that this can be fixed by just completely restoring the stack prior to
doing reifyInlineCallFrames().

I used this as an opportunity to simplify NewArray. That revealed a bug; whenever we say
lowJSValue() in there we need to use ManualOperandSpeculation since we're using it to
rebox values even when we also have to do some speculations. The speculations are done
at the top of compileNewArray().

This also revealed a bug in StringCharAt() for the OOB case.

ftl/FTLAbstractHeapRepository.h:

(JSC::FTL::AbstractHeapRepository::forIndexingType):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLIntrinsicRepository.h:
ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileNewArray):
(JSC::FTL::LowerDFGToLLVM::compileNewArrayBuffer):
(JSC::FTL::LowerDFGToLLVM::compileStringCharAt):

ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

4:39 PM Changeset in webkit [158976] by Alexandru Chiculita

4 edits
2 adds in trunk

Web Inspector: It should be possible to debug the Inspector code
https://bugs.webkit.org/show_bug.cgi?id=124065

Reviewed by Timothy Hatcher.

Source/WebKit2:

When the script is paused, the debugger will pause all the pages in the same PageGroup.
All the Inspector windows were created in the same PageGroup, so pausing one debugger
would stop the other too.

Added WebInspectorPageGroups to manage the PageGroups created for the Inspectors.
The WebInspectors will now use the inspection "level" to figure out which PageGroup to use.
The inspector that debugs the main page will use "WebInspectorPageGroupLevel1",
the second inspector (that debugs the first inspector) will use "WebInspectorPageGroupLevel2" ...

UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorPageGroups::shared):
(WebKit::WebInspectorPageGroups::inspectorLevel):
(WebKit::WebInspectorPageGroups::isInspectorPageGroup):
(WebKit::WebInspectorPageGroups::inspectorPageGroupLevel):
(WebKit::WebInspectorPageGroups::inspectorPageGroupForLevel):
(WebKit::WebInspectorPageGroups::createInspectorPageGroup):
(WebKit::WebInspectorProxy::WebInspectorProxy):
(WebKit::WebInspectorProxy::inspectorPageGroup):
(WebKit::WebInspectorProxy::isInspectorPage):
(WebKit::WebInspectorProxy::canAttach):

UIProcess/WebInspectorProxy.h:

LayoutTests:

Added test to check that a second inspector window can be used to debug the first one.

inspector-protocol/debugger/nested-inspectors-expected.txt: Added.
inspector-protocol/debugger/nested-inspectors.html: Added.

4:39 PM Changeset in webkit [158975] by fpizlo@apple.com

5 edits in trunk/Source/JavaScriptCore

It should be easy to disable blinding on a per-architecture basis
https://bugs.webkit.org/show_bug.cgi?id=124083

Reviewed by Michael Saboff.

assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::haveScratchRegisterForBlinding):
(JSC::AbstractMacroAssembler::scratchRegisterForBlinding):
(JSC::AbstractMacroAssembler::canBlind):
(JSC::AbstractMacroAssembler::shouldBlindForSpecificArch):

assembler/MacroAssembler.h:

(JSC::MacroAssembler::shouldBlind):
(JSC::MacroAssembler::store32):
(JSC::MacroAssembler::branch32):
(JSC::MacroAssembler::branchAdd32):
(JSC::MacroAssembler::branchMul32):

assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::canBlind):

assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::haveScratchRegisterForBlinding):

4:32 PM Changeset in webkit [158974] by matthew_hanson@apple.com

5 edits in branches/safari-537.73-branch/Source

Versioning.

4:29 PM Changeset in webkit [158973] by matthew_hanson@apple.com

1 copy in tags/Safari-537.73.5

New Tag.

4:27 PM Changeset in webkit [158972] by weinig@apple.com

5 edits in trunk/Source/WebCore

Teach CanvasObserver about references
https://bugs.webkit.org/show_bug.cgi?id=124082

Reviewed by Anders Carlsson.

css/CSSCanvasValue.cpp:
css/CSSCanvasValue.h:
html/HTMLCanvasElement.cpp:
html/HTMLCanvasElement.h:

4:25 PM Changeset in webkit [158971] by andersca@apple.com

8 edits
3 moves
2 deletes in trunk/Source

Begin stubbing out a KeyedEncoder class in WebCore
https://bugs.webkit.org/show_bug.cgi?id=124079

Reviewed by Sam Weinig.

Source/WebCore:

WebCore.exp.in:

Add symbol needed by WebCore.

WebCore.xcodeproj/project.pbxproj:

Add new header file.

history/HistoryItem.cpp:

(WebCore::HistoryItem::encodeBackForwardTree):

history/HistoryItem.h:

Add an encodeBackForwardTree overload that takes a KeyedEncoder object. Encode the version.

platform/KeyedCoding.h:

Add a KeyedEncoder class that just has a single encodeUInt32 member function for now.

Source/WebKit2:

Shared/KeyedEncoder.h: Removed.
Shared/cf/KeyedCodingValueCF.cpp: Removed.
Shared/cf/KeyedEncoder.cpp: Added.

Remove old keyed encoders.

(WebKit::createDictionary):
Helper function to create a mutable dictionary.
(WebKit::KeyedEncoder::KeyedEncoder):
Create the root dictionary.

(WebKit::KeyedEncoder::encodeUInt32):
Create a CFNumberRef and add it to the dictionary.

Shared/cf/KeyedEncoder.h: Added.
WebKit2.xcodeproj/project.pbxproj:

Add new files.

WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::updateBackForwardItem):
Create a KeyedEncoder and encode the history tree.

4:18 PM Changeset in webkit [158970] by Lucas Forschler

2 edits in branches/safari-537.73-branch/Source/JavaScriptCore

Rollout r158882. <rdar://problem/15426318>

4:09 PM Changeset in webkit [158969] by beidson@apple.com

20 edits
1 move
1 add
2 deletes in trunk/Source

Merge IDBTransactionBackendInterface and IDBTransactionBackendImpl
https://bugs.webkit.org/show_bug.cgi?id=124077

Reviewed by Alexey Proskuryakov.

Source/WebCore:

The abstraction is no longer needed.

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.xcodeproj/project.pbxproj:

Modules/indexeddb/IDBTransactionBackendInterface.h: Removed.

Modules/indexeddb/IDBTransactionBackend.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.cpp.
Modules/indexeddb/IDBTransactionBackend.h: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.h.

Modules/indexeddb/IDBBackingStoreInterface.h:
Modules/indexeddb/IDBCursorBackend.cpp:
Modules/indexeddb/IDBCursorBackend.h:
Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
Modules/indexeddb/IDBDatabaseBackendImpl.h:
Modules/indexeddb/IDBFactoryBackendInterface.h:
Modules/indexeddb/IDBTransactionBackendOperations.h:
Modules/indexeddb/IDBTransactionCoordinator.cpp:
Modules/indexeddb/IDBTransactionCoordinator.h:
Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:

Source/WebKit2:

WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:

3:53 PM Changeset in webkit [158968] by Simon Fraser

2 edits in trunk/Source/WebCore

REGRESSION (r155660): Some Etherpad pages not scrollable with overlay scrollbars
https://bugs.webkit.org/show_bug.cgi?id=124075

Reviewed by Beth Dakin.

In r155660 I removed some scrollbar-related layouts when scrollbars
are in overlay mode.

However, ScrollView::updateScrollbars() has a case where we still need
to do multiple pases, related to its "Never ever try to both gain/lose a
scrollbar in the same pass" comment. When we avoid making a new scrollbar
because the other was removed, we need to do another pass to bring the
correct scrollbar back.

Can't test overlay scrollbars in tests.

platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):

3:46 PM Changeset in webkit [158967] by hmuller@adobe.com

4 edits
4 adds in trunk

[CSS Shapes] Image valued shape-outside that extends vertically into the margin-box is top-clipped
https://bugs.webkit.org/show_bug.cgi?id=123769

Reviewed by Dirk Schulze.

Source/WebCore:

Remove the assumption that Y coordinates are >= 0 from the RasterShapeIntervals class
and correct its computeShapeMarginIntervals() method. The computeShapeMarginIntervals()
method now generates intervals with Y coordinates that begin at the image shape's
bounds.y - shape-margin, which may be less than 0.

The RasterShapeIntervals::intervalsAt() method now offsets its Y coordinate parameter
by the shape-margin. A non-const overload of the method was added to centralize all
access to m_intervalLists.

Test: fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-004.html

fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-005.html

rendering/shapes/RasterShape.cpp:

(WebCore::MarginIntervalGenerator::intervalAt): Don't clip X coordinates to 0 since they can extend into the margin-box.
(WebCore::RasterShapeIntervals::appendInterval): Use the non-const intervalsAt() method.
(WebCore::RasterShapeIntervals::uniteMarginInterval): Ditto.
(WebCore::RasterShapeIntervals::computeShapeMarginIntervals): See above.

rendering/shapes/RasterShape.h:

(WebCore::RasterShapeIntervals::RasterShapeIntervals): Added a field for the margin.
(WebCore::RasterShapeIntervals::intervalsAt): Offset y coordinates by the margin; added a non-const overload.

LayoutTests:

Verify that lines overlap a shape-outside that extends into the top of the margin-box
do wrap around the top of the shape as well its side and bottom.

fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-004-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-004.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-005-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-005.html: Added.

3:46 PM Changeset in webkit [158966] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: remove -webkit-min and -webkit-max from CSS completions
https://bugs.webkit.org/show_bug.cgi?id=124072

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-11-08
Reviewed by Timothy Hatcher.

-webkit-min and -webkit-max are not implemented in WebCore, despite mentions of it.

UserInterface/CSSKeywordCompletions.js:

3:45 PM Changeset in webkit [158965] by commit-queue@webkit.org

3 edits
2 adds in trunk

Ended event should work also when playback rate is negative
https://bugs.webkit.org/show_bug.cgi?id=123879

Patch by Piotr Grad <p.grad@samsung.com> on 2013-11-08
Reviewed by Eric Carlson.

Source/WebCore:

According to W3C specification playback is ended also when playback rate is
negative and position is the earliest possible position.

Test: media/video-ended-event-negative-playback.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):

LayoutTests:

Tests if ended event is triggered for audio/video elements after
changing playback rate to negative.

media/video-ended-event-negative-playback-expected.txt: Added.
media/video-ended-event-negative-playback.html: Added.

3:36 PM Changeset in webkit [158964] by commit-queue@webkit.org

25 edits
1 add in trunk

Checking for TypeError in RTCPeerConnection object creation
https://bugs.webkit.org/show_bug.cgi?id=124049

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-08
Reviewed by Eric Carlson.

Source/WebCore:

If invalid parameters are passed on RTCPeerConnection creation we must throw a TypeError exception.
According to the spec it requires a Dictionary argument, the RTCConfiguration, which is mandatory.

Please notice that this patch does not make every tests run as expected,
RTCPeerConnectionHandlerMock needs to be update to deal with contraints.

Existing tests were updated.

GNUmakefile.list.am:
Modules/mediastream/RTCPeerConnection.idl:
UseJSC.cmake:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSRTCPeerConnectionCustom.cpp: Added.

(WebCore::JSRTCPeerConnectionConstructor::constructJSRTCPeerConnection):

LayoutTests:

Please notice that this patch does not make every tests run as expected,
RTCPeerConnectionHandlerMock needs to be update to deal with contraints.

fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
fast/mediastream/RTCPeerConnection-createAnswer.html:
fast/mediastream/RTCPeerConnection-createOffer.html:
fast/mediastream/RTCPeerConnection-datachannel.html:
fast/mediastream/RTCPeerConnection-dtmf.html:
fast/mediastream/RTCPeerConnection-events.html:
fast/mediastream/RTCPeerConnection-expected.txt:
fast/mediastream/RTCPeerConnection-ice-expected.txt:
fast/mediastream/RTCPeerConnection-ice.html:
fast/mediastream/RTCPeerConnection-localDescription.html:
fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
fast/mediastream/RTCPeerConnection-remoteDescription.html:
fast/mediastream/RTCPeerConnection-stats-expected.txt:
fast/mediastream/RTCPeerConnection-stats.html:
fast/mediastream/RTCPeerConnection-statsSelector-expected.txt:
fast/mediastream/RTCPeerConnection-statsSelector.html:
fast/mediastream/RTCPeerConnection.html:

3:24 PM Changeset in webkit [158963] by Bem Jones-Bey

4 edits in trunk/Source/WebCore

Use references instead of pointers to RenderBlockFlow in FloatingObjects and ComputeFloatOffsetAdapter
https://bugs.webkit.org/show_bug.cgi?id=124074

Reviewed by Sam Weinig.

Just a straightforward conversion from const pointers to const references.

Also, remove unneeded argument from FloatingObjects constructor.

No new tests, no behavior change.

rendering/FloatingObjects.cpp:

(WebCore::ComputeFloatOffsetAdapter::ComputeFloatOffsetAdapter):
(WebCore::FloatingObjects::findNextFloatLogicalBottomBelow):
(WebCore::FloatingObjects::findNextFloatLogicalBottomBelowForBlock):
(WebCore::FloatingObjects::FloatingObjects):
(WebCore::FloatingObjects::clearLineBoxTreePointers):
(WebCore::FloatingObjects::computePlacedFloatsTree):
(WebCore::shapeInfoForFloat):
(WebCore::::updateOffsetIfNeeded):
(WebCore::::collectIfNeeded):
(WebCore::::heightRemaining):

rendering/FloatingObjects.h:
rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::createFloatingObjects):

3:23 PM Changeset in webkit [158962] by weinig@apple.com

6 edits in trunk/Source/WebCore

Teach SubframeLoader a bit about references
https://bugs.webkit.org/show_bug.cgi?id=124076

Reviewed by Anders Carlsson.

html/HTMLAppletElement.cpp:
html/HTMLFrameElementBase.cpp:
html/HTMLMediaElement.cpp:
loader/SubframeLoader.cpp:
loader/SubframeLoader.h:

3:16 PM Changeset in webkit [158961] by beidson@apple.com

2 edits in trunk/Source/WebCore

Blind Windows build-fix attempt after r158959

WebCore.vcxproj/WebCore.vcxproj:

3:10 PM Changeset in webkit [158960] by matthew_hanson@apple.com

5 edits in branches/safari-537.73-branch/Source/WebKit2

Merge r158101.

2:48 PM Changeset in webkit [158959] by beidson@apple.com

22 edits
2 moves
1 delete in trunk/Source

Merge IDBCursorBackendInterface and IDBCursorBackendImpl
https://bugs.webkit.org/show_bug.cgi?id=124068

Reviewed by Anders Carlsson.

Source/WebCore:

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.xcodeproj/project.pbxproj:

Modules/indexeddb/IDBCursorBackendInterface.h: Removed.

Modules/indexeddb/IDBCursorBackend.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.cpp.
Modules/indexeddb/IDBCursorBackend.h: Renamed from Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.h.

Modules/indexeddb/IDBCallbacks.h:
Modules/indexeddb/IDBCursor.cpp:
Modules/indexeddb/IDBCursor.h:
Modules/indexeddb/IDBCursorWithValue.cpp:
Modules/indexeddb/IDBCursorWithValue.h:
Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
Modules/indexeddb/IDBFactoryBackendInterface.h:
Modules/indexeddb/IDBRequest.cpp:
Modules/indexeddb/IDBRequest.h:
Modules/indexeddb/IDBTransactionBackendImpl.cpp:
Modules/indexeddb/IDBTransactionBackendImpl.h:
Modules/indexeddb/IDBTransactionBackendInterface.h:
Modules/indexeddb/IDBTransactionBackendOperations.cpp:
Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:

Source/WebKit2:

WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:

(WebKit::WebIDBFactoryBackend::createCursorBackend):

WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:

2:42 PM Changeset in webkit [158958] by weinig@apple.com

5 edits in trunk/Source/WebCore

Modernize FrameLoader a bit
https://bugs.webkit.org/show_bug.cgi?id=124073

Reviewed by Anders Carlsson.

loader/FrameLoader.cpp:
loader/FrameLoader.h:

Use std::unique_ptrs rather than OwnPtrs.

loader/MixedContentChecker.cpp:
loader/MixedContentChecker.h:

Switch to hold a Frame& rather than Frame*.

2:11 PM Changeset in webkit [158957] by oliver@apple.com

1 edit
4 deletes in trunk/Source/JavaScriptCore

Remove more accidentally added files.

2:09 PM Changeset in webkit [158956] by zandobersek@gmail.com

3 edits in trunk/Source/WebCore

Remove code guarded with ENABLE(STREAM)
https://bugs.webkit.org/show_bug.cgi?id=123667

Reviewed by Anders Carlsson.

Remove ENABLE(STREAM)-guarded code. This was added in the effort to provide Stream API support, but
no port enables the feature and the work on this feature has wound down after the Chromium port forked,
leaving this code unmaintained.

fileapi/FileReaderLoader.cpp:
fileapi/FileReaderLoader.h:

2:04 PM Changeset in webkit [158955] by andersca@apple.com

3 edits in trunk/Source/WebKit2

Remove a workaround for a bug in malloc on Symbian
https://bugs.webkit.org/show_bug.cgi?id=124069

Reviewed by Sam Weinig.

Platform/CoreIPC/ArgumentDecoder.cpp:

(CoreIPC::ArgumentDecoder::~ArgumentDecoder):
(CoreIPC::ArgumentDecoder::initialize):

Platform/CoreIPC/ArgumentDecoder.h:

2:01 PM Changeset in webkit [158954] by Bem Jones-Bey

6 edits in trunk/Source/WebCore

RenderBlockFlow::nextFloatLogicalBottomBelow should not use ShapeOutsideFloatOffsetMode
https://bugs.webkit.org/show_bug.cgi?id=123931

Reviewed by Sam Weinig.

Rewrite nextFloatLogicalBottomBelow to use the placed floats tree for
the search and to not need ShapeOutsideFloatOffsetMode anymore. This
moves almost all of the logic into FloatingObjects, making a small
reduction in the amount that RenderBlockFlow needs to know about the
implementation of FloatingObjects.

In addition, change ComputeFloatOffsetAdapter to take in LayoutUnits
and roundToInt itself so that all of it's callers can be simplified.

No new tests, no new behavior.

rendering/FloatingObjects.cpp:

(WebCore::rangesIntersect):
(WebCore::ComputeFloatOffsetAdapter::ComputeFloatOffsetAdapter):
(WebCore::FindNextFloatLogicalBottomAdapter::FindNextFloatLogicalBottomAdapter):
(WebCore::FindNextFloatLogicalBottomAdapter::lowValue):
(WebCore::FindNextFloatLogicalBottomAdapter::highValue):
(WebCore::FindNextFloatLogicalBottomAdapter::nextLogicalBottom):
(WebCore::FindNextFloatLogicalBottomAdapter::nextShapeLogicalBottom):
(WebCore::FindNextFloatLogicalBottomAdapter::collectIfNeeded):
(WebCore::FloatingObjects::findNextFloatLogicalBottomBelow):
(WebCore::FloatingObjects::findNextFloatLogicalBottomBelowForBlock):
(WebCore::FloatingObjects::logicalLeftOffsetForPositioningFloat):
(WebCore::FloatingObjects::logicalRightOffsetForPositioningFloat):
(WebCore::FloatingObjects::logicalLeftOffset):
(WebCore::FloatingObjects::logicalRightOffset):

rendering/FloatingObjects.h:
rendering/LineWidth.cpp:

(WebCore::LineWidth::fitBelowFloats):

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::nextFloatLogicalBottomBelow):
(WebCore::RenderBlockFlow::nextFloatLogicalBottomBelowForBlock):
(WebCore::RenderBlockFlow::getClearDelta):

rendering/RenderBlockFlow.h:

2:01 PM Changeset in webkit [158953] by Lucas Forschler

2 edits in branches/safari-537.73-branch/Source/WebInspectorUI

Merged r157459. <rdar://problem/15411420>

1:55 PM Changeset in webkit [158952] by Lucas Forschler

15 edits in branches/safari-537.73-branch/Source/WebKit2

Merged r157137. <rdar://problem/15411426>

1:50 PM Changeset in webkit [158951] by matthew_hanson@apple.com

3 edits in tags/Safari-538.5/Source/WebCore

Merge r158923.

1:42 PM Changeset in webkit [158950] by Lucas Forschler

2 edits in branches/safari-537.73-branch/Source/WebCore

Merged r152867. <rdar://problem/15411424>

1:35 PM Changeset in webkit [158949] by andersca@apple.com

3 edits in trunk/Source/WebKit2

More build fixes.

UIProcess/API/mac/WKBrowsingContextController.mm:
UIProcess/API/mac/WKConnection.mm:

(didReceiveMessage):

1:22 PM Changeset in webkit [158948] by andersca@apple.com

3 edits in trunk/Source/WebKit2

More build fixes.

UIProcess/API/mac/WKConnection.h:
UIProcess/API/mac/WKConnection.mm:

(didReceiveMessage):

1:19 PM Changeset in webkit [158947] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Try to fix the 32-bit build.

Shared/API/Cocoa/WKBrowsingContextHandleInternal.h:

1:17 PM Changeset in webkit [158946] by matthew_hanson@apple.com

2 edits in trunk/Tools

Added myself as a contributor.

1:07 PM Changeset in webkit [158945] by ap@apple.com

2 edits
5 moves in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=124064
Some WebCrypto files are not in correct directories

Rubber-stamped by Anders Carlsson.

WebCore.xcodeproj/project.pbxproj:
crypto/CryptoAlgorithmAesCbcParams.h: Removed.
crypto/CryptoAlgorithmAesKeyGenParams.h: Removed.
crypto/CryptoKeyAES.cpp: Removed.
crypto/CryptoKeyAES.h: Removed.
crypto/CryptoKeyMac.cpp: Removed.
crypto/keys/CryptoKeyAES.cpp: Copied from Source/WebCore/crypto/CryptoKeyAES.cpp.
crypto/keys/CryptoKeyAES.h: Copied from Source/WebCore/crypto/CryptoKeyAES.h.
crypto/mac/CryptoKeyMac.cpp: Copied from Source/WebCore/crypto/CryptoKeyMac.cpp.
crypto/parameters/CryptoAlgorithmAesCbcParams.h: Copied from Source/WebCore/crypto/CryptoAlgorithmAesCbcParams.h.
crypto/parameters/CryptoAlgorithmAesKeyGenParams.h: Copied from Source/WebCore/crypto/CryptoAlgorithmAesKeyGenParams.h.

1:05 PM Changeset in webkit [158944] by andersca@apple.com

6 edits in trunk/Source/WebKit2

Replace alignof with alignof.

Rubber-stamped by Beth Dakin.

Platform/CoreIPC/ArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::decodeStringText):

Platform/CoreIPC/ArgumentCoders.h:

(CoreIPC::SimpleArgumentCoder::encode):
(CoreIPC::SimpleArgumentCoder::decode):

Platform/CoreIPC/ArgumentDecoder.h:

(CoreIPC::ArgumentDecoder::bufferIsLargeEnoughToContain):

WebProcess/WebPage/DecoderAdapter.cpp:

(WebKit::DecoderAdapter::decodeString):

WebProcess/WebPage/EncoderAdapter.cpp:

(WebKit::EncoderAdapter::encodeString):

1:01 PM Changeset in webkit [158943] by ap@apple.com

10 edits
14 adds
1 delete in trunk

Implement JWK key import for HMAC and AES-CBC
https://bugs.webkit.org/show_bug.cgi?id=124059

Reviewed by Anders Carlsson.

Source/WebCore:

Tests: crypto/subtle/aes-cbc-import-jwk.html

crypto/subtle/hmac-import-jwk.html
crypto/subtle/import-jwk.html

WebCrypto supports multiple key formats - raw, pkcs8, spki, jwk. The design is that
we'll transform these into parsed KeyData subclasses before passing to algorithms.

CryptoKeySerialization is a base class for handling all these formats.

WebCore.xcodeproj/project.pbxproj: Added new files. Removed CryptoKeyFormat.h.

bindings/js/JSCryptoKeySerializationJWK.h: Added.
bindings/js/JSCryptoKeySerializationJWK.cpp: Added.

(WebCore::getStringFromJSON): A helper. Note that we can rely on the object being
a nice freshly parsed JSON, no getters or anything.
(WebCore::getBooleanFromJSON): Ditto.
(WebCore::JSCryptoKeySerializationJWK::JSCryptoKeySerializationJWK):
(WebCore::JSCryptoKeySerializationJWK::~JSCryptoKeySerializationJWK):
(WebCore::createHMACParameters): A simple helper.
(WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm): WebCrypto API is weird,
you can have algorithm parameters both inside a JWK key and passed as importKey()
arguments. They need to agree, whatever that means for specific serialization's
algorithm options (not all necessarily have a 1-1 matching to WebCrypto).
(WebCore::JSCryptoKeySerializationJWK::reconcileUsages): Take an intersection of usages.
(WebCore::JSCryptoKeySerializationJWK::reconcileExtractable): Only extractable if
both JWK and the caller agree.
(WebCore::JSCryptoKeySerializationJWK::keySizeIsValid): Verify validity of JWK key.
(WebCore::JSCryptoKeySerializationJWK::keyData): Return an appropriate KeyData
subclass.

bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::ENUM_CLASS): Moved CryptoKeyFormat here.
(WebCore::cryptoKeyFormatFromJSValue): Added a human readable string to an exception.
(WebCore::JSSubtleCrypto::importKey): Support multiple key formats, not just raw.

crypto/CryptoAlgorithm.cpp: (WebCore::CryptoAlgorithm::importKey):
crypto/CryptoAlgorithm.h:

Updated signature for importKey to one that makes more sense. Decoding formats all
the way from a binary blob is not something that CryptoAlgorithm subclasses should
do, we now pass a KeyData subclass instead.
Removed exportKey/wrapKey/unwrapKey altogether, because I don't yet know what the
signatures will be.

crypto/CryptoKeyData.h: Added.

(WebCore::CryptoKeyData::ENUM_CLASS):
(WebCore::CryptoKeyData::CryptoKeyData):
(WebCore::CryptoKeyData::~CryptoKeyData):
(WebCore::CryptoKeyData::format):
A base class for passing key material to algorithms. Currently, only one type is
supported, that being OctetSequence for secret keys. Keys for RSA and EC are more
complicated, and secret/public ones are different too.

crypto/CryptoKeyFormat.h: Removed. There are too many key format classes

confusingly floating around, and this was only needed in one file for parsing.

crypto/CryptoKeySerialization.h: Added.

Base class for handling raw/pkcs8/spki/jwk keys.

crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:

(WebCore::CryptoAlgorithmAES_CBC::importKey):

crypto/algorithms/CryptoAlgorithmAES_CBC.h:

Updated to use CryptoKeyData.

crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::importKey):

crypto/algorithms/CryptoAlgorithmHMAC.h:

Updated to use CryptoKeyData.

crypto/keys/CryptoKeyDataOctetSequence.cpp: Added.

(WebCore::CryptoKeyDataOctetSequence::CryptoKeyDataOctetSequence):
(WebCore::CryptoKeyDataOctetSequence::~CryptoKeyDataOctetSequence):

crypto/keys/CryptoKeyDataOctetSequence.h: Added.

(WebCore::asCryptoKeyDataOctetSequence):

crypto/keys/CryptoKeySerializationRaw.cpp: Added.

(WebCore::CryptoKeySerializationRaw::CryptoKeySerializationRaw):
(WebCore::CryptoKeySerializationRaw::~CryptoKeySerializationRaw):
(WebCore::CryptoKeySerializationRaw::reconcileAlgorithm):
(WebCore::CryptoKeySerializationRaw::reconcileUsages):
(WebCore::CryptoKeySerializationRaw::reconcileExtractable):
(WebCore::CryptoKeySerializationRaw::keyData):

crypto/keys/CryptoKeySerializationRaw.h: Added.

Much code to pass around a Vector<char>.

LayoutTests:

crypto/subtle/aes-cbc-import-jwk-expected.txt: Added.
crypto/subtle/aes-cbc-import-jwk.html: Added.
crypto/subtle/hmac-import-jwk-expected.txt: Added.
crypto/subtle/hmac-import-jwk.html: Added.
crypto/subtle/import-jwk-expected.txt: Added.
crypto/subtle/import-jwk.html: Added.

12:42 PM Changeset in webkit [158942] by andersca@apple.com

3 edits in trunk/Source/WebKit2

Add a way to get a WKWebProcessPlugInBrowserContextController from a handle
https://bugs.webkit.org/show_bug.cgi?id=124063

Reviewed by Beth Dakin.

WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(+[WKWebProcessPlugInBrowserContextController lookUpBrowsingContextFromHandle:]):

WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:

12:41 PM Changeset in webkit [158941] by oliver@apple.com

1 edit
2 deletes in trunk/Source/JavaScriptCore

Remove accidentally added files.

12:27 PM Changeset in webkit [158940] by oliver@apple.com

2 edits
6 adds in trunk/Source/JavaScriptCore

Fix minor (unobservable) bug in ArrayIterator::next()
https://bugs.webkit.org/show_bug.cgi?id=124061

Reviewed by Beth Dakin.

I noticed this while reading the array iterator code. Due to how
ArrayIterator::next() and our enumeration behaviour is implemented
this is not actually a code path that can be hit. But in order to
future proof this it should be correct.

runtime/JSArrayIterator.cpp:

(JSC::arrayIteratorNext):

12:22 PM Changeset in webkit [158939] by andersca@apple.com

6 edits in trunk/Source/WebKit2

More work on WKBrowsingContextHandle
https://bugs.webkit.org/show_bug.cgi?id=124060

Reviewed by Beth Dakin.

Implement -hash and -isEqual: and add -[WKWebProcessPlugInBrowserContextController handle].

Shared/API/Cocoa/WKBrowsingContextHandle.mm:

(-[WKBrowsingContextHandle hash]):
(-[WKBrowsingContextHandle isEqual:]):

Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(decodeInvocation):

WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController mainFrameDocument]):
(-[WKWebProcessPlugInBrowserContextController selectedRange]):
(-[WKWebProcessPlugInBrowserContextController handle]):

WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerInternal.h:
WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:

12:06 PM Changeset in webkit [158938] by matthew_hanson@apple.com

2 edits in tags/Safari-538.5/Tools

Unreviewed. Added myself as a committer.

12:03 PM Changeset in webkit [158937] by mark.lam@apple.com

24 edits
4 adds in trunk/Source

Move breakpoint (and exception break) functionality into JSC::Debugger.
https://bugs.webkit.org/show_bug.cgi?id=121796.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

In ScriptDebugServer and JSC::Debugger, SourceID and BreakpointID are now numeric tokens.

JSC::Debugger now tracks user defined breakpoints in a JSC::Breakpoint record. Previously, this info is tracked in the ScriptBreakpoint record in ScriptDebugServer. The only element of ScriptBreakpoint that is not being tracked by JSC::Breakpoint is the ScriptBreakpointAction.

The ScriptBreakpointAction is still tracked by the ScriptDebugServer

in a list keyed on the corresponding BreakpointID.

The ScriptBreakpoint record is now only used as a means of passing

breakpoint paramaters to the ScriptDebugServer.

ScriptDebugServer now no longer accesses the JSC::CallFrame* directly. It always goes through the DebuggerCallFrame.

GNUmakefile.list.am:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:
debugger/Breakpoint.h: Added.

(JSC::Breakpoint::Breakpoint):

Breakpoint class to track info for each breakpoint in JSC::Debugger.
debugger/Debugger.cpp:

(JSC::DebuggerCallFrameScope::DebuggerCallFrameScope):
(JSC::DebuggerCallFrameScope::~DebuggerCallFrameScope):
(JSC::Debugger::Debugger):
(JSC::Debugger::detach):
(JSC::Debugger::updateNeedForOpDebugCallbacks):
(JSC::Debugger::setBreakpoint):
(JSC::Debugger::removeBreakpoint):
(JSC::Debugger::hasBreakpoint):
(JSC::Debugger::clearBreakpoints):
(JSC::Debugger::setBreakpointsActivated):
(JSC::Debugger::setPauseOnExceptionsState):
(JSC::Debugger::setPauseOnNextStatement):
(JSC::Debugger::breakProgram):
(JSC::Debugger::continueProgram):
(JSC::Debugger::stepIntoStatement):
(JSC::Debugger::stepOverStatement):
(JSC::Debugger::stepOutOfFunction):
(JSC::Debugger::updateCallFrame):
(JSC::Debugger::updateCallFrameAndPauseIfNeeded):
(JSC::Debugger::pauseIfNeeded):
(JSC::Debugger::exception):
(JSC::Debugger::atStatement):
(JSC::Debugger::callEvent):
(JSC::Debugger::returnEvent):
(JSC::Debugger::willExecuteProgram):
(JSC::Debugger::didExecuteProgram):
(JSC::Debugger::didReachBreakpoint):
(JSC::Debugger::currentDebuggerCallFrame):

debugger/Debugger.h:
debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::sourceID):
(JSC::DebuggerCallFrame::sourceIDForCallFrame):

debugger/DebuggerCallFrame.h:
debugger/DebuggerPrimitives.h: Added.
define SourceID, noSourceID, BreakpointID, and noBreakpointID.

Source/WebCore:

No new tests.

In ScriptDebugServer and JSC::Debugger, SourceID and BreakpointID are now numeric tokens.

JSC::Debugger now tracks user defined breakpoints in a JSC::Breakpoint record. Previously, this info is tracked in the ScriptBreakpoint record in ScriptDebugServer. The only element of ScriptBreakpoint that is not being tracked by JSC::Breakpoint is the ScriptBreakpointAction.

The ScriptBreakpointAction is still tracked by the ScriptDebugServer

in a list keyed on the corresponding BreakpointID.

The ScriptBreakpoint record is now only used as a means of passing

breakpoint paramaters to the ScriptDebugServer.

ScriptDebugServer now no longer accesses the JSC::CallFrame* directly. It always goes through the DebuggerCallFrame.

GNUmakefile.list.am:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
bindings/js/BreakpointID.h: Added.
bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::clearBreakpoints):
(WebCore::ScriptDebugServer::dispatchDidPause):
(WebCore::ScriptDebugServer::dispatchDidContinue):
(WebCore::ScriptDebugServer::dispatchDidParseSource):
(WebCore::ScriptDebugServer::notifyDoneProcessingDebuggerEvents):
(WebCore::ScriptDebugServer::needPauseHandling):
(WebCore::ScriptDebugServer::handleBreakpointHit):
(WebCore::ScriptDebugServer::handleExceptionInBreakpointCondition):
(WebCore::ScriptDebugServer::handlePause):

bindings/js/ScriptDebugServer.h:
bindings/js/SourceID.h: Added.
bindings/js/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):

bindings/js/WorkerScriptDebugServer.h:
inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::parseLocation):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::continueToLocation):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::getScriptSource):
(WebCore::InspectorDebuggerAgent::didParseSource):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::clear):

inspector/InspectorDebuggerAgent.h:
inspector/ScriptDebugListener.h:

Source/WebKit/mac:

WebView/WebScriptDebugger.h:
WebView/WebScriptDebugger.mm:

(WebScriptDebugger::WebScriptDebugger):
(WebScriptDebugger::handlePause):

11:49 AM Changeset in webkit [158936] by andersca@apple.com

5 edits
3 copies in trunk/Source/WebKit2

Add A WKBrowsingContextHandle class
https://bugs.webkit.org/show_bug.cgi?id=124058

Reviewed by Sam Weinig.

The WKBrowsingContextHandle class represents a browsing context and can be sent across process boundaries.

Shared/API/Cocoa/WKBrowsingContextHandle.h: Added.
Shared/API/Cocoa/WKBrowsingContextHandle.mm: Added.

(-[WKBrowsingContextHandle _initWithPageID:]):
(-[WKBrowsingContextHandle encodeWithCoder:]):
(-[WKBrowsingContextHandle initWithCoder:]):
(+[WKBrowsingContextHandle supportsSecureCoding]):

Shared/API/Cocoa/WKBrowsingContextHandleInternal.h: Added.
UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController handle]):

UIProcess/API/mac/WKBrowsingContextControllerInternal.h:
UIProcess/API/mac/WKBrowsingContextControllerPrivate.h:

(NS_ENUM):

WebKit2.xcodeproj/project.pbxproj:

11:45 AM Changeset in webkit [158935] by commit-queue@webkit.org

8 edits in trunk/Source/WebCore

InspectorConsoleAgent::didFinishXHRLoading ConsoleMessage should include a column number
https://bugs.webkit.org/show_bug.cgi?id=114316

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-11-08
Reviewed by Timothy Hatcher.

InspectorConsoleAgent::didFinishXHRLoading creates a ConsoleMessage with a line number,
but it should also include a column number. It looks like ultimately the line number comes from
JSXMLHttpRequest::send, it should also be possible to get the column number at the time.
The column number would be needed by the Web Inspector to jump to the proper place in source code
to show where the XHR originated from.

bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::SendFunctor::SendFunctor):
(WebCore::SendFunctor::column):
(WebCore::SendFunctor::operator()):
(WebCore::JSXMLHttpRequest::send):

inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::didFinishXHRLoading):

inspector/InspectorConsoleAgent.h:
inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didFinishXHRLoadingImpl):

inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didFinishXHRLoading):

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::setLastSendLineAndColumnNumber):
(WebCore::XMLHttpRequest::didFinishLoading):

xml/XMLHttpRequest.h:

11:38 AM Changeset in webkit [158934] by Simon Fraser

3 edits
4 adds in trunk

Left sidebar on cubic-bezier.com flickers
https://bugs.webkit.org/show_bug.cgi?id=123128

Source/WebCore:

Reviewed by Dean Jackson.

The logic that determined whether position:fixed elements outside the viewport
should be composited was incorrect if the fixed element also had a transform.

layer.calculateLayerBounds() only takes into account painted transforms (since they
affect layer bounds). So we need to compute the bounds relative to the layer
itself, then use localToContainerQuad() to map them to document coordinates,
but only to the RenderView so that we don't hit the page scale transform.

Tests: compositing/layer-creation/fixed-position-transformed-into-view.html

compositing/layer-creation/fixed-position-transformed-outside-view.html

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

LayoutTests:

Reviewed by Dean Jackson.

Tests with transformed, fixed elements which dump the layer tree to see
which layers get composited.

compositing/layer-creation/fixed-position-transformed-into-view-expected.txt: Added.
compositing/layer-creation/fixed-position-transformed-into-view.html: Added.
compositing/layer-creation/fixed-position-transformed-outside-view-expected.txt: Added.
compositing/layer-creation/fixed-position-transformed-outside-view.html: Added.

11:37 AM Changeset in webkit [158933] by ap@apple.com

2 edits in trunk/Source/WTF

Make base64url decoding actually work
https://bugs.webkit.org/show_bug.cgi?id=124050

Reviewed by Sam Weinig.

wtf/text/Base64.cpp: (WTF::base64DecodeInternal): Don't hardcode knowledge about

alphabet, put it into the map.

11:28 AM Changeset in webkit [158932] by oliver@apple.com

2 edits in trunk/LayoutTests

Fix layout test that was actually testing incorrect behaviour.

11:27 AM Changeset in webkit [158931] by Martin Robinson

9 edits in trunk

[MathML] Center of stretched curly bracket not always vertically centered
https://bugs.webkit.org/show_bug.cgi?id=123715

Reviewed by Brent Fulgham.

Source/WebCore:

rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::fillWithExtensionGlyph): Update an assertion and
handle the case where two glyph pieces abut.
(WebCore::RenderMathMLOperator::paint): Do not offset the center glyph by y().

LayoutTests:

TestExpectations: Unskip mo-stretch.html. It was skipped originally,

because MathML is changing rapidly, but we need it to test these changes.

mathml/presentation/mo-stretch.html: Update to show stretching characteristics

of all stretchable glyphs.

platform/gtk/mathml/presentation/mo-stretch-expected.png:
platform/gtk/mathml/presentation/mo-stretch-expected.txt:

11:10 AM Changeset in webkit [158930] by andersca@apple.com

3 edits in trunk/Source/WebKit2

Add WKRemoteObjectRegistry to WKConnection
https://bugs.webkit.org/show_bug.cgi?id=124054

Reviewed by Sam Weinig.

UIProcess/API/mac/WKConnection.h:
UIProcess/API/mac/WKConnection.mm:

(-[WKConnection delegate]):
(-[WKConnection setDelegate:]):
(-[WKConnection remoteObjectRegistry]):
(didReceiveMessage):

10:47 AM Changeset in webkit [158929] by oliver@apple.com

3 edits
3 adds in trunk

Map.forEach crashes on deleted values
https://bugs.webkit.org/show_bug.cgi?id=124017

Reviewed by Ryosuke Niwa.

Source/JavaScriptCore:

MapData iterator did not consider the case of the first entries
being holes. To fix this I've refactored iteration so that we
can perform an initialisation increment on construction, whle
retaining the useful assertion in MapData::const_iterator::operator++

runtime/MapData.h:

(JSC::MapData::const_iterator::operator++):
(JSC::MapData::const_iterator::internalIncrement):
(JSC::MapData::const_iterator::const_iterator):

LayoutTests:

Test case

js/map-iterate-first-entry-is-a-hole-expected.txt: Added.
js/map-iterate-first-entry-is-a-hole.html: Added.
js/script-tests/map-iterate-first-entry-is-a-hole.js: Added.

(set map0):

10:30 AM Changeset in webkit [158928] by jer.noble@apple.com

7 edits
2 adds in trunk

[MSE] Bring SourceBuffer.append up to the most recent spec.
https://bugs.webkit.org/show_bug.cgi?id=123377

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-source/media-source-append-failed.html

Bring the MediaSource append() implementation up to the current spec.

Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::appendBufferInternal):
(WebCore::SourceBuffer::appendBufferTimerFired):

platform/graphics/SourceBufferPrivate.h:
platform/mock/mediasource/MockSourceBufferPrivate.cpp:

(WebCore::MockSourceBufferPrivate::append):
(WebCore::MockSourceBufferPrivate::evictCodedFrames):
(WebCore::MockSourceBufferPrivate::isFull):

platform/mock/mediasource/MockSourceBufferPrivate.h:

LayoutTests:

media/media-source/media-source-append-failed-expected.txt: Added.
media/media-source/media-source-append-failed.html: Added.
media/media-source/mock-media-source.js:

10:28 AM Changeset in webkit [158927] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Encode and decode NSURLRequests using NSCoder
https://bugs.webkit.org/show_bug.cgi?id=124051

Reviewed by Sam Weinig.

Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::archiveAndEncodeObject):
(CoreIPC::decodeAndUnarchiveObject):
(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):

10:25 AM Changeset in webkit [158926] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

REGRESSION(r158883): Fix crashes for ARM architecture.
https://bugs.webkit.org/show_bug.cgi?id=124038

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-08
Reviewed by Michael Saboff.

jit/GPRInfo.h: Remove r11 from the temporary register set, use a free register for

nonPreservedNonReturnGPR and remove obsolete declaration of bucketCounterRegister.
(JSC::GPRInfo::toRegister):
(JSC::GPRInfo::toIndex):

jit/JITOperations.cpp: Frame pointer register is r11 for ARM_TRADITIONAL and

r7 for ARM_THUMB2 instead of r5 since r158883.

10:24 AM Changeset in webkit [158925] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

REGRESSION(r158883): Fix crashes for MIPS architecture.
https://bugs.webkit.org/show_bug.cgi?id=124044

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-08
Reviewed by Michael Saboff.

jit/JITOperations.cpp: Frame pointer register is fp instead of s0 since r158883 for MIPS.
jit/ThunkGenerators.cpp: Save and restore the new frame pointer register.

(JSC::returnFromJavaScript):
(JSC::callToJavaScript):

10:03 AM Changeset in webkit [158924] by Chris Fleizach

3 edits in branches/safari-537.73-branch/LayoutTests

Fix up failing layout tests that in branch due to recent accessibility patches.

Unreviewed.

media/track/track-in-band-mode-expected.txt:
platform/mac/accessibility/listitem-title-expected.txt:

9:55 AM Changeset in webkit [158923] by jer.noble@apple.com

3 edits in trunk/Source/WebCore

[Mac] Crash at com.apple.WebCore: WebCore::MediaPlayerPrivateAVFoundationObjC::tracksDidChange + 26
https://bugs.webkit.org/show_bug.cgi?id=124031

Reviewed by Eric Carlson.

WTF::bind() causes errors when given a bare id pointer as a parameter,
when that parameter is casted to a specific NS type pointer (in this
case, a NSArray*) in order to pass it as a parameter to the bound
function.

Instead of passing around bare id pointers, wrap them in RetainPtr<>
objects before passing them to WTF::bind().

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::seekableTimeRangesDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::loadedTimeRangesDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksDidChange):
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):

9:31 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

9:12 AM Changeset in webkit [158922] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

[Win] JavaScript crash in getHostCallReturnValue.
https://bugs.webkit.org/show_bug.cgi?id=124040

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-08
Reviewed by Geoffrey Garen.

jit/JITOperations.cpp: Update MSVC assembler code in getHostCallReturnValue according to gcc x86 version.

7:27 AM Changeset in webkit [158921] by Michał Pakuła vel Rutka

2 edits in trunk/LayoutTests

Unreviewed EFL gardening

Add test expectations for failing tests.

platform/efl/TestExpectations:

6:57 AM Changeset in webkit [158920] by Antti Koivisto

1 edit
1 add in trunk/PerformanceTests

Add line layout performance test that exercises more cases
https://bugs.webkit.org/show_bug.cgi?id=124041

Reviewed by Anders Carlsson.

The existing line-layout.html covers the most basic left-aligned case only.
Add a test with more coverage for things that are mostly not yet supported by the simple
line layout path:

centered text
right aligned text
justified text
pre
white-space:pre-wrap
text with simple inlines
text with br

Layout/line-layout-simple.html: Added.

6:42 AM Changeset in webkit [158919] by commit-queue@webkit.org

6 edits
5 copies
3 adds
5 deletes in trunk/LayoutTests

[GTK] Add new GTK-specific layout test results for vertical text
https://bugs.webkit.org/show_bug.cgi?id=124000

Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-11-08
Reviewed by Mario Sanchez Prada.

Rebaselined some expected results for tests that use vertical text.
These tests are now working fine after the fix from Bug 50619.
They have specific results for WebKit2 GTK+ because WebKit1 has a
permanent area in the bottom for the horizontal scroll bar.
This area reduces the layout area in WebKit1 and consequently the
results differ from WebKit2.

fast/repaint/japanese-rl-selection-clear-expected.txt:
fast/repaint/japanese-rl-selection-repaint-expected.txt:
fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
fast/text/international/vertical-text-glyph-test-expected.txt:
fast/text/justify-ideograph-vertical-expected.txt:
platform/efl/fast/repaint/japanese-rl-selection-clear-expected.txt: Removed.
platform/efl/fast/repaint/japanese-rl-selection-repaint-expected.txt: Removed.
platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Removed.
platform/efl/fast/text/international/vertical-text-glyph-test-expected.txt: Removed.
platform/efl/fast/text/justify-ideograph-vertical-expected.txt: Removed.
platform/gtk-wk2/fast/repaint/japanese-rl-selection-clear-expected.txt: Copied from LayoutTests/fast/repaint/japanese-rl-selection-clear-expected.txt.
platform/gtk-wk2/fast/repaint/japanese-rl-selection-repaint-expected.txt: Copied from LayoutTests/fast/repaint/japanese-rl-selection-repaint-expected.txt.
platform/gtk-wk2/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Copied from LayoutTests/fast/repaint/repaint-across-writing-mode-boundary-expected.txt.
platform/gtk-wk2/fast/text/international/vertical-text-glyph-test-expected.txt: Copied from LayoutTests/fast/text/international/vertical-text-glyph-test-expected.txt.
platform/gtk-wk2/fast/text/justify-ideograph-vertical-expected.txt: Copied from LayoutTests/fast/text/justify-ideograph-vertical-expected.txt.

4:53 AM Changeset in webkit [158918] by Antti Koivisto

4 edits in trunk/Source/WebCore

Templated LChar/UChar paths for simple line layout
https://bugs.webkit.org/show_bug.cgi?id=124035

Reviewed by Andreas Kling.

rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseForText):
(WebCore::SimpleLineLayout::canUseFor):

Use a templated function to check for illegal characters.

(WebCore::SimpleLineLayout::skipWhitespaces):

Make a template function.

(WebCore::SimpleLineLayout::textWidth):

Make a template function plus some argument changes.

(WebCore::SimpleLineLayout::createTextRuns):

Template function for creating runs while operating with either LChars or UChar.
Also simplified line breaking and text width measuring logic.

(WebCore::SimpleLineLayout::create):

Pick the template.

rendering/break_lines.cpp:
rendering/break_lines.h:

Move the implementation to the header (except for the table) so we can use the template
versions directly.

(WebCore::isBreakableSpace):
(WebCore::shouldBreakAfter):
(WebCore::needsLineBreakIterator):
(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):

4:16 AM Changeset in webkit [158917] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

[EFL] accessibility/aria-link-supports-press.html
https://bugs.webkit.org/show_bug.cgi?id=111987

Unreviewed EFL gardening, passes after r158913.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-08

platform/efl-wk1/TestExpectations: test is no longer failing.
platform/efl-wk2/TestExpectations: test is no longer failing.

3:26 AM Changeset in webkit [158916] by Csaba Osztrogonác

2 edits in trunk/Source/JavaScriptCore

[mips] Fix typo (introduced in r158751).
https://bugs.webkit.org/show_bug.cgi?id=124033.

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-08
Reviewed by Csaba Osztrogonác.

jit/ThunkGenerators.cpp:

(JSC::callToJavaScript):

3:22 AM Changeset in webkit [158915] by Csaba Osztrogonác

4 edits in trunk/Source/JavaScriptCore

[arm] Use specific PatchableJump implementation for CPU(ARM_TRADITIONAL).
https://bugs.webkit.org/show_bug.cgi?id=123891

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-08
Reviewed by Michael Saboff.

Although patchableBranch32 is implemented in MacroAssemblerARM.h, the used implementation
is the generic one in MacroAssembler.h. This patch fixes it and also implements the
patchableJump() function for CPU(ARM_TRADITIONAL). These specific implementations are
needed for this architecture backend to ensure that these jumps can be relinked.

assembler/MacroAssembler.h:
assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::patchableJump):

jit/GPRInfo.h: Remove static_cast that are generating warnings in debug builds.

(JSC::GPRInfo::toIndex):
(JSC::GPRInfo::debugName):

2:55 AM Changeset in webkit [158914] by mario@webkit.org

9 edits in trunk

AX: [ATK] <span> elements exposed through ATK when not needed
https://bugs.webkit.org/show_bug.cgi?id=123885

Reviewed by Chris Fleizach.

Source/WebCore:

As per SVN r158195, the way it's decided whether <span> elements
should be ignored or not has slightly changed, causing that the
GTK/EFL ports expose them in cases that they should be ignored,
such as for text elements that neither are focusable (e.g. by
explicitly setting tabindex) nor have a meaningful accessible name
suggesting they should be exposed.

As a result, the flattening that ATK based ports normally do for
this kind of elements (by folding them into their parents) do not
work correctly anymore, making two tests to fail:

platform/gtk/accessibility/spans-paragraphs-and-divs.html
platform/gtk/accessibility/spans.html

This patch encapsulates the part of the logic that affects this in
the computeAccessibilityIsIgnored() method, placing it in a
new method of AccessibilityObject that we can call from ATK's
accessibilityPlatformIncludesObject() to ensure we hide those
<span> elements when they don't fulfill those requirements.

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::hasAttributesRequiredForInclusion):
New virtual method encapsulating part of the logic from the function
that computes whether accessibility should be ignored or not.

accessibility/AccessibilityObject.h:

accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::hasAttributesRequiredForInclusion):
Override of the new method adding additional checks, as extracted from
the original bits in computeAccessibilityIsIgnored().

accessibility/AccessibilityNodeObject.h:

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
Use the newly added function where we had the original code before.

accessibility/atk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Make sure <span> elements are ignored if they are not focusable
and they don't have a meaningful accessible name.

LayoutTests:

Removed failure expectations for tests now passing.

platform/gtk/TestExpectations: Removed expectations.

2:24 AM Changeset in webkit [158913] by commit-queue@webkit.org

5 edits in trunk

[GTK] accessibility/aria-link-supports-press.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98355

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-08
Reviewed by Mario Sanchez Prada.

Tools:

Checking "jump" action for link elements. Action "jump" occurs when a link
element is pressed/clicked.

DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::isPressActionSupported):

WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::isPressActionSupported):

LayoutTests:

Removed failure expectation.

platform/gtk/TestExpectations: test is no longer failing.

1:43 AM Changeset in webkit [158912] by commit-queue@webkit.org

2 edits in trunk/Tools

[JHBUILD] Jhbuild Makefile build bug workaround
https://bugs.webkit.org/show_bug.cgi?id=123971

Patch by Przemyslaw Szymanski <p.szymanski3@samsung.com> on 2013-11-08
Reviewed by Ryosuke Niwa.

After Jhbuild repository is cloned (for instance when you use
Tools/Scripts/update-webkitefl-libs) it is built from sources.
If you have GREP_OPTIONS grep env variable set (for instance
GREP_OPTIONS=-n) then it is jhbuild build error. Makefile.plain
uses shell grep. For specific GREP_OPTIONS grep output will be
different than expected one by Jhbuild and there is an error
with Jhbuild build. Jhbuild will not be built and then WebKit
source also will not be built. This patch is a workaround to this
issue. It disables GREP_OPTIONS for Jhbuild build time.

jhbuild/jhbuild-wrapper:

(install_jhbuild):

1:06 AM Changeset in webkit [158911] by akling@apple.com

1 edit
1 add in trunk/LayoutTests

Add back expectation for test that went missing in r158813.

svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.

12:16 AM Changeset in webkit [158910] by Carlos Garcia Campos

3 edits in trunk/Source/WebCore

[GTK] Add missing symbols to WebKitDOMEventTarget.symbols
https://bugs.webkit.org/show_bug.cgi?id=123990

Reviewed by Philippe Normand.

Add webkit_dom_event_target_add_event_listener_with_closure and
webkit_dom_event_target_remove_event_listener_with_closure to the
symbols files.

bindings/gobject/WebKitDOMEventTarget.symbols:
bindings/gobject/webkitdom.symbols:

12:14 AM Changeset in webkit [158909] by Carlos Garcia Campos

2 edits in trunk/Tools

[GTK] Ignore deprecated macros when generating gtk-doc
https://bugs.webkit.org/show_bug.cgi?id=123988

Reviewed by Philippe Normand.

gtk/generate-gtkdoc:

(get_common_options): Ignore also WEBKIT_DEPRECATED and
WEBKIT_DEPRECATED_FOR decorators.

12:12 AM Changeset in webkit [158908] by Carlos Garcia Campos

3 edits in trunk/Tools

[GTK] Pass the library namespace to gtkdoc-mkdb
https://bugs.webkit.org/show_bug.cgi?id=123900

Reviewed by Martin Robinson.

This fixes the generation of the index of symbols in the API
documentation.

gtk/generate-gtkdoc:

(get_webkit2_options): Define namespace as WebKit.
(get_webkit1_options): Ditto.
(get_webkitdom_options): Define namespace as WebKitDOM.

gtk/gtkdoc.py:

(GTKDoc.init): Add namespace option.
(GTKDoc._run_gtkdoc_mkdb): Pass namespace to mkdb if present.

12:09 AM Changeset in webkit [158907] by Carlos Garcia Campos

4 edits in trunk/Source/WebCore

[GTK] Use deprecation guards around deprecated API in GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=123899

Reviewed by Martin Robinson.

Do not include deprecated API when compiling with
WEBKIT_DISABLE_DEPRECATED option.

bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunction):

bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed