⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 10, 2013:

11:43 PM Changeset in webkit [159040] by commit-queue@webkit.org
  • 6 edits in trunk/LayoutTests

[EFL] Layout tests with css1 box properties need to be rebaselined.
https://bugs.webkit.org/show_bug.cgi?id=124135

Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-11-10
Reviewed by Gyuyoung Kim.

EFL css1 rebaseline after r101343 for EFL gardening.

  • platform/efl/css1/box_properties/margin_right-expected.txt:
  • platform/efl/css1/box_properties/padding-expected.txt:
  • platform/efl/css1/box_properties/padding_left-expected.txt:
  • platform/efl/css1/box_properties/padding_right-expected.txt:
  • platform/efl/css1/box_properties/padding_top-expected.txt:
11:30 PM Changeset in webkit [159039] by fpizlo@apple.com
  • 26 edits in trunk/Source

Switch FTL GetById/PutById IC's over to using AnyRegCC
https://bugs.webkit.org/show_bug.cgi?id=124094

Source/JavaScriptCore:

Reviewed by Sam Weinig.

This closes the loop on inline caches (IC's) in the FTL. The goal is to have IC's
in LLVM-generated code that are just as efficient (if not more so) than what a
custom JIT could do. As in zero sources of overhead. Not a single extra instruction
or even register allocation pathology. We accomplish this by having two thingies in
LLVM. First is the llvm.experimental.patchpoint intrinsic, which is sort of an
inline machine code snippet that we can fill in with whatever we want and then
modify subsequently. But you have only two choices of how to pass values to a
patchpoint: (1) via the calling convention or (2) via the stackmap. Neither are good
for operands to an IC (like the base pointer for a GetById, for example). (1) is bad
because it results in things being pinned to certain registers a priori; a custom
JIT (like the DFG) will not pin IC operands to any registers a priori but will allow
the register allocator to do whatever it wants. (2) is bad because the operands may
be spilled or may be represented in other crazy ways. You generally want an IC to
have its operands in registers. Also, patchpoints only return values using the
calling convention, which is unfortunate since it pins the return value to a
register a priori. This is where the second thingy comes in: the AnyRegCC. This is
a special calling convention only for use with patchpoints. It means that arguments
passed "by CC" in the patchpoint can be placed in any register, and the register
that gets used is reported as part of the stackmap. It also means that the return
value (if there is one) can be placed in any register, and the stackmap will tell
you which one it was. Thus, patchpoints combined with AnyRegCC mean that you not
only get the kind of self-modifying code that you want for IC's, but you also get
all of the register allocation goodness that a custom JIT would have given you.
Except that you're getting it from LLVM and not a custom JIT. Awesome.

Even though all of the fun stuff is on the LLVM side, this patch was harder than
you'd expect.

First the obvious bits:

  • IC patchpoints now use AnyRegCC instead of the C CC. (CC = calling convention.)


  • FTL::fixFunctionBasedOnStackMaps() now correctly figures out which registers the IC is supposed to use instead of assuming C CC argument registers.


And then all of the stuff that broke and that this patch fixes:

  • IC sizing based on generating a dummy IC (what FTLInlineCacheSize did) is totally bad on x86-64, where various register permutations lead to bizarre header bytes and eclectic SIB encodings. I changed that to have magic constants, for now.


  • Slow path calls didn't preserve the CC return register.


  • Repatch's scratch register allocation would get totally confused if the operand registers weren't one of the DFG-style "temp" registers. And by "totally confused" I mean that it would crash.


  • We assumed that r10 is callee-saved. It's not. That one dude's PPT about x86-64 cdecl that I found on the intertubes was not a trustworthy source of information, apparently.


  • Call repatching didn't know that the FTL does its IC slow calls via specially generated thunks. This was particularly fun to fix: basically, now when we relink an IC call in the FTL, we use the old call target to find the SlowPathCallKey, which tells us everything we need to know to generate (or look up) a new thunk for the new function we want to call.


  • assembler/MacroAssemblerCodeRef.h:

(JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
(JSC::MacroAssemblerCodePtr::isEmptyValue):
(JSC::MacroAssemblerCodePtr::isDeletedValue):
(JSC::MacroAssemblerCodePtr::hash):
(JSC::MacroAssemblerCodePtr::emptyValue):
(JSC::MacroAssemblerCodePtr::deletedValue):
(JSC::MacroAssemblerCodePtrHash::hash):
(JSC::MacroAssemblerCodePtrHash::equal):

  • assembler/MacroAssemblerX86Common.h:
  • assembler/RepatchBuffer.h:

(JSC::RepatchBuffer::RepatchBuffer):
(JSC::RepatchBuffer::codeBlock):

  • ftl/FTLAbbreviations.h:

(JSC::FTL::setInstructionCallingConvention):

  • ftl/FTLCompile.cpp:

(JSC::FTL::fixFunctionBasedOnStackMaps):

  • ftl/FTLInlineCacheSize.cpp:

(JSC::FTL::sizeOfGetById):
(JSC::FTL::sizeOfPutById):

  • ftl/FTLJITFinalizer.cpp:

(JSC::FTL::JITFinalizer::finalizeFunction):

  • ftl/FTLLocation.cpp:

(JSC::FTL::Location::forStackmaps):

  • ftl/FTLLocation.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileGetById):
(JSC::FTL::LowerDFGToLLVM::compilePutById):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

  • ftl/FTLSlowPathCall.cpp:
  • ftl/FTLSlowPathCallKey.h:

(JSC::FTL::SlowPathCallKey::withCallTarget):

  • ftl/FTLStackMaps.cpp:

(JSC::FTL::StackMaps::Location::directGPR):
(JSC::FTL::StackMaps::Location::restoreInto):

  • ftl/FTLStackMaps.h:
  • ftl/FTLThunks.h:

(JSC::FTL::generateIfNecessary):
(JSC::FTL::keyForThunk):
(JSC::FTL::Thunks::keyForSlowPathCallThunk):

  • jit/FPRInfo.h:

(JSC::FPRInfo::toIndex):

  • jit/GPRInfo.h:

(JSC::GPRInfo::toIndex):
(JSC::GPRInfo::debugName):

  • jit/RegisterSet.cpp:

(JSC::RegisterSet::calleeSaveRegisters):

  • jit/RegisterSet.h:

(JSC::RegisterSet::filter):

  • jit/Repatch.cpp:

(JSC::readCallTarget):
(JSC::repatchCall):
(JSC::repatchByIdSelfAccess):
(JSC::tryCacheGetByID):
(JSC::tryCachePutByID):
(JSC::tryBuildPutByIdList):
(JSC::resetGetByID):
(JSC::resetPutByID):

  • jit/ScratchRegisterAllocator.h:

(JSC::ScratchRegisterAllocator::lock):

Source/WTF:

Reviewed by Sam Weinig.

I needed to add another set operation, namely filter(), which is an in-place set
intersection.

  • wtf/BitVector.cpp:

(WTF::BitVector::filterSlow):

  • wtf/BitVector.h:

(WTF::BitVector::filter):

10:20 PM Changeset in webkit [159038] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

Shrink RenderInline.
<https://webkit.org/b/124134>

Move the "always create line boxes" bit from RenderInline up to
RenderElement. I didn't do this earlier because there were no bits
free on RenderObject but thanks to RenderElement we now have tons!

540 kB progression on HTML5 spec at <http://whatwg.org/c>

Reviewed by Anders Carlsson.

8:58 PM Changeset in webkit [159037] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WTF

[EFL] Build break on Ubuntu 13.10
https://bugs.webkit.org/show_bug.cgi?id=124131

Reviewed by Gyuyoung Kim.

Turned DisallowCType macros off on EFL port because gtest-internal.h uses isspace().

  • wtf/DisallowCType.h: Added !PLATFORM(EFL) guard.
8:02 PM Changeset in webkit [159036] by weinig@apple.com
  • 53 edits in trunk/Source/WebCore

Make childShouldCreateRenderer() take a Node reference
https://bugs.webkit.org/show_bug.cgi?id=124132

Reviewed by Andreas Kling.

The Node passed to childShouldCreateRenderer() is never null.

5:58 PM Changeset in webkit [159035] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

CSS direction must be reset to ltr on <math> element.
<https://webkit.org/b/124121>

Patch by Frédéric Wang <fred.wang@free.fr> on 2013-11-10
Reviewed by Darin Adler.

Source/WebCore:

Test: mathml/presentation/direction.html

  • css/mathml.css:

(math): set direction: ltr; on the <math> element.

LayoutTests:

  • mathml/presentation/direction-expected.html: Added.
  • mathml/presentation/direction.html: Added.
4:22 PM Changeset in webkit [159034] by weinig@apple.com
  • 5 edits in trunk/Source/WebCore

Reduce the size of RenderBlockFlow by making its rare data inherit from RenderBlockRareData
https://bugs.webkit.org/show_bug.cgi?id=124124

Reviewed by Anders Carlsson.

Reduce RenderBlockFlow by one word.

  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:
  • rendering/RenderBlockFlow.cpp:
  • rendering/RenderBlockFlow.h:
4:13 PM Changeset in webkit [159033] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/efl

Cleanup the EFL --minimal build from unused parameters
https://bugs.webkit.org/show_bug.cgi?id=124048

Patch by Tibor Meszaros <mtibor@inf.u-szeged.hu> on 2013-11-10
Reviewed by Gyuyoung Kim.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::createWindow):

  • ewk/ewk_settings.cpp:

(ewk_settings_web_database_path_set):

  • ewk/ewk_view.cpp:

(ewk_view_visibility_state_set):
(ewk_view_visibility_state_get):

3:32 PM Changeset in webkit [159032] by Antti Koivisto
  • 5 edits in trunk/Source/WebCore

Use start/end instead of textOffset/textLength for simple text runs
https://bugs.webkit.org/show_bug.cgi?id=124130

Reviewed by Oliver Hunt.

The code reads better this way.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::createTextRuns):

  • rendering/SimpleLineLayout.h:

(WebCore::SimpleLineLayout::Run::Run):

  • rendering/SimpleLineLayoutFunctions.h:

(WebCore::SimpleLineLayout::findTextCaretMinimumOffset):
(WebCore::SimpleLineLayout::findTextCaretMaximumOffset):
(WebCore::SimpleLineLayout::containsTextCaretOffset):
(WebCore::SimpleLineLayout::isTextRendered):

  • rendering/SimpleLineLayoutResolver.h:

(WebCore::SimpleLineLayout::RunResolver::Run::text):

2:28 PM Changeset in webkit [159031] by oliver@apple.com
  • 11 edits
    3 moves
    6 adds in trunk

Implement Set iterators
https://bugs.webkit.org/show_bug.cgi?id=124129

Reviewed by Antti Koivisto.

Source/JavaScriptCore:

Add Set iterator classes and implementations

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/CommonIdentifiers.h:
  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h:
  • runtime/JSSetIterator.cpp: Added.

(JSC::JSSetIterator::finishCreation):
(JSC::JSSetIterator::visitChildren):
(JSC::JSSetIterator::createPair):

  • runtime/JSSetIterator.h: Added.

(JSC::JSSetIterator::createStructure):
(JSC::JSSetIterator::create):
(JSC::JSSetIterator::next):
(JSC::JSSetIterator::JSSetIterator):

  • runtime/SetIteratorConstructor.cpp: Added.

(JSC::SetIteratorConstructor::finishCreation):

  • runtime/SetIteratorConstructor.h: Added.

(JSC::SetIteratorConstructor::create):
(JSC::SetIteratorConstructor::createStructure):
(JSC::SetIteratorConstructor::SetIteratorConstructor):

  • runtime/SetIteratorPrototype.cpp: Added.

(JSC::SetIteratorPrototype::finishCreation):
(JSC::SetIteratorPrototypeFuncIterator):
(JSC::SetIteratorPrototypeFuncNext):

  • runtime/SetIteratorPrototype.h: Added.

(JSC::SetIteratorPrototype::create):
(JSC::SetIteratorPrototype::createStructure):
(JSC::SetIteratorPrototype::SetIteratorPrototype):

  • runtime/SetPrototype.cpp:

(JSC::SetPrototype::finishCreation):
(JSC::setProtoFuncValues):
(JSC::setProtoFuncEntries):
(JSC::setProtoFuncKeys):

LayoutTests:

Move Set tests to more sensible location and add iterator tests

  • js/basic-set-expected.txt: Renamed from LayoutTests/js/dom/basic-set-expected.txt.
  • js/basic-set.html: Renamed from LayoutTests/js/dom/basic-set.html.
  • js/script-tests/basic-set.js: Renamed from LayoutTests/js/dom/script-tests/basic-set.js.

(set new):
(otherString.string_appeared_here.set add):
(try.set forEach):
(set forEach):
(set gc):

2:17 PM Changeset in webkit [159030] by Antti Koivisto
  • 9 edits
    10 adds in trunk

Implement white-space property on simple line layout path
https://bugs.webkit.org/show_bug.cgi?id=124122

Source/WebCore:

Reviewed by Andreas Kling.

Support all values of the white-space property and the tab-size property.

Tests: fast/forms/basic-textareas-simple-lines.html

fast/text/embed-at-end-of-pre-wrap-line-simple-lines.html
fast/text/whitespace/pre-wrap-line-test-simple-lines.html
fast/text/whitespace/pre-wrap-long-word-simple-lines.html
fast/text/whitespace/pre-wrap-spaces-after-newline-simple-lines.html

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):
(WebCore::SimpleLineLayout::isWhitespace):
(WebCore::SimpleLineLayout::skipWhitespaces):
(WebCore::SimpleLineLayout::textWidth):
(WebCore::SimpleLineLayout::measureWord):
(WebCore::SimpleLineLayout::createTextRuns):

  • rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::paintDebugBorders):
(WebCore::SimpleLineLayout::paintFlow):

LayoutTests:

Reviewed by Andreas Kling.

The simple line layout produces slightly different runs in some pre-wrap cases compared
to the line box path (with less unnecessary boxes). To keep the test coverage this patch forces the
existing render tree dump based tests to use line boxes. It also adds new ref tests for
the same cases where the test uses the simple line path and the ref is forced on the line box path.
This ensures that the paths produce pixel-identical results.

  • fast/forms/basic-textareas-simple-lines-expected.html: Added.
  • fast/forms/basic-textareas-simple-lines.html: Added.
  • fast/forms/basic-textareas.html:
  • fast/text/embed-at-end-of-pre-wrap-line-simple-lines-expected.html: Added.
  • fast/text/embed-at-end-of-pre-wrap-line-simple-lines.html: Added.
  • fast/text/embed-at-end-of-pre-wrap-line.html:
  • fast/text/whitespace/pre-wrap-line-test-simple-lines-expected.html: Added.
  • fast/text/whitespace/pre-wrap-line-test-simple-lines.html: Added.
  • fast/text/whitespace/pre-wrap-line-test.html:
  • fast/text/whitespace/pre-wrap-long-word-simple-lines-expected.html: Added.
  • fast/text/whitespace/pre-wrap-long-word-simple-lines.html: Added. New simple test for overflowing lines which was only covered by the very large basic-textareas.html.
  • fast/text/whitespace/pre-wrap-spaces-after-newline-simple-lines-expected.html: Added.
  • fast/text/whitespace/pre-wrap-spaces-after-newline-simple-lines.html: Added.
  • fast/text/whitespace/pre-wrap-spaces-after-newline.html:
12:59 PM Changeset in webkit [159029] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix EFL build after r159027
https://bugs.webkit.org/show_bug.cgi?id=124127

Patch by Sergio Correia <Sergio Correia> on 2013-11-10
Reviewed by Anders Carlsson.

No new tests, build fix.

  • page/Settings.in: Add std to numeric_limits, since we don't have

'using std' directives anymore.

11:50 AM Changeset in webkit [159028] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix build.

  • rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::computeColumnCountAndWidth):
(WebCore::RenderMultiColumnBlock::checkForPaginationLogicalHeightChange):

11:32 AM Changeset in webkit [159027] by andersca@apple.com
  • 151 edits in trunk/Source/WebCore

Remove all 'std' using directives from WebCore
https://bugs.webkit.org/show_bug.cgi?id=124125

Reviewed by Sam Weinig.

As per the coding style guidelines.

  • loader/CrossOriginPreflightResultCache.cpp:

(WebCore::CrossOriginPreflightResultCache::appendEntry):
(WebCore::CrossOriginPreflightResultCache::canSkipPreflight):

  • loader/WorkerThreadableLoader.cpp:
  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::loadCache):

  • loader/appcache/ManifestParser.cpp:

(WebCore::parseManifest):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::deadCapacity):
(WebCore::MemoryCache::lruListFor):

  • page/CaptionUserPreferencesMediaAF.cpp:
  • page/Chrome.cpp:
  • page/DOMTimer.cpp:

(WebCore::DOMTimer::intervalClampedToMinimum):

  • page/FocusController.cpp:
  • page/Frame.cpp:

(WebCore::Frame::resizePageRectsKeepingRatio):

  • page/PageGroupLoadDeferrer.cpp:
  • page/Settings.cpp:
  • page/animation/AnimationBase.cpp:

(WebCore::solveStepsFunction):
(WebCore::AnimationBase::fireAnimationEventsIfNeeded):
(WebCore::AnimationBase::timeToNextService):
(WebCore::AnimationBase::fractionalTime):
(WebCore::AnimationBase::getTimeToNextEvent):

  • page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty):

  • platform/DateComponents.cpp:
  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleWheelEvent):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::unscaledVisibleContentSize):
(WebCore::ScrollView::setScrollOffset):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::scrollContents):

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::moveThumb):

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::usedTotalSize):
(WebCore::ScrollbarThemeComposite::thumbPosition):
(WebCore::ScrollbarThemeComposite::thumbLength):

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::append):
(WebCore::SharedBuffer::copyBufferAndClear):
(WebCore::SharedBuffer::getSomeData):

  • platform/ThreadTimers.cpp:

(WebCore::ThreadTimers::updateSharedTimer):

  • platform/Timer.cpp:

(WebCore::TimerHeapLessThanFunction::operator()):
(WebCore::TimerBase::heapPop):
(WebCore::TimerBase::nextUnalignedFireInterval):

  • platform/URL.cpp:

(WebCore::findHostnamesInMailToURL):
(WebCore::portAllowed):

  • platform/audio/AudioResampler.cpp:

(WebCore::AudioResampler::setRate):

  • platform/audio/AudioResamplerKernel.cpp:

(WebCore::AudioResamplerKernel::process):

  • platform/audio/Distance.cpp:

(WebCore::DistanceEffect::gain):

  • platform/audio/DynamicsCompressorKernel.cpp:

(WebCore::DynamicsCompressorKernel::process):

  • platform/audio/EqualPowerPanner.cpp:

(WebCore::EqualPowerPanner::pan):

  • platform/audio/HRTFDatabase.cpp:

(WebCore::HRTFDatabase::indexFromElevationAngle):

  • platform/audio/HRTFElevation.cpp:

(WebCore::HRTFElevation::createForSubject):

  • platform/audio/HRTFKernel.cpp:

(WebCore::HRTFKernel::HRTFKernel):
(WebCore::HRTFKernel::createInterpolatedKernel):

  • platform/audio/HRTFPanner.cpp:

(WebCore::HRTFPanner::calculateDesiredAzimuthIndexAndBlend):

  • platform/audio/Reverb.cpp:
  • platform/audio/SincResampler.cpp:

(WebCore::SincResampler::process):

  • platform/cf/URLCF.cpp:
  • platform/graphics/Color.cpp:

(WebCore::makeRGB):
(WebCore::makeRGBA):
(WebCore::colorFloatToRGBAByte):
(WebCore::Color::light):
(WebCore::Color::dark):

  • platform/graphics/CrossfadeGeneratedImage.cpp:
  • platform/graphics/FloatQuad.cpp:

(WebCore::min4):
(WebCore::max4):
(WebCore::withinEpsilon):

  • platform/graphics/FloatSize.cpp:

(WebCore::FloatSize::isZero):

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::floatWidthForSimpleText):

  • platform/graphics/FontPlatformData.cpp:
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/RoundedRect.cpp:

(WebCore::RoundedRect::Radii::expand):

  • platform/graphics/ShadowBlur.cpp:

(WebCore::calculateLobes):
(WebCore::computeSliceSizesFromRadii):

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::initCharWidths):

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator):
(WebCore::WidthIterator::advanceInternal):

  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::InbandTextTrackPrivateAVF::processCue):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration):
(WebCore::MediaPlayerPrivateAVFoundationObjC::currentTime):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setOpacity):
(WebCore::GraphicsLayerCA::setNeedsDisplay):
(WebCore::GraphicsLayerCA::setupAnimation):
(WebCore::clampedContentsScaleForScale):

  • platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::getTileIndexRangeForRect):
(WebCore::TileController::computeTileCoverageRect):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::computeLineBoundsAndAntialiasingModeForText):

  • platform/graphics/cg/ImageBufferCG.cpp:
  • platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::ImageBufferData::getData):

  • platform/graphics/cg/ImageSourceCG.cpp:
  • platform/graphics/filters/FEDropShadow.cpp:
  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::boxBlur):
(WebCore::FEGaussianBlur::platformApplyGeneric):
(WebCore::FEGaussianBlur::calculateUnscaledKernelSize):
(WebCore::FEGaussianBlur::calculateStdDeviation):

  • platform/graphics/gpu/Texture.cpp:

(WebCore::Texture::updateSubRect):

  • platform/graphics/gpu/TilingData.cpp:

(WebCore::computeNumTiles):
(WebCore::TilingData::tileXIndexFromSrcCoord):
(WebCore::TilingData::tileYIndexFromSrcCoord):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::offsetForPosition):
(WebCore::ComplexTextController::advance):
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::floatWidthForComplexText):

  • platform/graphics/mac/FontMac.mm:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::duration):

  • platform/graphics/mac/SimpleFontDataMac.mm:
  • platform/graphics/transforms/Matrix3DTransformOperation.cpp:
  • platform/graphics/transforms/MatrixTransformOperation.cpp:
  • platform/graphics/transforms/PerspectiveTransformOperation.cpp:
  • platform/graphics/transforms/RotateTransformOperation.cpp:
  • platform/graphics/transforms/TransformOperations.cpp:

(WebCore::TransformOperations::blendByMatchingOperations):

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::clampEdgeValue):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::adjustScrollPositionIfNecessary):

  • platform/mac/ScrollViewMac.mm:

(WebCore::ScrollView::platformSetContentsSize):
(WebCore::ScrollView::platformSetScrollPosition):

  • platform/mac/ScrollbarThemeMac.mm:
  • platform/mac/ThemeMac.mm:
  • platform/mac/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController incrementVolume]):
(timeToString):

  • platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::copyData):

  • platform/network/ResourceRequestBase.cpp:
  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::parseCacheControlDirectives):

  • platform/network/cf/ResourceResponseCFNet.cpp:
  • platform/network/mac/ResourceResponseMac.mm:

(WebCore::ResourceResponse::initNSURLResponse):

  • platform/text/TextBreakIteratorICU.cpp:

(WebCore::textClone):
(WebCore::textLatin1MoveInPrimaryContext):
(WebCore::textLatin1MoveInPriorContext):
(WebCore::textInChunkOrOutOfRange):
(WebCore::textOpenLatin1):
(WebCore::textUTF16MoveInPrimaryContext):
(WebCore::textUTF16MoveInPriorContext):
(WebCore::textOpenUTF16):

  • platform/text/TextCodecUTF16.cpp:

(WebCore::TextCodecUTF16::encode):

  • platform/text/TextCodecUTF8.cpp:

(WebCore::TextCodecUTF8::encode):

  • platform/text/TextStream.cpp:
  • platform/text/mac/LocaleMac.mm:
  • platform/text/mac/TextCodecMac.cpp:

(WebCore::TextCodecMac::decode):

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::computeIntrinsicLogicalWidths):
(WebCore::AutoTableLayout::applyPreferredLogicalWidthQuirks):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::layout):

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::applyPreferredLogicalWidthQuirks):

  • rendering/FloatingObjects.cpp:

(WebCore::FindNextFloatLogicalBottomAdapter::collectIfNeeded):
(WebCore::FloatingObjects::logicalRightOffsetForPositioningFloat):
(WebCore::FloatingObjects::logicalRightOffset):

  • rendering/InlineBox.cpp:
  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxRangeInInlineDirection):
(WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::computeMaxLogicalTop):
(WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
(WebCore::InlineFlowBox::addBorderOutsetVisualOverflow):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::constrainToLineTopAndBottomIfNeeded):
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment):
(WebCore::InlineFlowBox::computeUnderAnnotationAdjustment):
(WebCore::InlineFlowBox::collectLeafBoxesInLogicalOrder):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::isSelected):
(WebCore::InlineTextBox::localSelectionRect):
(WebCore::InlineTextBox::placeEllipsisBox):
(WebCore::InlineTextBox::applyShadowToGraphicsContext):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::selectionStartEnd):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::computeUnderlineOffset):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintDocumentMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
(WebCore::InlineTextBox::paintCompositionUnderline):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
(WebCore::RenderBlock::paintChild):
(WebCore::RenderBlock::blockSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionGap):
(WebCore::RenderBlock::logicalRightSelectionGap):
(WebCore::RenderBlock::calcColumnWidth):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::computeIntrinsicLogicalWidths):
(WebCore::RenderBlock::computePreferredLogicalWidths):
(WebCore::RenderBlock::adjustIntrinsicLogicalWidthsForColumns):
(WebCore::updatePreferredWidth):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::clearFloats):
(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::RenderBlockFlow::collapseMargins):
(WebCore::RenderBlockFlow::clearFloatsIfNeeded):
(WebCore::RenderBlockFlow::marginBeforeEstimateForChild):
(WebCore::RenderBlockFlow::estimateLogicalTopPosition):
(WebCore::RenderBlockFlow::setCollapsedBottomMargin):
(WebCore::RenderBlockFlow::handleAfterSideOfBlock):
(WebCore::calculateMinimumPageHeight):
(WebCore::RenderBlockFlow::adjustLinePositionForPagination):
(WebCore::RenderBlockFlow::removeFloatingObject):
(WebCore::RenderBlockFlow::computeLogicalLocationForFloat):
(WebCore::RenderBlockFlow::positionNewFloats):
(WebCore::RenderBlockFlow::lowestFloatLogicalBottom):
(WebCore::RenderBlockFlow::addOverhangingFloats):
(WebCore::RenderBlockFlow::getClearDelta):
(WebCore::RenderBlockFlow::adjustForBorderFit):
(WebCore::RenderBlockFlow::fitBorderToLinesIfNeeded):
(WebCore::RenderBlockFlow::updateLogicalHeight):
(WebCore::RenderBlockFlow::positionForPointWithInlineChildren):
(WebCore::RenderBlockFlow::addFocusRingRectsForInlineChildren):
(WebCore::RenderBlockFlow::relayoutForPagination):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::updateLogicalWidthForLeftAlignedBlock):
(WebCore::updateLogicalWidthForRightAlignedBlock):
(WebCore::updateLogicalWidthForCenterAlignedBlock):
(WebCore::setLogicalWidthForTextRun):
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
(WebCore::RenderBlockFlow::layoutLineBoxes):
(WebCore::RenderBlockFlow::checkFloatsInCleanLine):
(WebCore::RenderBlockFlow::checkPaginationAndFloatsAtEndLine):
(WebCore::tryHyphenating):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
(WebCore::RenderBox::constrainLogicalWidthInRegionByMinMax):
(WebCore::RenderBox::constrainLogicalHeightByMinMax):
(WebCore::RenderBox::constrainContentBoxLogicalHeightByMinMax):
(WebCore::RenderBox::adjustBorderBoxLogicalWidthForBoxSizing):
(WebCore::RenderBox::adjustBorderBoxLogicalHeightForBoxSizing):
(WebCore::RenderBox::adjustContentBoxLogicalWidthForBoxSizing):
(WebCore::RenderBox::adjustContentBoxLogicalHeightForBoxSizing):
(WebCore::RenderBox::repaintLayerRectsForImage):
(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats):
(WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
(WebCore::RenderBox::containingBlockAvailableLineWidthInRegion):
(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeIntrinsicLogicalWidthUsing):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth):
(WebCore::RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::applyVisualEffectOverflow):
(WebCore::RenderBox::addLayoutOverflow):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setNoRepeatX):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setNoRepeatY):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::useFixedAttachment):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
(WebCore::RenderBoxModelObject::paintOneBorderSide):
(WebCore::calculateAdjustedInnerBorder):
(WebCore::RenderBoxModelObject::paintBoxShadow):
(WebCore::RenderBoxModelObject::localCaretRectForEmptyElement):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::FlexBoxIterator::next):
(WebCore::RenderDeprecatedFlexibleBox::computeIntrinsicLogicalWidths):
(WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
(WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::maxFilenameWidth):
(WebCore::RenderFileUploadControl::computeIntrinsicLogicalWidths):
(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::setImageSizeForAltText):

  • rendering/RenderInline.cpp:

(WebCore::computeMargin):
(WebCore::RenderInline::linesVisualOverflowBoundingBox):
(WebCore::RenderInline::paintOutline):
(WebCore::RenderInline::paintOutlineForLine):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::clampScrollOffset):
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::visibleContentRect):
(WebCore::RenderLayer::updateScrollbarsAfterLayout):
(WebCore::RenderLayer::hitTestOverflowControls):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::calculateLayerBounds):

  • rendering/RenderLayerBacking.cpp:
  • rendering/RenderLayerModelObject.cpp:
  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::rangeIntersectsRect):
(WebCore::RenderLineBoxList::anyLineIntersectsRect):
(WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::paint):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::layout):
(WebCore::RenderListBox::computePreferredLogicalWidths):
(WebCore::RenderListBox::size):
(WebCore::RenderListBox::numVisibleItems):
(WebCore::RenderListBox::panScroll):
(WebCore::RenderListBox::scrollHeight):

  • rendering/RenderListItem.cpp:
  • rendering/RenderListMarker.cpp:
  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::marqueeSpeed):
(WebCore::RenderMarquee::computePosition):
(WebCore::RenderMarquee::timerFired):

  • rendering/RenderMediaControls.cpp:
  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::updateOptionsWidth):
(WebCore::RenderMenuList::computeIntrinsicLogicalWidths):
(WebCore::RenderMenuList::computePreferredLogicalWidths):

  • rendering/RenderMeter.cpp:
  • rendering/RenderMultiColumnBlock.cpp:
  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::heightAdjustedForSetOffset):
(WebCore::RenderMultiColumnSet::calculateBalancedHeight):
(WebCore::RenderMultiColumnSet::updateLogicalWidth):

  • rendering/RenderNamedFlowFragment.cpp:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
(WebCore::RenderObject::caretMaxOffset):

  • rendering/RenderProgress.cpp:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::overflowRectForFlowThreadPortion):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::shouldPaint):
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computePreferredLogicalWidths):

  • rendering/RenderRubyBase.cpp:
  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::getOverhang):

  • rendering/RenderRubyText.cpp:

(WebCore::RenderRubyText::adjustInlineDirectionLineBounds):

  • rendering/RenderScrollbarPart.cpp:

(WebCore::RenderScrollbarPart::computeScrollbarWidth):
(WebCore::RenderScrollbarPart::computeScrollbarHeight):

  • rendering/RenderSearchField.cpp:

(WebCore::RenderSearchField::computeControlLogicalHeight):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::updateLogicalWidth):
(WebCore::RenderTable::convertStyleLogicalHeightToComputedHeight):
(WebCore::RenderTable::layout):
(WebCore::RenderTable::computePreferredLogicalWidths):
(WebCore::RenderTable::calcBorderStart):
(WebCore::RenderTable::calcBorderEnd):
(WebCore::RenderTable::outerBorderBefore):
(WebCore::RenderTable::outerBorderAfter):
(WebCore::RenderTable::outerBorderStart):
(WebCore::RenderTable::outerBorderEnd):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::parseColSpanFromDOM):
(WebCore::RenderTableCell::parseRowSpanFromDOM):
(WebCore::RenderTableCell::logicalWidthFromColumns):
(WebCore::RenderTableCell::computePreferredLogicalWidths):
(WebCore::RenderTableCell::layout):
(WebCore::RenderTableCell::setOverrideLogicalContentHeightFromRowHeight):
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::alignLeftRightBorderPaintRect):
(WebCore::RenderTableCell::alignTopBottomBorderPaintRect):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::ensureRows):
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::distributeExtraLogicalHeightToPercentRows):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::firstLineBaseline):
(WebCore::RenderTableSection::removeCachedCollapsedBorders):
(WebCore::RenderTableSection::setCachedCollapsedBorder):
(WebCore::RenderTableSection::cachedCollapsedBorder):

  • rendering/RenderText.cpp:

(WebCore::makeCapitalized):
(WebCore::RenderText::absoluteRectsForRange):
(WebCore::RenderText::absoluteQuadsForRange):
(WebCore::maxWordFragmentWidth):
(WebCore::RenderText::computePreferredLogicalWidths):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::computePreferredLogicalWidths):

  • rendering/RenderTextControlSingleLine.cpp:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintProgressBar):
(WebCore::RenderThemeMac::paintMenuListButton):

  • rendering/RenderWidget.cpp:
  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::RootInlineBox::beforeAnnotationsAdjustment):
(WebCore::RootInlineBox::selectionTopAdjustedForPrecedingBlock):
(WebCore::RootInlineBox::blockDirectionPointInLine):
(WebCore::RootInlineBox::paddedLayoutOverflowRect):
(WebCore::setAscentAndDescent):
(WebCore::RootInlineBox::ascentAndDescentForBox):

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::layout):

  • rendering/style/RenderStyle.cpp:

(WebCore::calcConstraintScaleFor):
(WebCore::RenderStyle::setFontSize):
(WebCore::RenderStyle::getShadowExtent):
(WebCore::RenderStyle::getShadowInsetExtent):
(WebCore::RenderStyle::getShadowHorizontalExtent):
(WebCore::RenderStyle::getShadowVerticalExtent):

  • rendering/style/SVGRenderStyle.cpp:
  • rendering/style/ShadowData.cpp:

(WebCore::calculateShadowExtent):

  • rendering/svg/RenderSVGResourceFilter.cpp:
  • rendering/svg/RenderSVGRoot.cpp:
  • rendering/svg/SVGInlineFlowBox.cpp:

(WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::localSelectionRect):

  • svg/SVGAnimatedNumber.cpp:
  • svg/SVGAnimatedNumberOptionalNumber.cpp:
  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::startTimer):
(WebCore::SMILTimeContainer::updateAnimations):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::simpleDuration):
(WebCore::SVGSMILElement::repeatingDuration):
(WebCore::SVGSMILElement::resolveActiveEnd):
(WebCore::SVGSMILElement::resolveInterval):
(WebCore::SVGSMILElement::resolveFirstInterval):
(WebCore::SVGSMILElement::resolveNextInterval):
(WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):

  • xml/XMLTreeViewer.cpp:
  • xml/parser/XMLDocumentParser.cpp:
  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::OffsetBuffer::readOutBytes):

8:59 AM Changeset in webkit [159026] by gyuyoung.kim@samsung.com
  • 23 edits in trunk/Source

[AX] Clean up static_cast<> to cast from AccessibilityObject
https://bugs.webkit.org/show_bug.cgi?id=124032

Reviewed by Mario Sanchez Prada.

Source/WebCore:

ACCESSIBILITY_OBJECT_TYPE_CASTS can support more helpful casting functions.
So, we need to use them as much as possible. This patch cleans up all static_cast<> in accessibility.

This patch generates toAccessibilityFoo() in order to replace static_cast<> with it. Below toAccessibilityFoo()
are generated.

  • toAccessibilityARIAGridRow()
  • toAccessibilityImageMapLink()
  • toAccessibilityListBox()
  • toAccessibilityListBoxOption()
  • toAccessibilityMenuListOption()
  • toAccessibilityMenuListPopup()
  • toAccessibilityScrollbar()
  • toAccessibilitySlider()

No new tests, no behavior changes.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::focusedImageMapUIElement):

  • accessibility/AccessibilityARIAGridRow.h:
  • accessibility/AccessibilityImageMapLink.h:
  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::setSelectedChildren):
(WebCore::AccessibilityListBox::selectedChildren):
(WebCore::AccessibilityListBox::listBoxOptionAccessibilityObject):

  • accessibility/AccessibilityListBox.h:
  • accessibility/AccessibilityListBoxOption.h:
  • accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::addChildren):
(WebCore::AccessibilityMenuList::didUpdateActiveOption):

  • accessibility/AccessibilityMenuListOption.h:
  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):

  • accessibility/AccessibilityMenuListPopup.h:
  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isListBoxOption):
(WebCore::AccessibilityObject::isSliderThumb):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::getDocumentLinks):
(WebCore::AccessibilityRenderObject::addImageMapChildren):
(WebCore::AccessibilityRenderObject::addTextFieldChildren):

  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::addChildScrollbar):

  • accessibility/AccessibilityScrollbar.h:
  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::addChildren):

  • accessibility/AccessibilitySlider.h:
  • accessibility/AccessibilitySpinButton.cpp:

(WebCore::AccessibilitySpinButton::addChildren):

  • accessibility/atk/WebKitAccessibleInterfaceSelection.cpp:

(webkitAccessibleSelectionClearSelection):
(webkitAccessibleSelectionSelectAllSelection):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::didUpdateActiveOption):

Source/WebKit/win:

Use toAccessibilityListBox instead of using static_cast<AccessibilityListBox*>.

  • AccessibleBase.cpp:

(AccessibleBase::accSelect):

8:34 AM Changeset in webkit [159025] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Rebaseline bindings tests after r158997.

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
6:52 AM Changeset in webkit [159024] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

[GStreamer] Consolidate more code into TrackPrivateBaseGStreamer
https://bugs.webkit.org/show_bug.cgi?id=124020

Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-10
Reviewed by Philippe Normand.

No new tests because this is just refactoring.

  • platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:

(WebCore::AudioTrackPrivateGStreamer::AudioTrackPrivateGStreamer): Don't pass playbin to TrackPrivateBaseGStreamer, and do pass a pointer to "this".
(WebCore::AudioTrackPrivateGStreamer::disconnect): Clear m_playbin().

  • platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h: Move labelChanged() and languageChanged() to TrackPrivateBaseGStreamer. Move m_playbin to this class (along with disconnect() to clear it).
  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp: Move tag handling, pad and index to TrackPrivateBaseGStreamer.

(WebCore::textTrackPrivateEventCallback):
(WebCore::InbandTextTrackPrivateGStreamer::InbandTextTrackPrivateGStreamer):
(WebCore::InbandTextTrackPrivateGStreamer::disconnect):

  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
  • platform/graphics/gstreamer/TextCombinerGStreamer.cpp: Add WebKitTextCombinerPad with "tags" property, set in the same was as input-selector's pads.

(webkit_text_combiner_pad_init): Initialize tags to 0.
(webkitTextCombinerPadFinalize): Clear tags.
(webkitTextCombinerPadGetProperty): Handling "tags" property.
(webkitTextCombinerPadEvent): Changed to be a pad event function instead of a pad probe, and now intercepts tags and merges them (like input-selector pads do).
(webkitTextCombinerRequestNewPad): Using WebKitTextCombinerPad instead of just GhostPad.
(webkit_text_combiner_pad_class_init): Setup WebKitTextCombinerPad.

  • platform/graphics/gstreamer/TextCombinerGStreamer.h: Remove superfluous code.
  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:

(WebCore::TrackPrivateBaseGStreamer::TrackPrivateBaseGStreamer): Use "notify::active" so we don't need a playbin, and immediately check for tags after the constructor.
(WebCore::TrackPrivateBaseGStreamer::disconnect): Remove m_playbin.
(WebCore::TrackPrivateBaseGStreamer::getTag): Refactored out from notifyTrackOfTagsChanged.
(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfTagsChanged): Simplify using m_owner (so we can call labelChanged() and languageChanged() directly), and use getTag() above.

  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h: Add m_owner to we can access the owning track, and change some functions to match our needs better.

(WebCore::TrackPrivateBaseGStreamer::setActive): Add empty default since InbandTextTrackPrivateGStreamer doesn't need this.

  • platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp: Same as AudioTrackPrivateGStreamer.

(WebCore::VideoTrackPrivateGStreamer::VideoTrackPrivateGStreamer):
(WebCore::VideoTrackPrivateGStreamer::disconnect):

  • platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h: Same as AudioTrackPrivateGStreamer.
2:59 AM Changeset in webkit [159023] by akling@apple.com
  • 10 edits in trunk/Source/WebCore

Generate type casting helpers for Widget classes.
<https://webkit.org/b/124120>

Add a WIDGET_TYPE_CASTS macro and replace all the hand-written
toFoo() helpers we had for Widget subclasses. Fixed up a handful
of places that were still using static_cast.

Reviewed by Antti Koivisto.

2:58 AM Changeset in webkit [159022] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Remove unused FragmentationDisabler class.
<https://webkit.org/b/124118>

This RAII object was added in r144744 to avoid a crash when using
MathML inside CSS regions. Its only user was removed in r157070.

Reviewed by Antti Koivisto.

2:56 AM Changeset in webkit [159021] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Simplify some is-this-a-MathML-element? checks.
<https://webkit.org/b/124119>

As of r158198, the MathML-ness of an Element is determined by
a Node flag, so there's no need to cast to Element before checking
on this. Simplify accordingly.

Reviewed by Antti Koivisto.

12:57 AM Changeset in webkit [159020] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Remove RenderTheme::shouldOpenPickerWithF4Key().

Rubber-stamped by Anders Carlsson.

12:39 AM Changeset in webkit [159019] by akling@apple.com
  • 2 edits
    2 copies
    128 moves
    2 adds
    134 deletes in trunk/LayoutTests

Optimize baselines: svg/*

Unreviewed; run "webkit-patch optimize-baselines svg"

  • platform/efl-wk2/svg/dom/SVGLengthList-basics-expected.png: Renamed from LayoutTests/platform/efl/svg/dom/SVGLengthList-basics-expected.png.
  • platform/efl/svg/wicd/sizing-flakiness-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Removed.
  • platform/gtk/svg/as-image/svg-as-image-expected.png: Removed.
  • platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Removed.
  • platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Removed.
  • platform/gtk/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png: Removed.
  • platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Removed.
  • platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Removed.
  • platform/gtk/svg/custom/feDisplacementMap-01-expected.txt: Removed.
  • platform/gtk/svg/custom/pattern-skew-transformed-expected.png: Removed.
  • platform/gtk/svg/custom/radialGradient-focal-radius-expected.txt: Removed.
  • platform/gtk/svg/custom/simple-text-double-shadow-expected.png: Removed.
  • platform/gtk/svg/custom/simple-text-double-shadow-expected.txt: Removed.
  • platform/gtk/svg/dom/SVGPathSegList-segment-modification-expected.txt: Removed.
  • platform/gtk/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Removed.
  • platform/gtk/svg/dom/SVGRectElement/rect-modify-rx-expected.png: Removed.
  • platform/gtk/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png: Removed.
  • platform/gtk/svg/dynamic-updates/SVGAElement-dom-target-attr-expected.png: Removed.
  • platform/gtk/svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.png: Removed.
  • platform/gtk/svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.png: Removed.
  • platform/gtk/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png: Removed.
  • platform/gtk/svg/foreignObject/fO-display-none-expected.png: Removed.
  • platform/gtk/svg/foreignObject/fO-display-none-with-relative-pos-content-expected.png: Removed.
  • platform/gtk/svg/foreignObject/fO-parent-display-changes-expected.png: Removed.
  • platform/gtk/svg/foreignObject/fO-parent-display-changes-expected.txt: Removed.
  • platform/gtk/svg/foreignObject/fO-parent-display-none-expected.png: Removed.
  • platform/gtk/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.png: Removed.
  • platform/gtk/svg/foreignObject/fO-parent-of-parent-display-none-expected.png: Removed.
  • platform/gtk/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.png: Removed.
  • platform/gtk/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.png: Removed.
  • platform/gtk/svg/foreignObject/svg-document-as-direct-child-expected.png: Removed.
  • platform/gtk/svg/foreignObject/svg-document-as-direct-child-expected.txt: Removed.
  • platform/gtk/svg/in-html/by-reference-expected.txt: Removed.
  • platform/gtk/svg/overflow/overflow-on-foreignObject-expected.png: Removed.
  • platform/gtk/svg/overflow/overflow-on-inner-svg-element-defaults-expected.png: Removed.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Removed.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Removed.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Removed.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Removed.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.png: Removed.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.png: Removed.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.png: Removed.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.png: Removed.
  • platform/gtk/svg/repaint/filter-repaint-expected.txt: Removed.
  • platform/gtk/svg/repaint/image-href-change-expected.png: Removed.
  • platform/gtk/svg/repaint/inner-svg-change-viewBox-contract-expected.png: Removed.
  • platform/gtk/svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Removed.
  • platform/gtk/svg/repaint/text-mask-update-expected.png: Removed.
  • platform/gtk/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Removed.
  • platform/gtk/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Removed.
  • platform/gtk/svg/text/append-text-node-to-tspan-expected.txt: Removed.
  • platform/gtk/svg/text/bidi-embedded-direction-expected.txt: Removed.
  • platform/gtk/svg/text/bidi-reorder-value-lists-expected.txt: Removed.
  • platform/gtk/svg/text/bidi-text-anchor-direction-expected.txt: Removed.
  • platform/gtk/svg/text/bidi-text-query-expected.txt: Removed.
  • platform/gtk/svg/text/bidi-tspans-expected.txt: Removed.
  • platform/gtk/svg/text/ems-display-none-expected.txt: Removed.
  • platform/gtk/svg/text/exs-display-none-expected.txt: Removed.
  • platform/gtk/svg/text/font-size-below-point-five-expected.txt: Removed.
  • platform/gtk/svg/text/modify-text-node-in-tspan-expected.txt: Removed.
  • platform/gtk/svg/text/remove-text-node-from-tspan-expected.txt: Removed.
  • platform/gtk/svg/text/remove-tspan-from-text-expected.txt: Removed.
  • platform/gtk/svg/text/scaled-font-expected.txt: Removed.
  • platform/gtk/svg/text/scaling-font-with-geometric-precision-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-2-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-3-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-4-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacing-stretch-1-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacing-stretch-2-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacing-stretch-3-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacing-stretch-4-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt: Removed.
  • platform/gtk/svg/text/select-x-list-1-expected.txt: Removed.
  • platform/gtk/svg/text/select-x-list-2-expected.txt: Removed.
  • platform/gtk/svg/text/select-x-list-3-expected.txt: Removed.
  • platform/gtk/svg/text/select-x-list-4-expected.txt: Removed.
  • platform/gtk/svg/text/select-x-list-with-tspans-1-expected.txt: Removed.
  • platform/gtk/svg/text/select-x-list-with-tspans-2-expected.txt: Removed.
  • platform/gtk/svg/text/select-x-list-with-tspans-3-expected.txt: Removed.
  • platform/gtk/svg/text/select-x-list-with-tspans-4-expected.txt: Removed.
  • platform/gtk/svg/text/selection-doubleclick-expected.txt: Removed.
  • platform/gtk/svg/text/small-fonts-2-expected.txt: Removed.
  • platform/gtk/svg/text/small-fonts-3-expected.txt: Removed.
  • platform/gtk/svg/text/small-fonts-expected.txt: Removed.
  • platform/gtk/svg/text/text-align-01-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-align-02-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-align-03-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-align-04-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-align-05-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-align-06-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-altglyph-01-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-deco-01-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-fill-opacity-expected.txt: Removed.
  • platform/gtk/svg/text/text-fonts-01-t-expected.txt: Removed.
  • platform/gtk/svg/text/text-fonts-02-t-expected.txt: Removed.
  • platform/gtk/svg/text/text-gradient-positioning-expected.txt: Removed.
  • platform/gtk/svg/text/text-intro-05-t-expected.txt: Removed.
  • platform/gtk/svg/text/text-midpoint-split-bug-expected.txt: Removed.
  • platform/gtk/svg/text/text-path-01-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-path-middle-align-expected.txt: Removed.
  • platform/gtk/svg/text/text-spacing-01-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-text-01-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-text-03-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-text-04-t-expected.txt: Removed.
  • platform/gtk/svg/text/text-text-05-t-expected.txt: Removed.
  • platform/gtk/svg/text/text-text-06-t-expected.txt: Removed.
  • platform/gtk/svg/text/text-text-07-t-expected.txt: Removed.
  • platform/gtk/svg/text/text-text-08-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-tref-01-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-tselect-01-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-tselect-02-f-expected.txt: Removed.
  • platform/gtk/svg/text/text-tspan-01-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-ws-01-t-expected.txt: Removed.
  • platform/gtk/svg/text/text-ws-02-t-expected.txt: Removed.
  • platform/gtk/svg/text/tspan-dynamic-positioning-expected.txt: Removed.
  • platform/gtk/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Removed.
  • platform/gtk/svg/transforms/text-with-pattern-with-svg-transform-expected.txt: Removed.
  • platform/gtk/svg/wicd/sizing-flakiness-expected.txt: Removed.
  • platform/mac/svg/custom/feDisplacementMap-01-expected.txt: Removed.
  • platform/mac/svg/custom/radialGradient-focal-radius-expected.txt: Removed.
  • platform/mac/svg/custom/stroked-pattern-expected.txt: Removed.
  • platform/mac/svg/text/selection-tripleclick-expected.txt: Removed.
  • platform/win-future/svg/wicd/sizing-flakiness-expected.txt: Copied from LayoutTests/svg/wicd/sizing-flakiness-expected.txt.
  • platform/win/svg/custom/pattern-scaling-expected.txt: Removed.
  • svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt.
  • svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt.
  • svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt.
  • svg/as-image/svg-as-image-expected.png: Renamed from LayoutTests/platform/efl/svg/as-image/svg-as-image-expected.png.
  • svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Renamed from LayoutTests/platform/efl/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png.
  • svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Renamed from LayoutTests/platform/efl/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png.
  • svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png: Renamed from LayoutTests/platform/efl/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png.
  • svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Renamed from LayoutTests/platform/efl/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png.
  • svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Renamed from LayoutTests/platform/efl/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png.
  • svg/custom/feDisplacementMap-01-expected.txt: Renamed from LayoutTests/platform/efl/svg/custom/feDisplacementMap-01-expected.txt.
  • svg/custom/pattern-skew-transformed-expected.png: Renamed from LayoutTests/platform/efl/svg/custom/pattern-skew-transformed-expected.png.
  • svg/custom/radialGradient-focal-radius-expected.txt: Renamed from LayoutTests/platform/efl/svg/custom/radialGradient-focal-radius-expected.txt.
  • svg/custom/simple-text-double-shadow-expected.png: Renamed from LayoutTests/platform/efl/svg/custom/simple-text-double-shadow-expected.png.
  • svg/custom/simple-text-double-shadow-expected.txt: Renamed from LayoutTests/platform/efl/svg/custom/simple-text-double-shadow-expected.txt.
  • svg/custom/stroked-pattern-expected.txt: Renamed from LayoutTests/platform/efl/svg/custom/stroked-pattern-expected.txt.
  • svg/dom/SVGPathSegList-segment-modification-expected.txt: Renamed from LayoutTests/platform/efl/svg/dom/SVGPathSegList-segment-modification-expected.txt.
  • svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Renamed from LayoutTests/platform/efl/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt.
  • svg/dom/SVGRectElement/rect-modify-rx-expected.png: Renamed from LayoutTests/platform/efl/svg/dom/SVGRectElement/rect-modify-rx-expected.png.
  • svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png: Renamed from LayoutTests/platform/efl/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png.
  • svg/dynamic-updates/SVGAElement-dom-target-attr-expected.png: Renamed from LayoutTests/platform/efl/svg/dynamic-updates/SVGAElement-dom-target-attr-expected.png.
  • svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.png: Renamed from LayoutTests/platform/efl/svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.png.
  • svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.png: Renamed from LayoutTests/platform/efl/svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.png.
  • svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png.
  • svg/foreignObject/fO-display-none-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-display-none-expected.png.
  • svg/foreignObject/fO-display-none-with-relative-pos-content-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-display-none-with-relative-pos-content-expected.png.
  • svg/foreignObject/fO-parent-display-changes-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-parent-display-changes-expected.png.
  • svg/foreignObject/fO-parent-display-changes-expected.txt: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-parent-display-changes-expected.txt.
  • svg/foreignObject/fO-parent-display-none-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-parent-display-none-expected.png.
  • svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.png.
  • svg/foreignObject/fO-parent-of-parent-display-none-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-expected.png.
  • svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.png.
  • svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.png.
  • svg/foreignObject/svg-document-as-direct-child-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/svg-document-as-direct-child-expected.png.
  • svg/foreignObject/svg-document-as-direct-child-expected.txt: Renamed from LayoutTests/platform/efl/svg/foreignObject/svg-document-as-direct-child-expected.txt.
  • svg/in-html/by-reference-expected.txt: Renamed from LayoutTests/platform/efl/svg/in-html/by-reference-expected.txt.
  • svg/overflow/overflow-on-foreignObject-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-foreignObject-expected.png.
  • svg/overflow/overflow-on-inner-svg-element-defaults-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-inner-svg-element-defaults-expected.png.
  • svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png.
  • svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png.
  • svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png.
  • svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png.
  • svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.png.
  • svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.png.
  • svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.png.
  • svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.png.
  • svg/repaint/filter-repaint-expected.txt: Renamed from LayoutTests/platform/efl/svg/repaint/filter-repaint-expected.txt.
  • svg/repaint/image-href-change-expected.png: Renamed from LayoutTests/platform/efl/svg/repaint/image-href-change-expected.png.
  • svg/repaint/inner-svg-change-viewBox-contract-expected.png: Renamed from LayoutTests/platform/efl/svg/repaint/inner-svg-change-viewBox-contract-expected.png.
  • svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Renamed from LayoutTests/platform/efl/svg/repaint/inner-svg-change-viewPort-relative-expected.txt.
  • svg/repaint/text-mask-update-expected.png: Renamed from LayoutTests/platform/efl/svg/repaint/text-mask-update-expected.png.
  • svg/stroke/zero-length-path-linecap-rendering-expected.txt: Renamed from LayoutTests/platform/efl/svg/stroke/zero-length-path-linecap-rendering-expected.txt.
  • svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Renamed from LayoutTests/platform/efl/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt.
  • svg/text/append-text-node-to-tspan-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/append-text-node-to-tspan-expected.txt.
  • svg/text/bidi-embedded-direction-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/bidi-embedded-direction-expected.txt.
  • svg/text/bidi-reorder-value-lists-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/bidi-reorder-value-lists-expected.txt.
  • svg/text/bidi-text-anchor-direction-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/bidi-text-anchor-direction-expected.txt.
  • svg/text/bidi-text-query-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/bidi-text-query-expected.txt.
  • svg/text/bidi-tspans-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/bidi-tspans-expected.txt.
  • svg/text/ems-display-none-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/ems-display-none-expected.txt.
  • svg/text/exs-display-none-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/exs-display-none-expected.txt.
  • svg/text/font-size-below-point-five-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/font-size-below-point-five-expected.txt.
  • svg/text/modify-text-node-in-tspan-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/modify-text-node-in-tspan-expected.txt.
  • svg/text/remove-text-node-from-tspan-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/remove-text-node-from-tspan-expected.txt.
  • svg/text/remove-tspan-from-text-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/remove-tspan-from-text-expected.txt.
  • svg/text/scaled-font-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/scaled-font-expected.txt.
  • svg/text/scaling-font-with-geometric-precision-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/scaling-font-with-geometric-precision-expected.txt.
  • svg/text/select-textLength-spacing-squeeze-1-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-squeeze-1-expected.txt.
  • svg/text/select-textLength-spacing-squeeze-2-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-squeeze-2-expected.txt.
  • svg/text/select-textLength-spacing-squeeze-3-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-squeeze-3-expected.txt.
  • svg/text/select-textLength-spacing-squeeze-4-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-squeeze-4-expected.txt.
  • svg/text/select-textLength-spacing-stretch-1-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-stretch-1-expected.txt.
  • svg/text/select-textLength-spacing-stretch-2-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-stretch-2-expected.txt.
  • svg/text/select-textLength-spacing-stretch-3-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-stretch-3-expected.txt.
  • svg/text/select-textLength-spacing-stretch-4-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-stretch-4-expected.txt.
  • svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt.
  • svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt.
  • svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt.
  • svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt.
  • svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt.
  • svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt.
  • svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt.
  • svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt.
  • svg/text/select-x-list-1-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-1-expected.txt.
  • svg/text/select-x-list-2-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-2-expected.txt.
  • svg/text/select-x-list-3-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-3-expected.txt.
  • svg/text/select-x-list-4-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-4-expected.txt.
  • svg/text/select-x-list-with-tspans-1-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-with-tspans-1-expected.txt.
  • svg/text/select-x-list-with-tspans-2-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-with-tspans-2-expected.txt.
  • svg/text/select-x-list-with-tspans-3-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-with-tspans-3-expected.txt.
  • svg/text/select-x-list-with-tspans-4-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-with-tspans-4-expected.txt.
  • svg/text/selection-doubleclick-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/selection-doubleclick-expected.txt.
  • svg/text/selection-tripleclick-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/selection-tripleclick-expected.txt.
  • svg/text/small-fonts-2-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/small-fonts-2-expected.txt.
  • svg/text/small-fonts-3-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/small-fonts-3-expected.txt.
  • svg/text/small-fonts-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/small-fonts-expected.txt.
  • svg/text/text-align-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-align-01-b-expected.txt.
  • svg/text/text-align-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-align-02-b-expected.txt.
  • svg/text/text-align-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-align-03-b-expected.txt.
  • svg/text/text-align-04-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-align-04-b-expected.txt.
  • svg/text/text-align-05-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-align-05-b-expected.txt.
  • svg/text/text-align-06-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-align-06-b-expected.txt.
  • svg/text/text-altglyph-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-altglyph-01-b-expected.txt.
  • svg/text/text-deco-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-deco-01-b-expected.txt.
  • svg/text/text-fill-opacity-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-fill-opacity-expected.txt.
  • svg/text/text-fonts-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-fonts-01-t-expected.txt.
  • svg/text/text-fonts-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-fonts-02-t-expected.txt.
  • svg/text/text-gradient-positioning-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-gradient-positioning-expected.txt.
  • svg/text/text-intro-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-intro-05-t-expected.txt.
  • svg/text/text-midpoint-split-bug-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-midpoint-split-bug-expected.txt.
  • svg/text/text-path-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-path-01-b-expected.txt.
  • svg/text/text-path-middle-align-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-path-middle-align-expected.txt.
  • svg/text/text-spacing-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-spacing-01-b-expected.txt.
  • svg/text/text-text-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-text-01-b-expected.txt.
  • svg/text/text-text-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-text-03-b-expected.txt.
  • svg/text/text-text-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-text-04-t-expected.txt.
  • svg/text/text-text-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-text-05-t-expected.txt.
  • svg/text/text-text-06-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-text-06-t-expected.txt.
  • svg/text/text-text-07-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-text-07-t-expected.txt.
  • svg/text/text-text-08-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-text-08-b-expected.txt.
  • svg/text/text-tref-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-tref-01-b-expected.txt.
  • svg/text/text-tselect-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-tselect-01-b-expected.txt.
  • svg/text/text-tselect-02-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-tselect-02-f-expected.txt.
  • svg/text/text-tspan-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-tspan-01-b-expected.txt.
  • svg/text/text-ws-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-ws-01-t-expected.txt.
  • svg/text/text-ws-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-ws-02-t-expected.txt.
  • svg/text/tspan-dynamic-positioning-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/tspan-dynamic-positioning-expected.txt.
  • svg/transforms/text-with-mask-with-svg-transform-expected.txt: Renamed from LayoutTests/platform/efl/svg/transforms/text-with-mask-with-svg-transform-expected.txt.
  • svg/transforms/text-with-pattern-with-svg-transform-expected.txt: Renamed from LayoutTests/platform/efl/svg/transforms/text-with-pattern-with-svg-transform-expected.txt.
  • svg/wicd/sizing-flakiness-expected.txt:

Nov 9, 2013:

11:28 PM Changeset in webkit [159018] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

CSSValuePool::createFontFamilyValue() should return PassRef.
<https://webkit.org/b/124114>

Unlike createFontFaceValue(), createFontFamilyValue() can never
fail to return an object and thus should return PassRef.

Reviewed by Anders Carlsson.

11:26 PM Changeset in webkit [159017] by akling@apple.com
  • 371 edits in trunk

RenderIFrame should display its name correctly in DRT output.
<https://webkit.org/b/124117>

Source/WebCore:

Nuke an age-old FIXME about making RenderIFrame show its true name
in DRT output. No more "RenderPartObject {IFRAME}"!

Reviewed by Anders Carlsson.

LayoutTests:

Rebaseline results now that RenderIFrame correctly dumps its name
as "RenderIFrame".

Reviewed by Anders Carlsson.

  • compositing/iframes/composited-iframe-scroll-expected.txt:
  • compositing/iframes/iframe-content-flipping-expected.txt:
  • compositing/iframes/nested-iframe-scrolling-expected.txt:
  • fast/css/replaced-element-implicit-size-expected.txt:
  • fast/css/resize-corner-tracking-expected.txt:
  • fast/dom/attr_dead_doc-expected.txt:
  • fast/frames/content-opacity-1-expected.txt:
  • fast/frames/content-opacity-2-expected.txt:
  • fast/frames/iframe-scaling-with-scroll-expected.txt:
  • fast/frames/iframe-text-contents-expected.txt:
  • fast/frames/paint-iframe-background-expected.txt:
  • fast/repaint/4774354-expected.txt:
  • fast/repaint/iframe-scroll-repaint-expected.txt:
  • fast/repaint/repaint-during-scroll-with-zoom-expected.txt:
  • fast/replaced/percent-height-in-anonymous-block-expected.txt:
  • http/tests/misc/acid3-expected.txt:
  • media/media-document-audio-repaint-expected.txt:
  • platform/efl/compositing/iframes/composited-iframe-alignment-expected.txt:
  • platform/efl/compositing/iframes/iframe-copy-on-scroll-expected.txt:
  • platform/efl/compositing/iframes/iframe-in-composited-layer-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-004-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-005-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-007-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-011-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-012-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-014-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-018-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-019-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-021-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-025-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-026-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-028-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-032-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-033-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-035-expected.txt:
  • platform/efl/css2.1/20110323/block-replaced-height-004-expected.txt:
  • platform/efl/css2.1/20110323/block-replaced-height-005-expected.txt:
  • platform/efl/css2.1/20110323/block-replaced-height-007-expected.txt:
  • platform/efl/css2.1/20110323/float-replaced-height-004-expected.txt:
  • platform/efl/css2.1/20110323/float-replaced-height-005-expected.txt:
  • platform/efl/css2.1/20110323/float-replaced-height-007-expected.txt:
  • platform/efl/css2.1/20110323/inline-block-replaced-height-004-expected.txt:
  • platform/efl/css2.1/20110323/inline-block-replaced-height-005-expected.txt:
  • platform/efl/css2.1/20110323/inline-block-replaced-height-007-expected.txt:
  • platform/efl/css2.1/20110323/inline-replaced-height-004-expected.txt:
  • platform/efl/css2.1/20110323/inline-replaced-height-005-expected.txt:
  • platform/efl/css2.1/20110323/inline-replaced-height-007-expected.txt:
  • platform/efl/editing/pasteboard/4631972-expected.txt:
  • platform/efl/editing/selection/4776665-expected.txt:
  • platform/efl/editing/selection/4960137-expected.txt:
  • platform/efl/editing/selection/4975120-expected.txt:
  • platform/efl/editing/selection/drag-in-iframe-expected.txt:
  • platform/efl/editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • platform/efl/editing/selection/iframe-expected.txt:
  • platform/efl/editing/selection/select-all-iframe-expected.txt:
  • platform/efl/fast/block/basic/013-expected.txt:
  • platform/efl/fast/block/positioning/window-height-change-expected.txt:
  • platform/efl/fast/css/line-height-overflow-expected.txt:
  • platform/efl/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt:
  • platform/efl/fast/dom/Window/open-existing-pop-up-blocking-expected.txt:
  • platform/efl/fast/flexbox/016-expected.txt:
  • platform/efl/fast/forms/basic-textareas-expected.txt:
  • platform/efl/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/efl/fast/forms/targeted-frame-submission-expected.txt:
  • platform/efl/fast/frames/001-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-nested-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-offscreen-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-simple-expected.txt:
  • platform/efl/fast/frames/frameElement-iframe-expected.txt:
  • platform/efl/fast/frames/iframe-option-crash-expected.txt:
  • platform/efl/fast/frames/iframe-scrolling-attribute-expected.txt:
  • platform/efl/fast/frames/iframe-with-frameborder-expected.txt:
  • platform/efl/fast/frames/onlyCommentInIFrame-expected.txt:
  • platform/efl/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/efl/fast/frames/viewsource-attribute-expected.txt:
  • platform/efl/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/efl/fast/images/favicon-as-image-expected.txt:
  • platform/efl/fast/overflow/scrollRevealButton-expected.txt:
  • platform/efl/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-1-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-10-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-2-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-3-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-4-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-5-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-6-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-7-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-8-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-9-expected.txt:
  • platform/efl/fast/repaint/text-selection-rect-in-overflow-2-expected.txt:
  • platform/efl/fast/replaced/007-expected.txt:
  • platform/efl/fast/replaced/border-radius-clip-expected.txt:
  • platform/efl/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
  • platform/efl/fast/replaced/replaced-breaking-expected.txt:
  • platform/efl/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt:
  • platform/efl/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.txt:
  • platform/efl/fast/table/quote-text-around-iframe-expected.txt:
  • platform/efl/fast/text/selection-hard-linebreak-expected.txt:
  • platform/efl/http/tests/loading/simple-subframe-expected.txt:
  • platform/efl/http/tests/local/file-url-sent-as-referer-expected.txt:
  • platform/efl/http/tests/misc/acid3-expected.txt:
  • platform/efl/http/tests/misc/favicon-as-image-expected.txt:
  • platform/efl/http/tests/misc/frame-access-during-load-expected.txt:
  • platform/efl/http/tests/misc/iframe404-expected.txt:
  • platform/efl/http/tests/misc/location-replace-crossdomain-expected.txt:
  • platform/efl/http/tests/multipart/invalid-image-data-standalone-expected.txt:
  • platform/efl/media/media-document-audio-repaint-expected.txt:
  • platform/efl/svg/hixie/rendering-model/003-expected.txt:
  • platform/efl/svg/in-html/by-reference-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug131020-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug38916-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/gtk-wk1/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt:
  • platform/gtk-wk1/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-004-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-005-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-007-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-011-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-012-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-014-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-018-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-019-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-021-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-025-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-026-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-028-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-032-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-033-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-035-expected.txt:
  • platform/gtk/css2.1/20110323/block-replaced-height-004-expected.txt:
  • platform/gtk/css2.1/20110323/block-replaced-height-005-expected.txt:
  • platform/gtk/css2.1/20110323/block-replaced-height-007-expected.txt:
  • platform/gtk/css2.1/20110323/float-replaced-height-004-expected.txt:
  • platform/gtk/css2.1/20110323/float-replaced-height-005-expected.txt:
  • platform/gtk/css2.1/20110323/float-replaced-height-007-expected.txt:
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-004-expected.txt:
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-005-expected.txt:
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-007-expected.txt:
  • platform/gtk/css2.1/20110323/inline-replaced-height-004-expected.txt:
  • platform/gtk/css2.1/20110323/inline-replaced-height-005-expected.txt:
  • platform/gtk/css2.1/20110323/inline-replaced-height-007-expected.txt:
  • platform/gtk/editing/execCommand/find-after-replace-expected.txt:
  • platform/gtk/editing/execCommand/paste-1-expected.txt:
  • platform/gtk/editing/pasteboard/4631972-expected.txt:
  • platform/gtk/editing/pasteboard/copy-standalone-image-expected.txt:
  • platform/gtk/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
  • platform/gtk/editing/pasteboard/paste-2-expected.txt:
  • platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
  • platform/gtk/editing/selection/4776665-expected.txt:
  • platform/gtk/editing/selection/4960137-expected.txt:
  • platform/gtk/editing/selection/4975120-expected.txt:
  • platform/gtk/editing/selection/drag-in-iframe-expected.txt:
  • platform/gtk/editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • platform/gtk/editing/selection/iframe-expected.txt:
  • platform/gtk/editing/selection/select-all-iframe-expected.txt:
  • platform/gtk/fast/block/basic/013-expected.txt:
  • platform/gtk/fast/block/positioning/window-height-change-expected.txt:
  • platform/gtk/fast/css/line-height-overflow-expected.txt:
  • platform/gtk/fast/css/resize-corner-tracking-expected.txt:
  • platform/gtk/fast/css/resize-corner-tracking-transformed-iframe-expected.txt:
  • platform/gtk/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt:
  • platform/gtk/fast/dom/Window/open-existing-pop-up-blocking-expected.txt:
  • platform/gtk/fast/flexbox/016-expected.txt:
  • platform/gtk/fast/forms/basic-textareas-expected.txt:
  • platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/gtk/fast/forms/targeted-frame-submission-expected.txt:
  • platform/gtk/fast/frames/001-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-nested-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-offscreen-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-simple-expected.txt:
  • platform/gtk/fast/frames/frameElement-iframe-expected.txt:
  • platform/gtk/fast/frames/iframe-option-crash-expected.txt:
  • platform/gtk/fast/frames/iframe-scrolling-attribute-expected.txt:
  • platform/gtk/fast/frames/iframe-with-frameborder-expected.txt:
  • platform/gtk/fast/frames/onlyCommentInIFrame-expected.txt:
  • platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/gtk/fast/frames/viewsource-attribute-expected.txt:
  • platform/gtk/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/gtk/fast/images/favicon-as-image-expected.txt:
  • platform/gtk/fast/overflow/scrollRevealButton-expected.txt:
  • platform/gtk/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
  • platform/gtk/fast/repaint/iframe-scroll-repaint-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-1-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-10-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-2-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-3-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-4-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-5-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-6-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-7-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-8-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-9-expected.txt:
  • platform/gtk/fast/repaint/text-selection-rect-in-overflow-2-expected.txt:
  • platform/gtk/fast/replaced/007-expected.txt:
  • platform/gtk/fast/replaced/border-radius-clip-expected.txt:
  • platform/gtk/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-expected.txt:
  • platform/gtk/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt:
  • platform/gtk/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.txt:
  • platform/gtk/fast/table/quote-text-around-iframe-expected.txt:
  • platform/gtk/fast/text/selection-hard-linebreak-expected.txt:
  • platform/gtk/http/tests/loading/simple-subframe-expected.txt:
  • platform/gtk/http/tests/local/file-url-sent-as-referer-expected.txt:
  • platform/gtk/http/tests/misc/favicon-as-image-expected.txt:
  • platform/gtk/http/tests/misc/frame-access-during-load-expected.txt:
  • platform/gtk/http/tests/misc/iframe404-expected.txt:
  • platform/gtk/http/tests/misc/location-replace-crossdomain-expected.txt:
  • platform/gtk/http/tests/multipart/invalid-image-data-standalone-expected.txt:
  • platform/gtk/media/media-document-audio-repaint-expected.txt:
  • platform/gtk/plugins/iframe-plugin-bgcolor-expected.txt:
  • platform/gtk/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt:
  • platform/gtk/svg/custom/embedding-external-svgs-expected.txt:
  • platform/gtk/svg/hixie/rendering-model/003-expected.txt:
  • platform/gtk/svg/in-html/by-reference-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug131020-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug38916-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/iphone-simulator/text-autosizing/contenteditable-expected.txt:
  • platform/mac-mountainlion/editing/selection/4975120-expected.txt:
  • platform/mac-mountainlion/fast/forms/basic-textareas-expected.txt:
  • platform/mac-mountainlion/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/mac-mountainlion/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/mac-mountainlion/fast/replaced/replaced-breaking-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac-wk2/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
  • platform/mac/compositing/iframes/composited-iframe-alignment-expected.txt:
  • platform/mac/compositing/iframes/iframe-copy-on-scroll-expected.txt:
  • platform/mac/compositing/iframes/iframe-in-composited-layer-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-004-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-005-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-007-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-011-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-012-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-014-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-018-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-019-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-021-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-025-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-026-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-028-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-032-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-033-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-035-expected.txt:
  • platform/mac/css2.1/20110323/block-replaced-height-004-expected.txt:
  • platform/mac/css2.1/20110323/block-replaced-height-005-expected.txt:
  • platform/mac/css2.1/20110323/block-replaced-height-007-expected.txt:
  • platform/mac/css2.1/20110323/float-replaced-height-004-expected.txt:
  • platform/mac/css2.1/20110323/float-replaced-height-005-expected.txt:
  • platform/mac/css2.1/20110323/float-replaced-height-007-expected.txt:
  • platform/mac/css2.1/20110323/inline-block-replaced-height-004-expected.txt:
  • platform/mac/css2.1/20110323/inline-block-replaced-height-005-expected.txt:
  • platform/mac/css2.1/20110323/inline-block-replaced-height-007-expected.txt:
  • platform/mac/css2.1/20110323/inline-replaced-height-004-expected.txt:
  • platform/mac/css2.1/20110323/inline-replaced-height-005-expected.txt:
  • platform/mac/css2.1/20110323/inline-replaced-height-007-expected.txt:
  • platform/mac/editing/execCommand/find-after-replace-expected.txt:
  • platform/mac/editing/execCommand/paste-1-expected.txt:
  • platform/mac/editing/pasteboard/4631972-expected.txt:
  • platform/mac/editing/pasteboard/copy-standalone-image-expected.txt:
  • platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
  • platform/mac/editing/pasteboard/paste-2-expected.txt:
  • platform/mac/editing/pasteboard/subframe-dragndrop-1-expected.txt:
  • platform/mac/editing/selection/4776665-expected.txt:
  • platform/mac/editing/selection/4960137-expected.txt:
  • platform/mac/editing/selection/4975120-expected.txt:
  • platform/mac/editing/selection/drag-in-iframe-expected.txt:
  • platform/mac/editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • platform/mac/editing/selection/iframe-expected.txt:
  • platform/mac/editing/selection/select-all-iframe-expected.txt:
  • platform/mac/fast/block/basic/013-expected.txt:
  • platform/mac/fast/block/positioning/window-height-change-expected.txt:
  • platform/mac/fast/css/line-height-overflow-expected.txt:
  • platform/mac/fast/css/resize-corner-tracking-transformed-iframe-expected.txt:
  • platform/mac/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt:
  • platform/mac/fast/dom/Window/open-existing-pop-up-blocking-expected.txt:
  • platform/mac/fast/flexbox/016-expected.txt:
  • platform/mac/fast/forms/basic-textareas-expected.txt:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/mac/fast/forms/targeted-frame-submission-expected.txt:
  • platform/mac/fast/frames/001-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-nested-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-offscreen-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.txt:
  • platform/mac/fast/frames/frameElement-iframe-expected.txt:
  • platform/mac/fast/frames/iframe-option-crash-expected.txt:
  • platform/mac/fast/frames/iframe-scrolling-attribute-expected.txt:
  • platform/mac/fast/frames/iframe-with-frameborder-expected.txt:
  • platform/mac/fast/frames/onlyCommentInIFrame-expected.txt:
  • platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/mac/fast/frames/viewsource-attribute-expected.txt:
  • platform/mac/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/mac/fast/images/favicon-as-image-expected.txt:
  • platform/mac/fast/overflow/scrollRevealButton-expected.txt:
  • platform/mac/fast/repaint/4774354-expected.txt:
  • platform/mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-1-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-10-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-2-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-3-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-4-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-5-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-6-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-7-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-8-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-9-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
  • platform/mac/fast/repaint/repaint-during-scroll-with-zoom-expected.txt:
  • platform/mac/fast/repaint/text-selection-rect-in-overflow-2-expected.txt:
  • platform/mac/fast/replaced/007-expected.txt:
  • platform/mac/fast/replaced/border-radius-clip-expected.txt:
  • platform/mac/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-expected.txt:
  • platform/mac/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt:
  • platform/mac/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.txt:
  • platform/mac/fast/table/quote-text-around-iframe-expected.txt:
  • platform/mac/fast/text/selection-hard-linebreak-expected.txt:
  • platform/mac/http/tests/loading/simple-subframe-expected.txt:
  • platform/mac/http/tests/local/file-url-sent-as-referer-expected.txt:
  • platform/mac/http/tests/misc/acid3-expected.txt:
  • platform/mac/http/tests/misc/favicon-as-image-expected.txt:
  • platform/mac/http/tests/misc/frame-access-during-load-expected.txt:
  • platform/mac/http/tests/misc/iframe404-expected.txt:
  • platform/mac/http/tests/misc/location-replace-crossdomain-expected.txt:
  • platform/mac/http/tests/multipart/invalid-image-data-standalone-expected.txt:
  • platform/mac/plugins/update-widget-from-style-recalc-expected.txt:
  • platform/mac/plugins/update-widget-from-style-recalc.html:
  • platform/mac/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt:
  • platform/mac/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt:
  • platform/mac/svg/custom/embedding-external-svgs-expected.txt:
  • platform/mac/svg/hixie/rendering-model/003-expected.txt:
  • platform/mac/svg/in-html/by-reference-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug131020-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug38916-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac/webarchive/loading/cache-expired-subresource-expected.txt:
  • platform/win-xp/media/media-document-audio-repaint-expected.txt:
  • platform/win/http/tests/misc/acid3-expected.txt:
  • plugins/iframe-plugin-bgcolor-expected.txt:
  • printing/iframe-print-expected.txt:
  • scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt:
  • scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt:
  • svg/as-object/svg-embedded-in-html-in-iframe-expected.txt:
  • tables/mozilla/bugs/bug137388-1-expected.txt:
  • tables/mozilla/bugs/bug137388-2-expected.txt:
  • tables/mozilla/bugs/bug137388-3-expected.txt:
  • tables/mozilla/bugs/bug50695-2-expected.txt:
10:49 PM Changeset in webkit [159016] by mitz@apple.com
  • 6 edits
    2 adds in trunk/Source/WebKit2

Use createCFURLFromBuffer when converting a String to a CFURL
https://bugs.webkit.org/show_bug.cgi?id=124113

Reviewed by Anders Carlsson.

  • Shared/API/c/cf/WKURLCF.mm:

(WKURLCopyCFURL): Replaced some code with a call to createCFURLFromBuffer(), which does the
same thing.

  • Shared/Cocoa/WKNSURLExtras.h: Added.
  • Shared/Cocoa/WKNSURLExtras.mm: Added.

(+[NSURL _web_URLWithWTFString:relativeToURL:]): Added. Returns nil for the null String,
otherwise returns the result of createCFURLFromBuffer().

  • UIProcess/API/Cocoa/WKBackForwardListItem.mm:

(-[WKBackForwardListItem URL]): Changed to use +_web_URLWithWTFString:relativeToURL:.
(-[WKBackForwardListItem originalURL]): Ditto.

  • UIProcess/API/Cocoa/WKNavigationData.mm:

(-[WKNavigationData destinationURL]): Ditto.

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController unreachableURL]): Ditto.

  • WebKit2.xcodeproj/project.pbxproj: Added references to new files.
10:45 PM Changeset in webkit [159015] by akling@apple.com
  • 3 edits
    2 copies
    9 moves
    1 add
    13 deletes in trunk/LayoutTests

Optimize baselines: svg/W3C-SVG-1.1-SE

Unreviewed; run "webkit-patch optimize-baselines svg/W3C-SVG-1.1-SE"

  • platform/efl/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Removed.
  • platform/win-future/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Copied from LayoutTests/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt.
  • platform/win-future/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Copied from LayoutTests/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt.
  • svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt.
  • svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt.
  • svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt.
  • svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
  • svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt.
  • svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt.
  • svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt.
  • svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt.
  • svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt.
  • svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt.
  • svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
10:42 PM Changeset in webkit [159014] by akling@apple.com
  • 1 edit
    9 moves
    9 deletes in trunk/LayoutTests

Optimize baselines: svg/carto.net

Unreviewed; run "webkit-patch optimize-baselines svg/carto.net"

  • platform/gtk/svg/carto.net/button-expected.txt: Removed.
  • platform/gtk/svg/carto.net/colourpicker-expected.txt: Removed.
  • platform/gtk/svg/carto.net/combobox-expected.txt: Removed.
  • platform/gtk/svg/carto.net/scrollbar-expected.txt: Removed.
  • platform/gtk/svg/carto.net/selectionlist-expected.txt: Removed.
  • platform/gtk/svg/carto.net/slider-expected.txt: Removed.
  • platform/gtk/svg/carto.net/tabgroup-expected.txt: Removed.
  • platform/gtk/svg/carto.net/textbox-expected.txt: Removed.
  • platform/gtk/svg/carto.net/window-expected.txt: Removed.
  • svg/carto.net/button-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/button-expected.txt.
  • svg/carto.net/colourpicker-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/colourpicker-expected.txt.
  • svg/carto.net/combobox-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/combobox-expected.txt.
  • svg/carto.net/scrollbar-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/scrollbar-expected.txt.
  • svg/carto.net/selectionlist-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/selectionlist-expected.txt.
  • svg/carto.net/slider-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/slider-expected.txt.
  • svg/carto.net/tabgroup-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/tabgroup-expected.txt.
  • svg/carto.net/textbox-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/textbox-expected.txt.
  • svg/carto.net/window-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/window-expected.txt.
10:39 PM Changeset in webkit [159013] by akling@apple.com
  • 1 edit
    10 moves
    10 deletes in trunk/LayoutTests

Optimize baselines: svg/css

Unreviewed; run "webkit-patch optimize-baselines svg/css"

  • platform/gtk/svg/css/circle-in-mask-with-shadow-expected.png: Removed.
  • platform/gtk/svg/css/clippath-with-shadow-expected.png: Removed.
  • platform/gtk/svg/css/group-with-shadow-expected.txt: Removed.
  • platform/gtk/svg/css/path-with-shadow-expected.png: Removed.
  • platform/gtk/svg/css/shadow-with-large-radius-expected.png: Removed.
  • platform/gtk/svg/css/shadow-with-negative-offset-expected.png: Removed.
  • platform/gtk/svg/css/stars-with-shadow-expected.txt: Removed.
  • platform/gtk/svg/css/text-gradient-shadow-expected.txt: Removed.
  • platform/mac/svg/css/composite-shadow-example-expected.txt: Removed.
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
  • svg/css/circle-in-mask-with-shadow-expected.png: Renamed from LayoutTests/platform/efl-wk1/svg/css/circle-in-mask-with-shadow-expected.png.
  • svg/css/clippath-with-shadow-expected.png: Renamed from LayoutTests/platform/efl/svg/css/clippath-with-shadow-expected.png.
  • svg/css/composite-shadow-example-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/composite-shadow-example-expected.txt.
  • svg/css/composite-shadow-with-opacity-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/composite-shadow-with-opacity-expected.txt.
  • svg/css/group-with-shadow-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/group-with-shadow-expected.txt.
  • svg/css/path-with-shadow-expected.png: Renamed from LayoutTests/platform/efl-wk1/svg/css/path-with-shadow-expected.png.
  • svg/css/shadow-with-large-radius-expected.png: Renamed from LayoutTests/platform/efl-wk1/svg/css/shadow-with-large-radius-expected.png.
  • svg/css/shadow-with-negative-offset-expected.png: Renamed from LayoutTests/platform/efl-wk1/svg/css/shadow-with-negative-offset-expected.png.
  • svg/css/stars-with-shadow-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/stars-with-shadow-expected.txt.
  • svg/css/text-gradient-shadow-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/text-gradient-shadow-expected.txt.
10:37 PM Changeset in webkit [159012] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

SVGTextMetricsBuilder::walkTree() should take a RenderElement.
<https://webkit.org/b/124105>

Make walkTree() take a RenderElement so we can use the non-virtual
firstChild() internally. All call sites had pointers to compatible
objects already.

Reviewed by Anders Carlsson.

9:48 PM Changeset in webkit [159011] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

RenderMathMLFenced should pass around operators in tighter types.
<https://webkit.org/b/124115>

Store operator renderers in RenderMathMLOperator pointers instead
of passing them around as RenderObject.

Reviewed by Martin Robinson.

9:47 PM Changeset in webkit [159010] by akling@apple.com
  • 6 edits in trunk/Source/WebCore

Use RENDER_OBJECT_TYPE_CASTS for more types.
<https://webkit.org/b/124112>

Generate toRenderFoo() type casting helpers for these classes:

  • RenderCombineText
  • RenderDetailsMarker
  • RenderListMarker
  • RenderVideo
  • RenderView

Reviewed by Anders Carlsson.

9:08 PM Changeset in webkit [159009] by akling@apple.com
  • 13 edits in trunk/Source/WebCore

Move MathML type checking virtuals to RenderObject.
<https://webkit.org/b/124111>

Previously, checking the type of a MathML renderer would require
that you first check if it's a RenderMathMLBlock, and then casting
to that type to access the check you really wanted.

This change moves all the isRenderMathMLFoo() virtual functions
to RenderObject. I also made sure all the overloads were private
and marked them OVERRIDE/FINAL as appropriate.

Finally I replaced all the hand-written casting functions with
autogenerated ones using RENDER_OBJECT_TYPE_CASTS.

Reviewed by Anders Carlsson.

8:20 PM Changeset in webkit [159008] by oliver@apple.com
  • 12 edits
    3 moves
    6 adds in trunk

Add Map Iterators
https://bugs.webkit.org/show_bug.cgi?id=124109

Reviewed by Andreas Kling.

Source/JavaScriptCore:

Added new Map iterator implementation. This is a mostly boilerplate patch
however there's a a little bit of additional logic added to the MapData iterator
to deal with the possibility of map mutation between creation of the iterator
and use of it. We'll be able to improve the performance of this substantially
by using intrinsics, however I'm pondering coming up with a better way to define
these thunks without requiring so much duplicated logic.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/CommonIdentifiers.h:
  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h:
  • runtime/JSMapIterator.cpp: Added.

(JSC::JSMapIterator::finishCreation):
(JSC::JSMapIterator::visitChildren):
(JSC::JSMapIterator::createPair):

  • runtime/JSMapIterator.h: Added.

(JSC::JSMapIterator::createStructure):
(JSC::JSMapIterator::create):
(JSC::JSMapIterator::next):
(JSC::JSMapIterator::JSMapIterator):

  • runtime/MapData.h:

(JSC::MapData::const_iterator::ensureSlot):

  • runtime/MapIteratorConstructor.cpp: Added.

(JSC::MapIteratorConstructor::finishCreation):

  • runtime/MapIteratorConstructor.h: Added.

(JSC::MapIteratorConstructor::create):
(JSC::MapIteratorConstructor::createStructure):
(JSC::MapIteratorConstructor::MapIteratorConstructor):

  • runtime/MapIteratorPrototype.cpp: Added.

(JSC::MapIteratorPrototype::finishCreation):
(JSC::MapIteratorPrototypeFuncIterator):
(JSC::MapIteratorPrototypeFuncNext):

  • runtime/MapIteratorPrototype.h: Added.

(JSC::MapIteratorPrototype::create):
(JSC::MapIteratorPrototype::createStructure):
(JSC::MapIteratorPrototype::MapIteratorPrototype):

  • runtime/MapPrototype.cpp:

(JSC::MapPrototype::finishCreation):
(JSC::mapProtoFuncValues):
(JSC::mapProtoFuncEntries):
(JSC::mapProtoFuncKeys):

LayoutTests:

Moved map tests to a more sensible location, and added new iteration tests.

  • js/basic-map-expected.txt: Renamed from LayoutTests/js/dom/basic-map-expected.txt.
  • js/basic-map.html: Renamed from LayoutTests/js/dom/basic-map.html.
  • js/script-tests/basic-map.js: Renamed from LayoutTests/js/dom/script-tests/basic-map.js.

(set shouldBe):
(set var):

7:39 PM Changeset in webkit [159007] by Martin Robinson
  • 7 edits in trunk

[MathML] Poor spacing around delimiters in MathML Torture Test 14
https://bugs.webkit.org/show_bug.cgi?id=122837

Reviewed by Brent Fulgham.

Instead of stretching the vertical bar with the stretchable version, just repeat
the normal vertical bar. This follows what Gecko does when rendering tall vertical
bars and also works around an issue with STIX fonts leading to poor spacing in
formulas.

Source/WebCore:

  • rendering/mathml/RenderMathMLOperator.cpp: Stretch the vertical bar with the

normal variant.

LayoutTests:

  • platform/gtk/mathml/presentation/mo-stretch-expected.png: Update to reflect new results.
  • platform/gtk/mathml/presentation/mo-stretch-expected.txt: Ditto.
  • platform/mac/mathml/presentation/mo-stretch-expected.png: Ditto.
  • platform/mac/mathml/presentation/mo-stretch-expected.txt: Ditto.
7:36 PM Changeset in webkit [159006] by akling@apple.com
  • 2 edits
    1 copy
    20 moves
    1 add
    22 deletes in trunk/LayoutTests

Optimize baselines: svg/clip-path

Unreviewed; run "webkit-patch optimize-baselines svg/clip-path"

  • platform/efl/svg/clip-path/clip-path-pixelation-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-in-clip-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-clipped-no-content-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-pixelation-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-recursive-call-by-child-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-recursive-call-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-text-and-shape-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-text-and-stroke-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-text-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-use-as-child2-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-use-as-child3-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-use-as-child4-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-use-as-child5-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-with-container-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-with-different-unittypes-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-with-different-unittypes2-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-with-invisibile-child-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-with-text-clipped-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clipper-placement-issue-expected.png: Removed.
  • platform/gtk/svg/clip-path/deep-nested-clip-in-mask-expected.txt: Removed.
  • platform/gtk/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Removed.
  • platform/win-future/svg/clip-path/clip-path-pixelation-expected.txt: Copied from LayoutTests/svg/clip-path/clip-path-pixelation-expected.txt.
  • svg/clip-path/clip-in-clip-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-in-clip-expected.png.
  • svg/clip-path/clip-path-clipped-no-content-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-clipped-no-content-expected.png.
  • svg/clip-path/clip-path-pixelation-expected.txt:
  • svg/clip-path/clip-path-recursive-call-by-child-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-recursive-call-by-child-expected.png.
  • svg/clip-path/clip-path-recursive-call-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-recursive-call-expected.png.
  • svg/clip-path/clip-path-text-and-shape-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-text-and-shape-expected.txt.
  • svg/clip-path/clip-path-text-and-stroke-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-text-and-stroke-expected.txt.
  • svg/clip-path/clip-path-text-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-text-expected.txt.
  • svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-tspan-and-stroke-expected.txt.
  • svg/clip-path/clip-path-use-as-child2-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-use-as-child2-expected.png.
  • svg/clip-path/clip-path-use-as-child3-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-use-as-child3-expected.png.
  • svg/clip-path/clip-path-use-as-child4-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-use-as-child4-expected.png.
  • svg/clip-path/clip-path-use-as-child5-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-use-as-child5-expected.png.
  • svg/clip-path/clip-path-with-container-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-container-expected.png.
  • svg/clip-path/clip-path-with-different-unittypes-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-different-unittypes-expected.png.
  • svg/clip-path/clip-path-with-different-unittypes2-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-different-unittypes2-expected.png.
  • svg/clip-path/clip-path-with-invisibile-child-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-invisibile-child-expected.png.
  • svg/clip-path/clip-path-with-text-clipped-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-text-clipped-expected.txt.
  • svg/clip-path/clipper-placement-issue-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clipper-placement-issue-expected.png.
  • svg/clip-path/deep-nested-clip-in-mask-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/deep-nested-clip-in-mask-expected.txt.
  • svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt.
7:32 PM Changeset in webkit [159005] by akling@apple.com
  • 2 edits
    5 copies
    48 moves
    2 adds
    57 deletes in trunk/LayoutTests

Optimize baselines: svg/hixie

Unreviewed; run "webkit-patch optimize-baselines svg/hixie"

  • platform/efl/svg/hixie/perf/007-expected.txt: Removed.
  • platform/gtk/svg/hixie/dynamic/002-expected.png: Removed.
  • platform/gtk/svg/hixie/dynamic/003-expected.png: Removed.
  • platform/gtk/svg/hixie/dynamic/004-expected.png: Removed.
  • platform/gtk/svg/hixie/dynamic/005-expected.png: Removed.
  • platform/gtk/svg/hixie/dynamic/006-expected.png: Removed.
  • platform/gtk/svg/hixie/error/001-expected.png: Removed.
  • platform/gtk/svg/hixie/error/002-expected.png: Removed.
  • platform/gtk/svg/hixie/error/002-expected.txt: Removed.
  • platform/gtk/svg/hixie/error/003-expected.txt: Removed.
  • platform/gtk/svg/hixie/error/006-expected.png: Removed.
  • platform/gtk/svg/hixie/error/007-expected.png: Removed.
  • platform/gtk/svg/hixie/error/008-expected.png: Removed.
  • platform/gtk/svg/hixie/error/009-expected.png: Removed.
  • platform/gtk/svg/hixie/error/010-expected.png: Removed.
  • platform/gtk/svg/hixie/error/010-expected.txt: Removed.
  • platform/gtk/svg/hixie/error/011-expected.png: Removed.
  • platform/gtk/svg/hixie/error/011-expected.txt: Removed.
  • platform/gtk/svg/hixie/error/014-expected.png: Removed.
  • platform/gtk/svg/hixie/error/014-test-expected.png: Removed.
  • platform/gtk/svg/hixie/error/015-expected.png: Removed.
  • platform/gtk/svg/hixie/error/016-expected.png: Removed.
  • platform/gtk/svg/hixie/error/017-expected.txt: Removed.
  • platform/gtk/svg/hixie/intrinsic/001-expected.png: Removed.
  • platform/gtk/svg/hixie/intrinsic/001-expected.txt: Removed.
  • platform/gtk/svg/hixie/intrinsic/002-expected.png: Removed.
  • platform/gtk/svg/hixie/intrinsic/002-expected.txt: Removed.
  • platform/gtk/svg/hixie/links/002-expected.png: Removed.
  • platform/gtk/svg/hixie/links/002-expected.txt: Removed.
  • platform/gtk/svg/hixie/mixed/007-expected.png: Removed.
  • platform/gtk/svg/hixie/painting/001-expected.png: Removed.
  • platform/gtk/svg/hixie/perf/001-expected.txt: Removed.
  • platform/gtk/svg/hixie/perf/002-expected.txt: Removed.
  • platform/gtk/svg/hixie/perf/003-expected.txt: Removed.
  • platform/gtk/svg/hixie/perf/004-expected.txt: Removed.
  • platform/gtk/svg/hixie/perf/005-expected.txt: Removed.
  • platform/gtk/svg/hixie/perf/006-expected.txt: Removed.
  • platform/gtk/svg/hixie/perf/007-expected.txt: Removed.
  • platform/gtk/svg/hixie/processing-model/003-expected.png: Removed.
  • platform/gtk/svg/hixie/processing-model/004-expected.png: Removed.
  • platform/gtk/svg/hixie/processing-model/005-expected.png: Removed.
  • platform/gtk/svg/hixie/rendering-model/003a-expected.png: Removed.
  • platform/gtk/svg/hixie/shapes/path/001-expected.txt: Removed.
  • platform/gtk/svg/hixie/text/002-expected.txt: Removed.
  • platform/gtk/svg/hixie/text/003a-expected.txt: Removed.
  • platform/gtk/svg/hixie/text/003b-expected.txt: Removed.
  • platform/gtk/svg/hixie/use/001-expected.png: Removed.
  • platform/gtk/svg/hixie/use/002-expected.png: Removed.
  • platform/gtk/svg/hixie/use/002-test-expected.png: Removed.
  • platform/gtk/svg/hixie/viewbox/001-expected.png: Removed.
  • platform/gtk/svg/hixie/viewbox/004-expected.png: Removed.
  • platform/gtk/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Removed.
  • platform/gtk/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Removed.
  • platform/mac/svg/hixie/cascade/002-expected.txt: Removed.
  • platform/mac/svg/hixie/perf/004-expected.txt: Removed.
  • platform/mac/svg/hixie/perf/005-expected.txt: Removed.
  • platform/mac/svg/hixie/perf/006-expected.txt: Removed.
  • platform/win-future/svg/hixie/perf/007-expected.txt: Copied from LayoutTests/svg/hixie/perf/007-expected.txt.
  • svg/hixie/cascade/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/cascade/002-expected.txt.
  • svg/hixie/dynamic/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/002-expected.png.
  • svg/hixie/dynamic/003-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/003-expected.png.
  • svg/hixie/dynamic/004-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/004-expected.png.
  • svg/hixie/dynamic/005-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/005-expected.png.
  • svg/hixie/dynamic/006-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/006-expected.png.
  • svg/hixie/error/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/001-expected.png.
  • svg/hixie/error/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/002-expected.png.
  • svg/hixie/error/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/002-expected.txt.
  • svg/hixie/error/003-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/003-expected.txt.
  • svg/hixie/error/006-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/006-expected.png.
  • svg/hixie/error/007-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/007-expected.png.
  • svg/hixie/error/008-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/008-expected.png.
  • svg/hixie/error/009-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/009-expected.png.
  • svg/hixie/error/010-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/010-expected.png.
  • svg/hixie/error/010-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/010-expected.txt.
  • svg/hixie/error/011-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/011-expected.png.
  • svg/hixie/error/011-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/011-expected.txt.
  • svg/hixie/error/014-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/014-expected.png.
  • svg/hixie/error/014-test-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/014-test-expected.png.
  • svg/hixie/error/015-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/015-expected.png.
  • svg/hixie/error/016-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/016-expected.png.
  • svg/hixie/error/017-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/017-expected.txt.
  • svg/hixie/intrinsic/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/intrinsic/001-expected.png.
  • svg/hixie/intrinsic/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/intrinsic/001-expected.txt.
  • svg/hixie/intrinsic/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/intrinsic/002-expected.png.
  • svg/hixie/intrinsic/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/intrinsic/002-expected.txt.
  • svg/hixie/links/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/links/002-expected.png.
  • svg/hixie/links/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/links/002-expected.txt.
  • svg/hixie/mixed/007-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/mixed/007-expected.png.
  • svg/hixie/painting/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/painting/001-expected.png.
  • svg/hixie/perf/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/001-expected.txt.
  • svg/hixie/perf/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/002-expected.txt.
  • svg/hixie/perf/003-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/003-expected.txt.
  • svg/hixie/perf/004-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/004-expected.txt.
  • svg/hixie/perf/005-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/005-expected.txt.
  • svg/hixie/perf/006-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/006-expected.txt.
  • svg/hixie/perf/007-expected.txt:
  • svg/hixie/processing-model/003-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/processing-model/003-expected.png.
  • svg/hixie/processing-model/004-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/processing-model/004-expected.png.
  • svg/hixie/processing-model/005-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/processing-model/005-expected.png.
  • svg/hixie/rendering-model/003a-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/rendering-model/003a-expected.png.
  • svg/hixie/shapes/path/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/shapes/path/001-expected.txt.
  • svg/hixie/text/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/text/002-expected.txt.
  • svg/hixie/text/003a-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/text/003a-expected.txt.
  • svg/hixie/text/003b-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/text/003b-expected.txt.
  • svg/hixie/use/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/use/001-expected.png.
  • svg/hixie/use/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/use/002-expected.png.
  • svg/hixie/use/002-test-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/use/002-test-expected.png.
  • svg/hixie/viewbox/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/viewbox/001-expected.png.
  • svg/hixie/viewbox/004-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/viewbox/004-expected.png.
  • svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt.
  • svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt.
5:27 PM Changeset in webkit [159004] by andersca@apple.com
  • 7 edits in trunk/Source

Encode form data using the KeyedEncoder
https://bugs.webkit.org/show_bug.cgi?id=124107

Reviewed by Sam Weinig.

Source/WebCore:

  • platform/KeyedCoding.h:

(WebCore::KeyedEncoder::encodeEnum):

  • platform/network/FormData.cpp:

(WebCore::encodeElement):
(WebCore::FormData::encode):

  • platform/network/FormData.h:

Source/WebKit2:

  • Shared/cf/KeyedEncoder.cpp:

(WebKit::KeyedEncoder::encodeBool):
(WebKit::KeyedEncoder::encodeDouble):

  • Shared/cf/KeyedEncoder.h:
3:26 PM Changeset in webkit [159003] by andersca@apple.com
  • 1 edit
    1 delete in trunk/Source/WebKit2

Remove an unused file.

Rubber-stamped by Andreas Kling.

  • WebProcess/WebPage/gtk/ChunkedUpdateDrawingAreaGtk.cpp: Removed.
1:41 PM Changeset in webkit [159002] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Modernize CanvasObserverProxy
https://bugs.webkit.org/show_bug.cgi?id=124106

Reviewed by Anders Carlsson.

  • css/CSSCanvasValue.h:
12:59 PM Changeset in webkit [159001] by Patrick Gansterer
  • 101 edits
    7 moves
    1 add in trunk/Source

Move RunLoop from WebCore to WTF
https://bugs.webkit.org/show_bug.cgi?id=116606

Reviewed by Anders Carlsson.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • PlatformBlackBerry.cmake:
  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • PlatformWin.cmake:
  • WebCore.exp.in:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:

Source/WebKit/mac:

  • Carbon/CarbonWindowAdapter.mm:

(+[CarbonWindowAdapter initialize]):

  • History/WebBackForwardList.mm:

(+[WebBackForwardList initialize]):

  • History/WebHistoryItem.mm:

(+[WebHistoryItem initialize]):

  • Misc/WebCache.mm:

(+[WebCache initialize]):

  • Misc/WebElementDictionary.mm:

(+[WebElementDictionary initialize]):

  • Misc/WebIconDatabase.mm:

(+[WebIconDatabase initialize]):

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(+[WebHostedNetscapePluginView initialize]):

  • Plugins/WebBaseNetscapePluginView.mm:
  • Plugins/WebBasePluginPackage.mm:
  • Plugins/WebNetscapePluginView.mm:

(+[WebNetscapePluginView initialize]):

  • WebCoreSupport/WebEditorClient.mm:

(+[WebUndoStep initialize]):

  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebView/WebArchive.mm:

(+[WebArchivePrivate initialize]):

  • WebView/WebDataSource.mm:

(+[WebDataSource initialize]):

  • WebView/WebHTMLView.mm:

(+[WebHTMLViewPrivate initialize]):
(+[WebHTMLView initialize]):

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

  • WebView/WebResource.mm:

(+[WebResourcePrivate initialize]):

  • WebView/WebTextIterator.mm:

(+[WebTextIteratorPrivate initialize]):

  • WebView/WebView.mm:

(+[WebView initialize]):

  • WebView/WebViewData.mm:

(+[WebViewPrivate initialize]):

Source/WebKit2:

  • DatabaseProcess/DatabaseProcess.cpp:
  • DatabaseProcess/DatabaseToWebProcessConnection.cpp:
  • NetworkProcess/NetworkConnectionToWebProcess.cpp:
  • NetworkProcess/NetworkProcess.cpp:
  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/mac/DiskCacheMonitor.h:
  • NetworkProcess/unix/NetworkProcessMainUnix.cpp:
  • Platform/CoreIPC/Connection.cpp:
  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/mac/ConnectionMac.cpp:
  • PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:
  • PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm:
  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/PluginProcess.cpp:
  • PluginProcess/PluginProcess.h:
  • PluginProcess/WebProcessConnection.cpp:
  • PluginProcess/unix/PluginProcessMainUnix.cpp:
  • Shared/ChildProcess.cpp:
  • Shared/ChildProcess.h:
  • Shared/ChildProcessProxy.cpp:
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.h:
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.mm:
  • Shared/Plugins/NPObjectProxy.cpp:
  • Shared/WebKit2Initialize.cpp:

(WebKit::InitializeWebKit2):

  • UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
  • UIProcess/API/mac/FindIndicatorWindow.h:
  • UIProcess/API/mac/WKPrintingView.mm:
  • UIProcess/API/mac/WKView.mm:
  • UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyImpl.h:
  • UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:
  • UIProcess/Network/NetworkProcessProxy.cpp:
  • UIProcess/Plugins/PluginProcessProxy.cpp:
  • UIProcess/ResponsivenessTimer.cpp:
  • UIProcess/ResponsivenessTimer.h:
  • UIProcess/VisitedLinkProvider.h:
  • UIProcess/WebContext.cpp:
  • UIProcess/WebProcessProxy.cpp:
  • WebProcess/Databases/WebToDatabaseProcessConnection.cpp:
  • WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
  • WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
  • WebProcess/Network/WebResourceLoadScheduler.h:
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.h:
  • WebProcess/Plugins/PluginView.h:
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/EventDispatcher.cpp:
  • WebProcess/WebPage/PageOverlay.h:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebProcess.cpp:
  • WebProcess/efl/WebProcessMainEfl.cpp:
  • WebProcess/gtk/WebProcessMainGtk.cpp:

Source/WTF:

With this change RunLoop can be used in JavaScriptCore too.

  • GNUmakefile.list.am:
  • WTF.vcxproj/WTF.vcxproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/PlatformBlackBerry.cmake:
  • wtf/PlatformEfl.cmake:
  • wtf/PlatformGTK.cmake:
  • wtf/PlatformWin.cmake:
  • wtf/RunLoop.cpp: Renamed from Source/WebCore/platform/RunLoop.cpp.

(WTF::RunLoop::Holder::Holder):
(WTF::RunLoop::Holder::runLoop):
(WTF::RunLoop::initializeMainRunLoop):
(WTF::RunLoop::current):
(WTF::RunLoop::main):
(WTF::RunLoop::isMain):
(WTF::RunLoop::performWork):
(WTF::RunLoop::dispatch):

  • wtf/RunLoop.h: Renamed from Source/WebCore/platform/RunLoop.h.

(WTF::RunLoop::TimerBase::startRepeating):
(WTF::RunLoop::TimerBase::startOneShot):
(WTF::RunLoop::TimerBase::isRepeating):
(WTF::RunLoop::Timer::Timer):
(WTF::RunLoop::Timer::fired):

  • wtf/blackberry/RunLoopBlackBerry.cpp: Renamed from Source/WebCore/platform/blackberry/RunLoopBlackBerry.cpp.

(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::wakeUp):

  • wtf/cf/RunLoopCF.cpp: Renamed from Source/WebCore/platform/cf/RunLoopCF.cpp.

(WTF::RunLoop::performWork):
(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::runForDuration):
(WTF::RunLoop::wakeUp):
(WTF::RunLoop::run):
(WTF::RunLoop::stop):
(WTF::RunLoop::TimerBase::timerFired):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::~TimerBase):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):

  • wtf/efl/RunLoopEfl.cpp: Renamed from Source/WebCore/platform/efl/RunLoopEfl.cpp.

(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::run):
(WTF::RunLoop::stop):
(WTF::RunLoop::wakeUpEvent):
(WTF::RunLoop::wakeUp):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::~TimerBase):
(WTF::RunLoop::TimerBase::timerFired):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):

  • wtf/gtk/RunLoopGtk.cpp: Renamed from Source/WebCore/platform/gtk/RunLoopGtk.cpp.

(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::run):
(WTF::RunLoop::innermostLoop):
(WTF::RunLoop::pushNestedMainLoop):
(WTF::RunLoop::popNestedMainLoop):
(WTF::RunLoop::stop):
(WTF::RunLoop::queueWork):
(WTF::RunLoop::wakeUp):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::~TimerBase):
(WTF::RunLoop::TimerBase::clearTimerSource):
(WTF::RunLoop::TimerBase::timerFiredCallback):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):

  • wtf/win/RunLoopWin.cpp: Renamed from Source/WebCore/platform/win/RunLoopWin.cpp.

(WTF::RunLoop::RunLoopWndProc):
(WTF::RunLoop::wndProc):
(WTF::RunLoop::run):
(WTF::RunLoop::stop):
(WTF::RunLoop::registerRunLoopMessageWindowClass):
(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::wakeUp):
(WTF::RunLoop::TimerBase::timerFired):
(WTF::generateTimerID):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::~TimerBase):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):

8:11 AM Changeset in webkit [159000] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Tighten typing in SVGResourcesCycleSolver a bit.
<https://webkit.org/b/124104>

Make the SVGResourcesCycleSolver constructor take a RenderElement&
and a SVGResources&.

While I was in the neighborhood, also converted one loop to use a
renderer iterator instead of walking siblings manually.

Finally used "auto" to clean up some overly wordy loops.

Reviewed by Anders Carlsson.

3:32 AM Changeset in webkit [158999] by akling@apple.com
  • 18 edits in trunk/Source/WebCore

Beat SVGRenderSupport with the RenderElement stick.
<https://webkit.org/b/124102>

Tighten up all the SVGRenderSupport helper functions by making them
take const RenderElements references instead of raw RenderObject
pointers as much as possible.

This tunes up a bunch of branchy style() calls.

The patch looks big but it's mostly mechanical. I just changed the
signatures and then worked backwards until everything built again.

Reviewed by Antti Koivisto.

3:17 AM Changeset in webkit [158998] by akling@apple.com
  • 10 edits in trunk/Source/WebCore

SVGTextLayoutAttributes always has a RenderSVGInlineText.
<https://webkit.org/b/124101>

No SVGTextLayoutAttributes object is without a RenderSVGInlineText
"context" so make context() return a reference.

Reviewed by Antti Koivisto.

3:16 AM Changeset in webkit [158997] by akling@apple.com
  • 13 edits
    2 deletes in trunk/Source/WebCore

Move BindingSecurity stuff under JSDOMBinding umbrella.
<https://webkit.org/b/124099>

We are hitting shouldAllowAccessToDOMWindow() pretty hard on the
demo here: <http://www.jasondavies.com/maps/rotate/>

Putting it together with the rest of the JSDOMBinding code takes
CPU time spent in there from 8.7% to 6.5%. The abstraction was
only used to support alternate JS engines in the past.

Reviewed by Antti Koivisto.

3:14 AM Changeset in webkit [158996] by Antti Koivisto
  • 2 edits in trunk/PerformanceTests

Add subtest for word-break:break-all to Layout/line-layout-simple.html
https://bugs.webkit.org/show_bug.cgi?id=124103

Reviewed by Andreas Kling.

  • Layout/line-layout-simple.html:

Combination "white-space:pre-wrap; word-break:break-all" is common for pure text.

Note: See TracTimeline for information about the timeline view.