⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 23, 2013:

8:20 AM Changeset in webkit [159731] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

Remove lint from expected result.

Unreviewed.

  • platform/gtk/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
6:35 AM Changeset in webkit [159730] by calvaris@igalia.com
  • 41 edits
    3 deletes in trunk

[GStreamer] Remove 0.10 codepath
​https://bugs.webkit.org/show_bug.cgi?id=124534

Reviewed by Philippe Normand.

.:

  • Source/cmake/OptionsEfl.cmake: Removed GST_API_VERSION_1

definition.

Source/WebCore:

All GStreamer ports are using 1.0 now so we remove the 0.10
codepath.

  • GNUmakefile.list.am:
  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters: Removed

GStreamerVersioning.

  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(onGStreamerWavparsePadAddedCallback): Removed.
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
Replaced webkitGstPipelineGetBus and removed 0.10 codepath.
(WebCore::AudioDestinationGStreamer::~AudioDestinationGStreamer):
Replaced webkitGstPipelineGetBus.

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::copyGstreamerBuffersToAudioChannel):
(WebCore::onAppsinkPullRequiredCallback): Removed 0.10 codepath.
(WebCore::AudioFileReader::~AudioFileReader): Replaced
webkitGstPipelineGetBus and removed 0.10 codepath.
(WebCore::AudioFileReader::handleSample): Left as only codepath.
(WebCore::AudioFileReader::handleBuffer): Removed.
(WebCore::AudioFileReader::handleNewDeinterleavePad): Removed 0.10
codepath.
(WebCore::AudioFileReader::plugDeinterleave): Replaced
getGstAudioCaps.
(WebCore::AudioFileReader::decodeAudioForBusCreation): Replaced
webkitGstPipelineGetBus.
(WebCore::AudioFileReader::createBus): Removed 0.10 codepath.

  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(getGStreamerMonoAudioCaps):
(webKitWebAudioGStreamerChannelPosition): Removed 0.10 codepath.
(webkit_web_audio_src_class_init): Replaced
setGstElementClassMetadata.
(webkit_web_audio_src_init):
(webKitWebAudioSrcConstructed):
(webKitWebAudioSrcFinalize):
(webKitWebAudioSrcLoop): Removed 0.10 codepath.

  • platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:
  • platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:

Removed checks for 1.0 as it is the only codepath now.

  • platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::GstElement):
(WTF::GstPad):
(WTF::GstPadTemplate):
(WTF::GstTask):
(WTF::GstBus):
(WTF::GstElementFactory):
(WTF::adoptGRef): Replaced gstObjectIsFloating.
(WTF::refGRef): Replaced webkitGstObjectRefSink.
(WTF::GstTagList):
(WTF::GstSample): Removed checks for 1.0 as it is the only
codepath now.

  • platform/graphics/gstreamer/GRefPtrGStreamer.h: Removed checks

for 1.0 as it is the only codepath now.

  • platform/graphics/gstreamer/GStreamerUtilities.cpp:

(WebCore::webkitGstGhostPadFromStaticTemplate):
(WebCore::getVideoSizeAndFormatFromCaps):
(WebCore::createGstBuffer):
(WebCore::createGstBufferForData):
(WebCore::getGstBufferDataPointer):
(WebCore::mapGstBuffer):
(WebCore::unmapGstBuffer): Moved here from GstVersioning and added
to WebCore namespace.

  • platform/graphics/gstreamer/GStreamerUtilities.h:

(WebCore::webkitGstCheckVersion): Moved here from GstVersioning
and added to WebCore namespace.

  • platform/graphics/gstreamer/GStreamerVersioning.cpp: Removed.
  • platform/graphics/gstreamer/GStreamerVersioning.h: Removed.
  • platform/graphics/gstreamer/ImageGStreamer.h: Removed checks for

1.0 as it is the only codepath now.

  • platform/graphics/gstreamer/ImageGStreamerCairo.cpp:

(ImageGStreamer::ImageGStreamer): Removed 0.10 codepath.
(ImageGStreamer::~ImageGStreamer): Removed checks for 1.0 as it is
the only codepath now.

  • platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStreamer.h:
  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:

Removed checks for 1.0 as it is the only codepath now.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::setAudioStreamPropertiesCallback): Removed 0.10 codepath.
(WebCore::mediaPlayerPrivateTextChangedCallback): Removed checks
for 1.0 as it is the only codepath now.
(WebCore::MediaPlayerPrivateGStreamer::isAvailable): Replaced
gPlaybinName.
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
Removed checks for 1.0 and replaced webkitGstPipelineGetBus.
(WebCore::MediaPlayerPrivateGStreamer::duration): Removed 0.10
codepath.
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio):
(WebCore::MediaPlayerPrivateGStreamer::textChanged):
Removed checks for 1.0 as it is the only codepath now.
(WebCore::MediaPlayerPrivateGStreamer::buffered): Replaced
gPercentMax.
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Removed
0.10 codepath.
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContents):
Removed checks for 1.0 as it is the only codepath now.
(WebCore::MediaPlayerPrivateGStreamer::totalBytes): Removed 0.10
codepath.
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): Replaced
gPlaybinName and webkitGstPipelineGetBus and removed checks for
1.0.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

Removed checks for 1.0 as it is the only codepath now.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::naturalSize):
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture):
(WebCore::MediaPlayerPrivateGStreamerBase::paint): Removed 0.10
codepath.

  • platform/graphics/gstreamer/TextCombinerGStreamer.cpp:
  • platform/graphics/gstreamer/TextCombinerGStreamer.h:
  • platform/graphics/gstreamer/TextSinkGStreamer.cpp:
  • platform/graphics/gstreamer/TextSinkGStreamer.h:
  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h: Removed

checks for 1.0 as it is the only codepath now.

  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkitVideoSinkRender): Removed 0.10 codepath and added WebCore
as createGstBuffer namespace.
(webkitVideoSinkSetCaps): Removed 0.10 codepath.
(webkitVideoSinkProposeAllocation): Removed checks for 1.0 as it
is the only codepath now.
(webkitVideoSinkMarshalVoidAndMiniObject): Removed as it was 0.10.
(webkit_video_sink_class_init): Removed 0.10 codepath and replaced
setGstElementClassMetadata.

  • platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:
  • platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h:

Removed checks for 1.0 as it is the only codepath now.

  • platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:

(webkit_media_src_class_init): Replaced
setGstElementClassMetadata.
(webKitMediaSrcAddSrc): Added WebCore namespace to
webkitGstGhostPadFromStaticTemplate.
(MediaSourceClientGstreamer::didReceiveData): Added WebCore
namespace to createGstBufferForData.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

Removed 0.10 codepath.
(webKitWebSrcQuery): Removed as it was 0.10 only.
(void webkit_web_src_class_init): Replaced setGstElementClassMetadata.
(webkit_web_src_init): Removed haveAppSrc27 private attribute and
0.10 codepath.
(webKitWebSrcStop): Removed checks for 1.0 as it is the only
codepath now.
(webKitWebSrcSetProperty):
(webKitWebSrcUriGetType):
(webKitWebSrcGetProtocols):
(webKitWebSrcGetUri):
(webKitWebSrcSetUri): Removed 0.10 codepath.
(StreamingClient::createReadBuffer): Removed checks for 1.0 and
replaced getGstBufferSize.
(StreamingClient::handleResponseReceived): Removed 0.10 codepath
and replaced notifyGstTagsOnPad.
(StreamingClient::handleDataReceived): Removed 0.10 codepath and
replaced setGstBufferSize and gst_buffer_get_size.

Source/WebKit:

  • PlatformEfl.cmake: Removed FullscreenVideoControllerEfl.cpp.

Source/WebKit/efl:

  • WebCoreSupport/FullscreenVideoControllerEfl.cpp: Removed.

Source/WTF:

  • wtf/Platform.h: Removed macro for GStreamer 1.0 as it is the

only codepath now.

3:05 AM Changeset in webkit [159729] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

Rebaseline empty-clear-blocks.html after r159575

Unreviewed, rebaselining.

  • platform/gtk/fast/block/margin-collapse/empty-clear-blocks-expected.txt:

Nov 22, 2013:

11:11 PM Changeset in webkit [159728] by beidson@apple.com
  • 7 edits
    1 copy
    1 add in trunk/Source/WebKit2

Add DatabaseProcessCreationParameters, starting with the database path.
​https://bugs.webkit.org/show_bug.cgi?id=124804

Reviewed by Dean Jackson and Benjamin Poulain.

  • DatabaseProcess/DatabaseProcess.cpp:

(WebKit::DatabaseProcess::initializeDatabaseProcess):

  • DatabaseProcess/DatabaseProcess.h:

(WebKit::DatabaseProcess::indexedDatabaseDirectory):

  • DatabaseProcess/DatabaseProcess.messages.in:
  • Shared/Databases/DatabaseProcessCreationParameters.cpp: Added.

(WebKit::DatabaseProcessCreationParameters::DatabaseProcessCreationParameters):
(WebKit::DatabaseProcessCreationParameters::encode):
(WebKit::DatabaseProcessCreationParameters::decode):

  • Shared/Databases/DatabaseProcessCreationParameters.h: Added.
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureDatabaseProcess):

  • WebKit2.xcodeproj/project.pbxproj:
  • Scripts/webkit2/messages.py:

(struct_or_class):

10:03 PM Changeset in webkit [159727] by ryuan.choi@samsung.com
  • 5 edits in trunk/Source/WebKit2

[EFL] Build break after r159724
​https://bugs.webkit.org/show_bug.cgi?id=124806

Reviewed by Tim Horton.

  • Platform/CoreIPC/Connection.h: Include atomic header.
  • UIProcess/CoordinatedGraphics/WebView.cpp: Rename didChangeContentsSize to didChangeContentSize.

(WebKit::WebView::didChangeContentSize):

  • UIProcess/CoordinatedGraphics/WebView.h: Ditto.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Adjust TARGET_OS_IPHONE macro.
8:50 PM Changeset in webkit [159726] by rniwa@webkit.org
  • 4 edits
    1 add
    1 delete in trunk

Layout Test editing/deleting/password-delete-performance.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=124781

Reviewed by Alexey Proskuryakov.

PerformanceTests:

Add a new performance test to replace editing/deleting/password-delete-performance.html.
We skip this test by default since it's a micro benchmark.

  • Interactive/DeletingInPasswordField.html: Added.
  • Skipped:

LayoutTests:

Removed the test that has been timing out.

7:43 PM Changeset in webkit [159725] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Attempt build fixes for 32-bit after 159724.

There's probably a better fix, but this will work for now.

  • UIProcess/API/mac/WKView.h:
7:29 PM Changeset in webkit [159724] by enrica@apple.com
  • 101 edits
    50 adds
    2 deletes in trunk/Source/WebKit2

Upstream iOS WebKit2 to OpenSource (part 3).
​https://bugs.webkit.org/show_bug.cgi?id=124803

Reviewed by Anders Carlsson and Tim Horton.

6:54 PM Changeset in webkit [159723] by mhahnenberg@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

JSC Obj-C API should have real documentation
​https://bugs.webkit.org/show_bug.cgi?id=124805

Reviewed by Geoffrey Garen.

Massaging the header comments into proper headerdocs.

  • API/JSContext.h:
  • API/JSExport.h:
  • API/JSManagedValue.h:
  • API/JSValue.h:
  • API/JSVirtualMachine.h:
6:27 PM TestExpectations edited by Andres Gomez
(diff)
4:57 PM Changeset in webkit [159722] by jer.noble@apple.com
  • 4 edits in trunk/Source

[Mac] Can't drag full-screen video to another monitor
​https://bugs.webkit.org/show_bug.cgi?id=124798

Reviewed by Geoffrey Garen.

Source/WebCore:

Make full screen windows movable by default. Previously, we wanted non-movable full screen
windows since they were in the same space and were just placed atop non-full screen windows.
Now that all our supported Mac platforms have explicit full screen support, we can remove this
non-movable restriction.

  • platform/mac/WebCoreFullScreenWindow.mm:

(-[WebCoreFullScreenWindow initWithContentRect:styleMask:backing:defer:]):

Source/WebKit2:

Make full screen windows resizable by default. This allows the window to be resized when
moved between monitors with different resolutions.

  • UIProcess/API/mac/WKView.mm:

(-[WKView createFullScreenWindow]):

4:36 PM Changeset in webkit [159721] by fpizlo@apple.com
  • 20 edits in trunk/Source/JavaScriptCore

CodeBlock::m_numCalleeRegisters shouldn't also mean frame size, frame size needed for exit, or any other unrelated things
​https://bugs.webkit.org/show_bug.cgi?id=124793

Reviewed by Mark Hahnenberg.

Now m_numCalleeRegisters always refers to the number of locals that the attached
bytecode uses. It never means anything else.

For frame size, we now have it lazily computed from m_numCalleeRegisters for the
baseline engines and we have it stored in DFG::CommonData for the optimizing JITs.

For frame-size-needed-at-exit, we store that in DFG::CommonData, too.

The code no longer implies that there is any arithmetic relationship between
m_numCalleeRegisters and frameSize. Previously it implied that the latter is greater
than the former.

The code no longer implies that there is any arithmetic relationship between the
frame Size and the frame-size-needed-at-exit. Previously it implied that the latter
is greater that the former.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::frameRegisterCount):

  • bytecode/CodeBlock.h:
  • dfg/DFGCommonData.h:

(JSC::DFG::CommonData::CommonData):
(JSC::DFG::CommonData::requiredRegisterCountForExecutionAndExit):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::frameRegisterCount):
(JSC::DFG::Graph::requiredRegisterCountForExit):
(JSC::DFG::Graph::requiredRegisterCountForExecutionAndExit):

  • dfg/DFGGraph.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::SpeculativeJIT):

  • dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

  • ftl/FTLLink.cpp:

(JSC::FTL::link):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):

  • ftl/FTLOSREntry.cpp:

(JSC::FTL::prepareOSREntry):

  • interpreter/CallFrame.cpp:

(JSC::CallFrame::frameExtentInternal):

  • interpreter/JSStackInlines.h:

(JSC::JSStack::pushFrame):

  • jit/JIT.h:

(JSC::JIT::frameRegisterCountFor):

  • jit/JITOperations.cpp:
  • llint/LLIntEntrypoint.cpp:

(JSC::LLInt::frameRegisterCountFor):

  • llint/LLIntEntrypoint.h:
4:17 PM Changeset in webkit [159720] by Brent Fulgham
  • 4 edits in trunk/Source/WebCore

[Win] Clean up ColorSpace handling in Windows code
​https://bugs.webkit.org/show_bug.cgi?id=124795

Reviewed by Tim Horton.

Functionality covered by existing fast/css/color test suite.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::safeRGBColorSpaceRef): Handle case of Windows CG implementation not
handling sRGB correctly.
(WebCore::sRGBColorSpaceRef): Use new helper function.

  • platform/graphics/win/FontCGWin.cpp:

(WebCore::Font::drawGlyphs): Pass correct color space to fill functions.

  • platform/graphics/win/GraphicsContextCGWin.cpp:

(WebCore::GraphicsContext::platformInit): Initialize color space to value passed
via the style to the constructor.

4:07 PM Changeset in webkit [159719] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] Another build fix for NetworkProcess on iOS
​https://bugs.webkit.org/show_bug.cgi?id=124797

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-11-22
Reviewed by Alexey Proskuryakov.

  • NetworkProcess/NetworkResourceLoader.h:
3:47 PM Changeset in webkit [159718] by benjamin@webkit.org
  • 4 edits in trunk/Source/WebKit2

[WK2] Fix the build of the NetworkProcess on iOS
​https://bugs.webkit.org/show_bug.cgi?id=124794

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-11-22
Reviewed by Alexey Proskuryakov.

  • NetworkProcess/AsynchronousNetworkLoaderClient.cpp:

(WebKit::AsynchronousNetworkLoaderClient::didReceiveBuffer):

  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/SynchronousNetworkLoaderClient.cpp:

(WebKit::SynchronousNetworkLoaderClient::willSendRequest):

3:43 PM Changeset in webkit [159717] by ap@apple.com
  • 15 edits
    2 moves in trunk/Source/WebCore

WebCrypto algorithms should check that key algorithm matches
​https://bugs.webkit.org/show_bug.cgi?id=123628

Reviewed by Anders Carlsson.

No change in behavior yet, because we have one algorithm per key class.
Will be tested once more algorithms are added.

  • WebCore.xcodeproj/project.pbxproj: Updated for file renames.
  • bindings/js/JSCryptoAlgorithmDictionary.cpp:

(WebCore::createRsaKeyParamsWithHash):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey):

  • bindings/js/JSCryptoKeySerializationJWK.cpp:

(WebCore::createRSAKeyParametersWithHash):
(WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm):

  • crypto/CryptoAlgorithmParameters.h:

(WebCore::CryptoAlgorithmParameters::ENUM_CLASS):

  • crypto/parameters/CryptoAlgorithmRsaKeyParamsWithHash.h: Copied from Source/WebCore/crypto/parameters/CryptoAlgorithmRsaSsaKeyParams.h.
  • crypto/parameters/CryptoAlgorithmRsaSsaKeyParams.h: Removed.

Renamed RsaSsaKeyParams to RsaKeyParamsWithHash, because other algorithms (like RSA-OAEP)
are in the same boat. Depending on where the spec goes, we might need to introduce
algorithm specific RSA parameter classes later, but let's reduce copy/pasted code at
least for now.

  • crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp: Moved to the correct directory.
  • crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp: Copied from Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp.

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign): Factored out Mac specific
code, leaving type casting to cross-platform files.
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify): Ditto.

  • crypto/CryptoAlgorithmRegistry.h:

(WebCore::CryptoAlgorithmRegistry::registerAlgorithm):

  • crypto/mac/CryptoAlgorithmRegistryMac.cpp:

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
Reduce copy/pasting in registration code.

  • crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:

(WebCore::CryptoAlgorithmAES_CBC::keyAlgorithmMatches): Check key type and algorithm.
(WebCore::CryptoAlgorithmAES_CBC::encrypt): Cross platform type casting code.
Maybe we'll find a way to autogenerate or eliminate it one day.
(WebCore::CryptoAlgorithmAES_CBC::decrypt): Ditto.

  • crypto/algorithms/CryptoAlgorithmAES_CBC.h:
  • crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::keyAlgorithmMatches):
(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):

  • crypto/algorithms/CryptoAlgorithmHMAC.h:
  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::keyAlgorithmMatches):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::importKey):

  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
  • crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:

(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):

  • crypto/mac/CryptoAlgorithmHMACMac.cpp:

(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):
Same changes for all algorithms that have keys.

2:57 PM Changeset in webkit [159716] by Manuel Rego Casasnovas
  • 2 edits in trunk

[GTK] Review enabled/disabled CSS features for release builds
​https://bugs.webkit.org/show_bug.cgi?id=124791

Reviewed by Martin Robinson.

Enable and disable some CSS features according to what last versions of
Safari ship or not.

  • Source/autotools/SetupWebKitFeatures.m4: Enable ENABLE_CSS_REGIONS and

ENABLE_CSS_STICKY_POSITION. Disable ENABLE_CSS_EXCLUSIONS and
ENABLE_CSS_SHAPES.

2:52 PM Changeset in webkit [159715] by andersca@apple.com
  • 4 edits
    6 adds in trunk/Source/WebKit2

Move the remaining page loader clients out into separate files
​https://bugs.webkit.org/show_bug.cgi?id=124792

Reviewed by Dan Bernstein.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WKPageContextMenuClient.h: Added.
  • UIProcess/API/C/WKPageFindClient.h: Added.
  • UIProcess/API/C/WKPageFindMatchesClient.h: Added.
  • UIProcess/API/C/WKPageFormClient.h: Added.
  • UIProcess/API/C/WKPageLoaderClient.h:
  • UIProcess/API/C/WKPagePolicyClient.h: Added.
  • UIProcess/API/C/WKPageUIClient.h: Added.
  • WebKit2.xcodeproj/project.pbxproj:
2:24 PM Changeset in webkit [159714] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Fire "change" event on TextTrackList when a TextTrack's mode changes
​https://bugs.webkit.org/show_bug.cgi?id=124789

Patch by Brendan Long <​b.long@cablelabs.com> on 2013-11-22
Reviewed by Eric Carlson.

Source/WebCore:

Since AudioTrackList and VideoTrackList already have this event, the
interesting bits are in TrackListBase::scheduleChangeEvent(), and we
just need to call it for TextTrackList changes.

Test: media/track/track-change-event.html

  • html/HTMLMediaElement.cpp:

(HTMLMediaElement::textTrackModeChanged): Call TrackListBase::scheduleChangeEvent().

  • html/track/TextTrackList.idl: Add onchange event listener.

LayoutTests:

  • media/track/track-change-event-expected.txt: Added.
  • media/track/track-change-event.html: Added.
2:03 PM Changeset in webkit [159713] by fpizlo@apple.com
  • 17 edits in trunk/Source/JavaScriptCore

Combine SymbolTable and SharedSymbolTable
​https://bugs.webkit.org/show_bug.cgi?id=124761

Reviewed by Geoffrey Garen.

SymbolTable was never used directly; we now always used SharedSymbolTable. So, this
gets rid of SymbolTable and renames SharedSymbolTable to SymbolTable.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::symbolTable):

  • bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedFunctionExecutable::symbolTable):
(JSC::UnlinkedCodeBlock::symbolTable):
(JSC::UnlinkedCodeBlock::finishCreation):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::symbolTable):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStackLayoutPhase.cpp:

(JSC::DFG::StackLayoutPhase::run):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::symbolTableFor):

  • runtime/Arguments.h:

(JSC::Arguments::finishCreation):

  • runtime/Executable.h:

(JSC::FunctionExecutable::symbolTable):

  • runtime/JSActivation.h:

(JSC::JSActivation::create):
(JSC::JSActivation::JSActivation):
(JSC::JSActivation::registersOffset):
(JSC::JSActivation::allocationSize):

  • runtime/JSSymbolTableObject.h:

(JSC::JSSymbolTableObject::symbolTable):
(JSC::JSSymbolTableObject::JSSymbolTableObject):
(JSC::JSSymbolTableObject::finishCreation):

  • runtime/JSVariableObject.h:

(JSC::JSVariableObject::JSVariableObject):

  • runtime/SymbolTable.cpp:

(JSC::SymbolTable::destroy):
(JSC::SymbolTable::SymbolTable):

  • runtime/SymbolTable.h:

(JSC::SymbolTable::create):
(JSC::SymbolTable::createStructure):

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:
1:59 PM Changeset in webkit [159712] by andersca@apple.com
  • 3 edits
    1 add in trunk/Source/WebKit2

Move WKPageLoaderClient out into a separate header
​https://bugs.webkit.org/show_bug.cgi?id=124790

Reviewed by Dan Bernstein.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WKPageLoaderClient.h: Added.
  • WebKit2.xcodeproj/project.pbxproj:
1:44 PM Changeset in webkit [159711] by commit-queue@webkit.org
  • 7 edits in trunk

Add TextTrackList::getTrackById().
​https://bugs.webkit.org/show_bug.cgi?id=124785

Patch by Brendan Long <​b.long@cablelabs.com> on 2013-11-22
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/track-id.html

  • html/track/TextTrackList.cpp: Add getTrackById()

(TextTrackList::getTrackById):

  • html/track/TextTrackList.h: Same.
  • html/track/TextTrackList.idl: Same.

LayoutTests:

Update this test to make it more interesting. It now checks that the "id"
changes when the <track> id changes, makes sure TextTrack::id is readonly,
and looks the track up by id with getTrackById().

  • media/track/track-id-expected.txt:
  • media/track/track-id.html:
1:22 PM Changeset in webkit [159710] by dino@apple.com
  • 2 edits in trunk/Tools

Speculative Mountain Lion build fix.

  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate openDocument:]):

1:09 PM Changeset in webkit [159709] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Remove residual references to "dynamicGlobalObject".
​https://bugs.webkit.org/show_bug.cgi?id=124787.

Reviewed by Filip Pizlo.

12:57 PM Changeset in webkit [159708] by andersca@apple.com
  • 2 edits in trunk/Tools

Fix Mountain Lion bug.

  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate openDocument:]):

12:38 PM Changeset in webkit [159707] by andersca@apple.com
  • 2 edits in trunk/Tools

MiniBrowser should use the blocks-based NSOpenPanel API
​https://bugs.webkit.org/show_bug.cgi?id=124786

Reviewed by Simon Fraser.

  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate frontmostBrowserWindowController]):
Account for windows that don't have a BrowserWindowController.

(-[BrowserAppDelegate openDocument:]):

12:31 PM Changeset in webkit [159706] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Ensure that arity fixups honor stack alignment requirements.
​https://bugs.webkit.org/show_bug.cgi?id=124756.

Reviewed by Geoffrey Garen.

The LLINT and all the JITs rely on CommonSlowPaths::arityCheckFor() to
compute the arg count adjustment for the arity fixup. We take advantage
of this choke point and introduce the stack alignment padding there in
the guise of additional args.

The only cost of this approach is that the padding will also be
initialized to undefined values as if they were args. Since arity fixups
are considered a slow path that is rarely taken, this cost is not a
concern.

  • runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::arityCheckFor):

  • runtime/VM.h:

(JSC::VM::isSafeToRecurse):

12:18 PM Changeset in webkit [159705] by fpizlo@apple.com
  • 5 edits
    1 delete in trunk

BytecodeGenerator should align the stack according to native conventions
​https://bugs.webkit.org/show_bug.cgi?id=124735

Source/JavaScriptCore:

Reviewed by Mark Lam.

Rolling this back in because it actually fixed fast/dom/gc-attribute-node.html, but
our infrastructure misleads peole into thinking that fixing a test constitutes
breaking it.

  • bytecompiler/BytecodeGenerator.h:

(JSC::CallArguments::registerOffset):
(JSC::CallArguments::argumentCountIncludingThis):

  • bytecompiler/NodesCodegen.cpp:

(JSC::CallArguments::CallArguments):

LayoutTests:

Reviewed by Mark Lam.

  • platform/mac/fast/dom/gc-attribute-node-expected.txt: Removed.
12:06 PM Changeset in webkit [159704] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix 32-bit build.

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController dealloc]):
(-[WKBrowsingContextController _initWithPageRef:]):

11:48 AM Changeset in webkit [159703] by mitz@apple.com
  • 5 edits in trunk/Source/WebKit2

Debug builds unconditionally dump remote layer tree transactions to stderr.

Reviewed by Sam Weinig.

  • Platform/Logging.h: Declared RemoteLayerTree logging channel.
  • Shared/mac/RemoteLayerTreeTransaction.h: Declared description().
  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::dump): Changed to use description().
(WebKit::RemoteLayerTreeTransaction::description): Returns a CString with the description.

  • UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::commit): Changed to use logging instead of calling dump().

11:35 AM Changeset in webkit [159702] by hmuller@adobe.com
  • 7 edits
    4 adds in trunk

[CSS Shapes] When the <box> value is set, derive radii from border-radius
​https://bugs.webkit.org/show_bug.cgi?id=124228

Reviewed by Dean Jackson.

Source/WebCore:

Add support for BoxShape elliptical corners.

Tests: fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-001.html

fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-002.html

  • platform/graphics/FloatRoundedRect.h:

(WebCore::FloatRoundedRect::bottomLeftCorner): Corrected a copy-and-pasteO.

  • rendering/shapes/BoxShape.cpp:

(WebCore::BoxShape::getExcludedIntervals): Returned interval now depends on the top and bottom of the line.

  • rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape): Rounded rect parameters are now specified with a RoundedRect parameter.

  • rendering/shapes/Shape.h:
  • rendering/shapes/ShapeInfo.cpp:

(WebCore::::computedShape): Pass style's rounded border to createShape().

LayoutTests:

  • fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-001-expected.txt: Added.
  • fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-001.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-002-expected.txt: Added.
  • fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-002.html: Added.
11:33 AM Changeset in webkit [159701] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Send out the right KVO callbacks when the page title changes
​https://bugs.webkit.org/show_bug.cgi?id=124753

Reviewed by Simon Fraser.

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(PageLoadStateObserver::PageLoadStateObserver):
New class that sends the right KVO notifications when the load state changes.

(-[WKBrowsingContextController dealloc]):
Remove the observer.

(-[WKBrowsingContextController _initWithPageRef:]):
Allocate the observer and add it.

  • UIProcess/PageLoadState.cpp:

(WebKit::PageLoadState::~PageLoadState):
Assert that we don't have any observers left.

(WebKit::PageLoadState::addObserver):
Add the observer to the list.

(WebKit::PageLoadState::removeObserver):
Remove the observer from the list.

(WebKit::PageLoadState::reset):
Call title change callbacks.

(WebKit::PageLoadState::setTitle):
Ditto.

(WebKit::PageLoadState::callObserverCallback):
Helper function to dispatch callbacks to observers.

  • UIProcess/PageLoadState.h:

Add new members.

11:31 AM Changeset in webkit [159700] by Lucas Forschler
  • 5 edits in branches/safari-537.60-branch/Source

Versioning.

11:28 AM Changeset in webkit [159699] by Lucas Forschler
  • 1 copy in tags/Safari-537.60.7

New Tag.

11:14 AM Changeset in webkit [159698] by Brent Fulgham
  • 2 edits in branches/safari-537.60-branch/Source/WebCore

Merge r159691

2013-11-21 Brent Fulgham <Brent Fulgham>

[Win] Avoid deadlock when interacting with some AVFoundationCF content
<rdar://problem/15482977> and ​https://bugs.webkit.org/show_bug.cgi?id=124752

Prevent deadlock caused by conflict over the "mapLock" mutex. Notification handling in the file,
which modify assets and make other changes, are required to happen on the main thread. This
patch enforces this requirement.

Reviewed by Eric Carlson.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: (WebCore::NotificationCallbackData::NotificationCallbackData): Added (WebCore::AVFWrapper::processNotification): Moved logic from 'notificationCallback', which was sometimes happening on a background thread. (WebCore::AVFWrapper::notificationCallback): Dispatch calls to main thread.
10:24 AM Changeset in webkit [159697] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Get rid of CodeBlock::dumpStatistics()
​https://bugs.webkit.org/show_bug.cgi?id=124762

Reviewed by Mark Hahnenberg.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::~CodeBlock):

  • bytecode/CodeBlock.h:
9:46 AM Changeset in webkit [159696] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Unreviewed, rolling out r159690.
​http://trac.webkit.org/changeset/159690
​https://bugs.webkit.org/show_bug.cgi?id=124782

Broke webkitpy tests (Requested by ap on #webkit).

  • Scripts/webkitpy/tool/bot/queueengine.py:

(QueueEngine.run):
(QueueEngine._open_work_log):
(QueueEngine._ensure_work_log_closed):

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(AbstractEarlyWarningSystem.review_patch):

9:44 AM Changeset in webkit [159695] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Several missing/incorrect guards for LOG_DISABLED=0 against Release build (Mac)
​https://bugs.webkit.org/show_bug.cgi?id=78735

Patch by Andres Gomez <Andres Gomez> on 2013-11-22
Reviewed by Mario Sanchez Prada.

In a "Debug" build the CString.h header comes from another
indirect dependency. Now, we explicitly add this missing include.

  • page/CaptionUserPreferencesMediaAF.cpp: Explicitly adding

missing include.

9:38 AM Changeset in webkit [159694] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test editing/deleting/password-delete-performance.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=124781

  • TestExpectations: Skipped it, running a test that almost always times out makes little sense.
9:34 AM Changeset in webkit [159693] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r159652.
​http://trac.webkit.org/changeset/159652
​https://bugs.webkit.org/show_bug.cgi?id=124778

broke fast/dom/gc-attribute-node.html (Requested by ap on
#webkit).

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):

  • bytecompiler/BytecodeGenerator.h:

(JSC::CallArguments::registerOffset):
(JSC::CallArguments::argumentCountIncludingThis):

  • bytecompiler/NodesCodegen.cpp:

(JSC::CallArguments::CallArguments):
(JSC::CallArguments::newArgument):

9:27 AM Changeset in webkit [159692] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[curl] Fix of SSL certificate chain storage
​https://bugs.webkit.org/show_bug.cgi?id=124768

Patch by Robert Sipka <​sipka@inf.u-szeged.hu> on 2013-11-22
Reviewed by Brent Fulgham.

Change the certificates storage type into ListHashSet
from HashSet to keep the chain order in each case.
This ensures that there is no difference between the stored
and the recieved certificate chain.

  • platform/network/curl/SSLHandle.cpp:

(WebCore::allowsAnyHTTPSCertificateHosts):
(WebCore::sslIgnoreHTTPSCertificate):
(WebCore::pemData):
(WebCore::certVerifyCallback):

9:23 AM Changeset in webkit [159691] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Win] Avoid deadlock when interacting with some AVFoundationCF content
<rdar://problem/15482977> and ​https://bugs.webkit.org/show_bug.cgi?id=124752

Prevent deadlock caused by conflict over the "mapLock" mutex. Notification handling in the file,
which modify assets and make other changes, are required to happen on the main thread. This
patch enforces this requirement.

Reviewed by Eric Carlson.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::NotificationCallbackData::NotificationCallbackData): Added
(WebCore::AVFWrapper::processNotification): Moved logic from 'notificationCallback', which was
sometimes happening on a background thread.
(WebCore::AVFWrapper::notificationCallback): Dispatch calls to main thread.

8:26 AM Changeset in webkit [159690] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

EWS creates 0 byte sized log files
​https://bugs.webkit.org/show_bug.cgi?id=107606

Patch by László Langó <​lango@inf.u-szeged.hu> on 2013-11-22
Reviewed by Ryosuke Niwa.

There was a modification in r138264, that tried to make less log,
because some of the messeges were duplicated. After this the EWS
created the log file (with the same name as the bugID) but doesn't
write anything into it, even if there were errors during the build.
From now only creates the log file only if there is some error.

  • Scripts/webkitpy/tool/bot/queueengine.py:

(QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
there is nothing to log. Open the log file only if a ScriptError was raised to
avoid to make empty log files for bugs.
(QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
because of changes in r138264. Teeing is used for locally testing purposes and
this feature is not used anymore.
(QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output
teeing anymore. It is a necessary change because of QueueEngine._open_work_log
change.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
to be able to handle it in QueueEngine.run. Without this change, the existing
exception handler never run (the process_work_item method never raise ScriptError)
We can get the error message only from the ScriptError at this point.

8:07 AM Changeset in webkit [159689] by rniwa@webkit.org
  • 5 edits
    59 adds in trunk/LayoutTests

Import more W3C tests for parsing template elements
​https://bugs.webkit.org/show_bug.cgi?id=124763

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Imported more W3c tests for HTML template element at 12a1164ae919f29f6ba2d0c8a63f0eafb6b599aa
after applying fixes proposed at ​https://github.com/w3c/web-platform-tests/pull/442.

  • html-templates/definitions/template-contents-expected.txt: Added.
  • html-templates/definitions/template-contents-owner-document-type-expected.txt: Added.
  • html-templates/definitions/template-contents-owner-document-type.html: Added.
  • html-templates/definitions/template-contents-owner-test-001-expected.txt: Added.
  • html-templates/definitions/template-contents-owner-test-001.html: Added.
  • html-templates/definitions/template-contents-owner-test-002-expected.txt: Added.
  • html-templates/definitions/template-contents-owner-test-002.html: Added.
  • html-templates/definitions/template-contents.html: Added.
  • html-templates/innerhtml-on-templates/innerhtml-expected.txt: Added.
  • html-templates/innerhtml-on-templates/innerhtml.html: Added.
  • html-templates/parsing-html-templates/additions-to-foster-parenting/template-is-a-foster-parent-element-expected.txt: Added.
  • html-templates/parsing-html-templates/additions-to-foster-parenting/template-is-a-foster-parent-element.html: Added.
  • html-templates/parsing-html-templates/additions-to-foster-parenting/template-is-not-a-foster-parent-element-expected.txt: Added.
  • html-templates/parsing-html-templates/additions-to-foster-parenting/template-is-not-a-foster-parent-element.html: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/generating-of-implied-end-tags-expected.txt: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/generating-of-implied-end-tags.html: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-body-token-expected.txt: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-body-token.html: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-frameset-token-expected.txt: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-frameset-token.html: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-head-token-expected.txt: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-head-token.html: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-html-token-expected.txt: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-html-token.html: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/start-tag-body-expected.txt: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/start-tag-body.html: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/start-tag-html-expected.txt: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/start-tag-html.html: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/template-end-tag-without-start-one-expected.txt: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/template-end-tag-without-start-one.html: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-frameset-insertion-mode/end-tag-frameset-expected.txt: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-frameset-insertion-mode/end-tag-frameset.html: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-head-insertion-mode/generating-of-implied-end-tags-expected.txt: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-head-insertion-mode/generating-of-implied-end-tags.html: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-head-insertion-mode/template-end-tag-without-start-one-expected.txt: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-head-insertion-mode/template-end-tag-without-start-one.html: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-table-insertion-mode/end-tag-table-expected.txt: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-table-insertion-mode/end-tag-table.html: Added.
  • html-templates/parsing-html-templates/appending-to-a-template/template-child-nodes-expected.txt: Added.
  • html-templates/parsing-html-templates/appending-to-a-template/template-child-nodes.html: Added.
  • html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-body-context-expected.txt: Added.
  • html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-body-context.html: Added.
  • html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-context-expected.txt: Added.
  • html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-context.html: Added.
  • html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-row-context-expected.txt: Added.
  • html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-row-context.html: Added.
  • html-templates/parsing-html-templates/creating-an-element-for-the-token/template-owner-document-expected.txt: Added.
  • html-templates/parsing-html-templates/creating-an-element-for-the-token/template-owner-document.html: Added.

LayoutTests:

Updated the testharness.js/css to bc4639ba51b62158d94bb4fc6884b23453f3f7a1.

  • resources/testharness.css:
  • resources/testharness.js:
  • resources/testharnessreport.js: Use innerText instead of innerHTML to avoid interpreting markup inside

the status and message as HTML.

8:01 AM Changeset in webkit [159688] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Compile error when ACCELERATED_COMPOSITING is not used.
​https://bugs.webkit.org/show_bug.cgi?id=124773

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-11-22
Reviewed by Brent Fulgham.

  • rendering/RenderView.cpp:

(WebCore::RenderView::paintBoxDecorations): Added USE(ACCELERATED_COMPOSITING) guard.

7:12 AM Changeset in webkit [159687] by zandobersek@gmail.com
  • 6 edits
    5 adds in trunk/LayoutTests

Unreviewed GTK gardening.
Rebaselining after r159575 and r159579.

  • platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/gtk/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
  • platform/gtk/editing/deleting/delete-by-word-001-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-by-word-002-expected.txt: Added.
  • platform/gtk/editing/input/option-page-up-down-expected.txt: Added.
  • platform/gtk/editing/input/scroll-viewport-page-up-down-expected.txt: Added.
  • platform/gtk/editing/undo/undo-deleteWord-expected.txt: Added.
  • platform/gtk/fast/block/float/024-expected.txt:
  • platform/gtk/fast/block/margin-collapse/025-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
7:00 AM Changeset in webkit [159686] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.
Adding failure expectations for tests that regressed with r159572.

  • platform/gtk/TestExpectations:
3:03 AM Changeset in webkit [159685] by svillar@igalia.com
  • 4 edits
    3 adds in trunk

[CSS Grid Layout] Improve content-sized track layout
​https://bugs.webkit.org/show_bug.cgi?id=124408

Reviewed by Dean Jackson.

PerformanceTests:

From Blink r156122 by <​jchaffraix@chromium.org>

New test to check the performance of layouting grids with content sized tracks.

  • Layout/auto-grid-lots-of-data.html: Added.

Source/WebCore:

Test: fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html

From Blink r156122 & r157633 by <​jchaffraix@chromium.org>

Added a couple of optimizations to speed up the layout of content
based tracks. The idea is to narrow down the conditions for
relayouting when the height of a grid area changes. We basically
just need to layout tracks with percentage heights as they're the
only ones that change.

A new performance test is attached to demonstrate the effect of
these optimizations. We get a ~1000% improvement on a i7 M620
going from 14.5 runs/s to 165 runs/s.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::logicalContentHeightForChild):
(WebCore::RenderGrid::layoutGridItems):

LayoutTests:

From Blink r157633 by <​jchaffraix@chromium.org>

New test to verify that grid items with percentage logical
{min|max}-height resolve their sizes properly.

  • fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic-expected.txt: Added.
  • fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html: Added.
1:25 AM Changeset in webkit [159684] by svillar@igalia.com
  • 9 edits
    1 add in trunk

[CSS Grid Layout] Run the content-sized tracks sizing algorithm only when required
​https://bugs.webkit.org/show_bug.cgi?id=124039

Reviewed by Dean Jackson.

PerformanceTests:

From Blink r156028 and r156168 by <​jchaffraix@chromium.org>.

New performance tests for layouts in grids with fixed size tracks.

  • Layout/fixed-grid-lots-of-data.html: Added.

Source/WebCore:

The current code runs the content sized track sizing algorithm all
the time, which forces a layout even when the track is not
content-sized. This change improves the situation by applying two
optimizations. In the first one, we bail out the algorithm if we
detect that we don't need to run it. And by the second one we
reduce the amount of recomputations by only iterating over the
content sized tracks instead of all of them. Both changes follow
the ideas introduced in Blink r156028 and r156168 by
<​jchaffraix@chromium.org>.

As we changed the way we iterate over children (we use the
GridIterator now) the way they're stored in the RenderGrid changes
too. If a item spans through several "cells" inside the grid, we
will have a reference to it on each of them.

These two changes account for a ~3200% improvement on a i7 M620 in
the test that accompanies this change (15.5 vs 520 run/s).

New perf test: PerformanceTests/Layout/fixed-grid-lots-of-data.html

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computedUsedBreadthOfGridTracks): Keep track
of content sized tracks and only iterate over them.
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
Early return if there are no tracks to pass to the algorithm.

  • rendering/RenderGrid.h:
  • rendering/style/GridLength.h:

(WebCore::GridLength::isContentSized):

  • rendering/style/GridTrackSize.h:

(WebCore::GridTrackSize::isContentSized):

LayoutTests:

From Blink r156028 and r156168 by <​jchaffraix@chromium.org>.

Subtle baseline change due to grids triggering less layouts, which
changes the frame rects between 2 subsequent layouts thus changing
the repaint rectangles.

  • fast/css-grid-layout/grid-item-change-column-repaint-expected.txt:
  • fast/css-grid-layout/grid-item-change-row-repaint-expected.txt:
1:22 AM Changeset in webkit [159683] by Manuel Rego Casasnovas
  • 2 edits in trunk/Source/WebCore

[CSS Regions] Move code after early break in RenderRegion::repaintFlowThreadContentRectangle
​https://bugs.webkit.org/show_bug.cgi?id=124743

Reviewed by Mihnea Ovidenie.

No new tests, covered by existing tests.

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::repaintFlowThreadContentRectangle): Variable
flippedFlowThreadPortionRect is not used before the early break, so we
can move it after and save some unneeded operations.

12:28 AM Changeset in webkit [159682] by Manuel Rego Casasnovas
  • 2 edits in trunk/Source/WebCore

[CSS Regions] Use hasOverflowClip() in RenderRegion
​https://bugs.webkit.org/show_bug.cgi?id=124746

Reviewed by Mihnea Ovidenie.

Implement the suggested FIXME in RenderRegion using hasOverflowClip().

No new tests, covered by existing tests.

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::overflowRectForFlowThreadPortion): Use
hasOverflowClip().
(WebCore::RenderRegion::rectFlowPortionForBox): Ditto.

Note: See TracTimeline for information about the timeline view.