⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 25, 2013:

9:54 PM Changeset in webkit [159779] by weinig@apple.com
  • 17 edits in trunk/Source/WebCore

Convert some Shape code to use references
https://bugs.webkit.org/show_bug.cgi?id=124876

Reviewed by Andreas Kling.

  • inspector/InspectorOverlay.cpp:
  • rendering/FloatingObjects.cpp:
  • rendering/LayoutState.cpp:
  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:
  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:
  • rendering/line/BreakingContextInlineHeaders.h:
  • rendering/line/LineWidth.cpp:
  • rendering/shapes/ShapeInfo.cpp:
  • rendering/shapes/ShapeInfo.h:
  • rendering/shapes/ShapeInsideInfo.cpp:
  • rendering/shapes/ShapeInsideInfo.h:
  • rendering/shapes/ShapeOutsideInfo.cpp:
  • rendering/shapes/ShapeOutsideInfo.h:

Replace yet more pointers with references.

9:46 PM Changeset in webkit [159778] by ryuan.choi@samsung.com
  • 2 edits in trunk

[EFL] E_DBus should be an optional
https://bugs.webkit.org/show_bug.cgi?id=124881

Reviewed by Gyuyoung Kim.

  • Source/cmake/OptionsEfl.cmake:

Checked E_DBus when only ENABLE_BATTERY_STATUS is on.

6:21 PM Changeset in webkit [159777] by Alexandru Chiculita
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: [CSS Regions] A page with many flows should collapse the resources tree
https://bugs.webkit.org/show_bug.cgi?id=122926

Reviewed by Timothy Hatcher.

Refactored the code in FrameTreeElement._shouldGroupIntoFolders to make it easy to track
more types of resources. Added the content flows as another type of resource that would trigger the
collapsing.

  • UserInterface/DOMTreeManager.js:

(WebInspector.DOMTreeManager.prototype.namedFlowRemoved): Added code to remove the content nodes from
a flow that has been removed.

  • UserInterface/FrameTreeElement.js:

(WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders.pushCategory):
(WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders.pushResourceType):
(WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders):

6:16 PM Changeset in webkit [159776] by ryuan.choi@samsung.com
  • 4 edits
    1 delete in trunk

[EFL] Use Config mode of find_package for EFL 1.8
https://bugs.webkit.org/show_bug.cgi?id=124555

Reviewed by Gyuyoung Kim.

.:

EFL 1.8 changed VERSION macro so it's difficult to use tricky approach
which parses header files to know the version. Instead, EFL 1.8 supports
FooConfig.cmake such as EinaConfig.cmake.

This patch tries to use a config mode if it is available.
If config mode is not available with Eo, FindFoo.cmake will be used without
version requirement.

  • Source/cmake/FindEo.cmake: Removed.

EoConfig.cmake is only preffered for EFL 1.8.

  • Source/cmake/OptionsEfl.cmake:

Tools:

  • MiniBrowser/efl/CMakeLists.txt:

Added optional config mode and made version requirement optional.

4:47 PM Changeset in webkit [159775] by mitz@apple.com
  • 7 edits in trunk/Source/WebKit2

[Cocoa] Use class extensions for IPI
https://bugs.webkit.org/show_bug.cgi?id=124870

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKBrowsingContextController.mm: Reordered methods so that the Private

cateogry isn’t stuck between the API methods and the internal methods.
(-[WKBrowsingContextController setPaginationMode:]):
(-[WKBrowsingContextController paginationMode]):
(-[WKBrowsingContextController setPaginationBehavesLikeColumns:]):
(-[WKBrowsingContextController paginationBehavesLikeColumns]):
(-[WKBrowsingContextController setPageLength:]):
(-[WKBrowsingContextController pageLength]):
(-[WKBrowsingContextController setGapBetweenPages:]):
(-[WKBrowsingContextController gapBetweenPages]):
(-[WKBrowsingContextController pageCount]):
(-[WKBrowsingContextController handle]):

  • UIProcess/API/mac/WKBrowsingContextControllerInternal.h: Changed Internal category into

a class extension.

  • UIProcess/API/mac/WKConnection.mm:
  • UIProcess/API/mac/WKConnectionInternal.h: Changed Internal category into a class

extension.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInInternal.h: Ditto.
4:21 PM Changeset in webkit [159774] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Search functionality in MiniBrowser provides feedback on search fail
https://bugs.webkit.org/show_bug.cgi?id=122681

Patch by Andres Gomez <Andres Gomez> on 2013-11-25
Reviewed by Mario Sanchez Prada.

When using the search functionality in MiniBrowser, if the search
fails, the entry background color gets red to report the user
about the failing condition. When the entry is cleaned or the
search is again succesful the background turns back to its
original color.

  • MiniBrowser/gtk/BrowserSearchBar.c:

(setFailedStyleForEntry): Added.
(doSearch): Sets the entry's background to its original style if
there is no text to search.
(findControllerFailedToFindTextCallback): Added.
(findControllerFoundTextCallback): Added.
(browser_search_bar_init): Creates and adds a new CSS provider to
the text entry so we can change its style based on the success
condition of the search.
(browserSearchBarFinalize): Frees the new CSS provider.
(browser_search_bar_new): Connects the two new handlers to the
"failed-to-find-text" and "found-text" signals emitted by the
WebKitFindController.

4:20 PM Changeset in webkit [159773] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Fixed the iOS build.

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadDelegateInternal]):
(-[WKBrowsingContextController setLoadDelegateInternal:]):

3:55 PM Changeset in webkit [159772] by simon.pena@samsung.com
  • 2 edits in trunk/Source/WebCore

[EFL] X11Helper::createPixmap doesn't initialise out value handleId
https://bugs.webkit.org/show_bug.cgi?id=124722

Reviewed by Gyuyoung Kim.

The overloaded functions X11Helper::createPixmap don't initialise out
value handleId, and they do early returns on error situations. Since
the functions are void and they don't communicate their failure in any
way, returning an out value without initialising it could make the
error go farther unnoticed. With the variable being initialised, it can
be reliably checked for errors when the function returns.

  • platform/graphics/surfaces/glx/X11Helper.cpp:

(WebCore::X11Helper::createPixmap): Initialise handleId to 0.

3:50 PM Changeset in webkit [159771] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Mark URLRegistry's lookup() as const and its child classes as final
https://bugs.webkit.org/show_bug.cgi?id=124865

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-25
Reviewed by Eric Carlson.

No new tests needed. No behavior changes.

  • Modules/mediasource/MediaSourceRegistry.cpp:

(WebCore::MediaSourceRegistry::lookup): marked as const.

  • Modules/mediasource/MediaSourceRegistry.h: MediaSourceRegistry

marked as final.

  • Modules/mediastream/MediaStreamRegistry.cpp:

(WebCore::MediaStreamRegistry::lookup): marked as const.

  • Modules/mediastream/MediaStreamRegistry.h: MediaStreamRegistry

marked as final.

  • fileapi/Blob.cpp:
  • html/URLRegistry.h: lookup() marked as const.

(WebCore::URLRegistry::lookup): marked as const.

3:50 PM Changeset in webkit [159770] by mitz@apple.com
  • 9 edits in trunk/Source/WebKit2

[Cocoa] Remove some indirection that was only necessary for supporting the legacy Objective-C runtime
https://bugs.webkit.org/show_bug.cgi?id=123065

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKBrowsingContextController.h: Removed _data ivar and

WKBrowsingContextControllerData class declaration.

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController dealloc]): Removed
WKBrowsingContextControllerData class and moved ivars directly into
WKBrowsingContextController, declaring them in the @implementation. Removed ivar and
accessors for the delegate properties, letting the compiler synthesize them.
(-[WKBrowsingContextController _pageRef]): Removed indirection via _data.
(-[WKBrowsingContextController loadRequest:userData:]): Removed indirection via -_pageRef.
(-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:userData:]): Ditto.
(-[WKBrowsingContextController loadHTMLString:baseURL:userData:]): Ditto.
(-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:userData:]): Ditto.
(-[WKBrowsingContextController stopLoading]): Ditto.
(-[WKBrowsingContextController reload]): Ditto.
(-[WKBrowsingContextController reloadFromOrigin]): Ditto.
(-[WKBrowsingContextController goForward]): Ditto.
(-[WKBrowsingContextController canGoForward]): Ditto.
(-[WKBrowsingContextController goBack]): Ditto.
(-[WKBrowsingContextController canGoBack]): Ditto.
(-[WKBrowsingContextController goToBackForwardListItem:]): Ditto.
(-[WKBrowsingContextController backForwardList]): Ditto.
(-[WKBrowsingContextController activeURL]): Ditto.
(-[WKBrowsingContextController provisionalURL]): Ditto.
(-[WKBrowsingContextController committedURL]): Ditto.
(-[WKBrowsingContextController unreachableURL]): Removed idirection via _data.
(-[WKBrowsingContextController estimatedProgress]): Removed indirection via -_pageRef.
(-[WKBrowsingContextController title]): Ditto.
(-[WKBrowsingContextController textZoom]): Ditto.
(-[WKBrowsingContextController setTextZoom:]): Ditto.
(-[WKBrowsingContextController pageZoom]): Ditto.
(-[WKBrowsingContextController setPageZoom:]): Ditto.
(-[WKBrowsingContextController setPaginationMode:]): Ditto.
(-[WKBrowsingContextController paginationMode]): Ditto.
(-[WKBrowsingContextController setPaginationBehavesLikeColumns:]): Ditto.
(-[WKBrowsingContextController paginationBehavesLikeColumns]): Ditto.
(-[WKBrowsingContextController setPageLength:]): Ditto.
(-[WKBrowsingContextController pageLength]): Ditto.
(-[WKBrowsingContextController setGapBetweenPages:]): Ditto.
(-[WKBrowsingContextController gapBetweenPages]): Ditto.
(-[WKBrowsingContextController pageCount]): Ditto.
(-[WKBrowsingContextController handle]): Ditto.
(-[WKBrowsingContextController _initWithPageRef:]): Removed indirection via _data.

  • UIProcess/API/mac/WKBrowsingContextGroup.h: Removed _data ivar and

WKBrowsingContextGroupData class declaration.

  • UIProcess/API/mac/WKBrowsingContextGroup.mm: Removed WKBrowsingContextGroupData class and

moved _pageGroupRef ivar directly into WKBrowsingContextGroup, declaring it in the
@implementation.
(-[WKBrowsingContextGroup initWithIdentifier:]): Removed indirection via _data.
(-[WKBrowsingContextGroup allowsJavaScript]): Removed indirection via -_pageGroupRef.
(-[WKBrowsingContextGroup setAllowsJavaScript:]): Ditto.
(-[WKBrowsingContextGroup allowsJavaScriptMarkup]): Ditto.
(-[WKBrowsingContextGroup setAllowsJavaScriptMarkup:]): Ditto.
(-[WKBrowsingContextGroup allowsPlugIns]): Ditto.
(-[WKBrowsingContextGroup setAllowsPlugIns:]): Ditto.
(-[WKBrowsingContextGroup addUserStyleSheet:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:mainFrameOnly:]): Ditto.
(-[WKBrowsingContextGroup removeAllUserStyleSheets]): Ditto.
(-[WKBrowsingContextGroup addUserScript:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:injectionTime:mainFrameOnly:]): Ditto.
(-[WKBrowsingContextGroup removeAllUserScripts]): Ditto.
(-[WKBrowsingContextGroup _pageGroupRef]): Removed indirection via _data.

  • UIProcess/API/mac/WKConnection.h: Removed _data ivar and WKConnectionData class declaration.
  • UIProcess/API/mac/WKConnection.mm: Removed WKConnectionData class and moved _connectionRef

ivar directly into WKConnection, declaring it in the @implementation. Removed ivar and
accessors for the delegate property, letting the compiler synthesize them.
(-[WKConnection dealloc]): Removed indirection via _data.
(-[WKConnection sendMessageWithName:body:]): Ditto.
(-[WKConnection remoteObjectRegistry]): Ditto.
(didReceiveMessage): Ditto.
(-[WKConnection _initWithConnectionRef:]): Ditto.

  • UIProcess/API/mac/WKProcessGroup.h: Replaced forward declaration of WKConnection with an

import. Removed _data ivar and WKProcessGroupData class declaration.

  • UIProcess/API/mac/WKProcessGroup.mm: Removed WKProcessGroupData class and moved

_contextRef ivar directly into WKProcessGroup, declaring it in the @implementation. Removed
ivar and accessors for the delegate property, letting the compiler synthesize them.
(-[WKProcessGroup initWithInjectedBundleURL:]): Removed indirection via _data.
(-[WKProcessGroup dealloc]): Ditto.
(-[WKProcessGroup _contextRef]): Ditto.
(-[WKProcessGroup _geolocationProvider]): Ditto.

3:21 PM Changeset in webkit [159769] by commit-queue@webkit.org
  • 14 edits in trunk/Source/WebCore

[MediaStream] Use std::unique_ptr instead of OwnPtr/PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=124858

Patch by Sergio Correia <Sergio Correia> on 2013-11-25
Reviewed by Eric Carlson.

Another step of the OwnPtr/PassOwnPtr => std::unique_ptr conversion,
now targeting mediastream-related code.

No new tests, covered by existing ones.

  • Modules/mediastream/RTCDTMFSender.cpp:
  • Modules/mediastream/RTCDTMFSender.h:
  • Modules/mediastream/RTCDataChannel.cpp:
  • Modules/mediastream/RTCDataChannel.h:
  • Modules/mediastream/RTCPeerConnection.cpp:
  • Modules/mediastream/RTCPeerConnection.h:
  • platform/mediastream/MediaStreamSource.cpp:
  • platform/mediastream/RTCPeerConnectionHandler.cpp:
  • platform/mediastream/RTCPeerConnectionHandler.h:
  • platform/mediastream/RTCPeerConnectionHandlerClient.h:
  • platform/mock/RTCNotifiersMock.cpp:
  • platform/mock/RTCPeerConnectionHandlerMock.cpp:
  • platform/mock/RTCPeerConnectionHandlerMock.h:
3:08 PM Changeset in webkit [159768] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Source/WebKit

[Win] WebKit version in user agent string is incorrect.
https://bugs.webkit.org/show_bug.cgi?id=124454

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-25
Reviewed by Brent Fulgham.

Source/WebKit:

Generate WebKitVersion.h file from mac's Version.xcconfig file.

  • WebKit.vcxproj/WebKit/WebKit.vcxproj:
  • WebKit.vcxproj/WebKit/WebKit.vcxproj.filters:
  • WebKit.vcxproj/WebKit/WebKitVersion.cmd: Added.

Source/WebKit/win:

  • WebView.cpp: Use WebKit version from WebKitVersion.h in user agent.

(webKitVersionString):

2:55 PM Changeset in webkit [159767] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

MediaStreamRegistry should store MediaStreams instead of MediaStreamPrivates
https://bugs.webkit.org/show_bug.cgi?id=124860

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-25
Reviewed by Eric Carlson.

MediaStreamRegistry::lookup() should return a MediaStream instead of MediaStreamPrivate.

No new tests needed. No behavior changes.

  • Modules/mediastream/MediaStreamRegistry.cpp:

(WebCore::MediaStreamRegistry::registerURL): m_privateStreams -> m_mediaStreams
(WebCore::MediaStreamRegistry::unregisterURL): Ditto.
(WebCore::MediaStreamRegistry::lookup): Override URLRegistry::lookup() instead of add a
new method MediaStream::lookupMediaStreamPrivate().

  • Modules/mediastream/MediaStreamRegistry.h:
  • html/HTMLMediaElement.cpp:

(HTMLMediaElement::loadResource): call lookup() instead of lookupMediaStreamPrivate()

2:08 PM Changeset in webkit [159766] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Compile fails when GSTREAMER is not used.
https://bugs.webkit.org/show_bug.cgi?id=124853

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-25
Reviewed by Philippe Normand.

  • platform/graphics/gstreamer/GStreamerUtilities.cpp: Don't include GStreamerUtilities.h when GSTREAMER is not used.
2:02 PM Changeset in webkit [159765] by commit-queue@webkit.org
  • 21 edits in trunk/Source/WebKit2

Unreviewed, rolling out r159740.
http://trac.webkit.org/changeset/159740
https://bugs.webkit.org/show_bug.cgi?id=124859

Crashing xmlhttprequest/access-control-repeated-failed-
preflight-crash.html on Mavericks and Mountain Lion -
ASSERT(m_pageGroup) WebPage.cpp:352 (Requested by dino_ on
#webkit).

  • Scripts/webkit2/messages.py:

(struct_or_class):

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
  • Shared/mac/ObjCObjectGraphCoders.h:
  • Shared/mac/ObjCObjectGraphCoders.mm:

(WebKit::ObjCObjectGraphEncoder::baseEncode):
(WebKit::WebContextObjCObjectGraphEncoderImpl::WebContextObjCObjectGraphEncoderImpl):
(WebKit::WebContextObjCObjectGraphEncoderImpl::encode):
(WebKit::InjectedBundleObjCObjectGraphEncoderImpl::encode):
(WebKit::WebContextObjCObjectGraphEncoder::WebContextObjCObjectGraphEncoder):
(WebKit::WebContextObjCObjectGraphEncoder::encode):

  • UIProcess/WebConnectionToWebProcess.cpp:

(WebKit::WebConnectionToWebProcess::encodeMessageBody):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::createWebPage):
(WebKit::WebContext::postMessageToInjectedBundle):
(WebKit::WebContext::didReceiveSyncMessage):

  • UIProcess/WebContextUserMessageCoders.h:

(WebKit::WebContextUserMessageEncoder::WebContextUserMessageEncoder):
(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::decode):

  • UIProcess/WebPageGroup.cpp:
  • UIProcess/WebPageGroup.h:

(WebKit::WebPageGroup::sendToAllProcessesInGroup):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::loadData):
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadAlternateHTMLString):
(WebKit::WebPageProxy::loadPlainTextString):
(WebKit::WebPageProxy::loadWebArchiveData):
(WebKit::WebPageProxy::postMessageToInjectedBundle):
(WebKit::WebPageProxy::initializeCreationParameters):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::disconnect):
(WebKit::WebProcessProxy::createWebPage):

  • UIProcess/WebProcessProxy.h:
  • WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:

(WebKit::InjectedBundleUserMessageEncoder::encode):
(WebKit::InjectedBundleUserMessageDecoder::decode):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::webPageGroup):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
1:53 PM Changeset in webkit [159764] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Deduplicate shortish Text node strings during tree construction.
<https://webkit.org/b/124855>

Let HTMLConstructionSite keep a hash set of already seen strings over
its lifetime. Use this to deduplicate the strings inside Text nodes
for any string up to 64 characters of length.

This optimization already sort-of existed for whitespace-only Texts,
but those are laundered in the AtomicString table which we definitely
don't want to pollute with every single Text. It might be a good idea
to stop using the AtomicString table for all-whitespace Text too.

3.82 MB progression on HTML5-8266 locally.

Reviewed by Anders Carlsson.

1:36 PM Changeset in webkit [159763] by dino@apple.com
  • 2 edits in trunk/LayoutTests

RenderTableSection Blink merge asserting
https://bugs.webkit.org/show_bug.cgi?id=124857

Skipping these tests for now, since Ossy + Laszlo checked
in a lot of rebaselines and I didn't want to roll
everything out.

1:29 PM Changeset in webkit [159762] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unnecessary MediaStreamTrackDescriptor forward declaration
https://bugs.webkit.org/show_bug.cgi?id=124854

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-25
Reviewed by Eric Carlson.

No new tests needed. No behavior changed.

  • Modules/mediastream/VideoStreamTrack.h:
12:53 PM Changeset in webkit [159761] by mitz@apple.com
  • 1 edit in trunk/Source/WebKit2/ChangeLog

Fixed a typo in the change log.

12:52 PM Changeset in webkit [159760] by mitz@apple.com
  • 52 edits in trunk

[Cocoa] Put most of the Cocoa API behind WK_API_ENABLED guards
https://bugs.webkit.org/show_bug.cgi?id=124850

Reviewed by Brady Eidson.

Source/WebKit2:

Guarded all Cocoa API headers and implementatiosn with WK_API_ENABLED. Left the WKView class
unguarded, but limited its API.

  • Shared/API/Cocoa/WKFoundation.h: Replaced OBJ_VISIBLE with an explicit attribute.
  • Shared/API/Cocoa/WKRemoteObjectCoder.mm: Moved #if WK_API_ENABLED before the rest of the

imports.

  • Shared/API/Cocoa/WKRemoteObjectInterface.mm: Ditto.
  • Shared/API/Cocoa/WKRemoteObjectRegistry.mm: Ditto.
  • Shared/API/Cocoa/WKRemoteObjectRegistryPrivate.h: Ditto.
  • UIProcess/API/mac/WKBrowsingContextController.h: Guarded all declarations with

WK_API_ENABLED, changed to use WK_API_CLASS instead of WK_EXPORT.

  • UIProcess/API/mac/WKBrowsingContextController.mm: Guarded everything with WK_API_ENABLED.

(-[WKBrowsingContextController dealloc]):
(-[WKBrowsingContextController setPolicyDelegate:]):
(-[WKBrowsingContextController backForwardList]):
(didChangeBackForwardList):
(setUpPageLoaderClient):
(setUpPagePolicyClient):
(-[WKBrowsingContextController _initWithPageRef:]):

  • UIProcess/API/mac/WKBrowsingContextControllerInternal.h: Ditto.
  • UIProcess/API/mac/WKBrowsingContextControllerPrivate.h: Ditto.
  • UIProcess/API/mac/WKBrowsingContextGroup.h: Guarded all declarations with WK_API_ENABLED,

chanegd to use WK_API_CLASS instead of WK_EXPORT.

  • UIProcess/API/mac/WKBrowsingContextGroup.mm: Removed redundant import, guarded everything

with WK_API_ENABLED.

  • UIProcess/API/mac/WKBrowsingContextGroupPrivate.h: Guarded with WK_API_ENABLED.
  • UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h: Added necessary import.
  • UIProcess/API/mac/WKConnection.h: Guarded all declarations with WK_API_ENABLED, chanegd to

use WK_API_CLASS instead of WK_EXPORT.

  • UIProcess/API/mac/WKConnection.mm: Guarded everything with WK_API_ENABLED.

(-[WKConnection remoteObjectRegistry]):
(didReceiveMessage):

  • UIProcess/API/mac/WKConnectionInternal.h: Guarded the delcarations with WK_API_ENABLED.
  • UIProcess/API/mac/WKProcessGroup.h: Ditto. Also changed to use WK_API_CLASS instead of

WK_EXPORT.

  • UIProcess/API/mac/WKProcessGroup.mm: Guarded everything with WK_API_ENABLED.

(-[WKProcessGroup initWithInjectedBundleURL:]):

  • UIProcess/API/mac/WKProcessGroupPrivate.h: Guarded the declarations with WK_API_ENABLED.
  • UIProcess/API/mac/WKTypeRefWrapper.h: Moved #if WK_API_ENABLED before the rest of the

imports, changed to use WK_API_CLASS instead of WK_EXPORT.

  • UIProcess/API/mac/WKTypeRefWrapper.mm: Removed empty line after #import "config.h".
  • UIProcess/API/mac/WKView.h: Added #if WK_API_ENABLED around API that uses other Cocoa API

types.

  • UIProcess/API/mac/WKView.mm: Added #if WK_API_ENABLED around implementations of methods

that are only declared when the API is enabled.

  • UIProcess/API/mac/WKViewInternal.h: Reordered imports.
  • UIProcess/mac/WKFullScreenWindowController.mm: Added comment to #endif.
  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess): Guarded use of
WKBrowsingContextController with WK_API_ENABLED.
(WebKit::WebContext::platformInitializeNetworkProcess): Ditto.

  • UIProcess/mac/WebContextMenuProxyMac.mm: Removed newline between imports.
  • WebProcess/InjectedBundle/API/mac/WKDOMDocument.h: Moved #if WK_API_ENABLED before the

rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.

  • WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm: Removed newline after #import

"config.h".

  • WebProcess/InjectedBundle/API/mac/WKDOMElement.h: Moved #if WK_API_ENABLED before the

rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.

  • WebProcess/InjectedBundle/API/mac/WKDOMElement.mm: Removed newline after #import

"config.h".

  • WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm: Ditto.
  • WebProcess/InjectedBundle/API/mac/WKDOMNode.h: Moved #if WK_API_ENABLED before the

rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.

  • WebProcess/InjectedBundle/API/mac/WKDOMNode.mm: Removed redundant import.
  • WebProcess/InjectedBundle/API/mac/WKDOMRange.h: Moved #if WK_API_ENABLED before the

rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.

  • WebProcess/InjectedBundle/API/mac/WKDOMRange.mm: Removed newline and redundant import.
  • WebProcess/InjectedBundle/API/mac/WKDOMText.h: Moved #if WK_API_ENABLED before the

rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.

  • WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.h: Ditto.
  • WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.mm: Removed newline after

#import "config.h".

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h: Moved #if WK_API_ENABLED before

the rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm: Removed newline and redundant

imports.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.h: Moved #if

WK_API_ENABLED before the rest of the imports, and changed to use WK_API_CLASS instead of
WK_EXPORT.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm: Removed

newline after #import "config.h".

Tools:

Added #if WK_API_ENABLED guards around tests that use the Objective-C API.

  • TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
  • TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
  • TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
  • TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
  • TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
  • TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
  • TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
11:10 AM Changeset in webkit [159759] by mitz@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Set the svn:ignore property on the Xcode project to ignore the workspace and user data.

  • WebInspectorUI.xcodeproj: Added property svn:ignore.
10:50 AM Changeset in webkit [159758] by robert@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove code now unnecessary after r159575
https://bugs.webkit.org/show_bug.cgi?id=124809

Reviewed by Antti Koivisto.

Covered by existing tests fast/block/margin-collapse/self-collapsing-block-with-float*

  • rendering/line/LineBreaker.cpp:

(WebCore::LineBreaker::skipLeadingWhitespace):

10:46 AM Changeset in webkit [159757] by robert@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add complex line layout path version of empty-clear-blocks.html
https://bugs.webkit.org/show_bug.cgi?id=124808

Reviewed by Sam Weinig.

  • fast/block/margin-collapse/empty-clear-blocks-complex-expected.html: Added.
  • fast/block/margin-collapse/empty-clear-blocks-complex.html: Added.
10:41 AM Changeset in webkit [159756] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Tools

Unreviewed, rolling out r159752 and r159754.
http://trac.webkit.org/changeset/159752
http://trac.webkit.org/changeset/159754
https://bugs.webkit.org/show_bug.cgi?id=124847

Broke linux test bots. (Requested by mhahnenberg on #webkit).

  • Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
  • Scripts/run-javascriptcore-tests:
  • Scripts/run-jsc-stress-tests:
10:24 AM Changeset in webkit [159755] by Csaba Osztrogonác
  • 20 edits in trunk/LayoutTests

Vertical border spacing is doubled between table row groups
https://bugs.webkit.org/show_bug.cgi?id=20040

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-25
Reviewed by Csaba Osztrogonác.

Rebaseline the rest of EFL and GTK tests.

  • platform/efl/tables/mozilla/bugs/bug10296-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug26178-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug27038-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug278385-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug55789-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/core/backgrounds-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/other/test4-expected.txt:
  • platform/gtk/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/gtk/tables/mozilla/marvin/thead_valign_bottom-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_thead_valign_bottom-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt:
10:02 AM Changeset in webkit [159754] by mhahnenberg@apple.com
  • 2 edits in trunk/Tools

Followup fix after r159752

  • Scripts/run-jsc-stress-tests: We need to handle Release builds too.
9:34 AM Changeset in webkit [159753] by Csaba Osztrogonác
  • 265 edits
    1 add in trunk/LayoutTests

Vertical border spacing is doubled between table row groups
https://bugs.webkit.org/show_bug.cgi?id=20040

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-25
Reviewed by Csaba Osztrogonác.

Rebaseline efl tests (+mac corrections).

  • platform/efl/fast/forms/input-align-expected.png:
  • platform/efl/fast/forms/input-align-expected.txt:
  • platform/efl/fast/forms/input-value-expected.png:
  • platform/efl/fast/forms/input-value-expected.txt:
  • platform/efl/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/efl/fast/table/border-collapsing/004-vertical-expected.txt:
  • platform/efl/fast/table/floating-th-expected.png:
  • platform/efl/fast/table/floating-th-expected.txt:
  • platform/efl/fast/table/frame-and-rules-expected.png:
  • platform/efl/fast/table/frame-and-rules-expected.txt:
  • platform/efl/fast/table/multiple-captions-display-expected.png:
  • platform/efl/fast/table/multiple-captions-display-expected.txt:
  • platform/efl/fast/table/rowindex-expected.png:
  • platform/efl/fast/table/rowindex-expected.txt:
  • platform/efl/fast/table/table-display-types-expected.png:
  • platform/efl/fast/table/table-display-types-expected.txt:
  • platform/efl/fast/table/table-display-types-strict-expected.png:
  • platform/efl/fast/table/table-display-types-strict-expected.txt:
  • platform/efl/fast/table/table-display-types-vertical-expected.png:
  • platform/efl/fast/table/table-display-types-vertical-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug119786-expected.png:
  • platform/efl/tables/mozilla/bugs/bug119786-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug13118-expected.png:
  • platform/efl/tables/mozilla/bugs/bug13118-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug19061-1-expected.png:
  • platform/efl/tables/mozilla/bugs/bug19061-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug19061-2-expected.png:
  • platform/efl/tables/mozilla/bugs/bug19061-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug220536-expected.png:
  • platform/efl/tables/mozilla/bugs/bug220536-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug27038-2-expected.png:
  • platform/efl/tables/mozilla/bugs/bug27038-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug27038-3-expected.png:
  • platform/efl/tables/mozilla/bugs/bug27038-3-expected.txt: Added.
  • platform/efl/tables/mozilla/bugs/bug30418-expected.png:
  • platform/efl/tables/mozilla/bugs/bug30418-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug3263-expected.png:
  • platform/efl/tables/mozilla/bugs/bug3263-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug38916-expected.png:
  • platform/efl/tables/mozilla/bugs/bug38916-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug46268-3-expected.png:
  • platform/efl/tables/mozilla/bugs/bug46268-3-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug46268-5-expected.png:
  • platform/efl/tables/mozilla/bugs/bug46268-5-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug46268-expected.png:
  • platform/efl/tables/mozilla/bugs/bug46268-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug46924-expected.png:
  • platform/efl/tables/mozilla/bugs/bug46924-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug57378-expected.png:
  • platform/efl/tables/mozilla/bugs/bug57378-expected.txt:
  • platform/efl/tables/mozilla/dom/appendTbodyExpand1-expected.png:
  • platform/efl/tables/mozilla/dom/appendTbodyExpand1-expected.txt:
  • platform/efl/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
  • platform/efl/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
  • platform/efl/tables/mozilla/marvin/backgr_position-table-expected.png:
  • platform/efl/tables/mozilla/marvin/backgr_position-table-expected.txt:
  • platform/efl/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
  • platform/efl/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
  • platform/efl/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/efl/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
  • platform/efl/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/efl/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
  • platform/efl/tables/mozilla/marvin/backgr_simple-table-expected.png:
  • platform/efl/tables/mozilla/marvin/backgr_simple-table-expected.txt:
  • platform/efl/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/efl/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
  • platform/efl/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/efl/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
  • platform/efl/tables/mozilla/marvin/body_tfoot-expected.png:
  • platform/efl/tables/mozilla/marvin/body_tfoot-expected.txt:
  • platform/efl/tables/mozilla/marvin/body_thead-expected.png:
  • platform/efl/tables/mozilla/marvin/body_thead-expected.txt:
  • platform/efl/tables/mozilla/marvin/table_rules_groups-expected.png:
  • platform/efl/tables/mozilla/marvin/table_rules_groups-expected.txt:
  • platform/efl/tables/mozilla/marvin/tbody_align_center-expected.png:
  • platform/efl/tables/mozilla/marvin/tbody_align_center-expected.txt:
  • platform/efl/tables/mozilla/marvin/tbody_align_char-expected.png:
  • platform/efl/tables/mozilla/marvin/tbody_align_char-expected.txt:
  • platform/efl/tables/mozilla/marvin/tbody_align_justify-expected.png:
  • platform/efl/tables/mozilla/marvin/tbody_align_justify-expected.txt:
  • platform/efl/tables/mozilla/marvin/tbody_align_left-expected.png:
  • platform/efl/tables/mozilla/marvin/tbody_align_left-expected.txt:
  • platform/efl/tables/mozilla/marvin/tbody_align_right-expected.png:
  • platform/efl/tables/mozilla/marvin/tbody_align_right-expected.txt:
  • platform/efl/tables/mozilla/marvin/tbody_char-expected.png:
  • platform/efl/tables/mozilla/marvin/tbody_char-expected.txt:
  • platform/efl/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/efl/tables/mozilla/marvin/tbody_valign_baseline-expected.txt:
  • platform/efl/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/efl/tables/mozilla/marvin/tbody_valign_bottom-expected.txt:
  • platform/efl/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/efl/tables/mozilla/marvin/tbody_valign_middle-expected.txt:
  • platform/efl/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/efl/tables/mozilla/marvin/tbody_valign_top-expected.txt:
  • platform/efl/tables/mozilla/marvin/tfoot_align_center-expected.png:
  • platform/efl/tables/mozilla/marvin/tfoot_align_center-expected.txt:
  • platform/efl/tables/mozilla/marvin/tfoot_align_char-expected.png:
  • platform/efl/tables/mozilla/marvin/tfoot_align_char-expected.txt:
  • platform/efl/tables/mozilla/marvin/tfoot_align_justify-expected.png:
  • platform/efl/tables/mozilla/marvin/tfoot_align_justify-expected.txt:
  • platform/efl/tables/mozilla/marvin/tfoot_align_left-expected.png:
  • platform/efl/tables/mozilla/marvin/tfoot_align_left-expected.txt:
  • platform/efl/tables/mozilla/marvin/tfoot_align_right-expected.png:
  • platform/efl/tables/mozilla/marvin/tfoot_align_right-expected.txt:
  • platform/efl/tables/mozilla/marvin/tfoot_char-expected.png:
  • platform/efl/tables/mozilla/marvin/tfoot_char-expected.txt:
  • platform/efl/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/efl/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt:
  • platform/efl/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/efl/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt:
  • platform/efl/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/efl/tables/mozilla/marvin/tfoot_valign_middle-expected.txt:
  • platform/efl/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/efl/tables/mozilla/marvin/tfoot_valign_top-expected.txt:
  • platform/efl/tables/mozilla/marvin/thead_align_center-expected.png:
  • platform/efl/tables/mozilla/marvin/thead_align_center-expected.txt:
  • platform/efl/tables/mozilla/marvin/thead_align_char-expected.png:
  • platform/efl/tables/mozilla/marvin/thead_align_char-expected.txt:
  • platform/efl/tables/mozilla/marvin/thead_align_justify-expected.png:
  • platform/efl/tables/mozilla/marvin/thead_align_justify-expected.txt:
  • platform/efl/tables/mozilla/marvin/thead_align_left-expected.png:
  • platform/efl/tables/mozilla/marvin/thead_align_left-expected.txt:
  • platform/efl/tables/mozilla/marvin/thead_align_right-expected.png:
  • platform/efl/tables/mozilla/marvin/thead_align_right-expected.txt:
  • platform/efl/tables/mozilla/marvin/thead_char-expected.png:
  • platform/efl/tables/mozilla/marvin/thead_char-expected.txt:
  • platform/efl/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/efl/tables/mozilla/marvin/thead_valign_baseline-expected.txt:
  • platform/efl/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/efl/tables/mozilla/marvin/thead_valign_bottom-expected.txt:
  • platform/efl/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/efl/tables/mozilla/marvin/thead_valign_middle-expected.txt:
  • platform/efl/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/efl/tables/mozilla/marvin/thead_valign_top-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_table-expected.png:
  • platform/efl/tables/mozilla/marvin/x_table-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_table_border-expected.png:
  • platform/efl/tables/mozilla/marvin/x_table_border-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_table_border_none-expected.png:
  • platform/efl/tables/mozilla/marvin/x_table_border_none-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_table_border_px-expected.png:
  • platform/efl/tables/mozilla/marvin/x_table_border_px-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_table_frame_void-expected.png:
  • platform/efl/tables/mozilla/marvin/x_table_frame_void-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tbody_align_center-expected.png:
  • platform/efl/tables/mozilla/marvin/x_tbody_align_center-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tbody_align_char-expected.png:
  • platform/efl/tables/mozilla/marvin/x_tbody_align_char-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/efl/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tbody_align_left-expected.png:
  • platform/efl/tables/mozilla/marvin/x_tbody_align_left-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tbody_align_right-expected.png:
  • platform/efl/tables/mozilla/marvin/x_tbody_align_right-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tbody_valign_baseline-expected.png:
  • platform/efl/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tbody_valign_bottom-expected.png:
  • platform/efl/tables/mozilla/marvin/x_tbody_valign_bottom-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tbody_valign_middle-expected.png:
  • platform/efl/tables/mozilla/marvin/x_tbody_valign_middle-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tbody_valign_top-expected.png:
  • platform/efl/tables/mozilla/marvin/x_tbody_valign_top-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tfoot_align_center-expected.png:
  • platform/efl/tables/mozilla/marvin/x_tfoot_align_center-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tfoot_align_char-expected.png:
  • platform/efl/tables/mozilla/marvin/x_tfoot_align_char-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/efl/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tfoot_align_left-expected.png:
  • platform/efl/tables/mozilla/marvin/x_tfoot_align_left-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tfoot_align_right-expected.png:
  • platform/efl/tables/mozilla/marvin/x_tfoot_align_right-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tfoot_class-expected.png:
  • platform/efl/tables/mozilla/marvin/x_tfoot_class-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tfoot_id-expected.png:
  • platform/efl/tables/mozilla/marvin/x_tfoot_id-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tfoot_style-expected.png:
  • platform/efl/tables/mozilla/marvin/x_tfoot_style-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.png:
  • platform/efl/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.png:
  • platform/efl/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tfoot_valign_middle-expected.png:
  • platform/efl/tables/mozilla/marvin/x_tfoot_valign_middle-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tfoot_valign_top-expected.png:
  • platform/efl/tables/mozilla/marvin/x_tfoot_valign_top-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_thead_align_center-expected.png:
  • platform/efl/tables/mozilla/marvin/x_thead_align_center-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_thead_align_char-expected.png:
  • platform/efl/tables/mozilla/marvin/x_thead_align_char-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_thead_align_justify-expected.png:
  • platform/efl/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_thead_align_left-expected.png:
  • platform/efl/tables/mozilla/marvin/x_thead_align_left-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_thead_align_right-expected.png:
  • platform/efl/tables/mozilla/marvin/x_thead_align_right-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_thead_class-expected.png:
  • platform/efl/tables/mozilla/marvin/x_thead_class-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_thead_id-expected.png:
  • platform/efl/tables/mozilla/marvin/x_thead_id-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_thead_style-expected.png:
  • platform/efl/tables/mozilla/marvin/x_thead_style-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_thead_valign_baseline-expected.png:
  • platform/efl/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_thead_valign_bottom-expected.png:
  • platform/efl/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_thead_valign_middle-expected.png:
  • platform/efl/tables/mozilla/marvin/x_thead_valign_middle-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_thead_valign_top-expected.png:
  • platform/efl/tables/mozilla/marvin/x_thead_valign_top-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug4294-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug4294-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug46268-4-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug51000-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug51000-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug8499-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug8499-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.png:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.txt:
  • platform/mac-mountainlion/fast/forms/input-value-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/bugs/bug26178-expected.txt:
  • platform/mac/fast/forms/input-value-expected.txt:
9:29 AM Changeset in webkit [159752] by mhahnenberg@apple.com
  • 3 edits
    1 delete in trunk/Tools

run-jsc-stress-tests should be able to package its tests and move them places
https://bugs.webkit.org/show_bug.cgi?id=124549

Reviewed by Filip Pizlo.

  • Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation

of grep -i -q

  • Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
  • Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory.

We now also copy whatever VM was specified, along with its associated framework, into this directory.
All of the generated scripts now are completely relative within the results directory. This allows
run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a
tarball of the generated results directory. Also refactored several portions of the script into
separate functions to make it easier to run them conditionally depending on which mode we're running in.

9:02 AM Changeset in webkit [159751] by Csaba Osztrogonác
  • 271 edits
    1 add in trunk/LayoutTests

Vertical border spacing is doubled between table row groups
https://bugs.webkit.org/show_bug.cgi?id=20040

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-25
Reviewed by Csaba Osztrogonác.

Rebase GTK results after r159747.

  • platform/gtk/fast/forms/input-value-expected.png:
  • platform/gtk/fast/forms/input-value-expected.txt:
  • platform/gtk/fast/table/011-expected.txt:
  • platform/gtk/fast/table/border-collapsing/004-expected.txt:
  • platform/gtk/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/gtk/fast/table/border-collapsing/004-vertical-expected.txt:
  • platform/gtk/fast/table/floating-th-expected.png:
  • platform/gtk/fast/table/floating-th-expected.txt:
  • platform/gtk/fast/table/frame-and-rules-expected.png:
  • platform/gtk/fast/table/frame-and-rules-expected.txt:
  • platform/gtk/fast/table/rowindex-expected.png:
  • platform/gtk/fast/table/rowindex-expected.txt:
  • platform/gtk/fast/table/table-display-types-expected.png:
  • platform/gtk/fast/table/table-display-types-expected.txt:
  • platform/gtk/fast/table/table-display-types-strict-expected.png:
  • platform/gtk/fast/table/table-display-types-strict-expected.txt:
  • platform/gtk/fast/table/table-display-types-vertical-expected.png:
  • platform/gtk/fast/table/table-display-types-vertical-expected.txt:
  • platform/gtk/fast/table/tableInsideCaption-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug10296-1-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug119786-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug119786-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug13118-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug13118-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug19061-1-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug19061-1-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug19061-2-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug19061-2-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug220536-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug220536-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug26178-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug26178-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug27038-1-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug27038-2-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug27038-2-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug27038-3-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug27038-3-expected.txt: Added.
  • platform/gtk/tables/mozilla/bugs/bug278385-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug30418-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug30418-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug3263-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug3263-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug38916-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug38916-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug46268-3-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug46268-3-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug46268-5-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug46268-5-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug46268-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug46268-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug46924-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug46924-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug55789-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug57378-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug57378-expected.txt:
  • platform/gtk/tables/mozilla/dom/appendTbodyExpand1-expected.png:
  • platform/gtk/tables/mozilla/dom/appendTbodyExpand1-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
  • platform/gtk/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_position-table-expected.png:
  • platform/gtk/tables/mozilla/marvin/backgr_position-table-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-expected.png:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
  • platform/gtk/tables/mozilla/marvin/body_tfoot-expected.png:
  • platform/gtk/tables/mozilla/marvin/body_tfoot-expected.txt:
  • platform/gtk/tables/mozilla/marvin/body_thead-expected.png:
  • platform/gtk/tables/mozilla/marvin/body_thead-expected.txt:
  • platform/gtk/tables/mozilla/marvin/table_rules_groups-expected.png:
  • platform/gtk/tables/mozilla/marvin/table_rules_groups-expected.txt:
  • platform/gtk/tables/mozilla/marvin/tbody_align_center-expected.png:
  • platform/gtk/tables/mozilla/marvin/tbody_align_center-expected.txt:
  • platform/gtk/tables/mozilla/marvin/tbody_align_char-expected.png:
  • platform/gtk/tables/mozilla/marvin/tbody_align_char-expected.txt:
  • platform/gtk/tables/mozilla/marvin/tbody_align_justify-expected.png:
  • platform/gtk/tables/mozilla/marvin/tbody_align_justify-expected.txt:
  • platform/gtk/tables/mozilla/marvin/tbody_align_left-expected.png:
  • platform/gtk/tables/mozilla/marvin/tbody_align_left-expected.txt:
  • platform/gtk/tables/mozilla/marvin/tbody_align_right-expected.png:
  • platform/gtk/tables/mozilla/marvin/tbody_align_right-expected.txt:
  • platform/gtk/tables/mozilla/marvin/tbody_char-expected.png:
  • platform/gtk/tables/mozilla/marvin/tbody_char-expected.txt:
  • platform/gtk/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/gtk/tables/mozilla/marvin/tbody_valign_baseline-expected.txt:
  • platform/gtk/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/gtk/tables/mozilla/marvin/tbody_valign_bottom-expected.txt:
  • platform/gtk/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/gtk/tables/mozilla/marvin/tbody_valign_middle-expected.txt:
  • platform/gtk/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/gtk/tables/mozilla/marvin/tbody_valign_top-expected.txt:
  • platform/gtk/tables/mozilla/marvin/tfoot_align_center-expected.png:
  • platform/gtk/tables/mozilla/marvin/tfoot_align_center-expected.txt:
  • platform/gtk/tables/mozilla/marvin/tfoot_align_char-expected.png:
  • platform/gtk/tables/mozilla/marvin/tfoot_align_char-expected.txt:
  • platform/gtk/tables/mozilla/marvin/tfoot_align_justify-expected.png:
  • platform/gtk/tables/mozilla/marvin/tfoot_align_justify-expected.txt:
  • platform/gtk/tables/mozilla/marvin/tfoot_align_left-expected.png:
  • platform/gtk/tables/mozilla/marvin/tfoot_align_left-expected.txt:
  • platform/gtk/tables/mozilla/marvin/tfoot_align_right-expected.png:
  • platform/gtk/tables/mozilla/marvin/tfoot_align_right-expected.txt:
  • platform/gtk/tables/mozilla/marvin/tfoot_char-expected.png:
  • platform/gtk/tables/mozilla/marvin/tfoot_char-expected.txt:
  • platform/gtk/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/gtk/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt:
  • platform/gtk/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/gtk/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt:
  • platform/gtk/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/gtk/tables/mozilla/marvin/tfoot_valign_middle-expected.txt:
  • platform/gtk/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/gtk/tables/mozilla/marvin/tfoot_valign_top-expected.txt:
  • platform/gtk/tables/mozilla/marvin/thead_align_center-expected.png:
  • platform/gtk/tables/mozilla/marvin/thead_align_center-expected.txt:
  • platform/gtk/tables/mozilla/marvin/thead_align_char-expected.png:
  • platform/gtk/tables/mozilla/marvin/thead_align_char-expected.txt:
  • platform/gtk/tables/mozilla/marvin/thead_align_justify-expected.png:
  • platform/gtk/tables/mozilla/marvin/thead_align_justify-expected.txt:
  • platform/gtk/tables/mozilla/marvin/thead_align_left-expected.png:
  • platform/gtk/tables/mozilla/marvin/thead_align_left-expected.txt:
  • platform/gtk/tables/mozilla/marvin/thead_align_right-expected.png:
  • platform/gtk/tables/mozilla/marvin/thead_align_right-expected.txt:
  • platform/gtk/tables/mozilla/marvin/thead_char-expected.png:
  • platform/gtk/tables/mozilla/marvin/thead_char-expected.txt:
  • platform/gtk/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/gtk/tables/mozilla/marvin/thead_valign_baseline-expected.txt:
  • platform/gtk/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/gtk/tables/mozilla/marvin/thead_valign_middle-expected.txt:
  • platform/gtk/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/gtk/tables/mozilla/marvin/thead_valign_top-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_table-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_table-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_table_border-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_table_border-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_table_border_none-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_table_border_none-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_table_border_px-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_table_border_px-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_table_frame_void-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_table_frame_void-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tbody_align_center-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_tbody_align_center-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tbody_align_char-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_tbody_align_char-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tbody_align_left-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_tbody_align_left-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tbody_align_right-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_tbody_align_right-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tbody_valign_baseline-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tbody_valign_bottom-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_tbody_valign_bottom-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tbody_valign_middle-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_tbody_valign_middle-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tbody_valign_top-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_tbody_valign_top-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tfoot_align_center-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_tfoot_align_center-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tfoot_align_char-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_tfoot_align_char-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tfoot_align_left-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_tfoot_align_left-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tfoot_align_right-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_tfoot_align_right-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tfoot_class-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_tfoot_class-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tfoot_id-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_tfoot_id-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tfoot_style-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_tfoot_style-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tfoot_valign_middle-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_tfoot_valign_middle-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tfoot_valign_top-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_tfoot_valign_top-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_thead_align_center-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_thead_align_center-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_thead_align_char-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_thead_align_char-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_thead_align_justify-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_thead_align_left-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_thead_align_left-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_thead_align_right-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_thead_align_right-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_thead_class-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_thead_class-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_thead_id-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_thead_id-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_thead_style-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_thead_style-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_thead_valign_baseline-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_thead_valign_middle-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_thead_valign_middle-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_thead_valign_top-expected.png:
  • platform/gtk/tables/mozilla/marvin/x_thead_valign_top-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug4294-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug4294-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug46268-4-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug51000-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug51000-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/core/backgrounds-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:
8:04 AM Changeset in webkit [159750] by Csaba Osztrogonác
  • 117 edits
    2 adds in trunk/LayoutTests

Vertical border spacing is doubled between table row groups
https://bugs.webkit.org/show_bug.cgi?id=20040

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-25
Reviewed by Csaba Osztrogonác.

Rebase Mac results after r159747.

  • platform/mac/tables/mozilla/bugs/bug119786-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug19061-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug220536-expected.txt: Added.
  • platform/mac/tables/mozilla/bugs/bug26178-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug27038-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug27038-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug27038-3-expected.txt: Added.
  • platform/mac/tables/mozilla/bugs/bug278385-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug30418-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug38916-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46268-3-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46268-5-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46268-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46924-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug55789-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug57378-expected.txt:
  • platform/mac/tables/mozilla/marvin/table_rules_groups-expected.txt:
  • platform/mac/tables/mozilla/marvin/tbody_align_center-expected.txt:
  • platform/mac/tables/mozilla/marvin/tbody_align_char-expected.txt:
  • platform/mac/tables/mozilla/marvin/tbody_align_justify-expected.txt:
  • platform/mac/tables/mozilla/marvin/tbody_align_left-expected.txt:
  • platform/mac/tables/mozilla/marvin/tbody_align_right-expected.txt:
  • platform/mac/tables/mozilla/marvin/tbody_char-expected.txt:
  • platform/mac/tables/mozilla/marvin/tbody_valign_baseline-expected.txt:
  • platform/mac/tables/mozilla/marvin/tbody_valign_bottom-expected.txt:
  • platform/mac/tables/mozilla/marvin/tbody_valign_middle-expected.txt:
  • platform/mac/tables/mozilla/marvin/tbody_valign_top-expected.txt:
  • platform/mac/tables/mozilla/marvin/tfoot_align_center-expected.txt:
  • platform/mac/tables/mozilla/marvin/tfoot_align_char-expected.txt:
  • platform/mac/tables/mozilla/marvin/tfoot_align_justify-expected.txt:
  • platform/mac/tables/mozilla/marvin/tfoot_align_left-expected.txt:
  • platform/mac/tables/mozilla/marvin/tfoot_align_right-expected.txt:
  • platform/mac/tables/mozilla/marvin/tfoot_char-expected.txt:
  • platform/mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt:
  • platform/mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt:
  • platform/mac/tables/mozilla/marvin/tfoot_valign_middle-expected.txt:
  • platform/mac/tables/mozilla/marvin/tfoot_valign_top-expected.txt:
  • platform/mac/tables/mozilla/marvin/thead_align_center-expected.txt:
  • platform/mac/tables/mozilla/marvin/thead_align_char-expected.txt:
  • platform/mac/tables/mozilla/marvin/thead_align_justify-expected.txt:
  • platform/mac/tables/mozilla/marvin/thead_align_left-expected.txt:
  • platform/mac/tables/mozilla/marvin/thead_align_right-expected.txt:
  • platform/mac/tables/mozilla/marvin/thead_char-expected.txt:
  • platform/mac/tables/mozilla/marvin/thead_valign_baseline-expected.txt:
  • platform/mac/tables/mozilla/marvin/thead_valign_bottom-expected.txt:
  • platform/mac/tables/mozilla/marvin/thead_valign_middle-expected.txt:
  • platform/mac/tables/mozilla/marvin/thead_valign_top-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_table-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_table_border-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_table_border_none-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_table_border_px-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_table_frame_void-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tbody_align_center-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tbody_align_char-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tbody_align_left-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tbody_align_right-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tbody_valign_bottom-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tbody_valign_middle-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tbody_valign_top-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tfoot_align_center-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tfoot_align_char-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tfoot_align_left-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tfoot_align_right-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tfoot_class-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tfoot_id-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tfoot_style-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tfoot_valign_middle-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tfoot_valign_top-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_thead_align_center-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_thead_align_char-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_thead_align_left-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_thead_align_right-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_thead_class-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_thead_id-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_thead_style-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_thead_valign_middle-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_thead_valign_top-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug4294-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug51000-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/core/backgrounds-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:
7:48 AM Changeset in webkit [159749] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

EWS creates 0 byte sized log files
https://bugs.webkit.org/show_bug.cgi?id=107606

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-11-25
Reviewed by Ryosuke Niwa.

There was a modification in r138264, that tried to make less log,
because some of the messeges were duplicated. After this the EWS
created the log file (with the same name as the bugID) but doesn't
write anything into it, even if there were errors during the build.
From now only creates the log file only if there is some error.

  • Scripts/webkitpy/tool/bot/queueengine.py:

(QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
there is nothing to log. Open the log file only if a ScriptError was raised to
avoid to make empty log files for bugs.
(QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
because of changes in r138264. Teeing is used for locally testing purposes and
this feature is not used anymore.
(QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output
teeing anymore. It is a necessary change because of QueueEngine._open_work_log
change.

  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:

(LoggingDelegate): The order of the callbacks was changed by this patch.
(QueueEngineTest.test_trivial): Won't create log file if the queue was terminated,
so we have to update this test.
(QueueEngineTest.test_unexpected_error): The order of the callbacks was changed by
this patch.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
to be able to handle it in QueueEngine.run. Without this change, the existing
exception handler never run (the process_work_item method never raise ScriptError)
We can get the error message only from the ScriptError at this point.

7:28 AM Changeset in webkit [159748] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[arm][mips] Fix crash in dfg-arrayify-elimination layout jsc test.
https://bugs.webkit.org/show_bug.cgi?id=124839

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-25
Reviewed by Michael Saboff.

In ARM EABI and MIPS, 64-bit values have to be aligned on stack too.

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):

  • jit/JITInlines.h:

(JSC::JIT::callOperation): Add missing EABI_32BIT_DUMMY_ARG.

6:57 AM Changeset in webkit [159747] by Csaba Osztrogonác
  • 33 edits in trunk

Vertical border spacing is doubled between table row groups
https://bugs.webkit.org/show_bug.cgi?id=20040

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-25
Reviewed by Csaba Osztrogonác.

Source/WebCore:

Based on Chromium fix https://chromium.googlesource.com/chromium/blink/+/eb615069267f895c59bc576f9d65b3fa5add41e9

Rebaseline needed for table related tests (100+).

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):

LayoutTests:

First tuple of rebaselined tests for mac. Rebaseline needed for table related tests (100+).

  • fast/table/anonymous-table-section-removed.html:
  • platform/mac/accessibility/table-detection-expected.txt:
  • platform/mac/editing/deleting/deletionUI-single-instance-expected.txt:
  • platform/mac/fast/forms/input-value-expected.txt:
  • platform/mac/fast/table/011-expected.txt:
  • platform/mac/fast/table/border-collapsing/004-expected.txt:
  • platform/mac/fast/table/border-collapsing/004-vertical-expected.txt:
  • platform/mac/fast/table/floating-th-expected.txt:
  • platform/mac/fast/table/frame-and-rules-expected.txt:
  • platform/mac/fast/table/multiple-captions-display-expected.txt:
  • platform/mac/fast/table/rowindex-expected.txt:
  • platform/mac/fast/table/table-display-types-expected.txt:
  • platform/mac/fast/table/table-display-types-strict-expected.txt:
  • platform/mac/fast/table/table-display-types-vertical-expected.txt:
  • platform/mac/fast/table/tableInsideCaption-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug10296-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug13118-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug19061-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug3263-expected.txt:
  • platform/mac/tables/mozilla/dom/appendTbodyExpand1-expected.txt:
  • platform/mac/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
  • platform/mac/tables/mozilla/marvin/backgr_position-table-expected.txt:
  • platform/mac/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
  • platform/mac/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
  • platform/mac/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
  • platform/mac/tables/mozilla/marvin/backgr_simple-table-expected.txt:
  • platform/mac/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
  • platform/mac/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
  • platform/mac/tables/mozilla/marvin/body_tfoot-expected.txt:
  • platform/mac/tables/mozilla/marvin/body_thead-expected.txt:
6:03 AM Changeset in webkit [159746] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

[GStreamer] Seeking fails on media content provided by servers not supporting Range requests
https://bugs.webkit.org/show_bug.cgi?id=85994

Patch by Andres Gomez <Andres Gomez> on 2013-11-25
Reviewed by Philippe Normand.

Source/WebCore:

Based on the patch written by Andre Moreira Magalhaes.

When the GStreamer web source was doing a "Range" request we were
expecting to receive a 206 status reply with the "Content-Range"
header and just the requested data. Supporting "Range" requests is
not mandatory so, for the servers not supporting it they will be
replying with a 200 status and the whole content of the media
element. Now, we are properly handling these replies too.

Test: http/tests/media/media-seeking-no-ranges-server.html

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(StreamingClient::handleResponseReceived): Do not fail when
receiving 200 as response for HTTP range requests.
(StreamingClient::handleDataReceived): Manually seek on stream
when receiving the full data after a seek.

LayoutTests:

Added test to check that seeking media files on http servers not
supporting "Range" requests doesn't trigger an error.

  • http/tests/media/media-seeking-no-ranges-server-expected.txt: Added.
  • http/tests/media/media-seeking-no-ranges-server.html: Added.
  • http/tests/media/resources/load-video.php: Added support for new

"ranges" paramenter.

  • http/tests/media/resources/serve-video.php: Added support for

new "ranges" paramenter. When "ranges" is "no" we always answer
the HTTP status "200 OK" and send the whole file.

  • platform/mac/TestExpectations: New test skipped in Mac port as

media playback download control is passed to AVFoundation that
doesn't like fancy PHP URLs like the one used in the test and, in
addition, they won't care about HTTP servers not supporting
"Range" requests.

4:14 AM Changeset in webkit [159745] by stavila@adobe.com
  • 2 edits in trunk/Source/WebCore

Removed obsolete FIXME after the landing of visual overflow patch (https://bugs.webkit.org/show_bug.cgi?id=118665).
https://bugs.webkit.org/show_bug.cgi?id=124833

Reviewed by Mihnea Ovidenie.

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::layoutBlock):

3:36 AM Changeset in webkit [159744] by mario.prada@samsung.com
  • 3 edits in trunk/LayoutTests

Unreviewed GTK gardening. Removed expectations for test that is no
longer failing for the GTK bots, according to the flakiness dashboard.

  • platform/gtk-wk2/TestExpectations: Removed expectation.
  • platform/gtk/TestExpectations: Ditto.
3:19 AM Changeset in webkit [159743] by zandobersek@gmail.com
  • 3 edits
    2 deletes in trunk/LayoutTests

Unreviewed GTK gardening.
Managing current failures and removing redundant baselines.

  • platform/gtk-wk2/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/gtk/fast/dom/gc-attribute-node-expected.txt: Removed.
  • platform/gtk/fast/repaint/increasing-region-content-height-expected.txt: Removed.
1:52 AM Changeset in webkit [159742] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Need to update EFL TestExpectations file
https://bugs.webkit.org/show_bug.cgi?id=124825

Unreviewed, EFL gardening.

webgl/1.0.2/conformance/extensions/webgl-compressed-texture-s3tc.html
webgl/conformance/extensions/webgl-compressed-texture-s3tc.html
Above two tests are passed in Webkit2 layout test after r158798.

Patch by Jongwoo Choi <jw0330.choi@samsung.com> on 2013-11-25

  • platform/efl-wk1/TestExpectations:
  • platform/efl/TestExpectations:
12:22 AM Changeset in webkit [159741] by svillar@igalia.com
  • 3 edits in trunk/Source/WebCore

[CSS Grid Layout] Cache several vectors to avoid malloc/free churn
https://bugs.webkit.org/show_bug.cgi?id=123995

Reviewed by Dean Jackson.

From Blink r158228 by <jchaffraix@chromium.org>

Laying-out the grid items means a lot of calls to
distributeSpaceToTracks() and
resolveContentBasedTrackSizingFunctionsForItems() as they're
called in a loop. This means that there is a lot of malloc/free
going on there. By moving the vectors used by these methods to a
new class which is kept during the whole layout process we save a
lot of those calls.

This obviously mean that the price we pay for a significant
perfomance improvement is that we keep the maximum allocation till
the end of each layout, but it's an amount of memory that we have
to allocate anyway. The improvement in the
auto-grid-lots-of-data.html perf test is ~24% (165 runs/s vs 207
runs/s).

No new tests required as we're just refactoring code to a new
helper class. Nevertheless the performance improvement is backed
by the perf test mentioned above.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::GridSizingData::GridSizingData):
(WebCore::RenderGrid::computedUsedBreadthOfGridTracks):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
(WebCore::RenderGrid::distributeSpaceToTracks):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::findChildLogicalPosition):

  • rendering/RenderGrid.h:

Nov 24, 2013:

7:09 PM Changeset in webkit [159740] by weinig@apple.com
  • 21 edits in trunk/Source/WebKit2

WebPageGroup's should keep track of what processes they are being used by
https://bugs.webkit.org/show_bug.cgi?id=124556

Reviewed by Dan Bernstein.

  • Scripts/webkit2/messages.py:

(struct_or_class):
Mark WebPageGroupData as a struct.

  • Shared/UserMessageCoders.h:
  • Shared/mac/ObjCObjectGraphCoders.h:
  • Shared/mac/ObjCObjectGraphCoders.mm:
  • WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
  • UIProcess/WebConnectionToWebProcess.cpp:
  • UIProcess/WebContext.cpp:
  • UIProcess/WebContextUserMessageCoders.h:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:

Pass the WebProcess/WebProcessProxy to both encode and decode.

  • Shared/WebPageCreationParameters.h:

Pass the page group by ID when creating a page, as it will have had its own
creation message sent already.

  • UIProcess/WebPageGroup.cpp:
  • UIProcess/WebPageGroup.h:

Keep track of processes.

  • UIProcess/WebProcessProxy.cpp:
  • UIProcess/WebProcessProxy.h:

Keep track of the page groups used by the process.

  • WebProcess/WebPage/WebPage.cpp:

Get the already create page group on creation.

  • WebProcess/WebProcess.cpp:
  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:

Explicitly create page groups in the WebProcess.

6:00 PM Changeset in webkit [159739] by jinwoo7.song@samsung.com
  • 13 edits
    1 add in trunk/LayoutTests

Unreviewed EFL gardening. Rebaselining various tests under fast/

  • platform/efl/fast/backgrounds/background-position-parsing-expected.png:
  • platform/efl/fast/backgrounds/background-position-parsing-expected.txt:
  • platform/efl/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/efl/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
  • platform/efl/fast/css/empty-pseudo-class-expected.png:
  • platform/efl/fast/css/empty-pseudo-class-expected.txt:
  • platform/efl/fast/css/fieldset-display-row-expected.txt:
  • platform/efl/fast/css/first-child-pseudo-class-expected.png:
  • platform/efl/fast/css/first-child-pseudo-class-expected.txt:
  • platform/efl/fast/css/last-child-pseudo-class-expected.png:
  • platform/efl/fast/css/last-child-pseudo-class-expected.txt:
  • platform/efl/fast/css/only-child-pseudo-class-expected.png:
  • platform/efl/fast/css/only-child-pseudo-class-expected.txt:
4:10 PM Changeset in webkit [159738] by jinwoo7.song@samsung.com
  • 4 edits in trunk/LayoutTests

Unreviewed EFL gardening. Rebaselining after r159579.

  • platform/efl/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/efl/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
  • platform/efl/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
3:12 PM Changeset in webkit [159737] by beidson@apple.com
  • 12 edits
    2 copies
    2 adds in trunk/Source

DatabaseProcess: Add "UniqueIDBDatabase" that multiple WebProcesses can connect to
https://bugs.webkit.org/show_bug.cgi?id=124819

Reviewed by Dan Bernstein.

Source/WebCore:

  • Modules/indexeddb/IDBDatabaseBackend.cpp:

(WebCore::IDBDatabaseBackend::~IDBDatabaseBackend): Unregister from the IDBFactory.

Source/WebKit2:

UniqueIDBDatabase instances are per-DatabaseProcess, so it manages the set of them.

  • DatabaseProcess/DatabaseProcess.cpp:

(WebKit::DatabaseProcess::getOrCreateUniqueIDBDatabase):
(WebKit::DatabaseProcess::removeUniqueIDBDatabase):

  • DatabaseProcess/DatabaseProcess.h:
  • DatabaseProcess/DatabaseToWebProcessConnection.h:

Start forwarding things along to the appropriate UniqueIDBDatabase.

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

(WebKit::DatabaseProcessIDBConnection::~DatabaseProcessIDBConnection):
(WebKit::DatabaseProcessIDBConnection::disconnectedFromWebProcess):
(WebKit::DatabaseProcessIDBConnection::establishConnection):
(WebKit::DatabaseProcessIDBConnection::getOrEstablishIDBDatabaseMetadata):

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:

A class that represents a single concrete IDB database that multiple WebProcesses can connect to.

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::UniqueIDBDatabase):
(WebKit::UniqueIDBDatabase::~UniqueIDBDatabase):
(WebKit::UniqueIDBDatabase::registerConnection):
(WebKit::UniqueIDBDatabase::unregisterConnection):
(WebKit::UniqueIDBDatabase::getIDBDatabaseMetadata):

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:

(WebKit::UniqueIDBDatabase::create):
(WebKit::UniqueIDBDatabase::identifier):

A class to help uniquely identify an IDBDatabase that can be expanded as needed.
Importantly, it knows how to be used as a key in a HashMap.

  • DatabaseProcess/IndexedDB/UniqueIDBDatabaseIdentifier.cpp: Added.

(WebKit::UniqueIDBDatabaseIdentifier::UniqueIDBDatabaseIdentifier):
(WebKit::UniqueIDBDatabaseIdentifier::isHashTableDeletedValue):
(WebKit::UniqueIDBDatabaseIdentifier::hash):
(WebKit::UniqueIDBDatabaseIdentifier::isNull):
(WebKit::operator==):

  • DatabaseProcess/IndexedDB/UniqueIDBDatabaseIdentifier.h: Added.

(WebKit::UniqueIDBDatabaseIdentifier::databaseName):
(WebKit::UniqueIDBDatabaseIdentifier::openingOrigin):
(WebKit::UniqueIDBDatabaseIdentifier::mainFrameOrigin):
(WebKit::UniqueIDBDatabaseIdentifierHash::hash):
(WebKit::UniqueIDBDatabaseIdentifierHash::equal):
(WebKit::UniqueIDBDatabaseIdentifierHashTraits::isEmptyValue):

  • Shared/SecurityOriginData.cpp:

(WebKit::operator==):

  • Shared/SecurityOriginData.h:
  • UIProcess/WebContext.cpp:
  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:

(WebKit::WebIDBFactoryBackend::open):
(WebKit::WebIDBFactoryBackend::removeIDBDatabaseBackend):

  • WebKit2.xcodeproj/project.pbxproj:
1:46 PM Changeset in webkit [159736] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

Fix more fallout from failed attempts at div/mod DFG strength reductions
https://bugs.webkit.org/show_bug.cgi?id=124813

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArithMod):

LayoutTests:

  • js/dfg-mod-1-int.html: Added.
  • js/dfg-mod-1-int-expected.txt: Added.
  • js/script-tests/dfg-mod-1-int.js: Added.

(foo):

11:14 AM Changeset in webkit [159735] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WTF

Upstream USE(IOSURFACE) from the iOS port
https://bugs.webkit.org/show_bug.cgi?id=124814

Reviewed by Sam Weinig.

Some code guarded by USE(IOSURFACE) was recently upstreamed,
but not the definition of WTF_USE_IOSURFACE itself.

  • wtf/Platform.h:
10:20 AM Changeset in webkit [159734] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebKit2

[WK2][GTK] Adding SpatialNavigation setting to webkit2
https://bugs.webkit.org/show_bug.cgi?id=114298

Patch by Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk>, Arunprasad Rajkumar <arurajku@cisco.com> on 2013-11-24
Reviewed by Anders Carlsson.

Adding SpatialNavigation support to WebPreferencesStore allows us
to toggle that feature on WebKitSettings.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetSpatialNavigationEnabled):
(WKPreferencesGetSpatialNavigationEnabled):

  • UIProcess/API/C/WKPreferences.h:
  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_set_enable_spatial_navigation):
(webkit_settings_get_enable_spatial_navigation):

  • UIProcess/API/gtk/WebKitSettings.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

7:24 AM Changeset in webkit [159733] by gyuyoung.kim@samsung.com
  • 18 edits in trunk/Source/WebCore

Generate toHTMLMarquee|OListElement() to cleanup static_cast<>
https://bugs.webkit.org/show_bug.cgi?id=124707

Reviewed by Darin Adler.

As a step to use toFoo(), we need to generate toHTMLMarquee|OListElement().
Besides this patch cleans up remaining static_cast<> usage.

No new tests, no behavior changes.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::State::initElement):
(WebCore::StyleResolver::locateCousinList):
(WebCore::StyleResolver::findSiblingForStyleSharing):

  • dom/Attr.cpp:

(WebCore::Attr::style):

  • dom/Element.cpp:

(WebCore::Element::removeAttribute):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::wrappingStyleForSerialization):

  • editing/Editor.cpp:

(WebCore::Editor::applyEditingStyleToElement):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):

  • html/HTMLMarqueeElement.h:
  • html/HTMLOListElement.h:
  • html/HTMLTagNames.in:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):

  • inspector/InspectorOverlay.cpp:

(WebCore::buildObjectForElementInfo):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):

  • rendering/RenderCounter.cpp:

(WebCore::planCounter):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::resize):

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::calcValue):
(WebCore::RenderListItem::updateListMarkerNumbers):

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::marqueeSpeed):

12:34 AM Changeset in webkit [159732] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r156291): TileController tiles don't always repaint when they resize
https://bugs.webkit.org/show_bug.cgi?id=124796

Reviewed by Simon Fraser.

In removing platformCALayerDidCreateTiles, r156291 also removed
the call to setNeedsDisplay when tiles are resized, without
putting it somewhere else.

  • platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::setNeedsDisplay):
Use hasStaleContent when invalidating a whole tile, just
like we do for partial tile repaints.

(WebCore::TileController::setTileNeedsDisplayInRect):
Mark hasStaleContent for any unparented layers, so they'll be painted
when they are reparented.

(WebCore::TileController::ensureTilesForRect):
Invalidate the whole tile when it changes size.

Note: See TracTimeline for information about the timeline view.