Timeline
Dec 10, 2013:
- 11:25 PM Changeset in webkit [160412] by
-
- 4 edits in trunk/Source
<http://webkit.org/b/125556> WebKit doesn't deal with longer bundle versions correctly
<rdar://problem/15634192>
Reviewed by Dan Bernstein.
Source/WebKit/mac:
- WebView/WebView.mm:
(createUserVisibleWebKitVersionString): Strip as many leading digits as is necessary to
bring the major component of the version down to 3 digits.
Source/WebKit2:
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::userVisibleWebKitVersionString): Strip as many leading digits as is necessary to
bring the major component of the version down to 3 digits.
- 10:50 PM Changeset in webkit [160411] by
-
- 10 edits2 adds in trunk
Get rid of forward exit on DoubleAsInt32
https://bugs.webkit.org/show_bug.cgi?id=125552
PerformanceTests/SunSpider:
Reviewed by Oliver Hunt.
Use SunSpider as a kind of spot-check for the
no-architecture-specific-optimization paths in the compiler.
- no-architecture-specific-optimizations.yaml: Added.
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
The forward exit was just there so that we wouldn't have to keep the inputs alive up to
the DoubleAsInt32. That's dumb. Forward exits are a complicated piece of machinery and
we shouldn't have it just for a bit of liveness micro-optimization.
Also add a bunch of machinery to test this case on X86.
- assembler/AbstractMacroAssembler.h:
(JSC::optimizeForARMv7s):
(JSC::optimizeForARM64):
(JSC::optimizeForX86):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNodeType.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileDoubleAsInt32):
- runtime/Options.h:
- tests/stress/double-as-int32.js: Added.
(foo):
(test):
Tools:
Reviewed by Oliver Hunt.
Add some support for testing the generic (non-X86) paths on X86 by disabling
architecture-specific optimizations (ASO's).
- Scripts/run-javascriptcore-tests:
- Scripts/run-jsc-stress-tests:
- 9:57 PM Changeset in webkit [160410] by
-
- 6 edits2 adds in trunk
top and bottom black background line not getting displayed
https://bugs.webkit.org/show_bug.cgi?id=21664
Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-12-10
Reviewed by Simon Fraser.
Source/WebCore:
The table cell's background was not being displayed. Since the table
cell had no child correct offsetWidth was not being set even if table
width is being defined.
Test: fast/dom/HTMLTableElement/empy-table-cell-with-background-color.html
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
cellHasContent should also be set to true incase background color is
present.
LayoutTests:
- fast/dom/HTMLTableElement/empy-table-cell-with-background-color-expected.txt: Added.
- fast/dom/HTMLTableElement/empy-table-cell-with-background-color.html: Added.
Added new test case to verify that table cell offsetWidth is set even
when it has no contents but has background color.
- fast/table/auto-100-percent-width-expected.txt:
- platform/mac/fast/table/empty-cells-expected.txt:
- tables/mozilla/bugs/bug1818-6-expected.txt:
Rebaselining the existing test case as per the new changes. The new
dimension changes are as per mozilla behaviour. For
auto-100-percent-width-expected.txt we get 1 px red background because
if cellHasContent we set columnLayout's minLogicalWidth and
columnLayout's maxLogicalWidth as 1 initially even if cell is empty.
- 8:44 PM Changeset in webkit [160409] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed GTK build fix attempt after r160395 (second)
- GNUmakefile.list.am:
Added new files for UserData, APIFrameHandle, APIGeometry and APIPageHandle.
- 8:16 PM Changeset in webkit [160408] by
-
- 5 edits in trunk/Source/WebKit2
Unreviewed GTK build fix attempt after r160395
Renamed WebUInt64 to API::UInt64, WebDouble to API::Double, WebBoolean
to API::Boolean.
- UIProcess/API/gtk/WebKitInjectedBundleClient.cpp:
(didReceiveWebViewMessageFromInjectedBundle):
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_get_snapshot):
- UIProcess/API/gtk/WebKitWindowProperties.cpp: Included APINumber.h instead of WebNumber.h
(webkitWindowPropertiesUpdateFromWebWindowFeatures):
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(didInitiateLoadForResource):
(willSendRequestForFrame):
(didReceiveResponseForResource):
(didReceiveContentLengthForResource):
(didFinishLoadForResource):
(didFailLoadForResource):
(webkitWebPageDidReceiveMessage):
- 6:10 PM Changeset in webkit [160407] by
-
- 2 edits in trunk/Source/JavaScriptCore
Simplify CSE's treatment of NodeRelevantToOSR
https://bugs.webkit.org/show_bug.cgi?id=125538
Reviewed by Oliver Hunt.
Make the NodeRelevantToOSR thing obvious: if there is any MovHint on a node then the
node is relevant to OSR.
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::run):
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::CSEPhase::performBlockCSE):
- 6:08 PM Changeset in webkit [160406] by
-
- 29 edits in branches/safari-537.74-branch/Source
Merge 154333: <rdar://problem/15498740>.
- 6:07 PM Changeset in webkit [160405] by
-
- 6 edits in trunk/Source/WebKit2
All observable PageLoadState properties should change in an atomic fashion, with properly nested change notifications
https://bugs.webkit.org/show_bug.cgi?id=125431
Reviewed by Anders Carlsson.
Made PageLoadState maintain two copies of its state data members, one representing the
committed state and one possibly containing uncommitted changes. When changes are committed,
change notifications are sent and the uncommitted state is copied into the committed state.
Changes can be committed explicitly at any time, but are also committed when the last
outstanding transaction ends. Transactions are RAII objects vended by the PageLoadState.
Mutating the PageLoadState requires holding a Transaction, which is enforced by making all
the mutating member functions take a Transaction::Token. Passing a Token also marks the
PageLoadState as possibly having uncommitted changes.
- UIProcess/API/Cocoa/WKBrowsingContextController.mm:
Added PageLoadStateObserver::{will,did}ChangeActiveURL overrides that call
-{will,did}ChangeValueForKey:.
- UIProcess/PageLoadState.cpp:
Moved constant from the middle of the file to the beginning and reworded comment.
(WebKit::PageLoadState::PageLoadState): Added initializers for new member variables, removed
initialization of members that are not part of Data, which initializes them in its
constructor.
(WebKit::PageLoadState::endTransaction): Added. Calles when a Transaction is destructed.
Decrements the outstanding transaction count, and if it is zero, commits changes.
(WebKit::PageLoadState::commitChanges): Added. Checks for differences in observable
properties between the committed state and the uncommitted state, then makes appropriate
willChange Observer callbacks, then copies the uncommitted state into the committed state,
then makes appropriate didChange Observer callbacks in reverse order. Also added active URL
to the set of observable properties.
(WebKit::PageLoadState::reset): Changed to take a transaction token, act on
m_uncommittedState, and not make observer callbacks.
(WebKit::PageLoadState::isLoading): Changed to access m_committedState.
(WebKit::PageLoadState::activeURL): Changed to call a static function factored out of this.
(WebKit::PageLoadState::estimatedProgress): Ditto.
(WebKit::PageLoadState::pendingAPIRequestURL): Changed to access m_committedState.
(WebKit::PageLoadState::setPendingAPIRequestURL): Changed to take a transaction token, act
on m_uncommittedState, and not make observer callbacks.
(WebKit::PageLoadState::clearPendingAPIRequestURL): Ditto.
(WebKit::PageLoadState::didStartProvisionalLoad): Ditto.
(WebKit::PageLoadState::didReceiveServerRedirectForProvisionalLoad): Ditto.
(WebKit::PageLoadState::didFailProvisionalLoad): Ditto.
(WebKit::PageLoadState::didCommitLoad): Ditto.
(WebKit::PageLoadState::didFinishLoad): Ditto.
(WebKit::PageLoadState::didFailLoad): Ditto.
(WebKit::PageLoadState::didSameDocumentNavigation): Ditto.
(WebKit::PageLoadState::setUnreachableURL): Ditto.
(WebKit::PageLoadState::title): Changed to access m_committedState.
(WebKit::PageLoadState::setTitle): Changed to take a transaction token, act on
m_uncommittedState, and not make observer callbacks.
(WebKit::PageLoadState::didStartProgress): Ditto.
(WebKit::PageLoadState::didChangeProgress): Ditto.
(WebKit::PageLoadState::didFinishProgress): Ditto.
- UIProcess/PageLoadState.h:
(WebKit::PageLoadState::Transaction::Transaction): Added. Calls
PageLoadState::beginTransaction.
(WebKit::PageLoadState::Transaction::~Transaction): Added. Calls
PageLoadState::endTransaction.
(WebKit::PageLoadState::Transaction::Token::Token): Added. Sets m_mayHaveUncommittedChanges.
(WebKit::PageLoadState::transaction): Added. Returns a Transaction for this PageLoadState.
(WebKit::PageLoadState::provisionalURL): Changed to access m_committedState.
(WebKit::PageLoadState::url): Ditto.
(WebKit::PageLoadState::unreachableURL): Ditto.
(WebKit::PageLoadState::beginTransaction): Added. Increments the outstanding transaction
count.
(WebKit::PageLoadState::Data::Data): Added. Moved internal state members into this struct
and made its constructor initialize state and estimatedProgress.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadURL): Changed to create a PageLoadState::Transaction and pass it
along.
(WebKit::WebPageProxy::loadURLRequest): Ditto.
(WebKit::WebPageProxy::loadAlternateHTMLString): Ditto.
(WebKit::WebPageProxy::reload): Ditto.
(WebKit::WebPageProxy::goForward): Ditto.
(WebKit::WebPageProxy::goBack): Ditto.
(WebKit::WebPageProxy::goToBackForwardItem): Ditto.
(WebKit::WebPageProxy::receivedPolicyDecision): Ditto.
(WebKit::WebPageProxy::didStartProgress): Ditto. Also added a call to
PageLoadState::commitChanges before calling the client, so that the client sees the updated
state.
(WebKit::WebPageProxy::didChangeProgress): Ditto.
(WebKit::WebPageProxy::didFinishProgress): Ditto.
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame): Ditto.
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
(WebKit::WebPageProxy::didFailProvisionalLoadForFrame): Ditto.
(WebKit::WebPageProxy::didCommitLoadForFrame): Ditto.
(WebKit::WebPageProxy::didFinishLoadForFrame): Ditto.
(WebKit::WebPageProxy::didFailLoadForFrame): Ditto.
(WebKit::WebPageProxy::didSameDocumentNavigationForFrame): Ditto.
(WebKit::WebPageProxy::didReceiveTitleForFrame): Ditto.
(WebKit::WebPageProxy::decidePolicyForNavigationAction): Changed to create a
PageLoadState::Transaction and pass it along.
(WebKit::WebPageProxy::processDidCrash): Ditto. This addressed a FIXME about the client not
seeing the state prior to the crash, because now the changes cuased by reset() aren’t
committed until after the client callback.
- UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::WebPageProxy::restoreFromSessionStateData): Changed to create a
PageLoadState::Transaction and pass it along.
- 5:28 PM Changeset in webkit [160404] by
-
- 5 edits in trunk
Unreviewed EFL build fix attempt
Source/WebKit2:
- CMakeLists.txt: Added APIGeometry.cpp to source lists.
Tools:
- TestWebKitAPI/CMakeLists.txt: Added ${WEBKIT2_DIR}/Platform/CoreIPC to include lists.
- WebKitTestRunner/CMakeLists.txt: Ditto.
- 5:25 PM Changeset in webkit [160403] by
-
- 6 edits in branches/safari-537.74-branch/Source
Merge 152982: <rdar://problem/15498697>.
- 5:11 PM Changeset in webkit [160402] by
-
- 2 edits in branches/safari-537.74-branch/Tools
Merged r156928. <rdar://problem/15560412>
- 5:09 PM Changeset in webkit [160401] by
-
- 2 edits in branches/safari-537.74-branch/Tools
Merged r156926. <rdar://problem/15560412>
- 5:08 PM Changeset in webkit [160400] by
-
- 4 edits in trunk
Add a HashMap constructor that takes an initializer list
https://bugs.webkit.org/show_bug.cgi?id=125551
Reviewed by Dan Bernstein.
Source/WTF:
- wtf/HashMap.h:
(WTF::HashMap::HashMap):
Tools:
- TestWebKitAPI/Tests/WTF/HashMap.cpp:
(TestWebKitAPI::TEST):
- 5:01 PM Changeset in webkit [160399] by
-
- 40 edits in branches/safari-537.74-branch
Merge 152921
- 4:59 PM Changeset in webkit [160398] by
-
- 1 edit1 move in trunk/LayoutTests
AX: Share accessibility/aria-hidden-negates-no-visibility.html expectation with other ports
https://bugs.webkit.org/show_bug.cgi?id=125495
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-12-10
Reviewed by Chris Fleizach.
Expectation of accessibility/aria-hidden-negates-no-visibility.html is the same for EFL and GTK.
- accessibility/aria-hidden-negates-no-visibility-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-hidden-negates-no-visibility-expected.txt.
- 4:54 PM Changeset in webkit [160397] by
-
- 2 edits in trunk/Source/WebCore
Horizontal rubber-banding without a horizontal scrollbar is distracting
https://bugs.webkit.org/show_bug.cgi?id=125550
Reviewed by Simon Fraser.
Setting the ScrollElasticity to ScrollElasticityAutomatic will make sure we only
rubber-band horizontally when there is a horizontal scrollbar.
- page/FrameView.cpp:
(WebCore::FrameView::FrameView):
- 4:38 PM Changeset in webkit [160396] by
-
- 2 edits in trunk/Source/WebCore
Correct a preprocessor guard from a mis-merged patch
In r160367, I mismerged a patch from Gustavo Noronha. This commit
fixes the merge and thus fixes the CMake build.
- html/HTMLMediaElement.idl: Move the preprocessor guard to the correct property.
- 4:19 PM Changeset in webkit [160395] by
-
- 22 edits in trunk/Source/WebKit2
Move number and geometry classes into the API namespace
https://bugs.webkit.org/show_bug.cgi?id=125549
Reviewed by Geoffrey Garen.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(-[WKRemoteObjectEncoder encodeBool:forKey:]):
(-[WKRemoteObjectEncoder encodeInt64:forKey:]):
(-[WKRemoteObjectEncoder encodeDouble:forKey:]):
(-[WKRemoteObjectDecoder decodeBoolForKey:]):
(-[WKRemoteObjectDecoder decodeInt64ForKey:]):
(-[WKRemoteObjectDecoder decodeDoubleForKey:]):
- Shared/API/c/WKGeometry.cpp:
(WKSizeGetTypeID):
(WKPointGetTypeID):
(WKRectGetTypeID):
(WKPointCreate):
(WKSizeCreate):
(WKRectCreate):
- Shared/API/c/WKNumber.cpp:
(WKBooleanGetTypeID):
(WKBooleanCreate):
(WKDoubleGetTypeID):
(WKDoubleCreate):
(WKUInt64GetTypeID):
(WKUInt64Create):
- Shared/API/c/WKSharedAPICast.h:
- Shared/APIGeometry.cpp:
(API::Point::encode):
(API::Point::decode):
(API::Size::encode):
(API::Size::decode):
(API::Rect::encode):
(API::Rect::decode):
- Shared/APIGeometry.h:
(API::Size::create):
(API::Size::Size):
(API::Point::create):
(API::Point::Point):
(API::Rect::create):
(API::Rect::Rect):
- Shared/APINumber.h:
(API::Number::create):
(API::Number::decode):
(API::Number::Number):
- Shared/APIObject.h:
- Shared/Plugins/Netscape/PluginInformation.cpp:
(WebKit::getPluginModuleInformation):
(WebKit::createPluginInformationDictionary):
- Shared/Plugins/Netscape/mac/PluginInformationMac.mm:
(WebKit::getPlatformPluginModuleInformation):
- Shared/UserData.cpp:
(WebKit::UserData::encode):
(WebKit::UserData::decode):
- Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
- UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::populateCopyOfNotificationPermissions):
(WebKit::WebNotificationManagerProxy::providerDidCloseNotifications):
- UIProcess/Notifications/WebNotificationProvider.cpp:
(WebKit::WebNotificationProvider::clearNotifications):
- UIProcess/Plugins/PlugInAutoStartProvider.cpp:
(WebKit::PlugInAutoStartProvider::autoStartOriginsTableCopy):
(WebKit::PlugInAutoStartProvider::setAutoStartOriginsTable):
- UIProcess/StatisticsRequest.cpp:
(WebKit::addToDictionaryFromHashMap):
- UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didFindStringMatches):
- UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::createNewPage):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::trackedRepaintRects):
- WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:
(-[WKAccessibilityWebPageObject accessibilityAttributeValue:forParameter:]):
- 3:36 PM Changeset in webkit [160394] by
-
- 3 edits in trunk/Source/JavaScriptCore
Get rid of forward exit in GetByVal on Uint32Array
https://bugs.webkit.org/show_bug.cgi?id=125543
Reviewed by Oliver Hunt.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
- 3:30 PM Changeset in webkit [160393] by
-
- 3 edits in trunk/Source/WebKit2
Add encode and decode functions to WebNumber
https://bugs.webkit.org/show_bug.cgi?id=125547
Reviewed by Beth Dakin.
- Shared/APINumber.h:
(WebKit::WebNumber::encode):
(WebKit::WebNumber::decode):
- Shared/UserData.cpp:
(WebKit::UserData::encode):
(WebKit::UserData::decode):
- 3:27 PM Changeset in webkit [160392] by
-
- 11 edits in trunk/Source/WebKit2
[EFL] One more WK2 build fix
https://bugs.webkit.org/show_bug.cgi?id=125544
API::TypedObject has been renamed to API::ObjectImpl
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-12-10
Reviewed by Tim Horton.
- Shared/WebBatteryStatus.h:
- Shared/WebNetworkInfo.h:
- UIProcess/CoordinatedGraphics/WebView.h:
- UIProcess/WebBatteryManagerProxy.h:
- UIProcess/WebNetworkInfoManagerProxy.h:
- UIProcess/WebTextChecker.h:
- UIProcess/WebVibrationProxy.h:
- UIProcess/WebViewportAttributes.h:
- UIProcess/efl/WebPopupItemEfl.h:
- UIProcess/soup/WebSoupRequestManagerProxy.h:
- 3:00 PM Changeset in webkit [160391] by
-
- 12 edits1 move in trunk/Source/WebKit2
Rename WebNumber.h to APINumber.h
https://bugs.webkit.org/show_bug.cgi?id=125545
Reviewed by Beth Dakin.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
- Shared/API/c/WKNumber.cpp:
- Shared/API/c/WKSharedAPICast.h:
- Shared/APINumber.h: Renamed from Source/WebKit2/Shared/WebNumber.h.
- Shared/Plugins/Netscape/PluginInformation.cpp:
- Shared/Plugins/Netscape/mac/PluginInformationMac.mm:
- Shared/UserData.cpp:
- Shared/UserMessageCoders.h:
- UIProcess/API/C/mac/WKContextPrivateMac.mm:
- UIProcess/Notifications/WebNotificationProvider.cpp:
- UIProcess/WebUIClient.cpp:
- WebKit2.xcodeproj/project.pbxproj:
- 2:43 PM Changeset in webkit [160390] by
-
- 2 adds in trunk/Source/WebKit2/Shared
Add files.
- 2:28 PM Changeset in webkit [160389] by
-
- 4 edits in trunk/Source/WebCore
Clean up SVGScriptElement
https://bugs.webkit.org/show_bug.cgi?id=125527
Patch by Rob Buis <rob.buis@samsung.com> on 2013-12-10
Reviewed by Sam Weinig.
Rewrite to not store type in m_type and also remove type getter/setter.
- svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::parseAttribute):
(WebCore::SVGScriptElement::typeAttributeValue):
- svg/SVGScriptElement.h:
- svg/SVGScriptElement.idl:
- 2:11 PM Changeset in webkit [160388] by
-
- 6 edits1 delete in trunk/Source/WebKit2
UserData should handle geometry types
https://bugs.webkit.org/show_bug.cgi?id=125542
Reviewed by Andreas Kling.
Rename WebGeometry.h to APIGeometry.h in preparation for moving the classes into the API namespace.
Add encode/decode functions to geometry classes. Use them in UserData::encode and UserData::decode.
- Shared/API/c/WKGeometry.cpp:
- Shared/APIGeometry.cpp: Added.
- Shared/APIGeometry.h: Renamed from Source/WebKit2/Shared/WebGeometry.h.
(WebKit::UserData::encode):
(WebKit::UserData::decode):
- Shared/UserMessageCoders.h:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/WebPage.cpp:
- 1:51 PM Changeset in webkit [160387] by
-
- 2 edits in trunk/Source/JavaScriptCore
[MIPS] Redundant instructions in code generated from offlineasm.
https://bugs.webkit.org/show_bug.cgi?id=125528
Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-12-10
Reviewed by Michael Saboff.
Optimize lowering of offlineasm BaseIndex Addresses.
- offlineasm/mips.rb:
- 1:48 PM Changeset in webkit [160386] by
-
- 11 edits in trunk
Use std::array when computing MD5 checksum
https://bugs.webkit.org/show_bug.cgi?id=125509
Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-12-10
Reviewed by Anders Carlsson.
Source/WebCore:
Use MD5::Digest type and MD5::hashSize when computing MD5 checksum.
- platform/network/curl/CurlCacheEntry.cpp:
(WebCore::CurlCacheEntry::generateBaseFilename):
Source/WTF:
Added MD5::Digest type and MD5::hashSize for computing MD5 checksum.
- wtf/MD5.cpp:
(WTF::MD5::checksum):
- wtf/MD5.h:
Tools:
Use MD5::Digest type and MD5::hashSize when computing MD5 checksum.
- DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
(computeMD5HashStringForBitmapContext):
- DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
(computeMD5HashStringForBitmapContext):
- TestWebKitAPI/Tests/WTF/MD5.cpp:
(TestWebKitAPI::expectMD5):
- WebKitTestRunner/cairo/TestInvocationCairo.cpp:
(WTR::computeMD5HashStringForCairoSurface):
- WebKitTestRunner/cg/TestInvocationCG.cpp:
(WTR::computeMD5HashStringForContext):
- 1:39 PM Changeset in webkit [160385] by
-
- 12 edits in trunk/Source/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=125533
BackgroundExtendsBeyondPage setting should be switchable per WKView
-and corresponding-
<rdar://problem/15571310>
Reviewed by Anders Carlsson.
This patch removes the WKPreferences API and adds WKPage API in its place. To
ensure that the setting sticks after a crash, it is also now a creation parameter.
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- UIProcess/API/C/WKPage.cpp:
(WKPageSetBackgroundExtendsBeyondPage):
(WKPageBackgroundExtendsBeyondPage):
- UIProcess/API/C/WKPage.h:
- UIProcess/API/C/WKPreferences.cpp:
- UIProcess/API/C/WKPreferencesPrivate.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setBackgroundExtendsBeyondPage):
(WebKit::WebPageProxy::backgroundExtendsBeyondPage):
(WebKit::WebPageProxy::initializeCreationParameters):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::setBackgroundExtendsBeyondPage):
(WebKit::WebPage::updatePreferences):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 1:28 PM Changeset in webkit [160384] by
-
- 76 edits in trunk/Source/WebKit2
Rename API::TypedObject to API::ObjectImpl
https://bugs.webkit.org/show_bug.cgi?id=125539
Reviewed by Tim Horton.
All API::Objects are by definition typed, so ObjectImpl makes more sense as a name.
- Shared/APIArray.h:
- Shared/APIFrameHandle.h:
- Shared/APIObject.h:
(API::ObjectImpl::~ObjectImpl):
(API::ObjectImpl::ObjectImpl):
- Shared/APIPageHandle.h:
- Shared/ImmutableDictionary.h:
- Shared/WebArchive.h:
- Shared/WebArchiveResource.h:
- Shared/WebBackForwardListItem.h:
- Shared/WebCertificateInfo.h:
- Shared/WebConnection.h:
- Shared/WebContextMenuItem.h:
- Shared/WebData.h:
- Shared/WebError.h:
- Shared/WebGeolocationPosition.h:
- Shared/WebGeometry.h:
- Shared/WebHitTestResult.h:
- Shared/WebImage.h:
- Shared/WebNumber.h:
- Shared/WebOpenPanelParameters.h:
- Shared/WebRenderLayer.h:
- Shared/WebRenderObject.h:
- Shared/WebSecurityOrigin.h:
- Shared/WebSerializedScriptValue.h:
- Shared/WebString.h:
- Shared/WebURL.h:
- Shared/WebURLRequest.h:
- Shared/WebURLResponse.h:
- Shared/WebUserContentURLPattern.h:
- Shared/mac/ObjCObjectGraph.h:
- UIProcess/APINavigationData.h:
- UIProcess/Authentication/AuthenticationChallengeProxy.h:
- UIProcess/Authentication/AuthenticationDecisionListener.h:
- UIProcess/Authentication/WebCredential.h:
- UIProcess/Authentication/WebProtectionSpace.h:
- UIProcess/Downloads/DownloadProxy.h:
- UIProcess/GeolocationPermissionRequestProxy.h:
- UIProcess/Notifications/NotificationPermissionRequest.h:
- UIProcess/Notifications/WebNotification.h:
- UIProcess/Notifications/WebNotificationManagerProxy.h:
- UIProcess/Plugins/WebPluginSiteDataManager.h:
- UIProcess/WebApplicationCacheManagerProxy.h:
- UIProcess/WebBackForwardList.h:
- UIProcess/WebColorPickerResultListenerProxy.h:
- UIProcess/WebContext.h:
- UIProcess/WebCookieManagerProxy.h:
- UIProcess/WebDatabaseManagerProxy.h:
- UIProcess/WebEditCommandProxy.h:
- UIProcess/WebFrameProxy.h:
- UIProcess/WebGeolocationManagerProxy.h:
- UIProcess/WebGrammarDetail.h:
- UIProcess/WebIconDatabase.h:
- UIProcess/WebInspectorProxy.h:
- UIProcess/WebKeyValueStorageManager.h:
- UIProcess/WebMediaCacheManagerProxy.h:
- UIProcess/WebOpenPanelResultListenerProxy.h:
- UIProcess/WebOriginDataManagerProxy.h:
- UIProcess/WebPageGroup.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPreferences.h:
- UIProcess/WebResourceCacheManagerProxy.h:
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
- WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:
- WebProcess/InjectedBundle/InjectedBundle.h:
- WebProcess/InjectedBundle/InjectedBundleBackForwardList.h:
- WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h:
- WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.h:
- WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
- WebProcess/InjectedBundle/InjectedBundleNavigationAction.h:
- WebProcess/InjectedBundle/InjectedBundleScriptWorld.h:
- WebProcess/WebPage/PageBanner.h:
- WebProcess/WebPage/PageOverlay.h:
- WebProcess/WebPage/WebFrame.h:
- WebProcess/WebPage/WebInspector.h:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPageGroupProxy.h:
- 1:19 PM Changeset in webkit [160383] by
-
- 5 edits in trunk/Source/JavaScriptCore
Reduce the mass templatizing of the JS parser
https://bugs.webkit.org/show_bug.cgi?id=125535
Reviewed by Michael Saboff.
The various caches we have now have removed the need for many of
the template vs. regular parameters. This patch converts those
template parameters to regular parameters and updates the call
sites. This reduces the code size of the parser by around 15%.
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createProperty):
- parser/Parser.cpp:
(JSC::::parseInner):
(JSC::::parseSourceElements):
(JSC::::parseVarDeclarationList):
(JSC::::createBindingPattern):
(JSC::::tryParseDeconstructionPatternExpression):
(JSC::::parseDeconstructionPattern):
(JSC::::parseSwitchClauses):
(JSC::::parseSwitchDefaultClause):
(JSC::::parseBlockStatement):
(JSC::::parseFormalParameters):
(JSC::::parseFunctionInfo):
(JSC::::parseFunctionDeclaration):
(JSC::::parseProperty):
(JSC::::parseObjectLiteral):
(JSC::::parseStrictObjectLiteral):
(JSC::::parseMemberExpression):
- parser/Parser.h:
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createProperty):
(JSC::SyntaxChecker::createGetterOrSetterProperty):
- 1:10 PM Changeset in webkit [160382] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Fix WK2 build after r160341
https://bugs.webkit.org/show_bug.cgi?id=125529
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-12-10
Reviewed by Anders Carlsson.
- CMakeLists.txt: Added new files UserData.cpp, APIFrameHandle.cpp and APIPageHandle.cpp.
- 1:07 PM Changeset in webkit [160381] by
-
- 2 edits in trunk/Source/WebKit2
Add more API object types to UserData
https://bugs.webkit.org/show_bug.cgi?id=125532
Reviewed by Beth Dakin.
- Shared/UserData.cpp:
(WebKit::UserData::transform):
Handle dictionaries.
(WebKit::UserData::encode):
(WebKit::UserData::decode):
Handle more API::Objects.
- 12:12 PM Changeset in webkit [160380] by
-
- 9 edits in trunk
[ATK] Expose splitter elements with ATK_ROLE_SEPARATOR
https://bugs.webkit.org/show_bug.cgi?id=125522
Reviewed by Chris Fleizach.
Source/WebCore:
Expose objects with SplitterRole role as ATK_ROLE_SEPARATOR.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):
Tools:
Update strings representing ATK_ROLE_SEPARATOR for layout tests.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
LayoutTests:
Update expected results in layout test for EFL and GTK.
- platform/efl-wk1/accessibility/lists-expected.txt:
- platform/efl-wk2/accessibility/lists-expected.txt:
- platform/gtk/accessibility/lists-expected.txt:
- 12:11 PM Changeset in webkit [160379] by
-
- 4 edits in trunk
[ATK] Elements with role 'alertdialog' should be ATK_ROLE_ALERT
https://bugs.webkit.org/show_bug.cgi?id=125521
Reviewed by Chris Fleizach.
Source/WebCore:
Stop exposing alert dialogs as ATK_ROLE_DIALOG and do it as
ATK_ROLE_ALERT instead.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):
LayoutTests:
Update expected result in layout test.
- accessibility/aria-mappings-expected.txt:
- 11:43 AM Changeset in webkit [160378] by
-
- 8 edits in trunk/Source/WebKit2
More UserData work
https://bugs.webkit.org/show_bug.cgi?id=125524
Reviewed by Dan Bernstein.
- Shared/APIObject.h:
- Shared/UserData.cpp:
(WebKit::UserData::transform):
New helper function that takes an API::Object and returns a new API::Object with all "sub-objects" (arrays etc)
transformed by calling the transformer.
- Shared/UserData.h:
(WebKit::UserData::object):
New getter.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::apiObjectByConvertingToHandles):
Helper function that creates a new API::Object graph by converting WebFrameProxy objects to FrameHandles.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::apiObjectByConvertingFromHandles):
Helper function that creates a new API::Object graph by converting FrameHandles to WebFrame objects.
- 11:37 AM Changeset in webkit [160377] by
-
- 8 edits1 add in trunk/Source/JavaScriptCore
ASSERT !heap.vm()->isInitializingObject() when finishing DFG compilation at beginning of GC
https://bugs.webkit.org/show_bug.cgi?id=125472
Reviewed by Geoff Garen.
This patch makes it look like it's okay to allocate so that the DFG plan finalization stuff
can do what it needs to do. We already expected that we might do allocation during plan
finalization and we increased the deferral depth to handle this, but we need to fix this other
ASSERT stuff too.
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- heap/Heap.cpp:
(JSC::Heap::collect):
- heap/Heap.h:
- heap/RecursiveAllocationScope.h: Added.
(JSC::RecursiveAllocationScope::RecursiveAllocationScope):
(JSC::RecursiveAllocationScope::~RecursiveAllocationScope):
- runtime/VM.h:
- 11:29 AM Changeset in webkit [160376] by
-
- 2 edits in branches/safari-537.74-branch/Source/WTF
Merge r159892
- 10:54 AM Changeset in webkit [160375] by
-
- 4 edits in trunk/Source/WebCore
[GTK][GStreamer] media/video-preload.html is flakily crashing on WK2
https://bugs.webkit.org/show_bug.cgi?id=125411
Patch by Brendan Long <b.long@cablelabs.com> on 2013-12-10
Reviewed by Philippe Normand.
No new tests because this fixes flakeyness in existing tests (media/video-preload.html, and various tests in media/track/{audio,in-band,video}).
- platform/graphics/gstreamer/TextCombinerGStreamer.cpp:
(webkitTextCombinerPadGetProperty): Copy tag list to prevent concurrent modification problems.
(webkitTextCombinerPadEvent): Add locking.
- platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
(WebCore::TrackPrivateBaseGStreamer::TrackPrivateBaseGStreamer): Call tagsChanged() because we need it to setup m_tags.
(WebCore::TrackPrivateBaseGStreamer::disconnect): Clear m_tags.
(WebCore::TrackPrivateBaseGStreamer::tagsChanged): Lookup the tags while we're in this callback, because it's the only time we can guarantee that the input-selector won't unref them.
(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfTagsChanged): Use m_tags.
- platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h: Add m_tags and a mutex.
- 10:53 AM Changeset in webkit [160374] by
-
- 14 edits2 adds in trunk
PageConsole::addMessage should automatically determine column number alongside line number
https://bugs.webkit.org/show_bug.cgi?id=114319
Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-10
Reviewed by Joseph Pecoraro.
Source/WebCore:
- dom/InlineStyleSheetOwner.cpp:
(WebCore::InlineStyleSheetOwner::InlineStyleSheetOwner):
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::ScriptElement):
- dom/ScriptableDocumentParser.h:
- dom/StyledElement.cpp:
(WebCore::StyledElement::styleAttributeChanged):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpPendingSpeculations):
- html/parser/HTMLDocumentParser.h:
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::buildInitiatorObject):
- page/Console.cpp:
(WebCore::internalAddMessage):
- page/PageConsole.cpp:
(WebCore::PageConsole::printSourceURLAndPosition):
(WebCore::PageConsole::addMessage):
- page/PageConsole.h:
- xml/parser/XMLDocumentParser.h:
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::error):
LayoutTests:
- inspector-protocol/page/deny-X-FrameOption-expected.txt: Added.
- inspector-protocol/page/deny-X-FrameOption.html: Added.
- 10:49 AM Changeset in webkit [160373] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] [SOUP] Allow running the network process with an arbitrary prefix command
https://bugs.webkit.org/show_bug.cgi?id=125520
Reviewed by Carlos Garcia Campos.
Launch the network process using NETWORK_PROCESS_CMD_PREFIX as a
prefix. Useful for debugging the web process with gdb, valgrind,
etc.
- UIProcess/Network/soup/NetworkProcessProxySoup.cpp:
(WebKit::NetworkProcessProxy::platformGetLaunchOptions):
- 9:47 AM Changeset in webkit [160372] by
-
- 2 edits in trunk/Tools
Add --makeargs option to build-jsc
https://bugs.webkit.org/show_bug.cgi?id=125344
Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-12-10
Reviewed by Filip Pizlo.
- Scripts/build-jsc: Handle and pass makefile arguments in jsc build.
- 9:47 AM Changeset in webkit [160371] by
-
- 2 edits in trunk/Source/WebKit2
Allow us to use network process with a single process model
https://bugs.webkit.org/show_bug.cgi?id=125507
Patch by Kwang Yul Seo <skyul@company100.net> on 2013-12-10
Reviewed by Brady Eidson.
Currently, WebContext::sendToNetworkingProcess and
WebContext::sendToNetworkingProcessRelaunchingIfNecessary assume that
network process is not used when the given process model is
ProcessModelSharedSecondaryProcess. This is not consistent with
WebContext::networkingProcessConnection which returns the networking
process connection for ProcessModelSharedSecondaryProcess.
- UIProcess/WebContext.h:
(WebKit::WebContext::sendToNetworkingProcess):
(WebKit::WebContext::sendToNetworkingProcessRelaunchingIfNecessary):
- 8:50 AM Changeset in webkit [160370] by
-
- 4 edits in trunk/Source/WebCore
Jettison all StyleResolver data on memory pressure.
<https://webkit.org/b/125498>
The StyleResolver can be rebuilt relatively quickly; we already
have an optimization that discards it some time after last use.
If we find ourseles under serious memory pressure, don't wait for
the timer to kick in, throw everything overboard right away.
~5MB progression post-pressure on Membuster3.
Reviewed by Anders Carlsson.
- 8:47 AM Changeset in webkit [160369] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed EFL build fix
- CMakeLists.txt: Remove UIProcess/DrawingAreaProxy.cpp.
- PlatformGTK.cmake: Add the file above.
- 8:43 AM Changeset in webkit [160368] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] [CMake] Add support for building the WebKit injected bundle
https://bugs.webkit.org/show_bug.cgi?id=116373
Reviewed by Gustavo Noronha Silva.
- PlatformGTK.cmake: Add support for building the InjectedBundle and link the WebKit2
shared library against the GObject DOM bindings.
- WebProcess/gtk/WebGtkExtensionManager.h: Properly export symbols used by the InjectedBundle.
- 8:41 AM Changeset in webkit [160367] by
-
- 9 edits in trunk/Source/WebCore
[GTK] [CMake] Add support for building the DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=116375
Reviewed by Gustavo Noronha Silva.
The CMake build is more complete than the autotools counterpart, so autotools doesn't consider
some supplemental IDL attributes when building the DOM bindings. To prevent API breaks we should
protect these attributes from DOM binding generation.
- Modules/battery/BatteryManager.idl: Protect non-GObject DOM bound methods by C preprocessor checks.
- Modules/battery/NavigatorBattery.idl: Ditto.
- Modules/mediastream/HTMLMediaElementMediaStream.idl: Ditto.
- Modules/networkinfo/NavigatorNetworkInfoConnection.idl: Ditto.
- Modules/networkinfo/NetworkInfoConnection.idl: Ditto.
- PlatformGTK.cmake: Add build steps for building the bindings.
- dom/Document.idl: Protect non-GObject DOM bound methods by C preprocessor checks.
- html/HTMLMediaElement.idl: Ditto.
- 8:37 AM Changeset in webkit [160366] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening
Add failure expectations for tests added in r157725.
- platform/efl/TestExpectations:
- 7:44 AM Changeset in webkit [160365] by
-
- 6 edits22 adds in trunk
AX: [ATK] Convert the get_text atktest.c unit tests to layout tests
https://bugs.webkit.org/show_bug.cgi?id=125497
Reviewed by Mario Sanchez Prada.
Source/WebKit/gtk:
- tests/testatk.c: Remove the portions of the remaining tests which now exist as
layout tests.
(testWebkitAtkCaretOffsets):
(testWebkitAtkCaretOffsetsAndExtranousWhiteSpaces):
(testWebkitAtkComboBox):
(testWebkitAtkEmbeddedObjects):
(testWebkitAtkTextSelections):
(testWebkitAtkListsOfItems):
(main):
Tools:
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::stringForRange): Implemented.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::stringForRange): Implemented.
LayoutTests:
- platform/gtk/accessibility/text-for-range-combo-box-expected.txt: Added.
- platform/gtk/accessibility/text-for-range-combo-box.html: Added.
- platform/gtk/accessibility/text-for-range-embedded-objects-expected.txt: Added.
- platform/gtk/accessibility/text-for-range-embedded-objects.html: Added.
- platform/gtk/accessibility/text-for-range-entry-and-password-expected.txt: Added.
- platform/gtk/accessibility/text-for-range-entry-and-password.html: Added.
- platform/gtk/accessibility/text-for-range-extraneous-whitespace-expected.txt: Added.
- platform/gtk/accessibility/text-for-range-extraneous-whitespace.html: Added.
- platform/gtk/accessibility/text-for-range-formatted-expected.txt: Added.
- platform/gtk/accessibility/text-for-range-formatted.html: Added.
- platform/gtk/accessibility/text-for-range-heading-expected.txt: Added.
- platform/gtk/accessibility/text-for-range-heading.html: Added.
- platform/gtk/accessibility/text-for-range-list-items-expected.txt: Added.
- platform/gtk/accessibility/text-for-range-list-items.html: Added.
- platform/gtk/accessibility/text-for-range-simple-expected.txt: Added.
- platform/gtk/accessibility/text-for-range-simple.html: Added.
- platform/gtk/accessibility/text-for-range-table-cells-expected.txt: Added.
- platform/gtk/accessibility/text-for-range-table-cells.html: Added.
- platform/gtk/accessibility/text-for-range-with-link-expected.txt: Added.
- platform/gtk/accessibility/text-for-range-with-link.html: Added.
- platform/gtk/accessibility/text-for-table-expected.txt: Added.
- platform/gtk/accessibility/text-for-table.html: Added.
- 7:39 AM Changeset in webkit [160364] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][SOUP] WebContext::setIgnoreTLSErrors should send SetIgnoreTLSErrors to the network process when network process is enabled
https://bugs.webkit.org/show_bug.cgi?id=125505
Patch by Kwang Yul Seo <skyul@company100.net> on 2013-12-10
Reviewed by Carlos Garcia Campos.
This is a follow-up patch for r160355.
- UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::setIgnoreTLSErrors):
- 7:23 AM Changeset in webkit [160363] by
-
- 3 edits in trunk/Source/WebKit2
Try to fix the EFL build
- CMakeLists.txt: Remove DrawingAreaImpl.cpp from the global list.
- PlatformGTK.cmake: Move it to the GTK+ specific list.
- 6:33 AM Changeset in webkit [160362] by
-
- 2 edits in trunk
[CMAKE] Remove code that disables C++0x compat warnings for gcc-4.6 and above.
https://bugs.webkit.org/show_bug.cgi?id=125492
Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2013-12-10
Reviewed by Zoltan Herczeg.
Remove the code that disables these warnings for GCC >= 4.6.0
- Source/cmake/WebKitHelpers.cmake:
- 6:32 AM Changeset in webkit [160361] by
-
- 12 edits in trunk
Various fixes for the CMake GTK+ build
Reviewed by Gustavo Noronha.
.:
- Source/cmake/OptionsGTK.cmake: Disable Quota support to maintain consistency with
autotools build.
Source/WebCore:
- PlatformGTK.cmake: Update source list.
Source/WebKit2:
- CMakeLists.txt: Update the source lists.
- PlatformGTK.cmake: Ditto.
Source/WTF:
- wtf/PlatformGTK.cmake: Add Zlib library to the WTF build.
Tools:
- MiniBrowser/gtk/CMakeLists.txt: Update source list and correct the name of BrowserMarshal.h.
- TestWebKitAPI/PlatformGTK.cmake: Add GTK+ libraries to the test program. They're required.
- 6:31 AM Changeset in webkit [160360] by
-
- 3 edits in trunk/LayoutTests
[ATK] accessibility/alt-tag-on-image-with-nonimage-role.html is failing after r160311
https://bugs.webkit.org/show_bug.cgi?id=125504
Unreviewed ATK gardening.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-12-10
- platform/efl/TestExpectations: Marked as failing.
- platform/gtk/TestExpectations: Marked as failing.
- 6:31 AM Changeset in webkit [160359] by
-
- 2 edits in trunk/Tools
--cloop option does not work in Tools/Scripts/build-jsc.
https://bugs.webkit.org/show_bug.cgi?id=125214
Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-10
Reviewed by Csaba Osztrogonác.
- Scripts/build-jsc:
- 5:49 AM WebKitGTK/2.2.x edited by
- (diff)
- 5:06 AM Changeset in webkit [160358] by
-
- 3 edits in trunk/Source/WebKit2
[WK2] [GTK] Enable the network process in the WebContext
https://bugs.webkit.org/show_bug.cgi?id=125494
Reviewed by Carlos Garcia Campos.
This should be initialized using the setUsesNetworkProcess() API.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(createDefaultWebContext):
- UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
- 4:55 AM Changeset in webkit [160357] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening
Add failure expectations for tests that started to fail after r154906.
- platform/efl/TestExpectations:
- 4:44 AM Changeset in webkit [160356] by
-
- 2 edits in trunk/Source/WebCore
[nix][curl] Buildfix after r160310
https://bugs.webkit.org/show_bug.cgi?id=125489
Patch by Robert Sipka <sipka@inf.u-szeged.hu> on 2013-12-10
Reviewed by Gustavo Noronha Silva.
Curl doesn't include soup files.
- PlatformNix.cmake:
- 4:21 AM Changeset in webkit [160355] by
-
- 8 edits in trunk/Source/WebKit2
[WK2][SOUP] initialise the Network Process with ignoreTLSErrors
https://bugs.webkit.org/show_bug.cgi?id=125490
ResourceHandleSoup in the Network Process and is not initialised with
a policy on ignoring TLS errors. This simply requires that the
appropriate message is created for the Network Process and the
parameter created for initialisation.
Patch by Brian Holt <brian.holt@samsung.com> on 2013-12-10
Reviewed by Gustavo Noronha Silva.
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::platformInitializeNetworkProcess):
(WebKit::NetworkProcess::setIgnoreTLSErrors):
- Shared/Network/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode):
(WebKit::NetworkProcessCreationParameters::decode):
- Shared/Network/NetworkProcessCreationParameters.h:
- UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
- UIProcess/soup/WebContextSoup.cpp:
(WebKit::WebContext::platformInitializeNetworkProcess):
- 2:19 AM Changeset in webkit [160354] by
-
- 2 edits in trunk/Source/WebCore
[GTK] REGRESSION: www.yahoo.com redirects to the mobile version after UA change
https://bugs.webkit.org/show_bug.cgi?id=125444
Reviewed by Martin Robinson.
- platform/gtk/UserAgentGtk.cpp:
(WebCore::platformVersionForUAString): more correctly pretend we're Mac OS X.
(WebCore::standardUserAgent): ditto.
- 2:18 AM Changeset in webkit [160353] by
-
- 3 edits in trunk/Tools
Merge mark_for_landing and mark_for_commit_queue into one argument
https://bugs.webkit.org/show_bug.cgi?id=125448
Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-12-10
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(CommitQueueFlag):
(Bugzilla._commit_queue_flag):
(Bugzilla._fill_attachment_form):
(Bugzilla.add_patch_to_bug):
(Bugzilla.create_bug):
- Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
(test_commit_queue_flag.assert_commit_queue_flag):
(test_commit_queue_flag):
- 2:07 AM Changeset in webkit [160352] by
-
- 4 edits in trunk/Source/WebCore
[Soup] Send original encoded data size to didReceiveBuffer
https://bugs.webkit.org/show_bug.cgi?id=125410
Reviewed by Martin Robinson.
No tests, the only way to test this seems to be through the inspector UI.
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal): data member to track stream
position.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::currentStreamPosition): obtains the current stream position by querying
the first seekable input stream we find.
(WebCore::nextMultipartResponsePartCallback): store the position before we start reading a new part.
(WebCore::sendRequestCallback): store the position before we start reading the response body.
(WebCore::readCallback): pass the position delta to didReceiveData.
- 12:51 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:36 AM WebKitGTK/2.2.x edited by
- (diff)
Dec 9, 2013:
- 11:19 PM Changeset in webkit [160351] by
-
- 5 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: ctiNativeCallFallback and friends should renamed ...NativeTailCall
https://bugs.webkit.org/show_bug.cgi?id=125485
Not yet reviewed.
Changed ctiNativeCallFallback to ctiNativeTailCall and nativeCallFallbackGenerator
to nativeTailCallGenerator to be more descriptive of what is happening.
- jit/JITThunks.cpp:
(JSC::JITThunks::ctiNativeTailCall):
- jit/JITThunks.h:
- jit/ThunkGenerators.cpp:
(JSC::nativeTailCallGenerator):
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
(JSC::powThunkGenerator):
(JSC::imulThunkGenerator):
(JSC::arrayIteratorNextThunkGenerator):
- jit/ThunkGenerators.h:
- 10:54 PM Changeset in webkit [160350] by
-
- 1 edit in branches/jsCStack/Source/JavaScriptCore/ChangeLog
Fixed spelling errors in the ChangeLog entry for
CStack Branch: Fix baseline JIT for basic operation
- 9:57 PM Changeset in webkit [160349] by
-
- 4 edits in trunk/Source/WebCore
Clear out font width measurement caches on memory pressure.
<https://webkit.org/b/125481>
The data kept in WidthCaches can be regenerated on demand. Throwing
it away when we're under memory pressure buys us ~4MB on Membuster3.
Reviewed by Antti Koivisto.
- 9:52 PM Changeset in webkit [160348] by
-
- 5 edits in trunk/Source/JavaScriptCore
Impose and enforce some basic rules of sanity for where Phi functions are allowed to occur and where their (optional) corresponding MovHints can be
https://bugs.webkit.org/show_bug.cgi?id=125480
Reviewed by Geoffrey Garen.
Previously, if you wanted to insert some speculation right after where a value was
produced, you'd get super confused if that value was produced by a Phi node. You can't
necessarily insert speculations after a Phi node because Phi nodes appear in this
special sequence of Phis and MovHints that establish the OSR exit state for a block.
So, you'd probably want to search for the next place where it's safe to insert things.
We already do this "search for beginning of next bytecode instruction" search by
looking at the next node that has a different CodeOrigin. But this would be hard for a
Phi because those Phis and MovHints have basically random CodeOrigins and they can all
have different CodeOrigins.
This change imposes some sanity for this situation:
- Phis must have unset CodeOrigins.
- In each basic block, all nodes that have unset CodeOrigins must come before all nodes that have set CodeOrigins.
This all ends up working out just great because prior to this change we didn't have a
use for unset CodeOrigins. I think it's appropriate to make "unset CodeOrigin" mean
that we're in the prologue of a basic block.
It's interesting what this means for block merging, which we don't yet do in SSA.
Consider merging the edge A->B. One possibility is that the block merger is now
required to clean up Phi/Upsilons, and reascribe the MovHints to have the CodeOrigin of
the A's block terminal. But an answer that might be better is that the originless
nodes at the top of the B are just given the origin of the terminal and we keep the
Phis. That would require changing the above rules. We'll see how it goes, and what we
end up picking...
Overall, this special-things-at-the-top rule is analogous to what other SSA-based
compilers do. For example, LLVM has rules mandating that Phis appear at the top of a
block.
- bytecode/CodeOrigin.cpp:
(JSC::CodeOrigin::dump):
- dfg/DFGOSRExitBase.h:
(JSC::DFG::OSRExitBase::OSRExitBase):
- dfg/DFGSSAConversionPhase.cpp:
(JSC::DFG::SSAConversionPhase::run):
- dfg/DFGValidate.cpp:
(JSC::DFG::Validate::validate):
(JSC::DFG::Validate::validateSSA):
- 7:24 PM Changeset in webkit [160347] by
-
- 24 edits5 adds in trunk/Source/JavaScriptCore
Reveal array bounds checks in DFG IR
https://bugs.webkit.org/show_bug.cgi?id=125253
Reviewed by Oliver Hunt and Mark Hahnenberg.
In SSA mode, this reveals array bounds checks and the load of array length in DFG IR,
making this a candidate for LICM.
This also fixes a long-standing performance bug where the JSObject slow paths would
always create contiguous storage, rather than type-specialized storage, when doing a
"storage creating" storage, like:
var o = {};
o[0] = 42;
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/ExitKind.cpp:
(JSC::exitKindToString):
(JSC::exitKindIsCountable):
- bytecode/ExitKind.h:
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
- dfg/DFGArrayMode.cpp:
(JSC::DFG::permitsBoundsCheckLowering):
(JSC::DFG::ArrayMode::permitsBoundsCheckLowering):
- dfg/DFGArrayMode.h:
(JSC::DFG::ArrayMode::lengthNeedsStorage):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNodeType.h:
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSSALoweringPhase.cpp: Added.
(JSC::DFG::SSALoweringPhase::SSALoweringPhase):
(JSC::DFG::SSALoweringPhase::run):
(JSC::DFG::SSALoweringPhase::handleNode):
(JSC::DFG::SSALoweringPhase::lowerBoundsCheck):
(JSC::DFG::performSSALowering):
- dfg/DFGSSALoweringPhase.h: Added.
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileDoublePutByVal):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileContiguousPutByVal):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCheckInBounds):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::compilePutByVal):
(JSC::FTL::LowerDFGToLLVM::contiguousPutByValOutOfBounds):
- runtime/JSObject.cpp:
(JSC::JSObject::convertUndecidedForValue):
(JSC::JSObject::createInitialForValueAndSet):
(JSC::JSObject::putByIndexBeyondVectorLength):
(JSC::JSObject::putDirectIndexBeyondVectorLength):
- runtime/JSObject.h:
- tests/stress/float32array-out-of-bounds.js: Added.
(make):
(foo):
(test):
- tests/stress/int32-object-out-of-bounds.js: Added.
(make):
(foo):
(test):
- tests/stress/int32-out-of-bounds.js: Added.
(foo):
(test):
- 6:08 PM Changeset in webkit [160346] by
-
- 6 edits1 delete in trunk/Source/WTF
Remove FixedArray
https://bugs.webkit.org/show_bug.cgi?id=125478
Reviewed by Anders Carlsson.
- GNUmakefile.list.am:
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/FixedArray.h: Removed.
- 5:47 PM Changeset in webkit [160345] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Remove enabled() in InspectorRuntimeAgent.
https://bugs.webkit.org/show_bug.cgi?id=125476
Reviewed by Joseph Pecoraro.
Dead code. It's never called anywhere.
No new tests, no behavior change.
- inspector/InspectorRuntimeAgent.h:
- 5:28 PM Changeset in webkit [160344] by
-
- 24 edits in trunk/Source
Replace use of WTF::FixedArray with std::array
https://bugs.webkit.org/show_bug.cgi?id=125475
Reviewed by Anders Carlsson.
- bytecode/CodeBlockHash.cpp:
(JSC::CodeBlockHash::dump):
- bytecode/Opcode.cpp:
(JSC::OpcodeStats::~OpcodeStats):
- dfg/DFGCSEPhase.cpp:
- ftl/FTLAbstractHeap.h:
- heap/MarkedSpace.h:
- parser/ParserArena.h:
- runtime/CodeCache.h:
- runtime/DateInstanceCache.h:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
- runtime/JSGlobalObject.h:
- runtime/JSString.h:
- runtime/LiteralParser.h:
- runtime/NumericStrings.h:
- runtime/RegExpCache.h:
- runtime/SmallStrings.h:
../WebCore:
- crypto/parameters/CryptoAlgorithmAesCbcParams.h:
- platform/graphics/GlyphMetricsMap.h:
../WTF:
- wtf/AVLTree.h:
- wtf/Bitmap.h:
- wtf/SixCharacterHash.cpp:
(WTF::integerToSixCharacterHashString):
- wtf/SixCharacterHash.h:
- 4:37 PM Changeset in webkit [160343] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: Change nativeForGenerator fallBack bool to an enum
https://bugs.webkit.org/show_bug.cgi?id=125473
Reviewed by Filip Pizlo.
Change the "bool fallBack" to an enum name ThunkEntryType with values
EnterViaCall and EnterViaJump to indicate how the thunk will be entered.
- jit/ThunkGenerators.cpp:
(JSC::nativeForGenerator):
(JSC::nativeCallFallbackGenerator):
- 4:12 PM Changeset in webkit [160342] by
-
- 1 edit1 delete in trunk/Tools
Remove dead extract_reference_link.py (and the reftests module)
https://bugs.webkit.org/show_bug.cgi?id=125116
Reviewed by Ryosuke Niwa.
This code doesn't seem to have ever been used.
- Scripts/webkitpy/layout_tests/reftests/init.py: Removed.
- Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Removed.
- Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Removed.
- 4:11 PM Changeset in webkit [160341] by
-
- 3 edits6 adds in trunk/Source/WebKit2
Begin working on a UserData class intended to replace UserMessageCoders
https://bugs.webkit.org/show_bug.cgi?id=125471
Reviewed by Sam Weinig.
- Shared/APIFrameHandle.cpp: Added.
- Shared/APIFrameHandle.h: Added.
Add a new API::FrameHandle class that represents a frame.
- Shared/APIObject.h:
- Shared/APIPageHandle.cpp: Added.
- Shared/APIPageHandle.h: Added.
Add a new API::PageHandle class that represents a page.
- Shared/UserData.cpp: Added.
(WebKit::UserData::UserData):
(WebKit::UserData::~UserData):
(WebKit::UserData::encode):
(WebKit::UserData::decode):
- Shared/UserData.h: Added.
Add a UserData class that can be encoded and decoded. This will be used for sending data
between the web process and UI process without doing any of the Page -> BundlePage etc conversions.
- WebKit2.xcodeproj/project.pbxproj:
- 3:50 PM Changeset in webkit [160340] by
-
- 12 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: Fix baseline JIT for basic operation
https://bugs.webkit.org/show_bug.cgi?id=125470
Not yet reviewed.
Fixed compileOpCall and it's slow case to properly adjust the stack pointer before
and after a call.
Cleaned up the calling convention in the various thunks. Adjusted the stack
pointer at the end of the arity fixup thunk to account for the frame moving.
Added ctiNativeCallFallback() thunk generator for when another thunk that can't
perform its operation inline needs to make a native call. This thunk generator
differes from ctiNativeCall() in that it doesn't emit a funciton prologue, thus
allowing the original thunk to jump to the "fallback" thunk. I'm open to another
name beside "fallback". Maybe "ctiNativeTailCall()".
Fixed the OSR entry handling in the LLInt prologue macro to properly account
for the callee saving the caller frame pointer.
Added stack alignement check function for use in debug builds to find and break
if the stack pointer is not appropriately aligned.
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::checkStackPointerAlignment):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JIT.h:
(JSC::JIT::frameRegisterCountFor):
- jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_enter):
- jit/JITThunks.cpp:
(JSC::JITThunks::ctiNativeCallFallback):
- jit/JITThunks.h:
- jit/ThunkGenerators.cpp:
(JSC::slowPathFor):
(JSC::nativeForGenerator):
(JSC::nativeCallFallbackGenerator):
(JSC::arityFixup):
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
(JSC::powThunkGenerator):
(JSC::imulThunkGenerator):
(JSC::arrayIteratorNextThunkGenerator):
- jit/ThunkGenerators.h:
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter64.asm:
- 3:48 PM Changeset in webkit [160339] by
-
- 2 edits in tags/Safari-538.8.1/Source/WebKit/mac
Merge 160326 for <rdar://problem/15615561>.
- 3:45 PM Changeset in webkit [160338] by
-
- 7 edits4 adds in trunk/Source/WebCore
Refactor the CFURLConnectionClient to be the synchronous implementation of an abstract network delegate
https://bugs.webkit.org/show_bug.cgi?id=125379
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-12-09
Reviewed by Alexey Proskuryakov.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleInternal.h:
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::createCFURLConnection):
- platform/network/cf/ResourceHandleCFURLConnectionDelegate.cpp: Added.
(WebCore::ResourceHandleCFURLConnectionDelegate::ResourceHandleCFURLConnectionDelegate):
(WebCore::ResourceHandleCFURLConnectionDelegate::~ResourceHandleCFURLConnectionDelegate):
(WebCore::ResourceHandleCFURLConnectionDelegate::willSendRequestCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::didReceiveResponseCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::didReceiveDataCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::didFinishLoadingCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::didFailCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::willCacheResponseCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::didReceiveChallengeCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::didSendBodyDataCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::shouldUseCredentialStorageCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::canRespondToProtectionSpaceCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::didReceiveDataArrayCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::makeConnectionClient):
- platform/network/cf/ResourceHandleCFURLConnectionDelegate.h: Added.
- platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp: Added.
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::SynchronousResourceHandleCFURLConnectionDelegate):
(WebCore::synthesizeRedirectResponseIfNecessary):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::willSendRequest):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveResponse):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveData):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didFinishLoading):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didFail):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::willCacheResponse):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveChallenge):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didSendBodyData):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::shouldUseCredentialStorageCallback):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::canRespondToProtectionSpace):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveDataArray):
- platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.h: Added.
- 3:44 PM Changeset in webkit [160337] by
-
- 5 edits1 delete in trunk
REGRESSION(r136280): input[type=image] should assume coords of 0,0 when activated without physically clicking
https://bugs.webkit.org/show_bug.cgi?id=125392
Reviewed by Darin Adler.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/3c33d42207cd209bb171083ba66c225f694f2101
Activating an image button with the keyboard or element.click() should result in selected coords of (0,0) per
http://www.w3.org/TR/2013/CR-html5-20130806/forms.html#image-button-state-(type=image)
"If the user activates the control without explicitly selecting a coordinate, then the coordinate (0,0) must be assumed."
New behavior also matches that of Internet Explorer and Firefox.
Tests: fast/forms/input-image-submit.html
- html/ImageInputType.cpp:
(WebCore::ImageInputType::handleDOMActivateEvent): Set m_clickLocation to (0, 0) for simulated events.
LayoutTests:
- fast/events/stopPropagation-submit-expected.txt:
- fast/forms/input-image-submit.html:
- platform/gtk/fast/events/stopPropagation-submit-expected.txt: Removed.
- 3:36 PM Changeset in webkit [160336] by
-
- 28 edits5 adds in trunk
[MSE] Add support for VideoPlaybackMetrics.
https://bugs.webkit.org/show_bug.cgi?id=125380
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/media-source/media-source-video-playback-quality.html
Add a new object type VideoPlaybackQuality to be returned by
HTMLMediaElement.getVideoPlaybackQuality().
HTMLMediaElements must separately track a droppedVideoFrame count, as
certain operations on SourceBuffer will drop incoming frames, which must
be accounted for. Reset this count when the media engine changes, which is
indicitive of a new media load requset starting.
Add the new VideoPlaybackQuality class:
- Modules/mediasource/VideoPlaybackQuality.cpp: Added.
(WebCore::VideoPlaybackQuality::create):
(WebCore::VideoPlaybackQuality::VideoPlaybackQuality):
- Modules/mediasource/VideoPlaybackQuality.h: Added.
(WebCore::VideoPlaybackQuality::creationTime):
(WebCore::VideoPlaybackQuality::totalVideoFrames):
(WebCore::VideoPlaybackQuality::droppedVideoFrames):
(WebCore::VideoPlaybackQuality::corruptedVideoFrames):
(WebCore::VideoPlaybackQuality::totalFrameDelay):
- Modules/mediasource/VideoPlaybackQuality.idl: Added.
Add support for the new class to HTMLMediaElement:
- html/HTMLMediaElement.cpp:
(HTMLMediaElement::shouldUseVideoPluginProxy):
(HTMLMediaElement::getVideoPlaybackQuality):
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl:
Report the video quality metrics from the MediaPlayer:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::totalVideoFrames):
(WebCore::MediaPlayer::droppedVideoFrames):
(WebCore::MediaPlayer::corruptedVideoFrames):
(WebCore::MediaPlayer::totalFrameDelay):
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::totalVideoFrames):
(WebCore::MediaPlayerPrivateInterface::droppedVideoFrames):
(WebCore::MediaPlayerPrivateInterface::corruptedVideoFrames):
(WebCore::MediaPlayerPrivateInterface::totalFrameDelay):
Correctly report the dropped frame count:
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::TrackBuffer::TrackBuffer): needsRandomAccessFlag defaults to true.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): Check the sync status of the incoming sample.
(WebCore::SourceBuffer::didDropSample): Notify the media element of a dropped frame.
- Modules/mediasource/SourceBuffer.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(HTMLMediaElement::mediaPlayerEngineUpdated): Reset m_droppedFrameCount.
(HTMLMediaElement::getVideoPlaybackQuality): Return a new VideoPlaybackQuality object.
- html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::incrementDroppedFrameCount): Simple incrementer.
- platform/MediaSample.h:
(WebCore::MediaSample::isSync): Convenience function.
(WebCore::MediaSample::isNonDisplaying): Ditto.
Add support in the AVFoundation MediaSource Engine:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::totalVideoFrames):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::droppedVideoFrames):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::corruptedVideoFrames):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::totalFrameDelay):
Add support in the Mock MediaSource Engine:
- platform/mock/mediasource/MockBox.h:
- platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:
(WebCore::MockMediaPlayerMediaSource::totalVideoFrames): Simple accessor.
(WebCore::MockMediaPlayerMediaSource::droppedVideoFrames): Ditto.
(WebCore::MockMediaPlayerMediaSource::corruptedVideoFrames): Ditto.
(WebCore::MockMediaPlayerMediaSource::totalFrameDelay): Ditto.
- platform/mock/mediasource/MockMediaPlayerMediaSource.h:
- platform/mock/mediasource/MockMediaSourcePrivate.cpp:
(WebCore::MockMediaSourcePrivate::MockMediaSourcePrivate):
- platform/mock/mediasource/MockMediaSourcePrivate.h:
- platform/mock/mediasource/MockSourceBufferPrivate.cpp:
(WebCore::MockSourceBufferPrivate::enqueueSample): Increment the frame counts based on
the incoming sample.
- platform/mock/mediasource/MockSourceBufferPrivate.h:
Add the new files to the project:
- bindings/gobject/GNUmakefile.am:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- GNUMakefile.list.am:
- CMakeLists.txt:
LayoutTests:
- media/media-source/media-source-video-playback-quality-expected.txt: Added.
- media/media-source/media-source-video-playback-quality.html: Added.
- media/media-source/mock-media-source.js:
(var):
- 3:27 PM Changeset in webkit [160335] by
-
- 2 edits in trunk/Source/WebCore
Avoid divide by zero in scrollbar code, and protect against Obj-C exceptions
https://bugs.webkit.org/show_bug.cgi?id=125469
<rdar://problem/15535772>
Reviewed by Beth Dakin.
In ScrollbarThemeMac::setPaintCharacteristicsForScrollbar(), proportion could
end up as NaN if scrollbar->totalSize() were zero. Protect against that.
Also wrap functions that call into Objective-C with BEGIN_BLOCK_OBJC_EXCEPTIONS/
END_BLOCK_OBJC_EXCEPTIONS.
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::ScrollbarThemeMac::updateEnabledState):
(WebCore::ScrollbarThemeMac::setPaintCharacteristicsForScrollbar):
(WebCore::scrollbarPainterPaint):
- 3:27 PM Changeset in webkit [160334] by
-
- 5 edits in trunk/Source/JavaScriptCore
Remove miscellaneous unnecessary build statements
https://bugs.webkit.org/show_bug.cgi?id=125466
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-12-09
Reviewed by Darin Adler.
- DerivedSources.make:
- JavaScriptCore.vcxproj/build-generated-files.sh:
- JavaScriptCore.xcodeproj/project.pbxproj:
- make-generated-sources.sh:
- 3:27 PM Changeset in webkit [160333] by
-
- 1 copy in tags/Safari-538.8.1
New Tag.
- 3:11 PM Changeset in webkit [160332] by
-
- 3 edits in trunk/WebKitLibraries
Unreviewed, update LLVM binary drops to r196830.
- LLVMIncludesMountainLion.tar.bz2:
- LLVMLibrariesMountainLion.tar.bz2:
- 2:38 PM Changeset in webkit [160331] by
-
- 5 edits in branches/safari-537.74-branch/Source
Versioning.
- 2:06 PM Changeset in webkit [160330] by
-
- 14 edits6 adds in trunk
Implement Document.cloneNode()
https://bugs.webkit.org/show_bug.cgi?id=11646
Reviewed by Darin Adler.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/dc7879025e01d63be9fcf6a84ca6c9b8b5768a80
Implement the behavior specified in the current DOM4 working draft:
http://www.w3.org/TR/2013/WD-dom-20131107/#dom-node-clonenode
Tests: fast/dom/Document/clone-node.html
fast/dom/HTMLDocument/clone-node-quirks-mode.html
svg/custom/clone-node.html
- dom/Document.cpp:
(WebCore::Document::cloneNode):
(WebCore::Document::cloneDocumentWithoutChildren):
(WebCore::Document::cloneDataFromDocument):
- dom/Document.h:
- html/HTMLDocument.cpp:
(WebCore::HTMLDocument::cloneDocumentWithoutChildren):
- html/HTMLDocument.h:
- svg/SVGDocument.cpp:
(WebCore::SVGDocument::cloneDocumentWithoutChildren):
- svg/SVGDocument.h:
LayoutTests:
- dom/xhtml/level3/core/documentgetinputencoding04-expected.txt:
- dom/xhtml/level3/core/documentgetxmlencoding05-expected.txt:
- dom/xhtml/level3/core/nodeisequalnode01-expected.txt:
- dom/xhtml/level3/core/nodeisequalnode21-expected.txt:
- dom/xhtml/level3/core/nodeisequalnode25-expected.txt:
- dom/xhtml/level3/core/nodeisequalnode26-expected.txt:
- fast/dom/Document/clone-node-expected.txt: Added.
- fast/dom/Document/clone-node.html: Added.
- fast/dom/HTMLDocument/clone-node-quirks-mode-expected.txt: Added.
- fast/dom/HTMLDocument/clone-node-quirks-mode.html: Added.
- svg/custom/clone-node-expected.txt: Added.
- svg/custom/clone-node.html: Added.
- 2:04 PM Changeset in webkit [160329] by
-
- 1 copy in branches/safari-537.74-branch
New Branch.
- 2:02 PM Changeset in webkit [160328] by
-
- 3 edits in trunk/Source/JavaScriptCore
CSE should work in SSA
https://bugs.webkit.org/show_bug.cgi?id=125430
Reviewed by Oliver Hunt and Mark Hahnenberg.
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::run):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- 1:15 PM Changeset in webkit [160327] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r160260): Memory pressure signal causes web process to hang.
<https://webkit.org/b/125465>
Reviewed by Tim Horton.
This command caused all of my web processes to hang:
notifyutil -p org.WebKit.lowMemory
This only happens when the cache pruning code encounters a resource
using purgeable memory.
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::pruneLiveResourcesToSize):
Grab the next CachedResource pointer before continuing the loop.
- 12:38 PM Changeset in webkit [160326] by
-
- 2 edits in trunk/Source/WebKit/mac
Fix the build of projects including <WebKit/WebUIDelegatePrivate.h>
Rubber-stamped by Dan Bernstein.
- WebView/WebAllowDenyPolicyListener.h:
Use TARGET_OS_IPHONE rather than PLATFORM(IOS) in an exposed header.
- 12:20 PM Changeset in webkit [160325] by
-
- 2 edits1 delete in trunk/Source/JavaScriptCore
Remove docs/make-bytecode-docs.pl
https://bugs.webkit.org/show_bug.cgi?id=125462
This sript is very old and no longer outputs useful data since the
op code definitions have moved from Interpreter.cpp.
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-12-09
Reviewed by Darin Adler.
- DerivedSources.make:
- docs/make-bytecode-docs.pl: Removed.
- 12:17 PM Changeset in webkit [160324] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] OpenGL compile error.
https://bugs.webkit.org/show_bug.cgi?id=125383
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-12-09
Reviewed by Darin Adler.
- platform/graphics/opengl/Extensions3DOpenGLES.h: Define GL_HALF_FLOAT_ARB on Windows when OPENGL_ES_2 is used.
- 12:16 PM Changeset in webkit [160323] by
-
- 22 edits in trunk
[ATK] Translate ATK_ROLE_SECTION into "AXSection" in DRT/WKTR
https://bugs.webkit.org/show_bug.cgi?id=125456
Reviewed by Chris Fleizach.
Tools:
Return 'AXSection' for section roles instead of 'AXDiv'.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
LayoutTests:
Update expectations for GTK and EFL that were expecting AXDiv for
section roles, so they now expect AXSection.
- accessibility/adjacent-continuations-cause-assertion-failure-expected.txt:
- accessibility/div-within-anchors-causes-crash-expected.txt:
- platform/efl-wk1/accessibility/image-map2-expected.txt:
- platform/efl-wk1/accessibility/transformed-element-expected.txt:
- platform/efl-wk2/accessibility/image-map2-expected.txt:
- platform/efl-wk2/accessibility/transformed-element-expected.txt:
- platform/efl/accessibility/media-emits-object-replacement-expected.txt:
- platform/gtk/accessibility/aria-roles-unignored-expected.txt:
- platform/gtk/accessibility/aria-roles-unignored.html:
- platform/gtk/accessibility/entry-and-password-expected.txt:
- platform/gtk/accessibility/image-map2-expected.txt:
- platform/gtk/accessibility/media-emits-object-replacement-expected.txt:
- platform/gtk/accessibility/object-with-title-expected.txt:
- platform/gtk/accessibility/object-with-title.html:
- platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt:
- platform/gtk/accessibility/spans-paragraphs-and-divs-expected.txt:
- platform/gtk/accessibility/spans-paragraphs-and-divs.html:
- platform/gtk/accessibility/transformed-element-expected.txt:
- 11:45 AM Changeset in webkit [160322] by
-
- 12 edits in trunk
Fix handling of 'inherit' and 'initial' for grid lines.
https://bugs.webkit.org/show_bug.cgi?id=125223
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-12-09
Reviewed by Darin Adler.
'initial' and 'inherit' are always allowed values for CSS properties.
As the CSSParser handles them automatically, those 2 values were never
taken care of in StyleResolver, leading to crashes.
Source/WebCore:
Added tests cases for 'inherit' and 'initial' to the following tests:
fast/css-grid-layout/grid-item-column-row-get-set.html
fast/css-grid-layout/grid-item-end-after-get-set.html
fast/css-grid-layout/grid-item-start-before-get-set.html
Patch backported from Blink: https://src.chromium.org/viewvc/blink?revision=149257&view=revision
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- rendering/style/RenderStyle.h:
- rendering/style/StyleGridItemData.cpp:
(WebCore::StyleGridItemData::StyleGridItemData):
LayoutTests:
Patch backported from Blink: https://src.chromium.org/viewvc/blink?revision=149257&view=revision
- fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
- fast/css-grid-layout/grid-item-column-row-get-set.html:
- fast/css-grid-layout/grid-item-end-after-get-set-expected.txt:
- fast/css-grid-layout/grid-item-end-after-get-set.html:
- fast/css-grid-layout/grid-item-start-before-get-set-expected.txt:
- fast/css-grid-layout/grid-item-start-before-get-set.html:
- fast/css-grid-layout/resources/grid-item-column-row-parsing-utils.js:
- 11:30 AM Changeset in webkit [160321] by
-
- 6 edits in trunk/Source/WebKit2
[EFL][WK2] LayoutTests are broken after r160301
https://bugs.webkit.org/show_bug.cgi?id=125447
Reviewed by Darin Adler.
r160301 moved FullScreenManagerProxyClient logic to WebViewEfl, child class
of CoordinatedGraphics::WebView, because implementations are EFL specific.
However, CoordinatedGraphics::WebView creates WebPageProxy in constructor and
WebPageProxy requires FullScreenManagerProxyClient in constructor.
So, All WK2/Efl based applications got crashed
This patch adds virtual methods for FullScreenManagerProxyClient to CoordinatedGraphics::WebView
so that WebPageProxy can get FullScreenManagerProxyClient instance without
pure viertual methods.
- UIProcess/API/C/CoordinatedGraphics/WKView.cpp:
(WKViewExitFullScreen):
- UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::fullScreenManagerProxyClient):
(WebKit::WebView::requestExitFullScreen):
renamed from exitFullScreen not to conflict with methods of FullScreenManagerProxyClient.
- UIProcess/CoordinatedGraphics/WebView.h:
- UIProcess/efl/WebViewEfl.cpp:
- UIProcess/efl/WebViewEfl.h:
- 11:21 AM Changeset in webkit [160320] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Inspector.json and CodeGenerator tweaks
https://bugs.webkit.org/show_bug.cgi?id=125321
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-12-09
Reviewed by Timothy Hatcher.
- inspector/protocol/Runtime.json:
Runtime.js was depending on Network.FrameId. This is a layering
violation, so ideally we can fix this later. For now, just copy
the FrameId type into Runtime. They are strings so all is good.
- inspector/CodeGeneratorInspector.py:
(Generator.EventMethodStructTemplate.append_epilog):
- inspector/CodeGeneratorInspectorStrings.py:
Improve --help usage information.
Make the script work with a single domain json file.
Add ASCIILiteral's where appropriate.
- 11:01 AM Changeset in webkit [160319] by
-
- 3 edits in trunk/Tools
check-webkit-style should check for extra newlines at EOF
https://bugs.webkit.org/show_bug.cgi?id=125424
Patch by Brian J. Burg <Brian Burg> on 2013-12-09
Reviewed by Darin Adler.
Report a style violation if extraneous newlines are added
to the end of a C++ file. There should only be one newline at EOF.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_for_missing_new_line_at_eof): Renamed from check_for_new_line_at_eof.
(check_for_extra_new_line_at_eof): Added.
(_process_lines): Added new check and renamed existing EOF check.
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_extra_newlines_at_eof): Added.
(CppStyleTest.test_extra_newlines_at_eof.do_test): Added.
- 10:57 AM Changeset in webkit [160318] by
-
- 3 edits in trunk/Tools
check-webkit-style: ternary operator in macro call identified as initialization list
https://bugs.webkit.org/show_bug.cgi?id=125443
Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-12-09
Reviewed by Ryosuke Niwa.
Do not match initialization list when questionmark is placed before :
- Scripts/webkitpy/style/checkers/cpp.py:
(check_member_initialization_list):
- 10:51 AM Changeset in webkit [160317] by
-
- 1 edit4 adds in trunk/LayoutTests
Add a test for style sharing if grandparents matches different rule chain and nth-last child
https://bugs.webkit.org/show_bug.cgi?id=125397
Reviewed by Darin Adler.
Add the test from https://chromium.googlesource.com/chromium/blink/+/30ff49bf63cdec31070ab4eda8784564f56789d4
and https://chromium.googlesource.com/chromium/blink/+/3cb1724bb52f3607006ddd0a89d356da23766115
so that we may not introduce the same regressions in WebKit.
- fast/css/nth-last-child-recalc-expected.html: Added.
- fast/css/nth-last-child-recalc.html: Added.
- fast/css/style-sharing-grand-parent-invalidate-expected.txt: Added.
- fast/css/style-sharing-grand-parent-invalidate.html: Added.
- 10:40 AM Changeset in webkit [160316] by
-
- 11 edits16 adds in trunk
AX: [ATK] Convert the get_{string,text}_at_offset atktest.c unit tests to layout tests
https://bugs.webkit.org/show_bug.cgi?id=125451
Reviewed by Mario Sanchez Prada.
Source/WebKit/gtk:
- tests/testatk.c: Remove the tests which now exist as layout tests. Note that the
tests for atk_text_get_text_{before,after}_offset were removed without equivalents
added to the layout tests. The same is true for the END AtkTextBoundary types. Both
have been deprecated in ATK and are not being used by AT-SPI2 assistive technologies.
(testGetTextFunction):
(main):
Tools:
Create the needed callbacks for DRT and WKTR.
- DumpRenderTree/AccessibilityUIElement.cpp:
(characterAtOffsetCallback): added
(wordAtOffsetCallback): added
(lineAtOffsetCallback): added
(sentenceAtOffsetCallback): added
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(stringAtOffset): added
(AccessibilityUIElement::characterAtOffset): added
(AccessibilityUIElement::wordAtOffset): added
(AccessibilityUIElement::lineAtOffset): added
(AccessibilityUIElement::sentenceAtOffset): added
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::characterAtOffset): added
(WTR::AccessibilityUIElement::wordAtOffset): added
(WTR::AccessibilityUIElement::lineAtOffset): added
(WTR::AccessibilityUIElement::sentenceAtOffset): added
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::stringAtOffset): added
(WTR::AccessibilityUIElement::characterAtOffset): added
(WTR::AccessibilityUIElement::wordAtOffset): added
(WTR::AccessibilityUIElement::lineAtOffset): added
(WTR::AccessibilityUIElement::sentenceAtOffset): added
LayoutTests:
New tests and expectations based on the tests and expectations found in atktest.c.
These were done as platform-specific tests because only ATK-based assistive technologies
seem to have any need for this support.
- platform/gtk/accessibility/text-at-offset-embedded-objects-expected.txt: Added.
- platform/gtk/accessibility/text-at-offset-embedded-objects.html: Added.
- platform/gtk/accessibility/text-at-offset-newlines-expected.txt: Added.
- platform/gtk/accessibility/text-at-offset-newlines.html: Added.
- platform/gtk/accessibility/text-at-offset-preformatted-expected.txt: Added.
- platform/gtk/accessibility/text-at-offset-preformatted.html: Added.
- platform/gtk/accessibility/text-at-offset-simple-expected.txt: Added.
- platform/gtk/accessibility/text-at-offset-simple.html: Added.
- platform/gtk/accessibility/text-at-offset-special-chars-expected.txt: Added.
- platform/gtk/accessibility/text-at-offset-special-chars.html: Added.
- platform/gtk/accessibility/text-at-offset-textarea-expected.txt: Added.
- platform/gtk/accessibility/text-at-offset-textarea.html: Added.
- platform/gtk/accessibility/text-at-offset-textinput-expected.txt: Added.
- platform/gtk/accessibility/text-at-offset-textinput.html: Added.
- platform/gtk/accessibility/text-at-offset-wrapped-lines-expected.txt: Added.
- platform/gtk/accessibility/text-at-offset-wrapped-lines.html: Added.
- 10:36 AM Changeset in webkit [160315] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix sh4 LLINT build.
https://bugs.webkit.org/show_bug.cgi?id=125454
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-12-09
Reviewed by Michael Saboff.
In LLINT, sh4 backend implementation didn't handle properly conditional jumps using
a LabelReference instance. This patch fixes it through sh4LowerMisplacedLabels phase.
Also, to avoid the need of a 4th temporary gpr, this phase is triggered later in
getModifiedListSH4.
- offlineasm/sh4.rb:
- 10:30 AM Changeset in webkit [160314] by
-
- 2 edits in trunk/Source/WebCore
[Nix] Fix file name typo in PlatformNix.cmake
https://bugs.webkit.org/show_bug.cgi?id=125457
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-12-09
Reviewed by Gustavo Noronha Silva.
Wrong file name introduced in http://trac.webkit.org/changeset/160310.
- PlatformNix.cmake:
- 10:30 AM Changeset in webkit [160313] by
-
- 8 edits in trunk/LayoutTests
Unreviewed EFL gardening
Add failure test expectations and rebaselines for failing tests.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- platform/efl-wk1/fast/forms/validation-message-appearance-expected.png: Rebaseline after r159915.
- platform/efl-wk2/fast/forms/validation-message-appearance-expected.png: Ditto.
- platform/efl/fast/forms/validation-message-appearance-expected.txt: Ditto.
- platform/efl/fast/parser/entity-comment-in-textarea-expected.png: Rebaseline after r159192.
- platform/efl/fast/parser/entity-comment-in-textarea-expected.txt: Ditto.
- 8:18 AM Changeset in webkit [160312] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Memory leak due to incorrect use of gst_tag_list_merge in TextCombinerGStreamer
https://bugs.webkit.org/show_bug.cgi?id=125452
Patch by Brendan Long <b.long@cablelabs.com> on 2013-12-09
Reviewed by Philippe Normand.
No new tests because this fixes a memory leak.
- platform/graphics/gstreamer/TextCombinerGStreamer.cpp:
(webkitTextCombinerPadEvent): Use gst_tag_list_insert instead of gst_tag_list_merge, since we don't want to create a new list.
- 6:17 AM Changeset in webkit [160311] by
-
- 4 edits2 adds in trunk
AX: WebKit ignores @alt on IMG elements with role="text"
https://bugs.webkit.org/show_bug.cgi?id=125363
Reviewed by Mario Sanchez Prada.
Source/WebCore:
If an <img> element has a different role, the alt attribute should still be used in the
name calculation if present.
Test: accessibility/alt-tag-on-image-with-nonimage-role.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::usesAltTagForTextComputation):
(WebCore::AccessibilityNodeObject::alternativeText):
(WebCore::AccessibilityNodeObject::accessibilityDescription):
(WebCore::AccessibilityNodeObject::text):
- accessibility/AccessibilityNodeObject.h:
LayoutTests:
- accessibility/alt-tag-on-image-with-nonimage-role-expected.txt: Added.
- accessibility/alt-tag-on-image-with-nonimage-role.html: Added.
- 6:10 AM Changeset in webkit [160310] by
-
- 14 edits2 adds in trunk/Source
[WK2][Soup] Use didReceiveBuffer instead of didReceiveData
https://bugs.webkit.org/show_bug.cgi?id=118598
Reviewed by Gustavo Noronha Silva.
Original patch by Kwang Yul Seo <skyul@company100.net> and Csaba Osztrogonác <Csaba Osztrogonác>.
Switch from using didReceiveData to didReceiveBuffer for the Soup backend and
let SharedBuffer wrap a SoupBuffer. This is necessary because the NetworkProcess
only supports getting data via SharedBuffer.
Source/WebCore:
- GNUmakefile.list.am: Add the new SharedBufferSoup.cpp file to the list.
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- PlatformNix.cmake:
- platform/SharedBuffer.cpp: We no longer used the no-op version of the platformFoo methods.
- platform/SharedBuffer.h: Ditto.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: Use didReceiveBuffer instead of didReceiveData.
- platform/network/ResourceHandleInternal.h: Have only a m_soupBuffer member instead of three to manage the buffer.
- platform/network/soup/GOwnPtrSoup.cpp: Add support for SoupBuffer.
- platform/network/soup/GOwnPtrSoup.h: Ditto.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::WebCoreSynchronousLoader::didReceiveData): ASSERT_NOT_REACHED here, since it should never be
called now.
(WebCore::WebCoreSynchronousLoader::didReceiveBuffer): Handle this call properly.
(WebCore::ResourceHandle::ensureReadBuffer): Now we package up our buffer into a SoupBuffer.
(WebCore::redirectSkipCallback): Use the new m_soupBuffer member.
(WebCore::cleanupSoupRequestOperation): Ditto.
(WebCore::nextMultipartResponsePartCallback): Ditto.
(WebCore::sendRequestCallback): Ditto.
(WebCore::readCallback):
- platform/soup/SharedBufferSoup.cpp: Added.
Source/WebKit/gtk:
- webkit/webkitdownload.cpp:
(DownloadClient::didReceiveData): Replace with ASSERT_NOT_REACHED.
(DownloadClient::didReceiveBuffer): Use this to process incoming data.
- 4:42 AM Changeset in webkit [160309] by
-
- 5 edits2 adds in trunk
Source/WebCore: DataCloneError exception is not thrown when postMessage's second parameter is the source
port or the target port.
https://bugs.webkit.org/show_bug.cgi?id=124708
Patch by Michal Poteralski <m.poteralski@samsung.com> on 2013-12-09
Reviewed by Alexey Proskuryakov.
According to specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/web-messaging.html#dom-window-postmessage
If the method was invoked with a second argument transfer then if any of the objects in the
transfer are either the source port or the target port (if any), then a DataCloneError
exception should be thrown. Currently an InvalidStateError exception is thrown what is an
incorrect behaviour.
The proposed solution is change to the correct the exception value.
Tests: fast/dom/Window/postMessage-clone-port-error.html
- dom/MessagePort.cpp:
(WebCore::MessagePort::postMessage): Improve exception value
LayoutTests: DataCloneError exception is not thrown when postMessage's second parameter
is the source port or the target port.
https://bugs.webkit.org/show_bug.cgi?id=124708
Patch by Michal Poteralski <m.poteralski@samsung.com> on 2013-12-09
Reviewed by Alexey Proskuryakov.
Added layout test to check correctness of value thrown by postMessage:
- fast/dom/Window/postMessage-clone-port-error-expected.txt: Added.
- fast/dom/Window/postMessage-clone-port-error.html: Added.
- 4:28 AM Changeset in webkit [160308] by
-
- 7 edits in trunk/Source/WebKit2
[WK2] Add UNIX_DOMAIN_SOCKETS specific bits for supporting NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=110093
Reviewed by Martin Robinson.
Original patch by Balazs Kelemen <kbalazs@webkit.org>.
Adds the UNIX specific bits to support connections to the
NetworkProcess. Since the process of creating the pair of sockets
is exactly the same as in the PluginProcess, I've decided to
refactor it in ConnectionUnix::createPlatformConnection(). This
can be reused later to create a cross-platform solution and remove
all the ifdefs (see bug 110978).
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::createNetworkConnectionToWebProcess):
- Platform/CoreIPC/Connection.h:
- Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::createPlatformConnection):
- PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::createWebProcessConnection):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::networkProcessCrashedOrFailedToLaunch):
(WebKit::NetworkProcessProxy::didCreateNetworkConnectionToWebProcess):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::ensureNetworkProcessConnection):
- 4:06 AM Changeset in webkit [160307] by
-
- 4 edits in trunk/Source/WebKit2
[WK2][Soup] Support cache model in NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=118343
Reviewed by Carlos Garcia Campos.
Original patch by Kwang Yul Seo <skyul@company100.net> and Csaba Osztrogonác <Csaba Osztrogonác>.
Copied cache model code from WebProcess.
NetworkProcess is configured not to use the WebCore memory cache.
- NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::getCacheDiskFreeSize):
(WebKit::getMemorySize):
(WebKit::NetworkProcess::platformInitializeNetworkProcess):
Initialize soup cache.
(WebKit::NetworkProcess::platformSetCacheModel):
Copied code from WebProcess::platformSetCacheModel but removed
WebCore memory cache initialization because NetworkProcess does not use
the WebCore memory cache.
(WebKit::NetworkProcess::clearCacheForAllOrigins):
Copied code from WebProcess::clearCacheForAllOrigins.
- NetworkProcess/unix/NetworkProcessMainUnix.cpp:
Copied initialization code from WebProcessMainGtk.cpp.
(WebKit::NetworkProcessMain):
- WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::platformSetCacheModel):
Don't set the disk cache if NetworkProcess is used.
(WebKit::WebProcess::platformClearResourceCaches):
Don't clear the non-existing disk cache. (if NetworkProcess is used)
(WebKit::WebProcess::platformInitializeWebProcess):
Don't initialize the disk cache if NetworkProcess is used.
- 3:49 AM Changeset in webkit [160306] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix the GTK+ build with NetworkProcess enabled.
- GNUmakefile.list.am: Add missing file to compilation.
- 3:45 AM Changeset in webkit [160305] by
-
- 3 edits in trunk/LayoutTests
accessibility/press-targets-center-point.html should not depend on font layout
https://bugs.webkit.org/show_bug.cgi?id=125387
Reviewed by Chris Fleizach.
- accessibility/press-targets-center-point.html: use explicit sizes for heights (and width
for vertical writing mode), so that font layout does not alter the results.
- platform/gtk/TestExpectations: remove failure expectation for accessibility/press-targets-center-point.html
- 1:55 AM Changeset in webkit [160304] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] run-webkit-tests may DOS the system, specially in debug builds
https://bugs.webkit.org/show_bug.cgi?id=125436
Reviewed by Martin Robinson.
- GNUmakefile.am: use -no-fast-install for WebKitWebProcess and WebKitPluginProcess so
they do not need to be relinked the first time they are executed in-tree.
- 1:54 AM Changeset in webkit [160303] by
-
- 5 edits1 delete in trunk/Source/WebKit2
[GTK][WK2] Move WebFullScreenManagerProxyGtk logic to PageClientImpl
https://bugs.webkit.org/show_bug.cgi?id=125440
Reviewed by Martin Robinson.
Make PageClientImpl a WebFullScreenManagerProxyClient. This brings the GTK port in line
with changes in r160296 and fixes the WK2 build for that port.
- GNUmakefile.list.am:
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::fullScreenManagerProxyClient):
(WebKit::PageClientImpl::closeFullScreenManager):
(WebKit::PageClientImpl::isFullScreen):
(WebKit::PageClientImpl::enterFullScreen):
(WebKit::PageClientImpl::exitFullScreen):
(WebKit::PageClientImpl::beganEnterFullScreen):
(WebKit::PageClientImpl::beganExitFullScreen):
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseCreateWebPage):
- UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:
- 1:37 AM Changeset in webkit [160302] by
-
- 8 edits in trunk
[WK2][Gtk] Add support for ENABLE_NETWORK_PROCESS to the build system
https://bugs.webkit.org/show_bug.cgi?id=118231
Patch by Brian Holt <brian.holt@samsung.com> on 2013-12-09
Reviewed by Martin Robinson.
Original patch by Kwang Yul Seo <skyul@company100.net>.
.:
Disabled ENABLE_NETWORK_PROCESS by default.
- Source/autotools/SetupAutomake.m4:
- Source/autotools/SetupWebKitFeatures.m4:
Source/WebKit2:
Add source files to the build system and build NetworkProcess executable.
- GNUmakefile.am:
- GNUmakefile.list.am:
- NetworkProcess/unix/NetworkProcessMainUnix.cpp:
- UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
