Timeline

Dec 16, 2013:

11:48 PM Changeset in webkit [160696] by barraclough@apple.com

• 20 edits in trunk/Source/WebKit2

Add layer hosting mode to ViewState
​https://bugs.webkit.org/show_bug.cgi?id=125803

Unreviewed - reverting last commit - might have broken tests. :-(

• Shared/ViewState.h:
• Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

• Shared/WebPageCreationParameters.h:
• UIProcess/API/mac/PageClientImpl.h:
• UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::viewWillMoveToAnotherWindow):
(WebKit::PageClientImpl::viewLayerHostingMode):

• UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::layerHostingModeDidChange):

• UIProcess/PageClient.h:

(WebKit::PageClient::viewLayerHostingMode):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::updateViewState):
(WebKit::WebPageProxy::viewStateDidChange):
(WebKit::WebPageProxy::initializeCreationParameters):

• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::layerHostingMode):

• UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
• UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::layerHostingModeDidChange):

• WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::resumePainting):
(WebKit::DrawingArea::setLayerHostingMode):

• WebProcess/WebPage/DrawingArea.messages.in:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::~WebPage):
(WebKit::WebPage::scalePage):
(WebKit::WebPage::setDeviceScaleFactor):
(WebKit::WebPage::setActive):
(WebKit::WebPage::setViewState):
(WebKit::WebPage::setWindowIsVisible):
(WebKit::WebPage::windowAndViewFramesChanged):

• WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::layerHostingMode):

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::setLayerHostingMode):

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::setLayerHostingMode):

• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::sendComplexTextInputToPlugin):
(WebKit::WebPage::setLayerHostingMode):

11:46 PM Changeset in webkit [160695] by barraclough@apple.com

• 20 edits in trunk/Source/WebKit2

Add layer hosting mode to ViewState
​https://bugs.webkit.org/show_bug.cgi?id=125803

Reviewed by Anders Carlsson.

When the view state of the page is updated the layer mode may also
change. Currently this is passed by a separate message, remove this
and fold it into ViewState.

Previously the setLayerHostingMode message would be passed to the
DrawingArea, which would inform the WebPage. Since the WebPage is
passed the SetVisibilityState messgae reverse this.

WebPageProxy had a policy of only updating the hosting mode when
visible - the value is sticky whilst the view is not visible. Make
this policy explicit in the PageClientImpl, rather then implicit
from the flow control.

• Shared/ViewState.h:
  • Added ViewState::IsLayerWindowServerHosted.
• Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

• Shared/WebPageCreationParameters.h:
  • removed layerHostingMode.
• UIProcess/API/mac/PageClientImpl.h:
• UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::isLayerWindowServerHosted):
(WebKit::PageClientImpl::viewWillMoveToAnotherWindow):

• viewLayerHostingMode -> isLayerWindowServerHosted, added m_layerHostingMode.

• UIProcess/DrawingAreaProxy.h:
  • removed layerHostingModeDidChange.
• UIProcess/PageClient.h:
  • viewLayerHostingMode -> isLayerWindowServerHosted.
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):

• removed m_layerHostingMode.

(WebKit::WebPageProxy::updateViewState):

• added IsLayerWindowServerHosted.

(WebKit::WebPageProxy::viewStateDidChange):

• changes to ViewState::IsInWindow implies ViewState::IsLayerWindowServerHosted may change too.
• remove special handling (separate message) for LayerHostingMode.

(WebKit::WebPageProxy::initializeCreationParameters):

• removed m_layerHostingMode.

• UIProcess/WebPageProxy.h:
  • removed m_layerHostingMode.
• UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
• UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
  • removed layerHostingModeDidChange.
• WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::setLayerHostingMode):
(WebKit::DrawingArea::didUpdate):

• setLayerHostingMode takes a LayerHostingMode.

• WebProcess/WebPage/DrawingArea.messages.in:
  • SetLayerHostingMode is no longer a message.
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

• removed m_layerHostingMode.

(WebKit::WebPage::setViewState):

• handle ViewState::IsLayerWindowServerHosted.

(WebKit::WebPage::setLayerHostingMode):

• moved from ~Mac.mm (matching other ViewState setters), calls to DrawingArea.

• WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::layerHostingMode):

• layerHostingMode queries m_viewState, removed m_layerHostingMode.

• WebProcess/WebPage/ios/WebPageIOS.mm:
  • removed setLayerHostingMode.
• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::setLayerHostingMode):

• setLayerHostingMode takes a LayerHostingMode, WebPage now calls to DrawingArea.

• WebProcess/WebPage/mac/WebPageMac.mm:
  • removed setLayerHostingMode.

10:09 PM Changeset in webkit [160694] by msaboff@apple.com

• 9 edits in branches/jsCStack/Source/JavaScriptCore

CStack Branch: Need an implementation of sanitizeStack for C stack
​https://bugs.webkit.org/show_bug.cgi?id=125719

Reviewed by Geoffrey Garen.

Implemented sanitizeStackForVM() as a LLInt stub. It clears memory beyond
the top of stack through the last stack top, which is stored in the VM.

• dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

• heap/Heap.cpp:

(JSC::Heap::markRoots):

• interpreter/JSStack.cpp:

(JSC::JSStack::sanitizeStack):

• llint/LowLevelInterpreter.asm:
• runtime/VM.cpp:

(JSC::VM::VM):
(JSC::sanitizeStackForVM):

• runtime/VM.h:

(JSC::VM::lastStackTop):
(JSC::VM::setLastStackTop):

• runtime/VMEntryScope.cpp:

(JSC::VMEntryScope::VMEntryScope):
(JSC::VMEntryScope::~VMEntryScope):

• runtime/VMEntryScope.h:

8:12 PM Changeset in webkit [160693] by thiago.lacerda@openbossa.org

• 10 edits
  11 adds in trunk

Checking RTCPeerConnection signalingState before setting local/remoteDescription
​https://bugs.webkit.org/show_bug.cgi?id=125655

Reviewed by Eric Carlson.

Before setting a session description RTCPeerConnection must check if it is in valid state for that SDP type.

Source/WebCore:

New tests: fast/mediastream/RTCPeerConnection-have-local-answer.html

fast/mediastream/RTCPeerConnection-have-local-offer.html
fast/mediastream/RTCPeerConnection-have-local-pranswer.html
fast/mediastream/RTCPeerConnection-have-remote-offer.html
fast/mediastream/RTCPeerConnection-have-remote-pranswer.html
fast/mediastream/RTCPeerConnection-stable.html

Modified: fast/mediastream/RTCPeerConnection-remoteDescription.html

• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::checkStateForLocalDescription): Checks if the current state of RTCPeerConnection is
valid for the local SDP that is being set.
(WebCore::RTCPeerConnection::checkStateForRemoteDescription): Checks if the current state of RTCPeerConnection
is valid for the remote SDP that is being set.
(WebCore::RTCPeerConnection::setLocalDescription): Now calls checkStateForLocalDescription prior to set the
local SDP.
(WebCore::RTCPeerConnection::setRemoteDescription): Now Calls checkStateForRemoteDescription prior to set the
remote SDP.

• Modules/mediastream/RTCPeerConnection.h:
• platform/mock/RTCNotifiersMock.cpp: Adding new class to notify RTCPeerConnection about a signaling state

change: SignalingStateNotifier.
(WebCore::SignalingStateNotifier::SignalingStateNotifier):
(WebCore::SignalingStateNotifier::fire):

• platform/mock/RTCNotifiersMock.h:
• platform/mock/RTCPeerConnectionHandlerMock.cpp:

(WebCore::RTCPeerConnectionHandlerMock::signalingStateFromSDP): Defines the new state that RTCPeerConnection
should be, according the SDP that is being set.
(WebCore::RTCPeerConnectionHandlerMock::setLocalDescription): Calls signalingStateFromSDP, in order to get the
new signaling state and notify RTCPeerConnection object.
(WebCore::RTCPeerConnectionHandlerMock::setRemoteDescription): Ditto.

• platform/mock/RTCPeerConnectionHandlerMock.h:

LayoutTests:

• fast/mediastream/RTCPeerConnection-have-local-answer.html: Added.
• fast/mediastream/RTCPeerConnection-have-local-offer-expected.txt: Added.
• fast/mediastream/RTCPeerConnection-have-local-offer.html: Added.
• fast/mediastream/RTCPeerConnection-have-local-pranswer-expected.txt: Added.
• fast/mediastream/RTCPeerConnection-have-local-pranswer.html: Added.
• fast/mediastream/RTCPeerConnection-have-remote-offer-expected.txt: Added.
• fast/mediastream/RTCPeerConnection-have-remote-offer.html: Added.
• fast/mediastream/RTCPeerConnection-have-remote-pranswer-expected.txt: Added.
• fast/mediastream/RTCPeerConnection-have-remote-pranswer.html: Added.
• fast/mediastream/RTCPeerConnection-remoteDescription-expected.txt:
• fast/mediastream/RTCPeerConnection-remoteDescription.html:
• fast/mediastream/RTCPeerConnection-stable-expected.txt: Added.
• fast/mediastream/RTCPeerConnection-stable.html: Added.

7:48 PM Changeset in webkit [160692] by weinig@apple.com

• 3 edits in trunk/Source/WebKit2

[Cocoa] Remove unused contentAnchor SPI from WKView
​https://bugs.webkit.org/show_bug.cgi?id=125826

Reviewed by Tim Horton.

• UIProcess/API/Cocoa/WKViewPrivate.h:
• UIProcess/API/mac/WKView.mm:

(-[WKView setFrameSize:]):
(-[WKView _setDrawingAreaSize:]):
(-[WKView _setAcceleratedCompositingModeRootLayer:]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

7:06 PM Changeset in webkit [160691] by alex.christensen@flexsim.com

• 2 edits in trunk/Source/WebKit

[Win] Unreviewed build fix for 64-bit.

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Corrected 64-bit linker symbols.

6:56 PM Changeset in webkit [160690] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebCore

Revert a mysterious and inexplicable part of ​http://trac.webkit.org/changeset/160685

• platform/KeyedCoding.h:

(WebCore::KeyedEncoder::encodeEnum):
(WebCore::KeyedEncoder::encodeObject):
(WebCore::KeyedEncoder::encodeConditionalObject):
(WebCore::KeyedEncoder::encodeObjects):

6:43 PM Changeset in webkit [160689] by rwlbuis@webkit.org

• 2 edits in trunk/Tools

Add my Samsung email address.

Unreviewed.

• Scripts/webkitpy/common/config/contributors.json:

6:43 PM Changeset in webkit [160688] by oliver@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Avoid indirect function calls for custom getters
​https://bugs.webkit.org/show_bug.cgi?id=125821

Reviewed by Mark Hahnenberg.

Rather than invoking a helper function to perform an indirect call
through a function pointer, just have the JIT call the function directly.

Unfortunately this only works in JSVALUE64 at the moment as there
is not an obvious way to pass two EncodedJSValues uniformly over
the various effected JITs.

• jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArguments):

• jit/Repatch.cpp:

(JSC::generateProtoChainAccessStub):
(JSC::tryBuildGetByIDList):

6:27 PM Changeset in webkit [160687] by andersca@apple.com

• 19 edits
  1 delete in trunk/Source

Remove EnumClass.h from WTF
​https://bugs.webkit.org/show_bug.cgi?id=125820

Reviewed by Darin Adler.

Source/WebCore:

Replace uses of ENUM_CLASS with real enum class declarations.

• Modules/webdatabase/DatabaseBasicTypes.h:
• Modules/webdatabase/DatabaseError.h:
• Modules/webdatabase/SQLTransactionState.h:
• bindings/js/JSSubtleCryptoCustom.cpp:
• bindings/js/SerializedScriptValue.cpp:
• crypto/CryptoAlgorithmIdentifier.h:
• crypto/CryptoAlgorithmParameters.h:
• crypto/CryptoKey.h:
• crypto/CryptoKeyData.h:
• crypto/CryptoKeyType.h:
• crypto/keys/CryptoKeyDataRSAComponents.h:
• inspector/InspectorTimelineAgent.h:

Source/WTF:

All compilers we build on now support real strongly typed enums, so we can remove the ENUM_CLASS version.

• WTF.vcxproj/WTF.vcxproj:
• WTF.vcxproj/WTF.vcxproj.filters:
• WTF.xcodeproj/project.pbxproj:
• wtf/CheckedArithmetic.h:
• wtf/EnumClass.h: Removed.

6:16 PM Changeset in webkit [160686] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

WebKit2 View Gestures: Pinching beyond the extremes doesn't animate back to the min/max
​https://bugs.webkit.org/show_bug.cgi?id=125750

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::commitTransientZoom):
Remove some accidentally included commented out code.

6:12 PM Changeset in webkit [160685] by timothy_horton@apple.com

• 7 edits in trunk/Source

WebKit2 View Gestures: Pinching beyond the extremes doesn't animate back to the min/max
​https://bugs.webkit.org/show_bug.cgi?id=125750

Reviewed by Simon Fraser.

When you let go of a pinch where you exceeded the maximum or minimum scale,
the view should animate back to the limit instead of snapping back.

• UIProcess/mac/ViewGestureController.cpp:

(WebKit::ViewGestureController::endMagnificationGesture):
Unscrolling the scaled origin here is wrong; we should send the same
value for 'origin' for commitTransientZoom that we do for adjustTransientZoom.
The drawing area can deal with transforming that however it needs to call scalePage().

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::beginTransientZoom):
Drive-by use WebPage::mainFrameView().

(WebKit::TiledCoreAnimationDrawingArea::adjustTransientZoom):
Update the shadow layer's bounds, position, and shadow path while zooming,
instead of hiding it.

(WebKit::transientZoomSnapAnimationForKeyPath):
Create a CABasicAnimation that stays applied to its target when it finishes,
lasts for a quarter second, and uses the ease-in-ease-out timing function.

(WebKit::constrainZoomOriginForFrameView):
When we land a transient zoom, there may be overhang areas (linen, in the case of Mac)
visible. During the commit animation, we should move the RenderView layer appropriately
so that the page covers the entire view and there are no overhang areas visible.
Adapt some code from ScrollableArea to constrain the zoom origin to do so.

(WebKit::TiledCoreAnimationDrawingArea::commitTransientZoom):
Animate the RenderView layer's transform, and the shadow layer's bounds, position, and path.
When they complete, apply the zoom via scalePage() and flush the layer tree (otherwise there
can be a flash between removing the animations and the next flush with the new scale).

(WebKit::TiledCoreAnimationDrawingArea::applyTransientZoomToPage):
Move the code to land the transient zoom (via scalePage) and to put the shadow back
in the state WebCore left it out into its own function, so it can be called both from the
animation completion callback and from the short-circuit in the case where we don't need to animate.

• WebCore.exp.in:

Export a few things so WebKit2 can use them.

6:02 PM Changeset in webkit [160684] by ryuan.choi@samsung.com

• 5 edits in trunk/Source/WebKit2

Unreviewed. Fix GTK+ build after r160653.

Renamed WebData to API::Data

• GNUmakefile.list.am: Added APIData.cpp and APIData.h
• UIProcess/API/gtk/WebKitURISchemeRequest.cpp:

(webkitURISchemeRequestReadCallback):

• UIProcess/API/gtk/WebKitWebResource.cpp:
• UIProcess/API/gtk/WebKitWebView.cpp:

6:00 PM Changeset in webkit [160683] by commit-queue@webkit.org

• 8 edits in trunk/Source

Fix some whitespace issues in inspector code
​https://bugs.webkit.org/show_bug.cgi?id=125814

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-12-16
Reviewed by Darin Adler.

Source/JavaScriptCore:

• inspector/protocol/Debugger.json:
• inspector/protocol/Runtime.json:
• inspector/scripts/CodeGeneratorInspector.py:

(Generator.process_command):

Source/WebCore:

• inspector/protocol/DOM.json:
• inspector/protocol/DOMStorage.json:
• inspector/protocol/Timeline.json:

5:36 PM Changeset in webkit [160682] by commit-queue@webkit.org

• 10 edits
  2 deletes in trunk/Source/WebCore

Web Inspector: Use JSC::SourceID and JSC::BreakpointID instead of WebCore dups
​https://bugs.webkit.org/show_bug.cgi?id=125818

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-12-16
Reviewed by Mark Lam.

Remove the WebCore typedefs of JSC types. Prefer JSC namespace
prefixed types throughout WebCore's Inspector code.

• GNUmakefile.list.am:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/BreakpointID.h: Removed.
• bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::dispatchDidParseSource):

• bindings/js/ScriptDebugServer.h:
• bindings/js/SourceID.h: Removed.
• inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::parseLocation):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::continueToLocation):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::getScriptSource):
(WebCore::InspectorDebuggerAgent::didParseSource):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::clear):

• inspector/InspectorDebuggerAgent.h:
• inspector/ScriptDebugListener.h:

5:35 PM Changeset in webkit [160681] by benjamin@webkit.org

• 2 edits in trunk/Source/WebKit2

[WK2][iOS] WKView sends unscaled scroll position to WKContentView
​https://bugs.webkit.org/show_bug.cgi?id=125819

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-12-16
Reviewed by Anders Carlsson.

WKView was sending untransformed scroll coordinates to WKContentView. The scroll position
seen by WebKit was wrong when the content is scaled.

• UIProcess/API/ios/WKView.mm:

(-[WKView _didScroll]):
(-[WKView scrollViewDidEndDragging:willDecelerate:]):
(-[WKView scrollViewDidEndDecelerating:]):
(-[WKView scrollViewDidScrollToTop:]):

5:33 PM Changeset in webkit [160680] by mhahnenberg@apple.com

• 8 edits in trunk/Source/JavaScriptCore

Add some missing functions to MacroAssembler
​https://bugs.webkit.org/show_bug.cgi?id=125809

Reviewed by Oliver Hunt.

• assembler/AbstractMacroAssembler.h:
• assembler/AssemblerBuffer.h:
• assembler/LinkBuffer.cpp:
• assembler/MacroAssembler.h:

(JSC::MacroAssembler::storePtr):
(JSC::MacroAssembler::andPtr):

• assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::and64):
(JSC::MacroAssemblerARM64::branchTest8):

• assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::branchTest8):

• assembler/X86Assembler.h:

5:32 PM Changeset in webkit [160679] by dbates@webkit.org

• 40 edits in trunk/Source/WebCore

[iOS] Upstream WebCore/dom changes
​https://bugs.webkit.org/show_bug.cgi?id=125646

Reviewed by David Kilzer.

• WebCore.exp.in: Added symbol ZN7WebCore8Settings17setLayoutIntervalEi and removed symbol

ZN7WebCore24cLayoutScheduleThresholdE.

• dom/ActiveDOMObject.h: Add suspension reason DocumentWillBePaused.
• dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument): Opt-out of ENABLE(VIDEO) logic when
building for iOS.

• dom/DeviceMotionClient.h: Made class non-copyable.

(WebCore::DeviceMotionClient::DeviceMotionClient): Added;

• dom/DeviceMotionController.cpp: Added FIXME comment to reconcile iOS and OpenSource differences.

(WebCore::DeviceMotionController::suspendUpdates): Added; guarded by PLATFORM(IOS).
(WebCore::DeviceMotionController::resumeUpdates): Added; guarded by PLATFORM(IOS).

• dom/DeviceMotionController.h: Added FIXME comment to reconcile iOS and OpenSource differences.
• dom/DeviceOrientationClient.h: Made class non-copyable.

(WebCore::DeviceOrientationClient::DeviceOrientationClient): Added.

• dom/DeviceOrientationController.cpp: Added FIXME comment to reconcile iOS and OpenSource differences.

(WebCore::DeviceOrientationController::DeviceOrientationController):
(WebCore::DeviceOrientationController::suspendUpdates): Added; guarded by PLATFORM(IOS).
(WebCore::DeviceOrientationController::resumeUpdates): Added; guarded by PLATFORM(IOS).

• dom/DeviceOrientationController.h: Added FIXME comment to reconcile iOS and OpenSource differences.
• dom/DeviceOrientationData.cpp:

(WebCore::DeviceOrientationData::create): Added; iOS-specific. Added FIXME comment.
(WebCore::DeviceOrientationData::DeviceOrientationData): Added iOS-specific code.
(WebCore::DeviceOrientationData::compassHeading): Added; guarded by PLATFORM(IOS).
(WebCore::DeviceOrientationData::compassAccuracy): Added; guarded by PLATFORM(IOS).
(WebCore::DeviceOrientationData::canProvideCompassHeading): Added; guarded by PLATFORM(IOS).
(WebCore::DeviceOrientationData::canProvideCompassAccuracy): Added; guarded by PLATFORM(IOS).

• dom/DeviceOrientationData.h:
• dom/DeviceOrientationEvent.idl: Added iOS-specific code.
• dom/Document.cpp: Moved constant cLayoutScheduleThreshold to Settings.cpp and renamed it

layoutScheduleThreshold towards allowing a port to configure the layout interval.
(WebCore::Document::Document): Added optional argument isSynthesized, defaults false.
(WebCore::Document::~Document): Added iOS-specific code to destroy the device motion
and device orientation controllers.
(WebCore::Document::didBecomeCurrentDocumentInFrame): Added iOS-specific code with FIXME comment.
(WebCore::Document::prepareForDestruction): Added iOS-specific touch event code.
(WebCore::Document::removeAllEventListeners): Ditto.
(WebCore::Document::platformSuspendOrStopActiveDOMObjects): Added; compiles to an empty function on
non-iOS port.
(WebCore::Document::suspendActiveDOMObjects): Modified to call platformSuspendOrStopActiveDOMObjects().
(WebCore::Document::resumeActiveDOMObjects): Ditto.
(WebCore::Document::stopActiveDOMObjects): Added.
(WebCore::Document::implicitClose): Modified to query Settings::layoutInterval().
(WebCore::Document::minimumLayoutDelay): Ditto.
(WebCore::Document::processViewport): Added iOS-specific code.
(WebCore::Document::updateViewportArguments): Ditto.
(WebCore::setParserFeature): Added; guarded by PLATFORM(IOS).
(WebCore::Document::processFormatDetection): Added; guarded by PLATFORM(IOS).
(WebCore::Document::processWebAppOrientations): Added; guarded by PLATFORM(IOS).
(WebCore::Document::isTelephoneNumberParsingEnabled): Added; guarded by PLATFORM(IOS).
(WebCore::Document::setIsTelephoneNumberParsingAllowed): Added; guarded by PLATFORM(IOS).
(WebCore::Document::isTelephoneNumberParsingAllowed): Added; guarded by PLATFORM(IOS).
(WebCore::Document::initSecurityContext): Added iOS-specific code.
(WebCore::Document::suspendScheduledTasks): Added; guarded by PLATFORM(IOS).
(WebCore::Document::deviceMotionController): Added; iOS-specific.
(WebCore::Document::deviceOrientationController): Added; iOS-specific.
(WebCore::Document::adjustFloatQuadsForScrollAndAbsoluteZoomAndFrameScale): Added iOS-specific code.
(WebCore::Document::adjustFloatRectForScrollAndAbsoluteZoomAndFrameScale): Added iOS-specific code.

• dom/Document.h: Register gesture events gesture{change, end, start}; guarded by ENABLE(IOS_GESTURE_EVENTS).

(WebCore::Document::isSynthesized): Added.
(WebCore::Document::platformSuspendOrStopActiveDOMObjects): Added.

• dom/Document.idl:
• dom/DocumentMarker.h: Added iOS-specific changes. We should look to reconcile the differences between

iOS and OpenSource. See <rdar://problem/11306422>.
(WebCore::DocumentMarker::AllMarkers::AllMarkers):
(WebCore::DocumentMarker::DocumentMarker): Added; iOS-specific.
(WebCore::DocumentMarker::alternatives): Added; iOS-specific.
(WebCore::DocumentMarker::setAlternative): Added; iOS-specific.
(WebCore::DocumentMarker::metadata): Added; iOS-specific.
(WebCore::DocumentMarker::setMetadata): Added; iOS-specific.

• dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::addMarker):
(WebCore::DocumentMarkerController::addDictationPhraseWithAlternativesMarker):
(WebCore::DocumentMarkerController::addDictationResultMarker):
(WebCore::DocumentMarkerController::shiftMarkers):

• dom/DocumentMarkerController.h:
• dom/Element.cpp:

(WebCore::Element::focus): Add iOS-specific workaround for <rdar://problem/6699741>.

• dom/Element.h: Register gesture events gesture{change, end, start}; guarded by ENABLE(IOS_GESTURE_EVENTS).
• dom/EventContext.cpp: Opt-out of ENABLE(TOUCH_EVENTS)-guarded code when building the iOS port.
• dom/EventContext.h: Ditto.
• dom/EventDispatcher.cpp:

(WebCore::EventRelatedNodeResolver::EventRelatedNodeResolver): Ditto.
(WebCore::EventDispatcher::dispatchEvent): Ditto.
(WebCore::EventPath::EventPath): Ditto.

• dom/EventNames.h: Added events webkit{currentplaybacktargetiswirelesschanged, playbacktargetavailabilitychanged}

and gesture{change, end, start}.

• dom/EventNames.in: Added event names GestureEvent and WebKitPlaybackTargetAvailabilityEvent conditioned on

the macro defines ENABLE_IOS_GESTURE_EVENTS and ENABLE_IOS_AIRPLAY.

• dom/MouseRelatedEvent.cpp:

(WebCore::contentsScrollOffset): Added iOS-specific code.
(WebCore::MouseRelatedEvent::MouseRelatedEvent): Ditto.

• dom/Node.cpp:

(WebCore::Node::willBeDeletedFrom): Ditto.
(WebCore::Node::isDescendantOf): Fixed style issue in function prototype; moved '*' to the left side.
(WebCore::Node::isDescendantOrShadowDescendantOf): Added.
(WebCore::tryAddEventListener): Added iOS-specific code; also added FIXME comment.
(WebCore::tryRemoveEventListener): Ditto.
(WebCore::Node::dispatchEvent): Opt-out of ENABLE(TOUCH_EVENTS)-guarded code when building the iOS port.
(WebCore::Node::defaultEventHandler): Added iOS-specific code.
(WebCore::Node::willRespondToMouseMoveEvents): Added iOS-specific code; also added FIXME comment.
(WebCore::Node::willRespondToMouseClickEvents): Added iOS-specific code; also added FIXME comment.
(WebCore::Node::willRespondToMouseWheelEvents): Added.

• dom/Node.h:
• dom/Position.h:

(WebCore::operator<): Added.
(WebCore::operator>): Added.
(WebCore::operator>=): Added.
(WebCore::operator<=): Added.

• dom/Range.cpp:

(WebCore::Range::create): Added iOS-specific code; also added FIXME comment.
(WebCore::intervalsSufficientlyOverlap): Added; guarded by PLATFORM(IOS).
(WebCore::printRects): Added; guarded by PLATFORM(IOS).
(WebCore::adjustLineHeightOfSelectionRects): Added; guarded by PLATFORM(IOS).
(WebCore::coalesceSelectionRects): Added; guarded by PLATFORM(IOS).
(WebCore::Range::collectSelectionRects): Added; guarded by PLATFORM(IOS).

• dom/Range.h:
• dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::suspendActiveDOMObjects): Added iOS-specific code.
(WebCore::ScriptExecutionContext::dispatchErrorEvent): Ditto.

• dom/TreeScope.cpp:

(WebCore::nodeFromPoint): Ditto.

• dom/ViewportArguments.cpp:

(WebCore::computeViewportAttributes): Ditto.
(WebCore::setViewportFeature): Added iOS-specific code.
(WebCore::finalizeViewportArguments): Added; iOS-specific.

• dom/ViewportArguments.h:
• dom/make_names.pl: Added support to find the path to gcc with respect to the environment

variable SDKROOT.

• html/HTMLMediaElement.cpp:

(HTMLMediaElement::suspend):

• page/Settings.cpp:

(WebCore::Settings::Settings): Initialize setting m_layoutInterval to layoutScheduleThreshold.
(WebCore::Settings::setLayoutInterval): Added.

• page/Settings.h:

(WebCore::Settings::layoutInterval): Added.

5:12 PM Changeset in webkit [160678] by beidson@apple.com

• 14 edits in trunk/Source/WebKit2

DatabaseProcess: Plumb through messaging for the 4 basic transaction operations
​https://bugs.webkit.org/show_bug.cgi?id=125816

Reviewed by Alexey Proskuryakov.

The messaging begins and ends in the WebProcess:

• WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::beginTransaction):
(WebKit::WebIDBServerConnection::didBeginTransaction):
(WebKit::WebIDBServerConnection::commitTransaction):
(WebKit::WebIDBServerConnection::didCommitTransaction):
(WebKit::WebIDBServerConnection::resetTransaction):
(WebKit::WebIDBServerConnection::didResetTransaction):
(WebKit::WebIDBServerConnection::rollbackTransaction):
(WebKit::WebIDBServerConnection::didRollbackTransaction):

• WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
• WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in:

It travels from the WebProcess to the DatabaseProcess connection:

• DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

(WebKit::DatabaseProcessIDBConnection::beginTransaction):
(WebKit::DatabaseProcessIDBConnection::commitTransaction):
(WebKit::DatabaseProcessIDBConnection::resetTransaction):
(WebKit::DatabaseProcessIDBConnection::rollbackTransaction):

• DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
• DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:

It travels from the connection to the appropriate UniqueIDBDatabase:

• DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::openTransaction):
(WebKit::UniqueIDBDatabase::beginTransaction):
(WebKit::UniqueIDBDatabase::commitTransaction):
(WebKit::UniqueIDBDatabase::resetTransaction):
(WebKit::UniqueIDBDatabase::rollbackTransaction):
(WebKit::UniqueIDBDatabase::postTransactionOperation):
(WebKit::UniqueIDBDatabase::didCompleteTransactionOperation):
(WebKit::UniqueIDBDatabase::openBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::beginBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::commitBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::resetBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::rollbackBackingStoreTransaction):

• DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:

The UniqueIDBDatabase object performs the operation with the backing store:

• DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
• DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::establishTransaction):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::beginTransaction):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::commitTransaction):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::resetTransaction):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::rollbackTransaction):

• DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:

And the SQLite backing store calls the appropriate method on the SQLite transaction:

• DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.cpp:

(WebKit::SQLiteIDBTransaction::begin): Stubbed for now.
(WebKit::SQLiteIDBTransaction::commit): Ditto.
(WebKit::SQLiteIDBTransaction::reset): Ditto.
(WebKit::SQLiteIDBTransaction::rollback): Ditto.

• DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.h:

4:55 PM Changeset in webkit [160677] by Simon Fraser

• 3 edits in trunk/Source/WebCore

Attempt to fix the Windows build after r160672.

• platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayerWin::PlatformCALayerWin):

• platform/graphics/ca/win/PlatformCALayerWin.h:

4:44 PM Changeset in webkit [160676] by ryuan.choi@samsung.com

• 5 edits in trunk/Source/WebKit2

Unreviewed build fix on EFL port after r160653

Rename WebData to API::Data

• CMakeLists.txt: Added APIData.cpp to include list.
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::sessionStateData):
(WebKit::WebPageProxy::restoreFromSessionStateData):

• UIProcess/soup/WebSoupRequestManagerProxy.cpp:

(WebKit::WebSoupRequestManagerProxy::didHandleURIRequest):
(WebKit::WebSoupRequestManagerProxy::didReceiveURIRequestData):
(WebKit::WebSoupRequestManagerProxy::didReceiveURIRequest):

• UIProcess/soup/WebSoupRequestManagerProxy.h:

4:35 PM Changeset in webkit [160675] by timothy_horton@apple.com

• 4 edits in trunk/Source/WebKit2

WKView.magnification should include magnification due to the active gesture
​https://bugs.webkit.org/show_bug.cgi?id=125813

Reviewed by Simon Fraser.

Make WKView.magnification respect active pinch-zoom gestures.

• UIProcess/API/mac/WKView.mm:

(-[WKView magnification]):
If we have a ViewGestureController, defer to it for the current magnification.

• UIProcess/mac/ViewGestureController.cpp:

(WebKit::ViewGestureController::magnification):
Return either the current pinch-zoom magnification, if we're in the middle of a gesture,
or the pageScaleFactor, if we're not.

• UIProcess/mac/ViewGestureController.h:

4:29 PM Changeset in webkit [160674] by Brent Fulgham

• 2 edits in trunk/Source/WebKit

[Win] Unreviewed build fix.

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Correct typo that added a '\' at the

end of a line of the file.

4:24 PM Changeset in webkit [160673] by benjamin@webkit.org

• 2 edits in trunk/Source/WebKit2

[WK2] Remove the constraint that highlight rects must be smaller than the scrollview bounds
​https://bugs.webkit.org/show_bug.cgi?id=125812

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-12-16
Reviewed by Dan Bernstein.

Currently, _scrollView is never set on WKInteractionView and all highlight rects are discarded.

Eventually, the constraint rect should be computed from the useful area of ScrollView and the scale
of the document. In the meantime, the constraint code is just causing troubles.

The issue is tracked by <rdar://problem/15673655>.

• UIProcess/API/ios/WKInteractionView.mm:

(-[WKInteractionView _didGetTapHighlightForRequest:color:WebCore::quads:WebCore::topLeftRadius:WebCore::topRightRadius:WebCore::bottomLeftRadius:WebCore::bottomRightRadius:WebCore::]):

4:13 PM Changeset in webkit [160672] by Simon Fraser

• 19 edits in trunk/Source

Apply overhang shadow and linen to UI-side layers
​https://bugs.webkit.org/show_bug.cgi?id=125807

Source/WebCore:

Reviewed by Tim Horton.

With UI-side compositing, we need to apply the overhang shadow and linen
background to layers in the UI process. Achieve this by setting a "custom
appearance" flag on layers that need a shadow or linen background, and
migrating this flag to the UI process. Static functions on ScrollbarThemeMac
are exposed to do the actual setting.

• WebCore.exp.in: Export ScrollbarThemeMac and GraphicsLayerCA functions.
• WebCore.xcodeproj/project.pbxproj: ScrollbarThemeMac.h and ScrollbarThemeComposite.h

need to be Private.

• platform/graphics/GraphicsLayer.cpp: Initialize m_customAppearance.

(WebCore::GraphicsLayer::GraphicsLayer):

• platform/graphics/GraphicsLayer.h: Getter/setter for CustomAppearance.

(WebCore::GraphicsLayer::setCustomAppearance):
(WebCore::GraphicsLayer::customAppearance):

• platform/graphics/ca/GraphicsLayerCA.cpp: Update CustomAppearanceChanged as

we do other properties.
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::updateCustomAppearance):
(WebCore::GraphicsLayerCA::setCustomAppearance):

• platform/graphics/ca/GraphicsLayerCA.h:
• platform/graphics/ca/PlatformCALayer.h:
• platform/graphics/ca/mac/PlatformCALayerMac.h:
• platform/graphics/ca/mac/PlatformCALayerMac.mm: When we have a custom

appearance, use ScrollbarThemeMac functions to update the layer. Ensure
that if the bounds change, we update the shadow (whose path depends on the bounds).
(PlatformCALayerMac::PlatformCALayerMac):
(PlatformCALayerMac::clone):
(PlatformCALayerMac::setBounds):
(PlatformCALayerMac::requiresCustomAppearanceUpdateOnBoundsChange):
(PlatformCALayerMac::updateCustomAppearance):

• platform/mac/ScrollbarThemeMac.h: Export some static functions.
• platform/mac/ScrollbarThemeMac.mm: Change code to use static functions.

(WebCore::ScrollbarThemeMac::setUpOverhangAreaBackground):
(WebCore::ScrollbarThemeMac::removeOverhangAreaBackground):
(WebCore::ScrollbarThemeMac::setUpOverhangAreaShadow):
(WebCore::ScrollbarThemeMac::removeOverhangAreaShadow):
(WebCore::ScrollbarThemeMac::setUpOverhangAreasLayerContents):
(WebCore::ScrollbarThemeMac::setUpContentShadowLayer):

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateRootLayerPosition): No need to call
setUpContentShadowLayer() now when size changes; PlatformCALayer takes
care of that.
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers): Now set
custom appearance via GraphicsLayer.

Source/WebKit2:

Reviewed by Tim Horton.

With UI-side compositing, we need to apply the overhang shadow and linen
background to layers in the UI process. Achieve this by setting a "custom
appearance" flag on layers that need a shadow or linen background, and
migrating this flag to the UI process. Static functions on ScrollbarThemeMac
are exposed to do the actual setting.

• Shared/mac/RemoteLayerTreePropertyApplier.mm:

(WebKit::updateCustomAppearance): Use ScrollbarThemeMac to update the
appearance.
(WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer):

• Shared/mac/RemoteLayerTreeTransaction.h:
• Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::dumpChangedLayers):

• WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::setBounds): If the bounds change, also set the
CustomAppearanceChanged bit so that the UI side updates the shadow bounds
(done here because the UI side is not stateful).
(PlatformCALayerRemote::requiresCustomAppearanceUpdateOnBoundsChange):
(PlatformCALayerRemote::customAppearance):
(PlatformCALayerRemote::updateCustomAppearance):

• WebProcess/WebPage/mac/PlatformCALayerRemote.h:

4:06 PM Changeset in webkit [160671] by Brent Fulgham

• 18 edits in trunk/Source

Source/JavaScriptCore: [Win] Remove dead code after conversion to VS2013
​https://bugs.webkit.org/show_bug.cgi?id=125795

Reviewed by Darin Adler.

• API/tests/testapi.c: Remove local nan implementation

Source/WebCore: [Win] Remove dead code after converstion to VS2013
​https://bugs.webkit.org/show_bug.cgi?id=125795

Reviewed by Darin Adler.

• WebCorePrefix.h: Remove VS2012 include kludge.
• loader/FTPDirectoryParser.cpp: Remove gmtime workaround code.
• page/DOMWindow.cpp: Remove older pointer-based open implementation.
• page/DOMWindow.h: Ditto
• platform/text/TextEncodingRegistry.cpp:

(WebCore::TextEncodingNameHash::equal): Remove optimization bug workaround

• testing/Internals.cpp:

(WebCore::Internals::openDummyInspectorFrontend): Remove compiler workaround

Source/WebKit: [Win] Remove dead code after conversion to VS2013
​https://bugs.webkit.org/show_bug.cgi?id=125795

Reviewed by Darin Adler.

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Remove unused function exports.

Source/WTF: [Win] Remove dead code after conversion to VS2013
​https://bugs.webkit.org/show_bug.cgi?id=125795

Reviewed by Darin Adler.

• wtf/Assertions.h: Include <inttypes.h> now that it exists.
• wtf/Compiler.h: Update compiler checks for VS2013, and

enable support for NEVER_INLINE

• wtf/HashFunctions.h:

(WTF::PtrHash::hash): Remove compiler workaround.

• wtf/MathExtras.h: Remove C99 functions that are now supplied

by the MS runtime library.

• wtf/Platform.h: Remove old MSVC support flags.
• wtf/StdLibExtras.h: Remove old MSVC workaround code.

4:01 PM Changeset in webkit [160670] by oliver@apple.com

• 7 edits
  18 adds in trunk

Cache getters and custom accessors on the prototype chain
​https://bugs.webkit.org/show_bug.cgi?id=125602

Reviewed by Michael Saboff.

Source/JavaScriptCore:

Support caching of custom getters and accessors on the prototype chain.
This is relatively trivial and just requires a little work compared to
the direct access mode as we're under more register pressure.

• bytecode/StructureStubInfo.h: Removed the unsued initGetByIdProto as it was confusing to still have it present.
• jit/Repatch.cpp:

(JSC::generateProtoChainAccessStub):
(JSC::tryCacheGetByID):
(JSC::tryBuildGetByIDList):

Tools:

Make sure bencher scripts also make noInline exist

• Scripts/bencher:

LayoutTests:

Added a bunch of new tests

• js/regress/chain-custom-getter-expected.txt: Added.
• js/regress/chain-custom-getter.html: Added.
• js/regress/chain-getter-access-expected.txt: Added.
• js/regress/chain-getter-access.html: Added.
• js/regress/proto-custom-getter-expected.txt: Added.
• js/regress/proto-custom-getter.html: Added.
• js/regress/proto-getter-access-expected.txt: Added.
• js/regress/proto-getter-access.html: Added.
• js/regress/resources/regress-pre.js: Made sure that noInline always exists (either using testRunner.neverInlineFunction or a no-op function if nothing else is available)
• js/regress/script-tests/chain-custom-getter.js: Added.

(foo):

• js/regress/script-tests/chain-getter-access.js: Added.

(o.get value):
(foo):

• js/regress/script-tests/proto-custom-getter.js: Added.

(foo):

• js/regress/script-tests/proto-getter-access.js: Added.

(o.get value):
(foo):

• js/regress/script-tests/simple-custom-getter.js: Added.

(cycles.30000.numberObject.Number.foo):

• js/regress/script-tests/simple-getter-access.js: Added.

(o.get value):
(foo):

• js/regress/simple-custom-getter-expected.txt: Added.
• js/regress/simple-custom-getter.html: Added.
• js/regress/simple-getter-access-expected.txt: Added.
• js/regress/simple-getter-access.html: Added.

3:54 PM Changeset in webkit [160669] by dbates@webkit.org

• 10 edits in trunk/Source/WebCore

[iOS] Upstream WebCore/history changes
​https://bugs.webkit.org/show_bug.cgi?id=125769

Reviewed by Darin Adler.

• history/BackForwardClient.h:
• history/BackForwardList.cpp:

(WebCore::BackForwardList::current): Added; guard by PLATFORM(IOS). Also added FIXME comment.
(WebCore::BackForwardList::setCurrent): Added; guard by PLATFORM(IOS). Also added FIXME comment.
(WebCore::BackForwardList::clearAllPageCaches): Added; guarded by PLATFORM(IOS).

• history/BackForwardList.h:
• history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore): Added iOS-specific code.
(WebCore::CachedFrame::CachedFrame): Ditto.

• history/CachedPage.cpp:

(WebCore::CachedPage::restore): Ditto.

• history/HistoryItem.cpp:

(WebCore::HistoryItem::HistoryItem): Ditto.

• history/HistoryItem.h:

(WebCore::HistoryItem::scale): Added; guarded by PLATFORM(IOS).
(WebCore::HistoryItem::scaleIsInitial): Added; guarded by PLATFORM(IOS).
(WebCore::HistoryItem::setScale): Added; guarded by PLATFORM(IOS).
(WebCore::HistoryItem::viewportArguments): Added; guarded by PLATFORM(IOS).
(WebCore::HistoryItem::setViewportArguments): Added; guarded by PLATFORM(IOS).
(WebCore::HistoryItem::bookmarkID): Added; guarded by PLATFORM(IOS).
(WebCore::HistoryItem::setBookmarkID): Added; guarded by PLATFORM(IOS).
(WebCore::HistoryItem::sharedLinkUniqueIdentifier): Added; guarded by PLATFORM(IOS).
(WebCore::HistoryItem::setSharedLinkUniqueIdentifier): Added; guarded by PLATFORM(IOS).

• history/PageCache.cpp:

(WebCore::logCanCacheFrameDecision): Added iOS-specific code.
(WebCore::logCanCachePageDecision): Ditto.
(WebCore::PageCache::canCachePageContainingThisFrame): Ditto.
(WebCore::PageCache::canCache): Ditto.
(WebCore::PageCache::pruneToCapacityNow): Added.

• history/PageCache.h:

3:25 PM Changeset in webkit [160668] by dbates@webkit.org

• 4 edits in trunk/Source/WebCore

[iOS] Upstream WebCore/svg changes
​https://bugs.webkit.org/show_bug.cgi?id=125784

Reviewed by Darin Adler.

• svg/SVGAElement.cpp:

(WebCore::SVGAElement::willRespondToMouseClickEvents): Added.

• svg/SVGAElement.h:
• svg/SVGElement.cpp:

(WebCore::SVGElement::parseAttribute): Added attribute listeners for touch{cancel, end, move, start},
and gesture{change, end, start}.

3:23 PM Changeset in webkit [160667] by beidson@apple.com

• 15 edits
  2 copies
  1 add in trunk/Source/WebKit2

DatabaseProcess: Implement openTransaction()
​https://bugs.webkit.org/show_bug.cgi?id=125794

Reviewed by Darin Adler.

This patch hooks up all of the necessary infrastructure to open a uniquely
identified transaction in the DatabaseProcess backing store.

The transaction itself is not yet functional.

Add openTransaction messaging to the WebProcess side:

• WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::isClosed):
(WebKit::WebIDBServerConnection::getOrEstablishIDBDatabaseMetadata):
(WebKit::WebIDBServerConnection::didGetOrEstablishIDBDatabaseMetadata):
(WebKit::WebIDBServerConnection::openTransaction):
(WebKit::WebIDBServerConnection::didOpenTransaction):
(WebKit::WebIDBServerConnection::deleteObjectStore):

• WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
• WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in:

Add openTransaction messaging to the DatabaseProcess side:

• DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

(WebKit::DatabaseProcessIDBConnection::openTransaction):

• DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
• DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:

Add a hashable identifier that represents a connection/transactionID pair:

• DatabaseProcess/IndexedDB/IDBTransactionIdentifier.h: Added.

(WebKit::IDBTransactionIdentifier::IDBTransactionIdentifier):
(WebKit::IDBTransactionIdentifier::isolatedCopy):
(WebKit::IDBTransactionIdentifier::isEmpty):
(WebKit::IDBTransactionIdentifier::hash):
(WebKit::IDBTransactionIdentifier::operator==):
(WebKit::IDBTransactionIdentifier::isHashTableDeletedValue):
(WebKit::IDBTransactionIdentifierHash::hash):
(WebKit::IDBTransactionIdentifierHash::equal):
(WebKit::IDBTransactionIdentifierHashTraits::isEmptyValue):

Allow that identifier to be cross-thread copied:

• Shared/WebCrossThreadCopier.cpp:

(WebCore::::copy):

• Shared/WebCrossThreadCopier.h:

Ask the backing store to open this uniquely identified transaction:

• DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::openTransaction):
(WebKit::UniqueIDBDatabase::openBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::didOpenBackingStoreTransaction):

• DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:

Add the backing store implementation for opening a transaction:

• DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
• DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::~UniqueIDBDatabaseBackingStoreSQLite):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::establishTransaction):

• DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:

Object to represent the backing store transaction itself, to be used in future patches:

• DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.cpp:

(WebKit::SQLiteIDBTransaction::SQLiteIDBTransaction):

• DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.h:

(WebKit::SQLiteIDBTransaction::create):
(WebKit::SQLiteIDBTransaction::identifier):

• WebKit2.xcodeproj/project.pbxproj:

2:59 PM Changeset in webkit [160666] by mark.lam@apple.com

• 4 edits in branches/jsCStack/Source

Merged r160665 from trunk.

2013-12-16 Mark Lam <​mark.lam@apple.com>

Change slow path result to take a void* instead of a ExecState*.
​https://bugs.webkit.org/show_bug.cgi?id=125802.

Reviewed by Filip Pizlo.

This is in preparation for C Stack OSR entry work that is coming soon.
In the OSR entry case, we'll be returning a topOfFrame pointer value
instead of the ExecState*.

• offlineasm/cloop.rb:
• runtime/CommonSlowPaths.h: (JSC::encodeResult): (JSC::decodeResult):

2:52 PM Changeset in webkit [160665] by mark.lam@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Change slow path result to take a void* instead of a ExecState*.
​https://bugs.webkit.org/show_bug.cgi?id=125802.

Reviewed by Filip Pizlo.

This is in preparation for C Stack OSR entry work that is coming soon.
In the OSR entry case, we'll be returning a topOfFrame pointer value
instead of the ExecState*.

• offlineasm/cloop.rb:
• runtime/CommonSlowPaths.h:

(JSC::encodeResult):
(JSC::decodeResult):

2:51 PM Changeset in webkit [160664] by andersca@apple.com

• 4 edits in trunk

Fix crash when trying to load a null HTML string
​https://bugs.webkit.org/show_bug.cgi?id=125801

Reviewed by Dan Bernstein.

Source/WebKit2:

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadString):
Check that the string is not null before calling is8Bit(). Also, Use the latin1 encoding for
8-bit strings, since Latin 1 strings are not necessarily valid UTF-8 strings.

Tools:

• TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:

(TestWebKitAPI::TEST_F):
Update test results.

2:41 PM Changeset in webkit [160663] by jpfau@apple.com

• 2 edits in trunk/Source/WebCore

[Mac] Cache partitioning asserts when associated NSURLRequest is nil
​https://bugs.webkit.org/show_bug.cgi?id=125716

Reviewed by Darin Adler.

• platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::doUpdateResourceRequest):

2:17 PM Changeset in webkit [160662] by mitz@apple.com

• 6 edits in trunk/Source/WebKit2

[Cocoa] Expose whether the page contains only secure content
​https://bugs.webkit.org/show_bug.cgi?id=125758

Reviewed by Anders Carlsson.

• UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController hasOnlySecureContent]): Added a getter that calls
PageLoadState::hasOnlySecureContent.

• UIProcess/API/Cocoa/WKBrowsingContextControllerPrivate.h: Declared new property.

• UIProcess/PageLoadState.cpp:

(WebKit::PageLoadState::commitChanges): Notify observers of hasOnlySecureContent() changes.
(WebKit::PageLoadState::reset): Reset hasInsecureContent in the uncommitted state.
(WebKit::PageLoadState::hasOnlySecureContent): Added. Returns true if there is no insecure
content and the URL is an HTTPS URL.
(WebKit::PageLoadState::didCommitLoad): Set hasInsecureContent to false in the uncommitted
state.
(WebKit::PageLoadState::didDisplayOrRunInsecureContent): Set hasInsecureContent to true in
the uncommitted state.

• UIProcess/PageLoadState.h:

(WebKit::PageLoadState::Data::Data): Added hasInsecureContent member.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didDisplayInsecureContentForFrame): Call
PageLoadState::didDisplayOrRunInsecureContent and commit the change before calling out to
the client.
(WebKit::WebPageProxy::didRunInsecureContentForFrame): Ditto.

2:07 PM Changeset in webkit [160661] by benjamin@webkit.org

• 3 edits
  2 adds
  1 delete in trunk/Source/WebKit2

[WK2] The NetworkProcess tries to load SecItemShim.dylib on iOS
​https://bugs.webkit.org/show_bug.cgi?id=125800

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-12-16
Reviewed by Dan Bernstein.

Give the NetworkService its own Info.plist configured without the Shim.

• Configurations/NetworkService.xcconfig:
• NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX.plist: Copied from Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info.plist.
• NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist: Renamed from Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info.plist.
• WebKit2.xcodeproj/project.pbxproj:

1:31 PM Changeset in webkit [160660] by msaboff@apple.com

• 7 edits in branches/jsCStack/Source/JavaScriptCore

CStack Branch: Eliminate topOfStack parameter from callToJavaScript() and callToNativeFunction()
​https://bugs.webkit.org/show_bug.cgi?id=125791

Reviewed by Geoffrey Garen.

Eliminated topOfStack from the callToJavaScript() and callToNativeFunction() calling chains.

• interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):

• jit/JITCode.cpp:

(JSC::JITCode::execute):

• jit/JITCode.h:
• jit/JITStubs.h:
• llint/LLIntThunks.h:
• llint/LowLevelInterpreter.asm:

1:26 PM Changeset in webkit [160659] by beidson@apple.com

• 4 edits in trunk/Source

DatabaseProcess: Fix a few bugs with opening an IDB connection
​https://bugs.webkit.org/show_bug.cgi?id=125798

Reviewed by Alexey Proskuryakov.

Source/WebCore:

• Modules/indexeddb/IDBDatabaseBackend.cpp:

(WebCore::IDBDatabaseBackend::processPendingCalls): As the comment says, we should only

early return when there *are* pending delete calls. The logic here was backwards,
preventing the backend from ever getting to processPendingOpenCalls().

Source/WebKit2:

Database metadata always needs a non-zero database identifier, unique at runtime.

• DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::generateDatabaseId):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getOrEstablishMetadata):

1:23 PM Changeset in webkit [160658] by msaboff@apple.com

• 2 edits in branches/jsCStack/Source/JavaScriptCore

CStack Branch: REGRESSION(r160600) ASSERT failure in Heap::collect()
​https://bugs.webkit.org/show_bug.cgi?id=125789

Reviewed by Geoffrey Garen.

Restored the shouldCollect() check so we don't collect on start up.
Eliminated the Options::disableGC() check since it is part of the
isDeferred() check.

• heap/Heap.cpp:

(JSC::Heap::collectIfNecessaryOrDefer):

12:47 PM Changeset in webkit [160657] by andersca@apple.com

• 4 edits
  1 add in trunk/Source/WebKit2

UserData should encode and decode API::Data objects
​https://bugs.webkit.org/show_bug.cgi?id=125799

Reviewed by Beth Dakin.

• Shared/APIData.cpp: Added.

(API::Data::encode):
(API::Data::decode):

• Shared/APIData.h:
• Shared/UserData.cpp:

(WebKit::UserData::encode):
(WebKit::UserData::decode):

• WebKit2.xcodeproj/project.pbxproj:

12:46 PM Changeset in webkit [160656] by mark.lam@apple.com

• 7 edits in branches/jsCStack/Source/JavaScriptCore

Fix exception handling for the baseline JIT.
​https://bugs.webkit.org/show_bug.cgi?id=125736.

Reviewed by Geoffrey Garen.

• interpreter/Interpreter.cpp:

(JSC::unwindCallFrame):
Removed some unneeded code.

1. Removed use of the oldCodeBlock variable which is only a copy of the codeBlock variable. There is no longer any reason to use a copy. Just use codeBlock directly instead.
2. There's no need to set VM::topCallFrame. The UnwindFunctor automatically updates the incoming callFrame pointer reference to the frame that should be catching / handling the exception, and that is adequate for what we need.

• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_catch):

• Restored sp.

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_catch):

• jit/ThunkGenerators.cpp:

(JSC::nativeForGenerator):
Fixed 2 issues:

1. After returning from a native / host function, the thunk did not pop the native / host frame before executing exception handling code. This resulted in the VM trying to "unwind" the native / host frame which is not possible, and crashes ensue.
2. After returning from a native / host function and discovering the need to handle an exception, the thunk was wrongly popping a non-existant return address off the stack. This caused the callerFrame pointer of the current frame to be popped off the stack, and havoc ensues.

• llint/LowLevelInterpreter32_64.asm:
• Updated to match exception handling code in LowLevelInterpreter64.asm.

• runtime/VM.h:
• Removed dead code.

12:44 PM Changeset in webkit [160655] by commit-queue@webkit.org

• 43 edits in trunk

Fixed Win64 build on VS2013.
​https://bugs.webkit.org/show_bug.cgi?id=125753

Patch by Alex Christensen <​achristensen@webkit.org> on 2013-12-16
Reviewed by Brent Fulgham.

Source/JavaScriptCore:

• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
• JavaScriptCore.vcxproj/JavaScriptCoreGenerated.vcxproj:
• JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.vcxproj:
• JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj:
• JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcxproj:
• JavaScriptCore.vcxproj/jsc/jsc.vcxproj:
• JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj:
• JavaScriptCore.vcxproj/testapi/testapi.vcxproj:

Added correct PlatformToolset for 64-bit builds.

Source/ThirdParty/ANGLE:

• ANGLE.vcxproj/libGLESv2.vcxproj:
• ANGLE.vcxproj/preprocessor.vcxproj:
• ANGLE.vcxproj/translator_common.vcxproj:
• ANGLE.vcxproj/translator_glsl.vcxproj:
• ANGLE.vcxproj/translator_hlsl.vcxproj:

Added correct PlatformToolset for 64-bit builds.

Source/WebCore:

• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCoreTestSupport.vcxproj:

Added correct PlatformToolset for 64-bit builds.

Source/WebInspectorUI:

• WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:

Added 64-bit configuration.

Source/WebKit:

• WebKit.vcxproj/WebKit.sln:

Use new 64-bit WebInspectorUI configurations.

• WebKit.vcxproj/Interfaces/Interfaces.vcxproj:
• WebKit.vcxproj/WebKit/WebKit.vcxproj:
• WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj:
• WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj:

Added correct PlatformToolset for 64-bit builds.

Source/WTF:

• WTF.vcxproj/WTF.vcxproj:

Added correct PlatformToolset for 64-bit builds.

Tools:

• DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
• DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
• DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
• DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
• DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
• TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
• WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
• WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
• win/record-memory/record-memory.vcxproj:

Added correct PlatformToolset for 64-bit builds.

12:41 PM Changeset in webkit [160654] by Simon Fraser

• 4 edits in trunk/Tools

Add a menu option to MiniBrowser to enable UI-side compositing
​https://bugs.webkit.org/show_bug.cgi?id=125793

Reviewed by Anders Carlsson.

Make it possible to test UI-side compositing in MiniBrowser WK2 windows.

• MiniBrowser/mac/BrowserWindowController.h: Add optional protocol method

to toggle UI-side compositing.

• MiniBrowser/mac/MainMenu.xib: Add menu item to Debug menu.
• MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController validateMenuItem:]):
(-[WK2BrowserWindowController isUISideCompositingEnabled]):
(-[WK2BrowserWindowController toggleUISideCompositing:]):
(-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
Adjust the window title to indicate whether the window is using UI-side compositing.

12:21 PM Changeset in webkit [160653] by andersca@apple.com

• 31 edits
  1 move in trunk/Source/WebKit2

Rename WebData to API::Data
​https://bugs.webkit.org/show_bug.cgi?id=125797

Reviewed by Beth Dakin.

• Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(-[WKRemoteObjectEncoder encodeBytes:length:forKey:]):
(-[WKRemoteObjectDecoder decodeBytesForKey:returnedLength:]):

• Shared/API/c/WKData.cpp:

(WKDataGetTypeID):
(WKDataCreate):

• Shared/API/c/WKSharedAPICast.h:
• Shared/API/c/mac/WKWebArchive.cpp:

(WKWebArchiveCopyData):

• Shared/API/c/mac/WKWebArchiveResource.cpp:

(WKWebArchiveResourceCopyData):

• Shared/APIData.h: Renamed from Source/WebKit2/Shared/WebData.h.

(API::Data::createWithoutCopying):
(API::Data::create):
(API::Data::~Data):
(API::Data::bytes):
(API::Data::size):
(API::Data::dataReference):
(API::Data::Data):
(API::Data::fastFreeBytes):

• Shared/Cocoa/WKNSData.h:

(WebKit::wrapper):

• Shared/Cocoa/WKNSData.mm:

(-[WKNSData dealloc]):

• Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):

• Shared/WebArchive.cpp:

(WebKit::WebArchive::create):
(WebKit::WebArchive::WebArchive):
(WebKit::WebArchive::data):

• Shared/WebArchive.h:
• Shared/WebArchiveResource.cpp:

(WebKit::WebArchiveResource::create):
(WebKit::WebArchiveResource::WebArchiveResource):
(WebKit::WebArchiveResource::data):

• Shared/WebArchiveResource.h:
• UIProcess/API/C/WKPage.cpp:
• UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:userData:]):

• UIProcess/API/mac/WKPrintingView.mm:

(pageDidDrawToPDF):

• UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::createData):
(WebKit::DownloadProxy::didFail):
(WebKit::DownloadProxy::didCancel):

• UIProcess/Downloads/DownloadProxy.h:

(WebKit::DownloadProxy::resumeData):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadData):
(WebKit::WebPageProxy::loadWebArchiveData):
(WebKit::WebPageProxy::dataCallback):
(WebKit::WebPageProxy::saveDataToFileInDownloadsFolder):
(WebKit::WebPageProxy::savePDFToFileInDownloadsFolder):

• UIProcess/WebPageProxy.h:
• UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::saveDataToFileInDownloadsFolder):

• UIProcess/WebUIClient.h:
• UIProcess/cf/WebPageProxyCF.cpp:

(WebKit::WebPageProxy::sessionStateData):
(WebKit::WebPageProxy::restoreFromSessionStateData):

• WebKit2.xcodeproj/project.pbxproj:
• WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleCreateWKDataFromUInt8Array):

• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::createWebDataFromUint8Array):

• WebProcess/InjectedBundle/InjectedBundle.h:
• WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:

(WebKit::InjectedBundlePageEditorClient::getPasteboardDataForRange):

• WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::willLoadDataRequest):

• WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadDataImpl):

11:57 AM Changeset in webkit [160652] by Simon Fraser

• 8 edits in trunk/Source/WebCore

Package up some data about scrollability into a struct for use in the scrolling tree
​https://bugs.webkit.org/show_bug.cgi?id=125792

Reviewed by Beth Dakin.

Both scrolling state nodes and scrolling nodes share a set of parameters
relating to scrollability and rubberbanding, so package them into a struct
for re-use. Send the struct wholesale to the scrolling thread.

• page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollableAreaParameters::ScrollableAreaParameters): New struct.
(WebCore::ScrollableAreaParameters::operator==):

• page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode): Reordering.
(WebCore::ScrollingStateScrollingNode::setScrollOrigin): Moved.
(WebCore::ScrollingStateScrollingNode::setScrollableAreaParameters): Set the parameters all at once.
(WebCore::ScrollingStateScrollingNode::setRequestedScrollPosition):

• page/scrolling/ScrollingStateScrollingNode.h: Getters access the struct. Reorder member variables.
• page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::ScrollingTreeScrollingNode):
(WebCore::ScrollingTreeScrollingNode::updateBeforeChildren):

• page/scrolling/ScrollingTreeScrollingNode.h:

(WebCore::ScrollingTreeScrollingNode::scrollOrigin):
(WebCore::ScrollingTreeScrollingNode::horizontalScrollElasticity):
(WebCore::ScrollingTreeScrollingNode::verticalScrollElasticity):
(WebCore::ScrollingTreeScrollingNode::hasEnabledHorizontalScrollbar):
(WebCore::ScrollingTreeScrollingNode::hasEnabledVerticalScrollbar):
(WebCore::ScrollingTreeScrollingNode::canHaveScrollbars):

• page/scrolling/mac/ScrollingCoordinatorMac.h:
• page/scrolling/mac/ScrollingCoordinatorMac.mm: Removed setScrollParametersForNode().

(WebCore::ScrollingCoordinatorMac::frameViewLayoutUpdated): Set the params in this
function. Reordering.

11:23 AM Changeset in webkit [160651] by commit-queue@webkit.org

• 45 edits in trunk/Source/WebCore

CTTE: Convert more of SVG to use references
​https://bugs.webkit.org/show_bug.cgi?id=125762

Patch by Sam Weinig <​sam@webkit.org> on 2013-12-16
Reviewed by Darin Adler.

• rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::imageChanged):

• rendering/svg/RenderSVGResource.cpp:

(WebCore::removeFromCacheAndInvalidateDependencies):
(WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation):

• rendering/svg/RenderSVGResource.h:
• rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::removeClientFromCache):

• rendering/svg/RenderSVGResourceClipper.h:
• rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::markAllClientsForInvalidation):
(WebCore::RenderSVGResourceContainer::markAllClientLayersForInvalidation):
(WebCore::RenderSVGResourceContainer::markClientForInvalidation):
(WebCore::RenderSVGResourceContainer::removeClient):

• rendering/svg/RenderSVGResourceContainer.h:
• rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::removeClientFromCache):
(WebCore::RenderSVGResourceFilter::postApplyResource):
(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged):

• rendering/svg/RenderSVGResourceFilter.h:
• rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::RenderSVGResourceGradient::removeClientFromCache):

• rendering/svg/RenderSVGResourceGradient.h:
• rendering/svg/RenderSVGResourceMarker.cpp:

(WebCore::RenderSVGResourceMarker::removeClientFromCache):

• rendering/svg/RenderSVGResourceMarker.h:
• rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::removeClientFromCache):

• rendering/svg/RenderSVGResourceMasker.h:
• rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::removeClientFromCache):

• rendering/svg/RenderSVGResourcePattern.h:
• rendering/svg/RenderSVGResourceSolidColor.h:

(WebCore::RenderSVGResourceSolidColor::removeClientFromCache):

• rendering/svg/SVGRenderSupport.cpp:

(WebCore::invalidateResourcesOfChildren):

• rendering/svg/SVGResources.cpp:

(WebCore::SVGResources::removeClientFromCache):

• rendering/svg/SVGResources.h:
• rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::clientLayoutChanged):
(WebCore::SVGResourcesCache::clientStyleChanged):
(WebCore::SVGResourcesCache::clientWasAddedToTree):
(WebCore::SVGResourcesCache::clientWillBeRemovedFromTree):
(WebCore::SVGResourcesCache::clientDestroyed):

• svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::applyResultsToTarget):

• svg/SVGCircleElement.cpp:

(WebCore::SVGCircleElement::svgAttributeChanged):

• svg/SVGEllipseElement.cpp:

(WebCore::SVGEllipseElement::svgAttributeChanged):

• svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::notifyFinished):

• svg/SVGFELightElement.cpp:

(WebCore::SVGFELightElement::childrenChanged):

• svg/SVGFilterPrimitiveStandardAttributes.cpp:

(WebCore::invalidateFilterPrimitiveParent):

• svg/SVGFilterPrimitiveStandardAttributes.h:

(WebCore::SVGFilterPrimitiveStandardAttributes::invalidate):
(WebCore::SVGFilterPrimitiveStandardAttributes::primitiveAttributeChanged):

• svg/SVGForeignObjectElement.cpp:

(WebCore::SVGForeignObjectElement::svgAttributeChanged):

• svg/SVGGElement.cpp:

(WebCore::SVGGElement::svgAttributeChanged):

• svg/SVGGraphicsElement.cpp:

(WebCore::SVGGraphicsElement::svgAttributeChanged):

• svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::svgAttributeChanged):

• svg/SVGLineElement.cpp:

(WebCore::SVGLineElement::svgAttributeChanged):

• svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::invalidateMPathDependencies):
(WebCore::SVGPathElement::pathSegListChanged):

• svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::svgAttributeChanged):

• svg/SVGRectElement.cpp:

(WebCore::SVGRectElement::svgAttributeChanged):

• svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::svgAttributeChanged):
(WebCore::SVGSVGElement::setupInitialView):

• svg/SVGStopElement.cpp:

(WebCore::SVGStopElement::svgAttributeChanged):

• svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::svgAttributeChanged):

• svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::svgAttributeChanged):

• svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::svgAttributeChanged):

• svg/SVGTextPositioningElement.cpp:

(WebCore::SVGTextPositioningElement::svgAttributeChanged):

• svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::svgAttributeChanged):

11:08 AM Changeset in webkit [160650] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Unreviewed, rolling out r160645.
​http://trac.webkit.org/changeset/160645
​https://bugs.webkit.org/show_bug.cgi?id=125787

Change breaks test-webkitpy (Requested by bfulgham on
#webkit).

• Scripts/prepare-ChangeLog:

(get_selector_line_ranges_for_css):

10:17 AM Changeset in webkit [160649] by dfarler@apple.com

• 3 edits in trunk/Tools

[ASAN] WebKitLauncher: Include libasancrashreporter.dylib in DYLD_INSERT_LIBRARIES if it exists
​https://bugs.webkit.org/show_bug.cgi?id=124610

Reviewed by Mark Rowe.

• WebKitLauncher/WebKitNightlyEnabler.m:

(enableWebKitNightlyBehaviour):
Add libasancrashreporter.dylib to DYLD_INSERT_LIBRARIES.

• WebKitLauncher/main.m:

(main):
Include both libasancrashreporter and the nightly enabler to
the list of libraries to insert.

10:15 AM WebKitGTK/2.2.x edited by vjaquez@igalia.com

(diff)

10:10 AM Changeset in webkit [160648] by commit-queue@webkit.org

• 13 edits in trunk/Source

Delete RVCT related code parts.
​https://bugs.webkit.org/show_bug.cgi?id=125626

Patch by Peter Szanka <​h868064@stud.u-szeged.hu> on 2013-12-16
Reviewed by Darin Adler.

Source/JavaScriptCore:

• assembler/ARMAssembler.cpp:
• assembler/ARMAssembler.h:

(JSC::ARMAssembler::cacheFlush):

• assembler/MacroAssemblerARM.cpp:

(JSC::isVFPPresent):

• jit/JITStubsARM.h:
• jit/JITStubsARMv7.h:

Source/WebKit/blackberry:

• WebKitSupport/AboutData.cpp:

(BlackBerry::WebKit::configPage):

Source/WTF:

• wtf/Assertions.h:
• wtf/Compiler.h:
• wtf/FastMalloc.h:
• wtf/Platform.h:

10:04 AM Changeset in webkit [160647] by commit-queue@webkit.org

• 3 edits in trunk/Tools

Resolve inconsistant style warning caused by r160319.
​https://bugs.webkit.org/show_bug.cgi?id=125772

Patch by Gergo Balogh <​geryxyz@inf.u-szeged.hu> on 2013-12-16
Reviewed by Darin Adler.

• Scripts/webkitpy/style/checkers/cpp.py:

(check_for_extra_new_line_at_eof):

• Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTest.test_newline_at_eof):
(CppStyleTest.test_extra_newlines_at_eof):

10:01 AM Changeset in webkit [160646] by commit-queue@webkit.org

• 3 edits in trunk/Tools

Remove mock_drt.py: parse_options() - --test-shell and --pixel-tests=<path>
​https://bugs.webkit.org/show_bug.cgi?id=125780

Patch by Eva Balazsfalvi <​balazsfalvi.eva@stud.u-szeged.hu> on 2013-12-16
Reviewed by Darin Adler.

• Scripts/webkitpy/port/mock_drt.py:

(main):
(parse_options):
(MockDRT.write_test_output):

• Scripts/webkitpy/port/mock_drt_unittest.py:

(MockDRTTest.assertTest):
(MockDRTTest.test_reftest_mismatch):

9:58 AM Changeset in webkit [160645] by commit-queue@webkit.org

• 2 edits in trunk/Tools

prepare-Changelog treats CSS keyframes as mismatched parentheses.
​https://bugs.webkit.org/show_bug.cgi?id=125435

Patch by Gergo Balogh <​geryxyz@inf.u-szeged.hu> on 2013-12-16
Reviewed by Darin Adler.

• Scripts/prepare-ChangeLog:

(get_selector_line_ranges_for_css):

9:55 AM Changeset in webkit [160644] by hmuller@adobe.com

• 6 edits
  2 adds in trunk

[CSS Shapes] Add support for the computing the included intervals for a BoxShape
​https://bugs.webkit.org/show_bug.cgi?id=124605

Reviewed by Andreas Kling.

Source/WebCore:

Setting shape-inside to content-box now works.

Changed FloatRoundedRect::xInterceptsAtY() to include the bottom edge of
the rectangle and to check for the special cases where any or all of the
corner radii are empty.

Test: fast/shapes/shape-inside/shape-inside-content-box.html

• platform/graphics/FloatRoundedRect.cpp:

(WebCore::FloatRoundedRect::xInterceptsAtY):

• rendering/shapes/BoxShape.cpp:

(WebCore::BoxShape::getIncludedIntervals): Replaced the stub implementation with logic that's similar to getExcludedIntervals().

• rendering/shapes/ShapeInfo.cpp:

(WebCore::::computedShape): Removed a meaningless assert.

• rendering/shapes/ShapeInsideInfo.cpp:

(WebCore::ShapeInsideInfo::isEnabledFor):

LayoutTests:

Check that shape-inside:content-box works with and without border radii.

• fast/shapes/shape-inside/shape-inside-content-box-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-content-box.html: Added.

9:01 AM Changeset in webkit [160643] by Michał Pakuła vel Rutka

• 2 edits in trunk/Source/WebKit2

Fix build warning in files including DrawingAreaProxy.h
​https://bugs.webkit.org/show_bug.cgi?id=125778

Reviewed by Anders Carlsson.

Remove unused parameters from method declaration.

• UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::adjustTransientZoom):
(WebKit::DrawingAreaProxy::commitTransientZoom):

8:45 AM Changeset in webkit [160642] by commit-queue@webkit.org

• 2 edits in trunk/Websites/bugs.webkit.org

PrettyPatch.rb doesn't handle diffs where lines matching /^{--/ are missing properly
​https://bugs.webkit.org/show_bug.cgi?id=54928}

Patch by Dániel Bátyai <​Batyai.Daniel@stud.u-szeged.hu> on 2013-12-16
Reviewed by Adam Roben.

PrettyPatch will now check if the next line after /^{--- / matches /}+++ /, and if not,
then it's just a normal line

• PrettyPatch/PrettyPatch.rb:

8:18 AM Changeset in webkit [160641] by mario.prada@samsung.com

• 8 edits in trunk

[ATK] Expose accessibility objects for more WAI-ARIA roles
​https://bugs.webkit.org/show_bug.cgi?id=125596

Reviewed by Chris Fleizach.

Source/WebCore:

Exposed accessibility objects with the proper AtkRoles, some of
them to be provided by the next stable release of ATK.

• accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(atkRole):

Tools:

Add mappings to DRT & WKTR for the newly exposed roles.

• DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
• WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

LayoutTests:

Update test to update expectations.

• platform/gtk/accessibility/roles-exposed-expected.txt:
• platform/gtk/accessibility/roles-exposed.html:

8:04 AM Changeset in webkit [160640] by eric.carlson@apple.com

• 5 edits
  1 add in trunk

Fix QuickTime plug-in replacement scripting bugs
​https://bugs.webkit.org/show_bug.cgi?id=125717

Reviewed by Sam Weinig.

Source/WebCore:

No new tests, existing test updated.

• Modules/plugins/QuickTimePluginReplacement.js:

(Replacement): Change to "" to avoid "Empty character constant" warning when creating

Derived Sources.

(Replacement.prototype.createVideoElement): Handle qtsrc attribute. Remember base url.
(Replacement.prototype.setURL): Resolve urls relative to base.

LayoutTests:

• plugins/quicktime-plugin-replacement-expected.txt:
• plugins/quicktime-plugin-replacement.html: Update to test 'qtsrc' attribute, and to check

that relative urls are resolved correctly.

• plugins/resources/yellow.mov: Added.

8:00 AM Changeset in webkit [160639] by Darin Adler

• 2 edits in trunk/Source/WebCore

Catch callers who forget to use initializeStyle
​https://bugs.webkit.org/show_bug.cgi?id=125763

Reviewed by Andreas Kling.

A recent fix was because a caller used setStyle first rather than using
initializeStyle. This patch adds an assertion to catch cases where we do
that so we see the mistake right away instead of indirectly later.

• rendering/RenderElement.cpp:

(WebCore::RenderElement::initializeStyle): Simplified an assertion.
(WebCore::RenderElement::setStyle): Added an assertion that m_hasInitializedStyle
is true, with an exception for RenderView, which needs to be created before we
have the correct style computed for it (at least for now). Also broke out an
assertion that was using &&, since we would prefer to know which clause failed,
making separate assertions more useful than a combined assertion.

7:58 AM Changeset in webkit [160638] by mario.prada@samsung.com

• 8 edits in trunk

[ATK] Expose accessibility objects with ATK_ROLE_CHECK_MENU_ITEM
​https://bugs.webkit.org/show_bug.cgi?id=125594

Reviewed by Chris Fleizach.

Source/WebCore:

Exposed accessibility objects with checkmenuitem role with the
proper AtkRole, to be provided by the next stable release of ATK.

• accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(atkRole):

Tools:

Add mappings to DRT & WKTR for checkmenuitem role.

• DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
• WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

LayoutTests:

Update test to update expectations.

• platform/gtk/accessibility/roles-exposed-expected.txt:
• platform/gtk/accessibility/roles-exposed.html:

7:17 AM Changeset in webkit [160637] by mario.prada@samsung.com

• 9 edits in trunk

[ATK] Expose accessibility objects with ATK_ROLE_ARTICLE
​https://bugs.webkit.org/show_bug.cgi?id=125587

Reviewed by Chris Fleizach.

Source/WebCore:

Exposed accessibility objects with article role with the proper
AtkRole, to be provided by the next stable release of ATK.

• accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(atkRole):

Tools:

Add mappings to DRT & WKTR for article roles.

• DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
• WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

LayoutTests:

Update test to unskip article objects and update expectations.

• accessibility/aria-mappings-expected.txt:
• platform/gtk/accessibility/roles-exposed-expected.txt:
• platform/gtk/accessibility/roles-exposed.html:

7:08 AM Changeset in webkit [160636] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[FTL] Allow EFL to build FTL with the build-jsc script.
​https://bugs.webkit.org/show_bug.cgi?id=125774

Patch by Dániel Bátyai <Dániel Bátyai> on 2013-12-16
Reviewed by Zoltan Herczeg.

• Scripts/build-jsc:

6:56 AM Changeset in webkit [160635] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit2

Unreviewed. Fix GTK+ build after r160549.

• GNUmakefile.am: Fix the include paths to make sure we include

the WebKit2 config.h file when building libWebKit2Platform.

5:19 AM Changeset in webkit [160634] by k.czech@samsung.com

• 2 edits in trunk/Tools

Add myself as a committer

Unreviewed.

• Scripts/webkitpy/common/config/contributors.json:

4:08 AM Changeset in webkit [160633] by svillar@igalia.com

• 6 edits in trunk

[CSS Grid Layout] Fix the preferred logical widths code to work with spanning grid items
​https://bugs.webkit.org/show_bug.cgi?id=123994

Reviewed by Andreas Kling.

From Blink r159189 by <​jchaffraix@chromium.org>

Source/WebCore:

There was no definition in the specs for the intrinsic / preferred
logical widths on the grid element. The following was proposed to
the WG and later accepted:

• The sum of the grid tracks' UsedBreadth is the minimum logical width
• The sum of the grid tracks' MaxBreadth is the maximum logical width

​http://lists.w3.org/Archives/Public/www-style/2013Oct/0054.html
for more information.

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
(WebCore::RenderGrid::computedUsedBreadthOfGridTracks):
(WebCore::RenderGrid::minContentForChild):
(WebCore::RenderGrid::maxContentForChild):

• rendering/RenderGrid.h:

LayoutTests:

Extended the test case to include spanning grid items.

• fast/css-grid-layout/grid-preferred-logical-widths-expected.txt:
• fast/css-grid-layout/grid-preferred-logical-widths.html:

3:15 AM Changeset in webkit [160632] by svillar@igalia.com

• 7 edits in trunk/Source/WebKit2

[GTK] can't build from trunk: WebKitCookieManager: 'WebString' was not declared in this scope
​https://bugs.webkit.org/show_bug.cgi?id=125759

Reviewed by Carlos Garcia Campos.

Renamed WebString to API::String after r160608.

• UIProcess/API/gtk/WebKitCookieManager.cpp:

(webkitCookieManagerGetDomainsWithCookiesCallback):

• UIProcess/API/gtk/WebKitFileChooserRequest.cpp:

(webkit_file_chooser_request_get_mime_types):
(webkit_file_chooser_request_get_mime_types_filter):
(webkit_file_chooser_request_get_selected_files):

• UIProcess/API/gtk/WebKitFormSubmissionRequest.cpp:

(webkit_form_submission_request_get_text_fields):

• UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_set_web_extensions_directory):
(webkit_web_context_prefetch_dns):

• UIProcess/API/gtk/WebKitWebViewGroup.cpp:

(toAPIArray):

• WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:

(webkitWebExtensionDidReceiveMessage):

Dec 15, 2013:

10:53 PM Changeset in webkit [160631] by commit-queue@webkit.org

• 4 edits
  2 adds in trunk

Add support for maction@toggle
​https://bugs.webkit.org/show_bug.cgi?id=120059

Patch by Frédéric Wang <​fred.wang@free.fr> on 2013-12-15
Reviewed by Chris Fleizach.

Source/WebCore:

Test: mathml/presentation/maction-toggle.html

• mathml/MathMLSelectElement.cpp:

(WebCore::MathMLSelectElement::getSelectedChildAndIndex):
(WebCore::MathMLSelectElement::updateSelectedChild):
(WebCore::MathMLSelectElement::defaultEventHandler):
(WebCore::MathMLSelectElement::willRespondToMouseClickEvents):
(WebCore::MathMLSelectElement::toggle):

• mathml/MathMLSelectElement.h:

LayoutTests:

• mathml/presentation/maction-toggle-expected.html: Added.
• mathml/presentation/maction-toggle.html: Added.

10:39 PM Changeset in webkit [160630] by timothy_horton@apple.com

• 3 edits in trunk/Source/WebKit2

WebKit2 View Gestures: Can't pinch in past the maximum scale
​https://bugs.webkit.org/show_bug.cgi?id=125749

Reviewed by Anders Carlsson.

Pinching in past the maximum scale should result in the zoom resisting, but continuing.

• UIProcess/mac/ViewGestureController.cpp:

(WebKit::resistanceForDelta):
Clean up the logic and apply resistance to pinching in past the maximum.

(WebKit::ViewGestureController::handleMagnificationGesture):
(WebKit::ViewGestureController::endMagnificationGesture):

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::commitTransientZoom):

10:34 PM Changeset in webkit [160629] by Darin Adler

• 2 edits in trunk/Source/WebCore

More nullptr in RenderElement
​https://bugs.webkit.org/show_bug.cgi?id=125764

Reviewed by Andreas Kling.

• rendering/RenderElement.cpp:

(WebCore::RenderElement::uncachedFirstLineStyle):
(WebCore::RenderElement::updateShapeImage):
(WebCore::RenderElement::destroyLeftoverChildren):
(WebCore::RenderElement::findNextLayer):
Use nullptr in a few more places.

9:56 PM Changeset in webkit [160628] by rniwa@webkit.org

• 20 edits
  17 adds
  1 delete in trunk

REGRESSION: 2x regression on Dromaeo DOM query tests
​https://bugs.webkit.org/show_bug.cgi?id=125377

Reviewed by Filip Pizlo.

PerformanceTests:

Added a micro-benchmark for updating a named property on document.

• Bindings/update-name-getter.html: Added.
• Skipped:

Source/JavaScriptCore:

The bug was caused by JSC not JIT'ing property access on "document" due to its type info having
HasImpureGetOwnPropertySlot flag.

Fixed the bug by new type info flag NewImpurePropertyFiresWatchpoints, which allows the baseline
JIT to generate byte code for access properties on an object with named properties (a.k.a.
custom name getter) in DOM. When a new named property appears on the object, VM is notified via
VM::addImpureProperty and fires StructureStubClearingWatchpoint added during the repatch.

• bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt): Take the slow path if we have any object with impure
properties in the prototype chain.
(JSC::GetByIdStatus::computeForChain): Ditto.

• jit/Repatch.cpp:

(JSC::repatchByIdSelfAccess): Throw away the byte code when a new impure property is added on any
object in the prototype chain via StructureStubClearingWatchpoint.
(JSC::generateProtoChainAccessStub): Ditto.
(JSC::tryCacheGetByID):
(JSC::tryBuildGetByIDList):
(JSC::tryRepatchIn): Ditto.

• runtime/JSTypeInfo.h: Added NewImpurePropertyFiresWatchpoints.

(JSC::TypeInfo::newImpurePropertyFiresWatchpoints): Added.

• runtime/Operations.h:

(JSC::normalizePrototypeChainForChainAccess): Don't exit early if VM will be notified of new
impure property even if the object had impure properties.

• runtime/Structure.h:

(JSC::Structure::takesSlowPathInDFGForImpureProperty): Added. Wraps hasImpureGetOwnPropertySlot and
asserts that newImpurePropertyFiresWatchpoints is true whenever hasImpureGetOwnPropertySlot is true.

• runtime/VM.cpp:

(JSC::VM::registerWatchpointForImpureProperty): Added.
(JSC::VM::addImpureProperty): Added. HTMLDocument calls it to notify JSC of a new impure property.

• runtime/VM.h:

Source/WebCore:

The bug was caused by JSC not JIT'ing property accesses on document because of its having
custom named getter (named properties). This resulted in resolution of methods on document
such as getElementById to happen inside the interpreter.

Fixed the bug by using the new JSC type info flag which tells JSC to JIT property access on
document, and then notifying JSC whenever a new named property appeared on document.

Tests: js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-2.html

js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-3.html
js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-4.html
js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-2.html
js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-3.html
js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-4.html

• bindings/js/JSDOMBinding.cpp:

(WebCore::addImpureProperty): Wraps VM::addImpureProperty.

• bindings/js/JSDOMBinding.h:
• bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader): Added the support for NewImpurePropertyFiresWatchpoints.

• bindings/scripts/IDLAttributes.txt: Ditto.
• html/HTMLDocument.cpp:

(WebCore::HTMLDocument::addDocumentNamedItem): Calls addImpureProperty.

• html/HTMLDocument.idl: Added NewImpurePropertyFiresWatchpoints.

LayoutTests:

Added more regression tests for throwing away byte code when a new named property appears.

• js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-expected: Rebaselined.
• js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps.html: Fixed the test to use dfgShouldBe.
• js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-2-expected.txt: Added.
• js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-2.html: Added.
• js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-3-expected.txt: Added.
• js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-3.html: Added.
• js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-4-expected.txt: Added.
• js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-4.html: Added.
• js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-5-expected.txt: Added.
• js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-5.html: Added.
• js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-2-expected.txt: Added.
• js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-2.html: Added.
• js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-3-expected.txt: Added.
• js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-3.html: Added.
• js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-4-expected.txt: Added.
• js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-4.html: Added.
• js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-5-expected.txt: Added.
• js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-5.html: Added.
• js/dom/script-tests/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps.js: Removed.

8:58 PM Changeset in webkit [160627] by commit-queue@webkit.org

• 5 edits
  2 adds in trunk/Tools

Refactor option handling in WebKitTestRunner.
​https://bugs.webkit.org/show_bug.cgi?id=123185

Patch by Tamas Gergely <​tgergely.u-szeged@partner.samsung.com> on 2013-12-15
Reviewed by Darin Adler.

Option handling is refactored (according to the FIXME) that allows
to automatically generate the help message.

• WebKitTestRunner/CMakeLists.txt:
• WebKitTestRunner/GNUmakefile.am:
• WebKitTestRunner/Options.cpp: Added.

(WTR::Options::Options):
(WTR::handleOptionTimeout):
(WTR::handleOptionNoTimeout):
(WTR::handleOptionNoTimeoutAtAll):
(WTR::handleOptionVerbose):
(WTR::handleOptionGcBetweenTests):
(WTR::handleOptionPixelTests):
(WTR::handleOptionPrintSupportedFeatures):
(WTR::handleOptionComplexText):
(WTR::handleOptionAcceleratedDrawing):
(WTR::handleOptionRemoteLayerTree):
(WTR::handleOptionUnmatched):
(WTR::OptionsHandler::OptionsHandler):
(WTR::Option::Option):
(WTR::Option::matches):
(WTR::OptionsHandler::parse):
(WTR::OptionsHandler::printHelp):

• WebKitTestRunner/Options.h: Added.
• WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

• WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

8:04 PM Changeset in webkit [160626] by mitz@apple.com

• 3 edits in trunk/Source/WebKit2

[Cocoa] Expose the certificate chain for the main frame
​https://bugs.webkit.org/show_bug.cgi?id=125760

Reviewed by Sam Weinig.

• UIProcess/API/Cocoa/WKBrowsingContextController.h: Declared certificateChain property.
• UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController certificateChain]): Added this getter, which calls through
to WebFrameProxy::certificateInfo.

7:28 PM Changeset in webkit [160625] by Brent Fulgham

• 2 edits in trunk/Source/WebCore

[WIn] Unreviewed build fix after r160599

• rendering/RenderMediaControls.cpp:

(WebCore::determineState): RenderObject::theme now returns
a reference.

6:28 PM Changeset in webkit [160624] by Brent Fulgham

• 3 edits
  2 deletes in trunk/Source

Source/WebCore: [Win] Unreviewed build fix

The build system continues to attempt to build QTMovieWin, even
though it is excluded from the build solution. I'm actually
removing the project files to prevent this.

• WebCore.vcxproj/QTMovieWin/QTMovieWin.vcxproj: Removed.
• WebCore.vcxproj/QTMovieWin/QTMovieWin.vcxproj.filters: Removed.

Source/WebKit: [Win] Unreviewed build fix.

• WebKit.vcxproj/WebKit.sln: Remove reference to QTMovieWin,

which we do not wish to build.

2:34 PM Changeset in webkit [160623] by rwlbuis@webkit.org

• 5 edits in trunk

[CSS Shapes] shape-outside animation does not handle 'auto' well
​https://bugs.webkit.org/show_bug.cgi?id=125700

Reviewed by Dirk Schulze.

Source/WebCore:

Handle the case where we are blending/animating with a null ShapeValue due to 'auto'.

Adapted LayoutTests/fast/shapes/shape-outside-floats/shape-outside-animation.html for testing this.

• page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):

LayoutTests:

Test a shape-outside animation where one keyframe uses 'auto'.

• fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt:
• fast/shapes/shape-outside-floats/shape-outside-animation.html:

1:13 PM Changeset in webkit [160622] by aestes@apple.com

• 57 edits in trunk/Source/WebKit/mac

[iOS] Upstream changes to WebKit Public and Private headers
​https://bugs.webkit.org/show_bug.cgi?id=125745

Reviewed by Dan Bernstein.

• Configurations/WebKit.xcconfig: Ignore headers that are completely

excluded on iOS. This prevents empty headers from being installed into
the iOS SDK.

• DOM/WebDOMOperationsPrivate.h: Upstream iOS changes.
• History/WebBackForwardListPrivate.h: Ditto.
• History/WebHistoryItem.h: Ditto.
• History/WebHistoryItemPrivate.h: Ditto.
• Misc/WebCache.h: Ditto.
• Misc/WebIconDatabase.h: Ditto.
• Misc/WebIconDatabasePrivate.h: Ditto.
• Misc/WebKitNSStringExtras.h: Ditto.
• Misc/WebLocalizableStrings.h: Ditto.
• Misc/WebNSEventExtras.h: Ditto.
• Misc/WebNSFileManagerExtras.h: Ditto.
• Misc/WebNSPasteboardExtras.h: Ditto.
• Misc/WebNSURLExtras.h: Ditto.
• Misc/WebNSViewExtras.h: Ditto.
• Misc/WebNSWindowExtras.h: Ditto.
• Panels/WebPanelAuthenticationHandler.h: Ditto.
• Plugins/WebPlugin.h: Ditto.
• Plugins/WebPluginContainer.h: Ditto.
• Plugins/WebPluginContainerPrivate.h: Ditto.
• Plugins/WebPluginDatabase.h: Ditto.
• Plugins/WebPluginPrivate.h: Ditto.
• Plugins/WebPluginViewFactory.h: Ditto.
• Plugins/WebPluginsPrivate.h: Ditto.
• Storage/WebDatabaseManagerPrivate.h: Ditto.
• WebCoreSupport/WebApplicationCache.h: Ditto.
• WebCoreSupport/WebJavaScriptTextInputPanel.h: Ditto.
• WebCoreSupport/WebKeyGenerator.h: Ditto.
• WebCoreSupport/WebSecurityOriginPrivate.h: Ditto.
• WebView/WebDashboardRegion.h: Ditto.
• WebView/WebDataSource.h: Ditto.
• WebView/WebDataSourcePrivate.h: Ditto.
• WebView/WebDocument.h: Ditto.
• WebView/WebDocumentPrivate.h: Ditto.
• WebView/WebDynamicScrollBarsView.h: Ditto.
• WebView/WebEditingDelegate.h: Ditto.
• WebView/WebEditingDelegatePrivate.h: Ditto.
• WebView/WebFormDelegate.h: Ditto.
• WebView/WebFrameLoadDelegate.h: Ditto.
• WebView/WebFramePrivate.h: Ditto.
• WebView/WebFrameView.h: Ditto.
• WebView/WebFrameViewPrivate.h: Ditto.
• WebView/WebHTMLRepresentation.h: Ditto.
• WebView/WebHTMLView.h: Ditto.
• WebView/WebHTMLViewPrivate.h: Ditto.
• WebView/WebPolicyDelegate.h: Ditto.
• WebView/WebPreferenceKeysPrivate.h: Ditto.
• WebView/WebPreferences.h: Ditto.
• WebView/WebPreferencesPrivate.h: Ditto.
• WebView/WebRenderLayer.h: Ditto.
• WebView/WebResourceLoadDelegatePrivate.h: Ditto.
• WebView/WebResourcePrivate.h: Ditto.
• WebView/WebUIDelegate.h: Ditto.
• WebView/WebUIDelegatePrivate.h: Ditto.
• WebView/WebView.h: Ditto.
• WebView/WebViewPrivate.h: Ditto.

1:08 PM Changeset in webkit [160621] by aestes@apple.com

• 8 edits in trunk/Source

[iOS] Upstream changes to FeatureDefines.xcconfig
​https://bugs.webkit.org/show_bug.cgi?id=125742

Reviewed by Dan Bernstein.

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

• Configurations/FeatureDefines.xcconfig:

10:27 AM Changeset in webkit [160620] by mitz@apple.com

• 3 edits in trunk/Tools

32-bit build fix.

• TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
• TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:

10:16 AM Changeset in webkit [160619] by mitz@apple.com

• 2 edits in trunk/Source/WebKit2

Build fix for 32-bit clients.

• UIProcess/API/Cocoa/WKBrowsingContextLoadDelegate.h:

8:40 AM Changeset in webkit [160618] by Darin Adler

• 4 edits
  2 adds in trunk

Crash in CSSImageGeneratorValue and RenderScrollbar
​https://bugs.webkit.org/show_bug.cgi?id=125702

Reviewed by Alexey Proskuryakov.

Source/WebCore:

This crash had two causes at two different levels. The crash fixes both.

At the RenderScrollbar level, we were setting up a new renderer, a
RenderScrollbarPart, and never calling initializeStyle. This meant that
we did not do proper style setup, which meant we did not end up calling
CSSImageGeneratorValue::addClient and so had a removeClient that was not
properly balanced by an addClient. This is the primary bug.

At the CSSImageGeneratorValue level, the addClient and removeClient
functions were not properly handling possibly-mismatched calls. It was
easy to fix the functions to work even if the calls are not perfectly
matched up, which makes the consequences of a missed addClient call
much less dire, no longer messing up reference counting. Fixing this
mitigates the risk if we made this same mistake elsewhere, although I
could not find any other places with some quick searches.

Test: fast/css/scrollbar-image-crash.html

• css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::addClient): Only call ref if this will
add the first client.
(WebCore::CSSImageGeneratorValue::removeClient): Only call deref if this
removes the last client. Also added an assertion that can fire if we call
removeClient without first calling addClient, which is illegal. However,
the function handles that case without over-deref'ing itself.

• rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::updateScrollbarPart): Simplify the logic for
needRenderer a bit. Use initializeStyle rather than setStyle when first
creating the RenderScrollbarPart. Also use add and take properly so we
don't do extra hash lookups the old code did with get/set and get/remove.

LayoutTests:

• fast/css/scrollbar-image-crash-expected.txt: Added.
• fast/css/scrollbar-image-crash.html: Added.

4:48 AM Changeset in webkit [160617] by Michał Pakuła vel Rutka

• 3 edits in trunk/Source/WebKit2

Unreviewed EFL build fix after r160608.

• UIProcess/WebGrammarDetail.cpp:

(WebKit::WebGrammarDetail::WebGrammarDetail):
(WebKit::WebGrammarDetail::guesses):

• UIProcess/WebTextCheckerClient.cpp:

(WebKit::WebTextCheckerClient::guessesForWord):