Timeline

Jan 6, 2014:

11:26 PM Changeset in webkit [161410] by mrowe@apple.com

• 2 edits in trunk/Source/WebCore

Mountain Lion build fix.

• bindings/objc/WebKitAvailability.h: #define AVAILABILITY_INTERNALMAC_TBD so that

the TBD version works on Mountain Lion. Newer OS versions use a slightly different set
of macros that already support this version. Add a missing #include so that defintions
of the Foundation availability macros can be found even if no other Foundation headers
were included first.

11:19 PM Changeset in webkit [161409] by fpizlo@apple.com

• 83 edits
  5 adds in branches/jsCStack

Source/JavaScriptCore: Merge trunk r161072, r161126, r161218, r161353, r161356, r161364, 161399.

Source/WTF: Merge trunk r161364.

LayoutTests: Merge trunk r161072.

11:11 PM Changeset in webkit [161408] by gyuyoung.kim@samsung.com

• 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r161401.
​http://trac.webkit.org/changeset/161401
​https://bugs.webkit.org/show_bug.cgi?id=126418

REGRESSION(r161401): Break layout test on mac-wk1(Debug)

• html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::tHead):
(WebCore::HTMLTableElement::tFoot):
(WebCore::HTMLTableElement::lastBody):

• html/HTMLTableRowElement.cpp:

(WebCore::HTMLTableRowElement::rowIndex):

• html/HTMLTableSectionElement.h:

10:09 PM Changeset in webkit [161407] by msaboff@apple.com

• 2 edits in branches/jsCStack/Source/JavaScriptCore

CStack Branch: ARM64 Crash in llint_function_for_call_arity_check running 3d-raytrace.js
​https://bugs.webkit.org/show_bug.cgi?id=126557

Reviewed by Geoffrey Garen.

We were crashing due the to definition of t5 in the offline assembler not
matching the definition of regT5 in GPRInfo.h. The crash was due to passing
the stub return address to the fixup thunk in regT5, but it contained garbage.
I changed the definitions of t4, t5 and t6 in the ARM64 back end of the offline
assembler to match GPRInfo.h.

• offlineasm/arm64.rb:

10:09 PM Changeset in webkit [161406] by mrowe@apple.com

• 45 edits in trunk/Source/WebCore

<​https://webkit.org/b/126500> Move Objective-C DOM bindings off the legacy WebKit availability macros

The legacy WebKit availability macros are verbose, confusing, and provide no benefit
over using the system availability macros directly. The original vision was that
they'd serve a cross-platform purpose but that never came to be.

The OS X version used in the new availability macros is based on the mapping in
JavaScriptCore/WebKitAvailability.h.

Part of <rdar://problem/15512304>.

Reviewed by Sam Weinig.

• bindings/objc/DOMCSS.h:
• bindings/objc/DOMEventException.h:
• bindings/objc/DOMException.h:
• bindings/objc/DOMExtensions.h:
• bindings/objc/DOMObject.h:
• bindings/objc/DOMRangeException.h:
• bindings/objc/DOMXPathException.h:
• bindings/objc/PublicDOMInterfaces.h:
• bindings/objc/WebScriptObject.h:
• bindings/scripts/CodeGeneratorObjC.pm:

(ReadPublicInterfaces):
(GenerateHeader): Tag enums with WK_ENUM_AVAILABLE_MAC and classes with WEBKIT_CLASS_AVAILABLE_MAC.
Remove the #ifs that we were previously generating now that enums are appropriately tagged.

• bindings/scripts/test/ObjC/DOMTestActiveDOMObject.h:
• bindings/scripts/test/ObjC/DOMTestActiveDOMObjectInternal.h:
• bindings/scripts/test/ObjC/DOMTestCallback.h:
• bindings/scripts/test/ObjC/DOMTestCallbackInternal.h:
• bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.h:
• bindings/scripts/test/ObjC/DOMTestCustomNamedGetterInternal.h:
• bindings/scripts/test/ObjC/DOMTestEventConstructor.h:
• bindings/scripts/test/ObjC/DOMTestEventConstructorInternal.h:
• bindings/scripts/test/ObjC/DOMTestEventTarget.h:
• bindings/scripts/test/ObjC/DOMTestEventTargetInternal.h:
• bindings/scripts/test/ObjC/DOMTestException.h:
• bindings/scripts/test/ObjC/DOMTestExceptionInternal.h:
• bindings/scripts/test/ObjC/DOMTestGenerateIsReachable.h:
• bindings/scripts/test/ObjC/DOMTestGenerateIsReachableInternal.h:
• bindings/scripts/test/ObjC/DOMTestInterface.h:
• bindings/scripts/test/ObjC/DOMTestInterfaceInternal.h:
• bindings/scripts/test/ObjC/DOMTestMediaQueryListListener.h:
• bindings/scripts/test/ObjC/DOMTestMediaQueryListListenerInternal.h:
• bindings/scripts/test/ObjC/DOMTestNamedConstructor.h:
• bindings/scripts/test/ObjC/DOMTestNamedConstructorInternal.h:
• bindings/scripts/test/ObjC/DOMTestNode.h:
• bindings/scripts/test/ObjC/DOMTestNodeInternal.h:
• bindings/scripts/test/ObjC/DOMTestObj.h:
• bindings/scripts/test/ObjC/DOMTestObjInternal.h:
• bindings/scripts/test/ObjC/DOMTestOverloadedConstructors.h:
• bindings/scripts/test/ObjC/DOMTestOverloadedConstructorsInternal.h:
• bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
• bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterfaceInternal.h:
• bindings/scripts/test/ObjC/DOMTestTypedefs.h:
• bindings/scripts/test/ObjC/DOMTestTypedefsInternal.h:
• bindings/scripts/test/ObjC/DOMattribute.h:
• bindings/scripts/test/ObjC/DOMattributeInternal.h:
• bindings/scripts/test/ObjC/DOMreadonly.h:
• bindings/scripts/test/ObjC/DOMreadonlyInternal.h:

10:07 PM Changeset in webkit [161405] by msaboff@apple.com

• 2 edits in branches/jsCStack/Source/JavaScriptCore

CStack Branch: Fix nativeForGenerator() for non-X86 platforms
​https://bugs.webkit.org/show_bug.cgi?id=126551

Reviewed by Geoffrey Garen.

Removed the explicit saving and restoring of the return address and call frame register
from the non-X86 paths of nativeForGenerator() as these are no longer needed.
The function prologue and epilogue now perform calling convention consistent saving
and restoring of these values.

• jit/ThunkGenerators.cpp:

(JSC::nativeForGenerator):

9:40 PM Changeset in webkit [161404] by rniwa@webkit.org

• 4 edits
  2 adds in trunk

REGRESSION(r157851): trailing space inside an editable region could be erroneously collapsed
​https://bugs.webkit.org/show_bug.cgi?id=126549

Reviewed by Sam Weinig.

Source/WebCore:

The regression was caused by erroneous use of m_currentCharacterIsSpace in place of m_currentCharacterIsWS.

See the following two lines before the refactoring:
​http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp?rev=157850#L3074
​http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp?rev=157850#L3198

I've also cross-checked other places where m_currentCharacterIsSpace and m_currentCharacterIsWS are used.

Test: editing/inserting/inserting-trailing-space-and-letter.html

• rendering/line/BreakingContextInlineHeaders.h:

(WebCore::BreakingContext::handleText):

LayoutTests:

Added a regression test and reverted the erroneous rebaseline in r157851.

• editing/inserting/inserting-trailing-space-and-letter-expected.html: Added.
• editing/inserting/inserting-trailing-space-and-letter.html: Added.
• platform/mac/editing/selection/after-line-wrap-expected.txt:

9:24 PM Changeset in webkit [161403] by fpizlo@apple.com

• 39 edits
  2 adds in branches/jsCStack

PerformanceTests/SunSpider: Merge trunk r160411.

Source/JavaScriptCore: Merge trunk r160394, r160407, r160411, r160587.

Tools: Merge trunk r160411.

9:19 PM Changeset in webkit [161402] by Seokju Kwon

• 14 edits in trunk/Source

Web Inspector: Remove canOverrideDeviceMetrics and setDeviceMetricsOverride from protocol
​https://bugs.webkit.org/show_bug.cgi?id=126149

Reviewed by Joseph Pecoraro.

Source/WebCore:

No new tests, No changes in behavior.

These are not used anywhere in WebInspectorUI.
So, it removes unused Protocols and APIs.

• inspector/InspectorClient.h:
• inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::disable):

• inspector/InspectorPageAgent.h:
• inspector/protocol/Page.json:

Source/WebInspectorUI:

• UserInterface/InspectorWebBackendCommands.js: Remove unused codes.
• UserInterface/Legacy/6.0/InspectorWebBackendCommands.js: Ditto.
• UserInterface/Legacy/7.0/InspectorWebBackendCommands.js: Ditto.
• Versions/Inspector-iOS-6.0.json: Ditto.
• Versions/Inspector-iOS-7.0.json: Ditto.

Source/WebKit/blackberry:

• WebCoreSupport/InspectorClientBlackBerry.cpp: Remove dead codes.
• WebCoreSupport/InspectorClientBlackBerry.h: Ditto.

9:15 PM Changeset in webkit [161401] by gyuyoung.kim@samsung.com

• 4 edits in trunk/Source/WebCore

Add toHTMLTableSectionElement() functions, and use it
​https://bugs.webkit.org/show_bug.cgi?id=126418

Reviewed by Anders Carlsson.

HTMLTableSectionElement covers tbody, tfoot, and thead tags. So, we can't
generate isHTMLTableSectionElement() by using template. This patch add
toHTMLTableSectionElement() manually in order to cleanup static_cast<>.

No new tests, no behavior change.

• html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::tHead):
(WebCore::HTMLTableElement::tFoot):
(WebCore::HTMLTableElement::lastBody):

• html/HTMLTableRowElement.cpp:

(WebCore::HTMLTableRowElement::rowIndex):

• html/HTMLTableSectionElement.h:
• html/HTMLTagNames.in:

8:58 PM Changeset in webkit [161400] by msaboff@apple.com

• 7 edits in branches/jsCStack/Source/JavaScriptCore

Merge of trunk r160493

2013-12-11 Filip Pizlo <​fpizlo@apple.com>

ARM64: Hang running pdfjs test, suspect DFG generated code for "in"
​https://bugs.webkit.org/show_bug.cgi?id=124727
<rdar://problem/15566923>

Reviewed by Michael Saboff.

Get rid of In's hackish use of StructureStubInfo. Previously it was using hotPathBegin,
and it was the only IC that used that field, which was wasteful. Moreover, it used it
to store two separate locations: the label for patching the jump and the label right
after the jump. The code was relying on those two being the same label, which is true
on X86 and some other platforms, but it isn't true on ARM64.

This gets rid of hotPathBegin and makes In express those two locations as offsets from
the callReturnLocation, which is analogous to what the other IC's do.

This fixes a bug where any successful In patching would result in a trivially infinite
loop - and hence a hang - on ARM64.

• bytecode/StructureStubInfo.h:
• dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::link):
• dfg/DFGJITCompiler.h: (JSC::DFG::InRecord::InRecord):
• dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileIn):
• jit/JITInlineCacheGenerator.cpp: (JSC::JITByIdGenerator::finalize):
• jit/Repatch.cpp: (JSC::replaceWithJump): (JSC::patchJumpToGetByIdStub): (JSC::tryCachePutByID): (JSC::tryBuildPutByIdList): (JSC::tryRepatchIn): (JSC::resetGetByID): (JSC::resetPutByID): (JSC::resetIn):

8:52 PM Changeset in webkit [161399] by fpizlo@apple.com

• 16 edits
  2 adds in trunk/Source/JavaScriptCore

Make the different flavors of integer arithmetic more explicit, and don't rely on (possibly stale) results of the backwards propagator to decide integer arithmetic semantics
​https://bugs.webkit.org/show_bug.cgi?id=125519

Reviewed by Geoffrey Garen.

Adds the Arith::Mode enum to arithmetic nodes, which makes it explicit what sorts of
checks and overflows the node should do. Previously this would be deduced from
backwards analysis results.

This also makes "unchecked" variants really mean that you want the int32 wrapped
result, so ArithIMul is now done in terms of ArithMul(Unchecked). That means that the
constant folder needs to compute exactly the result implied by ArithMode, instead of
just folding the double result.

• CMakeLists.txt:
• GNUmakefile.list.am:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
• JavaScriptCore.xcodeproj/project.pbxproj:
• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGArithMode.cpp: Added.

(WTF::printInternal):

• dfg/DFGArithMode.h: Added.

(JSC::DFG::doesOverflow):
(JSC::DFG::shouldCheckOverflow):
(JSC::DFG::shouldCheckNegativeZero):

• dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::performNodeCSE):

• dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::attemptToMakeIntegerAdd):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

• dfg/DFGNode.h:

(JSC::DFG::Node::Node):
(JSC::DFG::Node::hasArithMode):
(JSC::DFG::Node::arithMode):
(JSC::DFG::Node::setArithMode):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::compileDoubleAsInt32):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileArithNegate):
(JSC::DFG::SpeculativeJIT::compileArithMul):
(JSC::DFG::SpeculativeJIT::compileArithDiv):
(JSC::DFG::SpeculativeJIT::compileArithMod):

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileAddSub):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithDivMod):
(JSC::FTL::LowerDFGToLLVM::compileArithNegate):
(JSC::FTL::LowerDFGToLLVM::compileUInt32ToNumber):

8:48 PM Changeset in webkit [161398] by fpizlo@apple.com

• 36 edits
  7 adds in branches/jsCStack/Source/JavaScriptCore

Merge trunk r160294, r160295, r160328, r160347, r160348.

8:45 PM Changeset in webkit [161397] by mrowe@apple.com

• 3 edits in trunk/Source/WebCore

<​https://webkit.org/b/126559> Be more correct in dealing with NSControlSize

Reviewed by Ryosuke Niwa.

• platform/mac/ScrollbarThemeMac.mm:

(WebCore::scrollbarControlSizeToNSControlSize): Helper function to map from ScrollbarControlSize
to NSControlSize.
(WebCore::ScrollbarThemeMac::registerScrollbar): Use the helper rather than casting.
(WebCore::ScrollbarThemeMac::scrollbarThickness): Use the helper.

• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::progressBarRectForBounds): Update the type of the local to NSControlSize.
(WebCore::RenderThemeMac::paintProgressBar): Ditto.

8:00 PM Changeset in webkit [161396] by mrowe@apple.com

• 3 edits in trunk/Tools

<​https://webkit.org/b/126560> Fix incorrectness in use of some AppKit enums

Reviewed by Ryosuke Niwa.

• DumpRenderTree/mac/DumpRenderTree.mm:

(-[DRTMockScroller rectForPart:]): Move to using an if with early return instead of a switch
with a single case. This avoids the potential for warnings about unhandled cases.

• WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView): Cast the argument to NSBackingStoreType.

7:52 PM Changeset in webkit [161395] by fpizlo@apple.com

• 1 edit
  1 add in branches/jsCStack/Source/JavaScriptCore

Finish merging r160292: add more forgotten files.

• tests/stress/fold-typed-array-properties.js: Added.

7:44 PM Changeset in webkit [161394] by fpizlo@apple.com

• 1 edit
  2 adds in branches/jsCStack/Source/JavaScriptCore

Finish merging r160292: add forgotten files.

• dfg/DFGStrengthReductionPhase.cpp: Added.
• dfg/DFGStrengthReductionPhase.h: Added.

7:42 PM Changeset in webkit [161393] by fpizlo@apple.com

• 25 edits in branches/jsCStack

Source/JavaScriptCore: Merge trunk r160292.

Tools: Merge trunk r160292.

7:17 PM Changeset in webkit [161392] by fpizlo@apple.com

• 6 edits
  15 adds in branches/jsCStack

Source/JavaScriptCore: Merge trunk r160238, r160242, r160246, r160252, r160257.

LayoutTests: Merge trunk r160242, r160246, r160252, r160257.

6:04 PM Changeset in webkit [161391] by Brent Fulgham

• 2 edits
  1 delete in trunk/LayoutTests

[WebGL] Unreviewed build fix for Mountain Lion drivers.

• platform/mac-mountainlion/TestExpectations: Removed. Moved test to the mac/TestExpectations file.
• platform/mac/TestExpectations: Add failure entry for MountainLion test.

5:55 PM Changeset in webkit [161390] by msaboff@apple.com

• 2 edits in branches/jsCStack/Source/JavaScriptCore

CStack Branch: Disable JIT stack alignment check for ARM64
​https://bugs.webkit.org/show_bug.cgi?id=126550

Reviewed by Mark Lam.

Since ARM64 enforces strict stack alignment, the need for checkStackPointerAlignment()
is not needed. Also, the implementation of checkStackPointerAlignment() would
need to be reworked given the limits on the operations that can be done with
the stack pointer register in ARM64. Therefore conditionally disabled
checkStackPointerAlignment() for ARM64.

• jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::checkStackPointerAlignment):

5:44 PM Changeset in webkit [161389] by Brent Fulgham

• 11 edits
  2 adds in trunk/Source/WebCore

[WebGL] Be safer about toggling OpenGL state by using a scoped object to control setting lifetime.
​https://bugs.webkit.org/show_bug.cgi?id=126548

Reviewed by Anders Carlsson.

No new tests since there is no change in behavior.

• GNUmakefile.list.am: Updated to build new TemporaryOpenGLSetting files.
• PlatformBlackBerry.cmake: Ditto
• PlatformEfl.cmake: Ditto
• PlatformGTK.cmake: Ditto
• PlatformNix.cmake: Ditto
• WebCore.vcxproj/WebCore.vcxproj: Ditto
• WebCore.vcxproj/WebCore.vcxproj.filters: Ditto
• WebCore.xcodeproj/project.pbxproj: Ditto
• platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary): Use new object.

• platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::prepareTexture): Ditto
(WebCore::GraphicsContext3D::reshape): Ditto

• platform/graphics/opengl/TemporaryOpenGLSetting.cpp: Added.

(WebCore::TemporaryOpenGLSetting::TemporaryOpenGLSetting):
(WebCore::TemporaryOpenGLSetting::~TemporaryOpenGLSetting):

• platform/graphics/opengl/TemporaryOpenGLSetting.h: Added.

5:41 PM Changeset in webkit [161388] by Brent Fulgham

• 1 edit
  1 add in trunk/LayoutTests

[WebGL] Unreviewed build fix for Mountain Lion drivers.

Add new TestExpectations file for Mountain Lion.

• platform/mac-mountainlion/TestExpectations: Added.

4:57 PM Changeset in webkit [161387] by Simon Fraser

• 17 edits in trunk/Source

Hook up the RemoteScrollingCoordinator
​https://bugs.webkit.org/show_bug.cgi?id=126547

Source/WebCore:

Reviewed by Tim Horton.

Export lots of scrolling-related symbols for use by WebKit2.

• WebCore.exp.in:

Source/WebKit2:

Reviewed by Tim Horton.

Hook up the RemoteScrollingCoordinator in WebKit2.

When the RemoteLayerTreeDrawingArea is in use, WebPageProxy creates
a RemoteScrollingCoordinator, and hands it mouseWheel events. It then
scrolls via a RemoteScrollingTree constructed from state tree commits from the
WebProcess.

Scrolling tree commits happen via a transaction received by RemoteLayerTreeDrawingAreaProxy,
atomically with layer tree transactions.

• Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:

(WebKit::RemoteScrollingCoordinatorTransaction::encode): Fix encoding for some
cases seen in WebKitTestRunner where a page has no ScrollingCoordinator.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeWebPage): Create the RemoteScrollingCoordinatorProxy
when using a remote layer tree drawing area.
(WebKit::WebPageProxy::handleWheelEvent): Pass to the scrolling coordinator.

• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::scrollingCoordinatorProxy):

• UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h: Include the RemoteScrollingCoordinatorTransaction.
• UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.messages.in:
• UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):

• UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::getLayer): It's valid to get a 0 layerID (e.g. when
a layer disappears) so handle this case.

• WebKit2.xcodeproj/project.pbxproj:
• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createScrollingCoordinator): Override to create the
RemoteScrollingCoordinator in the WebProcess.

• WebProcess/WebCoreSupport/WebChromeClient.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::scrollingCoordinator): Not inline to avoid polluting the
header with #includes.

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h: Say that we want a ScrollingCoordinator.
• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::flushLayers): Add the scrollingTransaction to the
message.

4:56 PM Changeset in webkit [161386] by ljaehun.lim@samsung.com

• 2 edits in trunk/Source/WebKit2

Use hasEnabledVerticalScrollbar instead of hasEnabledHorizontalScrollbar.
​https://bugs.webkit.org/show_bug.cgi?id=126546

Reviewed by Simon Fraser.

hasEnabledHorizontalScrollbar is used twice.

• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<WebCore::ScrollableAreaParameters>::encode):

4:52 PM Changeset in webkit [161385] by Seokju Kwon

• 15 edits
  1 delete in trunk/Source

Web Inspector: Remove support for FileSystem in Frontend.
​https://bugs.webkit.org/show_bug.cgi?id=126369

Reviewed by Joseph Pecoraro.

Source/WebCore:

No new tests, No change in behavior.

Remove leftover codes from protocol after r156692.

• CMakeLists.txt:
• DerivedSources.make:
• GNUmakefile.am:
• inspector/InspectorFrontendClient.h:
• inspector/InspectorFrontendClientLocal.h:
• inspector/InspectorFrontendHost.cpp:
• inspector/InspectorFrontendHost.h:
• inspector/InspectorFrontendHost.idl:
• inspector/protocol/FileSystem.json: Removed.

Source/WebInspectorUI:

Update InspectorWebBackendCommands after removing 'FileSystem' domain.

• UserInterface/InspectorWebBackendCommands.js:
• UserInterface/Legacy/6.0/InspectorWebBackendCommands.js:
• UserInterface/Legacy/7.0/InspectorWebBackendCommands.js:
• Versions/Inspector-iOS-6.0.json:
• Versions/Inspector-iOS-7.0.json:

4:42 PM Changeset in webkit [161384] by zoltan@webkit.org

• 3 edits
  2 adds in trunk

[CSS Regions][CSS Shapes] ASSERTION FAILED: m_segmentRanges.size() < m_segments.size()
​https://bugs.webkit.org/show_bug.cgi?id=125770

Reviewed by Bem Jones-Bey.

Source/WebCore:

When we have an e.g. up-side-down triangle, when the content doesn't fit in the bottom part of the shape,
and the adjusted content flows into the next region with a shape, we need to update the actual shape
and region. Since it wasn't updated, it led to a shape mismatch, which led to assert/layout error.

Test: fast/regions/shape-inside/shape-inside-on-multiple-regions-bottom-adjustment.html

• rendering/RenderBlockLineLayout.cpp:

(WebiCore::RenderBlockFlow::updateShapeAndSegmentsForCurrentLineInFlowThread): Update current shape
and region, when adjustment occured.

LayoutTests:

• fast/regions/shape-inside/shape-inside-on-multiple-regions-bottom-adjustment-expected.html: Added.
• fast/regions/shape-inside/shape-inside-on-multiple-regions-bottom-adjustment.html: Added.

4:35 PM Changeset in webkit [161383] by Brent Fulgham

• 3 edits in trunk/LayoutTests

Unreviewed test correction.

• webgl/1.0.2/resources/webgl_test_files/conformance/renderbuffers/framebuffer-object-attachment.html: Remove commented-out

line from debugging code.

• webgl/1.0.2/resources/webgl_test_files/conformance/resources/webgl-test-utils.js:

(WebGLTestUtils): Return to normal behavior of exiting immediately on test failure.

4:05 PM Changeset in webkit [161382] by Seokju Kwon

• 8 edits
  1 delete in trunk/Source/WebCore

Web Inspector: Get rid of Inspector/BindingVisitors.h
​https://bugs.webkit.org/show_bug.cgi?id=126374

Reviewed by Joseph Pecoraro.

No new tests, No change in behavior.

In r161204, methods related to BindingVisitors was removed.

• GNUmakefile.list.am:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/ScriptProfiler.h:
• inspector/BindingVisitors.h: Removed.
• inspector/InspectorCanvasAgent.cpp:
• inspector/InspectorMemoryAgent.cpp:

3:50 PM Changeset in webkit [161381] by timothy_horton@apple.com

• 10 edits in trunk/Source/WebCore

Add {IntRect, FloatRect}::infiniteRect() and ::isInfinite()
​https://bugs.webkit.org/show_bug.cgi?id=126537

Reviewed by Simon Fraser.

• platform/graphics/FloatRect.h:

(WebCore::FloatRect::infiniteRect):
(WebCore::FloatRect::isInfinite):

• platform/graphics/IntRect.h:

(WebCore::IntRect::infiniteRect):
(WebCore::IntRect::isInfinite):
Add infiniteRect() and isInfinite() to FloatRect and IntRect.

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setNeedsDisplay):

• rendering/PaintInfo.h:

(WebCore::PaintInfo::applyTransform):

• rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::fragmentsBoundingBox):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::collectFragments):
(WebCore::RenderLayer::calculateClipRects):

• rendering/RenderLayerBacking.cpp:

(WebCore::clipBox):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::clippedByAncestor):

• rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::renderSubtreeToImageBuffer):
Adopt the new functions.

3:35 PM Changeset in webkit [161380] by Seokju Kwon

• 9 edits
  2 deletes in trunk

Web Inspector: Get rid of DOM.setFileInputFiles from Protocol
​https://bugs.webkit.org/show_bug.cgi?id=126312

Reviewed by Joseph Pecoraro.

Source/WebCore:

No new tests, No changes in behavior.

It is a dead code as all ports in WebKit don't support it.
And this patch removes all things related to DOM.setFileInputFiles in Frontend.

• inspector/InspectorClient.h:
• inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

• inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):

• inspector/InspectorDOMAgent.h:

(WebCore::InspectorDOMAgent::create):

• inspector/protocol/DOM.json:

Source/WebInspectorUI:

Update InspectorWebBackendCommands.js after removing DOM.setFileInputFiles.

• UserInterface/InspectorWebBackendCommands.js:

LayoutTests:

• inspector-protocol/dom/setFileInputFiles-expected.txt: Removed.
• inspector-protocol/dom/setFileInputFiles.html: Removed.

3:28 PM Changeset in webkit [161379] by Brent Fulgham

• 2 edits in trunk/LayoutTests

Unreviewed test update after r161375.

• platform/mac/TestExpectations: Activate several tests that are now known to pass.

3:23 PM Changeset in webkit [161378] by Brent Fulgham

• 2 edits in trunk/Source/WebCore

[WebGL] Revise String Concatenation (Follow-up to r161247)
​https://bugs.webkit.org/show_bug.cgi?id=126411

Reviewed by Dean Jackson.

• html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getUniformLocation): Use more efficient string
concatenation per Darin Adler's suggestion.

3:04 PM Changeset in webkit [161377] by mhahnenberg@apple.com

• 11 edits in trunk/Source/JavaScriptCore

Add write barriers to the LLInt
​https://bugs.webkit.org/show_bug.cgi?id=126527

Reviewed by Filip Pizlo.

This patch takes a similar approach to how write barriers work in the baseline JIT.
We execute the write barrier at the beginning of the opcode so we don't have to
worry about saving and restoring live registers across write barrier slow path calls
to C code.

• llint/LLIntOfflineAsmConfig.h:
• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::llint_write_barrier_slow):

• llint/LLIntSlowPaths.h:
• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:
• offlineasm/arm64.rb:
• offlineasm/instructions.rb:
• offlineasm/x86.rb:

2:46 PM Changeset in webkit [161376] by Simon Fraser

• 2 edits in trunk/Source/WebKit2

Another build fix.

Need to look in the WebProcess/Scrolling directory for .messages.in files.

• DerivedSources.make:

2:43 PM Changeset in webkit [161375] by Brent Fulgham

• 4 edits in trunk

[WebGL] FBO Depth Buffer Attachment Function Improperly Clearing with 0
​https://bugs.webkit.org/show_bug.cgi?id=126538
<rdar://problem/15201336>

Reviewed by Dean Jackson.

Tested by webgl/1.0.2/resources/webgl_test_files/conformance/renderbuffers/framebuffer-object-attachment.html

• html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::initializeAttachments): Clear depth buffer with 1.0f (rather than 0), to match expected
default (clear) buffer state for OpenGL. Using 0 would require us to flip the clear mask for the depth attachment
type.

2:38 PM Changeset in webkit [161374] by Simon Fraser

• 2 edits in trunk/Source/WebKit2

Fix the build.

Need to add RemoteScrollingCoordinator to MESSAGE_RECEIVERS so that
RemoteScrollingCoordinatorMessages.h gets generated.

• DerivedSources.make:

2:19 PM Changeset in webkit [161373] by Simon Fraser

• 8 edits
  2 copies
  10 adds in trunk/Source

Add new files for UI-side scrolling
​https://bugs.webkit.org/show_bug.cgi?id=126532

Source/WebCore:

Reviewed by Anders Carlson.

• WebCore.xcodeproj/project.pbxproj: Make lots of scrolling-related headers Private

so WebKit2 can include them.

• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::scheduleUpdateScrollPositionForNode): Callback that
indicates that the given node has been scrolled asynchronously. Currently only
handles the main frame.

• page/scrolling/ScrollingCoordinator.h: Add support for type-casts of a remote subclass

in another namespace.
(WebCore::ScrollingCoordinator::isRemoteScrollingCoordinator):

• page/scrolling/ScrollingTree.h:

(WebCore::ScrollingTree::isRemoteScrollingTree):

Source/WebKit2:

Reviewed by Anders Carlson.

Add RemoteScrollingCoordinator, RemoteScrollingCoordinatorProxy,
RemoteScrollingCoordinatorTransaction, RemoteScrollingTree.

These allow the scrolling tree to be used in the UI process.
RemoteScrollingCoordinator builds a ScrollingStateTree, which is
encoded by RemoteScrollingCoordinatorTransaction. Decoding the
transaction recreates that ScrollingStateTree in the UI process,
and RemoteScrollingCoordinatorProxy "commits" that to update
the RemoteScrollingTree.

New classes are not hooked up to anything yet.

• Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp: Added.

(ArgumentCoder<ScrollingStateNode>::encode):
(ArgumentCoder<ScrollingStateNode>::decode):
(ArgumentCoder<ScrollingStateScrollingNode>::encode):
(ArgumentCoder<ScrollingStateScrollingNode>::decode):
(ArgumentCoder<ScrollingStateFixedNode>::encode):
(ArgumentCoder<ScrollingStateFixedNode>::decode):
(ArgumentCoder<ScrollingStateStickyNode>::encode):
(ArgumentCoder<ScrollingStateStickyNode>::decode):
(WebKit::encodeNodeAndDescendants):
(WebKit::RemoteScrollingCoordinatorTransaction::encode):
(WebKit::RemoteScrollingCoordinatorTransaction::decode):

• Shared/Scrolling/RemoteScrollingCoordinatorTransaction.h: Added.

(WebKit::RemoteScrollingCoordinatorTransaction::setStateTreeToEncode):
(WebKit::RemoteScrollingCoordinatorTransaction::scrollingStateTree):

• UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp: Added.

(WebKit::RemoteScrollingCoordinatorProxy::RemoteScrollingCoordinatorProxy):
(WebKit::RemoteScrollingCoordinatorProxy::~RemoteScrollingCoordinatorProxy):
(WebKit::RemoteScrollingCoordinatorProxy::layerTreeHost):
(WebKit::RemoteScrollingCoordinatorProxy::updateScrollingTree):
(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers):
(WebKit::RemoteScrollingCoordinatorProxy::handleWheelEvent):
(WebKit::RemoteScrollingCoordinatorProxy::scrollPositionChanged):

• UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.h: Added.
• UIProcess/Scrolling/RemoteScrollingTree.cpp: Added.

(WebKit::RemoteScrollingTree::create):
(WebKit::RemoteScrollingTree::RemoteScrollingTree):
(WebKit::RemoteScrollingTree::~RemoteScrollingTree):
(WebKit::RemoteScrollingTree::tryToHandleWheelEvent):
(WebKit::RemoteScrollingTree::handleWheelEventPhase):
(WebKit::RemoteScrollingTree::updateMainFrameScrollPosition):
(WebKit::RemoteScrollingTree::createNode):

• UIProcess/Scrolling/RemoteScrollingTree.h: Added.

(WebKit::RemoteScrollingTree::scrollingCoordinatorProxy):

• WebKit2.xcodeproj/project.pbxproj:
• WebProcess/Scrolling/RemoteScrollingCoordinator.h: Added.

(WebKit::RemoteScrollingCoordinator::create):

• WebProcess/Scrolling/RemoteScrollingCoordinator.messages.in: Added.
• WebProcess/Scrolling/RemoteScrollingCoordinator.mm: Added.

(WebKit::RemoteScrollingCoordinator::RemoteScrollingCoordinator):
(WebKit::RemoteScrollingCoordinator::~RemoteScrollingCoordinator):
(WebKit::RemoteScrollingCoordinator::scheduleTreeStateCommit):
(WebKit::RemoteScrollingCoordinator::createScrollingTreeNode):
(WebKit::RemoteScrollingCoordinator::isRubberBandInProgress):
(WebKit::RemoteScrollingCoordinator::setScrollPinningBehavior):
(WebKit::RemoteScrollingCoordinator::buildTransaction):
(WebKit::RemoteScrollingCoordinator::scrollPositionChangedForNode):

2:18 PM Changeset in webkit [161372] by mark.lam@apple.com

• 2 edits in branches/jsCStack/Source/JavaScriptCore

CStack: JSLock drop and grab lock APIs should be private.
​https://bugs.webkit.org/show_bug.cgi?id=126539.

Reviewed by Mark Hahnenberg.

We want the dropping and re-acquisition of the VM API lock to be via the
DropAllLocks raii object. Hence, we should not publicly publishing the
APIs for dropping and re-acquiring the locks.

• runtime/JSLock.h:

2:03 PM Changeset in webkit [161371] by ap@apple.com

• 2 edits in trunk/LayoutTests

REGRESSION (r161195): Acid2 regression tests frequently fail
​https://bugs.webkit.org/show_bug.cgi?id=126432

• TestExpectations: Marking them as flaky.

1:52 PM Changeset in webkit [161370] by Martin Robinson

• 2 edits in trunk/Source/WebCore/platform/gtk/po

[GTK] [CMake] Improve the way that translations are built with the built-in gettext support CMake
​https://bugs.webkit.org/show_bug.cgi?id=126453

Reviewed by Gustavo Noronha Silva.

• CMakeLists.txt: Use the built-in CMake support for gettext to simplify the way we

build translation files and to automatically take care of installing them. Also adjust
the pot file build location to make the CMake build more similar to autotools.

1:48 PM Changeset in webkit [161369] by mark.lam@apple.com

• 3 edits in branches/jsCStack/Source/JavaScriptCore

Follow up patch to remove the need for VMEntryScope::m_prevFirstEntryScope.
​https://bugs.webkit.org/show_bug.cgi?id=126266.

Reviewed by Geoffrey Garen.

There can only be one firstEntryScope. Instead of saving the previous value of
VM::firstEntryScope, we now check if the firstEntryScope is the same as this
VMEntryScope in its destructor. If so, we will set VM::firstEntryScope to 0.

• runtime/VMEntryScope.cpp:

(JSC::VMEntryScope::VMEntryScope):
(JSC::VMEntryScope::~VMEntryScope):

• runtime/VMEntryScope.h:

1:31 PM Changeset in webkit [161368] by Martin Robinson

• 4 edits in trunk/Source

Small build fix for the GTK+ CMake port

Source/WebKit:

• PlatformGTK.cmake: Include a missing GeoClue include directory.

Source/WebKit2:

• PlatformGTK.cmake: Include a missing GeoClue include directory.

1:30 PM Changeset in webkit [161367] by Simon Fraser

• 4 edits in trunk/Source/WebKit2

Rename DrawingArea::supportsThreadedScrolling() to supportsAsyncScrolling()
​https://bugs.webkit.org/show_bug.cgi?id=126529

Reviewed by Tim Horton.

Change function name from using "threaded" to "async" terminology.

• WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::supportsAsyncScrolling):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

1:14 PM Changeset in webkit [161366] by Martin Robinson

• 11 edits
  85 copies
  7 adds
  2 deletes in trunk

[GTK] Move all GTK/GObject unit tests to Tools/TestWebKitAPI
​https://bugs.webkit.org/show_bug.cgi?id=126342

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2014-01-04
Reviewed by Gustavo Noronha Silva.

.:

• GNUmakefile.am: Remove unused variable.
• Source/PlatformGTK.cmake: No longer include the old unit tests directories.

Source/WebKit/gtk:

• tests/CMakeLists.txt: Removed.
• tests/GNUmakefile.am: Removed.

Source/WebKit2:

• UIProcess/API/gtk/tests/CMakeLists.txt: Removed.
• UIProcess/API/gtk/tests/GNUmakefile.am: Removed.

Tools:

• CMakeLists.txt: Include the new unit tests subdirectories.
• Scripts/run-gtk-tests: Update to refer to the new build locations.
• Scripts/webkitpy/style/checker.py: Update the style checker.
• Scripts/webkitpy/style/checker_unittest.py:
• TestWebKitAPI/GNUmakefile.am:
• TestWebKitAPI/Tests/WebKit2Gtk/AccessibilityTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/AccessibilityTestServer.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Added.
• TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp: Added.
• TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/DOMNodeTest.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/FrameTest.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/InspectorTestServer.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.h.
• TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestAuthentication.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestBackForwardList.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestCookieManager.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/TestDOMDOMWindow.cpp: Added.
• TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDOMNode.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDownloads.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestFrame.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspector.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspectorServer.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestLoaderClient.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/TestMain.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/TestMain.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.h.
• TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestPrinting.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestSSL.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestUIClient.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebExtensions.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitVersion.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitVersion.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebContext.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebViewEditor.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebExtensionTest.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.h.
• TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.h.
• TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h.
• TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.h.
• TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp.
• TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.h.
• TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/link-title.js.
• TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-cert.pem.
• TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-key.pem.
• TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/webkit2gtk-tests.gresource.xml.
• TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Added.
• TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Renamed from Source/WebKit/gtk/tests/resources/blank.ico.
• TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Renamed from Source/WebKit/gtk/tests/resources/test.html.
• TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Renamed from Source/WebKit/gtk/tests/resources/test.ogg.
• TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Renamed from Source/WebKit/gtk/tests/resources/test.pdf.
• TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Renamed from Source/WebKit/gtk/tests/resources/test.txt.
• TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Renamed from Source/WebKit/gtk/tests/test_utils.c.
• TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Renamed from Source/WebKit/gtk/tests/test_utils.h.
• TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Renamed from Source/WebKit/gtk/tests/testapplicationcache.c.
• TestWebKitAPI/Tests/WebKitGtk/testatk.c: Renamed from Source/WebKit/gtk/tests/testatk.c.
• TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Renamed from Source/WebKit/gtk/tests/testatkroles.c.
• TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Renamed from Source/WebKit/gtk/tests/testcontextmenu.c.
• TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Renamed from Source/WebKit/gtk/tests/testcopyandpaste.c.
• TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Renamed from Source/WebKit/gtk/tests/testdomdocument.c.
• TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Renamed from Source/WebKit/gtk/tests/testdomdomwindow.c.
• TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Renamed from Source/WebKit/gtk/tests/testdomnode.c.
• TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Renamed from Source/WebKit/gtk/tests/testdownload.c.
• TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Renamed from Source/WebKit/gtk/tests/testfavicondatabase.c.
• TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Renamed from Source/WebKit/gtk/tests/testglobals.c.
• TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Renamed from Source/WebKit/gtk/tests/testhittestresult.c.
• TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Renamed from Source/WebKit/gtk/tests/testhttpbackend.c.
• TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Renamed from Source/WebKit/gtk/tests/testkeyevents.c.
• TestWebKitAPI/Tests/WebKitGtk/testloading.c: Renamed from Source/WebKit/gtk/tests/testloading.c.
• TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Renamed from Source/WebKit/gtk/tests/testmimehandling.c.
• TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Renamed from Source/WebKit/gtk/tests/testnetworkrequest.c.
• TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Renamed from Source/WebKit/gtk/tests/testnetworkresponse.c.
• TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Renamed from Source/WebKit/gtk/tests/testwebbackforwardlist.c.
• TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Renamed from Source/WebKit/gtk/tests/testwebdatasource.c.
• TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Renamed from Source/WebKit/gtk/tests/testwebframe.c.
• TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Renamed from Source/WebKit/gtk/tests/testwebhistoryitem.c.
• TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Renamed from Source/WebKit/gtk/tests/testwebinspector.c.
• TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Renamed from Source/WebKit/gtk/tests/testwebplugindatabase.c.
• TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Renamed from Source/WebKit/gtk/tests/testwebresource.c.
• TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Renamed from Source/WebKit/gtk/tests/testwebsettings.c.
• TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Renamed from Source/WebKit/gtk/tests/testwebview.c.
• TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Renamed from Source/WebKit/gtk/tests/testwindow.c.

1:00 PM Changeset in webkit [161365] by weinig@apple.com

• 12 edits in trunk

[JS] Implement Promise.all()
​https://bugs.webkit.org/show_bug.cgi?id=126510

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Add Promise.all() implementation and factor out performing resolves and rejects
on deferreds to share a bit of code. Also moves the abruptRejection helper to
JSPromiseDeferred so it can be used in JSPromiseFunctions.

• runtime/CommonIdentifiers.h:
• runtime/JSPromiseConstructor.cpp:

(JSC::JSPromiseConstructorFuncCast):
(JSC::JSPromiseConstructorFuncResolve):
(JSC::JSPromiseConstructorFuncReject):
(JSC::JSPromiseConstructorFuncAll):

• runtime/JSPromiseDeferred.cpp:

(JSC::updateDeferredFromPotentialThenable):
(JSC::performDeferredResolve):
(JSC::performDeferredReject):
(JSC::abruptRejection):

• runtime/JSPromiseDeferred.h:
• runtime/JSPromiseFunctions.cpp:

(JSC::promiseAllCountdownFunction):
(JSC::createPromiseAllCountdownFunction):

• runtime/JSPromiseFunctions.h:
• runtime/JSPromiseReaction.cpp:

(JSC::ExecutePromiseReactionMicrotask::run):

LayoutTests:

Enabled and fix the existing Promise.all() test case.

• Promise.all() and Promise.all({}) should reject by my reading of the spec.

Also removes the Promise.all() shim used by the crypto tests.

• crypto/subtle/resources/common.js:
• js/dom/Promise-static-all-expected.txt:
• js/dom/Promise-static-all.html:

12:41 PM Changeset in webkit [161364] by fpizlo@apple.com

• 31 edits in trunk/Source

Get rid of ENABLE(VALUE_PROFILER). It's on all the time now.

Rubber stamped by Mark Hahnenberg.

Source/JavaScriptCore:

• bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeFor):

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpValueProfiling):
(JSC::CodeBlock::dumpArrayProfiling):
(JSC::CodeBlock::dumpRareCaseProfile):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::setNumParameters):
(JSC::CodeBlock::shrinkToFit):
(JSC::CodeBlock::shouldOptimizeNow):

• bytecode/CodeBlock.h:

(JSC::CodeBlock::valueProfileForBytecodeOffset):

• bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeForChain):
(JSC::GetByIdStatus::computeFor):

• bytecode/LazyOperandValueProfile.cpp:
• bytecode/LazyOperandValueProfile.h:
• bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFor):

• bytecode/ValueProfile.h:
• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::newArrayProfile):
(JSC::BytecodeGenerator::newArrayAllocationProfile):
(JSC::BytecodeGenerator::emitProfiledOpcode):

• jit/GPRInfo.h:
• jit/JIT.cpp:

(JSC::JIT::JIT):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):

• jit/JIT.h:
• jit/JITArithmetic.cpp:

(JSC::JIT::compileBinaryArithOp):
(JSC::JIT::emit_op_mul):
(JSC::JIT::emit_op_div):

• jit/JITArithmetic32_64.cpp:

(JSC::JIT::emitBinaryDoubleOp):
(JSC::JIT::emit_op_mul):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emit_op_div):

• jit/JITCall.cpp:

(JSC::JIT::emitPutCallResult):

• jit/JITCall32_64.cpp:

(JSC::JIT::emitPutCallResult):

• jit/JITInlines.h:

(JSC::JIT::appendCallWithExceptionCheckSetJSValueResultWithProfile):
(JSC::JIT::emitValueProfilingSite):
(JSC::JIT::emitArrayProfilingSiteForBytecodeIndex):
(JSC::JIT::emitArrayProfileStoreToHoleSpecialCase):
(JSC::JIT::emitArrayProfileOutOfBoundsSpecialCase):
(JSC::arrayProfileSaw):
(JSC::JIT::chooseArrayMode):

• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_get_argument_by_val):

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_get_argument_by_val):

• jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_get_from_scope):

• jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_get_from_scope):

• llint/LLIntOfflineAsmConfig.h:
• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:
• profiler/ProfilerBytecodeSequence.cpp:

(JSC::Profiler::BytecodeSequence::BytecodeSequence):

• runtime/CommonSlowPaths.cpp:

Source/WTF:

• wtf/Platform.h:

12:35 PM Changeset in webkit [161363] by ap@apple.com

• 4 edits in trunk/Tools

Gtk and Efl API test results confuse the dashboard
​https://bugs.webkit.org/show_bug.cgi?id=126535

Reviewed by Tim Horton.

Added "API tests" step as "platform api tests".

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:

(Buildbot.prototype.platformAPITestResultsURLForIteration):

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(BuildbotIteration):
(BuildbotIteration.prototype.update):

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
(BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):

12:33 PM Changeset in webkit [161362] by zandobersek@gmail.com

• 5 edits in trunk/Source/WTF

Remove using directives for the std namespace from WTF
​https://bugs.webkit.org/show_bug.cgi?id=126524

Reviewed by Alexey Proskuryakov.

Remove the using directives for the std namespace throughout the WTF code.
The more explicit std:: nested name specifier should be used instead.

• wtf/MediaTime.cpp:

(WTF::MediaTime::createWithFloat):
(WTF::MediaTime::createWithDouble):

• wtf/text/StringImpl.cpp:

(WTF::StringImpl::create):
(WTF::StringImpl::lower):
(WTF::StringImpl::upper):
(WTF::StringImpl::foldCase):
(WTF::StringImpl::find):
(WTF::StringImpl::findIgnoringCase):
(WTF::reverseFindInner):
(WTF::StringImpl::reverseFind):
(WTF::reverseFindIgnoringCaseInner):
(WTF::StringImpl::reverseFindIgnoringCase):
(WTF::StringImpl::replace):
(WTF::StringImpl::utf8ForCharacters):
(WTF::StringImpl::utf8ForRange):

• wtf/text/WTFString.cpp:

(WTF::String::append):
(WTF::String::appendInternal):
(WTF::String::insert):
(WTF::String::substringSharingImpl):
(WTF::String::fromUTF8):
(WTF::toIntegralType):

• wtf/win/RunLoopWin.cpp:

12:23 PM Changeset in webkit [161361] by mark.lam@apple.com

• 2 edits in branches/jsCStack/Source/JavaScriptCore

CStack: jsStackLimit fixup should not exceed native stack limit.
​https://bugs.webkit.org/show_bug.cgi?id=126487.

Reviewed by Michael Saboff.

In doCallToJavaScript, we fixup VM::m_jsStackLimit once we know what the
stackPointerAtVMEntry is. However, we also need to ensure that the fixed
up jsStackLimit does not exceed the native stack limit. This check was
missing, and resulted in an assertion failure when running testapi on
platforms that have smaller stacks. This is now fixed.

• llint/LowLevelInterpreter64.asm:

12:10 PM Changeset in webkit [161360] by timothy_horton@apple.com

• 4 edits in trunk/Tools

build.webkit.org/dashboard should still function if localStorage is disabled
​https://bugs.webkit.org/show_bug.cgi?id=126511

Reviewed by Alexey Proskuryakov.

If localStorage is disabled, we should carry on with a warning.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:

Don't show the gear if localStorage isn't working.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:

(QueueView.prototype._updateHiddenState):
Bail if localStorage isn't working.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:

(Settings.prototype.available):

12:03 PM Changeset in webkit [161359] by zandobersek@gmail.com

• 3 edits in trunk

[GTK] configure errors out when building with libc++
​https://bugs.webkit.org/show_bug.cgi?id=126431

Reviewed by Martin Robinson.

Ease up the Clang and libstdc++ combination test to only fail if libstdc++ < 4.8.1 is actually used.
This allows for libc++ to be used as well. The test is moved into SetupCompilerFlags.m4 and is done
after the CXXFLAGS variable is properly set up, that is when all the C++ compiler options are determined.

• Source/autotools/CheckSystemAndBasicDependencies.m4:
• Source/autotools/SetupCompilerFlags.m4:

11:44 AM Changeset in webkit [161358] by enrica@apple.com

• 11 edits in trunk/Source/WebKit2

Add support to retrieve the autocorrection context.
​https://bugs.webkit.org/show_bug.cgi?id=126479

Reviewed by Sam Weinig.

We are adding the support to retrieve the input context for autocorrection
and input methods on iOS. The implementation is provided both via synchronous
and asynchronous calls to the WebProcess.

• Platform/IPC/HandleMessage.h: Added template with zero input parameters and six reply parameters.
• UIProcess/API/ios/WKInteractionView.mm:

(autocorrectionData):
(-[WKInteractionView requestAutocorrectionRectsForString:withCompletionHandler:]):
(autocorrectionResult):
(-[WKInteractionView applyAutocorrection:toString:withCompletionHandler:]):
(autocorrectionContext):
(-[WKInteractionView requestAutocorrectionContextWithCompletionHandler:]):
(-[WKInteractionView hasMarkedText]):
(-[WKInteractionView _startAssistingNode]):
(+[WKAutocorrectionContext autocorrectionContextWithData:markedText:selectedText:afterText:selectedRangeInMarkedText:]):
(-[WKAutocorrectionContext dealloc]):

• UIProcess/AutoCorrectionCallback.h:

(WebKit::AutocorrectionContextCallback::create):
(WebKit::AutocorrectionContextCallback::~AutocorrectionContextCallback):
(WebKit::AutocorrectionContextCallback::performCallbackWithReturnValue):
(WebKit::AutocorrectionContextCallback::invalidate):
(WebKit::AutocorrectionContextCallback::AutocorrectionContextCallback):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::resetState):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::autocorrectionContextCallback):
(WebKit::WebPageProxy::requestAutocorrectionContext):
(WebKit::WebPageProxy::getAutocorrectionContext):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::computeAutocorrectionContext):
(WebKit::WebPage::requestAutocorrectionContext):
(WebKit::WebPage::getAutocorrectionContext):

11:29 AM Changeset in webkit [161357] by barraclough@apple.com

• 19 edits
  1 add
  1 delete in trunk/Source

Move ViewState to WebCore
​https://bugs.webkit.org/show_bug.cgi?id=126488

Reviewed by Anders Carlson.

This change also partial reverts handling of LayerHostingMode, making this
a separate message again. With hindsight the new way of doing this wasn't
in all ways simpler, and it won't make sense to move this to WebCore.

Source/WebCore:

• WebCore.xcodeproj/project.pbxproj:
• page/ViewState.h: Added.
  • Moved from WebKit2, will be used by Page & FocusController.

Source/WebKit2:

• Shared/ViewState.h: Removed.
  • Moved to WebCore.
• Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

• Shared/WebPageCreationParameters.h:
  • Added layerHostingMode.
• UIProcess/API/mac/PageClientImpl.h:
• UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::viewLayerHostingMode):

• UIProcess/PageClient.h:

(WebKit::PageClient::viewLayerHostingMode):

• Revert isLayerWindowServerHosted -> viewLayerHostingMode.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):

• Added back m_layerHostingMode.

(WebKit::WebPageProxy::updateViewState):

• Removed IsLayerWindowServerHosted from ViewState.

(WebKit::WebPageProxy::viewStateDidChange):

• Added SetLayerHostingMode message.

(WebKit::WebPageProxy::initializeCreationParameters):

• Pass layerHostingMode.

• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::isInWindow):
(WebKit::WebPageProxy::isViewVisible):

• ViewState moved to WebCore.

• WebKit2.xcodeproj/project.pbxproj:
  • Removed ViewState.
• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::setLayerHostingMode):
(WebKit::PluginView::platformViewStateDidChange):

• Separated setLayerHostingMode from platformViewStateDidChange.

• WebProcess/Plugins/PluginView.h:
• WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::viewStateDidChange):
(WebKit::DrawingArea::setLayerHostingMode):

• Added virtual function, overridden in TiledCoreAnimationDrawingArea.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::setLayerHostingMode):

• Separated setLayerHostingMode from platformViewStateDidChange.

• WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::isVisible):
(WebKit::WebPage::layerHostingMode):

• ViewState moved to WebCore.

• WebProcess/WebPage/WebPage.messages.in:
  • Added SetLayerHostingMode message.
• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::viewStateDidChange):

• viewStateDidChange no longer calls setLayerHostingMode (this is called by WebPage).

11:20 AM Changeset in webkit [161356] by fpizlo@apple.com

• 5 edits in trunk/Source/JavaScriptCore

LLInt shouldn't check for ENABLE(JIT).

Rubber stamped by Mark Hahnenberg.

• llint/LLIntCommon.h:
• llint/LLIntOfflineAsmConfig.h:
• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::entryOSR):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

• llint/LowLevelInterpreter.asm:

11:19 AM Changeset in webkit [161355] by roger_fong@apple.com

• 2 edits in trunk/Tools

Set VSINSTALLDIR in win ews start script.
​https://bugs.webkit.org/show_bug.cgi?id=126407

Reviewed by Brent Fulgham.

• EWSTools/start-queue-win.sh:

11:01 AM Changeset in webkit [161354] by Martin Robinson

• 2 edits in trunk/Source/WebKit2

[GTK] [CMake] Parallel builds still fail when building WebKit2 GObject API unit tests
​https://bugs.webkit.org/show_bug.cgi?id=126465

Reviewed by Gustavo Noronha Silva.

• UIProcess/API/gtk/tests/CMakeLists.txt: Explicitly link the libWebKit2APITestCore static object against

WebKit2, which seems to be necessary on my new system. Also create an explicit dependency between the
injected bundle tests and WebKit2, because they need to use the generated headers.

10:56 AM Changeset in webkit [161353] by fpizlo@apple.com

• 4 edits in trunk/Source/JavaScriptCore

LLInt shouldnt check for ENABLE(JAVASCRIPT_DEBUGGER).

Rubber stamped by Mark Hahnenberg.

• debugger/Debugger.h:

(JSC::Debugger::Debugger):

• llint/LLIntOfflineAsmConfig.h:
• llint/LowLevelInterpreter.asm:

10:33 AM Changeset in webkit [161352] by Bem Jones-Bey

• 2 edits in trunk/Tools

Adding myself as a reviewer.

Unreviewed.

• Scripts/webkitpy/common/config/contributors.json:

10:33 AM Changeset in webkit [161351] by Martin Robinson

• 9 edits
  2 adds in trunk

[CMake] [GTK] Fix the build for the WebKitGTK+ developer configuration
​https://bugs.webkit.org/show_bug.cgi?id=126505

Reviewed by Gustavo Noronha Silva.

.:

• Source/cmake/FindGLIB.cmake: Add support for finding the gio-unix include directory location.
• Source/cmake/FindGUdev.cmake: Added.
• Source/cmake/FindGeoClue.cmake: Added.
• Source/cmake/OptionsGTK.cmake: When gamepad is enabled look for gio-unix and GUdev. When

geolocation is enabled look for GeoClue.

Source/WebCore:

• CMakeLists.txt: Add missing IDLS and source files to the lists.
• PlatformGTK.cmake: Add missing include directories and source files to the lists.

Use the GeoClue, GUdev, and gio-unix include paths and libraries and sort the list
of WebCore include directories.

• UseJSC.cmake: Align the sourced list with the contents of the bindings/js directory.

Source/WebKit:

• PlatformGTK.cmake: Add the geoclue platform directory to the include directory list.

10:25 AM Changeset in webkit [161350] by barraclough@apple.com

• 1 edit in trunk/Source/WebCore/ChangeLog

Refactor NSActivity handling code from ChildProcess to UserActivity
​https://bugs.webkit.org/show_bug.cgi?id=126330

Unreviewed speculative Windows build fix.

• WebCore.vcxproj/WebCore.vcxproj:
  • Added UserActivity.cpp/.h.

9:41 AM Changeset in webkit [161349] by mhahnenberg@apple.com

• 2 edits in trunk/Source/WTF

DoublyLinkedLists can't be concatenated
​https://bugs.webkit.org/show_bug.cgi?id=125976

Reviewed by Filip Pizlo.

• wtf/DoublyLinkedList.h:

(WTF::DoublyLinkedList<T>::append):

9:37 AM Changeset in webkit [161348] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[Win] Link error.
​https://bugs.webkit.org/show_bug.cgi?id=126526

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-01-06
Reviewed by Brent Fulgham.

• WebCore.vcxproj/WebCore.vcxproj: Include UserActivity files in build.
• WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.

9:22 AM Changeset in webkit [161347] by mrowe@apple.com

• 2 edits in trunk/Source/WebKit/mac

Mountain Lion build fix after r161332.

• Carbon/HIWebView.h: Mountain Lion's version of CF_AVAILABLE_MAC doesn't accept a message

argument so remove it.

8:29 AM Changeset in webkit [161346] by Lucas Forschler

• 5 edits in trunk/Source

Versioning.

8:25 AM Changeset in webkit [161345] by Lucas Forschler

• 1 copy in tags/Safari-538.11

New Tag.

7:23 AM Changeset in webkit [161344] by zandobersek@gmail.com

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

• platform/gtk/TestExpectations:

Mark accessibility/menu-list-sends-change-notification.html as flaky.

7:07 AM Changeset in webkit [161343] by thiago.lacerda@openbossa.org

• 2 edits in trunk/Source/WebCore

[Nix] Adding screenRect implementation to PlatformScreenNix
​https://bugs.webkit.org/show_bug.cgi?id=126231

Reviewed by Csaba Osztrogonác.

No new tests needed.

• platform/nix/PlatformScreenNix.cpp:

(WebCore::screenRect):

6:27 AM Changeset in webkit [161342] by thiago.lacerda@openbossa.org

• 5 edits in trunk/Source/WebCore

[Nix] Adding missing platform #ifs to WebCore files
​https://bugs.webkit.org/show_bug.cgi?id=126227

Reviewed by Csaba Osztrogonác.

No new tests needed.

• loader/EmptyClients.h:
• page/ChromeClient.h:
• page/DragController.cpp:

(WebCore::DragController::startDrag):

• platform/LocalizedStrings.h:

6:07 AM Changeset in webkit [161341] by zandobersek@gmail.com

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.
Adding failure expectations for the set of currently failing tests.

• platform/gtk/TestExpectations:

4:44 AM Changeset in webkit [161340] by zandobersek@gmail.com

• 2 edits in trunk/Tools

Unreviewed. Unbreaking JSC tests after r161328.

• Scripts/webkitdirs.pm:

(cmakeBasedPortName): Only recognize the GTK port as CMake-based if actually building
through the CMake build system (i.e. passing --gtkcmake to build-webkit).

3:22 AM Changeset in webkit [161339] by thiago.lacerda@openbossa.org

• 2 edits in trunk/Source/WebCore

[Nix] Adding new strings to LocalizedStringsNix
​https://bugs.webkit.org/show_bug.cgi?id=126228

Reviewed by Csaba Osztrogonác.

No new tests needed.

• platform/nix/LocalizedStringsNix.cpp:

(WebCore::submitButtonDefaultLabel):
(WebCore::inputElementAltText):
(WebCore::resetButtonDefaultLabel):
(WebCore::defaultDetailsSummaryText):
(WebCore::searchableIndexIntroduction):
(WebCore::fileButtonChooseFileLabel):
(WebCore::fileButtonChooseMultipleFilesLabel):
(WebCore::fileButtonNoFileSelectedLabel):
(WebCore::fileButtonNoFilesSelectedLabel):
(WebCore::contextMenuItemTagOpenLinkInNewWindow):
(WebCore::contextMenuItemTagDownloadLinkToDisk):
(WebCore::contextMenuItemTagCopyLinkToClipboard):
(WebCore::contextMenuItemTagOpenImageInNewWindow):
(WebCore::contextMenuItemTagDownloadImageToDisk):
(WebCore::contextMenuItemTagCopyImageToClipboard):
(WebCore::contextMenuItemTagCopyImageUrlToClipboard):
(WebCore::contextMenuItemTagOpenVideoInNewWindow):
(WebCore::contextMenuItemTagOpenAudioInNewWindow):
(WebCore::contextMenuItemTagDownloadVideoToDisk):
(WebCore::contextMenuItemTagDownloadAudioToDisk):
(WebCore::contextMenuItemTagCopyVideoLinkToClipboard):
(WebCore::contextMenuItemTagCopyAudioLinkToClipboard):
(WebCore::contextMenuItemTagToggleMediaControls):
(WebCore::contextMenuItemTagShowMediaControls):
(WebCore::contextMenuitemTagHideMediaControls):
(WebCore::contextMenuItemTagToggleMediaLoop):
(WebCore::contextMenuItemTagEnterVideoFullscreen):
(WebCore::contextMenuItemTagMediaPlay):
(WebCore::contextMenuItemTagMediaPause):
(WebCore::contextMenuItemTagMediaMute):
(WebCore::contextMenuItemTagOpenFrameInNewWindow):
(WebCore::contextMenuItemTagCopy):
(WebCore::contextMenuItemTagDelete):
(WebCore::contextMenuItemTagSelectAll):
(WebCore::contextMenuItemTagUnicode):
(WebCore::contextMenuItemTagInputMethods):
(WebCore::contextMenuItemTagGoBack):
(WebCore::contextMenuItemTagGoForward):
(WebCore::contextMenuItemTagStop):
(WebCore::contextMenuItemTagReload):
(WebCore::contextMenuItemTagCut):
(WebCore::contextMenuItemTagPaste):
(WebCore::contextMenuItemTagNoGuessesFound):
(WebCore::contextMenuItemTagIgnoreSpelling):
(WebCore::contextMenuItemTagLearnSpelling):
(WebCore::contextMenuItemTagSearchWeb):
(WebCore::contextMenuItemTagLookUpInDictionary):
(WebCore::contextMenuItemTagOpenLink):
(WebCore::contextMenuItemTagIgnoreGrammar):
(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):
(WebCore::contextMenuItemTagCheckSpelling):
(WebCore::contextMenuItemTagCheckSpellingWhileTyping):
(WebCore::contextMenuItemTagCheckGrammarWithSpelling):
(WebCore::contextMenuItemTagFontMenu):
(WebCore::contextMenuItemTagBold):
(WebCore::contextMenuItemTagItalic):
(WebCore::contextMenuItemTagUnderline):
(WebCore::contextMenuItemTagOutline):
(WebCore::contextMenuItemTagInspectElement):
(WebCore::contextMenuItemTagRightToLeft):
(WebCore::contextMenuItemTagLeftToRight):
(WebCore::contextMenuItemTagWritingDirectionMenu):
(WebCore::contextMenuItemTagTextDirectionMenu):
(WebCore::contextMenuItemTagDefaultDirection):
(WebCore::searchMenuNoRecentSearchesText):
(WebCore::searchMenuRecentSearchesText):
(WebCore::searchMenuClearRecentSearchesText):
(WebCore::AXDefinitionText):
(WebCore::AXDescriptionListText):
(WebCore::AXDescriptionListTermText):
(WebCore::AXDescriptionListDetailText):
(WebCore::AXFooterRoleDescriptionText):
(WebCore::AXSearchFieldCancelButtonText):
(WebCore::AXButtonActionVerb):
(WebCore::AXRadioButtonActionVerb):
(WebCore::AXTextFieldActionVerb):
(WebCore::AXCheckedCheckBoxActionVerb):
(WebCore::AXUncheckedCheckBoxActionVerb):
(WebCore::AXLinkActionVerb):
(WebCore::unknownFileSizeText):
(WebCore::imageTitle):
(WebCore::AXListItemActionVerb):
(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):
(WebCore::localizedMediaTimeDescription):
(WebCore::mediaElementLoadingStateText):
(WebCore::mediaElementLiveBroadcastStateText):
(WebCore::validationMessagePatternMismatchText):
(WebCore::validationMessageRangeOverflowText):
(WebCore::validationMessageRangeUnderflowText):
(WebCore::validationMessageStepMismatchText):
(WebCore::validationMessageTooLongText):
(WebCore::validationMessageTypeMismatchText):
(WebCore::validationMessageTypeMismatchForEmailText):
(WebCore::validationMessageTypeMismatchForMultipleEmailText):
(WebCore::validationMessageTypeMismatchForURLText):
(WebCore::validationMessageValueMissingText):
(WebCore::validationMessageValueMissingForCheckboxText):
(WebCore::validationMessageValueMissingForFileText):
(WebCore::validationMessageValueMissingForMultipleFileText):
(WebCore::validationMessageValueMissingForRadioText):
(WebCore::validationMessageValueMissingForSelectText):
(WebCore::validationMessageBadInputForNumberText):
(WebCore::missingPluginText):
(WebCore::AXMenuListPopupActionVerb):
(WebCore::AXMenuListActionVerb):
(WebCore::multipleFileUploadText):
(WebCore::crashedPluginText):
(WebCore::blockedPluginByContentSecurityPolicyText):
(WebCore::insecurePluginVersionText):
(WebCore::inactivePluginText):
(WebCore::unacceptableTLSCertificate):
(WebCore::textTrackClosedCaptionsText):
(WebCore::textTrackSubtitlesText):
(WebCore::textTrackOffMenuItemText):
(WebCore::textTrackAutomaticMenuItemText):
(WebCore::textTrackNoLabelText):
(WebCore::snapshottedPlugInLabelTitle):
(WebCore::snapshottedPlugInLabelSubtitle):

3:17 AM Changeset in webkit [161338] by commit-queue@webkit.org

• 37 edits in trunk/Source

Use unsigned consistently, and check for invalid casts when calling into SharedBuffer from other code.
​https://bugs.webkit.org/show_bug.cgi?id=124579

Patch by László Langó <​lango@inf.u-szeged.hu> on 2014-01-06
Reviewed by Anders Carlsson.

Source/WebCore:

• WebCore.exp.in:
• loader/NetscapePlugInStreamLoader.cpp:

(WebCore::NetscapePlugInStreamLoader::didReceiveData):

• loader/NetscapePlugInStreamLoader.h:
• loader/PingLoader.h:
• loader/ResourceBuffer.cpp:

(WebCore::ResourceBuffer::ResourceBuffer):

• loader/ResourceBuffer.h:

(WebCore::ResourceBuffer::create):

• loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::addDataOrBuffer):
(WebCore::ResourceLoader::didReceiveData):
(WebCore::ResourceLoader::didReceiveDataOrBuffer):
(WebCore::ResourceLoader::willStopBufferingData):

• loader/ResourceLoader.h:
• loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveData):

• loader/SubresourceLoader.h:
• loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didReceiveData):

• loader/appcache/ApplicationCacheGroup.h:
• loader/mac/ResourceLoaderMac.mm:

(WebCore::ResourceLoader::didReceiveDataArray):

• platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::SharedBuffer):

• platform/SharedBuffer.h:

(WebCore::SharedBuffer::create):

• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(ResourceHandleStreamingClient::didReceiveData):

• platform/network/BlobResourceHandle.cpp:
• platform/network/ResourceHandleClient.h:

(WebCore::ResourceHandleClient::didReceiveData):
(WebCore::ResourceHandleClient::willStopBufferingData):

• platform/network/SynchronousLoaderClient.cpp:

(WebCore::SynchronousLoaderClient::didReceiveData):

• platform/network/SynchronousLoaderClient.h:
• platform/network/blackberry/BlobStream.cpp:

(WebCore::BlobStream::didReceiveData):

• platform/network/blackberry/BlobStream.h:
• platform/network/blackberry/ResourceHandleBlackBerry.cpp:

(WebCore::WebCoreSynchronousLoader::didReceiveData):

• platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::WebCoreSynchronousLoader::didReceiveData):

• platform/network/mac/WebCoreResourceHandleAsDelegate.mm:

(-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):

• platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willStopBufferingData:]):

• platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::WebCoreSynchronousLoader::didReceiveData):

• platform/network/win/ResourceHandleWin.cpp:

(WebCore::WebCoreSynchronousLoader::didReceiveData):

Source/WebKit/gtk:

• webkit/webkitdownload.cpp:

(DownloadClient::didReceiveData):

Source/WebKit/win:

• WebKitDLL.cpp:

(loadResourceIntoBuffer):

Source/WebKit2:

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveData):
(WebKit::NetworkResourceLoader::willStopBufferingData):

• NetworkProcess/NetworkResourceLoader.h:
• Shared/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::didReceiveData):

2:39 AM Changeset in webkit [161337] by akling@apple.com

• 4 edits in trunk/Source/WebCore

RenderBlock::clone() should return RenderPtr.
<​https://webkit.org/b/126513>

Reviewed by Antti Koivisto.

• rendering/RenderBlock.h:
• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clone):

Tweaked to return RenderPtr<RenderBlock>.

(WebCore::RenderBlock::splitBlocks):

Store cloned RenderBlocks in RenderPtrs. Use leakPtr() to sink
them into ownership-taking APIs that still use raw pointers.

• rendering/RenderPtr.h:

Add a simple static_pointer_cast for RenderPtr&&.

1:49 AM Changeset in webkit [161336] by akling@apple.com

• 1 edit in trunk/Source/WebCore/ChangeLog

Fix ChangeLog authors that got mixed up in last commit.

1:47 AM Changeset in webkit [161335] by akling@apple.com

• 3 edits in trunk/Source/WebCore

RenderInline::clone() should return RenderPtr.
<​https://webkit.org/b/126514>

Patch by Gurpreet Kaur <​k.gurpreet@samsung.com> on 2014-01-06
Reviewed by Antti Koivisto.

• rendering/RenderInline.h:
• rendering/RenderInline.cpp:

(WebCore::RenderInline::clone):

Tweaked to return RenderPtr<RenderInline>.

(WebCore::RenderInline::splitInlines):

Store cloned RenderInlines in RenderPtrs. Use leakPtr() to sink
them into ownership-taking APIs that still use raw pointers.

1:04 AM Changeset in webkit [161334] by commit-queue@webkit.org

• 3 edits
  3 adds in trunk

<hr> appears gray instead of green because of color attribute is defined followed by noshade attribute
​https://bugs.webkit.org/show_bug.cgi?id=17674

Patch by Gurpreet Kaur <​k.gurpreet@samsung.com> on 2014-01-06
Reviewed by Simon Fraser.

Source/WebCore:

The noshade attribute is a boolean attribute and when set on hr element
it shows a gray color. When there is color attribute the default gray
color should be replaced by the color mentioned by the color attribute.
Firefox and IE show the same behaviour but Webkit is different. Making
the behaviour of Webkit similiar to Firefox and IE's behaviour.

Test: fast/dom/HTMLHrElement/hr-color-noshade-attribute.html

• html/HTMLHRElement.cpp:

(WebCore::HTMLHRElement::collectStyleForPresentationAttribute):
When the color attribute is present that value is applied and the
default gray color is ignored. Incase of no color attribute the default
gray color is applied.

LayoutTests:

• fast/dom/HTMLHrElement: Added.
• fast/dom/HTMLHrElement/hr-color-noshade-attribute-expected.txt: Added.
• fast/dom/HTMLHrElement/hr-color-noshade-attribute.html: Added.

Added new test cases to test the functionality of noshade and color
attribute of hr element when color attribute is present along with
noshade attribute, invalid color attribute and color noshade attributes
added via javascript.

12:56 AM Changeset in webkit [161333] by zandobersek@gmail.com

• 2 edits in trunk

[GTK] Use libc++ for C++11 on darwin
​https://bugs.webkit.org/show_bug.cgi?id=126325

Reviewed by Martin Robinson.

• Source/autotools/SetupCompilerFlags.m4: Don't default to libstdc++ when compiling with Clang.

Instead, the compiler should determine itself what standard library to use, except on Darwin,
where libc++ should be enforced. The standard library of user's choosing can still be enforced
through the CXXFLAGS environment variable.

12:15 AM Changeset in webkit [161332] by mrowe@apple.com

• 13 edits
  2 adds in trunk/Source

<​https://webkit.org/b/126499> Move WebKit off the legacy WebKit availability macros

The legacy WebKit availability macros are verbose, confusing, and provide no benefit
over using the system availability macros directly. The original vision was that
they'd serve a cross-platform purpose but that never came to be.

Since WebKit1 is API on OS X but SPI on iOS, some indirection is still needed in the
availability macros to allow the headers to advertise the API as unavailable on OS X
without interfering with the ability to build on iOS. This is achieved by defining
WEBKIT-prefixed versions of the Foundation availability macros that are defined to
their NS-prefixed equivalents. The installed headers are post-processed to map these
macros back to their Foundation equivalents.

Part of <rdar://problem/15512304>.

Source/WebCore:

Reviewed by Sam Weinig.

• WebCore.xcodeproj/project.pbxproj:
• bindings/objc/WebKitAvailability.h: Added. This lives at the WebCore level since it

will be needed by the Objective-C DOM bindings.

Source/WebKit:

Reviewed by Sam Weinig.

• WebKit.xcodeproj/project.pbxproj: Change the Postprocess Headers build phase to

invoke mac/postprocess-headers.sh.

Source/WebKit/mac:

The OS X version used in the new availability macros is based on the mapping in
JavaScriptCore/WebKitAvailability.h.

Reviewed by Sam Weinig.

• Carbon/CarbonUtils.h:
• Carbon/HIWebView.h:
• MigrateHeaders.make: Migrate WebKitAvailability.h from WebCore as an API header.
• Plugins/WebPlugin.h:
• Plugins/WebPluginViewFactory.h:
• WebView/WebFrameLoadDelegate.h:
• WebView/WebResourceLoadDelegatePrivate.h:
• WebView/WebUIDelegate.h:
• postprocess-headers.sh: Added. Extracted from the Xcode project. Extended to map the

WEBKIT-prefixed macros to their NS-prefixed equivalents on OS X and to remove them on iOS.

Jan 5, 2014:

11:54 PM Changeset in webkit [161331] by jinwoo7.song@samsung.com

• 4 edits in trunk/Source/WebKit/efl

[EFL] Fix failing WebKit1 API test of ewk_view_setting_tiled_backing_store
​https://bugs.webkit.org/show_bug.cgi?id=126509

Reviewed by Gyuyoung Kim.

In WebKit1 EFL port, unit test was using a webview based on tiled backing store,
so ewk_view_setting_tiled_backing_store_enabled_set() was set as true as default.
As we do not need to use tiled backing store, we disable tiled backing store
and remove unnecessary EwkViewType in unit test webview.

• tests/UnitTestUtils/EWKTestView.cpp:

(EWKUnitTests::EWKTestView::init):

• tests/UnitTestUtils/EWKTestView.h:
• tests/test_ewk_view.cpp: Fix wrong comment in the unit test.

8:18 PM Changeset in webkit [161330] by weinig@apple.com

• 6 edits in trunk

[JS] Implement Promise.race()
​https://bugs.webkit.org/show_bug.cgi?id=126506

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

• runtime/CommonIdentifiers.h:

Add identifier for "cast".

• runtime/JSPromiseConstructor.cpp:

(JSC::abruptRejection):
Helper for the RejectIfAbrupt abstract operation.

(JSC::JSPromiseConstructorFuncRace):
Add implementation of Promise.race()

LayoutTests:

Enabled and fix the existing Promise.race() test case.

• Promise.race() and Promise.race({}) should reject by my reading of the spec.

• js/dom/Promise-static-race-expected.txt:
• js/dom/Promise-static-race.html:

8:09 PM Changeset in webkit [161329] by Simon Fraser

• 3 edits in trunk/Source/WebKit2

Add encoding of ViewportConstraint and ScrollingParameter types
​https://bugs.webkit.org/show_bug.cgi?id=126497

Reviewed by Andreas Kling.

Add encoding/decoding of ScrollableAreaParameters, FixedPositionViewportConstraints
and StickyPositionViewportConstraints.

• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<WebCore::ScrollableAreaParameters>::encode):
(IPC::ArgumentCoder<WebCore::ScrollableAreaParameters>::decode):
(IPC::ArgumentCoder<WebCore::FixedPositionViewportConstraints>::encode):
(IPC::ArgumentCoder<WebCore::FixedPositionViewportConstraints>::decode):
(IPC::ArgumentCoder<WebCore::StickyPositionViewportConstraints>::encode):
(IPC::ArgumentCoder<WebCore::StickyPositionViewportConstraints>::decode):

• Shared/WebCoreArgumentCoders.h:

8:09 PM Changeset in webkit [161328] by Martin Robinson

• 3 edits in trunk/Tools

[GTK][CMake] Add support for building the GTK+ port with cmake to build-webkit
​https://bugs.webkit.org/show_bug.cgi?id=126212

Reviewed by Daniel Bates.

Allow building the GTK+ cmake port with --gtkcmake.

• Scripts/build-webkit: Use the new isGtkCMake function to head down the CMake path

when appropriate. Skip the autotoos path when isGtkAutotools is false.

• Scripts/webkitdirs.pm: Add an isGtkCMake path in addition to the newly renamed isGtkAutotools.

Add isGtk which checks isGtkCMake

isGtkAutotools

(determineArchitecture): Use the CMake path for GTK+ when appropriate.
(argumentsForConfiguration): use --gtkcmake when appropriate.
(jscProductDir): Look in the CMake directory when appropriate.
(builtDylibPathForName): CMake builds the library into a different directory, so handle that.
(determineIsGtkCMake): Added.
(isGtkCMake): Added.
(isGtkAutotools): Renamed from isGtk.

(isGtk): New function which returns isGtkAutotools

isGtkCMake.

(determineIsGtkAutotools): Renamed from determineIsGtk.
(cmakeBasedPortName): Added a GTK+ path.

8:08 PM Changeset in webkit [161327] by Simon Fraser

• 17 edits
  1 move in trunk/Source

Move responsibility for remote layer tree committing to RemoteLayerTreeDrawingArea
​https://bugs.webkit.org/show_bug.cgi?id=126501

Source/WebCore:

Reviewed by Sam Weinig.

Add type-safe casting to GraphicsLayer.

• platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::isGraphicsLayerCA):
(WebCore::GraphicsLayer::isGraphicsLayerCARemote):

• platform/graphics/ca/GraphicsLayerCA.h:

(WebCore::GraphicsLayerCA::isGraphicsLayerCA):

Source/WebKit2:

Reviewed by Sam Weinig.

Soon we shall need to do atomic commits of both the remote layer tree, and
the remote scrolling tree. Pave the way by moving responsibility for remote
layer tree committing to RemoteLayerTreeDrawingArea.

So move the flushing logic from RemoteLayerTreeHost to RemoteLayerTreeDrawingArea.
After this change, RemoteLayerTreeHost doesn't do much and could possibly be
removed in future.

Also add type-safe casting to GraphicsLayer and DrawingArea.

• DerivedSources.make: Out with RemoteLayerTreeHost, in with RemoteLayerTreeDrawingAreaProxy
• UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:

(WebKit::RemoteLayerTreeDrawingAreaProxy::remoteLayerTreeHost):

• UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.messages.in: Renamed from Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.messages.in.
• UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::RemoteLayerTreeDrawingAreaProxy): Add message receiver.
(WebKit::RemoteLayerTreeDrawingAreaProxy::~RemoteLayerTreeDrawingAreaProxy): Remove message receiver.
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree): Hand the transaction off to the layer
tree host.

• UIProcess/mac/RemoteLayerTreeHost.h:
• UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::RemoteLayerTreeHost): No longer a message receiver.
(WebKit::RemoteLayerTreeHost::~RemoteLayerTreeHost):
(WebKit::RemoteLayerTreeHost::updateLayerTree):

• WebKit2.xcodeproj/project.pbxproj:
• WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::type):

• WebProcess/WebPage/mac/GraphicsLayerCARemote.h:
• WebProcess/WebPage/mac/PlatformCALayerRemote.h:
• WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
• WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::RemoteLayerTreeContext):
(WebKit::RemoteLayerTreeContext::flushOutOfTreeLayers):
(WebKit::RemoteLayerTreeContext::buildTransaction):

• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::setRootCompositingLayer):
(WebKit::RemoteLayerTreeDrawingArea::setLayerTreeStateIsFrozen):
(WebKit::RemoteLayerTreeDrawingArea::forceRepaint):
(WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlush):
(WebKit::RemoteLayerTreeDrawingArea::layerFlushTimerFired):
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):

5:29 PM Changeset in webkit [161326] by msaboff@apple.com

• 2 edits in branches/jsCStack/Source/JavaScriptCore

CStack Branch: ARM64 Fix other prologue and epilogue macros in LLInt
​https://bugs.webkit.org/show_bug.cgi?id=126507

Reviewed by Mark Lam.

Fixed preserveCallerPCAndCFR() and restoreCallerPCAndCFR() for ARM64. Fixed
functionPrologue() so that the new callframe is set up from the stack pointer.

• llint/LowLevelInterpreter.asm:

4:25 PM Changeset in webkit [161325] by Martin Robinson

• 13 edits in trunk

[GTK] [CMake] Ensure that the autotools build and the CMake install the same files
​https://bugs.webkit.org/show_bug.cgi?id=116379

Reviewed by Gustavo Noronha Silva.

.:

• Source/PlatformGTK.cmake: Install the documentation.
• Source/cmake/OptionsCommon.cmake: Add a LIBEXEC variable for WebKit2 executables, and

don't use the default locations on GTK+. We will get them from the CMake-provided GNU installation
variables.

• Source/cmake/OptionsGTK.cmake: Setup the installation variables using the ones provided

by CMake's GNU installation directory support. Fix the definition of DATADIR. Always install
the jsc binary.

Source/JavaScriptCore:

• PlatformGTK.cmake: Install API headers, gir files, and the pkg-config file.

Source/WebCore:

• PlatformGTK.cmake: Reformat some install directives to be consistent with the rest of them.

Install the GObject DOM bindings headers.

Source/WebKit:

• PlatformGTK.cmake: Install API headers, gir files, and the pkg-config file. Move

a couple installed and generated headers to the installed headers list.

Source/WebKit2:

• CMakeLists.txt: Install the plugin process to the new LIBEXEC directory, which

for non-GTK+ platforms is the same as EXEC.

• PlatformGTK.cmake: Install API headers, gir files, and the pkg-config file. Move

a couple installed and generated headers to the installed headers list. Rename the
headers list to be consistent with the WebKit1 build. No longer use a variable for
the name of the plugin process, as it's unnecessary.

11:17 AM Changeset in webkit [161324] by Gustavo Noronha Silva

• 2 edits in trunk/Source/WebCore/platform/gtk/po

[GTK] Updated Dutch translation
​https://bugs.webkit.org/show_bug.cgi?id=126365

Patch by Reinout van Schouwen <​reinouts@gnome.org> on 2014-01-05
Reviewed by Gustavo Noronha.

• nl.po: Updated.

3:45 AM Changeset in webkit [161323] by akling@apple.com

• 4 edits in trunk/Source/WebCore

Use lineageOfType to simplify two rendering helpers.
<​https://webkit.org/b/126498>

Reviewed by Antti Koivisto.

• rendering/RenderRuby.cpp:

(WebCore::findRubyRunParent):

• rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::findTreeRootObject):

Simplify two functions that walk their parent chain to find the
closest ancestor of a certain type.

• rendering/RenderRubyRun.h:

Add requisite isRendererOfType<RenderRubyRun>().

2:34 AM Changeset in webkit [161322] by Carlos Garcia Campos

• 5 edits in trunk

[GTK] Stop installing WebKit2 C API headers
​https://bugs.webkit.org/show_bug.cgi?id=126489

Reviewed by Martin Robinson.

.:

• GNUmakefile.am:

Source/WebKit2:

We are not actually maintaining the API/ABI compatibility of the
WebKit2 C API, it's only used internally by the public GTK+ API
and nobody is using it.

• GNUmakefile.am:
• GNUmakefile.list.am:

1:46 AM Changeset in webkit [161321] by Csaba Osztrogonác

• 2 edits in trunk/Source/WebCore

Fix the Mac build too.

• page/PageThrottler.h:

1:27 AM Changeset in webkit [161320] by Csaba Osztrogonác

• 2 edits in trunk/Source/WebCore

Weekend URTBF after r161319 to make non Mac builds work again.

• page/PageThrottler.h:

12:28 AM Changeset in webkit [161319] by barraclough@apple.com

• 13 edits in trunk/Source

Move process suppression of WebProcess to Page (from UIProcess)
​https://bugs.webkit.org/show_bug.cgi?id=126480

Reviewed by Sam Weinig.

Let each page take a UserActivity rather than having to coalesce this state, and take different activity
tokens for normal visibility and suppression disabled, so we can see why the process is not suppressed.

Source/WebCore:

• WebCore.exp.in:
• page/Page.cpp:

(WebCore::Page::setIsVisuallyIdle):

• page/Page.h:
  • setThrottled -> setIsVisuallyIdle.
• page/PageThrottler.cpp:

(WebCore::PageThrottler::PageThrottler):

• Initialize m_visuallyNonIdle.

(WebCore::PageThrottler::~PageThrottler):

• setThrottled -> setIsVisuallyIdle.

(WebCore::PageThrottler::setIsVisuallyIdle):

• Use m_visuallyNonIdle to disable supression when the page is not visually idle.

• page/PageThrottler.h:
  • setThrottled -> setIsVisuallyIdle, added m_visuallyNonIdle.

Source/WebKit2:

• Shared/mac/ChildProcessMac.mm:

(WebKit::ChildProcess::platformInitialize):

• Don't start with process supression disabled; this is unnecessary, message from the UIProcess should wake.

• UIProcess/mac/WebProcessProxyMac.mm:

(WebKit::WebProcessProxy::updateProcessSuppressionState):

• Don't send explicit messages to supress the WebProcess, it handles this for itself.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

• call setIsVisuallyIdle.

(WebKit::WebPage::setViewState):

• call setIsVisuallyIdle.

(WebKit::WebPage::updatePreferences):

• Use m_suppressionDisabled to disable supression if the WebPreference is set.

(WebKit::WebPage::setIsVisuallyIdle):

• setThrottled -> setIsVisuallyIdle.

• WebProcess/WebPage/WebPage.h:
  • setThrottled -> setIsVisuallyIdle, added m_suppressionDisabled.
• WebProcess/WebProcess.cpp:
• WebProcess/WebProcess.h:

(WebKit::WebProcess::shouldForceScreenFontSubstitution):

• Removed setProcessSuppressionEnabled - WebPage now detects the supression change.