⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 10, 2014:

11:43 PM Changeset in webkit [161754] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Fix build for HTMLImageElement::willRespondToMouseClickEvents()

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::willRespondToMouseClickEvents):

11:38 PM Changeset in webkit [161753] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix test crashes.

  • loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::~ProgressTracker):
Comment out the call to progressTrackerDestroyed for now.

11:34 PM Changeset in webkit [161752] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Fix build for RenderEmbeddedObject::canHaveChildren()

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::canHaveChildren):

11:33 PM Changeset in webkit [161751] by andersca@apple.com
  • 19 edits in trunk/Source

Tweak ProgressTrackerClient functions
https://bugs.webkit.org/show_bug.cgi?id=126808

Reviewed by Sam Weinig.

Source/WebCore:

Rename the three progress state related member functions since it's up to the various
WebKit implementations to decide what to do - not everyone wants to post a notification.
Also add an originating progress frame parameter since WebKit2 doesn't report progress for
subframe navigation and we need to be able to keep track of that.

Finally, tweak ProgressTracker::completeProgress to get rid of an unnecessary hash lookup.

  • loader/EmptyClients.h:
  • loader/ProgressTracker.cpp:

(WebCore::ProgressItem::ProgressItem):
(WebCore::ProgressTracker::progressStarted):
(WebCore::ProgressTracker::finalProgressComplete):
(WebCore::ProgressTracker::incrementProgress):
(WebCore::ProgressTracker::completeProgress):

  • loader/ProgressTrackerClient.h:

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::progressStarted):
(WebCore::FrameLoaderClientEfl::progressEstimateChanged):
(WebCore::FrameLoaderClientEfl::progressFinished):

  • WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::progressStarted):
(WebKit::FrameLoaderClient::progressEstimateChanged):
(WebKit::FrameLoaderClient::progressFinished):

  • WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::progressStarted):
(WebFrameLoaderClient::progressEstimateChanged):
(WebFrameLoaderClient::progressFinished):

Source/WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::progressStarted):
(WebFrameLoaderClient::progressEstimateChanged):
(WebFrameLoaderClient::progressFinished):

  • WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::progressStarted):
(WebKit::WebFrameLoaderClient::progressEstimateChanged):
(WebKit::WebFrameLoaderClient::progressFinished):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
11:27 PM Changeset in webkit [161750] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Fix COMPILE_ASSERT by updating struct SameSizeAsStyleRareInheritedData

  • rendering/style/StyleRareInheritedData.cpp:
11:05 PM Changeset in webkit [161749] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Fix build of SubframeLoader.cpp

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):
(WebCore::SubframeLoader::loadPlugin):

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
10:56 PM Changeset in webkit [161748] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix Mac after r161747. One part of that is iOS specific.

Unreviewed build fix.

  • bindings/js/GCController.cpp:

(WebCore::GCController::releaseExecutableMemory):

10:53 PM Changeset in webkit [161747] by Joseph Pecoraro
  • 3 edits in trunk/Source/WebCore

[iOS] Fix GCController::releaseExecutableMemory
https://bugs.webkit.org/show_bug.cgi?id=126805

Reviewed by Sam Weinig and Mark Lam.

VM::dynamicGlobalObject has since been replaced by VMEntryScope.
Update to check entryScope instead of the dynamicGlobalObject.
Also, make this non-iOS only.

  • bindings/js/GCController.h:
  • bindings/js/GCController.cpp:

(WebCore::GCController::releaseExecutableMemory):

10:41 PM Changeset in webkit [161746] by Joseph Pecoraro
  • 3 edits in trunk/Source/WebCore

Fix HTMLMediaElement.o for iOS. Unreviewed build fix.

There is now local variable mediaElement. Just call the
functions since they are methods on this class.

Fix RequireUserGestureToShowPlaybackTargetPickerRestriction typos.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

10:33 PM Changeset in webkit [161745] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Convert HandleMessage.h to use variadic templates
https://bugs.webkit.org/show_bug.cgi?id=126469

Reviewed by Anders Carlsson.

  • Platform/IPC/HandleMessage.h:

(IPC::callMemberFunctionImpl):
(IPC::callMemberFunction):
Replace massive copy and pasted code with variadic magic.

10:33 PM Changeset in webkit [161744] by andersca@apple.com
  • 27 edits
    1 add in trunk/Source

Move progress tracking functions from FrameLoaderClient to a new ProgressTrackerClient
https://bugs.webkit.org/show_bug.cgi?id=126801

Reviewed by Sam Weinig.

Source/WebCore:

  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/EmptyClients.cpp:

(WebCore::fillWithEmptyClients):

  • loader/EmptyClients.h:
  • loader/FrameLoaderClient.h:
  • loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::ProgressTracker):
(WebCore::ProgressTracker::~ProgressTracker):
(WebCore::ProgressTracker::progressStarted):
(WebCore::ProgressTracker::progressCompleted):
(WebCore::ProgressTracker::finalProgressComplete):
(WebCore::ProgressTracker::incrementProgress):

  • loader/ProgressTracker.h:
  • loader/ProgressTrackerClient.h: Added.

(WebCore::ProgressTrackerClient::~ProgressTrackerClient):
(WebCore::ProgressTrackerClient::progressTrackerDestroyed):
(WebCore::ProgressTrackerClient::willChangeEstimatedProgress):
(WebCore::ProgressTrackerClient::didChangeEstimatedProgress):

  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::PageClients::PageClients):

  • page/Page.h:

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.h:
  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.h:
  • webkit/webkitwebview.cpp:

(webkit_web_view_init):

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):

Source/WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebView.cpp:

(WebView::initWithFrame):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

10:18 PM Changeset in webkit [161743] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix RenderObject.o for iOS. Unreviewed build fix.

r156285 renamed firstChild() to firstChildSlow(), so update
occurances in IOS_TEXT_AUTOSIZING code. Also account for a
RenderObject::style reference / pointer change.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::traverseNext):
(WebCore::includeNonFixedHeight):

10:08 PM Changeset in webkit [161742] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix MediaPlayerPrivateMediaSourceAVFObjC.o for iOS. Unreviewed build fix.

Import CALayer, which Mac must have been getting some other way.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
10:02 PM Changeset in webkit [161741] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix TileGrid.o for iOS. Unreviewed build fix.

Explicitly use namespace std in std::pair.

  • platform/ios/TileGrid.mm:

(WebCore::isFartherAway):
(WebCore::TileGrid::dropDistantTiles):

9:59 PM Changeset in webkit [161740] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix RenderImage.o for iOS. Unreviewed build fix.

inlineBoxWrapper() returns an InlineElementBox type, which is an InlineBox but
without including InlineElementBox.h, iOS didn't know what an InlineElementBox was!

  • rendering/RenderImage.cpp:
9:53 PM Changeset in webkit [161739] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Fix macros in Scrollbar::supportsUpdateOnSecondaryThread()

Fixes the following build error:

WebCore/platform/Scrollbar.cpp:552:22: error: 'MAC_OS_X_VERSION_MIN_REQUIRED' is not defined, evaluates to 0 [-Werror,-Wundef]
#if PLATFORM(MAC) &&
MAC_OS_X_VERSION_MIN_REQUIRED >= 101000 && ENABLE(ASYNC_SCROLLING)


  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::supportsUpdateOnSecondaryThread):

9:50 PM Changeset in webkit [161738] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix RenderFileUploadControl.o for iOS. Unreviewed build fix.

WebCore::theme() returns a reference now, not a pointer.

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject):

9:48 PM Changeset in webkit [161737] by fpizlo@apple.com
  • 12 edits in branches/jsCStack

FTL should work with the bytecode profiler
https://bugs.webkit.org/show_bug.cgi?id=126804

Source/JavaScriptCore:

Reviewed by Sam Weinig.

Implement CountExecution in FTL and make the FTL report a compilation with some kind
of description to the database. This still leaves a lot to be desired; for example
the descriptions we report don't have disassembly. But, this small step already
allows for some basic profiling.

  • dfg/DFGPlan.cpp:

(JSC::DFG::profilerCompilationKindForMode):
(JSC::DFG::Plan::Plan):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLJITFinalizer.cpp:

(JSC::FTL::JITFinalizer::finalizeFunction):

  • ftl/FTLLink.cpp:

(JSC::FTL::link):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCountExecution):

  • profiler/ProfilerCompilation.cpp:

(JSC::Profiler::Compilation::addDescription):

  • profiler/ProfilerCompilation.h:
  • profiler/ProfilerCompilationKind.cpp:

(WTF::printInternal):

  • profiler/ProfilerCompilationKind.h:

Tools:

Reviewed by Sam Weinig.

Teach this that there are more JITs.

  • Scripts/display-profiler-output:
9:45 PM Changeset in webkit [161736] by Joseph Pecoraro
  • 2 edits
    2 adds in trunk/Source/WebCore

Fix HTMLPlugInImageElement.o for iOS. Unreviewed build fix.

Forgot to upstream YouTubeEmbedShadowElement.*. Do so and
add the files to the Xcode project so they build.

  • WebCore.xcodeproj/project.pbxproj:
  • html/shadow/YouTubeEmbedShadowElement.cpp: Added.

(WebCore::YouTubeEmbedShadowElement::create):
(WebCore::YouTubeEmbedShadowElement::YouTubeEmbedShadowElement):
(WebCore::YouTubeEmbedShadowElement::pluginElement):
(WebCore::YouTubeEmbedShadowElement::shadowPseudoId):

  • html/shadow/YouTubeEmbedShadowElement.h: Added.
9:34 PM Changeset in webkit [161735] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Update EditorIOS.mm to switch from pointers to references

  • editing/ios/EditorIOS.mm:

(WebCore::Editor::setTextAlignmentForChangedBaseWritingDirection):
(WebCore::Editor::insertParagraphSeparatorInQuotedContent):
(WebCore::styleForSelectionStart):
(WebCore::Editor::selectionInWebArchiveFormat):
(WebCore::Editor::writeImageToPasteboard):
(WebCore::Editor::WebContentReader::readWebArchive):
(WebCore::Editor::WebContentReader::readRTFD):
(WebCore::Editor::WebContentReader::readRTF):
(WebCore::uniqueURLWithRelativePart):
(WebCore::Editor::WebContentReader::readPlainText):
(WebCore::Editor::webContentFromPasteboard):
(WebCore::Editor::createFragmentAndAddResources):
(WebCore::Editor::createFragmentForImageResourceAndAddResource):

9:33 PM Changeset in webkit [161734] by fpizlo@apple.com
  • 3 edits in branches/jsCStack/Source/JavaScriptCore

Unreviewed, unbreak all tests by undoing some assertions junk in
http://trac.webkit.org/changeset/161732 and changing typo "node->function()"
which should have been "node->executable()".

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileCheckExecutable):

  • runtime/Options.cpp:

(JSC::recomputeDependentOptions):
(JSC::Options::initialize):

9:18 PM Changeset in webkit [161733] by Joseph Pecoraro
  • 27 edits
    2 moves
    5 adds in trunk/Source

Web Inspector: Push InspectorAgent down into JSC, give JSC an InspectorController
https://bugs.webkit.org/show_bug.cgi?id=126763

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Introduce JSGlobalObjectInspectorController. This is the InspectorController
for a JSContext. It is created by the JSGlobalObject Remote Inspector Debuggable
when a remote frontend connects, and is destroyed when the remote frontend
disconnects of the JSGlobalObject is destroyed.

  • inspector/JSGlobalObjectInspectorController.h: Added.
  • inspector/JSGlobalObjectInspectorController.cpp: Added.

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::~JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::connectFrontend):
(Inspector::JSGlobalObjectInspectorController::disconnectFrontend):
(Inspector::JSGlobalObjectInspectorController::dispatchMessageFromFrontend):
(Inspector::JSGlobalObjectInspectorController::functionCallHandler):
(Inspector::JSGlobalObjectInspectorController::evaluateHandler):
Create/destory agents, create/destroy dispatches, implement InspectorEnvironment.

  • runtime/JSGlobalObjectDebuggable.h:
  • runtime/JSGlobalObjectDebuggable.cpp:

(JSC::JSGlobalObjectDebuggable::~JSGlobalObjectDebuggable):
(JSC::JSGlobalObjectDebuggable::connect):
(JSC::JSGlobalObjectDebuggable::disconnect):
(JSC::JSGlobalObjectDebuggable::dispatchMessageFromRemoteFrontend):
Forward actions to the InspectorController object.

  • inspector/agents/InspectorAgent.h: Renamed from Source/WebCore/inspector/InspectorAgent.h.
  • inspector/agents/InspectorAgent.cpp: Renamed from Source/WebCore/inspector/InspectorAgent.cpp.

(Inspector::InspectorAgent::InspectorAgent):
(Inspector::InspectorAgent::~InspectorAgent):
(Inspector::InspectorAgent::didCreateFrontendAndBackend):
(Inspector::InspectorAgent::inspect):
(Inspector::InspectorAgent::evaluateForTestInFrontend):
Implement InspectorAgent in JavaScriptCore in namespace Inspector.

Add files and new inspector/agents subdirectory.

Source/WebCore:

No new tests, no observable change in functionality.

  • CMakeLists.txt:
  • ForwardingHeaders/inspector/InspectorAgent.h: Added.
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorAllInOne.cpp:

InspectorAgent moved to JavaScriptCore.

  • inspector/PageConsoleAgent.cpp:

(WebCore::PageConsoleAgent::PageConsoleAgent):
(WebCore::PageConsoleAgent::~PageConsoleAgent):

  • inspector/PageConsoleAgent.h:

(WebCore::PageConsoleAgent::create):

  • inspector/InspectorApplicationCacheAgent.cpp:
  • inspector/InspectorApplicationCacheAgent.h:

InspectorAgent was not used by these files, remove it.

  • inspector/CommandLineAPIHost.cpp:
  • inspector/CommandLineAPIHost.h:

(WebCore::CommandLineAPIHost::init):

  • inspector/InspectorInstrumentation.cpp:
  • inspector/InstrumentingAgents.h:

(WebCore::InstrumentingAgents::inspectorAgent):
(WebCore::InstrumentingAgents::setInspectorAgent):
Switch to Inspector::InspectorAgent where applicable.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorController.h:

Manually add InspectorAgent to the InstrumentingAgents. It is one
of the agents that is always available in InstrumentingAgents.

9:06 PM Changeset in webkit [161732] by fpizlo@apple.com
  • 6 edits
    1 add in branches/jsCStack/Source/JavaScriptCore

FTL should enough things to compile inlined closure calls (like CheckExecutable and GetScope)
https://bugs.webkit.org/show_bug.cgi?id=126799

Reviewed by Oliver Hunt.

Added FTL support for CheckExecutable and GetScope because I wanted to compile
closure calls. But then I realized that closure call inlining was broken because
the baseline JIT would link the closure stubs to the slow path, thereby causing
the DFG's profiling to think that all closure calls are actually virtual calls.

Also fixed some hash() computing stuff to make debugging easier.

  • ftl/FTLAbstractHeapRepository.h:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCheckExecutable):
(JSC::FTL::LowerDFGToLLVM::compileGetScope):

  • jit/Repatch.cpp:

(JSC::linkClosureCall):

  • runtime/Options.cpp:

(JSC::recomputeDependentOptions):
(JSC::Options::initialize):
(JSC::Options::setOption):

  • tests/stress/inline-closure-call.js: Added.

(bar):

9:02 PM Changeset in webkit [161731] by Simon Fraser
  • 3 edits
    2 adds in trunk/Source/WebCore

Add TextAutoSizing.* for iOS, and fix DeviceOrientationController creation.

  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::Document):

  • rendering/TextAutoSizing.cpp: Added.

(WebCore::cloneRenderStyleWithState):
(WebCore::TextAutoSizingKey::TextAutoSizingKey):
(WebCore::TextAutoSizingKey::~TextAutoSizingKey):
(WebCore::TextAutoSizingKey::operator=):
(WebCore::TextAutoSizingKey::ref):
(WebCore::TextAutoSizingKey::deref):
(WebCore::TextAutoSizingValue::numNodes):
(WebCore::TextAutoSizingValue::addNode):
(WebCore::TextAutoSizingValue::adjustNodeSizes):
(WebCore::TextAutoSizingValue::reset):

  • rendering/TextAutoSizing.h: Added.

(WebCore::TextAutoSizingKey::doc):
(WebCore::TextAutoSizingKey::style):
(WebCore::TextAutoSizingKey::isValidDoc):
(WebCore::TextAutoSizingKey::isValidStyle):
(WebCore::TextAutoSizingKey::deletedKeyDoc):
(WebCore::TextAutoSizingKey::deletedKeyStyle):
(WebCore::operator==):
(WebCore::TextAutoSizingHash::hash):
(WebCore::TextAutoSizingHash::equal):
(WebCore::TextAutoSizingValue::create):
(WebCore::TextAutoSizingValue::TextAutoSizingValue):

8:44 PM Changeset in webkit [161730] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix GraphicsLayerCA.o for iOS. Unreviewed build fix.

Use of systemMemoryLevel was missing include of SystemMemory.h.

  • platform/graphics/ca/GraphicsLayerCA.cpp:
8:41 PM Changeset in webkit [161729] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Fix iOS build.

  • bindings/objc/DOM.mm:

(-[DOMRange renderedImageForcingBlackText:renderedImageForcingBlackText:]):

  • bindings/objc/DOMExtensions.h:
  • platform/DragImage.h:
8:41 PM Changeset in webkit [161728] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Fix iOS build.

Generated DOMTouch* and DOMGesture* files need to be in the project.
Exclude them on Mac via EXCLUDED_SOURCE_FILE_NAMES_macosx.

Use TARGET_OS_IPHONE instead of TARGET_OS_EMBEDDED in DOMPrivate.h

  • Configurations/WebCore.xcconfig:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMPrivate.h:
8:39 PM Changeset in webkit [161727] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix RenderThemeIOS.o for iOS. Unreviewed build fix.

Typo referring to generated name. Should be "iOS" not "IOS".

  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::mediaControlsScript):

8:31 PM Changeset in webkit [161726] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix WebAccessibilityObjectWrapperIOS.o for iOS. Unreviewed build fix.

The upstreamed WebAccessibilityObjectWrapperIOS.mm was out of date, e.g.
it was using GSFonts. Just upstream a newer version of the file. Also
explicitly namespace qualify std::pair.

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(AXAttributeStringSetStyle):

8:26 PM Changeset in webkit [161725] by jinwoo7.song@samsung.com
  • 3 edits in trunk/Source/WebCore

Remove willRespondToTouchEvents() which was used by chromium port
https://bugs.webkit.org/show_bug.cgi?id=126739

Reviewed by Alexey Proskuryakov.

willRespondToTouchEvents() was added to check if a node listens to touch events in r126945.
However, it is not used anywhere after chromium port is removed.

  • dom/Node.cpp:
  • dom/Node.h:
8:17 PM Changeset in webkit [161724] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix SystemVersionMac.o for iOS. Unreviewed build fix.

Add missing expected function. Maybe we can avoid including
this file entirely on iOS, there was already a FIXME.

  • platform/mac/SystemVersionMac.mm:

(WebCore::systemMarketingVersion):

8:13 PM Changeset in webkit [161723] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix JSDOMWindowBase.o for iOS. Unreviewed build fix.

Add missing iOS method declarations.

  • bindings/js/JSDOMWindowBase.h:
8:06 PM Changeset in webkit [161722] by commit-queue@webkit.org
  • 3 edits
    3 deletes in trunk

Unreviewed, rolling out r161702.
http://trac.webkit.org/changeset/161702
https://bugs.webkit.org/show_bug.cgi?id=126803

Broke multiple tests (Requested by ap on #webkit).

Source/JavaScriptCore:

  • runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::getCallData):

LayoutTests:

  • js/script-tests/typedarray-constructors.js: Removed.
  • js/typedarray-constructors-expected.txt: Removed.
  • js/typedarray-constructors.html: Removed.
8:05 PM Changeset in webkit [161721] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix InputType.o for iOS. Unreviewed build fix.

The RuntimeEnabledFeatures function pointer type should have a
const qualifier, because the implementations are all const.

  • html/InputType.cpp:
7:58 PM Changeset in webkit [161720] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix MediaPlayerPrivateIOS.o for iOS. Unreviewed build fix.

Add missing MediaPlayerProxy Objective C methods and forward declarations.

  • platform/graphics/mac/MediaPlayerProxy.h:
7:49 PM Changeset in webkit [161719] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix FrameSelection.o for iOS. Unreviewed build fix.

r160966 renamed rendererIsEditable to hasEditableStyle.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelectionFromNone):

7:46 PM Changeset in webkit [161718] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix DragData.o for iOS. Unreviewed build fix.

String m_pasteboardName is unused on iOS, so ifdef it out.

  • platform/DragData.h:
7:32 PM Changeset in webkit [161717] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix FrameIOS.o for iOS. Unreviewed build fix.

Remove stale include to file that no longer exists. It was not needed.

  • page/ios/FrameIOS.mm:
7:29 PM Changeset in webkit [161716] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix MonthInputType.o for iOS. Unreviewed build fix.

When ENABLE_INPUT_MULTIPLE_FIELDS_UI was removed in r150876,
the wrong class name lingered. Fix it to be the base class.

  • html/TimeInputType.cpp:

(WebCore::TimeInputType::TimeInputType):

6:26 PM Changeset in webkit [161715] by aestes@apple.com
  • 3 edits in trunk/Source/WebCore

[iOS] Build fix: make sure WTF_PLATFORM_IOS is defined when preprocessing

  • DerivedSources.make:
  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):

6:25 PM Changeset in webkit [161714] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Use TARGET_OS_IPHONE in this API file, and #if TARGET_OS_MAC
for a non-iOS function.

  • bindings/objc/DOMExtensions.h:
6:19 PM Changeset in webkit [161713] by ddkilzer@apple.com
  • 12 edits in trunk/Source

Clean up architectures in xcconfig files
<http://webkit.org/b/126794>

Reviewed by Andy Estes.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:
  • Configurations/JavaScriptCore.xcconfig: Remove armv6, ppc.
  • Configurations/ToolExecutable.xcconfig: Sort.
  • Add new arch.

Source/WebCore:

  • Configurations/Base.xcconfig:
  • Configurations/WebCore.xcconfig: Remove armv6.
  • DerivedSources.make: Remove armv6, armv7f. Sort.
  • Add new arch.

Source/WebKit/mac:

  • Configurations/WebKit.xcconfig: Remove armv6, armv7f, ppc.
  • Add new arch.

Source/WTF:

  • Configurations/Base.xcconfig:
  • Add new arch.
6:16 PM Changeset in webkit [161712] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Fix iOS build

  • Configurations/WebCore.xcconfig:
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyLineHeightForIOSTextAutosizing::applyValue):

5:59 PM Changeset in webkit [161711] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Fix iOS build.

  • html/DateTimeLocalInputType.h:

(WebCore::DateTimeLocalInputType::DateTimeLocalInputType):

  • loader/ios/DiskImageCacheIOS.h:
5:59 PM Changeset in webkit [161710] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

iOS build fix: add StyleRareInheritedData::compositionFillColor

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:
5:50 PM Changeset in webkit [161709] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix MonthInputType.o for iOS. Unreviewed build fix.

Incorrect base class name. Must have been typo'd when upstreaming.

  • html/MonthInputType.h:

(WebCore::MonthInputType::MonthInputType):

5:33 PM Changeset in webkit [161708] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix RenderButton.o for iOS. Unreviewed build fix.

Missing prototype in header for override of the layout method.

  • rendering/RenderButton.h:
5:29 PM Changeset in webkit [161707] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

A couple of iOS build fixes.

  • accessibility/ios/AXObjectCacheIOS.mm:

(WebCore::AXObjectCache::handleFocusedUIElementChanged):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):

5:29 PM Changeset in webkit [161706] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix iOS build.

  • loader/ResourceLoader.h:
5:29 PM Changeset in webkit [161705] by fpizlo@apple.com
  • 8 edits in branches/jsCStack/Source/JavaScriptCore

It should be easier to diagnose FTL performance issues due to register preservation thunks
https://bugs.webkit.org/show_bug.cgi?id=126798

Not yet reviewed.

You can now use --verboseFTLToJSThunk=true --verboseFTLFailure=true to figure out
which code blocks are rejected by the FTL and yet get called from functions that
were FTL compiled. Any such rejections in major benchmarks should be fixed.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::verboseCapabilities):
(JSC::FTL::canCompile):

  • jit/RegisterPreservationWrapperGenerator.cpp:

(JSC::generateRegisterPreservationWrapper):

  • runtime/Executable.cpp:

(JSC::ExecutableBase::dump):

  • runtime/Executable.h:
  • runtime/Options.cpp:

(JSC::Options::initialize):

  • runtime/Options.h:
5:26 PM Changeset in webkit [161704] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix PlatformScreenIOS.mm for iOS. Unreviewed build fix.

PlatformScreen.h removed screenVerticalDPI and screenHorizontalDPI in r132419,
so remove the stale implementations on iOS. Also, add a notImplemented version
of screenColorProfile, which matches Mac and is unused in WebCore for this port.

  • platform/ios/PlatformScreenIOS.mm:

(WebCore::screenColorProfile):

5:19 PM Changeset in webkit [161703] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

CTTE FrameTree
https://bugs.webkit.org/show_bug.cgi?id=126795

Reviewed by Tim Horton.

  • page/Frame.cpp:

(WebCore::Frame::Frame):

  • page/FrameTree.cpp:

(WebCore::FrameTree::transferChild):
(WebCore::FrameTree::appendChild):
(WebCore::FrameTree::actuallyAppendChild):
(WebCore::FrameTree::uniqueChildName):
(WebCore::FrameTree::scopedChild):
(WebCore::FrameTree::scopedChildCount):
(WebCore::FrameTree::child):
(WebCore::FrameTree::find):
(WebCore::FrameTree::isDescendantOf):
(WebCore::FrameTree::traverseNext):
(WebCore::FrameTree::traverseNextWithWrap):
(WebCore::FrameTree::traversePreviousWithWrap):
(WebCore::FrameTree::deepLastChild):
(WebCore::FrameTree::top):

  • page/FrameTree.h:

(WebCore::FrameTree::FrameTree):

5:09 PM Changeset in webkit [161702] by dino@apple.com
  • 3 edits
    3 adds in trunk

[JSC] Revise typed array implementations to match ECMAScript and WebGL Specification
https://bugs.webkit.org/show_bug.cgi?id=126754

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

The ECMAScript specification forbids calling the typed array
constructors without using "new". Change the call data to return
none so we throw and exception in these cases.

  • runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::getCallData):

LayoutTests:

New test which checks that we throw an exception when calling
any of the typed array constructors without using "new".

  • js/script-tests/typedarray-constructors.js: Added.
  • js/typedarray-constructors-expected.txt: Added.
  • js/typedarray-constructors.html: Added.
5:05 PM Changeset in webkit [161701] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix iOS build.

  • platform/graphics/ImageSource.h:

(WebCore::ImageSource::acceleratedImageDecodingEnabled):
(WebCore::ImageSource::setAcceleratedImageDecodingEnabled):

4:55 PM Changeset in webkit [161700] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Unreviewed EFL build fix after r161678.

static_cast a size_t to unsigned long for %lu format string.

  • page/Console.cpp:

(WebCore::internalAddMessage):

4:53 PM Changeset in webkit [161699] by benjamin@webkit.org
  • 38 edits in trunk

Remove the BlackBerry port from trunk
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-10
Reviewed by Anders Carlsson.

.:

  • CMakeLists.txt:
  • Source/cmake/OptionsCommon.cmake:

Source/JavaScriptCore:

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::cacheFlush):

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::replaceWithJump):
(JSC::ARMv7Assembler::maxJumpReplacementSize):
(JSC::ARMv7Assembler::cacheFlush):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::revertJumpReplacementToBranchPtrWithPatch):

  • heap/MachineStackMarker.cpp:

(JSC::getPlatformThreadRegisters):
(JSC::otherThreadStackPointer):
(JSC::freePlatformThreadRegisters):

  • jit/ExecutableAllocator.h:

Source/WebCore:

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::readPixels):

  • platform/graphics/ImageBuffer.cpp:
  • platform/graphics/ImageBufferData.h:
  • platform/graphics/IntPoint.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/IntSize.h:
  • platform/graphics/MediaPlayer.cpp:
  • platform/graphics/NativeImagePtr.h:
  • platform/graphics/OpenGLESShims.h:
  • platform/graphics/Path.cpp:

(WebCore::Path::addPathForRoundedRect):

  • platform/graphics/Path.h:
  • platform/graphics/PlatformLayer.h:
  • platform/graphics/filters/CustomFilterValidatedProgram.cpp:
  • platform/graphics/filters/CustomFilterValidatedProgram.h:
  • platform/graphics/filters/FilterOperation.h:
  • platform/graphics/gpu/DrawingBuffer.cpp:
  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
  • platform/graphics/opengl/Extensions3DOpenGLES.cpp:

(WebCore::Extensions3DOpenGLES::getGraphicsResetStatusARB):

  • platform/graphics/opengl/Extensions3DOpenGLES.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):

  • platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
(WebCore::GraphicsContext3D::reshapeFBOs):

  • platform/network/NetworkStateNotifier.h:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h:
  • platform/network/ResourceRequestBase.cpp:

Tools:

  • DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/PixelDumpSupport.cpp:
4:44 PM Changeset in webkit [161698] by Simon Fraser
  • 3 edits
    1 add in trunk/Source/WebCore

Fix CharsetData.cpp build for iOS
https://bugs.webkit.org/show_bug.cgi?id=126792

Reviewed by Mark Rowe.

CharsetData.cpp should have an empty CharsetTable list for iOS.
Achieve this with an iOS-specific encodings.txt file.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/text/mac/ios-encodings.txt: Added.
4:38 PM Changeset in webkit [161697] by andersca@apple.com
  • 8 edits in trunk/Source/WebCore

CTTE in NavigationScheduler
https://bugs.webkit.org/show_bug.cgi?id=126788

Reviewed by Tim Horton.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::frameScheduledNavigationImpl):
(WebCore::InspectorInstrumentation::frameClearedScheduledNavigationImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::frameScheduledNavigation):
(WebCore::InspectorInstrumentation::frameClearedScheduledNavigation):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::frameScheduledNavigation):
(WebCore::InspectorPageAgent::frameClearedScheduledNavigation):

  • inspector/InspectorPageAgent.h:
  • loader/NavigationScheduler.cpp:

(WebCore::ScheduledNavigation::shouldStartTimer):
(WebCore::ScheduledNavigation::didStartTimer):
(WebCore::ScheduledNavigation::didStopTimer):
(WebCore::NavigationScheduler::NavigationScheduler):
(WebCore::NavigationScheduler::clear):
(WebCore::NavigationScheduler::shouldScheduleNavigation):
(WebCore::NavigationScheduler::scheduleRedirect):
(WebCore::NavigationScheduler::mustLockBackForwardList):
(WebCore::NavigationScheduler::scheduleLocationChange):
(WebCore::NavigationScheduler::scheduleFormSubmission):
(WebCore::NavigationScheduler::scheduleRefresh):
(WebCore::NavigationScheduler::scheduleHistoryNavigation):
(WebCore::NavigationScheduler::timerFired):
(WebCore::NavigationScheduler::schedule):
(WebCore::NavigationScheduler::startTimer):
(WebCore::NavigationScheduler::cancel):

  • loader/NavigationScheduler.h:
  • page/Frame.cpp:

(WebCore::Frame::Frame):

4:31 PM Changeset in webkit [161696] by mmaxfield@apple.com
  • 19 edits
    7 adds in trunk

CSS word-spacing property does not obey percentages
https://bugs.webkit.org/show_bug.cgi?id=126674

Reviewed by Simon Fraser.

Source/WebCore:

One change between CSS2.1 and CSS3 is that the word-spacing CSS property can
take percentages (of the width of the space character) in CSS3. In order to
implement this, the datatype must be changed from a float to a Length, which
can hold percentage values. Then, during layout, we can query the width of
the space character and update the Font's word-spacing value appropriately.
However, the RenderStyle still holds on to the Length (as a rare inherited
value).

Tests: fast/css3-text/css3-word-spacing-percentage/word-spacing-change-font.html

fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage-parse.html
fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue): Use Font's computed value instead
of style's Length value.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): word-spacing and letter-spacing no longer are
parsed the same way.

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyWordSpacing::applyValue): Construct a length from a given
CSSValue and set the style's word spacing with it.
(WebCore::ApplyPropertyWordSpacing::createHandler):
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): Use ApplyPropertyWordSpacing.

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun): Use Font's computed value instead
of style's Length value.

  • rendering/RenderText.cpp:

(WebCore::RenderText::computePreferredLogicalWidths): Ditto.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor): Opt-out of the SimpleLineLayout
if either the percentage or the length is nonzero.

  • rendering/line/BreakingContextInlineHeaders.h:

(WebCore::BreakingContext::handleText): Use Font's computed value instead
of style's Length value.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::wordSpacing):
(WebCore::RenderStyle::setWordSpacing): Consult the Font's space with to compute
percentage values, but hold on to the original Length.

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareInheritedData.cpp:
  • rendering/style/StyleRareInheritedData.h: Hold on to the specified Length

LayoutTests:

See per-file description

  • fast/css3-text/css3-word-spacing-percentage/word-spacing-change-font-expected.html: Added.
  • fast/css3-text/css3-word-spacing-percentage/word-spacing-change-font.html: Added.

Make sure that if Javascript changes the font after initial layout, that the word-spacing
value gets appropriately updated.

  • fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage-expected.html: Added.
  • fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage-parse-expected.txt: Added.
  • fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage-parse.html: Added.

Make sure that the CSSOM yields the correct percentage values when queried.

  • fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage.html: Added.

Try some specific values of percentages (-100%, 0%, and 100%).

  • css1/text_properties/word_spacing.html: Updated to not disregard percentages
  • css2.1/20110323/c541-word-sp-001-expected.html:
  • css2.1/20110323/c541-word-sp-001.htm: Ditto
  • platform/mac/css1/text_properties/word_spacing-expected.png:
  • platform/mac/css1/text_properties/word_spacing-expected.txt: Ditto
4:29 PM Changeset in webkit [161695] by fpizlo@apple.com
  • 1 edit
    1 add in branches/jsCStack/Source/JavaScriptCore

Unreviewed, add a test for the case where LLVM finds a constant folding
opportunity that the DFG missed, and it involves a large constant, and then we
exit with the large constant folded into a stackmap for an OSR exit.

We fixed this incidentally as part of http://trac.webkit.org/changeset/161543, but
it only showed up as part of new tests specific to add/sub recovery and as a
Octane/gbemu *slow-down* because gbemu had such a constant. It seems like we
should have an explicit test for this since it's a really gross bug to have in a
rather critical code path.

  • tests/stress/exit-after-llvm-folds-large-int-constant.js: Added.

(foo):

4:19 PM Changeset in webkit [161694] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix the iOS build.

  • platform/audio/mac/MediaSessionManagerMac.cpp:
4:17 PM Changeset in webkit [161693] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

iOS doesn't have <OpenGL/gl.h>; fix iOS build.

  • platform/graphics/opengl/TemporaryOpenGLSetting.cpp:
4:16 PM Changeset in webkit [161692] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Build Fix: Properly add $SDKROOT/usr/local/include/ to the search path when building PublicDOMInterfaces.h

  • bindings/scripts/CodeGeneratorObjC.pm:

(ReadPublicInterfaces):

3:55 PM Changeset in webkit [161691] by commit-queue@webkit.org
  • 22 edits in trunk/Source

Web Inspector: Remove unimplemented or static ScriptDebugServer features
https://bugs.webkit.org/show_bug.cgi?id=126784

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-10
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

  • inspector/protocol/Debugger.json:

Source/WebCore:

These features are unimplemented in the backend, and unused by the
current frontend. Most deal with features that were supported by v8
and are as yet unimplemented by JSC. If we decide to add such features
we can reimplement without conforming to an old implementation.

  • bindings/js/ScriptDebugServer.cpp:
  • bindings/js/ScriptDebugServer.h:
  • bindings/js/ScriptProfiler.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::disable):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::reload):
(WebCore::InspectorPageAgent::frameNavigated):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorProfilerAgent.cpp:
  • inspector/InspectorProfilerAgent.h:
  • inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::didClearMainFrameWindowObject):

  • inspector/protocol/Page.json:
  • inspector/protocol/Profiler.json:

Source/WebInspectorUI:

  • UserInterface/InspectorJSBackendCommands.js:
  • UserInterface/InspectorWebBackendCommands.js:
  • UserInterface/Legacy/6.0/InspectorWebBackendCommands.js:
  • UserInterface/Legacy/7.0/InspectorWebBackendCommands.js:
  • Versions/Inspector-iOS-6.0.json:
  • Versions/Inspector-iOS-7.0.json:
3:54 PM Changeset in webkit [161690] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Remove unused variable from TileGrid::dropTilesBetweenRects()

Fixes the following build error:

WebCore/platform/ios/TileGrid.mm:88:23: error: unused variable 'end' [-Werror,-Wunused-variable]

TileMap::iterator end = m_tiles.end();


  • platform/ios/TileGrid.mm:

(WebCore::TileGrid::dropTilesBetweenRects): Remove unused
variable now that the for loop uses an auto iterator.

3:54 PM Changeset in webkit [161689] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: support negative numbers in secondsToString and bytesToString.

https://bugs.webkit.org/show_bug.cgi?id=125708

Reviewed by Joseph Pecoraro.

  • UserInterface/Utilities.js:

(Number.secondsToString): Use Math.abs in the size checks.
(Number.bytesToString): Ditto.

3:53 PM Changeset in webkit [161688] by dino@apple.com
  • 18 edits
    5 adds in trunk

Implement OES texture half float linear
https://bugs.webkit.org/show_bug.cgi?id=125060

Reviewed by Brent Fulgham.

Source/WebCore:

Test: fast/canvas/webgl/oes-texture-half-float-linear.html

  • CMakeLists.txt: Add new files.
  • DerivedSources.cpp: Ditto.
  • DerivedSources.make: Generate new file from IDL.
  • GNUmakefile.list.am: Add new files.
  • WebCore.vcxproj/WebCore.vcxproj: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • WebCore.xcodeproj/project.pbxproj: New files for OESTextureHalfFloatLinear.
  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS): Map from extension name to native object.

  • html/canvas/OESTextureHalfFloatLinear.cpp: Added. New files. These are boiler-plate.
  • html/canvas/OESTextureHalfFloatLinear.h: Added.
  • html/canvas/OESTextureHalfFloatLinear.idl: Added.
  • html/canvas/WebGLExtension.h: Add new enum for the new extension.
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension): Create the extension object if the
context is asked for one.
(WebCore::WebGLRenderingContext::getSupportedExtensions): Add the new extension to the
list of supported extensions. Actually remember to do it this time :)
(WebCore::WebGLRenderingContext::checkTextureCompleteness): Need to check for the half-float
extension as well, and update the log message.

  • html/canvas/WebGLRenderingContext.h: New extension object.
  • html/canvas/WebGLTexture.cpp:

(WebCore::WebGLTexture::WebGLTexture):
(WebCore::WebGLTexture::needToUseBlackTexture): Check for half-float type.
(WebCore::WebGLTexture::update): Mark a texture as half-float if necessary.

  • html/canvas/WebGLTexture.h:
  • platform/graphics/Extensions3D.h: Add a comment about the new extension.
  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::supportsExtension): This extension is available
when GL_ARB_texture_float is supported, so add the name to the translation.

LayoutTests:

Exercise the OES_texture_half_float_linear extension. The new test
is copied from the official Khronos WebGL repository.

  • fast/canvas/webgl/oes-texture-float-linear-expected.txt: Change the console log

messages, which now also mention half float linear.

  • fast/canvas/webgl/oes-texture-half-float-linear-expected.txt: Added.
  • fast/canvas/webgl/oes-texture-half-float-linear.html: Added.
3:48 PM Changeset in webkit [161687] by BJ Burg
  • 7 edits in trunk/Source/WebInspectorUI

Web Inspector: cycle clicked breakpoints between enabled, auto-continue, and disabled
https://bugs.webkit.org/show_bug.cgi?id=126669

Reviewed by Joseph Pecoraro.

It's time-consuming to change a breakpoint's auto-continue setting through the
breakpoint editor popup. This patch enables the user to toggle between enabled,
auto-continue, and disabled by clicking on the breakpoint wedge in the sidebar
tree and in the source text editor gutter. The auto-continue option is only
cycled when the breakpoint has associated actions.

Clean up the breakpoint editor dialog so it hides irrelevant options when
no breakpoint actions have been added.

Automatically unset auto-continue when the last breakpoint action is removed.

Rename the delegate textEditorBreakpointToggled to textEditorBreakpointClicked, since
the behavior of the click depends on breakpoint state not available in the text editor.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Breakpoint.js:

(WebInspector.Breakpoint.prototype.cycleToNextMode): Added.
(WebInspector.Breakpoint.prototype.toggleAutoContinue): Added.
(WebInspector.Breakpoint.prototype.appendContextMenuItems): Add auto-continue options.
(WebInspector.Breakpoint.prototype.removeAction):

(WebInspector.Breakpoint.prototype._editBreakpointPopoverContentElement):
(WebInspector.Breakpoint.prototype._popoverActionsAddActionButtonClicked):
(WebInspector.Breakpoint.prototype.breakpointActionViewAppendActionView):
(WebInspector.Breakpoint.prototype.breakpointActionViewRemoveActionView):
(WebInspector.Breakpoint.prototype.willDismissPopover):

  • UserInterface/BreakpointTreeElement.css:

(.item.breakpoint .status > .status-image.auto-continue):
(.item.breakpoint .status > .status-image.disabled):

  • UserInterface/BreakpointTreeElement.js:

(WebInspector.BreakpointTreeElement):
(WebInspector.BreakpointTreeElement.prototype.onenter):
(WebInspector.BreakpointTreeElement.prototype.onspace):
(WebInspector.BreakpointTreeElement.prototype._updateStatus):
(WebInspector.BreakpointTreeElement.prototype._breakpointLocationDidChange):
(WebInspector.BreakpointTreeElement.prototype._statusImageElementClicked):

  • UserInterface/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor):
(WebInspector.SourceCodeTextEditor.prototype.close):
(WebInspector.SourceCodeTextEditor.prototype._breakpointInfoForBreakpoint):
(WebInspector.SourceCodeTextEditor.prototype.textEditorBreakpointClicked):

  • UserInterface/TextEditor.css:

(.text-editor > .CodeMirror .breakpoint-auto-continue:not(.breakpoint-disabled) .CodeMirror-linenumber::before):

  • UserInterface/TextEditor.js:

(WebInspector.TextEditor.prototype._setBreakpointStylesOnLine.updateStyles):
(WebInspector.TextEditor.prototype._setBreakpointStylesOnLine):
(WebInspector.TextEditor.prototype.updateStyles):
(WebInspector.TextEditor.prototype._removeBreakpointFromLineAndColumn):
(WebInspector.TextEditor.prototype._documentMouseUp):

3:47 PM Changeset in webkit [161686] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

REGRESSION(C stack work): stack traces no longer work in CrashTracer, lldb, and other tools
https://bugs.webkit.org/show_bug.cgi?id=126764

Reviewed by Geoffrey Garen.

Updated callToJavaScript and cllToNativeFunction to properly replicate the caller's
return PC and frame pointer in the sentinel frame. For X86-64, added .cfi_
directives to create eh_frame info for all LLInt symbols so that the various
unwinding code understands that we are using a separate JS stack referenced
by BP and at what offsets in that frame the prior PC (register 16) and prior
BP (register 6) can be found. These two changes are sufficient for stack tracing
to work for Mac OSX.

  • llint/LowLevelInterpreter.cpp:
  • llint/LowLevelInterpreter64.asm:
3:36 PM Changeset in webkit [161685] by dbates@webkit.org
  • 2 edits in trunk/Tools

[iOS] Fix project build order

Ensure we build WebKitAdditions before WebCore (if applicable). Also, we don't
build WebInspectorUI, Tools/MiniBrowser, or Tools/WebKitTestRunner on iOS at the
time of writing.

  • Scripts/build-webkit:
3:28 PM Changeset in webkit [161684] by Brent Fulgham
  • 3 edits
    1 copy in trunk

Source/WebCore: [WebGL] Correct uniform input validation for texture sampler uniform
https://bugs.webkit.org/show_bug.cgi?id=126775

Reviewed by Dean Jackson.

Added fast/canvas/webgl/uniform-samplers-test.html

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::uniform1iv): Access Int32Array data properly.

LayoutTests: [WebGL] Correct uniform input validation for texture sampler uniforms.
https://bugs.webkit.org/show_bug.cgi?id=126775

Reviewed by Dean Jackson.

  • fast/canvas/webgl/uniform-samplers-test.html: Add a test that

shows that we can set sampler uniforms using Int32Array types.

3:17 PM Changeset in webkit [161683] by fpizlo@apple.com
  • 5 edits
    3 adds in branches/jsCStack/Source/JavaScriptCore

DFG should insert Phantoms when it uses conversion nodes
https://bugs.webkit.org/show_bug.cgi?id=126777

Reviewed by Oliver Hunt.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupSetLocalsInBlock):
(JSC::DFG::FixupPhase::fixupUntypedSetLocalsInBlock):
(JSC::DFG::FixupPhase::fixEdge):
(JSC::DFG::FixupPhase::fixIntEdge):
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):
(JSC::DFG::FixupPhase::addPhantomsIfNecessary):

  • dfg/DFGNodeFlags.cpp:

(JSC::DFG::dumpNodeFlags):

  • dfg/DFGValidate.cpp:

(JSC::DFG::Validate::validate):

  • tests/stress/exit-after-int32-to-double.js: Added.

(foo):

  • tests/stress/exit-after-int52-to-double.js: Added.

(foo):

  • tests/stress/exit-after-int52-to-value.js: Added.

(foo):
(makeWeirdObject):

2:54 PM Changeset in webkit [161682] by Manuel Rego Casasnovas
  • 2 edits in trunk/Source/WebCore

[GTK] Unreviewed build fix after r161644.

  • Modules/webaudio/MediaStreamAudioSourceNode.cpp:

(WebCore::MediaStreamAudioSourceNode::setFormat):

2:52 PM Changeset in webkit [161681] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Remove an unused FrameLoader function
https://bugs.webkit.org/show_bug.cgi?id=126785

Reviewed by Beth Dakin.

  • WebCore.exp.in:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::setState):

  • loader/FrameLoader.h:
2:48 PM Changeset in webkit [161680] by benjamin@webkit.org
  • 22 edits in trunk/Source/WebCore

Remove the BlackBerry port from trunk
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-10
Reviewed by Anders Carlsson.

  • platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypesForEncoding):

  • platform/PlatformKeyboardEvent.h:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

  • platform/PlatformMouseEvent.h:
  • platform/PlatformTouchEvent.h:

(WebCore::PlatformTouchEvent::PlatformTouchEvent):

  • platform/PlatformTouchPoint.h:
  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimator::create):

  • platform/URL.cpp:

(WebCore::URL::parse):
(WebCore::portAllowed):

  • platform/Widget.h:
  • platform/graphics/ANGLEWebKitBridge.h:
  • platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):

  • platform/graphics/DisplayRefreshMonitor.h:
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatSize.h:
  • platform/graphics/FontCache.h:
  • platform/graphics/FontPlatformData.h:
  • platform/graphics/GlyphBuffer.h:
  • platform/graphics/Gradient.cpp:
  • platform/graphics/Gradient.h:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsContext3D.h:
2:24 PM Changeset in webkit [161679] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Remove dead code
https://bugs.webkit.org/show_bug.cgi?id=126782

Reviewed by Tim Horton.

  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
2:16 PM Changeset in webkit [161678] by timothy@apple.com
  • 4 edits in trunk/Source/WebCore

Clean up and fix some issues with stdout formatting of console messages.

  • Fix URLs not printing line numbers unless column number is > 0.
  • Change "CONSOLEAPI" to "CONSOLE" for the source.
  • Clean up how console.trace outputs and print URL, line and column for each frame.
  • Print "(unknown)" for anonymous and native code call frames.

https://bugs.webkit.org/show_bug.cgi?id=126767

Reviewed by Joseph Pecoraro.

  • page/Console.cpp:

(WebCore::internalAddMessage):

  • page/PageConsole.cpp:

(WebCore::PageConsole::printSourceURLAndPosition):
(WebCore::PageConsole::printMessageSourceAndLevelPrefix):

  • page/PageConsole.h:
2:13 PM Changeset in webkit [161677] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Clean up some areas of TreeOutline.

https://bugs.webkit.org/show_bug.cgi?id=123924

Reviewed by Joseph Pecoraro.

  • UserInterface/TreeOutline.js:

(TreeOutline.prototype.appendChild): Don't force create _childrenListNode, it will be created
when the tree element is expanded. Only attach if _childrenListNode already exists.
(TreeOutline.prototype.insertChild): Ditto.
(TreeOutline.prototype.getCachedTreeElement): Check the value of treeElementIdentifier
not just the existence of the property. It should never be null/undefined/0, but be safe.
(TreeOutline.prototype.findTreeElement): Null check isAncestor, it isn't required.

2:11 PM Changeset in webkit [161676] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[iOS] Fill in missing WebCoreThread function pointers
https://bugs.webkit.org/show_bug.cgi?id=126776

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-10
Reviewed by Timothy Hatcher.

  • platform/ios/wak/WebCoreThreadSystemInterface.cpp:

(InitWebCoreThreadSystemInterface):

2:10 PM Changeset in webkit [161675] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk/Source

Clear unparented tiled layers on memory pressure.
https://bugs.webkit.org/show_bug.cgi?id=126737

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-01-10
Reviewed by Simon Fraser.

Source/WebCore:

TileController hold unparented tiles for a short period of time (1 -3 sec); we should clear these unparented
tiles immediately if we are under memory pressure.

The patch does 3 things to improve the behavior:
1) When the system free memory is low (<35%), reduce the tiling threshold. This could reduce
the peak memory usage when system is under low memory since we will convert more web layers into
tiled backing.
2) Under memory pressure, immediately clear all unparented tiles.
3) Add a cap (16 tiles) to limit the total number of unparented tiles in TileController's.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj: Add a new class TileControllerMemoryHandler.
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::requiresTiledLayer): Use a smaller tiling threshold if the system free memory is low.

  • platform/graphics/ca/mac/TileController.h:

(WebCore::TileController::numberOfUnparentedTiles):

  • platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::startedNewCohort):
(WebCore::TileController::removeUnparentedTilesNow): Remove all unparentd tiles.

  • platform/ios/MemoryPressureHandlerIOS.mm:
  • platform/ios/TileControllerMemoryHandlerIOS.cpp: Added.

(WebCore::TileControllerMemoryHandler::removeTileController):
(WebCore::TileControllerMemoryHandler::totalUnparentedTiledLayers):
(WebCore::TileControllerMemoryHandler::tileControllerGainUnparentedTiles):
(WebCore::TileControllerMemoryHandler::trimUnparentedTilesToTarget): Trims the number of unparented tiles until

it reaches the target.

(WebCore::tileControllerMemoryHandler):

  • platform/ios/TileControllerMemoryHandlerIOS.h: Added.

(WebCore::TileControllerMemoryHandler::TileControllerMemoryHandler):

Source/WebKit/mac:

  • WebView/WebView.mm:

(+[WebView _handleMemoryWarning]): Clear all unparented tiles when under memory pressure.

2:06 PM Changeset in webkit [161674] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Fix an exception in WebInspector.Color.

https://bugs.webkit.org/show_bug.cgi?id=126765

Reviewed by Joseph Pecoraro.

  • UserInterface/Color.js:

(WebInspector.Color.fromString): Check hasOwnPrperty before using the nickname color array.
(WebInspector.Color.prototype._toNicknameString): Ditto.

1:42 PM Changeset in webkit [161673] by commit-queue@webkit.org
  • 6 edits in trunk/Source

[CSS Blending] Log blending as a layer creation reason in the WI
https://bugs.webkit.org/show_bug.cgi?id=126159

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-10
Reviewed by Timothy Hatcher.

Source/WebCore:

  • inspector/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::reasonsForCompositingLayer):

  • inspector/protocol/LayerTree.json:

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/LayerTreeSidebarPanel.js:

(WebInspector.LayerTreeSidebarPanel.prototype._populateListOfCompositingReasons):

1:37 PM Changeset in webkit [161672] by commit-queue@webkit.org
  • 10 edits in trunk

[EFL][JSC] Enable udis86 disassembler on efl.
https://bugs.webkit.org/show_bug.cgi?id=125502

Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2014-01-10
Reviewed by Michael Saboff.

Enable udis86 disassembler on efl and fix build warnings.

.:

  • Source/cmake/OptionsEfl.cmake: Enable udis86 disassembler.

Source/JavaScriptCore:

  • CMakeLists.txt: Add udis86 disassembler source files.
  • disassembler/udis86/udis86_decode.c:

(decode_modrm_rm):

Build warning fixes.

  • disassembler/udis86/udis86_syn-att.c:

(gen_operand):

Build warning fixes.

  • disassembler/udis86/udis86_syn-intel.c:

(gen_operand):

Build warning fixes.

  • disassembler/udis86/udis86_types.h: Correct FMT64 for uint64_t.

Source/WTF:

  • wtf/Platform.h: Enable udis86 disassembler on EFL.
1:37 PM Changeset in webkit [161671] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Fix some iOS build errors during bindings generation.

  • bindings/objc/PublicDOMInterfaces.h: Included

WebKitAdditions/PublicDOMInterfacesIOS.h and change
-[DOMRGBColor color] to return a CGColorRef on iOS.

1:31 PM Changeset in webkit [161670] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

Prevent some resources from showing up in Web Inspector as years in duration.

No WebKit port passed a monotonic time to InspectorInstrumentation::didFinishLoading -- except Chromium.

https://bugs.webkit.org/show_bug.cgi?id=126760

Reviewed by Joseph Pecoraro.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didFinishLoadingImpl):
Revert part of r102961 to use finishTime as-is and not expect a monotonic time.

1:29 PM Changeset in webkit [161669] by krit@webkit.org
  • 4 edits
    16 adds in trunk

Make clipping path from basic-shapes relative to <box> value
https://bugs.webkit.org/show_bug.cgi?id=126206

Reviewed by Simon Fraser.

Source/WebCore:

Tests: css3/masking/clip-path-circle-border-box.html

css3/masking/clip-path-circle-bounding-box.html
css3/masking/clip-path-circle-content-box.html
css3/masking/clip-path-circle-margin-box.html
css3/masking/clip-path-circle-padding-box.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::setupClipPath): Add switch to differ between boxes

and use different reference boxes to size the clipping path.

LayoutTests:

Add new tests to check that different reference boxes are chosen for sizing and
positioning the clipping path.

  • css3/masking/clip-path-circle-border-box.html: Added.
  • css3/masking/clip-path-circle-bounding-box.html: Added.
  • css3/masking/clip-path-circle-content-box.html: Added.
  • css3/masking/clip-path-circle-margin-box.html: Added.
  • css3/masking/clip-path-circle-padding-box.html: Added.
  • platform/mac/css3/masking/clip-path-circle-border-box-expected.png: Added.
  • platform/mac/css3/masking/clip-path-circle-border-box-expected.txt: Added.
  • platform/mac/css3/masking/clip-path-circle-bounding-box-expected.png: Added.
  • platform/mac/css3/masking/clip-path-circle-bounding-box-expected.txt: Added.
  • platform/mac/css3/masking/clip-path-circle-content-box-expected.png: Added.
  • platform/mac/css3/masking/clip-path-circle-content-box-expected.txt: Added.
  • platform/mac/css3/masking/clip-path-circle-margin-box-expected.png: Added.
  • platform/mac/css3/masking/clip-path-circle-margin-box-expected.txt: Added.
  • platform/mac/css3/masking/clip-path-circle-padding-box-expected.png: Added.
  • platform/mac/css3/masking/clip-path-circle-padding-box-expected.txt: Added.
  • platform/mac/css3/masking/mask-luminance-png-expected.png: Added.
1:22 PM Changeset in webkit [161668] by commit-queue@webkit.org
  • 9 edits
    10 adds in trunk

Source/WebCore: Correctly set XHR loadend attributes (loaded and total).
https://bugs.webkit.org/show_bug.cgi?id=120828

Patch by Youenn Fablet <youennf@gmail.com> on 2014-01-10
Reviewed by Alexey Proskuryakov.

Added correct initialization of lengthComputable, loaded and total attributes
to XHR ProgressEvent events (load, loadstart, loadend, abort, error and timeout).

XMLHttpRequestProgressEventThrottle and XMLHttpRequestUpload now keep persistent knowledge
of m_loaded and m_total values with this patch.

Code refactoring to handle event dispatching in case of error in a single manner.
XMLHttpRequestProgressEventThrottle::dispatchProgressEvent is renamed as dispatchThrottledProgressEvent
XMLHttpRequestProgressEventThrottle::dispatchEventAndLoadend is replaced by dispatchProgressEvent(const AtomicString&)

Fixed assertion issues over bug 120828 patch

Tests: http/tests/xmlhttprequest/loadstart-event-init.html

http/tests/xmlhttprequest/onabort-progressevent-attributes.html
http/tests/xmlhttprequest/onload-progressevent-attributes.html
http/tests/xmlhttprequest/upload-onabort-progressevent-attributes.html
http/tests/xmlhttprequest/upload-onload-progressevent-attributes.html

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::callReadyStateChangeListener): changed readystatechange event from ProgressEvent to Event (not cancellable, not bubblable) to better match the spec
(WebCore::XMLHttpRequest::createRequest):
(WebCore::XMLHttpRequest::abort): code refactoring to handle error event dispatching in a single way
(WebCore::XMLHttpRequest::networkError): code refactoring to handle error event dispatching in a single way
(WebCore::XMLHttpRequest::abortError): code refactoring to handle error event dispatching in a single way
(WebCore::XMLHttpRequest::didSendData):
(WebCore::XMLHttpRequest::didReceiveData):
(WebCore::XMLHttpRequest::dispatchErrorEvents): dispatch progress events in case of error
(WebCore::XMLHttpRequest::didTimeout): code refactoring to handle error event dispatching in a single way

  • xml/XMLHttpRequest.h:
  • xml/XMLHttpRequestProgressEventThrottle.cpp: before the patch, the fact that a progress event is being throttled is stored indirectly (m_loaded or m_total not equal to zero). With the patch, this information is stored in m_hasThrottledProgressEvent. The m_loaded and m_total values are no longer set back to zero after a progress event is dispatched. This allows using these values to correctly initialize other ProgressEvent events (in particular loadend, abort, timeout...)

(WebCore::XMLHttpRequestProgressEventThrottle::XMLHttpRequestProgressEventThrottle):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchThrottledProgressEvent): always update the new m_loaded and m_total values. If progress event is not sent as part of the function call, store the fact that a progress event is being throttled through m_hasThrottledProgressEvent.
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent): used to send any ProgressEvent event that is not be throttled
(WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent): after the call, no progress event is throttled anymore
(WebCore::XMLHttpRequestProgressEventThrottle::fired): after the call, no progress event is throttled anymore
(WebCore::XMLHttpRequestProgressEventThrottle::hasEventToDispatch):
(WebCore::XMLHttpRequestProgressEventThrottle::suspend):

  • xml/XMLHttpRequestProgressEventThrottle.h: introduced m_hasThrottledProgressEvent which stores whether a progress event is being throttled and m_computableLength which is used to initialize ProgressEvent computableLength
  • xml/XMLHttpRequestUpload.cpp:

(WebCore::XMLHttpRequestUpload::XMLHttpRequestUpload):
(WebCore::XMLHttpRequestUpload::dispatchProgressEvent):

  • xml/XMLHttpRequestUpload.h: introduced m_loaded, m_total and m_lengthComputable, similarly to XMLHttpRequestProgressEventThrottle

LayoutTests: Correctly set XHR loadend event attributes (loaded and total).
https://bugs.webkit.org/show_bug.cgi?id=120828

Patch by Youenn Fablet <youennf@gmail.com> on 2014-01-10
Reviewed by Alexey Proskuryakov.

Tests for abort, load, loadstart and loadend ProgressEvent events for XMLHttpRequest and XMLHttpRequestUpload

  • fast/xmlhttprequest/xmlhttprequest-get-expected.txt: Changed to correct event values
  • http/tests/xmlhttprequest/loadstart-event-init-expected.txt: Added.
  • http/tests/xmlhttprequest/loadstart-event-init.html: Added.
  • http/tests/xmlhttprequest/onabort-progressevent-attributes-expected.txt: Added.
  • http/tests/xmlhttprequest/onabort-progressevent-attributes.html: Added.
  • http/tests/xmlhttprequest/onload-progressevent-attributes-expected.txt: Added.
  • http/tests/xmlhttprequest/onload-progressevent-attributes.html: Added.
  • http/tests/xmlhttprequest/upload-onabort-progressevent-attributes-expected.txt: Added.
  • http/tests/xmlhttprequest/upload-onabort-progressevent-attributes.html: Added.
  • http/tests/xmlhttprequest/upload-onload-progressevent-attributes-expected.txt: Added.
  • http/tests/xmlhttprequest/upload-onload-progressevent-attributes.html: Added.
1:12 PM Changeset in webkit [161667] by betravis@adobe.com
  • 3 edits in trunk/Source/WebCore

[CSS Shapes] Change parseBasicShape to return a CSSPrimitiveValue
https://bugs.webkit.org/show_bug.cgi?id=126713

Reviewed by Dirk Schulze.

Avoid the duplicated code wrapping the CSSBasicShape in a CSSPrimitiveValue
by having parseBasicShape return a CSSPrimitiveValue reference.

Refactoring, no new tests.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseShapeProperty):
(WebCore::CSSParser::parseClipPath):
(WebCore::CSSParser::parseBasicShape):

  • css/CSSParser.h:
1:10 PM Changeset in webkit [161666] by mario.prada@samsung.com
  • 29 edits in trunk

Move platformName property from testRunner to accessibilityController
https://bugs.webkit.org/show_bug.cgi?id=126689

Reviewed by Chris Fleizach.

Tools:

Move the platformName property from the testRunner into
accessibilityController, since this is a concept that has only be
used by accessibility tests since it got added, and also because
the real intention was not to distinguish among "ports" (mac, win,
gtk, efl) but between platforms (atk, mac, win).

This change will be very useful to merge GTK's roles-exposed.html
and Mac's role-subrole-roledescription.html into one single test,
since we will be specifying in the test itself which elements are
supported in which accessibility "platform". In this context,
being able to check accessibilityController.platformName directly
against a list of supported accessibility platforms (e.g. "atk,mac")
will certainly maintain the code cleaner and simpler.

  • DumpRenderTree/TestRunner.h:

(TestRunner::platformName): Removed.

  • DumpRenderTree/TestRunner.cpp:

(getPlatformNameCallback): Removed.
(TestRunner::staticValues): Removed platformName

  • DumpRenderTree/efl/TestRunnerEfl.cpp:

(TestRunner::platformName): Removed.

  • DumpRenderTree/gtk/TestRunnerGtk.cpp:

(TestRunner::platformName): Removed.

  • DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::platformName): Removed.

  • DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::platformName): Removed.

  • DumpRenderTree/AccessibilityController.h:

(AccessibilityController::platformName): Added.

  • DumpRenderTree/AccessibilityController.cpp:

(getPlatformNameCallback): Added.
(AccessibilityController::getJSClass): Added platformName.

  • DumpRenderTree/atk/AccessibilityControllerAtk.cpp:

(AccessibilityController::platformName): Added, returning "atk".

  • DumpRenderTree/mac/AccessibilityControllerMac.mm:

(AccessibilityController::platformName): Ditto, returning "mac".

  • DumpRenderTree/ios/AccessibilityControllerIOS.mm:

(AccessibilityController::platformName): Ditto, returning "ios".

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::platformName): Ditto, returning "win".

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:

(platformName): Removed.

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner::platformName): Removed.

  • WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:

(TestRunner::platformName): Removed.

  • WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:

(TestRunner::platformName): Removed.

  • WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:

(TestRunner::platformName): Removed.

  • WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:

(TestRunner::platformName): Removed.

  • WebKitTestRunner/InjectedBundle/AccessibilityController.h:

(WTR:AccessibilityController::platformName): Added.

  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:

(platformName): Added.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:

(WTR::AccessibilityController::platformName): Added, returning "atk".

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:

(WTR::AccessibilityController::platformName): Added, returning "mac".

LayoutTests:

Updated tests and expectations affected by the move of
platformName from TestRunner to AccessibilityController.

  • accessibility/canvas-fallback-content.html:
  • accessibility/ignore-spacer-elements.html:
  • accessibility/platform-name.html:
  • platform/efl/accessibility/platform-name-expected.txt:
  • platform/gtk/accessibility/platform-name-expected.txt:
1:08 PM Changeset in webkit [161665] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Possible crash in ApplicationCache::removeResource.
https://bugs.webkit.org/show_bug.cgi?id=126695

Patch by Piotr Grad <p.grad@samsung.com> on 2014-01-10
Reviewed by Alexey Proskuryakov.

No new tests.

Iterator variable was used after it was removed.

  • loader/appcache/ApplicationCache.cpp:

(WebCore::ApplicationCache::removeResource):

12:51 PM Changeset in webkit [161664] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Another build fix for the Production Mac build following <http://trac.webkit.org/changeset/161638>
(https://bugs.webkit.org/show_bug.cgi?id=126698)

Move the logic for appending the port-specific IDL files {Touch, TouchEvent, TouchList}.idl to the
list of binding IDLs (BINDING_IDLS) before the definition of variables DOM_CLASSES and JS_DOM_HEADERS
so that we generate the DOM and JS bindings for these IDLs.

  • DerivedSources.make:
12:47 PM Changeset in webkit [161663] by andersca@apple.com
  • 5 edits
    6 deletes in trunk

Remove supportMultipleWindows setting
https://bugs.webkit.org/show_bug.cgi?id=126772

Reviewed by Beth Dakin.

Source/WebCore:

This setting was added in https://bugs.webkit.org/show_bug.cgi?id=99716 for the Chromium port
and is unused by everyone else so get rid of it.

  • loader/FrameLoader.cpp:

(WebCore::createWindow):

  • page/ContextMenuController.cpp:

(WebCore::openNewWindow):

  • page/Settings.in:

LayoutTests:

  • fast/dom/HTMLAnchorElement/anchor-no-multiple-windows-expected.txt: Removed.
  • fast/dom/HTMLAnchorElement/anchor-no-multiple-windows.html: Removed.
  • fast/dom/Window/window-open-no-multiple-windows-expected.txt: Removed.
  • fast/dom/Window/window-open-no-multiple-windows.html: Removed.
  • fast/forms/post-popup-no-multiple-windows-expected.txt: Removed.
  • fast/forms/post-popup-no-multiple-windows.html: Removed.
12:41 PM Changeset in webkit [161662] by benjamin@webkit.org
  • 29 edits in trunk/Source

Remove the BlackBerry port from trunk
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-10
Reviewed by Anders Carlsson.

Source/WebCore:

  • dom/TouchEvent.cpp:

(WebCore::TouchEvent::TouchEvent):
(WebCore::TouchEvent::initTouchEvent):

  • dom/TouchEvent.h:
  • dom/ViewportArguments.cpp:
  • dom/ViewportArguments.h:
  • history/HistoryItem.h:
  • loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::createResourceHandle):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

  • loader/icon/IconLoader.cpp:

(WebCore::IconLoader::startLoading):

  • page/NavigatorBase.cpp:
  • page/Settings.cpp:
  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::create):

  • platform/Cursor.cpp:
  • platform/Cursor.h:

(WebCore::Cursor::Cursor):

  • platform/DragData.h:
  • platform/DragImage.h:
  • plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::defaultPluginDirectories):
(WebCore::PluginDatabase::isPreferredPluginDirectory):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintsIntoWindow):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::shouldRespectImageOrientation):

  • testing/Internals.cpp:

(WebCore::Internals::getCurrentCursorInfo):

  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerScriptLoader::load):

  • workers/Worker.cpp:

(WebCore::Worker::create):

  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::importScripts):

  • workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::createResourceRequest):

  • workers/WorkerScriptLoader.h:
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::setCursor):

12:40 PM Changeset in webkit [161661] by benjamin@webkit.org
  • 12 edits in trunk

Remove the BlackBerry port from trunk
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-10
Reviewed by Anders Carlsson.

.:

  • CMakeLists.txt:

Source/WebCore:

  • Modules/navigatorcontentutils/NavigatorContentUtils.cpp:

(WebCore::initProtocolHandlerWhitelist):

  • UseJSC.cmake:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):

  • bindings/js/GCController.cpp:

(WebCore::GCController::GCController):
(WebCore::GCController::garbageCollectSoon):

  • bindings/js/GCController.h:

Source/WebKit2:

  • Scripts/generate-forwarding-headers.pl:

Tools:

  • Scripts/webkitpy/common/config/watchlist:
12:38 PM Changeset in webkit [161660] by dbates@webkit.org
  • 4 edits in trunk/Source

Fix the WebCore, WebKit build targets following <http://trac.webkit.org/changeset/161638>
(https://bugs.webkit.org/show_bug.cgi?id=126698)

Source/WebCore:

Tell Xcode that the supported platforms for all WebKit targets are iOS and OS X.

  • Configurations/Base.xcconfig:

Source/WebKit/mac:

Tell Xcode that the supported platforms for all WebCore targets are iOS and OS X.

  • Configurations/Base.xcconfig:
11:50 AM Changeset in webkit [161659] by benjamin@webkit.org
  • 4 edits
    5 deletes in trunk

Remove the BlackBerry files outside WebCore
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

.:

  • ManualTests/blackberry: Removed.
  • Source/cmake/OptionsBlackBerry.cmake: Removed.

Source/JavaScriptCore:

  • PlatformBlackBerry.cmake: Removed.
  • runtime/GCActivityCallbackBlackBerry.cpp: Removed.
  • shell/PlatformBlackBerry.cmake: Removed.

Tools:

  • DumpRenderTree/blackberry: Removed.

LayoutTests:

  • platform/blackberry: Removed.
11:32 AM Changeset in webkit [161658] by aestes@apple.com
  • 4 edits in trunk/Source

[iOS] Upstream iOS changes to MigrateHeaders.make
https://bugs.webkit.org/show_bug.cgi?id=126731

Reviewed by David Kilzer.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj: Mark an iOS-specific header at

Private that will later be migrated by WebKit.

Source/WebKit/mac:

  • MigrateHeaders.make: Migrate iOS-specific headers when building for iOS.
11:13 AM Changeset in webkit [161657] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the Production Mac build following <http://trac.webkit.org/changeset/161638>
(https://bugs.webkit.org/show_bug.cgi?id=126698)

Substitute JAVASCRIPTCORE_PRIVATE_HEADERS_DIR_Production_ for JAVASCRIPTCORE_PRIVATE_HEADERS_Production_.

  • Configurations/WebCore.xcconfig:
11:12 AM Changeset in webkit [161656] by Simon Fraser
  • 6 edits in trunk/Tools

Remove knowledge of Blackberry from build scripts
https://bugs.webkit.org/show_bug.cgi?id=126766

Reviewed by Anders Carlsson.

Remove isBlackBerry() and references to it, and rmeove
blackberry-related stuff from the watchlist.

  • Scripts/build-webkit:
  • Scripts/webkit-build-directory:
  • Scripts/webkitdirs.pm:

(determineBaseProductDir):
(argumentsForConfiguration):
(builtDylibPathForName):
(isAppleWebKit):
(buildCMakeProjectOrExit):
(cmakeBasedPortArguments):
(cmakeBasedPortName):

  • Scripts/webkitperl/FeatureList.pm:
  • Scripts/webkitpy/common/config/watchlist:
11:07 AM Changeset in webkit [161655] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Add a missing include.

  • Modules/webdatabase/DatabaseManager.h:
11:02 AM Changeset in webkit [161654] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Use STL threading primitives in DatabaseDetails and DatabaseManager
https://bugs.webkit.org/show_bug.cgi?id=126759

Reviewed by Geoffrey Garen.

  • Modules/webdatabase/DatabaseDetails.h:

(WebCore::DatabaseDetails::DatabaseDetails):
(WebCore::DatabaseDetails::threadID):

  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::existingDatabaseContextFor):
(WebCore::DatabaseManager::registerDatabaseContext):
(WebCore::DatabaseManager::unregisterDatabaseContext):
(WebCore::DatabaseManager::didConstructDatabaseContext):
(WebCore::DatabaseManager::didDestructDatabaseContext):
(WebCore::DatabaseManager::addProposedDatabase):
(WebCore::DatabaseManager::removeProposedDatabase):
(WebCore::DatabaseManager::fullPathForDatabase):
(WebCore::DatabaseManager::detailsForNameAndOrigin):

  • Modules/webdatabase/DatabaseManager.h:
10:59 AM Changeset in webkit [161653] by commit-queue@webkit.org
  • 4 edits
    7 deletes in trunk

Unreviewed, rolling out r161629.
http://trac.webkit.org/changeset/161629
https://bugs.webkit.org/show_bug.cgi?id=126762

Fails svg/custom/conditional-processing-2.html (Requested by
ap on #webkit).

Source/WebCore:

  • svg/SVGSwitchElement.cpp:

(WebCore::SVGSwitchElement::childShouldCreateRenderer):

  • svg/SVGTests.cpp:

(WebCore::SVGTests::hasExtension):
(WebCore::SVGTests::isValid):

LayoutTests:

  • svg/custom/conditional-processing-1-expected.txt: Removed.
  • svg/custom/conditional-processing-1.svg: Removed.
  • svg/custom/conditional-processing-2-expected.txt: Removed.
  • svg/custom/conditional-processing-2.html: Removed.
  • svg/dom/SVGTests-expected.txt: Removed.
  • svg/dom/SVGTests.html: Removed.
  • svg/dom/script-tests/SVGTests.js: Removed.
10:53 AM Changeset in webkit [161652] by ChangSeok Oh
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix since r161589.

The changeset causes a compile failure with --no-svg.

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::drawGlyphBuffer):

10:49 AM Changeset in webkit [161651] by dbates@webkit.org
  • 3 edits in trunk/Tools

[iOS] Fix up simulator build and enable default features

Rubber-stamped by Joseph Pecoraro.

  • Scripts/webkitdirs.pm:

(determineArchitecture):
(determinePassedArchitecture):

  • Scripts/webkitperl/FeatureList.pm: Also expose command line option to toggle ENABLE_PLUGIN_PROXY_FOR_VIDEO (enabled

by default only in iOS).

10:38 AM Changeset in webkit [161650] by ggaren@apple.com
  • 7 edits
    2 deletes in trunk/Source/JavaScriptCore

Removed Blackberry #ifdefs and platform code from JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=126757

Reviewed by Sam Weinig.

  • PlatformBlackBerry.cmake: Removed.
  • heap/HeapTimer.cpp:
  • heap/HeapTimer.h:
  • heap/IncrementalSweeper.cpp:
  • heap/IncrementalSweeper.h:
  • jsc.cpp:

(main):

  • runtime/GCActivityCallbackBlackBerry.cpp: Removed.
  • runtime/MemoryStatistics.cpp:

(JSC::globalMemoryStatistics):

10:22 AM Changeset in webkit [161649] by Brent Fulgham
  • 1 edit in trunk/Source/WebCore/ChangeLog

[WebGL] Removing unnecessary pointer checks
https://bugs.webkit.org/show_bug.cgi?id=124046

Patch by Przemyslaw Szymanski <p.szymanski3@samsung.com> on 2014-01-10
Reviewed by Brent Fulgham.

We do not need to check for a null array three times in
the same call. Let's just do it once!

No new tests. Covered by existing ones.

  • html/canvas/WebGLBuffer.cpp:

(WebCore::WebGLBuffer::associateBufferData):

10:22 AM Changeset in webkit [161648] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

Speculative build fix for Windows following <http://trac.webkit.org/changeset/161638>
(https://bugs.webkit.org/show_bug.cgi?id=126698)

Patch by Daniel Bates <dabates@apple.com> on 2014-01-10
Reviewed by David Kilzer.

  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):

10:20 AM Changeset in webkit [161647] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Speculative build fix for Windows following <http://trac.webkit.org/changeset/161638>
(https://bugs.webkit.org/show_bug.cgi?id=126698)

  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):

10:15 AM Changeset in webkit [161646] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

Unreviewed test correction after r161605.

  • platform/mac/TestExpectations: Reactivate tests fixed by

https://bugs.webkit.org/show_bug.cgi?id=126718.

10:12 AM Changeset in webkit [161645] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[WebGL] Wrong condition order in the if statement
https://bugs.webkit.org/show_bug.cgi?id=125000

Patch by Przemyslaw Szymanski <p.szymanski3@samsung.com> on 2014-01-10
Reviewed by Brent Fulgham.

We should only pay the cost of string comparison once. The
current logic requires a string comparison every time we
pass through the function. Instead, by reordering the statements
we can short-circuit through the boolean test after the initial
setup is complete.

No new tests. No behaviour changes.

  • platform/graphics/opengl/Extensions3DOpenGLES.cpp:

(WebCore::Extensions3DOpenGLES::supportsExtension):

9:50 AM Changeset in webkit [161644] by andersca@apple.com
  • 8 edits in trunk/Source/WebCore

CTTE in AudioContext::AutoLocker
https://bugs.webkit.org/show_bug.cgi?id=126758

Reviewed by Antti Koivisto.

  • Modules/webaudio/AudioBasicInspectorNode.cpp:

(WebCore::AudioBasicInspectorNode::connect):
(WebCore::AudioBasicInspectorNode::disconnect):

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::setBuffer):

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::refNode):
(WebCore::AudioContext::deleteMarkedNodes):
(WebCore::AudioContext::removeMarkedSummingJunction):

  • Modules/webaudio/AudioContext.h:

(WebCore::AudioContext::AutoLocker::AutoLocker):
(WebCore::AudioContext::AutoLocker::~AutoLocker):

  • Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::connect):
(WebCore::AudioNode::disconnect):
(WebCore::AudioNode::setChannelCount):
(WebCore::AudioNode::setChannelCountMode):
(WebCore::AudioNode::setChannelInterpretation):
(WebCore::AudioNode::enableOutputsIfNecessary):

  • Modules/webaudio/MediaElementAudioSourceNode.cpp:

(WebCore::MediaElementAudioSourceNode::setFormat):

  • Modules/webaudio/WaveShaperNode.cpp:

(WebCore::WaveShaperNode::setOversample):

9:45 AM Changeset in webkit [161643] by Antti Koivisto
  • 6 edits in trunk/Source/WebCore

Use element iterators more
https://bugs.webkit.org/show_bug.cgi?id=126756

Reviewed by Anders Carlsson.

  • dom/VisitedLinkState.cpp:

(WebCore::VisitedLinkState::invalidateStyleForAllLinks):
(WebCore::VisitedLinkState::invalidateStyleForLink):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::renderMeter):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::renderProgress):

  • html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::ensureInsertionPointList):

  • style/StyleResolveTree.cpp:
9:37 AM Changeset in webkit [161642] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Attempt to fix the iOS build after <http://trac.webkit.org/changeset/161589>
(https://bugs.webkit.org/show_bug.cgi?id=126654)

  • platform/audio/ios/AudioSessionIOS.mm: Import header PassOwnPtr.h so that we can use adoptPtr().
9:19 AM Changeset in webkit [161641] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Attempt to fix the build after <http://trac.webkit.org/changeset/161638>
(https://bugs.webkit.org/show_bug.cgi?id=126698)

Substitute tab characters for space characters.

  • DerivedSources.make:
9:17 AM Changeset in webkit [161640] by commit-queue@webkit.org
  • 3 edits in trunk/WebKitLibraries

[WinCairo] Crash when rendering (in pixman dll)
https://bugs.webkit.org/show_bug.cgi?id=126750

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-01-10
Reviewed by Brent Fulgham.

Since we link with cairo.lib, and the gstreamer installation also comes with cairo.lib,
we link with the wrong cairo.lib, and loads gstreamers cairo dll, instead of our own.
We should user our own cairo dll for rendering.

  • win/tools/vsprops/GStreamer32.props: Put gstreamer lib path last, so we link with the correct cairo.lib.
  • win/tools/vsprops/GStreamer64.props: Ditto.
9:07 AM Changeset in webkit [161639] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

DOMWindow::showModalDialog should use std::function
https://bugs.webkit.org/show_bug.cgi?id=126753

Reviewed by Antti Koivisto.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::DialogHandler::dialogCreated):
(WebCore::JSDOMWindow::showModalDialog):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::createWindow):
(WebCore::DOMWindow::showModalDialog):

  • page/DOMWindow.h:
9:06 AM Changeset in webkit [161638] by dbates@webkit.org
  • 107 edits
    2 copies
    27 adds in trunk

[iOS] Upstream WebCore and Tools miscellaneous changes
https://bugs.webkit.org/show_bug.cgi?id=126698

Reviewed by David Kilzer.

Source/WebCore:

  • Configurations/Base.xcconfig:
  • Configurations/WebCore.xcconfig:
  • Configurations/WebCoreTestSupport.xcconfig:
  • Configurations/iOS.xcconfig: Added.
  • DerivedSources.make:
  • English.lproj/Localizable.strings:
  • Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.cpp: Copied from Source/WebCore/editing/TextAffinity.h.

(WebCore::stringForPlaybackTargetAvailability):
(WebCore::WebKitPlaybackTargetAvailabilityEvent::WebKitPlaybackTargetAvailabilityEvent):

  • Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.h: Added.

(WebCore::WebKitPlaybackTargetAvailabilityEventInit::WebKitPlaybackTargetAvailabilityEventInit):
(WebCore::WebKitPlaybackTargetAvailabilityEvent::~WebKitPlaybackTargetAvailabilityEvent):
(WebCore::WebKitPlaybackTargetAvailabilityEvent::create):
(WebCore::WebKitPlaybackTargetAvailabilityEvent::availability):

  • Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.idl: Copied from Source/WebCore/editing/DeleteButton.h.
  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::Geolocation):
(WebCore::Geolocation::canSuspend):
(WebCore::Geolocation::suspend):
(WebCore::Geolocation::resume):
(WebCore::Geolocation::resumeTimerFired):
(WebCore::Geolocation::resetAllGeolocationPermission):
(WebCore::Geolocation::stop):
(WebCore::Geolocation::setIsAllowed):
(WebCore::Geolocation::positionChanged):
(WebCore::Geolocation::setError):

  • Modules/geolocation/Geolocation.h:
  • Modules/geolocation/NavigatorGeolocation.cpp:

(WebCore::NavigatorGeolocation::resetAllGeolocationPermission):

  • Modules/geolocation/NavigatorGeolocation.h:
  • Modules/speech/SpeechSynthesis.cpp:

(WebCore::SpeechSynthesis::SpeechSynthesis):
(WebCore::SpeechSynthesis::speak):

  • Modules/speech/SpeechSynthesis.h:

(WebCore::SpeechSynthesis::userGestureRequiredForSpeechStart):
(WebCore::SpeechSynthesis::removeBehaviorRestriction):

  • Modules/webaudio/AudioContext.cpp:
  • Modules/webaudio/AudioContext.h:
  • Modules/webaudio/AudioScheduledSourceNode.cpp:
  • Modules/webdatabase/Database.cpp:
  • Modules/webdatabase/DatabaseBackendBase.cpp:

(WebCore::DatabaseBackendBase::performOpenAndVerify):
(WebCore::DatabaseBackendBase::incrementalVacuumIfNeeded):

  • Modules/webdatabase/DatabaseContext.cpp:

(WebCore::DatabaseContext::DatabaseContext):
(WebCore::DatabaseContext::databaseThread):
(WebCore::DatabaseContext::setPaused):

  • Modules/webdatabase/DatabaseContext.h:
  • Modules/webdatabase/DatabaseManagerClient.h:
  • Modules/webdatabase/DatabaseTask.cpp:

(WebCore::DatabaseTask::performTask):
(WebCore::Database::DatabaseTransactionTask::shouldPerformWhilePaused):

  • Modules/webdatabase/DatabaseTask.h:
  • Modules/webdatabase/DatabaseThread.cpp:

(WebCore::DatabaseThread::DatabaseThread):
(WebCore::DatabaseThread::requestTermination):
(WebCore::DatabaseUnpauseTask::create):
(WebCore::DatabaseUnpauseTask::shouldPerformWhilePaused):
(WebCore::DatabaseUnpauseTask::DatabaseUnpauseTask):
(WebCore::DatabaseUnpauseTask::doPerformTask):
(WebCore::DatabaseUnpauseTask::debugTaskName):
(WebCore::DatabaseThread::setPaused):
(WebCore::DatabaseThread::handlePausedQueue):
(WebCore::DatabaseThread::databaseThread):

  • Modules/webdatabase/DatabaseThread.h:
  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::setQuota):
(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::deleteDatabase):
(WebCore::DatabaseTracker::deleteDatabaseFile):
(WebCore::DatabaseTracker::removeDeletedOpenedDatabases):
(WebCore::isZeroByteFile):
(WebCore::DatabaseTracker::deleteDatabaseFileIfEmpty):
(WebCore::DatabaseTracker::openDatabaseMutex):
(WebCore::DatabaseTracker::emptyDatabaseFilesRemovalTaskWillBeScheduled):
(WebCore::DatabaseTracker::emptyDatabaseFilesRemovalTaskDidFinish):
(WebCore::DatabaseTracker::setDatabasesPaused):

  • Modules/webdatabase/DatabaseTracker.h:
  • Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::shouldPerformWhilePaused):

  • Modules/webdatabase/SQLTransactionBackend.h:
  • Resources/DictationPhraseWithAlternativesDot.png: Added.
  • Resources/DictationPhraseWithAlternativesDot@2x.png: Added.
  • Resources/SpellingDot.png: Added.
  • Resources/SpellingDot@2x.png: Added.
  • Resources/decrementArrow.tiff: Added.
  • Resources/hScrollControl_left.png: Added.
  • Resources/hScrollControl_middle.png: Added.
  • Resources/hScrollControl_right.png: Added.
  • Resources/incrementArrow.tiff: Added.
  • Resources/markedLeft.png: Added.
  • Resources/markedMiddle.png: Added.
  • Resources/markedRight.png: Added.
  • Resources/vScrollControl_bottom.png: Added.
  • Resources/vScrollControl_middle.png: Added.
  • Resources/vScrollControl_top.png: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/GCController.cpp:

(WebCore::GCController::garbageCollectNow):
(WebCore::GCController::releaseExecutableMemory):

  • bindings/js/GCController.h:
  • bindings/js/JSCallbackData.h:

(WebCore::JSCallbackData::~JSCallbackData):

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::supportsProfiling):
(WebCore::JSDOMWindowBase::shouldInterruptScriptBeforeTimeout):
(WebCore::JSDOMWindowBase::commonVM):
(WebCore::JSDOMWindowBase::commonVMExists):
(WebCore::JSDOMWindowBase::commonVMInternal):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::touch):
(WebCore::JSDOMWindow::touchList):

  • bindings/js/JSDeviceOrientationEventCustom.cpp:

(WebCore::JSDeviceOrientationEvent::webkitCompassHeading):
(WebCore::JSDeviceOrientationEvent::webkitCompassAccuracy):
(WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):

  • bindings/js/JSMainThreadExecState.h:
  • bindings/js/JSTouchCustom.cpp:
  • bindings/js/JSTouchListCustom.cpp:
  • bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::didContinue):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::initializeThreading):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::handlePause):

  • bindings/js/ios/TouchConstructors.cpp: Added.
  • bindings/objc/DOM.mm:

(WebCore::wkQuadFromFloatQuad):
(WebCore::kit):
(WebCore::min4):
(WebCore::max4):
(WebCore::emptyQuad):
(-[WKQuadObject initWithQuad:]):
(-[WKQuadObject quad]):
(-[WKQuadObject boundingBox]):
(-[DOMNode boundingBox]):
(-[DOMNode absoluteQuad]):
(-[DOMNode absoluteQuadAndInsideFixedPosition:]):
(-[DOMNode boundingBoxUsingTransforms]):
(-[DOMNode lineBoxQuads]):
(-[DOMNode _linkElement]):
(-[DOMNode hrefURL]):
(-[DOMNode hrefTarget]):
(-[DOMNode hrefFrame]):
(-[DOMNode hrefLabel]):
(-[DOMNode hrefTitle]):
(-[DOMNode boundingFrame]):
(-[DOMNode innerFrameQuad]):
(-[DOMNode computedFontSize]):
(-[DOMNode nextFocusNode]):
(-[DOMNode previousFocusNode]):
(-[DOMRange boundingBox]):
(-[DOMRange renderedImageForcingBlackText:renderedImageForcingBlackText:]):
(-[DOMElement _font]):
(-[DOMHTMLLinkElement _mediaQueryMatchesForOrientation:]):
(-[DOMHTMLLinkElement _mediaQueryMatches]):

  • bindings/objc/DOMEvents.h:
  • bindings/objc/DOMEvents.mm:

(kitClass):

  • bindings/objc/DOMExtensions.h:
  • bindings/objc/DOMHTML.mm:

(-[DOMHTMLElement scrollYOffset]):
(-[DOMHTMLElement setScrollXOffset:scrollYOffset:]):
(-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
(-[DOMHTMLElement absolutePosition::::]):
(-[DOMHTMLInputElement _autocapitalizeType]):
(-[DOMHTMLTextAreaElement _autocapitalizeType]):
(-[DOMHTMLInputElement setValueWithChangeEvent:]):
(-[DOMHTMLInputElement setValueAsNumberWithChangeEvent:]):

  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMInternal.mm:

(wrapperCacheLock):
(getDOMWrapper):
(addDOMWrapper):
(removeDOMWrapper):

  • bindings/objc/DOMPrivate.h:
  • bindings/objc/DOMUIKitExtensions.h: Added.
  • bindings/objc/DOMUIKitExtensions.mm: Added.
  • bindings/objc/PublicDOMInterfaces.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeaderContentHeader):
(GenerateImplementationContentHeader):
(GenerateHeader):
(GenerateImplementation):
(GenerateCallbackImplementation):

  • bindings/scripts/CodeGeneratorObjC.pm:

(ReadPublicInterfaces):
(GetClassName):
(IsCoreFoundationType):
(GetObjCType):
(AddIncludesForType):
(GenerateHeader):
(GenerateImplementation):
(WriteData):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):

  • bridge/objc/objc_class.mm:

(JSC::Bindings::ObjcClass::fieldNamed):

  • bridge/objc/objc_instance.mm:
  • config.h:
  • dom/Document.cpp:

(WebCore::Document::addAutoSizingNode):

  • dom/Document.h:
  • dom/Document.idl:
  • dom/ios/TouchEvents.cpp: Added.
  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyBlockStyle):

  • editing/CompositeEditCommand.cpp:

(WebCore::EditCommandComposition::unapply):
(WebCore::CompositeEditCommand::apply):
(WebCore::CompositeEditCommand::inputText):
(WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
(WebCore::CompositeEditCommand::moveParagraphs):

  • editing/CompositeEditCommand.h:
  • editing/DeleteButton.h:
  • editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::enable):
(WebCore::DeleteButtonController::disable):

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::doApply):

  • editing/DeleteSelectionCommand.h:
  • editing/EditAction.h:
  • editing/EditCommand.h:

(WebCore::EditCommand::isInsertTextCommand):

  • editing/EditingStyle.cpp:
  • editing/Editor.cpp:

(WebCore::ClearTextCommand::ClearTextCommand):
(WebCore::ClearTextCommand::editingAction):
(WebCore::ClearTextCommand::CreateAndApply):
(WebCore::Editor::handleTextEvent):
(WebCore::Editor::clearText):
(WebCore::Editor::insertDictationPhrases):
(WebCore::Editor::setDictationPhrasesAsChildOfElement):
(WebCore::Editor::confirmMarkedText):
(WebCore::Editor::setTextAsChildOfElement):
(WebCore::Editor::notifyComponentsOnChangedSelection):
(WebCore::Editor::ensureLastEditCommandHasCurrentSelectionIfOpenForMoreTyping):
(WebCore::Editor::copy):
(WebCore::Editor::setBaseWritingDirection):
(WebCore::Editor::setComposition):
(WebCore::Editor::showSpellingGuessPanel):
(WebCore::Editor::markMisspellingsAfterTypingToWord):
(WebCore::Editor::markMisspellingsOrBadGrammar):
(WebCore::Editor::changeBackToReplacedString):
(WebCore::Editor::updateMarkersForWordsAffectedByEditing):
(WebCore::Editor::setIgnoreCompositionSelectionChange):
(WebCore::Editor::changeSelectionAfterCommand):
(WebCore::Editor::shouldChangeSelection):
(WebCore::Editor::respondToChangedSelection):
(WebCore::Editor::resolveTextCheckingTypeMask):

  • editing/Editor.h:
  • editing/EditorCommand.cpp:

(WebCore::executeClearText):
(WebCore::enabledCopy):
(WebCore::enabledCut):
(WebCore::enabledClearText):
(WebCore::createCommandMap):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::FrameSelection):
(WebCore::FrameSelection::setSelection):
(WebCore::FrameSelection::modifyExtendingRight):
(WebCore::FrameSelection::modifyExtendingForward):
(WebCore::FrameSelection::modifyMovingRight):
(WebCore::FrameSelection::modifyMovingForward):
(WebCore::FrameSelection::modifyExtendingLeft):
(WebCore::FrameSelection::modifyExtendingBackward):
(WebCore::FrameSelection::modifyMovingLeft):
(WebCore::FrameSelection::modifyMovingBackward):
(WebCore::FrameSelection::setSelectedRange):
(WebCore::FrameSelection::focusedOrActiveStateChanged):
(WebCore::FrameSelection::updateAppearance):
(WebCore::FrameSelection::shouldDeleteSelection):
(WebCore::FrameSelection::revealSelection):
(WebCore::FrameSelection::setSelectionFromNone):
(WebCore::FrameSelection::shouldChangeSelection):
(WebCore::FrameSelection::expandSelectionToElementContainingCaretSelection):
(WebCore::FrameSelection::elementRangeContainingCaretSelection):
(WebCore::FrameSelection::expandSelectionToWordContainingCaretSelection):
(WebCore::FrameSelection::wordRangeContainingCaretSelection):
(WebCore::FrameSelection::expandSelectionToStartOfWordContainingCaretSelection):
(WebCore::FrameSelection::characterInRelationToCaretSelection):
(WebCore::FrameSelection::characterBeforeCaretSelection):
(WebCore::FrameSelection::characterAfterCaretSelection):
(WebCore::FrameSelection::wordOffsetInRange):
(WebCore::FrameSelection::spaceFollowsWordInRange):
(WebCore::FrameSelection::selectionAtDocumentStart):
(WebCore::FrameSelection::selectionAtSentenceStart):
(WebCore::FrameSelection::selectionAtWordStart):
(WebCore::FrameSelection::rangeByMovingCurrentSelection):
(WebCore::FrameSelection::rangeByExtendingCurrentSelection):
(WebCore::FrameSelection::selectRangeOnElement):
(WebCore::FrameSelection::wordSelectionContainingCaretSelection):
(WebCore::FrameSelection::actualSelectionAtSentenceStart):
(WebCore::FrameSelection::rangeByAlteringCurrentSelection):
(WebCore::FrameSelection::clearCurrentSelection):
(WebCore::FrameSelection::setCaretBlinks):
(WebCore::FrameSelection::setCaretColor):

  • editing/FrameSelection.h:

(WebCore::FrameSelection::suppressCloseTyping):
(WebCore::FrameSelection::restoreCloseTyping):
(WebCore::FrameSelection::setUpdateAppearanceEnabled):
(WebCore::FrameSelection::suppressScrolling):
(WebCore::FrameSelection::restoreScrolling):

  • editing/InsertIntoTextNodeCommand.cpp:

(WebCore::InsertIntoTextNodeCommand::doReapply):

  • editing/InsertIntoTextNodeCommand.h:
  • editing/InsertTextCommand.h:
  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::doApply):

  • editing/TextAffinity.h:
  • editing/TextCheckingHelper.cpp:
  • editing/TextGranularity.h:
  • editing/TextIterator.cpp:

(WebCore::isRendererReplacedElement):

  • editing/TypingCommand.cpp:

(WebCore::TypingCommand::ensureLastEditCommandHasCurrentSelectionIfOpenForMoreTyping):
(WebCore::TypingCommand::markMisspellingsAfterTyping):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
(WebCore::FriendlyEditCommand::setEndingSelection):
(WebCore::TypingCommand::setEndingSelectionOnLastInsertCommand):

  • editing/TypingCommand.h:
  • editing/VisiblePosition.h:

(WebCore::operator<):
(WebCore::operator>):
(WebCore::operator<=):
(WebCore::operator>=):

  • editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity):
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):

  • editing/VisibleUnits.cpp:

(WebCore::previousBoundary):
(WebCore::nextBoundary):
(WebCore::startOfDocument):
(WebCore::endOfDocument):
(WebCore::directionIsDownstream):
(WebCore::atBoundaryOfGranularity):
(WebCore::withinTextUnitOfGranularity):
(WebCore::nextCharacterBoundaryInDirection):
(WebCore::nextWordBoundaryInDirection):
(WebCore::nextSentenceBoundaryInDirection):
(WebCore::nextLineBoundaryInDirection):
(WebCore::nextParagraphBoundaryInDirection):
(WebCore::nextDocumentBoundaryInDirection):
(WebCore::positionOfNextBoundaryOfGranularity):
(WebCore::enclosingTextUnitOfGranularity):
(WebCore::distanceBetweenPositions):
(WebCore::wordRangeFromPosition):
(WebCore::closestWordBoundaryForPosition):

  • editing/VisibleUnits.h:
  • editing/ios/DictationCommandIOS.cpp: Added.
  • editing/ios/DictationCommandIOS.h: Added.

(WebCore::DictationCommandIOS::create):
(WebCore::DictationCommandIOS::editingAction):

  • editing/mac/FrameSelectionMac.mm:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

  • fileapi/AsyncFileStream.cpp:
  • generate-export-file: Added.
  • inspector/InspectorCounters.h:
  • inspector/InspectorFrontendHost.h:
  • make-export-file-generator:
  • plugins/PluginPackage.h:
  • plugins/PluginViewBase.h:

(WebCore::PluginViewBase::willProvidePluginLayer):
(WebCore::PluginViewBase::attachPluginLayer):
(WebCore::PluginViewBase::detachPluginLayer):

  • style/StyleResolveForDocument.cpp:

(WebCore::Style::resolveForDocument):

  • style/StyleResolveTree.cpp:

(WebCore::Style::elementImplicitVisibility):

  • testing/Internals.cpp:

(WebCore::Internals::getCurrentCursorInfo):
(WebCore::Internals::isSelectPopupVisible):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread):

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

  • MigrateHeaders.make:

Tools:

  • Scripts/check-for-inappropriate-objc-class-names:
  • Scripts/check-for-webkit-framework-include-consistency:
8:55 AM Changeset in webkit [161637] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the iOS build after <http://trac.webkit.org/changeset/161589>
(https://bugs.webkit.org/show_bug.cgi?id=126654)

  • platform/graphics/ios/MediaPlayerPrivateIOS.h:

(WebCore::MediaPlayerPrivateIOS::engineDescription): Adding missing return keyword.

8:31 AM Changeset in webkit [161636] by abucur@adobe.com
  • 3 edits in trunk/Source/WebCore

[CSS Regions] Remove unused CSSParser::parseFlowThread
https://bugs.webkit.org/show_bug.cgi?id=126749

Reviewed by Antti Koivisto.

There are two versions of CSSParser::parseFlowThread. Remove the unused one:
bool parseFlowThread(const String& flowName);

Tests: No tests, code cleanup.

  • css/CSSParser.cpp:
  • css/CSSParser.h:
8:27 AM Changeset in webkit [161635] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Build fix after r161589.
https://bugs.webkit.org/show_bug.cgi?id=126747

Patch by Alex Christensen <achristensen@webkit.org> on 2014-01-10
Reviewed by Anders Carlsson.

  • platform/network/ResourceHandle.cpp:

Include NotImplemented.h for all platforms.

8:19 AM Changeset in webkit [161634] by andersca@apple.com
  • 9 edits in trunk/Source/WebCore

Convert some for loops over to range-based for
https://bugs.webkit.org/show_bug.cgi?id=126752

Reviewed by Antti Koivisto.

  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources):

  • loader/appcache/ApplicationCache.cpp:

(WebCore::ApplicationCache::clearStorageID):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
(WebCore::ApplicationCacheGroup::clearStorageID):

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::fillResourceList):

  • loader/appcache/ApplicationCacheResource.cpp:

(WebCore::ApplicationCacheResource::estimatedSizeInStorage):

  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::cacheGroupForURL):

  • loader/archive/ArchiveFactory.cpp:

(WebCore::ArchiveFactory::registerKnownArchiveMIMETypes):

  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::styleAvailable):
(WebCore::AnimationControllerPrivate::startTimeResponse):

7:40 AM Changeset in webkit [161633] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Tighten up two functions in the inspector code
https://bugs.webkit.org/show_bug.cgi?id=126751

Reviewed by Antti Koivisto.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::frameStartedLoadingImpl):
(WebCore::InspectorInstrumentation::frameStoppedLoadingImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::frameStartedLoading):
(WebCore::InspectorInstrumentation::frameStoppedLoading):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::frameStartedLoading):
(WebCore::InspectorPageAgent::frameStoppedLoading):

  • inspector/InspectorPageAgent.h:
6:30 AM Changeset in webkit [161632] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Add missing function stub in InspectorFrontendHostStub.js
https://bugs.webkit.org/show_bug.cgi?id=126745

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2014-01-10
Reviewed by Timothy Hatcher.

  • UserInterface/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.debuggableType):
The function debuggableType() was added to InspectorFrontendHost.idl and InspectorFrontendHost.cpp
in r160887, but not to InspectorFrontendHostStub.js.

4:47 AM Changeset in webkit [161631] by mihnea@adobe.com
  • 5 edits in trunk/LayoutTests

[CSSRegions] Disable accelerated compositing for fixed elements in regions tests
https://bugs.webkit.org/show_bug.cgi?id=126743

Reviewed by Dirk Schulze.

Once we enable the support of accelerated compositing for fixed positioned elements in regions
in https://bugs.webkit.org/show_bug.cgi?id=125144, those tests will be added into compositing/regions as well.

  • fast/regions/fixed-inside-fixed-in-named-flow-expected.html:
  • fast/regions/fixed-inside-fixed-in-named-flow.html:
  • fast/regions/fixed-pos-elem-in-region-expected.html:
  • fast/regions/fixed-pos-elem-in-region.html:
4:33 AM Changeset in webkit [161630] by Antti Koivisto
  • 3 edits
    2 adds in trunk

Crash when mutating SVG text with transform
https://bugs.webkit.org/show_bug.cgi?id=126744

Reviewed by Dirk Schulze.

Source/WebCore:

Test: svg/custom/mutation-text-transform-crash.html

Text-transform property triggers subtreeTextDidChange when an SVG text renderer is
being added to the render tree. The function assumes the child is already fully in the tree
but in this case we are still in middle of adding it.

  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::subtreeTextDidChange):

Bail out if the changed RenderSVGInlineText can't be found from m_layoutAttributes.
This means that subtreeChildWasAdded hasn't been invoked yet for it and there is nothing
to update. The required updates will happen in subtreeChildWasAdded.

LayoutTests:

  • svg/custom/mutation-text-transform-crash-expected.txt: Added.
  • svg/custom/mutation-text-transform-crash.html: Added.
4:03 AM Changeset in webkit [161629] by commit-queue@webkit.org
  • 4 edits
    7 adds in trunk

[SVG] Accept HTML and MathML namespaces as valid requiredExtensions
https://bugs.webkit.org/show_bug.cgi?id=88188

Patch by Frédéric Wang <fred.wang@free.fr> on 2014-01-10
Reviewed by Dirk Schulze.

Source/WebCore:

When HTML and MathML are used as foreign objects of an SVG image, it is
important for Web authors to be able to specify a fallback content for
SVG-only readers or browsers without MathML support. We rely on the
requiredExtensions for that purpose and we use the XHTML/MathML
namespaces as suggested in SVG Tiny 1.2 and implemented in Gecko.

Tests: svg/custom/conditional-processing-1.svg

svg/custom/conditional-processing-2.html
svg/dom/SVGTests.html

  • svg/SVGSwitchElement.cpp: Remove an incorrect FIXME comment and replace it with a reference to bug 74749.

(WebCore::SVGSwitchElement::childShouldCreateRenderer):

  • svg/SVGTests.cpp: Check if the list of required extensions contains only the XHTML/MathML namespaces.

(WebCore::SVGTests::hasExtension):
(WebCore::SVGTests::isValid):

LayoutTests:

conditional-processing-1 verifies that indeed a renderer object is only
created for the first "valid" SVG element of a <switch>, contrary to
what an incorrect FIXME comment said. conditional-processing-2 verifies
that the <switch> takes into account XHTML and MathML namespaces in the
requiredExtensions attribute to decide which SVG element is "valid".
SVGTests.html verifies the SVGTests interface of SVG DOM: three
SVGStringList attributes (already tested in svg/dom/SVGStringList.html)
and the hasExtension() function.

  • svg/custom/conditional-processing-1-expected.txt: Added.
  • svg/custom/conditional-processing-1.svg: Added.
  • svg/custom/conditional-processing-2-expected.txt: Added.
  • svg/custom/conditional-processing-2.html: Added.
  • svg/dom/SVGTests-expected.txt: Added.
  • svg/dom/SVGTests.html: Added.
  • svg/dom/script-tests/SVGTests.js: Added.
3:30 AM Changeset in webkit [161628] by commit-queue@webkit.org
  • 18 edits
    15 adds in trunk

Add support for blendmode to Core Animation layer.
Patch by Rik Cabanier, Dean Jackson and Mihai Tica.

https://bugs.webkit.org/show_bug.cgi?id=99200

Patch by Mihai Tica <mitica@adobe.com> on 2014-01-10
Reviewed by Dirk Schulze.

Source/WebCore:

Tests: css3/compositing/blend-mode-layers.html

css3/compositing/blend-mode-overflow.html
css3/compositing/blend-mode-reflection.html
css3/compositing/blend-mode-should-not-have-compositing-layer.html
css3/compositing/blend-mode-simple.html

  • WebCore.exp.in: export PlatformCALayer::setBlendMode for WebKit::PlatformCALayerRemote
  • WebCore.xcodeproj/project.pbxproj: Add PlatformCAFiltersMac.h
  • platform/graphics/GraphicsLayer.cpp: add blendMode member

(WebCore::GraphicsLayer::GraphicsLayer):

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::blendMode):
(WebCore::GraphicsLayer::setBlendMode):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setBlendMode):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): add call to updateBlendMode()
(WebCore::GraphicsLayerCA::updateBlendMode):

  • platform/graphics/ca/GraphicsLayerCA.h:
  • platform/graphics/ca/PlatformCAFilters.h:
  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/mac/PlatformCAFiltersMac.h: Added.
  • platform/graphics/ca/mac/PlatformCAFiltersMac.mm:

(PlatformCAFilters::setBlendingFiltersOnLayer): set a compositing CAFilter on CALayer

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::setBlendMode): call to PlatformCAFilters::setBlendingFiltersOnLayer

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
(WebCore::RenderLayerBacking::updateBlendMode):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::setBlendMode):

  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::CompositingState::CompositingState): add m_subtreeHasBlending member
(WebCore::RenderLayerCompositor::computeCompositingRequirements): promote layer if subtree has blending
(WebCore::RenderLayerCompositor::reasonsForCompositing):
(WebCore::RenderLayerCompositor::logReasonsForCompositing): log blending reason
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason): add blending reason

  • rendering/RenderLayerCompositor.h:

LayoutTests:

  • css3/compositing/blend-mode-layers.html: Added.
  • css3/compositing/blend-mode-overflow-expected.txt: Added.
  • css3/compositing/blend-mode-overflow.html: Added.
  • css3/compositing/blend-mode-reflection.html: Added.
  • css3/compositing/blend-mode-should-not-have-compositing-layer-expected.txt: Added.
  • css3/compositing/blend-mode-should-not-have-compositing-layer.html: Added.
  • css3/compositing/blend-mode-simple.html: Added.
  • css3/compositing/should-have-compositing-layer-expected.txt:
  • platform/efl/TestExpectations: Efl doesn't support blend modes at the moment.
  • platform/mac/css3/compositing/blend-mode-layers-expected.png: Added.
  • platform/mac/css3/compositing/blend-mode-layers-expected.txt: Added.
  • platform/mac/css3/compositing/blend-mode-overflow-expected.png: Added.
  • platform/mac/css3/compositing/blend-mode-reflection-expected.png: Added.
  • platform/mac/css3/compositing/blend-mode-reflection-expected.txt: Added.
  • platform/mac/css3/compositing/blend-mode-simple-expected.png: Added.
  • platform/mac/css3/compositing/blend-mode-simple-expected.txt: Added.
3:17 AM Changeset in webkit [161627] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

[EFL] Enable the DFG_JIT on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=126742

Patch by Hunseop Jeong <Hunseop Jeong> on 2014-01-10
Reviewed by Gyuyoung Kim.

Turn on ENABLE_DFG_JIT on ARMv7 for EFL.

  • wtf/Platform.h:
2:38 AM Changeset in webkit [161626] by abucur@adobe.com
  • 8 edits
    10 adds in trunk

[CSS Regions] Implement visual overflow computation for inline elements
https://bugs.webkit.org/show_bug.cgi?id=125291

Reviewed by David Hyatt.

Source/WebCore:

The patch implements visual overflow computation for inline elements per region. The algorithm
uses the container region of each root line box to determine the lines in a region generated by
a RenderInline. The overflow of a RenderInline inside a region is the smallest rectangle that fits
all the line boxes belonging to that region.

The patch also correctly flips for writing mode the overflow of a renderer before clipping with it.

Tests: fast/regions/overflow-in-variable-width-regions-inline-bt.html

fast/regions/overflow-in-variable-width-regions-inline-continuation.html
fast/regions/overflow-in-variable-width-regions-inline-lr.html
fast/regions/overflow-in-variable-width-regions-inline-rl.html
fast/regions/overflow-in-variable-width-regions-inline.html

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::objectShouldPaintInFlowRegion):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::updateAlwaysCreateLineBoxes): Always create line boxes for RenderInline
(WebCore::RenderInline::linesVisualOverflowBoundingBoxInRegion):

  • rendering/RenderInline.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::visualOverflowRectForBox):
(WebCore::RenderRegion::visualOverflowRectForBoxForPropagation):

  • rendering/RenderRegion.h:

LayoutTests:

Tests for inline elements overflow correct painting inside regions.

  • fast/regions/overflow-in-variable-width-regions-inline-bt-expected.html: Added.
  • fast/regions/overflow-in-variable-width-regions-inline-bt.html: Added.
  • fast/regions/overflow-in-variable-width-regions-inline-continuation-expected.html: Added.
  • fast/regions/overflow-in-variable-width-regions-inline-continuation.html: Added.
  • fast/regions/overflow-in-variable-width-regions-inline-expected.html: Added.
  • fast/regions/overflow-in-variable-width-regions-inline-lr-expected.html: Added.
  • fast/regions/overflow-in-variable-width-regions-inline-lr.html: Added.
  • fast/regions/overflow-in-variable-width-regions-inline-rl-expected.html: Added.
  • fast/regions/overflow-in-variable-width-regions-inline-rl.html: Added.
  • fast/regions/overflow-in-variable-width-regions-inline.html: Added.
1:11 AM Changeset in webkit [161625] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

Implement NetworkResourceLoader::receivedCancellation
https://bugs.webkit.org/show_bug.cgi?id=126129

Reviewed Alexey Proskuryakov.

Implement ResourceHandleClient::receivedCancellation() in the
network process to cancel the load when cancellation is received
from the authentication manager like the web process does.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::receivedCancellation): Cancel the load.

  • NetworkProcess/NetworkResourceLoader.h:
12:00 AM Changeset in webkit [161624] by jinwoo7.song@samsung.com
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Add APIs for setting and getting the default text encoding name
https://bugs.webkit.org/show_bug.cgi?id=126736

Reviewed by Gyuyoung Kim.

Add APIs to set and get the default text encoding name.

  • UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_default_text_encoding_name_get):
(ewk_settings_default_text_encoding_name_set):

  • UIProcess/API/efl/ewk_settings.h:
  • UIProcess/API/efl/tests/test_ewk2_settings.cpp:

(TEST_F):

Jan 9, 2014:

11:26 PM Changeset in webkit [161623] by jer.noble@apple.com
  • 4 edits
    2 adds in trunk

[Mac] .mp3 media document controls missing their background
https://bugs.webkit.org/show_bug.cgi?id=126683

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-document-audio-controls-visible.html

<video> elements in a media document are created with an intrinsic size of 300x1,
with the expectation that either the size will be updated if the media has a video
track, or the controls will visibly overflow if the media is audio-only. Since the
shadow root is a flex-box, the panel was being collapsed to 1px high, so give the panel
a minimum height to prevent that. Also, disable "fading out" the controls in a
media document for an audio-only file by adding a "no-video" class to the panel
and adding a media document-only rule to force the controls to always be visible.

  • Modules/mediacontrols/mediaControlsApple.css:

(video:-webkit-full-page-media::-webkit-media-controls-panel.no-video):
(audio::-webkit-media-controls-panel):

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller): Call updateHasVideo().
(Controller.prototype.addVideoListeners): Add video track listeners.
(Controller.prototype.removeVideoListeners): Remove same.
(Controller.prototype.updateHasVideo): Add a 'no-video' class to the panel if

the video element has no video tracks.

LayoutTests:

  • media/media-document-audio-controls-visible-expected.txt: Added.
  • media/media-document-audio-controls-visible.html: Added.
11:19 PM Changeset in webkit [161622] by andersca@apple.com
  • 6 edits in trunk/Source/WebCore

Clean up ProgressTracker a little
https://bugs.webkit.org/show_bug.cgi?id=126738

Reviewed by Dan Bernstein.

Use Frame& where the frame can never be null, avoid an extra hash lookup and
switch the m_progressItems map over to std::unique_ptr.

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::frameStartedLoading):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::FrameProgressTracker::~FrameProgressTracker):
(WebCore::FrameLoader::FrameProgressTracker::progressStarted):
(WebCore::FrameLoader::FrameProgressTracker::progressCompleted):

  • loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::progressStarted):
(WebCore::ProgressTracker::progressCompleted):
(WebCore::ProgressTracker::incrementProgress):

  • loader/ProgressTracker.h:
  • loader/ResourceLoadNotifier.cpp:

(WebCore::ResourceLoadNotifier::didReceiveData):

10:22 PM Changeset in webkit [161621] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

Fix a build break on EFL debug build
https://bugs.webkit.org/show_bug.cgi?id=126735

Reviewed by Anders Carlsson.

No new tests, just build fix.

  • platform/ThreadTimers.cpp:

(WebCore::ThreadTimers::sharedTimerFiredInternal): Add parentheses.

9:03 PM Changeset in webkit [161620] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Remove unused FrameLoader member functions
https://bugs.webkit.org/show_bug.cgi?id=126734

Reviewed by Andreas Kling.

  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
8:18 PM Changeset in webkit [161619] by Lucas Forschler
  • 3 edits in trunk/Tools

Rollout 161618.

8:08 PM Changeset in webkit [161618] by Lucas Forschler
  • 3 edits in trunk/Tools

Update the LLINT CLoop bot infrastructure.
This will require a build master restart.

Unreviewed.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(CompileLLINTCLoop):
(RunLLINTCloopTests):
(BuildAndTestLLINTCLoopFactory):
(BuildAndTestLLINTCLoopFactory.init):

6:50 PM Changeset in webkit [161617] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Unreviewed Windows build fix for r161563.

Remove stale forward declaration causing namespace ambiguity
later on in a Windows AllInOne file that picked it up. Also
remove a few stale functions that are not used and accidentally
got added back in when the file changed names.

  • bindings/js/ScriptGlobalObject.h:
6:45 PM Changeset in webkit [161616] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

[WebGL] Expose texture_float_linear and texture_half_float to getSupportedExtensions
https://bugs.webkit.org/show_bug.cgi?id=126732

Reviewed by Tim Horton.

When I added support for these two extensions, I forgot to add their
names to the list in getSupportedExtensions.

Covered by the Khronos test: conformance/extensions/get-extension.html

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getSupportedExtensions): Add OES_texture_float_linear
and OES_texture_half_float if the WebGL context supports them.

6:28 PM Changeset in webkit [161615] by mhahnenberg@apple.com
  • 31 edits in trunk/Source

Marking should be generational
https://bugs.webkit.org/show_bug.cgi?id=126552

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Re-marking the same objects over and over is a waste of effort. This patch implements
the sticky mark bit algorithm (along with our already-present write barriers) to reduce
overhead during garbage collection caused by rescanning objects.

There are now two collection modes, EdenCollection and FullCollection. EdenCollections
only visit new objects or objects that were added to the remembered set by a write barrier.
FullCollections are normal collections that visit all objects regardless of their
generation.

In this patch EdenCollections do not do anything in CopiedSpace. This will be fixed in
https://bugs.webkit.org/show_bug.cgi?id=126555.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):

  • bytecode/CodeBlock.h:

(JSC::CodeBlockSet::mark):

  • dfg/DFGOperations.cpp:
  • heap/CodeBlockSet.cpp:

(JSC::CodeBlockSet::add):
(JSC::CodeBlockSet::traceMarked):
(JSC::CodeBlockSet::rememberCurrentlyExecutingCodeBlocks):

  • heap/CodeBlockSet.h:
  • heap/CopiedBlockInlines.h:

(JSC::CopiedBlock::reportLiveBytes):

  • heap/CopiedSpace.cpp:

(JSC::CopiedSpace::didStartFullCollection):

  • heap/CopiedSpace.h:

(JSC::CopiedSpace::heap):

  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::didAbandon):
(JSC::Heap::markRoots):
(JSC::Heap::copyBackingStores):
(JSC::Heap::addToRememberedSet):
(JSC::Heap::collectAllGarbage):
(JSC::Heap::collect):
(JSC::Heap::didAllocate):
(JSC::Heap::writeBarrier):

  • heap/Heap.h:

(JSC::Heap::isInRememberedSet):
(JSC::Heap::operationInProgress):
(JSC::Heap::shouldCollect):
(JSC::Heap::isCollecting):
(JSC::Heap::isWriteBarrierEnabled):
(JSC::Heap::writeBarrier):

  • heap/HeapOperation.h:
  • heap/MarkStack.cpp:

(JSC::MarkStackArray::~MarkStackArray):
(JSC::MarkStackArray::clear):
(JSC::MarkStackArray::fillVector):

  • heap/MarkStack.h:
  • heap/MarkedAllocator.cpp:

(JSC::isListPagedOut):
(JSC::MarkedAllocator::isPagedOut):
(JSC::MarkedAllocator::tryAllocateHelper):
(JSC::MarkedAllocator::addBlock):
(JSC::MarkedAllocator::removeBlock):
(JSC::MarkedAllocator::reset):

  • heap/MarkedAllocator.h:

(JSC::MarkedAllocator::MarkedAllocator):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::clearMarks):
(JSC::MarkedBlock::clearRememberedSet):
(JSC::MarkedBlock::clearMarksWithCollectionType):
(JSC::MarkedBlock::lastChanceToFinalize):

  • heap/MarkedBlock.h: Changed atomSize to 16 bytes because we have no objects smaller

than 16 bytes. This is also to pay for the additional Bitmap for the remembered set.
(JSC::MarkedBlock::didConsumeEmptyFreeList):
(JSC::MarkedBlock::setRemembered):
(JSC::MarkedBlock::clearRemembered):
(JSC::MarkedBlock::atomicClearRemembered):
(JSC::MarkedBlock::isRemembered):

  • heap/MarkedSpace.cpp:

(JSC::MarkedSpace::~MarkedSpace):
(JSC::MarkedSpace::resetAllocators):
(JSC::MarkedSpace::visitWeakSets):
(JSC::MarkedSpace::reapWeakSets):
(JSC::VerifyMarked::operator()):
(JSC::MarkedSpace::clearMarks):

  • heap/MarkedSpace.h:

(JSC::ClearMarks::operator()):
(JSC::ClearRememberedSet::operator()):
(JSC::MarkedSpace::didAllocateInBlock):
(JSC::MarkedSpace::clearRememberedSet):

  • heap/SlotVisitor.cpp:

(JSC::SlotVisitor::~SlotVisitor):
(JSC::SlotVisitor::clearMarkStack):

  • heap/SlotVisitor.h:

(JSC::SlotVisitor::markStack):
(JSC::SlotVisitor::sharedData):

  • heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::internalAppend):
(JSC::SlotVisitor::unconditionallyAppend):
(JSC::SlotVisitor::copyLater):
(JSC::SlotVisitor::reportExtraMemoryUsage):
(JSC::SlotVisitor::heap):

  • jit/Repatch.cpp:
  • runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::visitChildren):

  • runtime/JSPropertyNameIterator.h:

(JSC::StructureRareData::setEnumerationCache):

  • runtime/JSString.cpp:

(JSC::JSString::visitChildren):

  • runtime/StructureRareDataInlines.h:

(JSC::StructureRareData::setPreviousID):
(JSC::StructureRareData::setObjectToStringValue):

  • runtime/WeakMapData.cpp:

(JSC::WeakMapData::visitChildren):

Source/WTF:

  • wtf/Bitmap.h:

(WTF::WordType>::count): Added a cast that became necessary when Bitmap
is used with smaller types than int32_t.

6:02 PM Changeset in webkit [161614] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Revert r161611, incorrect fix, will fix better.

  • bindings/js/ScriptGlobalObject.h:
5:57 PM Changeset in webkit [161613] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebCore

[Mac] Scrubbing performance of HD content with software decoding is poor.
https://bugs.webkit.org/show_bug.cgi?id=126705

Reviewed by Eric Carlson.

Instead of issuing a new seek before the previous one completes, wait until that seek's
completion handler is called, and then issue the new seek. This has the added benefit of
coalescing multiple incoming seeks so that only the last one is acted upon.

Save the parameters passed into seekToTime and bind them together in a std::function
to be replayed once the in-flight seek completes. To handle the case where a completion
handler fires after the media player is destroyed, add a weakPtrFactory and pass a
WeakPtr into the completion handler.

Clean up some ivars which are no longer necessary: remove m_seekCount and m_seekTime.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): Initialize the

WeakPtrFactory.

(WebCore::MediaPlayerPrivateAVFoundation::seekWithTolerance):
(WebCore::MediaPlayerPrivateAVFoundation::seeking): m_seekTime -> m_seeking.
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createWeakPtr):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::seekToTime):
(WebCore::MediaPlayerPrivateAVFoundationObjC::finishSeek):

5:49 PM Changeset in webkit [161612] by jer.noble@apple.com
  • 9 edits
    1 move in trunk/Source/WebCore

[MSE][Mac] Report the intrinsic size of the media element
https://bugs.webkit.org/show_bug.cgi?id=125156

Reviewed by Eric Carlson.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::naturalSize): Pass to MediaSourcePrivateAVFObjC.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::sizeChanged): Added; Pass to MediaPlayer.

  • platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:

(WebCore::MediaSourcePrivateAVFObjC::naturalSize): Return the union of the naturalSizes of all active buffers.

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::didParseStreamDataAsAsset): Notify the media player that the size changed.
(WebCore::SourceBufferPrivateAVFObjC::naturalSize): Return the size of the selected video track.

  • platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.mm: Renamed from Source/WebCore/platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.cpp.

(WebCore::VideoTrackPrivateMediaSourceAVFObjC::assetTrack): Made const.
(WebCore::VideoTrackPrivateMediaSourceAVFObjC::naturalSize): Return the size of the AVAssetTrack.

5:45 PM Changeset in webkit [161611] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Unreviewed Windows build fix for r161563.

Remove stale forward declaration causing namespace ambiguity
later on in a Windows AllInOne file that picked it up.

  • bindings/js/ScriptGlobalObject.h:
5:38 PM Changeset in webkit [161610] by Simon Fraser
  • 16 edits
    4 copies
    3 adds in trunk/Source

Enable async scrolling for iOS
https://bugs.webkit.org/show_bug.cgi?id=126730

Source/WebCore:

Reviewed by Tim Horton.

Turn on ENABLE_ASYNC_SCROLLING for iOS.

Disable rubber-banding and scrollbar-related Mac code for PLATFORM(IOS),
provide stubs for scrolling nodes and scrolling state nodes, and an
iOS scrolling tree, and scrolling coordinator.

Move crollingCoordinator::create() into the platform implementation file.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::create):

  • page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::setScrollbarPaintersFromScrollbars):

  • page/scrolling/ScrollingStateScrollingNode.h:
  • page/scrolling/ScrollingTree.h:

(WebCore::ScrollingTree::isScrollingTreeIOS):

  • page/scrolling/ThreadedScrollingTree.h:
  • page/scrolling/ios/ScrollingCoordinatorIOS.h: Copied from Source/WebKit2/UIProcess/Scrolling/RemoteScrollingTree.h.
  • page/scrolling/ios/ScrollingCoordinatorIOS.mm: Copied from Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm.

(WebCore::ScrollingCoordinator::create):
(WebCore::ScrollingCoordinatorIOS::ScrollingCoordinatorIOS):
(WebCore::ScrollingCoordinatorIOS::~ScrollingCoordinatorIOS):
(WebCore::ScrollingCoordinatorIOS::pageDestroyed):
(WebCore::ScrollingCoordinatorIOS::commitTreeStateIfNeeded):
(WebCore::ScrollingCoordinatorIOS::scheduleTreeStateCommit):
(WebCore::ScrollingCoordinatorIOS::scrollingStateTreeCommitterTimerFired):
(WebCore::ScrollingCoordinatorIOS::commitTreeState):
(WebCore::ScrollingCoordinatorIOS::createScrollingTreeNode):

  • page/scrolling/ios/ScrollingTreeIOS.cpp: Added.

(WebCore::ScrollingTreeIOS::create):
(WebCore::ScrollingTreeIOS::ScrollingTreeIOS):
(WebCore::ScrollingTreeIOS::~ScrollingTreeIOS):
(WebCore::derefScrollingCoordinator):
(WebCore::ScrollingTreeIOS::invalidate):
(WebCore::ScrollingTreeIOS::commitNewTreeState):
(WebCore::ScrollingTreeIOS::updateMainFrameScrollPosition):
(WebCore::ScrollingTreeIOS::createNode):

  • page/scrolling/ios/ScrollingTreeIOS.h: Copied from Source/WebCore/page/scrolling/ThreadedScrollingTree.h.
  • page/scrolling/ios/ScrollingTreeScrollingNodeIOS.h: Added.
  • page/scrolling/ios/ScrollingTreeScrollingNodeIOS.mm: Added.

(WebCore::ScrollingTreeScrollingNodeIOS::create):
(WebCore::ScrollingTreeScrollingNodeIOS::ScrollingTreeScrollingNodeIOS):
(WebCore::ScrollingTreeScrollingNodeIOS::~ScrollingTreeScrollingNodeIOS):
(WebCore::ScrollingTreeScrollingNodeIOS::updateBeforeChildren):
(WebCore::ScrollingTreeScrollingNodeIOS::updateAfterChildren):
(WebCore::ScrollingTreeScrollingNodeIOS::scrollPosition):
(WebCore::ScrollingTreeScrollingNodeIOS::setScrollPosition):
(WebCore::ScrollingTreeScrollingNodeIOS::setScrollPositionWithoutContentEdgeConstraints):
(WebCore::ScrollingTreeScrollingNodeIOS::setScrollLayerPosition):
(WebCore::ScrollingTreeScrollingNodeIOS::minimumScrollPosition):
(WebCore::ScrollingTreeScrollingNodeIOS::maximumScrollPosition):
(WebCore::ScrollingTreeScrollingNodeIOS::scrollBy):
(WebCore::ScrollingTreeScrollingNodeIOS::scrollByWithoutContentEdgeConstraints):

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinator::create):

  • page/scrolling/mac/ScrollingTreeFixedNode.mm:
  • page/scrolling/mac/ScrollingTreeStickyNode.mm:

Source/WebKit2:

Reviewed by Tim Horton.

Turn on ENABLE_ASYNC_SCROLLING for iOS.

On iOS, create ScrollingTreeScrollingNodeIOS nodes.

  • UIProcess/Scrolling/RemoteScrollingTree.cpp:

(WebKit::RemoteScrollingTree::createNode):

  • UIProcess/Scrolling/RemoteScrollingTree.h:

Source/WTF:

Reviewed by Tim Horton.

Turn on ENABLE_ASYNC_SCROLLING for iOS.

  • wtf/FeatureDefines.h:
5:34 PM Changeset in webkit [161609] by barraclough@apple.com
  • 9 edits in trunk/Source

Source/WebCore: text-decoration-skip: ink does not work with line wraps
https://bugs.webkit.org/show_bug.cgi?id=126729

Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2014-01-09
Reviewed by Simon Fraser.

InlineTextBox's m_start and m_length fields are offsets into the renderer's string,
not the generated TextRun. Because of this distinction, when multiple InlineTextBoxes
were constructed for the same element, all the subsequent elements would use incorrect
indices and therefore not have skipping decorations.

Test: fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-multiline.html

  • platform/graphics/Font.h:
  • platform/graphics/mac/FontMac.mm:

(WebCore::Font::dashesForIntersectionsWithRect):

  • rendering/InlineTextBox.cpp:

(WebCore::drawSkipInkUnderline):
(WebCore::InlineTextBox::paintDecoration):

  • rendering/TextPainter.cpp:

(WebCore::TextPainter::dashesForIntersectionsWithRect):

  • rendering/TextPainter.h:

Source/WebKit2: Change Page, FocusController to use ViewState
https://bugs.webkit.org/show_bug.cgi?id=126533

Reviewed by Tim Horton.

These classes currently maintain a set of separate fields to represent the view state;
combine these into a single field, and allow WebPage to send the combined update rather
than individual changes.

Maintain existing interface for WebKit1 clients.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

  • Combined separate calls to Page::setViewState.

(WebKit::WebPage::updateIsInWindow):

  • Simplied from setIsInWindow.

(WebKit::WebPage::setViewState):

  • Combined separate calls to Page::setViewState.
  • WebProcess/WebPage/WebPage.h:
    • Declare updateIsInWindow.
5:29 PM Changeset in webkit [161608] by mmaxfield@apple.com
  • 7 edits
    2 adds in trunk

text-decoration-skip: ink does not work with line wraps
https://bugs.webkit.org/show_bug.cgi?id=126729

Reviewed by Simon Fraser.

Source/WebCore:

InlineTextBox's m_start and m_length fields are offsets into the renderer's string,
not the generated TextRun. Because of this distinction, when multiple InlineTextBoxes
were constructed for the same element, all the subsequent elements would use incorrect
indices and therefore not have skipping decorations.

Test: fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-multiline.html

  • platform/graphics/Font.h:
  • platform/graphics/mac/FontMac.mm:

(WebCore::Font::dashesForIntersectionsWithRect):

  • rendering/InlineTextBox.cpp:

(WebCore::drawSkipInkUnderline):
(WebCore::InlineTextBox::paintDecoration):

  • rendering/TextPainter.cpp:

(WebCore::TextPainter::dashesForIntersectionsWithRect):

  • rendering/TextPainter.h:

LayoutTests:

This test compares rending of a single element that wraps lines with one element per line.
Both elements have text-decoration-skip:ink turned on.

  • fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-multiline-expected.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-multiline.html: Added.
5:24 PM Changeset in webkit [161607] by benjamin@webkit.org
  • 1 edit
    12 deletes in trunk/Source/WebCore

Remove remaining blackberry files I could find in WebCore
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • Resources/blackberry: Removed.
  • css/mediaControlsBlackBerry.css: Removed.
  • css/mediaControlsBlackBerryFullscreen.css: Removed.
  • css/themeBlackBerry.css: Removed.
  • editing/blackberry: Removed.
  • history/blackberry: Removed.
  • html/shadow/MediaControlsBlackBerry.cpp: Removed.
  • html/shadow/MediaControlsBlackBerry.h: Removed.
  • page/blackberry: Removed.
  • page/scrolling/blackberry: Removed.
  • plugins/blackberry: Removed.
5:18 PM Changeset in webkit [161606] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Upstream iOS changes after r161530
https://bugs.webkit.org/show_bug.cgi?id=126728

Reviewed by Dean Jackson.

  • UIProcess/API/ios/WKContentView.mm:

(-[WKContentView setViewportSize:]):
(-[WKContentView didFinishScrollTo:]):
(-[WKContentView didScrollTo:]):
Adopt the new approach.

5:12 PM Changeset in webkit [161605] by Brent Fulgham
  • 4 edits in trunk/Source/WebCore

[WebGL] Return filtered results for getProgramParameter for ACTIVE_ATTRIBUTES and ACTIVE_UNIFORMS
https://bugs.webkit.org/show_bug.cgi?id=126718
<rdar://problem/15202048>

Reviewed by Dean Jackson.

Covered by webgl/conformance/ogles/GL/biuDepthRange/biuDepthRange_001_to_002.html and
webgl/conformance/ogles/GL/gl_FragCoord/gl_FragCoord_001_to_003.html.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getActiveAttrib): Added loging.
(WebCore::WebGLRenderingContext::getActiveUniform): Added logging.
(WebCore::WebGLRenderingContext::getAttribLocation): Drive-by-fix. Return
-1 on link failure (an invalid location) rather than 0 (a valid
location) when link fails.
(WebCore::WebGLRenderingContext::getProgramParameter): Use new
method to return filtered count.
(WebCore::WebGLRenderingContext::getUniformLocation): Use nullptr
rather than returning 0.

  • platform/graphics/GraphicsContext3D.h:

(WebCore::GraphicsContext3D::ActiveShaderSymbolCounts::ActiveShaderSymbolCounts):
(WebCore::GraphicsContext3D::ActiveShaderSymbolCounts::countForType):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::precisionsMatch): Drive-by-fix. Don't
copy giant objects to read a single value.
(WebCore::GraphicsContext3D::compileShader): Release filtered count
when we change shader source code.
(WebCore::GraphicsContext3D::getActiveAttribImpl): Renamed from getActiveAttrib.
(WebCore::GraphicsContext3D::getActiveAttrib): Maps filtered indices to
real OpenGL indices.
(WebCore::GraphicsContext3D::getActiveUniformImpl): Renamed from getActiveUniform.
(WebCore::GraphicsContext3D::getActiveUniform): Maps filtered indices to
real OpenGL indices.
(WebCore::GraphicsContext3D::originalSymbolName): Use C++11 loop.
(WebCore::GraphicsContext3D::getAttribLocation): Added logging.
(WebCore::GraphicsContext3D::getNonBuiltinActiveSymbolCount): Added.
(WebCore::GraphicsContext3D::getShaderiv): Const correctness.
(WebCore::GraphicsContext3D::getShaderInfoLog): Ditto.
(WebCore::GraphicsContext3D::getShaderSource): Ditto.

4:55 PM Changeset in webkit [161604] by zoltan@webkit.org
  • 13 edits
    2 adds in trunk

[CSS Shapes] First line gets incorrectly adjusted in shape-inside due to rounding
https://bugs.webkit.org/show_bug.cgi?id=126601

Reviewed by Bem Jones-Bey.

Source/WebCore:

In order to get consistent results of the first fit position of the content in shapes,
firstIncludedIntervalLogicalTop should take a FloatSize rather than LayoutSize for
minLogicalIntervalSize, because LayoutSize clamps the float value to int, when subpixel-layout
is disabled, thus firstIncludedIntervalLogicalTop could end up calculating with an unprecize
value. This change modifies firstIncludedIntervalLogicalTop to take FloatSize consistently.

Test: fast/shapes/shape-inside/shape-inside-polygon-rounded-first-fit.html

  • rendering/shapes/BoxShape.cpp:

(WebCore::BoxShape::firstIncludedIntervalLogicalTop):

  • rendering/shapes/BoxShape.h:
  • rendering/shapes/PolygonShape.cpp:

(WebCore::PolygonShape::firstIncludedIntervalLogicalTop):

  • rendering/shapes/PolygonShape.h:
  • rendering/shapes/RasterShape.cpp:

(WebCore::RasterShape::firstIncludedIntervalLogicalTop):

  • rendering/shapes/RasterShape.h:
  • rendering/shapes/RectangleShape.cpp:

(WebCore::RectangleShape::firstIncludedIntervalLogicalTop):

  • rendering/shapes/RectangleShape.h:
  • rendering/shapes/Shape.h:
  • rendering/shapes/ShapeInsideInfo.cpp:

(WebCore::ShapeInsideInfo::adjustLogicalLineTop):
(WebCore::ShapeInsideInfo::computeFirstFitPositionForFloat):

LayoutTests:

  • fast/shapes/shape-inside/shape-inside-polygon-rounded-first-fit-expected.html: Added.
  • fast/shapes/shape-inside/shape-inside-polygon-rounded-first-fit.html: Added.
4:46 PM Changeset in webkit [161603] by aestes@apple.com
  • 3 edits
    33 adds in trunk/Source/WebCore

[iOS] Upstream WAK
https://bugs.webkit.org/show_bug.cgi?id=126724

Reviewed by David Kilzer.

  • Configurations/WebCore.xcconfig: Excluded new iOS-specific Private

headers on the Mac build.

  • WebCore.xcodeproj/project.pbxproj: Added new files to the project.
  • platform/ios/wak/WAKAppKitStubs.h: Added.
  • platform/ios/wak/WAKAppKitStubs.m: Added.
  • platform/ios/wak/WAKClipView.h: Added.
  • platform/ios/wak/WAKClipView.m: Added.
  • platform/ios/wak/WAKResponder.h: Added.
  • platform/ios/wak/WAKResponder.m: Added.
  • platform/ios/wak/WAKScrollView.h: Added.
  • platform/ios/wak/WAKScrollView.mm: Added.
  • platform/ios/wak/WAKView.h: Added.
  • platform/ios/wak/WAKView.mm: Added.
  • platform/ios/wak/WAKViewPrivate.h: Added.
  • platform/ios/wak/WAKWindow.h: Added.
  • platform/ios/wak/WAKWindow.mm: Added.
  • platform/ios/wak/WKContentObservation.cpp: Added.
  • platform/ios/wak/WKContentObservation.h: Added.
  • platform/ios/wak/WKGraphics.h: Added.
  • platform/ios/wak/WKGraphics.mm: Added.
  • platform/ios/wak/WKTypes.h: Added.
  • platform/ios/wak/WKUtilities.c: Added.
  • platform/ios/wak/WKUtilities.h: Added.
  • platform/ios/wak/WKView.h: Added.
  • platform/ios/wak/WKView.mm: Added.
  • platform/ios/wak/WKViewPrivate.h: Added.
  • platform/ios/wak/WebCoreThread.h: Added.
  • platform/ios/wak/WebCoreThread.mm: Added.
  • platform/ios/wak/WebCoreThreadInternal.h: Added.
  • platform/ios/wak/WebCoreThreadMessage.h: Added.
  • platform/ios/wak/WebCoreThreadRun.cpp: Added.
  • platform/ios/wak/WebCoreThreadRun.h: Added.
  • platform/ios/wak/WebCoreThreadSafe.h: Added.
  • platform/ios/wak/WebCoreThreadSystemInterface.cpp: Added.
  • platform/ios/wak/WebCoreThreadSystemInterface.h: Added.
4:43 PM Changeset in webkit [161602] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Another attempt to fix the Windows build following <http://trac.webkit.org/changeset/161589>
(https://bugs.webkit.org/show_bug.cgi?id=126654)

  • platform/network/cf/ResourceRequest.h: Always declare ResourceRequest::updateFromDelegatePreservingOldHTTPBody()

instead of only declaring it when building without CFNetwork.

4:31 PM Changeset in webkit [161601] by andersca@apple.com
  • 18 edits
    2 deletes in trunk/Source/WTF

Remove Blackberry and QNX bits from WTF
https://bugs.webkit.org/show_bug.cgi?id=126726

Reviewed by Benjamin Poulain.

  • wtf/Assertions.cpp:
  • wtf/Atomics.h:
  • wtf/CurrentTime.cpp:

(WTF::currentCPUTime):

  • wtf/DateMath.cpp:
  • wtf/DisallowCType.h:
  • wtf/FeatureDefines.h:
  • wtf/InlineASM.h:
  • wtf/MathExtras.h:
  • wtf/NumberOfCores.cpp:

(WTF::numberOfProcessorCores):

  • wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveUncommitted):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::decommit):

  • wtf/Platform.h:
  • wtf/PlatformBlackBerry.cmake: Removed.
  • wtf/RAMSize.cpp:

(WTF::computeRAMSize):

  • wtf/StackBounds.cpp:
  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading):
(WTF::initializeCurrentThreadInternal):

  • wtf/blackberry/MainThreadBlackBerry.cpp: Removed.
  • wtf/blackberry/RunLoopBlackBerry.cpp: Removed.
  • wtf/text/AtomicString.h:
  • wtf/text/StringImpl.h:
  • wtf/text/WTFString.h:
4:26 PM Changeset in webkit [161600] by mark.lam@apple.com
  • 4 edits in branches/jsCStack

Merge trunk r161446.

4:15 PM Changeset in webkit [161599] by fpizlo@apple.com
  • 12 edits in branches/jsCStack/Source/JavaScriptCore

DFG and FTL should have separate compilation worklists
https://bugs.webkit.org/show_bug.cgi?id=126722

Reviewed by Mark Hahnenberg.

There are a number of architectural changes here:

  • DFGDriver.cpp is now the only place that decides whether or not to do a concurrent compile. Previously this decision was oddly squirreled away in VM.cpp.


  • VM no longer points to a worklist. That was always kind of weird since there was only one worklist per process anyway.


  • There are now two worklists: one for all DFG compiles and one for all FTL compiles.


  • The FTL worklist is now parallel by default.
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::checkIfOptimizationThresholdReached):

  • dfg/DFGCommon.h:
  • dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):
(JSC::DFG::compile):

  • dfg/DFGDriver.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGWorklist.cpp:

(JSC::DFG::initializeGlobalDFGWorklistOnce):
(JSC::DFG::ensureGlobalDFGWorklist):
(JSC::DFG::existingGlobalDFGWorklistOrNull):
(JSC::DFG::initializeGlobalFTLWorklistOnce):
(JSC::DFG::ensureGlobalFTLWorklist):
(JSC::DFG::existingGlobalFTLWorklistOrNull):
(JSC::DFG::ensureGlobalWorklistFor):

  • dfg/DFGWorklist.h:
  • jit/JITOperations.cpp:
  • runtime/Options.h:
  • runtime/VM.cpp:

(JSC::cleanWorklist):
(JSC::VM::~VM):
(JSC::prepareToDiscardCodeFor):
(JSC::VM::prepareToDiscardCode):
(JSC::VM::gatherConservativeRoots):

  • runtime/VM.h:
4:15 PM Changeset in webkit [161598] by dbates@webkit.org
  • 3 edits in trunk/Source/WebCore

Attempt to fix the Windows build following <http://trac.webkit.org/changeset/161589>
(https://bugs.webkit.org/show_bug.cgi?id=126654)

For some reason, the Windows build is unhappy that NeverDestroyed<FontCache> calls the private constructor
FontCache::FontCache() despite being a friend class of FontCache. Use DEFINE_STATIC_LOCAL instead of
NeverDestroyed<> for now. I'll look to investigate this issue offline.

  • platform/graphics/FontCache.cpp:

(WebCore::fontCache):

  • platform/graphics/FontCache.h:
4:13 PM Changeset in webkit [161597] by benjamin@webkit.org
  • 1 edit
    7 deletes in trunk/Source/WebCore

Remove blackberry from WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • platform/blackberry: Removed.
  • platform/graphics/blackberry: Removed.
  • platform/graphics/filters/blackberry: Removed.
  • platform/image-decoders/blackberry: Removed.
  • platform/mediastream/blackberry: Removed.
  • platform/network/blackberry: Removed.
  • platform/text/blackberry: Removed.
4:05 PM Changeset in webkit [161596] by matthew_hanson@apple.com
  • 5 edits in branches/safari-537.74-branch/Source

Versioning.

4:04 PM Changeset in webkit [161595] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Fix a copy-paste mistake in an include guard.

Rubber-stamped by Sam Weinig.

  • crypto/parameters/CryptoAlgorithmRsaKeyParamsWithHash.h:
4:03 PM Changeset in webkit [161594] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-537.74.6

New Tag.

4:02 PM Changeset in webkit [161593] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

History::StateObjectType should be a strong enum
https://bugs.webkit.org/show_bug.cgi?id=126725

Reviewed by Beth Dakin.

  • bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::pushState):
(WebCore::JSHistory::replaceState):

  • loader/HistoryController.cpp:

(WebCore::HistoryController::pushState):

  • page/History.cpp:

(WebCore::History::stateObjectAdded):

  • page/History.h:
3:59 PM Changeset in webkit [161592] by dbates@webkit.org
  • 3 edits in trunk/Source/WebCore

Attempt to fix the Mountain Lion Release (32-bit) build following <http://trac.webkit.org/changeset/161589>
(https://bugs.webkit.org/show_bug.cgi?id=126654)

  • platform/ios/WebEvent.h:
  • platform/ios/WebEvent.mm:
3:56 PM Changeset in webkit [161591] by benjamin@webkit.org
  • 1 edit
    2 deletes in trunk/Source/WebKit

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.

Remove the WebKit layer of the Blackberry port
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

  • PlatformBlackBerry.cmake: Removed.
  • blackberry: Removed.
3:12 PM Changeset in webkit [161590] by Lucas Forschler
  • 3 edits in branches/safari-537.74-branch/LayoutTests

Merge r161581. Rebaseline after 161568.

3:02 PM DeveloperTips edited by BJ Burg
(diff)
2:59 PM Changeset in webkit [161589] by dbates@webkit.org
  • 214 edits
    23 copies
    50 adds in trunk/Source

[iOS] Upstream WebCore/platform changes
https://bugs.webkit.org/show_bug.cgi?id=126654

Rubber-stamped by David Kilzer.

Source/WebCore:

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/ContentFilter.h:
  • platform/DragData.h:
  • platform/FileChooser.cpp:

(WebCore::FileChooser::chooseMediaFiles):

  • platform/FileChooser.h:
  • platform/FileSystem.cpp:

(WebCore::setMetadataURL):

  • platform/FileSystem.h:
  • platform/KillRingNone.cpp:
  • platform/LocalizedStrings.cpp:

(WebCore::fileButtonChooseMediaFileLabel):
(WebCore::fileButtonChooseMultipleMediaFilesLabel):
(WebCore::fileButtonNoMediaFileSelectedLabel):
(WebCore::fileButtonNoMediaFilesSelectedLabel):

  • platform/LocalizedStrings.h:
  • platform/Logging.h:
  • platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedNonImageMimeTypes):
(WebCore::initializeUnsupportedTextMIMETypes):

  • platform/MemoryPressureHandler.cpp:

(WebCore::MemoryPressureHandler::MemoryPressureHandler):

  • platform/MemoryPressureHandler.h:
  • platform/PlatformKeyboardEvent.h:

(WebCore::PlatformKeyboardEvent::event):

  • platform/PlatformMouseEvent.h:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

  • platform/PlatformScreen.h:
  • platform/RuntimeApplicationChecks.cpp:

(WebCore::mainBundleIsEqualTo):

  • platform/RuntimeApplicationChecksIOS.h: Copied from Source/WebCore/platform/graphics/StringTruncator.h.
  • platform/RuntimeApplicationChecksIOS.mm: Added.
  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleTouchEvent):

  • platform/ScrollAnimator.h:
  • platform/ScrollTypes.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::unscaledVisibleContentSize):
(WebCore::ScrollView::visibleContentRect):

  • platform/ScrollView.h:

(WebCore::ScrollView::actualScrollX):
(WebCore::ScrollView::actualScrollY):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::handleTouchEvent):
(WebCore::ScrollableArea::isPinnedInBothDirections):
(WebCore::ScrollableArea::isPinnedHorizontallyInDirection):
(WebCore::ScrollableArea::isPinnedVerticallyInDirection):

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::isTouchScrollable):
(WebCore::ScrollableArea::isOverflowScroll):
(WebCore::ScrollableArea::didStartScroll):
(WebCore::ScrollableArea::didEndScroll):
(WebCore::ScrollableArea::didUpdateScroll):
(WebCore::ScrollableArea::setIsUserScroll):
(WebCore::ScrollableArea::isHorizontalScrollerPinnedToMinimumPosition):
(WebCore::ScrollableArea::isHorizontalScrollerPinnedToMaximumPosition):
(WebCore::ScrollableArea::isVerticalScrollerPinnedToMinimumPosition):
(WebCore::ScrollableArea::isVerticalScrollerPinnedToMaximumPosition):

  • platform/Scrollbar.cpp:
  • platform/Scrollbar.h:
  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::SharedBuffer):
(WebCore::SharedBuffer::createPurgeableBuffer):
(WebCore::SharedBuffer::data):

  • platform/SharedBuffer.h:

(WebCore::SharedBuffer::shouldUsePurgeableMemory):

  • platform/SuddenTermination.h:
  • platform/Supplementable.h:

(WebCore::Supplementable::provideSupplement):
(WebCore::Supplementable::removeSupplement):
(WebCore::Supplementable::requireSupplement):

  • platform/SystemMemory.h: Copied from Source/WebCore/platform/graphics/StringTruncator.h.
  • platform/ThreadCheck.h:
  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::destroy):
(WebCore::ThreadGlobalData::setWebCoreThreadData):
(WebCore::threadGlobalData):

  • platform/ThreadGlobalData.h:
  • platform/ThreadTimers.cpp:

(WebCore::ThreadTimers::ThreadTimers):
(WebCore::ThreadTimers::sharedTimerFiredInternal):

  • platform/Timer.cpp:

(WebCore::TimerBase::start):
(WebCore::TimerBase::stop):
(WebCore::TimerBase::setNextFireTime):

  • platform/Timer.h:

(WebCore::TimerBase::isActive):

  • platform/URL.cpp:

(WebCore::enableURLSchemeCanonicalization):
(WebCore::equal):
(WebCore::URL::parse):

  • platform/URL.h:
  • platform/Widget.h:
  • platform/audio/ios/AudioDestinationIOS.cpp:
  • platform/audio/ios/AudioDestinationIOS.h:
  • platform/audio/ios/AudioFileReaderIOS.cpp: Copied from Source/WebCore/platform/audio/mac/AudioFileReaderMac.cpp.

(WebCore::createAudioBufferList):
(WebCore::destroyAudioBufferList):
(WebCore::AudioFileReader::AudioFileReader):
(WebCore::AudioFileReader::~AudioFileReader):
(WebCore::AudioFileReader::readProc):
(WebCore::AudioFileReader::getSizeProc):
(WebCore::AudioFileReader::createBus):
(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):

  • platform/audio/ios/AudioFileReaderIOS.h: Copied from Source/WebCore/platform/graphics/StringTruncator.h.

(WebCore::AudioFileReader::data):
(WebCore::AudioFileReader::dataSize):

  • platform/audio/ios/AudioSessionIOS.mm:

(SOFT_LINK_POINTER):
(-[WebAudioSessionHelper initWithCallback:WebCore::]):
(-[WebAudioSessionHelper dealloc]):
(-[WebAudioSessionHelper interruption:]):
(WebCore::AudioSession::setCategory):

  • platform/audio/mac/AudioDestinationMac.cpp:
  • platform/audio/mac/AudioFileReaderMac.cpp:

(WebCore::AudioFileReader::AudioFileReader):
(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):

  • platform/audio/mac/AudioSessionMac.cpp:
  • platform/audio/mac/MediaSessionManagerMac.cpp:

(MediaSessionManager::updateSessionState):

  • platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::SharedBuffer):

  • platform/cf/URLCF.cpp:
  • platform/cocoa/KeyEventCocoa.mm:

(WebCore::windowsKeyCodeForCharCode):

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::destroyDecodedDataIfNecessary):
(WebCore::BitmapImage::cacheFrame):
(WebCore::BitmapImage::cacheFrameInfo):
(WebCore::BitmapImage::updateSize):
(WebCore::BitmapImage::originalSize):
(WebCore::BitmapImage::originalSizeRespectingOrientation):
(WebCore::BitmapImage::dataChanged):
(WebCore::BitmapImage::ensureFrameInfoIsCached):
(WebCore::BitmapImage::frameAtIndex):
(WebCore::BitmapImage::frameIsCompleteAtIndex):
(WebCore::BitmapImage::frameDurationAtIndex):
(WebCore::BitmapImage::frameHasAlphaAtIndex):
(WebCore::BitmapImage::frameOrientationAtIndex):
(WebCore::BitmapImage::startAnimation):
(WebCore::BitmapImage::internalAdvanceAnimation):

  • platform/graphics/BitmapImage.h:

(WebCore::FrameData::FrameData):

  • platform/graphics/Color.cpp:

(WebCore::Color::isDark):

  • platform/graphics/Color.h:
  • platform/graphics/DisplayRefreshMonitor.h:
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatSize.h:
  • platform/graphics/Font.cpp:

(WebCore::Font::drawText):
(WebCore::Font::width):

  • platform/graphics/Font.h:
  • platform/graphics/FontCache.cpp:

(initFontCacheLockOnce):
(FontLocker::FontLocker):
(FontLocker::~FontLocker):
(WebCore::fontCache):
(WebCore::FontCache::getCachedFontPlatformData):
(WebCore::FontCache::getCachedFontData):
(WebCore::FontCache::releaseFontData):
(WebCore::FontCache::purgeInactiveFontDataIfNeeded):
(WebCore::FontCache::purgeInactiveFontData):

  • platform/graphics/FontCache.h:
  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::drawSimpleText):
(WebCore::Font::drawGlyphBuffer):

  • platform/graphics/FontGlyphs.h:
  • platform/graphics/FontPlatformData.cpp:

(WebCore::FontPlatformData::FontPlatformData):

  • platform/graphics/FontPlatformData.h:

(WebCore::FontPlatformData::font):
(WebCore::FontPlatformData::roundsGlyphAdvances):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::hashTableDeletedFontValue):

  • platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::initializePage):

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::drawRaisedEllipse):
(WebCore::GraphicsContext::drawText):
(WebCore::GraphicsContext::drawBidiText):
(WebCore::GraphicsContext::clipRoundedRect):
(WebCore::GraphicsContext::emojiDrawingEnabled):
(WebCore::GraphicsContext::setEmojiDrawingEnabled):

  • platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContextState::GraphicsContextState):

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::willBeDestroyed):

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::contentsLayerForMedia):
(WebCore::GraphicsLayer::pixelAlignmentOffset):
(WebCore::GraphicsLayer::hasFlattenedPerspectiveTransform):

  • platform/graphics/Icon.h:
  • platform/graphics/Image.cpp:

(WebCore::Image::drawTiled):

  • platform/graphics/ImageSource.h:

(WebCore::ImageSource::isSubsampled):

  • platform/graphics/IntPoint.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/IntSize.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::installedMediaEngines):
(WebCore::MediaPlayer::isCurrentPlaybackTargetWireless):
(WebCore::MediaPlayer::showPlaybackTargetPicker):
(WebCore::MediaPlayer::hasWirelessPlaybackTargets):
(WebCore::MediaPlayer::wirelessVideoPlaybackDisabled):
(WebCore::MediaPlayer::setWirelessVideoPlaybackDisabled):
(WebCore::MediaPlayer::setHasPlaybackTargetAvailabilityListeners):
(WebCore::MediaPlayer::currentPlaybackTargetIsWirelessChanged):
(WebCore::MediaPlayer::playbackTargetAvailabilityChanged):
(WebCore::MediaPlayer::attributeChanged):
(WebCore::MediaPlayer::readyForPlayback):
(WebCore::MediaPlayer::volumeChanged):

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerCurrentPlaybackTargetIsWirelessChanged):
(WebCore::MediaPlayerClient::mediaPlayerPlaybackTargetAvailabilityChanged):

  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::volume):
(WebCore::MediaPlayerPrivateInterface::isCurrentPlaybackTargetWireless):
(WebCore::MediaPlayerPrivateInterface::showPlaybackTargetPicker):
(WebCore::MediaPlayerPrivateInterface::hasWirelessPlaybackTargets):
(WebCore::MediaPlayerPrivateInterface::wirelessVideoPlaybackDisabled):
(WebCore::MediaPlayerPrivateInterface::setWirelessVideoPlaybackDisabled):
(WebCore::MediaPlayerPrivateInterface::setHasPlaybackTargetAvailabilityListeners):
(WebCore::MediaPlayerPrivateInterface::attributeChanged):
(WebCore::MediaPlayerPrivateInterface::readyForPlayback):

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::SimpleFontData):

  • platform/graphics/SimpleFontData.h:
  • platform/graphics/StringTruncator.cpp:

(WebCore::centerTruncateToBuffer):
(WebCore::rightTruncateToBuffer):
(WebCore::rightClipToCharacterBuffer):
(WebCore::rightClipToWordBuffer):
(WebCore::leftTruncateToBuffer):
(WebCore::truncateString):
(WebCore::StringTruncator::centerTruncate):
(WebCore::StringTruncator::rightTruncate):
(WebCore::StringTruncator::leftTruncate):
(WebCore::StringTruncator::rightClipToCharacter):
(WebCore::StringTruncator::rightClipToWord):

  • platform/graphics/StringTruncator.h:
  • platform/graphics/TextTrackRepresentation.cpp:
  • platform/graphics/WidthIterator.h:

(WebCore::WidthIterator::supportsTypesettingFeatures):

  • platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:

(WebCore::AVTrackPrivateAVFObjCImpl::label):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMaxTimeLoaded):
(WebCore::wkAVAssetResolvedURL):

  • platform/graphics/blackberry/FontBlackBerry.cpp:

(WebCore::Font::drawComplexText):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::supportsAcceleratedFilterAnimations):
(WebCore::GraphicsLayerCA::setContentsToImage):
(WebCore::GraphicsLayerCA::contentsLayerForMedia):
(WebCore::GraphicsLayerCA::computeVisibleRect):
(WebCore::GraphicsLayerCA::updateGeometry):
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
(WebCore::GraphicsLayerCA::updateContentsRects):
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
(WebCore::GraphicsLayerCA::setupContentsLayer):
(WebCore::GraphicsLayerCA::mediaLayerMustBeUpdatedOnMainThread):
(WebCore::GraphicsLayerCA::computePixelAlignment):

  • platform/graphics/ca/GraphicsLayerCA.h:
  • platform/graphics/ca/PlatformCAFilters.h:
  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp:

(WebCore::currentRunLoop):
(WebCore::LayerFlushScheduler::schedule):

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(-[WebAnimationDelegate animationDidStart:]):
(PlatformCALayerMac::setContentsScale):
(PlatformCALayer::isWebLayer):
(PlatformCALayer::setBoundsOnMainThread):
(PlatformCALayer::setPositionOnMainThread):
(PlatformCALayer::setAnchorPointOnMainThread):
(PlatformCALayer::setTileSize):

  • platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::platformCALayerPaintContents):
(WebCore::TileController::removeAllTiles):
(WebCore::TileController::removeAllSecondaryTiles):
(WebCore::TileController::removeTilesInCohort):
(WebCore::TileController::revalidateTiles):
(WebCore::TileController::createTileLayer):

  • platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:

(WebCore::Font::drawComplexText):

  • platform/graphics/cg/BitmapImageCG.cpp:

(WebCore::FrameData::clear):
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::checkForSolidColor):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::copyUnscaledFrameAtIndex):

  • platform/graphics/cg/ColorCG.cpp:

(WebCore::createCGColorWithDeviceWhite):
(WebCore::createCGColorWithDeviceRGBA):
(WebCore::Color::Color):

  • platform/graphics/cg/FloatPointCG.cpp:
  • platform/graphics/cg/FloatRectCG.cpp:
  • platform/graphics/cg/FloatSizeCG.cpp:
  • platform/graphics/cg/GradientCG.cpp:
  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::sRGBColorSpaceRef):
(WebCore::setStrokeAndFillColor):
(WebCore::GraphicsContext::platformInit):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::createIOSurface):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::draw):
(WebCore::jpegUTI):
(WebCore::utiFromMIMEType):

  • platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::ImageBufferData::getData):
(WebCore::ImageBufferData::putData):

  • platform/graphics/cg/ImageBufferDataCG.h:
  • platform/graphics/cg/ImageCG.cpp:

(WebCore::drawPatternCallback):
(WebCore::Image::drawPattern):

  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::ImageSource):
(WebCore::imageSourceOptions):
(WebCore::ImageSource::imageSourceOptions):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::originalSize):
(WebCore::ImageSource::createFrameAtIndex):

  • platform/graphics/cg/ImageSourceCGMac.mm:
  • platform/graphics/cg/IntPointCG.cpp:
  • platform/graphics/cg/IntRectCG.cpp:
  • platform/graphics/cg/IntSizeCG.cpp:
  • platform/graphics/cg/PDFDocumentImage.cpp:
  • platform/graphics/cg/PathCG.cpp:
  • platform/graphics/cg/PatternCG.cpp:
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::~FontPlatformData):
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):
(WebCore::FontPlatformData::platformIsEqual):
(WebCore::FontPlatformData::setFont):
(WebCore::FontPlatformData::allowsLigatures):
(WebCore::FontPlatformData::ctFont):

  • platform/graphics/ios/DisplayRefreshMonitorIOS.mm: Added.

(WebCore::DisplayRefreshMonitor::~DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::requestRefreshCallback):
(WebCore::DisplayRefreshMonitor::displayLinkFired):

  • platform/graphics/ios/FontCacheIOS.mm: Added.
  • platform/graphics/ios/FontServicesIOS.h: Added.
  • platform/graphics/ios/FontServicesIOS.mm: Added.

(WebCore::FontServicesIOS::FontServicesIOS):

  • platform/graphics/ios/GraphicsContext3DIOS.h: Added.
  • platform/graphics/ios/IconIOS.mm: Copied from Source/WebCore/platform/mac/DisplaySleepDisabler.cpp.
  • platform/graphics/ios/InbandTextTrackPrivateAVFIOS.h: Copied from Source/WebCore/platform/graphics/cg/ImageBufferDataCG.h.

(WebCore::InbandTextTrackPrivateAVFIOS::create):
(WebCore::InbandTextTrackPrivateAVFIOS::internalID):

  • platform/graphics/ios/InbandTextTrackPrivateAVFIOS.mm: Copied from Source/WebCore/platform/graphics/mac/IntRectMac.mm.

(WebCore::InbandTextTrackPrivateAVFIOS::InbandTextTrackPrivateAVFIOS):
(WebCore::InbandTextTrackPrivateAVFIOS::~InbandTextTrackPrivateAVFIOS):
(WebCore::InbandTextTrackPrivateAVFIOS::kind):

  • platform/graphics/ios/MediaPlayerPrivateIOS.h: Added.
  • platform/graphics/ios/MediaPlayerPrivateIOS.mm: Added.
  • platform/graphics/ios/SimpleFontDataIOS.mm: Added.

(WebCore::fontFamilyShouldNotBeUsedForArabic):
(WebCore::fontHasVerticalGlyphs):
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformCharWidthInit):
(WebCore::SimpleFontData::platformCreateScaledFontData):
(WebCore::SimpleFontData::containsCharacters):
(WebCore::SimpleFontData::determinePitch):
(WebCore::SimpleFontData::platformWidthForGlyph):

  • platform/graphics/ios/TextTrackRepresentationIOS.h: Copied from Source/WebCore/platform/graphics/TextTrackRepresentation.cpp.
  • platform/graphics/ios/TextTrackRepresentationIOS.mm: Added.
  • platform/graphics/mac/ColorMac.h:
  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):

  • platform/graphics/mac/FloatPointMac.mm:
  • platform/graphics/mac/FloatRectMac.mm:
  • platform/graphics/mac/FloatSizeMac.mm:
  • platform/graphics/mac/FontCacheMac.mm:
  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::drawComplexText):
(WebCore::Font::fontDataForCombiningCharacterSequence):

  • platform/graphics/mac/FontCustomPlatformData.cpp:
  • platform/graphics/mac/FontMac.mm:

(WebCore::showLetterpressedGlyphsWithAdvances):
(WebCore::Font::drawGlyphs):

  • platform/graphics/mac/GlyphPageTreeNodeMac.cpp:

(WebCore::GlyphPage::fill):

  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::setRenderbufferStorageFromDrawable):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::endPaint):

  • platform/graphics/mac/GraphicsContextMac.mm:

(WebCore::GraphicsContext::drawFocusRing):
(WebCore::createDotPattern):
(WebCore::GraphicsContext::drawLineForDocumentMarker):

  • platform/graphics/mac/IconMac.mm:
  • platform/graphics/mac/ImageMac.mm:

(WebCore::BitmapImage::invalidatePlatformData):

  • platform/graphics/mac/IntPointMac.mm:
  • platform/graphics/mac/IntRectMac.mm:
  • platform/graphics/mac/IntSizeMac.mm:
  • platform/graphics/mac/MediaPlayerProxy.h:
  • platform/graphics/mac/SimpleFontDataCoreText.cpp:
  • platform/graphics/mac/SimpleFontDataMac.mm:
  • platform/graphics/mac/WebGLLayer.h:
  • platform/graphics/mac/WebGLLayer.mm:

(-[WebGLLayer copyImageSnapshotWithColorSpace:]):
(-[WebGLLayer display]):

  • platform/graphics/mac/WebLayer.mm:

(WebCore::drawLayerContents):
(-[WebSimpleLayer display]):
(-[WebSimpleLayer drawInContext:]):

  • platform/graphics/mac/WebTiledLayer.mm:

(+[WebTiledLayer shouldDrawOnMainThread]):
(-[WebTiledLayer display]):
(-[WebTiledLayer drawInContext:]):

  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::blitFramebuffer):
(WebCore::Extensions3DOpenGL::bindVertexArrayOES):
(WebCore::Extensions3DOpenGL::supportsExtension):
(WebCore::Extensions3DOpenGL::drawBuffersEXT):

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::Extensions3DOpenGLCommon):

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary):
(WebCore::GraphicsContext3D::renderbufferStorage):
(WebCore::GraphicsContext3D::getIntegerv):
(WebCore::GraphicsContext3D::texImage2D):
(WebCore::GraphicsContext3D::depthRange):
(WebCore::GraphicsContext3D::clearDepth):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::multiply):

  • platform/graphics/win/FontWin.cpp:

(WebCore::Font::drawComplexText):

  • platform/graphics/wince/FontWinCE.cpp:

(WebCore::Font::drawComplexText):

  • platform/ios/ContentFilterIOS.mm: Copied from Source/WebCore/platform/ContentFilter.h.
  • platform/ios/DeviceMotionClientIOS.h: Added.

(WebCore::DeviceMotionClientIOS::create):

  • platform/ios/DeviceMotionClientIOS.mm: Added.
  • platform/ios/DeviceOrientationClientIOS.h: Added.

(WebCore::DeviceOrientationClientIOS::create):

  • platform/ios/DeviceOrientationClientIOS.mm: Added.
  • platform/ios/KeyEventIOS.mm:
  • platform/ios/MIMETypeRegistryIOS.mm: Copied from Source/WebCore/platform/network/mac/CredentialStorageMac.mm.
  • platform/ios/MemoryPressureHandlerIOS.mm: Added.
  • platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::write):
(WebCore::Pasteboard::resourceMIMEType):
(WebCore::Pasteboard::writePlainText):
(WebCore::Pasteboard::read):
(WebCore::supportedImageTypes):
(WebCore::Pasteboard::supportedPasteboardTypes):
(WebCore::Pasteboard::hasData):
(WebCore::Pasteboard::readString):

  • platform/ios/PlatformEventFactoryIOS.h: Copied from Source/WebCore/platform/mac/DisplaySleepDisabler.h.
  • platform/ios/PlatformEventFactoryIOS.mm: Added.
  • platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::write):

  • platform/ios/PlatformScreenIOS.mm: Added.
  • platform/ios/PlatformSpeechSynthesizerIOS.mm: Added.
  • platform/ios/SSLKeyGeneratorIOS.cpp: Added.
  • platform/ios/ScrollAnimatorIOS.h: Copied from Source/WebCore/platform/mac/DisplaySleepDisabler.h.
  • platform/ios/ScrollAnimatorIOS.mm: Added.
  • platform/ios/ScrollViewIOS.mm: Added.
  • platform/ios/ScrollbarThemeIOS.h: Added.
  • platform/ios/ScrollbarThemeIOS.mm: Added.
  • platform/ios/SelectionRect.cpp: Added.
  • platform/ios/SelectionRect.h: Added.
  • platform/ios/SoundIOS.mm: Copied from Source/WebCore/platform/text/mac/CharsetData.h.
  • platform/ios/SystemMemoryIOS.cpp: Added.
  • platform/ios/ThemeIOS.h: Copied from Source/WebCore/platform/KillRingNone.cpp.
  • platform/ios/ThemeIOS.mm: Copied from Source/WebCore/platform/KillRingNone.cpp.
  • platform/ios/TileCache.h: Added.

(WebCore::TileCache::isSpeculativeTileCreationEnabled):

  • platform/ios/TileCache.mm: Added.
  • platform/ios/TileGrid.h: Added.
  • platform/ios/TileGrid.mm: Added.
  • platform/ios/TileGridTile.h: Copied from Source/WebCore/platform/ContentFilter.h.
  • platform/ios/TileGridTile.mm: Added.
  • platform/ios/TileLayer.h: Copied from Source/WebCore/platform/mac/DisplaySleepDisabler.h.
  • platform/ios/TileLayer.mm: Added.
  • platform/ios/TileLayerPool.mm: Added.
  • platform/ios/WebCoreMotionManager.h: Copied from Source/WebCore/platform/KillRingNone.cpp.
  • platform/ios/WebCoreMotionManager.mm: Added.
  • platform/ios/WebCoreSystemInterfaceIOS.h: Added.
  • platform/ios/WebCoreSystemInterfaceIOS.mm: Added.
  • platform/ios/WebEvent.h: Added.
  • platform/ios/WebEvent.mm: Added.
  • platform/ios/WidgetIOS.mm: Added.
  • platform/mac/DisplaySleepDisabler.cpp:

(WebCore::DisplaySleepDisabler::DisplaySleepDisabler):
(WebCore::DisplaySleepDisabler::~DisplaySleepDisabler):

  • platform/mac/DisplaySleepDisabler.h:
  • platform/mac/FileSystemMac.mm:
  • platform/mac/KillRingMac.mm:
  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::install):
(WebCore::MemoryPressureHandler::releaseMemory):

  • platform/mac/PlatformClockCM.mm:

(PlatformClockCM::PlatformClockCM):

  • platform/mac/SoftLinking.h:
  • platform/mac/SystemVersionMac.mm:
  • platform/mac/WebCoreFullScreenPlaceholderView.h:
  • platform/mac/WebCoreFullScreenPlaceholderView.mm:
  • platform/mac/WebCoreFullScreenWarningView.h:
  • platform/mac/WebCoreFullScreenWarningView.mm:
  • platform/mac/WebCoreFullScreenWindow.h:
  • platform/mac/WebCoreFullScreenWindow.mm:
  • platform/mac/WebCoreNSCellExtras.h:
  • platform/mac/WebCoreNSCellExtras.m:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebFontCache.mm:

(+[WebFontCache fontWithFamily:traits:size:]):

  • platform/network/BlobRegistry.cpp:
  • platform/network/BlobRegistryImpl.cpp:
  • platform/network/Credential.h:
  • platform/network/CredentialStorage.cpp:

(WebCore::CredentialStorage::set):
(WebCore::CredentialStorage::clearCredentials):

  • platform/network/CredentialStorage.h:
  • platform/network/NetworkStateNotifier.h:
  • platform/network/ResourceHandle.cpp:

(WebCore::builtinResourceHandleConstructorMap):
(WebCore::ResourceHandle::continueWillSendRequest):
(WebCore::ResourceHandle::continueDidReceiveResponse):
(WebCore::ResourceHandle::continueShouldUseCredentialStorage):
(WebCore::ResourceHandle::continueCanAuthenticateAgainstProtectionSpace):

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::setDefaultAllowCookies):
(WebCore::ResourceRequestBase::defaultAllowCookies):

  • platform/network/ResourceRequestBase.h:

(WebCore::ResourceRequestBase::ResourceRequestBase):

  • platform/network/cf/CredentialStorageCFNet.cpp:

(WebCore::CredentialStorage::saveToPersistentStorage):

  • platform/network/cf/DNSCFNet.cpp:
  • platform/network/cf/ProxyServerCFNet.cpp:
  • platform/network/cf/ResourceRequest.h:

(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::setMainResourceRequest):
(WebCore::ResourceRequest::isMainResourceRequest):

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::updateFromDelegatePreservingOldHTTPBody):
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::applyWebArchiveHackForMail):
(WebCore::initializeHTTPConnectionSettingsOnStartup):

  • platform/network/cf/SocketStreamHandleCFNet.cpp:

(WebCore::SocketStreamHandle::reportErrorToClient):

  • platform/network/ios/NetworkStateNotifierIOS.cpp: Copied from Source/WebCore/platform/KillRingNone.cpp.

(WebCore::NetworkStateNotifier::NetworkStateNotifier):
(WebCore::NetworkStateNotifier::setIsOnLine):

  • platform/network/ios/QuickLook.h: Added.
  • platform/network/ios/QuickLook.mm: Added.
  • platform/network/ios/ResourceHandleIOS.mm: Added.
  • platform/network/ios/WebCoreURLResponseIOS.h: Copied from Source/WebCore/platform/graphics/StringTruncator.h.
  • platform/network/ios/WebCoreURLResponseIOS.mm: Added.
  • platform/network/mac/AuthenticationMac.mm:

(WebCore::mac):

  • platform/network/mac/CredentialStorageMac.mm:

(WebCore::CredentialStorage::saveToPersistentStorage):

  • platform/network/mac/ResourceErrorMac.mm:

(dictionaryThatCanCode):
(-[WebCustomNSURLError encodeWithCoder:]):
(NSErrorFromCFError):
(WebCore::ResourceError::nsError):

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::synchronousWillSendRequestEnabled):
(WebCore::ResourceHandle::createNSURLConnection):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::schedule):
(WebCore::ResourceHandle::unschedule):
(WebCore::ResourceHandle::platformLoadResourceSynchronously):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::updateNSURLRequest):
(WebCore::ResourceRequest::applyWebArchiveHackForMail):
(WebCore::ResourceRequest::useQuickLookResourceCachingQuirks):

  • platform/network/mac/UTIUtilities.mm:
  • platform/network/mac/WebCoreResourceHandleAsDelegate.mm:

(-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]):
(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
(-[WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]):
(-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]):
(-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]):
(-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]):

  • platform/sql/SQLiteDatabase.h:

(WebCore::SQLiteDatabase::sqlite3Handle):

  • platform/sql/SQLiteFileSystem.cpp:

(WebCore::SQLiteFileSystem::truncateDatabaseFile):

  • platform/sql/SQLiteFileSystem.h:
  • platform/sql/SQLiteTransaction.cpp:

(WebCore::SQLiteTransaction::begin):
(WebCore::SQLiteTransaction::commit):
(WebCore::SQLiteTransaction::rollback):
(WebCore::SQLiteTransaction::stop):

  • platform/sql/ios/SQLiteDatabaseTracker.cpp: Added.
  • platform/sql/ios/SQLiteDatabaseTracker.h: Copied from Source/WebCore/platform/MemoryPressureHandler.cpp.
  • platform/sql/ios/SQLiteDatabaseTrackerClient.h: Copied from Source/WebCore/platform/KillRingNone.cpp.
  • platform/text/PlatformLocale.cpp:
  • platform/text/PlatformLocale.h:
  • platform/text/TextBreakIteratorICU.cpp:

(WebCore::cursorMovementIterator):

  • platform/text/TextCodecICU.cpp:

(WebCore::TextCodecICU::registerEncodingNames):
(WebCore::TextCodecICU::registerCodecs):

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::extendTextCodecMaps):

  • platform/text/cf/HyphenationCF.cpp:

(WebCore::canHyphenate):

  • platform/text/ios/LocalizedDateCache.h: Copied from Source/WebCore/platform/MemoryPressureHandler.h.
  • platform/text/ios/LocalizedDateCache.mm: Added.
  • platform/text/mac/CharsetData.h:
  • platform/text/mac/LocaleMac.h:
  • platform/text/mac/LocaleMac.mm:

(WebCore::LocaleMac::formatDateTime):
(WebCore::LocaleMac::maximumWidthForDateType):

  • platform/text/mac/TextBoundaries.mm:

(WebCore::isSkipCharacter):
(WebCore::isWhitespaceCharacter):
(WebCore::isWordDelimitingCharacter):
(WebCore::isSymbolCharacter):
(WebCore::isAmbiguousBoundaryCharacter):
(WebCore::tokenizerForString):
(WebCore::findSimpleWordBoundary):
(WebCore::findComplexWordBoundary):
(WebCore::findWordBoundary):
(WebCore::findNextWordFromIndex):

  • platform/text/mac/TextCodecMac.cpp:
  • platform/text/mac/TextCodecMac.h:

Source/WTF:

  • wtf/MainThread.cpp:

(WTF::canAccessThreadLocalDataForThread):

  • wtf/MainThread.h:
2:53 PM Changeset in webkit [161588] by commit-queue@webkit.org
  • 14 edits in trunk/Source/WebCore

Web Inspector: Consolidate developerExtrasEnabled to just InspectorEnvironment
https://bugs.webkit.org/show_bug.cgi?id=126717

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-09
Reviewed by Timothy Hatcher.

They all route to InspectorEnvironment::developerExtrasEnabled, so make
InspectorEnvironment available to all agents through InstrumentingAgents
and use that where needed.

  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::InspectorAgent):

  • inspector/InspectorAgent.h:

(WebCore::InspectorAgent::create):

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::addMessageToConsole):
(WebCore::InspectorConsoleAgent::didFinishXHRLoading):
(WebCore::InspectorConsoleAgent::didReceiveResponse):
(WebCore::InspectorConsoleAgent::didFailLoading):
(WebCore::InspectorConsoleAgent::addConsoleMessage):

  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::enabled):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
(WebCore::InspectorInstrumentation::frameDocumentUpdatedImpl):
(WebCore::InspectorInstrumentation::didOpenDatabaseImpl):
(WebCore::InspectorInstrumentation::didCreateWebSocketImpl):

  • inspector/InstrumentingAgents.cpp:

(WebCore::InstrumentingAgents::InstrumentingAgents):

  • inspector/InstrumentingAgents.h:

(WebCore::InstrumentingAgents::create):
(WebCore::InstrumentingAgents::inspectorEnvironment):

  • inspector/PageConsoleAgent.cpp:
  • inspector/PageConsoleAgent.h:
  • inspector/WorkerConsoleAgent.cpp:
  • inspector/WorkerConsoleAgent.h:
  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):

2:51 PM Changeset in webkit [161587] by Lucas Forschler
  • 2 edits
    1 copy in tags/Safari-538.10.2/Source/JavaScriptCore

Merged r161574. <rdar://problem/15762689>

2:49 PM Changeset in webkit [161586] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Remove Unnecessary InspectorAgent parameters
https://bugs.webkit.org/show_bug.cgi?id=126712

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-09
Reviewed by Timothy Hatcher.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::create):
(WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):

  • inspector/InspectorDOMDebuggerAgent.h:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::create):
(WebCore::InspectorPageAgent::InspectorPageAgent):

  • inspector/InspectorPageAgent.h:
2:23 PM Changeset in webkit [161585] by Joseph Pecoraro
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed Windows build fix for r161563.

Copy all scripts, some may not be .py.

2:14 PM Changeset in webkit [161584] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Remove an accidentally left-behind static_cast.

  • dom/ElementDescendantIterator.h:

(WebCore::ElementDescendantIteratorAdapter<ElementType>::beginAt):

2:10 PM Changeset in webkit [161583] by Antti Koivisto
  • 6 edits in trunk/Source/WebCore

Replace ElementIteratorAdapter find() with beginAt()
https://bugs.webkit.org/show_bug.cgi?id=126714

Reviewed by Andreas Kling.

ElementIteratorAdapter find() would return iterator for the argument element if it was
of correct type and in the right subtree. This is not really what you would expect from find()
so replace it with a simple beginAt() iterator construction function.

  • dom/DocumentOrderedMap.cpp:

(WebCore::DocumentOrderedMap::getAllElementsById):

  • dom/ElementChildIterator.h:

(WebCore::ElementChildIteratorAdapter<ElementType>::beginAt):
(WebCore::ElementChildConstIteratorAdapter<ElementType>::beginAt):

  • dom/ElementDescendantIterator.h:

(WebCore::ElementDescendantIteratorAdapter<ElementType>::beginAt):
(WebCore::ElementDescendantConstIteratorAdapter<ElementType>::beginAt):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::formElementIndex):

  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::rowAfter):

2:07 PM Changeset in webkit [161582] by mark.lam@apple.com
  • 15 edits in branches/jsCStack/Source/JavaScriptCore

CStack: Rename "host zone" to "reserved zone".
https://bugs.webkit.org/show_bug.cgi?id=126716.

Reviewed by Michael Saboff.

The "zone" is used as a reserve of stack memory for:

  1. nominal host code stack usage.
  2. stack space for error handling.
  3. initial stack space for pushing VMEntrySentinel frames.

The "zone" may reside on the C stack and on the C loop JSStack depending
on context. Hence, the name "host zone" is not quite accurate, and we'll
rename it to "reserved zone".

  • interpreter/JSStack.cpp:

(JSC::JSStack::JSStack):
(JSC::JSStack::growSlowCase):
(JSC::JSStack::releaseExcessCapacity):
(JSC::JSStack::setReservedZoneSize):

  • interpreter/JSStack.h:
  • interpreter/JSStackInlines.h:

(JSC::JSStack::shrink):

  • runtime/ErrorHandlingScope.cpp:

(JSC::ErrorHandlingScope::ErrorHandlingScope):
(JSC::ErrorHandlingScope::~ErrorHandlingScope):

  • runtime/ErrorHandlingScope.h:
  • runtime/JSLock.cpp:

(JSC::JSLock::DropAllLocks::DropAllLocks):
(JSC::JSLock::DropAllLocks::~DropAllLocks):

  • runtime/JSLock.h:
  • runtime/Options.h:
  • runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::updateStackLimitWithReservedZoneSize):

  • runtime/VM.h:

(JSC::VM::reservedZoneSize):

  • runtime/VMEntryScope.cpp:

(JSC::VMEntryScope::VMEntryScope):
(JSC::VMEntryScope::~VMEntryScope):

  • runtime/VMEntryScope.h:
2:05 PM Changeset in webkit [161581] by timothy_horton@apple.com
  • 3 edits in trunk/LayoutTests

Rebaseline after r161568.

  • platform/mac/fast/images/pdf-as-image-landscape-expected.png:
  • platform/mac/fast/images/pdf-as-image-landscape-expected.txt:
1:31 PM Changeset in webkit [161580] by matthew_hanson@apple.com
  • 4 edits in branches/safari-537.74-branch/Source/WebCore

Merge r161568: <rdar://problem/15784802>

1:26 PM Changeset in webkit [161579] by Lucas Forschler
  • 4 edits
    2 copies in tags/Safari-538.10.2

Merged r161404. <rdar://problem/15398575>

1:23 PM Changeset in webkit [161578] by Lucas Forschler
  • 5 edits in tags/Safari-538.10.2/Source

Versioning.

1:21 PM Changeset in webkit [161577] by BJ Burg
  • 7 edits in trunk/Source

REGRESSION (r160152): Selection drag snapshot doesn't appear or has the wrong content on Retina
https://bugs.webkit.org/show_bug.cgi?id=125375

Reviewed by Darin Adler.

Source/WebCore:

Move scaling of drag images by the device scale factor out of DragClient
and into WebCore. This removes several redundant copies and scaling operations.

Fix scaling bugs that were cancelled out by over-allocating the backing store.

  • page/DragController.cpp:

(WebCore::DragController::startDrag): Scale the drag image for a link
according to the device scale factor before giving it to the OS.

(WebCore::DragController::doImageDrag): Scale the drag image for an image
according to the device scale factor before giving it to the OS.

  • page/FrameSnapshotting.cpp:

(WebCore::snapshotFrameRect): Don't pre-scale or clip the snapshot. The
ImageBuffer does this already.

  • platform/DragImage.cpp:

(WebCore::createDragImageFromSnapshot): Don't scale the backing store
when copying an ImageBuffer into an Image.

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::copyImage): Draw the image in user-space coordinates,
not in backing-store coordinates. Remove unnecessary assertions. Crop the
buffer before drawing the image into it.

Source/WebKit2:

Remove scaling from WebDragClient because it is now selectively
performed by WebCore according to the drag image source.

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::startDrag): Don't scale the provided drag image.

1:19 PM Changeset in webkit [161576] by Lucas Forschler
  • 1 copy in tags/Safari-538.10.2

New Tag.

1:10 PM Changeset in webkit [161575] by mark.lam@apple.com
  • 38 edits
    3 adds in branches/jsCStack

CStack: Need a separate stack limit for the JS stack and the C stack.
https://bugs.webkit.org/show_bug.cgi?id=126320.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

The purpose of this patch is mainly to change the way we compute the stack
limit for JS stack checks. Previously, we tally up the stack usage per
session of VM re-entry as tracked by the VMEntryScope, and we ensure that
the total usage does not exceed Options::maxStackSize(), and of course, is
also capped by the amount of native C stack available. The usage tracking
here does not count host / native function stack usage against the max
stack usage.

The new way is to compute a limit as an offset from the VMEntryScope of
the first entry into the VM. Options::maxPerThreadStackUsage()
will provide that offset. Any host / native function stack usage after
we've entered the VM will be counted against the max stack usage.

This patch supplants parts or all of the following previously committed
patches:

r161104: https://bugs.webkit.org/show_bug.cgi?id=126266

Rename VM::entryScope to firstEntryScope.

r161232: https://bugs.webkit.org/show_bug.cgi?id=126321

Introducing Options::maxStackSize().

r161172: https://bugs.webkit.org/show_bug.cgi?id=126331

Refactor to split the tracking of the jsStackLimit from the
native stackLimit.

r161174: https://bugs.webkit.org/show_bug.cgi?id=126334

Introduce tracking of the top VMEntryScope.

r161361: https://bugs.webkit.org/show_bug.cgi?id=126487

The fixed up jsStackLimit in doCallToJavaScript should not
exceed the native stack limit.

r161180: https://bugs.webkit.org/show_bug.cgi?id=126320

Need a separate stack limit for the JS stack and the C stack.
This was for the old way of tracking chunks of stack usage
per VMEntryScope.

Details of this patch:

  1. Renamed VM::firstEntryScope back to VM::entryScope. Removed the tracking of topEntryScope and related code.
  1. Renamed Options::maxStackSize() to maxPerThreadStackUsage(). Added Options::hostZoneSize() and Options::errorModeHostZoneSize().
  1. The VM now tracks its current hostZoneSize and stack limits. VM::m_stackLimit is computed when the hostZoneSize is set via VM::updateStackLimitWithHostZoneSize().

In the C Loop LLINT case, the VM also provides a setJSStackLimit()
since VM::m_stackLimit and VM::m_jsStackLimit are 2 different values
in that case.

  1. Replaced Interpreter::ErrorHandlingMode with ErrorHandlingScope. The ErrorHandlingScope constructor will set the VM host zone size to Options::errorModeHostZoneSize(), and restore the previous host zone size.

The destructor for ErrorHandlingScope will restore the previous stack
limit. We can enter multiple ErrorHandlingScopes. Only the destruction
of the very first one will restore the stack limit with the non-error
mode host zone.

  1. LLINT C loop JSStack changes: 5.1 Replaced calls to roundUpToAllocationSize() with WTF::roundUpToMultipleOf().

roundUpToAllocationSize() is redundant and is now removed.

5.2 Removed enable/disableErrorStackReserve() and updateStackLimit().

Their function is now handled by JSStack::setHostZoneSize().

5.3 Added accounting for a host zone in the LLINT C loop JSStack.

This includes growing the JS stack to allow space for the host zone
whenever the host zone size is adjusted via JSStack::setHostZoneSize().

Note: though setHostZoneSize() is based on disableErrorStackReserve(),
we don't retain the logic to shrink the stack there. That logic was
always dead code: we only call shrink() if m_end + 1 < m_useableTop,
but shrink() will only shrink the stack if m_end is pointing to the
base of the stack i.e. the 2 conditions are mutually exclusive, and
no work to shrink the stack will ever be done here.

m_useableTop is no longer needed and is now removed.

5.4 Change all non C loop code to reference VM::stackLimit() instead of

VM::jsStackLimit(). Though the 2 are the same for non C loop builds,
this makes it more straightforward. We now only reference the
jsStackLimit in 2 cases:

  1. LLINT and JIT code performing stack checks where they expect the jsStackLimit to be a pseudonym for the stackLimit in non C loop builds.
  1. In the C loop build, the JSStack itself sets VM::m_jsStackLimit() when it adjusts its host zone size.

In all other cases, we work directly with VM::stackLimit().

  1. Simplify the tracking of VM::stackPointerAtVMEntry. We now set VM::stackPointerAtVMEntry when we install a VMEntryScope if and only if it isn't already set.

When we drop the API locks, we'll save the current stackPointerAtVMEntry
and stack limit value, and clear stackPointerAtVMEntry to allow a new
thread acquiring the API locks to re-set it when it installs a VMEntryScope.
When we re-acquire the API locks again, we'll restore the previously saved
stackPointerAtVMEntry and stack limit.

With this change, we also no longer need the stackPointerAtVMEntry fix up
code in doCallToJavaScript(). That code is now removed.

(JSC::Debugger::recompileAllJSFunctions):

  • debugger/DebuggerCallFrame.cpp:
  • heap/Heap.cpp:

(JSC::Heap::lastChanceToFinalize):
(JSC::Heap::deleteAllCompiledCode):

  • interpreter/CallFrame.cpp:

(JSC::CallFrame::vmEntryGlobalObject):

  • interpreter/Interpreter.cpp:
  • interpreter/Interpreter.h:
  • interpreter/JSStack.cpp:

(JSC::JSStack::JSStack):
(JSC::JSStack::~JSStack):
(JSC::JSStack::growSlowCase):
(JSC::JSStack::releaseExcessCapacity):
(JSC::JSStack::setHostZoneSize):
(JSC::JSStack::lowAddress):

  • interpreter/JSStack.h:
  • interpreter/JSStackInlines.h:

(JSC::JSStack::ensureCapacityFor):
(JSC::JSStack::shrink):

  • jit/ExecutableAllocator.h:
  • jit/JITOperations.cpp:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter64.asm:
  • parser/ParserError.h:

(JSC::ParserError::toErrorObject):

  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/ErrorHandlingScope.cpp: Added.

(JSC::ErrorHandlingScope::ErrorHandlingScope):
(JSC::ErrorHandlingScope::~ErrorHandlingScope):

  • runtime/ErrorHandlingScope.h: Added.
  • runtime/ExceptionHelpers.cpp:

(JSC::throwStackOverflowError):
(JSC::throwTerminatedExecutionException):

  • runtime/JSLock.cpp:

(JSC::JSLock::DropAllLocks::DropAllLocks):
(JSC::JSLock::DropAllLocks::~DropAllLocks):

  • runtime/JSLock.h:
  • runtime/Options.h:
  • runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::releaseExecutableMemory):
(JSC::VM::updateStackLimitWithHostZoneSize):

  • runtime/VM.h:
  • runtime/VMEntryScope.cpp:

(JSC::VMEntryScope::VMEntryScope):
(JSC::VMEntryScope::~VMEntryScope):

  • runtime/VMEntryScope.h:

Source/WebCore:

No new tests.

  • ForwardingHeaders/runtime/ErrorHandlingScope.h: Added.
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::reportException):

  • Updated to use ErrorHandlingScope instead of Interpreter::ErrorHandlingMode.

Source/WTF:

  • wtf/StackBounds.h:

(WTF::StackBounds::recursionLimit):

  • Previously, StackBounds::recursionLimit() only takes a host zone size which it uses to compute the client's desired stack limit. Now, there's an alternate version that also allows the client to explicitly specify its desired stack limit in addition to its hostZoneSize requirement. In both cases, StackBounds::recursionLimit() will cap the limit (with allowance for the hostZoneSize) to be within its bounds, and return the capped limit.

LayoutTests:

  • js/large-expressions-expected.txt:
  • js/script-tests/large-expressions.js:
  • Changed expected result to reflect the much more constrained stack size now that the JS stack limit also limits stack usage by host / native functions.
12:41 PM Changeset in webkit [161574] by fpizlo@apple.com
  • 2 edits
    1 add in trunk/Source/JavaScriptCore

AI for CreateArguments should pass through non-SpecEmpty input values
https://bugs.webkit.org/show_bug.cgi?id=126709

Reviewed by Mark Hahnenberg.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • tests/stress/use-arguments-as-object-pointer.js: Added.

(foo):

12:30 PM Changeset in webkit [161573] by mmaxfield@apple.com
  • 3 edits
    2 adds in trunk

Narrow underlines are too tall
https://bugs.webkit.org/show_bug.cgi?id=126708

Reviewed by Simon Fraser.

Source/WebCore:

I made a typo in r158392 and used was settings the line rect's
height equal to its width. No one noticed because of the subsequent
if statement.

Test: fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-tall-underlines.html

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::computeLineBoundsAndAntialiasingModeForText):

LayoutTests:

This test clips to a region that should not be drawn in, then draws a scaled underline. It then compares
the output to an empty element.

  • fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-tall-underlines-expected.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-tall-underlines.html: Added.
12:22 PM Changeset in webkit [161572] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

DocumentOrderedMap should use iterator
https://bugs.webkit.org/show_bug.cgi?id=126696

Reviewed by Andreas Kling.

  • dom/DocumentOrderedMap.cpp:

(WebCore::keyMatchesId):
(WebCore::keyMatchesName):
(WebCore::keyMatchesMapName):
(WebCore::keyMatchesLowercasedMapName):
(WebCore::keyMatchesLowercasedUsemap):
(WebCore::keyMatchesLabelForAttribute):
(WebCore::keyMatchesWindowNamedItem):
(WebCore::keyMatchesDocumentNamedItem):

Switch to Element references.

(WebCore::DocumentOrderedMap::add):
(WebCore::DocumentOrderedMap::remove):
(WebCore::DocumentOrderedMap::get):
(WebCore::DocumentOrderedMap::getAllElementsById):

Use element iterator instead of ElementTraversal.

  • dom/DocumentOrderedMap.h:
12:20 PM Changeset in webkit [161571] by timothy_horton@apple.com
  • 5 edits in trunk/Source/WebKit2

WebKit2 View Gestures: Support plugins that take over the page scale gesture
https://bugs.webkit.org/show_bug.cgi?id=126399
<rdar://problem/15738928>

Reviewed by Sam Weinig.

Teach ViewGestureController how to handle WebFrame::handlesPageScaleGesture=true,
which is used so that PDFPlugin can deal with magnification itself.

  • UIProcess/mac/ViewGestureController.cpp:

(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::didCollectGeometryForMagnificationGesture):
(WebKit::ViewGestureController::handleMagnificationGesture):
(WebKit::ViewGestureController::endMagnificationGesture):
(WebKit::ViewGestureController::didCollectGeometryForSmartMagnificationGesture):
If the WebFrame is going to handle the page scale gesture itself (which currently
simply means that it is a main-frame PDFPlugin), send the magnification information
straight through to it. Also, don't provide smart-zoom in this case, since there
is currently no way to collect geometry information from the plugin.

  • UIProcess/mac/ViewGestureController.h:
  • UIProcess/mac/ViewGestureController.messages.in:
  • WebProcess/WebPage/ViewGestureGeometryCollector.cpp:

(WebKit::ViewGestureGeometryCollector::collectGeometryForMagnificationGesture):
(WebKit::ViewGestureGeometryCollector::collectGeometryForSmartMagnificationGesture):
Retrieve WebFrame::handlesPageScaleGesture and return it to the UI process.

12:20 PM Changeset in webkit [161570] by Beth Dakin
  • 18 edits in trunk/Source/WebCore

Margin tiles are not repainted when background color changes
https://bugs.webkit.org/show_bug.cgi?id=126541
-and corresponding-
<rdar://problem/15578131>

Reviewed by Simon Fraser.

This patch adds an optional parameter to GraphicsLayer::setNeedsDisplayInRect,
RenderLayerBacking::setContentsNeedDisplay(), and
RenderLayer::setBackingNeedsRepaint() that is used to determine whether or not to
clip the invalidation rect to the size of the layer. Then whenever the margin
needs to be repainted, we can call setNeedsDisplayInRect() with a rect that
includes the margin, and also indicate that it should not be clipped.

GraphicsLayer now takes an optional parameter which is an enum called
ShouldClipToLayer.

  • WebCore.exp.in:
  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:

(WebCore::GraphicsLayerBlackBerry::setNeedsDisplayInRect):

  • platform/graphics/blackberry/GraphicsLayerBlackBerry.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setNeedsDisplayInRect):

  • platform/graphics/ca/GraphicsLayerCA.h:
  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::setNeedsDisplayInRect):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setNeedsDisplayInRect):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

Make TileController::bounds() a virtual function, and declare it on TiledBacking
so that we can call it from RenderLayerBacking.

  • platform/graphics/TiledBacking.h:
  • platform/graphics/ca/mac/TileController.h:

RenderLayer also now takes an optional parameter which is an enum called
ShouldClipToLayer.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderLayer.h:

If the margin needs to be repainted, call GraphicsLayer::setNeedsDisplayInRect
with a big enough rect and a ShouldClipToLayer value of DoNotClipToLayer.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::setContentsNeedDisplay):

  • rendering/RenderLayerBacking.h:

Whenever all of the root contents need to be repainted the margin will also need
to be repainted, so call setBackingNeedsRepaint() with the new parameter
indicating the the invalidation should NOT be clipped to the layer size.

  • rendering/RenderView.cpp:

(WebCore::RenderView::repaintRootContents):

12:16 PM Changeset in webkit [161569] by betravis@adobe.com
  • 19 edits in trunk/Source/WebCore

[CSS Shapes] Factor the ReferenceBox type out of BasicShapes
https://bugs.webkit.org/show_bug.cgi?id=126648

Reviewed by Dirk Schulze.

Moving ReferenceBox out of BasicShapes and into RenderStyleConstants
as the LayoutBox enum. Most of the changes are removing the BasicShape
namespace.

Refactoring, no new tests.

  • css/BasicShapeFunctions.cpp:

(WebCore::valueForBox):
(WebCore::boxForValue):
(WebCore::valueForBasicShape):
(WebCore::basicShapeForValue):

  • css/BasicShapeFunctions.h:
  • css/CSSBasicShapes.cpp:

(WebCore::CSSBasicShapeRectangle::cssText):
(WebCore::CSSBasicShapeRectangle::equals):
(WebCore::CSSBasicShapeCircle::cssText):
(WebCore::CSSBasicShapeCircle::equals):
(WebCore::CSSDeprecatedBasicShapeCircle::cssText):
(WebCore::CSSDeprecatedBasicShapeCircle::equals):
(WebCore::CSSBasicShapeEllipse::cssText):
(WebCore::CSSBasicShapeEllipse::equals):
(WebCore::CSSDeprecatedBasicShapeEllipse::cssText):
(WebCore::CSSDeprecatedBasicShapeEllipse::equals):
(WebCore::CSSBasicShapePolygon::cssText):
(WebCore::CSSBasicShapePolygon::equals):
(WebCore::CSSBasicShapeInsetRectangle::cssText):
(WebCore::CSSBasicShapeInsetRectangle::equals):
(WebCore::CSSBasicShapeInset::cssText):

  • css/CSSBasicShapes.h:

(WebCore::CSSBasicShape::layoutBox):
(WebCore::CSSBasicShape::setLayoutBox):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseShapeProperty):

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyShape::applyValue):

  • rendering/ClipPathOperation.h:

(WebCore::ShapeClipPathOperation::setReferenceBox):
(WebCore::ShapeClipPathOperation::referenceBox):
(WebCore::ShapeClipPathOperation::ShapeClipPathOperation):
(WebCore::BoxClipPathOperation::create):
(WebCore::BoxClipPathOperation::referenceBox):
(WebCore::BoxClipPathOperation::BoxClipPathOperation):

  • rendering/shapes/Shape.cpp:

(WebCore::Shape::createLayoutBoxShape):

  • rendering/shapes/Shape.h:
  • rendering/shapes/ShapeInfo.cpp:

(WebCore::ShapeInfo<RenderType>::computedShape):

  • rendering/shapes/ShapeInfo.h:

(WebCore::ShapeInfo::setShapeSize):
(WebCore::ShapeInfo::logicalTopOffset):
(WebCore::ShapeInfo::logicalLeftOffset):

  • rendering/shapes/ShapeInsideInfo.h:
  • rendering/shapes/ShapeOutsideInfo.h:
  • rendering/style/BasicShapes.cpp:

(WebCore::BasicShape::canBlend):
(WebCore::BasicShape::referenceBoxSize):

  • rendering/style/BasicShapes.h:

(WebCore::BasicShape::layoutBox):
(WebCore::BasicShape::setLayoutBox):
(WebCore::BasicShape::BasicShape):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/ShapeValue.h:

(WebCore::ShapeValue::createLayoutBoxValue):
(WebCore::ShapeValue::layoutBox):
(WebCore::ShapeValue::ShapeValue):

12:14 PM Changeset in webkit [161568] by timothy_horton@apple.com
  • 4 edits in trunk/Source/WebCore

PDFDocumentImage can be very slow to do the initial paint
https://bugs.webkit.org/show_bug.cgi?id=126633
<rdar://problem/15770980>

Reviewed by Simon Fraser.

  • platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::PDFDocumentImage):
(WebCore::PDFDocumentImage::size):
(WebCore::transformContextForPainting):
(WebCore::PDFDocumentImage::computeBoundsForCurrentPage):
(WebCore::applyRotationForPainting):
(WebCore::PDFDocumentImage::drawPDFPage):

  • platform/graphics/cg/PDFDocumentImage.h:
  • platform/graphics/mac/PDFDocumentImageMac.mm:

(WebCore::PDFDocumentImage::computeBoundsForCurrentPage):
Store rotation from the PDF in degrees, since it can
only be 0, 90, 180, or 270, and don't do any trig to
perform the rotation, to avoid introducing minor rounding
issues in the size.

Once we're going to paint, if the difference between the
computed scale for each axis is due only to integer rounding
of the image size, use the same scale for both axes, to avoid
a CG slow-path which occurs whenever the scale is nonuniform.

12:09 PM Changeset in webkit [161567] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

Disconnect child frames iteratively
https://bugs.webkit.org/show_bug.cgi?id=126700

Reviewed by Andreas Kling.

Use descendant iterator instead of recursion for traversal.

  • dom/ContainerNode.cpp:

(WebCore::willRemoveChild):
(WebCore::willRemoveChildren):
(WebCore::ContainerNode::disconnectDescendantFrames):

  • dom/ContainerNodeAlgorithms.cpp:

(WebCore::assertConnectedSubrameCountIsConsistent):
(WebCore::collectFrameOwners):
(WebCore::disconnectSubframes):

Get rid of the strange ChildFrameDisconnector class in favor of a function.

  • dom/ContainerNodeAlgorithms.h:

(WebCore::disconnectSubframesIfNeeded):

11:38 AM Changeset in webkit [161566] by mitz@apple.com
  • 6 edits in trunk

[Cocoa] Promote WKBackForwardList{,Item}.h to public
https://bugs.webkit.org/show_bug.cgi?id=126707

Reviewed by Sam Weinig.

Source/WebKit2:

  • UIProcess/API/Cocoa/WKBackForwardList.h: Stopped including the C API header.
  • UIProcess/API/Cocoa/WKBackForwardListItem.h: Ditto.
  • WebKit2.xcodeproj/project.pbxproj: Made the headers public.

Tools:

  • Scripts/check-for-webkit-framework-include-consistency: Account for stale private headers

left behind in the build products directory after a private header is made public.

11:25 AM Changeset in webkit [161565] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Unreviewed Windows build fix for r161563.

Remove reference to removed file.

  • bindings/js/JSBindingsAllInOne.cpp:
11:14 AM Changeset in webkit [161564] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Constructors for Objective-C classes do not work properly with instanceof
https://bugs.webkit.org/show_bug.cgi?id=126670

Reviewed by Oliver Hunt.

This bug is due to the fact that the JS constructors created for Objective-C classes via the JSC
API inherit from JSCallbackObject, which overrides hasInstance with its own customHasInstance.
JSCallbackObject::customHasInstance only checks the JSClassRefs for hasInstance callbacks.
If it doesn't find any callbacks, it returns false.

This patch adds a hasInstance callback to constructors created for Objective-C wrapper classes.

  • API/JSWrapperMap.mm:

(constructorHasInstance):
(constructorWithCustomBrand):
(allocateConstructorForCustomClass):

  • API/tests/testapi.mm:
11:00 AM Changeset in webkit [161563] by Joseph Pecoraro
  • 69 edits
    9 copies
    10 moves
    11 adds
    6 deletes in trunk/Source

Web Inspector: Move InjectedScript classes into JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=126598

Source/JavaScriptCore:

Reviewed by Timothy Hatcher.

Part 1: Extract InspectorInstrumentationCookie class from InspectorInstrumentation.
Part 2: Move InjectedScriptSource and generation into JavaScriptCore.
Part 3: Update CodeGeneratorInspector to avoid inlining virtual destructors.
Part 4: Move all inspector scripts into JavaScriptCore and update generators.
Part 5: Move InjectedScript classes into JavaScriptCore
Part 6: Put it all together. Make WebCore use the JavaScriptCore InjectedScript files.

There are pieces of logic that WebCore wants to hook into in the InjectedScript
execution (e.g. for CommandLineAPIModule and InspectorInstrumentation). Create
hooks for those in a base class called InspectorEnvironment. For now, the
InspectorControllers (Page, JSGlobalObject, Worker) will be the InspectorEnvironments
and provide answers to its hooks.

  • inspector/InspectorEnvironment.h: Added.

New hooks needed by WebCore in various places. Mostly stubbed in JavaScriptCore.

  • inspector/InjectedScript.cpp: Renamed from Source/WebCore/inspector/InjectedScript.cpp.
  • inspector/InjectedScript.h: Added.
  • inspector/InjectedScriptBase.cpp: Renamed from Source/WebCore/inspector/InjectedScriptBase.cpp.
  • inspector/InjectedScriptBase.h: Renamed from Source/WebCore/inspector/InjectedScriptBase.h.
  • inspector/InjectedScriptModule.cpp: Renamed from Source/WebCore/inspector/InjectedScriptModule.cpp.
  • inspector/InjectedScriptModule.h: Renamed from Source/WebCore/inspector/InjectedScriptModule.h.

Cleanup the style of these files (nullptr, formatting, whitespace, etc).
Use the InspectorEnvironments call/evaluate function for ScriptFunctionCalls and checking access

  • inspector/InjectedScriptManager.cpp: Renamed from Source/WebCore/inspector/InjectedScriptManager.cpp.
  • inspector/InjectedScriptManager.h: Renamed from Source/WebCore/inspector/InjectedScriptManager.h.

Take an InspectorEnvironment with multiple hooks, instead of a single hook function.

  • inspector/InjectedScriptHost.cpp: Added.
  • inspector/InjectedScriptHost.h: Added.
  • inspector/JSInjectedScriptHost.cpp: Renamed from Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp.
  • inspector/JSInjectedScriptHost.h: Added.
  • inspector/JSInjectedScriptHostPrototype.cpp: Added.
  • inspector/JSInjectedScriptHostPrototype.h: Added.

Implementation of InjectedScriptHost which is passed into the script (InjectedScriptSource.js)
that we inject into the page. This is mostly copied from the original autogenerated code,
then simplified and cleaned up. InjectedScriptHost can be subclasses to provide specialized
implementations of isHTMLAllCollection and type for Web/DOM types unknown to a pure JS context.

For OS X be sure to export the scripts as if they are private headers.

  • GNUmakefile.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • inspector/scripts/cssmin.py: Renamed from Source/WebCore/inspector/Scripts/cssmin.py.
  • inspector/scripts/inline-and-minify-stylesheets-and-scripts.py: Renamed from Source/WebCore/inspector/Scripts/inline-and-minify-stylesheets-and-scripts.py.
  • inspector/scripts/jsmin.py: Renamed from Source/WebCore/inspector/Scripts/jsmin.py.
  • inspector/scripts/xxd.pl: Renamed from Source/WebCore/inspector/xxd.pl.

This avoids build errors about duplicate exported virtual inlined methods
are included from multiple places. Just put empty destructors in the
implementation file instead of inlined.

  • inspector/scripts/CodeGeneratorInspector.py:

(Generator):
(Generator.go):

  • inspector/scripts/CodeGeneratorInspectorStrings.py:

Move InjectedScriptSource.js and derived sources generation.

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • inspector/InjectedScriptSource.js: Renamed from Source/WebCore/inspector/InjectedScriptSource.js.

Source/WebCore:

Reviewed by Timothy Hatcher.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:

Remove old InjectedScript files.

  • ForwardingHeaders/inspector/InjectedScript.h: Added.
  • ForwardingHeaders/inspector/InjectedScriptBase.h: Added.
  • ForwardingHeaders/inspector/InjectedScriptHost.h: Added.
  • ForwardingHeaders/inspector/InjectedScriptManager.h: Added.
  • ForwardingHeaders/inspector/InjectedScriptModule.h: Added.
  • ForwardingHeaders/inspector/InspectorEnvironment.h: Added.

Expose headers to WebCore.

  • inspector/InspectorController.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::developerExtrasEnabled):
(WebCore::InspectorController::canAccessInspectedScriptState):
(WebCore::InspectorController::functionCallHandler):
(WebCore::InspectorController::evaluateHandler):
(WebCore::InspectorController::willCallInjectedScriptFunction):
(WebCore::InspectorController::didCallInjectedScriptFunction):

  • inspector/WorkerInspectorController.h:
  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::functionCallHandler):
(WebCore::WorkerInspectorController::evaluateHandler):
(WebCore::WorkerInspectorController::willCallInjectedScriptFunction):
(WebCore::WorkerInspectorController::didCallInjectedScriptFunction):
Make both InspectorControllers in WebCore be InspectorEnvironments.

  • bindings/js/JSMainThreadExecState.h:
  • bindings/js/JSMainThreadExecState.cpp:

(WebCore::evaluateHandlerFromAnyThread):
Make JSC::evaluate wrapper like the existing JSC::call wrapper.
These will be the ScriptFunctionCall implementations when debugging
a WebCore::Page or worker, instead of the pure JSC versions.

  • inspector/PageInjectedScriptHost.h: Copied from Source/WebCore/inspector/CommandLineAPIModule.h.
  • inspector/PageInjectedScriptHost.cpp: Copied from Source/WebCore/inspector/PageInjectedScriptManager.cpp.

(WebCore::PageInjectedScriptHost::type):
(WebCore::PageInjectedScriptHost::isHTMLAllCollection):
WebCore InjectedScriptHost implementation for DOM type handling.

  • inspector/PageInjectedScriptManager.h:
  • inspector/PageInjectedScriptManager.cpp:

(WebCore::PageInjectedScriptManager::PageInjectedScriptManager):
(WebCore::PageInjectedScriptManager::discardInjectedScriptsFor):
WebCore InjectedScriptManager implementation for CommandLineAPI and
specialized DOMWindow injected script management.

  • bindings/js/JSBindingsAllInOne.cpp:
  • inspector/CommandLineAPIHost.cpp:
  • inspector/CommandLineAPIHost.h:
  • inspector/CommandLineAPIModule.cpp:

(WebCore::CommandLineAPIModule::host):

  • inspector/CommandLineAPIModule.h:
  • inspector/ConsoleMessage.cpp:

(WebCore::ConsoleMessage::addToFrontend):

  • inspector/ConsoleMessage.h:
  • inspector/InjectedScriptCanvasModule.cpp:

(WebCore::InjectedScriptCanvasModule::InjectedScriptCanvasModule):

  • inspector/InjectedScriptCanvasModule.h:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorCanvasAgent.cpp:
  • inspector/InspectorCanvasAgent.h:

(WebCore::InspectorCanvasAgent::create):

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):

  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorDOMAgent.h:

(WebCore::InspectorDOMAgent::create):

  • inspector/InspectorDebuggerAgent.cpp:
  • inspector/InspectorDebuggerAgent.h:

(WebCore::InspectorDebuggerAgent::injectedScriptManager):

  • inspector/InspectorHeapProfilerAgent.cpp:

(WebCore::InspectorHeapProfilerAgent::create):
(WebCore::InspectorHeapProfilerAgent::InspectorHeapProfilerAgent):

  • inspector/InspectorHeapProfilerAgent.h:
  • inspector/InspectorIndexedDBAgent.cpp:
  • inspector/InspectorIndexedDBAgent.h:

(WebCore::InspectorIndexedDBAgent::create):

  • inspector/InspectorPageAgent.cpp:
  • inspector/InspectorPageAgent.h:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::PageProfilerAgent::PageProfilerAgent):
(WebCore::InspectorProfilerAgent::create):
(WebCore::WorkerProfilerAgent::WorkerProfilerAgent):
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):

  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorRuntimeAgent.cpp:
  • inspector/InspectorRuntimeAgent.h:

(WebCore::InspectorRuntimeAgent::injectedScriptManager):

  • inspector/PageConsoleAgent.cpp:

(WebCore::PageConsoleAgent::PageConsoleAgent):

  • inspector/PageConsoleAgent.h:

(WebCore::PageConsoleAgent::create):

  • inspector/PageDebuggerAgent.cpp:
  • inspector/PageDebuggerAgent.h:
  • inspector/PageRuntimeAgent.cpp:
  • inspector/PageRuntimeAgent.h:

(WebCore::PageRuntimeAgent::create):

  • inspector/WorkerConsoleAgent.cpp:

(WebCore::WorkerConsoleAgent::WorkerConsoleAgent):

  • inspector/WorkerConsoleAgent.h:

(WebCore::WorkerConsoleAgent::create):

  • inspector/WorkerDebuggerAgent.cpp:
  • inspector/WorkerDebuggerAgent.h:
  • inspector/WorkerRuntimeAgent.cpp:
  • inspector/WorkerRuntimeAgent.h:

(WebCore::WorkerRuntimeAgent::create):
Switch to using the Inspector namespace and JSC InjectedScript files.

  • bindings/js/JSInjectedScriptManager.cpp: Removed.
  • inspector/InjectedScript.h: Removed.
  • inspector/InjectedScriptHost.cpp: Removed.
  • inspector/InjectedScriptHost.h: Removed.
  • inspector/InjectedScriptHost.idl: Removed.

With the updated location switch to using the appropriate INSPECTOR_SCRIPTS_DIR
variable which defines where the scripts are.

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:

Currently InjectedScriptBase uses InspectorInstrumentation directly
to track calling into JavaScript for timeline purposes. We will remove
the direct call from InjectedScriptBase and extracting the Cookie class
will make that easier.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorInstrumentation.cpp:
  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorInstrumentationCookie.cpp: Added.

(WebCore::InspectorInstrumentationCookie::InspectorInstrumentationCookie):
(WebCore::InspectorInstrumentationCookie::operator=):
(WebCore::InspectorInstrumentationCookie::~InspectorInstrumentationCookie):

  • inspector/InspectorInstrumentationCookie.h: Added.

(WebCore::InspectorInstrumentationCookie::isValid):
(WebCore::InspectorInstrumentationCookie::instrumentingAgents):
(WebCore::InspectorInstrumentationCookie::hasMatchingTimelineAgentId):

10:46 AM Changeset in webkit [161562] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Regression: failing RegExp tests on 32 bit architectures.
https://bugs.webkit.org/show_bug.cgi?id=126699

Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2014-01-09
Reviewed by Michael Saboff.

Fix setRegExpConstructor functions for 32 bit architectures.

  • runtime/RegExpConstructor.cpp:

(JSC::setRegExpConstructorInput):
(JSC::setRegExpConstructorMultiline):

10:34 AM Changeset in webkit [161561] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Revert back to using the -n option when producing symbolic links to the GTK-specific
API directories under Source/WebKit2/. Removing the option in r161497 resulted in
recursive links being created under those directories since the links were dereferenced.

To actually ensure that the link is created anew, remove it so it is reconstructed.

Rubber-stamped by Carlos Garcia Campos.

  • GNUmakefile.am:
10:31 AM Changeset in webkit [161560] by ap@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION (r161429?): Frequent crashes on media/track/media-element-enqueue-event-crash.html
https://bugs.webkit.org/show_bug.cgi?id=117756

  • platform/mac/TestExpectations: Skipping the test, it crashes very frequently.
9:55 AM Changeset in webkit [161559] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Crash when starting a download before the network process has been launched
https://bugs.webkit.org/show_bug.cgi?id=126258

Reviewed by Anders Carlsson.

We need to ensure there's a network process running before
starting a new download like we do when using the web process.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::download): Use ChildProcessProxy::send()
instead of using the connection to make sure messages are queued
if the process is still launching.
(WebKit::WebContext::createDownloadProxy): Call
ensureNetworkProcess() before creating the download proxy.

9:23 AM Changeset in webkit [161558] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Cannot select multiple non-adjacent items in a multiple select control with the keyboard only
https://bugs.webkit.org/show_bug.cgi?id=15816

Patch by Pascal Jacquemart <p.jacquemart@samsung.com> on 2014-01-09
Reviewed by Chris Fleizach.

Source/WebCore:

Test: fast/forms/listbox-non-contiguous-keyboard-selection.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::HTMLSelectElement):
New member m_allowsNonContiguousSelection defaults to false
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
Tracking CTRL modifier to start multiple non contiguous selection

  • html/HTMLSelectElement.h: New member m_allowsNonContiguousSelection

(WebCore::HTMLSelectElement::allowsNonContiguousSelection): New getter

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::addFocusRingRects):
Following implementation made for spatial navigation

LayoutTests:

  • fast/forms/listbox-non-contiguous-keyboard-selection-expected.txt: Added.
  • fast/forms/listbox-non-contiguous-keyboard-selection.html: Added.
  • platform/mac/TestExpectations:

Multiple non contiguous selection with keyboard not enabled on Mac

9:21 AM Changeset in webkit [161557] by commit-queue@webkit.org
  • 31 edits in trunk/Source

Unreviewed, rolling out r161540.
http://trac.webkit.org/changeset/161540
https://bugs.webkit.org/show_bug.cgi?id=126704

Caused assertion failures on multiple tests (Requested by ap
on #webkit).

Source/JavaScriptCore:

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):

  • bytecode/CodeBlock.h:

(JSC::CodeBlockSet::mark):

  • dfg/DFGOperations.cpp:
  • heap/CodeBlockSet.cpp:

(JSC::CodeBlockSet::add):
(JSC::CodeBlockSet::traceMarked):

  • heap/CodeBlockSet.h:
  • heap/CopiedBlockInlines.h:

(JSC::CopiedBlock::reportLiveBytes):

  • heap/CopiedSpace.cpp:
  • heap/CopiedSpace.h:
  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::didAbandon):
(JSC::Heap::markRoots):
(JSC::Heap::copyBackingStores):
(JSC::Heap::collectAllGarbage):
(JSC::Heap::collect):
(JSC::Heap::didAllocate):

  • heap/Heap.h:

(JSC::Heap::shouldCollect):
(JSC::Heap::isCollecting):
(JSC::Heap::isWriteBarrierEnabled):
(JSC::Heap::writeBarrier):

  • heap/HeapOperation.h:
  • heap/MarkStack.cpp:

(JSC::MarkStackArray::~MarkStackArray):

  • heap/MarkStack.h:
  • heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::isPagedOut):
(JSC::MarkedAllocator::tryAllocateHelper):
(JSC::MarkedAllocator::addBlock):
(JSC::MarkedAllocator::removeBlock):

  • heap/MarkedAllocator.h:

(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::reset):

  • heap/MarkedBlock.cpp:
  • heap/MarkedBlock.h:

(JSC::MarkedBlock::lastChanceToFinalize):
(JSC::MarkedBlock::didConsumeEmptyFreeList):
(JSC::MarkedBlock::clearMarks):

  • heap/MarkedSpace.cpp:

(JSC::MarkedSpace::~MarkedSpace):
(JSC::MarkedSpace::resetAllocators):
(JSC::MarkedSpace::visitWeakSets):
(JSC::MarkedSpace::reapWeakSets):

  • heap/MarkedSpace.h:

(JSC::ClearMarks::operator()):
(JSC::MarkedSpace::clearMarks):

  • heap/SlotVisitor.cpp:

(JSC::SlotVisitor::~SlotVisitor):

  • heap/SlotVisitor.h:

(JSC::SlotVisitor::sharedData):

  • heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::internalAppend):
(JSC::SlotVisitor::copyLater):
(JSC::SlotVisitor::reportExtraMemoryUsage):

  • jit/Repatch.cpp:
  • runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::visitChildren):

  • runtime/JSPropertyNameIterator.h:

(JSC::StructureRareData::setEnumerationCache):

  • runtime/JSString.cpp:

(JSC::JSString::visitChildren):

  • runtime/StructureRareDataInlines.h:

(JSC::StructureRareData::setPreviousID):
(JSC::StructureRareData::setObjectToStringValue):

  • runtime/WeakMapData.cpp:

(JSC::WeakMapData::visitChildren):

Source/WTF:

  • wtf/Bitmap.h:

(WTF::WordType>::count):

9:19 AM Changeset in webkit [161556] by Seokju Kwon
  • 21 edits
    10 deletes in trunk

Web Inspector: Remove unused overriding protocols.
https://bugs.webkit.org/show_bug.cgi?id=126630

Reviewed by Timothy Hatcher.

Source/WebCore:

No new tests, No change in behavior.

Remove unused overriding protocols as these are not used anymore in Frontned.
-Page.setGeolocationOverride
-Page.clearGeolocationOverride
-Page.canOverrideGeolocation
-Page.setDeviceOrientationOverride
-Page.clearDeviceOrientationOverride
-Page.canOverrideGeolocation
-Network.setUserAgentOverride

  • Modules/geolocation/GeolocationController.cpp:

(WebCore::GeolocationController::GeolocationController):
(WebCore::GeolocationController::create):
(WebCore::GeolocationController::positionChanged):
(WebCore::provideGeolocationTo):

  • Modules/geolocation/GeolocationController.h:
  • dom/DeviceOrientationController.cpp:

(WebCore::DeviceOrientationController::DeviceOrientationController):
(WebCore::DeviceOrientationController::create):
(WebCore::DeviceOrientationController::didChangeDeviceOrientation):
(WebCore::provideDeviceOrientationTo):

  • dom/DeviceOrientationController.h:
  • inspector/InspectorInstrumentation.cpp:
  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::InspectorPageAgent):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::disable):

  • inspector/InspectorResourceAgent.h:
  • inspector/protocol/Network.json:
  • inspector/protocol/Page.json:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::userAgent):

Source/WebInspectorUI:

Update InspectorWebBackendCommands.js after removing unused overriding protocols.

  • UserInterface/InspectorWebBackendCommands.js:
  • UserInterface/Legacy/6.0/InspectorWebBackendCommands.js:
  • UserInterface/Legacy/7.0/InspectorWebBackendCommands.js:
  • Versions/Inspector-iOS-6.0.json:
  • Versions/Inspector-iOS-7.0.json:

LayoutTests:

  • http/tests/inspector/extensions-useragent-expected.txt: Removed.
  • http/tests/inspector/extensions-useragent.html: Removed.
  • inspector/device-orientation-success-expected.txt: Removed.
  • inspector/device-orientation-success.html: Removed.
  • inspector/geolocation-error-expected.txt: Removed.
  • inspector/geolocation-error.html: Removed.
  • inspector/geolocation-success-expected.txt: Removed.
  • inspector/geolocation-success.html: Removed.
  • inspector/geolocation-watchPosition-expected.txt: Removed.
  • inspector/geolocation-watchPosition.html: Removed.
8:27 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
8:08 AM Changeset in webkit [161555] by Carlos Garcia Campos
  • 4 edits in trunk

[SOUP] Partial file left on disk after a download fails or is cancelled in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=126686

Reviewed by Martin Robinson.

Source/WebKit2:

We are currently writing the downloads directly into the
destination, and when a download fails or is cancelled after the
destination has been decided, the partial file is left on the
disk. Deleting the final file is not safe because there might be a
race condition, so we can use an intermediate file like other
browsers do, a file in the same directory than the target
destination but with .wkdownload suffix, that is removed when the
download fails or is cancelled. If the download finishes
successfully the intermediate file is renamed to the final
destination.

  • Shared/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::deleteIntermediateFileInNeeded): Delete
the intermdiate file if it's been created already.
(WebKit::DownloadClient::downloadFailed): Call deleteIntermediateFileInNeeded.
(WebKit::DownloadClient::didReceiveResponse): Do not create a
SoupMessage for the given ResourceResponse that is not used, cache
the ResourceResponse instead. Create the intermediate file and use
it instead of the final destination.
(WebKit::DownloadClient::didReceiveData): Use the cached
ResourceResponse directly.
(WebKit::DownloadClient::didFinishLoading): Rename the
intermediate file to the final destination and write the metadata
in the final target destination.
(WebKit::DownloadClient::cancel): Handle the download cancellation
here, removing the intermediate file is needed and cancelling the
ResourceHandle and the download.
(WebKit::DownloadClient::handleResponseLater):
(WebKit::Download::cancel): Let the client handle the cancellation.

Tools:

Test that partial files are not left on disk after a download has
been cancelled after the destination has been decided. To make
sure the download is cancelled after the destination has been
decided and before the operation finishes, we cancel the download
in the destination decided callback, and we use an infinite
resource that writes chunks to the response body and never
completes the body.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:

(addContentDispositionHTTPHeaderToResponse): Helper function to
add the Content-Disposition to the response headers.
(writeNextChunkIdle): Write next chunk to response body.
(writeNextChunk): Write next chunk in an idle to avoid flooding
the network with the inifnite resource.
(serverCallback): Add an inifinite resource.
(testDownloadRemoteFileError): Check that partial file is not
present after the download has been cancelled.

7:50 AM Changeset in webkit [161554] by akling@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Shrink WatchpointSet.
<https://webkit.org/b/126694>

Reorder the members of WatchpointSet, shrinking it by 8 bytes.
767 kB progression on Membuster3.

Reviewed by Antti Koivisto.

  • bytecode/Watchpoint.h:
4:06 AM Changeset in webkit [161553] by abucur@adobe.com
  • 8 edits in trunk/Source/WebCore

[CSSRegions] Move regions auto-size code into RenderNamedFlowFragment
https://bugs.webkit.org/show_bug.cgi?id=122959

Reviewed by Mihnea Ovidenie.

Move the auto-height logic from RenderRegion to RenderNamedFlowFragment because it's
used only by the CSS Regions implementation.

Bug 126642 covers the auto-height logic move from RenderFlowThread to RenderNamedFlowThread.

Tests: No new tests, just refactorings.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::styleDidChange):
(WebCore::RenderFlowThread::validateRegions):
(WebCore::RenderFlowThread::isAutoLogicalHeightRegionsCountConsistent):
(WebCore::RenderFlowThread::initializeRegionsComputedAutoHeight):
(WebCore::RenderFlowThread::markAutoLogicalHeightRegionsForLayout):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::addForcedRegionBreak):

  • rendering/RenderMultiColumnSet.h:
  • rendering/RenderNamedFlowFragment.cpp:

(WebCore::RenderNamedFlowFragment::RenderNamedFlowFragment):
(WebCore::RenderNamedFlowFragment::styleDidChange):
(WebCore::RenderNamedFlowFragment::incrementAutoLogicalHeightCount):
(WebCore::RenderNamedFlowFragment::decrementAutoLogicalHeightCount):
(WebCore::RenderNamedFlowFragment::updateRegionHasAutoLogicalHeightFlag):
(WebCore::RenderNamedFlowFragment::updateLogicalHeight):
(WebCore::RenderNamedFlowFragment::pageLogicalHeight):
(WebCore::RenderNamedFlowFragment::layoutBlock):
(WebCore::RenderNamedFlowFragment::attachRegion):
(WebCore::RenderNamedFlowFragment::detachRegion):

  • rendering/RenderNamedFlowFragment.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::pageLogicalHeight):
(WebCore::RenderRegion::logicalHeightOfAllFlowThreadContent):
(WebCore::RenderRegion::isLastRegion):
(WebCore::RenderRegion::styleDidChange):
(WebCore::RenderRegion::attachRegion):
(WebCore::RenderRegion::detachRegion):

  • rendering/RenderRegion.h:
  • rendering/RenderRegionSet.h:
  • rendering/RenderTreeAsText.cpp:

(WebCore::writeRenderRegionList):

2:32 AM Changeset in webkit [161552] by rtakacs@inf.u-szeged.hu
  • 2 edits in trunk/Tools

Move myself to the committers list.

Unreviewed.

  • Scripts/webkitpy/common/config/contributors.json:
2:20 AM Changeset in webkit [161551] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Switch HTMLTableRowsCollection from Traversal<> to iterators
https://bugs.webkit.org/show_bug.cgi?id=126684

Reviewed by Andreas Kling.

This is the last remaining client of Traversal<> outside the iterator implementation.

  • dom/ElementChildIterator.h:

(WebCore::ElementChildIteratorAdapter<ElementType>::find):
(WebCore::ElementChildConstIteratorAdapter<ElementType>::find):

Add find with the same semantics as ElementDescendantIterator::find.

  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::rowAfter):
(WebCore::HTMLTableRowsCollection::lastRow):

12:44 AM Changeset in webkit [161550] by zandobersek@gmail.com
  • 13 edits
    3 adds in trunk/LayoutTests

Unreviewed GTK gardening. Rebaselining after r161521.

  • platform/gtk/css1/text_properties/letter_spacing-expected.png:
  • platform/gtk/css1/text_properties/letter_spacing-expected.txt:
  • platform/gtk/css1/text_properties/word_spacing-expected.png:
  • platform/gtk/css1/text_properties/word_spacing-expected.txt:
  • platform/gtk/css2.1/t1604-c542-letter-sp-00-b-a-expected.txt:
  • platform/gtk/fast/text/basic/013-expected.png:
  • platform/gtk/fast/text/basic/013-expected.txt:
  • platform/gtk/fast/text/text-letter-spacing-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/text-spacing-01-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt: Added.
  • platform/gtk/svg/batik/text/textLayout-expected.txt: Added.
  • platform/gtk/svg/custom/text-letter-spacing-expected.png:
  • platform/gtk/svg/custom/text-letter-spacing-expected.txt:
  • platform/gtk/svg/text/text-spacing-01-b-expected.png:
  • platform/gtk/svg/text/text-spacing-01-b-expected.txt: Added.
12:05 AM Changeset in webkit [161549] by Carlos Garcia Campos
  • 4 edits in trunk

REGRESSION(r161176): http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html is failing on GTK
https://bugs.webkit.org/show_bug.cgi?id=126518

Reviewed by Martin Robinson.

Source/WebCore:

Clear the credentials before calling willSendRequest on the client
to avoid sending the credentials to the API layer, but apply them
again to the request right before creating the new SoupRequest.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::continueAfterWillSendRequest):
(WebCore::doRedirect):

LayoutTests:

Unskip
http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html
and http/tests/security/redirect-BLOCKED-to-localURL.html.

  • platform/gtk/TestExpectations:
Note: See TracTimeline for information about the timeline view.