Timeline
Jan 12, 2014:
- 11:20 PM Changeset in webkit [161863] by
-
- 12 edits in branches/jsCStack/Source/JavaScriptCore
internal-js-tests.yaml/Octane/mandreel.js.default-ftl fails about 1/30 times with "TypeError: undefined is not an object"
https://bugs.webkit.org/show_bug.cgi?id=126797
Not yet reviewed.
This bug was a hilarious combination of concurrent JIT (making it a flake),
LLInt->JIT OSR, and the FTL's register preservation wrapper.
Consider that a CodeBlock with a LLInt JITCode may get called, and while running,
it may decide to tier up to the baseline JIT. At that point, the old JITCode gets
summarily deleted and replaced by the baseline JITCode. This used to be "correct"
because the LLInt's JITCode only held a reference to an immortal entrypoint thunk.
But not anymore: now the LLInt's JITCode may also hold references to register
preservation wrappers, which get generated lazily.
So consider that the FTL calls a LLInt'd CodeBlock and that LLInt JITCode lazily
creates a register preservation wrapper. That register preservation wrapper is on
the stack and the stack will have a return PC that points to it. Then the LLInt
code decides to tier up to the baseline JIT. This causes the LLInt JITCode to get
deleted. That means that the register preservation wrapper also gets deleted. Now
all it takes is for some more executable memory to get allocated, and when that
baseline JIT frame (that used to be a LLInt frame) returns, it returns into what
it *thinks* is a register preservation wrapper - except now it's something else!
Hilariously, the thing that we'd return into in mandreel was a PutByVal stub. When
the concurrent JIT interleaved itself in such a way as to make this case happen
(i.e. the FTL code for runMandreel was compiled just as some mandreel init routine
was *about* to get tiered up to baseline JIT), then the baseline code would
*always* allocate a PutByVal stub right where the register preservation wrapper's
return site used to be. Thus, returning from the baseline code for that
initialization function would cause it to jump to a PutByVal stub for one of the
PutByVal's in that same function. Somehow, we'd always end up returning to a valid
instruction rather than into the middle of something. That PutByVal stub would
then do a type check on some random variable that it thought was the base - it
would of course fail - and then the slow path would try to do conversions - that
would result in it seeing undefined - and then usually we would crash while trying
to throw the exception.
The solution is to make the return site of the register preservation thunk be
always immortal. We already had a standalone immortal return ramp for that thunk
for use by FTL OSR exit. I figure it doesn't hurt to just always use that immortal
return site.
This bug took several days to track down. I don't think I can add more tests for
this, although I'll think about it. Basically the lesson here is that running big
tests like Mandreel over and over again with the concurrent JIT enabled shakes out
interesting bugs.
This change also adds some useful debug flags, like --breakOnThrow=true, which
causes us to CRASH() whenever an exception is thrown. Without this, this bug was
basically impossible to figure out: we would wind up somewhere in
handleUncaughtException and then that code would go *completely berserk* because
the stack is of course totally screwed up once we "returned" into that PutByVal
stub.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpAssumingJITType):
(JSC::CodeBlock::CodeBlock):
- dfg/DFGCompilationMode.h:
(JSC::DFG::isFTL):
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::reportCompileTimes):
(JSC::DFG::Plan::compileInThread):
(JSC::DFG::Plan::compileInThreadImpl):
- dfg/DFGPlan.h:
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- jit/JITExceptions.cpp:
(JSC::genericUnwind):
- jit/RegisterPreservationWrapperGenerator.cpp:
(JSC::generateRegisterPreservationWrapper):
(JSC::generateRegisterRestoration):
- jit/RegisterPreservationWrapperGenerator.h:
- runtime/Options.cpp:
(JSC::recomputeDependentOptions):
- runtime/Options.h:
- runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::throwException):
- 10:29 PM Changeset in webkit [161862] by
-
- 7 edits in trunk
Unreviewed, rolling out r161843.
http://trac.webkit.org/changeset/161843
https://bugs.webkit.org/show_bug.cgi?id=126871
Caused CSS custom filter tests to assert (Requested by smfr on
#webkit).
Source/WebCore:
- platform/graphics/ANGLEWebKitBridge.cpp:
(WebCore::getSymbolInfo):
(WebCore::ANGLEWebKitBridge::compileShaderSource):
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getShaderInfoLog):
LayoutTests:
- fast/canvas/webgl/glsl-conformance-expected.txt:
- fast/canvas/webgl/glsl-conformance.html:
- 10:26 PM Changeset in webkit [161861] by
-
- 29 edits in trunk/Source
Unreviewed, rolling out r161840.
http://trac.webkit.org/changeset/161840
https://bugs.webkit.org/show_bug.cgi?id=126870
Caused jsscore and layout test failures (Requested by smfr on
#webkit).
Source/JavaScriptCore:
- API/JSValueRef.cpp:
(JSValueMakeFromJSONString):
- bindings/ScriptValue.cpp:
(Deprecated::jsToInspectorValue):
- inspector/InspectorValues.cpp:
- runtime/DatePrototype.cpp:
(JSC::formatLocaleDate):
- runtime/Identifier.h:
(JSC::Identifier::characters):
- runtime/JSStringBuilder.h:
(JSC::JSStringBuilder::append):
Source/WebCore:
- bindings/objc/WebScriptObject.mm:
(+[WebScriptObject _convertValueToObjcValue:JSC::originRootObject:rootObject:]):
- editing/CompositeEditCommand.cpp:
(WebCore::containsOnlyWhitespace):
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::insertText):
- editing/VisibleUnits.cpp:
(WebCore::startOfParagraph):
(WebCore::endOfParagraph):
- html/parser/HTMLParserIdioms.cpp:
(WebCore::stripLeadingAndTrailingHTMLSpaces):
(WebCore::parseHTMLNonNegativeInteger):
- inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::createSearchRegexSource):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::newLineAndWhitespaceDelimiters):
- inspector/InspectorStyleTextEditor.cpp:
(WebCore::InspectorStyleTextEditor::insertProperty):
(WebCore::InspectorStyleTextEditor::internalReplaceProperty):
- platform/Length.cpp:
(WebCore::newCoordsArray):
- platform/LinkHash.cpp:
(WebCore::visitedLinkHash):
- platform/graphics/Color.cpp:
(WebCore::Color::parseHexColor):
(WebCore::Color::Color):
- platform/graphics/TextRun.h:
(WebCore::TextRun::TextRun):
- platform/text/TextEncodingRegistry.cpp:
(WebCore::atomicCanonicalTextEncodingName):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::constructTextRun):
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::width):
- svg/SVGFontElement.cpp:
(WebCore::SVGFontElement::registerLigaturesInGlyphCache):
- xml/XPathFunctions.cpp:
(WebCore::XPath::FunId::evaluate):
- xml/XPathNodeSet.h:
Source/WTF:
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::replace):
- wtf/text/WTFString.h:
(WTF::String::isAllSpecialCharacters):
- 10:18 PM Changeset in webkit [161860] by
-
- 4 edits in trunk/Source
Fix build warnings by unused parameter
https://bugs.webkit.org/show_bug.cgi?id=126867
Reviewed by Gyuyoung Kim.
Source/WebCore:
- Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:
(WebCore::IDBServerConnectionLevelDB::changeDatabaseVersion): Remove unused parameter 'operation'.
Source/WebKit/efl:
- WebCoreSupport/EditorClientEfl.h:
(WebCore::EditorClientEfl::checkTextOfParagraph): Remove unused parameter 'checkingTypes'.
- 8:37 PM Changeset in webkit [161859] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix for WinCairo.
- WebCore.vcxproj/WebCoreCairo.props: Add missing include path
to locate SelectorCompiler.h.
- 8:31 PM Changeset in webkit [161858] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test maintenance.
- platform/mac/TestExpectations: Re-enable the typedarray/data-view-test.html
WebGL test now that it works properly.
- 8:09 PM Changeset in webkit [161857] by
-
- 7 edits in trunk
[EFL][WK2] Make API tests work again
https://bugs.webkit.org/show_bug.cgi?id=126769
Patch by Sergio Correia <Sergio Correia> on 2014-01-12
Reviewed by Gyuyoung Kim.
The EFL and WK2 test binaries are currently being generated at *TestWebKitAPI/
[E]WebKit2, respectively, and this causes problems because the logic to find
where WebProcess is to look in the same directory of the running process and
then proceed to use LIBEXECDIR (typically /usr/loca/bin).
This patch introduces a WEBKIT_EXEC_PATH environment variable, inspired in the
Gtk port, which allows us to look for WebProcess initially in this directory,
if it's defined.
.:
- Source/cmake/OptionsEfl.cmake: Define WEBKIT_EXEC_PATH, to be used by
[E]WebKit2 tests.
Source/WebKit2:
- Shared/efl/ProcessExecutablePathEfl.cpp:
(WebKit::findProcessPath): Change the logic to look initially in
WEBKIT_EXEC_PATH, then proceed with the existing checks.
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp:
(EWK2UnitTest::EWK2UnitTestEnvironment::EWK2UnitTestEnvironment):
Define WEBKIT_EXEC_PATH to be used by EWebKit2 tests.
Tools:
- TestWebKitAPI/efl/main.cpp:
(main): Define WEBKIT_EXEC_PATH to be used by WebKit2 API tests.
- 8:03 PM Changeset in webkit [161856] by
-
- 2 edits in trunk/Source/WebKit
Try to fix the Windows build after r161852.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 7:55 PM Changeset in webkit [161855] by
-
- 2 edits in trunk/Source/WTF
Fix an assertion failure in initializeDates() when launching Safari, which was introduced in r161852.
Reviewed by Andy Estes.
- wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading): Set isInitialized to true.
- 7:18 PM Changeset in webkit [161854] by
-
- 2 edits in trunk/Source/WebCore
Fix iOS build breakage from http://trac.webkit.org/changeset/161844
https://bugs.webkit.org/show_bug.cgi?id=126866
Reviewed by Simon Fraser.
- platform/text/TextBreakIteratorICU.cpp:
(WebCore::cursorMovementIterator): Use initializeIterator instead of createSharedIterator,
which does not exist.
- 6:42 PM Changeset in webkit [161853] by
-
- 4 edits in trunk/Source
Add PLATFORM(COCOA) and USE(FOUNDATION)
https://bugs.webkit.org/show_bug.cgi?id=126859
Reviewed by Anders Carlsson.
Source/WebCore:
config.h: Use PLATFORM(COCOA) instead of PLATFORM(MAC) PLATFORM(IOS) to set USE(FILE_LOCK). Would be nice to use OS(DARWIN), but that would be
a change in behavior that might be incorrect. Removed bogus comments in
the USE(NEW_THEME) setting code. Removed redundant code to set USE(CA),
which exactly duplicates code that already exists in Platform.h.
Source/WTF:
- wtf/Platform.h: Added PLATFORM(COCOA), which for now is set at exactly the same
times that PLATFORM(MAC) is. Added USE(FOUNDATION), which is set at the same times
that PLATFORM(COCOA) is. Re-organize the PLATFORM(MAC) and PLATFORM(IOS) settings
in the header so they are a bit easier to read. Put HAVE_LANGINFO_H in with the
rest of the OS(UNIX) settings and put HAVE_READLINE in with the rest of the
OS(DARWIN) settings. Tweak formatting a bit.
- 6:36 PM Changeset in webkit [161852] by
-
- 4 edits in trunk/Source/WTF
Remove AtomicallyInitializedStatic
https://bugs.webkit.org/show_bug.cgi?id=126864
Reviewed by Darin Adler.
- wtf/Threading.h:
- wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading):
- wtf/ThreadingWin.cpp:
(WTF::initializeThreading):
- 6:29 PM Changeset in webkit [161851] by
-
- 89 edits in trunk/Source
Add deprecatedCharacters as a synonym for characters and convert most call sites
https://bugs.webkit.org/show_bug.cgi?id=126858
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
- API/JSStringRef.cpp:
(JSStringGetCharactersPtr):
(JSStringGetUTF8CString):
(JSStringIsEqual):
- API/JSStringRefCF.cpp:
(JSStringCopyCFString):
- API/OpaqueJSString.h:
(OpaqueJSString::characters):
(OpaqueJSString::deprecatedCharacters):
(OpaqueJSString::length):
(OpaqueJSString::OpaqueJSString):
- inspector/InspectorValues.cpp:
(Inspector::InspectorValue::parseJSON):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::parseInt):
- runtime/StringPrototype.cpp:
(JSC::localeCompare):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncLink):
Use deprecatedCharacters instead of characters.
Source/WebCore:
- Modules/indexeddb/IDBKeyPath.cpp:
(WebCore::IDBKeyPathLexer::IDBKeyPathLexer):
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::setSubprotocol):
(WebCore::ThreadableWebSocketChannelClientWrapper::setExtensions):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::hasMisspelling):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::serialize):
(WebCore::CloneSerializer::write):
- dom/CharacterData.cpp:
(WebCore::CharacterData::parserAppendData):
- dom/Document.cpp:
(WebCore::Document::parseQualifiedName):
- editing/Editor.cpp:
(WebCore::Editor::misspelledWordAtCaretOrRange):
(WebCore::Editor::misspelledSelectionString):
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
- editing/TextCheckingHelper.cpp:
(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
(WebCore::TextCheckingHelper::findFirstBadGrammar):
(WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange):
- editing/TextCheckingHelper.h:
(WebCore::TextCheckingParagraph::textDeprecatedCharacters):
- editing/TextIterator.cpp:
(WebCore::collapsedSpaceLength):
(WebCore::SimplifiedBackwardsTextIterator::handleTextNode):
(WebCore::containsKanaLetters):
(WebCore::SearchBuffer::SearchBuffer):
- editing/TextIterator.h:
(WebCore::TextIterator::characters):
- editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::characterAfter):
- editing/VisibleUnits.cpp:
(WebCore::wordBreakIteratorForMinOffsetBoundary):
(WebCore::wordBreakIteratorForMaxOffsetBoundary):
(WebCore::visualWordPosition):
(WebCore::previousBoundary):
(WebCore::nextBoundary):
- fileapi/WebKitBlobBuilder.cpp:
(WebCore::BlobBuilder::append):
- html/FormDataList.cpp:
(WebCore::FormDataList::appendString):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::normalizeSpaces):
- html/parser/HTMLParserIdioms.cpp:
(WebCore::parseImagesWithScaleFromSrcsetAttribute):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::ExternalCharacterTokenBuffer):
- loader/appcache/ManifestParser.cpp:
(WebCore::parseManifest):
- page/ContentSecurityPolicy.cpp:
(WebCore::isSourceListNone):
(WebCore::CSPSourceList::parse):
(WebCore::NonceDirective::parse):
(WebCore::MediaListDirective::parse):
(WebCore::CSPDirectiveList::parse):
(WebCore::CSPDirectiveList::parseReportURI):
(WebCore::CSPDirectiveList::parseReflectedXSS):
(WebCore::ContentSecurityPolicy::didReceiveHeader):
- page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeFrame):
(WebCore::PageSerializer::serializeCSSStyleSheet):
- platform/Length.cpp:
(WebCore::newCoordsArray):
(WebCore::newLengthArray):
- platform/LinkHash.cpp:
(WebCore::visitedURL):
(WebCore::visitedLinkHash):
- platform/SharedBuffer.cpp:
(WebCore::utf8Buffer):
- platform/URL.cpp:
(WebCore::URL::port):
(WebCore::encodeHostnames):
- platform/graphics/StringTruncator.cpp:
(WebCore::centerTruncateToBuffer):
(WebCore::rightTruncateToBuffer):
(WebCore::rightClipToCharacterBuffer):
(WebCore::rightClipToWordBuffer):
(WebCore::leftTruncateToBuffer):
(WebCore::truncateString):
(WebCore::StringTruncator::width):
- platform/graphics/TextRun.h:
(WebCore::TextRun::TextRun):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):
- platform/network/FormDataBuilder.cpp:
(WebCore::FormDataBuilder::addFilenameToMultiPartHeader):
- platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::bindBlob):
(WebCore::SQLiteStatement::bindText):
- platform/text/DecodeEscapeSequences.h:
(WebCore::decodeEscapeSequences):
- platform/text/TextBreakIterator.cpp:
(WebCore::numGraphemeClusters):
(WebCore::numCharactersInGraphemeClusters):
- platform/text/TextBreakIteratorICU.cpp:
(WebCore::setUpIteratorWithRules):
- platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::encode):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::constructTextRun):
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint):
- rendering/RenderText.cpp:
(WebCore::maxWordFragmentWidth):
(WebCore::RenderText::computePreferredLogicalWidths):
(WebCore::RenderText::computeCanUseSimpleFontCodePath):
- rendering/RenderText.h:
(WebCore::RenderText::characters):
(WebCore::RenderText::deprecatedCharacters):
- rendering/line/BreakingContextInlineHeaders.h:
(WebCore::tryHyphenating):
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::constructTextRun):
- rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
(WebCore::processRenderSVGInlineText):
- rendering/svg/SVGTextLayoutEngine.cpp:
(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):
- rendering/svg/SVGTextMetrics.cpp:
(WebCore::SVGTextMetrics::measureCharacterRange):
(WebCore::SVGTextMetrics::SVGTextMetrics):
- rendering/svg/SVGTextMetricsBuilder.cpp:
(WebCore::SVGTextMetricsBuilder::initializeMeasurementWithTextRenderer):
- svg/SVGAngle.cpp:
(WebCore::SVGAngle::setValueAsString):
- svg/SVGAnimateMotionElement.cpp:
(WebCore::parsePoint):
- svg/SVGAnimationElement.cpp:
(WebCore::parseKeySplines):
- svg/SVGFitToViewBox.cpp:
(WebCore::SVGFitToViewBox::parseViewBox):
- svg/SVGFontData.cpp:
(WebCore::SVGFontData::applySVGGlyphSelection):
- svg/SVGGlyphMap.h:
(WebCore::SVGGlyphMap::addGlyph):
(WebCore::SVGGlyphMap::collectGlyphsForString):
- svg/SVGGlyphRefElement.cpp:
(WebCore::SVGGlyphRefElement::parseAttribute):
- svg/SVGLength.cpp:
(WebCore::SVGLength::setValueAsString):
- svg/SVGLengthList.cpp:
(WebCore::SVGLengthList::parse):
- svg/SVGNumberList.cpp:
(WebCore::SVGNumberList::parse):
- svg/SVGParserUtilities.cpp:
(WebCore::parseNumberFromString):
(WebCore::parseNumberOptionalNumber):
(WebCore::parseRect):
(WebCore::pointsListFromSVGData):
(WebCore::parseGlyphName):
(WebCore::parseKerningUnicodeString):
(WebCore::parseDelimitedString):
- svg/SVGPreserveAspectRatio.cpp:
(WebCore::SVGPreserveAspectRatio::parse):
- svg/SVGStringList.cpp:
(WebCore::SVGStringList::parse):
- svg/SVGTransformList.cpp:
(WebCore::SVGTransformList::parse):
- svg/SVGTransformable.cpp:
(WebCore::SVGTransformable::parseTransformType):
- svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::parseViewSpec):
- svg/SVGZoomAndPan.h:
(WebCore::SVGZoomAndPan::parseAttribute):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send):
- xml/XSLStyleSheetLibxslt.cpp:
(WebCore::XSLStyleSheet::parseString):
- xml/XSLTUnicodeSort.cpp:
(WebCore::xsltUnicodeSortFunction):
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::doWrite):
(WebCore::parseAttributes):
Use deprecatedCharacters instead of characters.
Source/WebKit/mac:
- History/BinaryPropertyList.cpp:
(BinaryPropertyListSerializer::appendStringObject):
Use deprecatedCharacters instead of characters.
Source/WebKit2:
- Shared/APIString.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::checkTextOfParagraph):
(WebKit::WebPageProxy::checkSpellingOfString):
(WebKit::WebPageProxy::checkGrammarOfString):
- WebProcess/WebPage/EncoderAdapter.cpp:
(WebKit::EncoderAdapter::encodeString):
Use deprecatedCharacters instead of characters.
Source/WTF:
- wtf/text/AtomicString.cpp:
(WTF::HashAndUTF8CharactersTranslator::equal):
(WTF::SubstringTranslator::hash):
(WTF::SubstringTranslator::equal):
- wtf/text/AtomicString.h:
(WTF::AtomicString::characters):
- wtf/text/Base64.cpp:
(WTF::base64Decode):
(WTF::base64URLDecode):
- wtf/text/StringBuilder.h:
(WTF::StringBuilder::characters):
(WTF::StringBuilder::deprecatedCharacters):
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::getData16SlowCase):
(WTF::StringImpl::upper):
(WTF::StringImpl::lower):
(WTF::StringImpl::find):
(WTF::StringImpl::findIgnoringCase):
- wtf/text/StringImpl.h:
(WTF::StringImpl::characters):
(WTF::StringImpl::deprecatedCharacters):
(WTF::StringImpl::getCharacters<UChar>):
(WTF::equalIgnoringNullity):
- wtf/text/WTFString.cpp:
(WTF::String::append):
(WTF::String::appendInternal):
(WTF::String::insert):
(WTF::String::truncate):
(WTF::String::percentage):
- wtf/text/WTFString.h:
(WTF::String::characters):
(WTF::String::deprecatedCharacters):
(WTF::String::getCharactersWithUpconvert<UChar>):
(WTF::append):
Use deprecatedCharacters instead of characters.
- 6:27 PM Changeset in webkit [161850] by
-
- 9 edits in trunk/Source
Add type checking to isEqual methods
https://bugs.webkit.org/show_bug.cgi?id=126862
Reviewed by Anders Carlsson.
Source/WebCore:
- page/ios/WebEventRegion.mm:
(-[WebEventRegion isEqual:]): Add type checking on the argument.
Add a FIXME about the lack of a hash method override. Formatted to match
the usual WebKit coding style.
Source/WebKit/ios:
- WebCoreSupport/WebVisiblePosition.mm:
(-[WebVisiblePosition isEqual:]): Add type checking on the argument.
Add a FIXME about the lack of a hash method override. Simplified by
removing the unneeded local variables.
Source/WebKit/mac:
- WebCoreSupport/WebSecurityOrigin.mm:
(-[WebSecurityOrigin isEqual:]): Added a FIXME about the lack of a hash method
override. Tweaked formatting.
- WebView/WebDashboardRegion.mm:
(-[WebDashboardRegion isEqual:]): Added type checking on the argument. Added a
FIXME about the lack of a hash method override.
Source/WebKit2:
- UIProcess/API/ios/WKInteractionView.mm:
(-[WKTextRange isEqual:]): Added type checking for the argument. The old
code asserted instead, and it's not clear what guarantees that assertion is
true. Added a FIXME about the lack of a hash method. Added another FIXME
about the fact that this method ignores much of the object state. Removed
an unneeded extra fetch of the isRange property. Deleted some dead code.
(-[WKTextPosition isEqual:]): Ditto.
- 6:23 PM Changeset in webkit [161849] by
-
- 5 edits in trunk/Source
Remove the last remaining uses of AtomicallyInitializedStatic
https://bugs.webkit.org/show_bug.cgi?id=126863
Reviewed by Darin Adler.
Source/WebKit2:
- Shared/mac/SecItemShim.cpp:
(WebKit::responseMap):
Source/WTF:
- wtf/HashTable.cpp:
(WTF::hashTableStatsMutex):
(WTF::HashTableStats::recordCollisionAtCount):
(WTF::HashTableStats::dumpStats):
- wtf/unicode/icu/CollatorICU.cpp:
(WTF::cachedCollatorMutex):
(WTF::Collator::createCollator):
(WTF::Collator::releaseCollator):
- 6:07 PM Changeset in webkit [161848] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the 32-bit build.
- platform/text/icu/UTextProviderLatin1.cpp:
(WebCore::uTextLatin1Clone):
(WebCore::uTextLatin1Extract):
(WebCore::uTextLatin1MapNativeIndexToUTF16):
- 6:01 PM Changeset in webkit [161847] by
-
- 5 edits in trunk/Source/WebCore
Remove all uses of AtomicallyInitializedStatic from WebCore
https://bugs.webkit.org/show_bug.cgi?id=126861
Reviewed by Darin Adler.
- Modules/indexeddb/IDBPendingTransactionMonitor.cpp:
(WebCore::transactions):
- fileapi/ThreadableBlobRegistry.cpp:
(WebCore::originMap):
- platform/text/TextEncodingRegistry.cpp:
(WebCore::encodingRegistryMutex):
(WebCore::newTextCodec):
(WebCore::atomicCanonicalTextEncodingName):
(WebCore::dumpTextEncodingNameMap):
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::DefaultSharedWorkerRepository::instance):
- 5:44 PM Changeset in webkit [161846] by
-
- 2 edits in trunk/Source/WebCore
Use an std::atomic<uint32_t> when computing IDBDatabase transaction IDs
https://bugs.webkit.org/show_bug.cgi?id=126853
Reviewed by Sam Weinig.
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::nextTransactionId):
- 5:38 PM Changeset in webkit [161845] by
-
- 2 edits in trunk/Tools
[iOS] Fix the build
For now, ensure we build WebKit System Interface before we build WebKit.
We'll remove this constraint and the constraint to build WebKit Additions
in a subsequent commit.
- Scripts/build-webkit:
- 5:28 PM Changeset in webkit [161844] by
-
- 9 edits in trunk/Source/WebCore
TextBreakIterator's should support Latin-1 for all iterator types (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=126856
Reviewed by Darin Adler.
- Do some initial cleanup before adding complete Latin-1 support.
- platform/text/TextBreakIterator.cpp:
Remove non-ICU acquireLineBreakIterator() implementation.
- platform/text/TextBreakIterator.h:
- Changes acquireLineBreakIterator() to take a StringView.
- platform/text/TextBreakIteratorICU.cpp:
- Refactor iterator initialization and setting of text on the iterator.
- Add support for using a Latin-1 provider (this is not currently used).
- platform/text/icu/UTextProviderLatin1.cpp:
- platform/text/icu/UTextProviderLatin1.h:
- Add back non-context aware Latin-1 provider (from r129662).
- Rename context aware provider.
- platform/text/icu/UTextProviderUTF16.cpp:
- platform/text/icu/UTextProviderUTF16.h:
- Rename context aware provider.
- 5:26 PM Changeset in webkit [161843] by
-
- 7 edits in trunk
[WebGL] Error messages should use source code labels, not internal mangled symbols.
https://bugs.webkit.org/show_bug.cgi?id=126832
Reviewed by Dean Jackson.
Source/WebCore:
Revised fast/canvas/webgl/glsl-conformance.html.
- platform/graphics/ANGLEWebKitBridge.cpp:
(WebCore::getSymbolInfo): Correct missing 'break'.
(WebCore::ANGLEWebKitBridge::compileShaderSource): Call 'getSymbolInfo'
for SH_VARYINGS.
- platform/graphics/GraphicsContext3D.h: Add new declarations.
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::compileShader): Demangle log output.
(WebCore::GraphicsContext3D::mappedSymbolName): Added.
(WebCore::GraphicsContext3D::getUnmangledInfoLog): Added.
(WebCore::GraphicsContext3D::getProgramInfoLog): Demangle log output.
(WebCore::GraphicsContext3D::getShaderInfoLog): Demangle log output.
LayoutTests:
- fast/canvas/webgl/glsl-conformance.html: Add log to program output
showing error message to confirm proper labels are being used.
- fast/canvas/webgl/glsl-conformance-expected.txt: updated.
- 4:57 PM Changeset in webkit [161842] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the Windows build after r161839.
- WebCore.vcxproj/WebCoreCommon.props:
- 3:52 PM Changeset in webkit [161841] by
-
- 2 edits in trunk/Source/ThirdParty
Fix the Mac build after r161777.
- gtest/xcode/Config/General.xcconfig: AspenFamily.xcconfig excludes
macosx from SUPPORTED_PLATFORMS, so add it back in ourselves.
- 3:23 PM Changeset in webkit [161840] by
-
- 29 edits in trunk/Source
Reduce use of String::characters
https://bugs.webkit.org/show_bug.cgi?id=126854
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- API/JSValueRef.cpp:
(JSValueMakeFromJSONString): Use characters16 instead of characters for 16-bit case.
Had to remove length check because an empty string could be either 8 bit or 16 bit.
Don't need a null string check before calling is8Bit because JSStringRef can't hold
a null string.
- bindings/ScriptValue.cpp:
(Deprecated::jsToInspectorValue): Use the existing string here instead of creating
a new one by calling characters and length on the old string. I think this may be
left over from when string types were not the same in JavaScriptCore and WebCore.
Also rewrite the property names loop to use modern for syntax and fewer locals.
- inspector/InspectorValues.cpp:
(Inspector::escapeChar): Changed to use appendLiteral instead of hard-coding string
lengths. Moved handling of "<" and ">" in here instead of at the call site.
(Inspector::doubleQuoteString): Simplify the code so there is no use of characters
and length. This is still an inefficient way of doing this job and could use a rethink.
- runtime/DatePrototype.cpp:
(JSC::formatLocaleDate): Use RetainPtr, createCFString, and the conversion from
CFStringRef to WTF::String to remove a lot of unneeded code.
- runtime/Identifier.h: Removed unneeded Identifier::characters function.
- runtime/JSStringBuilder.h:
(JSC::JSStringBuilder::append): Use characters16 instead of characters function here,
since we have already checked is8Bit above.
Source/WebCore:
- bindings/objc/WebScriptObject.mm:
(+[WebScriptObject _convertValueToObjcValue:JSC::originRootObject:rootObject:]):
Get rid of unneeded code to turn a WTF::String into an NSString, since that's
built into the WTF::String class.
- editing/CompositeEditCommand.cpp:
(WebCore::containsOnlyWhitespace): Use WTF::String's [] operator instead of
an explicit call to the characters function. Small performance cost.
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::insertText): Ditto.
- editing/VisibleUnits.cpp:
(WebCore::startOfParagraph): Use reverseFind instead of writing our own loop.
(WebCore::endOfParagraph): Use find instead of writing our own loop.
- html/parser/HTMLParserIdioms.cpp:
(WebCore::stripLeadingAndTrailingHTMLSpaces): Use characters16 instead of
characters since we have already checked is8Bit.
(WebCore::parseHTMLNonNegativeInteger): Ditto. Replace the length check with
a check of isNull since a zero length string could be 8 bit, but it's not
safe to call is8Bit on a null WTF::String. (That should probably be fixed.)
- inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::createSearchRegexSource): Use StringBuilder
instead of String in code that builds up a string one character at a time.
The old way was ridiculously slow because it allocated a new string for every
character; the new way still isn't all that efficient, but it's better. Also
changed to use strchr instead of WTF::String::find for special characters.
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::newLineAndWhitespaceDelimiters): Use WTF::String's
[] operator instead of an explicit call to the characters function.
- inspector/InspectorStyleTextEditor.cpp:
(WebCore::InspectorStyleTextEditor::insertProperty): Ditto.
(WebCore::InspectorStyleTextEditor::internalReplaceProperty): Ditto.
- platform/Length.cpp:
(WebCore::newCoordsArray): Ditto.
- platform/LinkHash.cpp:
(WebCore::visitedLinkHash): Use characters16 instead of characters since
we have already checked is8Bit. Replace the length check with a check of
isNull (as above in parseHTMLNonNegativeInteger).
- platform/graphics/Color.cpp:
(WebCore::Color::parseHexColor): Use characters16 since we already checked is8Bit.
(WebCore::Color::Color): Ditto.
- platform/graphics/TextRun.h:
(WebCore::TextRun::TextRun): Use characters16 instead of characters since
we have already checked is8Bit. Replace the length check with a check of
isNull (as above in parseHTMLNonNegativeInteger).
- platform/text/TextEncodingRegistry.cpp:
(WebCore::atomicCanonicalTextEncodingName): Use characters16 instead of
characters since we already checked is8Bit. Also use isEmpty instead of !length.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::constructTextRun): Use characters16 instead of characters
since we have already checked is8Bit. Replace the length check with a check of
isNull (as above in parseHTMLNonNegativeInteger).
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::width): Check for zero length instead of checking
for null characters.
- svg/SVGFontElement.cpp:
(WebCore::SVGFontElement::registerLigaturesInGlyphCache): Rewrite ligatures
for loop and give local variables a better name. Construct the substring with
the substring function. Still a really inefficient approach -- allocating a new
string for every character is absurdly expensive.
- xml/XPathFunctions.cpp:
(WebCore::XPath::FunId::evaluate): Use String instead of StringBuilder. Still
not all that efficient, but better than before. Use substring to construct the
substring.
- xml/XPathNodeSet.h: Added begin and end functions so we can use a C++11 for
loop with this class.
Source/WTF:
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::replace): Use characters16 here since is8Bit was already checked.
- wtf/text/WTFString.h:
(WTF::String::isAllSpecialCharacters): Use characters16 here since is8Bit was
already checked. Also renamed "len" to "length".
- 3:04 PM Changeset in webkit [161839] by
-
- 5 edits12 adds in trunk
Use the Selector Code Generator for matching in SelectorQuery
https://bugs.webkit.org/show_bug.cgi?id=126185
Reviewed by Ryosuke Niwa.
Source/WebCore:
Compile selectors on demand and use the generated binary to perform
element matching in SelectorQuery.
Tests: fast/selectors/querySelector-long-adjacent-backtracking.html
fast/selectors/querySelector-long-child-backtracking.html
fast/selectors/querySelector-mixed-child-adjacent-backtracking.html
fast/selectors/querySelector-multiple-simple-child-backtracking.html
fast/selectors/querySelector-simple-adjacent-backtracking.html
fast/selectors/querySelector-simple-child-backtracking.html
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::executeCompiledSimpleSelectorChecker):
(WebCore::SelectorDataList::executeCompiledSelectorCheckerWithContext):
(WebCore::SelectorDataList::execute):
- dom/SelectorQuery.h:
LayoutTests:
Add some tests for longer backtracking cases typically not covered by the other tests.
- fast/selectors/querySelector-long-adjacent-backtracking-expected.txt: Added.
- fast/selectors/querySelector-long-adjacent-backtracking.html: Added.
- fast/selectors/querySelector-long-child-backtracking-expected.txt: Added.
- fast/selectors/querySelector-long-child-backtracking.html: Added.
- fast/selectors/querySelector-mixed-child-adjacent-backtracking-expected.txt: Added.
- fast/selectors/querySelector-mixed-child-adjacent-backtracking.html: Added.
- fast/selectors/querySelector-multiple-simple-child-backtracking-expected.txt: Added.
- fast/selectors/querySelector-multiple-simple-child-backtracking.html: Added.
- fast/selectors/querySelector-simple-adjacent-backtracking-expected.txt: Added.
- fast/selectors/querySelector-simple-adjacent-backtracking.html: Added.
- fast/selectors/querySelector-simple-child-backtracking-expected.txt: Added.
- fast/selectors/querySelector-simple-child-backtracking.html: Added.
- 2:07 PM Changeset in webkit [161838] by
-
- 2 edits in trunk/Source/WebCore
Simplify creation of XMLHttpRequestStaticData
https://bugs.webkit.org/show_bug.cgi?id=126852
Reviewed by Sam Weinig.
Add a staticData() getter that does the initialization and get rid of the explicit
calls to initializeXMLHttpRequestStaticData().
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData):
(WebCore::staticData):
(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::isAllowedHTTPHeader):
- 1:38 PM Changeset in webkit [161837] by
-
- 2 edits in trunk/Source/WebCore
Final WebCore link error: update a symbol in WebCoreSystemInterfaceIOS.mm.
- platform/ios/WebCoreSystemInterfaceIOS.mm:
- 1:37 PM Changeset in webkit [161836] by
-
- 2 edits in trunk/Source/WebKit2
Added a reference to WebContentService/Info-OSX.plist to the project.
- WebKit2.xcodeproj/project.pbxproj:
- 1:31 PM Changeset in webkit [161835] by
-
- 2 edits in trunk/Source/WebCore
Use std::call_once instead of AtomicallyInitializedStatic in DatabaseBackendBase
https://bugs.webkit.org/show_bug.cgi?id=126851
Reviewed by Sam Weinig.
- Modules/webdatabase/DatabaseBackendBase.cpp:
(WebCore::guidMutex):
(WebCore::guidToVersionMap):
(WebCore::updateGuidVersionMap):
(WebCore::guidToDatabaseMap):
(WebCore::guidForOriginAndName):
(WebCore::DatabaseBackendBase::DatabaseBackendBase):
(WebCore::DatabaseBackendBase::closeDatabase):
(WebCore::DatabaseBackendBase::performOpenAndVerify):
(WebCore::DatabaseBackendBase::getCachedVersion):
(WebCore::DatabaseBackendBase::setCachedVersion):
- 1:23 PM Changeset in webkit [161834] by
-
- 2 edits1 move in trunk/Source/WebKit2
OS X build fix.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist: Copied from WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist.
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist: Removed.
- 1:14 PM Changeset in webkit [161833] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the Windows build after r161830.
- platform/network/NetworkStateNotifier.h:
- 1:09 PM Changeset in webkit [161832] by
-
- 2 edits in trunk/Source/WebCore
Don't build JSTouch* and JSGesture* files on Mac.
- Configurations/WebCore.xcconfig:
- 1:04 PM Changeset in webkit [161831] by
-
- 2 edits in trunk/Source/WebKit2
Build Fix: Objective-C GC should be unsupported in iOS WebKit2
- Configurations/Base.xcconfig:
- 12:59 PM Changeset in webkit [161830] by
-
- 3 edits in trunk/Source/WebCore
Clean up NetworkStateNotifier class
https://bugs.webkit.org/show_bug.cgi?id=126850
Reviewed by Andreas Kling.
Use std::call_once instead of AtomicallyInitializedStatic and a std::function
instead of a custom function pointer typedef.
- platform/network/NetworkStateNotifier.cpp:
(WebCore::networkStateNotifier):
(WebCore::NetworkStateNotifier::addNetworkStateChangeListener):
(WebCore::NetworkStateNotifier::notifyNetworkStateChange):
- platform/network/NetworkStateNotifier.h:
- 12:54 PM Changeset in webkit [161829] by
-
- 7 edits2 copies in trunk/Source/WebKit2
[iOS] Upstream WebKit2 xcconfig changes to fix the build
- Configurations/All-iOS.xcconfig: Added.
- Configurations/Base.xcconfig:
- Configurations/BaseLegacyProcess.xcconfig:
- Configurations/BaseTarget.xcconfig:
- Configurations/BaseXPCService.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/WebContentService.xcconfig:
- Configurations/iOS.xcconfig: Added.
- 12:50 PM Changeset in webkit [161828] by
-
- 2 edits in trunk/Source/WebCore
Add implementations of Frame::viewportArguments() and
Frame::setViewportArguments().
- page/ios/FrameIOS.mm:
(WebCore::Frame::viewportArguments):
(WebCore::Frame::setViewportArguments):
- 12:38 PM Changeset in webkit [161827] by
-
- 2 edits in trunk/Source/WebCore
Add JSWebKitPlaybackTargetAvailabilityEvent.* to the project.
- WebCore.xcodeproj/project.pbxproj:
- 12:38 PM Changeset in webkit [161826] by
-
- 2 edits1 add in trunk/Source/WebCore
Stub out some DragImage functions for iOS.
- WebCore.xcodeproj/project.pbxproj:
- platform/ios/DragImageIOS.mm: Added.
(WebCore::dragImageSize):
(WebCore::scaleDragImage):
(WebCore::createDragImageFromImage):
- 12:12 PM Changeset in webkit [161825] by
-
- 2 edits in trunk/Source/WebCore
We need DragImage.cpp code even when ENABLE_DRAG_SUPPORT is
not defined, because these are actually generic snapshotting
functions.
- platform/DragImage.cpp:
- 12:12 PM Changeset in webkit [161824] by
-
- 3 edits in trunk/Source/WebCore
Fix linker errors: add DateTimeFormat.cpp to the project,
and make DateInputType::DateInputType not inline.
- WebCore.xcodeproj/project.pbxproj:
- html/DateInputType.cpp:
(WebCore::DateInputType::DateInputType):
- platform/DragImage.cpp:
- 12:12 PM Changeset in webkit [161823] by
-
- 2 edits in trunk/Source/WebCore
Fix a bunch of linker errors related to exported functions.
I removed some iOS symbols from the .exp.in file; we may have
to add some back.
- WebCore.exp.in:
- 12:12 PM Changeset in webkit [161822] by
-
- 2 edits in trunk/Source/WebCore
Add generated JSTouch* and JSGestureEvent.* files to the project.
- WebCore.xcodeproj/project.pbxproj:
- 12:06 PM Changeset in webkit [161821] by
-
- 3 edits in trunk/Source/WebCore
Move implementation of AuthenticationChallenge::setAuthenticationClient() to source file for USE(CFNETWORK)
<http://webkit.org/b/126848>
Reviewed by Simon Fraser.
- platform/network/cf/AuthenticationCF.cpp:
(WebCore::AuthenticationChallenge::setAuthenticationClient):
Move implementation to here...
- platform/network/cf/AuthenticationChallenge.h: ...from here.
Remove duplicate header definitions inside USE(CFNETWORK).
- 12:04 PM Changeset in webkit [161820] by
-
- 2 edits in trunk/Source/JavaScriptCore
[iOS] Enable the JSC Objective-C API
Rubber-stamped by Simon Fraser.
- API/JSBase.h:
- 11:50 AM Changeset in webkit [161819] by
-
- 2 edits in trunk/Source/WebCore
Fix windows.
- WebCore.vcxproj/WebCore.vcxproj:
- 11:45 AM Changeset in webkit [161818] by
-
- 7 edits in trunk/Source
Replace more uses of AtomicallyInitializedStatic with std::call_once
https://bugs.webkit.org/show_bug.cgi?id=126847
Reviewed by Sam Weinig.
Source/WebCore:
- crypto/CryptoAlgorithmRegistry.cpp:
(WebCore::CryptoAlgorithmRegistry::shared):
(WebCore::registryMutex):
(WebCore::CryptoAlgorithmRegistry::getIdentifierForName):
(WebCore::CryptoAlgorithmRegistry::nameForIdentifier):
(WebCore::CryptoAlgorithmRegistry::create):
(WebCore::CryptoAlgorithmRegistry::registerAlgorithm):
- crypto/CryptoAlgorithmRegistry.h:
- inspector/WorkerDebuggerAgent.cpp:
(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::~WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::interruptAndDispatchInspectorCommands):
- workers/WorkerThread.cpp:
(WebCore::threadSetMutex):
(WebCore::workerThreads):
(WebCore::WorkerThread::workerThreadCount):
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::~WorkerThread):
(WebCore::WorkerThread::releaseFastMallocFreeMemoryInAllThreads):
Source/WTF:
- wtf/Forward.h:
Forward declare NeverDestroyed.
- 11:24 AM Changeset in webkit [161817] by
-
- 11 edits7 adds in trunk/Source
Split ICU UText providers out into their own files
https://bugs.webkit.org/show_bug.cgi?id=126834
Reviewed by Anders Carlsson.
Moves the implementation of our custom UText providers out into
their own files.
- UTextProviderLatin1.h/cpp contains the Latin-1 provider.
- UTextProviderUTF16.h/cpp contains the UTF-16 provider.
- UTextProvider.h/cpp contains code common to all the providers.
- CMakeLists.txt:
- GNUmakefile.list.am:
- PlatformGTK.cmake:
- WebCore.vcxproj/WebCoreCommon.props:
- WebCore.vcxproj/copyForwardingHeaders.cmd:
- WebCore.xcodeproj/project.pbxproj:
- platform/text/TextAllInOne.cpp:
- platform/text/TextBreakIteratorICU.cpp:
(WebCore::setUpIterator):
(WebCore::wordBreakIterator):
(WebCore::acquireLineBreakIterator):
(WebCore::sentenceBreakIterator):
(WebCore::setUpIteratorWithRules):
- platform/text/icu: Added.
- platform/text/icu/UTextProvider.cpp: Added.
(WebCore::fixPointer):
(WebCore::uTextCloneImpl):
- platform/text/icu/UTextProvider.h: Added.
(WebCore::uTextProviderContext):
(WebCore::uTextInitialize):
(WebCore::uTextAccessPinIndex):
(WebCore::uTextAccessInChunkOrOutOfRange):
- platform/text/icu/UTextProviderLatin1.cpp: Added.
- platform/text/icu/UTextProviderLatin1.h: Added.
- platform/text/icu/UTextProviderUTF16.cpp: Added.
- platform/text/icu/UTextProviderUTF16.h: Added.
- 11:15 AM Changeset in webkit [161816] by
-
- 13 edits in trunk
Unreviewed. Fix make distcheck.
Source/JavaScriptCore:
- GNUmakefile.am: Add inline-and-minify-stylesheets-and-scripts.py
to EXTRA_DIST and fix InjectedScriptSource.h generation rule.
- GNUmakefile.list.am: Move InjectedScriptSource.h to
built_nosources to make sure it's not disted.
Source/WebCore:
- GNUmakefile.list.am: Add missing files.
Source/WebKit/gtk:
- GNUmakefile.am: Add enum types template files to EXTRA_DIST.
Source/WebKit2:
- GNUmakefile.am: Add WebKit2InspectorGResourceBundle.xml to
EXTRA_DIST.
- GNUmakefile.list.am: Removed deleted files and add missing ones.
- NetworkProcess/unix/NetworkProcessMainUnix.cpp: Move
ProxyResolverSoup.h to EFL platform ifdef, because GTK port doesn't
build the proxy resolver.
Tools:
- gtk/GNUmakefile.am: Add generate-inspector-gresource-manifest.py
to EXTRA_DIST.
- 11:01 AM Changeset in webkit [161815] by
-
- 2 edits in trunk/Source/WebCore
Fix some CoreVideo linker errors on iOS by softlinking with more CoreVideo
symbols.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
- 10:55 AM Changeset in webkit [161814] by
-
- 3 edits2 adds in trunk
REGRESSION(r160806): line-height is not applied when only present in :link style.
<http://webkit.org/b/126839>
<rdar://problem/15799899>
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/css/line-height-link-style.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::CascadedProperties::Property::apply):
Use the CSSValue for SelectorChecker::MatchLink when applying
style inside a link.
LayoutTests:
- fast/css/line-height-link-style-expected.txt: Added.
- fast/css/line-height-link-style.html: Added.
- 10:47 AM Changeset in webkit [161813] by
-
- 3 edits in trunk/Source/WebCore
[iOS] Fix link errors for iOS: Part 3
- WebCore.exp.in:
- Move some Mac-only symbols to Mac-only section.
- WebCore.xcodeproj/project.pbxproj:
- Add missing references to AuthenticationCF.cpp and CookieJarCFNet.cpp.
- 9:33 AM Changeset in webkit [161812] by
-
- 3 edits in trunk/Source/WebCore
Remove unsafe uses of AtomicallyInitializedStatic
https://bugs.webkit.org/show_bug.cgi?id=126838
Reviewed by Andreas Kling.
AtomicStrings are per thread so any static initialization of them is potentially dangerous
unless it's certain that they're only ever used from the same thread.
This goes against using them with AtomicallyInitializedStatic, so just create AtomicStrings where needed.
(This is highly unlikely to have any real negative performance impact since these two functions
aren't called very frequently).
- loader/CrossOriginAccessControl.cpp:
(WebCore::passesAccessControlCheck):
- page/PerformanceResourceTiming.cpp:
(WebCore::passesTimingAllowCheck):
- 9:29 AM Changeset in webkit [161811] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Fix link errors for iOS: Part 2
- WebCore.exp.in:
- Move some Mac-only symbols to Mac-only section.
- 9:13 AM Changeset in webkit [161810] by
-
- 2 edits in trunk/Source/WebCore
[iOS] First of many iOS fixes to WebCore.exp.in
- WebCore.exp.in:
- Move some Mac-only symbols to Mac-only section.
- Upstream some changes to iOS-only section.
- 8:56 AM Changeset in webkit [161809] by
-
- 4 edits in trunk/Source/WebCore
[iOS] Don't link to Mac-only frameworks when building iOS
<http://webkit.org/b/126841>
- Configurations/WebCore.xcconfig:
(OTHER_LDFLAGS_iphonesimulator): Remove common frameworks that
are already in the Xcode project.
(OTHER_LDFLAGS_macosx): Add Mac-only frameworks removed from the
Xcode project.
- Configurations/WebCoreTestShim.xcconfig:
(OTHER_LDFLAGS[sdk=macosx*]): Link to Carbon.framework for Mac
since it was removed from the Xcode project.
- WebCore.xcodeproj/project.pbxproj: Remove Mac-only frameworks.
- 8:15 AM Changeset in webkit [161808] by
-
- 7 edits in trunk
Source/WebCore: --disable-dependency-tracking causes build failure due to missing directories
https://bugs.webkit.org/show_bug.cgi?id=94488
Patch by Tobias Mueller <tobiasmue@gnome.org> on 2014-01-12
Reviewed by Gustavo Noronha Silva.
Ensure output directory existing
before generating DerivedSources. This allows for
--disable-dependency-tracking to be run.
- GNUmakefile.am: Added new target DerivedSources/ANGLE which is a directory to be created
- bindings/gobject/GNUmakefile.am: Added new target DerivedSources/webkitdom which is a directory to be created
Source/WebKit/gtk: --disable-dependency-tracking causes build failure due to missing directories
https://bugs.webkit.org/show_bug.cgi?id=94488
Patch by Tobias Mueller <tobiasmue@gnome.org> on 2014-01-12
Reviewed by Gustavo Noronha Silva.
Autotools build fix: Ensure output directory existing
before generating DerivedSources. This allows for
--disable-dependency-tracking to be run.
- GNUmakefile.am: Added a new target of the directory in which files are meant to be stored ($(GENSOURCES_WEBKIT)).
Tools: --disable-dependency-tracking causes build failure due to missing directories
https://bugs.webkit.org/show_bug.cgi?id=94488
Patch by Tobias Mueller <tobiasmue@gnome.org> on 2014-01-12
Reviewed by Gustavo Noronha Silva.
Autotools build fix: Ensure output directory existing
before generating DerivedSources. This allows for
--disable-dependency-tracking to be run.
- WebKitTestRunner/GNUmakefile.am: Added a new target of the directory in which files are meant to be stored.
- 8:09 AM Changeset in webkit [161807] by
-
- 2 edits in trunk/Source/WebCore
[iOS] WebFontCache is Mac-only
- WebCore.exp.in: Move export to Mac-only section.
- 8:09 AM Changeset in webkit [161806] by
-
- 2 edits2 adds in trunk/Source/WebCore
[iOS] Upstream WebEventRegion.{h|mm} to fix the build
- WebCore.xcodeproj/project.pbxproj: Add to project.
- page/ios/WebEventRegion.h: Added.
- page/ios/WebEventRegion.mm: Added.
(-[WebEventRegion initWithPoints::::]):
(-[WebEventRegion copyWithZone:]):
(-[WebEventRegion description]):
(-[WebEventRegion hitTest:]):
(-[WebEventRegion isEqual:]):
(-[WebEventRegion quad]):
- 12:45 AM Changeset in webkit [161805] by
-
- 4 edits in trunk
[GTK] Fix return value of WebKitDownload::created-destination
https://bugs.webkit.org/show_bug.cgi?id=126741
Reviewed by Martin Robinson.
Source/WebKit2:
WebKitDownload::created-destination signal should be void instead
of gboolean. This doesn't break the API/ABI.
- UIProcess/API/gtk/WebKitDownload.cpp:
(webkit_download_class_init):
(webkitDownloadDestinationCreated):
Tools:
- TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Fix return
value of several callbacks.
Jan 11, 2014:
- 11:31 PM Changeset in webkit [161804] by
-
- 2 edits in trunk/Source/WebKit2
Support bool argument for encoding/decoding invocations.
https://bugs.webkit.org/show_bug.cgi?id=126823
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-01-11
Reviewed by Sam Weinig.
For remote invocation method argument, current we support int, double and ObjC
object, this patch add support for bool type too.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(encodeInvocation):
(decodeInvocationArguments):
- 11:15 PM Changeset in webkit [161803] by
-
- 3 edits in trunk/WebKitLibraries
[Mac] [Windows] Stop scheduling network requests in WebCore
https://bugs.webkit.org/show_bug.cgi?id=126789
<rdar://problem/15114727>
Update Windows WKSI.
- win/include/WebKitSystemInterface/WebKitSystemInterface.h:
- win/lib32/WebKitSystemInterface.lib:
- 11:15 PM Changeset in webkit [161802] by
-
- 2 edits in trunk/Source/WTF
Unreviewed build fix for ports using GCC after r161770.
- wtf/IteratorAdaptors.h:
(WTF::FilterIterator::operator*): Replicating r161797, the const qualifier for
FilterIterator::operator*() is removed since it clashes with some iterator types
that are also const, causing compilation failures with GCC.
- 10:30 PM Changeset in webkit [161801] by
-
- 4 edits in trunk/Source
Use std::call_once instead of AtomicallyInitializedStatic when creating a HTTP header set
https://bugs.webkit.org/show_bug.cgi?id=126837
Reviewed by Sam Weinig.
Source/WebCore:
Use std::call_once when constructing the HTTPHeaderSet.
- loader/CrossOriginAccessControl.cpp:
(WebCore::isOnAccessControlResponseHeaderWhitelist):
Source/WTF:
- wtf/HashSet.h:
(WTF::HashSet::HashSet):
Add a HashSet constructor that takes an initializer list.
- 9:59 PM Changeset in webkit [161800] by
-
- 3 edits in trunk/Source/WebCore
[iOS] Do not link to ApplicationServices.framework for iOS
<http://webkit.org/b/126835>
Reviewed by Dan Bernstein.
- Configurations/WebCore.xcconfig:
(OTHER_LDFLAGS_macosx): Add -framework ApplicationServices.
- WebCore.xcodeproj/project.pbxproj: Remove reference to
ApplicationServices.framework.
- 9:27 PM Changeset in webkit [161799] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Build fix for StyleResolver.cpp
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::setCompositionFillColor): Added.
- 8:56 PM Changeset in webkit [161798] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Fix build of RenderLayerCompositor::registerAllViewportConstrainedLayers()
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::registerAllViewportConstrainedLayers):
Fix use of std::make_unique<>() and add an adoptPtr() call.
- 8:33 PM Changeset in webkit [161797] by
-
- 2 edits in trunk/Source/WTF
Fix the EFL build.
- wtf/IteratorAdaptors.h:
(WTF::TransformIterator::operator*):
- 8:20 PM Changeset in webkit [161796] by
-
- 23 edits in trunk
[Mac] [Windows] Stop scheduling network requests in WebCore
https://bugs.webkit.org/show_bug.cgi?id=126789
<rdar://problem/15114727>
Source/WebCore:
Reviewed by Sam Weinig.
We'll just send all requests to CFNetwork now, along with associated priorities.
- WebCore.exp.in: WebKitSystemInterface functions are changing to support priorities
for more than just pipelining.
- loader/ResourceLoadScheduler.cpp:
(WebCore::ResourceLoadScheduler::scheduleLoad):
- platform/ios/WebCoreSystemInterfaceIOS.mm:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- platform/network/ResourceHandle.h: For syncronous requests, make it so that they
don't count against HTTP connection limit, to avoid the possibility of hanging the process.
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::createCFURLConnection):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::platformLoadResourceSynchronously):
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::initializeMaximumHTTPConnectionCountPerHost):
(WebCore::initializeHTTPConnectionSettingsOnStartup):
- platform/network/cf/ResourceRequestCFNet.h:
(WebCore::toPlatformRequestPriority):
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::createNSURLConnection):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::platformLoadResourceSynchronously):
- platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
Source/WebKit/mac:
Reviewed by Sam Weinig.
- WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Updated
for new WKSI function names.
Source/WebKit2:
Reviewed by Sam Weinig.
- NetworkProcess/mac/NetworkResourceLoadSchedulerMac.mm:
(WebKit::NetworkResourceLoadScheduler::platformInitializeMaximumHTTPConnectionCountPerHost):
We no longer need the trick with 7 connections, as synchronous requests always have
the right of way.
- UIProcess/API/C/WKContext.cpp: Removed long obsolete functions.
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (InitWebCoreSystemInterface):
Updated for new WKSI function names.
WebKitLibraries:
Update WKSI.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMavericks.a:
- libWebKitSystemInterfaceMountainLion.a:
- 8:13 PM Changeset in webkit [161795] by
-
- 3 edits in trunk/Source/WebCore
[iOS] Fix build failure in WebCore::findEndWordBoundary()
Filed Bug 126830 for the proper fix:
<http://webkit.org/b/126830>
- editing/VisibleUnits.cpp:
(WebCore::endWordBoundary): Switch back to using
WebCore::findWordBoundary() on iOS.
- platform/text/mac/TextBoundaries.mm:
(WebCore::findEndWordBoundary): Add FIXME for iOS implementation
that doesn't use NSAttributedString.
- 7:53 PM Changeset in webkit [161794] by
-
- 3 edits1 add in trunk/LayoutTests
[WebGL] Correct uniform input validation for texture sampler uniforms
https://bugs.webkit.org/show_bug.cgi?id=126775
Reviewed by Anders Carlsson.
- fast/canvas/webgl/uniform-samplers-test-expected.txt: Added.
- fast/canvas/webgl/uniform-samplers-test.html: Corrected resource
includes when moving from khronos suite to our fast suite.
- resources/js-test-pre.js:
(expectTrue): Added.
- 7:23 PM Changeset in webkit [161793] by
-
- 3 edits in trunk/Source/JavaScriptCore
Try again to fix the build.
- inspector/InspectorAgentRegistry.cpp:
- inspector/InspectorAgentRegistry.h:
- 7:00 PM Changeset in webkit [161792] by
-
- 3 edits in trunk/Source/JavaScriptCore
Try to prevent the Vector copy constructor from being instantiated.
- inspector/InspectorAgentRegistry.cpp:
(Inspector::InspectorAgentRegistry::InspectorAgentRegistry):
- inspector/InspectorAgentRegistry.h:
- 6:56 PM Changeset in webkit [161791] by
-
- 3 edits in trunk/Source/JavaScriptCore
Try something else.
- inspector/InspectorAgentRegistry.cpp:
(Inspector::InspectorAgentRegistry::~InspectorAgentRegistry):
- inspector/InspectorAgentRegistry.h:
- 6:51 PM Changeset in webkit [161790] by
-
- 6 edits in trunk/Source/WebCore
[iOS] Move text autosizing code from RenderBlock to RenderBlockFlow
https://bugs.webkit.org/show_bug.cgi?id=126829
Reviewed by Sam Weinig.
Some newly-upstreamed iOS text autosizing code needs to move to
RenderBlockFlow in order to build.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::RenderBlock):
- rendering/RenderBlock.h:
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::RenderBlockFlow):
(WebCore::isVisibleRenderText):
(WebCore::resizeTextPermitted):
(WebCore::RenderBlockFlow::immediateLineCount):
(WebCore::isNonBlocksOrNonFixedHeightListItems):
(WebCore::oneLineTextMultiplier):
(WebCore::textMultiplier):
(WebCore::RenderBlockFlow::adjustComputedFontSizes):
- rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::resetComputedFontSize):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::adjustComputedFontSizesOnBlocks):
(WebCore::RenderObject::resetTextAutosizing):
- 6:51 PM Changeset in webkit [161789] by
-
- 5 edits3 adds in trunk
[JSC] Revise typed array implementations to match ECMAScript and WebGL Specification
https://bugs.webkit.org/show_bug.cgi?id=126754
Patch by Dean Jackson <dino@apple.com> on 2014-01-11
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
The ECMAScript specification forbids calling the typed array
constructors without using "new". Change the call data to return
none so we throw and exception in these cases.
- runtime/JSGenericTypedArrayViewConstructorInlines.h:
(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::getCallData):
LayoutTests:
New test which checks that we throw an exception when calling
any of the typed array constructors without using "new".
- js/script-tests/typedarray-constructors.js: Added.
- js/typedarray-constructors-expected.txt: Added.
- js/typedarray-constructors.html: Added.
- resources/standalone-pre.js: Add missing 'shouldNotThrow'
method (duplicated from resources/js-test-pre.js)
- 6:49 PM Changeset in webkit [161788] by
-
- 3 edits in trunk/Source/JavaScriptCore
Try to fix the build by introducing a constructor.
- inspector/InspectorAgentRegistry.cpp:
(Inspector::InspectorAgentRegistry::InspectorAgentRegistry):
- inspector/InspectorAgentRegistry.h:
- 6:43 PM Changeset in webkit [161787] by
-
- 2 edits in trunk/Source/JavaScriptCore
- inspector/InspectorAgentRegistry.h:
Remove an unused function.
- 6:25 PM Changeset in webkit [161786] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Fix the build
Only call CGContextFlush() when building for OS X < 10.9.
- platform/graphics/cg/ImageBufferBackingStoreCache.cpp:
(WebCore::ImageBufferBackingStoreCache::deallocate):
- 5:54 PM Changeset in webkit [161785] by
-
- 4 edits1 add in trunk
Add support for null StringViews
https://bugs.webkit.org/show_bug.cgi?id=126827
Reviewed by Anders Carlsson.
Source/WTF:
- Do some style cleanup while in the neighborhood.
- wtf/text/StringView.h:
(WTF::StringView::StringView):
Add default constructor to create a null StringView.
(WTF::StringView::isNull):
Add isNull(), matching the semantics of String.
(WTF::StringView::operator bool):
Add an explicit operator bool() to allow use in if-statements.
Tools:
Add new test for StringView.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/StringView.cpp: Added.
(TestWebKitAPI::TEST):
- 4:54 PM Changeset in webkit [161784] by
-
- 39 edits in trunk/Source
InspectorAgentRegistry should use std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=126826
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- inspector/InspectorAgentRegistry.cpp:
(Inspector::InspectorAgentRegistry::append):
- inspector/InspectorAgentRegistry.h:
- inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
- inspector/agents/InspectorAgent.h:
Source/WebCore:
- inspector/InspectorApplicationCacheAgent.h:
- inspector/InspectorCSSAgent.h:
- inspector/InspectorCanvasAgent.h:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorDOMAgent.h:
- inspector/InspectorDOMDebuggerAgent.cpp:
- inspector/InspectorDOMDebuggerAgent.h:
- inspector/InspectorDOMStorageAgent.h:
- inspector/InspectorDatabaseAgent.h:
- inspector/InspectorHeapProfilerAgent.cpp:
- inspector/InspectorHeapProfilerAgent.h:
- inspector/InspectorIndexedDBAgent.h:
- inspector/InspectorInputAgent.h:
- inspector/InspectorLayerTreeAgent.h:
- inspector/InspectorMemoryAgent.cpp:
- inspector/InspectorMemoryAgent.h:
- inspector/InspectorPageAgent.cpp:
- inspector/InspectorPageAgent.h:
- inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::create):
- inspector/InspectorProfilerAgent.h:
- inspector/InspectorResourceAgent.h:
- inspector/InspectorTimelineAgent.h:
- inspector/InspectorWorkerAgent.cpp:
- inspector/InspectorWorkerAgent.h:
- inspector/PageConsoleAgent.h:
- inspector/PageDebuggerAgent.cpp:
- inspector/PageDebuggerAgent.h:
- inspector/PageRuntimeAgent.h:
- inspector/WorkerConsoleAgent.h:
- inspector/WorkerDebuggerAgent.cpp:
- inspector/WorkerDebuggerAgent.h:
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
- inspector/WorkerRuntimeAgent.h:
- 2:56 PM Changeset in webkit [161783] by
-
- 8 edits1 copy1 add in trunk/Source/WebCore
Extract the FormatConverter class out of GraphicsContext3D.cpp and into its own file
https://bugs.webkit.org/show_bug.cgi?id=126820
Patch by Sam Weinig <sam@webkit.org> on 2014-01-11
Reviewed by Anders Carlsson.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/FormatConverter.cpp: Copied from Source/WebCore/platform/graphics/GraphicsContext3D.cpp.
(WebCore::convertFloatToHalfFloat):
(WebCore::FormatConverter::convert):
- platform/graphics/FormatConverter.h: Copied from Source/WebCore/platform/graphics/GraphicsContext3D.cpp.
(WebCore::FormatConverter::FormatConverter):
(WebCore::FormatConverter::success):
- platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::computeFormatAndTypeParameters):
(WebCore::GraphicsContext3D::computeImageSizeInBytes):
(WebCore::GraphicsContext3D::packImageData):
(WebCore::GraphicsContext3D::extractImageData):
(WebCore::GraphicsContext3D::extractTextureData):
(WebCore::GraphicsContext3D::packPixels):
- platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::hasAlpha):
(WebCore::GraphicsContext3D::hasColor):
- 1:58 PM Changeset in webkit [161782] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
Eliminate obviously redundant InvalidationPoints
https://bugs.webkit.org/show_bug.cgi?id=126825
Not yet reviewed.
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::invalidationPointElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
- 1:03 PM Changeset in webkit [161781] by
-
- 1 edit1 add in branches/jsCStack/Source/JavaScriptCore
Unreviewed, add a test for InvalidationPoint in the FTL.
Probably there are other tests that cover this in various ways and it's possible
that we're just not running those tests in the FTL, yet. But anyway I think it's
good to have an FTL-specific test for this.
- tests/stress/invalidation-point.js: Added.
(foo):
(Thingy):
(Thingy.prototype.f):
(possiblyDoBadThings.Thingy.prototype.f):
(possiblyDoBadThings):
- 12:59 PM Changeset in webkit [161780] by
-
- 2 edits in trunk/Source/WebCore
Fix updateScrollingLayerWithClient() for iOS.
- rendering/RenderLayerCompositor.cpp:
(WebCore::updateScrollingLayerWithClient):
- 12:59 PM Changeset in webkit [161779] by
-
- 11 edits in trunk/Source
Unfork GraphicsContext::drawNativeImage for iOS
https://bugs.webkit.org/show_bug.cgi?id=126824
Reviewed by Dean Jackson.
GraphicsContext::drawNativeImage had a different signature for iOS,
which required #ifdefs at all the call sites. Unfork by passing the "scale"
parameter everywhere (it's only used on iOS).
Source/WebCore:
- WebCore.exp.in:
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
- platform/graphics/GraphicsContext.h:
- platform/graphics/cg/BitmapImageCG.cpp:
(WebCore::BitmapImage::draw):
- platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::paintToCanvas):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::platformInit):
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::draw):
- platform/graphics/ios/IconIOS.mm:
(WebCore::Icon::paint):
Source/WebKit2:
- Shared/API/c/cg/WKImageCG.cpp:
(WKImageCreateFromCGImage):
- 12:59 PM Changeset in webkit [161778] by
-
- 2 edits in trunk/Source/WebCore
Work around USE(CFNETWORK) build failure on iOS.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForResponseToAuthenticationChallenge):
- 12:56 PM Changeset in webkit [161777] by
-
- 3 edits1 add in trunk/Source/ThirdParty
[iOS] Upstream gtest
<http://webkit.org/b/126811>
Reviewed by Mark Rowe.
- gtest/xcode/Config/General.xcconfig: Include iOS.xcconfig.
- gtest/xcode/Config/iOS.xcconfig: Added.
- gtest/xcode/gtest.xcodeproj/project.pbxproj: Add iOS.xcconfig.
Sort.
- 12:31 PM Changeset in webkit [161776] by
-
- 4 edits in branches/jsCStack/Source/JavaScriptCore
FTL tier-up should behave the same with CountExecution's as it does without
https://bugs.webkit.org/show_bug.cgi?id=126822
Not yet reviewed.
CountExecution nodes are inserted by the profiler. Prior to this change, their
presence would change how we inserted CheckTierUp nodes, since a CountExecution
might be inserted before a LoopHint thereby making it so the LoopHint was no
longer at the top of a loop header. This makes the code resilient against such
things. The result is that when you enable the profiler, you get the same OSR
behavior as with the profiler disabled.
- dfg/DFGNode.h:
(JSC::DFG::Node::isSemanticallySkippable):
- dfg/DFGOSREntrypointCreationPhase.cpp:
(JSC::DFG::OSREntrypointCreationPhase::run):
- dfg/DFGTierUpCheckInjectionPhase.cpp:
(JSC::DFG::TierUpCheckInjectionPhase::run):
- 12:05 PM Changeset in webkit [161775] by
-
- 2 edits in trunk/Source/WebCore
Fix LegacyWebArchive.cpp:567:91: error: calling 'utf8' with incomplete return type 'WTF::CString'
- loader/archive/cf/LegacyWebArchive.cpp:
- 12:03 PM Changeset in webkit [161774] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Fix the easy half of the build errors in RenderBlock.cpp
- rendering/RenderBlock.cpp:
(WebCore::isNonBlocksOrNonFixedHeightListItems):
(WebCore::oneLineTextMultiplier):
(WebCore::textMultiplier):
(WebCore::RenderBlock::adjustComputedFontSizes):
- 11:56 AM Changeset in webkit [161773] by
-
- 7 edits in trunk/Source/WebCore
Change touch-related headers to include WebKitAdditions headers,
which have been renamed to have IOS suffixes.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/ios/TouchConstructors.cpp:
- dom/Touch.h:
- dom/TouchEvent.h:
- dom/TouchList.h:
- dom/ios/TouchEvents.cpp:
- 11:48 AM Changeset in webkit [161772] by
-
- 2 edits in trunk
[Mac] xcodebuild color output is suppressed when using make
https://bugs.webkit.org/show_bug.cgi?id=126815
Reviewed by Anders Carlsson.
WHen using make, xcodebuild’s output is piped through a filter, which causes it not to
format its output with color and emphasis.
- Makefile.shared: Pass COLOR_DIAGNOSTICS=YES to xcodebuild to force color output on. Due to
xcodebuild limitations, this restores some of the formatting, but not all of it.
- 11:31 AM Changeset in webkit [161771] by
-
- 8 edits in trunk/Source/WebCore
ScriptDebugServer should use a separate member function for its timer handler
https://bugs.webkit.org/show_bug.cgi?id=126819
Reviewed by Sam Weinig.
It's weird to have subclasses override a timer handler and sometimes invoke
the timer handler directly so make it a separate member function instead.
- bindings/js/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::recompileAllJSFunctions):
- bindings/js/PageScriptDebugServer.h:
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::recompileAllJSFunctionsTimerFired):
- bindings/js/ScriptDebugServer.h:
- bindings/js/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::addListener):
(WebCore::WorkerScriptDebugServer::recompileAllJSFunctions):
- bindings/js/WorkerScriptDebugServer.h:
- inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::start):
- 11:17 AM Changeset in webkit [161770] by
-
- 10 edits2 moves in trunk/Source
Clean up iterator filter / iterator range code
https://bugs.webkit.org/show_bug.cgi?id=126817
Reviewed by Anders Carlsson.
Source/WebKit2:
- Shared/APIArray.h:
Update elementsOfType() to use combination of FilterIterator and TransformIterator
(now that FilterIterator no longer has a transform predicate) and make use of the
makeFoo() helpers.
Source/WTF:
- Renames IteratorPair to IteratorRange.
- Splits FilterIterator into FilterIterator (which now only filters) and TransformIterator (which does the transform part of the old FilterIterator). Move both of these to IteratorAdaptors.h
- GNUmakefile.list.am:
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/FilterIterator.h: Removed.
Add/remove files.
- wtf/HashMap.h:
(WTF::HashMap::keys):
(WTF::HashMap::values):
- wtf/RefPtrHashMap.h:
Update for rename to IteratorRange. Simplify by using makeIteratorRange().
- wtf/IteratorAdaptors.h: Copied from wtf/FilterIterator.h.
(WTF::FilterIterator::FilterIterator):
(WTF::FilterIterator::operator*):
(WTF::makeFilterIterator):
(WTF::TransformIterator::TransformIterator):
(WTF::TransformIterator::operator++):
(WTF::TransformIterator::operator*):
(WTF::TransformIterator::operator==):
(WTF::TransformIterator::operator!=):
(WTF::makeTransformIterator):
Split up filtering and transforming. Add makeFilterIterator() and makeTransformIterator()
helpers.
- wtf/IteratorPair.h: Removed.
- wtf/IteratorRange.h: Copied from wtf/IteratorPair.h.
(WTF::IteratorRange::IteratorRange):
(WTF::makeIteratorRange):
Renamed to IteratorRange and adds makeIteratorRange() helper.
- 11:16 AM Changeset in webkit [161769] by
-
- 4 edits in trunk/Source
Simplify Timer and DeferrableOneShotTimer using std::function
https://bugs.webkit.org/show_bug.cgi?id=126816
Reviewed by Sam Weinig.
Source/WebCore:
- platform/Timer.h:
(WebCore::Timer::Timer):
Source/WebKit2:
Add another unexported symbol.
- Configurations/WebKit2.xcconfig:
- 10:19 AM Changeset in webkit [161768] by
-
- 133 edits in trunk/Source/WebCore
CTTE Timer and DeferrableOneShotTimer
https://bugs.webkit.org/show_bug.cgi?id=126814
Reviewed by Antti Koivisto.
Add new Timer and DeferrableOneShotTimer constructors whose member function pointers
take a reference instead of a pointer.
Also, convert a bunch of classes over to using these new constructors.
- Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::keyRequestTimerFired):
(WebCore::MediaKeySession::addKeyTimerFired):
- Modules/encryptedmedia/MediaKeySession.h:
- Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::GeoNotifier::timerFired):
(WebCore::Geolocation::resumeTimerFired):
- Modules/geolocation/Geolocation.h:
- Modules/indexeddb/IDBTransactionBackend.cpp:
(WebCore::IDBTransactionBackend::taskTimerFired):
- Modules/indexeddb/IDBTransactionBackend.h:
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::appendBufferTimerFired):
- Modules/mediasource/SourceBuffer.h:
- Modules/notifications/Notification.cpp:
(WebCore::Notification::taskTimerFired):
- Modules/notifications/Notification.h:
- Modules/notifications/NotificationCenter.cpp:
(WebCore::NotificationCenter::NotificationRequestCallback::timerFired):
- Modules/notifications/NotificationCenter.h:
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::notificationPostTimerFired):
- accessibility/AXObjectCache.h:
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::beginLoadTimerFired):
- css/CSSFontSelector.h:
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::CachedGeneratedImage::evictionTimerFired):
- css/CSSImageGeneratorValue.h:
- dom/Document.cpp:
(WebCore::Document::visualUpdatesSuppressionTimerFired):
(WebCore::Document::styleRecalcTimerFired):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::sharedObjectPoolClearTimerFired):
(WebCore::Document::styleResolverThrowawayTimerFired):
(WebCore::Document::updateFocusAppearanceTimerFired):
(WebCore::Document::resetHiddenFocusElementTimer):
(WebCore::Document::pendingTasksTimerFired):
(WebCore::Document::fullScreenChangeDelayTimerFired):
(WebCore::Document::loadEventDelayTimerFired):
(WebCore::Document::didAssociateFormControlsTimerFired):
- dom/Document.h:
- dom/EventSender.h:
(WebCore::EventSender::timerFired):
- dom/GenericEventQueue.cpp:
(WebCore::GenericEventQueue::timerFired):
- dom/GenericEventQueue.h:
- dom/ScriptRunner.cpp:
(WebCore::ScriptRunner::timerFired):
- dom/ScriptRunner.h:
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::animationTimerFired):
- dom/ScriptedAnimationController.h:
- editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::timerFired):
- editing/AlternativeTextController.h:
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::caretBlinkTimerFired):
- editing/FrameSelection.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
- html/HTMLMediaElement.h:
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::swapRendererTimerFired):
- html/HTMLPlugInElement.h:
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::removeSnapshotTimerFired):
(WebCore::HTMLPlugInImageElement::simulatedMouseClickTimerFired):
- html/HTMLPlugInImageElement.h:
- html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::errorEventTimerFired):
- html/HTMLSourceElement.h:
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::loadTimerFired):
- html/HTMLTrackElement.h:
- html/MediaController.cpp:
(MediaController::asyncEventTimerFired):
(MediaController::clearPositionTimerFired):
(MediaController::timeupdateTimerFired):
- html/MediaController.h:
- html/MediaDocument.cpp:
(WebCore::MediaDocument::replaceMediaElementTimerFired):
- html/MediaDocument.h:
- html/parser/HTMLParserScheduler.cpp:
(WebCore::HTMLParserScheduler::continueNextChunkTimerFired):
- html/parser/HTMLParserScheduler.h:
- html/shadow/MediaControlElementTypes.cpp:
(WebCore::MediaControlSeekButtonElement::seekTimerFired):
- html/shadow/MediaControlElementTypes.h:
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::transitionTimerFired):
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired):
- html/shadow/MediaControlElements.h:
- html/shadow/MediaControls.cpp:
(WebCore::MediaControls::hideFullscreenControlsTimerFired):
- html/shadow/MediaControls.h:
- html/track/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::loadTimerFired):
- html/track/LoadableTextTrack.h:
- inspector/InspectorCSSAgent.cpp:
(WebCore::UpdateRegionLayoutTask::UpdateRegionLayoutTask):
(WebCore::UpdateRegionLayoutTask::timerFired):
(WebCore::ChangeRegionOversetTask::ChangeRegionOversetTask):
(WebCore::ChangeRegionOversetTask::timerFired):
- inspector/InspectorDOMAgent.cpp:
(WebCore::RevalidateStyleAttributeTask::RevalidateStyleAttributeTask):
(WebCore::RevalidateStyleAttributeTask::timerFired):
- inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorBackendDispatchTask::InspectorBackendDispatchTask):
(WebCore::InspectorBackendDispatchTask::timerFired):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
- loader/DocumentLoader.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkTimerFired):
- loader/FrameLoader.h:
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::timerFired):
- loader/ImageLoader.h:
- loader/LinkLoader.cpp:
(WebCore::LinkLoader::linkLoadTimerFired):
(WebCore::LinkLoader::linkLoadingErrorTimerFired):
- loader/LinkLoader.h:
- loader/NavigationScheduler.cpp:
(WebCore::NavigationScheduler::timerFired):
- loader/NavigationScheduler.h:
- loader/PingLoader.cpp:
(WebCore::PingLoader::PingLoader):
- loader/PingLoader.h:
(WebCore::PingLoader::timeoutTimerFired):
- loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::progressHeartbeatTimerFired):
- loader/ProgressTracker.h:
- loader/ResourceLoadScheduler.cpp:
(WebCore::ResourceLoadScheduler::requestTimerFired):
- loader/ResourceLoadScheduler.h:
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::decodedDataDeletionTimerFired):
(WebCore::CachedResource::CachedResourceCallback::timerFired):
- loader/cache/CachedResource.h:
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):
- loader/cache/CachedResourceLoader.h:
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::syncTimerFired):
- loader/icon/IconDatabase.h:
- page/AutoscrollController.cpp:
(WebCore::AutoscrollController::autoscrollTimerFired):
- page/AutoscrollController.h:
- page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::timerFired):
- page/CaptionUserPreferences.h:
- page/DeviceController.cpp:
(WebCore::DeviceController::fireDeviceEvent):
- page/DeviceController.h:
- page/EventHandler.cpp:
(WebCore::EventHandler::cursorUpdateTimerFired):
(WebCore::EventHandler::autoHideCursorTimerFired):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):
(WebCore::EventHandler::hoverTimerFired):
- page/EventHandler.h:
- page/EventSource.cpp:
(WebCore::EventSource::connectTimerFired):
- page/EventSource.h:
- page/FrameView.cpp:
(WebCore::FrameView::deferredRepaintTimerFired):
(WebCore::FrameView::layoutTimerFired):
(WebCore::FrameView::postLayoutTimerFired):
- page/FrameView.h:
- page/PageThrottler.cpp:
(WebCore::PageThrottler::throttleHysteresisTimerFired):
- page/PageThrottler.h:
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
(WebCore::AnimationControllerPrivate::animationTimerFired):
- page/animation/AnimationControllerPrivate.h:
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::autoscrollTimerFired):
- platform/Scrollbar.h:
- platform/Timer.h:
(WebCore::Timer::Timer):
(WebCore::DeferrableOneShotTimer::DeferrableOneShotTimer):
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::advanceAnimation):
- platform/graphics/BitmapImage.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::reloadTimerFired):
- platform/graphics/MediaPlayer.h:
- platform/graphics/ca/mac/LayerPool.h:
- platform/graphics/ca/mac/LayerPool.mm:
(WebCore::LayerPool::pruneTimerFired):
- platform/graphics/cg/ImageBufferBackingStoreCache.cpp:
(WebCore::ImageBufferBackingStoreCache::timerFired):
- platform/graphics/cg/ImageBufferBackingStoreCache.h:
- platform/graphics/cg/SubimageCacheWithTimer.cpp:
(WebCore::SubimageCacheWithTimer::invalidateCacheTimerFired):
- platform/graphics/cg/SubimageCacheWithTimer.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::seekTimerFired):
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
(WebCore::ScrollAnimatorMac::initialScrollbarPaintTimerFired):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledTimerFired):
- platform/mock/DeviceOrientationClientMock.cpp:
(WebCore::DeviceOrientationClientMock::timerFired):
- platform/mock/DeviceOrientationClientMock.h:
- platform/network/NetworkStateNotifier.h:
- platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::failureTimerFired):
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
- platform/network/mac/NetworkStateNotifierMac.cpp:
(WebCore::NetworkStateNotifier::networkStateChangeTimerFired):
- rendering/ImageQualityController.cpp:
(WebCore::ImageQualityController::highQualityRepaintTimerFired):
- rendering/ImageQualityController.h:
- rendering/RenderButton.cpp:
(WebCore::RenderButton::timerFired):
- rendering/RenderButton.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateCompositingLayersTimerFired):
(WebCore::RenderLayerCompositor::layerFlushTimerFired):
(WebCore::RenderLayerCompositor::paintRelatedMilestonesTimerFired):
- rendering/RenderLayerCompositor.h:
- rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::timerFired):
- rendering/RenderMarquee.h:
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::regionLayoutUpdateEventTimerFired):
(WebCore::RenderNamedFlowThread::regionOversetChangeEventTimerFired):
- rendering/RenderNamedFlowThread.h:
- rendering/RenderProgress.cpp:
(WebCore::RenderProgress::animationTimerFired):
- rendering/RenderProgress.h:
- 8:58 AM Changeset in webkit [161767] by
-
- 4 edits in trunk/Source/WebCore
- dom/Touch.h:
- dom/TouchEvent.h:
- dom/TouchList.h:
- 8:58 AM Changeset in webkit [161766] by
-
- 3 edits in trunk/Source/WebCore
No need to include <ApplicationServices/ApplicationServices.h> in
the header. Can use <CoreGraphics/CoreGraphics.h> in the .cpp file.
- platform/graphics/cg/ImageBufferBackingStoreCache.cpp:
- platform/graphics/cg/ImageBufferBackingStoreCache.h:
- 8:58 AM Changeset in webkit [161765] by
-
- 4 edits in trunk/Source/WebCore
Fix DOM headers: TARGET_OS_EMBEDDED -> TARGET_OS_IPHONE
and a drive-by cleanup of DOMUIKitExtensions.mm #includes.
- bindings/objc/DOMPrivate.h:
- bindings/objc/DOMUIKitExtensions.h:
- bindings/objc/DOMUIKitExtensions.mm:
- 8:29 AM Changeset in webkit [161764] by
-
- 2 edits in trunk/Source/WebCore
Fix use of GL_HALF_FLOAT_ARB on iOS.
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::texSubImage2D):
- 8:29 AM Changeset in webkit [161763] by
-
- 2 edits in trunk/Source/WebCore
Fix build of SourceBufferPrivateAVFObjC.mm on iOS.
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
- 8:29 AM Changeset in webkit [161762] by
-
- 2 edits in trunk/Source/WebCore
Fix use of nonexistent kCGColorSpaceSRGB on iOS.
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::sRGBColorSpaceRef):
- 7:51 AM Changeset in webkit [161761] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: Some ScriptDebugServer Cleanup
https://bugs.webkit.org/show_bug.cgi?id=126793
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-11
Reviewed by Timothy Hatcher.
- bindings/js/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::didContinue):
(WebCore::PageScriptDebugServer::runEventLoopWhilePaused):
Move the special iOS WebThread EventLoop nesting handling here.
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::handlePause):
- bindings/js/ScriptDebugServer.h:
- inspector/InspectorDebuggerAgent.cpp:
- inspector/InspectorDebuggerAgent.h:
Remove unused headers and functions.
- 6:17 AM Changeset in webkit [161760] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Add USE(IOSURFACE_CANVAS_BACKING_STORE) to fix build
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::ImageBuffer): The 'width' and 'height'
variables are only used by code protected by
USE(IOSURFACE_CANVAS_BACKING_STORE).
- 5:02 AM Changeset in webkit [161759] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Multisampling is not available on iOS
- platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- 12:52 AM Changeset in webkit [161758] by
-
- 23 edits in trunk/Source/WebKit2
[EFL][WK2] Use nullptr instead of 0 in EFL API layer
https://bugs.webkit.org/show_bug.cgi?id=126806
Reviewed by Anders Carlsson.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::create):
- UIProcess/API/efl/ewk_auth_request.cpp:
(ewk_auth_request_suggested_username_get):
(ewk_auth_request_realm_get):
(ewk_auth_request_host_get):
- UIProcess/API/efl/ewk_back_forward_list.cpp:
(ewk_back_forward_list_current_item_get):
(ewk_back_forward_list_previous_item_get):
(ewk_back_forward_list_next_item_get):
(ewk_back_forward_list_item_at_index_get):
(ewk_back_forward_list_n_back_items_copy):
(ewk_back_forward_list_n_forward_items_copy):
- UIProcess/API/efl/ewk_back_forward_list_item.cpp:
(ewk_back_forward_list_item_url_get):
(ewk_back_forward_list_item_title_get):
(ewk_back_forward_list_item_original_url_get):
- UIProcess/API/efl/ewk_context.cpp:
(ewk_context_cookie_manager_get):
(ewk_context_database_manager_get):
(ewk_context_favicon_database_get):
(ewk_context_storage_manager_get):
(ewk_context_new_with_injected_bundle_path):
- UIProcess/API/efl/ewk_context_menu.cpp:
(ewk_context_menu_items_get):
- UIProcess/API/efl/ewk_context_menu_item.cpp:
(ewk_context_menu_item_new_with_submenu):
(ewk_context_menu_item_title_get):
(ewk_context_menu_item_parent_menu_get):
(ewk_context_menu_item_submenu_get):
- UIProcess/API/efl/ewk_download_job.cpp:
(ewk_download_job_request_get):
(ewk_download_job_response_get):
(ewk_download_job_destination_get):
(ewk_download_job_suggested_filename_get):
- UIProcess/API/efl/ewk_error.cpp:
(ewk_error_url_get):
(ewk_error_description_get):
- UIProcess/API/efl/ewk_file_chooser_request.cpp:
(ewk_file_chooser_request_accepted_mimetypes_get):
- UIProcess/API/efl/ewk_form_submission_request.cpp:
(ewk_form_submission_request_field_names_get):
(ewk_form_submission_request_field_value_get):
- UIProcess/API/efl/ewk_navigation_data.cpp:
(ewk_navigation_data_title_get):
(ewk_navigation_data_original_request_get):
(ewk_navigation_data_url_get):
- UIProcess/API/efl/ewk_navigation_policy_decision.cpp:
(ewk_navigation_policy_frame_name_get):
(ewk_navigation_policy_request_get):
- UIProcess/API/efl/ewk_object.cpp:
(ewk_object_ref):
- UIProcess/API/efl/ewk_popup_menu.cpp:
(ewk_popup_menu_items_get):
- UIProcess/API/efl/ewk_popup_menu_item.cpp:
(ewk_popup_menu_item_text_get):
(ewk_popup_menu_item_tooltip_get):
(ewk_popup_menu_item_accessibility_text_get):
- UIProcess/API/efl/ewk_security_origin.cpp:
(ewk_security_origin_host_get):
(ewk_security_origin_protocol_get):
- UIProcess/API/efl/ewk_settings.cpp:
(ewk_settings_default_text_encoding_name_get):
- UIProcess/API/efl/ewk_url_request.cpp:
(ewk_url_request_url_get):
(ewk_request_cookies_first_party_get):
(ewk_url_request_http_method_get):
- UIProcess/API/efl/ewk_url_response.cpp:
(ewk_url_response_url_get):
(ewk_url_response_mime_type_get):
- UIProcess/API/efl/ewk_url_scheme_request.cpp:
(ewk_url_scheme_request_scheme_get):
(ewk_url_scheme_request_url_get):
(ewk_url_scheme_request_path_get):
- UIProcess/API/efl/ewk_view.cpp:
(toEwkViewChecked):
(EWKViewGetWKView):
(ewk_view_smart_add):
(ewk_view_add_with_context):
(ewk_view_context_get):
(ewk_view_page_group_get):
(ewk_view_url_get):
(ewk_view_favicon_get):
(ewk_view_settings_get):
(ewk_view_title_get):
(ewk_view_theme_get):
(ewk_view_back_forward_list_get):
(ewk_view_custom_encoding_get):
(ewk_view_user_agent_get):
- 12:34 AM Changeset in webkit [161757] by
-
- 5 edits in tags/Safari-538.10.3/Source
Versioning.
- 12:31 AM Changeset in webkit [161756] by
-
- 1 copy in tags/Safari-538.10.3
New tag.
- 12:11 AM Changeset in webkit [161755] by
-
- 2 edits in trunk/Source/WebKit/efl
Build fix.
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::progressStarted):
