⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 18, 2014:

10:53 PM Changeset in webkit [162290] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Rename GestureEventIOS.{cpp,h} to GestureEvent.{cpp,h} to fix the build

InFilesCompiler.pm assumes that <interface name>.h exists for each
interface it processes. We renamed GestureEvent.h to GestureEventIOS.h
but kept the interface named GestureEvent, so a non-existant file was
being referenced by InFilesCompiler.pm (this was hard to detect since
GestureEvent.h still existed in the SDK due to not having submitted
WebKitAdditions recently).

Since we cannot rename the GestureEvent interface, and since there is
no conflicting GestureEvent in open source, we can just rename
GestureEventIOS.{cpp,h} back to GestureEvent.{cpp,h}.

  • dom/ios/TouchEvents.cpp: Updated to include GestureEvent.cpp.
10:47 PM Changeset in webkit [162289] by ap@apple.com
  • 2 edits in trunk/Tools

Add robots.txt to http://webkit-queues.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=127240

  • QueueStatusServer/app.yaml: Added required "upload" attribute for robots.txt.
10:43 PM Changeset in webkit [162288] by ap@apple.com
  • 2 edits
    1 add in trunk/Tools

Add robots.txt to http://webkit-queues.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=127240

Reviewed by Ryosuke Niwa.

  • QueueStatusServer/app.yaml: Added robots.txt as a static file. Updated version.
  • QueueStatusServer/robots.txt: Added.
10:39 PM Changeset in webkit [162287] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Memory leak in JSSubtleCrypto::wrapKey
https://bugs.webkit.org/show_bug.cgi?id=127241

Reviewed by Sam Weinig.

  • bindings/js/JSSubtleCryptoCustom.cpp: (WebCore::JSSubtleCrypto::wrapKey):

Delete algorithmPtr and parametersPtr that aren't smart pointers because of lambdas.

9:16 PM Changeset in webkit [162286] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the iOS Production build.

  • Configurations/WebCore.xcconfig:
6:32 PM Changeset in webkit [162285] by Alan Bujtas
  • 48 edits in trunk/LayoutTests

Unreviewed Apple Windows port gardering.

Add missing newlines.

  • platform/win/css1/box_properties/margin_right-expected.txt:
  • platform/win/css1/box_properties/padding-expected.txt:
  • platform/win/css1/box_properties/padding_left-expected.txt:
  • platform/win/css1/box_properties/padding_right-expected.txt:
  • platform/win/css1/box_properties/padding_top-expected.txt:
  • platform/win/css1/font_properties/font-expected.txt:
  • platform/win/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/win/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
  • platform/win/css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt:
  • platform/win/css2.1/t0804-c5509-padn-l-00-b-ag-expected.txt:
  • platform/win/css2.1/t0804-c5510-padn-00-b-ag-expected.txt:
  • platform/win/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
  • platform/win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
  • platform/win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
  • platform/win/fast/borders/bidi-012-expected.txt:
  • platform/win/fast/css/empty-pseudo-class-expected.txt:
  • platform/win/fast/css/fieldset-display-row-expected.txt:
  • platform/win/fast/css/first-child-pseudo-class-expected.txt:
  • platform/win/fast/css/last-child-pseudo-class-expected.txt:
  • platform/win/fast/css/only-child-pseudo-class-expected.txt:
  • platform/win/fast/forms/file/file-input-disabled-expected.txt:
  • platform/win/fast/inline/inline-box-background-expected.txt:
  • platform/win/fast/inline/inline-box-background-long-image-expected.txt:
  • platform/win/fast/inline/inline-box-background-repeat-x-expected.txt:
  • platform/win/fast/inline/inline-box-background-repeat-y-expected.txt:
  • platform/win/fast/lists/003-vertical-expected.txt:
  • platform/win/fast/multicol/vertical-rl/float-multicol-expected.txt:
  • platform/win/fast/multicol/vertical-rl/nested-columns-expected.txt:
  • platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
  • platform/win/svg/batik/filters/feTile-expected.txt:
  • platform/win/svg/batik/masking/maskRegions-expected.txt:
  • platform/win/svg/batik/paints/gradientLimit-expected.txt:
  • platform/win/svg/batik/text/textDecoration-expected.txt:
  • platform/win/svg/batik/text/textEffect-expected.txt:
  • platform/win/svg/batik/text/textLength-expected.txt:
  • platform/win/svg/batik/text/textPosition-expected.txt:
  • platform/win/svg/batik/text/verticalText-expected.txt:
  • platform/win/transforms/2d/hindi-rotated-expected.txt:
5:11 PM Changeset in webkit [162284] by akling@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

CodeBlock: Size m_callLinkInfos and m_byValInfos to fit earlier.
<https://webkit.org/b/127239>

Reviewed by Anders Carlsson.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::setNumberOfByValInfos):
(JSC::CodeBlock::setNumberOfCallLinkInfos):

Use resizeToFit() instead of grow() for these vectors, since
we know the final size here.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::shrinkToFit):

No need to shrink here anymore. We were not even shrinking
m_byValInfo before!

3:59 PM Changeset in webkit [162283] by berto@igalia.com
  • 2 edits in trunk/Tools

Tools/Scripts/test-webkitperl fails: 'tempdir' can't be called as a method
https://bugs.webkit.org/show_bug.cgi?id=127217

Reviewed by Daniel Bates.

The syntax File::Temp->tempdir() was explicitly made invalid
following <https://github.com/Perl-Toolchain-Gang/File-Temp/commit/c8920b2161ab6900a09e02b9410e0e4c3d74f565>
which was included in File::Temp v2.30, shipped with Perl v5.18.0.

Use File::Temp::tempdir() instead.

  • Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3:55 PM Changeset in webkit [162282] by Alan Bujtas
  • 27 edits
    26 adds in trunk/LayoutTests

Unreviewed Apple Windows port gardering.

Rebaseline subpixel layout results.

  • platform/win/TestExpectations:
  • platform/win/css1/box_properties/margin_right-expected.txt: Added.
  • platform/win/css1/box_properties/padding-expected.txt: Added.
  • platform/win/css1/box_properties/padding_left-expected.txt: Added.
  • platform/win/css1/box_properties/padding_right-expected.txt: Added.
  • platform/win/css1/box_properties/padding_top-expected.txt: Added.
  • platform/win/css1/font_properties/font-expected.txt:
  • platform/win/css1/formatting_model/vertical_formatting-expected.txt: Added.
  • platform/win/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt: Added.
  • platform/win/css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt: Added.
  • platform/win/css2.1/t0804-c5509-padn-l-00-b-ag-expected.txt: Added.
  • platform/win/css2.1/t0804-c5510-padn-00-b-ag-expected.txt: Added.
  • platform/win/css2.1/t0905-c414-flt-wrap-00-e-expected.txt: Added.
  • platform/win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
  • platform/win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
  • platform/win/fast/borders/bidi-012-expected.txt:
  • platform/win/fast/css/empty-pseudo-class-expected.txt: Added.
  • platform/win/fast/css/fieldset-display-row-expected.txt: Added.
  • platform/win/fast/css/first-child-pseudo-class-expected.txt: Added.
  • platform/win/fast/css/last-child-pseudo-class-expected.txt: Added.
  • platform/win/fast/css/only-child-pseudo-class-expected.txt: Added.
  • platform/win/fast/forms/file/file-input-disabled-expected.txt:
  • platform/win/fast/forms/range/slider-mouse-events-expected.txt:
  • platform/win/fast/inline/inline-box-background-expected.txt:
  • platform/win/fast/inline/inline-box-background-long-image-expected.txt:
  • platform/win/fast/inline/inline-box-background-repeat-x-expected.txt:
  • platform/win/fast/inline/inline-box-background-repeat-y-expected.txt:
  • platform/win/fast/lists/003-vertical-expected.txt:
  • platform/win/fast/multicol/vertical-rl/float-multicol-expected.txt:
  • platform/win/fast/multicol/vertical-rl/nested-columns-expected.txt:
  • platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
  • platform/win/svg/batik/filters/feTile-expected.txt: Added.
  • platform/win/svg/batik/masking/maskRegions-expected.txt: Added.
  • platform/win/svg/batik/paints/gradientLimit-expected.txt:
  • platform/win/svg/batik/text/textDecoration-expected.txt: Added.
  • platform/win/svg/batik/text/textEffect-expected.txt: Added.
  • platform/win/svg/batik/text/textLength-expected.txt: Added.
  • platform/win/svg/batik/text/textPosition-expected.txt: Added.
  • platform/win/svg/batik/text/verticalText-expected.txt: Added.
  • platform/win/transforms/2d/hindi-rotated-expected.txt:
3:35 PM Changeset in webkit [162281] by akling@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

CodeBlock: Size m_function{Exprs,Decls} to fit from creation.
<https://webkit.org/b/127238>

Reviewed by Anders Carlsson.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

Use resizeToFit() instead of grow() for m_functionExprs and
m_functionDecls since we know they will never change size.

(JSC::CodeBlock::shrinkToFit):

No need to shrink them here anymore.

3:31 PM Changeset in webkit [162280] by berto@igalia.com
  • 19 edits in trunk/Source/WebCore

[CodeGeneratorJS] Sort output of StructureFlags and function parameters

https://bugs.webkit.org/show_bug.cgi?id=127226

Reviewed by Alexey Proskuryakov.

The order of the keys in a hash is undefined and subject to change
between different Perl versions, so we have to sort them to make
sure that the output is always the same.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateParametersCheckExpression):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.h:
  • bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
  • bindings/scripts/test/JS/JSTestEventConstructor.h:
  • bindings/scripts/test/JS/JSTestEventTarget.h:
  • bindings/scripts/test/JS/JSTestException.h:
  • bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
  • bindings/scripts/test/JS/JSTestNamedConstructor.h:
  • bindings/scripts/test/JS/JSTestNode.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionOverloadedMethod):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/JS/JSTestTypedefs.h:
  • bindings/scripts/test/JS/JSattribute.h:
  • bindings/scripts/test/JS/JSreadonly.h:
3:20 PM Changeset in webkit [162279] by akling@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Remove unused CodeBlock::m_additionalIdentifiers member.
<https://webkit.org/b/127237>

Reviewed by Anders Carlsson.

  • bytecode/CodeBlock.h:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::shrinkToFit):

Remove m_additionalIdentifiers, nothing uses it.

3:10 PM Changeset in webkit [162278] by akling@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Remove two unused CodeBlock functions.
<https://webkit.org/b/127235>

Kill copyPostParseDataFrom() and copyPostParseDataFromAlternative()
since they are not used.

Reviewed by Anders Carlsson.

  • bytecode/CodeBlock.cpp:
  • bytecode/CodeBlock.h:
3:09 PM Changeset in webkit [162277] by akling@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

CodeBlock: Size m_exceptionHandlers to fit from creation.
<https://webkit.org/b/127234>

Avoid allocation churn for CodeBlock::m_exceptionHandlers.

Reviewed by Anders Carlsson.

  • bytecode/CodeBlock.h:

Removed unused CodeBlock::allocateHandlers() function.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

Use resizeToFit() instead of grow() for m_exceptionHandlers
since we know it's never going to change size.

(JSC::CodeBlock::shrinkToFit):

No need to shrink m_exceptionHandlers here since it's already
the perfect size.

3:00 PM Changeset in webkit [162276] by andersca@apple.com
  • 15 edits in trunk/Source

Replace a couple of uses of WTF::Function with std::function
https://bugs.webkit.org/show_bug.cgi?id=127218

Reviewed by Andreas Kling.

Source/WebCore:

  • WebCore.exp.in:
  • page/scrolling/ScrollingThread.cpp:

(WebCore::ScrollingThread::dispatch):
(WebCore::ScrollingThread::dispatchBarrier):
(WebCore::ScrollingThread::shared):
(WebCore::ScrollingThread::createThreadIfNeeded):
(WebCore::ScrollingThread::dispatchFunctionsFromScrollingThread):

  • page/scrolling/ScrollingThread.h:
  • page/scrolling/mac/ScrollingThreadMac.mm:

(WebCore::ScrollingThread::initializeRunLoop):

Source/WebKit2:

  • Platform/IPC/mac/ConnectionMac.cpp:

(IPC::createDataAvailableSource):

  • Platform/WorkQueue.h:
  • Platform/mac/WorkQueueMac.cpp:

(WorkQueue::dispatch):
(WorkQueue::dispatchAfter):

  • Shared/ChildProcess.cpp:

(WebKit::didCloseOnConnectionWorkQueue):

  • UIProcess/Storage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::scheduleDatabaseUpdate):

  • WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::dispatchAfterEnsuringUpdatedScrollPosition):

  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::dispatchAfterEnsuringUpdatedScrollPosition):

2:48 PM Changeset in webkit [162275] by andersca@apple.com
  • 25 edits in trunk/Source/WebCore

Modernize HTML parser code
https://bugs.webkit.org/show_bug.cgi?id=127236

Reviewed by Andreas Kling.

  • html/parser/AtomicHTMLToken.h:
  • html/parser/CSSPreloadScanner.cpp:

(WebCore::CSSPreloadScanner::emitRule):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::detach):
(WebCore::HTMLDocumentParser::stopParsing):
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):

  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLElementStack::ElementRecord::ElementRecord):
(WebCore::HTMLElementStack::insertAbove):
(WebCore::HTMLElementStack::pushCommon):

  • html/parser/HTMLElementStack.h:

(WebCore::HTMLElementStack::ElementRecord::releaseNext):
(WebCore::HTMLElementStack::ElementRecord::setNext):

  • html/parser/HTMLMetaCharsetParser.cpp:

(WebCore::HTMLMetaCharsetParser::HTMLMetaCharsetParser):

  • html/parser/HTMLMetaCharsetParser.h:
  • html/parser/HTMLParserScheduler.h:
  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):
(WebCore::TokenPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::HTMLPreloadScanner):

  • html/parser/HTMLPreloadScanner.h:
  • html/parser/HTMLResourcePreloader.cpp:

(WebCore::HTMLResourcePreloader::takeAndPreload):
(WebCore::HTMLResourcePreloader::preload):

  • html/parser/HTMLResourcePreloader.h:

(WebCore::PreloadRequest::PreloadRequest):

  • html/parser/HTMLScriptRunner.h:
  • html/parser/HTMLToken.h:

(WebCore::HTMLToken::beginDOCTYPE):
(WebCore::HTMLToken::releaseDoctypeData):

  • html/parser/HTMLTokenizer.h:
  • html/parser/HTMLTreeBuilder.h:
  • html/parser/HTMLViewSourceParser.cpp:

(WebCore::HTMLViewSourceParser::HTMLViewSourceParser):

  • html/parser/HTMLViewSourceParser.h:
  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):

  • html/parser/XSSAuditor.h:
  • html/parser/XSSAuditorDelegate.h:

(WebCore::XSSInfo::XSSInfo):

  • loader/TextResourceDecoder.cpp:

(WebCore::TextResourceDecoder::checkForHeadCharset):
(WebCore::TextResourceDecoder::checkForMetaCharset):

  • loader/TextResourceDecoder.h:
2:17 PM Changeset in webkit [162274] by benjamin@webkit.org
  • 8 edits in trunk/Source/WebCore

Make ElementData JIT friendly
https://bugs.webkit.org/show_bug.cgi?id=127209

Reviewed by Geoffrey Garen.

The offsets of ElementData's flags were not accessible by the JIT. This patch
refactor ElementData to use explicit flags so that they can be used from
the code generators.

  • dom/Element.cpp:

(WebCore::Element::synchronizeAllAttributes):
(WebCore::Element::synchronizeAttribute):
(WebCore::Element::attributeChanged):
(WebCore::Element::removeAttribute):

  • dom/ElementData.cpp:

(WebCore::ElementData::destroy):
(WebCore::ElementData::ElementData):
(WebCore::ShareableElementData::ShareableElementData):
(WebCore::ShareableElementData::~ShareableElementData):
(WebCore::ElementData::arraySizeAndFlagsFromOther):

  • dom/ElementData.h:

(WebCore::ElementData::hasName):
(WebCore::ElementData::isUnique):
(WebCore::ElementData::updateFlag):
(WebCore::ElementData::arraySize):
(WebCore::ElementData::setHasNameAttribute):
(WebCore::ElementData::styleAttributeIsDirty):
(WebCore::ElementData::setStyleAttributeIsDirty):
(WebCore::ElementData::presentationAttributeStyleIsDirty):
(WebCore::ElementData::setPresentationAttributeStyleIsDirty):
(WebCore::ElementData::animatedSVGAttributesAreDirty):
(WebCore::ElementData::setAnimatedSVGAttributesAreDirty):
(WebCore::ElementData::length):
(WebCore::ElementData::attributeBase):
(WebCore::ElementData::presentationAttributeStyle):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::synchronizeStyleAttributeInternal):
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::styleAttributeChanged):
(WebCore::StyledElement::inlineStyleChanged):
(WebCore::StyledElement::rebuildPresentationAttributeStyle):

  • dom/StyledElement.h:

(WebCore::StyledElement::invalidateStyleAttribute):
(WebCore::StyledElement::presentationAttributeStyle):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::synchronizeAnimatedSVGAttribute):

  • svg/SVGElement.h:

(WebCore::SVGElement::invalidateSVGAttributes):

1:24 PM Changeset in webkit [162273] by Alan Bujtas
  • 4 edits in trunk

Subpixel layout: IntRect::infiniteRect() overflows when subpixel layout is enabled.
https://bugs.webkit.org/show_bug.cgi?id=126899

Reviewed by Tim Horton.

Use LayoutUnits when setting the infinite values on IntRect::infiniteRect() to ensure
it won't overflow later when the IntRect gets converted to LayoutRect.

Source/WebCore:

Covered by existing tests.

  • platform/graphics/IntRect.h:

(WebCore::IntRect::infiniteRect):

LayoutTests:

  • platform/mac/TestExpectations: Unskipping svg test (failed with subpixel on)
1:15 PM Changeset in webkit [162272] by andersca@apple.com
  • 7 edits
    37 deletes in trunk

Remove support for the viewsource attribute
https://bugs.webkit.org/show_bug.cgi?id=127232

Reviewed by Andreas Kling.

Source/WebCore:

The 'viewsource' attribute on frames is nonstandard, not used by anyone (the inspector has
its own syntax highlighting) and not audited.

This patch removes parsing of the viewsource attribute and the associated tests. A subsequent
patch will remove the code as well.

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::parseAttribute):

Source/WTF:

  • wtf/FeatureDefines.h:

LayoutTests:

  • .gitattributes:
  • fast/frames/resources/viewsource-fake-image-file.png: Removed.
  • fast/frames/resources/viewsource-frame-1.html: Removed.
  • fast/frames/resources/viewsource-frame-2.html: Removed.
  • fast/frames/resources/viewsource-frame-3.html: Removed.
  • fast/frames/resources/viewsource-frame-4.html: Removed.
  • fast/frames/resources/viewsource-frame-5.html: Removed.
  • fast/frames/resources/viewsource-frame-unfinished-script.html: Removed.
  • fast/frames/resources/viewsource-frame-unfinished-textarea.html: Removed.
  • fast/frames/viewsource-attribute.html: Removed.
  • fast/frames/viewsource-empty-attribute-value-expected.txt: Removed.
  • fast/frames/viewsource-empty-attribute-value.html: Removed.
  • fast/frames/viewsource-linebreak-expected.txt: Removed.
  • fast/frames/viewsource-linebreak.html: Removed.
  • fast/frames/viewsource-link-on-href-value-expected.txt: Removed.
  • fast/frames/viewsource-link-on-href-value.html: Removed.
  • fast/frames/viewsource-on-image-file.html: Removed.
  • fast/frames/viewsource-plain-text-tags-expected.txt: Removed.
  • fast/frames/viewsource-plain-text-tags.html: Removed.
  • fast/frames/viewsource-unfinished-tags-expected.txt: Removed.
  • fast/frames/viewsource-unfinished-tags.html: Removed.
  • fast/frames/viewsource-xml-expected.txt: Removed.
  • fast/frames/viewsource-xml.html: Removed.
  • http/tests/security/resources/view-source-no-refresh.php: Removed.
  • http/tests/security/view-source-javascript-url-in-document-expected.txt: Removed.
  • http/tests/security/view-source-javascript-url-in-document.html: Removed.
  • http/tests/security/view-source-no-javascript-url-expected.txt: Removed.
  • http/tests/security/view-source-no-javascript-url.html: Removed.
  • http/tests/security/view-source-no-refresh-expected.txt: Removed.
  • http/tests/security/view-source-no-refresh.html: Removed.
  • platform/efl/fast/frames/viewsource-attribute-expected.png: Removed.
  • platform/efl/fast/frames/viewsource-attribute-expected.txt: Removed.
  • platform/efl/fast/frames/viewsource-on-image-file-expected.png: Removed.
  • platform/efl/fast/frames/viewsource-on-image-file-expected.txt: Removed.
  • platform/mac/fast/frames/viewsource-attribute-expected.png: Removed.
  • platform/mac/fast/frames/viewsource-attribute-expected.txt: Removed.
  • platform/mac/fast/frames/viewsource-on-image-file-expected.png: Removed.
  • platform/mac/fast/frames/viewsource-on-image-file-expected.txt: Removed.
  • platform/win/TestExpectations:
1:14 PM Changeset in webkit [162271] by commit-queue@webkit.org
  • 31 edits
    2 copies in trunk/Source/WebKit2

Flesh out session APIs (still not enabled at API level).
https://bugs.webkit.org/show_bug.cgi?id=126918

Patch by Martin Hock <mhock@apple.com> on 2014-01-18
Reviewed by Alexey Proskuryakov.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::storageSession):
(WebKit::NetworkConnectionToWebProcess::startDownload):
(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
(WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
(WebKit::NetworkConnectionToWebProcess::cookiesEnabled):
(WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue):
(WebKit::NetworkConnectionToWebProcess::getRawCookies):
(WebKit::NetworkConnectionToWebProcess::deleteCookie):

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:
  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::ensurePrivateBrowsingSession):
(WebKit::NetworkProcess::destroyPrivateBrowsingSession):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/RemoteNetworkingContext.h:
  • NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::storageSession):
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):

  • NetworkProcess/soup/RemoteNetworkingContextSoup.cpp:

(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):

  • Shared/SessionTracker.cpp: Copied from Source/WebKit2/UIProcess/APISession.cpp.

(WebKit::sessionMap):
(WebKit::identifierBase):
(WebKit::SessionTracker::getSessionMap):
(WebKit::SessionTracker::getIdentifierBase):
(WebKit::SessionTracker::session):
(WebKit::SessionTracker::destroySession):
(WebKit::SessionTracker::setIdentifierBase):

  • Shared/SessionTracker.h: Copied from Source/WebKit2/UIProcess/APISession.h.

(WebKit::SessionTracker::isEphemeralID):

  • Shared/mac/CookieStorageShim.cpp:

(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL):

  • UIProcess/APISession.cpp:

(API::generateID):
(API::Session::defaultSession):
(API::Session::legacyPrivateSession):
(API::Session::Session):
(API::Session::create):
(API::Session::isEphemeral):
(API::Session::getID):

  • UIProcess/APISession.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::setAnyPageGroupMightHavePrivateBrowsingEnabled):
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::createWebPage):

  • UIProcess/WebContext.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::sessionID):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createWebPage):

  • UIProcess/WebProcessProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setPrivateBrowsingEnabled):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::legacySessionID):
(WebKit::WebPlatformStrategies::cookiesForDOM):
(WebKit::WebPlatformStrategies::setCookiesFromDOM):
(WebKit::WebPlatformStrategies::cookiesEnabled):
(WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue):
(WebKit::WebPlatformStrategies::getRawCookies):
(WebKit::WebPlatformStrategies::deleteCookie):

  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
(WebKit::WebFrameNetworkingContext::storageSession):

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:

(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::storageSession):

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::ensurePrivateBrowsingSession):
(WebKit::WebProcess::destroyPrivateBrowsingSession):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
1:11 PM Changeset in webkit [162270] by mark.lam@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Add a hasBreakpointFlag arg to the op_debug bytecode.
https://bugs.webkit.org/show_bug.cgi?id=127230.

Reviewed by Geoffrey Garen.

This is in anticipation of upcoming changes to support bytecode level
breakpoints. This patch adds the flag to the op_debug bytecode and
initializes it, but does not use it yet.

  • bytecode/Opcode.h:

(JSC::padOpcodeName):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitDebugHook):

  • llint/LowLevelInterpreter.asm:
12:35 PM Changeset in webkit [162269] by andersca@apple.com
  • 6 edits in trunk/Source/WebCore

XMLTreeViewer shouldn't use the view source mode
https://bugs.webkit.org/show_bug.cgi?id=127229

Reviewed by Andreas Kling.

Add the relevant styles from view-source.css to XMLViewer.css.

  • xml/XMLTreeViewer.cpp:

(WebCore::XMLTreeViewer::transformDocumentToTreeView):

  • xml/XMLViewer.css:

(body):
(.comment):
(.tag):
(.attribute-name):
(.attribute-value):

  • xml/XMLViewer.js:

(createComment):
(createTag):
(createAttribute):

12:32 PM Changeset in webkit [162268] by BJ Burg
  • 5 edits in trunk/Source/WebKit

Another build fix attempt for Windows and EFL WebKit1.

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/efl:

  • ewk/ewk_paint_context.cpp:

(ewk_paint_context_paint_contents):

  • ewk/ewk_view.cpp:

(_ewk_view_smart_repaints_process):

12:19 PM Changeset in webkit [162267] by BJ Burg
  • 2 edits in trunk/Source/WebKit

Unreviewed build fix attempt for Windows.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
11:41 AM Changeset in webkit [162266] by berto@igalia.com
  • 3 edits in trunk/Source/JavaScriptCore

JavaScriptCore uses PLATFORM(MAC) when it means OS(DARWIN)
https://bugs.webkit.org/show_bug.cgi?id=99683

Reviewed by Anders Carlsson.

  • jit/ThunkGenerators.cpp:
  • tools/CodeProfile.cpp:

(JSC::symbolName):
(JSC::CodeProfile::sample):

11:16 AM Changeset in webkit [162265] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Remove unused "touchDragDropEnabled" setting.
<https://webkit.org/b/127227>

Reviewed by Sam Weinig.

  • page/Settings.in:
11:15 AM Changeset in webkit [162264] by BJ Burg
  • 44 edits in trunk/Source

Web Inspector: Page should use std::unique_ptr for InspectorController
https://bugs.webkit.org/show_bug.cgi?id=127068

Reviewed by Joseph Pecoraro.

Source/WebCore:

Make Page and WorkerGlobalScope keep a std::unique_ptr to InspectorController
and WorkerInspectorController. Store page references and return controller
references where possible.

Convert call sites to use an InspectorController reference.
Convert instantiations of InspectorFrontendClient to use std::unique_ptr.
Convert InspectorOverlay to keep Page references.

  • WebCore.exp.in:
  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::supportsProfiling):
(WebCore::JSDOMWindowBase::supportsRichSourceInfo):

  • dom/Node.cpp:

(WebCore::Node::inspect):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
(WebCore::InspectorController::setInspectorFrontendClient):
(WebCore::InspectorController::hasInspectorFrontendClient):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::inspectedPage):
(WebCore::InspectorController::developerExtrasEnabled):

  • inspector/InspectorController.h:
  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::canAttachWindow):
(WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight):
(WebCore::InspectorFrontendClientLocal::changeAttachedWindowWidth):
(WebCore::InspectorFrontendClientLocal::openInNewTab):
(WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::InspectorOverlay):
(WebCore::InspectorOverlay::getHighlight):
(WebCore::InspectorOverlay::highlightQuad):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::buildObjectForHighlightedNode):
(WebCore::InspectorOverlay::drawQuadHighlight):
(WebCore::InspectorOverlay::overlayPage):
(WebCore::InspectorOverlay::reset):

  • inspector/InspectorOverlay.h:
  • inspector/InstrumentingAgents.cpp:

(WebCore::instrumentationForPage): remove null checks.
(WebCore::instrumentationForWorkerGlobalScope): remove null checks.

  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::connectFrontend):
(WebCore::WorkerInspectorController::disconnectFrontend):

  • inspector/WorkerInspectorController.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::showContextMenu):
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::addInspectElementItem):

  • page/FrameView.cpp:

(WebCore::FrameView::sendResizeEventIfNeeded):

  • page/Page.cpp:

(WebCore::Page::Page):

  • page/Page.h:

(WebCore::Page::inspectorController):

  • page/PageDebuggable.cpp:

(WebCore::PageDebuggable::hasLocalDebugger):
(WebCore::PageDebuggable::parentProcessIdentifier):
(WebCore::PageDebuggable::connect):
(WebCore::PageDebuggable::disconnect):
(WebCore::PageDebuggable::dispatchMessageFromRemoteFrontend):
(WebCore::PageDebuggable::setIndicating):

  • platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:

(WebCore::CompositingCoordinator::syncDisplayState):

  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::inspectorHighlightRects):
(WebCore::Internals::inspectorHighlightObject):
(WebCore::Internals::emitInspectorDidBeginFrame):
(WebCore::Internals::emitInspectorDidCancelFrame):
(WebCore::Internals::openDummyInspectorFrontend):
(WebCore::Internals::closeDummyInspectorFrontend):
(WebCore::Internals::setInspectorResourcesDataSizeLimits):
(WebCore::Internals::setJavaScriptProfilingEnabled):

  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::WorkerGlobalScope):

  • workers/WorkerGlobalScope.h: remove clearInspector().

(WebCore::WorkerGlobalScope::workerInspectorController):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::connectToWorkerGlobalScopeInspectorTask):
(WebCore::disconnectFromWorkerGlobalScopeInspectorTask):
(WebCore::dispatchOnInspectorBackendTask):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThreadShutdownFinishTask::performTask):

Source/WebKit/efl:

Convert call sites to use a InspectorController reference.
Convert instantiations of InspectorFrontendClient to use std::unique_ptr.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::evaluateInWebInspector):

  • WebCoreSupport/InspectorClientEfl.cpp:

(WebCore::InspectorClientEfl::openInspectorFrontend):

  • ewk/ewk_view.cpp:

(ewk_view_inspector_show):
(ewk_view_inspector_close):

Source/WebKit/gtk:

Convert call sites to use a InspectorController reference.
Convert instantiations of InspectorFrontendClient to use std::unique_ptr.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::paintWebView):

  • WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorClient::openInspectorFrontend):

  • webkit/webkitwebinspector.cpp:

(webkit_web_inspector_set_property):
(webkit_web_inspector_get_property):
(webkit_web_inspector_show):
(webkit_web_inspector_inspect_node):
(webkit_web_inspector_inspect_coordinates):
(webkit_web_inspector_close):
(webkit_web_inspector_execute_script):

Source/WebKit/mac:

Convert call sites to use a InspectorController reference.
Convert instantiations of InspectorFrontendClient to use std::unique_ptr.

  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::openInspectorFrontend):
(-[WebInspectorWindowController destroyInspectorView:]):

  • WebInspector/WebInspector.mm:

(-showWindow):
(-isJavaScriptProfilingEnabled):
(-setJavaScriptProfilingEnabled:):
(-close:):
(-evaluateInFrontend:callId:script:):

  • WebInspector/WebNodeHighlighter.mm:

(-[WebNodeHighlighter highlight]):

Source/WebKit/win:

Convert call sites to use a InspectorController reference.

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::openInspectorFrontend):
(WebInspectorFrontendClient::destroyInspectorView):
(WebInspectorFrontendClient::onClose):

(WebInspector::show):
(WebInspector::close):
(WebInspector::isJavaScriptProfilingEnabled):
(WebInspector::setJavaScriptProfilingEnabled):
(WebInspector::evaluateInFrontend):

  • WebNodeHighlight.cpp:

(WebNodeHighlight::update):

Source/WebKit2:

Convert call sites to use a InspectorController reference.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::drawRect):

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:

(WebKit::WebInspectorFrontendClient::WebInspectorFrontendClient):
(WebKit::WebInspectorFrontendClient::closeWindow):

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::createInspectorPage):
(WebKit::WebInspector::show):
(WebKit::WebInspector::close):
(WebKit::WebInspector::evaluateScriptForTest):
(WebKit::WebInspector::showConsole):
(WebKit::WebInspector::showResources):
(WebKit::WebInspector::showMainResourceForFrame):
(WebKit::WebInspector::startJavaScriptDebugging):
(WebKit::WebInspector::stopJavaScriptDebugging):
(WebKit::WebInspector::setJavaScriptProfilingEnabled):
(WebKit::WebInspector::startJavaScriptProfiling):
(WebKit::WebInspector::stopJavaScriptProfiling):
(WebKit::WebInspector::startPageProfiling):
(WebKit::WebInspector::stopPageProfiling):
(WebKit::WebInspector::dispatchMessageFromRemoteFrontend):
(WebKit::WebInspector::remoteFrontendConnected):
(WebKit::WebInspector::remoteFrontendDisconnected):

10:57 AM Changeset in webkit [162263] by ap@apple.com
  • 4 edits in trunk/Tools

build.webkit.org/dashboard should have image diff links in test results popovers
https://bugs.webkit.org/show_bug.cgi?id=127188

Reviewed by Timothy Hatcher.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:

(Buildbot.prototype.layoutTestImagesURLForIteration):
(Buildbot.prototype.layoutTestImageDiffURLForIteration):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(BuildbotIteration.prototype.loadLayoutTestResults):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

(BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoLink):
(BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoText):
(BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):

10:50 AM Changeset in webkit [162262] by ap@apple.com
  • 3 edits in trunk/LayoutTests

media/video-size.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=124932

  • platform/efl/TestExpectations:
  • platform/TestExpectations:

Moving flakiness expectation to cross-platform file, as it also fails on Mac in the same way.

10:43 AM Changeset in webkit [162261] by ap@apple.com
  • 2 edits in trunk/LayoutTests

media/video-display-aspect-ratio.html fails
https://bugs.webkit.org/show_bug.cgi?id=35297

  • platform/mac/TestExpectations: Marking as flaky.
10:42 AM Changeset in webkit [162260] by andersca@apple.com
  • 16 edits in trunk

Remove ENABLE_THREADED_HTML_PARSER defines everywhere
https://bugs.webkit.org/show_bug.cgi?id=127225

Reviewed by Andreas Kling.

This concludes the removal of over 8.8 million lines of threaded parser code.

.:

  • Source/autotools/SetupWebKitFeatures.m4:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
10:30 AM Changeset in webkit [162259] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk/Source/WebKit2

Make WKRenderingProgressEvents a shareable API.
https://bugs.webkit.org/show_bug.cgi?id=127213

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-01-18
Reviewed by Dan Bernstein.

Move WKRenderingProgressEvents from UIProcess to Shared, so that an inject bundle
could also use this enum when listening to layout milestones.

  • Shared/API/Cocoa/WKRenderingProgressEvents.h: Added.

(NS_OPTIONS):

  • Shared/API/Cocoa/WKRenderingProgressEventsInternal.h: Added.

(renderingProgressEvents):

  • UIProcess/API/Cocoa/WKBrowsingContextController.h: Move WKRenderingProgressEvents to Shared/API/Cocoa/WKRenderingProgressEvents.h.
  • UIProcess/API/Cocoa/WKBrowsingContextController.mm: Move renderingProgressEvents() to WKRenderingProgressEventsInternal.h.
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h: Add

webProcessPlugInBrowserContextController:renderingProgressDidChange: to load delegate.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(didLayout):
(setUpPageLoaderClient): Also listen to didLayout callback for layout milestones.

10:25 AM Changeset in webkit [162258] by andersca@apple.com
  • 11 edits in trunk/Source/WebCore

Remove the remaining threaded parser code
https://bugs.webkit.org/show_bug.cgi?id=127224

Reviewed by Andreas Kling.

  • dom/Document.cpp:

(WebCore::Document::decrementActiveParserCount):

  • html/parser/AtomicHTMLToken.h:
  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::detach):
(WebCore::HTMLDocumentParser::stopParsing):
(WebCore::HTMLDocumentParser::prepareToStopParsing):
(WebCore::HTMLDocumentParser::resumeParsingAfterYield):
(WebCore::HTMLDocumentParser::forcePlaintextForTextDocument):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::end):
(WebCore::HTMLDocumentParser::finish):
(WebCore::HTMLDocumentParser::textPosition):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):

  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLParserIdioms.cpp:
  • html/parser/HTMLParserIdioms.h:
  • html/parser/HTMLTokenizer.cpp:
  • html/parser/HTMLTokenizer.h:
  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::isLoading):
(WebCore::DocumentLoader::checkLoadComplete):

  • page/Settings.in:
10:06 AM Changeset in webkit [162257] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Remove threaded parser code from the preload scanners
https://bugs.webkit.org/show_bug.cgi?id=127222

Reviewed by Andreas Kling.

  • html/parser/CSSPreloadScanner.cpp:

(WebCore::CSSPreloadScanner::CSSPreloadScanner):
Use nullptr.

(WebCore::CSSPreloadScanner::scan):
Move scanCommon here and simplify the code.

  • html/parser/CSSPreloadScanner.h:

Remove scanCommon.

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::tagIdFor):
TagId is a strong enum now, update enum values.

(WebCore::TokenPreloadScanner::initiatorFor):
Ditto.

(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
Ditto.

(WebCore::TokenPreloadScanner::StartTagScanner::match):
Indent this.

(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
TagId is a strong enum now, update enum values.

(WebCore::TokenPreloadScanner::StartTagScanner::charset):
Ditto.

(WebCore::TokenPreloadScanner::StartTagScanner::resourceType):
Ditto.

(WebCore::TokenPreloadScanner::StartTagScanner::shouldPreload):
Ditto.

(WebCore::TokenPreloadScanner::scan):
Merge scan and scanCommon.

  • html/parser/HTMLPreloadScanner.h:
9:55 AM Changeset in webkit [162256] by mark.lam@apple.com
  • 9 edits
    1 add
    1 delete in trunk/Source/JavaScriptCore

Adding UnlinkedCodeBlock::opDebugBytecodeOffsetForLineAndColumn()..
https://bugs.webkit.org/show_bug.cgi?id=127127.

Reviewed by Geoffrey Garen.

In order to implement bytecode level breakpoints, we need a mechanism
for computing the best fit op_debug bytecode offset for any valid given
line and column value in the source. The "best fit" op_debug bytecode
in this case is defined below in the comment for
UnlinkedCodeBlock::opDebugBytecodeOffsetForLineAndColumn().

(JSC::CodeBlock::opDebugBytecodeOffsetForLineAndColumn):

  • Convert the line and column to unlinked line and column values and pass them to UnlinkedCodeBlock::opDebugBytecodeOffsetForLineAndColumn() to do the real work.
  • bytecode/CodeBlock.h:
  • bytecode/LineColumnInfo.h: Added.

(JSC::LineColumnInfo::operator <):
(JSC::LineColumnInfo::LineColumnPair::LineColumnPair):
(JSC::LineColumnInfo::operator ==):
(JSC::LineColumnInfo::operator !=):
(JSC::LineColumnInfo::operator <=):
(JSC::LineColumnInfo::operator >):
(JSC::LineColumnInfo::operator >=):

  • bytecode/LineInfo.h: Removed.
  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::decodeExpressionRangeLineAndColumn):

  • Factored this out of expressionRangeForBytecodeOffset() so that it can be called from multiple places.

(JSC::dumpLineColumnEntry):
(JSC::UnlinkedCodeBlock::dumpExpressionRangeInfo):
(JSC::UnlinkedCodeBlock::dumpOpDebugLineColumnInfoList):

  • Some dumpers for debugging use only.

(JSC::UnlinkedCodeBlock::expressionRangeForBytecodeOffset):
(JSC::UnlinkedCodeBlock::opDebugBytecodeOffsetForLineAndColumn):

  • Finds the earliest op_debug bytecode whose line and column matches the specified line and column values. If an exact match is not found, then finds the nearest op_debug bytecode that precedes the specified line and column values. If there are more than one op_debug at that preceding line and column value, then the earliest of those op_debug bytecodes will be be selected. The offset of the selected bytecode will be returned.

We want the earliest one because when we have multiple op_debug bytecodes
that map to a given line and column, a debugger user would expect to break
on the first one and step through the rest thereafter if needed.

(JSC::compareLineColumnInfo):
(JSC::UnlinkedCodeBlock::opDebugLineColumnInfoList):

  • Creates the sorted opDebugLineColumnInfoList on demand. This list is stored in the UnlinkedCodeBlock's rareData.
  • bytecode/UnlinkedCodeBlock.h:
9:19 AM Changeset in webkit [162255] by akling@apple.com
  • 2 edits
    10 deletes in trunk

Remove Nix files from WebCore
https://bugs.webkit.org/show_bug.cgi?id=127176

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2014-01-18
Reviewed by Anders Carlsson.

.:

  • Source/cmake/OptionsNix.cmake: Removed.

Source/WebCore:

  • PlatformNix.cmake: Removed.
  • css/mediaControlsNix.css: Removed.
  • css/mediaControlsNixFullscreen.css: Removed.
  • editing/nix/EditorNix.cpp: Removed.
  • page/nix/EventHandlerNix.cpp: Removed.
  • platform/audio/nix/AudioBusNix.cpp: Removed.
  • platform/audio/nix/AudioDestinationNix.cpp: Removed.
  • platform/audio/nix/AudioDestinationNix.h: Removed.
  • platform/audio/nix/FFTFrameNix.cpp: Removed.
  • platform/graphics/nix/IconNix.cpp: Removed.
  • platform/graphics/nix/ImageNix.cpp: Removed.
  • platform/nix/CursorNix.cpp: Removed.
  • platform/nix/DragDataNix.cpp: Removed.
  • platform/nix/DragImageNix.cpp: Removed.
  • platform/nix/ErrorsNix.cpp: Removed.
  • platform/nix/ErrorsNix.h: Removed.
  • platform/nix/FileSystemNix.cpp: Removed.
  • platform/nix/GamepadsNix.cpp: Removed.
  • platform/nix/LanguageNix.cpp: Removed.
  • platform/nix/LocalizedStringsNix.cpp: Removed.
  • platform/nix/MIMETypeRegistryNix.cpp: Removed.
  • platform/nix/NixKeyboardUtilities.cpp: Removed.
  • platform/nix/NixKeyboardUtilities.h: Removed.
  • platform/nix/PasteboardNix.cpp: Removed.
  • platform/nix/PlatformKeyboardEventNix.cpp: Removed.
  • platform/nix/PlatformScreenNix.cpp: Removed.
  • platform/nix/RenderThemeNix.cpp: Removed.
  • platform/nix/RenderThemeNix.h: Removed.
  • platform/nix/ScrollbarThemeNix.cpp: Removed.
  • platform/nix/ScrollbarThemeNix.h: Removed.
  • platform/nix/SharedTimerNix.cpp: Removed.
  • platform/nix/SoundNix.cpp: Removed.
  • platform/nix/TemporaryLinkStubs.cpp: Removed.
  • platform/nix/WidgetNix.cpp: Removed.
  • platform/nix/support/MultiChannelPCMData.cpp: Removed.
  • platform/text/nix/TextBreakIteratorInternalICUNix.cpp: Removed.
9:11 AM Changeset in webkit [162254] by andersca@apple.com
  • 9 edits in trunk/Source/WebCore

Remove DocumentParser::pinToMainThread() and related code
https://bugs.webkit.org/show_bug.cgi?id=127221

Reviewed by Andreas Kling.

  • dom/Document.cpp:

(WebCore::Document::setContent):

  • dom/DocumentParser.h:
  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::HTMLDocumentParser):

  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLParserOptions.cpp:

(WebCore::HTMLParserOptions::HTMLParserOptions):

  • html/parser/HTMLParserOptions.h:
  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processEndTag):

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::replaceDocument):

9:00 AM Changeset in webkit [162253] by andersca@apple.com
  • 7 edits
    2 deletes in trunk/Source/WebCore

Remove HTMLParserThread
https://bugs.webkit.org/show_bug.cgi?id=127220

Reviewed by Andreas Kling.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/HTMLDocumentParser.cpp:
  • html/parser/HTMLParserThread.cpp: Removed.
  • html/parser/HTMLParserThread.h: Removed.
8:50 AM Changeset in webkit [162252] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

GC soon after responding to fake memory pressure.
<https://webkit.org/b/127210>

Ask JSC to garbage collect "soon" after handling the fake memory
pressure signal on Mac. This seems to stabilize the post-pressure
numbers on Membuster3 a bit on my laptop. The difference is mostly
made up of JSC::CodeBlock objects.

Reviewed by Geoffrey Garen.

  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::install):

8:48 AM Changeset in webkit [162251] by andersca@apple.com
  • 11 edits
    10 deletes in trunk/Source/WebCore

Remove files only used by the threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=127219
<rdar://problem/13331277>

Reviewed by Andreas Kling.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/AtomicHTMLToken.h:
  • html/parser/BackgroundHTMLInputStream.cpp: Removed.
  • html/parser/BackgroundHTMLInputStream.h: Removed.
  • html/parser/BackgroundHTMLParser.cpp: Removed.
  • html/parser/BackgroundHTMLParser.h: Removed.
  • html/parser/CompactHTMLToken.cpp: Removed.
  • html/parser/CompactHTMLToken.h: Removed.
  • html/parser/HTMLDocumentParser.cpp:
  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLIdentifier.cpp: Removed.
  • html/parser/HTMLIdentifier.h: Removed.
  • html/parser/HTMLParserIdioms.h:
  • html/parser/HTMLPreloadScanner.h:
  • html/parser/HTMLTreeBuilderSimulator.cpp: Removed.
  • html/parser/HTMLTreeBuilderSimulator.h: Removed.
1:04 AM Changeset in webkit [162250] by zandobersek@gmail.com
  • 3 edits in trunk/Source/JavaScriptCore

Inspector scripts are not compatible with Python v3
https://bugs.webkit.org/show_bug.cgi?id=127128

Reviewed by Benjamin Poulain.

  • inspector/scripts/generate-combined-inspector-json.py: Turn print statements into print function calls.
  • inspector/scripts/jsmin.py: Try importing the StringIO class from the StringIO module (which will work for

Python v2) or, on import error, import the class from the io module (which will work for Python v3).

12:22 AM Changeset in webkit [162249] by zandobersek@gmail.com
  • 2 edits in trunk

[GTK] Bump the minimum required Clang version to 3.3
https://bugs.webkit.org/show_bug.cgi?id=127178

Reviewed by Martin Robinson.

  • Source/autotools/CheckSystemAndBasicDependencies.m4: Require Clang 3.3 or later when using the Clang compiler to

build the GTK port. Building with Clang 3.2 doesn't work anymore and there's no point in fixing that, as we should
support the latest two versions of Clang (3.3 and 3.4), just like we do with GCC (4.7 and 4.8).

Jan 17, 2014:

11:26 PM Changeset in webkit [162248] by mark.lam@apple.com
  • 2 edits in branches/jsCStack/Source/JavaScriptCore

Fix 32-bit C loop LLINT.
https://bugs.webkit.org/show_bug.cgi?id=127086.

Reviewed by Geoffrey Garen.

  • llint/LowLevelInterpreter32_64.asm:
10:54 PM Changeset in webkit [162247] by fpizlo@apple.com
  • 2 edits in branches/jsCStack/Tools

Unreviewed, run Mozilla tests with the FTL.

All of those tests pass. Because the FTL is now awesome.

  • Scripts/run-jsc-stress-tests:
10:32 PM Changeset in webkit [162246] by fpizlo@apple.com
  • 2 edits in branches/jsCStack/Source/JavaScriptCore

FTL mishandles (-2147483648 % 0) | 0
https://bugs.webkit.org/show_bug.cgi?id=127215

Not yet reviewed.

This fixes:

jsc-layout-tests.yaml/js/script-tests/dfg-mod-neg2tothe31-by-one-and-then-or-zero-with-interesting-reg-alloc.js.layout-ftl-eager-no-cjit


Now the FTL passes all JSC layout tests.

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileArithDivMod):

10:27 PM Changeset in webkit [162245] by commit-queue@webkit.org
  • 30 edits
    2 deletes in trunk/Source/WebKit2

Unreviewed, rolling out r162237 and r162241.
http://trac.webkit.org/changeset/162237
http://trac.webkit.org/changeset/162241
https://bugs.webkit.org/show_bug.cgi?id=127216

Broke lots of API tests (Requested by ap on #webkit).

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::storageSession):
(WebKit::NetworkConnectionToWebProcess::startDownload):
(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
(WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
(WebKit::NetworkConnectionToWebProcess::cookiesEnabled):
(WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue):
(WebKit::NetworkConnectionToWebProcess::getRawCookies):
(WebKit::NetworkConnectionToWebProcess::deleteCookie):

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:
  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::ensurePrivateBrowsingSession):
(WebKit::NetworkProcess::destroyPrivateBrowsingSession):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/RemoteNetworkingContext.h:
  • NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::privateBrowsingStorageSession):
(WebKit::RemoteNetworkingContext::storageSession):
(WebKit::RemoteNetworkingContext::privateBrowsingSession):
(WebKit::privateBrowsingStorageSessionIdentifierBase):
(WebKit::RemoteNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase):
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::RemoteNetworkingContext::destroyPrivateBrowsingSession):

  • NetworkProcess/soup/RemoteNetworkingContextSoup.cpp:

(WebKit::RemoteNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase):
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::RemoteNetworkingContext::destroyPrivateBrowsingSession):
(WebKit::RemoteNetworkingContext::privateBrowsingSession):

  • Shared/SessionTracker.cpp: Removed.
  • Shared/SessionTracker.h: Removed.
  • UIProcess/APISession.cpp:

(API::Session::Session):
(API::Session::create):
(API::Session::isEphemeral):

  • UIProcess/APISession.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::setAnyPageGroupMightHavePrivateBrowsingEnabled):
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::createWebPage):

  • UIProcess/WebContext.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createWebPage):

  • UIProcess/WebProcessProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setPrivateBrowsingEnabled):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::cookiesForDOM):
(WebKit::WebPlatformStrategies::setCookiesFromDOM):
(WebKit::WebPlatformStrategies::cookiesEnabled):
(WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue):
(WebKit::WebPlatformStrategies::getRawCookies):
(WebKit::WebPlatformStrategies::deleteCookie):

  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::privateSession):
(WebKit::identifierBase):
(WebKit::WebFrameNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase):
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::destroyPrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
(WebKit::WebFrameNetworkingContext::storageSession):

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:

(WebKit::privateSession):
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::destroyPrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::storageSession):

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::ensurePrivateBrowsingSession):
(WebKit::WebProcess::destroyPrivateBrowsingSession):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
9:48 PM Changeset in webkit [162244] by fpizlo@apple.com
  • 3 edits in branches/jsCStack/Source/JavaScriptCore

FTL should update machine virtual registers in runtime meta-data according to the captured stackmap
https://bugs.webkit.org/show_bug.cgi?id=125725

Reviewed by Michael Saboff.

This is pretty awesome - it closes the loop on our FTL stackwalking story. We use
an alloca for storing all of the things that the runtime will want to discover
during a stack walk, like the closure pointer for inlined closure calls and the
arguments to inlined functions. We then pass that alloca as an argument to a
stackmap in the prologue, and LLVM reports the alloca's frame offset using a
stackmap direct entry. We call this the "localsOffset". Previously we just used
this to update some OSR exit meta-data. Now we also use it to properly adjust the
ValueRecovery meta-data in inline call frames.

Currently we only have to do this for inline call frames and OSR exits, but in the
future we'll use similar techniques for activations. This bug doesn't cover that
since the FTL doesn't support compiling functions that create activations, yet.
This change makes us incorporate localsOffset into all of the relevant things that
the FTL supports.

This fixes:

jsc-layout-tests.yaml/js/script-tests/dfg-inline-arguments-use-from-all-the-places.js.layout-ftl-eager-no-cjit


With this fix, the FTL only fails one of the JSC layout tests.

  • bytecode/ValueRecovery.h:

(JSC::ValueRecovery::withLocalsOffset):

  • ftl/FTLCompile.cpp:

(JSC::FTL::fixFunctionBasedOnStackMaps):

9:33 PM Changeset in webkit [162243] by Martin Robinson
  • 2 edits in trunk/Source/WebKit

Build fix for the CMake GTK+ build

  • PlatformGTK.cmake: We need to include ProgressTrackerClientGtk in the source list.
9:10 PM Changeset in webkit [162242] by msaboff@apple.com
  • 8 edits in branches/jsCStack/Source/JavaScriptCore

CStack Branch: Fix Baseline JIT for X86-32
https://bugs.webkit.org/show_bug.cgi?id=127201

Reviewed by Geoffrey Garen.

Most of the changes are to follow calling convention (emiting function prologues and
epilogues) and making room on the stack for outgoing arguments.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::unwind):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile): Eliminated stack alignment check before moving the stack
pointer down for locals since it will not be aligned at that time. The move will align
the stack pointer.
(JSC::JIT::frameRegisterCountFor): Changed to allocate the outgoing register space
after rounding the number of local registers as the outgoing register count will
properly align the local registers.

  • jit/JITCall32_64.cpp:

(JSC::JIT::emit_op_ret): Changed to emit epilogue.
(JSC::JIT::emit_op_ret_object_or_this): Changed to emit epilogue.
(JSC::JIT::compileLoadVarargs): Alignment changes matching what is in
JITCall.cpp::JIT::compileLoadVarargs.
(JSC::JIT::compileCallEvalSlowCase): Changed to use the stack pointer to fill-in the
new callee frame.
(JSC::JIT::compileOpCall): Changed to use the stack pointer to fill-in the
new callee frame.
(JSC::JIT::compileOpCallSlowCase): Code to restore the stack pointer after the call.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_ret_object_or_this): Remove dead code in 64 bit path found while
working on this patch.

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall): Changes to follow native calling convention,
allocate space and populate outgoing args and pass the caller to operationVMHandleException.
(JSC::JIT::emit_op_end): Emit the epilogue.

  • jit/ThunkGenerators.cpp:

(JSC::slowPathFor): Allocate stack space for arguments.
(JSC::arityFixup): Changes to match 64 bit code.

  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL): Whitespace cleanup.

9:06 PM Changeset in webkit [162241] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix on EFL port after r162237

The EFL port disabled NETWORK_PROCESS yet and use -Werror=unused-function.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

Guarded legacySessionID with ENABLE(NETWORK_PROCESS)

9:05 PM Changeset in webkit [162240] by msaboff@apple.com
  • 13 edits in branches/jsCStack/Source/JavaScriptCore

CStack Branch: X86-32 Fix LLInt
https://bugs.webkit.org/show_bug.cgi?id=127071

Reviewed by Filip Pizlo.

This fixes X86-32 compilation issues in JITCall32_64.cpp and JITPropertyAccess32_64.cpp.

Fixed the 32 bit LLInt to work with X86. Since X86 passes arguments on the stack,
calls (e.g. LLInt CCall2, JITOperations::getHostCallReturnValue) need to make an
outgoing argument area on the stack, populate the arguments and then make the call.

Much of the argument and call logic is based on the alignment of the stack pointer
and call frame register. The stack pointer at the time of a call needs to be
stackAlignmentBytes() (16 byte) aligned. The call frame register, which points at
the current call frame will be at an alignment that is stackAlignmentBytes() minus
what gets pushed on the stack as part of the call, i.e. the caller PC and caller
frame pointer. For us this is JSStack::CallerFrameAndPCSize * sizeof(Register).

Using roundLocalRegisterCountForFramePointerOffset() eliminates the need for
maxFrameExtentForSlowPathCall needing additional bytes to pad out the stack
to be aligned.

Tested on X86-32 with LLInt only testapi. Tested on X86-64 with all javascript tests.

  • assembler/MaxFrameExtentForSlowPathCall.h:
  • interpreter/ProtoCallFrame.cpp:

(JSC::ProtoCallFrame::init):

  • interpreter/ProtoCallFrame.h:

(JSC::ProtoCallFrame::setPaddedArgCount):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileCallEval):
(JSC::JIT::compileOpCallSlowCase):

  • jit/JITOperations.cpp:
  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):

  • llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

  • llint/LLIntEntrypoint.cpp:

(JSC::LLInt::frameRegisterCountFor):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/StackAlignment.h:

(JSC::roundArgumentCountToAlignFrame):
(JSC::roundLocalRegisterCountForFramePointerOffset):

7:54 PM Changeset in webkit [162239] by fpizlo@apple.com
  • 8 edits in branches/jsCStack/Source/JavaScriptCore

FTL watchpoint tests that use dfgIncrement() and friends fail because numberOfDFGCompiles() returns zero with --testTheFTL=true and right after the first FTL OSR exit but just before recompilation is triggered
https://bugs.webkit.org/show_bug.cgi?id=127163

Reviewed by Michael Saboff.

We just need to track if we had ever compiled with the FTL. Also rework the various
bool's in CodeBlock so that they are bitfields if possible. To that end, make sure
we only write to them from the main thread.

This fixes a bunch of LayoutTests with --ftl-jit. Now only two fail.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpAssumingJITType):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::numberOfDFGCompiles):

  • bytecode/CodeBlock.h:
  • dfg/DFGJITCode.cpp:

(JSC::DFG::JITCode::setOptimizationThresholdBasedOnCompilationResult):

  • dfg/DFGJITFinalizer.cpp:

(JSC::DFG::JITFinalizer::finalizeCommon):

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::Plan):

  • dfg/DFGPlan.h:
  • dfg/DFGTierUpCheckInjectionPhase.cpp:

(JSC::DFG::TierUpCheckInjectionPhase::run):

6:31 PM Changeset in webkit [162238] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Micro-optimize RenderBoxModelObject::computedCSSPadding().
<https://webkit.org/b/127208>

Make computedCSSPadding() take the Length as a const reference
to avoid creating a temporary copy. This was showing up (0.2%)
on DoYouEvenBench.

Reviewed by Anders Carlsson.

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::computedCSSPadding):

6:17 PM Changeset in webkit [162237] by commit-queue@webkit.org
  • 30 edits
    2 copies in trunk/Source/WebKit2

Flesh out session APIs (still not enabled at API level).
https://bugs.webkit.org/show_bug.cgi?id=126918

Patch by Martin Hock <mhock@apple.com> on 2014-01-17
Reviewed by Alexey Proskuryakov.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::storageSession):
(WebKit::NetworkConnectionToWebProcess::startDownload):
(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
(WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
(WebKit::NetworkConnectionToWebProcess::cookiesEnabled):
(WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue):
(WebKit::NetworkConnectionToWebProcess::getRawCookies):
(WebKit::NetworkConnectionToWebProcess::deleteCookie):

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:
  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::ensurePrivateBrowsingSession):
(WebKit::NetworkProcess::destroyPrivateBrowsingSession):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/RemoteNetworkingContext.h:
  • NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::storageSession):
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):

  • NetworkProcess/soup/RemoteNetworkingContextSoup.cpp:

(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):

  • Shared/SessionTracker.cpp: Copied from Source/WebKit2/UIProcess/APISession.cpp.

(WebKit::sessionMap):
(WebKit::identifierBase):
(WebKit::SessionTracker::getSessionMap):
(WebKit::SessionTracker::getIdentifierBase):
(WebKit::SessionTracker::session):
(WebKit::SessionTracker::destroySession):
(WebKit::SessionTracker::setIdentifierBase):

  • Shared/SessionTracker.h: Copied from Source/WebKit2/UIProcess/APISession.h.

(WebKit::SessionTracker::isEphemeralID):

  • UIProcess/APISession.cpp:

(API::generateID):
(API::Session::defaultSession):
(API::Session::legacyPrivateSession):
(API::Session::Session):
(API::Session::create):
(API::Session::isEphemeral):
(API::Session::getID):

  • UIProcess/APISession.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::setAnyPageGroupMightHavePrivateBrowsingEnabled):
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::createWebPage):

  • UIProcess/WebContext.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::sessionID):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createWebPage):

  • UIProcess/WebProcessProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setPrivateBrowsingEnabled):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::legacySessionID):
(WebKit::WebPlatformStrategies::cookiesForDOM):
(WebKit::WebPlatformStrategies::setCookiesFromDOM):
(WebKit::WebPlatformStrategies::cookiesEnabled):
(WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue):
(WebKit::WebPlatformStrategies::getRawCookies):
(WebKit::WebPlatformStrategies::deleteCookie):

  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
(WebKit::WebFrameNetworkingContext::storageSession):

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:

(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::storageSession):

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::ensurePrivateBrowsingSession):
(WebKit::WebProcess::destroyPrivateBrowsingSession):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
6:08 PM Changeset in webkit [162236] by ap@apple.com
  • 4 edits in trunk/Tools

build.webkit.org/dashboard should have diff links in test results popovers
https://bugs.webkit.org/show_bug.cgi?id=126986

Reviewed by Tim Horton.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:

(Buildbot.prototype.layoutTestCrashLogURLForIteration):
(Buildbot.prototype.layoutTestStderrURLForIteration):
(Buildbot.prototype.layoutTestDiffURLForIteration):
(Buildbot.prototype.layoutTestPrettyDiffURLForIteration):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(BuildbotIteration.prototype.loadLayoutTestResults):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

(BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):

5:58 PM Changeset in webkit [162235] by andersca@apple.com
  • 6 edits in trunk/Source

Add a callOnMainThreadAndWait variant in SocketStreamHandle
https://bugs.webkit.org/show_bug.cgi?id=127180

Reviewed by Geoffrey Garen.

Source/WebCore:

WTF::callOnMainThreadAndWait was only used inside SocketStreamHandleCFNet.cpp,
so add an improved version there which is implemented in terms of callOnMainThread and
with the bonus of handling spurious wake-ups correctly (the old version didn't).

  • platform/network/cf/SocketStreamHandle.h:
  • platform/network/cf/SocketStreamHandleCFNet.cpp:

(WebCore::callOnMainThreadAndWait):
(WebCore::SocketStreamHandle::pacExecutionCallback):
(WebCore::SocketStreamHandle::readStreamCallback):
(WebCore::SocketStreamHandle::writeStreamCallback):

Source/WTF:

Remove callOnMainThreadAndWait from WTF.

  • wtf/MainThread.cpp:
  • wtf/MainThread.h:
5:47 PM Changeset in webkit [162234] by andersca@apple.com
  • 15 edits in trunk/Source

Clean up PageCache classes
https://bugs.webkit.org/show_bug.cgi?id=127202

Reviewed by Andreas Kling.

Source/WebCore:

  • WebCore.exp.in:
  • history/CachedFrame.cpp:

(WebCore::CachedFrameBase::~CachedFrameBase):
(WebCore::CachedFrame::CachedFrame):
(WebCore::CachedFrame::clear):
(WebCore::CachedFrame::setCachedFramePlatformData):

  • history/CachedFrame.h:
  • history/CachedPage.cpp:

(WebCore::CachedPage::CachedPage):

  • history/CachedPage.h:
  • history/HistoryItem.h:

(WebCore::HistoryItem::isInPageCache):

  • history/PageCache.cpp:

(WebCore::PageCache::add):
(WebCore::PageCache::take):
(WebCore::PageCache::remove):

  • history/PageCache.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad):

  • loader/HistoryController.cpp:

(WebCore::HistoryController::invalidateCurrentItemCachedPage):

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::savePlatformDataToCachedFrame):
(WebFrameLoaderClient::transitionToCommittedFromCachedFrame):

Source/WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::savePlatformDataToCachedFrame):

5:18 PM Changeset in webkit [162233] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Work around a preprocessor warning in mediaControlsApple.js
https://bugs.webkit.org/show_bug.cgi?id=127204

Reviewed by Dan Bernstein.

  • Modules/mediacontrols/mediaControlsApple.js: Changed to String().
4:36 PM Changeset in webkit [162232] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the iOS build after <http://trac.webkit.org/changeset/162184>
(https://bugs.webkit.org/show_bug.cgi?id=126856)

Remove symbol for WebCore::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator(unsigned short const*, int).
Add symbol for WebCore::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator(WTF::StringView).

  • WebCore.exp.in:
4:34 PM Changeset in webkit [162231] by akling@apple.com
  • 9 edits
    2 deletes in trunk/Source

Remove unused TOUCH_ADJUSTMENT code.
<https://webkit.org/b/127181>

Source/WebCore:

There are no ports using the ENABLE(TOUCH_ADJUSTMENT) feature
anymore, so nuke it from orbit.

Reviewed by Anders Carlsson.

  • page/EventHandler.cpp:
  • page/EventHandler.h:
  • page/Settings.in:
  • page/TouchAdjustment.cpp: Removed.
  • page/TouchAdjustment.h: Removed.
  • testing/Internals.cpp:
  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/CoordinatedGraphics/WebPageCoordinatedGraphics.cpp:

(WebKit::WebPage::findZoomableAreaForPoint):

4:05 PM Changeset in webkit [162230] by Beth Dakin
  • 16 edits
    2 adds in trunk

Need a way to test the tile cache with margins enabled
https://bugs.webkit.org/show_bug.cgi?id=127194
-and corresponding-
<rdar://problem/15571327>

Reviewed by Tim Horton.

Source/WebCore:

This patch adds a new function to InternalSettings that will allow layout tests to
flip the setting Settings::setBackgroundShouldExtendBeyondPage(). This patch also
makes changing that setting take effect immediately.

To make this setting dynamic, we can no longer generate the Setting function, so
we have to export the symbol manually.

  • WebCore.exp.in:

This new function on FrameView will call into RenderLayerBacking to add or remove
margins.

  • page/FrameView.cpp:

(WebCore::FrameView::setBackgroundExtendsBeyondPage):

  • page/FrameView.h:

Again, we’re no longer using the boiler-plate generated Setting functions, so now
we can call into FrameView to make the background extend.

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setBackgroundShouldExtendBeyondPage):

  • page/Settings.h:

(WebCore::Settings::backgroundShouldExtendBeyondPage):

  • page/Settings.in:

Whenever tile margins are set, call setNeedsRevalidateTiles() to make the change
dynamic.

  • platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::setTileMargins):

Move the call to TiledBacking::setTileMargins() into a helper function so that the
same code can be used for FrameView.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::RenderLayerBacking::setTiledBackingHasMargins):

  • rendering/RenderLayerBacking.h:

New InternalSetting.

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::setBackgroundShouldExtendBeyondPage):

  • testing/InternalSettings.h:
  • testing/InternalSettings.idl:

Source/WebKit:

Attempt to keep Windows building.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

LayoutTests:

  • platform/mac-wk2/tiled-drawing/simple-document-with-margin-tiles-expected.txt: Added.
  • platform/mac-wk2/tiled-drawing/simple-document-with-margin-tiles.html: Added.
3:49 PM Changeset in webkit [162229] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Fix build.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
3:43 PM Changeset in webkit [162228] by matthew_hanson@apple.com
  • 3 edits in trunk/Tools

Add the bare minimum support for branches to the bot-watchers dashboard
https://bugs.webkit.org/show_bug.cgi?id=127124

This patch simply introduces the notion of branches into the bot-watchers dashboard.
Subsequent patches will build functionality on top of this simple bit of infrastructure.

Reviewed by Timothy Hatcher.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:

(BuildbotQueue): store the branch property in the BuildbotQueue constructor

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:

Initialize the Dashboard.Branch object

3:17 PM Changeset in webkit [162227] by andersca@apple.com
  • 25 edits in trunk/Source

Remove another unused FrameLoaderClient callback
https://bugs.webkit.org/show_bug.cgi?id=127192

Reviewed by Dan Bernstein.

Source/WebCore:

FrameLoaderClient::dispatchDocumentElementAvailable() was only used by the Chromium port, so remove it.

  • html/ImageDocument.cpp:

(WebCore::ImageDocument::createDocumentStructure):

  • html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):

  • html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::createDocumentStructure):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::dispatchDocumentElementAvailableIfNeeded):

  • loader/EmptyClients.h:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::startElementNs):

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:
  • WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:
  • WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

Source/WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit/wince:

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:
  • WebCoreSupport/FrameLoaderClientWinCE.h:
2:59 PM Changeset in webkit [162226] by andersca@apple.com
  • 9 edits in trunk/Source

Remove FrameLoaderClient::didPerformFirstNavigation()
https://bugs.webkit.org/show_bug.cgi?id=127191

Reviewed by Dan Bernstein.

Source/WebCore:

  • loader/EmptyClients.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::FrameLoader):

  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/HistoryController.cpp:

(WebCore::HistoryController::updateBackForwardListClippedAtTarget):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
2:49 PM Changeset in webkit [162225] by andersca@apple.com
  • 14 edits in trunk/Source/WebKit

Remove didPerformFirstNavigation from all FrameLoaderClient subclasses
https://bugs.webkit.org/show_bug.cgi?id=127190

Reviewed by Dan Bernstein.

Source/WebKit/efl:

According to the EFl maintainers, this is not used by any applications so it's safe to remove it.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:
  • WebCoreSupport/FrameLoaderClientEfl.h:
  • ewk/ewk_frame.cpp:
  • ewk/ewk_frame_private.h:

Source/WebKit/gtk:

Removing this shouldn't have any bad effects, but if that is the case it's possible to
set the cache model in didCommitLoadForFrame, similar to what is done in r162224.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:
  • WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit/wince:

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:
  • WebCoreSupport/FrameLoaderClientWinCE.h:
2:38 PM Changeset in webkit [162224] by andersca@apple.com
  • 7 edits in trunk/Source

Move didPerformFirstNavigation() logic to -[WebView _didCommitLoadForFrame:]
https://bugs.webkit.org/show_bug.cgi?id=127189

Reviewed by Dan Bernstein.

Source/WebCore:

  • loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::didPerformFirstNavigation):
Add an empty implementation of didPerformFirstNavigation() to make it easier to remove it from subclasses.

Source/WebKit/mac:

This is a first step towards completely eliminating the didPerformFirstNavigation() client callback.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

Remove didPerformFirstNavigation() implementation.

  • WebView/WebView.mm:

(-[WebView _checkDidPerformFirstNavigation]):
Check if we have both a current item and a previous item which indicates that we've navigated once.
The old code was called before there was a current item but since this is called from _didCommitLoadForFrame
we have to check that there's a current item as well.

(-[WebView _didCommitLoadForFrame:]):
Call _didCommitLoadForFrame.

  • WebView/WebViewData.h:

Add new ivar.

2:22 PM Changeset in webkit [162223] by Manuel Rego Casasnovas
  • 7 edits in trunk/PerformanceTests

[CSS Regions] Minor fixes in regions performance tests
https://bugs.webkit.org/show_bug.cgi?id=127041

Reviewed by Ryosuke Niwa.

Fix minor issues in CSS Regions performance tests.

  • Layout/RegionsAuto.html: Change type to lower case.
  • Layout/RegionsAutoMaxHeight.html: Ditto.
  • Layout/RegionsFixed.html: Ditto.
  • Layout/RegionsFixedShort.html: Ditto.
  • Layout/RegionsSelection.html: Ditto. Move test methods from regions.js.
  • Layout/resources/regions.js: Remove moved methods.
1:54 PM Changeset in webkit [162222] by Chris Fleizach
  • 7 edits in trunk/Tools

platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
https://bugs.webkit.org/show_bug.cgi?id=127141

Reviewed by Alexey Proskuryakov.

Make sure to reset the notification handler each time.

  • DumpRenderTree/AccessibilityController.cpp:

(AccessibilityController::resetToConsistentState):

  • DumpRenderTree/AccessibilityController.h:
  • DumpRenderTree/atk/AccessibilityControllerAtk.cpp:

(AccessibilityController::platformResetToConsistentState):

  • DumpRenderTree/ios/AccessibilityControllerIOS.mm:

(AccessibilityController::platformResetToConsistentState):

  • DumpRenderTree/mac/AccessibilityControllerMac.mm:

(AccessibilityController::~AccessibilityController):
(AccessibilityController::platformResetToConsistentState):
(AccessibilityController::removeNotificationListener):

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::platformResetToConsistentState):

1:36 PM Changeset in webkit [162221] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] HTMLMediaSession should set AudioSession category
https://bugs.webkit.org/show_bug.cgi?id=127137

Reviewed by Sam Weinig.

  • html/HTMLMediaSession.cpp:

(WebCore::initializeAudioSession): New, set the audio session to "media" on iOS.
(WebCore::HTMLMediaSession::HTMLMediaSession): Call initializeAudioSession.

1:31 PM Changeset in webkit [162220] by rniwa@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Host DoYouEvenBench on webkit.org
https://bugs.webkit.org/show_bug.cgi?id=127185

Reviewed by Benjamin Poulain.

The previous patch didn't quite work due to cross-origin restrictions.
Simply add a hyperlink to a trac page.

  • perf/DoYouEvenBench/index.html:
1:24 PM Changeset in webkit [162219] by ap@apple.com
  • 2 edits in trunk/Source/WebKit/mac

More iOS build fix.

  • WebView/WebPreferences.mm: (-[WebPreferences _synchronizeWebStoragePolicyWithCookiePolicy]):

NSHTTPCookieAcceptPolicyExclusivelyFromMainDocumentDomain is not part of NSHTTPCookieAcceptPolicy enum.

1:13 PM Changeset in webkit [162218] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the iOS build after <http://trac.webkit.org/changeset/162178>
(https://bugs.webkit.org/show_bug.cgi?id=127147)

Declare WebMediaSessionHelper outside of namespace WebCore to resolve error that
"Objective-C declarations may only appear in global scope".

  • platform/audio/ios/MediaSessionManagerIOS.mm:
1:11 PM Changeset in webkit [162217] by Bem Jones-Bey
  • 6 edits
    6 adds in trunk

[CSS Shapes] Stacked floats with shape-outside should allow inline content to interact with the non-outermost float
https://bugs.webkit.org/show_bug.cgi?id=122576

Reviewed by David Hyatt.

Source/WebCore:

Make inline content interact with stacked floats with shape-outside
per the spec. This means that content can interact with floats on the
line that are not the outermost float.

This refactors ComputeFloatOffsetAdapter into a superclass and two
subclasses: one adaptor for determining the offset for float layout,
and one for determining the offset for inline layout.

The logic in LineWidth::shrinkAvailableWidthForNewFloatIfNeeded has
been updated to handle stacked floats with shape-outside properly and
has been considerably simplified in the process. It was previously
doing a whole bunch of unnecessary work.

Tests: fast/shapes/shape-outside-floats/shape-outside-floats-stacked-000.html

fast/shapes/shape-outside-floats/shape-outside-floats-stacked-001.html
fast/shapes/shape-outside-floats/shape-outside-floats-stacked-002.html

  • rendering/FloatingObjects.cpp:

(WebCore::ComputeFloatOffsetAdapter::~ComputeFloatOffsetAdapter):
(WebCore::ComputeFloatOffsetForFloatLayoutAdapter::ComputeFloatOffsetForFloatLayoutAdapter):
(WebCore::ComputeFloatOffsetForFloatLayoutAdapter::~ComputeFloatOffsetForFloatLayoutAdapter):
(WebCore::ComputeFloatOffsetForLineLayoutAdapter::ComputeFloatOffsetForLineLayoutAdapter):
(WebCore::ComputeFloatOffsetForLineLayoutAdapter::~ComputeFloatOffsetForLineLayoutAdapter):
(WebCore::FloatingObjects::logicalLeftOffsetForPositioningFloat):
(WebCore::FloatingObjects::logicalRightOffsetForPositioningFloat):
(WebCore::FloatingObjects::logicalLeftOffset):
(WebCore::FloatingObjects::logicalRightOffset):
(WebCore::ComputeFloatOffsetForFloatLayoutAdapter<FloatingObject::FloatLeft>::updateOffsetIfNeeded):
(WebCore::ComputeFloatOffsetForFloatLayoutAdapter<FloatingObject::FloatRight>::updateOffsetIfNeeded):
(WebCore::ComputeFloatOffsetForFloatLayoutAdapter<FloatTypeValue>::heightRemaining):
(WebCore::shapeInfoForFloat):
(WebCore::ComputeFloatOffsetForLineLayoutAdapter<FloatingObject::FloatLeft>::updateOffsetIfNeeded):
(WebCore::ComputeFloatOffsetForLineLayoutAdapter<FloatingObject::FloatRight>::updateOffsetIfNeeded):

  • rendering/line/LineWidth.cpp:

(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):

  • rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::ShapeOutsideInfo::updateDeltasForContainingBlockLine):

  • rendering/shapes/ShapeOutsideInfo.h:

LayoutTests:

Tests for shape-outside on stacked floats and interaction with inline
content.

  • fast/shapes/shape-outside-floats/shape-outside-floats-stacked-000-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-stacked-000.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-stacked-001-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-stacked-001.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-stacked-002-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-stacked-002.html: Added.
1:10 PM Changeset in webkit [162216] by rniwa@webkit.org
  • 3 edits
    1 copy
    1 add in trunk

Host DoYouEvenBench on webkit.org
https://bugs.webkit.org/show_bug.cgi?id=127185

Reviewed by Benjamin Poulain.

PerformanceTests:

Compute the resources directory relative to the benchmark-runner's location
so that we can load tests even if the runner HTML was located elsewhere.

  • DoYouEvenBench/Full.html:
  • DoYouEvenBench/resources/benchmark-runner.js:

(BenchmarkState._containingDirectory):

Websites/webkit.org:

Added webkit.org/perf/DoYouEvenBench.

  • perf/DoYouEvenBench: Added.
  • perf/DoYouEvenBench/index.html: Copied from PerformanceTests/DoYouEvenBench/Full.html.
12:56 PM Changeset in webkit [162215] by Manuel Rego Casasnovas
  • 4 edits in trunk/Source/WebKit2

[GTK] Add CSS Grid Layout as experimental feature
https://bugs.webkit.org/show_bug.cgi?id=127089

Reviewed by Martin Robinson.

Allow CSS Grid Layout to be enabled through the environment variable WEBKITGTK_EXPERIMENTAL_FEATURES.

Example: WEBKITGTK_EXPERIMENTAL_FEATURES="CSS_GRID_LAYOUT=1"

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsConstructed): Use new experimental feature to enable or disable CSS Grid Layout.

  • UIProcess/gtk/ExperimentalFeatures.cpp: Add new experimental feature.
  • UIProcess/gtk/ExperimentalFeatures.h: Ditto.
12:43 PM Changeset in webkit [162214] by rniwa@webkit.org
  • 3 edits
    3 moves in trunk/PerformanceTests

DoYouEvenBench: Move flightjs-example-app and todomvc into resources
https://bugs.webkit.org/show_bug.cgi?id=127183

Rubber-stamped by Anders Carlsson.

  • DoYouEvenBench/InteractiveRunner.html: Copied from PerformanceTests/DoYouEvenBench/benchmark.html.
  • DoYouEvenBench/benchmark.html: Removed.
  • DoYouEvenBench/flightjs-example-app: Removed.
  • DoYouEvenBench/flightjs-example-app/LICENSE.md: Removed.
  • DoYouEvenBench/flightjs-example-app/README.md: Removed.
  • DoYouEvenBench/flightjs-example-app/app: Removed.
  • DoYouEvenBench/flightjs-example-app/app/boot: Removed.
  • DoYouEvenBench/flightjs-example-app/app/boot/page.js: Removed.
  • DoYouEvenBench/flightjs-example-app/app/component_data: Removed.
  • DoYouEvenBench/flightjs-example-app/app/component_data/compose_box.js: Removed.
  • DoYouEvenBench/flightjs-example-app/app/component_data/mail_items.js: Removed.
  • DoYouEvenBench/flightjs-example-app/app/component_data/move_to.js: Removed.
  • DoYouEvenBench/flightjs-example-app/app/component_ui: Removed.
  • DoYouEvenBench/flightjs-example-app/app/component_ui/compose_box.js: Removed.
  • DoYouEvenBench/flightjs-example-app/app/component_ui/folders.js: Removed.
  • DoYouEvenBench/flightjs-example-app/app/component_ui/mail_controls.js: Removed.
  • DoYouEvenBench/flightjs-example-app/app/component_ui/mail_items.js: Removed.
  • DoYouEvenBench/flightjs-example-app/app/component_ui/move_to_selector.js: Removed.
  • DoYouEvenBench/flightjs-example-app/app/component_ui/with_select.js: Removed.
  • DoYouEvenBench/flightjs-example-app/app/css: Removed.
  • DoYouEvenBench/flightjs-example-app/app/css/custom.css: Removed.
  • DoYouEvenBench/flightjs-example-app/app/data.js: Removed.
  • DoYouEvenBench/flightjs-example-app/app/templates.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components: Removed.
  • DoYouEvenBench/flightjs-example-app/components/bootstrap: Removed.
  • DoYouEvenBench/flightjs-example-app/components/bootstrap/css: Removed.
  • DoYouEvenBench/flightjs-example-app/components/bootstrap/css/bootstrap-responsive.css: Removed.
  • DoYouEvenBench/flightjs-example-app/components/bootstrap/css/bootstrap-responsive.min.css: Removed.
  • DoYouEvenBench/flightjs-example-app/components/bootstrap/css/bootstrap.css: Removed.
  • DoYouEvenBench/flightjs-example-app/components/bootstrap/css/bootstrap.min.css: Removed.
  • DoYouEvenBench/flightjs-example-app/components/bootstrap/img: Removed.
  • DoYouEvenBench/flightjs-example-app/components/bootstrap/img/glyphicons-halflings-white.png: Removed.
  • DoYouEvenBench/flightjs-example-app/components/bootstrap/img/glyphicons-halflings.png: Removed.
  • DoYouEvenBench/flightjs-example-app/components/bootstrap/js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/bootstrap/js/bootstrap.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/bootstrap/js/bootstrap.min.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/.gitignore: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/CHANGES: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/CONTRIBUTORS.md: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/LICENSE: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/README.md: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/component.json: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/es5-sham.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/es5-sham.min.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/es5-shim.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/es5-shim.min.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/package.json: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/helpers: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/helpers/h-kill.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/helpers/h-matchers.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/helpers/h.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/index.html: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/jasmine-html.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/jasmine.css: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/jasmine.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/jasmine_favicon.png: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/json2.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-array.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-date.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-function.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-object.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-string.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/flight: Removed.
  • DoYouEvenBench/flightjs-example-app/components/flight/.travis.yml: Removed.
  • DoYouEvenBench/flightjs-example-app/components/flight/lib: Removed.
  • DoYouEvenBench/flightjs-example-app/components/flight/lib/advice.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/flight/lib/component.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/flight/lib/compose.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/flight/lib/index.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/flight/lib/logger.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/flight/lib/registry.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/flight/lib/utils.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/flight/tools: Removed.
  • DoYouEvenBench/flightjs-example-app/components/flight/tools/debug: Removed.
  • DoYouEvenBench/flightjs-example-app/components/flight/tools/debug/debug.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/jasmine-flight: Removed.
  • DoYouEvenBench/flightjs-example-app/components/jasmine-flight/LICENSE.md: Removed.
  • DoYouEvenBench/flightjs-example-app/components/jasmine-flight/README.md: Removed.
  • DoYouEvenBench/flightjs-example-app/components/jasmine-flight/bower.json: Removed.
  • DoYouEvenBench/flightjs-example-app/components/jasmine-flight/lib: Removed.
  • DoYouEvenBench/flightjs-example-app/components/jasmine-flight/lib/jasmine-flight.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/jasmine-jquery: Removed.
  • DoYouEvenBench/flightjs-example-app/components/jasmine-jquery/lib: Removed.
  • DoYouEvenBench/flightjs-example-app/components/jasmine-jquery/lib/jasmine-jquery.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/jquery: Removed.
  • DoYouEvenBench/flightjs-example-app/components/jquery/component.json: Removed.
  • DoYouEvenBench/flightjs-example-app/components/jquery/composer.json: Removed.
  • DoYouEvenBench/flightjs-example-app/components/jquery/jquery.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/jquery/jquery.min.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/mustache: Removed.
  • DoYouEvenBench/flightjs-example-app/components/mustache/mustache.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/requirejs: Removed.
  • DoYouEvenBench/flightjs-example-app/components/requirejs/require.js: Removed.
  • DoYouEvenBench/flightjs-example-app/index.html: Removed.
  • DoYouEvenBench/flightjs-example-app/karma.conf.js: Removed.
  • DoYouEvenBench/flightjs-example-app/package.json: Removed.
  • DoYouEvenBench/flightjs-example-app/requireMain.js: Removed.
  • DoYouEvenBench/resources/benchmark-runner.js:
  • DoYouEvenBench/resources/flightjs-example-app: Copied from PerformanceTests/DoYouEvenBench/flightjs-example-app.
  • DoYouEvenBench/resources/todomvc: Copied from PerformanceTests/DoYouEvenBench/todomvc.
  • DoYouEvenBench/todomvc: Removed.
  • DoYouEvenBench/todomvc/architecture-examples: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower.json: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular-mocks: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular-mocks/angular-mocks.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular/angular.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/base.css: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/base.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/bg.png: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/index.html: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js/app.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js/controllers: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js/controllers/todoCtrl.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives/todoBlur.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives/todoEscape.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives/todoFocus.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js/services: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js/services/todoStorage.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/readme.md: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/test: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/test/config: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/test/config/testacular.conf.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/test/package.json: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/test/readme.md: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/test/unit: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/test/unit/directivesSpec.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/test/unit/todoCtrlSpec.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower.json: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/backbone: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/backbone.localStorage: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/backbone.localStorage/backbone.localStorage.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/backbone/backbone.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/jquery: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/jquery/jquery.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/todomvc-common: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/todomvc-common/base.css: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/todomvc-common/base.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/todomvc-common/bg.png: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/underscore: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/underscore/underscore.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/index.html: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/app.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/collections: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/collections/todos.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/models: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/models/todo.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/routers: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/routers/router.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/views: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/views/app-view.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/views/todo-view.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/readme.md: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower.json: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/ember: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/ember-localstorage-adapter: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/ember-localstorage-adapter/localstorage_adapter.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/handlebars: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/handlebars/handlebars.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/jquery: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/jquery/jquery.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/todomvc-common: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/base.css: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/base.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/bg.png: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/index.html: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/app.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/controllers: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/controllers/todo_controller.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/controllers/todos_controller.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/libs: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/libs/ember-data.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/models: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/models/store.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/models/todo.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/router.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/views: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/views/edit_todo_view.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/readme.md: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/test.html: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower.json: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/handlebars: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/handlebars/handlebars.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/jquery: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/jquery/jquery.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/todomvc-common: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/todomvc-common/base.css: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/todomvc-common/base.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/todomvc-common/bg.png: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/css: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/css/app.css: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/index.html: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/js/app.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/readme.md: Removed.
  • DoYouEvenBench/todomvc/labs: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower.json: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/LICENSE: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/README.md: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/build: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/build/director.js: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/build/director.min.js: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/build/ender.js: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react/JSXTransformer.js: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react/bower.json: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react/react.js: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react/react.min.js: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/todomvc-common: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/todomvc-common/base.css: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/todomvc-common/base.js: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/todomvc-common/bg.png: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/index.html: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/js: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/js/app.jsx: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/js/footer.jsx: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/js/todoItem.jsx: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/js/utils.jsx: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/readme.md: Removed.
  • DoYouEvenBench/todomvc/license.md: Removed.
  • DoYouEvenBench/todomvc/readme.md: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower.json: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/base.css: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/base.js: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/bg.png: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/index.html: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/app.js: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/controller.js: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/helpers.js: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/model.js: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/store.js: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/view.js: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/readme.md: Removed.
  • Skipped:
12:33 PM Changeset in webkit [162213] by zoltan@webkit.org
  • 4 edits
    4 adds in trunk

[CSS3] Add rendering support for -webkit-text-align-last
https://bugs.webkit.org/show_bug.cgi?id=99584

Reviewed by David Hyatt.

Source/WebCore:

Add support for the text-align-last CSS3 property, according to the latest specification:
http://dev.w3.org/csswg/css-text-3/#text-align-last-property

Tests: fast/css3-text/css3-text-align-last/text-align-last-with-text-align-justify.html

fast/css3-text/css3-text-align-last/text-align-last-with-text-align-non-justify.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::textAlignmentForLine):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresLayout):

LayoutTests:

  • fast/css3-text/css3-text-align-last/text-align-last-with-text-align-justify-expected.html: Added.
  • fast/css3-text/css3-text-align-last/text-align-last-with-text-align-justify.html: Added.
  • fast/css3-text/css3-text-align-last/text-align-last-with-text-align-non-justify-expected.html: Added.
  • fast/css3-text/css3-text-align-last/text-align-last-with-text-align-non-justify.html: Added.
12:29 PM Changeset in webkit [162212] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the iOS build after <http://trac.webkit.org/changeset/162208>
(https://bugs.webkit.org/show_bug.cgi?id=127139)

MAC_OS_X_VERSION_MIN_REQUIRED isn't defined when building for iOS. Instead, explicitly
check that we're not PLATFORM(IOS) to avoid defining the enum value CFHTTPCookieStorageAcceptPolicyExclusivelyFromMainDocumentDomain.

  • platform/network/cf/CookieJarCFNet.cpp:
12:26 PM Changeset in webkit [162211] by berto@igalia.com
  • 2 edits in trunk/Tools

[GTK] Test /webkit/download/not-found fails in GTK Linux 64-bit Release bot
https://bugs.webkit.org/show_bug.cgi?id=82329

Reviewed by Carlos Garcia Campos.

Unskip, this is working fine now.

  • Scripts/run-gtk-tests:

(TestRunner):

12:13 PM Changeset in webkit [162210] by betravis@adobe.com
  • 12 edits in trunk

[CSS Shapes] Basic shapes' computed position should be a horizontal and vertical offset
https://bugs.webkit.org/show_bug.cgi?id=127010

Reviewed by Rob Buis.

Source/WebCore:

This patch updates the computed position values used for blending to be a horizontal
left offset and a vertical top offset. When positions include a center, bottom, or
right position offset, it is converted to the appropriate top/left coordinate as
a calc expression. Serialized values still use the original bottom/right directions
when present, and also omit the top/left keywords where possible.

Updated parsing and animation tests.

  • css/BasicShapeFunctions.cpp:

(WebCore::valueForCenterCoordinate): Use the simplified BasicShapeCenterCoordinate,
which includes an offset and whether the direction is from the top/left or bottom/right.
(WebCore::valueForBasicShape): Ditto.
(WebCore::convertToCenterCoordinate): Ditto.
(WebCore::basicShapeForValue): Ditto.
(WebCore::floatValueForCenterCoordinate): Ditto.

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc): Remove the RenderBox parameter, which is no longer needed.

  • rendering/style/BasicShapes.cpp:

(WebCore::BasicShapeCenterCoordinate::updateComputedLength): Calculate the computed
position offset for this center coordinate.
(WebCore::BasicShapeRectangle::blend): Remove the RenderBox parameter.
(WebCore::DeprecatedBasicShapeCircle::blend): Ditto.
(WebCore::BasicShapeCircle::blend): Ditto.
(WebCore::DeprecatedBasicShapeEllipse::blend): Ditto.
(WebCore::BasicShapeEllipse::blend): Ditto.
(WebCore::BasicShapePolygon::blend): Ditto.
(WebCore::BasicShapeInsetRectangle::blend): Ditto.
(WebCore::BasicShapeInset::blend): Ditto.

  • rendering/style/BasicShapes.h:

(WebCore::BasicShapeCenterCoordinate::BasicShapeCenterCoordinate): Simplify
BasicShapeCenterCoordinate to contain an offset and a direction. Also add a
computed length, which is an offset from the top/left direction.
(WebCore::BasicShapeCenterCoordinate::direction):
(WebCore::BasicShapeCenterCoordinate::computedLength):
(WebCore::BasicShapeCenterCoordinate::blend):

LayoutTests:

Update existing parsing and animation tests. For parsing tests, top / left keywords
are omitted whenever possible. For animation tests, animations to bottom / right
offsets will use calc values based from the top / left direction.

  • animations/resources/animation-test-helpers.js:

(parseBasicShape): Parse non-numerical arguments to the shape function.
(basicShapeParametersMatch): Match non-numerical arguments to the shape function.

  • fast/shapes/parsing/parsing-shape-inside-expected.txt: Update serialized values

to omit top / left keywords when possible.

  • fast/shapes/parsing/parsing-shape-outside-expected.txt: Update serialized values

to omit top / left keywords when possible.

  • fast/shapes/parsing/parsing-test-utils.js: Modify shape parsing test expectations.
  • fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt: Ditto.
  • fast/shapes/shape-outside-floats/shape-outside-animation.html: Ditto.
11:55 AM Changeset in webkit [162209] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

String::is8Bit() crashes if m_impl is null, handle this.

  • API/OpaqueJSString.h:

(OpaqueJSString::OpaqueJSString):

11:34 AM Changeset in webkit [162208] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

More non-Mac build fix.

  • platform/network/cf/CookieJarCFNet.cpp:
11:32 AM Changeset in webkit [162207] by mmaxfield@apple.com
  • 3 edits
    2 adds in trunk

Unprefix text-emphasis CSS properties
https://bugs.webkit.org/show_bug.cgi?id=127160

Reviewed by Sam Weinig.

Source/WebCore:

Add synonym CSS properties. We don't want to delete the old ones because
we've shipped with them included.

Test: fast/css3-text/css3-text-decoration/text-decoration-unprefix.html

  • css/CSSPropertyNames.in:

LayoutTests:

Add a reftest to compare the prefixed and unprefixed properties

  • fast/css3-text/css3-text-decoration/text-decoration-unprefix-expected.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-unprefix.html: Added.
11:25 AM Changeset in webkit [162206] by andersca@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Try to fix the Windows build.

  • API/OpaqueJSString.cpp:

(OpaqueJSString::~OpaqueJSString):
(OpaqueJSString::characters):

  • API/OpaqueJSString.h:

(OpaqueJSString::OpaqueJSString):

9:44 AM Changeset in webkit [162205] by andersca@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Get rid of OpaqueJSString::deprecatedCharacters()
https://bugs.webkit.org/show_bug.cgi?id=127161

Reviewed by Sam Weinig.

Handle OpaqueJSString::m_string being either 8-bit or 16-bit and add extra
code paths for the 8-bit cases.

Unfortunately, JSStringGetCharactersPtr is still expected to return a 16-bit character pointer.
Handle this by storing a separate 16-bit string and initializing it on demand when JSStringGetCharactersPtr
is called and the backing string is 8-bit.

This has the nice side effect of making JSStringGetCharactersPtr thread-safe when it wasn't before.
(In theory, someone could have a JSStringRef backed by an 8-bit string and call JSStringGetCharactersPtr on it
causing an unsafe upconversion to a 16-bit string).

  • API/JSStringRef.cpp:

(JSStringGetCharactersPtr):
Call OpaqueJSString::characters.

(JSStringGetUTF8CString):
Add a code path that handles 8-bit strings.

(JSStringIsEqual):
Call OpaqueJSString::equal.

  • API/JSStringRefCF.cpp:

(JSStringCreateWithCFString):
Reformat the code to use an early return instead of putting most of the code inside the body of an if statement.

(JSStringCopyCFString):
Create an 8-bit CFStringRef if possible.

  • API/OpaqueJSString.cpp:

(OpaqueJSString::create):
Use nullptr.

(OpaqueJSString::~OpaqueJSString):
Free m_characters.

(OpaqueJSString::characters):
Do the up-conversion and store the result in m_characters.

(OpaqueJSString::equal):
New helper function.

  • API/OpaqueJSString.h:

(OpaqueJSString::is8Bit):
New function that returns whether a string is 8-bit or not.

(OpaqueJSString::characters8):
(OpaqueJSString::characters16):
Add getters.

9:34 AM Changeset in webkit [162204] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

Support WebSelections in WK2 on iOS.
https://bugs.webkit.org/show_bug.cgi?id=127015
<rdar://problem/15843090>

Reviewed by Dan Bernstein.

Removing unused variable in selectWithGesture that
causes Release build to fail after r162103.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::selectWithGesture):

9:21 AM Changeset in webkit [162203] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=127138
Add more delegate callback methods to WKWebProcessPlugInLoadDelegate.

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-01-17
Reviewed by Sam Weinig.

Add more WKWebProcessPlugInLoadDelegate callback methods so that a injected
bundle can listen/react to more frame loading events.

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h: Add more delegate callback methods for

WKWebProcessPlugInLoadDelegate.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(didCommitLoadForFrame):
(didFinishDocumentLoadForFrame):
(didFailLoadWithErrorForFrame):
(didSameDocumentNavigationForFrame):
(didLayoutForFrame):
(setUpPageLoaderClient):

8:00 AM Changeset in webkit [162202] by Michał Pakuła vel Rutka
  • 5 edits in trunk/LayoutTests

Unreviewed EFL gardening

  • platform/efl/js/dom/dom-static-property-for-in-iteration-expected.txt: Rebaseline after r153772 and r154057.
  • platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Rebaseline after r153772 and r154127.
  • platform/efl/js/dom/global-constructors-attributes-expected.txt: Ditto.
  • platform/efl/js/dom/global-constructors-attributes-shared-worker-expected.txt: Ditto.
6:37 AM Changeset in webkit [162201] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore

[GTK] WebKitGtk/testcopyandpaste fails in debug builds
https://bugs.webkit.org/show_bug.cgi?id=127173

Reviewed by Carlos Garcia Campos.

Remove duplicate "PasteGlobalSelection" entry.

  • editing/EditorCommand.cpp:

(WebCore::createCommandMap):

6:32 AM Changeset in webkit [162200] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Pack ResourceRequest harder.
<https://webkit.org/b/126982>

Re-arrange the members of ResourceRequest to reduce padding,
shrinking it by 8 bytes.

Reviewed by Anders Carlsson.

  • platform/network/ResourceRequestBase.h:

(WebCore::ResourceRequestBase::ResourceRequestBase):

6:04 AM Changeset in webkit [162199] by berto@igalia.com
  • 2 edits in trunk/Tools

[GTK] Test /webkit/webview/icon-uri times out in GTK Linux 64-bit Release bot
https://bugs.webkit.org/show_bug.cgi?id=82328

Reviewed by Carlos Garcia Campos.

This was caused by the icon database being corrupted in the
Release bot. After removing it the test works fine so it can be
run again.

  • Scripts/run-gtk-tests:

(TestRunner):

4:24 AM Changeset in webkit [162198] by commit-queue@webkit.org
  • 60 edits in trunk/Source

Remove workaround for compilers not supporting deleted functions
https://bugs.webkit.org/show_bug.cgi?id=127166

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2014-01-17
Reviewed by Andreas Kling.

Source/JavaScriptCore:

  • inspector/InspectorAgentRegistry.h:

Source/WebCore:

  • bindings/js/JSLazyEventListener.h:
  • dom/ContainerNode.h:
  • dom/Document.h:
  • dom/Element.h:
  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.h:
  • rendering/RenderButton.h:
  • rendering/RenderCombineText.h:
  • rendering/RenderElement.h:
  • rendering/RenderFieldset.h:
  • rendering/RenderFileUploadControl.h:
  • rendering/RenderFrame.h:
  • rendering/RenderFrameBase.h:
  • rendering/RenderFrameSet.h:
  • rendering/RenderHTMLCanvas.h:
  • rendering/RenderIFrame.h:
  • rendering/RenderLineBreak.h:
  • rendering/RenderListBox.h:
  • rendering/RenderListMarker.h:
  • rendering/RenderMedia.h:
  • rendering/RenderMenuList.h:
  • rendering/RenderSnapshottedPlugIn.h:
  • rendering/RenderTableCell.h:
  • rendering/RenderTableRow.h:
  • rendering/RenderTableSection.h:
  • rendering/RenderText.h:
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.h:
  • rendering/RenderVideo.h:
  • rendering/RenderWidget.h:
  • rendering/svg/RenderSVGBlock.h:
  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGImage.h:
  • rendering/svg/RenderSVGInline.h:
  • rendering/svg/RenderSVGRect.h:
  • rendering/svg/RenderSVGResourceClipper.h:
  • rendering/svg/RenderSVGResourceFilter.h:
  • rendering/svg/RenderSVGResourceFilterPrimitive.h:
  • rendering/svg/RenderSVGResourceGradient.h:
  • rendering/svg/RenderSVGResourceLinearGradient.h:
  • rendering/svg/RenderSVGResourceMarker.h:
  • rendering/svg/RenderSVGResourceMasker.h:
  • rendering/svg/RenderSVGResourcePattern.h:
  • rendering/svg/RenderSVGResourceRadialGradient.h:
  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGShape.h:
  • rendering/svg/RenderSVGTSpan.h:
  • rendering/svg/RenderSVGText.h:
  • rendering/svg/RenderSVGTextPath.h:
  • rendering/svg/RenderSVGTransformableContainer.h:
  • rendering/svg/RenderSVGViewportContainer.h:
  • xml/XPathValue.h:

Source/WTF:

  • wtf/Compiler.h:
  • wtf/Noncopyable.h:
  • wtf/PassRefPtr.h:
3:46 AM WebKitGTK/2.2.x edited by ltilve@igalia.com
(diff)
3:02 AM Changeset in webkit [162197] by zandobersek@gmail.com
  • 5 edits in trunk/Source/WebCore

[ATK] Modernize the for loops in ATK AX code
https://bugs.webkit.org/show_bug.cgi?id=127120

Reviewed by Mario Sanchez Prada.

Update the for loops to be range-based in ATK accessibility code.
This work is complementary to r161979.

  • accessibility/atk/WebKitAccessibleInterfaceHypertext.cpp:

(webkitAccessibleHypertextGetLink):

  • accessibility/atk/WebKitAccessibleInterfaceTable.cpp:

(webkitAccessibleTableGetColumnHeader):
(webkitAccessibleTableGetRowHeader):

  • accessibility/atk/WebKitAccessibleUtil.cpp:

(accessibilityTitle):
(accessibilityDescription):

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(getNChildrenForTable):
(getChildForTable):
(getIndexInParentForCellInRow):

1:41 AM Changeset in webkit [162196] by Michał Pakuła vel Rutka
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening

Fix wrong test expectations added in r162128.

  • platform/efl-wk2/TestExpectations:
1:23 AM Changeset in webkit [162195] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Build fix. Skip HTML files that are not tests.

  • Skipped:
1:18 AM Changeset in webkit [162194] by g.czajkowski@samsung.com
  • 9 edits in trunk/LayoutTests

Allow grammar checking tests to be able to run asynchronously
https://bugs.webkit.org/show_bug.cgi?id=127099

Reviewed by Ryosuke Niwa.

Some grammar checking tests have already used asynchronous text checking path.
Due to WebKit tends to use asynchronous spell checking, this patch adapts grammar
checking tests that used synchronous path to be able to run asynchronously.

Additionally, the tests description was fixed.

  • editing/spelling/grammar-edit-word-expected.txt:
  • editing/spelling/grammar-edit-word.html:
  • editing/spelling/grammar-expected.txt:
  • editing/spelling/grammar-markers.html:
  • editing/spelling/grammar.html:
  • editing/spelling/markers-expected.txt:
  • editing/spelling/markers.html:
  • platform/mac-wk2/TestExpectations:

Marking markers.html as failing for mac-wk2 due to bug 125690.

1:15 AM Changeset in webkit [162193] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

[Soup] Remove unnecessary using-directives for the std namespace
https://bugs.webkit.org/show_bug.cgi?id=127122

Reviewed by Martin Robinson.

  • platform/network/soup/ResourceRequestSoup.cpp: Remove the unnecessary using-directive for the std namespace

as no symbols from that namespace are in use in this implementation file.

  • platform/network/soup/ResourceResponseSoup.cpp: Ditto.
12:16 AM Changeset in webkit [162192] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r162185, r162186, and r162187.
http://trac.webkit.org/changeset/162185
http://trac.webkit.org/changeset/162186
http://trac.webkit.org/changeset/162187
https://bugs.webkit.org/show_bug.cgi?id=127164

Broke JSStringCreateWithCharactersNoCopy, as evidenced by a
JSC API test (Requested by ap on #webkit).

  • API/JSStringRef.cpp:

(JSStringGetCharactersPtr):
(JSStringGetUTF8CString):
(JSStringIsEqual):

  • API/JSStringRefCF.cpp:

(JSStringCreateWithCFString):
(JSStringCopyCFString):

  • API/OpaqueJSString.cpp:

(OpaqueJSString::create):
(OpaqueJSString::identifier):

  • API/OpaqueJSString.h:

(OpaqueJSString::create):
(OpaqueJSString::characters):
(OpaqueJSString::deprecatedCharacters):
(OpaqueJSString::OpaqueJSString):

Note: See TracTimeline for information about the timeline view.