Timeline



Jan 19, 2014:

11:25 PM Changeset in webkit [162305] by jinwoo7.song@samsung.com
  • 2 edits in trunk/Source/WebCore

Use unsigned type for the size of CSSParserValueList
​https://bugs.webkit.org/show_bug.cgi?id=127211

Reviewed by Andreas Kling.

  • css/CSSParser.cpp: Changed variable type from int to unsigned.

(WebCore::CSSParser::parseValue):

11:03 PM Changeset in webkit [162304] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebKit2

Unreviewed GTK build fix after r162276.

Updating the WorkQueue implementation to use std::function and std::chrono.

  • Platform/WorkQueue.h:
  • Platform/gtk/WorkQueueGtk.cpp:

(WorkQueue::dispatchOnSource):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfter):

10:44 PM Changeset in webkit [162303] by ryuan.choi@samsung.com
  • 8 edits in trunk

[EFL][WK1] Remove and refactor the APIs which use single and base keyword
​https://bugs.webkit.org/show_bug.cgi?id=127214

Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

Since removed ewk_vie_tiled, we don't need to use single or base in the API name.
Removed them and clean up the code.

  • ewk/ewk_view.cpp:

(ewk_view_smart_set):
(_ewk_view_smart_class_new):
(ewk_view_add):

  • ewk/ewk_view.h:
  • ewk/ewk_view_private.h:

Removed the class names and macro to distinguish single or tiled.

  • tests/UnitTestUtils/EWKTestView.cpp:

(EWKUnitTests::EWKTestView::init):

Tools:

Followed the changes of API.

  • DumpRenderTree/efl/DumpRenderTreeView.cpp:

(drtViewAdd):

  • EWebLauncher/main.c:

(windowCreate):

10:34 PM Changeset in webkit [162302] by eunmi15.lee@samsung.com
  • 2 edits in trunk/Tools

[EFL][WK2] Add touch events option to MiniBrowser.
​https://bugs.webkit.org/show_bug.cgi?id=127262

Reviewed by Gyuyoung Kim.

As a default, touch events are disabled and mouse events are enabled.
If touch events option sets to true, touch events are enabled and mouse
events are disabled.

  • MiniBrowser/efl/main.c:

(window_create):
(elm_main):

8:42 PM Changeset in webkit [162301] by jinwoo7.song@samsung.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed debug build fix on EFL port after r162300.

  • Platform/efl/DispatchQueueWorkItemEfl.h:

(TimerWorkItem::create):

8:13 PM Changeset in webkit [162300] by jinwoo7.song@samsung.com
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] build fix after r162276
​https://bugs.webkit.org/show_bug.cgi?id=127259

Reviewed by Anders Carlsson.

  • Platform/efl/DispatchQueueEfl.cpp:

(DispatchQueue::performTimerWork):
(DispatchQueue::getNextTimeOut):

  • Platform/efl/DispatchQueueWorkItemEfl.h:

(WorkItem::create):
(WorkItem::WorkItem):
(TimerWorkItem::create):
(TimerWorkItem::TimerWorkItem):

  • Platform/efl/WorkQueueEfl.cpp:

(WorkQueue::dispatch):
(WorkQueue::dispatchAfter):

5:26 PM Changeset in webkit [162299] by fpizlo@apple.com
  • 6 edits
    2 adds in branches/jsCStack/Source/JavaScriptCore

FTL should ascribe range meta-data when loading array.length
​https://bugs.webkit.org/show_bug.cgi?id=126543

Not yet reviewed.

The main thing this accomplishes is we now have Output::load32NonNegative() which is
a 32-bit integer load that promises that the value is not negative. We then use that
for all length loads.

But underneath that, we have the notion of ValueRange, which is a simplified
encapsulation of LLVM "range" metadata.

I considered making the range meta-data part of AbstractHeap. It would make sense
there. But considering that we just use this for basically one thing (the length), it
feels like conflating this with the AbstractHeap would result in some
overengineering. We should revisit this if we ever have other ranges.

(JSC::FTL::CommonValues::CommonValues):

  • ftl/FTLCommonValues.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileGetArrayLength):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::compileStringCharAt):
(JSC::FTL::LowerDFGToLLVM::compileStringCharCodeAt):
(JSC::FTL::LowerDFGToLLVM::compileSwitch):
(JSC::FTL::LowerDFGToLLVM::typedArrayLength):
(JSC::FTL::LowerDFGToLLVM::boolify):
(JSC::FTL::LowerDFGToLLVM::contiguousPutByValOutOfBounds):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::ascribeRange):
(JSC::FTL::Output::nonNegative32):
(JSC::FTL::Output::load32NonNegative):

  • ftl/FTLValueRange.cpp: Added.

(JSC::FTL::ValueRange::decorateInstruction):

  • ftl/FTLValueRange.h: Added.

(JSC::FTL::ValueRange::ValueRange):
(JSC::FTL::ValueRange::begin):
(JSC::FTL::ValueRange::end):

5:18 PM Changeset in webkit [162298] by ljaehun.lim@samsung.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r162293

Fix debug build.

[ 13%] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/html/parser/HTMLTreeBuilder.cpp.o
/source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp: In member function ‘void WebCore::HTMLTreeBuilder::processStartTagForInTable(WebCore::AtomicHTMLToken*)’:
/source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:1037:40: error: no match for ‘operator!’ in ‘!(WebCore::HTMLTreeBuilder::InsertionMode)12’
/source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:1037:40: note: candidate is:
/source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:1037:40: note: operator!(bool) <built-in>
/source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:1037:40: note: no known conversion for argument 1 from ‘WebCore::HTMLTreeBuilder::InsertionMode’ to ‘bool’
make[2]: * [Source/WebCore/CMakeFiles/WebCore.dir/html/parser/HTMLTreeBuilder.cpp.o] Error 1
make[1]: * [Source/WebCore/CMakeFiles/WebCore.dir/all] Error 2
make: * [all] Error 2

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTagForInTable): Fix ASSERT.

4:07 PM Changeset in webkit [162297] by Alan Bujtas
  • 3 edits in trunk/Tools

Pretty print LayoutUnit, LayoutPoint, and LayoutSize in lldb and gdb.
​https://bugs.webkit.org/show_bug.cgi?id=126080

Reviewed by Sam Weinig.

This changes the output of printing LayoutUnits to be in px but it also
preserves the original LayoutUnit value.

This will lead to lldb output like: (and it works even when subpixel is disabled)

(const WebCore::LayoutRect) $0 = {

m_location = { x = 2.25px (144), y = 1px (64)}
m_size = { width = 13.75px (880), height = 20px (1280) }

And gdb output like:

m_frameRect = {

m_location = LayoutPoint(0px (0), 0px(0)),
m_size = LayoutSize(8px (512), 5px (320))

}

This patch is based on patch by Bem Jones-Bey and for Blink by ​cbiesinger@chromium.org.

  • gdb/webkit.py:

(WebCoreLayoutUnitPrinter):
(WebCoreLayoutUnitPrinter.init):
(WebCoreLayoutUnitPrinter.to_string):
(WebCoreLayoutSizePrinter):
(WebCoreLayoutSizePrinter.init):
(WebCoreLayoutSizePrinter.to_string):
(WebCoreLayoutPointPrinter):
(WebCoreLayoutPointPrinter.init):
(WebCoreLayoutPointPrinter.to_string):
(add_pretty_printers):

  • lldb/lldb_webkit.py:

(lldb_init_module):
(WebCoreLayoutUnit_SummaryProvider):
(WebCoreLayoutSize_SummaryProvider):
(WebCoreLayoutPoint_SummaryProvider):
(WebCoreLayoutUnitProvider):
(WebCoreLayoutUnitProvider.init):
(WebCoreLayoutUnitProvider.to_string):
(WebCoreLayoutSizeProvider):
(WebCoreLayoutSizeProvider.init):
(WebCoreLayoutSizeProvider.get_width):
(WebCoreLayoutSizeProvider.get_height):
(WebCoreLayoutPointProvider):
(WebCoreLayoutPointProvider.init):
(WebCoreLayoutPointProvider.get_x):
(WebCoreLayoutPointProvider.get_y):

12:37 PM Changeset in webkit [162296] by andersca@apple.com
  • 17 edits in trunk/Source/WebCore

Stop using MutexTryLocker in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=127254

Reviewed by Andreas Kling.

Instead use std::mutex and std::unique_lock with the std::try_to_lock constructor.

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::process):
(WebCore::AudioBufferSourceNode::setBuffer):

  • Modules/webaudio/AudioBufferSourceNode.h:
  • Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::insertEvent):
(WebCore::AudioParamTimeline::cancelScheduledValues):
(WebCore::AudioParamTimeline::valueForContextTime):
(WebCore::AudioParamTimeline::valuesForTimeRange):
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):

  • Modules/webaudio/AudioParamTimeline.h:
  • Modules/webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::process):
(WebCore::ConvolverNode::reset):
(WebCore::ConvolverNode::setBuffer):

  • Modules/webaudio/ConvolverNode.h:
  • Modules/webaudio/MediaElementAudioSourceNode.cpp:

(WebCore::MediaElementAudioSourceNode::setFormat):
(WebCore::MediaElementAudioSourceNode::process):
(WebCore::MediaElementAudioSourceNode::lock):
(WebCore::MediaElementAudioSourceNode::unlock):

  • Modules/webaudio/MediaElementAudioSourceNode.h:
  • Modules/webaudio/MediaStreamAudioSourceNode.cpp:

(WebCore::MediaStreamAudioSourceNode::setFormat):
(WebCore::MediaStreamAudioSourceNode::process):

  • Modules/webaudio/MediaStreamAudioSourceNode.h:
  • Modules/webaudio/OscillatorNode.cpp:

(WebCore::OscillatorNode::process):
(WebCore::OscillatorNode::setPeriodicWave):

  • Modules/webaudio/OscillatorNode.h:
  • Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::process):
(WebCore::PannerNode::setPanningModel):

  • Modules/webaudio/PannerNode.h:
  • Modules/webaudio/WaveShaperProcessor.cpp:

(WebCore::WaveShaperProcessor::setCurve):
(WebCore::WaveShaperProcessor::setOversample):
(WebCore::WaveShaperProcessor::process):

  • Modules/webaudio/WaveShaperProcessor.h:
11:13 AM Changeset in webkit [162295] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore

Does not build with SVG disabled
​https://bugs.webkit.org/show_bug.cgi?id=127248

Reviewed by Sam Weinig.

Add missing #if ENABLE(SVG) guard.

  • dom/ElementData.h:
11:00 AM Changeset in webkit [162294] by Alan Bujtas
  • 3 edits in trunk/LayoutTests

Unreviewed Apple Windows port gardering.

A few more missing newlines.

  • platform/win/svg/batik/masking/maskRegions-expected.txt:
  • platform/win/svg/batik/text/textPosition-expected.txt:
11:00 AM Changeset in webkit [162293] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Use a strong enum for HTMLTreeBuilder::InsertionMode
​https://bugs.webkit.org/show_bug.cgi?id=127252

Reviewed by Antti Koivisto.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::constructTree):
(WebCore::HTMLTreeBuilder::processDoctypeToken):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processTemplateStartTag):
(WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
(WebCore::HTMLTreeBuilder::closeTheCell):
(WebCore::HTMLTreeBuilder::processStartTagForInTable):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processBodyEndTagForInBody):
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody):
(WebCore::HTMLTreeBuilder::processEndTagForInRow):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processCaptionEndTagForInCaption):
(WebCore::HTMLTreeBuilder::processTrEndTagForInRow):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processComment):
(WebCore::HTMLTreeBuilder::processCharacterBuffer):
(WebCore::HTMLTreeBuilder::processEndOfFile):
(WebCore::HTMLTreeBuilder::defaultForInitial):
(WebCore::HTMLTreeBuilder::defaultForBeforeHTML):
(WebCore::HTMLTreeBuilder::processStartTagForInHead):
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag):
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):

  • html/parser/HTMLTreeBuilder.h:
10:42 AM Changeset in webkit [162292] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Convert LoaderRunLoopCF.cpp and WebCoreThreadRun.cpp over to modern threading primitives
​https://bugs.webkit.org/show_bug.cgi?id=127251

Reviewed by Antti Koivisto.

Also add a condition to the loaderRunLoop() function to protect against spurious wake-ups.

  • platform/ios/wak/WebCoreThreadRun.cpp:
  • platform/network/cf/LoaderRunLoopCF.cpp:

(WebCore::loaderRunLoopMutex):
(WebCore::loaderRunLoopConditionVariable):
(WebCore::runLoaderThread):
(WebCore::loaderRunLoop):

10:20 AM Changeset in webkit [162291] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Modernize ReverbConvolver
​https://bugs.webkit.org/show_bug.cgi?id=127250

Reviewed by Andreas Kling.

Use std::unique_ptr instead of OwnPtr and the STL threading primitives instead of the WTF ones.

  • platform/audio/ReverbConvolver.cpp:

(WebCore::ReverbConvolver::ReverbConvolver):
(WebCore::ReverbConvolver::~ReverbConvolver):
(WebCore::ReverbConvolver::backgroundThreadEntry):
(WebCore::ReverbConvolver::process):

  • platform/audio/ReverbConvolver.h:

Jan 18, 2014:

10:53 PM Changeset in webkit [162290] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Rename GestureEventIOS.{cpp,h} to GestureEvent.{cpp,h} to fix the build

InFilesCompiler.pm assumes that <interface name>.h exists for each
interface it processes. We renamed GestureEvent.h to GestureEventIOS.h
but kept the interface named GestureEvent, so a non-existant file was
being referenced by InFilesCompiler.pm (this was hard to detect since
GestureEvent.h still existed in the SDK due to not having submitted
WebKitAdditions recently).

Since we cannot rename the GestureEvent interface, and since there is
no conflicting GestureEvent in open source, we can just rename
GestureEventIOS.{cpp,h} back to GestureEvent.{cpp,h}.

  • dom/ios/TouchEvents.cpp: Updated to include GestureEvent.cpp.
10:47 PM Changeset in webkit [162289] by ap@apple.com
  • 2 edits in trunk/Tools

Add robots.txt to ​http://webkit-queues.appspot.com
​https://bugs.webkit.org/show_bug.cgi?id=127240

  • QueueStatusServer/app.yaml: Added required "upload" attribute for robots.txt.
10:43 PM Changeset in webkit [162288] by ap@apple.com
  • 2 edits
    1 add in trunk/Tools

Add robots.txt to ​http://webkit-queues.appspot.com
​https://bugs.webkit.org/show_bug.cgi?id=127240

Reviewed by Ryosuke Niwa.

  • QueueStatusServer/app.yaml: Added robots.txt as a static file. Updated version.
  • QueueStatusServer/robots.txt: Added.
10:39 PM Changeset in webkit [162287] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Memory leak in JSSubtleCrypto::wrapKey
​https://bugs.webkit.org/show_bug.cgi?id=127241

Reviewed by Sam Weinig.

  • bindings/js/JSSubtleCryptoCustom.cpp: (WebCore::JSSubtleCrypto::wrapKey):

Delete algorithmPtr and parametersPtr that aren't smart pointers because of lambdas.

9:16 PM Changeset in webkit [162286] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the iOS Production build.

  • Configurations/WebCore.xcconfig:
6:32 PM Changeset in webkit [162285] by Alan Bujtas
  • 48 edits in trunk/LayoutTests

Unreviewed Apple Windows port gardering.

Add missing newlines.

  • platform/win/css1/box_properties/margin_right-expected.txt:
  • platform/win/css1/box_properties/padding-expected.txt:
  • platform/win/css1/box_properties/padding_left-expected.txt:
  • platform/win/css1/box_properties/padding_right-expected.txt:
  • platform/win/css1/box_properties/padding_top-expected.txt:
  • platform/win/css1/font_properties/font-expected.txt:
  • platform/win/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/win/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
  • platform/win/css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt:
  • platform/win/css2.1/t0804-c5509-padn-l-00-b-ag-expected.txt:
  • platform/win/css2.1/t0804-c5510-padn-00-b-ag-expected.txt:
  • platform/win/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
  • platform/win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
  • platform/win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
  • platform/win/fast/borders/bidi-012-expected.txt:
  • platform/win/fast/css/empty-pseudo-class-expected.txt:
  • platform/win/fast/css/fieldset-display-row-expected.txt:
  • platform/win/fast/css/first-child-pseudo-class-expected.txt:
  • platform/win/fast/css/last-child-pseudo-class-expected.txt:
  • platform/win/fast/css/only-child-pseudo-class-expected.txt:
  • platform/win/fast/forms/file/file-input-disabled-expected.txt:
  • platform/win/fast/inline/inline-box-background-expected.txt:
  • platform/win/fast/inline/inline-box-background-long-image-expected.txt:
  • platform/win/fast/inline/inline-box-background-repeat-x-expected.txt:
  • platform/win/fast/inline/inline-box-background-repeat-y-expected.txt:
  • platform/win/fast/lists/003-vertical-expected.txt:
  • platform/win/fast/multicol/vertical-rl/float-multicol-expected.txt:
  • platform/win/fast/multicol/vertical-rl/nested-columns-expected.txt:
  • platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
  • platform/win/svg/batik/filters/feTile-expected.txt:
  • platform/win/svg/batik/masking/maskRegions-expected.txt:
  • platform/win/svg/batik/paints/gradientLimit-expected.txt:
  • platform/win/svg/batik/text/textDecoration-expected.txt:
  • platform/win/svg/batik/text/textEffect-expected.txt:
  • platform/win/svg/batik/text/textLength-expected.txt:
  • platform/win/svg/batik/text/textPosition-expected.txt:
  • platform/win/svg/batik/text/verticalText-expected.txt:
  • platform/win/transforms/2d/hindi-rotated-expected.txt:
5:11 PM Changeset in webkit [162284] by akling@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

CodeBlock: Size m_callLinkInfos and m_byValInfos to fit earlier.
<​https://webkit.org/b/127239>

Reviewed by Anders Carlsson.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::setNumberOfByValInfos):
(JSC::CodeBlock::setNumberOfCallLinkInfos):

Use resizeToFit() instead of grow() for these vectors, since
we know the final size here.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::shrinkToFit):

No need to shrink here anymore. We were not even shrinking
m_byValInfo before!

3:59 PM Changeset in webkit [162283] by berto@igalia.com
  • 2 edits in trunk/Tools

Tools/Scripts/test-webkitperl fails: 'tempdir' can't be called as a method
​https://bugs.webkit.org/show_bug.cgi?id=127217

Reviewed by Daniel Bates.

The syntax File::Temp->tempdir() was explicitly made invalid
following <​https://github.com/Perl-Toolchain-Gang/File-Temp/commit/c8920b2161ab6900a09e02b9410e0e4c3d74f565>
which was included in File::Temp v2.30, shipped with Perl v5.18.0.

Use File::Temp::tempdir() instead.

  • Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3:55 PM Changeset in webkit [162282] by Alan Bujtas
  • 27 edits
    26 adds in trunk/LayoutTests

Unreviewed Apple Windows port gardering.

Rebaseline subpixel layout results.

  • platform/win/TestExpectations:
  • platform/win/css1/box_properties/margin_right-expected.txt: Added.
  • platform/win/css1/box_properties/padding-expected.txt: Added.
  • platform/win/css1/box_properties/padding_left-expected.txt: Added.
  • platform/win/css1/box_properties/padding_right-expected.txt: Added.
  • platform/win/css1/box_properties/padding_top-expected.txt: Added.
  • platform/win/css1/font_properties/font-expected.txt:
  • platform/win/css1/formatting_model/vertical_formatting-expected.txt: Added.
  • platform/win/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt: Added.
  • platform/win/css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt: Added.
  • platform/win/css2.1/t0804-c5509-padn-l-00-b-ag-expected.txt: Added.
  • platform/win/css2.1/t0804-c5510-padn-00-b-ag-expected.txt: Added.
  • platform/win/css2.1/t0905-c414-flt-wrap-00-e-expected.txt: Added.
  • platform/win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
  • platform/win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
  • platform/win/fast/borders/bidi-012-expected.txt:
  • platform/win/fast/css/empty-pseudo-class-expected.txt: Added.
  • platform/win/fast/css/fieldset-display-row-expected.txt: Added.
  • platform/win/fast/css/first-child-pseudo-class-expected.txt: Added.
  • platform/win/fast/css/last-child-pseudo-class-expected.txt: Added.
  • platform/win/fast/css/only-child-pseudo-class-expected.txt: Added.
  • platform/win/fast/forms/file/file-input-disabled-expected.txt:
  • platform/win/fast/forms/range/slider-mouse-events-expected.txt:
  • platform/win/fast/inline/inline-box-background-expected.txt:
  • platform/win/fast/inline/inline-box-background-long-image-expected.txt:
  • platform/win/fast/inline/inline-box-background-repeat-x-expected.txt:
  • platform/win/fast/inline/inline-box-background-repeat-y-expected.txt:
  • platform/win/fast/lists/003-vertical-expected.txt:
  • platform/win/fast/multicol/vertical-rl/float-multicol-expected.txt:
  • platform/win/fast/multicol/vertical-rl/nested-columns-expected.txt:
  • platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
  • platform/win/svg/batik/filters/feTile-expected.txt: Added.
  • platform/win/svg/batik/masking/maskRegions-expected.txt: Added.
  • platform/win/svg/batik/paints/gradientLimit-expected.txt:
  • platform/win/svg/batik/text/textDecoration-expected.txt: Added.
  • platform/win/svg/batik/text/textEffect-expected.txt: Added.
  • platform/win/svg/batik/text/textLength-expected.txt: Added.
  • platform/win/svg/batik/text/textPosition-expected.txt: Added.
  • platform/win/svg/batik/text/verticalText-expected.txt: Added.
  • platform/win/transforms/2d/hindi-rotated-expected.txt:
3:35 PM Changeset in webkit [162281] by akling@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

CodeBlock: Size m_function{Exprs,Decls} to fit from creation.
<​https://webkit.org/b/127238>

Reviewed by Anders Carlsson.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

Use resizeToFit() instead of grow() for m_functionExprs and
m_functionDecls since we know they will never change size.

(JSC::CodeBlock::shrinkToFit):

No need to shrink them here anymore.

3:31 PM Changeset in webkit [162280] by berto@igalia.com
  • 19 edits in trunk/Source/WebCore

[CodeGeneratorJS] Sort output of StructureFlags and function parameters

​https://bugs.webkit.org/show_bug.cgi?id=127226

Reviewed by Alexey Proskuryakov.

The order of the keys in a hash is undefined and subject to change
between different Perl versions, so we have to sort them to make
sure that the output is always the same.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateParametersCheckExpression):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.h:
  • bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
  • bindings/scripts/test/JS/JSTestEventConstructor.h:
  • bindings/scripts/test/JS/JSTestEventTarget.h:
  • bindings/scripts/test/JS/JSTestException.h:
  • bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
  • bindings/scripts/test/JS/JSTestNamedConstructor.h:
  • bindings/scripts/test/JS/JSTestNode.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionOverloadedMethod):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/JS/JSTestTypedefs.h:
  • bindings/scripts/test/JS/JSattribute.h:
  • bindings/scripts/test/JS/JSreadonly.h:
3:20 PM Changeset in webkit [162279] by akling@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Remove unused CodeBlock::m_additionalIdentifiers member.
<​https://webkit.org/b/127237>

Reviewed by Anders Carlsson.

  • bytecode/CodeBlock.h:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::shrinkToFit):

Remove m_additionalIdentifiers, nothing uses it.

3:10 PM Changeset in webkit [162278] by akling@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Remove two unused CodeBlock functions.
<​https://webkit.org/b/127235>

Kill copyPostParseDataFrom() and copyPostParseDataFromAlternative()
since they are not used.

Reviewed by Anders Carlsson.

  • bytecode/CodeBlock.cpp:
  • bytecode/CodeBlock.h:
3:09 PM Changeset in webkit [162277] by akling@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

CodeBlock: Size m_exceptionHandlers to fit from creation.
<​https://webkit.org/b/127234>

Avoid allocation churn for CodeBlock::m_exceptionHandlers.

Reviewed by Anders Carlsson.

  • bytecode/CodeBlock.h:

Removed unused CodeBlock::allocateHandlers() function.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

Use resizeToFit() instead of grow() for m_exceptionHandlers
since we know it's never going to change size.

(JSC::CodeBlock::shrinkToFit):

No need to shrink m_exceptionHandlers here since it's already
the perfect size.

3:00 PM Changeset in webkit [162276] by andersca@apple.com
  • 15 edits in trunk/Source

Replace a couple of uses of WTF::Function with std::function
​https://bugs.webkit.org/show_bug.cgi?id=127218

Reviewed by Andreas Kling.

Source/WebCore:

  • WebCore.exp.in:
  • page/scrolling/ScrollingThread.cpp:

(WebCore::ScrollingThread::dispatch):
(WebCore::ScrollingThread::dispatchBarrier):
(WebCore::ScrollingThread::shared):
(WebCore::ScrollingThread::createThreadIfNeeded):
(WebCore::ScrollingThread::dispatchFunctionsFromScrollingThread):

  • page/scrolling/ScrollingThread.h:
  • page/scrolling/mac/ScrollingThreadMac.mm:

(WebCore::ScrollingThread::initializeRunLoop):

Source/WebKit2:

  • Platform/IPC/mac/ConnectionMac.cpp:

(IPC::createDataAvailableSource):

  • Platform/WorkQueue.h:
  • Platform/mac/WorkQueueMac.cpp:

(WorkQueue::dispatch):
(WorkQueue::dispatchAfter):

  • Shared/ChildProcess.cpp:

(WebKit::didCloseOnConnectionWorkQueue):

  • UIProcess/Storage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::scheduleDatabaseUpdate):

  • WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::dispatchAfterEnsuringUpdatedScrollPosition):

  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::dispatchAfterEnsuringUpdatedScrollPosition):

2:48 PM Changeset in webkit [162275] by andersca@apple.com
  • 25 edits in trunk/Source/WebCore

Modernize HTML parser code
​https://bugs.webkit.org/show_bug.cgi?id=127236

Reviewed by Andreas Kling.

  • html/parser/AtomicHTMLToken.h:
  • html/parser/CSSPreloadScanner.cpp:

(WebCore::CSSPreloadScanner::emitRule):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::detach):
(WebCore::HTMLDocumentParser::stopParsing):
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):

  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLElementStack::ElementRecord::ElementRecord):
(WebCore::HTMLElementStack::insertAbove):
(WebCore::HTMLElementStack::pushCommon):

  • html/parser/HTMLElementStack.h:

(WebCore::HTMLElementStack::ElementRecord::releaseNext):
(WebCore::HTMLElementStack::ElementRecord::setNext):

  • html/parser/HTMLMetaCharsetParser.cpp:

(WebCore::HTMLMetaCharsetParser::HTMLMetaCharsetParser):

  • html/parser/HTMLMetaCharsetParser.h:
  • html/parser/HTMLParserScheduler.h:
  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):
(WebCore::TokenPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::HTMLPreloadScanner):

  • html/parser/HTMLPreloadScanner.h:
  • html/parser/HTMLResourcePreloader.cpp:

(WebCore::HTMLResourcePreloader::takeAndPreload):
(WebCore::HTMLResourcePreloader::preload):

  • html/parser/HTMLResourcePreloader.h:

(WebCore::PreloadRequest::PreloadRequest):

  • html/parser/HTMLScriptRunner.h:
  • html/parser/HTMLToken.h:

(WebCore::HTMLToken::beginDOCTYPE):
(WebCore::HTMLToken::releaseDoctypeData):

  • html/parser/HTMLTokenizer.h:
  • html/parser/HTMLTreeBuilder.h:
  • html/parser/HTMLViewSourceParser.cpp:

(WebCore::HTMLViewSourceParser::HTMLViewSourceParser):

  • html/parser/HTMLViewSourceParser.h:
  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):

  • html/parser/XSSAuditor.h:
  • html/parser/XSSAuditorDelegate.h:

(WebCore::XSSInfo::XSSInfo):

  • loader/TextResourceDecoder.cpp:

(WebCore::TextResourceDecoder::checkForHeadCharset):
(WebCore::TextResourceDecoder::checkForMetaCharset):

  • loader/TextResourceDecoder.h:
2:17 PM Changeset in webkit [162274] by benjamin@webkit.org
  • 8 edits in trunk/Source/WebCore

Make ElementData JIT friendly
​https://bugs.webkit.org/show_bug.cgi?id=127209

Reviewed by Geoffrey Garen.

The offsets of ElementData's flags were not accessible by the JIT. This patch
refactor ElementData to use explicit flags so that they can be used from
the code generators.

  • dom/Element.cpp:

(WebCore::Element::synchronizeAllAttributes):
(WebCore::Element::synchronizeAttribute):
(WebCore::Element::attributeChanged):
(WebCore::Element::removeAttribute):

  • dom/ElementData.cpp:

(WebCore::ElementData::destroy):
(WebCore::ElementData::ElementData):
(WebCore::ShareableElementData::ShareableElementData):
(WebCore::ShareableElementData::~ShareableElementData):
(WebCore::ElementData::arraySizeAndFlagsFromOther):

  • dom/ElementData.h:

(WebCore::ElementData::hasName):
(WebCore::ElementData::isUnique):
(WebCore::ElementData::updateFlag):
(WebCore::ElementData::arraySize):
(WebCore::ElementData::setHasNameAttribute):
(WebCore::ElementData::styleAttributeIsDirty):
(WebCore::ElementData::setStyleAttributeIsDirty):
(WebCore::ElementData::presentationAttributeStyleIsDirty):
(WebCore::ElementData::setPresentationAttributeStyleIsDirty):
(WebCore::ElementData::animatedSVGAttributesAreDirty):
(WebCore::ElementData::setAnimatedSVGAttributesAreDirty):
(WebCore::ElementData::length):
(WebCore::ElementData::attributeBase):
(WebCore::ElementData::presentationAttributeStyle):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::synchronizeStyleAttributeInternal):
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::styleAttributeChanged):
(WebCore::StyledElement::inlineStyleChanged):
(WebCore::StyledElement::rebuildPresentationAttributeStyle):

  • dom/StyledElement.h:

(WebCore::StyledElement::invalidateStyleAttribute):
(WebCore::StyledElement::presentationAttributeStyle):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::synchronizeAnimatedSVGAttribute):

  • svg/SVGElement.h:

(WebCore::SVGElement::invalidateSVGAttributes):

1:24 PM Changeset in webkit [162273] by Alan Bujtas
  • 4 edits in trunk

Subpixel layout: IntRect::infiniteRect() overflows when subpixel layout is enabled.
​https://bugs.webkit.org/show_bug.cgi?id=126899

Reviewed by Tim Horton.

Use LayoutUnits when setting the infinite values on IntRect::infiniteRect() to ensure
it won't overflow later when the IntRect gets converted to LayoutRect.

Source/WebCore:

Covered by existing tests.

  • platform/graphics/IntRect.h:

(WebCore::IntRect::infiniteRect):

LayoutTests:

  • platform/mac/TestExpectations: Unskipping svg test (failed with subpixel on)
1:15 PM Changeset in webkit [162272] by andersca@apple.com
  • 7 edits
    37 deletes in trunk

Remove support for the viewsource attribute
​https://bugs.webkit.org/show_bug.cgi?id=127232

Reviewed by Andreas Kling.

Source/WebCore:

The 'viewsource' attribute on frames is nonstandard, not used by anyone (the inspector has
its own syntax highlighting) and not audited.

This patch removes parsing of the viewsource attribute and the associated tests. A subsequent
patch will remove the code as well.

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::parseAttribute):

Source/WTF:

  • wtf/FeatureDefines.h:

LayoutTests:

  • .gitattributes:
  • fast/frames/resources/viewsource-fake-image-file.png: Removed.
  • fast/frames/resources/viewsource-frame-1.html: Removed.
  • fast/frames/resources/viewsource-frame-2.html: Removed.
  • fast/frames/resources/viewsource-frame-3.html: Removed.
  • fast/frames/resources/viewsource-frame-4.html: Removed.
  • fast/frames/resources/viewsource-frame-5.html: Removed.
  • fast/frames/resources/viewsource-frame-unfinished-script.html: Removed.
  • fast/frames/resources/viewsource-frame-unfinished-textarea.html: Removed.
  • fast/frames/viewsource-attribute.html: Removed.
  • fast/frames/viewsource-empty-attribute-value-expected.txt: Removed.
  • fast/frames/viewsource-empty-attribute-value.html: Removed.
  • fast/frames/viewsource-linebreak-expected.txt: Removed.
  • fast/frames/viewsource-linebreak.html: Removed.
  • fast/frames/viewsource-link-on-href-value-expected.txt: Removed.
  • fast/frames/viewsource-link-on-href-value.html: Removed.
  • fast/frames/viewsource-on-image-file.html: Removed.
  • fast/frames/viewsource-plain-text-tags-expected.txt: Removed.
  • fast/frames/viewsource-plain-text-tags.html: Removed.
  • fast/frames/viewsource-unfinished-tags-expected.txt: Removed.
  • fast/frames/viewsource-unfinished-tags.html: Removed.
  • fast/frames/viewsource-xml-expected.txt: Removed.
  • fast/frames/viewsource-xml.html: Removed.
  • http/tests/security/resources/view-source-no-refresh.php: Removed.
  • http/tests/security/view-source-javascript-url-in-document-expected.txt: Removed.
  • http/tests/security/view-source-javascript-url-in-document.html: Removed.
  • http/tests/security/view-source-no-javascript-url-expected.txt: Removed.
  • http/tests/security/view-source-no-javascript-url.html: Removed.
  • http/tests/security/view-source-no-refresh-expected.txt: Removed.
  • http/tests/security/view-source-no-refresh.html: Removed.
  • platform/efl/fast/frames/viewsource-attribute-expected.png: Removed.
  • platform/efl/fast/frames/viewsource-attribute-expected.txt: Removed.
  • platform/efl/fast/frames/viewsource-on-image-file-expected.png: Removed.
  • platform/efl/fast/frames/viewsource-on-image-file-expected.txt: Removed.
  • platform/mac/fast/frames/viewsource-attribute-expected.png: Removed.
  • platform/mac/fast/frames/viewsource-attribute-expected.txt: Removed.
  • platform/mac/fast/frames/viewsource-on-image-file-expected.png: Removed.
  • platform/mac/fast/frames/viewsource-on-image-file-expected.txt: Removed.
  • platform/win/TestExpectations:
1:14 PM Changeset in webkit [162271] by commit-queue@webkit.org
  • 31 edits
    2 copies in trunk/Source/WebKit2

Flesh out session APIs (still not enabled at API level).
​https://bugs.webkit.org/show_bug.cgi?id=126918

Patch by Martin Hock <​mhock@apple.com> on 2014-01-18
Reviewed by Alexey Proskuryakov.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::storageSession):
(WebKit::NetworkConnectionToWebProcess::startDownload):
(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
(WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
(WebKit::NetworkConnectionToWebProcess::cookiesEnabled):
(WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue):
(WebKit::NetworkConnectionToWebProcess::getRawCookies):
(WebKit::NetworkConnectionToWebProcess::deleteCookie):

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:
  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::ensurePrivateBrowsingSession):
(WebKit::NetworkProcess::destroyPrivateBrowsingSession):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/RemoteNetworkingContext.h:
  • NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::storageSession):
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):

  • NetworkProcess/soup/RemoteNetworkingContextSoup.cpp:

(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):

  • Shared/SessionTracker.cpp: Copied from Source/WebKit2/UIProcess/APISession.cpp.

(WebKit::sessionMap):
(WebKit::identifierBase):
(WebKit::SessionTracker::getSessionMap):
(WebKit::SessionTracker::getIdentifierBase):
(WebKit::SessionTracker::session):
(WebKit::SessionTracker::destroySession):
(WebKit::SessionTracker::setIdentifierBase):

  • Shared/SessionTracker.h: Copied from Source/WebKit2/UIProcess/APISession.h.

(WebKit::SessionTracker::isEphemeralID):

  • Shared/mac/CookieStorageShim.cpp:

(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL):

  • UIProcess/APISession.cpp:

(API::generateID):
(API::Session::defaultSession):
(API::Session::legacyPrivateSession):
(API::Session::Session):
(API::Session::create):
(API::Session::isEphemeral):
(API::Session::getID):

  • UIProcess/APISession.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::setAnyPageGroupMightHavePrivateBrowsingEnabled):
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::createWebPage):

  • UIProcess/WebContext.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::sessionID):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createWebPage):

  • UIProcess/WebProcessProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setPrivateBrowsingEnabled):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::legacySessionID):
(WebKit::WebPlatformStrategies::cookiesForDOM):
(WebKit::WebPlatformStrategies::setCookiesFromDOM):
(WebKit::WebPlatformStrategies::cookiesEnabled):
(WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue):
(WebKit::WebPlatformStrategies::getRawCookies):
(WebKit::WebPlatformStrategies::deleteCookie):

  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
(WebKit::WebFrameNetworkingContext::storageSession):

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:

(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::storageSession):

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::ensurePrivateBrowsingSession):
(WebKit::WebProcess::destroyPrivateBrowsingSession):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
1:11 PM Changeset in webkit [162270] by mark.lam@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Add a hasBreakpointFlag arg to the op_debug bytecode.
​https://bugs.webkit.org/show_bug.cgi?id=127230.

Reviewed by Geoffrey Garen.

This is in anticipation of upcoming changes to support bytecode level
breakpoints. This patch adds the flag to the op_debug bytecode and
initializes it, but does not use it yet.

  • bytecode/Opcode.h:

(JSC::padOpcodeName):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitDebugHook):

  • llint/LowLevelInterpreter.asm:
12:35 PM Changeset in webkit [162269] by andersca@apple.com
  • 6 edits in trunk/Source/WebCore

XMLTreeViewer shouldn't use the view source mode
​https://bugs.webkit.org/show_bug.cgi?id=127229

Reviewed by Andreas Kling.

Add the relevant styles from view-source.css to XMLViewer.css.

  • xml/XMLTreeViewer.cpp:

(WebCore::XMLTreeViewer::transformDocumentToTreeView):

  • xml/XMLViewer.css:

(body):
(.comment):
(.tag):
(.attribute-name):
(.attribute-value):

  • xml/XMLViewer.js:

(createComment):
(createTag):
(createAttribute):

12:32 PM Changeset in webkit [162268] by BJ Burg
  • 5 edits in trunk/Source/WebKit

Another build fix attempt for Windows and EFL WebKit1.

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/efl:

  • ewk/ewk_paint_context.cpp:

(ewk_paint_context_paint_contents):

  • ewk/ewk_view.cpp:

(_ewk_view_smart_repaints_process):

12:19 PM Changeset in webkit [162267] by BJ Burg
  • 2 edits in trunk/Source/WebKit

Unreviewed build fix attempt for Windows.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
11:41 AM Changeset in webkit [162266] by berto@igalia.com
  • 3 edits in trunk/Source/JavaScriptCore

JavaScriptCore uses PLATFORM(MAC) when it means OS(DARWIN)
​https://bugs.webkit.org/show_bug.cgi?id=99683

Reviewed by Anders Carlsson.

  • jit/ThunkGenerators.cpp:
  • tools/CodeProfile.cpp:

(JSC::symbolName):
(JSC::CodeProfile::sample):

11:16 AM Changeset in webkit [162265] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Remove unused "touchDragDropEnabled" setting.
<​https://webkit.org/b/127227>

Reviewed by Sam Weinig.

  • page/Settings.in:
11:15 AM Changeset in webkit [162264] by BJ Burg
  • 44 edits in trunk/Source

Web Inspector: Page should use std::unique_ptr for InspectorController
​https://bugs.webkit.org/show_bug.cgi?id=127068

Reviewed by Joseph Pecoraro.

Source/WebCore:

Make Page and WorkerGlobalScope keep a std::unique_ptr to InspectorController
and WorkerInspectorController. Store page references and return controller
references where possible.

Convert call sites to use an InspectorController reference.
Convert instantiations of InspectorFrontendClient to use std::unique_ptr.
Convert InspectorOverlay to keep Page references.

  • WebCore.exp.in:
  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::supportsProfiling):
(WebCore::JSDOMWindowBase::supportsRichSourceInfo):

  • dom/Node.cpp:

(WebCore::Node::inspect):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
(WebCore::InspectorController::setInspectorFrontendClient):
(WebCore::InspectorController::hasInspectorFrontendClient):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::inspectedPage):
(WebCore::InspectorController::developerExtrasEnabled):

  • inspector/InspectorController.h:
  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::canAttachWindow):
(WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight):
(WebCore::InspectorFrontendClientLocal::changeAttachedWindowWidth):
(WebCore::InspectorFrontendClientLocal::openInNewTab):
(WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::InspectorOverlay):
(WebCore::InspectorOverlay::getHighlight):
(WebCore::InspectorOverlay::highlightQuad):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::buildObjectForHighlightedNode):
(WebCore::InspectorOverlay::drawQuadHighlight):
(WebCore::InspectorOverlay::overlayPage):
(WebCore::InspectorOverlay::reset):

  • inspector/InspectorOverlay.h:
  • inspector/InstrumentingAgents.cpp:

(WebCore::instrumentationForPage): remove null checks.
(WebCore::instrumentationForWorkerGlobalScope): remove null checks.

  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::connectFrontend):
(WebCore::WorkerInspectorController::disconnectFrontend):

  • inspector/WorkerInspectorController.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::showContextMenu):
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::addInspectElementItem):

  • page/FrameView.cpp:

(WebCore::FrameView::sendResizeEventIfNeeded):

  • page/Page.cpp:

(WebCore::Page::Page):

  • page/Page.h:

(WebCore::Page::inspectorController):

  • page/PageDebuggable.cpp:

(WebCore::PageDebuggable::hasLocalDebugger):
(WebCore::PageDebuggable::parentProcessIdentifier):
(WebCore::PageDebuggable::connect):
(WebCore::PageDebuggable::disconnect):
(WebCore::PageDebuggable::dispatchMessageFromRemoteFrontend):
(WebCore::PageDebuggable::setIndicating):

  • platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:

(WebCore::CompositingCoordinator::syncDisplayState):

  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::inspectorHighlightRects):
(WebCore::Internals::inspectorHighlightObject):
(WebCore::Internals::emitInspectorDidBeginFrame):
(WebCore::Internals::emitInspectorDidCancelFrame):
(WebCore::Internals::openDummyInspectorFrontend):
(WebCore::Internals::closeDummyInspectorFrontend):
(WebCore::Internals::setInspectorResourcesDataSizeLimits):
(WebCore::Internals::setJavaScriptProfilingEnabled):

  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::WorkerGlobalScope):

  • workers/WorkerGlobalScope.h: remove clearInspector().

(WebCore::WorkerGlobalScope::workerInspectorController):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::connectToWorkerGlobalScopeInspectorTask):
(WebCore::disconnectFromWorkerGlobalScopeInspectorTask):
(WebCore::dispatchOnInspectorBackendTask):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThreadShutdownFinishTask::performTask):

Source/WebKit/efl:

Convert call sites to use a InspectorController reference.
Convert instantiations of InspectorFrontendClient to use std::unique_ptr.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::evaluateInWebInspector):

  • WebCoreSupport/InspectorClientEfl.cpp:

(WebCore::InspectorClientEfl::openInspectorFrontend):

  • ewk/ewk_view.cpp:

(ewk_view_inspector_show):
(ewk_view_inspector_close):

Source/WebKit/gtk:

Convert call sites to use a InspectorController reference.
Convert instantiations of InspectorFrontendClient to use std::unique_ptr.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::paintWebView):

  • WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorClient::openInspectorFrontend):

  • webkit/webkitwebinspector.cpp:

(webkit_web_inspector_set_property):
(webkit_web_inspector_get_property):
(webkit_web_inspector_show):
(webkit_web_inspector_inspect_node):
(webkit_web_inspector_inspect_coordinates):
(webkit_web_inspector_close):
(webkit_web_inspector_execute_script):

Source/WebKit/mac:

Convert call sites to use a InspectorController reference.
Convert instantiations of InspectorFrontendClient to use std::unique_ptr.

  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::openInspectorFrontend):
(-[WebInspectorWindowController destroyInspectorView:]):

  • WebInspector/WebInspector.mm:

(-showWindow):
(-isJavaScriptProfilingEnabled):
(-setJavaScriptProfilingEnabled:):
(-close:):
(-evaluateInFrontend:callId:script:):

  • WebInspector/WebNodeHighlighter.mm:

(-[WebNodeHighlighter highlight]):

Source/WebKit/win:

Convert call sites to use a InspectorController reference.

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::openInspectorFrontend):
(WebInspectorFrontendClient::destroyInspectorView):
(WebInspectorFrontendClient::onClose):

(WebInspector::show):
(WebInspector::close):
(WebInspector::isJavaScriptProfilingEnabled):
(WebInspector::setJavaScriptProfilingEnabled):
(WebInspector::evaluateInFrontend):

  • WebNodeHighlight.cpp:

(WebNodeHighlight::update):

Source/WebKit2:

Convert call sites to use a InspectorController reference.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::drawRect):

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:

(WebKit::WebInspectorFrontendClient::WebInspectorFrontendClient):
(WebKit::WebInspectorFrontendClient::closeWindow):

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::createInspectorPage):
(WebKit::WebInspector::show):
(WebKit::WebInspector::close):
(WebKit::WebInspector::evaluateScriptForTest):
(WebKit::WebInspector::showConsole):
(WebKit::WebInspector::showResources):
(WebKit::WebInspector::showMainResourceForFrame):
(WebKit::WebInspector::startJavaScriptDebugging):
(WebKit::WebInspector::stopJavaScriptDebugging):
(WebKit::WebInspector::setJavaScriptProfilingEnabled):
(WebKit::WebInspector::startJavaScriptProfiling):
(WebKit::WebInspector::stopJavaScriptProfiling):
(WebKit::WebInspector::startPageProfiling):
(WebKit::WebInspector::stopPageProfiling):
(WebKit::WebInspector::dispatchMessageFromRemoteFrontend):
(WebKit::WebInspector::remoteFrontendConnected):
(WebKit::WebInspector::remoteFrontendDisconnected):

10:57 AM Changeset in webkit [162263] by ap@apple.com
  • 4 edits in trunk/Tools

build.webkit.org/dashboard should have image diff links in test results popovers
​https://bugs.webkit.org/show_bug.cgi?id=127188

Reviewed by Timothy Hatcher.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:

(Buildbot.prototype.layoutTestImagesURLForIteration):
(Buildbot.prototype.layoutTestImageDiffURLForIteration):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(BuildbotIteration.prototype.loadLayoutTestResults):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

(BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoLink):
(BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoText):
(BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):

10:50 AM Changeset in webkit [162262] by ap@apple.com
  • 3 edits in trunk/LayoutTests

media/video-size.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=124932

  • platform/efl/TestExpectations:
  • platform/TestExpectations:

Moving flakiness expectation to cross-platform file, as it also fails on Mac in the same way.

10:43 AM Changeset in webkit [162261] by ap@apple.com
  • 2 edits in trunk/LayoutTests

media/video-display-aspect-ratio.html fails
​https://bugs.webkit.org/show_bug.cgi?id=35297

  • platform/mac/TestExpectations: Marking as flaky.
10:42 AM Changeset in webkit [162260] by andersca@apple.com
  • 16 edits in trunk

Remove ENABLE_THREADED_HTML_PARSER defines everywhere
​https://bugs.webkit.org/show_bug.cgi?id=127225

Reviewed by Andreas Kling.

This concludes the removal of over 8.8 million lines of threaded parser code.

.:

  • Source/autotools/SetupWebKitFeatures.m4:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
10:30 AM Changeset in webkit [162259] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk/Source/WebKit2

Make WKRenderingProgressEvents a shareable API.
​https://bugs.webkit.org/show_bug.cgi?id=127213

Patch by Yongjun Zhang <​yongjun_zhang@apple.com> on 2014-01-18
Reviewed by Dan Bernstein.

Move WKRenderingProgressEvents from UIProcess to Shared, so that an inject bundle
could also use this enum when listening to layout milestones.

  • Shared/API/Cocoa/WKRenderingProgressEvents.h: Added.

(NS_OPTIONS):

  • Shared/API/Cocoa/WKRenderingProgressEventsInternal.h: Added.

(renderingProgressEvents):

  • UIProcess/API/Cocoa/WKBrowsingContextController.h: Move WKRenderingProgressEvents to Shared/API/Cocoa/WKRenderingProgressEvents.h.
  • UIProcess/API/Cocoa/WKBrowsingContextController.mm: Move renderingProgressEvents() to WKRenderingProgressEventsInternal.h.
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h: Add

webProcessPlugInBrowserContextController:renderingProgressDidChange: to load delegate.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(didLayout):
(setUpPageLoaderClient): Also listen to didLayout callback for layout milestones.

10:25 AM Changeset in webkit [162258] by andersca@apple.com
  • 11 edits in trunk/Source/WebCore

Remove the remaining threaded parser code
​https://bugs.webkit.org/show_bug.cgi?id=127224

Reviewed by Andreas Kling.

  • dom/Document.cpp:

(WebCore::Document::decrementActiveParserCount):

  • html/parser/AtomicHTMLToken.h:
  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::detach):
(WebCore::HTMLDocumentParser::stopParsing):
(WebCore::HTMLDocumentParser::prepareToStopParsing):
(WebCore::HTMLDocumentParser::resumeParsingAfterYield):
(WebCore::HTMLDocumentParser::forcePlaintextForTextDocument):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::end):
(WebCore::HTMLDocumentParser::finish):
(WebCore::HTMLDocumentParser::textPosition):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):

  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLParserIdioms.cpp:
  • html/parser/HTMLParserIdioms.h:
  • html/parser/HTMLTokenizer.cpp:
  • html/parser/HTMLTokenizer.h:
  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::isLoading):
(WebCore::DocumentLoader::checkLoadComplete):

  • page/Settings.in:
10:06 AM Changeset in webkit [162257] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Remove threaded parser code from the preload scanners
​https://bugs.webkit.org/show_bug.cgi?id=127222

Reviewed by Andreas Kling.

  • html/parser/CSSPreloadScanner.cpp:

(WebCore::CSSPreloadScanner::CSSPreloadScanner):
Use nullptr.

(WebCore::CSSPreloadScanner::scan):
Move scanCommon here and simplify the code.

  • html/parser/CSSPreloadScanner.h:

Remove scanCommon.

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::tagIdFor):
TagId is a strong enum now, update enum values.

(WebCore::TokenPreloadScanner::initiatorFor):
Ditto.

(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
Ditto.

(WebCore::TokenPreloadScanner::StartTagScanner::match):
Indent this.

(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
TagId is a strong enum now, update enum values.

(WebCore::TokenPreloadScanner::StartTagScanner::charset):
Ditto.

(WebCore::TokenPreloadScanner::StartTagScanner::resourceType):
Ditto.

(WebCore::TokenPreloadScanner::StartTagScanner::shouldPreload):
Ditto.

(WebCore::TokenPreloadScanner::scan):
Merge scan and scanCommon.

  • html/parser/HTMLPreloadScanner.h:
9:55 AM Changeset in webkit [162256] by mark.lam@apple.com
  • 9 edits
    1 add
    1 delete in trunk/Source/JavaScriptCore

Adding UnlinkedCodeBlock::opDebugBytecodeOffsetForLineAndColumn()..
​https://bugs.webkit.org/show_bug.cgi?id=127127.

Reviewed by Geoffrey Garen.

In order to implement bytecode level breakpoints, we need a mechanism
for computing the best fit op_debug bytecode offset for any valid given
line and column value in the source. The "best fit" op_debug bytecode
in this case is defined below in the comment for
UnlinkedCodeBlock::opDebugBytecodeOffsetForLineAndColumn().

(JSC::CodeBlock::opDebugBytecodeOffsetForLineAndColumn):

  • Convert the line and column to unlinked line and column values and pass them to UnlinkedCodeBlock::opDebugBytecodeOffsetForLineAndColumn() to do the real work.
  • bytecode/CodeBlock.h:
  • bytecode/LineColumnInfo.h: Added.

(JSC::LineColumnInfo::operator <):
(JSC::LineColumnInfo::LineColumnPair::LineColumnPair):
(JSC::LineColumnInfo::operator ==):
(JSC::LineColumnInfo::operator !=):
(JSC::LineColumnInfo::operator <=):
(JSC::LineColumnInfo::operator >):
(JSC::LineColumnInfo::operator >=):

  • bytecode/LineInfo.h: Removed.
  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::decodeExpressionRangeLineAndColumn):

  • Factored this out of expressionRangeForBytecodeOffset() so that it can be called from multiple places.

(JSC::dumpLineColumnEntry):
(JSC::UnlinkedCodeBlock::dumpExpressionRangeInfo):
(JSC::UnlinkedCodeBlock::dumpOpDebugLineColumnInfoList):

  • Some dumpers for debugging use only.

(JSC::UnlinkedCodeBlock::expressionRangeForBytecodeOffset):
(JSC::UnlinkedCodeBlock::opDebugBytecodeOffsetForLineAndColumn):

  • Finds the earliest op_debug bytecode whose line and column matches the specified line and column values. If an exact match is not found, then finds the nearest op_debug bytecode that precedes the specified line and column values. If there are more than one op_debug at that preceding line and column value, then the earliest of those op_debug bytecodes will be be selected. The offset of the selected bytecode will be returned.

We want the earliest one because when we have multiple op_debug bytecodes
that map to a given line and column, a debugger user would expect to break
on the first one and step through the rest thereafter if needed.

(JSC::compareLineColumnInfo):
(JSC::UnlinkedCodeBlock::opDebugLineColumnInfoList):

  • Creates the sorted opDebugLineColumnInfoList on demand. This list is stored in the UnlinkedCodeBlock's rareData.
  • bytecode/UnlinkedCodeBlock.h:
9:19 AM Changeset in webkit [162255] by akling@apple.com
  • 2 edits
    10 deletes in trunk

Remove Nix files from WebCore
​https://bugs.webkit.org/show_bug.cgi?id=127176

Patch by Lauro Neto <​lauro.neto@openbossa.org> on 2014-01-18
Reviewed by Anders Carlsson.

.:

  • Source/cmake/OptionsNix.cmake: Removed.

Source/WebCore:

  • PlatformNix.cmake: Removed.
  • css/mediaControlsNix.css: Removed.
  • css/mediaControlsNixFullscreen.css: Removed.
  • editing/nix/EditorNix.cpp: Removed.
  • page/nix/EventHandlerNix.cpp: Removed.
  • platform/audio/nix/AudioBusNix.cpp: Removed.
  • platform/audio/nix/AudioDestinationNix.cpp: Removed.
  • platform/audio/nix/AudioDestinationNix.h: Removed.
  • platform/audio/nix/FFTFrameNix.cpp: Removed.
  • platform/graphics/nix/IconNix.cpp: Removed.
  • platform/graphics/nix/ImageNix.cpp: Removed.
  • platform/nix/CursorNix.cpp: Removed.
  • platform/nix/DragDataNix.cpp: Removed.
  • platform/nix/DragImageNix.cpp: Removed.
  • platform/nix/ErrorsNix.cpp: Removed.
  • platform/nix/ErrorsNix.h: Removed.
  • platform/nix/FileSystemNix.cpp: Removed.
  • platform/nix/GamepadsNix.cpp: Removed.
  • platform/nix/LanguageNix.cpp: Removed.
  • platform/nix/LocalizedStringsNix.cpp: Removed.
  • platform/nix/MIMETypeRegistryNix.cpp: Removed.
  • platform/nix/NixKeyboardUtilities.cpp: Removed.
  • platform/nix/NixKeyboardUtilities.h: Removed.
  • platform/nix/PasteboardNix.cpp: Removed.
  • platform/nix/PlatformKeyboardEventNix.cpp: Removed.
  • platform/nix/PlatformScreenNix.cpp: Removed.
  • platform/nix/RenderThemeNix.cpp: Removed.
  • platform/nix/RenderThemeNix.h: Removed.
  • platform/nix/ScrollbarThemeNix.cpp: Removed.
  • platform/nix/ScrollbarThemeNix.h: Removed.
  • platform/nix/SharedTimerNix.cpp: Removed.
  • platform/nix/SoundNix.cpp: Removed.
  • platform/nix/TemporaryLinkStubs.cpp: Removed.
  • platform/nix/WidgetNix.cpp: Removed.
  • platform/nix/support/MultiChannelPCMData.cpp: Removed.
  • platform/text/nix/TextBreakIteratorInternalICUNix.cpp: Removed.
9:11 AM Changeset in webkit [162254] by andersca@apple.com
  • 9 edits in trunk/Source/WebCore

Remove DocumentParser::pinToMainThread() and related code
​https://bugs.webkit.org/show_bug.cgi?id=127221

Reviewed by Andreas Kling.

  • dom/Document.cpp:

(WebCore::Document::setContent):

  • dom/DocumentParser.h:
  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::HTMLDocumentParser):

  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLParserOptions.cpp:

(WebCore::HTMLParserOptions::HTMLParserOptions):

  • html/parser/HTMLParserOptions.h:
  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processEndTag):

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::replaceDocument):

9:00 AM Changeset in webkit [162253] by andersca@apple.com
  • 7 edits
    2 deletes in trunk/Source/WebCore

Remove HTMLParserThread
​https://bugs.webkit.org/show_bug.cgi?id=127220

Reviewed by Andreas Kling.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/HTMLDocumentParser.cpp:
  • html/parser/HTMLParserThread.cpp: Removed.
  • html/parser/HTMLParserThread.h: Removed.
8:50 AM Changeset in webkit [162252] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

GC soon after responding to fake memory pressure.
<​https://webkit.org/b/127210>

Ask JSC to garbage collect "soon" after handling the fake memory
pressure signal on Mac. This seems to stabilize the post-pressure
numbers on Membuster3 a bit on my laptop. The difference is mostly
made up of JSC::CodeBlock objects.

Reviewed by Geoffrey Garen.

  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::install):

8:48 AM Changeset in webkit [162251] by andersca@apple.com
  • 11 edits
    10 deletes in trunk/Source/WebCore

Remove files only used by the threaded HTML parser
​https://bugs.webkit.org/show_bug.cgi?id=127219
<rdar://problem/13331277>

Reviewed by Andreas Kling.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/AtomicHTMLToken.h:
  • html/parser/BackgroundHTMLInputStream.cpp: Removed.
  • html/parser/BackgroundHTMLInputStream.h: Removed.
  • html/parser/BackgroundHTMLParser.cpp: Removed.
  • html/parser/BackgroundHTMLParser.h: Removed.
  • html/parser/CompactHTMLToken.cpp: Removed.
  • html/parser/CompactHTMLToken.h: Removed.
  • html/parser/HTMLDocumentParser.cpp:
  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLIdentifier.cpp: Removed.
  • html/parser/HTMLIdentifier.h: Removed.
  • html/parser/HTMLParserIdioms.h:
  • html/parser/HTMLPreloadScanner.h:
  • html/parser/HTMLTreeBuilderSimulator.cpp: Removed.
  • html/parser/HTMLTreeBuilderSimulator.h: Removed.
1:04 AM Changeset in webkit [162250] by zandobersek@gmail.com
  • 3 edits in trunk/Source/JavaScriptCore

Inspector scripts are not compatible with Python v3
​https://bugs.webkit.org/show_bug.cgi?id=127128

Reviewed by Benjamin Poulain.

  • inspector/scripts/generate-combined-inspector-json.py: Turn print statements into print function calls.
  • inspector/scripts/jsmin.py: Try importing the StringIO class from the StringIO module (which will work for

Python v2) or, on import error, import the class from the io module (which will work for Python v3).

12:22 AM Changeset in webkit [162249] by zandobersek@gmail.com
  • 2 edits in trunk

[GTK] Bump the minimum required Clang version to 3.3
​https://bugs.webkit.org/show_bug.cgi?id=127178

Reviewed by Martin Robinson.

  • Source/autotools/CheckSystemAndBasicDependencies.m4: Require Clang 3.3 or later when using the Clang compiler to

build the GTK port. Building with Clang 3.2 doesn't work anymore and there's no point in fixing that, as we should
support the latest two versions of Clang (3.3 and 3.4), just like we do with GCC (4.7 and 4.8).

Note: See TracTimeline for information about the timeline view.