Timeline

Jan 22, 2014:

11:53 PM Changeset in webkit [162599] by Carlos Garcia Campos

• 135 edits
  1 copy
  1 move
  1 delete in trunk

[GLIB] Use GUniquePtr instead of GOwnPtr
​https://bugs.webkit.org/show_bug.cgi?id=127431

Reviewed by Martin Robinson.

GUniquePtr is a template alias of std::unique_ptr with a custom
deleter that replaces GOwnPtr. GOwnPtr is still used for the cases
where the output pointer is needed, but it will also be replaced soon.

Source/WebCore:

• GNUmakefile.list.am:
• PlatformGTK.cmake:
• accessibility/atk/AXObjectCacheAtk.cpp:
• accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(getAttributeSetForAccessibilityObject):
(accessibilityObjectLength):
(textExtents):
(webkitAccessibleTextGetChar):
(numberOfReplacedElementsBeforeOffset):

• page/ContextMenuController.cpp:
• platform/SharedBuffer.h:
• platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webKitWebAudioSrcConstructed):
(webKitWebAudioSrcLoop):

• platform/audio/gtk/AudioBusGtk.cpp:

(WebCore::AudioBus::loadPlatformResource):

• platform/geoclue/GeolocationProviderGeoclue.cpp:
• platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::setAudioStreamProperties):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):

• platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:

(webKitMediaSrcAddSrc):

• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcStart):
(ResourceHandleStreamingClient::wasBlocked):
(ResourceHandleStreamingClient::cannotShowURL):

• platform/graphics/gtk/ImageBufferGtk.cpp:

(WebCore::encodeImage):
(WebCore::ImageBuffer::toDataURL):

• platform/graphics/gtk/ImageGtk.cpp:

(WebCore::getThemeIconFileName):
(WebCore::Image::loadPlatformResource):

• platform/gtk/ContextMenuGtk.cpp:

(WebCore::ContextMenu::itemCount):
(WebCore::contextMenuItemVector):

• platform/gtk/ContextMenuItemGtk.cpp:

(WebCore::createPlatformMenuItemDescription):

• platform/gtk/DataObjectGtk.cpp:

(WebCore::DataObjectGtk::setURIList):
(WebCore::DataObjectGtk::setURL):

• platform/gtk/FileSystemGtk.cpp:

(WebCore::filenameToString):
(WebCore::fileSystemRepresentation):
(WebCore::filenameForDisplay):
(WebCore::pathGetFileName):
(WebCore::applicationDirectoryPath):
(WebCore::sharedResourcesPath):
(WebCore::directoryName):
(WebCore::listDirectory):
(WebCore::openTemporaryFile):

• platform/gtk/GOwnPtrGtk.cpp: Removed.
• platform/gtk/GOwnPtrGtk.h: Removed.
• platform/gtk/GUniquePtrGtk.h: Added.
• platform/gtk/GamepadsGtk.cpp:

(WebCore::GamepadsGtk::GamepadsGtk):

• platform/gtk/GtkClickCounter.cpp:

(WebCore::GtkClickCounter::shouldProcessButtonEvent):

• platform/gtk/GtkInputMethodFilter.cpp:

(WebCore::GtkInputMethodFilter::sendCompositionAndPreeditWithFakeKeyEvents):

• platform/gtk/GtkPopupMenu.cpp:

(WebCore::GtkPopupMenu::popUp):
(WebCore::GtkPopupMenu::typeAheadFind):

• platform/gtk/LanguageGtk.cpp:

(WebCore::platformLanguage):

• platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::imageTitle):
(WebCore::localizedMediaTimeDescription):

• platform/gtk/PasteboardHelper.cpp:

(WebCore::selectionDataToUTF8String):
(WebCore::PasteboardHelper::getClipboardContents):
(WebCore::PasteboardHelper::fillSelectionData):

• platform/gtk/PopupMenuGtk.cpp:

(WebCore::PopupMenuGtk::createGtkActionForMenuItem):
(WebCore::PopupMenuGtk::show):

• platform/gtk/WebKitAuthenticationWidget.cpp:

(webkitAuthenticationWidgetInitialize):

• platform/network/ResourceHandleInternal.h:
• platform/network/gtk/CredentialBackingStore.cpp:

(WebCore::credentialForChallengeAsyncReadyCallback):

• platform/network/soup/CookieJarSoup.cpp:

(WebCore::setCookiesFromDOM):
(WebCore::cookiesForSession):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
(WebCore::deleteAllCookies):

• platform/network/soup/DNSSoup.cpp:
• platform/network/soup/GUniquePtrSoup.h: Added.
• platform/network/soup/ResourceErrorSoup.cpp:

(WebCore::failingURI):

• platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::ResourceHandle::ensureReadBuffer):
(WebCore::cleanupSoupRequestOperation):
(WebCore::createSoupRequestAndMessageForHandle):

• platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateSoupMessageMembers):
(WebCore::ResourceRequest::updateSoupMessage):

• platform/network/soup/ResourceResponseSoup.cpp:
• platform/network/soup/SoupURIUtils.cpp:

(WebCore::soupURIToKURL):

• platform/soup/SharedBufferSoup.cpp:

(WebCore::SharedBuffer::SharedBuffer):
(WebCore::SharedBuffer::clearPlatformData):
(WebCore::SharedBuffer::maybeTransferPlatformData):
(WebCore::SharedBuffer::hasPlatformData):

• plugins/gtk/PluginPackageGtk.cpp:

(WebCore::PluginPackage::fetchInfo):
(WebCore::PluginPackage::load):

Source/WebKit/gtk:

• WebCoreSupport/ContextMenuClientGtk.cpp:

(WebKit::getUnicodeMenuItemPosition):

• WebCoreSupport/DragClientGtk.cpp:

(WebKit::DragClient::startDrag):

• WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setValueForUser):

• WebCoreSupport/EditorClientGtk.h:
• WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::userAgent):
(WebKit::FrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
(WebKit::FrameLoaderClient::dispatchWillSendRequest):
(WebKit::FrameLoaderClient::assignIdentifierToInitialRequest):
(WebKit::FrameLoaderClient::dispatchDidReceiveResponse):
(WebKit::FrameLoaderClient::dispatchDidReceiveContentLength):
(WebKit::FrameLoaderClient::dispatchDidFinishLoading):
(WebKit::FrameLoaderClient::dispatchDidFailLoading):
(WebKit::FrameLoaderClient::dispatchDidFailLoad):

• WebCoreSupport/InspectorClientGtk.h:
• webkit/webkitfavicondatabase.cpp:

(webkit_favicon_database_set_path):

• webkit/webkitfilechooserrequest.cpp:
• webkit/webkitglobals.cpp:

(webkitInit):

• webkit/webkithittestresult.cpp:

(WebKit::kit):

• webkit/webkiticondatabase.cpp:

(webkit_icon_database_set_path):

• webkit/webkitspellcheckerenchant.cpp:
• webkit/webkitwebplugin.cpp:

(webkit_web_plugin_get_path):

• webkit/webkitwebpluginprivate.h:
• webkit/webkitwebsettings.cpp:

(webkit_web_settings_class_init):
(webkit_web_settings_copy):

• webkit/webkitwebview.cpp:

(webkit_web_view_forward_context_menu_event):
(fileChooserDialogResponseCallback):
(webkit_web_view_drag_end):

• webkit/webkitwebviewprivate.h:

Source/WebKit2:

• Shared/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::didReceiveResponse):

• Shared/NativeWebKeyboardEvent.h:
• Shared/NativeWebMouseEvent.h:
• Shared/NativeWebWheelEvent.h:
• Shared/gtk/ArgumentCodersGtk.cpp:

(IPC::encodeGKeyFile):
(IPC::decodeGKeyFile):
(IPC::encode):
(IPC::decode):

• UIProcess/API/gtk/WebKitContextMenuItem.cpp:

(webkitContextMenuItemSetSubMenuFromGtkMenu):

• UIProcess/API/gtk/WebKitDownload.cpp:

(webkitDownloadDecideDestination):
(webkitDownloadNotifyProgress):
(webkitDownloadFailed):

• UIProcess/API/gtk/WebKitFileChooserRequest.cpp:

(webkit_file_chooser_request_select_files):

• UIProcess/API/gtk/WebKitInjectedBundleClient.cpp:

(didReceiveWebViewMessageFromInjectedBundle):
(getInjectedBundleInitializationUserData):

• UIProcess/API/gtk/WebKitLoaderClient.cpp:

(didFailProvisionalLoadWithErrorForFrame):
(didFailLoadWithErrorForFrame):

• UIProcess/API/gtk/WebKitPrintOperation.cpp:

(drawPagesForPrintingCompleted):

• UIProcess/API/gtk/WebKitURIRequest.cpp:

(webkit_uri_request_get_http_headers):

• UIProcess/API/gtk/WebKitURISchemeRequest.cpp:

(webkit_uri_scheme_request_get_scheme):
(webkit_uri_scheme_request_get_path):

• UIProcess/API/gtk/WebKitWebContext.cpp:

(injectedBundleFilename):
(webkit_web_context_set_favicon_database_directory):

• UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewLoadFail):
(webkitWebViewCreateJavaScriptDialog):
(fileChooserDialogResponseCallback):
(webkitWebViewLoadChanged):
(webkitWebViewLoadFailedWithTLSErrors):
(webkitWebViewPopulateContextMenu):

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseButtonPressEvent):
(webkitWebViewBaseStartDrag):

• UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:

(WebKit::WebInspectorServer::platformResourceForPath):

• UIProcess/InspectorServer/soup/WebSocketServerSoup.cpp:

(WebKit::connectionCallback):

• UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::ProcessLauncher::launchProcess):

• UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformDefaultApplicationCacheDirectory):
(WebKit::WebContext::platformDefaultDatabaseDirectory):
(WebKit::WebContext::platformDefaultIconDatabasePath):
(WebKit::WebContext::platformDefaultLocalStorageDirectory):
(WebKit::WebContext::platformDefaultDiskCacheDirectory):

• UIProcess/gtk/WebContextMenuProxyGtk.cpp:

(WebKit::contextMenuItemVisibilityChanged):

• UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformInspectedURLChanged):

• UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::createGtkActionForMenuItem):

• WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
• WebProcess/WebPage/gtk/WebPageGtk.cpp:

(WebKit::WebPage::platformInitialize):

• WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
• WebProcess/gtk/WebProcessMainGtk.cpp:
• WebProcess/soup/WebSoupRequestManager.cpp:

(WebKit::WebSoupRequestManager::send):

Tools:

• DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:

(printAccessibilityEvent):
(axObjectEventListener):

• DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(indexRangeInTable):
(AccessibilityUIElement::role):
(AccessibilityUIElement::title):
(AccessibilityUIElement::description):
(AccessibilityUIElement::stringValue):
(AccessibilityUIElement::language):
(AccessibilityUIElement::lineForIndex):
(AccessibilityUIElement::selectedTextRange):
(AccessibilityUIElement::url):

• DumpRenderTree/efl/AccessibilityControllerEfl.cpp:

(AccessibilityController::accessibleElementById):

• DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:

(AccessibilityController::accessibleElementById):

• DumpRenderTree/gtk/DumpRenderTree.cpp:

(getOutputDir):
(getFontsPath):
(initializeFonts):
(dumpFramesAsText):
(compareHistoryItems):
(dumpHistoryItem):
(soupURIToStringPreservingPassword):
(resetDefaultsToConsistentValues):
(temporaryDatabaseDirectory):
(webViewTitleChanged):
(webFrameLoadStatusNotified):
(pathFromSoupURI):
(convertWebResourceToURLPath):
(urlSuitableForTestResult):
(descriptionSuitableForTestResult):
(willSendRequestCallback):
(frameLoadEventCallback):

• DumpRenderTree/gtk/EditingCallbacks.cpp:

(dumpNodePath):
(dumpRange):
(shouldApplyStyle):

• DumpRenderTree/gtk/EventSender.cpp:

(contextClickCallback):
(beginDragWithFilesCallback):

• DumpRenderTree/gtk/TestRunnerGtk.cpp:

(TestRunner::pathToLocalResource):
(TestRunner::queueLoad):
(TestRunner::removeOriginAccessWhitelistEntry):
(TestRunner::setMockGeolocationPositionUnavailableError):
(TestRunner::setIconDatabaseEnabled):
(TestRunner::findString):
(TestRunner::setDomainRelaxationForbiddenForURLScheme):
(TestRunner::overridePreference):
(TestRunner::addUserScript):
(TestRunner::addUserStyleSheet):
(TestRunner::setTextDirection):

• DumpRenderTree/gtk/TextInputController.cpp:

(setMarkedTextCallback):
(insertTextCallback):
(doCommandCallback):

• DumpRenderTree/gtk/WorkQueueItemGtk.cpp:

(LoadHTMLStringItem::invoke):

• TestWebKitAPI/PlatformGTK.cmake:
• TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:

(WebKitDOMNodeTest::testTagNames):

• TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:

(testBackForwardListLimitAndCache):

• TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:

(testContextMenuSmartSeparators):

• TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
• TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:

(testDownloadLocalFile):
(testDownloadLocalFileError):
(addContentDispositionHTTPHeaderToResponse):
(serverCallback):
(testDownloadRemoteFileError):

• TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:

(startTestServer):
(testInspectorServerPageList):
(openRemoteDebuggingSession):

• TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:

(testPrintOperationPrint):

• TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:

(addCacheHTTPHeadersToResponse):
(serverCallback):

• TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:

(httpsServerCallback):
(httpServerCallback):

• TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:

(testWebViewJavaScriptDialogs):
(testWebViewWindowProperties):
(testWebViewFileChooserRequest):

• TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:

(testWebExtensionWindowObjectCleared):
(testWebExtensionIsolatedWorld):

• TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:

(startTestServer):
(checkAtspiAccessible):

• TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:

(serverCallback):
(testClearDatabase):
(testGetFaviconURI):
(webkitFaviconDatabaseFinalizedCallback):

• TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:

(testWebContextGetPlugins):
(testWebContextURIScheme):

• TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:

(testWebViewRunJavaScript):
(testWebViewMode):
(testWebViewPageVisibility):

• TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:

(isStyleSheetInjectedForURLAtPath):

• TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:

(testWebViewEditorCutCopyPasteNonEditable):
(testWebViewEditorCutCopyPasteEditable):
(testWebViewEditorSelectAllNonEditable):
(testWebViewEditorSelectAllEditable):

• TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:

(sendRequestCallback):
(methodCallCallback):

• TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:

(TestWebKitAPI::Util::createInjectedBundlePath):
(TestWebKitAPI::Util::createURLForResource):

• TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:

(TestWebKitAPI::doKeyStroke):
(TestWebKitAPI::doMouseButtonEvent):
(TestWebKitAPI::PlatformWebView::simulateMouseMove):

• TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:

(loadFailedCallback):
(LoadTrackingTest::loadURI):
(LoadTrackingTest::loadHtml):
(LoadTrackingTest::loadPlainText):
(LoadTrackingTest::loadRequest):
(LoadTrackingTest::reload):
(LoadTrackingTest::goBack):
(LoadTrackingTest::goForward):

• TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
• TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:

(registerGResource):
(removeNonEmptyDirectory):
(main):

• TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:

(Test::getWebKit1TestResoucesDir):
(Test::getResourcesDir):

• TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:

(WebKitTestBus::run):

• TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:

(WebKitTestServer::WebKitTestServer):
(WebKitTestServer::getURIForPath):

• TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:

(WebProcessTestRunner::runTest):

• TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:

(resourceGetDataCallback):
(WebViewTest::mainResourceData):
(WebViewTest::mouseMoveTo):
(WebViewTest::keyStroke):
(WebViewTest::doMouseButtonEvent):

• TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
• WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:

(WTR::AccessibilityController::accessibleElementById):

• WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
• WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::role):
(WTR::AccessibilityUIElement::title):
(WTR::AccessibilityUIElement::description):
(WTR::AccessibilityUIElement::stringValue):
(WTR::AccessibilityUIElement::language):
(WTR::AccessibilityUIElement::lineForIndex):
(WTR::AccessibilityUIElement::selectedTextRange):
(WTR::AccessibilityUIElement::url):

• WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:

(WTR::getOutputDir):
(WTR::getFontsPath):
(WTR::initializeFontConfigSetting):

• WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:

(WTR::topLevelPath):

• WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:

(WTR::TestRunner::pathToLocalResource):

• WebKitTestRunner/gtk/TestControllerGtk.cpp:

(WTR::TestController::initializeInjectedBundlePath):
(WTR::TestController::initializeTestPluginDirectory):

11:39 PM Changeset in webkit [162598] by mark.lam@apple.com

• 13 edits in trunk/Source/JavaScriptCore

Poor man's fast breakpoints for a 2.3x debugger speedup.
<​https://webkit.org/b/122836>

Reviewed by Geoffrey Garen.

Previously we gained back some performance (run at baseline JIT speeds)
when the WebInspector is opened provided no breakpoints are set. This
was achieved by simply skipping all op_debug callbacks to the debugger
if no breakpoints are set. If any breakpoints are set, the debugger will
set a m_needsOpDebugCallbacks flag which causes the callbacks to be
called, and we don't get the baseline JIT speeds anymore.

With this patch, we will now track the number of breakpoints set in the
CodeBlock that they are set in. The LLINT and baseline JIT code will
check CodeBlock::m_numBreakpoints to determine if the op_debug callbacks
need to be called. With this, we will only enable op_debug callbacks for
CodeBlocks that need it i.e. those with breakpoints set in them.

Debugger::m_needsOpDebugCallbacks is now obsoleted. The LLINT and baseline
JIT code still needs to check Debugger::m_shouldPause to determine if the
debugger is in stepping mode and hence, needs op_debug callbacks enabled
for everything until the debugger "continues" the run and exit stepping
mode.

Also in this patch, I fixed a regression in DOM breakpoints which relies
Debugger::breakProgram() to pause the debugger.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

• Missed accounting for op_debug's new hasBreakpointFlag operand here when it was added.

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::hasOpDebugForLineAndColumn):

• This is needed in Debugger::toggleBreakpoint() to determine if a breakpoint falls within a CodeBlock or not. Simply checking the bounds of the CodeBlock is insufficient. For example, let's say we have the following JS code:

begin global scope
function f1() {

function f2() {

... set breakpoint here.

}

}
end global scope

Using the CodeBlock bounds alone, the breakpoint above will to appear
to be in the global program CodeBlock, and the CodeBlocks for function
f1() and f2(). With CodeBlock::hasOpDebugForLineAndColumn() we can
rule out the global program CodeBlock and f1(), and only apply the
breakpoint to f2(0 where it belongs.

CodeBlock::hasOpDebugForLineAndColumn() works by iterating over all
the opcodes in the CodeBlock to look for op_debug's. For each op_debug,
it calls CodeBlock::expressionRangeForBytecodeOffset() to do a binary
seach to get the line and column info for that op_debug. This is a
N * log(N) algorithm. However, a quick hands on test using the
WebInspector (with this patch applied) to exercise setting, breaking
on, and clearing breakpoints, as well as stepping through some code
shows no noticeable degradation of the user experience compared to the
baseline without this patch.

• bytecode/CodeBlock.h:

(JSC::CodeBlock::numBreakpoints):
(JSC::CodeBlock::numBreakpointsOffset):
(JSC::CodeBlock::addBreakpoint):
(JSC::CodeBlock::removeBreakpoint):
(JSC::CodeBlock::clearAllBreakpoints):

• debugger/Breakpoint.h:
• defined Breakpoint::unspecifiedColumn so that we can explicitly indicate when the WebInspector was setting a line breakpoint and did not provide a column value. CodeBlock::hasOpDebugForLineAndColumn() needs this information in order to loosen its matching criteria for op_debug bytecodes for the specified breakpoint line and column values provided by the debugger.

Previously, we just hijack a 0 value column as an unspecified column.
However, the WebInspector operates on 0-based ints for column values.
Hence, 0 should be a valid column value and should not be hijacked to
mean an unspecified column.

• debugger/Debugger.cpp:

(JSC::Debugger::Debugger):

• added tracking of the VM that the debugger is used with. This is needed by Debugger::breakProgram().

The VM pointer is attained from the first JSGlobalObject that the debugger
attaches to. When the debugger detaches from the last JSGlobalObject, it
will nullify its VM pointer to allow a new one to be set on the next
attach.

We were always only using each debugger instance with one VM. This change
makes it explicit with an assert to ensure that all globalObjects that
the debugger attaches to beongs to the same VM.

(JSC::Debugger::attach):
(JSC::Debugger::detach):
(JSC::Debugger::setShouldPause):

(JSC::Debugger::registerCodeBlock):
(JSC::Debugger::unregisterCodeBlock):

• registerCodeBlock() is responsible for applying pre-existing breakpoints to new CodeBlocks being installed. Similarly, unregisterCodeBlock() clears the breakpoints.

(JSC::Debugger::toggleBreakpoint):

• This is the workhorse function that checks if a breakpoint falls within a CodeBlock or not. If it does, then it can either enable or disable said breakpoint in the CodeBlock. In the current implementation, enabling/disabling the breakpoint simply means incrementing/decrementing the CodeBlock's m_numBreakpoints.

(JSC::Debugger::applyBreakpoints):

(JSC::Debugger::ToggleBreakpointFunctor::ToggleBreakpointFunctor):
(JSC::Debugger::ToggleBreakpointFunctor::operator()):
(JSC::Debugger::toggleBreakpoint):

• Iterates all relevant CodeBlocks and apply the specified breakpoint if appropriate. This is called when a new breakpoint is being defined by the WebInspector and needs to be applied to an already installed CodeBlock.

(JSC::Debugger::setBreakpoint):
(JSC::Debugger::removeBreakpoint):
(JSC::Debugger::hasBreakpoint):
(JSC::Debugger::ClearBreakpointsFunctor::ClearBreakpointsFunctor):
(JSC::Debugger::ClearBreakpointsFunctor::operator()):
(JSC::Debugger::clearBreakpoints):

(JSC::Debugger::breakProgram):

• Fixed a regression that broke DOM breakpoints. The issue is that with the skipping of op_debug callbacks, we don't always have an updated m_currentCallFrame. Normally, m_currentCallFrame is provided as arg in the op_debug callback. In this case, we can get the CallFrame* from m_vm->topCallFrame.

(JSC::Debugger::updateCallFrameAndPauseIfNeeded):
(JSC::Debugger::pauseIfNeeded):
(JSC::Debugger::willExecuteProgram):

• debugger/Debugger.h:

(JSC::Debugger::Debugger):
(JSC::Debugger::shouldPause):

• heap/CodeBlockSet.h:

(JSC::CodeBlockSet::iterate):

• heap/Heap.h:

(JSC::Heap::forEachCodeBlock):

• Added utility to iterate all CodeBlocks in the heap / VM.

• interpreter/Interpreter.cpp:

(JSC::Interpreter::debug):

• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_debug):

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_debug):

• llint/LowLevelInterpreter.asm:
• These now checks CodeBlock::m_numBreakpoints and Debugger::m_shouldPause instead of Debugger::m_needsOpDebugCallbacks.

• runtime/Executable.cpp:

(JSC::ScriptExecutable::installCode):

10:32 PM Changeset in webkit [162597] by Simon Fraser

• 8 edits in trunk/Source

Surround fixedVisibleContentRect code with USE(TILED_BACKING_STORE)
​https://bugs.webkit.org/show_bug.cgi?id=127461

Source/WebCore:

Reviewed by Andreas Kling.

The "fixedVisibleContentRect" code path is only used by platforms
which enabled TILED_BACKING_STORE, so to reduce confusion, surround
this code with #if USE(TILED_BACKING_STORE).

• page/Frame.cpp:

(WebCore::Frame::createView):

• page/FrameView.cpp:
• page/FrameView.h:
• platform/ScrollView.cpp:

(WebCore::ScrollView::unscaledVisibleContentSize):
(WebCore::ScrollView::visibleContentRect):

• platform/ScrollView.h:

(WebCore::ScrollView::visibleSize):

Source/WebKit2:

Reviewed by Andreas Kling.

The "fixedVisibleContentRect" code path is only used by platforms
which enabled TILED_BACKING_STORE, so to reduce confusion, surround
this code with #if USE(TILED_BACKING_STORE).

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

10:10 PM Changeset in webkit [162596] by fpizlo@apple.com

• 2 edits in branches/jsCStack/Source/JavaScriptCore

Unreviewed, fix style.

This slipped past code review. The following is wrong:

void compileArithSin(){

for two reasons:

1. There should be a space between ) and {.

2. For function bodies, we always put the { on the next line, like:

void compileArithSin()
{

I fixed this by putting these function bodies all on one line, since they are very small
anyway.

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileArithSin):
(JSC::FTL::LowerDFGToLLVM::compileArithCos):
(JSC::FTL::LowerDFGToLLVM::compileArithSqrt):

10:05 PM Changeset in webkit [162595] by fpizlo@apple.com

• 8 edits
  2 adds in branches/jsCStack/Source/JavaScriptCore

FTL should support MakeRope
​https://bugs.webkit.org/show_bug.cgi?id=127462

Not yet reviewed.

• ftl/FTLAbstractHeap.cpp:

(JSC::FTL::IndexedAbstractHeap::IndexedAbstractHeap):
(JSC::FTL::IndexedAbstractHeap::baseIndex):
(JSC::FTL::IndexedAbstractHeap::initialize):
(JSC::FTL::NumberedAbstractHeap::NumberedAbstractHeap):
(JSC::FTL::AbsoluteAbstractHeap::AbsoluteAbstractHeap):

• ftl/FTLAbstractHeap.h:
• ftl/FTLAbstractHeapRepository.cpp:

(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):

• ftl/FTLAbstractHeapRepository.h:
• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLIntrinsicRepository.h:
• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileMakeRope):
(JSC::FTL::LowerDFGToLLVM::speculate):

• tests/stress/make-rope-2.js: Added.

(foo):

• tests/stress/make-rope-3.js: Added.

(foo):

9:36 PM Changeset in webkit [162594] by Lucas Forschler

• 5 edits in tags/Safari-538.13/Source

Versioning.

9:11 PM Changeset in webkit [162593] by fpizlo@apple.com

• 5 edits
  7 adds in branches/jsCStack/Source/JavaScriptCore

FTL should support ToString
​https://bugs.webkit.org/show_bug.cgi?id=127460

Reviewed by Geoffrey Garen.

• ftl/FTLAbstractHeapRepository.h:
• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLIntrinsicRepository.h:
• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileToString):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::speculateStringObject):
(JSC::FTL::LowerDFGToLLVM::speculateStringOrStringObject):
(JSC::FTL::LowerDFGToLLVM::speculateStringObjectForCell):
(JSC::FTL::LowerDFGToLLVM::speculateStringObjectForStructure):

• tests/stress/to-string-on-object-or-string.js: Added.

(Foo):
(Foo.prototype.toString):
(foo):

• tests/stress/to-string-on-object.js: Added.

(Foo):
(Foo.prototype.toString):
(foo):

• tests/stress/to-string-on-string-object.js: Added.

(foo):

• tests/stress/to-string-on-string-or-string-object.js: Added.

(foo):

• tests/stress/to-string-on-string-or-string-object-then-object.js: Added.

(foo):
(Foo):
(Foo.prototype.toString):

• tests/stress/to-string-on-value-or-string.js: Added.

(foo):

• tests/stress/to-string-on-value.js: Added.

(foo):

9:08 PM Changeset in webkit [162592] by Lucas Forschler

• 5 edits in trunk/Source

Versioning.

9:06 PM Changeset in webkit [162591] by Lucas Forschler

• 1 copy in tags/Safari-538.13

New Tag.

9:04 PM Changeset in webkit [162590] by benjamin@webkit.org

• 3 edits in trunk/Source/WebKit2

Add a minimalistic SPI to control the layout size outside of WKView
​https://bugs.webkit.org/show_bug.cgi?id=127403

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-01-22
Reviewed by Sam Weinig.

The API lets a client of WKView force the layout size. Once the size
is set this way, default update is disabled and the client needs to
update the size systematically as needed. This is done to avoid double
layout or flickering.

• UIProcess/API/Cocoa/WKViewPrivate.h:
• UIProcess/API/ios/WKViewIOS.mm:

(-[WKView _frameOrBoundsChanged]):
(-[WKView overrideMinimumLayoutSize:]):

8:31 PM Changeset in webkit [162589] by jinwoo7.song@samsung.com

• 22 edits in trunk/LayoutTests

Unreviewed EFL gardening after r162553.

• platform/efl/css1/box_properties/padding-expected.txt:
• platform/efl/css1/box_properties/padding_top-expected.txt:
• platform/efl/css1/formatting_model/vertical_formatting-expected.txt:
• platform/efl/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
• platform/efl/css2.1/t0804-c5510-padn-00-b-ag-expected.txt:
• platform/efl/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
• platform/efl/fast/css/empty-pseudo-class-expected.txt:
• platform/efl/fast/css/fieldset-display-row-expected.txt:
• platform/efl/fast/css/first-child-pseudo-class-expected.txt:
• platform/efl/fast/css/last-child-pseudo-class-expected.txt:
• platform/efl/fast/css/only-child-pseudo-class-expected.txt:
• platform/efl/fast/repaint/reflection-redraw-expected.txt:
• platform/efl/fast/table/dynamic-caption-add-remove-before-child-expected.txt:
• platform/efl/fast/table/multiple-captions-display-expected.txt:
• platform/efl/tables/mozilla/marvin/body_col-expected.txt:
• platform/efl/tables/mozilla/marvin/x_th_valign_baseline-expected.txt:
• platform/efl/tables/mozilla/other/body_col-expected.txt:
• platform/efl/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
• platform/efl/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
• platform/efl/tables/mozilla_expected_failures/core/captions3-expected.txt:
• platform/efl/tables/mozilla_expected_failures/other/test4-expected.txt:

8:24 PM Changeset in webkit [162588] by mmaxfield@apple.com

• 3 edits
  2 adds in trunk

ASSERTION FAILED: v.isFixed() in WebCore::RenderStyle::setWordSpacing
​https://bugs.webkit.org/show_bug.cgi?id=126987

Reviewed by Simon Fraser.

When "inherit" is specified and there is no parent, Length values have an "Auto" type

Source/WebCore:

Test: fast/css3-text/css3-word-spacing-percentage/word-spacing-crash.html

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setWordSpacing):

LayoutTests:

• fast/css3-text/css3-word-spacing-percentage/word-spacing-crash-expected.txt: Added.
• fast/css3-text/css3-word-spacing-percentage/word-spacing-crash.html: Added.

8:12 PM Changeset in webkit [162587] by Samuel White

• 3 edits
  2 adds in trunk

AX: Can't always increment web sliders.
​https://bugs.webkit.org/show_bug.cgi?id=127451

Reviewed by Chris Fleizach.

Source/WebCore:

Clamping the decrement/increment amount to one when necessary (if a percent change would result in a change of less than one).

Test: accessibility/range-alter-by-percent.html

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::changeValueByPercent):

LayoutTests:

Adding range-alter-by-percent.html to compliment the existing range-alter-by-step.html test.

• accessibility/range-alter-by-percent-expected.txt: Added.
• accessibility/range-alter-by-percent.html: Added.

7:55 PM Changeset in webkit [162586] by Martin Robinson

• 1 edit in trunk/Tools/ChangeLog

Fix a small issue in my recently committed ChangeLog

7:50 PM Changeset in webkit [162585] by Martin Robinson

• 3 edits in trunk/Tools

[GTK] [CMake] run-webkit-tests should support the CMake build
​https://bugs.webkit.org/show_bug.cgi?id=126503

Reviewed by Daniel Bates.

Update run-launcher and gtk.py to work properly when dealing with the CMake port.
run-webkit-tests does not need the --gtkcmake flag, but run-launcher does.

• Scripts/run-launcher: Work properly with the gtkcmake flag.
• Scripts/webkitpy/port/gtk.py:

(GtkPort._is_cmake_build): Added this helper which looks for the CMakeCache
file to detect a CMake build.
(GtkPort._built_executables_path): Added this helper to locate the built executable path.
(GtkPort._built_libraries_path): Added this helper to locate the built library path.
(GtkPort._port_flag_for_scripts): Use --gtkcmake when appropriate.
(GtkPort.setup_environ_for_server): The way CMake builds libraries differs from GTK+.
(GtkPort._path_to_driver): Use the new helper.
(GtkPort._path_to_image_diff): Use the new Helper.
(GtkPort._path_to_webcore_library): Use the new helper.
(GtkPort.build_webkit_command): Use --gtkcmake when appropriate.

7:09 PM Changeset in webkit [162584] by jinwoo7.song@samsung.com

• 3 edits in trunk/Source/WebKit2

[EFL][WK2] defaultTextEncodingName should be stored as a member variable of EwkSettings
​https://bugs.webkit.org/show_bug.cgi?id=127420

Reviewed by Gyuyoung Kim.

As the defaultTextEncodingName is returned as a local WKEinaSharedString variable,
the stringshared data is de-refed by eina_stringshare_del().
To maintain the reference counter, the defaultTextEncodingName should be stored
as a member variable of EwkSettings class.

• UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_encoding_detector_enabled_get): Reordering.
(ewk_settings_default_text_encoding_name_set):
(ewk_settings_default_text_encoding_name_get):
(EwkSettings::setDefaultTextEncodingName):
(EwkSettings::defaultTextEncodingName):

• UIProcess/API/efl/ewk_settings_private.h:

(EwkSettings::EwkSettings): Add m_defaultTextEncodingName and setter/getter methods.

7:08 PM Changeset in webkit [162583] by fpizlo@apple.com

• 3 edits in branches/jsCStack/Source/JavaScriptCore

FTL should support GetCallee
​https://bugs.webkit.org/show_bug.cgi?id=127459

Not yet reviewed.

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetCallee):

6:56 PM Changeset in webkit [162582] by enrica@apple.com

• 4 edits in trunk/Source/WebKit2

Support WebSelections in WK2 on iOS.
​https://bugs.webkit.org/show_bug.cgi?id=127015
<rdar://problem/15211964>

Reviewed by Benjamin Poulain.

This change adds support for text only (non block mode)
selections in non editable content.
The main changes consist in hooking up the new gesture type
and touches to handle selection creation and interaction.
It also includes changes to the way first responder is handled
which includes the implementation of the isEditable method
to allow iOS to know when to show the keyboard.

• Shared/ios/WKGestureTypes.h:
• UIProcess/API/ios/WKInteractionView.mm:

(-[WKInteractionView isEditable]):
(-[WKInteractionView canBecomeFirstResponder]):
(-[WKInteractionView webSelectionRects]):
(-[WKInteractionView _highlightLongPressRecognized:]):
(-[WKInteractionView _singleTapRecognized:]):
(-[WKInteractionView inputAccessoryView]):
(-[WKInteractionView canPerformAction:withSender:]):
(-[WKInteractionView _showDictionary:]):
(toWKGestureType):
(toUIWKGestureType):
(selectionChangedWithGesture):
(selectionChangedWithTouch):
(-[WKInteractionView selectedTextRange]):
(-[WKInteractionView webSelectionAssistant]):
(-[WKInteractionView _startAssistingNode]):
(-[WKInteractionView _stopAssistingNode]):
(-[WKInteractionView _selectionChanged]):

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::selectWithGesture):
(WebKit::WebPage::updateSelectionWithTouches):

6:24 PM Changeset in webkit [162581] by ryuan.choi@samsung.com

• 5 edits in trunk

[EFL] Remove unnecessary smart method since ewk_view_tiled removed
​https://bugs.webkit.org/show_bug.cgi?id=127417

Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

pre_render related codes is only for ewk_view_tiled.
In addition, we don't have any requirement to override repaints_process
and scroll_process now.

• ewk/ewk_view.cpp:

(_ewk_view_smart_repaints_process):
(_ewk_view_smart_calculate):
(ewk_view_smart_set):
(ewk_view_scrolls_process):

• ewk/ewk_view.h:

Tools:

• EWebLauncher/main.c:

(on_key_down): Removed shortcut to test pre render.

6:24 PM Changeset in webkit [162580] by andersca@apple.com

• 10 edits in trunk/Source/WebKit2

WKBrowsingContextController should not be an API wrapper around WebPageProxy
​https://bugs.webkit.org/show_bug.cgi?id=127454

Reviewed by Dan Bernstein.

• Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

• Shared/mac/ObjCObjectGraphCoders.mm:

(WebKit::WebContextObjCObjectGraphDecoderImpl::decode):

• UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController _initWithPageRef:]):
(+[WKBrowsingContextController _browsingContextControllerForPageRef:]):

• UIProcess/API/Cocoa/WKBrowsingContextControllerInternal.h:
• UIProcess/API/Cocoa/WKProcessGroup.mm:

(didNavigateWithNavigationData):
(didPerformClientRedirect):
(didPerformServerRedirect):
(didUpdateHistoryTitle):

• UIProcess/API/ios/WKContentView.mm:

(-[WKContentView browsingContextController]):

• UIProcess/API/mac/WKView.mm:

(-[WKView browsingContextController]):

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::platformInitialize):

• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::platformInitialize):

6:19 PM Changeset in webkit [162579] by mmaxfield@apple.com

• 39 edits in trunk

Remove CSS3_TEXT_DECORATION define
​https://bugs.webkit.org/show_bug.cgi?id=127333

Source/JavaScriptCore:

This is required for unprefixing the text-decoration-* CSS properties.

Reviewed by Simon Fraser.

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Reviewed by Simon Fraser.

This is required for unprefixing the text-decoration-* CSS properties.

No new tests are necessary becase the flag was already on by default.

• Configurations/FeatureDefines.xcconfig:
• css/CSSComputedStyleDeclaration.cpp:

(WebCore::renderTextDecorationSkipFlagsToCSSValue):
(WebCore::ComputedStyleExtractor::propertyValue):

• css/CSSParser.cpp:

(WebCore::isColorPropertyID):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::addTextDecorationProperty):
(WebCore::CSSParser::parseTextUnderlinePosition):

• css/CSSParser.h:
• css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator TextUnderlinePosition):

• css/CSSPropertyNames.in:
• css/CSSValueKeywords.in:
• css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):

• css/StylePropertyShorthand.cpp:

(WebCore::webkitTextDecorationShorthand):
(WebCore::shorthandForProperty):
(WebCore::matchingShorthandsForLonghand):

• css/StylePropertyShorthand.h:
• css/StyleResolver.cpp:

(WebCore::shouldApplyPropertyInParseOrder):
(WebCore::isValidVisitedLinkProperty):
(WebCore::StyleResolver::applyProperty):

• platform/graphics/GraphicsContext.h:
• platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::setPlatformStrokeStyle):

• platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::platformInit):

• platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::createPen):

• rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeMaxLogicalTop):

• rendering/InlineFlowBox.h:
• rendering/InlineTextBox.cpp:

(WebCore::textDecorationStyleToStrokeStyle):
(WebCore::boundingBoxForAllActiveDecorations):
(WebCore::InlineTextBox::paintDecoration):

• rendering/RenderObject.cpp:

(WebCore::decorationColor):

• rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalTop):

• rendering/RootInlineBox.h:
• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresRepaintIfTextOrBorderOrOutline):
(WebCore::RenderStyle::colorIncludingFallback):
(WebCore::RenderStyle::visitedDependentColor):

• rendering/style/RenderStyle.h:
• rendering/style/RenderStyleConstants.h:
• rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

• rendering/style/StyleRareInheritedData.h:
• rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

• rendering/style/StyleRareNonInheritedData.h:

Source/WebKit/mac:

Reviewed by Simon Fraser.

This is required for unprefixing the text-decoration-* CSS properties.

• Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Reviewed by Simon Fraser.

This is required for unprefixing the text-decoration-* CSS properties.

• Configurations/FeatureDefines.xcconfig:

Source/WTF:

Reviewed by Simon Fraser.

This is required for unprefixing the text-decoration-* CSS properties.

• wtf/Platform.h:

Tools:

This is required for unprefixing the text-decoration-* CSS properties.

Reviewed by Simon Fraser.

• Configurations/FeatureDefines.xcconfig:

6:16 PM Changeset in webkit [162578] by barraclough@apple.com

• 12 edits in trunk/Source/WebKit2

Debug mechanism to override process QoS on Mac
​https://bugs.webkit.org/show_bug.cgi?id=127455

Reviewed by Anders Carlsson.

• NetworkProcess/NetworkProcess.messages.in:
  • added message.
• PluginProcess/PluginProcess.messages.in:
  • added message.
• Shared/ChildProcess.h:
• Shared/mac/ChildProcessMac.mm:

(WebKit::ChildProcess::setQOS):

• Added implementation of new message.

• UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::didFinishLaunching):

• SetQOS for the PluginProcess.

• UIProcess/Plugins/PluginProcessProxy.h:
• UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::pluginProcessLatencyQOS):
(WebKit::pluginProcessThroughputQOS):

• read NSUserDefaults.

• UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureNetworkProcess):

• SetQOS for the NetworkProcess.

(WebKit::WebContext::createNewWebProcess):

• SetQOS for the WebProcess.

• UIProcess/WebContext.h:
• UIProcess/mac/WebContextMac.mm:

(WebKit::networkProcessLatencyQOS):
(WebKit::networkProcessThroughputQOS):
(WebKit::webProcessLatencyQOS):
(WebKit::webProcessThroughputQOS):

• read NSUserDefaults.

• WebProcess/WebProcess.messages.in:
  • added message.

6:02 PM Changeset in webkit [162577] by mark.lam@apple.com

• 7 edits in branches/jsCStack/Source

Switching Windows port to using the C Loop LLINT.
​https://bugs.webkit.org/show_bug.cgi?id=127228.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

With the switch to using the C stack for the JS stack, the LLINT becomes
a mandatory component for providing trampoline glue code to enter JIT code.
Since the Windows port does not currently have a LLINT implementation that
can generate assembly code for Windows, we'll switch the Windows port to
using the C Loop LLINT.

Note: We're opting to not continue using hand-written glue code for the
Windows port because they can easily bit rot relative to the LLINT asm
source.

• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
• jit/JITStubsMSVC64.asm: Removed.
• jit/JITStubsX86.h:
• Removing these hand-written pieces of glue code that are no longer needed with the switch to using the C Loop LLINT.

Source/WTF:

• wtf/Platform.h:
• Disabling the JIT for all Windows ports, which enables the C Loop LLINT.

6:01 PM Changeset in webkit [162576] by Chris Fleizach

• 5 edits in trunk

Source/WebCore: AX: Do not return an accessible name for an object just because it has tabindex=0
​https://bugs.webkit.org/show_bug.cgi?id=126914

Reviewed by Mario Sanchez Prada.

WebKit has code to return an accessible name for any object that is "generically" focusable (ie. tabindex=0).
This behavior, which is not supported in ARIA, has caused many problems for VoiceOver. Often VoiceOver will
speak all the text underneath any type of group.

I think we need to revert this behavior and follow the ARIA spec more closely.

Test: accessibility/aria-describedby-ensures-visibility.html

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::visibleText):
(WebCore::AccessibilityNodeObject::title):

LayoutTests: AX: WebKit concatenates name of all toolbar buttons in the apple.com video player
​https://bugs.webkit.org/show_bug.cgi?id=126914

Reviewed by Mario Sanchez Prada.

• accessibility/focusable-div-expected.txt:
• accessibility/focusable-div.html:

5:35 PM Changeset in webkit [162575] by ap@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Update JS whitespace definition for changes in Unicode 6.3
​https://bugs.webkit.org/show_bug.cgi?id=127450
<rdar://15863457>

Reviewed by Oliver Hunt.

Covered by existing tests when running against a Unicode back-end that supports
Unicode 6.3 or higher.

• runtime/JSGlobalObjectFunctions.cpp: (JSC::isStrWhiteSpace): Explicitly allow

U+180E MONGOLIAN VOWEL SEPARATOR, because we need to keep recognizing all characters
that used to be whitespace.

5:17 PM Changeset in webkit [162574] by dfarler@apple.com

• 5 edits in trunk/Source/WebKit2

ASAN builds are broken - missing flags
​https://bugs.webkit.org/show_bug.cgi?id=127231

Reviewed by Andy Estes.

Add missing $(ASAN_OTHER_LDFLAGS).

• Configurations/PluginProcessShim.xcconfig:
• Configurations/SecItemShim.xcconfig:
• Configurations/WebKit2.xcconfig:
• Configurations/WebProcessShim.xcconfig:

5:11 PM Changeset in webkit [162573] by aestes@apple.com

• 6 edits
  2 adds in trunk/Tools

[iOS] Prepare for upstreaming DumpRenderTree changes
​https://bugs.webkit.org/show_bug.cgi?id=127412

Reviewed by Simon Fraser.

Unlike on Mac where DumpRenderTree is a command-line tool, on iOS it is
an application bundle. Instead of upstreaming a separate target for the
app that duplicates the 'Compile Sources' phase of the tool, separate
out the compilation into a static library target that both the
command-line tool and the app can link against. Also, perform some
unrelated cleanup.

• DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Updated the

project file format from 2.4- to 3.2-compatible. Removed the
'Copy Headers' build phase and removed all files from the
'Compile Sources' build phase of DumpRenderTree. Added some files that
were missing from the project. Created a 'DumpRenderTree (Library)'
target for building the static library and made the 'DumpRenderTree'
target depend on it. Added a 'Compile Sources' build phase to this
target that builds the same files the DumpRenderTree target used to.
Created DumpRenderTreeMain.mm as the only source file of the
DumpRenderTree target, since targets won't link a binary without at
least one source file. Made DumpRenderTree (Library) use
DumpRenderTreeLibrary.xcconfig and made LayoutTestHelper use
BaseTarget.xcconfig (so that it doesn't try to link libDumpRenderTree.a).

• DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Moved

definitions of GCC_ENABLE_OBJC_EXCEPTIONS and GCC_PREFIX_HEADER from
DumpRenderTree.xcconfig to here so that LayoutTestHelper can use them.

• DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Passed

-force_load $(BUILT_PRODUCTS_DIR)libDumpRenderTree.a to OTHER_LDFLAGS.
This is needed to correctly link a static library containing an Objective-C
category (see <​https://developer.apple.com/library/mac/qa/qa1490/_index.html>).

• DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Added.
• DumpRenderTree/mac/DumpRenderTree.mm:

(DumpRenderTreeMain): Renamed from main.

• DumpRenderTree/mac/DumpRenderTreeMac.h: Added declaration of DumpRenderTreeMain.
• DumpRenderTree/mac/DumpRenderTreeMain.mm: Added.

(main): Called DumpRenderTreeMain from main.

4:38 PM Changeset in webkit [162572] by matthew_hanson@apple.com

• 5 edits in branches/safari-537.74-branch/Source

Versioning.

4:36 PM Changeset in webkit [162571] by matthew_hanson@apple.com

• 1 copy in tags/Safari-537.74.11

New Tag.

4:31 PM Changeset in webkit [162570] by matthew_hanson@apple.com

• 3 edits
  3 copies in branches/safari-537.74-branch

Merge r158676: <rdar://problem/15886062>

4:30 PM Changeset in webkit [162569] by beidson@apple.com

• 9 edits in trunk/Source

Source/WebCore: The IDB backing store get() method shouldn't call IDB callbacks directly
​https://bugs.webkit.org/show_bug.cgi?id=127453

Reviewed by Beth Dakin.

• Modules/indexeddb/IDBServerConnection.h:

(WebCore::IDBGetResult::IDBGetResult): Add a new structure to hold all of the

possible results of a get() call.

• Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:

(WebCore::IDBServerConnectionLevelDB::get): Don't call IDBCallbacks directly.

Instead, return the GetResult to the GetOperation which will make IDBCallbacks.

• Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:

• Modules/indexeddb/IDBTransactionBackendOperations.cpp:

(WebCore::GetOperation::perform): Get all of the IDBGetResults in the completion callback

make the appropriate IDBCallback.

• Modules/indexeddb/IDBTransactionBackendOperations.h:

Source/WebKit2: The IDB backing store get() method shouldn't call IDB callbacks directly
​https://bugs.webkit.org/show_bug.cgi?id=127453

Reviewed by Beth Dakin.

• WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::get):

• WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:

4:28 PM Changeset in webkit [162568] by commit-queue@webkit.org

• 25 edits in trunk/Source/WebKit2

Enable Session API.
​https://bugs.webkit.org/show_bug.cgi?id=127255

Patch by Martin Hock <​mhock@apple.com> on 2014-01-22
Reviewed by Alexey Proskuryakov.

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::storageSession):

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::NetworkResourceLoader):
(WebKit::NetworkResourceLoader::start):

• NetworkProcess/NetworkResourceLoader.h:
• NetworkProcess/RemoteNetworkingContext.h:
• NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::storageSession):
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):

• Shared/Network/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::NetworkResourceLoadParameters):
(WebKit::NetworkResourceLoadParameters::encode):
(WebKit::NetworkResourceLoadParameters::decode):

• Shared/Network/NetworkResourceLoadParameters.h:
• Shared/SessionTracker.cpp:

(WebKit::staticSessionMap):
(WebKit::SessionTracker::sessionMap):
(WebKit::SessionTracker::session):
(WebKit::SessionTracker::setSession):
(WebKit::SessionTracker::destroySession):

• Shared/SessionTracker.h:
• UIProcess/API/C/WKPage.cpp:

(WKPageSetSession):

• UIProcess/API/C/WKPage.h:
• UIProcess/API/C/WKSessionRef.cpp:

(WKSessionCreate):

• UIProcess/API/C/WKSessionRef.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setSession):

• UIProcess/WebPageProxy.h:
• WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::scheduleLoad):

• WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::loadResourceSynchronously):

• WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
(WebKit::WebFrameNetworkingContext::storageSession):

• WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:

(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):

• WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::startDownload):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::sessionID):
(WebKit::WebPage::updatePreferences):

• WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::setSessionID):

• WebProcess/WebPage/WebPage.messages.in:

3:58 PM Changeset in webkit [162567] by dino@apple.com

• 5 edits in trunk/Source/WebCore

Unreviewed attempt to fix 32-bit builds.

Use long long rather than GC3Dintptr.

• html/canvas/ANGLEInstancedArrays.cpp:

(WebCore::ANGLEInstancedArrays::drawElementsInstancedANGLE):

• html/canvas/ANGLEInstancedArrays.h:
• html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::drawElementsInstanced):

• html/canvas/WebGLRenderingContext.h:

3:48 PM Changeset in webkit [162566] by beidson@apple.com

• 31 edits
  1 copy
  1 add in trunk/Source

IDB: "Put" support
<rdar://problem/15779643> and ​https://bugs.webkit.org/show_bug.cgi?id=127401

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Add persistent encode/decode for storage to the database:

• Modules/indexeddb/IDBKey.cpp:

(WebCore::IDBKey::encode):
(WebCore::IDBKey::decode):

• Modules/indexeddb/IDBKey.h:

Add a data class to represent IDBKey suitable for crossing IPC:

• Modules/indexeddb/IDBKeyData.cpp: Added.

(WebCore::IDBKeyData::IDBKeyData):
(WebCore::IDBKeyData::maybeCreateIDBKey):
(WebCore::IDBKeyData::isolatedCopy):

• Modules/indexeddb/IDBKeyData.h: Added.

(WebCore::IDBKeyData::IDBKeyData):

• platform/CrossThreadCopier.cpp:

(WebCore::IDBKeyData>::copy):

• platform/CrossThreadCopier.h:

• WebCore.exp.in:
• WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

Ship putRecord requests over to the DatabaseProcess, and listen for completion from the DatabaseProcess:

• WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::put):
(WebKit::WebIDBServerConnection::didPutRecord):

• WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
• WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in:

Pass off the putRecord request to the Unique IDBDatabase:

• DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

(WebKit::DatabaseProcessIDBConnection::putRecord):

• DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
• DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:

Pass off the putRecord request to the backing store:

• DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::putRecord):
(WebKit::UniqueIDBDatabase::putRecordInBackingStore):
(WebKit::UniqueIDBDatabase::didPutRecordInBackingStore):

• DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:

Add backing store methods related to putRecord, though only one is critical right now:

• DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
• DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createAndPopulateInitialMetadata):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::generateKey):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::keyExistsInObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::putRecord):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::updateKeyGenerator):

• DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:

Add the IDBKeyData type to IPC:

• Scripts/webkit2/messages.py:

(struct_or_class):

• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<IDBKeyData>::encode):
(IPC::ArgumentCoder<IDBKeyData>::decode):

• Shared/WebCoreArgumentCoders.h:

• DatabaseProcess/IndexedDB/IDBSerialization.cpp:

(WebKit::serializeIDBKey):

• DatabaseProcess/IndexedDB/IDBSerialization.h:

Implement more cross-thread copying:

• Shared/WebCrossThreadCopier.cpp:

(WebCore::Vector<uint8_t>>::copy):
(WebCore::Vector<Vector<IDBKeyData>>>::copy):
(WebCore::ASCIILiteral>::copy):

• Shared/WebCrossThreadCopier.h:

Implement more numbers of generic AsyncTask templates:

• Shared/AsyncTask.h:

(WebKit::createAsyncTask):

3:47 PM Changeset in webkit [162565] by dino@apple.com

• 21 edits
  8 adds in trunk

Source/WebCore: [WebGL] Implement ANGLE_instanced_arrays
​https://bugs.webkit.org/show_bug.cgi?id=127257

Reviewed by Brent Fulgham.

Implement the instanced drawing WebGL extension,
ANGLE_instanced_arrays. This is currently Mac-only,
but should be portable to other platforms if their
OpenGL exposes the functions. It's also done in a way
that will make exposing it to WebGL2 simple.

Test: fast/canvas/webgl/angle-instanced-arrays.html

• CMakeLists.txt:
• DerivedSources.cpp:
• DerivedSources.make:
• GNUmakefile.list.am:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:

Add the new files to all the build systems.

• bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS): Link JS side to C++ side.

• html/canvas/ANGLEInstancedArrays.cpp: Added.

(WebCore::ANGLEInstancedArrays::ANGLEInstancedArrays):

• html/canvas/ANGLEInstancedArrays.h: Added.
• html/canvas/ANGLEInstancedArrays.idl: Added.

New boilerplate files that expose the extension methods.

• html/canvas/WebGLExtension.h: New extension enum.

• html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::validateVertexAttributes): Add an optional
parameter representing the number of instance primitives we are asked
to draw. Use that for the draw count if looking at an instanced attribute.
Also make sure we see at least one non-instanced attribute.
(WebCore::WebGLRenderingContext::validateDrawArrays): Update this so it could
be used from either drawArrays or drawArraysInstanced.
(WebCore::WebGLRenderingContext::drawArrays):
(WebCore::WebGLRenderingContext::validateDrawElements): Same here, now can be
used by the instanced and non-instanced versions.
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::getExtension): Create and return the new extension.
(WebCore::WebGLRenderingContext::getSupportedExtensions): Add new extension to the list.
(WebCore::WebGLRenderingContext::getVertexAttrib): Intercept a query to the divisor
attribute and return the value we kept in the state.
(WebCore::WebGLRenderingContext::drawArraysInstanced): Call the GC3D method.
(WebCore::WebGLRenderingContext::drawElementsInstanced): Ditto.
(WebCore::WebGLRenderingContext::vertexAttribDivisor): Ditto.

• html/canvas/WebGLRenderingContext.h: Define the new methods and parameters.

• html/canvas/WebGLVertexArrayObjectOES.cpp:

(WebCore::WebGLVertexArrayObjectOES::setVertexAttribDivisor): Keep a record of the
divisor if we set it.

• html/canvas/WebGLVertexArrayObjectOES.h:

(WebCore::WebGLVertexArrayObjectOES::VertexAttribState::VertexAttribState):

• platform/graphics/GraphicsContext3D.h: New enum.
• platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::drawArraysInstanced): The actual calls into OpenGL.
(WebCore::GraphicsContext3D::drawElementsInstanced): Ditto.
(WebCore::GraphicsContext3D::vertexAttribDivisor): Ditto.

• platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: Empty implementations

for non-mac platforms.

• platform/graphics/ios/GraphicsContext3DIOS.h: Define the iOS names for the

functions.

LayoutTests: Implement ANGLE_instanced_arrays
​https://bugs.webkit.org/show_bug.cgi?id=127257

Reviewed by Brent Fulgham.

Copied a slightly modified version of the Khronos instanced
arrays test (mostly modified due to the fact this comes from
an in-progress update to the test suite).

• fast/canvas/webgl/angle-instanced-arrays-expected.txt: Added.
• fast/canvas/webgl/angle-instanced-arrays.html: Added.
• fast/canvas/webgl/resources/webgl-test-utils.js:

(WebGLTestUtils): Added some new functions that were missing, and
some output to a checkColor test.

• platform/efl/TestExpectations: Skip this for EFL.
• platform/mac-mountainlion/fast/canvas/webgl/angle-instanced-arrays-expected.txt: Not

supported on Mountain Lion.

3:27 PM Changeset in webkit [162564] by timothy@apple.com

• 2 edits in trunk/Source/WebInspectorUI

Improve collapsing of TimelineDataGridNode graphs up to ancestors.

​https://bugs.webkit.org/show_bug.cgi?id=127440

Reviewed by Joseph Pecoraro.

• UserInterface/TimelineDataGridNode.js:

(WebInspector.TimelineDataGridNode.prototype.collapse):
(WebInspector.TimelineDataGridNode.prototype.createCellContent):
(WebInspector.TimelineDataGridNode.prototype.refresh):
(WebInspector.TimelineDataGridNode.prototype.needsGraphRefresh):
Notify the next visible ancestor it needs to refresh. Use needsGraphRefresh so ancestors
are notified instead of directly calling refreshGraph in some places.

3:22 PM Changeset in webkit [162563] by Alan Bujtas

• 1 edit
  10 adds in trunk/LayoutTests

Unreviewed Apple Windows port gardering after r162553.

• platform/win/fast/repaint/reflection-redraw-expected.txt: Added.
• platform/win/fast/table/dynamic-caption-add-remove-before-child-expected.txt: Added.
• platform/win/fast/table/multiple-captions-display-expected.txt: Added.
• platform/win/tables/mozilla/marvin/body_col-a-expected.txt: Added.
• platform/win/tables/mozilla/marvin/x_th_valign_baseline-expected.txt: Added.
• platform/win/tables/mozilla/other/body_col-expected.txt: Added.

3:14 PM Changeset in webkit [162562] by andersca@apple.com

• 8 edits
  1 move in trunk/Source/WebKit2

WKProcessClass should create a WebContext
​https://bugs.webkit.org/show_bug.cgi?id=127449
<rdar://problem/15885582>

Reviewed by Dan Bernstein.

• Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

• UIProcess/API/Cocoa/WKBrowsingContextController.h:
• UIProcess/API/Cocoa/WKBrowsingContextController.mm:
• UIProcess/API/Cocoa/WKProcessClass.mm:

(-[WKProcessClass initWithConfiguration:]):
(-[WKProcessClass dealloc]):
(-[WKProcessClass API::]):

• UIProcess/API/Cocoa/WKProcessClassInternal.h: Renamed from Source/WebKit2/UIProcess/API/Cocoa/WKProcessGroupInternal.h.

(WebKit::wrapper):

• UIProcess/API/Cocoa/WKProcessGroup.mm:

(-[WKProcessGroup initWithInjectedBundleURL:]):

• UIProcess/API/ios/WKContentView.mm:

(-[WKContentView _decidePolicyForGeolocationRequestFromOrigin:frame:request:]):

• WebKit2.xcodeproj/project.pbxproj:

2:57 PM Changeset in webkit [162561] by timothy@apple.com

• 5 edits in trunk/Source/WebInspectorUI

Don't include a hidden Timeline selection in the navigation path components.

​https://bugs.webkit.org/show_bug.cgi?id=127443

Reviewed by Joseph Pecoraro.

• UserInterface/GeneralTreeElementPathComponent.js:

(WebInspector.GeneralTreeElementPathComponent.prototype.get previousSibling):
(WebInspector.GeneralTreeElementPathComponent.prototype.get nextSibling):
Skip hidden siblings.

• UserInterface/OverviewTimelineView.js:

(WebInspector.OverviewTimelineView.prototype.updateLayout):
(WebInspector.OverviewTimelineView.prototype.get selectionPathComponents):
Don't include hidden selection and dispatch SelectionPathComponentsDidChange event if hidden changes.

• UserInterface/TimelineContentView.js:

(WebInspector.TimelineContentView.prototype._timeRangeSelectionChanged):
Dispatch SelectionPathComponentsDidChange event if hidden changes on the selected tree element.

• UserInterface/TimelineView.js:

(WebInspector.TimelineView.prototype.get selectionPathComponents):
Don't include hidden selection.

2:57 PM Changeset in webkit [162560] by timothy@apple.com

• 11 edits in trunk/Source/WebInspectorUI

Support collapsing call site records into the resource timeline.

Also fix some filtering and graph issues.

​https://bugs.webkit.org/show_bug.cgi?id=127440

Reviewed by Joseph Pecoraro.

• UserInterface/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel.prototype.updateFilter):
(WebInspector.NavigationSidebarPanel.prototype.applyFiltersToTreeElement.matchTextFilter):
(WebInspector.NavigationSidebarPanel.prototype.applyFiltersToTreeElement.makeVisible):
(WebInspector.NavigationSidebarPanel.prototype.applyFiltersToTreeElement):
(WebInspector.NavigationSidebarPanel.prototype._updateFilter):
Tweak how filtering happens so custom filters never expand to reveal and auto expanded
tree elements will auto-collapse again later even with custom filters.

• UserInterface/OverviewTimelineView.css:

(.timeline-view.overview > .data-grid tr.parent:not(.expanded) td.graph-column .timeline-record-bar:not(.timeline-record-type-network) > .segment):
(.timeline-view.overview > .data-grid tr.parent:not(.expanded).selected td.graph-column .timeline-record-bar:not(.timeline-record-type-network) > .segment):
(.timeline-view.overview > .data-grid:focus tr.parent:not(.expanded).selected td.graph-column .timeline-record-bar:not(.timeline-record-type-network) > .segment):
Add a shadow to provide some negative space between juxtaposed records. Only needed when not expanded and not netwrok records.

• UserInterface/OverviewTimelineView.js:

(WebInspector.OverviewTimelineView.prototype.updateLayout):
(WebInspector.OverviewTimelineView.prototype._addResourceToTreeIfNeeded):
Update the filter when current time changes and only auto expand the main resource.

• UserInterface/ResourceTimelineDataGridNode.js:

(WebInspector.ResourceTimelineDataGridNode):
(WebInspector.ResourceTimelineDataGridNode.prototype._timelineRecordUpdated):
Don't schedule a refresh of the graph if the record isn't visible.

• UserInterface/SourceCodeTimelineTimelineDataGridNode.js:

(WebInspector.SourceCodeTimelineTimelineDataGridNode):
(WebInspector.SourceCodeTimelineTimelineDataGridNode.prototype._timelineRecordAdded):
Don't schedule a refresh of the graph if the record isn't visible.

• UserInterface/TimelineContentView.js:

(WebInspector.TimelineContentView.prototype._timeRangeSelectionChanged):
Remove the boolean for updateFilter.

• UserInterface/TimelineDataGrid.js:

(WebInspector.TimelineDataGrid.prototype._refreshDirtyDataGridNodes):
(WebInspector.TimelineDataGrid.prototype._sort):
Keep the hidden state in-sync between node and element.

• UserInterface/TimelineDataGridNode.js:

(WebInspector.TimelineDataGridNode.prototype.collapse):
(WebInspector.TimelineDataGridNode.prototype.expand):
(WebInspector.TimelineDataGridNode.prototype.appendChild):
(WebInspector.TimelineDataGridNode.prototype.insertChild):
(WebInspector.TimelineDataGridNode.prototype.removeChild):
(WebInspector.TimelineDataGridNode.prototype.removeChildren):
(WebInspector.TimelineDataGridNode.prototype.removeChildrenRecursive):
(WebInspector.TimelineDataGridNode.prototype.refreshGraph.createBarsForRecords):
(WebInspector.TimelineDataGridNode.prototype.refreshGraph.else.collectRecordsByType.get if):
(WebInspector.TimelineDataGridNode.prototype.needsGraphRefresh):
(WebInspector.TimelineDataGridNode.prototype.isRecordVisible):
Support drawing the children records on the parent graph.

• UserInterface/TimelineRecordBar.css:

(.timeline-record-bar.unfinished > .segment):
(:focus .selected .timeline-record-bar > .segment):
(:focus .selected .timeline-record-bar > .segment.inactive):
(:focus .selected .timeline-record-bar.has-inactive-segment > .segment:not(.inactive)):
Tweaked styles to look bettwen when selected.

• UserInterface/TimelineRecordBar.js:

(WebInspector.TimelineRecordBar.recordsCannotBeCombined):
(WebInspector.TimelineRecordBar.prototype.set records):
(WebInspector.TimelineRecordBar.prototype.refresh):
Drive-by fixes for some bug with bars being reused.

2:56 PM Changeset in webkit [162559] by Alan Bujtas

• 6 edits in trunk

[CSS Shapes] shape-inside rectangle layout can fail
​https://bugs.webkit.org/show_bug.cgi?id=124784

Reviewed by Darin Adler.

Early subpixel rounding/flooring/ceiling can have unwanted
side effect on the final pixel value. Delay pixel
conversions as much as possible.

Existing test is changed to reflect subpixel functionality.

Source/WebCore:

• rendering/shapes/RectangleShape.cpp:

(WebCore::RectangleShape::firstIncludedIntervalLogicalTop):

LayoutTests:

• fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top-expected.html:
• platform/mac/TestExpectations:
• platform/win/TestExpectations:

2:38 PM Changeset in webkit [162558] by Brent Fulgham

• 1 edit in branches/safari-537.75-branch/Source/JavaScriptCore/jit/JITStubsMSVC64.asm

Back out accidental assembly change.

2:37 PM Changeset in webkit [162557] by Brent Fulgham

• 9 edits in branches/safari-537.75-branch/Tools

Merge r157882

2013-10-23 Alex Christensen <​achristensen@webkit.org>

Explicitly build Win32 or x64 configuration on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=123206

Reviewed by Brent Fulgham.

• Scripts/webkitdirs.pm: (jscPath): (determineConfigurationForVisualStudio): (determinePassedConfiguration): Add |Win32 to the end of 32-bit Visual Studio build configurations. (safariPath):
• Scripts/build-webkit:
• Scripts/old-run-webkit-tests:
• Scripts/run-api-tests: (testToolPath):
• Scripts/run-javascriptcore-tests: (testapiPath):
• Scripts/run-regexp-tests: (testapiPath):
• Scripts/sunspider-compare-results: (pathToBuiltJSC): Use configuration instead of configurationForVisualStudio, which are now always different.

2:18 PM Changeset in webkit [162556] by timothy_horton@apple.com

• 3 edits in trunk/Source/WebKit2

Crashes in DrawingAreaProxy::setExposedRect (null DrawingAreaProxy)
​https://bugs.webkit.org/show_bug.cgi?id=127445

Reviewed by Anders Carlsson.

• UIProcess/API/ios/WKContentView.mm:

(-[WKContentView _updateViewExposedRect]):

• UIProcess/API/mac/WKView.mm:

(-[WKView _updateViewExposedRect]):
Null-check.

2:17 PM Changeset in webkit [162555] by jochen@chromium.org

• 6 edits in trunk/Source/WebCore

Add protocolIsInHTTPFamily for strings and use it where appropriate
​https://bugs.webkit.org/show_bug.cgi?id=127336

Reviewed by Alexey Proskuryakov.

• html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parseAttribute):

• page/ContentSecurityPolicy.cpp:

(WebCore::CSPSource::schemeMatches):

• page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::generateReferrerHeader):

• platform/URL.cpp:

(WebCore::protocolIsInHTTPFamily):

• platform/URL.h:

2:16 PM Changeset in webkit [162554] by andersca@apple.com

• 2 edits
  2 adds in trunk/Source/WebKit2

Add WKWebView class
​https://bugs.webkit.org/show_bug.cgi?id=127444
<rdar://problem/15884418>

Reviewed by Dan Bernstein.

• UIProcess/API/Cocoa/WKWebView.h: Added.
• UIProcess/API/Cocoa/WKWebView.mm: Added.

(-[WKWebView initWithFrame:configuration:]):
(-[WKWebView configuration]):

• WebKit2.xcodeproj/project.pbxproj:

2:03 PM Changeset in webkit [162553] by Alan Bujtas

• 24 edits
  1 delete in trunk

Subpixel Layout: SimpleLineLayout needs more position rounding to match InlineFlowBox layout.
​https://bugs.webkit.org/show_bug.cgi?id=127404

Reviewed by Antti Koivisto.

In order to produce a CSS pixel perfect layout, SimpleLineLayout needs to
round line positions to CSS (integral) position similarly to InlineFlowBox.

Source/WebCore:

Existing tests cover it.

• rendering/SimpleLineLayoutResolver.h:

(WebCore::SimpleLineLayout::RunResolver::Run::rect):
(WebCore::SimpleLineLayout::RunResolver::Run::baseline):

LayoutTests:

• platform/mac/css1/box_properties/padding-expected.txt:
• platform/mac/css1/box_properties/padding_top-expected.txt:
• platform/mac/css1/formatting_model/vertical_formatting-expected.txt:
• platform/mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
• platform/mac/css2.1/t0804-c5510-padn-00-b-ag-expected.txt:
• platform/mac/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
• platform/mac/fast/css/empty-pseudo-class-expected.txt:
• platform/mac/fast/css/fieldset-display-row-expected.txt:
• platform/mac/fast/css/first-child-pseudo-class-expected.txt:
• platform/mac/fast/css/last-child-pseudo-class-expected.txt:
• platform/mac/fast/css/only-child-pseudo-class-expected.txt:
• platform/mac/fast/repaint/reflection-redraw-expected.txt:
• platform/mac/fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top-expected.png: Removed.
• platform/mac/fast/table/dynamic-caption-add-remove-before-child-expected.txt:
• platform/mac/fast/table/multiple-captions-display-expected.txt:
• platform/mac/tables/mozilla/marvin/body_col-expected.txt:
• platform/mac/tables/mozilla/marvin/x_th_valign_baseline-expected.txt:
• platform/mac/tables/mozilla/other/body_col-expected.txt:
• platform/mac/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
• platform/mac/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
• platform/mac/tables/mozilla_expected_failures/core/captions3-expected.txt:
• platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:

1:58 PM Changeset in webkit [162552] by Brent Fulgham

• 5 edits
  1 copy in branches/safari-537.75-branch

Merge r157607

2013-10-17 Alex Christensen <​achristensen@webkit.org>

Run JavaScriptCore tests again on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=122787

Reviewed by Tim Horton.

Source/JavaScriptCore:

• JavaScriptCore.vcxproj/JavaScriptCore.sln: Added.
• jit/JITStubsMSVC64.asm: Removed reference to cti_vm_throw unused since r157581.

Tools:

• Scripts/build-jsc: (buildMyProject): Use JavaScriptCore.sln to build JavaScriptCore and WTF.
• Scripts/run-javascriptcore-tests: Don't run stress tests on WinCairo.
• Scripts/webkitdirs.pm: (determineConfigurationForVisualStudio): (determineConfigurationProductDir): Build directory should end with bin64 and configuration should end with |x64 on Win64. (isAppleWinWebKit): (copyInspectorFrontendFiles): (setPathForRunningWebKitApp): Separated WinCairo directories and options from AppleWin.

1:56 PM Changeset in webkit [162551] by fpizlo@apple.com

• 4 edits in branches/jsCStack/Source/JavaScriptCore

FTL should support CheckArgumentsNotCreated
​https://bugs.webkit.org/show_bug.cgi?id=127384

Reviewed by Mark Hahnenberg.

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLCompile.cpp:

(JSC::FTL::fixFunctionBasedOnStackMaps):

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCheckArgumentsNotCreated):

1:02 PM Changeset in webkit [162550] by Joseph Pecoraro

• 7 edits in trunk/Source/WebCore

Unreviewed rollout of r162534, this caused inspector test failures.

• bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::addListener):
(WebCore::PageScriptDebugServer::removeListener):
(WebCore::PageScriptDebugServer::recompileAllJSFunctions):
(WebCore::PageScriptDebugServer::didRemoveLastListener):

• bindings/js/PageScriptDebugServer.h:
• bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::recompileAllJSFunctionsSoon):
(WebCore::ScriptDebugServer::recompileAllJSFunctionsTimerFired):

• bindings/js/ScriptDebugServer.h:
• bindings/js/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::addListener):
(WebCore::WorkerScriptDebugServer::recompileAllJSFunctions):
(WebCore::WorkerScriptDebugServer::removeListener):

• inspector/InspectorProfilerAgent.cpp:

12:29 PM Changeset in webkit [162549] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Fix 32-bit build.

• UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

12:18 PM Changeset in webkit [162548] by timothy_horton@apple.com

• 4 edits in trunk/Source/WebKit2

[wk2] Scroll pinning state is wrong until the first scroll event
​https://bugs.webkit.org/show_bug.cgi?id=127437

Reviewed by Simon Fraser.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::didChangeScrollOffset):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updateMainFrameScrollOffsetPinning):
(WebKit::WebPage::didCommitLoad):

• WebProcess/WebPage/WebPage.h:

Rename WebPage::didChangeScrollOffsetForMainFrame to
updateMainFrameScrollOffsetPinning, which better describes what it
actually does. Call it when a load is committed, so that we have valid
pinning state before the first scroll event comes in.

12:17 PM Changeset in webkit [162547] by andersca@apple.com

• 2 edits
  2 adds in trunk/Source/WebKit2

Add WKWebViewConfiguration class
​https://bugs.webkit.org/show_bug.cgi?id=127436
<rdar://problem/15882923>

Reviewed by Tim Horton.

• UIProcess/API/Cocoa/WKWebViewConfiguration.h: Added.
• UIProcess/API/Cocoa/WKWebViewConfiguration.mm: Added.

(-[WKWebViewConfiguration copyWithZone:]):

• WebKit2.xcodeproj/project.pbxproj:

12:08 PM Changeset in webkit [162546] by alice.liu@apple.com

• 3 edits in trunk/Source/WebKit2

[WK2] add cocoa API for private browsing setting
​https://bugs.webkit.org/show_bug.cgi?id=127391

Reviewed by Sam Weinig.

• UIProcess/API/Cocoa/WKBrowsingContextGroup.h:
• UIProcess/API/Cocoa/WKBrowsingContextGroup.mm:

(-[WKBrowsingContextGroup privateBrowsingEnabled]):
(-[WKBrowsingContextGroup setPrivateBrowsingEnabled:]):
Adding some API for the private Browsing setting. Reaches through
to the WKPageGroup's preferences.

11:55 AM Changeset in webkit [162545] by Martin Robinson

• 3 edits in trunk/Tools

[GTK][CMake] build-webkit should try harder to avoid re-running cmake
​https://bugs.webkit.org/show_bug.cgi?id=127073

Reviewed by Daniel Bates.

• Scripts/build-webkit: Unify all the ports that call buildCMakeProjectOrExit with

the new isCMakeBuild conditional. This allows us to share more code between ports.
Pass the build arguments to the removeCMakeCache function.

• Scripts/webkitdirs.pm:

(runAutogenForAutotoolsProjectIfNecessary): Renamed mustReRunAutogen to cachedArgumentFileOutOfDate
because it's now shared with the CMake build.
(cachedArgumentFileOutOfDate): Renamed.
(cmakeCachePath): Added this helper which gets the CMakeCache.txt path.
(shouldRemoveCMakeCache): Tries to preserve current behavior for all ports,
except GTK+ which examines the OptionsGTK.cmake and OptionsCommon.cmake file
as well as checking if build-webkit has been run with different arguments.
(removeCMakeCache): Call shouldRemoveCMakeCache now.
(generateBuildSystemFromCMakeProject): Exit early if CMakeCache.txt exists for GTK+.
(isCMakeBuild): Added.

11:55 AM Changeset in webkit [162544] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Crashes in setTextForIterator
​https://bugs.webkit.org/show_bug.cgi?id=127424

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-01-22
Reviewed by Brent Fulgham.

• platform/text/icu/UTextProviderLatin1.cpp:

(WebCore::uTextLatin1Clone): Provide correct buffer size in utext_setup function call.
(WebCore::uTextLatin1Access): Give correct buffer size to memset call.
(WebCore::openLatin1UTextProvider): Ditto.

11:53 AM Changeset in webkit [162543] by ap@apple.com

• 2 edits in trunk/LayoutTests

REGRESSION: fast/js/dfg-* typed array tests frequently time out on debug bots
​https://bugs.webkit.org/show_bug.cgi?id=126166

Rubber-stamped by Filip Pizlo.

• TestExpectations: Skipped these tests in debug builds.

11:42 AM Changeset in webkit [162542] by Brent Fulgham

• 4 edits in branches/safari-537.75-branch/Source/WebCore

Unreviewed build fix for branch.

• WebCore.vcxproj/WebCore.vcxproj: Correct merged files.
• WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
• platform/graphics/cg/GraphicsContextCG.cpp: Remove work-around implementation (from branch)

now that WKSI provides the method.

11:26 AM Changeset in webkit [162541] by andersca@apple.com

• 4 edits
  1 copy
  1 add in trunk/Source/WebKit2

Add WKProcessClass class
​https://bugs.webkit.org/show_bug.cgi?id=127433
<rdar://problem/15882582>

Reviewed by Dan Bernstein.

Add a stubbed out WKProcessClass class.

• Shared/API/Cocoa/WKFoundation.h:
• UIProcess/API/Cocoa/WKProcessClass.h: Added.
• UIProcess/API/Cocoa/WKProcessClass.mm: Added.

(-[WKProcessClass initWithConfiguration:]):
(-[WKProcessClass configuration]):

• UIProcess/API/Cocoa/WKProcessClassConfiguration.mm:
• WebKit2.xcodeproj/project.pbxproj:

11:24 AM Changeset in webkit [162540] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

[Mac] MediaPlayerPrivateMediaSourceAVFObjC::load ASSERTs on lots of tests
​https://bugs.webkit.org/show_bug.cgi?id=127430

Reviewed by Eric Carlson.

When other registered media engines cannot load a URL, the engine selection
will eventually pick MediaPlayerPrivateMediaSourceAVFObjC and ask it to load
the URL. Instead of ASSERTing here, simply reject the URL by setting the
network state to FormatError.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::load):

11:21 AM Changeset in webkit [162539] by msaboff@apple.com

• 2 edits in branches/jsCStack/Source/WTF

Merge trunk r160838

2013-12-18 Daniel Bates <​dabates@apple.com>

WTF, JavaScriptCore fails to build with trunk clang: operators new, new[],
delete, delete[] cannot be declared inline
​https://bugs.webkit.org/show_bug.cgi?id=124186
<rdar://problem/15644039>

Reviewed by Geoffrey Garen and Anders Carlsson.

Following <​http://llvm.org/viewvc/llvm-project?view=revision&revision=193044>
(​http://llvm.org/bugs/show_bug.cgi?id=17591>), Clang emits warnings when
operator new, delete are inlined. Such definitions cannot be inline per
replacement.functions (17.6.4.6/3) of the C++ standard. For now,
disable these warnings instead of exporting these functions.

• wtf/FastMalloc.h:

11:21 AM Changeset in webkit [162538] by thiago.lacerda@openbossa.org

• 15 edits in trunk

[EFL][GTK] Get EFL and GTK compiling with ACCESSIBILITY disabled
​https://bugs.webkit.org/show_bug.cgi?id=127119

Reviewed by Mario Sanchez Prada.

Source/WebCore:

At build time, the compiler was not able to determine which Timer's constructor to call in AXObjectCache when
ACCESSIBILITY is not enabled, fixing that.
Also guarding some members in AccessibilityObject that are only being used by EFL and GTK with ACCESSIBILITY.

• accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::AXObjectCache):

• accessibility/AccessibilityObject.h:

Source/WebKit/gtk:

Guarding ACCESSIBILITY code with HAVE(ACCESSIBILITY).

• webkit/webkitwebview.cpp:

(webkit_web_view_class_init):

Source/WebKit2:

Guarding ACCESSIBILITY code with HAVE(ACCESSIBILITY).

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/gtk/WebPageGtk.cpp:

(WebKit::WebPage::platformInitialize):

Tools:

Guarding ACCESSIBILITY code in DumpRenderTree and WebKitTestRunner with HAVE(ACCESSIBILITY).

• DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
• DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
• DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):
(webViewWindowObjectCleared):
(main):

• WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:

(WTR::AccessibilityController::platformName):

• WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::isIndeterminate):

11:10 AM Changeset in webkit [162537] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Refactor calculation of hasRx and hasRy values in SVGPathData
​https://bugs.webkit.org/show_bug.cgi?id=127423

Patch by Peter Molnar <​pmolnar.u-szeged@partner.samsung.com> on 2014-01-22
Reviewed by Darin Adler.

This is a follow-up on ​https://bugs.webkit.org/show_bug.cgi?id=127337

• rendering/svg/SVGPathData.cpp:

(WebCore::updatePathFromRectElement):

11:00 AM Changeset in webkit [162536] by Martin Robinson

• 6 edits in trunk

[GTK][CMake] Add support for building the NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=127195

Reviewed by Daniel Bates.

.:

• Source/cmake/OptionsGTK.cmake: Turn on the network process and give it

a name like the WebProcess.

Source/WebKit2:

• CMakeLists.txt: Add shared network process build instructions.
• PlatformEfl.cmake: Move build instructions to the platform-independent file.
• PlatformGTK.cmake: Add some files to the source lists.

10:59 AM Changeset in webkit [162535] by Martin Robinson

• 2 edits in trunk/Source/WebKit

[GTK] Avoid a circular dependency when building webkitenumtypes.h
​https://bugs.webkit.org/show_bug.cgi?id=127199

Reviewed by Daniel Bates.

• PlatformGTK.cmake: Create a new list of headers consisting of all installed headers

except webkitenumtypes.h. Use this list when generating webkitenumtypes.h.

10:57 AM Changeset in webkit [162534] by Joseph Pecoraro

• 7 edits in trunk/Source/WebCore

Web Inspector: Remove recompileAllJSFunctions timer in ScriptDebugServer
​https://bugs.webkit.org/show_bug.cgi?id=127409

Reviewed by Timothy Hatcher.

• bindings/js/ScriptDebugServer.h:
• bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::ScriptDebugServer):
Remove m_recompileTimer and the recompile soon function.
We can just recompile immediately in all existing cases.

• bindings/js/PageScriptDebugServer.h:
• bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::addListener):
(WebCore::PageScriptDebugServer::removeListener):
(WebCore::PageScriptDebugServer::recompileAllJSFunctions):
(WebCore::PageScriptDebugServer::didAddFirstListener):
(WebCore::PageScriptDebugServer::didRemoveLastListener):
Add a "didAddFirstListener" to match "didRemoveLastListener".
Only recompile functions when we attach the debugger and when
we detach the last listener.

• bindings/js/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::addListener):
(WebCore::WorkerScriptDebugServer::removeListener):
(WebCore::WorkerScriptDebugServer::recompileAllJSFunctions):
Same thing. Also rearrange the functions to read better.

• inspector/InspectorProfilerAgent.cpp:

Use the direct recompile function instead of the removed "soon" version.

10:47 AM Changeset in webkit [162533] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit2

REGRESSION(r162441): [GTK] ResourceLoader is broken when there aren't user extensions
​https://bugs.webkit.org/show_bug.cgi?id=127422

Reviewed by Anders Carlsson.

• WebProcess/gtk/WebGtkExtensionManager.cpp:

(WebKit::WebGtkExtensionManager::initialize): Always create the
WebKitWebExtension object since it's used internally to implement
the ResourceLoader client.

10:47 AM Changeset in webkit [162532] by Michał Pakuła vel Rutka

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening

Add some http/tests/websocket/tests/hybi tests to skipped list as they crash
generating thousands lines of error messages.

• platform/efl/TestExpectations:

10:29 AM Changeset in webkit [162531] by jer.noble@apple.com

• 2 edits
  1 move in trunk/Source/WebKit2

[Mac][WK2] Unable to play video protected by session cookies
​https://bugs.webkit.org/show_bug.cgi?id=127207

Reviewed by Sam Weinig.

Recent changes in our underlying media frameworks caused our shimmed methods
in CookieStorageShim to stop being called. Insert an objective-c shim in addition
to our original shim to intercept pulling cookies out of cookie storage.

• Shared/mac/CookieStorageShim.mm: Renamed from Source/WebKit2/Shared/mac/CookieStorageShim.cpp.

(WebKit::CookieStorageShim::initialize): Insert the shim.
(-[WKNSURLSessionLocal _copyCookiesForRequestUsingAllAppropriateStorageSemantics:]):

Pass through to webKitCookieStorageCopyRequestHeaderFieldsForURL().

• WebKit2.xcodeproj/project.pbxproj: Rename CookieStorageShim.cpp -> .mm.

10:20 AM Changeset in webkit [162530] by commit-queue@webkit.org

• 7 edits in trunk/Source/WebCore

[curl] Improve detecting and handling of SSL client certificate
​https://bugs.webkit.org/show_bug.cgi?id=125006

Patch by Robert Sipka <​sipka@inf.u-szeged.hu> on 2014-01-22
Reviewed by Brent Fulgham.

Add client certificate handling.

• platform/network/ResourceHandle.h:
• platform/network/curl/ResourceError.h:

(WebCore::ResourceError::hasSSLConnectError):

• platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandle::setClientCertificateInfo):

• platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::initializeHandle):

• platform/network/curl/SSLHandle.cpp:

(WebCore::addAllowedClientCertificate):
(WebCore::setSSLClientCertificate):

• platform/network/curl/SSLHandle.h:

10:16 AM Changeset in webkit [162529] by jae.park@company100.net

• 2 edits in trunk/Source/WTF

Remove unnecessary include in Noncopyable.h
​https://bugs.webkit.org/show_bug.cgi?id=127406

Reviewed by Anders Carlsson.

• wtf/Noncopyable.h: We don't need Compiler.h as of r162198.

9:54 AM Changeset in webkit [162528] by timothy@apple.com

• 2 edits in trunk/Source/WebInspectorUI

Remember the Timeline Overview zoom and selection between sessions.

​https://bugs.webkit.org/show_bug.cgi?id=127369

Reviewed by Joseph Pecoraro.

• UserInterface/TimelineOverview.js:

(WebInspector.TimelineOverview):
(WebInspector.TimelineOverview.prototype.set secondsPerPixel):
(WebInspector.TimelineOverview.prototype._timeRangeSelectionChanged):

9:54 AM Changeset in webkit [162527] by timothy@apple.com

• 8 edits in trunk/Source/WebInspectorUI

Show the Resource and Record selection path in the navigation bar for Timeline views.

​https://bugs.webkit.org/show_bug.cgi?id=127367

Reviewed by Joseph Pecoraro.

• UserInterface/LayoutTimelineView.js:

(WebInspector.LayoutTimelineView.prototype.treeElementPathComponentSelected):
(WebInspector.LayoutTimelineView.prototype._dataGridNodeSelected):

• UserInterface/NetworkTimelineView.js:

(WebInspector.NetworkTimelineView.prototype.treeElementPathComponentSelected):
(WebInspector.NetworkTimelineView.prototype._dataGridNodeSelected):

• UserInterface/OverviewTimelineView.js:

(WebInspector.OverviewTimelineView.prototype.get selectionPathComponents):
(WebInspector.OverviewTimelineView.prototype.treeElementPathComponentSelected):
(WebInspector.OverviewTimelineView.prototype._dataGridNodeSelected):

• UserInterface/ScriptTimelineView.js:

(WebInspector.ScriptTimelineView.prototype.treeElementPathComponentSelected):
(WebInspector.ScriptTimelineView.prototype._dataGridNodeSelected):

• UserInterface/TimelineContentView.js:

(WebInspector.TimelineContentView.prototype._timelineViewSelectionPathComponentsDidChange):
(WebInspector.TimelineContentView.prototype._showTimelineView):

• UserInterface/TimelineDataGrid.js:

(WebInspector.TimelineDataGrid.prototype.treeElementForDataGridNode):
(WebInspector.TimelineDataGrid.prototype.dataGridNodeForTreeElement):

• UserInterface/TimelineView.js:

(WebInspector.TimelineView.prototype.get selectionPathComponents):
(WebInspector.TimelineView.prototype.treeElementPathComponentSelected):

9:38 AM Changeset in webkit [162526] by Brent Fulgham

• 3 edits in branches/safari-537.75-branch/WebKitLibraries

Merge r154534

2013-08-23 Brent Fulgham <Brent Fulgham>

[Windows] Unreviewed build correction.

• win/lib32/WebKitSystemInterface.lib: Update with new API for r132545.

9:35 AM Changeset in webkit [162525] by mitz@apple.com

• 2 edits in trunk/Source/WebKit/mac

Build fix for iOS clients of WebUIDelegatePrivate.h.

• WebView/WebUIDelegatePrivate.h: Ensure that ENABLE_DASHBOARD_SUPPORT is defined on iOS.

9:30 AM Changeset in webkit [162524] by Brent Fulgham

• 2 edits in branches/safari-537.75-branch/Source/WebCore

Merge r154526

2014-01-22 Brent Fulgham <Brent Fulgham>

[Windows] Unreviewed build correction. Need to force environment variable
to be escaped when running nmake command.

• WebCore.vcxproj/WebCoreGenerated.make:

9:30 AM Changeset in webkit [162523] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebCore

[CSS Regions] layerOwner in RenderNamedFlowFragment cannot return null
​https://bugs.webkit.org/show_bug.cgi?id=127343

Patch by Mihai Maerean <Mihai Maerean> on 2014-01-22
Reviewed by Sam Weinig.

RenderNamedFlowFragment::layerOwner cannot return null because regions create stacking
contexts which create layers.

No new tests, no functional change.

• rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::hasCompositingRegionDescendant):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::adjustAncestorCompositingBoundsForFlowThread):

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeRegionCompositingRequirements):

• rendering/RenderNamedFlowFragment.h:

9:25 AM Changeset in webkit [162522] by Brent Fulgham

• 2 edits in branches/safari-537.75-branch/Source/WTF

Merge r154520

2013-08-23 Brent Fulgham <Brent Fulgham>

[Windows] Unreviewed build correction after r154513.

• WTF.vcxproj/build-generated-files.sh: Variable was missing '$' character.

9:19 AM Changeset in webkit [162521] by msaboff@apple.com

• 13 edits in branches/jsCStack/Source/JavaScriptCore

CStack Branch: Fix DFG for X86-32
​https://bugs.webkit.org/show_bug.cgi?id=127407

Reviewed by Filip Pizlo.

Made DFG calling convention changes. Change frameRegisterCount() to
appropriately round so the stack pointer will end up being properly aligned.
Removed some stack pointer alignment checks that are before setting
the stack pointer.

Fixed maxFrameExtentForSlowPathCall to account that the most arguments we
actually use when calling a helper is 7. Added a compile assert to make
sure that maxFrameExtentForSlowPathCall has the right padding. Made the
corresponding changes in the LLInt.

Moved the stack pointer down by maxFrameExtentForSlowPathCall before calling
a helper when the stack pointer hasn't been properly set up.

Eliminated emitGetReturnPCFromCallFrameHeaderPtr() since it is no longer called.

Moved the stack pointer down in ThunkGenerators::defineUnaryDoubleOpWrapper()
to align it for storing xmm arguments and making a call to the helper.

Fixed an issue where ArityCheckFailReturnThunks was clobbering edx. Changed
it to use regT4 (edi) instead of regT1 (edx).

Made temporary space on the stack for in the LLInt when calling out to C code
when the stack ponter hasn't been properly set up for a code block.

• assembler/MaxFrameExtentForSlowPathCall.h:
• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::frameRegisterCount):

• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

• jit/ArityCheckFailReturnThunks.cpp:

(JSC::ArityCheckFailReturnThunks::returnPCsFor):

• jit/AssemblyHelpers.h:
• jit/JIT.cpp:

(JSC::JIT::privateCompile):

• jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCall):

• jit/JITInlines.h:

(JSC::JIT::emitNakedCall):

• jit/ThunkGenerators.cpp:

(JSC::nativeForGenerator):

• llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

• llint/LowLevelInterpreter.asm:

8:52 AM Changeset in webkit [162520] by msaboff@apple.com

• 2 edits in branches/jsCStack/Source/JavaScriptCore

Unreviewed build fix for non FTL platforms.

• ftl/FTLValueRange.cpp: Encapsulated code within #if ENABLE(FTL_JIT) / #endif

8:41 AM Changeset in webkit [162519] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=127380
Add more methods to WKWebProcessPlugInNodeHandle.

Patch by Yongjun Zhang <​yongjun_zhang@apple.com> on 2014-01-22
Reviewed by Sam Weinig.

Add a static method that creates a WKWebProcessPlugInNodeHandle from a JSValue* and a JSContext*. Also
add a method to return the iframe's content frame from a WKWebProcessPlugInNodeHandle.

• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h:
• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:

(+[WKWebProcessPlugInNodeHandle nodeHandleWithJSValue:inContext:]):
(-[WKWebProcessPlugInNodeHandle htmlIFrameElementContentFrame]):

8:15 AM Changeset in webkit [162518] by Antti Koivisto

• 3 edits in trunk/Source/WebCore

Avoid unthrottled layer flushes triggered by RenderLayerCompositor::ensureRootLayer
​https://bugs.webkit.org/show_bug.cgi?id=127426

Reviewed by Anders Carlsson.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateScrollLayerPosition):
(WebCore::RenderLayerCompositor::frameViewDidScroll):

Factor scroll layer position update to a function.

(WebCore::RenderLayerCompositor::ensureRootLayer):

Stop calling frameViewDidChangeSize/frameViewDidScroll. Instead call the relevent functions
directly. This avoid unthrottled layer flush that is done when the view actually scrolls.

• rendering/RenderLayerCompositor.h:

6:53 AM Changeset in webkit [162517] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

[CSS Background Blending] -webkit-background-blend-mode fails for certain SVG files
​https://bugs.webkit.org/show_bug.cgi?id=127350

Patch by Mihai Tica <​mitica@adobe.com> on 2014-01-22
Reviewed by Dirk Schulze.

Source/WebCore:

The graphics context of the SVG inherits the blend mode set
on the background layer. Fix consists in drawing the SVG
in a transparency layer.

Test: css3/compositing/background-blend-mode-svg.html

• svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::draw): Begin a transparency layer if a blend mode is set.

LayoutTests:

• css3/compositing/background-blend-mode-svg-expected.html: Added.
• css3/compositing/background-blend-mode-svg.html: Added.

6:03 AM Changeset in webkit [162516] by Carlos Garcia Campos

• 4 edits
  3 adds in trunk

[GTK] Add GUniquePtr
​https://bugs.webkit.org/show_bug.cgi?id=127170

Reviewed by Gustavo Noronha Silva.

Source/WTF:

The idea is to replace GOwnPtr with a template alias of
std:unique_ptr. Not everything can be replaced, though, because
GOwnPtr::outPtr() doesn't seem to be possible to implement with
unique_ptr. This smart pointer is more flexible than GOwnPtr and
allows to transfer the ownership of the pointer using
std::move().

• GNUmakefile.list.am: Add new file to compilation.
• wtf/gobject/GUniquePtr.h: Added.

(WTF::GPtrDeleter::operator()):

Tools:

Add unit tests for GUniquePtr.

• TestWebKitAPI/GNUmakefile.am: Add new file to compilation.
• TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp: Added.

(log):
(takeLogStr):
(TestWebKitAPI::TEST):

5:07 AM Changeset in webkit [162515] by Antti Koivisto

• 4 edits in trunk

Update overlay scrollbars in single pass
​https://bugs.webkit.org/show_bug.cgi?id=127289

Source/WebCore:

Reviewed by Anders Carlsson.

• platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):

Multi-pass scrollbar resolution is only needed for traditional scrollbars. Overlay scrollbars don't affect layout.

LayoutTests:

• platform/mac/accessibility/iframe-aria-hidden.html:

Try to keep this non-flaky by forcing layout. Real fix would probably be in the
accessibility test framework.

3:40 AM Changeset in webkit [162514] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit2

Unreviewed. Fix GTK+ build with CUSTOM_PROTOCOL enabled after r162449.

• UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManager.h:

Use override instead of OVERRIDE.

3:15 AM Changeset in webkit [162513] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

Build fixes for FreeBSD.
​https://bugs.webkit.org/show_bug.cgi?id=126779

Patch by Koop Mast <​kwm@FreeBSD.org> on 2014-01-22
Reviewed by Csaba Osztrogonác.

• UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:

(WebKit::PluginProcessProxy::scanPlugin):

3:03 AM Changeset in webkit [162512] by jinwoo7.song@samsung.com

• 6 edits
  2 deletes in trunk/Tools

Remove Nix files from Tools
​https://bugs.webkit.org/show_bug.cgi?id=127418

Reviewed by Csaba Osztrogonác.

• Scripts/build-webkit:
• Scripts/update-webkit-libs-jhbuild:
• Scripts/webkitdirs.pm:

(determineArchitecture):
(argumentsForConfiguration):
(jscProductDir):
(builtDylibPathForName):
(isAppleWebKit):
(launcherPath):
(launcherName):
(checkRequiredSystemConfig):
(copyInspectorFrontendFiles):
(jhbuildWrapperPrefixIfNeeded):
(buildCMakeProjectOrExit):
(cmakeBasedPortName):

• Scripts/webkitpy/common/config/ports.py:

(DeprecatedPort.port):
(EflWK2Port.build_webkit_command):

• Scripts/webkitpy/port/factory.py:

(platform_options):
(PortFactory):

• Scripts/webkitpy/port/nix.py: Removed.
• Scripts/webkitpy/port/nix_unittest.py: Removed.

1:00 AM Changeset in webkit [162511] by jinwoo7.song@samsung.com

• 6 edits in trunk/Source/WebKit2

[EFL][WK2] Use std::function in the rest of EFL's WorkQueue implementation
​https://bugs.webkit.org/show_bug.cgi?id=127397

Reviewed by Anders Carlsson.

Move to using std::function and move semantics in WorkQueue::registerSocketEventHandler
and DispatchQueue::setSocketEventHandler.

• Platform/IPC/unix/ConnectionUnix.cpp:

(IPC::Connection::open):

• Platform/WorkQueue.h:
• Platform/efl/DispatchQueueEfl.cpp:

(DispatchQueue::setSocketEventHandler):

• Platform/efl/DispatchQueueEfl.h:
• Platform/efl/WorkQueueEfl.cpp:

(WorkQueue::registerSocketEventHandler):

12:50 AM Changeset in webkit [162510] by ChangSeok Oh

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening

Remove test expectations for passed tests.
fast/parser/document-write-basic.html is marked crash but passed.
fast/forms/select-live-pseudo-selectors.html is marked crash but passed.

• platform/gtk-wk2/TestExpectations:

12:40 AM Changeset in webkit [162509] by ap@apple.com

• 2 edits in trunk/LayoutTests

inspector-protocol/page/deny-X-FrameOption.html is very flaky
​https://bugs.webkit.org/show_bug.cgi?id=127414

• inspector-protocol/page/deny-X-FrameOption.html: Speculative fix, don't manipulate

a frame before onload, even if it's empty.

12:30 AM Changeset in webkit [162508] by mihnea@adobe.com

• 3 edits
  2 adds in trunk

[CSSRegions] Incorrect layout of a region pseudo children
​https://bugs.webkit.org/show_bug.cgi?id=126146

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/collapse-anonymous-region.html

A region behaviour, styled using -webkit-flow-from, is modeled using an anonymous
block created to fragment the named flow content inside the region. We have to prevent
the behaviour of anonymous children collapsing for this block to make sure that the
region element children are still laid out properly when the region element becomes an ordinary
element.

• rendering/RenderBlockFlow.h:

LayoutTests:

• fast/regions/collapse-anonymous-region-expected.html: Added.
• fast/regions/collapse-anonymous-region.html: Added.

Jan 21, 2014:

11:45 PM Changeset in webkit [162507] by ryuan.choi@samsung.com

• 4 edits in trunk

Remove unused "acceleratedCompositingForScrollableFramesEnabled" setting
​https://bugs.webkit.org/show_bug.cgi?id=127402

Reviewed by Anders Carlsson.

Source/WebCore:

compositing/iframes/iframe-composited-scrolling.html is updated because
there are no usages in WebCore.

• page/Settings.in:

LayoutTests:

• compositing/iframes/iframe-composited-scrolling.html:

Removed acceleratedCompositingForScrollableFramesEnabled changes because
it is dead code in WebCore side.

10:36 PM Changeset in webkit [162506] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Compile fix for using libsoup on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=127377

Patch by Alex Christensen <​achristensen@webkit.org> on 2014-01-21
Reviewed by Daniel Bates.

• platform/network/soup/ProxyResolverSoup.cpp:

(soupProxyResolverWkSetProperty):
(soupProxyResolverWkGetProperty):
(soupProxyResolverWkGetProxyURISync):
Replaced uint with unsigned.

10:18 PM Changeset in webkit [162505] by timothy_horton@apple.com

• 25 edits in trunk/Source/WebKit2

[wk2] De-.get()ify receivers of Objective-C messages
​https://bugs.webkit.org/show_bug.cgi?id=127398

Reviewed by Sam Weinig.

RetainPtr does the right thing when you use it as the
receiver of an Obj-C message, so we don't need .get().

Long and useless file list elided.

10:08 PM Changeset in webkit [162504] by mitz@apple.com

• 2 edits in trunk/Source/WebKit/mac

Added a method declaration that was missed in r161185.

Reviewed by Sam Weinig.

• WebView/WebViewPrivate.h: Declared -removeVisitedLink:.

9:50 PM Changeset in webkit [162503] by dbates@webkit.org

• 2 edits in trunk/Source/WebCore

Break up single assertion into two assertions in HTMLMediaElement::returnPlatformLayer()

Following up after <​http://trac.webkit.org/changeset/162473>, we should break up
the assertion into two assertions as suggested by Darin Adler. Separating the single
assertion into two assertions makes it straightforward to determine the conjunct that
failed among other benefits.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

9:17 PM Changeset in webkit [162502] by benjamin@webkit.org

• 2 edits in trunk/Tools

Add Ian and Ricky to the contributor list

• Scripts/webkitpy/common/config/contributors.json:

I am too old to remember all those email addresses :)

9:15 PM Changeset in webkit [162501] by beidson@apple.com

• 9 edits in trunk/Source

The IDB backing store put() method shouldn't call IDB callbacks directly
​https://bugs.webkit.org/show_bug.cgi?id=127399

Reviewed by Beth Dakin.

Source/WebCore:

Refactor the put() callback to take a resulting key or an error.

• Modules/indexeddb/IDBServerConnection.h:

• Modules/indexeddb/IDBTransactionBackendOperations.cpp:

(WebCore::PutOperation::perform): Call to the backing store, then perform the

appropriate IDB callback whether a key or an error was returned.

• Modules/indexeddb/IDBTransactionBackendOperations.h:

• Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:

(WebCore::IDBServerConnectionLevelDB::put): Don’t call IDB callbacks directly.

Instead, pass the resulting key/error back to the PutOperation.

• Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:

Source/WebKit2:

• WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::put):

• WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:

9:13 PM Changeset in webkit [162500] by matthew_hanson@apple.com

• 5 edits in branches/safari-537.74-branch/Source

Versioning.

9:12 PM Changeset in webkit [162499] by matthew_hanson@apple.com

• 1 copy in tags/Safari-537.74.10

New Tag.

9:10 PM Changeset in webkit [162498] by matthew_hanson@apple.com

• 2 edits in branches/safari-537.74-branch/Source/WebCore

Merge r162486: <rdar://problem/15877502>

8:25 PM Changeset in webkit [162497] by matthew_hanson@apple.com

• 5 edits in branches/safari-537.74-branch/Source

Versioning.

8:23 PM Changeset in webkit [162496] by matthew_hanson@apple.com

• 1 copy in tags/Safari-537.74.9

New Tag.

8:01 PM Changeset in webkit [162495] by mrowe@apple.com

• 6 edits in trunk/Source

Roll out r162483. It removes SPI that is currently in use.

7:24 PM Changeset in webkit [162494] by Alan Bujtas

• 4 edits in trunk/LayoutTests

Subpixel Layout: Off-by-one pixel text when multiple regions with different widths are present.
​https://bugs.webkit.org/show_bug.cgi?id=127212

Reviewed by Simon Fraser.

Subpixel values accumulate differently when computing the text position inside a 300px wide div
vs. multiple 'flow into' regions with 300px, 400px widths. They are both correct. Blink
also addressed it by adjusting the test content.

• fast/regions/overflow-moving-below-floats-in-variable-width-regions.html:
• platform/mac/TestExpectations:

6:51 PM Changeset in webkit [162493] by jae.park@company100.net

• 2 edits in trunk/Source/WebCore

Use nullptr in HTMLCanvasElement
​https://bugs.webkit.org/show_bug.cgi?id=127388

Reviewed by Gyuyoung Kim.

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext):
(WebCore::HTMLCanvasElement::drawingContext):
(WebCore::HTMLCanvasElement::existingDrawingContext):

6:31 PM Changeset in webkit [162492] by commit-queue@webkit.org

• 4 edits
  2 adds in trunk

Assertion failure in Range::nodeWillBeRemoved
​https://bugs.webkit.org/show_bug.cgi?id=121694

Patch by László Langó <​llango.u-szeged@partner.samsung.com> on 2014-01-21
Reviewed by Ryosuke Niwa.

Source/WebCore:

Based on Blink a change: ​https://chromium.googlesource.com/chromium/blink/+/407c1d7b2c45974aa614b3f847ffe9e8fce205fa

This patch fix an assertion failure. Range::nodeWillBeRemoved() might
be called with removed node in ContainerNode, when DOMNodeRemovedFromDocument
event handler calls removeChild(), for node being removed.

Test: fast/dom/Range/remove-twice-crash.html

• dom/ContainerNode.cpp:

(WebCore::ContainerNode::willRemoveChild):

• dom/ContainerNode.h:

LayoutTests:

• fast/dom/Range/remove-twice-crash-expected.txt: Added.
• fast/dom/Range/remove-twice-crash.html: Added.

6:22 PM Changeset in webkit [162491] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Fix 32-bit build.

• UIProcess/API/Cocoa/WKProcessClassConfiguration.mm:

6:02 PM Changeset in webkit [162490] by jinwoo7.song@samsung.com

• 3 edits in trunk/Source/WebKit2

[EFL][WK2] Use nanoseconds in TimerWorkItem class consistently
​https://bugs.webkit.org/show_bug.cgi?id=127263

Reviewed by Gyuyoung Kim.

After r162276 and r162300, TimerWorkItem is getting nanoseconds as parameter.
So it would be better to use nanoseconds in TimerWorkItem for consistency.

• Platform/efl/DispatchQueueEfl.cpp:

(DispatchQueue::performTimerWork):
(DispatchQueue::insertTimerWorkItem):
(DispatchQueue::getNextTimeOut):

• Platform/efl/DispatchQueueWorkItemEfl.h:

(TimerWorkItem::create):
(TimerWorkItem::expirationTimeNanoSeconds):
(TimerWorkItem::hasExpired):
(TimerWorkItem::TimerWorkItem):

5:59 PM Changeset in webkit [162489] by fpizlo@apple.com

• 5 edits in branches/jsCStack

Source/JavaScriptCore: Add a --enableExperimentalFTLCoverage option and use it to protect recently added features.

Rubber stamped by Mark Hahnenberg.

We're still in a mode where adding new FTL features can cause performance regressions. This allows us to
add them and get them to be tested for correctness while we still continue to track progress on performance
work.

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• runtime/Options.h:

Tools: Use --enableExperimentalFTLCoverage=true for all FTL tests.

Rubber stamped by Mark Hahnenberg.

• Scripts/run-jsc-stress-tests:

5:59 PM Changeset in webkit [162488] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

Don't copy ViewGestureGeometryCollector.messages.in into the WebProcess bundle.

Reviewed by Simon Fraser.

• WebKit2.xcodeproj/project.pbxproj:

5:57 PM Changeset in webkit [162487] by andersca@apple.com

• 2 edits
  3 adds in trunk/Source/WebKit2

Add a WKProcessClassConfiguration class
​https://bugs.webkit.org/show_bug.cgi?id=127378
<rdar://problem/15875413>

Reviewed by Dan Bernstein.

• UIProcess/API/Cocoa/WKProcessClassConfiguration.h: Added.
• UIProcess/API/Cocoa/WKProcessClassConfiguration.mm: Added.

(-[WKProcessClassConfiguration copyWithZone:]):

• UIProcess/API/Cocoa/WKProcessClassConfigurationPrivate.h: Added.
• WebKit2.xcodeproj/project.pbxproj:

5:44 PM EFLWebKit edited by ryuan.choi@samsung.com

Add efreet related know issue that fails launching MiniBrowser on som … (diff)

5:34 PM Changeset in webkit [162486] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebCore

REGRESSION (r161580): Some PDFs render outside their <img>
​https://bugs.webkit.org/show_bug.cgi?id=127381
<rdar://problem/15872168>

Reviewed by Simon Fraser.

• platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::transformContextForPainting):
Only try to make the scale uniform if it isn't already, and use the minimum
of the two original scales when doing so, so that it is absolutely certain
to fit inside space allocated for the image during layout.

5:18 PM Changeset in webkit [162485] by timothy_horton@apple.com

• 2 edits
  1 move in trunk/Source/WebKit2

Make ViewGestureController Obj-C++
​https://bugs.webkit.org/show_bug.cgi?id=127385

Reviewed by Dean Jackson.

• UIProcess/mac/ViewGestureController.mm: Renamed from Source/WebKit2/UIProcess/mac/ViewGestureController.cpp.
• WebKit2.xcodeproj/project.pbxproj:

4:42 PM Changeset in webkit [162484] by fpizlo@apple.com

• 3 edits in branches/jsCStack/Source/JavaScriptCore

FTL should support AllocationProfileWatchpoint
​https://bugs.webkit.org/show_bug.cgi?id=127383

Rubber stamped by Mark Hahnenberg.

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):

4:28 PM Changeset in webkit [162483] by roger_fong@apple.com

• 6 edits in trunk/Source

Unreviewed. WebGLLoadPolicy::WebGLAsk is an unnecessary value.

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext):

• loader/FrameLoaderTypes.h:
• UIProcess/API/C/WKAPICast.h:

(WebKit::toWebGLLoadPolicy):

• UIProcess/API/C/WKPageLoaderClient.h:

4:06 PM Changeset in webkit [162482] by ap@apple.com

• 2 edits in trunk/LayoutTests

AX: Mac: Expose the visible text of a password field to AX
​https://bugs.webkit.org/show_bug.cgi?id=127353

Test landed with this fix was filing everywhere, trying to fix it.

• accessibility/password-field-value.html: Fix paths in the test, and clean it up a little.

4:04 PM Changeset in webkit [162481] by dfarler@apple.com

• 2 edits
  1 add in trunk/Tools

Upstream package-root for iOS

Reviewed by Daniel bates.

• Scripts/package-root: Added.

(usage):

• Scripts/webkitdirs.pm:

(XcodeSDKPath): Added function.

3:54 PM Changeset in webkit [162480] by Simon Fraser

• 5 edits in trunk/Source/WebCore

Remove #if PLATFORM(IOS) in various places around customFixedPositionLayoutRect() code
​https://bugs.webkit.org/show_bug.cgi?id=127373

Reviewed by Beth Dakin.

Instead of PLATFORM(IOS) #idefs at every call site for viewportConstrainedVisibleContentRect(),
move the #ifdef inside viewportConstrainedVisibleContentRect().

The one call site that needs special handling is RenderLayerBacking::updateCompositedBounds(),
which needs to avoid clipping fixed layers to the custom fixed position rect, but instead to
visibleContentRect() (which is really the document bounds on iOS). This ensures that the
fixed layers aren't clipped when zooming out.

• page/FrameView.cpp:

(WebCore::FrameView::viewportConstrainedVisibleContentRect):

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::stickyPositionOffset):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateCompositedBounds):

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
(WebCore::RenderLayerCompositor::computeFixedViewportConstraints):
(WebCore::RenderLayerCompositor::computeStickyViewportConstraints):

3:49 PM Changeset in webkit [162479] by alex.christensen@flexsim.com

• 2 edits in trunk/Source/WebKit

Unreviewed build fix for Win64.

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Corrected 64-bit linker symbols.

3:43 PM Changeset in webkit [162478] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Make all the WebKit2 headers private and move Cocoa UIProcess API headers to a Deprecated group
​https://bugs.webkit.org/show_bug.cgi?id=127374

Reviewed by Dan Bernstein.

• WebKit2.xcodeproj/project.pbxproj:

3:14 PM Changeset in webkit [162477] by aestes@apple.com

• 2 edits in trunk/Source/WebCore

[iOS] Allow all clients to link against WebCore
​https://bugs.webkit.org/show_bug.cgi?id=127372

Reviewed by Dan Bernstein.

• Configurations/WebCore.xcconfig:

2:45 PM Changeset in webkit [162476] by dbates@webkit.org

• 2 edits in trunk/Tools

[iOS] Tools/Makefile shouldn't build modules DumpRenderTree, gtest, or TestWebKitAPI
​https://bugs.webkit.org/show_bug.cgi?id=127368

Reviewed by Tim Horton.

Similar to the build-webkit change in <​https://bugs.webkit.org/show_bug.cgi?id=127364>,
we don't want to build DumpRenderTree, gtest, or TestWebKitAPI when running make in
Tools.

• Makefile:

2:23 PM Changeset in webkit [162475] by betravis@adobe.com

• 12 edits in trunk

[CSS Shapes] Preserve box-shape order when serializing shape values
​https://bugs.webkit.org/show_bug.cgi?id=127200

Reviewed by Dirk Schulze.

Source/WebCore:

Convert the parsed shape-box pair to a CSSValueList rather than directly
adding the box value to BasicShape. The CSSValueList preserves the
shape-box ordering, and cleans up a little bit of the code shared between
clip and shape values.

Modifying existing parsing tests.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::shapePropertyValue): Factor out code common to generating shape
values.
(WebCore::ComputedStyleExtractor::propertyValue): Generate a CSSValueList when
you have both a shape and a box.

• css/CSSParser.cpp:

(WebCore::CSSParser::parseBasicShapeAndOrBox): Factor out code common to clip

paths and shape properties that parses the [basic-shape

box] syntax from

the CSS Shapes spec.
(WebCore::CSSParser::parseShapeProperty): Parse shape-box pairs as a CSSValueList.

• css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyShape::applyValue): Use the CSSValueList for shape-box pairs.

• css/CSSValueList.h:

(WebCore::CSSValueList::itemWithoutBoundsCheck): Add a const version.

• page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc): Specify a box when blending.

• rendering/style/ShapeValue.h:

(WebCore::ShapeValue::createShapeValue): Add a box parameter.
(WebCore::ShapeValue::ShapeValue): Ditto.

LayoutTests:

Modify the expectations for box shape pairs, preserving the order of
the arguments in non-computed values. Computed values are still a
shape followed by a box.

• fast/shapes/parsing/parsing-shape-inside-expected.txt:
• fast/shapes/parsing/parsing-shape-outside-expected.txt:
• fast/shapes/parsing/parsing-test-utils.js:

2:14 PM Changeset in webkit [162474] by ap@apple.com

• 3 edits in trunk/LayoutTests

platform/mac/accessibility/iframe-aria-hidden.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=127323

Reviewed by Chris Fleizach.

This test got de-flaked on bots by rolling out r162354. But there was still
a potential race in it, which this change fixes.

• platform/mac-wk2/TestExpectations: Removed expectation.

• platform/mac/accessibility/iframe-aria-hidden.html: Run the test in onload, as

frames load asynchronously.

1:45 PM Changeset in webkit [162473] by dbates@webkit.org

• 2 edits in trunk/Source/WebCore

Fix the iOS Simulator release build

Substitute ASSERT_UNUSED() for ASSERT() to resolve a compiler warning
that the argument platformLayer is unused. The argument platformLayer
is only used in the asserted condition, which isn't compiled in a
release build; => the argument is unused in a release build.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

1:33 PM Changeset in webkit [162472] by zoltan@webkit.org

• 6 edits in trunk/Source/WebCore

Since MidpointState is a class, it should behave like a class
​https://bugs.webkit.org/show_bug.cgi?id=127154

Reviewed by David Hyatt.

I modified MidpointState to behave like a class, updated the call sites also.

No new tests, no behavior change.

• platform/text/BidiResolver.h:

(WebCore::MidpointState::reset):
(WebCore::MidpointState::startIgnoringSpaces):
(WebCore::MidpointState::stopIgnoringSpaces):
(WebCore::MidpointState::midpoints):
(WebCore::MidpointState::numMidpoints):
(WebCore::MidpointState::currentMidpoint):
(WebCore::MidpointState::incrementCurrentMidpoint):
(WebCore::MidpointState::decreaseNumMidpoints):
(WebCore::MidpointState::betweenMidpoints):
(WebCore::MidpointState::setBetweenMidpoints):
(WebCore::MidpointState::addMidpoint): Renamed from deprecatedAddMidpoint, since now
its private, we no longer need to discourage callers from using it.

• rendering/InlineIterator.h:

(WebCore::IsolateTracker::addFakeRunIfNecessary):

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::appendRunsForObject):
(WebCore::constructBidiRunsForLine):

• rendering/line/BreakingContextInlineHeaders.h:

(WebCore::checkMidpoints):

• rendering/line/TrailingObjects.cpp:

(WebCore::TrailingObjects::updateMidpointsForTrailingBoxes):

1:29 PM Changeset in webkit [162471] by dbates@webkit.org

• 2 edits in trunk/Tools

[iOS] Don't build DumpRenderTree, gtest, or TestWebKitAPI
​https://bugs.webkit.org/show_bug.cgi?id=127364

Reviewed by Simon Fraser.

For now, don't build DumpRenderTree and TestWebKitAPI for iOS as these
projects fail to build because we need to upstream the relevant iOS changes.
Also, don't build gtest, which is a dependency of TestWebKitAPI since we
aren't building TestWebKitAPI.

• Scripts/build-webkit:

1:23 PM Changeset in webkit [162470] by rakuco@webkit.org

• 2 edits in trunk/Tools

Unreviewed, remove myself from some watchlist entries.

• Scripts/webkitpy/common/config/watchlist:

1:10 PM Changeset in webkit [162469] by Lucas Forschler

• 5 edits in branches/safari-537.75-branch/Source

Versioning.

1:06 PM Changeset in webkit [162468] by Lucas Forschler

• 1 copy in branches/safari-537.75-branch

New Branch.

1:05 PM Changeset in webkit [162467] by commit-queue@webkit.org

• 11 edits in trunk/Source

Unreviewed, rolling out r162452.
​http://trac.webkit.org/changeset/162452
​https://bugs.webkit.org/show_bug.cgi?id=127366

broke a few tests on all Mac WebKit1 bots (Requested by
thorton on #webkit).

Source/WebCore:

• WebCore.exp.in:
• page/FocusController.cpp:

(WebCore::FocusController::FocusController):
(WebCore::FocusController::setFocused):
(WebCore::FocusController::setActive):
(WebCore::FocusController::setContentIsVisible):

• page/FocusController.h:

(WebCore::FocusController::isActive):
(WebCore::FocusController::isFocused):

• page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::setIsInWindow):
(WebCore::Page::setIsVisuallyIdle):
(WebCore::Page::setIsVisible):
(WebCore::Page::visibilityState):
(WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged):

• page/Page.h:

(WebCore::Page::isVisible):
(WebCore::Page::isInWindow):

Source/WebKit/mac:

• WebView/WebView.mm:

(-[WebView _windowWillOrderOnScreen:]):
(-[WebView _windowWillOrderOffScreen:]):

Source/WebKit2:

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::setActive):
(WebKit::WebPage::setViewIsVisible):
(WebKit::WebPage::setFocused):
(WebKit::WebPage::setIsInWindow):
(WebKit::WebPage::setViewStateInternal):
(WebKit::WebPage::setIsVisuallyIdle):

• WebProcess/WebPage/WebPage.h:

12:56 PM Changeset in webkit [162466] by Chris Fleizach

• 3 edits
  2 adds in trunk

AX: Mac: Expose the visible text of a password field to AX
​https://bugs.webkit.org/show_bug.cgi?id=127353

Reviewed by Brent Fulgham.

Source/WebCore:

The Mac platform should now expose the rendered value of password fields through AX.

Test: accessibility/password-field-value.html

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textLength):
(WebCore::AccessibilityRenderObject::passwordFieldValue):

LayoutTests:

• accessibility/password-field-value-expected.txt: Added.
• accessibility/password-field-value.html: Added.

12:32 PM Changeset in webkit [162465] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit2

Trivial Session API cleanup.
​https://bugs.webkit.org/show_bug.cgi?id=127356

Patch by Martin Hock <​mhock@apple.com> on 2014-01-21
Reviewed by Alexey Proskuryakov.

• UIProcess/API/C/WKSessionRef.cpp:

(WKSessionIsEphemeral):

• UIProcess/API/C/WKSessionRef.h:

12:26 PM Changeset in webkit [162464] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Support SSL error handling in case of synchronous job.
​https://bugs.webkit.org/show_bug.cgi?id=125301

Patch by Robert Sipka <​sipka@inf.u-szeged.hu> on 2014-01-21
Reviewed by Brent Fulgham.

Set ssl error informations for the users.

• platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::dispatchSynchronousJob):

12:25 PM Changeset in webkit [162463] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Export systemTotalMemory() and systemMemoryLevel() for MobileSafari
​https://bugs.webkit.org/show_bug.cgi?id=127360

Reviewed by Andy Estes.

MobileSafari inappropriately calls these WebCore functions directly,
so export them.

• WebCore.exp.in:

12:25 PM Changeset in webkit [162462] by Simon Fraser

• 4 edits in trunk/Source/WebCore

Clean up PLATFORM(IOS) code related to the custom fixed position layout rect
​https://bugs.webkit.org/show_bug.cgi?id=127362

Reviewed by Dave Hyatt.

Various platforms customize the rect used to layout position:fixed elements,
and each modified RenderBox::availableLogicalHeight/WidthUsing() in different
ways.

Clean this up by adding RenderView::clientLogicalWidth/HeightForFixedPosition(),
and moving the platform hacks into it.

• rendering/RenderBox.cpp:

(WebCore::RenderBox::availableLogicalHeightUsing):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):

• rendering/RenderView.cpp:

(WebCore::RenderView::clientLogicalWidthForFixedPosition):
(WebCore::RenderView::clientLogicalHeightForFixedPosition):

• rendering/RenderView.h:

12:25 PM Changeset in webkit [162461] by Simon Fraser

• 2 edits in trunk/Source/WebKit2

Log an error for a common cause of WebProcess early launch crashing in misconfigured development builds
​https://bugs.webkit.org/show_bug.cgi?id=127121

Reviewed by Anders Carlsson.

A common cause of early WebProcess crashes during development is a null return
from CFBundleGetValueForInfoDictionaryKey(), so log and return an error in
this case rather than passing a null C string to dlsym().

• Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.mm:

(WebKit::BootstrapMain):

12:19 PM Changeset in webkit [162460] by mhahnenberg@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Registers used in writeBarrierOnOperand can cause clobbering on some platforms
​https://bugs.webkit.org/show_bug.cgi?id=127357

Reviewed by Filip Pizlo.

Some platforms use t0 and t1 for their first two arguments, so using those to load the
cell for the write barrier is a bad idea because it will get clobbered.

• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:

12:17 PM Changeset in webkit [162459] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

ASSERT(time.isFinite()) in SVGSMILElement::createInstanceTimesFromSyncbase
<​https://webkit.org/b/108184>

Patch by Tamas Gergely <​tgergely.u-szeged@partner.samsung.com> on 2014-01-21
Reviewed by Philip Rogers.

Source/WebCore:

In the case a SMILElement timing had a syncbase dependency on an indefinite value
the assert were raised. The assert has been removed and a check has been added
instead that prevents the addition of indefinite times to the time list.

Test: svg/animations/smil-syncbase-self-dependency.svg

• svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::createInstanceTimesFromSyncbase):

ASSERT removed.

LayoutTests:

Test checks whether valid self-dependency is accidentally broken.

• svg/animations/smil-syncbase-self-dependency-expected.txt: Added.
• svg/animations/smil-syncbase-self-dependency.svg: Added.

11:58 AM Changeset in webkit [162458] by timothy_horton@apple.com

• 3 edits in trunk/Source/WebKit2

Sort headers after the rename that happened in r162454.

• UIProcess/mac/RemoteLayerTreeHost.mm:
• WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:

11:54 AM Changeset in webkit [162457] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit/win

[WinCairo][Curl] Download request has incorrect user agent string.
​https://bugs.webkit.org/show_bug.cgi?id=127110

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-01-21
Reviewed by Brent Fulgham.

• WebDownloadCurl.cpp:

(WebDownload::init): Set user agent string in download request.

• WebView.cpp:

(WebView::downloadURL): Avoid early return if no ResourceHandle is provided.

11:40 AM Changeset in webkit [162456] by Alan Bujtas

• 2 edits in trunk/Tools

Use 64 as the default value for the subpixel denominator.

Reviewed by Simon Fraser.

• lldb/lldb_webkit.py:

(WebCoreLayoutUnitProvider.to_string):

11:37 AM Changeset in webkit [162455] by mmaxfield@apple.com

• 1 edit
  2 adds in trunk/LayoutTests

Test that text-decoration-skip: ink inherits as expected
​https://bugs.webkit.org/show_bug.cgi?id=127329

Reviewed by Dean Jackson.

Adding a test for text-decoration-skip: ink inheriting

• fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-inherit-expected.html: Added.
• fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-inherit.html: Added.

11:36 AM Changeset in webkit [162454] by timothy_horton@apple.com

• 7 edits
  2 adds
  2 deletes in trunk/Source

Address late review naming comments after r162453.

• UIProcess/API/mac/WKView.mm:

And, fix the build by adding an include I accidentally missed.

• UIProcess/mac/RemoteLayerTreeHost.mm:
• WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:

• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/ca/mac/PlatformCALayerMac.mm:
• platform/graphics/mac/CALayerWebAdditions.h: Removed.
• platform/graphics/mac/CALayerWebAdditions.mm: Removed.
• platform/graphics/mac/WebCoreCALayerExtras.h: Added.
• platform/graphics/mac/WebCoreCALayerExtras.mm: Added.

Rename.

(-[CALayer web_disableAllActions]):

11:19 AM Changeset in webkit [162453] by timothy_horton@apple.com

• 9 edits
  1 move
  2 adds in trunk/Source

Keep CALayer implicit animation disabling code in a single place
​https://bugs.webkit.org/show_bug.cgi?id=127355

Reviewed by Simon Fraser.

• WebCore.xcodeproj/project.pbxproj:

Add CALayerWebAdditions.{h,mm}.

• platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayerMac::commonInit):
Remove nullActionsDictionary() and use [CALayer(WebAdditions) web_disableAllActions] instead.

• platform/graphics/mac/CALayerWebAdditions.h: Added.
• platform/graphics/mac/CALayerWebAdditions.mm: Added.

(-[CALayer web_disableAllActions]):
Added. Disable all implicit actions on the layer.

• Shared/mac/RemoteLayerTreePropertyApplier.h:
• Shared/mac/RemoteLayerTreePropertyApplier.mm:

Remove disableActionsForLayer.

• UIProcess/API/mac/WKView.mm:

(-[WKView _rootLayer]):
Disable actions on the root layer. It doesn't need them, and currently
isn't affected by implicit animations, but future patches which animate
the root layer will benefit from this.

• UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::createLayer):
Use web_disableAllActions instead of disableActionsForLayer.

• WebKit2.xcodeproj/project.pbxproj:
• WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm: Renamed from Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.cpp.

(PlatformCALayerRemoteCustom::PlatformCALayerRemoteCustom):
(PlatformCALayerRemoteCustom::~PlatformCALayerRemoteCustom):
(PlatformCALayerRemoteCustom::hostingContextID):
Use web_disableAllActions instead of disableActionsForLayer.
This requires making this file Obj-C++ but that's OK since it's Mac/iOS only.

11:02 AM Changeset in webkit [162452] by barraclough@apple.com

• 11 edits in trunk/Source

Change Page, FocusController to use ViewState
​https://bugs.webkit.org/show_bug.cgi?id=126533

Reviewed by Tim Horton.

These classes currently maintain a set of separate fields to represent the view state;
combine these into a single field, and allow WebPage to send the combined update rather
than individual changes.

Maintain existing interface for WebKit1 clients.

Source/WebCore:

• WebCore.exp.in:
  • Added WebCore::setViewState, removed WebCore::setIsVisuallyIdle.
• page/FocusController.cpp:

(WebCore::FocusController::FocusController):

• Initialize combined m_viewState.

(WebCore::FocusController::setFocused):

• Calls setViewState.

(WebCore::FocusController::setFocusedInternal):

• setFocused -> setFocusedInternal.

(WebCore::FocusController::setViewState):

• Added, update all ViewState flags.

(WebCore::FocusController::setActive):

• Calls setViewState.

(WebCore::FocusController::setActiveInternal):

• setActive -> setActiveInternal.

(WebCore::FocusController::setContentIsVisible):

• Calls setViewState.

(WebCore::FocusController::setContentIsVisibleInternal):

• setContentIsVisible -> setContentIsVisibleInternal.

• page/FocusController.h:

(WebCore::FocusController::isActive):
(WebCore::FocusController::isFocused):
(WebCore::FocusController::contentIsVisible):

• Implemented in terms of ViewState.

• page/Page.cpp:

(WebCore::Page::Page):

• Initialize using PageInitialViewState.

(WebCore::Page::setIsInWindow):

• Calls setViewState.

(WebCore::Page::setIsInWindowInternal):

• setIsInWindow -> setIsInWindowInternal.

(WebCore::Page::setIsVisuallyIdleInternal):

• setIsVisuallyIdle -> setIsVisuallyIdleInternal.

(WebCore::Page::setViewState):

• Added, update all ViewState flags, including FocusController.

(WebCore::Page::setIsVisible):

• Calls setViewState.

(WebCore::Page::setIsVisibleInternal):

• setIsVisible -> setIsVisibleInternal.

(WebCore::Page::visibilityState):

• m_isVisible -> isVisible()

(WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged):

• m_isVisible -> isVisible()

• page/Page.h:

(WebCore::Page::isVisible):
(WebCore::Page::isInWindow):

• Implemented in terms of ViewState.

(WebCore::Page::scriptedAnimationsSuspended):

• Combined member fields into ViewState::Flags.

Source/WebKit/mac:

• WebView/WebView.mm:

(-[WebView _windowWillOrderOnScreen:]):
(-[WebView _windowWillOrderOffScreen:]):

• remove calls to FocusController::setContentIsVisible, these are redundant (this is handled when page visibility is set).

Source/WebKit2:

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

• Combined separate calls to Page::setViewState.

(WebKit::WebPage::updateIsInWindow):

• Simplied from setIsInWindow.

(WebKit::WebPage::setViewState):

• Combined separate calls to Page::setViewState.

• WebProcess/WebPage/WebPage.h:
  • Declare updateIsInWindow.

10:46 AM Changeset in webkit [162451] by lauro.neto@openbossa.org

• 42 edits in trunk/Source/WebCore

Remove PLATFORM(NIX) from WebCore
​https://bugs.webkit.org/show_bug.cgi?id=127299

Reviewed by Anders Carlsson.

• editing/Editor.cpp:

(WebCore::Editor::cut):
(WebCore::Editor::copy):
(WebCore::Editor::copyImage):

• editing/Editor.h:
• html/HTMLCanvasElement.h:
• loader/EmptyClients.h:
• loader/FrameLoader.cpp:

(WebCore::FrameLoader::defaultObjectContentType):

• page/ChromeClient.h:
• page/DragController.cpp:

(WebCore::DragController::startDrag):

• platform/Cursor.h:
• platform/DragData.h:
• platform/DragImage.h:
• platform/FileSystem.h:
• platform/LocalizedStrings.h:
• platform/Widget.h:
• platform/audio/FFTFrame.h:
• platform/audio/HRTFElevation.cpp:
• platform/cairo/WidgetBackingStore.h:
• platform/graphics/ANGLEWebKitBridge.h:
• platform/graphics/FontPlatformData.h:
• platform/graphics/GLContext.cpp:

(WebCore::GLContext::createContextForWindow):

• platform/graphics/GLContext.h:
• platform/graphics/GraphicsContext3D.h:
• platform/graphics/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):

• platform/graphics/OpenGLESShims.h:
• platform/graphics/OpenGLShims.cpp:

(WebCore::getProcAddress):

• platform/graphics/OpenGLShims.h:
• platform/graphics/PlatformLayer.h:
• platform/graphics/freetype/FontPlatformDataFreeType.cpp:
• platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::createVertexArrayOES):
(WebCore::Extensions3DOpenGL::deleteVertexArrayOES):
(WebCore::Extensions3DOpenGL::isVertexArrayOES):
(WebCore::Extensions3DOpenGL::bindVertexArrayOES):
(WebCore::Extensions3DOpenGL::supportsExtension):

• platform/graphics/opengl/Extensions3DOpenGL.h:
• platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
• platform/graphics/opengl/Extensions3DOpenGLES.h:
• platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
• platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::reshape):

• platform/graphics/opengl/TemporaryOpenGLSetting.cpp:
• platform/graphics/texmap/TextureMapper.h:
• platform/network/ResourceHandle.h:
• plugins/PluginPackage.cpp:
• plugins/PluginView.cpp:

(WebCore::PluginView::PluginView):

• plugins/PluginView.h:
• plugins/PluginViewNone.cpp:
• rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

10:44 AM Changeset in webkit [162450] by eric.carlson@apple.com

• 6 edits in trunk

Add &lrm; &rlm; and &nbsp; to WebVTT parser
​https://bugs.webkit.org/show_bug.cgi?id=85112

Reviewed by Jer Noble.

Source/WebCore:

No new tests, track-webvtt-tc022-entities.html was updated to test this.

• html/track/WebVTTTokenizer.cpp:

(WebCore::WebVTTTokenizer::nextToken): Support RLM, LRM, and NBSP entities.

LayoutTests:

• media/track/captions-webvtt/tc022-entities.vtt:
• media/track/track-webvtt-tc022-entities-expected.txt:
• media/track/track-webvtt-tc022-entities.html:

10:30 AM Changeset in webkit [162449] by Carlos Garcia Campos

• 26 edits
  3 copies
  5 adds in trunk/Source/WebKit2

[SOUP] Implement CUSTOM PROTOCOLS
​https://bugs.webkit.org/show_bug.cgi?id=125583

Reviewed by Anders Carlsson.

Add new classes to implement CustomProtocols for soup. The
implementation is the same, but using the CustomProtocol API and
messages. The current implementation can be removed once all ports
using soup switch to using CustomProtocols.

• GNUmakefile.am: Add new include paths.
• GNUmakefile.list.am: Add new files to compilation.
• PlatformGTK.cmake: Add new files to compilation.
• Shared/API/c/soup/WKBaseSoup.h:
• Shared/APIObject.h:
• Shared/Network/CustomProtocols/CustomProtocolManager.h:
• Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.cpp: Added.

(WebKit::generateCustomProtocolID):
(WebKit::WebSoupRequestAsyncData::WebSoupRequestAsyncData):
(WebKit::WebSoupRequestAsyncData::~WebSoupRequestAsyncData):
(WebKit::WebSoupRequestAsyncData::requestFailed):
(WebKit::WebSoupRequestAsyncData::releaseTask):
(WebKit::CustomProtocolManagerImpl::CustomProtocolManagerImpl):
(WebKit::CustomProtocolManagerImpl::~CustomProtocolManagerImpl):
(WebKit::CustomProtocolManagerImpl::registerScheme):
(WebKit::CustomProtocolManagerImpl::supportsScheme):
(WebKit::CustomProtocolManagerImpl::didFailWithError):
(WebKit::CustomProtocolManagerImpl::didLoadData):
(WebKit::CustomProtocolManagerImpl::didReceiveResponse):
(WebKit::CustomProtocolManagerImpl::didFinishLoading):
(WebKit::CustomProtocolManagerImpl::send):
(WebKit::CustomProtocolManagerImpl::finish):

• Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.h: Added.
• Shared/Network/CustomProtocols/soup/CustomProtocolManagerSoup.cpp:

(WebKit::CustomProtocolManager::CustomProtocolManager):
(WebKit::CustomProtocolManager::initialize):
(WebKit::CustomProtocolManager::registerScheme):
(WebKit::CustomProtocolManager::supportsScheme):
(WebKit::CustomProtocolManager::didFailWithError):
(WebKit::CustomProtocolManager::didLoadData):
(WebKit::CustomProtocolManager::didReceiveResponse):
(WebKit::CustomProtocolManager::didFinishLoading):

• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

• Shared/WebProcessCreationParameters.h:
• UIProcess/API/C/soup/WKAPICastSoup.h:
• UIProcess/API/C/soup/WKSoupCustomProtocolRequestManager.cpp: Copied from Source/WebKit2/UIProcess/soup/WebContextSoup.cpp.

(WKSoupCustomProtocolRequestManagerGetTypeID):
(WKSoupCustomProtocolRequestManagerSetClient):

• UIProcess/API/C/soup/WKSoupCustomProtocolRequestManager.h: Added.
• UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:
• UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm:

(WebKit::CustomProtocolManagerProxy::CustomProtocolManagerProxy):

• UIProcess/Network/CustomProtocols/soup/CustomProtocolManagerProxySoup.cpp:

(WebKit::CustomProtocolManagerProxy::CustomProtocolManagerProxy):
(WebKit::CustomProtocolManagerProxy::startLoading):
(WebKit::CustomProtocolManagerProxy::stopLoading):

• UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManager.cpp: Added.

(WebKit::WebSoupCustomProtocolRequestManager::supplementName):
(WebKit::WebSoupCustomProtocolRequestManager::create):
(WebKit::WebSoupCustomProtocolRequestManager::WebSoupCustomProtocolRequestManager):
(WebKit::WebSoupCustomProtocolRequestManager::~WebSoupCustomProtocolRequestManager):
(WebKit::WebSoupCustomProtocolRequestManager::initializeClient):
(WebKit::WebSoupCustomProtocolRequestManager::contextDestroyed):
(WebKit::WebSoupCustomProtocolRequestManager::processDidClose):
(WebKit::WebSoupCustomProtocolRequestManager::refWebContextSupplement):
(WebKit::WebSoupCustomProtocolRequestManager::derefWebContextSupplement):
(WebKit::WebSoupCustomProtocolRequestManager::registerSchemeForCustomProtocol):
(WebKit::WebSoupCustomProtocolRequestManager::unregisterSchemeForCustomProtocol):
(WebKit::WebSoupCustomProtocolRequestManager::startLoading):
(WebKit::WebSoupCustomProtocolRequestManager::stopLoading):
(WebKit::WebSoupCustomProtocolRequestManager::didReceiveResponse):
(WebKit::WebSoupCustomProtocolRequestManager::didLoadData):
(WebKit::WebSoupCustomProtocolRequestManager::didFailWithError):
(WebKit::WebSoupCustomProtocolRequestManager::didFinishLoading):

• UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManager.h: Added.

(WebKit::WebSoupCustomProtocolRequestManager::registeredSchemesForCustomProtocols):

• UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManagerClient.cpp: Added.

(WebKit::WebSoupCustomProtocolRequestManagerClient::startLoading):
(WebKit::WebSoupCustomProtocolRequestManagerClient::stopLoading):

• UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManagerClient.h: Added.
• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::NetworkProcessProxy):

• UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):

• UIProcess/WebPageProxy.cpp:
• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::WebProcessProxy):

• UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

• UIProcess/soup/WebContextSoup.cpp:

(WebKit::WebContext::platformInitializeNetworkProcess):

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

• WebProcess/soup/WebKitSoupRequestGeneric.cpp:

(webkitSoupRequestGenericSendAsync):
(webkitSoupRequestGenericSendFinish):

• WebProcess/soup/WebKitSoupRequestGeneric.h:
• WebProcess/soup/WebProcessSoup.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):

10:22 AM Changeset in webkit [162448] by ChangSeok Oh

• 2 edits
  1 add in trunk/Tools

[GTK] Fix a c++11 compliance issue for fontconfig
​https://bugs.webkit.org/show_bug.cgi?id=127283

Reviewed by Martin Robinson.

fontconfig-2.8.0 is not compliant with C++11. So I propose to apply a
hotfix until bumping fontconfig up.

• gtk/jhbuild.modules:
• gtk/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.

10:06 AM Changeset in webkit [162447] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r162354.
​http://trac.webkit.org/changeset/162354
​https://bugs.webkit.org/show_bug.cgi?id=127354

Appears to have broken accessibility in a non-trivial way
(Requested by ap on #webkit).

• platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):

9:23 AM Changeset in webkit [162446] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r162445.
​http://trac.webkit.org/changeset/162445
​https://bugs.webkit.org/show_bug.cgi?id=127351

It broke the 32 bit GTK build (Requested by Ossy on #webkit).

• rendering/style/StyleRareInheritedData.cpp:

9:06 AM Changeset in webkit [162445] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Wrong struct size when CSS_IMAGE_ORIENTATION and CSS3_TEXT_DECORATION are enabled.
​https://bugs.webkit.org/show_bug.cgi?id=127346

Efl build fix.

Patch by László Langó <​llango.u-szeged@partner.samsung.com> on 2014-01-21
Reviewed by Csaba Osztrogonác.

• rendering/style/StyleRareInheritedData.cpp:

8:54 AM Changeset in webkit [162444] by commit-queue@webkit.org

• 2 edits in trunk/Tools

run-jsc-stress-tests should accept --child-processes option and WEBKIT_TEST_CHILD_PROCESSES env.var
like run_webkit_test does
​https://bugs.webkit.org/show_bug.cgi?id=127349

Patch by Peter Molnar <​pmolnar.u-szeged@partner.samsung.com> on 2014-01-21
Reviewed by Csaba Osztrogonác.

• Scripts/run-jsc-stress-tests:

8:40 AM Changeset in webkit [162443] by Antti Koivisto

• 3 edits in trunk/Source/WebCore

Delay initial layer flush during loading on all platforms
​https://bugs.webkit.org/show_bug.cgi?id=127347

Reviewed by Andreas Kling.

To reduce unnecessary repaints enable the same behaviour as iOS already has.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::RenderLayerCompositor):

Set the initial state of m_layerFlushThrottlingEnabled correctly.

(WebCore::RenderLayerCompositor::scheduleLayerFlush):
(WebCore::RenderLayerCompositor::startInitialLayerFlushTimerIfNeeded):

• rendering/RenderLayerCompositor.h:

Enable initial layer flush delay on all platforms.

8:36 AM Changeset in webkit [162442] by commit-queue@webkit.org

• 10 edits
  2 adds in trunk

Source/WebCore: If you set a tiled cross-faded-image or a tiled gradient as
a background layer, -webkit-background-blend-mode doesn't work.
The problem consists in the blendMode parameter not being set
for these specific drawing paths.

​https://bugs.webkit.org/show_bug.cgi?id=126888
Patch by Mihai Tica <​mitica@adobe.com> on 2014-01-21
Reviewed by Dirk Schulze.

Test: css3/compositing/background-blend-mode-tiled-layers.html

• platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::drawPattern): Add the blendMode parameter and pass it to ImageBuffer::drawPattern.

• platform/graphics/GradientImage.cpp:

(WebCore::GradientImage::drawPattern): Add the blendMode parameter and pass it to ImageBuffer::drawPattern.

• platform/graphics/ImageBuffer.h: Add a BlendMode parameter to the drawPattern method.
• platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::drawPattern): Add the default BlendMode parameter to the method declaration.

• platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::drawPattern): Add and use the blendMode parameter for all the code paths.

• platform/graphics/wince/ImageBufferWinCE.cpp:

(WebCore::BufferedImage::drawPattern): Add the default BlendMode parameter to the method declaration.

LayoutTests: If you set a tiled cross-faded-image or a tiled gradient as
a background layer, -webkit-background-blend-mode doesn't work.
​https://bugs.webkit.org/show_bug.cgi?id=126888

Patch by Mihai Tica <​mitica@adobe.com> on 2014-01-21
Reviewed by Dirk Schulze.

• css3/compositing/background-blend-mode-tiled-layers-expected.html: Added.
• css3/compositing/background-blend-mode-tiled-layers.html: Added.
• platform/efl/TestExpectations: Skip test for efl, blendModes are not implemented.
• platform/mac/TestExpectations: Mark added test as ImageOnlyFailure due to slight differences between the actual result and the blending formula.

6:57 AM Changeset in webkit [162441] by commit-queue@webkit.org

• 12 edits in trunk

[GTK] Allow passing extra data to web extensions
​https://bugs.webkit.org/show_bug.cgi?id=125990

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2014-01-21
Reviewed by Carlos Garcia Campos.

Allow passing additional information to the injected bundle. On top
of the string containing the path to the web extensions directory,
a GVariant can be set with additional data using
webkit_web_context_set_web_extensions_initialization_user_data().
Also, a new initialize-web-extensions signal is emitted before
launching a new WebProcess to allow setting different user data
for each process. The GVariant is serialized as a string, passed
to the injected bundle, and the injected bundle deserializes back
the data, which is passed to web extensions which define the
webkit_web_extension_initialize_with_user_data() function (for
backwards compatibility, webkit_web_extension_initialize() is
used as a fallback.)

Source/WebKit2:

• UIProcess/API/gtk/WebKitInjectedBundleClient.cpp:

(getInjectedBundleInitializationUserData): Define new callback
function which causes emission of the initialize-web-extensions
signal, and serializes the data to be passed to the web process.
(attachInjectedBundleClientToContext): Set the
getInjectedBundleInitializationUserData() callback.

• UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_class_init): Define the
initialize-web-extensions signal.
(webkit_web_context_set_web_extensions_directory):
Web extensions directory as now member of WebKitWebContextPrivate,
to be able to retrieve it later.
(webkit_web_context_set_web_extensions_initialization_user_data):
New API method to set the user data passed to the web extensions
when initialized.
(webkitWebContextInitializeWebExtensions): Private function used
to trigger emission of the initialize-web-extensions signal.

• UIProcess/API/gtk/WebKitWebContext.h:

Added prototype for new API method
webkit_web_context_set_web_extensions_initialization_user_data().

• UIProcess/API/gtk/WebKitWebContextPrivate.h:

Prototype of the new private function.

• UIProcess/API/gtk/docs/webkit2gtk-sections.txt:

Add new public API bits to the documentation.

• WebProcess/gtk/WebGtkExtensionManager.cpp:

(WebKit::WebGtkExtensionManager::initialize):
Deserialize the data received from the UI process and pass it to
webkit_web_extension_initialize_with_user_data() if available,
keeping webkit_web_extension_initialize() as fallback.

Tools:

• TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:

(initializeWebExtensions): Handles the initialize-web-extensions
signal, and sets the web extensions directory and the initialization
user data.
(testWebExtensionInitializationUserData): New test case for checking
the user data passed on initialization to web extensions.

• TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:

(methodCallCallback): Added implementation for the
GetInitializationUserData D-Bus method, used by
testWebExtensionInitializationUserData().
(webkit_web_extension_initialize_with_user_data): Define the
initialization function with the additional user data parameter.

6:53 AM Changeset in webkit [162440] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

The WebCore.vcxproj.filters doesnot apply
​https://bugs.webkit.org/show_bug.cgi?id=127338

Patch by Gurpreet Kaur <​k.gurpreet@samsung.com> on 2014-01-21
Reviewed by Csaba Osztrogonác.

• WebCore.vcxproj/WebCore.vcxproj.filters:

Modified the WebCore.vcxproj.filters so that it is applied when loading
WebCore.vcxproj file.

6:11 AM Changeset in webkit [162439] by Carlos Garcia Campos

• 1 copy in releases/WebKitGTK/webkit-2.2.4

Tagging the WebKitGTK+ 2.2.4 release

5:29 AM Changeset in webkit [162438] by commit-queue@webkit.org

• 4 edits
  2 adds in trunk

Fix SVG animations which set rx or ry attributes
​https://bugs.webkit.org/show_bug.cgi?id=127337

Patch by Peter Molnar <​pmolnar.u-szeged@partner.samsung.com> on 2014-01-21
Reviewed by Dirk Schulze.

Source/WebCore:

Test: svg/stroke/animated-non-scaling-rxry.html

Merged from Blink: ​https://src.chromium.org/viewvc/blink?revision=152376&view=revision

• rendering/svg/RenderSVGRect.cpp:

(WebCore::RenderSVGRect::updateShapeFromElement):

• rendering/svg/SVGPathData.cpp:

(WebCore::updatePathFromRectElement):

LayoutTests:

Merged from Blink: ​https://src.chromium.org/viewvc/blink?revision=152376&view=revision

• svg/stroke/animated-non-scaling-rxry-expected.html: Added.
• svg/stroke/animated-non-scaling-rxry.html: Added.

4:32 AM Changeset in webkit [162437] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.2

Unreviewed. Update NEWS and Versions.m4 for 2.2.4 release.

.:

• Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

• NEWS: Add release notes.

4:22 AM Changeset in webkit [162436] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk

Unreviewed. Fix make distcheck.

• GNUmakefile.am: Remove non existent files from EXTRA_DIST.

4:09 AM Changeset in webkit [162435] by s.mathur@ieee.org

• 2 edits in trunk/Tools

Change email address for Siddharth Mathur in contributors.json.

3:47 AM Changeset in webkit [162434] by mrowe@apple.com

• 5 edits in trunk/Source/JavaScriptCore

Mac production build fix.

Move the shell script build phase to copy jsc into JavaScriptCore.framework
out of the jsc target and in to the All target so that it's not run during
production builds. Xcode appears to the parent directories of paths referenced
in the Output Files of the build phase, which leads to problems when the
SYMROOT for the JavaScriptCore framework and the jsc executables are later merged.

I've also fixed the path to the Resources folder in the script while I'm here.
On iOS the framework bundle is shallow so the correct destination is Resources/
rather than Versions/A/Resources. This is handled by tweaking the
JAVASCRIPTCORE_RESOURCES_DIR configuration setting to be relative rather than
a complete path so we can reuse it in the script. The references in JSC.xcconfig
and ToolExecutable.xcconfig are updated to prepend JAVASCRIPTCORE_FRAMEWORKS_DIR
to preserve their former values.

• Configurations/Base.xcconfig:
• Configurations/JSC.xcconfig:
• Configurations/ToolExecutable.xcconfig:
• JavaScriptCore.xcodeproj/project.pbxproj:

2:50 AM Changeset in webkit [162433] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.2/Source/JavaScriptCore

Merge r162266 - JavaScriptCore uses PLATFORM(MAC) when it means OS(DARWIN)
​https://bugs.webkit.org/show_bug.cgi?id=99683

Reviewed by Anders Carlsson.

• jit/ThunkGenerators.cpp:
• tools/CodeProfile.cpp:

(JSC::symbolName):
(JSC::CodeProfile::sample):

2:47 AM Changeset in webkit [162432] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.2/Source/WTF

Merge r162137 - Source/WTF/wtf/Atomics.h:300: Error: bad register name `%bpl'
​https://bugs.webkit.org/show_bug.cgi?id=126985

Reviewed by Csaba Osztrogonác.

Use the 'q' constraint to force using a register that allows
access to its lower byte.

• wtf/Atomics.h:

(WTF::weakCompareAndSwap):

2:24 AM Changeset in webkit [162431] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.2/Source/WTF

Merge r162086 - [GTK] v2.3.3 fails to build in Debian / FreeBSD
​https://bugs.webkit.org/show_bug.cgi?id=126502

Reviewed by Mark Lam.

• wtf/Platform.h: Add LLINT support to FreeBSD.

1:52 AM Changeset in webkit [162430] by Carlos Garcia Campos

• 7 edits in releases/WebKitGTK/webkit-2.2

Merge r161500 - Fix some compilation warnings
​https://bugs.webkit.org/show_bug.cgi?id=126635

Reviewed by Csaba Osztrogonác.

Source/WebCore:

Remove code that is no longer being used.

• platform/graphics/cairo/GraphicsContextCairo.cpp:
• platform/graphics/texmap/GraphicsLayerTextureMapper.h:
• platform/gtk/PopupMenuGtk.cpp:
• platform/gtk/RedirectedXCompositeWindow.h:

Tools:

• GtkLauncher/main.c:

(createWindow): This function is not supposed to receive any
parameter, yet we are passing one.

1:10 AM Changeset in webkit [162429] by k.czech@samsung.com

• 6 edits
  2 moves in trunk

[ATK] Expose aria-flowto through ATK_RELATION_FLOWS_TO
​https://bugs.webkit.org/show_bug.cgi?id=127291

Reviewed by Mario Sanchez Prada.

Source/WebCore:

Test: accessibility/aria-flowto.html

Expose aria-flowto through ATK_RELATION_FLOWS_TO according to
​http://www.w3.org/TR/wai-aria-implementation/#mapping_state-property

• accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(setAtkRelationSetFromCoreObject):

Tools:

Implemented AccessibilityUIElement::ariaFlowToElementAtIndex method.

• DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::ariaFlowToElementAtIndex):

• WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):

LayoutTests:

Share aria-flowto.html with other ports. It passes on GTK and EFL.

• accessibility/aria-flowto-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-flowto-expected.txt.
• accessibility/aria-flowto.html: Renamed from LayoutTests/platform/mac/accessibility/aria-flowto.html.

12:06 AM Changeset in webkit [162428] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk

Merge r160171 - [GTK] Fix GObject introspection warnings in webkitspellchecker
​https://bugs.webkit.org/show_bug.cgi?id=125299

Reviewed by Philippe Normand.

• webkit/webkitspellchecker.cpp: Add missing ':' after some

gobject-introspection annotations.