Context Navigation

← Previous Period
Next Period →

Timeline

Jan 26, 2014:

11:33 PM Changeset in webkit [162828] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

Fix the iOS build (failed to correctly revert some broken changes in the last patch).

platform/graphics/cg/BitmapImageCG.cpp:

11:16 PM Changeset in webkit [162827] by timothy_horton@apple.com

24 edits in trunk/Source/WebCore

Start cleaning up iOS upstreaming #ifs in platform/graphics
https://bugs.webkit.org/show_bug.cgi?id=127641

Reviewed by Sam Weinig.

platform/graphics/BitmapImage.h:
platform/graphics/mac/ColorMac.h:

Use USE(APPKIT) instead of PLATFORM(MAC) && !PLATFORM(IOS) for NSImage/getNSImage().

platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:

(WebCore::AVTrackPrivateAVFObjCImpl::label):

platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:

(WebCore::InbandTextTrackPrivateLegacyAVFObjC::label):

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
Remove some code that was only used on OS X on Lion or below.

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::platformInit):
ToT WebKit doesn't build on Lion or earlier anymore, so this code can always run.

platform/graphics/cg/FloatPointCG.cpp:
platform/graphics/cg/FloatRectCG.cpp:
platform/graphics/cg/FloatSizeCG.cpp:
platform/graphics/cg/GradientCG.cpp:
platform/graphics/cg/ImageBufferCG.cpp:
platform/graphics/cg/ImageCG.cpp:
platform/graphics/cg/IntPointCG.cpp:
platform/graphics/cg/IntRectCG.cpp:
platform/graphics/cg/PathCG.cpp:
platform/graphics/cg/PatternCG.cpp:
platform/graphics/mac/FontCustomPlatformData.cpp:

Use CoreGraphics/CoreGraphics.h instead of ApplicationServices/ApplicationServices.h
even on Mac, so we can share the include.

platform/graphics/cg/IntSizeCG.cpp:

Remove a random comment of a style we don't tend to use in WebKit,
and from a file not large enough to need it.

platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::setFont):
Remove some more always-true #ifs.

platform/graphics/mac/WebLayer.mm:

Move a #if'd include out to its own block as per the style guide.

10:23 PM Changeset in webkit [162826] by ap@apple.com

2 edits in trunk/Tools

REGRESSION(r127412): http/tests/misc/link-rel-icon-beforeload.html is broken.

DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setIconDatabaseEnabled):

Fixed an incorrect ifdef.

9:45 PM Changeset in webkit [162825] by akling@apple.com

10 edits
2 adds in trunk/Source/JavaScriptCore

JSC: Pack unlinked instructions harder.
<https://webkit.org/b/127660>

Store UnlinkedCodeBlock's instructions in a variable-length stream
to reduce memory usage. Compression rate ends up around 60-61%.

The format is very simple. Every instruction starts with a 1 byte
opcode. It's followed by an opcode-dependent number of argument
values, each encoded separately for maximum packing. There are
7 packed value formats:

5-bit positive integer
5-bit negative integer
13-bit positive integer
13-bit positive integer
5-bit constant register index
13-bit constant register index
32-bit value (fallback)

27.5 MB progression on Membuster3. (~2% of total memory.)

Reviewed by Filip Pizlo.

JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/UnlinkedInstructionStream.h: Added.

(JSC::UnlinkedInstructionStream::count):
(JSC::UnlinkedInstructionStream::Reader::atEnd):

bytecode/UnlinkedInstructionStream.cpp: Added.

(JSC::UnlinkedInstructionStream::Reader::Reader):
(JSC::UnlinkedInstructionStream::Reader::read8):
(JSC::UnlinkedInstructionStream::Reader::read32):
(JSC::UnlinkedInstructionStream::Reader::next):
(JSC::append8):
(JSC::append32):
(JSC::UnlinkedInstructionStream::UnlinkedInstructionStream):
(JSC::UnlinkedInstructionStream::unpackForDebugging):

bytecompiler/BytecodeGenerator.cpp:
bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::lineNumberForBytecodeOffset):
(JSC::dumpLineColumnEntry):
(JSC::UnlinkedCodeBlock::expressionRangeForBytecodeOffset):
(JSC::UnlinkedCodeBlock::setInstructions):
(JSC::UnlinkedCodeBlock::instructions):

bytecode/UnlinkedCodeBlock.h:

(JSC::BytecodeGenerator::generate):

9:44 PM Changeset in webkit [162824] by ddkilzer@apple.com

2 edits in trunk/Source/WebKit/mac

Remove duplicate settings for ENABLE(DISK_IMAGE_CACHE)
<http://webkit.org/b/127669>

Reviewed by Joseph Pecoraro.

WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Remove duplicate code.

9:21 PM Changeset in webkit [162823] by b.long@cablelabs.com

2 edits in trunk/Tools

[GTK] DumpRenderTree prints out suggesting to set WEBKIT_TOP_LEVEL when fonts are missing but doesn't use it.
https://bugs.webkit.org/show_bug.cgi?id=110602

Reviewed by Philippe Normand.

DumpRenderTree/gtk/DumpRenderTree.cpp:

(getTopLevelPath): Use WEBKIT_TOP_LEVEL environment variable if it exists.
(initializeFonts): Fix printing of expected font path (fontPath is guaranteed to be null here).

7:57 PM Changeset in webkit [162822] by hyatt@apple.com

4 edits in trunk/Source/WebCore

[New Multicolumn] Change the axis property to be a boolean like other isInline checks
https://bugs.webkit.org/show_bug.cgi?id=127661

Reviewed by Simon Fraser.

rendering/ColumnInfo.h:

(WebCore::ColumnInfo::ColumnInfo):
(WebCore::ColumnInfo::progressionIsInline):
(WebCore::ColumnInfo::setProgressionIsInline):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::initialBlockOffsetForPainting):
(WebCore::RenderBlock::blockDeltaForPaintingNextColumn):
(WebCore::RenderBlock::setComputedColumnCountAndWidth):
(WebCore::RenderBlock::updateColumnInfoFromStyle):
(WebCore::RenderBlock::columnRectAt):
(WebCore::RenderBlock::adjustPointToColumnContents):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::adjustForColumns):

rendering/RenderMultiColumnFlowThread.h:
rendering/RenderObject.cpp:

(WebCore::RenderObject::columnNumberForOffset):

6:22 PM Changeset in webkit [162821] by benjamin@webkit.org

11 edits
1 delete in trunk/Source/WebCore

Make DOMStringMap a typedef of DatasetDOMStringMap
https://bugs.webkit.org/show_bug.cgi?id=127658

Reviewed by Sam Weinig.

The only concrete implementation of DOMStringMap is DatasetDOMStringMap.
The abstract interface for a single definition is adding complexity for no gain.

This patch removes DOMStringMap and simply keeps the name through a typedef.
I used a typedef instead of just renaming DatasetDOMStringMap because I think
having both name has value. DatasetDOMStringMap is a better description of what
the implementation does. DOMStringMap is the public name and the classname is
the same as the JavaScript type by convention.

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
dom/DOMAllInOne.cpp:
dom/DOMStringMap.cpp: Removed.
dom/DOMStringMap.h:
dom/DatasetDOMStringMap.h:
dom/Element.cpp:

(WebCore::Element::dataset):

dom/Element.h:

5:34 PM Changeset in webkit [162820] by ddkilzer@apple.com

5 edits in trunk/Source/WebCore

Part 2: Assertion failure in WebCore::PseudoElement::didRecalcStyle()
<https://bugs.webkit.org/show_bug.cgi?id=126761>
<rdar://problem/15793540>

Reviewed by Simon Fraser.

bindings/objc/DOM.mm:

(-[DOMElement image]):
(-[DOMElement _imageTIFFRepresentation]):

platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::writeImage):

platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::writeImage):
(WebCore::getCachedImage):

rendering/HitTestResult.cpp:

(WebCore::HitTestResult::image):

More places where toRenderImage() should be used instead of toImage().
Fixed last two places where static_cast<WebCore::RenderImage*> was being used instead of toRenderImage().

5:28 PM Changeset in webkit [162819] by jinwoo7.song@samsung.com

71 edits
4 deletes in trunk/LayoutTests

Unreviewed EFL gardening after r162742, r162791 and r162803.

platform/efl-wk1/fast/forms/basic-inputs-expected.png: Removed.
platform/efl-wk1/fast/forms/indeterminate-expected.png: Removed.
platform/efl-wk2/fast/forms/basic-inputs-expected.png: Removed.
platform/efl-wk2/fast/forms/indeterminate-expected.png: Removed.
platform/efl/compositing/overflow/theme-affects-visual-overflow-expected.png:
platform/efl/compositing/overflow/theme-affects-visual-overflow-expected.txt:
platform/efl/css1/box_properties/acid_test-expected.png:
platform/efl/css1/box_properties/acid_test-expected.txt:
platform/efl/css2.1/t09-c5526c-display-00-e-expected.png:
platform/efl/css2.1/t09-c5526c-display-00-e-expected.txt:
platform/efl/css3/selectors3/html/css3-modsel-25-expected.png:
platform/efl/css3/selectors3/html/css3-modsel-25-expected.txt:
platform/efl/css3/selectors3/html/css3-modsel-70-expected.png:
platform/efl/css3/selectors3/html/css3-modsel-70-expected.txt:
platform/efl/css3/selectors3/xhtml/css3-modsel-25-expected.png:
platform/efl/css3/selectors3/xhtml/css3-modsel-25-expected.txt:
platform/efl/css3/selectors3/xhtml/css3-modsel-70-expected.png:
platform/efl/css3/selectors3/xhtml/css3-modsel-70-expected.txt:
platform/efl/css3/selectors3/xml/css3-modsel-25-expected.png:
platform/efl/css3/selectors3/xml/css3-modsel-25-expected.txt:
platform/efl/css3/selectors3/xml/css3-modsel-70-expected.png:
platform/efl/css3/selectors3/xml/css3-modsel-70-expected.txt:
platform/efl/fast/block/basic/011-expected.png:
platform/efl/fast/block/basic/011-expected.txt:
platform/efl/fast/block/margin-collapse/103-expected.png:
platform/efl/fast/block/margin-collapse/103-expected.txt:
platform/efl/fast/css/non-standard-checkbox-size-expected.png:
platform/efl/fast/css/non-standard-checkbox-size-expected.txt:
platform/efl/fast/forms/001-expected.png:
platform/efl/fast/forms/001-expected.txt:
platform/efl/fast/forms/basic-inputs-expected.txt:
platform/efl/fast/forms/box-shadow-override-expected.png:
platform/efl/fast/forms/box-shadow-override-expected.txt:
platform/efl/fast/forms/file/file-input-disabled-expected.png:
platform/efl/fast/forms/file/file-input-disabled-expected.txt:
platform/efl/fast/forms/form-element-geometry-expected.png:
platform/efl/fast/forms/form-element-geometry-expected.txt:
platform/efl/fast/forms/formmove-expected.png:
platform/efl/fast/forms/formmove-expected.txt:
platform/efl/fast/forms/formmove2-expected.png:
platform/efl/fast/forms/formmove2-expected.txt:
platform/efl/fast/forms/indeterminate-expected.txt:
platform/efl/fast/forms/input-appearance-height-expected.png:
platform/efl/fast/forms/input-appearance-height-expected.txt:
platform/efl/fast/forms/input-value-expected.png:
platform/efl/fast/forms/input-value-expected.txt:
platform/efl/fast/forms/search-vertical-alignment-expected.png:
platform/efl/fast/forms/search-vertical-alignment-expected.txt:
platform/efl/fast/forms/searchfield-heights-expected.png:
platform/efl/fast/forms/searchfield-heights-expected.txt:
platform/efl/fast/inline/positionedLifetime-expected.png:
platform/efl/fast/inline/positionedLifetime-expected.txt:
platform/efl/fast/parser/bad-xml-slash-expected.png:
platform/efl/fast/parser/bad-xml-slash-expected.txt:
platform/efl/fast/replaced/replaced-breaking-expected.png:
platform/efl/fast/replaced/replaced-breaking-expected.txt:
platform/efl/fast/replaced/width100percent-checkbox-expected.png:
platform/efl/fast/replaced/width100percent-checkbox-expected.txt:
platform/efl/fast/replaced/width100percent-radio-expected.png:
platform/efl/fast/replaced/width100percent-radio-expected.txt:
platform/efl/fast/text/textIteratorNilRenderer-expected.png:
platform/efl/fast/text/textIteratorNilRenderer-expected.txt:
platform/efl/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
platform/efl/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
platform/efl/http/tests/navigation/javascriptlink-frames-expected.png:
platform/efl/http/tests/navigation/javascriptlink-frames-expected.txt:
platform/efl/tables/mozilla/bugs/bug1318-expected.png:
platform/efl/tables/mozilla/bugs/bug1318-expected.txt:
platform/efl/tables/mozilla/bugs/bug4527-expected.png:
platform/efl/tables/mozilla/bugs/bug4527-expected.txt:
platform/efl/tables/mozilla_expected_failures/core/captions1-expected.png:
platform/efl/tables/mozilla_expected_failures/core/captions1-expected.txt:
platform/efl/tables/mozilla_expected_failures/core/captions2-expected.png:
platform/efl/tables/mozilla_expected_failures/core/captions2-expected.txt:

4:44 PM Changeset in webkit [162818] by ryuan.choi@samsung.com

2 edits in trunk/Source/WebKit/efl

Unreviewed build fix on the EFL build since r162808

lastVisitedTime and visitCount are removed from WebCore::HistoryItem

ewk/ewk_history.cpp:

(ewk_history_item_new):
(ewk_history_item_time_last_visited_get):
(ewk_history_item_visit_count):

4:01 PM Changeset in webkit [162817] by aestes@apple.com

56 edits
4 copies
18 adds in trunk

[iOS] Upstream changes in Tools/DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=127412

Reviewed by Simon Fraser.

Source/WebKit/mac:

Misc/WebCoreStatistics.h: Included CGContext.h.

Tools:

Upstream all iOS changes. Added a new target called DumpRenderTree.app,
which builds the DumpRenderTree static library into an app bundle as
expected by the iOS Simulator.

DumpRenderTree/AccessibilityTextMarker.h:
DumpRenderTree/AccessibilityUIElement.h:
DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
DumpRenderTree/DumpRenderTreePrefix.h:
DumpRenderTree/PixelDumpSupport.cpp:
DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
DumpRenderTree/TestNetscapePlugIn/TestObject.h:
DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSAfterRemovingPluginElement.cpp:
DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp:
DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
DumpRenderTree/TestNetscapePlugIn/main.cpp:
DumpRenderTree/TestRunner.cpp:
DumpRenderTree/TestRunner.h:
DumpRenderTree/cg/ImageDiffCG.cpp:
DumpRenderTree/cg/PixelDumpSupportCG.cpp:
DumpRenderTree/ios/AccessibilityControllerIOS.mm:
DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
DumpRenderTree/ios/DumpRenderTreeBrowserView.h: Added.
DumpRenderTree/ios/DumpRenderTreeBrowserView.mm: Added.
DumpRenderTree/ios/Info.plist: Added.
DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport.c: Added.
DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Added.
DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Added.
DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Changes: Added.
DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/IPhoneSimulatorNotification.xs: Added.
DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/MANIFEST: Added.
DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL: Added.
DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/README: Added.
DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm: Added.
DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/ppport.h: Added.
DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/t/IPhoneSimulatorNotification.t: Added.
DumpRenderTree/ios/PerlSupport/Makefile: Added.
DumpRenderTree/ios/PixelDumpSupportIOS.mm: Added.
DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
DumpRenderTree/mac/AppleScriptController.m:
DumpRenderTree/mac/Configurations/Base.xcconfig:
DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Added.
DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Added.
DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
DumpRenderTree/mac/DumpRenderTree.mm:
DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
DumpRenderTree/mac/DumpRenderTreeMac.h:
DumpRenderTree/mac/DumpRenderTreePasteboard.h:
DumpRenderTree/mac/DumpRenderTreePasteboard.m:
DumpRenderTree/mac/DumpRenderTreeWindow.h:
DumpRenderTree/mac/DumpRenderTreeWindow.mm:
DumpRenderTree/mac/EditingDelegate.h:
DumpRenderTree/mac/EventSendingController.h:
DumpRenderTree/mac/EventSendingController.mm:
DumpRenderTree/mac/FrameLoadDelegate.mm:
DumpRenderTree/mac/HistoryDelegate.h:
DumpRenderTree/mac/LayoutTestHelper.m:
DumpRenderTree/mac/MockGeolocationProvider.mm:
DumpRenderTree/mac/NavigationController.h:
DumpRenderTree/mac/ObjCPlugin.h:
DumpRenderTree/mac/ObjCPlugin.m:
DumpRenderTree/mac/ObjCPluginFunction.h:
DumpRenderTree/mac/PolicyDelegate.h:
DumpRenderTree/mac/ResourceLoadDelegate.h:
DumpRenderTree/mac/ResourceLoadDelegate.mm:
DumpRenderTree/mac/TestRunnerMac.mm:
DumpRenderTree/mac/TextInputController.h:
DumpRenderTree/mac/TextInputController.m:
DumpRenderTree/mac/UIDelegate.h:
DumpRenderTree/mac/UIDelegate.mm:

3:40 PM Changeset in webkit [162816] by Chris Fleizach

8 edits in trunk/Source

AX: Disable accessibility after every test run
https://bugs.webkit.org/show_bug.cgi?id=127439

Reviewed by Alexey Proskuryakov.

../WebCore:

If accessibility is disabled, we may still need to return the existing
AXObjectCache, so that objects can be cleaned up appropriately.

A such we have to be prepared to handle a nullptr return value in more cases.

accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::disableAccessibility):

accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::childrenChanged):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::remoteSVGRootElement):

dom/Document.cpp:

(WebCore::Document::existingAXObjectCache):

../WebKit:

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

2:55 PM Changeset in webkit [162815] by andersca@apple.com

2 edits in trunk/Source/WebKit/win

Follow-up build fix.

WebHistoryItem.cpp:

(WebHistoryItem::visitedWithTitle):

2:52 PM Changeset in webkit [162814] by andersca@apple.com

3 edits in trunk/Source/WebKit/win

Remove even more Windows history code.

WebHistory.cpp:

(WebHistory::removeItemForURLString):

WebHistoryItem.cpp:

(WebHistoryItem::initFromDictionaryRepresentation):
(WebHistoryItem::dictionaryRepresentation):
(WebHistoryItem::getDailyVisitCounts):
(WebHistoryItem::getWeeklyVisitCounts):
(WebHistoryItem::recordInitialVisit):
(WebHistoryItem::initWithURLString):

2:46 PM Changeset in webkit [162813] by andersca@apple.com

3 edits in trunk/Source/WebKit/win

Another follow-up build fix.

WebHistory.cpp:

(WebHistory::removeAllItems):
(WebHistory::orderedItemsLastVisitedOnDay):

WebHistoryItem.cpp:

(WebHistoryItem::initFromDictionaryRepresentation):
(WebHistoryItem::dictionaryRepresentation):
(WebHistoryItem::visitCount):
(WebHistoryItem::setVisitCount):

2:41 PM Changeset in webkit [162812] by andersca@apple.com

4 edits in trunk/Source/WebKit/win

Remove more history gunk.

WebHistory.cpp:

(WebHistory::orderedLastVisitedDays):
(WebHistory::addItem):
(WebHistory::visitedURL):
(WebHistory::removeItemForURLString):

WebHistory.h:
WebHistoryItem.cpp:

(WebHistoryItem::initFromDictionaryRepresentation):
(WebHistoryItem::dictionaryRepresentation):
(WebHistoryItem::mergeAutoCompleteHints):
(WebHistoryItem::setLastVisitedTimeInterval):
(WebHistoryItem::initWithURLString):
(WebHistoryItem::lastVisitedTimeInterval):

2:39 PM Changeset in webkit [162811] by fpizlo@apple.com

8 edits
1 add in branches/jsCStack/Source/JavaScriptCore

FTL should do polyvariant GetById inlining
https://bugs.webkit.org/show_bug.cgi?id=127639

Not yet reviewed.

This does polyvariant inlining for GetByIds. It's pretty easy to do this, now that we
have all of that infrastructure from polyvariant Call/Construct inlining. Basically we
just keep around the StubInfoMaps of the DFG code block when compiling the FTL code
block.

The combination of Call, Construct, and GetById inlining causes a 17% speed-up on
V8v7/raytrace.

GetById inlining alone appears to be a speed-up on other benchmarks as well.

bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeDFGStatuses):

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::getStubInfoMap):
(JSC::CodeBlock::addStubInfo):

bytecode/CodeBlock.h:
bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::hasExitSite):
(JSC::GetByIdStatus::computeFor):
(JSC::GetByIdStatus::computeForStubInfo):

bytecode/GetByIdStatus.h:
dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parse):

runtime/Options.h:
tests/stress/simple-polyvariant-get-by-id-inlining-example.js: Added.

(foo):
(fuzz):
(bar):

2:34 PM Changeset in webkit [162810] by andersca@apple.com

2 edits in trunk/Source/WebKit/win

Build fix.

WebHistoryItem.cpp:

(WebHistoryItem::initFromDictionaryRepresentation):
(WebHistoryItem::dictionaryRepresentation):

2:29 PM Changeset in webkit [162809] by Alan Bujtas

1 edit
1 add in trunk/LayoutTests

Some more Apple Windows port rebaseline.

platform/win/svg/custom/foreign-object-skew-expected.txt: Added.

2:22 PM Changeset in webkit [162808] by andersca@apple.com

8 edits in trunk/Source

Move history item visit count handling to WebKit
https://bugs.webkit.org/show_bug.cgi?id=127659

Reviewed by Dan Bernstein.

Source/WebCore:

Remove all members dealing with visit handling - they're going back to WebKit.

WebCore.exp.in:
history/HistoryItem.cpp:

(WebCore::HistoryItem::HistoryItem):
(WebCore::HistoryItem::reset):
(WebCore::HistoryItem::decodeBackForwardTree):

history/HistoryItem.h:

(WebCore::HistoryItem::create):

Source/WebKit/mac:

Move code to deal with visit count and visit dates here from WebCore.

History/HistoryPropertyList.mm:

(HistoryPropertyListWriter::writeHistoryItem):

History/WebHistoryItem.mm:

(-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
(-[WebHistoryItem copyWithZone:]):
(-[WebHistoryItem lastVisitedTimeInterval]):
(-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):
(-[WebHistoryItem setVisitCount:]):
(-[WebHistoryItem _mergeAutoCompleteHints:]):
(-[WebHistoryItem initFromDictionaryRepresentation:]):
(-[WebHistoryItem _visitedWithTitle:increaseVisitCount:]):
(-[WebHistoryItem _recordInitialVisit]):
(timeToDay):
(-[WebHistoryItem _padDailyCountsForNewVisit:]):
(-[WebHistoryItem _collapseDailyVisitsToWeekly]):
(-[WebHistoryItem _recordVisitAtTime:increaseVisitCount:]):
(-[WebHistoryItem _setLastVisitedTimeInterval:]):

History/WebHistoryItemInternal.h:

1:32 PM Changeset in webkit [162807] by andersca@apple.com

6 edits
1 move in trunk/Source/WebKit

Source/WebKit: Fix build.

Make HistoryPropertyList an Objective-C++ class.

WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac: Fix build.

Pass a WebHistoryItem to writeHistoryItem so we can extract _lastVisitWasHTTPNonGet from it.

History/HistoryPropertyList.h:
History/HistoryPropertyList.mm:

(HistoryPropertyListWriter::HistoryPropertyListWriter):
(HistoryPropertyListWriter::buffer):
(HistoryPropertyListWriter::releaseData):
(HistoryPropertyListWriter::writeObjects):
(HistoryPropertyListWriter::writeHistoryItem):

History/WebHistory.mm:

(WebHistoryWriter::writeHistoryItems):

History/WebHistoryItem.mm:

1:21 PM Changeset in webkit [162806] by andersca@apple.com

11 edits in trunk/Source

Move lastVisitWasHTTPNonGet out to WebHistoryItem
https://bugs.webkit.org/show_bug.cgi?id=127657

Reviewed by Dan Bernstein.

Source/WebCore:

Remove m_lastVisitWasHTTPNonGet, it's only used by WebKit.

history/HistoryItem.cpp:

(WebCore::HistoryItem::HistoryItem):
(WebCore::HistoryItem::reset):

history/HistoryItem.h:

Source/WebKit/mac:

Keep track of _lastVisitWasHTTPNonGet inside WebHistoryItem.

History/WebHistory.mm:

(-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]):
Set entry->_private->_lastVisitWasHTTPNonGet.

History/WebHistoryItem.h:

Change @private to @package so we can get at WebHistoryItemPrivate from WebHistory.

History/WebHistoryItem.mm:

(-[WebHistoryItem copyWithZone:]):
Assign _private->_lastVisitWasHTTPNonGet.

(-[WebHistoryItem initFromDictionaryRepresentation:]):
Set _private->_lastVisitWasHTTPNonGet.

History/WebHistoryItemInternal.h:

Move WebHistoryItemPrivate interface here.

Source/WebKit/win:

Remove uses of lastVisitWasHTTPNonGet.

WebHistory.cpp:

(WebHistory::visitedURL):

WebHistoryItem.cpp:

(WebHistoryItem::initFromDictionaryRepresentation):
(WebHistoryItem::lastVisitWasHTTPNonGet):
(WebHistoryItem::setLastVisitWasHTTPNonGet):

12:04 PM Changeset in webkit [162805] by Alan Bujtas

1 edit
58 adds in trunk/LayoutTests

Unreviewed Apple Windows port rebaseline after r162803.

platform/win/editing/selection/3690703-2-expected.txt: Added.
platform/win/editing/selection/3690703-expected.txt: Added.
platform/win/editing/selection/3690719-expected.txt: Added.
platform/win/editing/selection/4397952-expected.txt: Added.
platform/win/editing/selection/5240265-expected.txt: Added.
platform/win/editing/selection/selection-button-text-expected.txt: Added.
platform/win/fast/block/float/float-avoidance-expected.txt: Added.
platform/win/fast/css/continuationCrash-expected.txt: Added.
platform/win/fast/css/margin-top-bottom-dynamic-expected.txt: Added.
platform/win/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Added.
platform/win/fast/forms/001-expected.txt: Added.
platform/win/fast/forms/blankbuttons-expected.txt: Added.
platform/win/fast/forms/button-table-styles-expected.txt: Added.
platform/win/fast/forms/control-restrict-line-height-expected.txt: Added.
platform/win/fast/forms/file/file-input-direction-expected.txt: Added.
platform/win/fast/forms/file/input-file-re-render-expected.txt: Added.
platform/win/fast/forms/formmove3-expected.txt: Added.
platform/win/fast/forms/input-appearance-height-expected.txt: Added.
platform/win/fast/forms/input-button-sizes-expected.txt: Added.
platform/win/fast/forms/input-value-expected.txt: Added.
platform/win/fast/forms/targeted-frame-submission-expected.txt: Added.
platform/win/fast/html/details-replace-summary-child-expected.txt: Added.
platform/win/fast/html/details-replace-text-expected.txt: Added.
platform/win/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt: Added.
platform/win/fast/overflow/scrollRevealButton-expected.txt: Added.
platform/win/fast/replaced/width100percent-button-expected.txt: Added.
platform/win/fast/text/textIteratorNilRenderer-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug138725-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug18359-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug2479-3-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug2479-4-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug26178-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug28928-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug33855-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug39209-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug4429-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug46368-1-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug46368-2-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug51037-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug51727-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug52505-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug52506-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug60749-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug7342-expected.txt: Added.
platform/win/tables/mozilla/collapsing_borders/bug41262-4-expected.txt: Added.
platform/win/tables/mozilla/dom/tableDom-expected.txt: Added.
platform/win/tables/mozilla/other/move_row-expected.txt: Added.
platform/win/tables/mozilla_expected_failures/bugs/bug1725-expected.txt: Added.
platform/win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Added.
platform/win/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt: Added.

10:54 AM Changeset in webkit [162804] by andersca@apple.com

2 edits in trunk/Source/WebKit/mac

Turn WebHistoryItemPrivate back into a real Objective-C class
https://bugs.webkit.org/show_bug.cgi?id=127653

Reviewed by Sam Weinig.

This is a first step towards moving some history specific code from WebCore::HistoryItem back into WebKit.

History/WebHistoryItem.mm:

(-[WebHistoryItem dealloc]):
(-[WebHistoryItem finalize]):
(-[WebHistoryItem initWithWebCoreHistoryItem:]):

10:28 AM Changeset in webkit [162803] by Alan Bujtas

129 edits
1 add in trunk

Subpixel Layout: Align <input type="button", submit etc (PushButtonPart) top and bottom paddings with <button>
https://bugs.webkit.org/show_bug.cgi?id=127640

Reviewed by Simon Fraser.

<button> sets padding-top: 2px and padding-bottom: 3px as default values (html.css),
while <input type="button" (submit, etc) has the hardcoded values of 0, 0 and we center the text using the available space.
This results in different baseline text position in normal cases. This adjustment puts the <input type='button'
rendering back to the pre-subpixel layout state.

Source/WebCore:

platform/mac/ThemeMac.mm:

(WebCore::ThemeMac::controlPadding):

LayoutTests:

platform/mac/css3/flexbox/button-expected.txt:
platform/mac/editing/selection/3690703-2-expected.txt:
platform/mac/editing/selection/3690703-expected.txt:
platform/mac/editing/selection/3690719-expected.txt:
platform/mac/editing/selection/4397952-expected.txt:
platform/mac/editing/selection/5240265-expected.txt:
platform/mac/editing/selection/selection-button-text-expected.txt:
platform/mac/fast/block/float/float-avoidance-expected.txt:
platform/mac/fast/css/continuationCrash-expected.txt:
platform/mac/fast/css/margin-top-bottom-dynamic-expected.txt:
platform/mac/fast/css/rtl-ordering-expected.txt:
platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
platform/mac/fast/forms/001-expected.png:
platform/mac/fast/forms/001-expected.txt:
platform/mac/fast/forms/basic-buttons-expected.png:
platform/mac/fast/forms/basic-buttons-expected.txt:
platform/mac/fast/forms/blankbuttons-expected.txt:
platform/mac/fast/forms/box-shadow-override-expected.png:
platform/mac/fast/forms/box-shadow-override-expected.txt:
platform/mac/fast/forms/button-positioned-expected.png:
platform/mac/fast/forms/button-positioned-expected.txt:
platform/mac/fast/forms/button-sizes-expected.png:
platform/mac/fast/forms/button-sizes-expected.txt:
platform/mac/fast/forms/button-style-color-expected.png:
platform/mac/fast/forms/button-style-color-expected.txt:
platform/mac/fast/forms/button-table-styles-expected.png:
platform/mac/fast/forms/button-table-styles-expected.txt:
platform/mac/fast/forms/button-text-transform-expected.png:
platform/mac/fast/forms/button-text-transform-expected.txt:
platform/mac/fast/forms/control-restrict-line-height-expected.png:
platform/mac/fast/forms/control-restrict-line-height-expected.txt:
platform/mac/fast/forms/file/file-input-direction-expected.png:
platform/mac/fast/forms/file/file-input-direction-expected.txt:
platform/mac/fast/forms/file/file-input-disabled-expected.txt:
platform/mac/fast/forms/file/input-file-re-render-expected.txt:
platform/mac/fast/forms/form-element-geometry-expected.png:
platform/mac/fast/forms/form-element-geometry-expected.txt:
platform/mac/fast/forms/formmove3-expected.txt:
platform/mac/fast/forms/input-appearance-height-expected.png:
platform/mac/fast/forms/input-appearance-height-expected.txt:
platform/mac/fast/forms/input-button-sizes-expected.png:
platform/mac/fast/forms/input-button-sizes-expected.txt:
platform/mac/fast/forms/input-value-expected.png:
platform/mac/fast/forms/input-value-expected.txt:
platform/mac/fast/forms/targeted-frame-submission-expected.txt:
platform/mac/fast/forms/validation-message-appearance-expected.png:
platform/mac/fast/forms/validation-message-appearance-expected.txt:
platform/mac/fast/html/details-replace-summary-child-expected.txt:
platform/mac/fast/html/details-replace-text-expected.txt:
platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
platform/mac/fast/overflow/scrollRevealButton-expected.txt:
platform/mac/fast/replaced/replaced-breaking-expected.txt:
platform/mac/fast/replaced/width100percent-button-expected.txt:
platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
platform/mac/svg/custom/foreign-object-skew-expected.txt: Added.
platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
platform/mac/tables/mozilla/bugs/bug138725-expected.txt:
platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt:
platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
platform/mac/tables/mozilla/bugs/bug26178-expected.txt:
platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
platform/mac/tables/mozilla/bugs/bug33855-expected.txt:
platform/mac/tables/mozilla/bugs/bug39209-expected.txt:
platform/mac/tables/mozilla/bugs/bug4429-expected.txt:
platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
platform/mac/tables/mozilla/bugs/bug51727-expected.txt:
platform/mac/tables/mozilla/bugs/bug52505-expected.txt:
platform/mac/tables/mozilla/bugs/bug52506-expected.txt:
platform/mac/tables/mozilla/bugs/bug60749-expected.txt:
platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
platform/mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
platform/mac/tables/mozilla/dom/tableDom-expected.txt:
platform/mac/tables/mozilla/other/move_row-expected.txt:
platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
platform/mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:

5:39 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

5:33 AM Changeset in webkit [162802] by zandobersek@gmail.com

56 edits in trunk/LayoutTests

Unreviewed GTK gardening. Rebaselining after r162553, r162742, r162791 and possibly other revisions.

platform/gtk/css1/box_properties/padding-expected.txt:
platform/gtk/css1/box_properties/padding_top-expected.txt:
platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
platform/gtk/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
platform/gtk/css2.1/t0804-c5510-padn-00-b-ag-expected.txt:
platform/gtk/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
platform/gtk/css3/selectors3/html/css3-modsel-25-expected.txt:
platform/gtk/css3/selectors3/html/css3-modsel-70-expected.txt:
platform/gtk/css3/selectors3/xhtml/css3-modsel-25-expected.txt:
platform/gtk/css3/selectors3/xhtml/css3-modsel-70-expected.txt:
platform/gtk/css3/selectors3/xml/css3-modsel-25-expected.txt:
platform/gtk/css3/selectors3/xml/css3-modsel-70-expected.txt:
platform/gtk/fast/block/basic/011-expected.txt:
platform/gtk/fast/block/float/032-expected.txt:
platform/gtk/fast/block/margin-collapse/103-expected.txt:
platform/gtk/fast/css/empty-pseudo-class-expected.txt:
platform/gtk/fast/css/fieldset-display-row-expected.txt:
platform/gtk/fast/css/first-child-pseudo-class-expected.txt:
platform/gtk/fast/css/input-search-padding-expected.txt:
platform/gtk/fast/css/last-child-pseudo-class-expected.txt:
platform/gtk/fast/css/non-standard-checkbox-size-expected.txt:
platform/gtk/fast/css/only-child-pseudo-class-expected.txt:
platform/gtk/fast/forms/001-expected.txt:
platform/gtk/fast/forms/basic-inputs-expected.txt:
platform/gtk/fast/forms/box-shadow-override-expected.txt:
platform/gtk/fast/forms/file/file-input-disabled-expected.txt:
platform/gtk/fast/forms/form-element-geometry-expected.txt:
platform/gtk/fast/forms/formmove-expected.txt:
platform/gtk/fast/forms/formmove2-expected.txt:
platform/gtk/fast/forms/indeterminate-expected.txt:
platform/gtk/fast/forms/input-appearance-height-expected.txt:
platform/gtk/fast/forms/input-text-word-wrap-expected.txt:
platform/gtk/fast/forms/input-value-expected.txt:
platform/gtk/fast/forms/large-toggle-elements-expected.txt:
platform/gtk/fast/inline/positionedLifetime-expected.txt:
platform/gtk/fast/parser/bad-xml-slash-expected.txt:
platform/gtk/fast/repaint/reflection-redraw-expected.txt:
platform/gtk/fast/replaced/replaced-breaking-expected.txt:
platform/gtk/fast/replaced/width100percent-checkbox-expected.txt:
platform/gtk/fast/replaced/width100percent-radio-expected.txt:
platform/gtk/fast/table/dynamic-caption-add-remove-before-child-expected.txt:
platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
platform/gtk/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
platform/gtk/http/tests/navigation/javascriptlink-frames-expected.txt:
platform/gtk/tables/mozilla/bugs/bug1318-expected.txt:
platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
platform/gtk/tables/mozilla/marvin/body_col-expected.txt:
platform/gtk/tables/mozilla/marvin/x_th_valign_baseline-expected.txt:
platform/gtk/tables/mozilla/other/body_col-expected.txt:
platform/gtk/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
platform/gtk/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.txt:
platform/gtk/tables/mozilla_expected_failures/core/captions2-expected.txt:
platform/gtk/tables/mozilla_expected_failures/core/captions3-expected.txt:
platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:

2:30 AM Changeset in webkit [162801] by benjamin@webkit.org

4 edits
2 adds in trunk

Improve the bindings of NodeList's name accessor
https://bugs.webkit.org/show_bug.cgi?id=127358

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-26
Reviewed by Geoffrey Garen.

Source/WebCore:

When accessing an item of NodeList by name, the default bindings was
going through the list of node twice:
-First, getOwnProperty calls canGetItemsForName() to find if a property exists for

the given name. This in turn used NodeList::namedItem() which is a slow operation.

-Then, the value itself was queried through nameGetter(), calling NodeList::namedItem()

a second time to find the same value.

This patch kills the default name getter in favor of a getOwnPropertySlotDelegate() returning
the value directly on the PropertySlot.

Ad Hoc testing show about 15% speed up for simple cases.

bindings/js/JSNodeListCustom.cpp:

(WebCore::JSNodeList::getOwnPropertySlotDelegate):

dom/NodeList.idl:

LayoutTests:

fast/dom/NodeList/nodelist-name-getter-properties-expected.txt: Added.
fast/dom/NodeList/nodelist-name-getter-properties.html: Added.

2:26 AM Changeset in webkit [162800] by benjamin@webkit.org

1 edit
2 adds in trunk/LayoutTests

ASSERTION FAILED: !m_hasPendingCharacter
https://bugs.webkit.org/show_bug.cgi?id=110118

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-26
Reviewed by Sam Weinig.

Add more test coverage for r144552 with a use case that use to hit the assertion.

fast/dom/xml-parser-entity-in-attribute-value-expected.txt: Added.
fast/dom/xml-parser-entity-in-attribute-value.html: Added.

12:39 AM Changeset in webkit [162799] by Joseph Pecoraro

26 edits
2 moves
12 adds in trunk

Web Inspector: Move InspectorDebuggerAgent into JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=127629

Rubber-stamped by Sam Weinig.

Source/JavaScriptCore:

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:
Add new files to the build.
Also, since non REMOTE_INSPECTOR ports cannot yet connect to a JSGlobalObject for inspection remove those files as they don't need to be built.

inspector/EventLoop.cpp: Added.

(Inspector::EventLoop::cycle):

inspector/EventLoop.h: Added.

(Inspector::EventLoop::EventLoop):
(Inspector::EventLoop::ended):
Add a JavaScriptCore version of EventLoop. This is currently only
used by the Mac port for JSGlobalObject remote inspection. Keep
the WebCore/platform version alive because for the Mac port it does
slightly different things involving AppKit.

inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
Create DebuggerAgent and hook up ScriptDebugServer where needed.

inspector/JSGlobalObjectScriptDebugServer.cpp: Added.

(Inspector::JSGlobalObjectScriptDebugServer::JSGlobalObjectScriptDebugServer):
(Inspector::JSGlobalObjectScriptDebugServer::addListener):
(Inspector::JSGlobalObjectScriptDebugServer::removeListener):
(Inspector::JSGlobalObjectScriptDebugServer::recompileAllJSFunctions):
(Inspector::JSGlobalObjectScriptDebugServer::runEventLoopWhilePaused):

inspector/JSGlobalObjectScriptDebugServer.h: Added.

Simple implementation of ScriptDebugServer with a JSGlobalObject.

inspector/agents/InspectorDebuggerAgent.cpp: Renamed from Source/WebCore/inspector/InspectorDebuggerAgent.cpp.
inspector/agents/InspectorDebuggerAgent.h: Renamed from Source/WebCore/inspector/InspectorDebuggerAgent.h.

Copied from WebCore. A few methods need to be made virtual so that Web implementations
can override and extend the funcitonality. E.g. sourceMapURLForScript and enable/disable.

inspector/agents/JSGlobalObjectDebuggerAgent.cpp: Added.
inspector/agents/JSGlobalObjectDebuggerAgent.h: Added.

(Inspector::JSGlobalObjectDebuggerAgent::JSGlobalObjectDebuggerAgent):
(Inspector::JSGlobalObjectDebuggerAgent::startListeningScriptDebugServer):
(Inspector::JSGlobalObjectDebuggerAgent::stopListeningScriptDebugServer):
(Inspector::JSGlobalObjectDebuggerAgent::injectedScriptForEval):
Simple implementation of DebuggerAGent with a JSGlobalObject.

Source/WebCore:

Test: inspector-protocol/debugger/pause-on-assert.html

CMakeLists.txt:
ForwardingHeaders/inspector/agents/InspectorDebuggerAgent.h: Added.
GNUmakefile.list.am:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
inspector/InspectorAllInOne.cpp:
Remove InspectorDebuggerAgent.
Add WebDebuggerAgent (shared between Page and Worker).

inspector/WebDebuggerAgent.h: Added.

(WebCore::WebDebuggerAgent::~WebDebuggerAgent):

inspector/WebDebuggerAgent.cpp: Added.

(WebCore::WebDebuggerAgent::WebDebuggerAgent):
(WebCore::WebDebuggerAgent::enable):
(WebCore::WebDebuggerAgent::disable):
Shared code for Page and Worker debugger agents.
Instrumenting agents is a concept in WebCore only,
and the Debugger agent is only in the instrumenting
agents list when it is enabled and removed when disabled.

inspector/InstrumentingAgents.h:

(WebCore::InstrumentingAgents::inspectorDebuggerAgent):
(WebCore::InstrumentingAgents::setInspectorDebuggerAgent):

inspector/InspectorDOMDebuggerAgent.cpp:
inspector/InspectorDOMDebuggerAgent.h:

Update namespace for debugger agent.

inspector/InspectorInstrumentation.cpp:

(WebCore::isConsoleAssertMessage):
(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
DebuggerAgent in JavaScriptCore does not yet know about console
types. So temporarily handle it here. We need to give JavaScriptCore
some concept of Console messages and types.

inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::PageDebuggerAgent):
(WebCore::PageDebuggerAgent::enable):
(WebCore::PageDebuggerAgent::disable):
(WebCore::PageDebuggerAgent::sourceMapURLForScript):
(WebCore::PageDebuggerAgent::injectedScriptForEval):

inspector/PageDebuggerAgent.h:
inspector/WorkerDebuggerAgent.cpp:

(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::injectedScriptForEval):

inspector/WorkerDebuggerAgent.h:

Modernize the Page and Worker debugger agents.

inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

inspector/InspectorController.h:
inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):
New constructors for the debugger agents.

LayoutTests:

Add a test that we pause in the debugger for console.assert failures
when the DebuggerAgent is enabled.

inspector-protocol/debugger/pause-on-assert-expected.txt: Added.
inspector-protocol/debugger/pause-on-assert.html: Added.
inspector-protocol/debugger/resources/assert.js: Added.

(assertTrue):
(assertFalse):
(assertCondition):
(assertConditionWithMessage):

Jan 25, 2014:

11:19 PM Changeset in webkit [162798] by fpizlo@apple.com

4 edits in branches/jsCStack/Source

StubInfoMap should use CodeOriginApproximateHash
https://bugs.webkit.org/show_bug.cgi?id=127646

Not yet reviewed.

Source/JavaScriptCore:

bytecode/StructureStubInfo.h:

Source/WTF:

wtf/BagToHashMap.h:

(WTF::toHashMap):

10:53 PM Changeset in webkit [162797] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

Gardening: fix build breakage from previous commit.

Not reviewed.

profiler/ProfileNode.cpp:

(JSC::ProfileNode::debugPrintData):

Removed obsolete references to "visible" timers.

10:30 PM Changeset in webkit [162796] by timothy@apple.com

14 edits in trunk

Remove dead code from the JSC profiler.

https://bugs.webkit.org/show_bug.cgi?id=127643

Reviewed by Mark Lam.

Source/JavaScriptCore:

profiler/Profile.cpp:
profiler/Profile.h:
profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::stopProfiling):

profiler/ProfileNode.cpp:

(JSC::ProfileNode::ProfileNode):
(JSC::ProfileNode::stopProfiling):
(JSC::ProfileNode::endAndRecordCall):
(JSC::ProfileNode::debugPrintData):
(JSC::ProfileNode::debugPrintDataSampleStyle):

profiler/ProfileNode.h:

(JSC::ProfileNode::totalTime):
(JSC::ProfileNode::setTotalTime):
(JSC::ProfileNode::selfTime):
(JSC::ProfileNode::setSelfTime):
(JSC::ProfileNode::totalPercent):
(JSC::ProfileNode::selfPercent):
Remove support for things like focus and exclude. The Inspector does those in JS now.

Source/WebCore:

Passes existing tests in fast/profiler.

bindings/js/ScriptProfile.cpp:

(WebCore::buildInspectorObjectFor): Remove visible.

inspector/ScriptProfileNode.idl: Ditto.
inspector/protocol/Profiler.json: Ditto.

Source/WebInspectorUI:

Versions/Inspector-iOS-7.0.json: Remove visible from CPUProfileNode.

LayoutTests:

fast/profiler/resources/profiler-test-JS-resources.js:

(printProfileNodeWithoutTime): Don't use visible. It was always true.

10:25 PM Changeset in webkit [162795] by commit-queue@webkit.org

34 edits in trunk/Source

Remove unused support for DRAGGABLE_REGION
https://bugs.webkit.org/show_bug.cgi?id=127642

Patch by Sam Weinig <sam@webkit.org> on 2014-01-25
Reviewed by Simon Fraser.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:
DerivedSources.make:
WebCore.exp.in:
css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

css/CSSPropertyNames.in:
css/CSSValueKeywords.in:
css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

dom/Document.cpp:

(WebCore::Document::Document):

dom/Document.h:
page/Chrome.cpp:
page/ChromeClient.h:
page/FrameView.cpp:

(WebCore::FrameView::layout):
(WebCore::FrameView::paintContents):

page/FrameView.h:
rendering/RenderElement.cpp:

(WebCore::RenderElement::styleWillChange):

rendering/RenderInline.cpp:

(WebCore::RenderInline::addAnnotatedRegions):

rendering/RenderInline.h:
rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):
(WebCore::RenderLayer::updateScrollbarsAfterLayout):

rendering/RenderListBox.cpp:

(WebCore::RenderListBox::setHasVerticalScrollbar):

rendering/RenderObject.cpp:

(WebCore::RenderObject::addAnnotatedRegions):

rendering/RenderObject.h:

(WebCore::AnnotatedRegionValue::operator==):

rendering/style/RenderStyle.h:
rendering/style/RenderStyleConstants.h:
rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

rendering/style/StyleRareNonInheritedData.h:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

Source/WTF:

wtf/FeatureDefines.h:

8:15 PM Changeset in webkit [162794] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Remove FIXME in CSSKeywordCompletions.js about "inherit" keyword
https://bugs.webkit.org/show_bug.cgi?id=127638

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-25
Reviewed by Timothy Hatcher.

UserInterface/CSSKeywordCompletions.js:

(WebInspector.CSSKeywordCompletions.forProperty):
Replace FIXME with a descriptive comment about why the code is what it is.

7:54 PM Changeset in webkit [162793] by commit-queue@webkit.org

5 edits in trunk/Source/WTF

Add FALLTHROUGH and -Wimplicit-fallthrough to warn about unannotated implicit fallthroughs in switches
https://bugs.webkit.org/show_bug.cgi?id=127637

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-25
Reviewed by Darin Adler.

For information about [[clang::fallthrough]], see:
<http://clang.llvm.org/docs/LanguageExtensions.html#the-clang-fallthrough-attribute>

Configurations/Base.xcconfig:

Enable -Wimplicit-fallthrough warnings.

wtf/Compiler.h:

Define FALLTHROUGH on clang and fallback to outputing nothing when unsupported.

wtf/dtoa/fast-dtoa.cc:
wtf/unicode/UTF8.cpp:

(WTF::Unicode::convertLatin1ToUTF8):
(WTF::Unicode::convertUTF16ToUTF8):
(WTF::Unicode::isLegalUTF8):
(WTF::Unicode::readUTF8Sequence):
Explicitly annotate implicit fallthroughs with FALLTHROUGH.

7:43 PM Changeset in webkit [162792] by gyuyoung.kim@samsung.com

2 edits in trunk/Source/WebCore

Clean up SVGPatternElement::collectPatternAttributes
https://bugs.webkit.org/show_bug.cgi?id=127612

Reviewed by Andreas Kling.

This patch refactors SVGPatternElement::collectPatternAttributes() by extracting
the setPatternAttributes logic into a new function. This patch also changes the
while loop to be easier to understand and similar to collectGradientAttributes.

svg/SVGPatternElement.cpp:

(WebCore::setPatternAttributes):
(WebCore::SVGPatternElement::collectPatternAttributes):

5:27 PM Changeset in webkit [162791] by Alan Bujtas

10 edits in trunk

Subpixel layout: RenderInline is not centered when child RenderTextControl's innerTextRenderer needs bias centering.
https://bugs.webkit.org/show_bug.cgi?id=125659

Source/WebCore:

Reviewed by Andreas Kling

layoutMod(logicalHeightDiff, 2) fails to bias round when subpixel layout is enabled. It sets
the denominator value to 2, which returns incorrect modulo result.
(subpixel off: 3px % 2 = 1 vs subpixel on: (3px * 64) -> 192 % 2 = 0)

Covered by existing tests.

platform/LayoutUnit.h:
rendering/RenderSearchField.cpp:

(WebCore::RenderSearchField::centerContainerIfNeeded):

rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::centerRenderer):
(WebCore::RenderTextControlSingleLine::layout):

rendering/RenderTextControlSingleLine.h:

LayoutTests:

Reviewed by Andreas Kling.

Covered by existing tests.

platform/mac/fast/block/float/032-expected.txt:
platform/mac/fast/forms/search-vertical-alignment-expected.png:
platform/mac/fast/forms/search-vertical-alignment-expected.txt:
platform/mac-mountainlion/fast/forms/search-vertical-alignment-expected.txt:

5:08 PM Changeset in webkit [162790] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Position the completion suggestions popup below if there is room
https://bugs.webkit.org/show_bug.cgi?id=127615

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-01-25
Reviewed by Joseph Pecoraro.

UserInterface/CompletionSuggestionsView.js:

(WebInspector.CompletionSuggestionsView.prototype.show):

4:50 PM Changeset in webkit [162789] by weinig@apple.com

2 edits in trunk/Source/WebCore

Remove more unnecessary #if PLATFORM(IOS)s in ApplicationCacheStorage.cpp
https://bugs.webkit.org/show_bug.cgi?id=127635

Reviewed by Antti Koivisto.

loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::executeSQLCommand):
(WebCore::ApplicationCacheStorage::verifySchemaVersion):
(WebCore::ApplicationCacheStorage::executeStatement):
(WebCore::ApplicationCacheStorage::store):
(WebCore::ApplicationCacheStorage::ensureOriginRecord):
(WebCore::ApplicationCacheStorage::loadCache):

4:44 PM Changeset in webkit [162788] by fpizlo@apple.com

40 edits
2 adds in branches/jsCStack/Source/JavaScriptCore

FTL should do polyvariant Call/Construct inlining
https://bugs.webkit.org/show_bug.cgi?id=127335

Reviewed by Oliver Hunt.

Imagine that you have a call stack like foo calls bar, which calls baz. Lets say that
there's another call stack where bar calls something other than baz at the same
callsite, but whenver bar is called from foo, it always calls baz.

This bar->baz callsite can be said to be polymorphic, because it may call things other
than baz in some cases.

But if we conduct a polyvariant analysis - that is, one that accounts for the call
stack when reporting results - then this call appears monomorphic whenever bar gets
called from foo. A polyvariant analysis of callsites will report results of the form
"when statement S ran on a call stack that included functions f, g, etc then the set
of possible callees is bounded by ...". This is in contrast to a monovariant analysis
that will attempt to construct a bounding set of callees without adding the call stack
as a contingency.

Prior to this patch, all inlining decisions were made based on a monovariant dynamic
analysis.

This patch allows the FTL to make its Call/Construct inlining decisions based on a
polyvariant analysis. That analysis is cleverly simple: we just ask the DFG to do the
same "analysis" that the LLInt and Baseline JIT perform. That "analysis" is just an
inline cache plus a slow-path count. But the DFG has performed inlining. Hence each
callsite that the DFG reports information for is actually sitting on a static call
stack. When the DFG reports the status of its call inline caches, it can report the
information with a (short) snippet of call stack as a kind of contingency, much like a
polyvariant analysis would.

Consider the foo->bar->baz example. Lets say that foo's call to bar is trivially
monomorphic, and the DFG inlines it. The DFG won't be able to then inline the call
from foo->bar to baz because when we ask the Baseline JIT profiling what the status of
the bar->baz call is, the profiling will say "polymorphic". That's because that
profiling doesn't have any context sensitivity, and so it doesn't know that the call
would be monomorphic if foo was bar's caller.

But, with this patch, once we tier-up from the DFG to the FTL, the FTL will be able to
ask the DFG: "hey, what do you know about the callsite to baz in foo->bar?" The DFG
had, as we said above, inlined bar into foo and so it sees that callsite in its
proper context. That call inline cache would be monomorphic. The FTL would then be
able to inline baz into foo->bar.

This will eventually benefit V8v7/raytrace, but we still have some more things to do
before we can close the loop on this. Right now, the callsite in question is not an
inlining candidate because it's op_call_varargs. We'll fix that eventually.

JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeFor):
(JSC::CallLinkStatus::computeDFGStatuses):

bytecode/CallLinkStatus.h:

(JSC::CallLinkStatus::makeClosureCall):

bytecode/CodeBlock.h:

(JSC::CodeBlock::specialFastCaseProfileForBytecodeOffset):

bytecode/CodeOrigin.cpp:

(JSC::CodeOrigin::isApproximatelyEqualTo):
(JSC::CodeOrigin::approximateHash):

bytecode/CodeOrigin.h:

(JSC::CodeOrigin::CodeOrigin):
(JSC::CodeOrigin::deletedMarker):
(JSC::CodeOriginApproximateHash::hash):
(JSC::CodeOriginApproximateHash::equal):

bytecode/DFGExitProfile.cpp:

(JSC::DFG::ExitProfile::add):
(JSC::DFG::ExitProfile::hasExitSite):

bytecode/DFGExitProfile.h:

(JSC::DFG::FrequentExitSite::FrequentExitSite):
(JSC::DFG::FrequentExitSite::operator==):
(JSC::DFG::FrequentExitSite::subsumes):
(JSC::DFG::FrequentExitSite::hash):
(JSC::DFG::FrequentExitSite::jitType):
(JSC::DFG::FrequentExitSite::withJITType):
(JSC::DFG::QueryableExitProfile::hasExitSite):

bytecode/ExitKind.h:
bytecode/ExitingJITType.h: Added.

(JSC::exitingJITTypeFor):

bytecode/ProfiledCodeBlockJettisoningWatchpoint.cpp:

(JSC::ProfiledCodeBlockJettisoningWatchpoint::fireInternal):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parse):

dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

dfg/DFGCapabilities.h:

(JSC::DFG::inlineFunctionForCallCapabilityLevel):
(JSC::DFG::inlineFunctionForClosureCallCapabilityLevel):
(JSC::DFG::inlineFunctionForConstructCapabilityLevel):
(JSC::DFG::inlineFunctionForCapabilityLevel):

dfg/DFGCommon.h:
dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):
(JSC::DFG::compile):

dfg/DFGDriver.h:
dfg/DFGFailedFinalizer.cpp:

(JSC::DFG::FailedFinalizer::codeSize):

dfg/DFGFailedFinalizer.h:
dfg/DFGFinalizer.h:
dfg/DFGJITCode.h:
dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::currentJSCallIndex):

dfg/DFGJITFinalizer.cpp:

(JSC::DFG::JITFinalizer::codeSize):

dfg/DFGJITFinalizer.h:
dfg/DFGOSRExit.h:

(JSC::DFG::OSRExit::considerAddingAsFrequentExitSite):

dfg/DFGOSRExitBase.cpp:

(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSiteSlow):

dfg/DFGOSRExitBase.h:

(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSite):

dfg/DFGOperations.cpp:
dfg/DFGPlan.cpp:

(JSC::DFG::Plan::Plan):
(JSC::DFG::Plan::compileInThread):

dfg/DFGPlan.h:
dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::prepareJITCodeForTierUp):
(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT.h:
dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

ftl/FTLJITFinalizer.cpp:

(JSC::FTL::JITFinalizer::codeSize):

ftl/FTLJITFinalizer.h:
ftl/FTLOSRExit.h:

(JSC::FTL::OSRExit::considerAddingAsFrequentExitSite):

jit/JITCode.h:
jit/JITOperations.cpp:
runtime/Options.h:
tests/stress/simple-polyvariant-call-inlining-example.js: Added.

(foo):
(fuzz):
(bar):
(baz1):
(baz2):

4:36 PM Changeset in webkit [162787] by weinig@apple.com

11 edits
3 copies
1 delete in trunk/Source/WebCore

Remove some iOS #ifdefs by adding SQLiteDatabaseTracker to all the builds
https://bugs.webkit.org/show_bug.cgi?id=127632

Reviewed by Darin Adler.

Move the SQLiteDatabaseTracker and client from platform/sql/ios to platform/sql,
as there is nothing iOS specific about it. Then, un-#ifdef all its uses. For
ports that don't setup a client, this has no change in behavior.

CMakeLists.txt:
GNUmakefile.list.am:
Modules/webdatabase/DatabaseBackendBase.cpp:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
loader/appcache/ApplicationCacheStorage.cpp:
platform/ScrollableArea.h:

(WebCore::ScrollableArea::sendWillRevealEdgeEventsIfNeeded):

platform/sql/SQLiteDatabaseTracker.cpp: Copied from Source/WebCore/platform/sql/ios/SQLiteDatabaseTracker.cpp.
platform/sql/SQLiteDatabaseTracker.h: Copied from Source/WebCore/platform/sql/ios/SQLiteDatabaseTracker.h.
platform/sql/SQLiteDatabaseTrackerClient.h: Copied from Source/WebCore/platform/sql/ios/SQLiteDatabaseTrackerClient.h.
platform/sql/ios: Removed.
platform/sql/ios/SQLiteDatabaseTracker.cpp: Removed.
platform/sql/ios/SQLiteDatabaseTracker.h: Removed.
platform/sql/ios/SQLiteDatabaseTrackerClient.h: Removed.
storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::openDatabase):
(WebCore::StorageAreaSync::sync):

storage/StorageTracker.cpp:

3:04 PM Changeset in webkit [162786] by andersca@apple.com

22 edits in trunk/Source

Remove an unused FrameLoaderClient function
https://bugs.webkit.org/show_bug.cgi?id=127628

Reviewed by Andreas Kling.

Source/WebCore:

All implementations of FrameLoaderClient::shouldStopLoadingForHistoryItem return true and this function
was only used by Chromium so we can get rid of it.

loader/EmptyClients.h:
loader/FrameLoaderClient.h:
loader/HistoryController.cpp:

(WebCore::HistoryController::shouldStopLoadingForHistoryItem):

Source/WebKit/efl:

WebCoreSupport/FrameLoaderClientEfl.cpp:
WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

WebCoreSupport/FrameLoaderClientGtk.cpp:
WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/mac:

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm:

Source/WebKit/win:

WebCoreSupport/WebFrameLoaderClient.cpp:
WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit/wince:

WebCoreSupport/FrameLoaderClientWinCE.cpp:
WebCoreSupport/FrameLoaderClientWinCE.h:

Source/WebKit2:

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

2:58 PM Changeset in webkit [162785] by Darin Adler

2 edits in trunk/Source/JavaScriptCore

Try to fix Mac build.

runtime/DatePrototype.cpp: Put the include of <unicode/udat.h> inside

a conditional since we don't have that header in our Mac build configuration.

2:47 PM Changeset in webkit [162784] by Darin Adler

31 edits in trunk

Call deprecatedCharacters instead of characters at more call sites
https://bugs.webkit.org/show_bug.cgi?id=127631

Reviewed by Sam Weinig.

Source/JavaScriptCore:

API/JSValueRef.cpp:

(JSValueMakeFromJSONString):

API/OpaqueJSString.cpp:

(OpaqueJSString::~OpaqueJSString):

bindings/ScriptValue.cpp:

(Deprecated::jsToInspectorValue):

inspector/ContentSearchUtilities.cpp:

(Inspector::ContentSearchUtilities::createSearchRegexSource):

inspector/InspectorValues.cpp:
runtime/Identifier.h:

(JSC::Identifier::deprecatedCharacters):

runtime/JSStringBuilder.h:

(JSC::JSStringBuilder::append):
Use the new name.

Source/WebCore:

bindings/objc/WebScriptObject.mm:

(+[WebScriptObject _convertValueToObjcValue:JSC::originRootObject:rootObject:]):

editing/CompositeEditCommand.cpp:

(WebCore::containsOnlyWhitespace):

editing/TypingCommand.cpp:

(WebCore::TypingCommand::insertText):

editing/VisibleUnits.cpp:

(WebCore::startOfParagraph):
(WebCore::endOfParagraph):

html/parser/HTMLParserIdioms.cpp:

(WebCore::stripLeadingAndTrailingHTMLSpaces):
(WebCore::parseHTMLNonNegativeInteger):

inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::newLineAndWhitespaceDelimiters):

inspector/InspectorStyleTextEditor.cpp:

(WebCore::InspectorStyleTextEditor::insertProperty):
(WebCore::InspectorStyleTextEditor::internalReplaceProperty):

platform/Length.cpp:

(WebCore::newCoordsArray):

platform/LinkHash.cpp:

(WebCore::visitedLinkHash):

platform/graphics/Color.cpp:

(WebCore::Color::parseHexColor):
(WebCore::Color::Color):

platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun):

platform/text/TextEncodingRegistry.cpp:

(WebCore::atomicCanonicalTextEncodingName):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::constructTextRun):

rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::width):

svg/SVGFontElement.cpp:

(WebCore::SVGFontElement::registerLigaturesInGlyphCache):

xml/XPathFunctions.cpp:

(WebCore::XPath::FunId::evaluate):
Use the new name.

Source/WTF:

wtf/text/StringImpl.cpp:

(WTF::StringImpl::replace):

wtf/text/WTFString.h:

(WTF::String::isAllSpecialCharacters):
Use the new name.

Tools:

TestWebKitAPI/Tests/WTF/StringBuilder.cpp:

(TestWebKitAPI::expectBuilderContent):
(TestWebKitAPI::expectEmpty):
(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WTF/StringImpl.cpp:

(TestWebKitAPI::TEST):
Use the new name.

2:46 PM Changeset in webkit [162783] by Darin Adler

6 edits
1 add in trunk/Source/WTF

Add a new separate LChar.h header file, to be used after we remove Unicode.h
https://bugs.webkit.org/show_bug.cgi?id=127630

Reviewed by Sam Weinig.

GNUmakefile.list.am: Added the new file
WTF.vcxproj/WTF.vcxproj: Ditto.
WTF.vcxproj/WTF.vcxproj.filters: Ditto.
WTF.xcodeproj/project.pbxproj: Ditto.
wtf/CMakeLists.txt: Ditto.
wtf/text/LChar.h: Added.

1:36 PM Changeset in webkit [162782] by Darin Adler

28 edits
1 delete in trunk

Get rid of ICU_UNICODE and WCHAR_UNICODE remnants
https://bugs.webkit.org/show_bug.cgi?id=127623

Reviewed by Anders Carlsson.

Source/cmake/OptionsEfl.cmake: Removed ICU_UNICODE and WCHAR_UNICODE flags.
Source/cmake/OptionsGTK.cmake: Ditto.
Source/cmake/OptionsWinCE.cmake: Ditto.

Source/JavaScriptCore:

runtime/DatePrototype.cpp: Removed USE(ICU_UNICODE) checks, since that's always true now.

Source/WebCore:

CMakeLists.txt: Removed SmartReplaceICU.cpp.
GNUmakefile.list.am: Ditto.
PlatformEfl.cmake: Ditto.
PlatformGTK.cmake: Ditto.

editing/FrameSelection.cpp:

(WebCore::FrameSelection::modifyMovingRight): Ditto.
(WebCore::FrameSelection::modifyMovingLeft): Ditto.

editing/SmartReplace.cpp: Moved code here from SmartReplaceICU,

since we always support ICU now. Added some FIXME comments about
bugs and mistakes I spotted in the code as I was moving it.

editing/SmartReplaceICU.cpp: Removed.

editing/TextIterator.cpp: Removed unneeded checks.
platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData): Ditto.
(WebCore::ThreadGlobalData::destroy): Ditto.

platform/ThreadGlobalData.h: Ditto.
platform/URL.cpp:

(WebCore::appendEncodedHostname): Ditto.

platform/graphics/SurrogatePairAwareTextIterator.cpp: Ditto.

Also removed unneeded "using namespace".

platform/text/TextCodecICU.cpp: Ditto.
platform/text/TextEncoding.cpp:

(WebCore::TextEncoding::encode): Ditto.

platform/text/TextEncodingRegistry.cpp:

(WebCore::extendTextCodecMaps): Ditto.

Source/WTF:

wtf/CMakeLists.txt: Removed WTF_USE_ICU_UNICODE and

WTF_USE_WCHAR_UNICODE since they are true and false respectively.

wtf/Platform.h: Removed code to set WTF_USE_ICU_UNICODE.

wtf/unicode/Collator.h: Removed ifdefs.
wtf/unicode/CollatorDefault.cpp: Ditto.
wtf/unicode/Unicode.h: Ditto.
wtf/unicode/icu/CollatorICU.cpp: Ditto.

1:31 PM Changeset in webkit [162781] by Darin Adler

2 edits in trunk/Source/JavaScriptCore

[Mac] Rewrite locale-specific date formatting code to remove strange string creation
https://bugs.webkit.org/show_bug.cgi?id=127624

Reviewed by Anders Carlsson.

runtime/DatePrototype.cpp:

(JSC::formatLocaleDate): Use some smart pointers and conversion operators we already
have to do the formatting in a more straightforward way.

1:31 PM Changeset in webkit [162780] by Darin Adler

10 edits
2 deletes in trunk/Source/WebCore

Get rid of UnicodeRange.h/cpp, using ICU instead
https://bugs.webkit.org/show_bug.cgi?id=127622

Reviewed by Anders Carlsson.

CMakeLists.txt: Remove UnicodeRange.h/cpp.
GNUmakefile.list.am: Ditto.
WebCore.vcxproj/WebCore.vcxproj: Ditto.
WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.

platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::systemFallbackForCharacters): To check if a character has
multiple code pages, use UCHAR_UNIFIED_IDEOGRAPH instead of cRangeSetCJK.

platform/graphics/wince/FontCacheWinCE.cpp:

(WebCore::FontCache::systemFallbackForCharacters): Ditto. Also, to check if a
character is in the Thai block, use UBLOCK_THAI.

platform/graphics/wince/FontPlatformData.cpp: Removed include of UnicodeRange.h.

platform/text/UnicodeRange.cpp: Removed.
platform/text/UnicodeRange.h: Removed.

rendering/svg/SVGTextLayoutEngineBaseline.cpp:

(WebCore::SVGTextLayoutEngineBaseline::calculateGlyphOrientationAngle): To figure
out if a character is full width, use UCHAR_EAST_ASIAN_WIDTH, instead of hard-coding
"not Latin or Arabic" as the rule.

1:25 PM Changeset in webkit [162779] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

Remove an unnecessary platform #if in BitmapImage(CG)::checkForSolidColor()
https://bugs.webkit.org/show_bug.cgi?id=127610

Reviewed by Simon Fraser.

platform/graphics/cg/BitmapImageCG.cpp:

(WebCore::BitmapImage::checkForSolidColor):
Over time, the two sides of this #if !PLATFORM(IOS) converged. Remove the #if
and merge the code. We explicitly use kCGBitmapByteOrder32Big to be correct everywhere.

1:24 PM Changeset in webkit [162778] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

[cg] Look in the PNG dictionary for image duration information
https://bugs.webkit.org/show_bug.cgi?id=127611
<rdar://problem/15408643>

Reviewed by Simon Fraser.

We should look in the PNG properties dictionary for frame duration and loop count data.

platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::repetitionCount):
Mush repetitionCount a bit more to make it easier to read (early returns, etc.)
Also, look in the PNG properties dictionary for a loop count.

(WebCore::ImageSource::frameDurationAtIndex):
Look in the PNG properties dictionary for delay time.
Get rid of WebCoreCGImagePropertyGIFUnclampedDelayTime; it hasn't
been needed since Snow Leopard.

1:16 PM Changeset in webkit [162777] by andersca@apple.com

19 edits in trunk/Source

Remove atomicIncrement/atomicDecrement
https://bugs.webkit.org/show_bug.cgi?id=127625

Reviewed by Andreas Kling.

Replace atomicIncrement/atomicDecrement with std::atomic.

Source/JavaScriptCore:

bytecode/Watchpoint.h:
ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::lower):

profiler/ProfilerDatabase.cpp:

(JSC::Profiler::Database::Database):
(JSC::Profiler::Database::addDatabaseToAtExit):

Source/WebCore:

Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::incrementActiveSourceCount):
(WebCore::AudioContext::decrementActiveSourceCount):

Modules/webaudio/AudioContext.h:
Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::~AudioNode):
(WebCore::AudioNode::ref):
(WebCore::AudioNode::finishDeref):

Modules/webaudio/AudioNode.h:
Modules/webdatabase/OriginLock.h:

Source/WebKit2:

Platform/IPC/Connection.cpp:

(IPC::Connection::createSyncMessageEncoder):

Shared/mac/SecItemShim.cpp:

(WebKit::generateSecItemRequestID):

UIProcess/StatisticsRequest.cpp:

(WebKit::StatisticsRequest::addOutstandingRequest):

Source/WTF:

wtf/Atomics.h:
wtf/RefCountedLeakCounter.cpp:

(WTF::RefCountedLeakCounter::~RefCountedLeakCounter):
(WTF::RefCountedLeakCounter::increment):
(WTF::RefCountedLeakCounter::decrement):

wtf/RefCountedLeakCounter.h:
wtf/ThreadSafeRefCounted.h:

(WTF::ThreadSafeRefCountedBase::ref):
(WTF::ThreadSafeRefCountedBase::refCount):
(WTF::ThreadSafeRefCountedBase::derefBase):

12:49 PM Changeset in webkit [162776] by alex.christensen@flexsim.com

4 edits in trunk/Source

Source/WebCore: Unreviewed build fix for WinCairo.

platform/network/curl/CurlDownload.h:

Included wtf/Threading.h for ThreadIdentifier definition.

Source/WebKit: Unreviewed build fix for Win64.

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Corrected 64-bit linker symbol.

12:10 PM Changeset in webkit [162775] by andersca@apple.com

2 edits in trunk/Source/WebKit/mac

Build fix.

WebView/WebViewData.h:

11:24 AM Changeset in webkit [162774] by andersca@apple.com

16 edits in trunk

Modernize HashTable threading code
https://bugs.webkit.org/show_bug.cgi?id=127621

Reviewed by Darin Adler.

Source/WebCore:

Explicitly include headers that used to be brought in by HashTable.h

platform/DragData.h:

Change a Windows-specific typedef to avoid having to include WindDef.h from a header.

platform/audio/AudioSession.h:
platform/network/cf/SocketStreamHandle.h:

Source/WebKit/win:

Explicitly include headers that used to be brought in by HashTable.h

WebLocalizableStrings.cpp:

Source/WebKit2:

Explicitly include headers that used to be brought in by HashTable.h

Shared/BlockingResponseMap.h:

Source/WTF:

Use std::mutex and std::atomic instead of WTF threading primitives.

wtf/DynamicAnnotations.h:

Include Platform.h here since this file relies on USE macros.

wtf/HashTable.cpp:

(WTF::HashTableStats::recordCollisionAtCount):
Change this to take an unsigned.

(WTF::HashTableStats::dumpStats):

wtf/HashTable.h:

(WTF::KeyTraits>::HashTable):
(WTF::KeyTraits>::remove):
(WTF::KeyTraits>::invalidateIterators):
Use a single probe counter.

(WTF::addIterator):
(WTF::removeIterator):

Tools:

Explicitly include headers that used to be brought in by HashTable.h

DumpRenderTree/JavaScriptThreading.cpp:

10:55 AM Changeset in webkit [162773] by zandobersek@gmail.com

8 edits in trunk/Source/WebCore

Move CSSGroupingRule, CSSStyleSheet, ElementRuleCollector to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=127575

Reviewed by Andreas Kling.

Use std::unique_ptr and std::make_unique in place of OwnPtr and adoptPtr
in the CSSGroupingRule, CSSStyleSheet and ElementRuleCollector classes.

css/CSSFunctionValue.cpp: Remove the unnecessary PassOwnPtr header inclusion.
css/CSSGroupingRule.cpp:

(WebCore::CSSGroupingRule::cssRules):

css/CSSGroupingRule.h:
css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::cssRules):

css/CSSStyleSheet.h:
css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::addMatchedRule):

css/ElementRuleCollector.h:

10:54 AM Changeset in webkit [162772] by zandobersek@gmail.com

5 edits in trunk/Source/WebCore

Move MediaQueryMatcher, SelectorFilter to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=127574

Reviewed by Andreas Kling.

Replace the use of OwnPtr and adoptPtr with std::unique_ptr and std::make_unique
in the MediaQueryMatcher and SelectorFilter classes.

css/MediaQueryMatcher.cpp:

(WebCore::MediaQueryMatcher::prepareEvaluator):
(WebCore::MediaQueryMatcher::evaluate):
(WebCore::MediaQueryMatcher::addListener):
(WebCore::MediaQueryMatcher::styleResolverChanged):

css/MediaQueryMatcher.h:
css/SelectorFilter.cpp:

(WebCore::SelectorFilter::popParentStackFrame):
(WebCore::SelectorFilter::setupParentStack):

css/SelectorFilter.h:

10:52 AM Changeset in webkit [162771] by zandobersek@gmail.com

5 edits in trunk/Source/WebCore

Move PropertySetCSSStyleDeclaration, WebKitCSSKeyframesRule to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=127572

Reviewed by Andreas Kling.

Switch the PropertySetCSSStyleDeclaration and WebKitCSSKeyframesRule classes from using
OwnPtr and adoptPtr to using std::unique_ptr and std::make_unique.

css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::cloneAndCacheForCSSOM):
(WebCore::StyleRuleCSSStyleDeclaration::didMutate):
(WebCore::InlineCSSStyleDeclaration::didMutate):

css/PropertySetCSSStyleDeclaration.h:
css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::cssRules):

css/WebKitCSSKeyframesRule.h:

10:51 AM Changeset in webkit [162770] by zandobersek@gmail.com

6 edits in trunk/Source/WebCore

Move StyleProperties, StyleResolver to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=127570

Reviewed by Andreas Kling.

Move the StyleProperties and StyleResolver classes from using OwnPtr and adoptPtr
to using std::unique_ptr and std::make_unique.

css/StyleInvalidationAnalysis.h: Remove the PassOwnPtr.h header inclusion.
css/StyleProperties.cpp:

(WebCore::MutableStyleProperties::ensureCSSStyleDeclaration):
(WebCore::MutableStyleProperties::ensureInlineCSSStyleDeclaration):

css/StyleProperties.h:
css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::addViewportDependentMediaQueryResult):

css/StyleResolver.h:
css/StyleScopeResolver.h:

10:49 AM Changeset in webkit [162769] by zandobersek@gmail.com

5 edits in trunk/Source/WebCore

Move CSSFontFace, CSSFontSelector to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=127569

Reviewed by Andreas Kling.

Move the CSSFontFace and CSSFontSelector classes from using OwnPtr, PassOwnPtr and adoptPtr
to using std::unique_ptr, move semantics and std::make_unique.

css/CSSFontFace.cpp:

(WebCore::CSSFontFace::addSource):

css/CSSFontFace.h:
css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::CSSFontSelector::getFontFace):

css/CSSFontSelector.h:

10:48 AM Changeset in webkit [162768] by zandobersek@gmail.com

2 edits in trunk/Source/WebKit2

[GTK] Remove null check for WebPopupMenuProxy::Client in WebPopupMenuProxyGtk::showPopupMenu
https://bugs.webkit.org/show_bug.cgi?id=107036

Reviewed by Andreas Kling.

UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::showPopupMenu): Don't perform an early return
if the client is not available - it always should be. The client is set to null
only when the proxy is invalidated. This happens immediately after this function
returns, either with the popup being forced to close or being closed by the user
with possibly an item being chosen. Rather than the early return, use an ASSERT.

9:48 AM Changeset in webkit [162767] by Joseph Pecoraro

21 edits
2 moves
3 adds in trunk/Source

Web Inspector: Move InspectorRuntimeAgent into JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=127605

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:

Add new files to the build.

inspector/agents/InspectorRuntimeAgent.h: Renamed from Source/WebCore/inspector/InspectorRuntimeAgent.h.
inspector/agents/InspectorRuntimeAgent.cpp: Renamed from Source/WebCore/inspector/InspectorRuntimeAgent.cpp.

(Inspector::InspectorRuntimeAgent::InspectorRuntimeAgent):
(Inspector::InspectorRuntimeAgent::parse):
(Inspector::InspectorRuntimeAgent::evaluate):
(Inspector::InspectorRuntimeAgent::callFunctionOn):
(Inspector::InspectorRuntimeAgent::getProperties):

Move the agent into JavaScriptCore.
Modernize and cleanup.
Make globalVM a pure virtual function for subclasses to implement.

inspector/agents/JSGlobalObjectRuntimeAgent.h: Added.
inspector/agents/JSGlobalObjectRuntimeAgent.cpp: Added.

(Inspector::JSGlobalObjectRuntimeAgent::JSGlobalObjectRuntimeAgent):
(Inspector::JSGlobalObjectRuntimeAgent::didCreateFrontendAndBackend):
(Inspector::JSGlobalObjectRuntimeAgent::willDestroyFrontendAndBackend):
(Inspector::JSGlobalObjectRuntimeAgent::globalVM):
(Inspector::JSGlobalObjectRuntimeAgent::injectedScriptForEval):
Straightforward JSGlobalObject implementation.

inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
Add a runtime agent when inspecting a JSContext!

Source/WebCore:

Covered by existing tests. No change in functionality.

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
inspector/InspectorAllInOne.cpp:

Remove WebCore InspectorRuntimeAgent.

ForwardingHeaders/inspector/agents/InspectorRuntimeAgent.h: Added.

Add JavaScriptCore InspectorRuntimeAgent.

inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

inspector/WorkerInspectorController.h:
inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):
New constructors for the runtime agent.

inspector/PageRuntimeAgent.h:
inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::PageRuntimeAgent):
(WebCore::PageRuntimeAgent::enable):
(WebCore::PageRuntimeAgent::disable):
(WebCore::PageRuntimeAgent::didCreateMainWorldContext):
(WebCore::PageRuntimeAgent::didCreateIsolatedContext):
(WebCore::PageRuntimeAgent::globalVM):
Modernize and implement globalVM.

inspector/WorkerRuntimeAgent.h:
inspector/WorkerRuntimeAgent.cpp:

(WebCore::WorkerRuntimeAgent::WorkerRuntimeAgent):
(WebCore::WorkerRuntimeAgent::injectedScriptForEval):
(WebCore::WorkerRuntimeAgent::globalVM):
Modernize and implement globalVM.

9:25 AM Changeset in webkit [162766] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GTK] Add parameters from 'DOM Object Model Core' spec and 'DOM CSS' spec that can be NULL

https://bugs.webkit.org/show_bug.cgi?id=117536

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-01-25
Reviewed by Xan Lopez.

bindings/scripts/CodeGeneratorGObject.pm:

(ParamCanBeNull): Add new pairs (function, parameter) that can be NULL

9:18 AM Changeset in webkit [162765] by Darin Adler

2 edits in trunk/Source/WTF

Restore alphabetical order in Compiler.h
https://bugs.webkit.org/show_bug.cgi?id=127620

Reviewed by Sam Weinig.

wtf/Compiler.h: Resorted some things into alphabetical order

9:16 AM Changeset in webkit [162764] by andersca@apple.com

8 edits in trunk/Source

Get rid of BackForwardController::isActive()
https://bugs.webkit.org/show_bug.cgi?id=127604

Reviewed by Sam Weinig.

Source/WebCore:

BackForwardController::isActive() used to mean "my page maintains a back forward
list that has zero capacity". Move that logic into WebKit instead, namely the
WebFrameLoaderClient::canCachePage function so we can simplify WebCore.