Timeline
Jan 27, 2014:
- 11:52 PM Changeset in webkit [162920] by
-
- 26 edits in trunk
[GTK] Make webkit_uri_scheme_request_get_web_view() work with CustomProtocols
https://bugs.webkit.org/show_bug.cgi?id=127614
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Add API to set the page identifier that initiated the request to
ResourceRequest, and remove the initiatingPageID() method from the
NetworkingContext class.
- platform/network/NetworkingContext.h:
- platform/network/ResourceHandle.h:
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::createSoupRequestAndMessageForHandle):
- platform/network/soup/ResourceRequest.h:
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::initiatingPageID):
(WebCore::ResourceRequest::setInitiatingPageID):
- platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::updateSoupRequest):
(WebCore::ResourceRequest::updateFromSoupRequest):
Source/WebKit/efl:
Remove initiatingPageID() method form the FrameNetworkingContext.
- WebCoreSupport/FrameNetworkingContextEfl.cpp:
- WebCoreSupport/FrameNetworkingContextEfl.h:
Source/WebKit/gtk:
Remove initiatingPageID() method from FrameNetworkingContext.
- WebCoreSupport/FrameNetworkingContextGtk.cpp:
- WebCoreSupport/FrameNetworkingContextGtk.h:
Source/WebKit2:
- NetworkProcess/RemoteNetworkingContext.h: Remove
initiatingPageID() method.
- NetworkProcess/soup/RemoteNetworkingContextSoup.cpp: Ditto.
- Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.cpp:
(WebKit::CustomProtocolManagerImpl::send): Create the request with
the ResourceRequest constructor that receives a SoupRequest.
- Shared/soup/WebCoreArgumentCodersSoup.cpp:
(IPC::ArgumentCoder<ResourceRequest>::encodePlatformData): Encode initiatingPageID.
(IPC::ArgumentCoder<ResourceRequest>::decodePlatformData): Decode initiatingPageID.
- UIProcess/API/gtk/WebKitURISchemeRequest.cpp:
(webkitURISchemeRequestCreate): Remove initiatingPageID parameter
and get it from the given ResourceRequest.
- UIProcess/API/gtk/WebKitURISchemeRequestPrivate.h:
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextStartLoadingCustomProtocol): Update to
webkitURISchemeRequestCreate API change.
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(willSendRequestForFrame): Set the initiatingPageID to the ResourceRequest.
- WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:
(WebKit::WebFrameNetworkingContext::WebFrameNetworkingContext):
Remove initiatingPageID() method.
- WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
- WebProcess/soup/WebSoupRequestManager.cpp:
(WebKit::WebSoupRequestManager::send): Get the initiatingPageID
from the SoupRequest using the ResourceRequest API.
Tools:
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Bring
back the custom URI scheme WebView check.
- 11:43 PM Changeset in webkit [162919] by
-
- 3 edits in trunk/Source/WebKit/efl
[EFL][WK1] Remove ewk_history_item_time_last_visited_get and ewk_history_item_visit_count
https://bugs.webkit.org/show_bug.cgi?id=127662
Reviewed by Gyuyoung Kim.
These APIs are exposing WebCore's internal structure, but they removed
from WebCore since 162808.
This patch removed not to support them because applications can do it
if they want.
- ewk/ewk_history.cpp:
- ewk/ewk_history.h:
- 11:29 PM Changeset in webkit [162918] by
-
- 11 edits in trunk/Source/JavaScriptCore
-[JSContext evaluteScript:] calls JSEvaluteScript with startingLineNumber 0, later interpreted as a oneBasedInt
https://bugs.webkit.org/show_bug.cgi?id=127648
Reviewed by Geoffrey Garen.
The actual bug being fixed here is that the line number for
scripts evaluated via the JSC APIs is now sane. However,
there is no good infrastructure in place right now to test that.
- API/tests/testapi.c:
(main):
- API/tests/testapi.mm:
(testObjectiveCAPI):
Add tests for exception line numbers and handling of bad
startingLineNumbers in public APIs. These tests were already
passing, I just add them to make sure they are not regressed
in the future.
- API/JSBase.cpp:
(JSEvaluateScript):
(JSCheckScriptSyntax):
- API/JSBase.h:
- API/JSObjectRef.cpp:
(JSObjectMakeFunction):
- API/JSObjectRef.h:
- API/JSScriptRef.cpp:
- API/JSScriptRefPrivate.h:
- API/JSStringRef.h:
- Clarify documentation that startingLineNumber is 1 based and clamped.
- Add clamping in the implementation to put sane values into JSC::SourceProvider.
- inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::InspectorDebuggerAgent::didParseSource):
Remove the FIXME now that the SourceProvider is giving us expected values.
- 11:25 PM Changeset in webkit [162917] by
-
- 3 edits in trunk/Tools
Revert yet one more tiny part of r162629 that didn't get reverted in r162883
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::pluginLoadPolicy):
- WebKitTestRunner/TestController.h:
- 11:20 PM Changeset in webkit [162916] by
-
- 2 edits in trunk/Tools
Revert one more tiny part of r162629 that didn't get reverted in r162883.
... which was also causing test failures!
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions):
- 11:16 PM Changeset in webkit [162915] by
-
- 2 edits in trunk/Source/WebCore
Lots of varied and random crashes on the scrolling thread (ScrollbarPainters are going away)
https://bugs.webkit.org/show_bug.cgi?id=127734
<rdar://problem/15906263>
Reviewed by Simon Fraser.
- page/scrolling/ScrollingStateScrollingNode.h:
Retain the ScrollbarPainters in the scrolling state tree.
- 9:29 PM Changeset in webkit [162914] by
-
- 211 edits5 adds in branches/jsCStack
Merge branch up to ToT r162909.
- 9:19 PM Changeset in webkit [162913] by
-
- 4 edits in trunk/Source
Unreviewed iOS build fix. FALLTHROUGHs for iOS.
Source/WebCore:
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityTraits]):
(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
Source/WebKit/ios:
- Misc/WebNSStringDrawing.mm:
(needsBidiLayout):
- 9:09 PM Changeset in webkit [162912] by
-
- 6 edits in trunk/Source
WebGLLoadPolicy::WebGLAsk is an unnecessary value.
https://bugs.webkit.org/show_bug.cgi?id=127755
Reviewed by Anders Carlsson.
- UIProcess/API/C/WKAPICast.h:
(WebKit::toWebGLLoadPolicy):
- UIProcess/API/C/WKPageLoaderClient.h:
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
- loader/FrameLoaderTypes.h:
- 9:03 PM Changeset in webkit [162911] by
-
- 15 edits in trunk/Source
IDB: Cursor support - Messaging, IPC, Threading plumbing
https://bugs.webkit.org/show_bug.cgi?id=127736
Reviewed by Sam Weinig.
Source/WebCore:
- Modules/indexeddb/IDBCursorBackendOperations.h:
(WebCore::CursorIterationOperation::cursorID):
(WebCore::CursorAdvanceOperation::cursorID):
- Modules/indexeddb/IDBTransactionBackendOperations.h:
(WebCore::OpenCursorOperation::transactionID):
- WebCore.exp.in:
Source/WebKit2:
Pipe three cursor-related calls to the DatabaseProcess, and handle messages
from the database process when it is done handling them:
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
(WebKit::WebIDBServerConnection::didOpenCursor):
(WebKit::WebIDBServerConnection::didAdvanceCursor):
(WebKit::WebIDBServerConnection::didIterateCursor):
(WebKit::WebIDBServerConnection::openCursor):
(WebKit::WebIDBServerConnection::cursorAdvance):
(WebKit::WebIDBServerConnection::cursorIterate):
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in:
Pipe the calls through to the appropriate UniqueIDBDatabase:
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:
(WebKit::DatabaseProcessIDBConnection::openCursor):
(WebKit::DatabaseProcessIDBConnection::cursorAdvance):
(WebKit::DatabaseProcessIDBConnection::cursorIterate):
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:
Pass the calls to the backing store thread, then message back to the WebProcess
when the requests are complete.
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
(WebKit::UniqueIDBDatabase::openCursor):
(WebKit::UniqueIDBDatabase::cursorAdvance):
(WebKit::UniqueIDBDatabase::cursorIterate):
(WebKit::UniqueIDBDatabase::openCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didOpenCursorInBackingStore):
(WebKit::UniqueIDBDatabase::advanceCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didAdvanceCursorInBackingStore):
(WebKit::UniqueIDBDatabase::iterateCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didIterateCursorInBackingStore):
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
- Shared/WebCrossThreadCopier.cpp:
(WebCore::Vector<char>>::copy):
- Shared/WebCrossThreadCopier.h:
- 8:55 PM Changeset in webkit [162910] by
-
- 5 edits in trunk/Source/JavaScriptCore
Web Inspector: CRASH when debugger closes remote inspecting JSContext
https://bugs.webkit.org/show_bug.cgi?id=127738
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-27
Reviewed by Timothy Hatcher.
RemoteInspectorXPCConnection could be accessed in a background dispatch
queue, while being deallocated on the main thread when a connection
was suddenly terminated.
Make RemoteInspectorXPCConnection a ThreadSafeRefCounted object. Always
keep the connection object ref'd until the main thread calls close()
and removes its reference. At that point we can close the connection,
queue, and deref safely on the background queue.
- inspector/remote/RemoteInspector.h:
- inspector/remote/RemoteInspector.mm:
(Inspector::RemoteInspector::setupXPCConnectionIfNeeded):
(Inspector::RemoteInspector::xpcConnectionFailed):
For simplicity RemoteInspectorXPCConnections's don't have any threading
primatives to prevent client callbacks after they are closed. RemoteInspector
does, so it just ignores possible callbacks from connections it no longer
cares about.
- inspector/remote/RemoteInspectorXPCConnection.h:
- inspector/remote/RemoteInspectorXPCConnection.mm:
(Inspector::RemoteInspectorXPCConnection::RemoteInspectorXPCConnection):
(Inspector::RemoteInspectorXPCConnection::~RemoteInspectorXPCConnection):
(Inspector::RemoteInspectorXPCConnection::close):
Keep the connection alive as long as the queue it can be used on
is alive. Clean up everything on the queue when close() is called.
(Inspector::RemoteInspectorXPCConnection::handleEvent):
Checking if closed here is not thread safe so it is meaningless.
Remove the check.
(Inspector::RemoteInspectorXPCConnection::sendMessage):
Bail based on the m_closed state.
- 8:04 PM Changeset in webkit [162909] by
-
- 4 edits in trunk/Source/WebKit2
WebKit2: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
https://bugs.webkit.org/show_bug.cgi?id=127665
Reviewed by Anders Carlsson.
- Shared/UserData.cpp:
(WebKit::UserData::encode):
These look like they should not have fallen through!
- Configurations/Base.xcconfig:
- Shared/mac/ObjCObjectGraphCoders.mm:
(WebKit::InjectedBundleObjCObjectGraphEncoderImpl::encode):
- 8:04 PM Changeset in webkit [162908] by
-
- 4 edits in trunk/Source/WebKit/mac
WebKit1: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
https://bugs.webkit.org/show_bug.cgi?id=127664
Reviewed by Darin Adler.
- Configurations/Base.xcconfig:
- History/BinaryPropertyList.cpp:
(BinaryPropertyListSerializer::appendObjectReference):
(BinaryPropertyListSerializer::startObject):
(BinaryPropertyListSerializer::addAggregateObjectReference):
- WebView/WebPDFView.mm:
(-[WebPDFView PDFViewWillClickOnLink:withURL:]):
- 8:04 PM Changeset in webkit [162907] by
-
- 45 edits in trunk/Source
WebCore: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
https://bugs.webkit.org/show_bug.cgi?id=127671
Source/WebCore:
Reviewed by Ryosuke Niwa.
- Configurations/Base.xcconfig:
Enable the warning.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
Caught a bug. CSSPropertyWebkitAlt could fall through to CSSPropertyQuotes.
- css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
Caught a bug. CSSPropertyWebkitSvgShadow could fall through to CSSPropertyMaskType.
- platform/Decimal.cpp:
(WebCore::Decimal::fromString):
Possible bug. Implementation doesn't seem to match its documentation.
Filed an issue to follow-up on this unclear function.
- css/makeprop.pl:
- css/makevalues.pl:
- platform/ColorData.gperf:
Ignore implicit fallthrough warnings in generated code. gperf outputs
a "/*FALLTHROUGH*/" comment, but is not easily customizable to change
this output. Easiest to just ignore the warning for now.
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::layout):
There has been a "fall through" comment immediately followed by a break
since its introduction in 2003. Removing the inaccurate comment.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::canHaveChildren):
(WebCore::AccessibilityNodeObject::visibleText):
(WebCore::AccessibilityNodeObject::title):
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase accessibilityDescription]):
(-[WebAccessibilityObjectWrapperBase accessibilityHelpText]):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::serialize):
(WebCore::CloneDeserializer::deserialize):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::realLex):
- css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType):
(WebCore::CSSSelector::selectorText):
- css/StyleProperties.cpp:
(WebCore::StyleProperties::asText):
- css/StyleSheetContents.cpp:
(WebCore::childRulesHaveFailedOrCanceledSubresources):
- dom/Node.cpp:
(WebCore::appendTextContent):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processCharacterBuffer):
(WebCore::HTMLTreeBuilder::processEndOfFile):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
- page/EventSource.cpp:
(WebCore::EventSource::parseEventStream):
- platform/DateComponents.cpp:
(WebCore::DateComponents::toStringForTime):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::updateStates):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::platformInit):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::totalBytes):
- platform/graphics/win/FullScreenController.cpp:
(FullScreenController::Private::fullscreenClientWndProc):
- platform/text/BidiResolver.h:
(WebCore::Run>::updateStatusLastFromCurrentDirection):
(WebCore::Run>::createBidiRunsForLine):
- platform/text/win/LocaleWin.cpp:
(WebCore::LocaleWin::initializeLocaleData):
- rendering/PointerEventsHitRules.cpp:
(WebCore::PointerEventsHitRules::PointerEventsHitRules):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::newLine):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::updateLogicalWidthForAlignment):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateFillTileSize):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):
- rendering/RenderQuote.cpp:
(WebCore::RenderQuote::originalText):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::replacedContentRect):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setWordSpacing):
- rendering/svg/RenderSVGResource.cpp:
(WebCore::requestPaintingResource):
- rendering/svg/SVGMarkerData.h:
(WebCore::SVGMarkerData::updateMarkerDataForPathElement):
- svg/SVGPathParser.cpp:
(WebCore::SVGPathParser::parsePathDataFromSource):
- svg/SVGTransformDistance.cpp:
(WebCore::SVGTransformDistance::SVGTransformDistance):
(WebCore::SVGTransformDistance::scaledDistance):
(WebCore::SVGTransformDistance::addSVGTransforms):
(WebCore::SVGTransformDistance::addToSVGTransform):
(WebCore::SVGTransformDistance::distance):
Add annotation or break before falling into a default:break;
Source/WTF:
Reviewed by Ryosuke Niwa.
- wtf/text/WTFString.h:
(WTF::appendNumber):
- 8:04 PM Changeset in webkit [162906] by
-
- 16 edits in trunk/Source/JavaScriptCore
JavaScriptCore: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
https://bugs.webkit.org/show_bug.cgi?id=127647
Reviewed by Anders Carlsson.
Explicitly annotate switch case fallthroughs in JavaScriptCore and
enable warnings for unannotated fallthroughs.
- dfg/DFGArithMode.h:
(doesOverflow):
Only insert FALLTHROUGH in release builds. In debug builds, the
FALLTHROUGH would be unreachable (due to the ASSERT_NOT_REACHED)
and would through a warning.
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt52):
Due to the templatized nature of this function, a fallthrough
in one of the template expansions would be unreachable. Disable
the warning for this function.
- Configurations/Base.xcconfig:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
- dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::run):
- dfg/DFGValidate.cpp:
(JSC::DFG::Validate::validateCPS):
- parser/Lexer.cpp:
(JSC::Lexer<T>::lex):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseStatement):
(JSC::Parser<LexerType>::parseProperty):
- runtime/JSArray.cpp:
(JSC::JSArray::push):
- runtime/JSONObject.cpp:
(JSC::Walker::walk):
- runtime/JSObject.cpp:
(JSC::JSObject::putByIndex):
(JSC::JSObject::putByIndexBeyondVectorLength):
- runtime/JSObject.h:
(JSC::JSObject::setIndexQuickly):
(JSC::JSObject::initializeIndex):
- runtime/LiteralParser.cpp:
(JSC::LiteralParser<CharType>::parse):
- yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::backtrackParenthesesOnceBegin):
(JSC::Yarr::Interpreter::backtrackParenthesesOnceEnd):
- yarr/YarrParser.h:
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomPatternCharacter):
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomBuiltInCharacterClass):
(JSC::Yarr::Parser::parseEscape):
(JSC::Yarr::Parser::parseTokens):
- 7:36 PM Changeset in webkit [162905] by
-
- 2 edits1 add in branches/jsCStack/Source/JavaScriptCore
DFG ArrayPush implementation does strange things to the result register on the slow path
https://bugs.webkit.org/show_bug.cgi?id=127754
Reviewed by Michael Saboff.
This told the slow path machinery that there was NoResult, which then sort of worked
by accident because it would invoke a callOperation and pass the result register
(i.e. storageLengthGPR) thinking it was giving it the first argument when in reality
that callOperation would use it as the result register. The downside is that we would
probably fail to omit the result register from silent spilling, but that probably
doesn't even matter since storageLengthGPR doesn't appear as an in-use register (it's
locked, but not attached to a Node, and so it's not "in use").
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- tests/stress/array-push.js: Added.
(foo):
- 6:56 PM Changeset in webkit [162904] by
-
- 10 edits in trunk/Source/WebKit2
[WebKit2] Add SPI to disable the WebCore memory cache
https://bugs.webkit.org/show_bug.cgi?id=127747
Reviewed by Tim Horton.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
Initialized memoryCacheDisabled to false.
(WebKit::WebProcessCreationParameters::encode):
Encoded memoryCacheDisabled.
(WebKit::WebProcessCreationParameters::decode):
Decoded memoryCacheDisabled.
- Shared/WebProcessCreationParameters.h:
- UIProcess/API/C/WKContext.cpp:
(WKContextSetMemoryCacheDisabled):
Called WebContext::setMemoryCacheDisabled().
- UIProcess/API/C/WKContextPrivate.h: Declared new SPI.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext): Initialized m_memoryCacheDisabled to false.
(WebKit::WebContext::createNewWebProcess):
Set WebProcessCreationParameters::memoryCacheDisabled to m_memoryCacheDisabled.
(WebKit::WebContext::setMemoryCacheDisabled): Set m_memoryCacheDisabled
and sent new value to all existing processes.
- UIProcess/WebContext.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
Called WebProcess::setMemoryCacheDisabled().
(WebKit::WebProcess::setMemoryCacheDisabled):
Called MemoryCache::setDisabled() if the disabled state changed.
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- 6:50 PM Changeset in webkit [162903] by
-
- 1 edit in branches/jsCStack/Source/JavaScriptCore/ChangeLog
Mark appropriate things as reviewed
- 6:31 PM Changeset in webkit [162902] by
-
- 1 edit in branches/jsCStack/Source/JavaScriptCore/ChangeLog
Mark appropriate things as reviewed
- 6:12 PM Changeset in webkit [162901] by
-
- 1 copy in tags/Safari-537.75.1
New Tag
- 6:12 PM Changeset in webkit [162900] by
-
- 1 edit in branches/jsCStack/Source/WebKit/mac/postprocess-headers.sh
Set exectueable property to match trunk.
- 6:04 PM Changeset in webkit [162899] by
-
- 3 edits in trunk/Source/WebKit2
Add -[WKWebView loadRequest:] API
https://bugs.webkit.org/show_bug.cgi?id=127727
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKWebView.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
(-[WKWebView loadRequest:]):
- 6:02 PM Changeset in webkit [162898] by
-
- 3 edits in trunk/Tools
iOS DumpRenderTree.app dies loading fonts
https://bugs.webkit.org/show_bug.cgi?id=127730
Reviewed by Daniel Bates.
- DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
- Add Ahem to the DATA section
- DumpRenderTree/mac/DumpRenderTree.mm:
(activateFontsIOS):
- Load "WeightWatcher100" instead.
- 5:59 PM Changeset in webkit [162897] by
-
- 3 edits in trunk/Source/WebCore
Allow mmap encoded data replacement for WOFF fonts.
<https://webkit.org/b/127737>
We always have to convert WOFF fonts to SFNT format. This happens
in a separate buffer from the CachedFont's internal resource buffer.
Because of this, there's no need to protect the original buffer from
mmap replacement.
With this change, WOFF web fonts are no longer duplicated between
the network and web processes.
Reviewed by Brady Eidson.
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::CachedFont):
(WebCore::CachedFont::ensureCustomFontData):
(WebCore::CachedFont::mayTryReplaceEncodedData):
- loader/cache/CachedFont.h:
- 5:56 PM Changeset in webkit [162896] by
-
- 7 edits in trunk/LayoutTests
Web Inspector: clean up initialization of managers and observers in InspectorTest
https://bugs.webkit.org/show_bug.cgi?id=127707
Reviewed by Timothy Hatcher.
The test harness was setting up managers and observers before
telling the frontend host that the page loaded. The InspectorObserver
was also not being initialized.
For clarity, rename importInspectorScripts to initializeInspectorModels.
For easier debugging, make model test assertions use InspectorTest.log.
- http/tests/inspector-protocol/resources/InspectorTest.js:
(InspectorTest.initializeInspectorModels.console.error.window.onerror):
(InspectorTest.initializeInspectorModels.console.assert):
(InspectorTest.initializeInspectorModels):
- inspector-protocol/model/content-flow-content-nodes.html:
- inspector-protocol/model/content-flow-content-removal.html:
- inspector-protocol/model/content-flow-list.html:
- inspector-protocol/model/content-node-region-info.html:
- inspector-protocol/model/main-frame-resource.html:
- 5:50 PM Changeset in webkit [162895] by
-
- 2 edits in trunk/Tools
[Mac] Extra logging output from run-safari --no-saved-state
https://bugs.webkit.org/show_bug.cgi?id=127732
Reviewed by Daniel Bates.
- Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): Use an option that
disables saved state without logging.
- 5:45 PM Changeset in webkit [162894] by
-
- 969 edits17 adds4 deletes in branches/jsCStack
Getting all layout tests passing on the branch.
- 5:35 PM Changeset in webkit [162893] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
Structure::dump() should say things about specific values
https://bugs.webkit.org/show_bug.cgi?id=127741
Not yet reviewed.
- runtime/Structure.cpp:
(JSC::Structure::dump):
- 5:26 PM Changeset in webkit [162892] by
-
- 13 edits4 adds in trunk
[New Multicolumn] Add support for block progression axis and reverse direction
https://bugs.webkit.org/show_bug.cgi?id=127715
Reviewed by thorton.
This patch adds support for -webkit-progression-direction and -webkit-progression-axis
to the new column code. This allows columns to stack along the block axis instead of
the inline axis or to reverse directions along that progression axis.
Added fast/multicol/newmulticol/progression-reverse.html and
fast/multicol/newmulticol/progression-reverse-overflow.html
Source/WebCore:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::isTopLayoutOverflowAllowed):
(WebCore::RenderBlock::isLeftLayoutOverflowAllowed):
New functions have been added for top and left layout overflow in order to get
a bunch of code out of RenderBox that didn't belong there. RenderBlock is overriding
the functions for the old multicolumn layout code to keep it working.
- rendering/RenderBlock.h:
Added the new top/left overflow functions.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::determineLogicalLeftPositionForChild):
Moved from RenderBlock, since it didn't belong there.
(WebCore::RenderBlockFlow::isTopLayoutOverflowAllowed):
(WebCore::RenderBlockFlow::isLeftLayoutOverflowAllowed):
- rendering/RenderBlockFlow.h:
Overridden for the new multi-column code to specify when top/left overflow are
allowed (e.g., when the columns go backwards).
- rendering/RenderBox.cpp:
(WebCore::RenderBox::addLayoutOverflow):
Overridden to use the new top/left overflow functions.
- rendering/RenderBox.h:
(WebCore::RenderBox::isTopLayoutOverflowAllowed):
(WebCore::RenderBox::isLeftLayoutOverflowAllowed):
Added base definitions that look at direction and writing-mode.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::isTopLayoutOverflowAllowed):
(WebCore::RenderFlexibleBox::isLeftLayoutOverflowAllowed):
- rendering/RenderFlexibleBox.h:
Overrides for flexible box of the top/left overflow functions.
- rendering/RenderMultiColumnFlowThread.h:
Make sure requiresBalancing() is set to false if the axis of the columns
is block, since at least right now, we don't support balancing columns
along the block axis. (In theory we could support this in the future, but
nobody has requested it.)
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::updateLogicalWidth):
Remove the code that expands the width of multi column sets. We now always
let their logical width match the containing block's content width and instead
add the overflow to the set itself.
(WebCore::RenderMultiColumnSet::columnRectAt):
(WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):
(WebCore::RenderMultiColumnSet::paintColumnRules):
(WebCore::RenderMultiColumnSet::initialBlockOffsetForPainting):
(WebCore::RenderMultiColumnSet::collectLayerFragments):
(WebCore::RenderMultiColumnSet::adjustRegionBoundsFromFlowThreadPortionRect):
Patch all of these functions to know how to handle a block axis or reversed
direction.
(WebCore::RenderMultiColumnSet::addOverflowFromChildren):
- rendering/RenderMultiColumnSet.h:
Make multi-column set add in its overflow in the same way that the old
multi-column code did, by looking at the last column rect. (This is really
not a very good way to do it, but it's the same as the old code for now.)
LayoutTests:
- fast/multicol/newmulticol/progression-reverse-expected.html: Added.
- fast/multicol/newmulticol/progression-reverse-overflow-expected.html: Added.
- fast/multicol/newmulticol/progression-reverse-overflow.html: Added.
- fast/multicol/newmulticol/progression-reverse.html: Added.
- 5:17 PM Changeset in webkit [162891] by
-
- 9 edits in trunk/Source/WebKit2
IDB: Rename "IDBTransactionIdentifier" to be more general purpose (take 2)
https://bugs.webkit.org/show_bug.cgi?id=127717
Reviewed by Tim Horton.
Update all related variable names since the type no longer contains the relevant info.
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
- DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
- DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.cpp:
- DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.h:
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:
- Shared/WebCrossThreadCopier.cpp:
- 5:12 PM Changeset in webkit [162890] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening. Add test expectations for failing tests.
- platform/efl/TestExpectations:
- 5:01 PM Changeset in webkit [162889] by
-
- 2 edits in trunk/Source/WebCore
Fix the Mac build following <http://trac.webkit.org/changeset/162887>
(https://bugs.webkit.org/show_bug.cgi?id=127703)
Export symbol for WebCore::AXObjectCache::enableAccessibility().
- WebCore.exp.in:
- 4:49 PM Changeset in webkit [162888] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Unreviewed build fix. Add missing export symbol.
- WebCore.exp.in:
- 4:31 PM Changeset in webkit [162887] by
-
- 5 edits in trunk/Source
[Windows] Tests crashing on Windows after r162816.
https://bugs.webkit.org/show_bug.cgi?id=127703.
Reviewed by Alexey Proskuryakov.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::enableAccessibility):
(WebCore::AXObjectCache::disableAccessibility):
- accessibility/AXObjectCache.h: Un-inline some methods so that they can be exported.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Remove variable export in favor of function export.
- 4:24 PM Changeset in webkit [162886] by
-
- 2 edits in trunk/Source/WebKit2
Copy relevant code from the iOS version of WKView to WKWebView
https://bugs.webkit.org/show_bug.cgi?id=127721
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
(-[WKWebView setFrame:]):
(-[WKWebView setBounds:]):
(-[WKWebView scrollView]):
(-[WKWebView browsingContextController]):
(-[WKWebView contentView:contentsSizeDidChange:]):
(-[WKWebView contentViewDidCommitLoadForMainFrame:]):
(-[WKWebView contentViewDidReceiveMobileDocType:]):
(-[WKWebView contentView:didChangeViewportArgumentsSize:initialScale:minimumScale:maximumScale:allowsUserScaling:]):
(-[WKWebView viewportHandlerDidChangeScales:]):
(-[WKWebView viewportHandler:didChangeViewportSize:]):
(-[WKWebView viewForZoomingInScrollView:]):
(-[WKWebView scrollViewWillBeginZooming:withView:]):
(-[WKWebView _didFinishScroll]):
(-[WKWebView scrollViewDidEndDragging:willDecelerate:]):
(-[WKWebView scrollViewDidEndDecelerating:]):
(-[WKWebView scrollViewDidScrollToTop:]):
(-[WKWebView scrollViewDidScroll:]):
(-[WKWebView scrollViewDidEndZooming:withView:atScale:]):
(-[WKWebView _frameOrBoundsChanged]):
(-[WKWebView _setDocumentScale:]):
- 4:20 PM Changeset in webkit [162885] by
-
- 3 edits in trunk/Source/WebCore
Update bindings test expectations after r162872
- bindings/scripts/test/ObjC/DOMTestInterface.h:
- bindings/scripts/test/ObjC/DOMTestObj.h:
- 4:18 PM Changeset in webkit [162884] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening, unskip now passing webgl tests on EFL port.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 4:07 PM Changeset in webkit [162883] by
-
- 12 edits in trunk
Revert the parts of r162629 that add a new pluginLoadPolicy and the context menu item.
We're leaving the parts that make us use PDFPlugin instead of showing the blocked
plugin indicator intact, though.
- UIProcess/API/APILoaderClient.h:
(API::LoaderClient::pluginLoadPolicy):
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageLoaderClient):
- UIProcess/API/C/WKPageLoaderClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findPlugin):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/Plugins/PDF/PDFPlugin.h:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::PDFPlugin):
(WebKit::PDFPlugin::handleContextMenuEvent):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
(WebKit::WebPage::canPluginHandleResponse):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions):
- 4:04 PM Changeset in webkit [162882] by
-
- 3 edits in trunk/Source/WebKit2
Add a WKContentView initializer that takes a WKWebViewConfiguration
https://bugs.webkit.org/show_bug.cgi?id=127718
Reviewed by Tim Horton.
This initializer will be used by WKWebView.
- UIProcess/API/ios/WKContentView.h:
- UIProcess/API/ios/WKContentView.mm:
(-[WKContentView initWithFrame:configuration:]):
- 4:01 PM Changeset in webkit [162881] by
-
- 18 edits in trunk
Scrub WebKit API headers of WTF macros
https://bugs.webkit.org/show_bug.cgi?id=127706
Reviewed by David Kilzer.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig: Added ENABLE_INSPECTOR.
Source/WebCore:
- Configurations/FeatureDefines.xcconfig: Added ENABLE_INSPECTOR.
- bindings/objc/DOMEvents.h: Guarded include of
DOM{Gesture,Touch}Event.h with TARGET_OS_IPHONE, since those features
are always enabled on iOS.
- platform/graphics/mac/MediaPlayerProxy.h: Replaced PLATFORM(IOS) with
TARGET_OS_IPHONE and ensured ENABLE_IOS_AIRPLAY is defined.
- platform/ios/SystemMemory.h: Replaced PLATFORM(IOS) with
TARGET_OS_IPHONE.
- platform/ios/wak/WKGraphics.h: Replaced PLATFORM(IOS_SIMULATOR) with
TARGET_IPHONE_SIMULATOR.
Source/WebKit/ios:
- WebCoreSupport/WebMIMETypeRegistry.h: Changed PLATFORM(IOS) to
TARGET_OS_IPHONE.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig: Added ENABLE_INSPECTOR.
- WebView/WebPreferenceKeysPrivate.h: Changed ENABLE(REMOTE_INSPECTOR)
to !defined(ENABLE_REMOTE_INSPECTOR) ENABLE_REMOTE_INSPECTOR. We are in a TARGET_OS_IPHONE block, and ENABLE_REMOTE_INSPECTOR is enabled by
default on iOS, so include this block unless the feature is explicitly
disabled.
- postprocess-headers.sh: Stopped processing ENABLE_IOS_TOUCH_EVENTS
and ENABLE_IOS_GESTURE_EVENTS. These are now defined in DOMEvents.h.
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig: Added ENABLE_INSPECTOR.
Tools:
- Scripts/check-for-inappropriate-macros-in-external-headers: Modified
the regex to require a '(' after the macro name in order to be
considered a match. This prevents things like 'ENABLE_SOME_FEATURE'
from being flagged as an ENABLE() macro.
- 3:56 PM Changeset in webkit [162880] by
-
- 2 edits in trunk/Source/WebKit2
Crashes in RemoteScrollingCoordinatorProxy::rootScrollingNodeID
Reviewed by Simon Fraser.
- UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:
(WebKit::RemoteScrollingCoordinatorProxy::rootScrollingNodeID):
Null-check the root scrolling node, in case something scrolls before
we've made the first remote layer/scrolling tree commit.
- 3:51 PM Changeset in webkit [162879] by
-
- 3 edits in trunk/Source/WebCore
[iOS] Use callOnMainThread() not dispatch_async() in MediaPlayerPrivateAVFoundationObjC
https://bugs.webkit.org/show_bug.cgi?id=127701
Reviewed by Eric Carlson.
dispatch_async(dispatch_get_main_queue(), ...) used to be fine so long as the main
thread was also the web thread. But since that's not the case on iOS, we should be
using callOnMainThread() instead (because it dispatches to the web thread, not as
its name implies, the main thread).
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createWeakPtr):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::seekToTime):
(-[WebCoreAVFMovieObserver legibleOutput:didOutputAttributedStrings:nativeSampleBuffers:forItemTime:]):
(-[WebCoreAVFMovieObserver outputSequenceWasFlushed:]):
(-[WebCoreAVFLoaderDelegate resourceLoader:shouldWaitForLoadingOfRequestedResource:]):
(-[WebCoreAVFLoaderDelegate resourceLoader:shouldWaitForResponseToAuthenticationChallenge:]):
(-[WebCoreAVFLoaderDelegate resourceLoader:didCancelLoadingRequest:]):
- 3:50 PM Changeset in webkit [162878] by
-
- 2 edits in trunk/Source/WebCore
Move Conditional=BLOB from URL interface to Blob-related methods, to prepare for adding URL API
https://bugs.webkit.org/show_bug.cgi?id=127719
Reviewed by Sam Weinig.
- html/DOMURL.idl:
- 3:48 PM Changeset in webkit [162877] by
-
- 12 edits1 move in trunk/Source/WebKit2
IDB: Rename "IDBTransactionIdentifier" to be more general purpose
https://bugs.webkit.org/show_bug.cgi?id=127717
Reviewed by Tim Horton.
Global rename of IDBTransactionIdentifier to IDBIdentifier.
- DatabaseProcess/IndexedDB/IDBIdentifier.h: Renamed from Source/WebKit2/DatabaseProcess/IndexedDB/IDBTransactionIdentifier.h.
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
- DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.cpp:
- DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.h:
- DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:
- Shared/WebCrossThreadCopier.cpp:
- Shared/WebCrossThreadCopier.h:
- WebKit2.xcodeproj/project.pbxproj:
- 3:39 PM Changeset in webkit [162876] by
-
- 5 edits in trunk/Source/WebKit2
Move underlying C++ objects to class extensions
https://bugs.webkit.org/show_bug.cgi?id=127716
Reviewed by Tim Horton.
This allows us to get at the internals without calling any Obj-C methods.
- UIProcess/API/Cocoa/WKProcessClass.mm:
- UIProcess/API/Cocoa/WKProcessClassInternal.h:
- UIProcess/API/ios/WKContentView.mm:
- UIProcess/API/ios/WKContentViewInternal.h:
- 3:29 PM Changeset in webkit [162875] by
-
- 6 edits2 deletes in trunk/Source/WebCore
Remove unused USE(OPENTYPE_SANITIZER) code.
<https://webkit.org/b/127710>
This code was only used by the Chromium port.
Reviewed by Darin Adler.
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj:
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::ensureCustomFontData):
- platform/graphics/WOFFFileFormat.cpp:
- platform/graphics/WOFFFileFormat.h:
- platform/graphics/opentype/OpenTypeSanitizer.cpp: Removed.
- platform/graphics/opentype/OpenTypeSanitizer.h: Removed.
- 3:25 PM Changeset in webkit [162874] by
-
- 9 edits in trunk/Source/WebInspectorUI
Web Inspector: Feature Check all Protocol Generated Interfaces to get JSContext Inspection working
https://bugs.webkit.org/show_bug.cgi?id=127712
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-27
Reviewed by Timothy Hatcher.
Feature check protocol generated interfaces (e.g. FooAgent and registerFooObserver).
Also drive by handle a possible exception if a SourceCode's URL is null, which is possible.
- UserInterface/ApplicationCacheManager.js:
(WebInspector.ApplicationCacheManager):
(WebInspector.ApplicationCacheManager.prototype.initialize):
- UserInterface/CSSCompletions.js:
(WebInspector.CSSCompletions.requestCSSNameCompletions):
- UserInterface/CSSStyleManager.js:
(WebInspector.CSSStyleManager):
(WebInspector.CSSStyleManager.prototype.canForcePseudoClasses):
- UserInterface/DebuggerManager.js:
- UserInterface/FrameResourceManager.js:
(WebInspector.FrameResourceManager):
(WebInspector.FrameResourceManager.prototype.initialize):
- UserInterface/Main.js:
(WebInspector.loaded):
- UserInterface/ProfileManager.js:
(WebInspector.ProfileManager):
- UserInterface/StorageManager.js:
(WebInspector.StorageManager):
Type check generated interfaces.
(WebInspector.DebuggerManager):
(WebInspector.DebuggerManager.prototype.debuggerDidPause):
Null check a SourceCode URL, which can be null for a Script with no URL.
- 3:22 PM Changeset in webkit [162873] by
-
- 2 edits in trunk/Source/WebKit2
Implement the _injectedBundleURL property
https://bugs.webkit.org/show_bug.cgi?id=127714
Reviewed by Tim Horton.
Properties declared in class categories need to be implemented. Do this
for the _injectedBundleURL property.
- UIProcess/API/Cocoa/WKProcessClassConfiguration.mm:
(-[WKProcessClassConfiguration _injectedBundleURL]):
(-[WKProcessClassConfiguration _setInjectedBundleURL:]):
- 3:15 PM Changeset in webkit [162872] by
-
- 2 edits in trunk/Source/WebCore
Stop the code generator from adding ENABLE() macros to Objective-C DOM headers
https://bugs.webkit.org/show_bug.cgi?id=127706
Reviewed by David Kilzer.
Instead of adding ENABLE() macros to generated Objective-C DOM
headers, which might become Public or Private headers, elide generated
code for disabled features.
- bindings/scripts/CodeGeneratorObjC.pm:
(GenerateInterface): Passed $defines to GenerateHeader.
(ConditionalIsEnabled): Checked if the given conditional is found in
$defines. Handled conditionals with '&' and '|'.
(GenerateHeader): Rather than calling GenerateConditionalString to
generate an "#if ENABLE(...)", called ConditionalIsEnabled() to see
whether we should generate code for the given constant, attribute, or
function.
- 3:03 PM Changeset in webkit [162871] by
-
- 5 edits in trunk
[CSS Shapes] Remove restriction of negative values for inset parameters
https://bugs.webkit.org/show_bug.cgi?id=127704
Reviewed by Darin Adler.
Source/WebCore:
The latest version of CSS Shapes (http://www.w3.org/TR/css-shapes/) specification
doesn't contain any restriction of using negative values for the inset sizing.
I removed the restriction from the code and added testing for them.
Existing tests have been extended with the new cases.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseBasicShapeInset):
LayoutTests:
- fast/shapes/parsing/parsing-shape-lengths-expected.txt:
- fast/shapes/parsing/parsing-shape-lengths.html:
- 2:47 PM Changeset in webkit [162870] by
-
- 3 edits in trunk/Source/WebCore
[iOS] preload=none prevents play()
https://bugs.webkit.org/show_bug.cgi?id=127702
Reviewed by Jer Noble.
No new tests, covered by existing tests.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::potentiallyPlaying): Cleanup logic to make it simpler to understand,
fix logic error introduced in r161973
(WebCore::HTMLMediaElement::updatePlayState): Conditionalize some iOS-only code on whether or not
we are using the plug-in proxy.
- 2:38 PM Changeset in webkit [162869] by
-
- 9 edits in trunk/Source
IDB: LevelDB backing store shouldn't know about IDBCursor or IDBCallbacks
https://bugs.webkit.org/show_bug.cgi?id=127708
Reviewed by Tim Horton.
Source/WebCore:
Move that knowledge to the IDBCursorBackendOperations inside the callback.
- Modules/indexeddb/IDBCursorBackendOperations.cpp:
(WebCore::CursorAdvanceOperation::perform):
(WebCore::CursorIterationOperation::perform):
- Modules/indexeddb/IDBCursorBackendOperations.h:
- Modules/indexeddb/IDBServerConnection.h:
- Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:
(WebCore::IDBServerConnectionLevelDB::cursorAdvance):
(WebCore::IDBServerConnectionLevelDB::cursorIterate):
- Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:
Source/WebKit2:
Update to new callback signatures:
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
(WebKit::WebIDBServerConnection::cursorAdvance):
(WebKit::WebIDBServerConnection::cursorIterate):
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
- 2:37 PM Changeset in webkit [162868] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
FTL ArithMod case needs to be factored for hackability and correctness rather than just minimizing the amount of code
https://bugs.webkit.org/show_bug.cgi?id=127709
Rubber stamped by Mark Hahnenberg.
Roll out part of r156784. 60% progression on Kraken/audio-oscillator.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileArithDiv):
(JSC::FTL::LowerDFGToLLVM::compileArithMod):
- 2:20 PM Changeset in webkit [162867] by
-
- 8 edits2 adds1 delete in branches/jsCStack
Added missing files to the branch.
- 1:52 PM Changeset in webkit [162866] by
-
- 3 edits6 adds in branches/jsCStack/Source/JavaScriptCore
FTL should support NewArrayWithSize
https://bugs.webkit.org/show_bug.cgi?id=127698
Reviewed by Mark Hahnenberg.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileNewArrayWithSize):
- tests/stress/new-array-storage-array-with-size.js: Added.
(foo):
(test):
- tests/stress/new-array-with-size-with-bad-time.js: Added.
(foo):
- tests/stress/new-contiguous-array-with-size.js: Added.
(foo):
(test):
- tests/stress/new-double-array-with-size.js: Added.
(foo):
(test):
- tests/stress/new-int32-array-with-size.js: Added.
(foo):
(test):
- tests/stress/new-undecided-array-with-size.js: Added.
(foo):
(test):
- 1:45 PM Changeset in webkit [162865] by
-
- 3 edits in trunk/Source/WebKit2
Tweak the WKWebView and WKWebViewConfiguration headers
https://bugs.webkit.org/show_bug.cgi?id=127705
Reviewed by Dan Bernstein.
Add WK_API_CLASS to WKWebView and make WKWebView.h and WKWebViewConfiguration.h public.
- UIProcess/API/Cocoa/WKWebView.h:
- WebKit2.xcodeproj/project.pbxproj:
- 1:29 PM Changeset in webkit [162864] by
-
- 11 edits in trunk/Source
IDB: Remove unused concept of "cursor prefetch"
https://bugs.webkit.org/show_bug.cgi?id=127700
Reviewed by Tim Horton.
Source/WebCore:
- Modules/indexeddb/IDBCursorBackend.cpp:
- Modules/indexeddb/IDBCursorBackend.h:
- Modules/indexeddb/IDBCursorBackendOperations.cpp:
- Modules/indexeddb/IDBCursorBackendOperations.h:
- Modules/indexeddb/IDBServerConnection.h:
- Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:
Source/WebKit2:
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
- 1:24 PM Changeset in webkit [162863] by
-
- 3 edits3 adds3 deletes in branches/safari-537.75-branch/Source
Merge r162723.
2014-01-24 Brent Fulgham <Brent Fulgham>
[Win] Convert some NMake files to MSBuild project files
https://bugs.webkit.org/show_bug.cgi?id=127579
Reviewed by Tim Horton.
Source/JavaScriptCore:
- JavaScriptCore.vcxproj/JavaScriptCore.make: Removed.
- JavaScriptCore.vcxproj/JavaScriptCore.proj: Added.
Source/WebCore:
- WebCore.vcxproj/WebCore.make: Removed.
- WebCore.vcxproj/WebCore.proj: Added.
Source/WTF:
- WTF.vcxproj/WTF.make: Removed.
- WTF.vcxproj/WTF.proj: Added.
- 1:16 PM Changeset in webkit [162862] by
-
- 2 edits in trunk/Source/WTF
[WK2] callOnMainThread() from main thread sometimes results in ASSERTs.
https://bugs.webkit.org/show_bug.cgi?id=127370
Reviewed by Alexey Proskuryakov.
When WEB_THREAD is enabled, and callOnMainThread() is called from the main
thread, if the web thread is locked, a timer is set and the passed-in function
is called on the next run-loop. However, by that time the web thread may have
been unlocked, and isMainThread() will no longer return true, resulting in
an assert.
Instead, scheduleDispatchFunctionsOnMainThread() should check isWebThread(),
which is equivalent to isMainThread() when the WEB_THREAD is disabled, but
will do the correct thing when WEB_THREAD is enabled.
- wtf/mac/MainThreadMac.mm:
(WTF::scheduleDispatchFunctionsOnMainThread):
- 1:03 PM Changeset in webkit [162861] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: [X86-32] testapi crashes in gatherConservativeRoots()
https://bugs.webkit.org/show_bug.cgi?id=127699
Reviewed by Mark Hahnenberg.
sanitizeStackForVMImpl was using "t4" (edi) which is a callee save register, which
trashed its prior contents. Change to use t2 (ecx) on X86 which is a scratch register.
- llint/LowLevelInterpreter.asm:
- 1:00 PM Changeset in webkit [162860] by
-
- 2 edits in branches/safari-537.75-branch/Source/WebCore
Unreviewed build fix after r162631.
- WebCore.vcxproj/WebCore.submit.sln: Do not build QTMovieWin for 64-bit architecture.
- 12:53 PM Changeset in webkit [162859] by
-
- 2 edits in trunk/Source/WebKit2
Fix the build on case-sensitive filesystems
- WebProcess/WebPage/ViewGestureGeometryCollector.h:
- 12:52 PM Changeset in webkit [162858] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r162837): fast/writing-mode/ruby-text-logical-left.html fails on WK1
- TestExpectations: skip for now
- 12:51 PM Changeset in webkit [162857] by
-
- 2 edits in trunk/Source/WTF
Build fix.
- wtf/ThreadSafeRefCounted.h: Added a necessary #include.
- 12:48 PM UsingGitHub edited by
- typo you/your (diff)
- 12:34 PM Changeset in webkit [162856] by
-
- 9 edits in trunk/Source
IDB: Refactor out the last of the operation callbacks that are called by the LevelDB backing store
https://bugs.webkit.org/show_bug.cgi?id=127592
Reviewed by Tim Horton.
Source/WebCore:
For each of the 3 remaining operations where the backing store calls callbacks directly,
factor out the callbacks to the operation itself.
- Modules/indexeddb/IDBTransactionBackendOperations.cpp:
(WebCore::OpenCursorOperation::perform):
(WebCore::CountOperation::perform):
(WebCore::DeleteRangeOperation::perform):
- Modules/indexeddb/IDBTransactionBackendOperations.h:
- Modules/indexeddb/IDBServerConnection.h:
- Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:
(WebCore::IDBServerConnectionLevelDB::openCursor):
(WebCore::IDBServerConnectionLevelDB::count):
(WebCore::IDBServerConnectionLevelDB::deleteRange):
- Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:
Source/WebKit2:
Update the WebIDBServerConnection to the new callback signatures:
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
(WebKit::WebIDBServerConnection::openCursor):
(WebKit::WebIDBServerConnection::count):
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
- 12:31 PM Changeset in webkit [162855] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r162755.
http://trac.webkit.org/changeset/162755
https://bugs.webkit.org/show_bug.cgi?id=127696
not quite right, breaks subframe scrolling in some cases
(Requested by thorton on #webkit).
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::ScrollingTree):
(WebCore::ScrollingTree::shouldHandleWheelEventSynchronously):
(WebCore::ScrollingTree::removeDestroyedNodes):
- page/scrolling/ScrollingTree.h:
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::handleWheelEvent):
- 12:28 PM Changeset in webkit [162854] by
-
- 776 edits162 adds1 delete in branches/jsCStack
Source/JavaScriptCore: Merge branch up to ToT r162844.
- 12:21 PM Changeset in webkit [162853] by
-
- 23 edits in trunk/Source/WebKit2
WebKit2 View Gestures: Fluid back-forward swipe
https://bugs.webkit.org/show_bug.cgi?id=127363
Reviewed by Anders Carlsson.
Add support for a "back-forward swipe", which allows fluid swiping between
items in the back-forward list. Currently disabled by default.
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetViewGestureDebuggingEnabled):
(WKPreferencesGetViewGestureDebuggingEnabled):
- UIProcess/API/C/WKPreferencesPrivate.h:
Add a ViewGestureDebuggingEnabled preference, which currently causes snapshots to be blurred.
Additional view gesture debugging features could come in the future.
- UIProcess/API/Cocoa/WKViewPrivate.h:
- UIProcess/API/mac/WKView.mm:
(-[WKView _ensureGestureController]):
(-[WKView scrollWheel:]):
If back-forward navigation gestures are enabled, intercept scrollWheel events
on the WKView and let the ViewGestureController take the first crack at them.
(-[WKView setAllowsBackForwardNavigationGestures:]):
(-[WKView allowsBackForwardNavigationGestures]):
- UIProcess/API/mac/WKViewInternal.h:
Add allowsBackForwardNavigationGesture property, which enables the gesture.
- UIProcess/mac/ViewGestureController.h:
Add swipe-related methods, which will be described below.
Add an enum for the swipe transition style. Currently only Overlap is accessible,
but in the future one could see having API to choose the style.
'Overlap' has the outgoing page swipe out to the right (when swiping right)
or the incoming page swipe in from the right (when swiping left).
'Push' has the pages push each other along in sync, as if all the pages in the
back-forward list were oriented from left to right.
- UIProcess/mac/ViewGestureController.messages.in:
- UIProcess/mac/ViewGestureController.mm: Renamed from Source/WebKit2/UIProcess/mac/ViewGestureController.cpp.
Use some CAFilter SPI to blur the snapshot if ViewGestureDebuggingEnabled is on.
(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::~ViewGestureController):
(WebKit::ViewGestureController::endMagnificationGesture):
Move m_activeGestureType clearing to each end* function instead of one global place,
so that each gesture can handle when it ends separately.
(WebKit::ViewGestureController::handleScrollWheelEvent):
If we receive a scroll wheel event which is appropriate for starting a
fluid swipe, in a direction where the main frame is pinned to the appropriate
edge of the view, start tracking a swipe.
This should eventually have some hysterisis to avoid stealing scrolls that
venture into the wrong direction, but for now it starts tracking immediately.
Forward events from the tracking loop to {begin, handle, end}SwipeGesture.
(WebKit::ViewGestureController::beginSwipeGesture):
Create a layer with the destination page's snapshot, and set it up.
(WebKit::ViewGestureController::handleSwipeGesture):
Appropriately adjust the position of the root layer and snapshot layer,
given the transition style and swipe direction.
(WebKit::ViewGestureController::endSwipeGesture):
When the gesture ends, do the navigation, and tell the WebProcess to
inform us when the render tree hits half the size it was when the
snapshot was taken (when that happens, we will remove the snapshot
and the gesture will be truly complete). Also, start a watchdog timer
in case the render tree never hits that size, after which we will
also remove the snapshot.
(WebKit::ViewGestureController::didHitRenderTreeSizeThreshold):
(WebKit::ViewGestureController::swipeSnapshotWatchdogTimerFired):
(WebKit::ViewGestureController::removeSwipeSnapshot):
Tear down the swipe snapshot layer, and mark our current gesture as complete.
(WebKit::ViewGestureController::endActiveGesture):
Simplify endActiveGesture; it only has work to do for a pinch-zoom gesture,
as those are the only gestures where the user is directly in control of when they end.
- WebProcess/WebPage/ViewGestureGeometryCollector.cpp:
(WebKit::ViewGestureGeometryCollector::ViewGestureGeometryCollector):
(WebKit::ViewGestureGeometryCollector::mainFrameDidLayout):
(WebKit::ViewGestureGeometryCollector::renderTreeSizeNotificationTimerFired):
- WebProcess/WebPage/ViewGestureGeometryCollector.h:
(WebKit::ViewGestureGeometryCollector::setRenderTreeSizeNotificationThreshold):
- WebProcess/WebPage/ViewGestureGeometryCollector.messages.in:
ViewGestureController pushes a render-tree size threshold to the WebProcess;
ViewGestureGeometryCollector (whose name is now more unfortunate than before)
monitors render-tree size changes and informs ViewGestureController when
it reaches that threshold via the 'DidHitRenderTreeSizeThreshold' message.
- UIProcess/API/Cocoa/WKViewPrivate.h:
- UIProcess/API/ios/PageClientImplIOS.h:
- UIProcess/API/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::acceleratedCompositingRootLayer):
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::acceleratedCompositingRootLayer):
- UIProcess/API/mac/WKView.mm:
(-[WKView _acceleratedCompositingModeRootLayer]):
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.h:
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::acceleratedCompositingRootLayer):
Add a getter for the accelerated compositing root layer.
- UIProcess/mac/ViewSnapshotStore.mm:
(WebKit::ViewSnapshotStore::snapshotAndRenderTreeSize):
Don't extract the CGImageRef from a RetainPtr just to put it back in one.
- 12:04 PM Changeset in webkit [162852] by
-
- 7 edits in branches/safari-537.75-branch/Source/JavaScriptCore
2013-08-23 Alex Christensen <alex.christensen@flexsim.com>
Re-separating Win32 and Win64 builds.
https://bugs.webkit.org/show_bug.cgi?id=120178
Reviewed by Brent Fulgham.
- JavaScriptCore.vcxproj/JavaScriptCoreGenerated.make:
- JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.make:
- JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.make:
Pass PlatformArchitecture as a command line parameter to bash scripts.
- JavaScriptCore.vcxproj/copy-files.cmd: Use correct architecture
for build conditions.
- JavaScriptCore.vcxproj/jsc/jscCommon.props: Ditto
- JavaScriptCore.vcxproj/testRegExp/testRegExpCommon.props: Ditto
- 11:54 AM Changeset in webkit [162851] by
-
- 4 edits in branches/safari-537.75-branch/Source/WTF
Merge r162850
2014-01-27 Brent Fulgham <Brent Fulgham>
[Win] Unreviewed build correction.
- WTF.vcxproj/WTFGeneratedCommon.props: Export PLATFORMARCHITECTURE macro for use in Makefiles and shell scripts.
- WTF.vcxproj/build-generated-files.sh: Output header search path to identify when the build is confused about build architecture.
- 11:49 AM Changeset in webkit [162850] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r162846.
http://trac.webkit.org/changeset/162846
https://bugs.webkit.org/show_bug.cgi?id=127695
"Broke the WebKit Bot Watcher's Dashboard; will fix offline"
(Requested by dydz on #webkit).
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype.update.):
- 11:42 AM Changeset in webkit [162849] by
-
- 4 edits1 add in branches/jsCStack/Source/JavaScriptCore
FTL should do polyvariant PutById inlining
https://bugs.webkit.org/show_bug.cgi?id=127692
Reviewed by Mark Hahnenberg.
Expanded the existign GetById polyvariance support to include PutByIds as well.
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::hasExitSite):
(JSC::PutByIdStatus::computeFor):
(JSC::PutByIdStatus::computeForStubInfo):
- bytecode/PutByIdStatus.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- tests/stress/simple-polyvariant-put-by-id-inlining-example.js: Added.
(foo):
(fuzz):
(bar):
- 11:15 AM Changeset in webkit [162848] by
-
- 6 edits in trunk
[CSS Shapes] inset() function with multiple spaces on element style
https://bugs.webkit.org/show_bug.cgi?id=127617
Reviewed by Dirk Schulze.
Source/WebCore:
When only a subset of parameters were defined for an inset shape, the built
inset string contained some extra spaces. This patch fixes the behavior and
adds tests for the case. I also removed the string allocation optimization from
buildInsetString, since it's not worthwhile to always allocate as many memory
as needed for a fully defined inset.
I added the new test cases to the shapes parser code test.
- css/CSSBasicShapes.cpp:
(WebCore::buildInsetString):
LayoutTests:
- fast/shapes/parsing/parsing-shape-inside-expected.txt:
- fast/shapes/parsing/parsing-shape-outside-expected.txt:
- fast/shapes/parsing/parsing-test-utils.js:
- 11:08 AM Changeset in webkit [162847] by
-
- 3 edits in trunk/Tools
Add support for displaying results from multiple Buildbots on WebKit Bot Watcher's Dashboard
https://bugs.webkit.org/show_bug.cgi?id=127564
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
- 11:06 AM Changeset in webkit [162846] by
-
- 2 edits in trunk/Tools
Teach Buildbot dashboard to parse alternative revision format
https://bugs.webkit.org/show_bug.cgi?id=127561
Reviewed by Alexey Proskuryakov.
Add support for extracting the OpenSource and Internal revision numbers when Buildbot
returns a dictionary for the value of property got_revision.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(parseRevisionProperty): Added; parses Buildbot revision property, which can either be a
string or a dictionary.
(BuildbotIteration.prototype.update.): Modified to call parseRevisionProperty() to determine
the OpenSource and Internal revision numbers.
- 10:53 AM Changeset in webkit [162845] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove unused CodeBlock::createActivation().
<https://webkit.org/b/127686>
Reviewed by Filip Pizlo.
- bytecode/CodeBlock.cpp:
- bytecode/CodeBlock.h:
- 9:48 AM Changeset in webkit [162844] by
-
- 2 edits in trunk/Source/WebCore
- WebCore.exp.in: Add export needed for iOS.
- 9:12 AM Changeset in webkit [162843] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r133214): Don't invalidate style when adding classes that don't match rules
https://bugs.webkit.org/show_bug.cgi?id=126177
Reviewed by Anders Carlsson.
Spotted by Elliott Sprehn in Chromium.
- dom/Element.cpp:
(WebCore::checkSelectorForClassChange):
Remove unnecessary templating.
(WebCore::Element::classAttributeChanged):
Fix logic error with 'continue'.
- 8:57 AM Changeset in webkit [162842] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Lockup when playing Icecast radio
https://bugs.webkit.org/show_bug.cgi?id=127452
Reviewed by Philippe Normand.
No new tests. This bug can only be demonstrated with an Icecast stream, and it's
not clear how to do that in our testing framework.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient::handleResponseReceived): Wait until we unlock to send notifications.
- 8:49 AM Changeset in webkit [162841] by
-
- 2 edits in trunk/LayoutTests
Typo fix after r162838.
- platform/wk2/TestExpectations:
- 8:31 AM Changeset in webkit [162840] by
-
- 2 edits in trunk/Source/WebCore
Build fix after r162838.
- page/FrameView.cpp:
Remove an unused constant.
- 8:27 AM Changeset in webkit [162839] by
-
- 9 edits in trunk/Source/WebCore
Remove repaint throttling
https://bugs.webkit.org/show_bug.cgi?id=127681
Patch by Antti Koivisto <Antti Koivisto> on 2014-01-27
Reviewed by Sam Weinig.
Nowadays we throttle layer flushes. This code is unnecessary.
- WebCore.exp.in:
- dom/Document.cpp:
(WebCore::Document::recalcStyle):
- dom/Element.cpp:
(WebCore::Element::classAttributeChanged):
- editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::insertDictatedText):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkCompleted):
- page/EventHandler.cpp:
(WebCore::EventHandler::dispatchDragEvent):
(WebCore::EventHandler::dispatchMouseEvent):
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::handleTextInputEvent):
- page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::flushCompositingStateForThisFrame):
(WebCore::FrameView::layout):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::disableLayerFlushThrottlingTemporarilyForInteraction):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
- page/FrameView.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::setSelection):
- 8:18 AM Changeset in webkit [162838] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, unskip now passing tests.
- platform/wk2/TestExpectations:
- 7:11 AM Changeset in webkit [162837] by
-
- 12 edits in trunk/Source
Remove repaint throttling
https://bugs.webkit.org/show_bug.cgi?id=127681
Reviewed by Sam Weinig.
Nowadays we throttle layer flushes. This code is unnecessary.
- WebCore.exp.in:
- dom/Document.cpp:
(WebCore::Document::recalcStyle):
- dom/Element.cpp:
(WebCore::Element::classAttributeChanged):
- editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::insertDictatedText):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkCompleted):
- page/EventHandler.cpp:
(WebCore::EventHandler::dispatchDragEvent):
(WebCore::EventHandler::dispatchMouseEvent):
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::handleTextInputEvent):
- page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::flushCompositingStateForThisFrame):
(WebCore::FrameView::layout):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::disableLayerFlushThrottlingTemporarilyForInteraction):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
- page/FrameView.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::setSelection):
- 7:05 AM Changeset in webkit [162836] by
-
- 8 edits in trunk/Source/WebCore
Merge Chromium TextTrack cleanups
https://bugs.webkit.org/show_bug.cgi?id=127483
Reviewed by Darin Adler.
Merge some TextTrack cleanups:
https://chromium.googlesource.com/chromium/blink/+/b571b9fbc6e62e05aa77a402cf8f447e681b8ee3
https://chromium.googlesource.com/chromium/blink/+/6b1940151258150ea01bcf21ebfd958e2af247f4
https://chromium.googlesource.com/chromium/blink/+/397c2a2d9416f5c0d79bca22d6979f174eefcce2
https://chromium.googlesource.com/chromium/blink/+/f42ad93e25c6310b2b0327ab7ce5d82d3c4a6c1b
https://chromium.googlesource.com/chromium/blink/+/d55b52b53b7da05bba5fe378a4278250b9347430
https://chromium.googlesource.com/chromium/blink/+/cac766ecaaac477a08879f0b3157d0327cc75d96
https://chromium.googlesource.com/chromium/blink/+/6197ce278696cdd52fc2ad81893f369492468ca0
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::loadTimerFired): Remove the LoadableTextTrack* parameter, it isn't used.
(WebCore::HTMLTrackElement::didCompleteLoad): Ditto.
- html/HTMLTrackElement.h: didCompleteLoad doesn't need to be virtual.
- html/track/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::loadTimerFired): Pass a reference, not a pointer.
(WebCore::LoadableTextTrack::cueLoadingStarted): Removed, it wasn't used.
(WebCore::LoadableTextTrack::cueLoadingCompleted): Pass a reference, not a pointer.
- html/track/LoadableTextTrack.h: Delete LoadableTextTrackClient, it is no longer used.
- loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::TextTrackLoader): Take a TextTrackLoaderClient reference.
(WebCore::TextTrackLoader::~TextTrackLoader): Rename m_cachedCueData m_resource.
(WebCore::TextTrackLoader::cueLoadTimerFired): m_client is a reference.
(WebCore::TextTrackLoader::cancelLoad): m_cachedCueData -> m_resource.
(WebCore::TextTrackLoader::processNewCueData): Ditto.
(WebCore::TextTrackLoader::deprecatedDidReceiveCachedResource): Ditto.
(WebCore::TextTrackLoader::notifyFinished): Ditto.
(WebCore::TextTrackLoader::load): shouldLoadCues was removed from the client interface because
the only implementation always returned true.
(WebCore::TextTrackLoader::newRegionsParsed): m_client is a reference
- loader/TextTrackLoader.h:
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest): Remove an outdated comment.
- 5:14 AM Changeset in webkit [162835] by
-
- 14 edits in trunk
[GTK] Implement custom URI schemes with CustomProtocols
https://bugs.webkit.org/show_bug.cgi?id=127091
Reviewed by Gustavo Noronha Silva.
Source/WebKit2:
The old classes are no longer built for GTK+ and should be removed once
other ports using soup backend switch to custom protocols implementation.
- GNUmakefile.am: Remove include path.
- GNUmakefile.list.am: Remove files from compilation.
- PlatformGTK.cmake: Ditto.
- UIProcess/API/gtk/WebKitPrivate.h:
- UIProcess/API/gtk/WebKitRequestManagerClient.cpp:
(startLoading):
(stopLoading):
(attachRequestManagerClientToContext):
- UIProcess/API/gtk/WebKitURISchemeRequest.cpp:
(webkitURISchemeRequestCreate):
(webkit_uri_scheme_request_get_web_view):
(webkitURISchemeRequestReadCallback):
(webkit_uri_scheme_request_finish):
(webkit_uri_scheme_request_finish_error):
- UIProcess/API/gtk/WebKitURISchemeRequestPrivate.h:
- UIProcess/API/gtk/WebKitWebContext.cpp:
(createDefaultWebContext):
(webkit_web_context_register_uri_scheme):
(webkitWebContextGetRequestManager):
(webkitWebContextStartLoadingCustomProtocol):
(webkitWebContextStopLoadingCustomProtocol):
(webkitWebContextDidFinishLoadingCustomProtocol):
- UIProcess/API/gtk/WebKitWebContextPrivate.h:
- UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
- WebKit2Prefix.h: Enable CustomProtocols unconditionally for the
GTK+ port.
Tools:
Temporarily disable the WebKitWebView check until we figure out
how to implement it with CustomProtocols.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
- 4:40 AM Changeset in webkit [162834] by
-
- 2 edits in trunk/Source/WebCore
AX: Disable accessibility after every test run
https://bugs.webkit.org/show_bug.cgi?id=127439
Patch by Chris Fleizach <Chris Fleizach> on 2014-01-27
Reviewed by Csaba Osztrogonác.
Speculative fix for EFL build. Don't process these notifications unless accessibility is enabled.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::prepareForLoadStart):
- 3:13 AM Changeset in webkit [162833] by
-
- 2 edits in trunk/Source/WebCore
Buildfix for !ENABLE(COMPARE_AND_SWAP) platforms after r162774
https://bugs.webkit.org/show_bug.cgi?id=127678
Reviewed by Zoltan Herczeg.
- platform/text/TextBreakIterator.cpp:
(WebCore::compareAndSwapNonSharedCharacterBreakIterator):
Use std::mutex instead of Mutex and std::lock_guard instead of MutexLocker.
- 2:46 AM Changeset in webkit [162832] by
-
- 5 edits1 delete in trunk/LayoutTests
[Mac] fast/profiler/stop-profiling-after-setTimeout.html and fast/profiler/dead-time.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=84102
Reviewed by Darin Adler.
- fast/profiler/dead-time-expected.txt: Updated.
- fast/profiler/stop-profiling-after-setTimeout-expected.txt: Updated.
- platform/efl/TestExpectations: Unskip tests.
- platform/gtk/fast/profiler/dead-time-expected.txt: Removed.
- platform/gtk/fast/profiler/stop-profiling-after-setTimeout-expected.txt: Removed.
- platform/mac/TestExpectations: Unskip tests.
- 1:09 AM Changeset in webkit [162831] by
-
- 2 edits in trunk/Source/WebKit/mac
Another iOS build fix.
- Misc/WebElementDictionary.mm:
(-[WebElementDictionary _image]):
We were apparently depending on Image::getNSImage() being defined
(yet always returning nullptr) on iOS.
- 12:27 AM Changeset in webkit [162830] by
-
- 2 edits in trunk/Source/WebKit2
[SOUP] WebProcess sometimes crashes when a download is cancelled
https://bugs.webkit.org/show_bug.cgi?id=127650
Reviewed by Martin Robinson.
The problem is that when the download is cancelled, the download
manager removes the download from the map and it's deleted. The
Download destructor calls platformInvalidate() that cancels the
resource handle if there's still one. We set to nullptr the
ResourceHandle when the download is cancelled to avoid cancelling
it twice, but it's done after calling Download::didCancel(). It
should be done before, because at that moment, when the download
is deleted, the resource handle pointer is still valid.
- Shared/Downloads/soup/DownloadSoup.cpp:
(WebKit::Download::cancel):
- 12:18 AM Changeset in webkit [162829] by
-
- 2 edits in trunk/Source/WebKit/gtk
Unreviewed. Fix GTK+ build after r162808.
- webkit/webkitwebhistoryitem.cpp:
(webkit_web_history_item_new_with_data):
(webkit_web_history_item_get_last_visited_time):
Jan 26, 2014:
- 11:33 PM Changeset in webkit [162828] by
-
- 2 edits in trunk/Source/WebCore
Fix the iOS build (failed to correctly revert some broken changes in the last patch).
- platform/graphics/cg/BitmapImageCG.cpp:
- 11:16 PM Changeset in webkit [162827] by
-
- 24 edits in trunk/Source/WebCore
Start cleaning up iOS upstreaming #ifs in platform/graphics
https://bugs.webkit.org/show_bug.cgi?id=127641
Reviewed by Sam Weinig.
- platform/graphics/BitmapImage.h:
- platform/graphics/mac/ColorMac.h:
Use USE(APPKIT) instead of PLATFORM(MAC) && !PLATFORM(IOS) for NSImage/getNSImage().
- platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:
(WebCore::AVTrackPrivateAVFObjCImpl::label):
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::label):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
Remove some code that was only used on OS X on Lion or below.
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::platformInit):
ToT WebKit doesn't build on Lion or earlier anymore, so this code can always run.
- platform/graphics/cg/FloatPointCG.cpp:
- platform/graphics/cg/FloatRectCG.cpp:
- platform/graphics/cg/FloatSizeCG.cpp:
- platform/graphics/cg/GradientCG.cpp:
- platform/graphics/cg/ImageBufferCG.cpp:
- platform/graphics/cg/ImageCG.cpp:
- platform/graphics/cg/IntPointCG.cpp:
- platform/graphics/cg/IntRectCG.cpp:
- platform/graphics/cg/PathCG.cpp:
- platform/graphics/cg/PatternCG.cpp:
- platform/graphics/mac/FontCustomPlatformData.cpp:
Use CoreGraphics/CoreGraphics.h instead of ApplicationServices/ApplicationServices.h
even on Mac, so we can share the include.
- platform/graphics/cg/IntSizeCG.cpp:
Remove a random comment of a style we don't tend to use in WebKit,
and from a file not large enough to need it.
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::setFont):
Remove some more always-true #ifs.
- platform/graphics/mac/WebLayer.mm:
Move a #if'd include out to its own block as per the style guide.
- 10:23 PM Changeset in webkit [162826] by
-
- 2 edits in trunk/Tools
REGRESSION(r127412): http/tests/misc/link-rel-icon-beforeload.html is broken.
- DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setIconDatabaseEnabled):
Fixed an incorrect ifdef.
- 9:45 PM Changeset in webkit [162825] by
-
- 10 edits2 adds in trunk/Source/JavaScriptCore
JSC: Pack unlinked instructions harder.
<https://webkit.org/b/127660>
Store UnlinkedCodeBlock's instructions in a variable-length stream
to reduce memory usage. Compression rate ends up around 60-61%.
The format is very simple. Every instruction starts with a 1 byte
opcode. It's followed by an opcode-dependent number of argument
values, each encoded separately for maximum packing. There are
7 packed value formats:
5-bit positive integer
5-bit negative integer
13-bit positive integer
13-bit positive integer
5-bit constant register index
13-bit constant register index
32-bit value (fallback)
27.5 MB progression on Membuster3. (~2% of total memory.)
Reviewed by Filip Pizlo.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/UnlinkedInstructionStream.h: Added.
(JSC::UnlinkedInstructionStream::count):
(JSC::UnlinkedInstructionStream::Reader::atEnd):
- bytecode/UnlinkedInstructionStream.cpp: Added.
(JSC::UnlinkedInstructionStream::Reader::Reader):
(JSC::UnlinkedInstructionStream::Reader::read8):
(JSC::UnlinkedInstructionStream::Reader::read32):
(JSC::UnlinkedInstructionStream::Reader::next):
(JSC::append8):
(JSC::append32):
(JSC::UnlinkedInstructionStream::UnlinkedInstructionStream):
(JSC::UnlinkedInstructionStream::unpackForDebugging):
- bytecompiler/BytecodeGenerator.cpp:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::lineNumberForBytecodeOffset):
(JSC::dumpLineColumnEntry):
(JSC::UnlinkedCodeBlock::expressionRangeForBytecodeOffset):
(JSC::UnlinkedCodeBlock::setInstructions):
(JSC::UnlinkedCodeBlock::instructions):
- bytecode/UnlinkedCodeBlock.h:
(JSC::BytecodeGenerator::generate):
- 9:44 PM Changeset in webkit [162824] by
-
- 2 edits in trunk/Source/WebKit/mac
Remove duplicate settings for ENABLE(DISK_IMAGE_CACHE)
<http://webkit.org/b/127669>
Reviewed by Joseph Pecoraro.
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Remove duplicate code.
- 9:21 PM Changeset in webkit [162823] by
-
- 2 edits in trunk/Tools
[GTK] DumpRenderTree prints out suggesting to set WEBKIT_TOP_LEVEL when fonts are missing but doesn't use it.
https://bugs.webkit.org/show_bug.cgi?id=110602
Reviewed by Philippe Normand.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(getTopLevelPath): Use WEBKIT_TOP_LEVEL environment variable if it exists.
(initializeFonts): Fix printing of expected font path (fontPath is guaranteed to be null here).
- 7:57 PM Changeset in webkit [162822] by
-
- 4 edits in trunk/Source/WebCore
[New Multicolumn] Change the axis property to be a boolean like other isInline checks
https://bugs.webkit.org/show_bug.cgi?id=127661
Reviewed by Simon Fraser.
- rendering/ColumnInfo.h:
(WebCore::ColumnInfo::ColumnInfo):
(WebCore::ColumnInfo::progressionIsInline):
(WebCore::ColumnInfo::setProgressionIsInline):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::initialBlockOffsetForPainting):
(WebCore::RenderBlock::blockDeltaForPaintingNextColumn):
(WebCore::RenderBlock::setComputedColumnCountAndWidth):
(WebCore::RenderBlock::updateColumnInfoFromStyle):
(WebCore::RenderBlock::columnRectAt):
(WebCore::RenderBlock::adjustPointToColumnContents):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::adjustForColumns):
- rendering/RenderMultiColumnFlowThread.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::columnNumberForOffset):
- 6:22 PM Changeset in webkit [162821] by
-
- 11 edits1 delete in trunk/Source/WebCore
Make DOMStringMap a typedef of DatasetDOMStringMap
https://bugs.webkit.org/show_bug.cgi?id=127658
Reviewed by Sam Weinig.
The only concrete implementation of DOMStringMap is DatasetDOMStringMap.
The abstract interface for a single definition is adding complexity for no gain.
This patch removes DOMStringMap and simply keeps the name through a typedef.
I used a typedef instead of just renaming DatasetDOMStringMap because I think
having both name has value. DatasetDOMStringMap is a better description of what
the implementation does. DOMStringMap is the public name and the classname is
the same as the JavaScript type by convention.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- dom/DOMAllInOne.cpp:
- dom/DOMStringMap.cpp: Removed.
- dom/DOMStringMap.h:
- dom/DatasetDOMStringMap.h:
- dom/Element.cpp:
(WebCore::Element::dataset):
- dom/Element.h:
- 5:34 PM Changeset in webkit [162820] by
-
- 5 edits in trunk/Source/WebCore
Part 2: Assertion failure in WebCore::PseudoElement::didRecalcStyle()
<https://bugs.webkit.org/show_bug.cgi?id=126761>
<rdar://problem/15793540>
Reviewed by Simon Fraser.
- bindings/objc/DOM.mm:
(-[DOMElement image]):
(-[DOMElement _imageTIFFRepresentation]):
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::writeImage):
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeImage):
(WebCore::getCachedImage):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::image):
- More places where toRenderImage() should be used instead of toImage().
- Fixed last two places where static_cast<WebCore::RenderImage*> was being used instead of toRenderImage().
- 5:28 PM Changeset in webkit [162819] by
-
- 71 edits4 deletes in trunk/LayoutTests
Unreviewed EFL gardening after r162742, r162791 and r162803.
- platform/efl-wk1/fast/forms/basic-inputs-expected.png: Removed.
- platform/efl-wk1/fast/forms/indeterminate-expected.png: Removed.
- platform/efl-wk2/fast/forms/basic-inputs-expected.png: Removed.
- platform/efl-wk2/fast/forms/indeterminate-expected.png: Removed.
- platform/efl/compositing/overflow/theme-affects-visual-overflow-expected.png:
- platform/efl/compositing/overflow/theme-affects-visual-overflow-expected.txt:
- platform/efl/css1/box_properties/acid_test-expected.png:
- platform/efl/css1/box_properties/acid_test-expected.txt:
- platform/efl/css2.1/t09-c5526c-display-00-e-expected.png:
- platform/efl/css2.1/t09-c5526c-display-00-e-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-25-expected.png:
- platform/efl/css3/selectors3/html/css3-modsel-25-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-70-expected.png:
- platform/efl/css3/selectors3/html/css3-modsel-70-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-25-expected.png:
- platform/efl/css3/selectors3/xhtml/css3-modsel-25-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-70-expected.png:
- platform/efl/css3/selectors3/xhtml/css3-modsel-70-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-25-expected.png:
- platform/efl/css3/selectors3/xml/css3-modsel-25-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-70-expected.png:
- platform/efl/css3/selectors3/xml/css3-modsel-70-expected.txt:
- platform/efl/fast/block/basic/011-expected.png:
- platform/efl/fast/block/basic/011-expected.txt:
- platform/efl/fast/block/margin-collapse/103-expected.png:
- platform/efl/fast/block/margin-collapse/103-expected.txt:
- platform/efl/fast/css/non-standard-checkbox-size-expected.png:
- platform/efl/fast/css/non-standard-checkbox-size-expected.txt:
- platform/efl/fast/forms/001-expected.png:
- platform/efl/fast/forms/001-expected.txt:
- platform/efl/fast/forms/basic-inputs-expected.txt:
- platform/efl/fast/forms/box-shadow-override-expected.png:
- platform/efl/fast/forms/box-shadow-override-expected.txt:
- platform/efl/fast/forms/file/file-input-disabled-expected.png:
- platform/efl/fast/forms/file/file-input-disabled-expected.txt:
- platform/efl/fast/forms/form-element-geometry-expected.png:
- platform/efl/fast/forms/form-element-geometry-expected.txt:
- platform/efl/fast/forms/formmove-expected.png:
- platform/efl/fast/forms/formmove-expected.txt:
- platform/efl/fast/forms/formmove2-expected.png:
- platform/efl/fast/forms/formmove2-expected.txt:
- platform/efl/fast/forms/indeterminate-expected.txt:
- platform/efl/fast/forms/input-appearance-height-expected.png:
- platform/efl/fast/forms/input-appearance-height-expected.txt:
- platform/efl/fast/forms/input-value-expected.png:
- platform/efl/fast/forms/input-value-expected.txt:
- platform/efl/fast/forms/search-vertical-alignment-expected.png:
- platform/efl/fast/forms/search-vertical-alignment-expected.txt:
- platform/efl/fast/forms/searchfield-heights-expected.png:
- platform/efl/fast/forms/searchfield-heights-expected.txt:
- platform/efl/fast/inline/positionedLifetime-expected.png:
- platform/efl/fast/inline/positionedLifetime-expected.txt:
- platform/efl/fast/parser/bad-xml-slash-expected.png:
- platform/efl/fast/parser/bad-xml-slash-expected.txt:
- platform/efl/fast/replaced/replaced-breaking-expected.png:
- platform/efl/fast/replaced/replaced-breaking-expected.txt:
- platform/efl/fast/replaced/width100percent-checkbox-expected.png:
- platform/efl/fast/replaced/width100percent-checkbox-expected.txt:
- platform/efl/fast/replaced/width100percent-radio-expected.png:
- platform/efl/fast/replaced/width100percent-radio-expected.txt:
- platform/efl/fast/text/textIteratorNilRenderer-expected.png:
- platform/efl/fast/text/textIteratorNilRenderer-expected.txt:
- platform/efl/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
- platform/efl/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
- platform/efl/http/tests/navigation/javascriptlink-frames-expected.png:
- platform/efl/http/tests/navigation/javascriptlink-frames-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1318-expected.png:
- platform/efl/tables/mozilla/bugs/bug1318-expected.txt:
- platform/efl/tables/mozilla/bugs/bug4527-expected.png:
- platform/efl/tables/mozilla/bugs/bug4527-expected.txt:
- platform/efl/tables/mozilla_expected_failures/core/captions1-expected.png:
- platform/efl/tables/mozilla_expected_failures/core/captions1-expected.txt:
- platform/efl/tables/mozilla_expected_failures/core/captions2-expected.png:
- platform/efl/tables/mozilla_expected_failures/core/captions2-expected.txt:
- 4:44 PM Changeset in webkit [162818] by
-
- 2 edits in trunk/Source/WebKit/efl
Unreviewed build fix on the EFL build since r162808
lastVisitedTime and visitCount are removed from WebCore::HistoryItem
- ewk/ewk_history.cpp:
(ewk_history_item_new):
(ewk_history_item_time_last_visited_get):
(ewk_history_item_visit_count):
- 4:01 PM Changeset in webkit [162817] by
-
- 56 edits4 copies18 adds in trunk
[iOS] Upstream changes in Tools/DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=127412
Reviewed by Simon Fraser.
Source/WebKit/mac:
- Misc/WebCoreStatistics.h: Included CGContext.h.
Tools:
Upstream all iOS changes. Added a new target called DumpRenderTree.app,
which builds the DumpRenderTree static library into an app bundle as
expected by the iOS Simulator.
- DumpRenderTree/AccessibilityTextMarker.h:
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
- DumpRenderTree/DumpRenderTreePrefix.h:
- DumpRenderTree/PixelDumpSupport.cpp:
- DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
- DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
- DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
- DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
- DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
- DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
- DumpRenderTree/TestNetscapePlugIn/TestObject.h:
- DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
- DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSAfterRemovingPluginElement.cpp:
- DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
- DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
- DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
- DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp:
- DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
- DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
- DumpRenderTree/TestNetscapePlugIn/main.cpp:
- DumpRenderTree/TestRunner.cpp:
- DumpRenderTree/TestRunner.h:
- DumpRenderTree/cg/ImageDiffCG.cpp:
- DumpRenderTree/cg/PixelDumpSupportCG.cpp:
- DumpRenderTree/ios/AccessibilityControllerIOS.mm:
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
- DumpRenderTree/ios/DumpRenderTreeBrowserView.h: Added.
- DumpRenderTree/ios/DumpRenderTreeBrowserView.mm: Added.
- DumpRenderTree/ios/Info.plist: Added.
- DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport.c: Added.
- DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Added.
- DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Added.
- DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Changes: Added.
- DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/IPhoneSimulatorNotification.xs: Added.
- DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/MANIFEST: Added.
- DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL: Added.
- DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/README: Added.
- DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm: Added.
- DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/ppport.h: Added.
- DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/t/IPhoneSimulatorNotification.t: Added.
- DumpRenderTree/ios/PerlSupport/Makefile: Added.
- DumpRenderTree/ios/PixelDumpSupportIOS.mm: Added.
- DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
- DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
- DumpRenderTree/mac/AppleScriptController.m:
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
- DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
- DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Added.
- DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
- DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
- DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Added.
- DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
- DumpRenderTree/mac/DumpRenderTree.mm:
- DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
- DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
- DumpRenderTree/mac/DumpRenderTreeMac.h:
- DumpRenderTree/mac/DumpRenderTreePasteboard.h:
- DumpRenderTree/mac/DumpRenderTreePasteboard.m:
- DumpRenderTree/mac/DumpRenderTreeWindow.h:
- DumpRenderTree/mac/DumpRenderTreeWindow.mm:
- DumpRenderTree/mac/EditingDelegate.h:
- DumpRenderTree/mac/EventSendingController.h:
- DumpRenderTree/mac/EventSendingController.mm:
- DumpRenderTree/mac/FrameLoadDelegate.mm:
- DumpRenderTree/mac/HistoryDelegate.h:
- DumpRenderTree/mac/LayoutTestHelper.m:
- DumpRenderTree/mac/MockGeolocationProvider.mm:
- DumpRenderTree/mac/NavigationController.h:
- DumpRenderTree/mac/ObjCPlugin.h:
- DumpRenderTree/mac/ObjCPlugin.m:
- DumpRenderTree/mac/ObjCPluginFunction.h:
- DumpRenderTree/mac/PolicyDelegate.h:
- DumpRenderTree/mac/ResourceLoadDelegate.h:
- DumpRenderTree/mac/ResourceLoadDelegate.mm:
- DumpRenderTree/mac/TestRunnerMac.mm:
- DumpRenderTree/mac/TextInputController.h:
- DumpRenderTree/mac/TextInputController.m:
- DumpRenderTree/mac/UIDelegate.h:
- DumpRenderTree/mac/UIDelegate.mm:
- 3:40 PM Changeset in webkit [162816] by
-
- 8 edits in trunk/Source
AX: Disable accessibility after every test run
https://bugs.webkit.org/show_bug.cgi?id=127439
Reviewed by Alexey Proskuryakov.
../WebCore:
If accessibility is disabled, we may still need to return the existing
AXObjectCache, so that objects can be cleaned up appropriately.
A such we have to be prepared to handle a nullptr return value in more cases.
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::disableAccessibility):
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::childrenChanged):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::remoteSVGRootElement):
- dom/Document.cpp:
(WebCore::Document::existingAXObjectCache):
../WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 2:55 PM Changeset in webkit [162815] by
-
- 2 edits in trunk/Source/WebKit/win
Follow-up build fix.
- WebHistoryItem.cpp:
(WebHistoryItem::visitedWithTitle):
- 2:52 PM Changeset in webkit [162814] by
-
- 3 edits in trunk/Source/WebKit/win
Remove even more Windows history code.
- WebHistory.cpp:
(WebHistory::removeItemForURLString):
- WebHistoryItem.cpp:
(WebHistoryItem::initFromDictionaryRepresentation):
(WebHistoryItem::dictionaryRepresentation):
(WebHistoryItem::getDailyVisitCounts):
(WebHistoryItem::getWeeklyVisitCounts):
(WebHistoryItem::recordInitialVisit):
(WebHistoryItem::initWithURLString):
- 2:46 PM Changeset in webkit [162813] by
-
- 3 edits in trunk/Source/WebKit/win
Another follow-up build fix.
- WebHistory.cpp:
(WebHistory::removeAllItems):
(WebHistory::orderedItemsLastVisitedOnDay):
- WebHistoryItem.cpp:
(WebHistoryItem::initFromDictionaryRepresentation):
(WebHistoryItem::dictionaryRepresentation):
(WebHistoryItem::visitCount):
(WebHistoryItem::setVisitCount):
- 2:41 PM Changeset in webkit [162812] by
-
- 4 edits in trunk/Source/WebKit/win
Remove more history gunk.
- WebHistory.cpp:
(WebHistory::orderedLastVisitedDays):
(WebHistory::addItem):
(WebHistory::visitedURL):
(WebHistory::removeItemForURLString):
- WebHistory.h:
- WebHistoryItem.cpp:
(WebHistoryItem::initFromDictionaryRepresentation):
(WebHistoryItem::dictionaryRepresentation):
(WebHistoryItem::mergeAutoCompleteHints):
(WebHistoryItem::setLastVisitedTimeInterval):
(WebHistoryItem::initWithURLString):
(WebHistoryItem::lastVisitedTimeInterval):
- 2:39 PM Changeset in webkit [162811] by
-
- 8 edits1 add in branches/jsCStack/Source/JavaScriptCore
FTL should do polyvariant GetById inlining
https://bugs.webkit.org/show_bug.cgi?id=127639
Not yet reviewed.
This does polyvariant inlining for GetByIds. It's pretty easy to do this, now that we
have all of that infrastructure from polyvariant Call/Construct inlining. Basically we
just keep around the StubInfoMaps of the DFG code block when compiling the FTL code
block.
The combination of Call, Construct, and GetById inlining causes a 17% speed-up on
V8v7/raytrace.
GetById inlining alone appears to be a speed-up on other benchmarks as well.
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeDFGStatuses):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::getStubInfoMap):
(JSC::CodeBlock::addStubInfo):
- bytecode/CodeBlock.h:
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::hasExitSite):
(JSC::GetByIdStatus::computeFor):
(JSC::GetByIdStatus::computeForStubInfo):
- bytecode/GetByIdStatus.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parse):
- runtime/Options.h:
- tests/stress/simple-polyvariant-get-by-id-inlining-example.js: Added.
(foo):
(fuzz):
(bar):
- 2:34 PM Changeset in webkit [162810] by
-
- 2 edits in trunk/Source/WebKit/win
Build fix.
- WebHistoryItem.cpp:
(WebHistoryItem::initFromDictionaryRepresentation):
(WebHistoryItem::dictionaryRepresentation):
- 2:29 PM Changeset in webkit [162809] by
-
- 1 edit1 add in trunk/LayoutTests
Some more Apple Windows port rebaseline.
- platform/win/svg/custom/foreign-object-skew-expected.txt: Added.
- 2:22 PM Changeset in webkit [162808] by
-
- 8 edits in trunk/Source
Move history item visit count handling to WebKit
https://bugs.webkit.org/show_bug.cgi?id=127659
Reviewed by Dan Bernstein.
Source/WebCore:
Remove all members dealing with visit handling - they're going back to WebKit.
- WebCore.exp.in:
- history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
(WebCore::HistoryItem::reset):
(WebCore::HistoryItem::decodeBackForwardTree):
- history/HistoryItem.h:
(WebCore::HistoryItem::create):
Source/WebKit/mac:
Move code to deal with visit count and visit dates here from WebCore.
- History/HistoryPropertyList.mm:
(HistoryPropertyListWriter::writeHistoryItem):
- History/WebHistoryItem.mm:
(-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
(-[WebHistoryItem copyWithZone:]):
(-[WebHistoryItem lastVisitedTimeInterval]):
(-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):
(-[WebHistoryItem setVisitCount:]):
(-[WebHistoryItem _mergeAutoCompleteHints:]):
(-[WebHistoryItem initFromDictionaryRepresentation:]):
(-[WebHistoryItem _visitedWithTitle:increaseVisitCount:]):
(-[WebHistoryItem _recordInitialVisit]):
(timeToDay):
(-[WebHistoryItem _padDailyCountsForNewVisit:]):
(-[WebHistoryItem _collapseDailyVisitsToWeekly]):
(-[WebHistoryItem _recordVisitAtTime:increaseVisitCount:]):
(-[WebHistoryItem _setLastVisitedTimeInterval:]):
- History/WebHistoryItemInternal.h:
- 1:32 PM Changeset in webkit [162807] by
-
- 6 edits1 move in trunk/Source/WebKit
Source/WebKit: Fix build.
Make HistoryPropertyList an Objective-C++ class.
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac: Fix build.
Pass a WebHistoryItem to writeHistoryItem so we can extract _lastVisitWasHTTPNonGet from it.
- History/HistoryPropertyList.h:
- History/HistoryPropertyList.mm:
(HistoryPropertyListWriter::HistoryPropertyListWriter):
(HistoryPropertyListWriter::buffer):
(HistoryPropertyListWriter::releaseData):
(HistoryPropertyListWriter::writeObjects):
(HistoryPropertyListWriter::writeHistoryItem):
- History/WebHistory.mm:
(WebHistoryWriter::writeHistoryItems):
- History/WebHistoryItem.mm:
- 1:21 PM Changeset in webkit [162806] by
-
- 11 edits in trunk/Source
Move lastVisitWasHTTPNonGet out to WebHistoryItem
https://bugs.webkit.org/show_bug.cgi?id=127657
Reviewed by Dan Bernstein.
Source/WebCore:
Remove m_lastVisitWasHTTPNonGet, it's only used by WebKit.
- history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
(WebCore::HistoryItem::reset):
- history/HistoryItem.h:
Source/WebKit/mac:
Keep track of _lastVisitWasHTTPNonGet inside WebHistoryItem.
- History/WebHistory.mm:
(-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]):
Set entry->_private->_lastVisitWasHTTPNonGet.
- History/WebHistoryItem.h:
Change @private to @package so we can get at WebHistoryItemPrivate from WebHistory.
- History/WebHistoryItem.mm:
(-[WebHistoryItem copyWithZone:]):
Assign _private->_lastVisitWasHTTPNonGet.
(-[WebHistoryItem initFromDictionaryRepresentation:]):
Set _private->_lastVisitWasHTTPNonGet.
- History/WebHistoryItemInternal.h:
Move WebHistoryItemPrivate interface here.
Source/WebKit/win:
Remove uses of lastVisitWasHTTPNonGet.
- WebHistory.cpp:
(WebHistory::visitedURL):
- WebHistoryItem.cpp:
(WebHistoryItem::initFromDictionaryRepresentation):
(WebHistoryItem::lastVisitWasHTTPNonGet):
(WebHistoryItem::setLastVisitWasHTTPNonGet):
- 12:04 PM Changeset in webkit [162805] by
-
- 1 edit58 adds in trunk/LayoutTests
Unreviewed Apple Windows port rebaseline after r162803.
- platform/win/editing/selection/3690703-2-expected.txt: Added.
- platform/win/editing/selection/3690703-expected.txt: Added.
- platform/win/editing/selection/3690719-expected.txt: Added.
- platform/win/editing/selection/4397952-expected.txt: Added.
- platform/win/editing/selection/5240265-expected.txt: Added.
- platform/win/editing/selection/selection-button-text-expected.txt: Added.
- platform/win/fast/block/float/float-avoidance-expected.txt: Added.
- platform/win/fast/css/continuationCrash-expected.txt: Added.
- platform/win/fast/css/margin-top-bottom-dynamic-expected.txt: Added.
- platform/win/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Added.
- platform/win/fast/forms/001-expected.txt: Added.
- platform/win/fast/forms/blankbuttons-expected.txt: Added.
- platform/win/fast/forms/button-table-styles-expected.txt: Added.
- platform/win/fast/forms/control-restrict-line-height-expected.txt: Added.
- platform/win/fast/forms/file/file-input-direction-expected.txt: Added.
- platform/win/fast/forms/file/input-file-re-render-expected.txt: Added.
- platform/win/fast/forms/formmove3-expected.txt: Added.
- platform/win/fast/forms/input-appearance-height-expected.txt: Added.
- platform/win/fast/forms/input-button-sizes-expected.txt: Added.
- platform/win/fast/forms/input-value-expected.txt: Added.
- platform/win/fast/forms/targeted-frame-submission-expected.txt: Added.
- platform/win/fast/html/details-replace-summary-child-expected.txt: Added.
- platform/win/fast/html/details-replace-text-expected.txt: Added.
- platform/win/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt: Added.
- platform/win/fast/overflow/scrollRevealButton-expected.txt: Added.
- platform/win/fast/replaced/width100percent-button-expected.txt: Added.
- platform/win/fast/text/textIteratorNilRenderer-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug138725-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug18359-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug2479-3-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug2479-4-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug26178-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug28928-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug33855-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug39209-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug4429-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug46368-1-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug46368-2-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug51037-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug51727-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug52505-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug52506-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug60749-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug7342-expected.txt: Added.
- platform/win/tables/mozilla/collapsing_borders/bug41262-4-expected.txt: Added.
- platform/win/tables/mozilla/dom/tableDom-expected.txt: Added.
- platform/win/tables/mozilla/other/move_row-expected.txt: Added.
- platform/win/tables/mozilla_expected_failures/bugs/bug1725-expected.txt: Added.
- platform/win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Added.
- platform/win/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt: Added.
- 10:54 AM Changeset in webkit [162804] by
-
- 2 edits in trunk/Source/WebKit/mac
Turn WebHistoryItemPrivate back into a real Objective-C class
https://bugs.webkit.org/show_bug.cgi?id=127653
Reviewed by Sam Weinig.
This is a first step towards moving some history specific code from WebCore::HistoryItem back into WebKit.
- History/WebHistoryItem.mm:
(-[WebHistoryItem dealloc]):
(-[WebHistoryItem finalize]):
(-[WebHistoryItem initWithWebCoreHistoryItem:]):
- 10:28 AM Changeset in webkit [162803] by
-
- 129 edits1 add in trunk
Subpixel Layout: Align <input type="button", submit etc (PushButtonPart) top and bottom paddings with <button>
https://bugs.webkit.org/show_bug.cgi?id=127640
Reviewed by Simon Fraser.
<button> sets padding-top: 2px and padding-bottom: 3px as default values (html.css),
while <input type="button" (submit, etc) has the hardcoded values of 0, 0 and we center the text using the available space.
This results in different baseline text position in normal cases. This adjustment puts the <input type='button'
rendering back to the pre-subpixel layout state.
Source/WebCore:
- platform/mac/ThemeMac.mm:
(WebCore::ThemeMac::controlPadding):
LayoutTests:
- platform/mac/css3/flexbox/button-expected.txt:
- platform/mac/editing/selection/3690703-2-expected.txt:
- platform/mac/editing/selection/3690703-expected.txt:
- platform/mac/editing/selection/3690719-expected.txt:
- platform/mac/editing/selection/4397952-expected.txt:
- platform/mac/editing/selection/5240265-expected.txt:
- platform/mac/editing/selection/selection-button-text-expected.txt:
- platform/mac/fast/block/float/float-avoidance-expected.txt:
- platform/mac/fast/css/continuationCrash-expected.txt:
- platform/mac/fast/css/margin-top-bottom-dynamic-expected.txt:
- platform/mac/fast/css/rtl-ordering-expected.txt:
- platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
- platform/mac/fast/forms/001-expected.png:
- platform/mac/fast/forms/001-expected.txt:
- platform/mac/fast/forms/basic-buttons-expected.png:
- platform/mac/fast/forms/basic-buttons-expected.txt:
- platform/mac/fast/forms/blankbuttons-expected.txt:
- platform/mac/fast/forms/box-shadow-override-expected.png:
- platform/mac/fast/forms/box-shadow-override-expected.txt:
- platform/mac/fast/forms/button-positioned-expected.png:
- platform/mac/fast/forms/button-positioned-expected.txt:
- platform/mac/fast/forms/button-sizes-expected.png:
- platform/mac/fast/forms/button-sizes-expected.txt:
- platform/mac/fast/forms/button-style-color-expected.png:
- platform/mac/fast/forms/button-style-color-expected.txt:
- platform/mac/fast/forms/button-table-styles-expected.png:
- platform/mac/fast/forms/button-table-styles-expected.txt:
- platform/mac/fast/forms/button-text-transform-expected.png:
- platform/mac/fast/forms/button-text-transform-expected.txt:
- platform/mac/fast/forms/control-restrict-line-height-expected.png:
- platform/mac/fast/forms/control-restrict-line-height-expected.txt:
- platform/mac/fast/forms/file/file-input-direction-expected.png:
- platform/mac/fast/forms/file/file-input-direction-expected.txt:
- platform/mac/fast/forms/file/file-input-disabled-expected.txt:
- platform/mac/fast/forms/file/input-file-re-render-expected.txt:
- platform/mac/fast/forms/form-element-geometry-expected.png:
- platform/mac/fast/forms/form-element-geometry-expected.txt:
- platform/mac/fast/forms/formmove3-expected.txt:
- platform/mac/fast/forms/input-appearance-height-expected.png:
- platform/mac/fast/forms/input-appearance-height-expected.txt:
- platform/mac/fast/forms/input-button-sizes-expected.png:
- platform/mac/fast/forms/input-button-sizes-expected.txt:
- platform/mac/fast/forms/input-value-expected.png:
- platform/mac/fast/forms/input-value-expected.txt:
- platform/mac/fast/forms/targeted-frame-submission-expected.txt:
- platform/mac/fast/forms/validation-message-appearance-expected.png:
- platform/mac/fast/forms/validation-message-appearance-expected.txt:
- platform/mac/fast/html/details-replace-summary-child-expected.txt:
- platform/mac/fast/html/details-replace-text-expected.txt:
- platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
- platform/mac/fast/overflow/scrollRevealButton-expected.txt:
- platform/mac/fast/replaced/replaced-breaking-expected.txt:
- platform/mac/fast/replaced/width100percent-button-expected.txt:
- platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
- platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
- platform/mac/svg/custom/foreign-object-skew-expected.txt: Added.
- platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
- platform/mac/tables/mozilla/bugs/bug138725-expected.txt:
- platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
- platform/mac/tables/mozilla/bugs/bug26178-expected.txt:
- platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
- platform/mac/tables/mozilla/bugs/bug33855-expected.txt:
- platform/mac/tables/mozilla/bugs/bug39209-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4429-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
- platform/mac/tables/mozilla/bugs/bug51727-expected.txt:
- platform/mac/tables/mozilla/bugs/bug52505-expected.txt:
- platform/mac/tables/mozilla/bugs/bug52506-expected.txt:
- platform/mac/tables/mozilla/bugs/bug60749-expected.txt:
- platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
- platform/mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
- platform/mac/tables/mozilla/dom/tableDom-expected.txt:
- platform/mac/tables/mozilla/other/move_row-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
- 5:39 AM WebKitGTK/2.2.x edited by
- (diff)
- 5:33 AM Changeset in webkit [162802] by
-
- 56 edits in trunk/LayoutTests
Unreviewed GTK gardening. Rebaselining after r162553, r162742, r162791 and possibly other revisions.
- platform/gtk/css1/box_properties/padding-expected.txt:
- platform/gtk/css1/box_properties/padding_top-expected.txt:
- platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
- platform/gtk/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
- platform/gtk/css2.1/t0804-c5510-padn-00-b-ag-expected.txt:
- platform/gtk/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-25-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-70-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-25-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-70-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-25-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-70-expected.txt:
- platform/gtk/fast/block/basic/011-expected.txt:
- platform/gtk/fast/block/float/032-expected.txt:
- platform/gtk/fast/block/margin-collapse/103-expected.txt:
- platform/gtk/fast/css/empty-pseudo-class-expected.txt:
- platform/gtk/fast/css/fieldset-display-row-expected.txt:
- platform/gtk/fast/css/first-child-pseudo-class-expected.txt:
- platform/gtk/fast/css/input-search-padding-expected.txt:
- platform/gtk/fast/css/last-child-pseudo-class-expected.txt:
- platform/gtk/fast/css/non-standard-checkbox-size-expected.txt:
- platform/gtk/fast/css/only-child-pseudo-class-expected.txt:
- platform/gtk/fast/forms/001-expected.txt:
- platform/gtk/fast/forms/basic-inputs-expected.txt:
- platform/gtk/fast/forms/box-shadow-override-expected.txt:
- platform/gtk/fast/forms/file/file-input-disabled-expected.txt:
- platform/gtk/fast/forms/form-element-geometry-expected.txt:
- platform/gtk/fast/forms/formmove-expected.txt:
- platform/gtk/fast/forms/formmove2-expected.txt:
- platform/gtk/fast/forms/indeterminate-expected.txt:
- platform/gtk/fast/forms/input-appearance-height-expected.txt:
- platform/gtk/fast/forms/input-text-word-wrap-expected.txt:
- platform/gtk/fast/forms/input-value-expected.txt:
- platform/gtk/fast/forms/large-toggle-elements-expected.txt:
- platform/gtk/fast/inline/positionedLifetime-expected.txt:
- platform/gtk/fast/parser/bad-xml-slash-expected.txt:
- platform/gtk/fast/repaint/reflection-redraw-expected.txt:
- platform/gtk/fast/replaced/replaced-breaking-expected.txt:
- platform/gtk/fast/replaced/width100percent-checkbox-expected.txt:
- platform/gtk/fast/replaced/width100percent-radio-expected.txt:
- platform/gtk/fast/table/dynamic-caption-add-remove-before-child-expected.txt:
- platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
- platform/gtk/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
- platform/gtk/http/tests/navigation/javascriptlink-frames-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug1318-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
- platform/gtk/tables/mozilla/marvin/body_col-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_th_valign_baseline-expected.txt:
- platform/gtk/tables/mozilla/other/body_col-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/core/captions2-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/core/captions3-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:
- 2:30 AM Changeset in webkit [162801] by
-
- 4 edits2 adds in trunk
Improve the bindings of NodeList's name accessor
https://bugs.webkit.org/show_bug.cgi?id=127358
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-26
Reviewed by Geoffrey Garen.
Source/WebCore:
When accessing an item of NodeList by name, the default bindings was
going through the list of node twice:
-First, getOwnProperty calls canGetItemsForName() to find if a property exists for
the given name. This in turn used NodeList::namedItem() which is a slow operation.
-Then, the value itself was queried through nameGetter(), calling NodeList::namedItem()
a second time to find the same value.
This patch kills the default name getter in favor of a getOwnPropertySlotDelegate() returning
the value directly on the PropertySlot.
Ad Hoc testing show about 15% speed up for simple cases.
- bindings/js/JSNodeListCustom.cpp:
(WebCore::JSNodeList::getOwnPropertySlotDelegate):
- dom/NodeList.idl:
LayoutTests:
- fast/dom/NodeList/nodelist-name-getter-properties-expected.txt: Added.
- fast/dom/NodeList/nodelist-name-getter-properties.html: Added.
- 2:26 AM Changeset in webkit [162800] by
-
- 1 edit2 adds in trunk/LayoutTests
ASSERTION FAILED: !m_hasPendingCharacter
https://bugs.webkit.org/show_bug.cgi?id=110118
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-26
Reviewed by Sam Weinig.
Add more test coverage for r144552 with a use case that use to hit the assertion.
- fast/dom/xml-parser-entity-in-attribute-value-expected.txt: Added.
- fast/dom/xml-parser-entity-in-attribute-value.html: Added.
- 12:39 AM Changeset in webkit [162799] by
-
- 26 edits2 moves12 adds in trunk
Web Inspector: Move InspectorDebuggerAgent into JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=127629
Rubber-stamped by Sam Weinig.
Source/JavaScriptCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Add new files to the build.
- Also, since non REMOTE_INSPECTOR ports cannot yet connect to a JSGlobalObject for inspection remove those files as they don't need to be built.
- inspector/EventLoop.cpp: Added.
(Inspector::EventLoop::cycle):
- inspector/EventLoop.h: Added.
(Inspector::EventLoop::EventLoop):
(Inspector::EventLoop::ended):
Add a JavaScriptCore version of EventLoop. This is currently only
used by the Mac port for JSGlobalObject remote inspection. Keep
the WebCore/platform version alive because for the Mac port it does
slightly different things involving AppKit.
- inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
Create DebuggerAgent and hook up ScriptDebugServer where needed.
- inspector/JSGlobalObjectScriptDebugServer.cpp: Added.
(Inspector::JSGlobalObjectScriptDebugServer::JSGlobalObjectScriptDebugServer):
(Inspector::JSGlobalObjectScriptDebugServer::addListener):
(Inspector::JSGlobalObjectScriptDebugServer::removeListener):
(Inspector::JSGlobalObjectScriptDebugServer::recompileAllJSFunctions):
(Inspector::JSGlobalObjectScriptDebugServer::runEventLoopWhilePaused):
- inspector/JSGlobalObjectScriptDebugServer.h: Added.
Simple implementation of ScriptDebugServer with a JSGlobalObject.
- inspector/agents/InspectorDebuggerAgent.cpp: Renamed from Source/WebCore/inspector/InspectorDebuggerAgent.cpp.
- inspector/agents/InspectorDebuggerAgent.h: Renamed from Source/WebCore/inspector/InspectorDebuggerAgent.h.
Copied from WebCore. A few methods need to be made virtual so that Web implementations
can override and extend the funcitonality. E.g. sourceMapURLForScript and enable/disable.
- inspector/agents/JSGlobalObjectDebuggerAgent.cpp: Added.
- inspector/agents/JSGlobalObjectDebuggerAgent.h: Added.
(Inspector::JSGlobalObjectDebuggerAgent::JSGlobalObjectDebuggerAgent):
(Inspector::JSGlobalObjectDebuggerAgent::startListeningScriptDebugServer):
(Inspector::JSGlobalObjectDebuggerAgent::stopListeningScriptDebugServer):
(Inspector::JSGlobalObjectDebuggerAgent::injectedScriptForEval):
Simple implementation of DebuggerAGent with a JSGlobalObject.
Source/WebCore:
Test: inspector-protocol/debugger/pause-on-assert.html
- CMakeLists.txt:
- ForwardingHeaders/inspector/agents/InspectorDebuggerAgent.h: Added.
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorAllInOne.cpp:
- Remove InspectorDebuggerAgent.
- Add WebDebuggerAgent (shared between Page and Worker).
- inspector/WebDebuggerAgent.h: Added.
(WebCore::WebDebuggerAgent::~WebDebuggerAgent):
- inspector/WebDebuggerAgent.cpp: Added.
(WebCore::WebDebuggerAgent::WebDebuggerAgent):
(WebCore::WebDebuggerAgent::enable):
(WebCore::WebDebuggerAgent::disable):
Shared code for Page and Worker debugger agents.
Instrumenting agents is a concept in WebCore only,
and the Debugger agent is only in the instrumenting
agents list when it is enabled and removed when disabled.
- inspector/InstrumentingAgents.h:
(WebCore::InstrumentingAgents::inspectorDebuggerAgent):
(WebCore::InstrumentingAgents::setInspectorDebuggerAgent):
- inspector/InspectorDOMDebuggerAgent.cpp:
- inspector/InspectorDOMDebuggerAgent.h:
Update namespace for debugger agent.
- inspector/InspectorInstrumentation.cpp:
(WebCore::isConsoleAssertMessage):
(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
DebuggerAgent in JavaScriptCore does not yet know about console
types. So temporarily handle it here. We need to give JavaScriptCore
some concept of Console messages and types.
- inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::PageDebuggerAgent):
(WebCore::PageDebuggerAgent::enable):
(WebCore::PageDebuggerAgent::disable):
(WebCore::PageDebuggerAgent::sourceMapURLForScript):
(WebCore::PageDebuggerAgent::injectedScriptForEval):
- inspector/PageDebuggerAgent.h:
- inspector/WorkerDebuggerAgent.cpp:
(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::injectedScriptForEval):
- inspector/WorkerDebuggerAgent.h:
Modernize the Page and Worker debugger agents.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorController.h:
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
New constructors for the debugger agents.
LayoutTests:
Add a test that we pause in the debugger for console.assert failures
when the DebuggerAgent is enabled.
- inspector-protocol/debugger/pause-on-assert-expected.txt: Added.
- inspector-protocol/debugger/pause-on-assert.html: Added.
- inspector-protocol/debugger/resources/assert.js: Added.
(assertTrue):
(assertFalse):
(assertCondition):
(assertConditionWithMessage):
