Context Navigation

platform/efl/fast/css-generated-content/005-expected.txt:
platform/efl/fast/css-generated-content/beforeAfter-interdocument-expected.txt:
platform/efl/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
platform/efl/fast/css-generated-content/no-openclose-quote-expected.txt:

10:29 PM Changeset in webkit [163004] by fpizlo@apple.com

4 edits
3 adds in branches/jsCStack/Source/JavaScriptCore

FTL should support ArrayPop
https://bugs.webkit.org/show_bug.cgi?id=127749

Reviewed by Geoffrey Garen.

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLIntrinsicRepository.h:
ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileArrayPush):
(JSC::FTL::LowerDFGToLLVM::compileArrayPop):

tests/stress/array-pop-contiguous.js: Added.

(foo):

tests/stress/array-pop-double.js: Added.

(foo):

tests/stress/array-pop-int32.js: Added.

(foo):

10:12 PM Changeset in webkit [163003] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Crashes in ViewGestureController::wheelEventWasNotHandledByWebCore
https://bugs.webkit.org/show_bug.cgi?id=127828
<rdar://problem/15932902>

Reviewed by Dan Bernstein.

UIProcess/API/mac/WKView.mm:

(-[WKView _wheelEventWasNotHandledByWebCore:]):
Null check. ViewGestureController only needs unhandled wheel events after it has been created.

10:03 PM Changeset in webkit [163002] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Fix the Mountain Lion build if you have private headers.

UIProcess/mac/ViewGestureController.mm:

(WebKit::ViewGestureController::beginSwipeGesture):

9:22 PM Changeset in webkit [163001] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[iOS] UI process crashes whenever web process crashes
https://bugs.webkit.org/show_bug.cgi?id=127826

Patch by Ian Henderson <ianh@apple.com> on 2014-01-28
Reviewed by Tim Horton.

UIProcess/API/ios/WKContentView.mm:

(-[WKContentView _updateFixedPositionRect]): Null-check the drawing
area before calling size() on it.

9:14 PM Changeset in webkit [163000] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

WKRemoteObjectCoder should support more argument types
https://bugs.webkit.org/show_bug.cgi?id=127824

Patch by Ian Henderson <ianh@apple.com> on 2014-01-28
Reviewed by Anders Carlsson.

Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(encodeInvocation): Support encoding char values.
(decodeInvocationArguments): Support decoding char values.

8:44 PM Changeset in webkit [162999] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

[Mac] Handle NSURLAuthenticationMethodServerTrust challenges from -resourceLoader:shouldWaitForResponseToAuthenticationChallenge:
https://bugs.webkit.org/show_bug.cgi?id=127806

Reviewed by Eric Carlson.

In addition to the normal "user/password" NSURLAuthenticationChallenges, the
-resourceLoader:shouldWaitForResponseToAuthenticationChallenge: delegate method will
ask us to confirm server certificate chains. Rather than pop up an authentication
dialog (which won't work anyway) we will now just drop such requests and continue
on normally.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(-[WebCoreAVFLoaderDelegate resourceLoader:shouldWaitForResponseToAuthenticationChallenge:]):

8:18 PM Changeset in webkit [162998] by commit-queue@webkit.org

29 edits in trunk

Unreviewed, rolling out r162987.
http://trac.webkit.org/changeset/162987
https://bugs.webkit.org/show_bug.cgi?id=127825

Broke Mountain Lion build (Requested by andersca on #webkit).

Source/JavaScriptCore:

inspector/InjectedScriptSource.js:

(.):

runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertyDescriptor):

runtime/PropertyDescriptor.cpp:
runtime/PropertyDescriptor.h:
runtime/PropertySlot.h:

Source/WebCore:

bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateAttributesHashTable):
(GenerateImplementation):

bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::jsTestActiveDOMObjectConstructor):

bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::jsTestCustomNamedGetterConstructor):

bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::jsTestEventConstructorConstructor):

bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::jsTestEventTargetConstructor):

bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::jsTestExceptionConstructor):

bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::jsTestGenerateIsReachableConstructor):

bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::jsTestInterfaceConstructor):

bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::jsTestMediaQueryListListenerConstructor):

bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::jsTestNamedConstructorConstructor):

bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::jsTestNodeConstructor):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjConstructor):

bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::jsTestOverloadedConstructorsConstructor):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::jsTestSerializedScriptValueInterfaceConstructor):

bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::jsTestTypedefsConstructor):

bindings/scripts/test/JS/JSattribute.cpp:

(WebCore::jsattributeConstructor):

bindings/scripts/test/JS/JSreadonly.cpp:

(WebCore::jsreadonlyConstructor):

LayoutTests:

fast/dom/Window/replaceable-expected.txt:
fast/dom/Window/replaceable.html:
js/dom/getOwnPropertyDescriptor-expected.txt:
js/resources/getOwnPropertyDescriptor.js:

8:09 PM Changeset in webkit [162997] by enrica@apple.com

8 edits in trunk/Source/WebCore

Add support for ActionSheets in WK2 for iOS.
https://bugs.webkit.org/show_bug.cgi?id=127586
<rdar://problem/15283667>

Reviewed by Benjamin Poulain.

This patch contains some WebCore changes required to
implement support for ActionSheets.
It adds copyURL implementation for iOS in the Editor
class and fixes some bugs in the iOS specific pasteboard
writing code.
The changes to Localizable.strings are the result of
running update-webkit-localizedstrings script.

English.lproj/Localizable.strings:
WebCore.exp.in:
editing/Editor.cpp:
editing/Editor.h:
editing/ios/EditorIOS.mm:

(WebCore::Editor::writeImageToPasteboard):

platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::write):

platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::write):

7:24 PM Changeset in webkit [162996] by ryuan.choi@samsung.com

2 edits in trunk/Source/WebKit2

Unreviewed build fix on the cmake based port after r162981

One more build fix.

CMakeLists.txt: Added WebDocumentLoader.cpp

7:12 PM Changeset in webkit [162995] by matthew_hanson@apple.com

2 edits in tags/Safari-538.14.1/Source/WebCore

Merge r162994: <rdar://problem/15920823>

7:06 PM Changeset in webkit [162994] by aestes@apple.com

2 edits in trunk/Source/WebCore

[iOS] REGRESSION (r162663): Webpages have strange artifacts or corruption around tile boundaries
https://bugs.webkit.org/show_bug.cgi?id=127823

Reviewed by Daniel Bates.

Original patch by Simon Fraser.

platform/ScrollView.cpp: Specify LegacyIOSDocumentViewRect when calling visibleContentRect().

6:58 PM Changeset in webkit [162993] by ryuan.choi@samsung.com

2 edits in trunk/Source/WebKit2

Unreviewed build fix on the EFL build after r162984

r162984 added wheelEventWasNotHandledByWebCore which is guarded to PLATFORM(MAC).

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveEvent):

6:42 PM Changeset in webkit [162992] by fpizlo@apple.com

2 edits
1 add in branches/jsCStack/Source/JavaScriptCore

DFG ArrayPop double array mishandles the NaN hole installation
https://bugs.webkit.org/show_bug.cgi?id=127813

Reviewed by Mark Rowe.

Our object model for arrays inferred double dictates that we use quiet NaN (QNaN) to
mark holes. Holes, in this context, are any entries in the allocated array buffer
(i.e. from index 0 up to the vectorLength) that don't currently hold a value. Popping
creates a hole, since it deletes the value at publicLength - 1.

But, because of some sloppy copy-and-paste, we were storing (int64_t)0 when creating
the hole, instead of storing QNaN. That's likely because for other kinds of arrays,
64-bit zero is the hole marker, instead of QNaN.

The attached test case illustrates the problem. In the LLInt and Baseline JIT, the
result returned from foo() is "1.5,2.5_{4.5", since array.pop() removes 3.5 and

replaces it with a hole and then the assignment "array[3] = 4.5" creates an element

just beyond that hole. But, once we tier-up to the DFG, the result previously became

"1.5,2.5,0,4.5", which is wrong. The 0 appeared because the IEEE double

interpretation of 64-bit zero is simply zero.

This patch fixes that problem. Now the DFG agrees with the other engines.

This patch also fixes style. For some reason that copy-pasted code wasn't even

indented correctly.}

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

tests/stress/array-pop-double-hole.js: Added.

(foo):

5:44 PM Changeset in webkit [162991] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Fix a thinko.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::goBack):
Remove early return if isValid() is true.

5:39 PM Changeset in webkit [162990] by andersca@apple.com

4 edits in trunk/Source/WebKit2

WebPage should be in charge of creating document loaders
https://bugs.webkit.org/show_bug.cgi?id=127818

Reviewed by Dan Bernstein.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createDocumentLoader):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createDocumentLoader):

WebProcess/WebPage/WebPage.h:

5:22 PM Changeset in webkit [162989] by zoltan@webkit.org

7 edits in trunk

[CSS Shapes] Adjust inset sizing syntax to the latest specification
https://bugs.webkit.org/show_bug.cgi?id=127785

Reviewed by Bem Jones-Bey.

Source/WebCore:

According to the latest CSS Shapes specification [1], the width arguments of inset should
follow the syntax of the margin shorthand, which let us set all four insets with one, two
or four values. This patch updates the behavior and updates the affected tests.

[1] http://dev.w3.org/csswg/css-shapes/#funcdef-inset

Existing tests have been updated.

css/CSSParser.cpp:

(WebCore::CSSParser::parseInsetRoundedCorners):
(WebCore::CSSParser::parseBasicShapeInset):

LayoutTests:

fast/shapes/parsing/parsing-shape-inside-expected.txt:
fast/shapes/parsing/parsing-shape-outside-expected.txt:
fast/shapes/parsing/parsing-test-utils.js:
fast/shapes/shape-outside-floats/shape-outside-floats-inset.html:

5:19 PM Changeset in webkit [162988] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

Unreviewed GTK build fix after r162951.
https://bugs.webkit.org/show_bug.cgi?id=127815

Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-01-28

GNUmakefile.list.am: Adding missing build targets.

5:13 PM Changeset in webkit [162987] by oliver@apple.com

29 edits in trunk

Make DOM attributes appear to be faux accessor properties
https://bugs.webkit.org/show_bug.cgi?id=127797

Reviewed by Michael Saboff.

Source/JavaScriptCore:

Add flag so we can identify which properties should have the old
custom property semantics vs. the new faux accessors. Update the
inspector protocol accordingly.

These faux accessors produce descriptors with "get" and "set"
properties, but both values are undefined so can't be used
directly. A few custom properties actually require their
existing magical behaviour, so we now have a flag to
distinguish the expected output.

inspector/InjectedScriptSource.js:

(.):

runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertyDescriptor):

runtime/PropertyDescriptor.cpp:

(JSC::PropertyDescriptor::setCustomDescriptor):

runtime/PropertyDescriptor.h:
runtime/PropertySlot.h:

Source/WebCore:

Refactor the bindings generator, and make sure we emit
the CustomAccessor flag on properties that should
appear to be accessors.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateAttributesHashTable):
(GenerateImplementation):

LayoutTests:

These properties now show up as accessors in these tests

fast/dom/Window/replaceable-expected.txt:
fast/dom/Window/replaceable.html:
js/dom/getOwnPropertyDescriptor-expected.txt:
js/resources/getOwnPropertyDescriptor.js:

5:05 PM Changeset in webkit [162986] by Chris Fleizach

26 edits
2 adds in trunk

AX: Support @scope in HTML tables
https://bugs.webkit.org/show_bug.cgi?id=127688

Reviewed by Mario Sanchez Prada.

Source/WebCore:

Add support for scope attribute so that row headers and column headers
are now exposed at the table cell level where appropriate.

Test: platform/mac/accessibility/table-scope.html

accessibility/AccessibilityARIAGridCell.cpp:

(WebCore::AccessibilityARIAGridCell::parentTable):

accessibility/AccessibilityARIAGridCell.h:
accessibility/AccessibilityARIAGridRow.cpp:

(WebCore::AccessibilityARIAGridRow::parentTable):

accessibility/AccessibilityARIAGridRow.h:
accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::columns):
(WebCore::AccessibilityTable::rows):

accessibility/AccessibilityTable.h:
accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::parentTable):
(WebCore::AccessibilityTableCell::isTableHeaderCell):
(WebCore::AccessibilityTableCell::isTableCellInSameRowGroup):
(WebCore::AccessibilityTableCell::isTableCellInSameColGroup):
(WebCore::AccessibilityTableCell::columnHeaders):
(WebCore::AccessibilityTableCell::rowHeaders):

accessibility/AccessibilityTableCell.h:
accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::parentTable):

accessibility/AccessibilityTableRow.h:
accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

Tools:

Add support for rowHeaders and columnHeaders.

DumpRenderTree/AccessibilityUIElement.cpp:

(convertElementsToObjectArray):
(columnHeadersCallback):
(rowHeadersCallback):
(uiElementArrayAttributeValueCallback):
(AccessibilityUIElement::columnHeaders):
(AccessibilityUIElement::rowHeaders):
(AccessibilityUIElement::getJSClass):

DumpRenderTree/AccessibilityUIElement.h:
DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::rowHeaders):
(AccessibilityUIElement::columnHeaders):

WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
(WTR::AccessibilityUIElement::rowHeaders):
(WTR::AccessibilityUIElement::columnHeaders):

WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::convertElementsToObjectArray):
(WTR::AccessibilityUIElement::rowHeaders):
(WTR::AccessibilityUIElement::columnHeaders):
(WTR::AccessibilityUIElement::uiElementArrayAttributeValue):

LayoutTests:

platform/mac/accessibility/aria-columnrowheaders-expected.txt:
platform/mac/accessibility/table-attributes-expected.txt:
platform/mac/accessibility/table-cell-spans-expected.txt:
platform/mac/accessibility/table-cells-expected.txt:
platform/mac/accessibility/table-scope-expected.txt: Added.
platform/mac/accessibility/table-scope.html: Added.
platform/mac/accessibility/table-sections-expected.txt:

4:59 PM Changeset in webkit [162985] by Brent Fulgham

5 edits in trunk/Source/WebCore

Improve latching behavior for wheel events
https://bugs.webkit.org/show_bug.cgi?id=127386
<rdar://problem/12176858>

Reviewed by Simon Fraser.

page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::clearLatchedNode): Added
(WebCore::ScrollingTree::latchedNode): Added
(WebCore::ScrollingTree::removeDestroyedNodes): Clear latched node if it's being removed.
(WebCore::ScrollingTree::ScrollingTree): Initialize new value used for tracking
scroll latching state.
(WebCore::ScrollingTree::setLatchedNode): Added
(WebCore::ScrollingTree::setOrClearLatchedNode): Added
Set latched node when beginning a swipe event, or clear latched node when scroll/momentum ends.
(WebCore::ScrollingTree::shouldHandleWheelEventSynchronously): Check for an existing
latched node and stay in fast scrolling mode if possible. If the current event should
start a swipe event, clear the current latched node so we can correctly find and assign
the new latch node.

page/scrolling/ScrollingTree.h:

(WebCore::ScrollingTree::hasLatchedNode): Added

page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::handleWheelEvent): Determine latching state
based on wheel event state and position of mouse pointer in the document.

platform/ScrollAnimator.cpp:

(ScrollAnimator::handleWheelEvent): Always treat PlatformWheelEventPhaseMayBegin
as successfully handled so that it does not "bubble back up" to the root of
the scrolling tree.

4:50 PM Changeset in webkit [162984] by timothy_horton@apple.com

11 edits in trunk/Source/WebKit2

WebKit2 View Gestures (Swipe): Give WebCore the first crack at scroll events if it needs it
https://bugs.webkit.org/show_bug.cgi?id=127396

Reviewed by Anders Carlsson.

UIProcess/API/ios/PageClientImplIOS.h:
UIProcess/API/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::wheelEventWasNotHandledByWebCore):

UIProcess/API/mac/PageClientImpl.h:
UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::wheelEventWasNotHandledByWebCore):

UIProcess/API/mac/WKView.mm:

(-[WKView _wheelEventWasNotHandledByWebCore:]):

UIProcess/API/mac/WKViewInternal.h:
UIProcess/PageClient.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveEvent):
In addition to informing the page client about un-handled wheel events,
inform the ViewGestureController, in a roundabout way.

UIProcess/mac/ViewGestureController.h:

Add and use SwipeDirection enum instead of 'bool willSwipeLeft'.

UIProcess/mac/ViewGestureController.mm:

(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::handleScrollWheelEvent):
If we get a Begin scroll wheel event, any previously deferred
swipes are invalid.

If the page has subframes or wheel handlers, defer starting the
swipe until we get a wheelEventWasNotHandledByWebCore back from the WebProcess.

(WebKit::ViewGestureController::wheelEventWasNotHandledByWebCore):
Start the swipe if the WebProcess didn't eat the event.

(WebKit::ViewGestureController::trackSwipeGesture):
(WebKit::ViewGestureController::beginSwipeGesture):
(WebKit::ViewGestureController::handleSwipeGesture):
Use SwipeDirection.

4:48 PM Changeset in webkit [162983] by matthew_hanson@apple.com

2 edits in tags/Safari-538.14.1/Source/WebKit2

Merge r162977: <rdar://problem/15930116>

4:42 PM Changeset in webkit [162982] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Fix build.

WebProcess/WebPage/WebFrame.cpp:

4:39 PM Changeset in webkit [162981] by andersca@apple.com

3 edits
2 adds in trunk/Source/WebKit2

Add WebDocumentLoader, a WebCore::DocumentLoader subclass
https://bugs.webkit.org/show_bug.cgi?id=127817

Reviewed by Tim Horton.

We need a place to store navigation IDs, and since they are per document loader, putting them
in a DocumentLoader subclass seems like a good idea.

WebKit2.xcodeproj/project.pbxproj:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createDocumentLoader):

WebProcess/WebPage/WebDocumentLoader.cpp: Added.

(WebKit::WebDocumentLoader::WebDocumentLoader):
(WebKit::WebDocumentLoader::setNavigationID):

WebProcess/WebPage/WebDocumentLoader.h: Added.

(WebKit::WebDocumentLoader::create):
(WebKit::WebDocumentLoader::navigationID):

4:16 PM Changeset in webkit [162980] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Simplify WebFrame::isMainFrame
https://bugs.webkit.org/show_bug.cgi?id=127812

Reviewed by Sam Weinig.

WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::isMainFrame):

4:11 PM Changeset in webkit [162979] by matthew_hanson@apple.com

5 edits in tags/Safari-538.14.1/Source

Versioning.

4:07 PM Changeset in webkit [162978] by ap@apple.com

2 edits in trunk/LayoutTests

REGRESSION (r162947): Repaint test results are different between WK1 and WK2
https://bugs.webkit.org/show_bug.cgi?id=127814

platform/mac-wk2/TestExpectations: Marking them as failing for now.

3:55 PM Changeset in webkit [162977] by aestes@apple.com

2 edits in trunk/Source/WebKit2

[iOS] Set INSTALL_PATH_ACTUAL when building WebKit2 for the iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=127811

Reviewed by Dan Bernstein.

Configurations/WebKit2.xcconfig:

3:51 PM Changeset in webkit [162976] by jinwoo7.song@samsung.com

2 edits in trunk/Source/WebKit2

Unreviewed EFL WebKit2 build fix.

CMakeLists.txt: Added Shared/NavigationActionData.cpp

3:49 PM Changeset in webkit [162975] by fpizlo@apple.com

2 edits in branches/jsCStack/Source/JavaScriptCore

FTL should support ArrayPush
https://bugs.webkit.org/show_bug.cgi?id=127748

Not reviewed, remove some debug code.

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileArrayPush):

3:46 PM Changeset in webkit [162974] by ap@apple.com

2 edits in trunk/LayoutTests

REGRESSION (r162947): css3/flexbox/multiline-justify-content.html and
css3/flexbox/position-absolute-child.html are timing out
https://bugs.webkit.org/show_bug.cgi?id=127809

platform/mac/TestExpectations: Skipping for now, Antti is going to take a look tomorrow.

3:43 PM Changeset in webkit [162973] by matthew_hanson@apple.com

1 copy in tags/Safari-538.14.1

New Tag.

3:36 PM Changeset in webkit [162972] by mmaxfield@apple.com

14 edits
2 adds in trunk

ASSERT_WITH_SECURITY_IMPLICATION in WebCore::InlineTextBox::paint
https://bugs.webkit.org/show_bug.cgi?id=114586

Reviewed by Dave Hyatt.

Taken mostly from https://chromium.googlesource.com/chromium/blink/+/cb2297db16f2e9328cb4dd8b552093d6b22340a8

If RenderQuote is a subclass of RenderObject, it can't be split by the first-letter CSS pseudoclass.
Instead, we should make it a subclass of RenderElement, so that it can be split properly.

Source/WebCore:

Test: fast/css-generated-content/quote-first-letter.html

dom/PseudoElement.cpp:

(WebCore::PseudoElement::didRecalcStyle):

rendering/RenderQuote.cpp:

(WebCore::RenderQuote::RenderQuote):
(WebCore::RenderQuote::willBeDestroyed):
(WebCore::RenderQuote::willBeRemovedFromTree):
(WebCore::RenderQuote::styleDidChange):
(WebCore::RenderQuote::updateText):
(WebCore::RenderQuote::computeText):
(WebCore::RenderQuote::updateDepth):

rendering/RenderQuote.h:
rendering/style/ContentData.cpp:

(WebCore::QuoteContentData::createContentRenderer):

LayoutTests:

This adds a test to make sure that the splitting behavior occurs, as well as updates existing tests that
didn't use the splitting behavior.

fast/css-generated-content/quote-first-letter-expected.html: Added.
fast/css-generated-content/quote-first-letter.html: Added.
platform/mac/fast/css-generated-content/005-expected.txt:
platform/mac/fast/css-generated-content/beforeAfter-interdocument-expected.txt:
platform/mac/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
platform/mac/fast/css-generated-content/no-openclose-quote-expected.txt:

3:30 PM Changeset in webkit [162971] by dbates@webkit.org

2 edits in trunk/Tools

Teach Buildbot dashboard to parse alternative revision format
https://bugs.webkit.org/show_bug.cgi?id=127561

Reviewed by Alexey Proskuryakov.

Add support for extracting the OpenSource and Internal revision numbers when Buildbot
returns a dictionary for the value of property got_revision.

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(isMultiCodebaseGotRevisionProperty): Added.
(parseRevisionProperty): Added; parses Buildbot revision property, which can either be a
string or a dictionary.
(BuildbotIteration.prototype.update.): Modified to call parseRevisionProperty() to determine
the OpenSource and Internal revision numbers.

3:29 PM Changeset in webkit [162970] by mark.lam@apple.com

21 edits in trunk/Source/JavaScriptCore

Remove some unneeded debugger code.
https://bugs.webkit.org/show_bug.cgi?id=127805.

Reviewed by Oliver Hunt.

JSC will now always support the debugger. Hence, the #if ENABLE(JAVASCRIPT_DEBUGGER)
checks can be removed.

DebuggerCallFrame::callFrame() is also unused and will be removed.

debugger/Breakpoint.h:
debugger/Debugger.cpp:
debugger/DebuggerCallFrame.h:
inspector/InjectedScript.cpp:

(Inspector::InjectedScript::wrapCallFrames):

inspector/InjectedScript.h:
inspector/JSGlobalObjectScriptDebugServer.cpp:
inspector/JSGlobalObjectScriptDebugServer.h:
inspector/JSJavaScriptCallFrame.cpp:
inspector/JSJavaScriptCallFrame.h:
inspector/JSJavaScriptCallFramePrototype.cpp:
inspector/JSJavaScriptCallFramePrototype.h:
inspector/JavaScriptCallFrame.cpp:
inspector/JavaScriptCallFrame.h:
inspector/ScriptDebugListener.h:
inspector/ScriptDebugServer.cpp:
inspector/ScriptDebugServer.h:
inspector/agents/InspectorDebuggerAgent.cpp:
inspector/agents/InspectorDebuggerAgent.h:
inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::InspectorRuntimeAgent):
(Inspector::setPauseOnExceptionsState):
(Inspector::InspectorRuntimeAgent::evaluate):
(Inspector::InspectorRuntimeAgent::callFunctionOn):
(Inspector::InspectorRuntimeAgent::getProperties):

inspector/agents/InspectorRuntimeAgent.h:

3:22 PM Changeset in webkit [162969] by fpizlo@apple.com

5 edits
3 adds in branches/jsCStack/Source/JavaScriptCore

FTL should support ArrayPush
https://bugs.webkit.org/show_bug.cgi?id=127748

Reviewed by Oliver Hunt.

ftl/FTLAbstractHeapRepository.h:

(JSC::FTL::AbstractHeapRepository::forArrayType):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLIntrinsicRepository.h:
ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileArrayPush):

tests/stress/array-push-contiguous.js: Added.

(foo):

tests/stress/array-push-double.js: Added.

(foo):

3:12 PM Changeset in webkit [162968] by ggaren@apple.com

4 edits in trunk/Source/JavaScriptCore

REGRESSION: JavascriptCore crash during OS Installation (due to
Heap::m_operationInProgress ASSERT vs DelayedReleaseScope)
https://bugs.webkit.org/show_bug.cgi?id=127793

Reviewed by Mark Hahnenberg.

This was a mistaken ASSERT.

API/tests/testapi.mm:

(-[EvilAllocationObject doEvilThingsWithContext:]): Added a test to verify
that GC from a DelayedReleaseScope doesn't crash.

heap/DelayedReleaseScope.h:

(JSC::DelayedReleaseScope::~DelayedReleaseScope): Our contract is that
it is valid to do anything while running a DelayedReleaseScope -dealloc
method, so the Heap must be ready for new allocations and collections.

Change the Heap's operationInProgress value to NoOperation while running
-dealloc methods, so that it doesn't ASSERT in the face of new allocations
and collections.

heap/Heap.h: Made DelayedReleaseScope a friend because exposing a setter

for m_operationInProgress seemed like the worse of the two options for
encapsulation: we don't really want arbitrary clients to set the Heap's
m_operationInProgress.

3:04 PM Changeset in webkit [162967] by andersca@apple.com

5 edits in trunk/Source/WebKit2

Remove WebPageProxy::canGoBack and WebPageProxy::canGoForward
https://bugs.webkit.org/show_bug.cgi?id=127803

Reviewed by Andreas Kling.

UIProcess/API/C/WKPage.cpp:

(WKPageCanGoForward):
(WKPageCanGoBack):

UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController canGoForward]):
(-[WKBrowsingContextController canGoBack]):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::goForward):
(WebKit::WebPageProxy::goBack):
(WebKit::WebPageProxy::sendWheelEvent):

UIProcess/WebPageProxy.h:

3:02 PM Changeset in webkit [162966] by Joseph Pecoraro

2 edits in trunk/Source/WebInspectorUI

Unreviewed follow-up to r162965. Better coding style.

Timothy Hatcher pointed out a clearer style for classes
on the <body> is to specify body.class. I agree.

UserInterface/DashboardView.css:

(body.javascript .toolbar .dashboard):
(body.web .toolbar.collapsed .dashboard > .logs):
(body.javascript .toolbar .dashboard > .resourcesCount):

2:47 PM Changeset in webkit [162965] by Joseph Pecoraro

6 edits in trunk/Source/WebInspectorUI

Web Inspector: Tweak UI when debugging a JSContext
https://bugs.webkit.org/show_bug.cgi?id=127799

Reviewed by Timothy Hatcher.

UserInterface/DashboardView.css:

(.toolbar.javascript .dashboard):
(.toolbar.web.collapsed .dashboard > .logs):
(.toolbar.javascript .dashboard > .resourcesCount):
Adjust collapsed dashboard in web and javascript debugging modes.
JavaScript debugging mode is always treated as collapsed.

UserInterface/Main.js:

(WebInspector.contentLoaded):
Adjust what is created and shown when in javascript debugging mode.

UserInterface/NavigationSidebarPanel.css:

(.navigation-sidebar-panel-content-tree-outline.hide-disclosure-buttons .item.small):

UserInterface/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel):
(WebInspector.ResourceSidebarPanel.prototype._scriptWasAdded):

UserInterface/TimelineSidebarPanel.css:

(.sidebar > .panel.timeline > .status-bar):
(.sidebar > .panel.timeline > .title-bar):
When javascript debugging expect to put things at the root level, so hide
disclosure buttons and adjust the style so resources look nice here.

2:46 PM Changeset in webkit [162964] by andersca@apple.com

4 edits in trunk/Source/WebKit2

API::PolicyClient::decidePolicyForNavigationAction should take a NavigationActionData object
https://bugs.webkit.org/show_bug.cgi?id=127798

Reviewed by Tim Horton.

UIProcess/API/APIPolicyClient.h:

(API::PolicyClient::decidePolicyForNavigationAction):

UIProcess/API/C/WKPage.cpp:

(WKPageSetPagePolicyClient):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::decidePolicyForNavigationAction):

2:44 PM Changeset in webkit [162963] by commit-queue@webkit.org

4 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Remove failure/timeout expectations for the following passed tests:

fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-non-intersecting-underline.html
fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html
svg/custom/mouse-move-on-svg-container.xhtml
svg/custom/mouse-move-on-svg-root.xhtml
fast/css/style-scoped/style-scoped-with-dom-operation.html

http/tests/download failures only affect gtk-wk1 now

Report and mark flaky tests:

http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_attributes_order.html
fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html
fast/parser/document-write-basic.html
http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_dynamic_insertion.html
media/crash-closing-page-with-media-as-plugin-fallback.html

Add timeout to flaky test media/audio-garbage-collect.html

Report and mark failed tests:

accessibility/range-alter-by-percent.html
media/video-restricted-no-preload-auto.html

Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-01-28

platform/gtk/TestExpectations:
platform/gtk-wk1/TestExpectations:
platform/gtk-wk2/TestExpectations:

2:32 PM Changeset in webkit [162962] by Antti Koivisto

8 edits in trunk/Source/WebCore

Document::topDocument() should return a reference
https://bugs.webkit.org/show_bug.cgi?id=127786

Reviewed by Darin Adler.

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::mainFrame):
(WebCore::AccessibilityObject::topDocument):

accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityContainer]):

dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::createRenderTree):
(WebCore::Document::destroyRenderTree):
(WebCore::Document::clearAXObjectCache):
(WebCore::Document::existingAXObjectCache):
(WebCore::Document::axObjectCache):
(WebCore::Document::implicitClose):
(WebCore::Document::topDocument):
(WebCore::Document::topOrigin):
(WebCore::Document::webkitCancelFullScreen):
(WebCore::Document::webkitDidExitFullScreenForElement):

dom/Document.h:
page/DOMWindow.cpp:

(WebCore::DOMWindow::incrementScrollEventListenersCount):
(WebCore::DOMWindow::decrementScrollEventListenersCount):

rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::isReplacementObscured):

rendering/RenderView.cpp:

(WebCore::RenderView::RepaintRegionAccumulator::RepaintRegionAccumulator):

2:25 PM Changeset in webkit [162961] by ap@apple.com

12 edits
1 delete in trunk/LayoutTests

js/dom/post-message-numeric-property.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=127713

Reviewed by Geoffrey Garen.

Plain testRunner and js-test-post.js approaches to being asynchronous don't work
together, you need one or the other.

js/dom/post-message-numeric-property-expected.txt:
js/dom/script-tests/post-message-numeric-property.js:

Updated to use jsTestIsAsync, as the wrapper includes js-test-post.js. The results
are now always printed in correct order, not flakily.

js/dom/cross-global-object-inline-global-var-expected.txt:
js/dom/script-tests/cross-global-object-inline-global-var.js:

Ditto.

js/dom/function-prototype.html:
js/dom/parse-error-external-script-in-eval.html:
js/dom/parse-error-external-script-in-new-Function.html:
js/dom/parse-syntax-error-in-initializer.html:

Removed waitUntilDone, these tests are not asynchronous at all.

js/dom/script-tests/cross-frame-bad-time.js:
js/dom/script-tests/cross-frame-really-bad-time-with-proto.js:
js/dom/script-tests/cross-frame-really-bad-time.js:

Updated to use jsTestIsAsync. These tests were not flaky because they happened to
run synchronously in practice, but document.writing a script into subframe won't
necessarily execute it synchronously in the future.

js/resources/fs-test-post.js: Removed. This file was unused.

2:21 PM Changeset in webkit [162960] by commit-queue@webkit.org

5 edits
4 adds in trunk

Sticky positioning is broken for table rows
https://bugs.webkit.org/show_bug.cgi?id=112024

Patch by Viatcheslav Ostapenko <sl.ostapenko@samsung.com> on 2014-01-28
Reviewed by Simon Fraser.

Source/WebCore:

Enable sticky positioning for table elements.
Also includes fix for bug wkb.ug/105654
I don't have access to this bug, but from related commit message I
assume it says about "Heap use after free problem".
Debugging showed that it wasn't heap use after free.
The real problem that RenderObject::container() returns object which is
not RenderBlock and it is used as RenderBlock in
RenderBox::containingBlockLogicalHeightForPositioned() method.
Added extra isRenderBlock check and search for containingBlock if
current block is not RenderBlock.

Tests: fast/css/sticky/sticky-table-row-top.html

fast/css/sticky/sticky-table-thead-top.html

css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):

rendering/RenderBox.cpp:

(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):

rendering/RenderTableRow.h:

LayoutTests:

Add layout tests for sticky positioned table row and table thead.

fast/css/sticky/sticky-table-row-top-expected.html: Added.
fast/css/sticky/sticky-table-row-top.html: Added.
fast/css/sticky/sticky-table-thead-top-expected.html: Added.
fast/css/sticky/sticky-table-thead-top.html: Added.

2:20 PM Changeset in webkit [162959] by andersca@apple.com

2 edits
2 adds in trunk/Source/WebKit2

Add an empty WKNavigation class
https://bugs.webkit.org/show_bug.cgi?id=127796

Reviewed by Tim Horton.

UIProcess/API/Cocoa/WKNavigation.h: Added.
UIProcess/API/Cocoa/WKNavigation.mm: Added.
WebKit2.xcodeproj/project.pbxproj:

2:10 PM Changeset in webkit [162958] by fpizlo@apple.com

2 edits
1 add in branches/jsCStack/Source/JavaScriptCore

Arity fixup clobbers callee-saves, causing FTL->FTL arity fixed-up calls to corrupt state
https://bugs.webkit.org/show_bug.cgi?id=127791

Reviewed by Michael Saboff.

Make the 64-bit path - i.e. the only path where the FTL matters - use regT6 instead
of regT3. regT6 is not a callee save.

jit/ThunkGenerators.cpp:

(JSC::arityFixup):

tests/stress/ftl-to-ftl-arity-fixup.js: Added.

(foo):
(bar):

2:03 PM Changeset in webkit [162957] by mmaxfield@apple.com

2 edits in trunk/Source/WebCore

Fixing several incorrect assumptions with handling isolated inlines.
https://bugs.webkit.org/show_bug.cgi?id=127608

Reviewed by Simon Fraser.

Fixing capitalization.

rendering/RenderBlockLineLayout.cpp:

(WebCore::setUpResolverToResumeInIsolate):
(WebCore::constructBidiRunsForSegment):

1:53 PM Changeset in webkit [162956] by mmaxfield@apple.com

5 edits
4 adds in trunk

Fixing several incorrect assumptions with handling isolated inlines.
https://bugs.webkit.org/show_bug.cgi?id=127608

Reviewed by Dave Hyatt.

Source/WebCore:

First, when an isolated inline spans multiple lines, we aren't guaranteed
to exit BidiResolver with a nested inline count of zero. Removing the
assert that says otherwise.

Previously in constructBidiRunsForSegment, we called bidiFirst in
an attempt to properly setup the isolatedResolver for any dom/style
that applied, but this only worked on the first line the isolated
inline appeared in. Adding a function that approaches this properly
by recursing through the parents of the starting object for the line
and post-fixing direction attributes to the resolver.

Finally, addressing an issue where the line following a removed isolated
inline (with a continuation) failed to be marked dirty.

Merged from Blink: https://chromium.googlesource.com/chromium/blink/+/72698f203b1c50900e535b80945563b92b7eef23

Tests: fast/text/nested-bidi-assert.html

fast/text/nested-bidi-with-continuation-crash.html

platform/text/BidiResolver.h:

(WebCore::Run>::~BidiResolver):

rendering/RenderBlockLineLayout.cpp:

(WebCore::setupResolverToResumeInIsolate):
(WebCore::constructBidiRunsForSegment):

rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):

LayoutTests:

See file-specific info.

Merged from Blink: https://chromium.googlesource.com/chromium/blink/+/72698f203b1c50900e535b80945563b92b7eef23

fast/text/nested-bidi-assert-expected.txt: Added.
fast/text/nested-bidi-assert.html: Added. Tests that no crash occurs

when an isolated inline spans several lines

fast/text/nested-bidi-with-continuation-crash-expected.txt: Added.
fast/text/nested-bidi-with-continuation-crash.html: Added. Tests that

no crash occurs when additional isolates need to be set up for a
continuation

1:42 PM Changeset in webkit [162955] by fpizlo@apple.com

2 edits in branches/jsCStack/Source/JavaScriptCore

FTL should really, *really* support NotCellUse
https://bugs.webkit.org/show_bug.cgi?id=127790

Reviewed by Mark Hahnenberg.

It's easy to forget about Phantoms. Any use kind that appears in any node can
eventually appear in a Phantom. This was covered by Octane/mandreel.

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::speculateNotCell):

1:37 PM Changeset in webkit [162954] by Antti Koivisto

3 edits in trunk/LayoutTests

Rebase fast/repaint/background-shorthand-with-gradient-and-height-changes.html after https://trac.webkit.org/r162947

fast/repaint/background-shorthand-with-gradient-and-height-changes-expected.txt:
fast/repaint/background-shorthand-with-gradient-and-height-changes.html:

1:31 PM Changeset in webkit [162953] by fpizlo@apple.com

2 edits
1 add in branches/jsCStack/Source/JavaScriptCore

FTL should really support NotCellUse
https://bugs.webkit.org/show_bug.cgi?id=127789

Reviewed by Mark Hahnenberg.

This is for ValueToInt32(NotCell:). That support was added ages ago, and it even
works as demonstrated by the new test case.

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

tests/stress/not-cell-use.js: Added.

(foo):
(bar):

1:26 PM Changeset in webkit [162952] by Antti Koivisto

27 edits in trunk/LayoutTests

Rebaseline some repaint test results after https://trac.webkit.org/r162947

There are less repaint rects.

compositing/repaint/resize-repaint-expected.txt:
fast/box-shadow/shadow-repaint-expected.txt:
fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt:
fast/css-grid-layout/grid-element-change-rows-repaint-expected.txt:
fast/css-grid-layout/grid-item-change-column-repaint-expected.txt:
fast/css-grid-layout/grid-item-change-row-repaint-expected.txt:
fast/regions/repaint/element-in-named-flow-absolute-from-fixed-expected.txt:
fast/regions/repaint/element-in-named-flow-fixed-from-absolute-expected.txt:
fast/regions/repaint/element-inflow-fixed-from-outflow-static-expected.txt:
fast/regions/repaint/element-outflow-static-from-inflow-fixed-expected.txt:
fast/regions/repaint/invalid-region-repaint-crash-expected.txt:
fast/regions/repaint/repaint-element-inside-relative-region-expected.txt:
fast/regions/repaint/repaint-regions-overflow-expected.txt:
fast/repaint/horizontal-bt-overflow-child-expected.txt:
fast/repaint/horizontal-bt-overflow-parent-expected.txt:
fast/repaint/horizontal-bt-overflow-same-expected.txt:
fast/repaint/negative-text-indent-with-overflow-hidden-expected.txt:
fast/repaint/overflow-flipped-writing-mode-table-expected.txt:
fast/repaint/reflection-table-layout-expected.txt:
fast/repaint/transform-table-layout-expected.txt:
fast/repaint/vertical-overflow-child-expected.txt:
fast/repaint/vertical-overflow-parent-expected.txt:
fast/repaint/vertical-overflow-same-expected.txt:
platform/mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
platform/mac/fast/images/repaint-subrect-grid-expected.txt:
svg/repaint/repaint-webkit-svg-shadow-container-expected.txt:

1:15 PM Changeset in webkit [162951] by andersca@apple.com

7 edits
2 adds in trunk/Source/WebKit2

Add a NavigationActionData object for easy storage of navigation action data
https://bugs.webkit.org/show_bug.cgi?id=127787

Reviewed by Tim Horton.

Scripts/webkit2/messages.py:

(struct_or_class):

Shared/NavigationActionData.cpp: Added.

(WebKit::NavigationActionData::NavigationActionData):
(WebKit::NavigationActionData::encode):
(WebKit::NavigationActionData::decode):

Shared/NavigationActionData.h: Added.
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebKit2.xcodeproj/project.pbxproj:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

12:49 PM Changeset in webkit [162950] by timothy_horton@apple.com

3 edits in trunk/Source/WebKit2

Fix the Mountain Lion build.

UIProcess/mac/ViewGestureController.mm:

(WebKit::ViewGestureController::beginSwipeGesture):
(WebKit::ViewGestureController::removeSwipeSnapshot):

UIProcess/mac/ViewSnapshotStore.mm:

(WebKit::ViewSnapshotStore::recordSnapshot):

12:25 PM Changeset in webkit [162949] by timothy_horton@apple.com

4 edits in trunk/Source/WebKit2

Fix the iOS build.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::recordNavigationSnapshot):

UIProcess/mac/ViewSnapshotStore.h:
UIProcess/mac/ViewSnapshotStore.mm:

12:01 PM Changeset in webkit [162948] by beidson@apple.com

3 edits in trunk/Source/WebKit2

Remove unneeded “WebCore::” prefixing in two .cpp files.

Rubberstamped by Alexey Proskuryakov.

DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

11:40 AM Changeset in webkit [162947] by Antti Koivisto

5 edits in trunk/Source/WebCore

REGRESSION(r162837): 5% regression on html5-full-render and 3% regression in DoYouEvenBench
https://bugs.webkit.org/show_bug.cgi?id=127722

Reviewed by Darin Adler.

Accumulate repaint region in RendeView instead of flushing rects directly to the system.

dom/Document.cpp:

(WebCore::Document::recalcStyle):
(WebCore::Document::updateLayout):
(WebCore::Document::topDocument):

Make less silly.

page/FrameView.cpp:

(WebCore::FrameView::layout):

rendering/RenderView.cpp:

(WebCore::RenderView::repaintViewRectangle):
(WebCore::RenderView::flushAccumulatedRepaintRegion):
(WebCore::RenderView::RepaintRegionAccumulator::RepaintRegionAccumulator):
(WebCore::RenderView::RepaintRegionAccumulator::~RepaintRegionAccumulator):

rendering/RenderView.h:

11:33 AM Changeset in webkit [162946] by timothy_horton@apple.com

4 edits in trunk/Source/WebKit2

WebKit2 View Gestures (Swipe): Snapshots should be purgeable
https://bugs.webkit.org/show_bug.cgi?id=127390
<rdar://problem/15876775>

Reviewed by Anders Carlsson.

Make snapshots be purgeable, and implement a straightforward
(if perhaps expensive, for now) cache eviction strategy to limit the
number of snapshots to 20.

UIProcess/mac/ViewGestureController.mm:

(WebKit::ViewGestureController::beginSwipeGesture):
When beginning a gesture, attempt to make the retrieved snapshot
non-volatile. If it was purged while volatile, we won't use it, but if it
is still valid, we'll go ahead and use it as the swipe layer's contents.

(WebKit::ViewGestureController::removeSwipeSnapshot):
When removing the swipe snapshot, make it volatile once again.

UIProcess/mac/ViewSnapshotStore.h:

Store a creation time along with the image.
Store and return IOSurfaces instead of CGImages.
Store snapshots and render tree sizes separately, so that we can
throw away snapshots but keep the render tree sizes indefinitely.

UIProcess/mac/ViewSnapshotStore.mm:

(WebKit::ViewSnapshotStore::pruneSnapshots):
Cap the number of snapshots we'll ever have live at 20.
Enforce this cap by first trying to remove snapshots farthest
from the current back-forward list's current item, falling back
to removing the least recently created snapshot if there are no
snapshots owned by the current back-forward list.

(WebKit::createIOSurfaceFromImage):
Build an IOSurface from the CGImage snapshot we took, for ease of
use of its purgeability API.

(WebKit::ViewSnapshotStore::recordSnapshot):
Bail from taking the snapshot if the image is empty; this can happen
if the view is out of the window when the snapshot is taken.

Mark snapshots as purgeable as soon as they go into the cache.

(WebKit::ViewSnapshotStore::snapshotAndRenderTreeSize):
Return the target render tree size even if there is no snapshot image.
Take care not to look up an empty UUID.

11:26 AM Changeset in webkit [162945] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

HTMLMediaElement::m_platformLayerBorrowed is uninitialized.
https://bugs.webkit.org/show_bug.cgi?id=127759

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-01-28
Reviewed by Eric Carlson.

Initalize m_platformLayerBorrowed to false.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):

10:22 AM Changeset in webkit [162944] by jer.noble@apple.com

3 edits in trunk/Source/WebCore

[Mac] Use explicit, rather than canonical, AudioFormatFlags and types.
https://bugs.webkit.org/show_bug.cgi?id=127781

Reviewed by Eric Carlson.

Since every mac platform uses Float32 audio samples, use these types explicitly
rather than the implicit, canonical AudioSampleType type. Once we're using Float32
explicity, we can also use the explicit kAudioFormatFlagsNativeFloatPacked flag
rather than the canonical version.

platform/audio/mac/AudioDestinationMac.cpp:

(WebCore::AudioDestinationMac::configure):

platform/audio/mac/AudioFileReaderMac.cpp:

(WebCore::AudioFileReader::createBus):

10:18 AM Changeset in webkit [162943] by ap@apple.com

18 edits in trunk/Source

Expose SQL database creation and modification times
https://bugs.webkit.org/show_bug.cgi?id=127728

Reviewed by Brady Eidson.

Source/WebCore:

platform/FileSystem.h:
platform/posix/FileSystemPOSIX.cpp:

(WebCore::getFileCreationTime):

platform/win/FileSystemWin.cpp:

(WebCore::getFileCreationTimeFromFindData):
(WebCore::getFileCreationTime):
Added functions to get file creation times. Not all OSes support that, but Darwin
and Windows do, as (I think) various BSD flavors.

platform/gtk/FileSystemGtk.cpp: Added a stub for getFileCreationTime().

platform/sql/SQLiteFileSystem.h:
platform/sql/SQLiteFileSystem.cpp:

(WebCore::SQLiteFileSystem::databaseCreationTime):
(WebCore::SQLiteFileSystem::databaseModificationTime):
Expose it in the same strange manner other database file operations are.

Modules/webdatabase/DatabaseDetails.h:

(WebCore::DatabaseDetails::DatabaseDetails):
(WebCore::DatabaseDetails::creationTime):
(WebCore::DatabaseDetails::modificationTime):
Added creation and modification times to DatabaseDetails.

Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::ProposedDatabase::ProposedDatabase):
(WebCore::DatabaseManager::openDatabaseBackend):
ProposedDatabase is an unfortunate mechanism for communicating quota errors to the
client, we should really straighten it up. But for now, just leave the times uninitialized.

Modules/webdatabase/DatabaseBackendBase.cpp: (WebCore::DatabaseBackendBase::details):

This code path is for handling quota errors, so there is no need to initialize most
of DatabaseDetails here as well.

Modules/webdatabase/DatabaseTracker.cpp: (WebCore::DatabaseTracker::detailsForNameAndOrigin):
Modules/webdatabase/DatabaseTracker.h:

Fill in database file times. Inlined and removed usageForDatabase function to
avoid rebuilding the path multiple times.

Source/WebKit2:

Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<DatabaseDetails>::encode):
(IPC::ArgumentCoder<DatabaseDetails>::decode):
Encode and decode new DatabaseDetails member variables.

UIProcess/API/C/WKDatabaseManager.cpp:

(WKDatabaseManagerGetDatabaseDetailsCreationTimeKey):
(WKDatabaseManagerGetDatabaseDetailsModificationTimeKey):

UIProcess/API/C/WKDatabaseManager.h:

Added new keys for database details.

UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::databaseDetailsCreationTimeKey):
(WebKit::WebDatabaseManagerProxy::databaseDetailsModificationTimeKey):
(WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):

UIProcess/WebDatabaseManagerProxy.h:

Set the new keys if times are valid.

9:55 AM Changeset in webkit [162942] by Michał Pakuła vel Rutka

2 edits in trunk/LayoutTests

Unreviewed EFL gardening

Skip crashing http tests.

platform/efl-wk2/TestExpectations:

9:49 AM Changeset in webkit [162941] by jer.noble@apple.com

6 edits in trunk

Setting muted attribute on <video> element is not reflected in controls
https://bugs.webkit.org/show_bug.cgi?id=127726

Reviewed by Eric Carlson.

Source/WebCore:

If the 'muted' IDL attribute is queried after the 'muted' and 'src' content attributes are
set but before loading begins, it will return 'false' until loading begins, but with no
way to query whether that value is valid, nor firing a volumechange event when its value
changes.

The HTML spec says that the 'muted' content attribute controls whether audio output is
muted "when the media element is created", not when loading begins, but we don't
necessarily have a signal that the element is fully parsed. Additionally, this means its
impossible to make an element via script and get this behavior.

So the new behavior is that the 'muted' IDL attribute will always reflect the 'muted'
content attribute up until one of the following three conditions:

The 'muted' IDL attribute is set via script.
The element is inserted in the document.
The element begins loading.

After the first one of the above conditions, the 'muted' IDL attribute will no longer
change when the 'muted' content attribute changes.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::parseAttribute):

html/HTMLMediaElement.h:

LayoutTests:

media/video-defaultmuted-expected.txt:
media/video-defaultmuted.html:

9:43 AM Changeset in webkit [162940] by mark.lam@apple.com

15 edits
2 adds in trunk

Jettison DFG code when neither breakpoints or the profiler are active.
<https://webkit.org/b/127766>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

We need to jettison the DFG CodeBlocks under the following circumstances:

When adding breakpoints to a CodeBlock, jettison it if it is a DFG CodeBlock.
When enabling stepping mode in a CodeBlock, jettison it if it a DFG CodeBlock.
When settign the enabled profiler in the VM, we need to jettison all DFG CodeBlocks.

Instead of emitting speculation checks, the DFG code will now treat Breakpoint,
ProfileWillCall, and ProfileDidCall as no-ops similar to a Phantom node. We
still need to track these nodes so that they match the corresponding opcodes
in the baseline JIT when we jettison and OSR exit. Without them, we would OSR
exit to the wrong location in the baseline JIT code.

In DFGDriver's compileImpl() and DFGPlan's finalizeWithoutNotifyingCallback()
we fail the compilation effort with a CompilationInvalidated result. This allows
the DFG compiler to re-attampt the compilation of the function after some time
if it is hot. The CompilationInvalidated result is supposed to cause the DFG
to exercise an exponential back off before re-attempting compilation again
(see runtime/CompilationResult.h).

This patch improves the Octane score from ~2950 to ~3067.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::addBreakpoint):
(JSC::CodeBlock::setSteppingMode):

bytecode/CodeBlock.h:
debugger/Debugger.h:
dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):

dfg/DFGPlan.cpp:

(JSC::DFG::Plan::finalizeWithoutNotifyingCallback):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

profiler/LegacyProfiler.cpp:

(JSC::LegacyProfiler::startProfiling):
(JSC::LegacyProfiler::stopProfiling):

runtime/VM.cpp:

(JSC::VM::VM):
(JSC::SetEnabledProfilerFunctor::operator()):
(JSC::VM::setEnabledProfiler):

runtime/VM.h:

(JSC::VM::enabledProfiler):

LayoutTests:

Added a test to exercise setting a breakpoint in 2 DFG compiled functions:
1 not inlined, and 1 inlined.

inspector-protocol/debugger/resources/breakpoint.js:

(notInlineable):
(inlineable):
(notInliningFoo):
(inliningFoo):
(dfgWithoutInline):
(dfgWithInline):

inspector-protocol/debugger/setBreakpoint-dfg-expected.txt: Added.
inspector-protocol/debugger/setBreakpoint-dfg.html: Added.

9:38 AM Changeset in webkit [162939] by andersca@apple.com

3 edits in trunk/Source/WTF

Actually turn stack stats back off.

wtf/StackStats.cpp:
wtf/StackStats.h:

9:36 AM Changeset in webkit [162938] by andersca@apple.com

2 edits in trunk/Source/WTF

Turn stack stats back off.

wtf/StackStats.cpp:

9:28 AM Changeset in webkit [162937] by andersca@apple.com

8 edits
2 adds in trunk/Source/WebCore

Add stubbed out VisitedLinkProvider class
https://bugs.webkit.org/show_bug.cgi?id=127744

Reviewed by Andreas Kling.

This is a first step towards moving responsibility of visited links from
the page group to a separate object.

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
page/PageGroup.cpp:

(WebCore::PageGroup::PageGroup):

page/PageGroup.h:

(WebCore::PageGroup::visitedLinkProvider):

page/VisitedLinkProvider.cpp: Added.

(WebCore::VisitedLinkProvider::VisitedLinkProvider):
(WebCore::VisitedLinkProvider::~VisitedLinkProvider):

page/VisitedLinkProvider.h: Added.

(WebCore::VisitedLinkProvider::create):

9:19 AM Changeset in webkit [162936] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

WebKit2 View Gestures (Swipe): Use CGSCaptureWindowsContentsToRect for now
https://bugs.webkit.org/show_bug.cgi?id=127768
<rdar://problem/15923662>

Reviewed by Simon Fraser.

UIProcess/API/mac/WKView.mm:

(-[WKView _takeViewSnapshot]):
Until <rdar://problem/15709646> is resolved, we'll use
CGSCaptureWindowsContentsToRect instead of CGWindowListCreateImage.

9:13 AM Changeset in webkit [162935] by andersca@apple.com

5 edits in trunk/Source/WTF

Use std::mutex instead of WTF::Mutex in WTF
https://bugs.webkit.org/show_bug.cgi?id=127783

Reviewed by Antti Koivisto.

wtf/CryptographicallyRandomNumber.cpp:
wtf/MainThread.cpp:

(WTF::mainThreadFunctionQueueMutex):
(WTF::functionQueue):
(WTF::dispatchFunctionsFromMainThread):
(WTF::callOnMainThread):
(WTF::cancelCallOnMainThread):

wtf/StackStats.cpp:

(WTF::StackStats::initialize):
(WTF::StackStats::CheckPoint::CheckPoint):
(WTF::StackStats::CheckPoint::~CheckPoint):
(WTF::StackStats::probe):
(WTF::StackStats::LayoutCheckPoint::LayoutCheckPoint):
(WTF::StackStats::LayoutCheckPoint::~LayoutCheckPoint):

wtf/StackStats.h:

9:07 AM Changeset in webkit [162934] by msaboff@apple.com

3 edits in branches/jsCStack/Source/JavaScriptCore

CStack Branch: Some LLInt symbols not declared extern "C"
https://bugs.webkit.org/show_bug.cgi?id=127782

Reviewed by Geoffrey Garen.

Added 'extern "C"' to the definitions of llint_throw_stack_overflow_error() and
llint_stack_check_at_vm_entry(). Added WTF_INTERNAL to their declarations.

JavaScriptCore.xcodeproj/project.pbxproj:
llint/LLIntSlowPaths.cpp:

(JSC::LLInt::llint_throw_stack_overflow_error):
(JSC::LLInt::llint_stack_check_at_vm_entry):

llint/LLIntSlowPaths.h:

8:34 AM Changeset in webkit [162933] by commit-queue@webkit.org

21 edits
2 copies
20 adds in trunk

Add support for menclose element
https://bugs.webkit.org/show_bug.cgi?id=85729

Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2014-01-28
Reviewed by Chris Fleizach.

Source/WebCore:

Added support for menclose element. MathML <menclose> element renders
its content inside an enclosing notation specified by the notation
attribute. The notation attribute can have values longdiv, box, left,
right, top, bottom , radical, madruwb, actuarial, roundedbox, circle,
updiagonalstrike, downdiagonalstrike, verticalstrike and
horizontalstrike.

Tests: mathml/presentation/menclose-add-children.html

mathml/presentation/menclose-notation-attribute-add.html
mathml/presentation/menclose-notation-attribute-change-value.html
mathml/presentation/menclose-notation-attribute-remove.html
mathml/presentation/menclose-notation-attribute-set1.html
mathml/presentation/menclose-notation-attribute-set2.html
mathml/presentation/menclose-notation-no-overlap.html
mathml/presentation/menclose-notation-radical.html
mathml/presentation/menclose-remove-children.html

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
css/mathml.css:

(mo, mrow, mfenced, mfrac, msub, msup, msubsup, mmultiscripts, mprescripts, none, munder, mover, munderover, msqrt, mroot, merror, mphantom, mstyle, menclose):
(math, mrow, mfenced, msqrt, mroot, merror, mphantom, mstyle, menclose):

mathml/MathMLAllInOne.cpp:
mathml/MathMLElement.h:
mathml/MathMLInlineContainerElement.cpp:
mathml/MathMLMencloseElement.cpp: Added.

(WebCore::MathMLMencloseElement::MathMLMencloseElement):
(WebCore::MathMLMencloseElement::create):
(WebCore::MathMLMencloseElement::createElementRenderer):
(WebCore::MathMLMencloseElement::isPresentationAttribute):
(WebCore::MathMLMencloseElement::finishParsingChildren):
(WebCore::MathMLMencloseElement::collectStyleForPresentationAttribute):
(WebCore::MathMLMencloseElement::longDivLeftPadding):

mathml/MathMLMencloseElement.h: Added.

(WebCore::toMathMLMencloseElement):

mathml/mathattrs.in:
mathml/mathtags.in:
rendering/mathml/RenderMathMLMenclose.cpp: Added.

(WebCore::RenderMathMLMenclose::RenderMathMLMenclose):
(WebCore::RenderMathMLMenclose::addChild):
(WebCore::RenderMathMLMenclose::computePreferredLogicalWidths):
(WebCore::RenderMathMLMenclose::updateLogicalHeight):
(WebCore::RenderMathMLMenclose::paint):
(WebCore::RenderMathMLMenclose::checkNotationalValuesValidity):

rendering/mathml/RenderMathMLMenclose.h: Added.
rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::RenderMathMLRoot):

rendering/mathml/RenderMathMLRoot.h:
rendering/mathml/RenderMathMLSquareRoot.cpp:

(WebCore::RenderMathMLSquareRoot::RenderMathMLSquareRoot):
(WebCore::RenderMathMLSquareRoot::createAnonymousWithParentRenderer):

rendering/mathml/RenderMathMLSquareRoot.h:

Added new file related to menclose element implementation. Menclose
element is created and while parsing its notation attribute based on
its values like top, left CSSBorder properties are applied and for
values like circle, verticalstrike, longidv its taken care in paint.
For radical value an anonymous RenderMathMLSquareRoot is created as
a child of menclose.

LayoutTests:

mathml/presentation/inferred-mrow-baseline-expected.txt:
mathml/presentation/inferred-mrow-baseline.html:
mathml/presentation/inferred-mrow-stretchy-expected.txt:
mathml/presentation/inferred-mrow-stretchy.html:

Rebaselining existing tests as per the new behavior.

mathml/presentation/menclose-add-children-expected.html: Added.
mathml/presentation/menclose-add-children.html: Added.
mathml/presentation/menclose-notation-attribute-add-expected.html: Added.
mathml/presentation/menclose-notation-attribute-add.html: Added.
mathml/presentation/menclose-notation-attribute-change-value-expected.html: Added.
mathml/presentation/menclose-notation-attribute-change-value.html: Added.
mathml/presentation/menclose-notation-attribute-remove-expected.html: Added.
mathml/presentation/menclose-notation-attribute-remove.html: Added.
mathml/presentation/menclose-notation-attribute-set1-expected.txt: Added.
mathml/presentation/menclose-notation-attribute-set1.html: Added.
mathml/presentation/menclose-notation-attribute-set2-expected-mismatch.html: Added.
mathml/presentation/menclose-notation-attribute-set2.html: Added.
mathml/presentation/menclose-notation-no-overlap-expected.txt: Added.
mathml/presentation/menclose-notation-no-overlap.html: Added.
mathml/presentation/menclose-notation-radical-expected.html: Added.
mathml/presentation/menclose-notation-radical.html: Added.
mathml/presentation/menclose-remove-children-expected.html: Added.
mathml/presentation/menclose-remove-children.html: Added.

Added new test cases for verifying the behaviour of menclose element
with different values of notation attribute and removing/changing/adding
notation attribute.

8:29 AM Changeset in webkit [162932] by k.czech@samsung.com

2 edits in trunk/Source/WebCore

[ATK] accessibility/range-alter-by-percent.html is failing after r162587.
https://bugs.webkit.org/show_bug.cgi?id=127774

Reviewed by Mario Sanchez Prada.

Implicit value of step in range type elements should be one or larger.

No new tests. Covered by exiting one.

accessibility/atk/WebKitAccessibleInterfaceValue.cpp:

(webkitAccessibleValueGetMinimumIncrement):

7:40 AM Changeset in webkit [162931] by commit-queue@webkit.org

3 edits in trunk/Source/WebInspectorUI

Web Inspector: In a DataGrid, store value of columnIdentifier to DOM node representing a cell
https://bugs.webkit.org/show_bug.cgi?id=127613

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-01-28
Reviewed by Timothy Hatcher.

UserInterface/DOMStorageContentView.js:

(WebInspector.DOMStorageContentView.prototype._editingCallback):

UserInterface/DataGrid.js:

(WebInspector.DataGrid):
(WebInspector.DataGrid.prototype._keyDown):
(WebInspector.DataGrid.prototype._contextMenuInDataTable):
(WebInspector.DataGridNode.prototype.createCell):

7:08 AM Changeset in webkit [162930] by zandobersek@gmail.com

2 edits in trunk/Source/WebKit/efl

Remove unnecessary forward declarations of MessagePortChannel, MessagePortChannelArray in DumpRenderTreeSupportEfl.h
https://bugs.webkit.org/show_bug.cgi?id=127654

Reviewed by Alexey Proskuryakov.

WebCoreSupport/DumpRenderTreeSupportEfl.h: Remove the forward declarations of MessagePortChannel

and MessagePortChannelArray. They were most likely at one point used in DRT support methods, but are
not necessary anymore.

2:40 AM Changeset in webkit [162929] by mrowe@apple.com

10 edits in trunk/Source

<https://webkit.org/b/127767> Disable some deprecation warnings to fix the build.

Reviewed by Ryosuke Niwa.

Source/WebCore:

accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper renderWidgetChildren]):

platform/audio/mac/AudioDestinationMac.cpp:

(WebCore::AudioDestinationMac::configure):

platform/audio/mac/AudioFileReaderMac.cpp:

(WebCore::AudioFileReader::createBus):

Source/WebKit/mac:

WebCoreSupport/PopupMenuMac.mm:

(PopupMenuMac::populate):

Source/WebKit2:

UIProcess/API/mac/WKView.mm:

(-[WKView _updateWindowAndViewFrames]):

WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:

2:22 AM Changeset in webkit [162928] by commit-queue@webkit.org

9 edits
1 add in trunk

[GTK] Add API to allow setting the process model in WebKitWebContext
https://bugs.webkit.org/show_bug.cgi?id=125463

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2014-01-28
Reviewed by Carlos Garcia Campos.

Implements accessors in WebKitWebContext for the process model.
The default behavior is unchanged, and a single web process is
used. Using WEBKIT_PROCESS_MODEL_ONE_SECONDARY_PROCESS_PER_WEB_VIEW
as the process model will make use one web process for each
WebKitWebView. This also enables the network process. Setting
the process model must be done as early as possible, before the
very first web process is spawned.

Source/WebKit2:

UIProcess/API/gtk/WebKitWebContext.cpp:

Add accessors in the API to get/set the process model.
(webkit_web_context_set_process_model):
(webkit_web_context_get_process_model):

UIProcess/API/gtk/WebKitWebContext.h:

Define the WebKitProcessModel enum.

UIProcess/API/gtk/docs/webkit2gtk-sections.txt:

Add new public API bits to the documentation.

Tools:

MiniBrowser/gtk/main.c:

(main):
Enable multiple process mode if the MINIBROWSER_MULTIPROCESS
environment variable is defined and not empty.

TestWebKitAPI/GNUmakefile.am:

Add new TestMultiprocess test case.

TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:

Add new TestMultiprocess test case.

TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp: Added.

(loadChanged):
(testMultipleSecondaryProcesses):
(initializeWebExtensions):
(beforeAll):
(afterAll):

TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:

(methodCallCallback):
Implement the GetProcessIdentifier D-Bus method.
(makeBusName):
Choose a different bus name when the web extension is used
from TestMultiprocess.
(webkit_web_extension_initialize_with_user_data):
Use makeBusName() to choose the bus name.

2:02 AM Changeset in webkit [162927] by bshafiei@apple.com

3 edits in tags/Safari-538.14/Source/WebCore

Merged r162885.

1:56 AM Changeset in webkit [162926] by bshafiei@apple.com

18 edits in tags/Safari-538.14

Merged r162881.

1:38 AM Changeset in webkit [162925] by bshafiei@apple.com

2 edits in tags/Safari-538.14/Source/WebCore

Merged r162872.

1:21 AM Changeset in webkit [162924] by bshafiei@apple.com

5 edits in trunk/Source

Versioning.

1:15 AM Changeset in webkit [162923] by bshafiei@apple.com

1 copy in tags/Safari-538.14

New tag.

1:08 AM Changeset in webkit [162922] by Carlos Garcia Campos

14 edits
1 add
2 deletes in trunk

[SOUP] Remove soupURIToKURL
https://bugs.webkit.org/show_bug.cgi?id=127104

Reviewed by Martin Robinson.

Source/WebCore:

In favor of a URL constructor receiving a SoupURI. Also add a
method to URL to create a soupURI.

GNUmakefile.list.am: Remove SoupURIUtils and add URLSoup.
PlatformEfl.cmake: Ditto.
PlatformGTK.cmake: Ditto.
platform/URL.h: Add URL constructor receiving a SoupURI and

createSoupURI() to create a new soupURI for the URL.

platform/network/soup/CookieJarSoup.cpp:

(WebCore::setCookiesFromDOM): Use URL::createSoupURI().
(WebCore::cookiesForSession): Ditto.
(WebCore::getRawCookies): Ditto.
(WebCore::deleteCookie): Ditto.

platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::doRedirect): Use the new URL constructor instead of
soupURIToKURL.
(WebCore::createSoupRequestAndMessageForHandle): Use URL::createSoupURI().

platform/network/soup/ResourceRequest.h: Rename soupURI as

createSoupURI to make it clear that the method returns a newly
created SoupURI.

platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateSoupMessageMembers): Use URL::createSoupURI().
(WebCore::ResourceRequest::updateSoupMessage): Ditto.
(WebCore::ResourceRequest::updateFromSoupMessage): Use the new URL
constructor instead of soupURIToKURL.
(WebCore::ResourceRequest::createSoupURI): Use URL::createSoupURI().

platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::updateFromSoupMessage): Use the new
URL constructor instead of soupURIToKURL.

platform/network/soup/SoupURIUtils.cpp: Removed.
platform/network/soup/SoupURIUtils.h: Removed.
platform/soup/URLSoup.cpp: Added.

(WebCore::URL::URL):
(WebCore::URL::createSoupURI):

Tools:

TestWebKitAPI/GNUmakefile.am: Add soup cppflags to WebCore unit

tests, because URL.h now includes GUniquePtrSoup.h.

TestWebKitAPI/CMakeLists.txt: Ditto.
WebKitTestRunner/PlatformEfl.cmake: Add soup cppflags to WTR,

because URL.h now includes GUniquePtrSoup.h.

12:15 AM Changeset in webkit [162921] by Carlos Garcia Campos

2 edits in trunk/Source/WebCore

[GTK] Avoid unnecessary string duplications in FileSystemGtk
https://bugs.webkit.org/show_bug.cgi?id=127469

Reviewed by Martin Robinson.

We are using fileSystemRepresentation() everywhere internally
which returns a CString that always duplicates the string.
Add unescapedFilename() internal helper function that returns a
GUniquePtr and used it everywhere instead of fileSystemRepresentation().

platform/gtk/FileSystemGtk.cpp:

(WebCore::unescapedFilename):
(WebCore::fileSystemRepresentation):
(WebCore::filenameForDisplay):
(WebCore::fileExists):
(WebCore::deleteFile):
(WebCore::deleteEmptyDirectory):
(WebCore::getFileStat):
(WebCore::getFileSize):
(WebCore::getFileModificationTime):
(WebCore::getFileMetadata):
(WebCore::pathByAppendingComponent):
(WebCore::makeAllDirectories):
(WebCore::pathGetFileName):
(WebCore::directoryName):
(WebCore::listDirectory):
(WebCore::openFile):

Jan 27, 2014:

11:52 PM Changeset in webkit [162920] by Carlos Garcia Campos

26 edits in trunk

[GTK] Make webkit_uri_scheme_request_get_web_view() work with CustomProtocols
https://bugs.webkit.org/show_bug.cgi?id=127614

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Add API to set the page identifier that initiated the request to
ResourceRequest, and remove the initiatingPageID() method from the
NetworkingContext class.

platform/network/NetworkingContext.h:
platform/network/ResourceHandle.h:
platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::createSoupRequestAndMessageForHandle):

platform/network/soup/ResourceRequest.h:

(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::initiatingPageID):
(WebCore::ResourceRequest::setInitiatingPageID):

platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateSoupRequest):
(WebCore::ResourceRequest::updateFromSoupRequest):

Source/WebKit/efl:

Remove initiatingPageID() method form the FrameNetworkingContext.

WebCoreSupport/FrameNetworkingContextEfl.cpp:
WebCoreSupport/FrameNetworkingContextEfl.h:

Source/WebKit/gtk:

Remove initiatingPageID() method from FrameNetworkingContext.

WebCoreSupport/FrameNetworkingContextGtk.cpp:
WebCoreSupport/FrameNetworkingContextGtk.h:

Source/WebKit2:

NetworkProcess/RemoteNetworkingContext.h: Remove

initiatingPageID() method.

NetworkProcess/soup/RemoteNetworkingContextSoup.cpp: Ditto.
Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.cpp:

(WebKit::CustomProtocolManagerImpl::send): Create the request with
the ResourceRequest constructor that receives a SoupRequest.

Shared/soup/WebCoreArgumentCodersSoup.cpp:

(IPC::ArgumentCoder<ResourceRequest>::encodePlatformData): Encode initiatingPageID.
(IPC::ArgumentCoder<ResourceRequest>::decodePlatformData): Decode initiatingPageID.

UIProcess/API/gtk/WebKitURISchemeRequest.cpp:

(webkitURISchemeRequestCreate): Remove initiatingPageID parameter
and get it from the given ResourceRequest.

UIProcess/API/gtk/WebKitURISchemeRequestPrivate.h:
UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextStartLoadingCustomProtocol): Update to
webkitURISchemeRequestCreate API change.

WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:

(willSendRequestForFrame): Set the initiatingPageID to the ResourceRequest.

WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:

(WebKit::WebFrameNetworkingContext::WebFrameNetworkingContext):
Remove initiatingPageID() method.

WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
WebProcess/soup/WebSoupRequestManager.cpp:

(WebKit::WebSoupRequestManager::send): Get the initiatingPageID
from the SoupRequest using the ResourceRequest API.

Tools:

TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Bring

back the custom URI scheme WebView check.

11:43 PM Changeset in webkit [162919] by ryuan.choi@samsung.com

3 edits in trunk/Source/WebKit/efl

[EFL][WK1] Remove ewk_history_item_time_last_visited_get and ewk_history_item_visit_count
https://bugs.webkit.org/show_bug.cgi?id=127662

Reviewed by Gyuyoung Kim.

These APIs are exposing WebCore's internal structure, but they removed
from WebCore since 162808.

This patch removed not to support them because applications can do it
if they want.

ewk/ewk_history.cpp:
ewk/ewk_history.h:

11:29 PM Changeset in webkit [162918] by Joseph Pecoraro

11 edits in trunk/Source/JavaScriptCore

-[JSContext evaluteScript:] calls JSEvaluteScript with startingLineNumber 0, later interpreted as a oneBasedInt
https://bugs.webkit.org/show_bug.cgi?id=127648

Reviewed by Geoffrey Garen.

The actual bug being fixed here is that the line number for
scripts evaluated via the JSC APIs is now sane. However,
there is no good infrastructure in place right now to test that.

API/tests/testapi.c:

(main):

API/tests/testapi.mm:

(testObjectiveCAPI):
Add tests for exception line numbers and handling of bad
startingLineNumbers in public APIs. These tests were already
passing, I just add them to make sure they are not regressed
in the future.

API/JSBase.cpp:

(JSEvaluateScript):
(JSCheckScriptSyntax):

API/JSBase.h:
API/JSObjectRef.cpp:

(JSObjectMakeFunction):

API/JSObjectRef.h:
API/JSScriptRef.cpp:
API/JSScriptRefPrivate.h:
API/JSStringRef.h:
Clarify documentation that startingLineNumber is 1 based and clamped.
Add clamping in the implementation to put sane values into JSC::SourceProvider.

inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::didParseSource):
Remove the FIXME now that the SourceProvider is giving us expected values.

11:25 PM Changeset in webkit [162917] by timothy_horton@apple.com

3 edits in trunk/Tools

Revert yet one more tiny part of r162629 that didn't get reverted in r162883

WebKitTestRunner/TestController.cpp:

(WTR::TestController::pluginLoadPolicy):

WebKitTestRunner/TestController.h:

11:20 PM Changeset in webkit [162916] by timothy_horton@apple.com

2 edits in trunk/Tools

Revert one more tiny part of r162629 that didn't get reverted in r162883.

... which was also causing test failures!

WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):

11:16 PM Changeset in webkit [162915] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

Lots of varied and random crashes on the scrolling thread (ScrollbarPainters are going away)
https://bugs.webkit.org/show_bug.cgi?id=127734
<rdar://problem/15906263>

Reviewed by Simon Fraser.

page/scrolling/ScrollingStateScrollingNode.h:

Retain the ScrollbarPainters in the scrolling state tree.

9:29 PM Changeset in webkit [162914] by mhahnenberg@apple.com

211 edits
5 adds in branches/jsCStack

Merge branch up to ToT r162909.

9:19 PM Changeset in webkit [162913] by Joseph Pecoraro

4 edits in trunk/Source

Unreviewed iOS build fix. FALLTHROUGHs for iOS.

Source/WebCore:

accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityTraits]):
(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):

Source/WebKit/ios:

Misc/WebNSStringDrawing.mm:

(needsBidiLayout):

9:09 PM Changeset in webkit [162912] by roger_fong@apple.com

6 edits in trunk/Source

WebGLLoadPolicy::WebGLAsk is an unnecessary value.
https://bugs.webkit.org/show_bug.cgi?id=127755

Reviewed by Anders Carlsson.

UIProcess/API/C/WKAPICast.h:

(WebKit::toWebGLLoadPolicy):

UIProcess/API/C/WKPageLoaderClient.h:
html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext):

loader/FrameLoaderTypes.h:

9:03 PM Changeset in webkit [162911] by beidson@apple.com

15 edits in trunk/Source

IDB: Cursor support - Messaging, IPC, Threading plumbing
https://bugs.webkit.org/show_bug.cgi?id=127736

Reviewed by Sam Weinig.

Source/WebCore:

Modules/indexeddb/IDBCursorBackendOperations.h:

(WebCore::CursorIterationOperation::cursorID):
(WebCore::CursorAdvanceOperation::cursorID):

Modules/indexeddb/IDBTransactionBackendOperations.h:

(WebCore::OpenCursorOperation::transactionID):

WebCore.exp.in:

Source/WebKit2:

Pipe three cursor-related calls to the DatabaseProcess, and handle messages
from the database process when it is done handling them:

WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::didOpenCursor):
(WebKit::WebIDBServerConnection::didAdvanceCursor):
(WebKit::WebIDBServerConnection::didIterateCursor):
(WebKit::WebIDBServerConnection::openCursor):
(WebKit::WebIDBServerConnection::cursorAdvance):
(WebKit::WebIDBServerConnection::cursorIterate):

WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in:

Pipe the calls through to the appropriate UniqueIDBDatabase:

DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

(WebKit::DatabaseProcessIDBConnection::openCursor):
(WebKit::DatabaseProcessIDBConnection::cursorAdvance):
(WebKit::DatabaseProcessIDBConnection::cursorIterate):

DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:

Pass the calls to the backing store thread, then message back to the WebProcess
when the requests are complete.

DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::openCursor):
(WebKit::UniqueIDBDatabase::cursorAdvance):
(WebKit::UniqueIDBDatabase::cursorIterate):
(WebKit::UniqueIDBDatabase::openCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didOpenCursorInBackingStore):
(WebKit::UniqueIDBDatabase::advanceCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didAdvanceCursorInBackingStore):
(WebKit::UniqueIDBDatabase::iterateCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didIterateCursorInBackingStore):

DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:

Shared/WebCrossThreadCopier.cpp:

(WebCore::Vector<char>>::copy):

Shared/WebCrossThreadCopier.h:

8:55 PM Changeset in webkit [162910] by commit-queue@webkit.org

5 edits in trunk/Source/JavaScriptCore

Web Inspector: CRASH when debugger closes remote inspecting JSContext
https://bugs.webkit.org/show_bug.cgi?id=127738

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-27
Reviewed by Timothy Hatcher.

RemoteInspectorXPCConnection could be accessed in a background dispatch
queue, while being deallocated on the main thread when a connection
was suddenly terminated.

Make RemoteInspectorXPCConnection a ThreadSafeRefCounted object. Always
keep the connection object ref'd until the main thread calls close()
and removes its reference. At that point we can close the connection,
queue, and deref safely on the background queue.

inspector/remote/RemoteInspector.h:
inspector/remote/RemoteInspector.mm:

(Inspector::RemoteInspector::setupXPCConnectionIfNeeded):
(Inspector::RemoteInspector::xpcConnectionFailed):
For simplicity RemoteInspectorXPCConnections's don't have any threading
primatives to prevent client callbacks after they are closed. RemoteInspector
does, so it just ignores possible callbacks from connections it no longer
cares about.

inspector/remote/RemoteInspectorXPCConnection.h:
inspector/remote/RemoteInspectorXPCConnection.mm:

(Inspector::RemoteInspectorXPCConnection::RemoteInspectorXPCConnection):
(Inspector::RemoteInspectorXPCConnection::~RemoteInspectorXPCConnection):
(Inspector::RemoteInspectorXPCConnection::close):
Keep the connection alive as long as the queue it can be used on
is alive. Clean up everything on the queue when close() is called.

(Inspector::RemoteInspectorXPCConnection::handleEvent):
Checking if closed here is not thread safe so it is meaningless.
Remove the check.

(Inspector::RemoteInspectorXPCConnection::sendMessage):
Bail based on the m_closed state.

8:04 PM Changeset in webkit [162909] by Joseph Pecoraro

4 edits in trunk/Source/WebKit2

WebKit2: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
https://bugs.webkit.org/show_bug.cgi?id=127665

Reviewed by Anders Carlsson.

Shared/UserData.cpp:

(WebKit::UserData::encode):
These look like they should not have fallen through!

Configurations/Base.xcconfig:
Shared/mac/ObjCObjectGraphCoders.mm:

(WebKit::InjectedBundleObjCObjectGraphEncoderImpl::encode):

8:04 PM Changeset in webkit [162908] by Joseph Pecoraro

4 edits in trunk/Source/WebKit/mac

WebKit1: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
https://bugs.webkit.org/show_bug.cgi?id=127664

Reviewed by Darin Adler.

Configurations/Base.xcconfig:
History/BinaryPropertyList.cpp:

(BinaryPropertyListSerializer::appendObjectReference):
(BinaryPropertyListSerializer::startObject):
(BinaryPropertyListSerializer::addAggregateObjectReference):

WebView/WebPDFView.mm:

(-[WebPDFView PDFViewWillClickOnLink:withURL:]):

8:04 PM Changeset in webkit [162907] by Joseph Pecoraro

45 edits in trunk/Source

WebCore: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
https://bugs.webkit.org/show_bug.cgi?id=127671

Source/WebCore:

Reviewed by Ryosuke Niwa.

Configurations/Base.xcconfig:

Enable the warning.

css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):
Caught a bug. CSSPropertyWebkitAlt could fall through to CSSPropertyQuotes.

css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):
Caught a bug. CSSPropertyWebkitSvgShadow could fall through to CSSPropertyMaskType.

platform/Decimal.cpp:

(WebCore::Decimal::fromString):
Possible bug. Implementation doesn't seem to match its documentation.
Filed an issue to follow-up on this unclear function.

css/makeprop.pl:
css/makevalues.pl:
platform/ColorData.gperf:

Ignore implicit fallthrough warnings in generated code. gperf outputs
a "/*FALLTHROUGH*/" comment, but is not easily customizable to change
this output. Easiest to just ignore the warning for now.

rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::layout):
There has been a "fall through" comment immediately followed by a break
since its introduction in 2003. Removing the inaccurate comment.

accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::canHaveChildren):
(WebCore::AccessibilityNodeObject::visibleText):
(WebCore::AccessibilityNodeObject::title):

accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(-[WebAccessibilityObjectWrapperBase accessibilityDescription]):
(-[WebAccessibilityObjectWrapperBase accessibilityHelpText]):

bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::serialize):
(WebCore::CloneDeserializer::deserialize):

css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::realLex):

css/CSSSelector.cpp:

(WebCore::CSSSelector::extractPseudoType):
(WebCore::CSSSelector::selectorText):

css/StyleProperties.cpp:

(WebCore::StyleProperties::asText):

css/StyleSheetContents.cpp:

(WebCore::childRulesHaveFailedOrCanceledSubresources):

dom/Node.cpp:

(WebCore::appendTextContent):

html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processCharacterBuffer):
(WebCore::HTMLTreeBuilder::processEndOfFile):

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

page/EventSource.cpp:

(WebCore::EventSource::parseEventStream):

platform/DateComponents.cpp:

(WebCore::DateComponents::toStringForTime):

platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::updateStates):

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::platformInit):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::totalBytes):

platform/graphics/win/FullScreenController.cpp:

(FullScreenController::Private::fullscreenClientWndProc):

platform/text/BidiResolver.h:

(WebCore::Run>::updateStatusLastFromCurrentDirection):
(WebCore::Run>::createBidiRunsForLine):

platform/text/win/LocaleWin.cpp:

(WebCore::LocaleWin::initializeLocaleData):

rendering/PointerEventsHitRules.cpp:

(WebCore::PointerEventsHitRules::PointerEventsHitRules):

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::newLine):

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::updateLogicalWidthForAlignment):

rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalWidthUsing):

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateFillTileSize):

rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide):

rendering/RenderQuote.cpp:

(WebCore::RenderQuote::originalText):

rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::replacedContentRect):

rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild):

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setWordSpacing):

rendering/svg/RenderSVGResource.cpp:

(WebCore::requestPaintingResource):

rendering/svg/SVGMarkerData.h:

(WebCore::SVGMarkerData::updateMarkerDataForPathElement):

svg/SVGPathParser.cpp:

(WebCore::SVGPathParser::parsePathDataFromSource):

svg/SVGTransformDistance.cpp:

(WebCore::SVGTransformDistance::SVGTransformDistance):
(WebCore::SVGTransformDistance::scaledDistance):
(WebCore::SVGTransformDistance::addSVGTransforms):
(WebCore::SVGTransformDistance::addToSVGTransform):
(WebCore::SVGTransformDistance::distance):
Add annotation or break before falling into a default:break;

Source/WTF:

Reviewed by Ryosuke Niwa.

wtf/text/WTFString.h:

(WTF::appendNumber):

8:04 PM Changeset in webkit [162906] by Joseph Pecoraro

16 edits in trunk/Source/JavaScriptCore

JavaScriptCore: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
https://bugs.webkit.org/show_bug.cgi?id=127647

Reviewed by Anders Carlsson.

Explicitly annotate switch case fallthroughs in JavaScriptCore and
enable warnings for unannotated fallthroughs.

dfg/DFGArithMode.h:

(doesOverflow):
Only insert FALLTHROUGH in release builds. In debug builds, the
FALLTHROUGH would be unreachable (due to the ASSERT_NOT_REACHED)
and would through a warning.

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt52):
Due to the templatized nature of this function, a fallthrough
in one of the template expansions would be unreachable. Disable
the warning for this function.

Configurations/Base.xcconfig:
bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):

dfg/DFGValidate.cpp:

(JSC::DFG::Validate::validateCPS):

parser/Lexer.cpp:

(JSC::Lexer<T>::lex):

parser/Parser.cpp:

(JSC::Parser<LexerType>::parseStatement):
(JSC::Parser<LexerType>::parseProperty):

runtime/JSArray.cpp:

(JSC::JSArray::push):

runtime/JSONObject.cpp:

(JSC::Walker::walk):

runtime/JSObject.cpp:

(JSC::JSObject::putByIndex):
(JSC::JSObject::putByIndexBeyondVectorLength):

runtime/JSObject.h:

(JSC::JSObject::setIndexQuickly):
(JSC::JSObject::initializeIndex):

runtime/LiteralParser.cpp:

(JSC::LiteralParser<CharType>::parse):

yarr/YarrInterpreter.cpp:

(JSC::Yarr::Interpreter::backtrackParenthesesOnceBegin):
(JSC::Yarr::Interpreter::backtrackParenthesesOnceEnd):

yarr/YarrParser.h:

(JSC::Yarr::Parser::CharacterClassParserDelegate::atomPatternCharacter):
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomBuiltInCharacterClass):
(JSC::Yarr::Parser::parseEscape):
(JSC::Yarr::Parser::parseTokens):

7:36 PM Changeset in webkit [162905] by fpizlo@apple.com

2 edits
1 add in branches/jsCStack/Source/JavaScriptCore

DFG ArrayPush implementation does strange things to the result register on the slow path
https://bugs.webkit.org/show_bug.cgi?id=127754

Reviewed by Michael Saboff.

This told the slow path machinery that there was NoResult, which then sort of worked
by accident because it would invoke a callOperation and pass the result register
(i.e. storageLengthGPR) thinking it was giving it the first argument when in reality
that callOperation would use it as the result register. The downside is that we would
probably fail to omit the result register from silent spilling, but that probably
doesn't even matter since storageLengthGPR doesn't appear as an in-use register (it's
locked, but not attached to a Node, and so it's not "in use").

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

tests/stress/array-push.js: Added.

(foo):

6:56 PM Changeset in webkit [162904] by aestes@apple.com

10 edits in trunk/Source/WebKit2

[WebKit2] Add SPI to disable the WebCore memory cache
https://bugs.webkit.org/show_bug.cgi?id=127747

Reviewed by Tim Horton.

Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
Initialized memoryCacheDisabled to false.
(WebKit::WebProcessCreationParameters::encode):
Encoded memoryCacheDisabled.
(WebKit::WebProcessCreationParameters::decode):
Decoded memoryCacheDisabled.

Shared/WebProcessCreationParameters.h:
UIProcess/API/C/WKContext.cpp:

(WKContextSetMemoryCacheDisabled):
Called WebContext::setMemoryCacheDisabled().

UIProcess/API/C/WKContextPrivate.h: Declared new SPI.
UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext): Initialized m_memoryCacheDisabled to false.
(WebKit::WebContext::createNewWebProcess):
Set WebProcessCreationParameters::memoryCacheDisabled to m_memoryCacheDisabled.
(WebKit::WebContext::setMemoryCacheDisabled): Set m_memoryCacheDisabled
and sent new value to all existing processes.

UIProcess/WebContext.h:
WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
Called WebProcess::setMemoryCacheDisabled().
(WebKit::WebProcess::setMemoryCacheDisabled):
Called MemoryCache::setDisabled() if the disabled state changed.

WebProcess/WebProcess.h:
WebProcess/WebProcess.messages.in:

6:50 PM Changeset in webkit [162903] by fpizlo@apple.com

1 edit in branches/jsCStack/Source/JavaScriptCore/ChangeLog

Mark appropriate things as reviewed

6:31 PM Changeset in webkit [162902] by fpizlo@apple.com

1 edit in branches/jsCStack/Source/JavaScriptCore/ChangeLog

Mark appropriate things as reviewed

6:12 PM Changeset in webkit [162901] by matthew_hanson@apple.com

1 copy in tags/Safari-537.75.1

New Tag

6:12 PM Changeset in webkit [162900] by msaboff@apple.com

1 edit in branches/jsCStack/Source/WebKit/mac/postprocess-headers.sh

Set exectueable property to match trunk.

6:04 PM Changeset in webkit [162899] by andersca@apple.com

3 edits in trunk/Source/WebKit2

Add -[WKWebView loadRequest:] API
https://bugs.webkit.org/show_bug.cgi?id=127727

Reviewed by Dan Bernstein.

UIProcess/API/Cocoa/WKWebView.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):
(-[WKWebView loadRequest:]):

6:02 PM Changeset in webkit [162898] by dfarler@apple.com

3 edits in trunk/Tools

iOS DumpRenderTree.app dies loading fonts
https://bugs.webkit.org/show_bug.cgi?id=127730

Reviewed by Daniel Bates.

DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
Add Ahem to the DATA section
DumpRenderTree/mac/DumpRenderTree.mm:

(activateFontsIOS):

Load "WeightWatcher100" instead.

5:59 PM Changeset in webkit [162897] by akling@apple.com

3 edits in trunk/Source/WebCore

Allow mmap encoded data replacement for WOFF fonts.
<https://webkit.org/b/127737>

We always have to convert WOFF fonts to SFNT format. This happens
in a separate buffer from the CachedFont's internal resource buffer.
Because of this, there's no need to protect the original buffer from
mmap replacement.

With this change, WOFF web fonts are no longer duplicated between
the network and web processes.

Reviewed by Brady Eidson.

loader/cache/CachedFont.cpp:

(WebCore::CachedFont::CachedFont):
(WebCore::CachedFont::ensureCustomFontData):
(WebCore::CachedFont::mayTryReplaceEncodedData):

loader/cache/CachedFont.h:

5:56 PM Changeset in webkit [162896] by BJ Burg

7 edits in trunk/LayoutTests

Web Inspector: clean up initialization of managers and observers in InspectorTest
https://bugs.webkit.org/show_bug.cgi?id=127707

Reviewed by Timothy Hatcher.

The test harness was setting up managers and observers before
telling the frontend host that the page loaded. The InspectorObserver
was also not being initialized.

For clarity, rename importInspectorScripts to initializeInspectorModels.
For easier debugging, make model test assertions use InspectorTest.log.

http/tests/inspector-protocol/resources/InspectorTest.js:

(InspectorTest.initializeInspectorModels.console.error.window.onerror):
(InspectorTest.initializeInspectorModels.console.assert):
(InspectorTest.initializeInspectorModels):

inspector-protocol/model/content-flow-content-nodes.html:
inspector-protocol/model/content-flow-content-removal.html:
inspector-protocol/model/content-flow-list.html:
inspector-protocol/model/content-node-region-info.html:
inspector-protocol/model/main-frame-resource.html:

5:50 PM Changeset in webkit [162895] by ap@apple.com

2 edits in trunk/Tools

[Mac] Extra logging output from run-safari --no-saved-state
https://bugs.webkit.org/show_bug.cgi?id=127732

Reviewed by Daniel Bates.

Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): Use an option that

disables saved state without logging.

5:45 PM Changeset in webkit [162894] by mhahnenberg@apple.com

969 edits
17 adds
4 deletes in branches/jsCStack

Getting all layout tests passing on the branch.

5:35 PM Changeset in webkit [162893] by fpizlo@apple.com

2 edits in branches/jsCStack/Source/JavaScriptCore

Structure::dump() should say things about specific values
https://bugs.webkit.org/show_bug.cgi?id=127741

Not yet reviewed.

runtime/Structure.cpp:

(JSC::Structure::dump):

5:26 PM Changeset in webkit [162892] by hyatt@apple.com

13 edits
4 adds in trunk

[New Multicolumn] Add support for block progression axis and reverse direction
https://bugs.webkit.org/show_bug.cgi?id=127715

Reviewed by thorton.

This patch adds support for -webkit-progression-direction and -webkit-progression-axis
to the new column code. This allows columns to stack along the block axis instead of
the inline axis or to reverse directions along that progression axis.

Added fast/multicol/newmulticol/progression-reverse.html and

fast/multicol/newmulticol/progression-reverse-overflow.html

Source/WebCore:

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::isTopLayoutOverflowAllowed):
(WebCore::RenderBlock::isLeftLayoutOverflowAllowed):
New functions have been added for top and left layout overflow in order to get
a bunch of code out of RenderBox that didn't belong there. RenderBlock is overriding
the functions for the old multicolumn layout code to keep it working.

rendering/RenderBlock.h:

Added the new top/left overflow functions.

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::determineLogicalLeftPositionForChild):
Moved from RenderBlock, since it didn't belong there.

(WebCore::RenderBlockFlow::isTopLayoutOverflowAllowed):
(WebCore::RenderBlockFlow::isLeftLayoutOverflowAllowed):

rendering/RenderBlockFlow.h:

Overridden for the new multi-column code to specify when top/left overflow are
allowed (e.g., when the columns go backwards).

rendering/RenderBox.cpp:

(WebCore::RenderBox::addLayoutOverflow):
Overridden to use the new top/left overflow functions.

rendering/RenderBox.h:

(WebCore::RenderBox::isTopLayoutOverflowAllowed):
(WebCore::RenderBox::isLeftLayoutOverflowAllowed):
Added base definitions that look at direction and writing-mode.

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::isTopLayoutOverflowAllowed):
(WebCore::RenderFlexibleBox::isLeftLayoutOverflowAllowed):

rendering/RenderFlexibleBox.h:

Overrides for flexible box of the top/left overflow functions.

rendering/RenderMultiColumnFlowThread.h:

Make sure requiresBalancing() is set to false if the axis of the columns
is block, since at least right now, we don't support balancing columns
along the block axis. (In theory we could support this in the future, but
nobody has requested it.)

rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::updateLogicalWidth):
Remove the code that expands the width of multi column sets. We now always
let their logical width match the containing block's content width and instead
add the overflow to the set itself.

(WebCore::RenderMultiColumnSet::columnRectAt):
(WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):
(WebCore::RenderMultiColumnSet::paintColumnRules):
(WebCore::RenderMultiColumnSet::initialBlockOffsetForPainting):
(WebCore::RenderMultiColumnSet::collectLayerFragments):
(WebCore::RenderMultiColumnSet::adjustRegionBoundsFromFlowThreadPortionRect):
Patch all of these functions to know how to handle a block axis or reversed
direction.

(WebCore::RenderMultiColumnSet::addOverflowFromChildren):

rendering/RenderMultiColumnSet.h:

Make multi-column set add in its overflow in the same way that the old
multi-column code did, by looking at the last column rect. (This is really
not a very good way to do it, but it's the same as the old code for now.)

LayoutTests:

fast/multicol/newmulticol/progression-reverse-expected.html: Added.
fast/multicol/newmulticol/progression-reverse-overflow-expected.html: Added.
fast/multicol/newmulticol/progression-reverse-overflow.html: Added.
fast/multicol/newmulticol/progression-reverse.html: Added.

5:17 PM Changeset in webkit [162891] by beidson@apple.com

9 edits in trunk/Source/WebKit2

IDB: Rename "IDBTransactionIdentifier" to be more general purpose (take 2)
https://bugs.webkit.org/show_bug.cgi?id=127717

Reviewed by Tim Horton.

Update all related variable names since the type no longer contains the relevant info.

DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.cpp:
DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.h:
DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:
Shared/WebCrossThreadCopier.cpp:

5:12 PM Changeset in webkit [162890] by jinwoo7.song@samsung.com

2 edits in trunk/LayoutTests

Unreviewed EFL gardening. Add test expectations for failing tests.

platform/efl/TestExpectations:

5:01 PM Changeset in webkit [162889] by dbates@webkit.org

2 edits in trunk/Source/WebCore

Fix the Mac build following <http://trac.webkit.org/changeset/162887>
(https://bugs.webkit.org/show_bug.cgi?id=127703)

Export symbol for WebCore::AXObjectCache::enableAccessibility().

WebCore.exp.in:

4:49 PM Changeset in webkit [162888] by roger_fong@apple.com

2 edits in trunk/Source/WebCore

[Mac] Unreviewed build fix. Add missing export symbol.

WebCore.exp.in:

4:31 PM Changeset in webkit [162887] by roger_fong@apple.com

5 edits in trunk/Source

[Windows] Tests crashing on Windows after r162816.
https://bugs.webkit.org/show_bug.cgi?id=127703.

Reviewed by Alexey Proskuryakov.

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::enableAccessibility):
(WebCore::AXObjectCache::disableAccessibility):

accessibility/AXObjectCache.h: Un-inline some methods so that they can be exported.
WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Remove variable export in favor of function export.

4:24 PM Changeset in webkit [162886] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Copy relevant code from the iOS version of WKView to WKWebView
https://bugs.webkit.org/show_bug.cgi?id=127721

Reviewed by Dan Bernstein.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):
(-[WKWebView setFrame:]):
(-[WKWebView setBounds:]):
(-[WKWebView scrollView]):
(-[WKWebView browsingContextController]):
(-[WKWebView contentView:contentsSizeDidChange:]):
(-[WKWebView contentViewDidCommitLoadForMainFrame:]):
(-[WKWebView contentViewDidReceiveMobileDocType:]):
(-[WKWebView contentView:didChangeViewportArgumentsSize:initialScale:minimumScale:maximumScale:allowsUserScaling:]):
(-[WKWebView viewportHandlerDidChangeScales:]):
(-[WKWebView viewportHandler:didChangeViewportSize:]):
(-[WKWebView viewForZoomingInScrollView:]):
(-[WKWebView scrollViewWillBeginZooming:withView:]):
(-[WKWebView _didFinishScroll]):
(-[WKWebView scrollViewDidEndDragging:willDecelerate:]):
(-[WKWebView scrollViewDidEndDecelerating:]):
(-[WKWebView scrollViewDidScrollToTop:]):
(-[WKWebView scrollViewDidScroll:]):
(-[WKWebView scrollViewDidEndZooming:withView:atScale:]):
(-[WKWebView _frameOrBoundsChanged]):
(-[WKWebView _setDocumentScale:]):

4:20 PM Changeset in webkit [162885] by aestes@apple.com

3 edits in trunk/Source/WebCore

Update bindings test expectations after r162872

bindings/scripts/test/ObjC/DOMTestInterface.h:
bindings/scripts/test/ObjC/DOMTestObj.h:

4:18 PM Changeset in webkit [162884] by gyuyoung.kim@samsung.com

3 edits in trunk/LayoutTests

Unreviewed gardening, unskip now passing webgl tests on EFL port.

platform/efl-wk2/TestExpectations:
platform/efl/TestExpectations:

4:07 PM Changeset in webkit [162883] by timothy_horton@apple.com

12 edits in trunk

Revert the parts of r162629 that add a new pluginLoadPolicy and the context menu item.

We're leaving the parts that make us use PDFPlugin instead of showing the blocked
plugin indicator intact, though.

UIProcess/API/APILoaderClient.h:

(API::LoaderClient::pluginLoadPolicy):

UIProcess/API/C/WKPage.cpp:

(WKPageSetPageLoaderClient):

UIProcess/API/C/WKPageLoaderClient.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::findPlugin):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebProcess/Plugins/PDF/PDFPlugin.h:
WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::PDFPlugin):
(WebKit::PDFPlugin::handleContextMenuEvent):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
(WebKit::WebPage::canPluginHandleResponse):

WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):

4:04 PM Changeset in webkit [162882] by andersca@apple.com

3 edits in trunk/Source/WebKit2

Add a WKContentView initializer that takes a WKWebViewConfiguration
https://bugs.webkit.org/show_bug.cgi?id=127718

Reviewed by Tim Horton.

This initializer will be used by WKWebView.

UIProcess/API/ios/WKContentView.h:
UIProcess/API/ios/WKContentView.mm:

(-[WKContentView initWithFrame:configuration:]):

4:01 PM Changeset in webkit [162881] by aestes@apple.com

18 edits in trunk

Scrub WebKit API headers of WTF macros
https://bugs.webkit.org/show_bug.cgi?id=127706

Reviewed by David Kilzer.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig: Added ENABLE_INSPECTOR.

Source/WebCore:

Configurations/FeatureDefines.xcconfig: Added ENABLE_INSPECTOR.
bindings/objc/DOMEvents.h: Guarded include of

DOM{Gesture,Touch}Event.h with TARGET_OS_IPHONE, since those features
are always enabled on iOS.

platform/graphics/mac/MediaPlayerProxy.h: Replaced PLATFORM(IOS) with

TARGET_OS_IPHONE and ensured ENABLE_IOS_AIRPLAY is defined.

platform/ios/SystemMemory.h: Replaced PLATFORM(IOS) with

TARGET_OS_IPHONE.

platform/ios/wak/WKGraphics.h: Replaced PLATFORM(IOS_SIMULATOR) with

TARGET_IPHONE_SIMULATOR.

Source/WebKit/ios:

WebCoreSupport/WebMIMETypeRegistry.h: Changed PLATFORM(IOS) to

TARGET_OS_IPHONE.

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig: Added ENABLE_INSPECTOR.
WebView/WebPreferenceKeysPrivate.h: Changed ENABLE(REMOTE_INSPECTOR)

to !defined(ENABLE_REMOTE_INSPECTOR)

ENABLE_REMOTE_INSPECTOR. We are

in a TARGET_OS_IPHONE block, and ENABLE_REMOTE_INSPECTOR is enabled by
default on iOS, so include this block unless the feature is explicitly
disabled.

postprocess-headers.sh: Stopped processing ENABLE_IOS_TOUCH_EVENTS

and ENABLE_IOS_GESTURE_EVENTS. These are now defined in DOMEvents.h.

Source/WebKit2:

Configurations/FeatureDefines.xcconfig: Added ENABLE_INSPECTOR.

Tools:

Scripts/check-for-inappropriate-macros-in-external-headers: Modified

the regex to require a '(' after the macro name in order to be
considered a match. This prevents things like 'ENABLE_SOME_FEATURE'
from being flagged as an ENABLE() macro.

3:56 PM Changeset in webkit [162880] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Crashes in RemoteScrollingCoordinatorProxy::rootScrollingNodeID

Reviewed by Simon Fraser.

UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::rootScrollingNodeID):
Null-check the root scrolling node, in case something scrolls before
we've made the first remote layer/scrolling tree commit.

3:51 PM Changeset in webkit [162879] by jer.noble@apple.com

3 edits in trunk/Source/WebCore

[iOS] Use callOnMainThread() not dispatch_async() in MediaPlayerPrivateAVFoundationObjC
https://bugs.webkit.org/show_bug.cgi?id=127701

Reviewed by Eric Carlson.

dispatch_async(dispatch_get_main_queue(), ...) used to be fine so long as the main
thread was also the web thread. But since that's not the case on iOS, we should be
using callOnMainThread() instead (because it dispatches to the web thread, not as
its name implies, the main thread).

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createWeakPtr):

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::seekToTime):
(-[WebCoreAVFMovieObserver legibleOutput:didOutputAttributedStrings:nativeSampleBuffers:forItemTime:]):
(-[WebCoreAVFMovieObserver outputSequenceWasFlushed:]):
(-[WebCoreAVFLoaderDelegate resourceLoader:shouldWaitForLoadingOfRequestedResource:]):
(-[WebCoreAVFLoaderDelegate resourceLoader:shouldWaitForResponseToAuthenticationChallenge:]):
(-[WebCoreAVFLoaderDelegate resourceLoader:didCancelLoadingRequest:]):

3:50 PM Changeset in webkit [162878] by mjs@apple.com

2 edits in trunk/Source/WebCore

Move Conditional=BLOB from URL interface to Blob-related methods, to prepare for adding URL API
https://bugs.webkit.org/show_bug.cgi?id=127719

Reviewed by Sam Weinig.

html/DOMURL.idl:

3:48 PM Changeset in webkit [162877] by beidson@apple.com

12 edits
1 move in trunk/Source/WebKit2

IDB: Rename "IDBTransactionIdentifier" to be more general purpose
https://bugs.webkit.org/show_bug.cgi?id=127717

Reviewed by Tim Horton.

Global rename of IDBTransactionIdentifier to IDBIdentifier.

DatabaseProcess/IndexedDB/IDBIdentifier.h: Renamed from Source/WebKit2/DatabaseProcess/IndexedDB/IDBTransactionIdentifier.h.

DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:

DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.cpp:
DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.h:

DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:

Shared/WebCrossThreadCopier.cpp:
Shared/WebCrossThreadCopier.h:

WebKit2.xcodeproj/project.pbxproj:

3:39 PM Changeset in webkit [162876] by andersca@apple.com

5 edits in trunk/Source/WebKit2

Move underlying C++ objects to class extensions
https://bugs.webkit.org/show_bug.cgi?id=127716

Reviewed by Tim Horton.

This allows us to get at the internals without calling any Obj-C methods.

UIProcess/API/Cocoa/WKProcessClass.mm:
UIProcess/API/Cocoa/WKProcessClassInternal.h:
UIProcess/API/ios/WKContentView.mm:
UIProcess/API/ios/WKContentViewInternal.h:

3:29 PM Changeset in webkit [162875] by akling@apple.com

6 edits
2 deletes in trunk/Source/WebCore

Remove unused USE(OPENTYPE_SANITIZER) code.
<https://webkit.org/b/127710>

This code was only used by the Chromium port.

Reviewed by Darin Adler.

GNUmakefile.list.am:
WebCore.xcodeproj/project.pbxproj:
loader/cache/CachedFont.cpp:

(WebCore::CachedFont::ensureCustomFontData):

platform/graphics/WOFFFileFormat.cpp:
platform/graphics/WOFFFileFormat.h:
platform/graphics/opentype/OpenTypeSanitizer.cpp: Removed.
platform/graphics/opentype/OpenTypeSanitizer.h: Removed.

3:25 PM Changeset in webkit [162874] by commit-queue@webkit.org

9 edits in trunk/Source/WebInspectorUI

Web Inspector: Feature Check all Protocol Generated Interfaces to get JSContext Inspection working
https://bugs.webkit.org/show_bug.cgi?id=127712

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-27
Reviewed by Timothy Hatcher.

Feature check protocol generated interfaces (e.g. FooAgent and registerFooObserver).
Also drive by handle a possible exception if a SourceCode's URL is null, which is possible.

UserInterface/ApplicationCacheManager.js:

(WebInspector.ApplicationCacheManager):
(WebInspector.ApplicationCacheManager.prototype.initialize):

UserInterface/CSSCompletions.js:

(WebInspector.CSSCompletions.requestCSSNameCompletions):

UserInterface/CSSStyleManager.js:

(WebInspector.CSSStyleManager):
(WebInspector.CSSStyleManager.prototype.canForcePseudoClasses):

UserInterface/DebuggerManager.js:
UserInterface/FrameResourceManager.js:

(WebInspector.FrameResourceManager):
(WebInspector.FrameResourceManager.prototype.initialize):

UserInterface/Main.js:

(WebInspector.loaded):

UserInterface/ProfileManager.js:

(WebInspector.ProfileManager):

UserInterface/StorageManager.js:

(WebInspector.StorageManager):
Type check generated interfaces.

(WebInspector.DebuggerManager):
(WebInspector.DebuggerManager.prototype.debuggerDidPause):
Null check a SourceCode URL, which can be null for a Script with no URL.

3:22 PM Changeset in webkit [162873] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Implement the _injectedBundleURL property
https://bugs.webkit.org/show_bug.cgi?id=127714

Reviewed by Tim Horton.

Properties declared in class categories need to be implemented. Do this
for the _injectedBundleURL property.

UIProcess/API/Cocoa/WKProcessClassConfiguration.mm:

(-[WKProcessClassConfiguration _injectedBundleURL]):
(-[WKProcessClassConfiguration _setInjectedBundleURL:]):

3:15 PM Changeset in webkit [162872] by aestes@apple.com

2 edits in trunk/Source/WebCore

Stop the code generator from adding ENABLE() macros to Objective-C DOM headers
https://bugs.webkit.org/show_bug.cgi?id=127706

Reviewed by David Kilzer.

Instead of adding ENABLE() macros to generated Objective-C DOM
headers, which might become Public or Private headers, elide generated
code for disabled features.

bindings/scripts/CodeGeneratorObjC.pm:

(GenerateInterface): Passed $defines to GenerateHeader.
(ConditionalIsEnabled): Checked if the given conditional is found in
$defines. Handled conditionals with '&' and '|'.
(GenerateHeader): Rather than calling GenerateConditionalString to
generate an "#if ENABLE(...)", called ConditionalIsEnabled() to see
whether we should generate code for the given constant, attribute, or
function.

3:03 PM Changeset in webkit [162871] by zoltan@webkit.org

5 edits in trunk

[CSS Shapes] Remove restriction of negative values for inset parameters
https://bugs.webkit.org/show_bug.cgi?id=127704

Reviewed by Darin Adler.

Source/WebCore:

The latest version of CSS Shapes (http://www.w3.org/TR/css-shapes/) specification
doesn't contain any restriction of using negative values for the inset sizing.
I removed the restriction from the code and added testing for them.

Existing tests have been extended with the new cases.

css/CSSParser.cpp:

(WebCore::CSSParser::parseBasicShapeInset):

LayoutTests:

fast/shapes/parsing/parsing-shape-lengths-expected.txt:
fast/shapes/parsing/parsing-shape-lengths.html:

2:47 PM Changeset in webkit [162870] by eric.carlson@apple.com

3 edits in trunk/Source/WebCore

[iOS] preload=none prevents play()
https://bugs.webkit.org/show_bug.cgi?id=127702

Reviewed by Jer Noble.

No new tests, covered by existing tests.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::potentiallyPlaying): Cleanup logic to make it simpler to understand,

fix logic error introduced in r161973

(WebCore::HTMLMediaElement::updatePlayState): Conditionalize some iOS-only code on whether or not

we are using the plug-in proxy.

2:38 PM Changeset in webkit [162869] by beidson@apple.com

9 edits in trunk/Source

IDB: LevelDB backing store shouldn't know about IDBCursor or IDBCallbacks
https://bugs.webkit.org/show_bug.cgi?id=127708

Reviewed by Tim Horton.

Source/WebCore:

Move that knowledge to the IDBCursorBackendOperations inside the callback.

Modules/indexeddb/IDBCursorBackendOperations.cpp:

(WebCore::CursorAdvanceOperation::perform):
(WebCore::CursorIterationOperation::perform):

Modules/indexeddb/IDBCursorBackendOperations.h:

Modules/indexeddb/IDBServerConnection.h:
Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:

(WebCore::IDBServerConnectionLevelDB::cursorAdvance):
(WebCore::IDBServerConnectionLevelDB::cursorIterate):

Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:

Source/WebKit2:

Update to new callback signatures:

WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::cursorAdvance):
(WebKit::WebIDBServerConnection::cursorIterate):

WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:

2:37 PM Changeset in webkit [162868] by fpizlo@apple.com

2 edits in branches/jsCStack/Source/JavaScriptCore

FTL ArithMod case needs to be factored for hackability and correctness rather than just minimizing the amount of code
https://bugs.webkit.org/show_bug.cgi?id=127709

Rubber stamped by Mark Hahnenberg.

Roll out part of r156784. 60% progression on Kraken/audio-oscillator.

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileArithDiv):
(JSC::FTL::LowerDFGToLLVM::compileArithMod):

2:20 PM Changeset in webkit [162867] by mhahnenberg@apple.com

8 edits
2 adds
1 delete in branches/jsCStack

Added missing files to the branch.

1:52 PM Changeset in webkit [162866] by fpizlo@apple.com

3 edits
6 adds in branches/jsCStack/Source/JavaScriptCore

FTL should support NewArrayWithSize
https://bugs.webkit.org/show_bug.cgi?id=127698

Reviewed by Mark Hahnenberg.

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileNewArrayWithSize):

tests/stress/new-array-storage-array-with-size.js: Added.

(foo):
(test):

tests/stress/new-array-with-size-with-bad-time.js: Added.

(foo):

tests/stress/new-contiguous-array-with-size.js: Added.

(foo):
(test):

tests/stress/new-double-array-with-size.js: Added.

(foo):
(test):

tests/stress/new-int32-array-with-size.js: Added.

(foo):
(test):

tests/stress/new-undecided-array-with-size.js: Added.

(foo):
(test):

1:45 PM Changeset in webkit [162865] by andersca@apple.com

3 edits in trunk/Source/WebKit2

Tweak the WKWebView and WKWebViewConfiguration headers
https://bugs.webkit.org/show_bug.cgi?id=127705

Reviewed by Dan Bernstein.

Add WK_API_CLASS to WKWebView and make WKWebView.h and WKWebViewConfiguration.h public.

UIProcess/API/Cocoa/WKWebView.h:
WebKit2.xcodeproj/project.pbxproj:

1:29 PM Changeset in webkit [162864] by beidson@apple.com

11 edits in trunk/Source

IDB: Remove unused concept of "cursor prefetch"
https://bugs.webkit.org/show_bug.cgi?id=127700

Reviewed by Tim Horton.

Source/WebCore:

Modules/indexeddb/IDBCursorBackend.cpp:
Modules/indexeddb/IDBCursorBackend.h:
Modules/indexeddb/IDBCursorBackendOperations.cpp:
Modules/indexeddb/IDBCursorBackendOperations.h:
Modules/indexeddb/IDBServerConnection.h:
Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:
Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:

Source/WebKit2:

WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:

1:24 PM Changeset in webkit [162863] by Brent Fulgham

3 edits
3 adds
3 deletes in branches/safari-537.75-branch/Source

Merge r162723.

2014-01-24 Brent Fulgham <Brent Fulgham>

[Win] Convert some NMake files to MSBuild project files
https://bugs.webkit.org/show_bug.cgi?id=127579

Reviewed by Tim Horton.

Source/JavaScriptCore:

JavaScriptCore.vcxproj/JavaScriptCore.make: Removed.
JavaScriptCore.vcxproj/JavaScriptCore.proj: Added.

Source/WebCore:

WebCore.vcxproj/WebCore.make: Removed.
WebCore.vcxproj/WebCore.proj: Added.

Source/WTF:

WTF.vcxproj/WTF.make: Removed.
WTF.vcxproj/WTF.proj: Added.

1:16 PM Changeset in webkit [162862] by jer.noble@apple.com

2 edits in trunk/Source/WTF

[WK2] callOnMainThread() from main thread sometimes results in ASSERTs.
https://bugs.webkit.org/show_bug.cgi?id=127370

Reviewed by Alexey Proskuryakov.

When WEB_THREAD is enabled, and callOnMainThread() is called from the main
thread, if the web thread is locked, a timer is set and the passed-in function
is called on the next run-loop. However, by that time the web thread may have
been unlocked, and isMainThread() will no longer return true, resulting in
an assert.

Instead, scheduleDispatchFunctionsOnMainThread() should check isWebThread(),
which is equivalent to isMainThread() when the WEB_THREAD is disabled, but
will do the correct thing when WEB_THREAD is enabled.

wtf/mac/MainThreadMac.mm:

(WTF::scheduleDispatchFunctionsOnMainThread):

1:03 PM Changeset in webkit [162861] by msaboff@apple.com

2 edits in branches/jsCStack/Source/JavaScriptCore

CStack Branch: [X86-32] testapi crashes in gatherConservativeRoots()
https://bugs.webkit.org/show_bug.cgi?id=127699

Reviewed by Mark Hahnenberg.

sanitizeStackForVMImpl was using "t4" (edi) which is a callee save register, which
trashed its prior contents. Change to use t2 (ecx) on X86 which is a scratch register.

llint/LowLevelInterpreter.asm:

1:00 PM Changeset in webkit [162860] by Brent Fulgham

2 edits in branches/safari-537.75-branch/Source/WebCore

Unreviewed build fix after r162631.

WebCore.vcxproj/WebCore.submit.sln: Do not build QTMovieWin for 64-bit architecture.

12:53 PM Changeset in webkit [162859] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Fix the build on case-sensitive filesystems

WebProcess/WebPage/ViewGestureGeometryCollector.h:

12:52 PM Changeset in webkit [162858] by Antti Koivisto

2 edits in trunk/LayoutTests

REGRESSION(r162837): fast/writing-mode/ruby-text-logical-left.html fails on WK1

TestExpectations: skip for now

12:51 PM Changeset in webkit [162857] by mitz@apple.com

2 edits in trunk/Source/WTF

Build fix.

wtf/ThreadSafeRefCounted.h: Added a necessary #include.

12:48 PM UsingGitHub edited by Ricky de Laveaga

typo you/your (diff)

12:34 PM Changeset in webkit [162856] by beidson@apple.com

9 edits in trunk/Source

IDB: Refactor out the last of the operation callbacks that are called by the LevelDB backing store
https://bugs.webkit.org/show_bug.cgi?id=127592

Reviewed by Tim Horton.

Source/WebCore:

For each of the 3 remaining operations where the backing store calls callbacks directly,
factor out the callbacks to the operation itself.

Modules/indexeddb/IDBTransactionBackendOperations.cpp:

(WebCore::OpenCursorOperation::perform):
(WebCore::CountOperation::perform):
(WebCore::DeleteRangeOperation::perform):

Modules/indexeddb/IDBTransactionBackendOperations.h:

Modules/indexeddb/IDBServerConnection.h:
Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:

(WebCore::IDBServerConnectionLevelDB::openCursor):
(WebCore::IDBServerConnectionLevelDB::count):
(WebCore::IDBServerConnectionLevelDB::deleteRange):

Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:

Source/WebKit2:

Update the WebIDBServerConnection to the new callback signatures:

WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::openCursor):
(WebKit::WebIDBServerConnection::count):

WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:

12:31 PM Changeset in webkit [162855] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Unreviewed, rolling out r162755.
http://trac.webkit.org/changeset/162755
https://bugs.webkit.org/show_bug.cgi?id=127696

not quite right, breaks subframe scrolling in some cases
(Requested by thorton on #webkit).

page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::ScrollingTree):
(WebCore::ScrollingTree::shouldHandleWheelEventSynchronously):
(WebCore::ScrollingTree::removeDestroyedNodes):

page/scrolling/ScrollingTree.h:
page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::handleWheelEvent):

12:28 PM Changeset in webkit [162854] by mhahnenberg@apple.com

776 edits
162 adds
1 delete in branches/jsCStack

Source/JavaScriptCore: Merge branch up to ToT r162844.

12:21 PM Changeset in webkit [162853] by timothy_horton@apple.com

23 edits in trunk/Source/WebKit2

WebKit2 View Gestures: Fluid back-forward swipe
https://bugs.webkit.org/show_bug.cgi?id=127363

Reviewed by Anders Carlsson.

Add support for a "back-forward swipe", which allows fluid swiping between
items in the back-forward list. Currently disabled by default.

Shared/WebPreferencesStore.h:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetViewGestureDebuggingEnabled):
(WKPreferencesGetViewGestureDebuggingEnabled):

UIProcess/API/C/WKPreferencesPrivate.h:

Add a ViewGestureDebuggingEnabled preference, which currently causes snapshots to be blurred.
Additional view gesture debugging features could come in the future.

UIProcess/API/Cocoa/WKViewPrivate.h:
UIProcess/API/mac/WKView.mm:

(-[WKView _ensureGestureController]):
(-[WKView scrollWheel:]):
If back-forward navigation gestures are enabled, intercept scrollWheel events
on the WKView and let the ViewGestureController take the first crack at them.

(-[WKView setAllowsBackForwardNavigationGestures:]):
(-[WKView allowsBackForwardNavigationGestures]):

UIProcess/API/mac/WKViewInternal.h:

Add allowsBackForwardNavigationGesture property, which enables the gesture.

UIProcess/mac/ViewGestureController.h:

Add swipe-related methods, which will be described below.

Add an enum for the swipe transition style. Currently only Overlap is accessible,
but in the future one could see having API to choose the style.
'Overlap' has the outgoing page swipe out to the right (when swiping right)
or the incoming page swipe in from the right (when swiping left).
'Push' has the pages push each other along in sync, as if all the pages in the
back-forward list were oriented from left to right.

UIProcess/mac/ViewGestureController.messages.in:
UIProcess/mac/ViewGestureController.mm: Renamed from Source/WebKit2/UIProcess/mac/ViewGestureController.cpp.

Use some CAFilter SPI to blur the snapshot if ViewGestureDebuggingEnabled is on.

(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::~ViewGestureController):
(WebKit::ViewGestureController::endMagnificationGesture):
Move m_activeGestureType clearing to each end* function instead of one global place,
so that each gesture can handle when it ends separately.

(WebKit::ViewGestureController::handleScrollWheelEvent):
If we receive a scroll wheel event which is appropriate for starting a
fluid swipe, in a direction where the main frame is pinned to the appropriate
edge of the view, start tracking a swipe.

This should eventually have some hysterisis to avoid stealing scrolls that
venture into the wrong direction, but for now it starts tracking immediately.

Forward events from the tracking loop to {begin, handle, end}SwipeGesture.

(WebKit::ViewGestureController::beginSwipeGesture):
Create a layer with the destination page's snapshot, and set it up.

(WebKit::ViewGestureController::handleSwipeGesture):
Appropriately adjust the position of the root layer and snapshot layer,
given the transition style and swipe direction.

(WebKit::ViewGestureController::endSwipeGesture):
When the gesture ends, do the navigation, and tell the WebProcess to
inform us when the render tree hits half the size it was when the
snapshot was taken (when that happens, we will remove the snapshot
and the gesture will be truly complete). Also, start a watchdog timer
in case the render tree never hits that size, after which we will
also remove the snapshot.

(WebKit::ViewGestureController::didHitRenderTreeSizeThreshold):
(WebKit::ViewGestureController::swipeSnapshotWatchdogTimerFired):
(WebKit::ViewGestureController::removeSwipeSnapshot):
Tear down the swipe snapshot layer, and mark our current gesture as complete.

(WebKit::ViewGestureController::endActiveGesture):
Simplify endActiveGesture; it only has work to do for a pinch-zoom gesture,
as those are the only gestures where the user is directly in control of when they end.

WebProcess/WebPage/ViewGestureGeometryCollector.cpp:

(WebKit::ViewGestureGeometryCollector::ViewGestureGeometryCollector):
(WebKit::ViewGestureGeometryCollector::mainFrameDidLayout):
(WebKit::ViewGestureGeometryCollector::renderTreeSizeNotificationTimerFired):

WebProcess/WebPage/ViewGestureGeometryCollector.h:

(WebKit::ViewGestureGeometryCollector::setRenderTreeSizeNotificationThreshold):

WebProcess/WebPage/ViewGestureGeometryCollector.messages.in:

ViewGestureController pushes a render-tree size threshold to the WebProcess;
ViewGestureGeometryCollector (whose name is now more unfortunate than before)
monitors render-tree size changes and informs ViewGestureController when
it reaches that threshold via the 'DidHitRenderTreeSizeThreshold' message.

UIProcess/API/Cocoa/WKViewPrivate.h:
UIProcess/API/ios/PageClientImplIOS.h:
UIProcess/API/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::acceleratedCompositingRootLayer):

UIProcess/API/mac/PageClientImpl.h:
UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::acceleratedCompositingRootLayer):

UIProcess/API/mac/WKView.mm:

(-[WKView _acceleratedCompositingModeRootLayer]):

UIProcess/API/mac/WKViewInternal.h:
UIProcess/PageClient.h:
UIProcess/WebPageProxy.h:
UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::acceleratedCompositingRootLayer):
Add a getter for the accelerated compositing root layer.

UIProcess/mac/ViewSnapshotStore.mm:

(WebKit::ViewSnapshotStore::snapshotAndRenderTreeSize):
Don't extract the CGImageRef from a RetainPtr just to put it back in one.

12:04 PM Changeset in webkit [162852] by Brent Fulgham

7 edits in branches/safari-537.75-branch/Source/JavaScriptCore

Merge r154513, r154354.

2013-08-23 Alex Christensen <alex.christensen@flexsim.com>

Re-separating Win32 and Win64 builds.
https://bugs.webkit.org/show_bug.cgi?id=120178

Reviewed by Brent Fulgham.

JavaScriptCore.vcxproj/JavaScriptCoreGenerated.make:
JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.make:
JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.make:

Pass PlatformArchitecture as a command line parameter to bash scripts.

JavaScriptCore.vcxproj/copy-files.cmd: Use correct architecture

for build conditions.

JavaScriptCore.vcxproj/jsc/jscCommon.props: Ditto
JavaScriptCore.vcxproj/testRegExp/testRegExpCommon.props: Ditto

11:54 AM Changeset in webkit [162851] by Brent Fulgham

4 edits in branches/safari-537.75-branch/Source/WTF

Merge r162850

2014-01-27 Brent Fulgham <Brent Fulgham>

[Win] Unreviewed build correction.

WTF.vcxproj/WTFGeneratedCommon.props: Export PLATFORMARCHITECTURE macro for use in Makefiles and shell scripts.
WTF.vcxproj/build-generated-files.sh: Output header search path to identify when the build is confused about build architecture.

11:49 AM Changeset in webkit [162850] by commit-queue@webkit.org

2 edits in trunk/Tools

Unreviewed, rolling out r162846.
http://trac.webkit.org/changeset/162846
https://bugs.webkit.org/show_bug.cgi?id=127695

"Broke the WebKit Bot Watcher's Dashboard; will fix offline"
(Requested by dydz on #webkit).

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(BuildbotIteration.prototype.update.):

11:42 AM Changeset in webkit [162849] by fpizlo@apple.com

4 edits
1 add in branches/jsCStack/Source/JavaScriptCore

FTL should do polyvariant PutById inlining
https://bugs.webkit.org/show_bug.cgi?id=127692

Reviewed by Mark Hahnenberg.

Expanded the existign GetById polyvariance support to include PutByIds as well.

bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::hasExitSite):
(JSC::PutByIdStatus::computeFor):
(JSC::PutByIdStatus::computeForStubInfo):

bytecode/PutByIdStatus.h:
dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

tests/stress/simple-polyvariant-put-by-id-inlining-example.js: Added.

(foo):
(fuzz):
(bar):

11:15 AM Changeset in webkit [162848] by zoltan@webkit.org

6 edits in trunk

[CSS Shapes] inset() function with multiple spaces on element style
https://bugs.webkit.org/show_bug.cgi?id=127617

Reviewed by Dirk Schulze.

Source/WebCore:

When only a subset of parameters were defined for an inset shape, the built
inset string contained some extra spaces. This patch fixes the behavior and
adds tests for the case. I also removed the string allocation optimization from
buildInsetString, since it's not worthwhile to always allocate as many memory
as needed for a fully defined inset.

I added the new test cases to the shapes parser code test.

css/CSSBasicShapes.cpp:

(WebCore::buildInsetString):

LayoutTests:

fast/shapes/parsing/parsing-shape-inside-expected.txt:
fast/shapes/parsing/parsing-shape-outside-expected.txt:
fast/shapes/parsing/parsing-test-utils.js:

11:08 AM Changeset in webkit [162847] by dbates@webkit.org

3 edits in trunk/Tools

Add support for displaying results from multiple Buildbots on WebKit Bot Watcher's Dashboard
https://bugs.webkit.org/show_bug.cgi?id=127564

Reviewed by Alexey Proskuryakov.

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:

11:06 AM Changeset in webkit [162846] by dbates@webkit.org

2 edits in trunk/Tools

Teach Buildbot dashboard to parse alternative revision format
https://bugs.webkit.org/show_bug.cgi?id=127561

Reviewed by Alexey Proskuryakov.

Add support for extracting the OpenSource and Internal revision numbers when Buildbot
returns a dictionary for the value of property got_revision.

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(parseRevisionProperty): Added; parses Buildbot revision property, which can either be a
string or a dictionary.
(BuildbotIteration.prototype.update.): Modified to call parseRevisionProperty() to determine
the OpenSource and Internal revision numbers.

10:53 AM Changeset in webkit [162845] by mark.lam@apple.com

3 edits in trunk/Source/JavaScriptCore

Remove unused CodeBlock::createActivation().
<https://webkit.org/b/127686>

Reviewed by Filip Pizlo.

bytecode/CodeBlock.cpp:
bytecode/CodeBlock.h:

9:48 AM Changeset in webkit [162844] by Antti Koivisto

2 edits in trunk/Source/WebCore

WebCore.exp.in: Add export needed for iOS.

9:12 AM Changeset in webkit [162843] by Antti Koivisto

2 edits in trunk/Source/WebCore

REGRESSION(r133214): Don't invalidate style when adding classes that don't match rules
https://bugs.webkit.org/show_bug.cgi?id=126177

Reviewed by Anders Carlsson.

Spotted by Elliott Sprehn in Chromium.

dom/Element.cpp:

(WebCore::checkSelectorForClassChange):

Remove unnecessary templating.

(WebCore::Element::classAttributeChanged):

Fix logic error with 'continue'.

8:57 AM Changeset in webkit [162842] by b.long@cablelabs.com

2 edits in trunk/Source/WebCore

[GStreamer] Lockup when playing Icecast radio
https://bugs.webkit.org/show_bug.cgi?id=127452

Reviewed by Philippe Normand.

No new tests. This bug can only be demonstrated with an Icecast stream, and it's
not clear how to do that in our testing framework.

platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(StreamingClient::handleResponseReceived): Wait until we unlock to send notifications.

8:49 AM Changeset in webkit [162841] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Typo fix after r162838.

platform/wk2/TestExpectations:

8:31 AM Changeset in webkit [162840] by jberlin@webkit.org

2 edits in trunk/Source/WebCore

Build fix after r162838.

page/FrameView.cpp:

Remove an unused constant.

8:27 AM Changeset in webkit [162839] by hyatt@apple.com

9 edits in trunk/Source/WebCore

Remove repaint throttling
https://bugs.webkit.org/show_bug.cgi?id=127681

Patch by Antti Koivisto <Antti Koivisto> on 2014-01-27
Reviewed by Sam Weinig.

Nowadays we throttle layer flushes. This code is unnecessary.

WebCore.exp.in:
dom/Document.cpp:

(WebCore::Document::recalcStyle):

dom/Element.cpp:

(WebCore::Element::classAttributeChanged):

editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::insertDictatedText):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkCompleted):

page/EventHandler.cpp:

(WebCore::EventHandler::dispatchDragEvent):
(WebCore::EventHandler::dispatchMouseEvent):
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::handleTextInputEvent):

page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::flushCompositingStateForThisFrame):
(WebCore::FrameView::layout):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::disableLayerFlushThrottlingTemporarilyForInteraction):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):

page/FrameView.h:
rendering/RenderView.cpp:

(WebCore::RenderView::setSelection):

8:18 AM Changeset in webkit [162838] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed gardening, unskip now passing tests.

platform/wk2/TestExpectations:

7:11 AM Changeset in webkit [162837] by Antti Koivisto

12 edits in trunk/Source

Remove repaint throttling
https://bugs.webkit.org/show_bug.cgi?id=127681

Reviewed by Sam Weinig.

Nowadays we throttle layer flushes. This code is unnecessary.

WebCore.exp.in:
dom/Document.cpp:

(WebCore::Document::recalcStyle):

dom/Element.cpp:

(WebCore::Element::classAttributeChanged):

editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::insertDictatedText):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkCompleted):

page/EventHandler.cpp:

(WebCore::EventHandler::dispatchDragEvent):
(WebCore::EventHandler::dispatchMouseEvent):
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::handleTextInputEvent):

page/FrameView.cpp:

page/FrameView.h:
rendering/RenderView.cpp:

(WebCore::RenderView::setSelection):

7:05 AM Changeset in webkit [162836] by eric.carlson@apple.com

8 edits in trunk/Source/WebCore

Merge Chromium TextTrack cleanups
https://bugs.webkit.org/show_bug.cgi?id=127483

Reviewed by Darin Adler.

Merge some TextTrack cleanups:
https://chromium.googlesource.com/chromium/blink/+/b571b9fbc6e62e05aa77a402cf8f447e681b8ee3
https://chromium.googlesource.com/chromium/blink/+/6b1940151258150ea01bcf21ebfd958e2af247f4
https://chromium.googlesource.com/chromium/blink/+/397c2a2d9416f5c0d79bca22d6979f174eefcce2
https://chromium.googlesource.com/chromium/blink/+/f42ad93e25c6310b2b0327ab7ce5d82d3c4a6c1b
https://chromium.googlesource.com/chromium/blink/+/d55b52b53b7da05bba5fe378a4278250b9347430
https://chromium.googlesource.com/chromium/blink/+/cac766ecaaac477a08879f0b3157d0327cc75d96
https://chromium.googlesource.com/chromium/blink/+/6197ce278696cdd52fc2ad81893f369492468ca0

html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::loadTimerFired): Remove the LoadableTextTrack* parameter, it isn't used.
(WebCore::HTMLTrackElement::didCompleteLoad): Ditto.

html/HTMLTrackElement.h: didCompleteLoad doesn't need to be virtual.

html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::loadTimerFired): Pass a reference, not a pointer.
(WebCore::LoadableTextTrack::cueLoadingStarted): Removed, it wasn't used.
(WebCore::LoadableTextTrack::cueLoadingCompleted): Pass a reference, not a pointer.

html/track/LoadableTextTrack.h: Delete LoadableTextTrackClient, it is no longer used.

loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::TextTrackLoader): Take a TextTrackLoaderClient reference.
(WebCore::TextTrackLoader::~TextTrackLoader): Rename m_cachedCueData m_resource.
(WebCore::TextTrackLoader::cueLoadTimerFired): m_client is a reference.
(WebCore::TextTrackLoader::cancelLoad): m_cachedCueData -> m_resource.
(WebCore::TextTrackLoader::processNewCueData): Ditto.
(WebCore::TextTrackLoader::deprecatedDidReceiveCachedResource): Ditto.
(WebCore::TextTrackLoader::notifyFinished): Ditto.
(WebCore::TextTrackLoader::load): shouldLoadCues was removed from the client interface because

the only implementation always returned true.

(WebCore::TextTrackLoader::newRegionsParsed): m_client is a reference

loader/TextTrackLoader.h:

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::canRequest): Remove an outdated comment.

5:14 AM Changeset in webkit [162835] by Carlos Garcia Campos

14 edits in trunk

[GTK] Implement custom URI schemes with CustomProtocols
https://bugs.webkit.org/show_bug.cgi?id=127091

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

The old classes are no longer built for GTK+ and should be removed once
other ports using soup backend switch to custom protocols implementation.

GNUmakefile.am: Remove include path.
GNUmakefile.list.am: Remove files from compilation.
PlatformGTK.cmake: Ditto.
UIProcess/API/gtk/WebKitPrivate.h:
UIProcess/API/gtk/WebKitRequestManagerClient.cpp:

(startLoading):
(stopLoading):
(attachRequestManagerClientToContext):

UIProcess/API/gtk/WebKitURISchemeRequest.cpp:

(webkitURISchemeRequestCreate):
(webkit_uri_scheme_request_get_web_view):
(webkitURISchemeRequestReadCallback):
(webkit_uri_scheme_request_finish):
(webkit_uri_scheme_request_finish_error):

UIProcess/API/gtk/WebKitURISchemeRequestPrivate.h:
UIProcess/API/gtk/WebKitWebContext.cpp:

(createDefaultWebContext):
(webkit_web_context_register_uri_scheme):
(webkitWebContextGetRequestManager):
(webkitWebContextStartLoadingCustomProtocol):
(webkitWebContextStopLoadingCustomProtocol):
(webkitWebContextDidFinishLoadingCustomProtocol):

UIProcess/API/gtk/WebKitWebContextPrivate.h:
UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

WebKit2Prefix.h: Enable CustomProtocols unconditionally for the

GTK+ port.

Tools:

Temporarily disable the WebKitWebView check until we figure out
how to implement it with CustomProtocols.

TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:

4:40 AM Changeset in webkit [162834] by Csaba Osztrogonác

2 edits in trunk/Source/WebCore

AX: Disable accessibility after every test run
https://bugs.webkit.org/show_bug.cgi?id=127439

Patch by Chris Fleizach <Chris Fleizach> on 2014-01-27
Reviewed by Csaba Osztrogonác.

Speculative fix for EFL build. Don't process these notifications unless accessibility is enabled.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::prepareForLoadStart):

3:13 AM Changeset in webkit [162833] by Csaba Osztrogonác

2 edits in trunk/Source/WebCore

Buildfix for !ENABLE(COMPARE_AND_SWAP) platforms after r162774
https://bugs.webkit.org/show_bug.cgi?id=127678

Reviewed by Zoltan Herczeg.

platform/text/TextBreakIterator.cpp:

(WebCore::compareAndSwapNonSharedCharacterBreakIterator):
Use std::mutex instead of Mutex and std::lock_guard instead of MutexLocker.

2:46 AM Changeset in webkit [162832] by Csaba Osztrogonác

5 edits
1 delete in trunk/LayoutTests

[Mac] fast/profiler/stop-profiling-after-setTimeout.html and fast/profiler/dead-time.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=84102

Reviewed by Darin Adler.

fast/profiler/dead-time-expected.txt: Updated.
fast/profiler/stop-profiling-after-setTimeout-expected.txt: Updated.
platform/efl/TestExpectations: Unskip tests.
platform/gtk/fast/profiler/dead-time-expected.txt: Removed.
platform/gtk/fast/profiler/stop-profiling-after-setTimeout-expected.txt: Removed.
platform/mac/TestExpectations: Unskip tests.

1:09 AM Changeset in webkit [162831] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit/mac

Another iOS build fix.

Misc/WebElementDictionary.mm:

(-[WebElementDictionary _image]):
We were apparently depending on Image::getNSImage() being defined
(yet always returning nullptr) on iOS.

12:27 AM Changeset in webkit [162830] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit2

[SOUP] WebProcess sometimes crashes when a download is cancelled
https://bugs.webkit.org/show_bug.cgi?id=127650

Reviewed by Martin Robinson.

The problem is that when the download is cancelled, the download
manager removes the download from the map and it's deleted. The
Download destructor calls platformInvalidate() that cancels the
resource handle if there's still one. We set to nullptr the
ResourceHandle when the download is cancelled to avoid cancelling
it twice, but it's done after calling Download::didCancel(). It
should be done before, because at that moment, when the download
is deleted, the resource handle pointer is still valid.

Shared/Downloads/soup/DownloadSoup.cpp:

(WebKit::Download::cancel):

12:18 AM Changeset in webkit [162829] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit/gtk

Unreviewed. Fix GTK+ build after r162808.

webkit/webkitwebhistoryitem.cpp:

(webkit_web_history_item_new_with_data):
(webkit_web_history_item_get_last_visited_time):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed