Timeline

Feb 7, 2014:

10:56 PM Changeset in webkit [163695] by fpizlo@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Don't throw away code if there is code on the worklists
​https://bugs.webkit.org/show_bug.cgi?id=128443

Reviewed by Joseph Pecoraro.

If we throw away compiled code and there is code currently being JITed then the JIT
will get confused after it resumes: it will see a code block that had claimed to belong
to an executable except that it doesn't belong to any executables anymore.

• dfg/DFGWorklist.h:

(JSC::DFG::Worklist::isActive):

• heap/Heap.cpp:

(JSC::Heap::deleteAllCompiledCode):

9:59 PM Changeset in webkit [163694] by jinwoo7.song@samsung.com

• 2 edits in trunk/Source/WebKit2

Unreviewed EFL WebKit2 build fix after r163671.

• UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::WebView): Use WebPageConfiguration in creating WebPage.

9:33 PM Changeset in webkit [163693] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebCore

[ASan] Use new/delete in PODFreeListArena
<​http://webkit.org/b/128437>

Reviewed by Oliver Hunt.

• platform/PODFreeListArena.h:

(WebCore::PODFreeListArena::allocateObject): Use new when
ADDRESS_SANITIZER is defined.
(WebCore::PODFreeListArena::freeObject): Use delete when
ADDRESS_SANITIZER is defined.

9:27 PM Changeset in webkit [163692] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

Merge updateSelectionCachesIfSelectionIsInsideTextFormControl into setSelectionWithoutUpdatingAppearance
​https://bugs.webkit.org/show_bug.cgi?id=128439

Reviewed by Anders Carlsson.

FrameSelection::selectAll had a superfluous call to updateSelectionCachesIfSelectionIsInsideTextFormControl
because it wasn't setting UserTriggered option to avoid revealing selection.

Call setSelection with UserTriggered and recently added DoNotRevealSelection option and merge
updateSelectionCachesIfSelectionIsInsideTextFormControl into setSelectionWithoutUpdatingAppearance.

Also rename local variables in setSelectionWithoutUpdatingAppearance, newSelection to
newSelectionPossiblyWithoutDirection and s to newSelection so that they're self explanatory.

In addition, we now update the input element's selection caches before calling
selectFrameElementInParentIfFullySelected but this should be fine because selection cannot simultaneously
select the entire document and be inside a text form control.

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelectionWithoutUpdatingAppearance):
(WebCore::FrameSelection::selectAll):

9:06 PM Changeset in webkit [163691] by fpizlo@apple.com

• 21 edits in trunk/Source/JavaScriptCore

GC should safepoint the DFG worklist in a smarter way rather than just waiting for everything to complete
​https://bugs.webkit.org/show_bug.cgi?id=128297

Reviewed by Oliver Hunt.

This makes DFG worklist threads have a rightToRun lock that gives them the ability to
be safepointed by the GC in much the same way as you'd expect from a fully
multithreaded VM.

The idea is that the worklist threads's roots are the DFG::Plan. They only touch those
roots when holding the rightToRun lock. They currently grab that lock to run the
compiler, but relinquish it when accessing - and waiting on - the worklist.

• bytecode/CodeBlock.h:

(JSC::CodeBlockSet::mark):

• dfg/DFGCompilationKey.cpp:

(JSC::DFG::CompilationKey::visitChildren):

• dfg/DFGCompilationKey.h:
• dfg/DFGDesiredStructureChains.cpp:

(JSC::DFG::DesiredStructureChains::visitChildren):

• dfg/DFGDesiredStructureChains.h:
• dfg/DFGDesiredTransitions.cpp:

(JSC::DFG::DesiredTransition::visitChildren):
(JSC::DFG::DesiredTransitions::visitChildren):

• dfg/DFGDesiredTransitions.h:
• dfg/DFGDesiredWeakReferences.cpp:

(JSC::DFG::DesiredWeakReferences::visitChildren):

• dfg/DFGDesiredWeakReferences.h:
• dfg/DFGDesiredWriteBarriers.cpp:

(JSC::DFG::DesiredWriteBarrier::visitChildren):
(JSC::DFG::DesiredWriteBarriers::visitChildren):

• dfg/DFGDesiredWriteBarriers.h:
• dfg/DFGPlan.cpp:

(JSC::DFG::Plan::visitChildren):

• dfg/DFGPlan.h:
• dfg/DFGWorklist.cpp:

(JSC::DFG::Worklist::~Worklist):
(JSC::DFG::Worklist::finishCreation):
(JSC::DFG::Worklist::suspendAllThreads):
(JSC::DFG::Worklist::resumeAllThreads):
(JSC::DFG::Worklist::visitChildren):
(JSC::DFG::Worklist::runThread):
(JSC::DFG::Worklist::threadFunction):

• dfg/DFGWorklist.h:

(JSC::DFG::numberOfWorklists):
(JSC::DFG::worklistForIndexOrNull):

• heap/CodeBlockSet.h:
• heap/Heap.cpp:

(JSC::Heap::markRoots):
(JSC::Heap::collect):

• runtime/IntendedStructureChain.cpp:

(JSC::IntendedStructureChain::visitChildren):

• runtime/IntendedStructureChain.h:
• runtime/VM.cpp:

(JSC::VM::~VM):
(JSC::VM::prepareToDiscardCode):

7:54 PM Changeset in webkit [163690] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

EFL build fix attempt after r163662.

• Modules/indexeddb/leveldb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::encodeIDBKey):

7:50 PM Changeset in webkit [163689] by rniwa@webkit.org

• 3 edits in trunk/Source/WebCore

FrameSelection's destructor shouldn't notify accessibility
​https://bugs.webkit.org/show_bug.cgi?id=128421

Reviewed by Benjamin Poulain.

Extracted setSelectionWithoutUpdatingAppearance out of setSelection and called it in prepareForDestruction
instead of setting DoNotUpdateAppearance option. This new function doesn't reveal selection or notify
accessibility code in addition to not updating appearance.

Note that all implementations of notifyAccessibilityForSelectionChange in FrameSelectionAtk.cpp and
FrameSelectionMac.mm exit early when the selection type is not caret or either start or end is null,
which is already the case inside FrameSelection's destructor. In addition, revealSelection is never called
when selection change was not triggered by user so there should be no behavioral change from this patch.

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelectionWithoutUpdatingAppearance):
(WebCore::FrameSelection::setSelection):
(WebCore::FrameSelection::prepareForDestruction):

• editing/FrameSelection.h:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange): Added the trivial implementation in the case
accessibility is disabled to tidy up call sites.

7:11 PM Changeset in webkit [163688] by rniwa@webkit.org

• 61 adds in trunk/Websites/perf.webkit.org

Merge database-common.js and utility.js into run-tests.js.

Reviewed by Matthew Hanson.

Now that run-tests is the only node.js script, merged database-common.js and utility.js into it.
Also moved init-database.sql out of the database directory and removed the directory entirely.

• database: Removed.
• database/database-common.js: Removed.
• database/utility.js: Removed.
• init-database.sql: Moved from database/init-database.sql.
• run-tests.js:

(connect): Moved from database-common.js.
(pathToDatabseSQL): Extracted from pathToLocalScript.
(pathToTests): Moved from database-common.js.
(config): Ditto.
(TaskQueue): Ditto.
(SerializedTaskQueue): Ditto.
(main):
(initializeDatabase):
(TestEnvironment.it):
(TestEnvironment.queryAndFetchAll):
(sendHttpRequest):

7:11 PM Changeset in webkit [163687] by Martin Robinson

• 2 edits in trunk/Source/WebCore

Build fix for the GTK+ CMake build

• PlatformGTK.cmake: VTTCue.idl was unintentionally added to the list of GObject DOM bindings

output files. Remove it.

7:01 PM Changeset in webkit [163686] by krit@webkit.org

• 4 edits in trunk

Per CSSOM, computed rect() function values must be comma separated
​https://bugs.webkit.org/show_bug.cgi?id=128401

Reviewed by Simon Fraser.

Updated tests.

• css/Rect.h:

(WebCore::Rect::generateCSSString):

6:52 PM Changeset in webkit [163685] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unify JSLock implementation for iOS and non-iOS ports.
<​https://webkit.org/b/128409>

Reviewed by Michael Saboff.

The iOS and non-iOS implementations of dropAllLocks(),
dropAllLocksUnconditionally(), and grabAllLocks() effectively do the
same work. The main difference is that the iOS implementation acquires
the JSLock spin lock in the DropAllLocks class while the other ports
acquire it when it calls JSLock::lock() and unlock().

The other difference is that the iOS implementation will only increment
m_locksDropDepth if it actually drops locks, whereas other ports will
increment it unconditionally. Analogously, iOS decrements the depth only
when needed while other ports will decrement it unconditionally when
re-grabbing locks.

We can unify the 2 implementations by having both use the iOS
implementation for a start.

• runtime/JSLock.cpp:

(JSC::JSLock::dropAllLocks):
(JSC::JSLock::dropAllLocksUnconditionally):
(JSC::JSLock::grabAllLocks):
(JSC::JSLock::DropAllLocks::DropAllLocks):
(JSC::JSLock::DropAllLocks::~DropAllLocks):

6:51 PM Changeset in webkit [163684] by barraclough@apple.com

• 4 edits in trunk/Source/WebKit2

Add better comments to code that boosts the NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=128431

Rubber stamped by Tim Horton

• Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:

(WebKit::XPCServiceEventHandler):

• Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:

(WebKit::XPCServiceEventHandler):

• UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::connectToService):

6:42 PM Changeset in webkit [163683] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

Build fix.

• UIProcess/API/ios/WKContentView.mm:

(-[WKContentView initWithFrame:configuration:]):

6:39 PM Changeset in webkit [163682] by zoltan@webkit.org

• 2 edits
  2 adds in trunk/PerformanceTests

[CSS Shapes] Add initial performance tests for inset shape
​https://bugs.webkit.org/show_bug.cgi?id=128378

Reviewed by Ryosuke Niwa.

• Layout/Shapes/ShapeOutsideContentBox.html: Move js to shapes.js.
• Layout/Shapes/ShapeOutsideInset.html: Added.
• Layout/Shapes/resources/shapes.js: Added.

(.):

6:38 PM Changeset in webkit [163681] by andersca@apple.com

• 8 edits in trunk/Source/WebKit2

Pass the preferences through from the WKWebViewConfiguration object
​https://bugs.webkit.org/show_bug.cgi?id=128430

Reviewed by Tim Horton.

• UIProcess/API/Cocoa/WKPreferences.h:
• UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences init]):
Don't return nil if [super init] returns a valid object.

(-[WKPreferences minimumFontSize]):
(-[WKPreferences setMinimumFontSize:]):
Change this property to be unsigned.

• UIProcess/API/Cocoa/WKPreferencesInternal.h:

Use @package.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):
Set up a WebKit::WebPageConfiguration and use the new -[WKView initWithFrame:context:configuration:] method.

• UIProcess/API/ios/WKContentView.mm:

(-[WKContentView initWithFrame:configuration:]):
Set the preferences.

• UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:context:configuration:]):
Add a new initializer that takes a WebContext and a WebPageConfiguration.

(-[WKView _registerDraggedTypes]):
This shouldn't be in the private category.

(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
Call the new initializer.

• UIProcess/API/mac/WKViewInternal.h:

6:28 PM Changeset in webkit [163680] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

Fix the WebKit2 build after r163671.

• UIProcess/API/ios/WKContentView.mm:

(-[WKContentView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):

6:25 PM Changeset in webkit [163679] by barraclough@apple.com

• 16 edits in trunk

Remove isInitialState flag from Page::setViewState
​https://bugs.webkit.org/show_bug.cgi?id=128428

Reviewed by Sam Weinig.

Source/WebCore:

• WebCore.exp.in:
  • removed isInitialState.
• page/Page.cpp:

(WebCore::Page::setViewState):

• removed isInitialState.

(WebCore::Page::setIsVisible):

• removed isInitialState.

(WebCore::Page::setIsVisibleInternal):

• removed isInitialState.

• page/Page.h:
  • removed isInitialState.

Source/WebKit/efl:

• ewk/ewk_view.cpp:

(ewk_view_visibility_state_set):

• don't pass isInitialState to setViewState.

Source/WebKit/gtk:

• WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setPageVisibility):

• don't pass isInitialState to setViewState.

Source/WebKit/mac:

• WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _updateVisibilityState]):
(-[WebView _setIsVisible:]):
(-[WebView _setVisibilityState:isInitialState:]):
(-[WebView _windowWillOrderOnScreen:]):
(-[WebView _windowWillOrderOffScreen:]):

• don't pass isInitialState to setViewState.

Source/WebKit2:

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

• don't pass isInitialState to setViewState.

(WebKit::WebPage::reinitializeWebPage):

• if the viewState changes this should fire a visibility event.

(WebKit::WebPage::setViewState):

• merged with setViewStateInternal.

• WebProcess/WebPage/WebPage.h:
  • removed setViewStateInternal.

LayoutTests:

• fast/events/page-visibility-iframe-delete-test.html:
• fast/events/page-visibility-iframe-move-test.html:
  • resetPageVisibility will now cause additional visibiliy events to fire; clean up the event listeners to avoid this affecting the test results.

6:23 PM Changeset in webkit [163678] by Lucas Forschler

• 13 edits in tags/Safari-538.16.3

Merged r163674.

6:19 PM Changeset in webkit [163677] by Simon Fraser

• 6 edits in trunk/Source

Encode requestedScrollPosition on ScrollingStateScrollingNodes to send to the UI process
​https://bugs.webkit.org/show_bug.cgi?id=128416

Source/WebCore:

Reviewed by Tim Horton.

Change requestedScrollPosition() to be a FloatPoint, and export
ScrollingStateScrollingNode::setRequestedScrollPosition(WebCore::FloatPoint const&, bool)
for WK2.

• WebCore.exp.in:
• page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::setRequestedScrollPosition):

• page/scrolling/ScrollingStateScrollingNode.h:

Source/WebKit2:

Reviewed by Tim Horton.

Encode and decode requestedScrollPosition() and requestedScrollPositionRepresentsProgrammaticScroll(),
which can't use the macros because the setter takes both arguments.

The UI process needs this to notice programmatic scrolls.

• Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:

(ArgumentCoder<ScrollingStateScrollingNode>::encode):
(ArgumentCoder<ScrollingStateScrollingNode>::decode):

6:19 PM Changeset in webkit [163676] by Simon Fraser

• 7 edits in trunk/Source/WebKit2

Add typesafe casts for DrawingAreaProxy classes
​https://bugs.webkit.org/show_bug.cgi?id=128419

Reviewed by Andreas Kling.

Add typesafe casts, and use one in RemoteScrollingCoordinatorProxy::layerTreeHost().

• UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::layerTreeHost):

• UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
• UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::contentsSizeChanged):

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

6:12 PM Changeset in webkit [163675] by Beth Dakin

• 12 edits in trunk

Should get rid of TileController's CoverageForSlowScrolling mode
​https://bugs.webkit.org/show_bug.cgi?id=128339

Reviewed by Simon Fraser.

Source/WebCore:

This patch gets rid of CoverageForSlowScrolling in the TileController. It also
makes sure that margin tiles are properly invalidated on pages with slow repaint
objects that cause slow scrolling.

When we invalidate because of slow scrolling, don’t clip the update rect to the
layer bounds.

• page/FrameView.cpp:

(WebCore::FrameView::scrollContentsSlowPath):

Call new RenderObject paint function repaintSlowRepaintObject() instead of the
more-generic repaint().
(WebCore::FrameView::repaintSlowRepaintObjects):

Remove CoverageForSlowScrolling.

• platform/graphics/TiledBacking.h:
• platform/graphics/ca/mac/TileController.h:
• platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::tilesWouldChangeForVisibleRect):
(WebCore::TileController::computeTileCoverageRect):
(WebCore::TileController::revalidateTiles):

• rendering/RenderLayerBacking.cpp:

(WebCore::computeTileCoverage):

Handle repainting a slow repaint object. Don’t clip when we shouldn’t, use the
RenderView’s backgroundRect as a repaintRect when this is the root background
since that will take the extended background rect into consideration.

• rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintSlowRepaintObject):

• rendering/RenderObject.h:

LayoutTests:

Slow scrolling no longer creates tiles of a different size.

• platform/mac-wk2/tiled-drawing/fixed-background/fixed-non-propagated-body-background-expected.txt:
• platform/mac-wk2/tiled-drawing/tile-coverage-slow-scrolling-expected.txt:
• platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed-expected.txt:

6:11 PM Changeset in webkit [163674] by fpizlo@apple.com

• 13 edits in trunk

More FTL build scaffolding
​https://bugs.webkit.org/show_bug.cgi?id=128330

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:
• llvm/library/LLVMAnchor.cpp:

Source/WebCore:

The FTL already has tests.

• Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

• Configurations/FeatureDefines.xcconfig:

Source/WTF:

• wtf/Platform.h:

Tools:

• Scripts/copy-webkitlibraries-to-product-directory:

6:02 PM Changeset in webkit [163673] by timothy_horton@apple.com

• 4 edits in trunk/Source/WebKit2

Move allowsBackForwardNavigationGestures back to private because apparently our build systems are broken.

• UIProcess/API/Cocoa/WKView.h:
• UIProcess/API/Cocoa/WKViewPrivate.h:
• UIProcess/API/mac/WKView.mm:

(-[WKView setAllowsBackForwardNavigationGestures:]):
(-[WKView allowsBackForwardNavigationGestures]):

6:01 PM Changeset in webkit [163672] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

iOS port needs to clear VM::stackPointerAtVMEntry when it drops locks.
<​https://webkit.org/b/128424>

Reviewed by Geoffrey Garen.

The iOS code path for dropping locks differ from the non-iOS code path
in that it (iOS) does not clear m_vm->stackPointerAtVMEntry nor reset the
VM stack limit. This is now fixed by copying that snippit from
JSLock::unlock().

• runtime/JSLock.cpp:

(JSC::JSLock::dropAllLocks):
(JSC::JSLock::dropAllLocksUnconditionally):

5:57 PM Changeset in webkit [163671] by andersca@apple.com

• 9 edits in trunk/Source/WebKit2

Simplify web page creation
​https://bugs.webkit.org/show_bug.cgi?id=128425

Reviewed by Andreas Kling.

Add a WebPageConfiguration class and stick the page group, preferences, session etc there
instead of adding more and more parameters to the WebPageProxy constructor.

Make WebContext::createWebPage fill in the missing pieces in the WebPageConfiguration object.

• UIProcess/API/ios/WKContentView.mm:

(-[WKContentView initWithFrame:configuration:]):
(-[WKContentView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):

• UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

• UIProcess/WebContext.cpp:

(WebKit::WebContext::createWebPage):

• UIProcess/WebContext.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):

• UIProcess/WebPageProxy.h:
• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createWebPage):

• UIProcess/WebProcessProxy.h:

5:49 PM Changeset in webkit [163670] by timothy_horton@apple.com

• 2 edits in trunk/Tools

Touch Minibrowser for a hopeful build fix.

• MiniBrowser/mac/WK2BrowserWindowController.m:

5:25 PM Changeset in webkit [163669] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

Build fix. Wrong section of the file.

• UIProcess/API/mac/WKView.mm:

(-[WKView setAllowsBackForwardNavigationGestures:]):
(-[WKView allowsBackForwardNavigationGestures]):

5:10 PM Changeset in webkit [163668] by benjamin@webkit.org

• 2 edits in trunk/Source/WebKit2

[WK2] The WebPageProxy's copy of pageScaleFactor is not update when the scale is changed from the viewport configuration
​https://bugs.webkit.org/show_bug.cgi?id=128415

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-02-07
Reviewed by Simon Fraser.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::viewportConfigurationChanged):
The scale needs to be updated through WebPage::scalePage().

5:09 PM Changeset in webkit [163667] by ap@apple.com

• 3 edits in trunk/Source/WebCore

Remove some unused functions from SerializedScriptValue
​https://bugs.webkit.org/show_bug.cgi?id=128407

Reviewed by Anders Carlsson.

• bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::nullValue):

• bindings/js/SerializedScriptValue.h:

4:58 PM Changeset in webkit [163666] by timothy_horton@apple.com

• 18 edits
  1 add in trunk/Source/WebKit2

WebKit2 View Gestures (Swipe): Support for iOS
​https://bugs.webkit.org/show_bug.cgi?id=128363
<rdar://problem/15194194>

Reviewed by Anders Carlsson.

• Shared/mac/RemoteLayerTreeTransaction.h:

(WebKit::RemoteLayerTreeTransaction::renderTreeSize):
(WebKit::RemoteLayerTreeTransaction::setRenderTreeSize):

• Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):

• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
Send the render tree size along with remote layer tree commits,
so that we can act upon it (to hide snapshots) in the UI process
in sync with layer commits.

• UIProcess/API/Cocoa/WKViewPrivate.h:

We want allowsBackForwardNavigationGestures for both platforms.

• UIProcess/API/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::takeViewSnapshot):

• UIProcess/API/ios/WKContentView.h:
• UIProcess/API/ios/WKContentView.mm:

(-[WKContentView _takeViewSnapshot]):

• UIProcess/API/ios/WKContentViewInternal.h:

Plumb snapshotting through to WKViewIOS.

• UIProcess/API/ios/WKViewIOS.mm:

(-[WKView setAllowsBackForwardNavigationGestures:]):
(-[WKView allowsBackForwardNavigationGestures]):
Create/destroy the gesture controller when we turn on/off back-forward swipe.
Tell WebPageProxy to save snapshots if swipe is enabled.

(-[WKView contentView:didCommitLayerTree:]):
Forward the current transaction's render tree size to ViewGestureController.

(-[WKView takeViewSnapshotForContentView:]):
Snapshot the view. This is not the best SPI to use, we should consider
using one of those which returns an IOSurface and plumbing it through
to ViewSnapshotStore, but all of our PageClient abstraction makes that annoying.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::recordNavigationSnapshot):
Record snapshots on iOS as well.

• UIProcess/ios/ViewGestureControllerIOS.mm: Added.

(-[WKSwipeInteractiveTransitionDelegate initWithViewGestureController:WebKit::swipingView:]):
(-[WKSwipeInteractiveTransitionDelegate WebKit::ViewGestureController::directionForTransition:]):
(-[WKSwipeInteractiveTransitionDelegate startInteractiveTransition:]):
(-[WKSwipeInteractiveTransitionDelegate shouldBeginInteractiveTransition:]):
(-[WKSwipeInteractiveTransitionDelegate interactiveTransition:gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKSwipeInteractiveTransitionDelegate interactiveTransition:gestureRecognizer:shouldReceiveTouch:]):
(-[WKSwipeInteractiveTransitionDelegate gestureRecognizerForInteractiveTransition:WithTarget:action:]):
(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::~ViewGestureController):
(WebKit::ViewGestureController::installSwipeHandler):
(WebKit::ViewGestureController::beginSwipeGesture):
(WebKit::ViewGestureController::canSwipeInDirection):
(WebKit::ViewGestureController::endSwipeGesture):
(WebKit::ViewGestureController::setRenderTreeSize):
(WebKit::ViewGestureController::swipeSnapshotWatchdogTimerFired):
(WebKit::ViewGestureController::removeSwipeSnapshot):

• UIProcess/mac/ViewGestureController.h:

Add iOS-specific methods, and don't include all of the Mac-specific code.
We can move towards sharing more logic in the future.

• UIProcess/mac/ViewGestureController.messages.in:
• UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::ViewGestureController):

• UIProcess/mac/ViewSnapshotStore.h:
• UIProcess/mac/ViewSnapshotStore.mm:

(WebKit::ViewSnapshotStore::recordSnapshot):
(WebKit::ViewSnapshotStore::snapshotAndRenderTreeSize):
Make ViewSnapshotStore build/work without IOSurface.

• WebKit2.xcodeproj/project.pbxproj:

4:55 PM Changeset in webkit [163665] by mark.lam@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Removed superflous JSLock::entryStackPointer field.
<​https://webkit.org/b/128413>

Reviewed by Geoffrey Garen.

• runtime/JSLock.cpp:

(JSC::JSLock::lock):

• runtime/JSLock.h:

4:46 PM Changeset in webkit [163664] by mark.lam@apple.com

• 5 edits in trunk/Source/JavaScriptCore

Revert workaround committed in ​http://trac.webkit.org/r163595.
<​https://webkit.org/b/128408>

Reviewed by Geoffrey Garen.

Now that we have fixed the bugs in JSLock's stack limit adjusments
in ​https://bugs.webkit.org/show_bug.cgi?id=128406, we can revert the
workaround in r163595.

• API/JSContextRef.cpp:

(JSContextGroupCreate):
(JSGlobalContextCreateInGroup):

• API/tests/testapi.js:
• runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::updateStackLimitWithReservedZoneSize):

• runtime/VM.h:

4:37 PM Changeset in webkit [163663] by andersca@apple.com

• 6 edits
  1 copy in trunk/Source/WebKit2

Implement more of WKPreferences
​https://bugs.webkit.org/show_bug.cgi?id=128411

Reviewed by Tim Horton.

Give WKPreferences an underlying WebKit::WebPreferences object, add a minimumFontSize preference
and make sure that WKWebView's initializer creates a WKPreferences object if the configuration doesn't specify one.

• UIProcess/API/Cocoa/WKPreferences.h:
• UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences init]):
(-[WKPreferences minimumFontSize]):
(-[WKPreferences setMinimumFontSize:]):

• UIProcess/API/Cocoa/WKPreferencesInternal.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm.
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):

• UIProcess/WebPageProxy.h:
• WebKit2.xcodeproj/project.pbxproj:

4:30 PM Changeset in webkit [163662] by beidson@apple.com

• 21 edits in trunk

IDB: Some Mozilla cursor mutation tests fail
<rdar://problem/16011680> and ​https://bugs.webkit.org/show_bug.cgi?id=128374

Reviewed by Sam Weinig.

Source/WebCore:

Tested by:
storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html
storage/indexeddb/mozilla/cursor-mutation.html

The previous comment about LevelDB was wrong.
Apparently calling onSuccess() with a null SharedBuffer means the cursor reached the end.
Update to distinguish between an error and reaching the end:

• Modules/indexeddb/IDBCursorBackendOperations.cpp:

(WebCore::CursorAdvanceOperation::perform):
(WebCore::CursorIterationOperation::perform):

Add a new IDBKey type - Maximum - To be used in comparisons between keys.
This will allow the DatabaseProcess to operate on the range of all keys:

• Modules/indexeddb/IDBKey.cpp:

(WebCore::IDBKey::compare):

• Modules/indexeddb/IDBKey.h:

• Modules/indexeddb/IDBKeyData.cpp:

(WebCore::IDBKeyData::IDBKeyData):
(WebCore::IDBKeyData::maybeCreateIDBKey):
(WebCore::IDBKeyData::isolatedCopy):
(WebCore::IDBKeyData::encode):
(WebCore::IDBKeyData::decode):
(WebCore::IDBKeyData::compare):
(WebCore::IDBKeyData::loggingString):

• Modules/indexeddb/IDBKeyData.h:

(WebCore::IDBKeyData::minimum):
(WebCore::IDBKeyData::maximum):

• bindings/js/IDBBindingUtilities.cpp:

(WebCore::idbKeyToJSValue):

Remove an unused callback:

• Modules/indexeddb/IDBCallbacks.h:
• Modules/indexeddb/IDBRequest.h:

Source/WebKit2:

After a SQLite statement is prepared, stepping it will not pick up any subsequent changes
to the object store.

By keeping track of the current record we’re looking at in the object store and being told
that the object store changed its contents, we can reset the statement to pick up where it
left off but with the new object store contents.

• DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::putRecordInBackingStore): Tell the backing store to notify

its cursors that the object store changed its records.

(WebKit::UniqueIDBDatabase::deleteRangeInBackingStore): Ditto.

• DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
• DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::notifyCursorsOfChanges): Tell the transaction

to notify its cursors that the object store changed its records.

• DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:

• DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.cpp:

(WebKit::SQLiteIDBTransaction::notifyCursorsOfChanges): Tell the relevant cursors that their

object store changed its records.

• DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.h:

• DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:

(WebKit::SQLiteIDBCursor::SQLiteIDBCursor):
(WebKit::getIndexStatement): All statements now have a lower and upper range. By default we bind

IDBKey::Minimum to the lower range and IDBKey::Maximum to the upper range.

(WebKit::getObjectStoreStatement): Ditto.
(WebKit::SQLiteIDBCursor::establishStatement):
(WebKit::SQLiteIDBCursor::createSQLiteStatement):
(WebKit::SQLiteIDBCursor::objectStoreRecordsChanged): Set the flag indicating the statement

needs to be reset and rebound.

(WebKit::SQLiteIDBCursor::resetAndRebindStatement):
(WebKit::SQLiteIDBCursor::bindArguments): Factored out to be shared between statement prepare()

and statement reset().

(WebKit::SQLiteIDBCursor::advance):
(WebKit::SQLiteIDBCursor::advanceOnce): If the statement needs to be reset, do so before advancing it.
(WebKit::SQLiteIDBCursor::internalAdvanceOnce): In a few cases, tell advanceOnce that it needs to

try again because it is on a missing record or is repeating a record.

• DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.h:

(WebKit::SQLiteIDBCursor::objectStoreID):

Make sure Maximum and Minimum keys are never sent across IPC, as that doesn’t make sense:

• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<IDBKeyData>::encode):
(IPC::ArgumentCoder<IDBKeyData>::decode):

LayoutTests:

• platform/mac-wk2/TestExpectations: Add two tests that now pass.

4:24 PM Changeset in webkit [163661] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Fix bug in stack limit adjustments in JSLock.
<​https://webkit.org/b/128406>

Reviewed by Geoffrey Garen.

1. JSLock::unlock() was only clearing the VM::stackPointerAtEntry when m_vm->stackPointerAtVMEntry == entryStackPointer. FYI, entryStackPointer is a field in JSLock.

When DropAllLocks::~DropAllLocks() will call JSLock::grabAllLocks()
to relock the JSLock, JSLock::grabAllLocks() will set a new
entryStackPointer value. Thereafter, DropAllLocks::~DropAllLocks() will
restore the saved VM::stackPointerAtEntry, which will now defer from
the JSLock's entryStackPointer value.

It turns out that when m_vm->stackPointerAtVMEntry was initialized,
it was set to whatever value entryStackPointer is set to. At no time
do we ever expect the 2 values to differ. The only time it differs is
when this bug manifests.

The fix is to remove the entryStackPointer field in JSLock and its uses
altogether.

2. DropAllLocks was unconditionally clearing VM::stackPointerAtEntry in its constructor instead of letting JSLock::unlock() do the clearing.

However, DropAllLocks will not actually drop locks if it isn't required
to (e.g. when alwaysDropLocks is DontAlwaysDropLocks), and when we've
already drop locks once (i.e. JSLock::m_lockDropDepth is not 0).

We should not have cleared VM::stackPointerAtEntry here if we don't
actually drop the locks.

• runtime/JSLock.cpp:

(JSC::JSLock::unlock):
(JSC::JSLock::DropAllLocks::DropAllLocks):

4:19 PM Changeset in webkit [163660] by mitz@apple.com

• 2 edits in trunk/Source/WebKit/mac

iOS build fix.

• Misc/WebElementDictionary.mm:

(+[WebElementDictionary initializeLookupTable]):
(-[WebElementDictionary _image]):
(-[WebElementDictionary _imageRect]):

4:16 PM Changeset in webkit [163659] by roger_fong@apple.com

• 2 edits in trunk/Source/WebCore

CGContextGetUserSpaceToDeviceSpaceTransform returns the wrong value on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=128395.

Rubberstamped by Zalan Bujtas.

The call essentially returns 0 and causes an assertion failure when running many layout tests.

• platform/graphics/cg/GraphicsContextCG.cpp: Don't make the call on Windows. We default to 1.

(WebCore::GraphicsContext::platformInit):

4:07 PM Changeset in webkit [163658] by mitz@apple.com

• 2 edits in trunk/Source/WebCore

iOS build fix.

• platform/PlatformKeyboardEvent.h: Fixed a typo.

3:37 PM Changeset in webkit [163657] by mitz@apple.com

• 104 edits in trunk/Source/WebCore

Stop using PLATFORM(MAC) in WebCore/platform except where it means “OS X but not iOS”
​https://bugs.webkit.org/show_bug.cgi?id=128404

Reviewed by Anders Carlsson.

• Configurations/WebCore.xcconfig: Removed KeyEventMac.mm from

EXCLUDED_SOURCE_FILE_NAMES_iphoneos, because that file contains !PLATFORM(IOS) guards.
Removed WheelEventMac.mm from the same definition, because that file no longer exists.

• platform/ContentFilter.h: Changed PLATFORM(MAC) to PLATFORM(COCOA).
• platform/ContextMenu.h: Ditto.
• platform/ContextMenuItem.h: Ditto.
• platform/Cursor.cpp: Ditto.
• platform/Cursor.h: Ditto.
• platform/DragData.cpp: Ditto.
• platform/DragImage.cpp: Ditto.
• platform/Language.cpp:

(WebCore::displayNameForLanguageLocale): Changed PLATFORM(MAC) to USE(CF) && !PLATFORM(WIN).

• platform/LocalizedStrings.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).

(WebCore::contextMenuItemTagSearchWeb):

• platform/LocalizedStrings.h: Ditto.
• platform/MIMETypeRegistry.cpp: Ditto.

(WebCore::initializeSupportedImageMIMETypesForEncoding):

• platform/PasteboardStrategy.h: Ditto.
• platform/PlatformKeyboardEvent.h: Ditto.
• platform/PlatformMenuDescription.h: Ditto.
• platform/PlatformSpeechSynthesizer.h: Ditto.
• platform/PlatformWheelEvent.h: Ditto.

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

• platform/SchemeRegistry.cpp: Ditto.

(WebCore::localURLSchemes):
(WebCore::SchemeRegistry::removeURLSchemeRegisteredAsLocal):
(WebCore::SchemeRegistry::shouldCacheResponsesFromURLSchemeIndefinitely):

• platform/ScrollAnimator.cpp: Ditto.

(WebCore::ScrollAnimator::handleWheelEvent):

• platform/ScrollAnimator.h: Ditto.
• platform/ScrollView.cpp: Ditto.
• platform/ScrollView.h: Ditto.
• platform/ScrollbarThemeComposite.h: Ditto.
• platform/SharedBuffer.h: Changed PLATFORM(MAC) to USE(FOUNDATION) around NSData-related

code.

• platform/URL.h: Changed PLATFORM(MAC) to USE(FOUNDATION) around NSURL-related code.
• platform/Widget.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
• platform/Widget.h: Ditto.
• platform/audio/AudioSession.cpp: Changed !PLATFORM(MAC) && !PLATFORM(IOS) to

!PLATFORM(COCOA).

• platform/audio/HRTFElevation.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
• platform/audio/MediaSessionManager.cpp: Ditto.
• platform/audio/mac/AudioSessionMac.cpp: Updated comment.
• platform/audio/mac/MediaSessionManagerMac.cpp: Removed PLATFORM(MAC) from Cocoa-only file.
• platform/cf/SharedBufferCF.cpp: Changed !PLATFORM(MAC) to !USE(FOUNDATION) and updated

comment.

• platform/cf/URLCF.cpp: Changed !PLATFORM(MAC) to !USE(FOUNDATION).
• platform/graphics/BitmapImage.h: Changed one instance of PLATFORM(MAC) to

USE(CG)

USE(APPKIT), and another to PLATFORM(COCOA).

• platform/graphics/DisplayRefreshMonitor.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).

(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):

• platform/graphics/DisplayRefreshMonitor.h: Ditto.
• platform/graphics/FloatPoint.h: Collapsed nested #ifs into a single #if.
• platform/graphics/FloatRect.h: Ditto.
• platform/graphics/FloatSize.h: Ditto.
• platform/graphics/Font.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
• platform/graphics/Font.h: Ditto.
• platform/graphics/FontCache.cpp: Ditto.

(WebCore::FontCache::getFontData):

• platform/graphics/FontCache.h: Ditto. Also removed redundant friend class declaration.
• platform/graphics/FontGlyphs.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).

(WebCore::FontGlyphs::glyphDataAndPageForCharacter):

• platform/graphics/GlyphPage.h: Ditto.
• platform/graphics/GraphicsContext3D.h: Ditto.
• platform/graphics/Image.h: Changed PLATFORM(MAC) to USE(APPKIT) around use of NSImage.

Changed another PLATFORM(MAC) to PLATFORM(COCOA).

• platform/graphics/IntRect.h: Collapsed nested #ifs into a single #if.
• platform/graphics/IntSize.h: Ditto.
• platform/graphics/MediaPlayer.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).

(WebCore::installedMediaEngines):
(WebCore::MediaPlayer::supportsType):

• platform/graphics/SimpleFontData.cpp: Ditto.

(WebCore::SimpleFontData::nonSyntheticItalicFontData):
(WebCore::SimpleFontData::DerivedFontData::~DerivedFontData):

• platform/graphics/SimpleFontData.h: Ditto.
• platform/graphics/TiledBacking.h: Ditto.
• platform/graphics/ca/GraphicsLayerCA.cpp: Ditto.

(WebCore::GraphicsLayerCA::filtersCanBeComposited):
(WebCore::GraphicsLayerCA::createPlatformCALayer):

• platform/graphics/ca/LayerFlushScheduler.h: Ditto.
• platform/graphics/ca/PlatformCAAnimation.h: Ditto.
• platform/graphics/ca/PlatformCAFilters.h: Ditto.
• platform/graphics/ca/PlatformCALayer.h: Ditto.
• platform/graphics/cg/BitmapImageCG.cpp: Ditto.
• platform/graphics/cg/GraphicsContextCG.cpp: Ditto.

(WebCore::GraphicsContext::setAllowsFontSmoothing):

• platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: Ditto.
• platform/graphics/cg/ImageBufferCG.cpp: Ditto.
• platform/graphics/cg/ImageBufferDataCG.h: Ditto.
• platform/graphics/cg/ImageCG.cpp: Ditto.
• platform/graphics/cg/ImageSourceCG.cpp: Ditto.

(WebCore::ImageSource::setData):

• platform/graphics/cg/ImageSourceCG.h: Ditto.
• platform/graphics/cg/PathCG.cpp: Ditto.

(WebCore::Path::platformAddPathForRoundedRect):

• platform/graphics/cg/PatternCG.cpp: Ditto.
• platform/graphics/gpu/DrawingBuffer.h: Ditto.
• platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::createQTMovieView): Removed PLATFORM(MAC) guards, since
this file is only used on Mac and iOS.

• platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::supportsExtension): Changed the GL_EXT_draw_buffers check to
match the implementation.

• platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: Changed PLATFORM(MAC) to

PLATFORM(COCOA).

• platform/mac/KeyEventMac.mm: Added !PLATFORM(IOS).
• platform/mac/PlatformEventFactoryMac.h: Changed PLATFORM(MAC) to PLATFORM(COCOA).
• platform/mac/WebCoreSystemInterface.h: Ditto. Removed redundant check for PLATFORM(MAC).
• platform/mac/WebCoreSystemInterface.mm: Removed redundant check for PLATFORM(MAC).

platform/network/Credential.h: Changed PLATFORM(IOS)

PLATFORM(MAC) to PLATFORM(COCOA).

• platform/network/NetworkStateNotifier.h: Changed PLATFORM(MAC) to PLATFORM(COCOA).
• platform/network/NetworkStorageSession.h: Ditto.
• platform/network/NetworkingContext.h: Ditto.
• platform/network/ProtectionSpace.cpp: Ditto.

(WebCore::ProtectionSpace::receivesCredentialSecurely):

• platform/network/ResourceHandle.cpp: Ditto.

(WebCore::ResourceHandle::clearAuthentication):
(WebCore::ResourceHandle::shouldContentSniffURL):

• platform/network/ResourceHandle.h: Ditto.
• platform/network/ResourceHandleClient.cpp: Ditto.
• platform/network/ResourceHandleClient.h: Ditto.
• platform/network/ResourceHandleInternal.h: Ditto.

(WebCore::ResourceHandleInternal::ResourceHandleInternal):

• platform/network/ResourceRequestBase.cpp: Ditto.
• platform/network/cf/AuthenticationCF.h: Ditto.
• platform/network/cf/CookieStorageCFNet.cpp: Ditto.
• platform/network/cf/CredentialStorageCFNet.cpp: Ditto.
• platform/network/cf/FormDataStreamCFNet.cpp: Ditto.
• platform/network/cf/NetworkStorageSessionCFNet.cpp: Ditto.

(WebCore::NetworkStorageSession::switchToNewTestingSession):
(WebCore::NetworkStorageSession::createPrivateBrowsingSession):

• platform/network/cf/ResourceError.h: Ditto.
• platform/network/cf/ResourceHandleCFNet.cpp: Ditto.

(WebCore::ResourceHandle::createCFURLConnection):

• platform/network/cf/ResourceHandleCFURLConnectionDelegate.cpp:
• platform/network/cf/ResourceRequest.h: Ditto.

(WebCore::ResourceRequest::ResourceRequest):

• platform/network/cf/ResourceRequestCFNet.cpp: Ditto.

(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
(WebCore::ResourceRequest::setStorageSession):

• platform/network/cf/ResourceResponse.h: Ditto.
• platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp:

(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveResponse):

• platform/network/mac/ResourceResponseMac.mm: Ditto.
• platform/posix/FileSystemPOSIX.cpp: Changed PLATFORM(MAC) to OS(DARWIN) &&

!PLATFORM(EFL) && !PLATFORM(GTK).

• platform/text/TextBoundaries.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).

3:26 PM Changeset in webkit [163656] by andersca@apple.com

• 9 edits in trunk/Source/WebKit2

Make it possible for each web page to have different preferences
​https://bugs.webkit.org/show_bug.cgi?id=128403

Reviewed by Tim Horton.

• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesCreate):

• UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureNetworkProcess):
(WebKit::WebContext::createNewWebProcess):

• UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::setDatabasePath):

• UIProcess/WebPageGroup.cpp:

(WebKit::WebPageGroup::WebPageGroup):
(WebKit::WebPageGroup::~WebPageGroup):
(WebKit::WebPageGroup::setPreferences):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::~WebPageProxy):
(WebKit::WebPageProxy::setPreferences):
(WebKit::WebPageProxy::preferencesDidChange):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::~WebPreferences):
(WebKit::WebPreferences::addPage):
(WebKit::WebPreferences::removePage):
(WebKit::WebPreferences::update):
(WebKit::WebPreferences::updatePrivateBrowsingValue):
(WebKit::WebPreferences::anyPagesAreUsingPrivateBrowsing):

• UIProcess/WebPreferences.h:

3:07 PM Changeset in webkit [163655] by rniwa@webkit.org

• 7 edits
  3 deletes in trunk

Revert r154384 and r154674 as they broke selection rect computations for text with ligatures.

Source/WebCore:

• platform/graphics/Font.cpp:

(WebCore::Font::drawText):
(WebCore::Font::drawEmphasisMarks):
(WebCore::Font::selectionRectForText):
(WebCore::Font::offsetForPosition):

• platform/graphics/FontFastPath.cpp:

(WebCore::Font::getGlyphsAndAdvancesForSimpleText):
(WebCore::Font::selectionRectForSimpleText):
(WebCore::Font::offsetForPositionForSimpleText):

• platform/graphics/GlyphBuffer.h:
• platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator):
(WebCore::WidthIterator::advanceInternal):
(WebCore::WidthIterator::advanceOneCharacter):

• platform/graphics/WidthIterator.h:

LayoutTests:

• fast/text/partial-textruns-expected.html: Removed.
• fast/text/partial-textruns.html: Removed.
• fast/text/resources/PTS55F-webfont.ttf: Removed.

3:03 PM Changeset in webkit [163654] by benjamin@webkit.org

• 10 edits in trunk/Source

[WK2] Add support for text document viewport configuration
​https://bugs.webkit.org/show_bug.cgi?id=128359

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-02-07
Reviewed by Simon Fraser.

Source/WebCore:

Define a set of ViewportParameters suitable for displaying text documents.
Add a documents class for text document to differentiate them from other type of documents.

• WebCore.exp.in:
• dom/Document.h:

(WebCore::Document::isTextDocument):

• html/TextDocument.cpp:

(WebCore::TextDocument::TextDocument):

• page/ViewportConfiguration.cpp:

(WebCore::ViewportConfiguration::ViewportConfiguration):
(WebCore::ViewportConfiguration::webpageParameters):
(WebCore::ViewportConfiguration::plainTextParameters):

• page/ViewportConfiguration.h:

Source/WebKit2:

When a text document is being loaded, use the plainText viewport parameters.

• UIProcess/API/ios/WKContentView.h:
• UIProcess/API/ios/WKContentView.mm:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didCommitLoad):

3:02 PM Changeset in webkit [163653] by Lucas Forschler

• 2 edits in tags/Safari-538.16.3/Source/JavaScriptCore

Merged r163342.

3:01 PM Changeset in webkit [163652] by Lucas Forschler

• 5 edits in tags/Safari-538.16.3/Source

Versioning.

3:01 PM Changeset in webkit [163651] by Bem Jones-Bey

• 2 edits in trunk/Source/WebCore

FloatingObject::unsafeClone should not copy m_originatingLine
​https://bugs.webkit.org/show_bug.cgi?id=128381

Reviewed by Andreas Kling.

Copying the originatingLine allows to break the invariant that the
floating object must only contain lines that are owned by the renderer
it is attached to.

• rendering/FloatingObjects.cpp:

(WebCore::FloatingObject::unsafeClone):

2:56 PM Changeset in webkit [163650] by Lucas Forschler

• 1 copy in tags/Safari-538.16.3

New Tag.

2:32 PM Changeset in webkit [163649] by b.long@cablelabs.com

• 41 edits
  3 copies
  2 moves
  2 adds in trunk

Update TextTrack API to current spec
​https://bugs.webkit.org/show_bug.cgi?id=122218

Refactoring VTTCue out of TextTrackCue.

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/track-vttcue.html

• CMakeLists.txt: Add VTTCue and rename RenderTextTrackCue to RenderVTTCue.
• DerivedSources.cpp: Same.
• DerivedSources.make: Same.
• GNUmakefile.list.am: Same.
• PlatformGTK.cmake: Same.
• WebCore.vcxproj/WebCore.vcxproj: Same.
• WebCore.vcxproj/WebCore.vcxproj.filters: Same.
• WebCore.xcodeproj/project.pbxproj: Same.
• bindings/js/JSTextTrackCueCustom.cpp:

(WebCore::toJS): Use VTTCue DOM wrapper for VTTCue and its subclasses.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Convert to VTTCue as needed.
(WebCore::HTMLMediaElement::textTrackRemoveCue): Same.

• html/HTMLMediaElement.h: Only print cue.text in debug output if the cue type has a .text attribute
• html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Convert to VTTCue as needed, and fix TextTrackCueBox to VTTCueBox.
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired): Convert to VTTCue as needed.

• html/track/InbandGenericTextTrack.cpp:

(WebCore::InbandGenericTextTrack::addGenericCue): Use refactored VTTCue attributes.

• html/track/InbandWebVTTTextTrack.cpp:

(WebCore::InbandWebVTTTextTrack::newCuesParsed): Use VTTCue's constructor instead of deprecated TextTrackCue constructor.

• html/track/TextTrack.cpp:

(WebCore::TextTrack::setMode): Convert to VTTCue as needed.
(WebCore::TextTrack::hasCue): Make this function only accept VTTCues, since it's only used for them anyway, and convert existing cues to VTTCues as needed.

• html/track/TextTrack.h: Same as hasCue above.
• html/track/TextTrackCue.cpp: Refactor a lot of code out. Everything that was removed went to VTTCue.cpp.

(WebCore::TextTrackCue::create): For backwards compatibility, just call VTTCue::create().
(WebCore::TextTrackCue::TextTrackCue): Refactor a lot of code out.
(WebCore::TextTrackCue::~TextTrackCue): Same.
(WebCore::TextTrackCue::didChange): Same.
(WebCore::TextTrackCue::setIsActive): Same.

• html/track/TextTrackCue.h: Same.
• html/track/TextTrackCue.idl: Remove VTTCue attributes and add custom toJS function.
• html/track/TextTrackCueGeneric.cpp: Use VTTCue instead of TextTrackCue.
• html/track/TextTrackCueGeneric.h: Same.
• html/track/VTTCue.cpp: Copied from Source/WebCore/html/track/TextTrackCue.cpp.
• html/track/VTTCue.h: Copied from Source/WebCore/html/track/TextTrackCue.h.
• html/track/VTTCue.idl: Copied from Source/WebCore/html/track/TextTrackCue.idl.
• loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::getNewCues): Use VTTCue instead of TextTrackCue.

• page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::captionsStyleSheetOverride): Use VTTCueBox instead of TextTrackCueBox.

• rendering/RenderVTTCue.cpp: Renamed from Source/WebCore/rendering/RenderTextTrackCue.cpp. Changed to use VTTCue instead of TextTrackCue.
• rendering/RenderVTTCue.h: Renamed from Source/WebCore/rendering/RenderTextTrackCue.h. Changed to use VTTCue instead of TextTrackCue.
• rendering/RenderingAllInOne.cpp: Rename RenderTextTrackCue to RenderVTTCue.

LayoutTests:

• js/dom/constructor-length.html: Add VTTCue constructor.
• platform/efl/js/dom/global-constructors-attributes-expected.txt: Same.
• platform/efl/js/dom/constructor-length-expected.txt: Same.
• js/dom/global-constructors-attributes-expected.txt: Same.
• platform/gtk-wk2/js/dom/constructor-length-expected.txt: Same.
• platform/gtk-wk2/js/dom/global-constructors-attributes-expected.txt: Same.
• platform/gtk/js/dom/constructor-length-expected.txt: Same.
• platform/gtk/js/dom/global-constructors-attributes-expected.txt: Same.
• platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt: Same.
• platform/mac/js/dom/constructor-length-expected.txt: Same.
• platform/mac/js/dom/global-constructors-attributes-expected.txt: Same.
• platform/win/js/dom/global-constructors-attributes-expected.txt: Same.
• media/track/track-cues-cuechange-expected.txt: Cues are of type VTTCue now.
• media/track/track-cues-enter-exit-expected.txt: Same.
• media/track/track-vttcue-expected.txt: Test VTTCue interface.
• media/track/track-vttcue.html: Same.
• media/video-test.js:

(testExpected): Add "instanceof" as a valid operator.

2:31 PM Changeset in webkit [163648] by commit-queue@webkit.org

• 5 edits in trunk/Source/JavaScriptCore

[iOS] Eliminate race between XPC connection queue and Notification queue
​https://bugs.webkit.org/show_bug.cgi?id=128384

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-02-07
Reviewed by Timothy Hatcher.

• inspector/remote/RemoteInspector.h:
• inspector/remote/RemoteInspector.mm:

(Inspector::RemoteInspector::RemoteInspector):
(Inspector::RemoteInspector::start):
(Inspector::RemoteInspector::setupXPCConnectionIfNeeded):
Create the queue to use for RemoteInspector xpc connection
management and the connection itself.

• inspector/remote/RemoteInspectorXPCConnection.h:
• inspector/remote/RemoteInspectorXPCConnection.mm:

(Inspector::RemoteInspectorXPCConnection::RemoteInspectorXPCConnection):
Use the passed in queue instead of creating one for itself.

2:27 PM Changeset in webkit [163647] by barraclough@apple.com

• 5 edits in trunk/Source

Should report user input to PageThrottler
​https://bugs.webkit.org/show_bug.cgi?id=128398

Reviewed by Tim Horton.

Make sure we wake from AppNap if there is user interaction.

Source/WebCore:

• page/PageThrottler.h:

(WebCore::PageThrottler::didReceiveUserInput):
(WebCore::PageThrottler::pluginDidEvaluate):

• added, these call reportInterestingEvent()

Source/WebKit2:

• WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::evaluate):

• reportInterestingEvent() -> pluginDidEvaluate()

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::wheelEvent):
(WebKit::WebPage::keyEvent):

• call didReceiveUserInput()

2:12 PM Changeset in webkit [163646] by dino@apple.com

• 3 edits in trunk/Source/WebKit2

WebGL doesn't update with remotely hosted layers
​https://bugs.webkit.org/show_bug.cgi?id=128390

Reviewed by Simon Fraser.

PlatformCALayerRemote was intercepting the setNeedsDisplay calls to
WebGL layers, and thus causing them to not draw. Fix this by adding an
override in PlatformCALayerRemoteCustom to check if it is a WebGLLayer
and call setNeedsDisplay directly.

• WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:
• WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:

(PlatformCALayerRemoteCustom::PlatformCALayerRemoteCustom):
(PlatformCALayerRemoteCustom::setNeedsDisplay):

2:01 PM Changeset in webkit [163645] by benjamin@webkit.org

• 3 edits in trunk/Source/WebKit2

[WK2] Fitler touch events only based on touch start
​https://bugs.webkit.org/show_bug.cgi?id=128354

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-02-07
Reviewed by Simon Fraser.

Touch Events track their target, we should not test the touch regions
again after a touch sequence starts.

This patch adds a boolean flag to know if we are sending events to the WebProcess
(m_isTrackingTouchEvents). The flag is updated every time a touch sequence starts.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::shouldStartTrackingTouchEvents):
(WebKit::WebPageProxy::handleTouchEvent):

• UIProcess/WebPageProxy.h:

1:42 PM Changeset in webkit [163644] by andersca@apple.com

• 3 edits in trunk/Source/WebKit2

Simplify WebPreferences creation inside WebPageGroup
​https://bugs.webkit.org/show_bug.cgi?id=128392

Reviewed by Andreas Kling.

Always create a WebPreferences object when creating the web page group.
This is another step towards letting WebPageProxy manage web preferences.

• UIProcess/WebPageGroup.cpp:

(WebKit::pageGroupData):
(WebKit::WebPageGroup::WebPageGroup):
(WebKit::WebPageGroup::~WebPageGroup):
(WebKit::WebPageGroup::setPreferences):
(WebKit::WebPageGroup::preferences):

• UIProcess/WebPageGroup.h:

1:39 PM Changeset in webkit [163643] by barraclough@apple.com

• 2 edits in trunk/Source/WebKit2

Reenable AppNap
​https://bugs.webkit.org/show_bug.cgi?id=128394

Reviewed by Tim Horton.

• Shared/WebPreferencesStore.h:
  • pageVisibilityBasedProcessSuppressionEnabled shoud default to true.

1:23 PM Changeset in webkit [163642] by k.czech@samsung.com

• 2 edits in trunk/Tools

Build fix after r163632

Unreviewed EFL build fix

Added empty stub to WKTR to not break EFL build.

• WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::selectTextWithCriteria):

1:17 PM Changeset in webkit [163641] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

Unreviewed build fix for 32-bit iOS.

Use magic ? values to allow the exported symbol to be different on 32- and 64-bit builds.

• WebCore.exp.in:

12:14 PM Changeset in webkit [163640] by timothy_horton@apple.com

• 2 edits
  1 move in trunk/Source/WebKit2

Rename ViewGestureController.mm to ViewGestureControllerMac.mm
​https://bugs.webkit.org/show_bug.cgi?id=128387

Reviewed by Anders Carlsson.

As a precursor to having a second nearly completely divergent
ViewGestureController implementation for iOS.

• UIProcess/mac/ViewGestureControllerMac.mm: Renamed from Source/WebKit2/UIProcess/mac/ViewGestureController.mm.
• WebKit2.xcodeproj/project.pbxproj:

Rename ViewGestureController.mm to ViewGestureControllerMac.mm.
Unfortunately, since we're not renaming the class, the header
has to keep its name (and will be the recipient of a giant #if in a later
patch), because the message receiver generated code will try to import
ViewGestureController.h (without the Mac suffix).

11:59 AM Changeset in webkit [163639] by oliver@apple.com

• 2 edits in trunk/Source/JavaScriptCore

REGRESSION (r160628): LLint does not appear to handle impure get own property properly
​https://bugs.webkit.org/show_bug.cgi?id=127943

Reviewed by Filip Pizlo.

Make sure the LLINT doesn't attempt to cache property
access on structures with impureGetOwnPropertySlot set.

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

11:57 AM Changeset in webkit [163638] by andersca@apple.com

• 3 edits in trunk/Source/WebCore

Convert ProgressTracker to std::chrono
​https://bugs.webkit.org/show_bug.cgi?id=128377

Reviewed by Andreas Kling.

• loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::ProgressTracker):
(WebCore::ProgressTracker::reset):
(WebCore::ProgressTracker::progressStarted):
(WebCore::ProgressTracker::finalProgressComplete):
(WebCore::ProgressTracker::incrementProgress):

• loader/ProgressTracker.h:

11:49 AM Changeset in webkit [163637] by BJ Burg

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Clean up DataGrid and add table columns incrementally
​https://bugs.webkit.org/show_bug.cgi?id=128332

Reviewed by Timothy Hatcher.

Miscellaneous improvements to DataGrid to make it more maintainable.
In particular, it now uses a Map to store column settings, and the
construction sequence has been simplified so that it is safe to add
columns at the end of the constructor (or any later time).

DataGrid stores a bunch of settings per-column, but before this was done
by both storing properties on the provided column objects as well as
keeping several columnIdentifier-keyed maps for properties like group
and hidden.

Improve code readability by using for..of loops, destructuring assignment,
Node.createElement, and updating variable names. All variables that refer
to DOM nodes now have a Element suffix to distinguish them from model objects.

• UserInterface/DataGrid.js:

(.sortDataGrid):
(WebInpector.DataGrid): Create all DOM elements before populating columns.
Remove redundant objects for storing per-column values. Copy column settings
into a map rather than mutating the passed-in JSON-like settings data structure.

(WebInspector.DataGrid.createSortableDataGrid):
(WebInspector.DataGrid.prototype.get length):
(WebInspector.DataGrid.prototype.updateLayout):
(WebInspector.DataGrid.prototype.get scrollContainer):
(WebInspector.DataGrid.prototype.isScrolledToLastRow):
(WebInspector.DataGrid.prototype.scrollToLastRow):
(WebInspector.DataGrid.prototype._positionResizerElements):
(WebInspector.DataGrid.prototype.addCreationNode):
(WebInspector.DataGrid.prototype.):
(WebInspector.DataGrid.prototype.sortNodes):
(WebInspector.DataGrid.prototype.dataGridNodeFromPoint):
(WebInspector.DataGrid.prototype._clickInHeaderCell):
(WebInspector.DataGrid.prototype.isColumnSortColumn):
(WebInspector.DataGrid.prototype.headerTableHeader):
(WebInspector.DataGrid.prototype._copyTextForDataGridNode):
(WebInspector.DataGrid.prototype._resizerDragging):
(WebInspector.DataGridNode.prototype.createCells):
(WebInspector.DataGridNode.prototype.createCell.get var):
(WebInspector.DataGridNode.prototype.elementWithColumnIdentifier):
(WebInspector.DataGridNode.prototype._attach):

• UserInterface/TimelineDataGrid.js:

(WebInspector.TimelineDataGrid.prototype.treeElementMatchesActiveScopeFilters.scopeBar.this.columns.get scopeBar):
(WebInspector.TimelineDataGrid.prototype.treeElementMatchesActiveScopeFilters):

11:43 AM Changeset in webkit [163636] by andersca@apple.com

• 4 edits in trunk/Source/WebKit2

Copying a WebPreferences object should be done through a member function
​https://bugs.webkit.org/show_bug.cgi?id=128385

Reviewed by Andreas Kling.

• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesCreateCopy):

• UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::copy):

• UIProcess/WebPreferences.h:

11:10 AM Changeset in webkit [163635] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

WebPageGroup::setPreferences should set the preferences on all pages in the group
​https://bugs.webkit.org/show_bug.cgi?id=128383

Reviewed by Alexey Proskuryakov.

• UIProcess/WebPageGroup.cpp:

(WebKit::WebPageGroup::setPreferences):

10:53 AM Changeset in webkit [163634] by ap@apple.com

• 2 edits in trunk/Source/WebCore

32-bit build fix.

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(accessibilitySelectTextCriteriaForCriteriaParameterizedAttribute):

10:46 AM Changeset in webkit [163633] by commit-queue@webkit.org

• 50 edits in trunk

[CSS Background Blending] Unprefix the -webkit-background-blend-mode property

​https://bugs.webkit.org/show_bug.cgi?id=128270

Patch by Mihai Tica <​mitica@adobe.com> on 2014-02-07
Reviewed by Dean Jackson.

Source/WebCore:

This patch consist of unprefixing the -webkit-background-blend-mode.
The property now changes to background-blend-mode.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

• css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillProperty):

• css/CSSPropertyNames.in:
• css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):

Source/WebInspectorUI:

• UserInterface/CSSKeywordCompletions.js: Refactor -webkit-background-blend-mode to background-blend-mode.

LayoutTests:

This patch consist of unprefixing the -webkit-background-blend-mode.
The property now changes to background-blend-mode.

• css3/compositing/background-blend-mode-background-attachement-fixed-expected.html:
• css3/compositing/background-blend-mode-background-attachement-fixed.html:
• css3/compositing/background-blend-mode-background-clip-content-box-expected.html:
• css3/compositing/background-blend-mode-background-clip-content-box.html:
• css3/compositing/background-blend-mode-background-clip-padding-box-expected.html:
• css3/compositing/background-blend-mode-background-clip-padding-box.html:
• css3/compositing/background-blend-mode-background-origin-border-box-expected.html:
• css3/compositing/background-blend-mode-background-origin-border-box.html:
• css3/compositing/background-blend-mode-background-position-percentage-expected.html:
• css3/compositing/background-blend-mode-background-position-percentage.html:
• css3/compositing/background-blend-mode-background-repeat-no-repeat-expected.html:
• css3/compositing/background-blend-mode-background-repeat-no-repeat.html:
• css3/compositing/background-blend-mode-background-size-contain-expected.html:
• css3/compositing/background-blend-mode-background-size-contain.html:
• css3/compositing/background-blend-mode-background-size-cover-expected.html:
• css3/compositing/background-blend-mode-background-size-cover.html:
• css3/compositing/background-blend-mode-crossfade-image.html:
• css3/compositing/background-blend-mode-data-uri-svg-image.html:
• css3/compositing/background-blend-mode-default-value.html:
• css3/compositing/background-blend-mode-different-image-formats.html:
• css3/compositing/background-blend-mode-gif-color-2.html:
• css3/compositing/background-blend-mode-gif-color.html:
• css3/compositing/background-blend-mode-gradient-color.html:
• css3/compositing/background-blend-mode-gradient-gradient.html:
• css3/compositing/background-blend-mode-gradient-image.html:
• css3/compositing/background-blend-mode-image-color.html:
• css3/compositing/background-blend-mode-image-image.html:
• css3/compositing/background-blend-mode-image-svg.html:
• css3/compositing/background-blend-mode-multiple-background-layers.html:
• css3/compositing/background-blend-mode-property-expected.txt:
• css3/compositing/background-blend-mode-property-parsing-expected.txt:
• css3/compositing/background-blend-mode-separate-layer-declaration.html:
• css3/compositing/background-blend-mode-single-layer-no-blending.html:
• css3/compositing/background-blend-mode-svg-color.html:
• css3/compositing/background-blend-mode-svg.html:
• css3/compositing/background-blend-mode-tiled-layers.html:
• css3/compositing/blend-mode-layers.html:
• css3/compositing/effect-background-blend-mode-stacking.html:
• css3/compositing/effect-background-blend-mode-tiled.html:
• css3/compositing/effect-background-blend-mode.html:
• css3/compositing/script-tests/background-blend-mode-property-parsing.js:

(testBlendModeRule):

• css3/compositing/script-tests/background-blend-mode-property.js:

(testblendmode):

10:43 AM Changeset in webkit [163632] by Samuel White

• 20 edits
  2 adds in trunk

AX: Find and select text with respect to insertion point using accessibility API.
​https://bugs.webkit.org/show_bug.cgi?id=128026

Reviewed by Chris Fleizach.

Source/WebCore:

Added facilities to support semi-ambiguous text selection through the accessibility API. All
requests are handled with respect to the current selection. The requests are disambiguated in
WebCore using passed parameters such as: SelectStringAfterSelection , ..Before.., ..ClosestTo...,
etc. Callers can also supply an array of strings to select and the closest that matches the
disambiguation criteria will be used.

Test: platform/mac/accessibility/select-text.html

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::rangeClosestToRange):
(WebCore::AccessibilityObject::rangeOfStringClosestToRangeInDirection):
(WebCore::AccessibilityObject::selectionRange):
(WebCore::AccessibilityObject::selectText):
(WebCore::AccessibilityObject::frame):

• accessibility/AccessibilityObject.h:

(WebCore::AccessibilitySelectTextCriteria::AccessibilitySelectTextCriteria):

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(accessibilitySelectTextCriteriaForCriteriaParameterizedAttribute):
(-[WebAccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

• dom/Position.cpp:

(WebCore::Position::positionCountBetweenPositions):

• dom/Position.h:

Tools:

Added method to AccessibilityUIElement to enable testing of accessibility text selection.

• DumpRenderTree/AccessibilityUIElement.cpp:

(selectTextWithCriteriaCallback):
(AccessibilityUIElement::getJSClass):

• DumpRenderTree/AccessibilityUIElement.h:
• DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::selectTextWithCriteria):

• DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(AccessibilityUIElement::selectTextWithCriteria):

• DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(selectTextParameterizedAttributeForCriteria):
(AccessibilityUIElement::selectTextWithCriteria):

• DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::selectTextWithCriteria):

• WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::selectTextWithCriteria):

• WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
• WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
• WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:

(WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
(WTR::AccessibilityUIElement::selectTextWithCriteria):

• WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::selectTextParameterizedAttributeForCriteria):
(WTR::AccessibilityUIElement::selectTextWithCriteria):

LayoutTests:

Tests that text selection via the accessibility API works as expected.

• platform/mac/accessibility/bounds-for-range-expected.txt:
• platform/mac/accessibility/select-text-expected.txt: Added.
• platform/mac/accessibility/select-text.html: Added.

10:37 AM Changeset in webkit [163631] by Bem Jones-Bey

• 3 edits in trunk/Source/WebCore

FloatingObject m_paginationStrut should be LayoutUnit
​https://bugs.webkit.org/show_bug.cgi?id=119808

Reviewed by Andreas Kling.

Make the paginationStrut in FloatingObject have the same type as all
of the other paginationStruts in the code.

• rendering/FloatingObjects.h:

(WebCore::FloatingObject::paginationStrut):
(WebCore::FloatingObject::setPaginationStrut):

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::positionNewFloatOnLine):

10:32 AM Changeset in webkit [163630] by mitz@apple.com

• 3 edits in trunk/Source/WebKit2

[Cocoa] WKRemoteObjectInterface doesn’t support aribtrary argument classes
​https://bugs.webkit.org/show_bug.cgi?id=128368

Reviewed by Anders Carlsson.

• Shared/API/Cocoa/WKRemoteObjectInterface.h: Declared new methods.
• Shared/API/Cocoa/WKRemoteObjectInterface.mm:

(propertyListClasses): Removed NSNull, which is not really a property list class.
(classesForSelectorArgument): Added helper function.
(-[WKRemoteObjectInterface classesForSelector:argumentIndex:]): Added.
(-[WKRemoteObjectInterface setClasses:forSelector:argumentIndex:]): Added.

10:32 AM Changeset in webkit [163629] by mitz@apple.com

• 8 edits
  4 adds in trunk/Source/WebKit2

[Cocoa] API::FrameHandle has a generic wrapper
​https://bugs.webkit.org/show_bug.cgi?id=128366

Reviewed by Anders Carlsson.

Added WKFrameHandle.

• Shared/API/Cocoa/WKFrameHandle.h: Added.
• Shared/API/Cocoa/WKFrameHandle.mm: Added.

(-[WKFrameHandle dealloc]): Calls the API::FrameHandle destructor.
(-[WKFrameHandle isEqual:]): Checks for frame ID equality.
(-[WKFrameHandle hash]): Returns the frame ID.
(-[WKFrameHandle _frameID]): Ditto.
(-[WKFrameHandle copyWithZone:]): Retains self.
(+[WKFrameHandle supportsSecureCoding]): Returns YES.
(-[WKFrameHandle initWithCoder:]): Decodes the frame ID and constructs an API::FrameHandle
with it.
(-[WKFrameHandle encodeWithCoder:]): Encodes the frame ID.
(-[WKFrameHandle _apiObject]): Returns the wrapped API::FrameHandle.

• Shared/API/Cocoa/WKFrameHandleInternal.h: Added.

(WebKit::wrapper): Added. Returns an API::FrameHandle’s wrapper as a WKFrameHandle.

• Shared/APIFrameHandle.cpp:

(API::FrameHandle::create): Changed to return a PassRefPtr.

• Shared/APIFrameHandle.h: Made the constructor public for -[WKFrameHandle initWithCoder:].

• Shared/Cocoa/APIObject.mm:

(API::Object::newObject): Allocate a WKFrameHandle if the object is an API::FrameHandle.

• WebKit2.xcodeproj/project.pbxproj: Added references to new files.

• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h: Declared handle property.
• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:

(+[WKWebProcessPlugInFrame lookUpFrameFromHandle:]): Added. Calls WebProcess::webFrame to
look up a frame with the given handle’s frame ID.
(-[WKWebProcessPlugInFrame handle]): Added. Returns a new handle with the frame’s ID.

• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrameInternal.h: Updated #import.
• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h: Added.

10:31 AM Changeset in webkit [163628] by mitz@apple.com

• 2 edits in trunk/Source/WebKit2

[Cocoa] WKWebProcessPlugInNodeHandle methods leak and may crash
​https://bugs.webkit.org/show_bug.cgi?id=128365

Reviewed by Anders Carlsson.

• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:

(+[WKWebProcessPlugInNodeHandle nodeHandleWithJSValue:inContext:]): Null-check the result
of InjectedBundleNodeHandle::getOrCreate, and autorelease the return value.
(-[WKWebProcessPlugInNodeHandle htmlIFrameElementContentFrame]): Null-check the result of
InjectedBundleNodeHandle::htmlIFrameElementContentFrame, and autorelease the return value.

10:26 AM Changeset in webkit [163627] by beidson@apple.com

• 20 edits in trunk

IDB: storage/indexeddb/create-index-with-integer-keys.html fails
<rdar://problem/16002857> and ​https://bugs.webkit.org/show_bug.cgi?id=128316

Reviewed by Geoff Garen.

Source/WebCore:

Tested by storage/indexeddb/create-index-with-integer-keys.html (and probably some others)

• Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::update): Update createIDBKeyFromScriptValueAndKeyPath usage.
(WebCore::IDBCursor::setValueReady): Update createIDBKeyFromScriptValueAndKeyPath usage.

• Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::put): Update usage of binding utilities.

• Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess): Update createIDBKeyFromScriptValueAndKeyPath usage.

• bindings/js/IDBBindingUtilities.cpp:

(WebCore::internalCreateIDBKeyFromScriptValueAndKeyPath):
(WebCore::createIDBKeyFromScriptValueAndKeyPath): Changed to take an ExecState*.
(WebCore::deserializeIDBValueBuffer): Added new version that starts with ExecState* and Vector<uint8_t>

instead of RequestState and SharedBuffer.

(WebCore::generateIndexKeysForValue): Moved from IDBObjectStore.cpp and changed to take an ExecState*

• bindings/js/IDBBindingUtilities.h:

Added new blob fetcher that works with uint8_t buffers:

• platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::getColumnBlobAsVector):

• platform/sql/SQLiteStatement.h:

• WebCore.exp.in:

Source/WebKit2:

Update Vector<char> to Vector<uint8_t> throughout:

• DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::openCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didOpenCursorInBackingStore):
(WebKit::UniqueIDBDatabase::advanceCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didAdvanceCursorInBackingStore):
(WebKit::UniqueIDBDatabase::iterateCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didIterateCursorInBackingStore):

• DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:

Update Vector<char> to Vector<uint8_t> throughout:

• DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:

(WebKit::SQLiteIDBCursor::advanceOnce):

• DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.h:

(WebKit::SQLiteIDBCursor::currentValueBuffer):

• DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
• DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createIndex): Create a script value from the value data, use

generateIndexKeysForValue to get the index keys, and then write the resulting index records.

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::putIndexRecord): Call through to uncheckedPutIndexRecord.
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::uncheckedPutIndexRecord): Version of putIndexRecord that doesn’t

validate the transaction or its mode.

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::openCursor): Update Vector<char> to Vector<uint8_t>.
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::advanceCursor): Ditto.
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::iterateCursor): Ditto.

• DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:

LayoutTests:

• platform/mac-wk2/TestExpectations: Enable the test.

10:20 AM Changeset in webkit [163626] by commit-queue@webkit.org

• 3 edits
  4 adds in trunk

childShouldCreateRenderer should return false for the mspace element
​https://bugs.webkit.org/show_bug.cgi?id=128325

Patch by Frédéric Wang <​fred.wang@free.fr> on 2014-02-07
Reviewed by Chris Fleizach.

Source/WebCore:

The mspace element can not have children so this makes its
childShouldCreateRenderer always return false.

Test: mathml/presentation/mspace-children.html

• mathml/MathMLTextElement.cpp:

(WebCore::MathMLTextElement::childShouldCreateRenderer):

LayoutTests:

Add tests to ensure that the mspace element does not have renderer
children.

• mathml/presentation/mspace-children-expected.png: Added.
• mathml/presentation/mspace-children-expected.txt: Added.
• mathml/presentation/mspace-children.html: Added.
• platform/mathml/presentation/mspace-children-expected.txt: Added.

9:45 AM Changeset in webkit [163625] by commit-queue@webkit.org

• 90 edits in trunk

[CSS Grid Layout] Rename grid-definition-{columns|rows} to match the new syntax
​https://bugs.webkit.org/show_bug.cgi?id=127989

Patch by Javier Fernandez <​jfernandez@igalia.com> on 2014-02-07
Reviewed by Andreas Kling.

In the latest WD, grid-definition-{columns|rows} were renamed to grid-template-{columns|rows}.

Source/WebCore:

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::isLayoutDependent):
(WebCore::ComputedStyleExtractor::propertyValue):

• css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

• css/CSSPropertyNames.in:
• css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

LayoutTests:

• fast/css-grid-layout/auto-content-resolution-columns.html:
• fast/css-grid-layout/auto-content-resolution-rows.html:
• fast/css-grid-layout/breadth-size-resolution-grid.html:
• fast/css-grid-layout/calc-resolution-grid-item.html:
• fast/css-grid-layout/flex-and-minmax-content-resolution-columns.html:
• fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html:
• fast/css-grid-layout/flex-content-resolution-columns.html:
• fast/css-grid-layout/flex-content-resolution-rows.html:
• fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution.html:
• fast/css-grid-layout/grid-auto-columns-rows-resolution.html:
• fast/css-grid-layout/grid-auto-columns-rows-update.html:
• fast/css-grid-layout/grid-auto-flow-resolution.html:
• fast/css-grid-layout/grid-auto-flow-update.html:
• fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
• fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
• fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
• fast/css-grid-layout/grid-columns-rows-get-set.html:
• fast/css-grid-layout/grid-dynamic-updates-relayout.html:
• fast/css-grid-layout/grid-element-border-grid-item.html:
• fast/css-grid-layout/grid-element-border-padding-grid-item.html:
• fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt:
• fast/css-grid-layout/grid-element-change-columns-repaint.html:
• fast/css-grid-layout/grid-element-change-rows-repaint-expected.txt:
• fast/css-grid-layout/grid-element-change-rows-repaint.html:
• fast/css-grid-layout/grid-element-empty-row-column.html:
• fast/css-grid-layout/grid-element-min-max-width.html:
• fast/css-grid-layout/grid-element-padding-grid-item.html:
• fast/css-grid-layout/grid-element-padding-margin.html:
• fast/css-grid-layout/grid-element-repeat-get-set-expected.txt:
• fast/css-grid-layout/grid-element-repeat-get-set.html:
• fast/css-grid-layout/grid-item-addition-auto-placement-update.html:
• fast/css-grid-layout/grid-item-addition-track-breadth-update.html:
• fast/css-grid-layout/grid-item-bad-named-area-auto-placement.html:
• fast/css-grid-layout/grid-item-bad-resolution-double-span.html:
• fast/css-grid-layout/grid-item-change-column-repaint.html:
• fast/css-grid-layout/grid-item-change-row-repaint.html:
• fast/css-grid-layout/grid-item-margin-resolution.html:
• fast/css-grid-layout/grid-item-multiple-minmax-content-resolution.html:
• fast/css-grid-layout/grid-item-named-grid-area-resolution.html:
• fast/css-grid-layout/grid-item-named-grid-line-resolution.html:
• fast/css-grid-layout/grid-item-negative-integer-explicit-grid-resolution.html:
• fast/css-grid-layout/grid-item-negative-position-resolution.html:
• fast/css-grid-layout/grid-item-order-auto-flow-resolution.html:
• fast/css-grid-layout/grid-item-order-paint-order.html:
• fast/css-grid-layout/grid-item-removal-auto-placement-update.html:
• fast/css-grid-layout/grid-item-removal-track-breadth-update.html:
• fast/css-grid-layout/grid-item-spanning-resolution.html:
• fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html:
• fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html:
• fast/css-grid-layout/grid-preferred-logical-widths.html:
• fast/css-grid-layout/implicit-columns-auto-resolution.html:
• fast/css-grid-layout/implicit-position-dynamic-change.html:
• fast/css-grid-layout/implicit-rows-auto-resolution.html:
• fast/css-grid-layout/minmax-fixed-logical-height-only.html:
• fast/css-grid-layout/minmax-fixed-logical-width-only.html:
• fast/css-grid-layout/minmax-max-content-resolution-columns.html:
• fast/css-grid-layout/minmax-max-content-resolution-rows.html:
• fast/css-grid-layout/minmax-min-content-column-resolution-columns.html:
• fast/css-grid-layout/minmax-min-content-column-resolution-rows.html:
• fast/css-grid-layout/minmax-spanning-resolution-columns.html:
• fast/css-grid-layout/minmax-spanning-resolution-rows.html:
• fast/css-grid-layout/named-grid-line-get-set-expected.txt:
• fast/css-grid-layout/named-grid-line-get-set.html:
• fast/css-grid-layout/non-grid-columns-rows-get-set-expected.txt:
• fast/css-grid-layout/non-grid-columns-rows-get-set-multiple-expected.txt:
• fast/css-grid-layout/non-grid-columns-rows-get-set-multiple.html:
• fast/css-grid-layout/non-grid-columns-rows-get-set.html:
• fast/css-grid-layout/non-grid-element-repeat-get-set-expected.txt:
• fast/css-grid-layout/non-grid-element-repeat-get-set.html:
• fast/css-grid-layout/non-named-grid-line-get-set-expected.txt:
• fast/css-grid-layout/non-named-grid-line-get-set.html:
• fast/css-grid-layout/percent-grid-item-in-percent-grid-track-in-percent-grid.html:
• fast/css-grid-layout/percent-grid-item-in-percent-grid-track-update.html:
• fast/css-grid-layout/percent-grid-item-in-percent-grid-track.html:
• fast/css-grid-layout/percent-padding-margin-resolution-grid-item-update.html:
• fast/css-grid-layout/percent-padding-margin-resolution-grid-item.html:
• fast/css-grid-layout/percent-resolution-grid-item.html:
• fast/css-grid-layout/place-cell-by-index.html:
• fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:

(testInherit):
(testInitial):

• fast/css-grid-layout/resources/grid-columns-rows-get-set.js:

(testInherit):
(testInitial):

• fast/css-grid-layout/resources/grid-definitions-parsing-utils.js:

(testGridTemplatesValues):
(testGridTemplatesSetJSValues):
(testNonGridTemplatesSetJSValues):
(checkGridTemplatesSetJSValues):
(testGridTemplatesSetBadJSValues):

• fast/css-grid-layout/resources/non-grid-columns-rows-get-set-multiple.js:

(testInherit):
(testInitial):

• fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js:

(testInherit):
(testInitial):

• ietestcenter/css3/grid/display-grid-001-expected.htm:

9:43 AM Changeset in webkit [163624] by dino@apple.com

• 2 edits in trunk/LayoutTests

animations/suspend-resume-animation.html is flakey
​https://bugs.webkit.org/show_bug.cgi?id=128379

Marking it as such.

• platform/mac/TestExpectations:

8:11 AM Changeset in webkit [163623] by Michał Pakuła vel Rutka

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening

Remove test expectations after r163586 and skip two http tests.

• platform/efl-wk2/TestExpectations:

4:02 AM Changeset in webkit [163622] by akling@apple.com

• 5 edits in trunk/Source/WebCore

CTTE: DocumentThreadableLoader always has a Document.
<​https://webkit.org/b/128364>

DocumentThreadableLoader always has an "owner" Document, so store
that as a reference instead of a pointer. Removed some unnecessary
assertions exposed by this change.

Reviewed by Antti Koivisto.

• loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadResourceSynchronously):
(WebCore::DocumentThreadableLoader::create):
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::didReceiveResponse):
(WebCore::DocumentThreadableLoader::didReceiveData):
(WebCore::DocumentThreadableLoader::didFinishLoading):
(WebCore::DocumentThreadableLoader::didFail):
(WebCore::DocumentThreadableLoader::preflightFailure):
(WebCore::DocumentThreadableLoader::loadRequest):
(WebCore::DocumentThreadableLoader::securityOrigin):

• loader/DocumentThreadableLoader.h:
• loader/ThreadableLoader.cpp:

(WebCore::ThreadableLoader::create):
(WebCore::ThreadableLoader::loadResourceSynchronously):

• loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):

3:44 AM Changeset in webkit [163621] by Manuel Rego Casasnovas

• 3 edits in trunk/Tools

[GTK] Disable gtk-doc in EWS
​https://bugs.webkit.org/show_bug.cgi?id=128370

Reviewed by Carlos Garcia Campos.

Disable gtk-doc generation in EWS due to ​http://webkit.org/b/128369.

• Scripts/webkitpy/common/config/ports.py:

(GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
(GtkWK2Port.build_webkit_command): Ditto.

• Scripts/webkitpy/common/config/ports_unittest.py:

(DeprecatedPortTest.test_gtk_port): Ditto.
(DeprecatedPortTest.test_gtk_wk2_port): Ditto.

2:52 AM Changeset in webkit [163620] by commit-queue@webkit.org

• 4 edits in trunk/LayoutTests

[EFL] editing/style/block-style-005.html failing
​https://bugs.webkit.org/show_bug.cgi?id=114612

Patch by Lukasz Bialek <​l.bialek@samsung.com> on 2014-02-07
Reviewed by Ryosuke Niwa.

After r148378 editing/style/block-style-005.htm test stopped passing.
Number of "moveSelectionByLineCommand" is changed to 4 to match intended
test behaviour. Test is confirmed to pass in EFL and GTK ports now.

• editing/style/block-style-005.html:
• platform/efl/TestExpectations:
• platform/gtk/TestExpectations:

2:49 AM Changeset in webkit [163619] by mihnea@adobe.com

• 7 edits
  1 delete in trunk/LayoutTests

[CSSRegions] Remove style-scoped tests
​https://bugs.webkit.org/show_bug.cgi?id=128361

Reviewed by Andrei Bucur.

Remove tests combining style-scoped and regions. The support was removed from code base
and the tests were skipped from a long time.

• fast/regions/style-scoped/style-scoped-in-flow-expected.html: Removed.
• fast/regions/style-scoped/style-scoped-in-flow-override-container-style-expected.html: Removed.
• fast/regions/style-scoped/style-scoped-in-flow-override-container-style.html: Removed.
• fast/regions/style-scoped/style-scoped-in-flow-override-region-styling-expected.html: Removed.
• fast/regions/style-scoped/style-scoped-in-flow-override-region-styling-multiple-regions-expected.html: Removed.
• fast/regions/style-scoped/style-scoped-in-flow-override-region-styling-multiple-regions.html: Removed.
• fast/regions/style-scoped/style-scoped-in-flow-override-region-styling.html: Removed.
• fast/regions/style-scoped/style-scoped-in-flow.html: Removed.
• platform/efl/TestExpectations:
• platform/gtk-wk2/TestExpectations:
• platform/gtk/TestExpectations:
• platform/mac/TestExpectations:
• platform/win/TestExpectations:
• platform/wincairo/TestExpectations:

2:44 AM Changeset in webkit [163618] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

Vector-effect updates require a re-layout
​https://bugs.webkit.org/show_bug.cgi?id=127553

Patch by Peter Molnar <​pmolnar.u-szeged@partner.samsung.com> on 2014-02-07
Reviewed by Andreas Kling.

As noted in the stale SVGRenderStyle::diff() comment, now that layout() observes vector-effect
we need to trigger a re-layout on attribute changes.

Merged from Blink: ​https://src.chromium.org/viewvc/blink?revision=152570&view=revision

Source/WebCore:

Tests: svg/custom/non-scaling-stroke-update-expected.svg

svg/custom/non-scaling-stroke-update.svg

• rendering/style/SVGRenderStyle.cpp:

(WebCore::SVGRenderStyle::diff):

LayoutTests:

• svg/custom/non-scaling-stroke-update-expected.svg: Added.
• svg/custom/non-scaling-stroke-update.svg: Added.

2:21 AM Changeset in webkit [163617] by commit-queue@webkit.org

• 9 edits in trunk/Source/WebCore

Renaming isTableElement() to isRenderedTable() as per the FIXME comment
​https://bugs.webkit.org/show_bug.cgi?id=127769

Patch by Laszlo Vidacs <​lvidacs.u-szeged@partner.samsung.com> on 2014-02-07
Reviewed by Andreas Kling.

Rename method and use IsTable() instead of local type checking.

• dom/Position.cpp:

(WebCore::Position::parentAnchoredEquivalent):
(WebCore::Position::upstream):
(WebCore::Position::downstream):
(WebCore::Position::isCandidate):

• dom/PositionIterator.cpp:

(WebCore::PositionIterator::isCandidate):

• editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
(WebCore::CompositeEditCommand::moveParagraphWithClones):

• editing/FrameSelection.cpp:

(WebCore::caretRendersInsideNode):

• editing/VisibleUnits.cpp:

(WebCore::startOfParagraph):
(WebCore::endOfParagraph):

• editing/htmlediting.cpp:

(WebCore::firstInSpecialElement):
(WebCore::lastInSpecialElement):
(WebCore::isRenderedTable):

• editing/htmlediting.h:
• rendering/RenderBox.cpp:

(WebCore::RenderBox::localCaretRect):

2:10 AM Changeset in webkit [163616] by ChangSeok Oh

• 3 edits in trunk/LayoutTests

Unreviewed GTK port gardening

• platform/gtk-wk2/TestExpectations:
• platform/gtk/TestExpectations:

1:20 AM Changeset in webkit [163615] by g.czajkowski@samsung.com

• 5 edits in trunk/LayoutTests

Verify misspellings after lines merge/split asynchronously
​https://bugs.webkit.org/show_bug.cgi?id=128305

Reviewed by Ryosuke Niwa.

Adapt two spelling tests to use asynchronous spellchecking.

• editing/spelling/script-tests/spelling-backspace-between-lines.js:

(testTwoLinesMisspellings):
(testMisspellingsAfterLineMergeUsingDelete):
(testMisspellingsAfterLineMergeUsingForwardDelete):
Group test cases into separated methods.
Use shouldBeEqualToString to compare strings.
Add newly created div elements instead of overriding
the previous one in order that non DumpRenderTree users
can see what has been tested.

• editing/spelling/spelling-backspace-between-lines-expected.txt:
• editing/spelling/spelling-linebreak-expected.txt:
• editing/spelling/spelling-linebreak.html:

12:32 AM Changeset in webkit [163614] by jinwoo7.song@samsung.com

• 6 edits in trunk

[EFL][WK2] WebView should be able to configure to set fixed layout
​https://bugs.webkit.org/show_bug.cgi?id=128300

Reviewed by Gyuyoung Kim.

Source/WebKit2:

Currently, webview is created by setting fixed layout as true and there is no way to change the setting.
But some applications may do not want to use fixed layout so I'd like to add ewk APIs to configure to it.

• UIProcess/API/efl/ewk_view.cpp:

(EWKViewCreate): Do not set to use fixed layout as default.
(ewk_view_layout_fixed_set):
(ewk_view_layout_fixed_get):

• UIProcess/API/efl/ewk_view.h: Add ewk APIs to set fixed layout.
• UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

Tools:

• MiniBrowser/efl/main.c:

(window_create):
(elm_main): Add command argument option to use fixed layout.

Feb 6, 2014:

11:23 PM Changeset in webkit [163613] by beidson@apple.com

• 2 edits in trunk/Source/WebKit2

Unreviewed build fix after r163612.

• DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

10:37 PM Changeset in webkit [163612] by beidson@apple.com

• 23 edits in trunk/Source

IDB: Remove the entirely unnecessary "Value Key" concept
​https://bugs.webkit.org/show_bug.cgi?id=128360

Reviewed by Dan Bernstein.

Source/WebCore:

No new tests (No change in behavior)

All cursor operations were set up to pass a value key parameter around, but it was:
1 - Entirely unused
2 - The same thing that the primary key is supposed to be

• Modules/indexeddb/IDBCallbacks.h:

• Modules/indexeddb/IDBCursorBackend.cpp:

(WebCore::IDBCursorBackend::updateCursorData):
(WebCore::IDBCursorBackend::clear):

• Modules/indexeddb/IDBCursorBackend.h:

• Modules/indexeddb/IDBCursorBackendOperations.cpp:

(WebCore::CursorAdvanceOperation::perform):
(WebCore::CursorIterationOperation::perform):

• Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess):

• Modules/indexeddb/IDBRequest.h:

• Modules/indexeddb/IDBTransactionBackendOperations.cpp:

(WebCore::OpenCursorOperation::perform):

• Modules/indexeddb/IDBServerConnection.h:
• Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:

(WebCore::IDBServerConnectionLevelDB::openCursor):
(WebCore::IDBServerConnectionLevelDB::cursorAdvance):
(WebCore::IDBServerConnectionLevelDB::cursorIterate):

• Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:

Source/WebKit2:

All cursor operations were set up to pass a value key parameter around, but it was:
1 - Entirely unused
2 - The same thing that the primary key is supposed to be

• DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

(WebKit::DatabaseProcessIDBConnection::openCursor):
(WebKit::DatabaseProcessIDBConnection::cursorAdvance):
(WebKit::DatabaseProcessIDBConnection::cursorIterate):

• DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::openCursor):
(WebKit::UniqueIDBDatabase::cursorAdvance):
(WebKit::UniqueIDBDatabase::cursorIterate):
(WebKit::UniqueIDBDatabase::openCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didOpenCursorInBackingStore):
(WebKit::UniqueIDBDatabase::advanceCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didAdvanceCursorInBackingStore):
(WebKit::UniqueIDBDatabase::iterateCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didIterateCursorInBackingStore):

• DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:

• DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:

(WebKit::SQLiteIDBCursor::advanceOnce): Clean this logic up to not need temporaries,

and also to save the correct primary key (previously the 'value key')

• DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.h:

• DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
• DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getIndexRecord):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::openCursor):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::advanceCursor):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::iterateCursor):

• DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:

• WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::didOpenCursor):
(WebKit::WebIDBServerConnection::didAdvanceCursor):
(WebKit::WebIDBServerConnection::didIterateCursor):
(WebKit::WebIDBServerConnection::openCursor):
(WebKit::WebIDBServerConnection::cursorAdvance):
(WebKit::WebIDBServerConnection::cursorIterate):

• WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
• WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in:

10:32 PM Changeset in webkit [163611] by ryuan.choi@samsung.com

• 2 edits in trunk/Source/WebKit2

Unreviewed build fix on GTK build since r163597

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseUpdatePreferences):

9:38 PM Changeset in webkit [163610] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit2

Need a ObjC SPI to get the process identifier for web process.
​https://bugs.webkit.org/show_bug.cgi?id=128356

Patch by Yongjun Zhang <​yongjun_zhang@apple.com> on 2014-02-06
Reviewed by Dan Bernstein.

Add a SPI for WKBrowsingContextController to return the process identifier of web
process in the current page.

• UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController processIdentifier]):

• UIProcess/API/Cocoa/WKBrowsingContextControllerPrivate.h:

9:14 PM Changeset in webkit [163609] by ryuan.choi@samsung.com

• 6 edits in trunk/Source/WebKit2

Unreviewed build fix on EFL build since r163597

preferences() changed return type from pointer to reference.

• UIProcess/API/efl/ewk_settings.cpp:

(EwkSettings::preferences):
(ewk_settings_fullscreen_enabled_set):
(ewk_settings_fullscreen_enabled_get):
(ewk_settings_javascript_enabled_set):
(ewk_settings_javascript_enabled_get):
(ewk_settings_loads_images_automatically_set):
(ewk_settings_loads_images_automatically_get):
(ewk_settings_developer_extras_enabled_set):
(ewk_settings_developer_extras_enabled_get):
(ewk_settings_file_access_from_file_urls_allowed_set):
(ewk_settings_file_access_from_file_urls_allowed_get):
(ewk_settings_frame_flattening_enabled_set):
(ewk_settings_frame_flattening_enabled_get):
(ewk_settings_dns_prefetching_enabled_set):
(ewk_settings_dns_prefetching_enabled_get):
(ewk_settings_encoding_detector_enabled_set):
(ewk_settings_encoding_detector_enabled_get):
(ewk_settings_preferred_minimum_contents_width_set):
(ewk_settings_preferred_minimum_contents_width_get):
(ewk_settings_offline_web_application_cache_enabled_set):
(ewk_settings_offline_web_application_cache_enabled_get):
(ewk_settings_scripts_can_open_windows_set):
(ewk_settings_scripts_can_open_windows_get):
(ewk_settings_local_storage_enabled_set):
(ewk_settings_local_storage_enabled_get):
(ewk_settings_plugins_enabled_set):
(ewk_settings_plugins_enabled_get):
(ewk_settings_default_font_size_set):
(ewk_settings_default_font_size_get):
(ewk_settings_private_browsing_enabled_set):
(ewk_settings_private_browsing_enabled_get):
(ewk_settings_text_autosizing_enabled_set):
(ewk_settings_text_autosizing_enabled_get):
(ewk_settings_spatial_navigation_enabled_set):
(ewk_settings_spatial_navigation_enabled_get):
(EwkSettings::setDefaultTextEncodingName):

• UIProcess/API/efl/ewk_settings_private.h:

(EwkSettings::EwkSettings):

• UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:

(WebKit::CoordinatedDrawingAreaProxy::CoordinatedDrawingAreaProxy):

• UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::WebView):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::preferencesDidChange):

8:11 PM Changeset in webkit [163608] by Joseph Pecoraro

• 2 edits in trunk

[iOS] make should build WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=128351

Reviewed by Daniel Bates.

• Source/Makefile:

7:12 PM Changeset in webkit [163607] by gyuyoung.kim@samsung.com

• 4 edits
  2 adds in trunk/LayoutTests

Add a test case for navigator.isProtocolHandlerRegistered
​https://bugs.webkit.org/show_bug.cgi?id=128302

Reviewed by Anders Carlsson.

Add a test case for navigator.isProtocolHandlerRegistered. This new test will
check if "navigator.isProtocolHandlerRegistered" throws the proper exceptions
and returns a proper state of handler.

Currently, this function is only supported by EFL WK1 port.

• fast/dom/is-protocol-handler-registered-expected.txt: Added.
• fast/dom/is-protocol-handler-registered.html: Added.
• platform/efl-wk2/TestExpectations: Skip this test.
• platform/gtk/TestExpectations: ditto.
• platform/mac/TestExpectations: ditto.

7:10 PM Changeset in webkit [163606] by bshafiei@apple.com

• 5 edits in tags/Safari-538.17.1/Source/JavaScriptCore

Merged r163595.

7:04 PM Changeset in webkit [163605] by bshafiei@apple.com

• 5 edits in tags/Safari-538.17.1/Source

Versioning.

7:02 PM Changeset in webkit [163604] by bshafiei@apple.com

• 1 copy in tags/Safari-538.17.1

New tag.

6:41 PM Changeset in webkit [163603] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Crash in MiniBrowser when using Command-W to close a WK2 window
​https://bugs.webkit.org/show_bug.cgi?id=128355
<rdar://problem/16008531>

Reviewed by Simon Fraser.

Don't set the API clients to nullptr when closing the page, just create new empty ones instead.
Too much code depends on the clients never being null.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):

6:30 PM Changeset in webkit [163602] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

[wk2] iOS should use accelerated drawing by default, except in the simulator
​https://bugs.webkit.org/show_bug.cgi?id=128140
<rdar://problem/15974171>

Reviewed by Anders Carlsson.

• Shared/WebPreferencesStore.h:

Turn full-page accelerated drawing on for iOS, except the simulator which doesn't support it.
Turn canvas accelerated drawing on for all platforms except the iOS simulator, for the same reason.
The defaults remain the same for non-iOS platforms.

6:29 PM Changeset in webkit [163601] by rniwa@webkit.org

• 2 edits in trunk/Tools

Fix DoYouEvenBench after r163429.

• Scripts/webkitpy/performance_tests/perftest.py:

6:19 PM Changeset in webkit [163600] by commit-queue@webkit.org

• 17 edits
  6 adds in trunk/Source

Add support for AVKit fullscreen to WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=128143

Patch by Jeremy Jones <​jeremyj@apple.com> on 2014-02-06
Reviewed by Simon Fraser.

Source/WebCore:

Rename overloaded functions to prevent ambiguous template parameter
compile error in generated code.

Rename overloaded exitFullscreen to exitFullscreenWithCompletionHandler.
Rename overloaded enterFullscreen to enterFullscreenWithCompletionHandler.

• WebCore.exp.in:
• WebCore.xcodeproj/project.pbxproj:
• platform/ios/WebVideoFullscreenControllerAVKit.mm:

(-[WebVideoFullscreenController exitFullscreen]):

• platform/ios/WebVideoFullscreenInterfaceAVKit.h:
• platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::enterFullscreenWithCompletionHandler):
(WebVideoFullscreenInterfaceAVKit::enterFullscreen):
(WebVideoFullscreenInterfaceAVKit::exitFullscreenWithCompletionHandler):
(WebVideoFullscreenInterfaceAVKit::exitFullscreen):

• platform/ios/WebVideoFullscreenModelMediaElement.h:

Source/WebKit2:

Add WebVideoFullscreenManager and WebVideoFullscreenManagerProxy that implement
WebVideoFullscreenModel and WebVideoFullscreenInterface.

• DerivedSources.make:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):

initialize member m_videoFullscreenManager

(WebKit::WebPageProxy::videoFullscreenManager):

add accessor for videoFullscreenManager

• UIProcess/WebPageProxy.h:
• UIProcess/WebVideoFullscreenManagerProxy.cpp: Added.

(WebKit::WebVideoFullscreenManagerProxy::create):
(WebKit::WebVideoFullscreenManagerProxy::WebVideoFullscreenManagerProxy):
(WebKit::WebVideoFullscreenManagerProxy::~WebVideoFullscreenManagerProxy):

add basic creation for object.

(WebKit::WebVideoFullscreenManagerProxy::setVideoLayerID):
(WebKit::WebVideoFullscreenManagerProxy::requestExitFullScreen):
(WebKit::WebVideoFullscreenManagerProxy::play):
(WebKit::WebVideoFullscreenManagerProxy::pause):
(WebKit::WebVideoFullscreenManagerProxy::togglePlayState):
(WebKit::WebVideoFullscreenManagerProxy::seekToTime):
(WebKit::WebVideoFullscreenManagerProxy::didExitFullscreen):

implement WebVideoFullscreenModel to send IPC message.

• UIProcess/WebVideoFullscreenManagerProxy.h: Added.
• UIProcess/WebVideoFullscreenManagerProxy.messages.in: Added.

this interface closely matches WebVideoFullscreenInterface

• WebKit2.xcodeproj/project.pbxproj:
• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::supportsFullscreenForNode):
(WebKit::WebChromeClient::enterFullscreenForNode):
(WebKit::WebChromeClient::exitFullscreenForNode):

Forward these requests onto the videoFullscreenManager

• WebProcess/WebCoreSupport/WebChromeClient.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::videoFullscreenManager):

accessor for m_videoFullscreenManager

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebVideoFullscreenManager.cpp: Added.

(WebKit::WebVideoFullscreenManager::create):
(WebKit::WebVideoFullscreenManager::WebVideoFullscreenManager):
(WebKit::WebVideoFullscreenManager::~WebVideoFullscreenManager):

add basic creation for object.

(WebKit::WebVideoFullscreenManager::supportsFullscreen):
(WebKit::WebVideoFullscreenManager::enterFullscreenForNode):
(WebKit::WebVideoFullscreenManager::exitFullscreenForNode):

implement interface called by WebChromeClient

(WebKit::WebVideoFullscreenManager::setDuration):
(WebKit::WebVideoFullscreenManager::setCurrentTime):
(WebKit::WebVideoFullscreenManager::setRate):
(WebKit::WebVideoFullscreenManager::setVideoDimensions):
(WebKit::WebVideoFullscreenManager::setVideoLayer):
(WebKit::WebVideoFullscreenManager::setVideoLayerID):
(WebKit::WebVideoFullscreenManager::enterFullscreen):
(WebKit::WebVideoFullscreenManager::exitFullscreen):

implement WebVideoFullscreenInterface to send IPC message.

• WebProcess/WebVideoFullscreenManager.h: Added.
• WebProcess/WebVideoFullscreenManager.messages.in: Added.

this interface closely matches WebVideoFullscreenModel

6:18 PM Changeset in webkit [163599] by jpfau@apple.com

• 4 edits in trunk

loadSubframe can return null in SubframeLoader::loadOrRedirectSubframe
​https://bugs.webkit.org/show_bug.cgi?id=128344

Reviewed by Ryosuke Niwa.

Source/WebCore:

• loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadOrRedirectSubframe):

LayoutTests:

• TestExpectations: Unskipped tests that were previously crashing

6:16 PM Changeset in webkit [163598] by Lucas Forschler

• 5 edits in tags/Safari-538.16.2/Source/JavaScriptCore

Merged r163595.

6:12 PM Changeset in webkit [163597] by andersca@apple.com

• 13 edits in trunk/Source/WebKit2

Begin work on making preferences per page instead of per page group
​https://bugs.webkit.org/show_bug.cgi?id=128349

Reviewed by Andreas Kling.

• UIProcess/API/C/WKPageGroup.cpp:

(WKPageGroupGetPreferences):

• UIProcess/API/C/mac/WKPagePrivateMac.cpp:

(WKPageIsURLKnownHSTSHost):

• UIProcess/API/mac/WKView.mm:

(-[WKView _preferencesDidChange]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

• UIProcess/WebContext.cpp:

(WebKit::WebContext::createWebPage):

• UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorPageGroups::createInspectorPageGroup):
(WebKit::WebInspectorProxy::attach):
(WebKit::WebInspectorProxy::detach):
(WebKit::WebInspectorProxy::setAttachedWindowHeight):
(WebKit::WebInspectorProxy::setAttachedWindowWidth):
(WebKit::WebInspectorProxy::createInspectorPage):
(WebKit::WebInspectorProxy::shouldOpenAttached):

• UIProcess/WebPageGroup.cpp:

(WebKit::WebPageGroup::preferences):

• UIProcess/WebPageGroup.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::isProcessSuppressible):
(WebKit::WebPageProxy::canShowMIMEType):
(WebKit::WebPageProxy::preferencesDidChange):
(WebKit::WebPageProxy::creationParameters):

• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::preferences):
(WebKit::WebPageProxy::setPreferences):

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createWebPage):

• UIProcess/mac/ViewGestureController.mm:

(WebKit::ViewGestureController::beginSwipeGesture):

• UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::createInspectorWindow):
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::windowFrameDidChange):
(WebKit::WebInspectorProxy::platformAttach):

6:04 PM Changeset in webkit [163596] by akling@apple.com

• 3 edits in trunk/Source/WebCore

Use child iterator in HTMLDetailsElement::findMainSummary().
<​https://webkit.org/b/128335>

Reviewed by Antti Koivisto.

• html/HTMLDetailsElement.h:
• html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::findMainSummary):

6:03 PM Changeset in webkit [163595] by msaboff@apple.com

• 5 edits in trunk/Source/JavaScriptCore

Workaround REGRESSION(r163195-r163227): Crash beneath NSErrorUserInfoFromJSException when installing AppleInternal.mpkg
​https://bugs.webkit.org/show_bug.cgi?id=128347

Reviewed by Geoffrey Garen.

Added a flag to VM class called m_ignoreStackLimit that disables stack limit checks.
We set this flag in JSContextGroupCreate() and JSGlobalContextCreateInGroup().

Disabled stack overflow tests in testapi.js since it uses these paths.

THis patch will be reverted as part of a comprehensive solution to the problem.

• API/JSContextRef.cpp:

(JSContextGroupCreate):
(JSGlobalContextCreateInGroup):

• API/tests/testapi.js:
• runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::updateStackLimitWithReservedZoneSize):

• runtime/VM.h:

(JSC::VM::ignoreStackLimit):

6:01 PM Changeset in webkit [163594] by Antti Koivisto

• 2 edits in trunk/Source/WebCore

Add missing &.

• css/StyleInvalidationAnalysis.cpp:

(WebCore::shouldDirtyAllStyle):

6:01 PM Changeset in webkit [163593] by Lucas Forschler

• 3 edits in tags/Safari-538.16.2/Source/WebCore

Rollout r163558.

5:58 PM Changeset in webkit [163592] by Antti Koivisto

• 11 edits in trunk/Source/WebCore

Check selectors exactly when invalidating style
​https://bugs.webkit.org/show_bug.cgi?id=128321

Reviewed by Andreas Kling.

Selectors are now really fast to match with the JIT. Take advantage of this by invalidating
the document style exactly when a new stylesheet arrives (instead of using heuristics).

This reduces need for large style recalculations in some common cases.

• css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::clearMatchedRules):
(WebCore::ElementRuleCollector::collectMatchingRulesForList):

• css/ElementRuleCollector.h:

(WebCore::ElementRuleCollector::hasMatchedRules):

• css/RuleSet.h:

(WebCore::RuleSet::hasShadowPseudoElementRules):

• css/SelectorChecker.cpp:

(WebCore::SelectorChecker::matchRecursively):

• css/SelectorChecker.h:

Add new mode where all pseudo elements match so we can invalidate their element.

• css/StyleInvalidationAnalysis.cpp:

(WebCore::shouldDirtyAllStyle):
(WebCore::StyleInvalidationAnalysis::StyleInvalidationAnalysis):
(WebCore::invalidateStyleRecursively):
(WebCore::StyleInvalidationAnalysis::invalidateStyle):

Switch to real selector checker.

• css/StyleInvalidationAnalysis.h:
• css/StyleResolver.cpp:

(WebCore::StyleResolver::MatchedProperties::~MatchedProperties):

• css/StyleResolver.h:

(WebCore::StyleResolver::mediaQueryEvaluator):

• dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):

5:57 PM Changeset in webkit [163591] by barraclough@apple.com

• 15 edits in trunk/Source

Remove ChildProcess::m_activeTasks
​https://bugs.webkit.org/show_bug.cgi?id=128342

Reviewed by Anders Carlson.

Currently we funnel a number of different user activities
to a single UserActivity object, which requires a call down
from WebCore to WebKit2. Split these out so we can track
them separately.

Source/WebCore:

• page/ChromeClient.h:
  • removed [inc|dec]rementActivePageCount
• page/PageThrottler.cpp:

(WebCore::PageThrottler::PageThrottler):

• incrementActivePageCount -> beginActivity

(WebCore::PageThrottler::~PageThrottler):

• decrementActivePageCount -> endActivity

(WebCore::PageThrottler::throttlePage):

• decrementActivePageCount -> endActivity

(WebCore::PageThrottler::unthrottlePage):

• incrementActivePageCount -> beginActivity

• page/PageThrottler.h:
  • Added m_pageActivity.

Source/WebKit2:

• PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::PluginProcess):

• added m_connectionActivity.

• PluginProcess/PluginProcess.h:

(WebKit::PluginProcess::connectionActivity):

• added m_connectionActivity.

• PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::didReceiveSyncMessage):
(WebKit::WebProcessConnection::destroyPlugin):
(WebKit::WebProcessConnection::createPlugin):

• use connectionActivity

• PluginProcess/mac/PluginProcessMac.mm:

(WebKit::PluginProcess::platformInitializeProcess):

• use a separate UserActivity for Java.

• Shared/ActivityAssertion.cpp:

(WebKit::ActivityAssertion::ActivityAssertion):
(WebKit::ActivityAssertion::~ActivityAssertion):

• Shared/ActivityAssertion.h:
  • ChildProcess -> UserActivity
• Shared/ChildProcess.cpp:

(WebKit::ChildProcess::ChildProcess):

• Shared/ChildProcess.h:
  • remove m_activeTasks.

(WebKit::ChildProcess::processSuppressionEnabled):

• WebProcess/WebCoreSupport/WebChromeClient.cpp:
• WebProcess/WebCoreSupport/WebChromeClient.h:
  • removed [inc|dec]rementActivePageCount

5:56 PM Changeset in webkit [163590] by mhahnenberg@apple.com

• 6 edits in trunk/Source/JavaScriptCore

+[JSContext currentCallee] should return the currently executing JS function
​https://bugs.webkit.org/show_bug.cgi?id=122621

Reviewed by Geoffrey Garen.

It would be useful if there was a +[JSContext currentObject] API which was
callable from ObjC API callbacks. Its purpose would be to allow convenient
access to the JSValue wrapper for the currently-executing block callback.

• API/JSContext.h:
• API/JSContext.mm:

(+[JSContext currentCallee]):
(-[JSContext beginCallbackWithData:calleeValue:thisValue:argumentCount:arguments:]):

• API/JSContextInternal.h:
• API/ObjCCallbackFunction.mm:

(JSC::objCCallbackFunctionCallAsFunction):
(JSC::objCCallbackFunctionCallAsConstructor):

• API/tests/testapi.mm:

5:55 PM Changeset in webkit [163589] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r163558.
​http://trac.webkit.org/changeset/163558
​https://bugs.webkit.org/show_bug.cgi?id=128350

Breaks scrolling on certain websites (Requested by bfulgham on
#webkit).

• page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent):

• page/WheelEventDeltaTracker.h:

5:33 PM Changeset in webkit [163588] by psolanki@apple.com

• 3 edits
  1 add in trunk/Source/WebKit2

[iOS] WebKit2 can't access the GPU
​https://bugs.webkit.org/show_bug.cgi?id=128345
<rdar://problem/15976084>

Reviewed by Tim Horton.

Add an entitlement to allow web process to access GPU.

• Configurations/WebContent-iOS.entitlements: Added.
• Configurations/WebContentService.Development.xcconfig:
• Configurations/WebContentService.xcconfig:

5:30 PM Changeset in webkit [163587] by psolanki@apple.com

• 5 edits in trunk/Source/WebKit2

[iOS][WebKit2] Remove JoinExistingSession from plist
​https://bugs.webkit.org/show_bug.cgi?id=128318
<rdar://problem/15971612>

Reviewed by Tim Horton.

Remove JoinExistingSession key that is not available on iOS.

• NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info-iOS.plist:
• NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist:
• WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-iOS.plist:
• WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist:

5:29 PM Changeset in webkit [163586] by Chris Fleizach

• 5 edits in trunk/Source/WebCore

AX: Crash in WebCore::AXObjectCache::computedObjectAttributeCache
​https://bugs.webkit.org/show_bug.cgi?id=128310

Reviewed by Alexey Proskuryakov.

Be more careful about using axObjectCache() directly since it can return null.
I audited the usage cases of this method and ensured the ptr was not null in cases
where I thought we might get hit by this.

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::parentObject):
(WebCore::AccessibilityNodeObject::menuForMenuButton):
(WebCore::AccessibilityNodeObject::menuButtonForMenu):

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::firstAccessibleObjectFromNode):
(WebCore::AccessibilityObject::findMatchingObjects):
(WebCore::AccessibilityObject::elementAccessibilityHitTest):
(WebCore::AccessibilityObject::axObjectCache):
(WebCore::AccessibilityObject::notifyIfIgnoredValueChanged):
(WebCore::AccessibilityObject::accessibilityIsIgnored):

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::parentObjectIfExists):
(WebCore::AccessibilityRenderObject::parentObject):
(WebCore::AccessibilityRenderObject::anchorElement):
(WebCore::AccessibilityRenderObject::isTabItemSelected):
(WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
(WebCore::AccessibilityRenderObject::nodeIsTextControl):
(WebCore::AccessibilityRenderObject::activeDescendant):
(WebCore::AccessibilityRenderObject::handleAriaExpandedChanged):
(WebCore::AccessibilityRenderObject::observableObject):
(WebCore::AccessibilityRenderObject::textChanged):

• accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::addChildScrollbar):
(WebCore::AccessibilityScrollView::webAreaObject):
(WebCore::AccessibilityScrollView::parentObject):
(WebCore::AccessibilityScrollView::parentObjectIfExists):

5:21 PM Changeset in webkit [163585] by zoltan@webkit.org

• 6 edits
  2 adds in trunk

[CSS Shapes] Rounded Insets Let Content Overlap Shape
​https://bugs.webkit.org/show_bug.cgi?id=127852

Reviewed by Bem Jones-Bey.

Source/WebCore:

Using LengthSize to FloatSize conversion from LengthSize.h lead to miscalculated
inset border radius, when the border radius was defined by percentages. This patch
fixes the behavior and removes the incorrect conversion.

Test: fast/shapes/shape-outside-floats/shape-outside-rounded-inset.html

• css/LengthFunctions.cpp:

(WebCore::floatSizeForLengthSize): Add new helper function for LengthSize to FloatSize conversion.

• css/LengthFunctions.h:
• platform/LengthSize.h: Remove floatSize conversion.
• rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape): Use new helper function to calculate the right with for the inset border radius.

LayoutTests:

• fast/shapes/shape-outside-floats/shape-outside-rounded-inset-expected.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-rounded-inset.html: Added.

5:18 PM Changeset in webkit [163584] by mhahnenberg@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Fix iOS builds after r163574

• API/JSManagedValue.h:

5:17 PM Changeset in webkit [163583] by Lucas Forschler

• 5 edits in branches/safari-537.60-branch/Source

Versioning.

5:13 PM Changeset in webkit [163582] by Lucas Forschler

• 1 copy in tags/Safari-537.60.15

New Tag.

5:00 PM Changeset in webkit [163581] by Joseph Pecoraro

• 2 edits in trunk/Source/WebCore

Regenerate JSTestObj now that ScriptArguments moved. Generator knows what to do.

Rubber-stamped by Zalan Bujtas.

• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionWithScriptArgumentsAndCallStack):

4:58 PM Changeset in webkit [163580] by Lucas Forschler

• 2 edits in branches/safari-537.60-branch/Source/WebKit/win

Merged r163557.

4:54 PM Changeset in webkit [163579] by jpfau@apple.com

• 6 edits
  6 adds in trunk

Make adoption agency use the task queue
​https://bugs.webkit.org/show_bug.cgi?id=109445

Reviewed by Ryosuke Niwa.

Source/WebCore:

Tests: fast/parser/adoption-agency-crash-01.html

fast/parser/adoption-agency-crash-02.html
fast/parser/adoption-agency-crash-03.html

• html/parser/HTMLConstructionSite.cpp:

(WebCore::insert):
(WebCore::executeInsertTask):
(WebCore::executeReparentTask):
(WebCore::executeInsertAlreadyParsedChildTask):
(WebCore::executeTakeAllChildrenTask):
(WebCore::executeTask):
(WebCore::HTMLConstructionSite::attachLater):
(WebCore::HTMLConstructionSite::executeQueuedTasks):
(WebCore::HTMLConstructionSite::insertTextNode):
(WebCore::HTMLConstructionSite::reparent):
(WebCore::HTMLConstructionSite::insertAlreadyParsedChild):
(WebCore::HTMLConstructionSite::takeAllChildren):
(WebCore::HTMLConstructionSite::fosterParent):

• html/parser/HTMLConstructionSite.h:

(WebCore::HTMLConstructionSiteTask::HTMLConstructionSiteTask):
(WebCore::HTMLConstructionSiteTask::oldParent):

• html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

LayoutTests:

• TestExpectations:
• fast/parser/adoption-agency-crash-01-expected.txt: Added.
• fast/parser/adoption-agency-crash-01.html: Added.
• fast/parser/adoption-agency-crash-02-expected.txt: Added.
• fast/parser/adoption-agency-crash-02.html: Added.
• fast/parser/adoption-agency-crash-03-expected.txt: Added.
• fast/parser/adoption-agency-crash-03.html: Added.

4:51 PM Changeset in webkit [163578] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Fix build.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _remoteObjectRegistry]):

4:50 PM Changeset in webkit [163577] by benjamin@webkit.org

• 2 edits in trunk/Source/WebKit2

Fix the setter definition from r163514.

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-02-06

• UIProcess/API/Cocoa/WKWebViewPrivate.h:

4:42 PM Changeset in webkit [163576] by mhahnenberg@apple.com

• 20 edits
  1 copy in trunk/Source

Heap::writeBarrier shouldn't be static
​https://bugs.webkit.org/show_bug.cgi?id=127807

Reviewed by Geoffrey Garen.

Currently it looks up the Heap in which to fire the write barrier by using
the cell passed to it. Almost every call site already has a reference to the
VM or the Heap itself. It seems wasteful to look it up all over again.

Source/JavaScriptCore:

• GNUmakefile.list.am:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
• JavaScriptCore.xcodeproj/project.pbxproj:
• heap/CopyWriteBarrier.h:

(JSC::CopyWriteBarrier::set):

• heap/Heap.cpp:

(JSC::Heap::writeBarrier):

• heap/Heap.h:

(JSC::Heap::writeBarrier):

• jit/JITOperations.cpp:
• jit/JITWriteBarrier.h:

(JSC::JITWriteBarrierBase::set):

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::llint_write_barrier_slow):

• runtime/Arguments.h:
• runtime/JSWeakMap.cpp:
• runtime/MapData.cpp:

(JSC::MapData::ensureSpaceForAppend):

• runtime/PropertyTable.cpp:

(JSC::PropertyTable::PropertyTable):

• runtime/Structure.h:
• runtime/WriteBarrier.h:
• runtime/WriteBarrierInlines.h: Added.

Source/WebCore:

• bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener):

• bindings/js/JSEventListener.h:

(WebCore::JSEventListener::jsFunction):

4:33 PM Changeset in webkit [163575] by Joseph Pecoraro

• 2 edits in trunk/Source/WebKit

Unreviewed Windows Build Fix after r163568.

Remove old symbol export. It is now const. Waiting for bot to produce new symbol.

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

4:29 PM Changeset in webkit [163574] by mhahnenberg@apple.com

• 7 edits
  1 add in trunk/Source/JavaScriptCore

JSManagedValue should automatically call removeManagedReference:withOwner: upon dealloc
​https://bugs.webkit.org/show_bug.cgi?id=124053

Reviewed by Geoffrey Garen.

• API/JSManagedValue.h:
• API/JSManagedValue.mm:

(+[JSManagedValue managedValueWithValue:andOwner:]):
(-[JSManagedValue initWithValue:]):
(-[JSManagedValue dealloc]):
(-[JSManagedValue didAddOwner:]):
(-[JSManagedValue didRemoveOwner:]):

• API/JSManagedValueInternal.h: Added.
• API/JSVirtualMachine.mm:

(-[JSVirtualMachine addManagedReference:withOwner:]):
(-[JSVirtualMachine removeManagedReference:withOwner:]):

• API/WebKitAvailability.h:
• API/tests/testapi.mm:

(-[TextXYZ click]):

• JavaScriptCore.xcodeproj/project.pbxproj:

4:29 PM Changeset in webkit [163573] by ljaehun.lim@samsung.com

• 3 edits in trunk/Source/WebCore

Unreviewed, fix build error on 64bit debug build

Apply static_cast<long long> to int64_t variable when '%lli' is used.

• Modules/indexeddb/IDBDatabaseBackend.cpp:

(WebCore::IDBDatabaseBackend::clearObjectStore):

• Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::setActive):

4:28 PM Changeset in webkit [163572] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[iOS] Remove duplicate call to RunLoop::initializeMainRunLoop
​https://bugs.webkit.org/show_bug.cgi?id=128328

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-02-06
Reviewed by Dan Bernstein.

• UIProcess/API/ios/WKContentView.mm:

(-[WKContentView initWithFrame:configuration:]):
(-[WKContentView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):

4:25 PM Changeset in webkit [163571] by Brent Fulgham

• 2 edits in branches/safari-537.75-branch/Source/WebKit/win

Merge r163557.

2014-02-06 Brent Fulgham <Brent Fulgham>

[Win] Correct IME Regression after r141479
​https://bugs.webkit.org/show_bug.cgi?id=128323
<rdar://problem/15952986>

Reviewed by Tim Horton.

• WebView.cpp: (WebView::updateSelectionForIME): Refactoring flipped the meaning of the test used to select the resetIME case. Corrected for behavior of new cancel method.

4:03 PM Changeset in webkit [163570] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Add support for multiple sources for AutoInstaller
​https://bugs.webkit.org/show_bug.cgi?id=124848

Patch by Jozsef Berta <​jberta.u-szeged@partner.samsung.com> on 2014-02-06
Reviewed by Ryosuke Niwa.

The autoinstaller in the webkitpy currently fails if the download source of a package is unavailable.
This patch adds support for multiple sources to the script. The sources are provided in three environment variables.
If it exists, the script will look at a local cache. If not, it will try to download the package from the original url.
If it fails, it gets a mirror from the corresponding environment variable.(One for sourceforge.org and one for pypi.python.org)

• Scripts/webkitpy/common/system/autoinstall.py:

(AutoInstaller._copy_unpackaged_files_from_local_cache): If the package is not packaged in its original form,
this method will copy it to the scratch directory. Otherwise it would be deleted from the cache, which we do not want.
(AutoInstaller._prepare_package): If the package is not zipped or tarred, and the file is in the cache, the
_copy_unpackaged_files_from_local_cache function is called.
(AutoInstaller._parse_colon_separated_mirrors_from_env): This will read the mirrors from the environment variables if possible,
and prepares them for further use.
(AutoInstaller):
(AutoInstaller._replace_domain_with_next_mirror): If the original download url fails, it is replaced by a mirror provided
in the environment variables. The function identifies the original source, and replaces it with a mirror. If it can't be done,
the return url will be None, indicating that no mirrors are provided, or none of them could be reached.
(AutoInstaller._download_to_stream): The timeout for one try is now limited to 30 seconds. Without this, the script waited for
roughly 4 minutes before retrying. After three failiures the script will try to switch to a mirror.
(AutoInstaller._check_package_in_local_autoinstall_cache): This method searches the cache for the currently downloaded module.
If it's found there, its path is returned.
(AutoInstaller._download): Before downloading the module, it is looked up in the cache. If it's not found there,
the script will continue with the download, and cache the module.

3:45 PM Changeset in webkit [163569] by Joseph Pecoraro

• 2 edits in trunk/Source/WebKit2

[iOS] Set UIProcess pid in WebProcess initialization for Remote Inspector
​https://bugs.webkit.org/show_bug.cgi?id=128338

Reviewed by Sam Weinig.

• WebProcess/ios/WebProcessIOS.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

3:45 PM Changeset in webkit [163568] by Joseph Pecoraro

• 135 edits
  3 copies
  15 moves
  10 adds
  2 deletes in trunk

Web Inspector: Add Console support to JSContext Inspection
​https://bugs.webkit.org/show_bug.cgi?id=127941

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

• CMakeLists.txt:
• DerivedSources.make:
• GNUmakefile.am:
• GNUmakefile.list.am:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
• JavaScriptCore.xcodeproj/project.pbxproj:

Add new files.

• inspector/agents/InspectorConsoleAgent.cpp: Renamed from Source/WebCore/inspector/InspectorConsoleAgent.cpp.
• inspector/agents/InspectorConsoleAgent.h: Added.

New agent moved from WebCore. Rename a method to work in JS only context.

• inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
Instantiate ConsoleAgent.

• inspector/agents/JSGlobalObjectConsoleAgent.h: Copied from Source/WebCore/inspector/PageInjectedScriptHost.h.
• inspector/agents/JSGlobalObjectConsoleAgent.cpp: Copied from Source/WebCore/inspector/PageInjectedScriptHost.h.

(Inspector::JSGlobalObjectConsoleAgent::JSGlobalObjectConsoleAgent):
(Inspector::JSGlobalObjectConsoleAgent::setMonitoringXHREnabled):
(Inspector::JSGlobalObjectConsoleAgent::addInspectedNode):
(Inspector::JSGlobalObjectConsoleAgent::addInspectedHeapObject):
JSGlobalObject implementation.

• inspector/agents/JSGlobalObjectDebuggerAgent.h:
• inspector/agents/JSGlobalObjectDebuggerAgent.cpp:

(Inspector::JSGlobalObjectDebuggerAgent::JSGlobalObjectDebuggerAgent):
(Inspector::JSGlobalObjectDebuggerAgent::breakpointActionLog):
Use ConsoleAgent to report logs.

• inspector/ConsoleMessage.cpp: Renamed from Source/WebCore/inspector/ConsoleMessage.cpp.
• inspector/ConsoleMessage.h: Renamed from Source/WebCore/inspector/ConsoleMessage.h.
• inspector/ConsoleTypes.h: Copied from Source/WebCore/inspector/ConsoleAPITypes.h.
• inspector/IdentifiersFactory.cpp: Renamed from Source/WebCore/inspector/IdentifiersFactory.cpp.
• inspector/IdentifiersFactory.h: Renamed from Source/WebCore/inspector/IdentifiersFactory.h.
• inspector/ScriptArguments.cpp: Renamed from Source/WebCore/inspector/ScriptArguments.cpp.
• inspector/ScriptArguments.h: Renamed from Source/WebCore/inspector/ScriptArguments.h.
• inspector/ScriptCallFrame.cpp: Renamed from Source/WebCore/inspector/ScriptCallFrame.cpp.
• inspector/ScriptCallFrame.h: Renamed from Source/WebCore/inspector/ScriptCallFrame.h.
• inspector/ScriptCallStack.cpp: Renamed from Source/WebCore/inspector/ScriptCallStack.cpp.
• inspector/ScriptCallStack.h: Renamed from Source/WebCore/inspector/ScriptCallStack.h.
• inspector/ScriptCallStackFactory.cpp: Renamed from Source/WebCore/bindings/js/ScriptCallStackFactory.cpp.
• inspector/ScriptCallStackFactory.h: Renamed from Source/WebCore/bindings/js/ScriptCallStackFactory.h.
• inspector/protocol/Console.json: Renamed from Source/WebCore/inspector/protocol/Console.json.
• inspector/scripts/generate-combined-inspector-json.py:

Source/WebCore:

• Move InspectorConsoleAgent and dependencies to JavaScriptCore and into the Inspector namespace.
• Update Console Message enum types to enum classes and update all users to the new, simpler names.
• Since we are updating addConsoleMessage callsites anyways, add ASCIILiteral where appropriate.
• Add WebConsoleAgent base of Page/Worker ConsoleAgent to implement what could not be pushed into JavaScriptCore.

• CMakeLists.txt:
• DerivedSources.make:
• ForwardingHeaders/inspector/ConsoleMessage.h: Added.
• ForwardingHeaders/inspector/ConsoleTypes.h: Added.
• ForwardingHeaders/inspector/IdentifiersFactory.h: Added.
• ForwardingHeaders/inspector/ScriptArguments.h: Added.
• ForwardingHeaders/inspector/ScriptCallFrame.h: Added.
• ForwardingHeaders/inspector/ScriptCallStack.h: Added.
• ForwardingHeaders/inspector/ScriptCallStackFactory.h: Added.
• ForwardingHeaders/inspector/agents/InspectorConsoleAgent.h: Added.
• GNUmakefile.am:
• GNUmakefile.list.am:

Add / remove files from builds.

• inspector/WebConsoleAgent.h:
• inspector/WebConsoleAgent.cpp: Added.

(WebCore::WebConsoleAgent::WebConsoleAgent):
(WebCore::WebConsoleAgent::setMonitoringXHREnabled):
(WebCore::WebConsoleAgent::frameWindowDiscarded):
(WebCore::WebConsoleAgent::didFinishXHRLoading):
(WebCore::WebConsoleAgent::didReceiveResponse):
(WebCore::WebConsoleAgent::didFailLoading):
(WebCore::WebConsoleAgent::addInspectedHeapObject):
Implement what could not be pushed down into JavaScriptCore.

• inspector/InstrumentingAgents.h:

(WebCore::InstrumentingAgents::webConsoleAgent):
(WebCore::InstrumentingAgents::setWebConsoleAgent):
Hold a WebConsoleAgent instead of InspectorConsoleAgent.

• Modules/indexeddb/IDBCursor.cpp:
• Modules/indexeddb/IDBDatabase.cpp:
• Modules/indexeddb/IDBTransaction.cpp:
• Modules/quota/DOMWindowQuota.cpp:

(WebCore::DOMWindowQuota::webkitStorageInfo):

• Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::looping):
(WebCore::AudioBufferSourceNode::setLooping):

• Modules/webaudio/AudioContext.cpp:
• Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::setPanningModel):

• Modules/webdatabase/DatabaseBase.cpp:

(WebCore::DatabaseBase::logErrorMessage):

• Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::logErrorMessage):

• Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):
(WebCore::WebSocket::send):
(WebCore::WebSocket::close):
(WebCore::WebSocket::setBinaryType):

• Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::didFailSocketStream):

• Modules/websockets/WebSocketHandshake.cpp:
• WebCore.exp.in:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSAudioContextCustom.cpp:

(WebCore::JSAudioContextConstructor::constructJSAudioContext):

• bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

• bindings/js/JSDOMBinding.cpp:
• bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::JSSubtleCrypto::encrypt):
(WebCore::JSSubtleCrypto::decrypt):
(WebCore::JSSubtleCrypto::sign):
(WebCore::JSSubtleCrypto::verify):
(WebCore::JSSubtleCrypto::wrapKey):
(WebCore::JSSubtleCrypto::unwrapKey):

• bindings/js/ScriptController.cpp:

(WebCore::ScriptController::canExecuteScripts):

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallWith):

• bindings/scripts/test/JS/JSTestObj.cpp:
• css/CSSParser.cpp:

(WebCore::CSSParser::logError):

• css/MediaList.cpp:

(WebCore::addResolutionWarningMessageToConsole):

• dom/Document.cpp:

(WebCore::Document::logExceptionToConsole):
(WebCore::Document::processHttpEquiv):
(WebCore::Document::addMessage):

• dom/Document.h:
• dom/ScriptElement.cpp:

(WebCore::ScriptElement::executeScript):
(WebCore::ScriptElement::notifyFinished):

• dom/ScriptExecutionContext.cpp:
• dom/ScriptExecutionContext.h:
• dom/ViewportArguments.cpp:

(WebCore::viewportErrorMessageLevel):
(WebCore::reportViewportWarning):

• fileapi/Blob.cpp:
• fileapi/WebKitBlobBuilder.cpp:
• html/HTMLFormControlElement.cpp:

(WebCore::shouldAutofocus):

• html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::validateInteractively):

• html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::parseAttribute):

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::getImageData):

• html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::printWarningToConsole):

• html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::init):

• html/parser/XSSAuditorDelegate.cpp:

(WebCore::XSSAuditorDelegate::didBlockScript):

• inspector/CommandLineAPIHost.cpp:
• inspector/CommandLineAPIHost.h:

(WebCore::CommandLineAPIHost::init):

• inspector/InspectorAllInOne.cpp:
• inspector/InspectorConsoleAgent.h: Removed.
• inspector/InspectorConsoleInstrumentation.h:

(WebCore::InspectorInstrumentation::addMessageToConsole):
(WebCore::InspectorInstrumentation::consoleCount):
(WebCore::InspectorInstrumentation::stopConsoleTiming):
(WebCore::InspectorInstrumentation::consoleTimeStamp):
(WebCore::InspectorInstrumentation::addProfile):

• inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

• inspector/InspectorDOMAgent.cpp:
• inspector/InspectorFrontendHost.h:
• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::frameWindowDiscardedImpl):
(WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
(WebCore::InspectorInstrumentation::didFailLoadingImpl):
(WebCore::InspectorInstrumentation::didFinishXHRLoadingImpl):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
(WebCore::isConsoleAssertMessage):
(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
(WebCore::InspectorInstrumentation::consoleCountImpl):
(WebCore::InspectorInstrumentation::startConsoleTimingImpl):
(WebCore::InspectorInstrumentation::stopConsoleTimingImpl):
(WebCore::InspectorInstrumentation::consoleAgentEnabled):

• inspector/InspectorInstrumentation.h:
• inspector/InspectorLayerTreeAgent.cpp:
• inspector/InspectorPageAgent.cpp:
• inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
(WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):

• inspector/InspectorProfilerAgent.h:
• inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::buildInitiatorObject):

• inspector/InspectorTimelineAgent.cpp:
• inspector/InstrumentingAgents.cpp:

(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::reset):

• inspector/PageConsoleAgent.cpp:

(WebCore::PageConsoleAgent::PageConsoleAgent):
(WebCore::PageConsoleAgent::clearMessages):
(WebCore::PageConsoleAgent::addInspectedNode):

• inspector/PageConsoleAgent.h:
• inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::breakpointActionLog):

• inspector/PageInjectedScriptHost.h:
• inspector/PageInjectedScriptManager.h:
• inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createGenericRecord):
(WebCore::WebConsoleAgent::~WebConsoleAgent):

• inspector/WorkerConsoleAgent.cpp:

(WebCore::WorkerConsoleAgent::WorkerConsoleAgent):
(WebCore::WorkerConsoleAgent::addInspectedNode):

• inspector/WorkerConsoleAgent.h:
• inspector/WorkerDebuggerAgent.cpp:

(WebCore::WorkerDebuggerAgent::breakpointActionLog):

• inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived):

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::reportLocalLoadFailed):
(WebCore::FrameLoader::handleBeforeUnloadEvent):
(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
(WebCore::createWindow):

• loader/ImageLoader.cpp:

(WebCore::ImageLoader::notifyFinished):

• loader/MixedContentChecker.cpp:

(WebCore::MixedContentChecker::logWarning):

• loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::corsPolicyPreventedLoad):

• loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::abort):
(WebCore::ApplicationCacheGroup::didReceiveResponse):
(WebCore::ApplicationCacheGroup::didFinishLoading):
(WebCore::ApplicationCacheGroup::didFail):
(WebCore::ApplicationCacheGroup::didReceiveManifestResponse):
(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):

• loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::printAccessDeniedMessage):

• page/ChromeClient.h:
• page/Console.cpp:

(WebCore::internalAddMessage):
(WebCore::Console::debug):
(WebCore::Console::error):
(WebCore::Console::log):
(WebCore::Console::warn):
(WebCore::Console::dir):
(WebCore::Console::dirxml):
(WebCore::Console::table):
(WebCore::Console::clear):
(WebCore::Console::trace):
(WebCore::Console::assertCondition):
(WebCore::Console::group):
(WebCore::Console::groupCollapsed):
(WebCore::Console::groupEnd):

• page/Console.h:
• page/ConsoleTypes.h: Removed.
• page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::reportViolation):
(WebCore::ContentSecurityPolicy::logToConsole):

• page/DOMSecurityPolicy.cpp:
• page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessage):
(WebCore::DOMWindow::dispatchMessageEventWithOriginCheck):
(WebCore::DOMWindow::close):
(WebCore::DOMWindow::printErrorMessage):

• page/DOMWindow.h:
• page/EventSource.cpp:

(WebCore::EventSource::didReceiveResponse):
(WebCore::EventSource::didFailAccessControlCheck):

• page/PageConsole.cpp:

(WebCore::PageConsole::printMessageSourceAndLevelPrefix):
(WebCore::PageConsole::addMessage):

• page/PageConsole.h:
• page/PointerLockController.cpp:

(WebCore::PointerLockController::requestPointerLock):

• platform/CrossThreadCopier.h:
• rendering/shapes/ShapeInfo.cpp:

(WebCore::checkShapeImageOrigin):

• svg/SVGDocumentExtensions.cpp:

(WebCore::reportMessage):
(WebCore::SVGDocumentExtensions::reportWarning):
(WebCore::SVGDocumentExtensions::reportError):

• testing/Internals.cpp:

(WebCore::Internals::consoleMessageArgumentCounts):

• workers/DefaultSharedWorkerRepository.cpp:
• workers/SharedWorkerGlobalScope.cpp:

(WebCore::SharedWorkerGlobalScope::logExceptionToConsole):

• workers/SharedWorkerGlobalScope.h:
• workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::addMessageToWorkerConsole):

• workers/WorkerGlobalScope.h:
• workers/WorkerMessagingProxy.cpp:
• workers/WorkerReportingProxy.h:
• xml/XMLHttpRequest.cpp:

(WebCore::logConsoleError):
(WebCore::XMLHttpRequest::send):

• xml/XSLTProcessorLibxslt.cpp:

(WebCore::XSLTProcessor::parseErrorFunc):

Source/WebInspectorUI:

• UserInterface/InspectorJSBackendCommands.js:
• UserInterface/InspectorWebBackendCommands.js:

ConsoleAgent moved to JavaScript section.

Source/WebKit/gtk:

• WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::addMessageToConsole):

Source/WebKit/mac:

• WebCoreSupport/WebChromeClient.h:
• WebCoreSupport/WebChromeClient.mm:

(stringForMessageSource):
(stringForMessageLevel):
(WebChromeClient::addMessageToConsole):

Source/WebKit/win:

• WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

• WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit2:

• WebProcess/WebCoreSupport/WebChromeClient.h:

LayoutTests:

• inspector-protocol/page/deny-X-FrameOption-expected.txt:

Update with better line/column numbers now.

3:29 PM Changeset in webkit [163567] by andersca@apple.com

• 3 edits in trunk/Source/WebKit2

Add preferences property to WKWebViewConfiguration
​https://bugs.webkit.org/show_bug.cgi?id=128337

Reviewed by Sam Weinig.

Also use RetainPtr for processClass and preferences so we won't leak them.

• UIProcess/API/Cocoa/WKWebViewConfiguration.h:
• UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration processClass]):
(-[WKWebViewConfiguration setProcessClass:]):
(-[WKWebViewConfiguration preferences]):
(-[WKWebViewConfiguration setPreferences:]):

3:24 PM Changeset in webkit [163566] by benjamin@webkit.org

• 2 edits
  1 delete in trunk/Tools

Remove run-test-webkit-api
​https://bugs.webkit.org/show_bug.cgi?id=118145

Reviewed by Csaba Osztrogonác.

Having two scripts doing the same thing is confusing. There are also cases failing
on run-test-webkit-api since it does not restart a new process for each test.

• Scripts/run-test-webkit-api: Removed.
• Scripts/webkitdirs.pm:

3:06 PM Changeset in webkit [163565] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Convert a parameter to PassRefPtr
​https://bugs.webkit.org/show_bug.cgi?id=128327

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-02-06
Reviewed by Timothy Hatcher.

• inspector/InspectorConsoleInstrumentation.h:

(WebCore::InspectorInstrumentation::addProfile):

• inspector/InspectorInstrumentation.h:

2:40 PM Changeset in webkit [163564] by andersca@apple.com

• 4 edits in trunk/Source/WebKit2

Add a remoteObjectRegistry property to WKWebView
​https://bugs.webkit.org/show_bug.cgi?id=128331

Reviewed by Tim Horton.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView resizeSubviewsWithOldSize:]):
(-[WKWebView _remoteObjectRegistry]):

• UIProcess/API/Cocoa/WKWebViewInternal.h:
• UIProcess/API/Cocoa/WKWebViewPrivate.h:

2:04 PM Changeset in webkit [163563] by andersca@apple.com

• 5 edits
  3 copies in trunk/Source/WebKit2

Add WKNavigationResponse class
​https://bugs.webkit.org/show_bug.cgi?id=128326

Reviewed by Dan Bernstein.

• UIProcess/API/Cocoa/WKFrameInfo.mm:

(-[WKFrameInfo initWithWebFrameProxy:WebKit::]):

• UIProcess/API/Cocoa/WKFrameInfoInternal.h:
• UIProcess/API/Cocoa/WKNavigationResponse.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfo.mm.
• UIProcess/API/Cocoa/WKNavigationResponse.mm: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfo.mm.

(-[WKNavigationResponse frame]):
(-[WKNavigationResponse setFrame:]):
(-[WKNavigationResponse response]):
(-[WKNavigationResponse setResponse:]):

• UIProcess/API/Cocoa/WKNavigationResponseInternal.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfoInternal.h.
• UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction):
(WebKit::NavigationState::PolicyClient::decidePolicyForResponse):

• WebKit2.xcodeproj/project.pbxproj:

1:53 PM Changeset in webkit [163562] by oliver@apple.com

• 41 edits in trunk

Push DOM attributes into the prototype chain
​https://bugs.webkit.org/show_bug.cgi?id=127969

Reviewed by Mark Lam.

Source/WebCore:

This patch does the actual work of moving dom attributes up the
prototype chain. There are still a few class and edge cases
where we can't do this without impacting existing behaviour,
but they can be fixed separately in later patches.

• bindings/js/JSDOMBinding.h:

(WebCore::getStaticPropertySlotEntryWithoutCaching):
(WebCore::getStaticPropertySlotEntryWithoutCaching<JSDOMWrapper>):

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(HasComplexGetOwnProperty):
(ConstructorShouldBeOnInstance):
(AttributeShouldBeOnInstance):
(InstanceAttributeCount):
(PrototypeAttributeCount):
(InstanceOverridesGetOwnPropertySlot):
(PrototypeOverridesGetOwnPropertySlot):
(GenerateAttributesHashTable):
(GenerateImplementation):

LayoutTests:

Update layout test results

• fast/dom/wrapper-classes-expected.txt:
• js/dom/constructor-attributes-expected.txt:
• js/dom/dom-static-property-for-in-iteration-expected.txt:
• js/dom/script-tests/constructor-attributes.js:

1:35 PM Changeset in webkit [163561] by Lucas Forschler

• 3 edits in tags/Safari-538.16.2/Source/WebCore

Merged r163558.

1:24 PM Changeset in webkit [163560] by akling@apple.com

• 38 edits
  29 deletes in trunk

Remove display:run-in support.
<​https://webkit.org/b/127874>
<rdar://problem/15926949>

Source/WebCore:

Remove support for the "run-in" display type. Blink recently removed
this and Gecko never supported in the first place.

Rubber-stamped by Anders Carlsson.

• css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):

• css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

• css/CSSValueKeywords.in:
• css/StyleResolver.cpp:

(WebCore::equivalentBlockDisplay):
(WebCore::doesNotInheritTextDecoration):

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::willBeDestroyed):
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
(WebCore::RenderBlock::makeChildrenNonInline):
(WebCore::canMergeContiguousAnonymousBlocks):
(WebCore::RenderBlock::renderName):

• rendering/RenderBlock.h:
• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::willBeDestroyed):
(WebCore::shouldCheckLines):
(WebCore::getHeightForLineCount):

• rendering/RenderElement.cpp:

(WebCore::RenderElement::createFor):
(WebCore::RenderElement::destroyLeftoverChildren):

• rendering/RenderFileUploadControl.cpp:
• rendering/RenderFileUploadControl.h:
• rendering/RenderInline.cpp:

(WebCore::RenderInline::updateFromStyle):
(WebCore::RenderInline::renderName):
(WebCore::RenderInline::clippedOverflowRectForRepaint):

• rendering/RenderListBox.cpp:
• rendering/RenderListBox.h:
• rendering/RenderMenuList.cpp:
• rendering/RenderMenuList.h:
• rendering/RenderObject.cpp:
• rendering/RenderObject.h:
• rendering/RenderProgress.cpp:
• rendering/RenderProgress.h:
• rendering/RenderSlider.cpp:
• rendering/RenderSlider.h:
• rendering/RenderTextControl.cpp:
• rendering/RenderTextControl.h:
• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):

• rendering/style/RenderStyleConstants.h:

Source/WebInspectorUI:

Rubber-stamped by Anders Carlsson.

• UserInterface/CSSKeywordCompletions.js:
• UserInterface/External/CodeMirror/css.js:

LayoutTests:

Rubber-stamped by Anders Carlsson.

• editing/undo/undo-after-event-edited.html:
• fast/css-generated-content/generated-runin-expected.html: Removed.
• fast/css-generated-content/generated-runin.html: Removed.
• fast/lists/parent-box-not-box-crash-expected.txt: Removed.
• fast/lists/parent-box-not-box-crash.html: Removed.
• fast/multicol/span/runin-continuation-crash-expected.txt: Removed.
• fast/multicol/span/runin-continuation-crash.html: Removed.
• fast/runin/001.html: Removed.
• fast/runin/002.html: Removed.
• fast/runin/crash-when-reparent-sibling-expected.txt: Removed.
• fast/runin/crash-when-reparent-sibling.html: Removed.
• fast/runin/generated-content-crash-expected.png: Removed.
• fast/runin/generated-content-crash-expected.txt: Removed.
• fast/runin/generated-content-crash.html: Removed.
• fast/runin/generated.html: Removed.
• fast/runin/generated2.html: Removed.
• fast/runin/generated3.html: Removed.
• fast/runin/generated4.html: Removed.
• fast/runin/input-text-runin-expected.txt: Removed.
• fast/runin/input-text-runin.html: Removed.
• fast/runin/insert-before-run-in-expected.png: Removed.
• fast/runin/insert-before-run-in-expected.txt: Removed.
• fast/runin/insert-before-run-in.html: Removed.
• fast/runin/move-run-in-original-position-crash-expected.png: Removed.
• fast/runin/move-run-in-original-position-crash-expected.txt: Removed.
• fast/runin/move-run-in-original-position-crash.html: Removed.
• fast/runin/nonblock-runin-expected.txt: Removed.
• fast/runin/nonblock-runin.html: Removed.
• fast/runin/progress-run-in-crash-expected.txt: Removed.
• fast/runin/progress-run-in-crash.html: Removed.
• fast/runin/run-in-after-run-in-expected.png: Removed.
• fast/runin/run-in-after-run-in-expected.txt: Removed.
• fast/runin/run-in-after-run-in.html: Removed.
• fast/runin/run-in-layer-not-removed-crash-expected.txt: Removed.
• fast/runin/run-in-layer-not-removed-crash.html: Removed.
• fast/runin/run-in-parent-add-child-expected.png: Removed.
• fast/runin/run-in-parent-add-child-expected.txt: Removed.
• fast/runin/run-in-parent-add-child.html: Removed.
• fast/runin/run-in-parent-block-child-add-and-intrude-expected.png: Removed.
• fast/runin/run-in-parent-block-child-add-and-intrude-expected.txt: Removed.
• fast/runin/run-in-parent-block-child-add-and-intrude.html: Removed.
• fast/runin/run-in-parent-block-child-add-expected.png: Removed.
• fast/runin/run-in-parent-block-child-add-expected.txt: Removed.
• fast/runin/run-in-parent-block-child-add.html: Removed.
• fast/runin/runin-between-list-marker-and-before-content-expected.png: Removed.
• fast/runin/runin-between-list-marker-and-before-content-expected.txt: Removed.
• fast/runin/runin-between-list-marker-and-before-content.html: Removed.
• fast/runin/runin-continuations-crash-expected.txt: Removed.
• fast/runin/runin-continuations-crash.html: Removed.
• fast/runin/runin-div-before-child-expected.png: Removed.
• fast/runin/runin-div-before-child-expected.txt: Removed.
• fast/runin/runin-div-before-child.html: Removed.
• fast/runin/runin-generated-before-content-expected.png: Removed.
• fast/runin/runin-generated-before-content-expected.txt: Removed.
• fast/runin/runin-generated-before-content.html: Removed.
• fast/runin/runin-into-div-with-float-child-expected.png: Removed.
• fast/runin/runin-into-div-with-float-child-expected.txt: Removed.
• fast/runin/runin-into-div-with-float-child.html: Removed.
• fast/runin/runin-not-go-into-float-expected.png: Removed.
• fast/runin/runin-not-go-into-float-expected.txt: Removed.
• fast/runin/runin-not-go-into-float.html: Removed.
• fast/runin/runin-remove-child-simple-expected.txt: Removed.
• fast/runin/runin-remove-child-simple.html: Removed.
• fast/runin/runin-reparent-crash-expected.txt: Removed.
• fast/runin/runin-reparent-crash.html: Removed.
• fast/runin/runin-sibling-inline-expected.txt: Removed.
• fast/runin/runin-sibling-inline.html: Removed.
• fast/runin/runin-table-before-child-expected.png: Removed.
• fast/runin/runin-table-before-child-expected.txt: Removed.
• fast/runin/runin-table-before-child.html: Removed.
• fast/runin/select-runin-expected.txt: Removed.
• fast/runin/select-runin.html: Removed.
• fast/runin/textarea-runin-expected.txt: Removed.
• fast/runin/textarea-runin.html: Removed.
• fast/table/form-with-table-style.html: Removed.
• platform/efl/fast/runin/001-expected.png: Removed.
• platform/efl/fast/runin/001-expected.txt: Removed.
• platform/efl/fast/runin/002-expected.png: Removed.
• platform/efl/fast/runin/002-expected.txt: Removed.
• platform/efl/fast/runin/generated-expected.png: Removed.
• platform/efl/fast/runin/generated-expected.txt: Removed.
• platform/efl/fast/runin/generated2-expected.png: Removed.
• platform/efl/fast/runin/generated2-expected.txt: Removed.
• platform/efl/fast/runin/generated3-expected.png: Removed.
• platform/efl/fast/runin/generated3-expected.txt: Removed.
• platform/efl/fast/runin/generated4-expected.png: Removed.
• platform/efl/fast/runin/generated4-expected.txt: Removed.
• platform/efl/fast/runin/runin-generated-before-content-expected.png: Removed.
• platform/gtk/fast/runin/001-expected.png: Removed.
• platform/gtk/fast/runin/001-expected.txt: Removed.
• platform/gtk/fast/runin/002-expected.png: Removed.
• platform/gtk/fast/runin/002-expected.txt: Removed.
• platform/gtk/fast/runin/generated-content-crash-expected.png: Removed.
• platform/gtk/fast/runin/generated-expected.png: Removed.
• platform/gtk/fast/runin/generated-expected.txt: Removed.
• platform/gtk/fast/runin/generated2-expected.png: Removed.
• platform/gtk/fast/runin/generated2-expected.txt: Removed.
• platform/gtk/fast/runin/generated3-expected.png: Removed.
• platform/gtk/fast/runin/generated3-expected.txt: Removed.
• platform/gtk/fast/runin/generated4-expected.png: Removed.
• platform/gtk/fast/runin/generated4-expected.txt: Removed.
• platform/gtk/fast/runin/insert-before-run-in-expected.png: Removed.
• platform/gtk/fast/runin/move-run-in-original-position-crash-expected.png: Removed.
• platform/gtk/fast/runin/run-in-after-run-in-expected.png: Removed.
• platform/gtk/fast/runin/run-in-parent-add-child-expected.png: Removed.
• platform/gtk/fast/runin/run-in-parent-block-child-add-and-intrude-expected.png: Removed.
• platform/gtk/fast/runin/run-in-parent-block-child-add-expected.png: Removed.
• platform/gtk/fast/runin/runin-between-list-marker-and-before-content-expected.png: Removed.
• platform/gtk/fast/runin/runin-div-before-child-expected.png: Removed.
• platform/gtk/fast/runin/runin-generated-before-content-expected.png: Removed.
• platform/gtk/fast/runin/runin-into-div-with-float-child-expected.png: Removed.
• platform/gtk/fast/runin/runin-not-go-into-float-expected.png: Removed.
• platform/gtk/fast/runin/runin-table-before-child-expected.png: Removed.
• platform/mac/fast/runin/001-expected.png: Removed.
• platform/mac/fast/runin/001-expected.txt: Removed.
• platform/mac/fast/runin/002-expected.png: Removed.
• platform/mac/fast/runin/002-expected.txt: Removed.
• platform/mac/fast/runin/generated-expected.png: Removed.
• platform/mac/fast/runin/generated-expected.txt: Removed.
• platform/mac/fast/runin/generated2-expected.png: Removed.
• platform/mac/fast/runin/generated2-expected.txt: Removed.
• platform/mac/fast/runin/generated3-expected.png: Removed.
• platform/mac/fast/runin/generated3-expected.txt: Removed.
• platform/mac/fast/runin/generated4-expected.png: Removed.
• platform/mac/fast/runin/generated4-expected.txt: Removed.
• platform/win/fast/runin/nonblock-runin-expected.txt: Removed.

1:20 PM Changeset in webkit [163559] by akling@apple.com

• 5 edits in trunk/Source/WebCore

Remove leftover cruft from scoped stylesheet implementation.
<​https://webkit.org/b/128139>

Kill some pointless non-null checks that were left behind by the
removed <style scoped> code. Also pruned outdated comments and
FIXME's about such scopes.

Reviewed by Antti Koivisto.

• css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::collectMatchingRules):

• css/RuleSet.cpp:

(WebCore::RuleSet::addChildRules):
(WebCore::RuleSet::addRulesFromSheet):

• css/RuleSet.h:
• css/StyleResolver.cpp:

(WebCore::StyleResolver::checkRegionStyle):

12:43 PM Changeset in webkit [163558] by Brent Fulgham

• 3 edits in trunk/Source/WebCore

Wheel events don't latch to inner scrollable elements
​https://bugs.webkit.org/show_bug.cgi?id=128225

Reviewed by Beth Dakin.

• page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent): Identify the case
where we have hit the end of a scroll, and treat that as a
valid 'handled' case. If the scroll event is just starting,
treat end-of-scroll as unhandled so the parent element can
handle things.

• page/WheelEventDeltaTracker.h:

(WebCore::WheelEventDeltaTracker::isFirstWheelEvent): Added.

12:38 PM Changeset in webkit [163557] by Brent Fulgham

• 2 edits in trunk/Source/WebKit/win

[Win] Correct IME Regression after r141479
​https://bugs.webkit.org/show_bug.cgi?id=128323
<rdar://problem/15952986>

Reviewed by Tim Horton.

• WebView.cpp:

(WebView::updateSelectionForIME): Refactoring flipped the meaning of the test used
to select the resetIME case. Corrected for behavior of new cancel method.

12:22 PM Changeset in webkit [163556] by commit-queue@webkit.org

• 20 edits
  1 delete in trunk/Source

Unreviewed, rolling out r163542.
​http://trac.webkit.org/changeset/163542
​https://bugs.webkit.org/show_bug.cgi?id=128324

Caused many assertion failures (Requested by ap on #webkit).

Source/JavaScriptCore:

• GNUmakefile.list.am:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
• JavaScriptCore.xcodeproj/project.pbxproj:
• heap/CopyWriteBarrier.h:

(JSC::CopyWriteBarrier::set):

• heap/Heap.cpp:

(JSC::Heap::writeBarrier):

• heap/Heap.h:

(JSC::Heap::writeBarrier):

• jit/JITOperations.cpp:
• jit/JITWriteBarrier.h:

(JSC::JITWriteBarrierBase::set):

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::llint_write_barrier_slow):

• runtime/Arguments.h:
• runtime/JSWeakMap.cpp:
• runtime/MapData.cpp:

(JSC::MapData::ensureSpaceForAppend):

• runtime/PropertyTable.cpp:

(JSC::PropertyTable::PropertyTable):

• runtime/Structure.h:
• runtime/WriteBarrier.h:

(JSC::WriteBarrierBase::set):
(JSC::WriteBarrierBase::setMayBeNull):
(JSC::WriteBarrierBase::setEarlyValue):
(JSC::WriteBarrierBase<Unknown>::set):

• runtime/WriteBarrierInlines.h: Removed.

Source/WebCore:

• bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener):

• bindings/js/JSEventListener.h:

(WebCore::JSEventListener::jsFunction):

12:17 PM Changeset in webkit [163555] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Replace ’ with ' to silence the check-for-webkit-framework-include-consistency script.

• UIProcess/API/Cocoa/WKWebView.h:

12:05 PM Changeset in webkit [163554] by andersca@apple.com

• 4 edits in trunk/Source/WebKit2

Add backForwardList property to WKWebView
​https://bugs.webkit.org/show_bug.cgi?id=128320

Reviewed by Tim Horton.

• UIProcess/API/Cocoa/WKWebView.h:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView backForwardList]):

12:00 PM Changeset in webkit [163553] by commit-queue@webkit.org

• 14 edits
  4 adds in trunk

Do not draw multi-characters <mi> in italic.
​https://bugs.webkit.org/show_bug.cgi?id=44208

Patch by Frédéric Wang <​fred.wang@free.fr> on 2014-02-06
Reviewed by Chris Fleizach.

Source/WebCore:

This test prevents multi-char <mi> to be drawn in italic and prepare
further improvements to MathML token and mfenced elements (bugs 124838
and bug 99620).

Test: mathml/presentation/tokenElements-dynamic.html

• CMakeLists.txt:
• GNUmakefile.list.am:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• css/mathml.css:

(mi, mo, mrow, mfenced, mfrac, msub, msup, msubsup, mmultiscripts, mprescripts, none, munder, mover, munderover, msqrt, mroot, merror, mphantom, mstyle, menclose):

• mathml/MathMLTextElement.cpp:

(WebCore::MathMLTextElement::didAttachRenderers):
(WebCore::MathMLTextElement::childrenChanged):
(WebCore::MathMLTextElement::createElementRenderer):

• rendering/RenderObject.h:

(WebCore::RenderObject::isRenderMathMLToken):

• rendering/mathml/RenderMathMLToken.cpp: Added.

(WebCore::RenderMathMLToken::RenderMathMLToken):
(WebCore::RenderMathMLToken::addChild):
(WebCore::RenderMathMLToken::createWrapperIfNeeded):
(WebCore::RenderMathMLToken::updateTokenContent):
(WebCore::RenderMathMLToken::updateStyle):
(WebCore::RenderMathMLToken::styleDidChange):
(WebCore::RenderMathMLToken::updateFromElement):

• rendering/mathml/RenderMathMLToken.h: Added.

(WebCore::RenderMathMLToken::element):
(WebCore::RenderMathMLToken>):

LayoutTests:

Add tests for single-char/multi-char <mi> elements, the mathvariant
attribute and MathML token elements dynamically modified.

• mathml/presentation/attributes-mathvariant-expected.html:
• mathml/presentation/attributes-mathvariant.html:
• mathml/presentation/tokenElements-dynamic-expected.html: Added.
• mathml/presentation/tokenElements-dynamic.html: Added.
• mathml/presentation/tokenElements-mathvariant-expected.html:
• mathml/presentation/tokenElements-mathvariant.html:

11:34 AM Changeset in webkit [163552] by zoltan@webkit.org

• 2 edits in trunk/Source/WebCore

[CSS Shapes] Simplify BasicShapeInset creation
​https://bugs.webkit.org/show_bug.cgi?id=128314

Reviewed by David Hyatt.

Introduce convertToLengthSize helper function in order to simplify and make BasicShapeInset more readable.

No new tests, no behavior change.

• css/BasicShapeFunctions.cpp:

(WebCore::convertToLengthSize):
(WebCore::basicShapeForValue):

11:26 AM Changeset in webkit [163551] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

The source frame request is not the same thing as the original request
​https://bugs.webkit.org/show_bug.cgi?id=128317

Reviewed by Andreas Kling.

Grab the source frame URL From the WebFrameProxy object.

• UIProcess/Cocoa/NavigationState.mm:

(WebKit::frameInfoFromWebFrameProxy):
(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction):

10:54 AM Changeset in webkit [163550] by andersca@apple.com

• 2 edits in trunk/Source/WebCore

Try to fix the Windows build.

• loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::didReceiveResponse):

10:45 AM Changeset in webkit [163549] by oliver@apple.com

• 5 edits in trunk/Source/JavaScriptCore

Make 32bit pass the correct this value to custom getters
​https://bugs.webkit.org/show_bug.cgi?id=128313

Reviewed by Mark Lam.

Now that the custom getter calling convetion uses a single register
for the slot base we can easily pass the correct |thisValue| instead
of simply relying on the thisValue not be relevant to existing
custom getters. This also means that 32bit can call custom getters
directly.

• jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):

• jit/Repatch.cpp:

(JSC::generateProtoChainAccessStub):
(JSC::tryBuildGetByIDList):

10:20 AM Changeset in webkit [163548] by ap@apple.com

• 2 edits in trunk/LayoutTests

Fix a copy/paste mistake in TestExpectations.

• platform/mac/TestExpectations:

10:13 AM Changeset in webkit [163547] by svillar@igalia.com

• 16 edits
  9 copies
  1 add in trunk

[CSS Grid Layout] getComputedStyle() is wrong for grid-definition-{columns|rows}
​https://bugs.webkit.org/show_bug.cgi?id=127033

Reviewed by Andreas Kling.

Source/WebCore:

Tests: fast/css-grid-layout/non-grid-columns-rows-get-set-multiple.html

fast/css-grid-layout/non-grid-columns-rows-get-set.html
fast/css-grid-layout/non-grid-element-repeat-get-set.html
fast/css-grid-layout/non-named-grid-line-get-set.html

According to the specs getComputedStyle() should return the used
values instead of the resolved values for compatibility with early
implementations. This means that grid-definition-{columns|rows}
are now layout dependent as we need to compute the used values for
grid track sizes.

Updated the outcome of existing tests and added a bunch of new
ones that check the behavior of the different properties outside
grid containers.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::specifiedValueForGridTrackSize):
(WebCore::valueForGridTrackList):
(WebCore::isLayoutDependent):
(WebCore::ComputedStyleExtractor::propertyValue):

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::GridIterator::GridIterator):
(WebCore::RenderGrid::computedUsedBreadthOfGridTracks):
(WebCore::RenderGrid::computeUsedBreadthOfMinLength):
(WebCore::RenderGrid::computeUsedBreadthOfMaxLength):
(WebCore::RenderGrid::computeUsedBreadthOfSpecifiedLength):
(WebCore::RenderGrid::computeNormalizedFractionBreadth):
(WebCore::RenderGrid::gridTrackSize):
(WebCore::RenderGrid::minContentForChild):
(WebCore::RenderGrid::maxContentForChild):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
(WebCore::RenderGrid::tracksAreWiderThanMinTrackBreadth):
(WebCore::RenderGrid::growGrid):
(WebCore::RenderGrid::autoPlacementMajorAxisDirection):
(WebCore::RenderGrid::autoPlacementMinorAxisDirection):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::resolveGridPositionsFromAutoPlacementPosition):
(WebCore::RenderGrid::resolveGridPositionsFromStyle):
(WebCore::RenderGrid::gridAreaBreadthForChild):
(WebCore::RenderGrid::populateGridPositions):
(WebCore::RenderGrid::findChildLogicalPosition):

• rendering/RenderGrid.h:

LayoutTests:

Updated the expected results of many tests, as we should expect
the used values instead of the resolved ones when asking for
getComputedStyle().

• fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
• fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
• fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
• fast/css-grid-layout/grid-columns-rows-get-set.html:
• fast/css-grid-layout/grid-element-repeat-get-set-expected.txt:
• fast/css-grid-layout/grid-element-repeat-get-set.html:
• fast/css-grid-layout/named-grid-line-get-set-expected.txt:
• fast/css-grid-layout/named-grid-line-get-set.html:
• fast/css-grid-layout/non-grid-columns-rows-get-set-expected.txt: Copied from LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt.
• fast/css-grid-layout/non-grid-columns-rows-get-set-multiple-expected.txt: Copied from LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt.
• fast/css-grid-layout/non-grid-columns-rows-get-set-multiple.html: Copied from LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple.html.
• fast/css-grid-layout/non-grid-columns-rows-get-set.html: Copied from LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set.html.
• fast/css-grid-layout/non-grid-element-repeat-get-set-expected.txt: Copied from LayoutTests/fast/css-grid-layout/grid-element-repeat-get-set-expected.txt.
• fast/css-grid-layout/non-grid-element-repeat-get-set.html: Copied from LayoutTests/fast/css-grid-layout/grid-element-repeat-get-set.html.
• fast/css-grid-layout/non-named-grid-line-get-set-expected.txt: Copied from LayoutTests/fast/css-grid-layout/named-grid-line-get-set-expected.txt.
• fast/css-grid-layout/non-named-grid-line-get-set.html: Added.
• fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:

(testInherit):
(testInitial):

• fast/css-grid-layout/resources/grid-columns-rows-get-set.js:

(testInherit):
(testInitial):

• fast/css-grid-layout/resources/grid-definitions-parsing-utils.js:

(testGridDefinitionsValues):
(checkGridDefinitionsSetJSValues):

• fast/css-grid-layout/resources/non-grid-columns-rows-get-set-multiple.js: Copied from LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js.

(testInherit):
(testInitial):

• fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js: Copied from LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js.

(testInherit):
(testInitial):

10:10 AM Changeset in webkit [163546] by Lucas Forschler

• 5 edits in tags/Safari-538.16.2/Source/WebKit2

Merged r163504.

10:08 AM Changeset in webkit [163545] by andersca@apple.com

• 4 edits in trunk/Source/WebCore

Modernize CrossOriginPreflightResultCache
​https://bugs.webkit.org/show_bug.cgi?id=128309

Reviewed by Antti Koivisto.

Use std::chrono::steady_clock instead of currentTime() for determining when
cache items expire, Use std::unique_ptr instead of OwnPtr, use NeverDestroyed,
get rid of unnecessary container typedefs now that we have auto. Finally,
de-indent the entire class declaration.

• loader/CrossOriginPreflightResultCache.cpp:

(WebCore::CrossOriginPreflightResultCache::CrossOriginPreflightResultCache):
(WebCore::parseAccessControlMaxAge):
(WebCore::CrossOriginPreflightResultCacheItem::parse):
(WebCore::CrossOriginPreflightResultCacheItem::allowsRequest):
(WebCore::CrossOriginPreflightResultCache::shared):
(WebCore::CrossOriginPreflightResultCache::appendEntry):
(WebCore::CrossOriginPreflightResultCache::canSkipPreflight):

• loader/CrossOriginPreflightResultCache.h:

(WebCore::CrossOriginPreflightResultCacheItem::CrossOriginPreflightResultCacheItem):

• loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::didReceiveResponse):

10:08 AM Changeset in webkit [163544] by ap@apple.com

• 2 edits in trunk/LayoutTests

editing/caret/caret-color.html is flaky on WK2
​https://bugs.webkit.org/show_bug.cgi?id=128315

• platform/mac-wk2/TestExpectations: Marked it as such.

10:04 AM Changeset in webkit [163543] by commit-queue@webkit.org

• 4 edits
  9 adds in trunk

Menclose with no notation attribute does not display anything.
​https://bugs.webkit.org/show_bug.cgi?id=127889

Patch by Gurpreet Kaur <​k.gurpreet@samsung.com> on 2014-02-06
Reviewed by Chris Fleizach.

Source/WebCore:

Menclose with no notation attribute should behave same as menclose with
notation attribute with value as longdiv. By default the division
symbol should be displayed. For empty and invalid notation attribute
nothing should be displayed.

Tests: mathml/presentation/menclose-notation-default-longdiv.html

mathml/presentation/menclose-notation-invalid-empty.html

• mathml/MathMLMencloseElement.h:
• rendering/mathml/RenderMathMLMenclose.cpp:

(WebCore::RenderMathMLMenclose::computePreferredLogicalWidths):
(WebCore::RenderMathMLMenclose::paint):
Added style for menclose with no notation attribute and handled this
condition in paint also where for longdiv we are explicitly drawing
the division symbol.

LayoutTests:

• mathml/presentation/menclose-notation-default-longdiv.html: Added.
• mathml/presentation/menclose-notation-invalid-empty-expected.html: Added.
• mathml/presentation/menclose-notation-invalid-empty.html: Added.
• platform/efl/mathml/presentation/menclose-notation-default-longdiv-expected.png: Added.
• platform/efl/mathml/presentation/menclose-notation-default-longdiv-expected.txt: Added.
• platform/gtk/mathml/presentation/menclose-notation-default-longdiv-expected.png: Added.
• platform/gtk/mathml/presentation/menclose-notation-default-longdiv-expected.txt: Added.
• platform/mac/mathml/presentation/menclose-notation-default-longdiv-expected.png: Added.
• platform/mac/mathml/presentation/menclose-notation-default-longdiv-expected.txt: Added.

Added new test cases to test the functionality of menclose with no
notation attribute, invalid and empty notation attribute.

9:59 AM Changeset in webkit [163542] by mhahnenberg@apple.com

• 20 edits
  1 add in trunk/Source

Heap::writeBarrier shouldn't be static
​https://bugs.webkit.org/show_bug.cgi?id=127807

Reviewed by Geoffrey Garen.

Currently it looks up the Heap in which to fire the write barrier by using
the cell passed to it. Almost every call site already has a reference to the
VM or the Heap itself. It seems wasteful to look it up all over again.

Source/JavaScriptCore:

• GNUmakefile.list.am:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
• JavaScriptCore.xcodeproj/project.pbxproj:
• heap/CopyWriteBarrier.h:

(JSC::CopyWriteBarrier::set):

• heap/Heap.cpp:

(JSC::Heap::writeBarrier):

• heap/Heap.h:

(JSC::Heap::writeBarrier):

• jit/JITOperations.cpp:
• jit/JITWriteBarrier.h:

(JSC::JITWriteBarrierBase::set):

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::llint_write_barrier_slow):

• runtime/Arguments.h:
• runtime/JSWeakMap.cpp:
• runtime/MapData.cpp:

(JSC::MapData::ensureSpaceForAppend):

• runtime/PropertyTable.cpp:

(JSC::PropertyTable::PropertyTable):

• runtime/Structure.h:
• runtime/WriteBarrier.h:
• runtime/WriteBarrierInlines.h: Added.

Source/WebCore:

• bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener):

• bindings/js/JSEventListener.h:

(WebCore::JSEventListener::jsFunction):

9:55 AM Changeset in webkit [163541] by ap@apple.com

• 2 edits in trunk/LayoutTests

media/video-load-preload-metadata.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=128312

• platform/mac/TestExpectations: Marked it as such.

9:50 AM Changeset in webkit [163540] by Lucas Forschler

• 5 edits in tags/Safari-538.16.2

Merged r163481.

9:49 AM Changeset in webkit [163539] by commit-queue@webkit.org

• 8 edits
  2 copies
  1 delete in trunk/Tools

Unreviewed, rolling out r163530.
​http://trac.webkit.org/changeset/163530
​https://bugs.webkit.org/show_bug.cgi?id=128311

It broke run-gtk-tests (Requested by Ossy on #webkit).

• efl/common.py: Copied from Tools/gtk/jhbuildrc.

(script_path):
(top_level_path):

• efl/jhbuildrc:
• gtk/common.py:

(script_path):
(top_level_path):

• gtk/find-make-dist-errors:

(get_missing_headers):

• gtk/generate-gtkdoc:

(get_webkit2_options):
(get_webkit1_options.src_path):
(get_webkit1_options):
(get_webkitdom_options.src_path):
(get_webkitdom_options):

• gtk/generate-inspector-gresource-manifest.py:
• gtk/jhbuildrc:
• jhbuild/jhbuildrc_common.py: Removed.
• nix/common.py: Copied from Tools/nix/jhbuildrc.

(script_path):
(top_level_path):

• nix/jhbuildrc:

9:42 AM Changeset in webkit [163538] by beidson@apple.com

• 14 edits in trunk

IDB: storage/indexeddb/mozilla/clear.html fails
<rdar://problem/15997155> and ​https://bugs.webkit.org/show_bug.cgi?id=128282

Reviewed by David Kilzer.

Source/WebCore:

Covered by storage/indexeddb/mozilla/clear.html (and probably others)

Update the value deserializer to take into account whether or not there was an IDBKey:

• bindings/js/IDBBindingUtilities.cpp:

(WebCore::deserializeIDBValueBuffer):

• bindings/js/IDBBindingUtilities.h:

• Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess): Call the new form of deserializeIDBValueBuffer.

• Modules/indexeddb/IDBDatabaseBackend.cpp:

(WebCore::IDBDatabaseBackend::clearObjectStore): Update logging.

• Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::setActive): Update logging.

• Modules/indexeddb/IDBTransactionBackend.cpp:

(WebCore::IDBTransactionBackend::commit): Fix ASSERTs to reflect multi-process worlds.

Source/WebKit2:

• DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

(WebKit::DatabaseProcessIDBConnection::openTransaction): Update logging.

• DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.cpp:

(WebKit::SQLiteIDBTransaction::commit): Update ASSERT.

LayoutTests:

• platform/mac-wk2/TestExpectations: Enable this test.

Update the test for (what I can only assume are) changes in the spec:

• storage/indexeddb/mozilla/clear-expected.txt:
• storage/indexeddb/mozilla/resources/clear.js:

(areWeClearYet):

9:29 AM Changeset in webkit [163537] by Csaba Osztrogonác

• 2 edits in trunk/Source/WebCore

Re-enable simple line layout on non-Mac platforms
​https://bugs.webkit.org/show_bug.cgi?id=123338

Reviewed by Anders Carlsson.

• rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

9:03 AM Changeset in webkit [163536] by andersca@apple.com

• 2 edits in trunk/Source/WTF

Use std::chrono functions in dispatchFunctionsFromMainThread()
​https://bugs.webkit.org/show_bug.cgi?id=128308

Reviewed by Antti Koivisto.

• wtf/MainThread.cpp:

(WTF::dispatchFunctionsFromMainThread):

8:50 AM Changeset in webkit [163535] by Michał Pakuła vel Rutka

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening

Add test expectations for tests crashing after r162816.

• platform/efl-wk2/TestExpectations:

8:45 AM Changeset in webkit [163534] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Use system default compiler instead of gcc, as final fall through.
​https://bugs.webkit.org/show_bug.cgi?id=126773

Patch by Koop Mast <​kwm@FreeBSD.org> on 2014-02-06
Reviewed by Alexey Proskuryakov.

• dom/make_names.pl:

8:29 AM Changeset in webkit [163533] by eric.carlson@apple.com

• 2 edits in trunk/Source/WebCore

No need to enterFullscreen() when already in fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=128276

Reviewed by Jer Noble.

No new tests, this is just cleanup.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updatePlayState): Don't call enterFullscreen() if already there.
(WebCore::HTMLMediaElement::enterFullscreen): Return early if m_isFullscreen is already true.

7:24 AM Changeset in webkit [163532] by d.nomiyama@samsung.com

• 2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

• Scripts/webkitpy/common/config/contributors.json:

6:42 AM Changeset in webkit [163531] by stavila@adobe.com

• 4 edits
  2 adds in trunk

[CSS Regions] Null dereference applying animation with CSS regions
​https://bugs.webkit.org/show_bug.cgi?id=128218

Reviewed by Andrei Bucur.

Source/WebCore:

The first issue (the null dereference) was caused by the checkForZoomChange method
not guarding against a null parentStyle parameter, as the checkForGenericFamilyChange
method does, which in the crashing scenario is called just before the faulty
checkForZoomChange method.
The second issue was an assert which was caused by the fact that detaching is performed
in a certain situation if the element has a renderer or if it's inside a named flow.
However, when reattaching and asserting the element has no renderer, the
"inside named flow" condition was no longer considered.

Test: fast/regions/animation-element-in-region-flowed-to-other-thread.html

• css/StyleResolver.cpp:

(WebCore::StyleResolver::checkForZoomChange):

• style/StyleResolveTree.cpp:

(WebCore::Style::attachChildren):

LayoutTests:

Added test for crash caused by using animations with DOM children of regions flowed
into another flow thread.

• fast/regions/animation-element-in-region-flowed-to-other-thread-expected.html: Added.
• fast/regions/animation-element-in-region-flowed-to-other-thread.html: Added.

5:41 AM Changeset in webkit [163530] by commit-queue@webkit.org

• 8 edits
  1 add
  2 deletes in trunk/Tools

Extract common parts from jhbuildrc files.
​https://bugs.webkit.org/show_bug.cgi?id=125986

Patch by Peter Szanka <​h868064@stud.u-szeged.hu> on 2014-02-06
Reviewed by Csaba Osztrogonác.

• efl/common.py: Removed.
• efl/jhbuildrc:
• gtk/common.py:

(binary_build_path):

• gtk/find-make-dist-errors:

(get_missing_headers):

• gtk/generate-gtkdoc:

(get_webkit2_options):
(get_webkit1_options.src_path):
(get_webkit1_options):
(get_webkitdom_options.src_path):
(get_webkitdom_options):

• gtk/generate-inspector-gresource-manifest.py:
• gtk/jhbuildrc:
• jhbuild/jhbuildrc_common.py: Added.

(script_path):
(top_level_path):
(init):

• nix/common.py: Removed.
• nix/jhbuildrc:

2:50 AM Changeset in webkit [163529] by g.czajkowski@samsung.com

• 6 edits in trunk/LayoutTests

Verify copy/paste of misspellings asynchronously
​https://bugs.webkit.org/show_bug.cgi?id=128246

Reviewed by Ryosuke Niwa.

Refactoring two spelling tests that use copy/paste to be able to
verify spelling markers asynchronously.
Additionally, use evalAndLog() to make test expectation more readable.
Fix the description according to the tests.

Start off verifying whether spelling marker is available when continuous spell
checking (spellcheck attribute, respectively) is on.
Without this test case, the tests passed even spellchecking
or copy/paste were not implemented (EFL).

• editing/spelling/spellcheck-paste-continuous-disabled-expected.txt:
• editing/spelling/spellcheck-paste-continuous-disabled.html:

Remove unnecessary spellcheck=true attribute. It's default value and we
do not manipulate it at all.
Add destination element where paste operation is performed.

• editing/spelling/spellcheck-paste-disabled-expected.txt:
• editing/spelling/spellcheck-paste-disabled.html:

• platform/efl/TestExpectations:

Mark spellcheck-paste-continuous-disabled.html as failing since EFL does not
implement copy/paste feature.

2:05 AM Changeset in webkit [163528] by commit-queue@webkit.org

• 5 edits in trunk

Create a HTMLUnknownElement when using createElement('image')
​https://bugs.webkit.org/show_bug.cgi?id=125896

Patch by László Langó <​llango.u-szeged@partner.samsung.com> on 2014-02-06
Reviewed by Antti Koivisto.

Source/WebCore:

Backported from Blink: ​https://chromium.googlesource.com/chromium/blink/+/fd8a7b65f3300fb9245db24d5ed240c80b7f76ad

• html/HTMLTagNames.in:

LayoutTests:

• fast/dom/wrapper-classes-expected.txt:
• fast/dom/wrapper-classes.html:

1:42 AM Changeset in webkit [163527] by commit-queue@webkit.org

• 6 edits
  6 adds in trunk

[XHR] Ensure response return null when error flag is set for blob and arraybuffer
​https://bugs.webkit.org/show_bug.cgi?id=127050

Patch by Youenn Fablet <​youennf@gmail.com> on 2014-02-06
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Added a check in JSXMLHttpRequest::response to ensure response return null when error flag is set for blob and arraybuffer
This check also applies to document and json response types (no change in behavior for those types but code path change)
Added assertions in the related XMLHttpRequest blob and array buffer getters
Minor code clean-up.
The test cases check all four response types in case of timeout and abort

Tests: http/tests/xmlhttprequest/onabort-response-getters.html

http/tests/xmlhttprequest/ontimeout-response-getters.html

• bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::response):

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::didCacheResponseJSON):
(WebCore::XMLHttpRequest::responseXML):
(WebCore::XMLHttpRequest::responseBlob):
(WebCore::XMLHttpRequest::responseArrayBuffer):

LayoutTests:

Added test cases that check XHR response in case of timeout and abort for arraybuffer, blob, document and json.

• fast/files/script-tests/xhr-response-blob.js: updated to expect null for blob response in case of XHR requesting a file that does not exist

(.xhr.onreadystatechange):
(.xhr.onerror):
(.xhr.onload):
(.xhr.onloadend):
(testBlob):

• fast/files/xhr-response-blob-expected.txt:
• http/tests/resources/load-then-wait.cgi: Added (similar to load-and-stall except that it sends the whole document and then wait for some time before completing the response).
• http/tests/xmlhttprequest/onabort-response-getters-expected.txt: Added.
• http/tests/xmlhttprequest/onabort-response-getters.html: Added.
• http/tests/xmlhttprequest/ontimeout-response-getters-expected.txt: Added.
• http/tests/xmlhttprequest/ontimeout-response-getters.html: Added.

1:01 AM Changeset in webkit [163526] by Csaba Osztrogonác

• 2 edits in trunk/Source/WebKit2

Fix the build after r163516 for !ENABLE(ASYNC_SCROLLING) platforms
​https://bugs.webkit.org/show_bug.cgi?id=128299

Reviewed by Antti Koivisto.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleTouchEvent):

12:38 AM Changeset in webkit [163525] by Csaba Osztrogonác

• 2 edits in trunk/Tools

Unreviewed fix after r163520, remove Andrei from committers list, because
he is reviewer now, and webkit-patch doesn't like duplicated entries.

• Scripts/webkitpy/common/config/contributors.json:

12:23 AM Changeset in webkit [163524] by barraclough@apple.com

• 11 edits in trunk/Source

Change Page, FocusController to use ViewState
​https://bugs.webkit.org/show_bug.cgi?id=126533

Reviewed by Tim Horton.

These classes currently maintain a set of separate fields to represent the view state;
combine these into a single field, and allow WebPage to send the combined update rather
than individual changes.

Maintain existing interface for WebKit1 clients.

Source/WebCore:

• WebCore.exp.in:
  • Added WebCore::setViewState, removed WebCore::setIsVisuallyIdle.
• page/FocusController.cpp:

(WebCore::FocusController::FocusController):

• Initialize combined m_viewState.

(WebCore::FocusController::setFocused):

• Calls setViewState.

(WebCore::FocusController::setFocusedInternal):

• setFocused -> setFocusedInternal.

(WebCore::FocusController::setViewState):

• Added, update all ViewState flags.

(WebCore::FocusController::setActive):

• Calls setViewState.

(WebCore::FocusController::setActiveInternal):

• setActive -> setActiveInternal.

(WebCore::FocusController::setContentIsVisible):

• Calls setViewState.

(WebCore::FocusController::setContentIsVisibleInternal):

• setContentIsVisible -> setContentIsVisibleInternal.

• page/FocusController.h:

(WebCore::FocusController::isActive):
(WebCore::FocusController::isFocused):
(WebCore::FocusController::contentIsVisible):

• Implemented in terms of ViewState.

• page/Page.cpp:

(WebCore::Page::Page):

• Initialize using PageInitialViewState.

(WebCore::Page::setIsInWindow):

• Calls setViewState.

(WebCore::Page::setIsInWindowInternal):

• setIsInWindow -> setIsInWindowInternal.

(WebCore::Page::setIsVisuallyIdleInternal):

• setIsVisuallyIdle -> setIsVisuallyIdleInternal.

(WebCore::Page::setViewState):

• Added, update all ViewState flags, including FocusController.

(WebCore::Page::setIsVisible):

• Calls setViewState.

(WebCore::Page::setIsVisibleInternal):

• setIsVisible -> setIsVisibleInternal.

(WebCore::Page::visibilityState):

• m_isVisible -> isVisible()

(WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged):

• m_isVisible -> isVisible()

• page/Page.h:

(WebCore::Page::isVisible):
(WebCore::Page::isInWindow):

• Implemented in terms of ViewState.

(WebCore::Page::scriptedAnimationsSuspended):

• Combined member fields into ViewState::Flags.

Source/WebKit/mac:

• WebView/WebView.mm:

(-[WebView _windowWillOrderOnScreen:]):
(-[WebView _windowWillOrderOffScreen:]):

• remove calls to FocusController::setContentIsVisible, these are redundant (this is handled when page visibility is set).

Source/WebKit2:

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

• Combined separate calls to Page::setViewState.

(WebKit::WebPage::updateIsInWindow):

• Simplied from setIsInWindow.

(WebKit::WebPage::setViewState):

• Combined separate calls to Page::setViewState.

• WebProcess/WebPage/WebPage.h:
  • Declare updateIsInWindow.

12:03 AM Changeset in webkit [163523] by bshafiei@apple.com

• 5 edits in trunk/Source

Versioning.

12:00 AM Changeset in webkit [163522] by bshafiei@apple.com

• 1 copy in tags/Safari-538.17

New tag.