Timeline

Feb 8, 2014:

11:29 PM Changeset in webkit [163743] by akling@apple.com

• 2 edits in trunk/Tools

Let Instruments time profiler run until tests finish.
<​https://webkit.org/b/128488>

Pass "-T 0" to iprofiler to ensure that we get a time profile of the
entire performance test run instead of just the first 10 seconds.

Reviewed by Brady Eidson.

• Scripts/webkitpy/common/system/profiler.py:

(IProfiler.attach_to_pid):

10:08 PM Changeset in webkit [163742] by beidson@apple.com

• 4 edits in trunk

IDB: storage/indexeddb/mozilla/object-cursors.html fails
<rdar://problem/16020585> and ​https://bugs.webkit.org/show_bug.cgi?id=128479

Reviewed by Dan Bernstein.

Source/WebKit2:

• DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createAndPopulateInitialMetadata): Update the IndexInfo

table schema to allow for indexes with the same id/name as previous indexes.
But with different object stores, of course.

LayoutTests:

• platform/mac-wk2/TestExpectations: Enable the test.

10:07 PM Changeset in webkit [163741] by beidson@apple.com

• 5 edits in trunk

IDB: storage/indexeddb/mozilla/index-prev-no-duplicate.html fails
<rdar://problem/16018918> and ​https://bugs.webkit.org/show_bug.cgi?id=128444

Reviewed by Dan Bernstein.

Source/WebKit2:

• DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:

(WebKit::getIndexStatement): Return different statements for unique cursors that will

sort the values in reverse of the cursor direction, matching expected IndexedDB behavior.

(WebKit::SQLiteIDBCursor::establishStatement):

• DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::uncheckedPutIndexRecord): Insert the values as

strings since we need the collation function to be called for proper sorting.

LayoutTests:

• platform/mac-wk2/TestExpectations: Enable the test.

9:48 PM Changeset in webkit [163740] by rniwa@webkit.org

• 2 edits in trunk/Source/WebKit/ios

Build fix after r163739.

• WebCoreSupport/WebFrameIOS.mm:

(-[WebFrame collapseSelection]):
(-[WebFrame aggressivelyExpandSelectionToWordContainingCaretSelection]):

8:58 PM Changeset in webkit [163739] by rniwa@webkit.org

• 21 edits in trunk/Source

Cleanup the interface of FrameSelection
​https://bugs.webkit.org/show_bug.cgi?id=128481

Reviewed by Andreas Kling.

Source/WebCore:

Removed FrameSelection::end() as intended in r163232, and the stale declaration of
paintDragCaret() which was supposed to be removed when we extracted DragCaretController.

Renamed caretRenderer() to caretRendererWithoutUpdatingLayout() to clarify the contract
as the only caller of this function is RenderBlock::paintCaret. Also renamed bounds()
to selectionBounds() to make it more easily identifiable / grep'able.

In addition, made recomputeCaretRect() and invalidateCaretRect() private.

• WebCore.exp.in:
• editing/FrameSelection.cpp:

(WebCore::FrameSelection::caretRendererWithoutUpdatingLayout):
(WebCore::FrameSelection::selectionBounds):
(WebCore::FrameSelection::revealSelection):

• editing/FrameSelection.h:

(WebCore::FrameSelection::setCaretVisible):

• page/DragController.cpp:

(WebCore::dragLocForSelectionDrag):

• page/FrameSnapshotting.cpp:

(WebCore::snapshotSelection):

• page/win/FrameWin.cpp:

(WebCore::imageFromSelection):

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintCaret):

• testing/Internals.cpp:

(WebCore::Internals::selectionBounds):

Source/WebKit/efl:

• WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::selectionRectangle):

Source/WebKit/gtk:

• WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::rectangleForSelection):

Source/WebKit/mac:

• WebView/WebHTMLView.mm:

(-[WebHTMLView _lookUpInDictionaryFromMenu:]):
(-[WebHTMLView selectionRect]):
(-[WebHTMLView selectionImageRect]):

Source/WebKit/win:

• WebView.cpp:

(WebView::selectionRect):

Source/WebKit2:

• WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::getFindIndicatorBitmapAndRect):
(WebKit::FindController::drawRect):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::scaledSnapshotWithOptions):

8:31 PM Changeset in webkit [163738] by mitz@apple.com

• 2 edits in trunk/Source/WebCore

Reverted part of r163734, because the assertion it enabled still fails when running
loader/load-defer-resume-crash.html

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::dataReceived):

7:51 PM Changeset in webkit [163737] by andersca@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Simplify single character substrings in JSC
​https://bugs.webkit.org/show_bug.cgi?id=128483

Reviewed by Andreas Kling.

With the recent work to make StringImpl occupy less space, it is actually more
efficient to allocate a single character string that it is to use createSubstringSharingImpl!

• runtime/JSString.h:

(JSC::jsSingleCharacterString):
(JSC::jsSingleCharacterSubstring):
(JSC::jsString):
(JSC::jsSubstring8):

• runtime/SmallStrings.cpp:

(JSC::SmallStringsStorage::SmallStringsStorage):
(JSC::SmallStrings::SmallStrings):

7:36 PM Changeset in webkit [163736] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

EFL build fix after r163729.

• Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::version):

6:56 PM Changeset in webkit [163735] by BJ Burg

• 11 edits
  8 adds in trunk/Source/WebInspectorUI

Web Inspector: show probe sets for script content views in the details sidebar
​https://bugs.webkit.org/show_bug.cgi?id=128333

Reviewed by Timothy Hatcher.

This patch adds a new details sidebar for showing the probes associated with any
breakpoint in the currently visible source file. Each probe set (corresponding to
multiple actions of single breakpoint) gets its own ProbeSetDetailsSection. The
section contains a custom DataGrid subclass to display probe data, and some icons
for clearing samples, deleting the probe, and adding a new probe expression.

The table containing probe data keeps its columns in sync with the probe set's
probe expressions. To support this, DataGrid has been further refactored to support
removing columns, and inserting columns (rather than only appending). With this
capability, probe columns are removed and re-inserted when the expression changes.

The availability of the probe details sidebar is controlled by providing the
probe sets matching the script content view's resource URL as supplemental
represented objects.

Lastly, added the utility EventListenerSet class. This holds a set of event listeners
that should be added and removed together, and takes care of binding thisObject
according to whether the event emitter is a Node or WebInspector.Object.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/BreakpointActionView.js:

(WebInspector.BreakpointActionView):
(WebInspector.BreakpointActionView.prototype._removeAction): Renamed from removeButtonClicked.
(WebInspector.BreakpointActionView.prototype._codeMirrorBlurred): Change the behavior
of CodeMirror-backed editors for probe and evaluate expression actions. If the expression
consists entirely of trimmable whitespace, then delete the action rather than saving it.

• UserInterface/DataGrid.js:

(WebInspector.DataGrid): Copy over the column data into a map inside insertColumn() instead.
(WebInspector.DataGrid.prototype.insertColumn): Renamed from addColumn. It now takes an
optional insertionIndex argument and splices the column before the element at that index.
Also, convert code to use EventListenerSet for adding/removing per-column event listeners.

(WebInspector.DataGrid.prototype.removeColumn): Added. It splices the column out.
(WebInspector.DataGridNode.prototype.isEventWithinDisclosureTriangle): Whitespace.

• UserInterface/EventListenerSet.js: Added.

(WebInspector.EventListenerSet):
(WebInspector.EventListenerSet.prototype.register):
(WebInspector.EventListenerSet.prototype.unregister):
(WebInspector.EventListenerSet.prototype.install):
(WebInspector.EventListenerSet.prototype.uninstall):

• UserInterface/Images/NavigationItemProbes.pdf: Added.
• UserInterface/LayerTreeDataGrid.js:

(WebInspector.LayerTreeDataGrid.prototype._updateChildren): Fix a missing column.get().

• UserInterface/Main.html: Add new JavaScript and CSS files.
• UserInterface/Main.js:

(WebInspector.contentLoaded): Add the probe details sidebar.

• UserInterface/ProbeDetailsSidebarPanel.css: Added.

(.sidebar > .panel.probes > .navigation-bar):
(.sidebar > .panel.probes > .content):
(.details-section.probe-set .options > .probe-add):
(.details-section.probe-set .options > .probe-clear-samples):
(.details-section.probe-set .options > .probe-remove):
(.details-section.probe-set .options > input):
(.panel.probes ::-webkit-scrollbar):
(.panel.probes ::-webkit-scrollbar-track):
(.panel.probes ::-webkit-scrollbar-thumb):
(.panel.probes ::-webkit-scrollbar-corner):
(.popover .probe-popover):
(.popover .probe-popover input):

• UserInterface/ProbeDetailsSidebarPanel.js: Added.

(WebInspector.ProbeDetailsSidebarPanel):
(WebInspector.ProbeDetailsSidebarPanel.prototype.get inspectedProbeSets):
(WebInspector.ProbeDetailsSidebarPanel.prototype._probeSetAdded):

• UserInterface/ProbeManager.js: Remove unused probeSetForBreakpoint function.
• UserInterface/ProbeSet.js: Fix erroneous uses of probe.identifier instead of probe.id.

(WebInspector.ProbeSet.prototype.removeProbe):
(WebInspector.ProbeSet.prototype._sampleCollected):

• UserInterface/ProbeSetDataGrid.css: Added.

(.details-section.probe-set .data-grid .data-container tr.past-value td):
(.details-section.probe-set .data-grid > .data-container td.unknown-value):
(.details-section.probe-set .data-grid .data-container tr.revealed.highlighted):
(@-webkit-keyframes blink-frame-highlight):
(100%):
(.details-section.probe-set .data-grid .data-container tr.separator):
(.details-section.probe-set .data-grid > .data-container tr.data-updated):
(@-webkit-keyframes blink-probe-frame):
(.details-section.probe-set .data-grid .data-container .selected .section *):
(.details-section.probe-set .data-grid .data-container .selected td.unknown-value):
(.details-section.probe-set .data-grid .data-container .section):
(.details-section.probe-set .data-grid th):
(.details-section.probe-set .data-grid th:not(:last-child)):
(.details-section.probe-set .data-grid td):

• UserInterface/ProbeSetDataGrid.js: Added.

(WebInspector.ProbeSetDataGrid):
(WebInspector.ProbeSetDataGrid.prototype.closed):
(WebInspector.ProbeSetDataGrid.prototype._setupProbe):
(WebInspector.ProbeSetDataGrid.prototype._teardownProbe):
(WebInspector.ProbeSetDataGrid.prototype._setupData):
(WebInspector.ProbeSetDataGrid.prototype._teardownData):
(WebInspector.ProbeSetDataGrid.prototype._updateNodeForFrame.else.sortFunction):
(WebInspector.ProbeSetDataGrid.prototype._updateNodeForFrame.else.set node):
(WebInspector.ProbeSetDataGrid.prototype._dataFrameInserted):
(WebInspector.ProbeSetDataGrid.prototype._dataSeparatorInserted):
(WebInspector.ProbeSetDataGrid.prototype._probeExpressionChanged.get var):

• UserInterface/ProbeSetDataGridNode.js: Added.

(WebInspector.ProbeSetDataGridNode):
(WebInspector.ProbeSetDataGridNode.prototype.get element):
(WebInspector.ProbeSetDataGridNode.prototype.get data):
(WebInspector.ProbeSetDataGridNode.prototype.set frame):
(WebInspector.ProbeSetDataGridNode.prototype.get frame):
(WebInspector.ProbeSetDataGridNode.prototype.createCellContent):
(WebInspector.ProbeSetDataGridNode.prototype.updateCellsFromFrame):
(WebInspector.ProbeSetDataGridNode.prototype.updateCellsForSeparator):

• UserInterface/ProbeSetDataTable.js:

(WebInspector.ProbeSetDataTable.prototype.removeProbe): Fix a typo in for..of loop refactor.

• UserInterface/ProbeSetDetailsSection.js: Added.

(WebInspector.ProbeSetDetailsSection):
(WebInspector.ProbeSetDetailsSection.prototype.closed):
(WebInspector.ProbeSetDetailsSection.prototype._probeSetPositionTextOrLink):
(WebInspector.ProbeSetDetailsSection.prototype._addProbeButtonClicked):
(WebInspector.ProbeSetDetailsSection.prototype._removeButtonClicked):
(WebInspector.ProbeSetDetailsSection.prototype._clearSamplesButtonClicked):

• UserInterface/TextResourceContentView.js:

(WebInspector.TextResourceContentView):
(WebInspector.TextResourceContentView.prototype.get supplementalRepresentedObjects):
Add probe sets whose breakpoint matches the represented object's URL.
(WebInspector.TextResourceContentView.prototype._probeSetsChanged): Tell listeners
to re-fetch supplementalRepresentedObjects when probe sets are added or removed.

6:37 PM Changeset in webkit [163734] by mitz@apple.com

• 2 edits in trunk/Source/WebCore

Remove outdated workarounds in DocumentLoader::dataReceived
​https://bugs.webkit.org/show_bug.cgi?id=128465

Reviewed by Andreas Kling.

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::dataReceived):

5:43 PM Changeset in webkit [163733] by mhahnenberg@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Baseline JIT uses the wrong version of checkMarkWord in emitWriteBarrier
​https://bugs.webkit.org/show_bug.cgi?id=128474

Reviewed by Michael Saboff.

• jit/JITPropertyAccess.cpp:

(JSC::JIT::emitWriteBarrier):

5:21 PM Changeset in webkit [163732] by ap@apple.com

• 4 edits in trunk/Source/WebCore

Remove some unused functions from SerializedScriptValue
​https://bugs.webkit.org/show_bug.cgi?id=128407

Reviewed by Oliver Hunt.

Removed more unused code, particularly in API helpers. Renamed one serialize()
function to create(), because it does the same thing as other create() functions.

• Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::put):

• bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):

• bindings/js/SerializedScriptValue.h:

5:13 PM Changeset in webkit [163731] by mitz@apple.com

• 3 edits in trunk/Source/WebKit/mac

Remove use of PLATFORM(MAC) from WebKit/mac
​https://bugs.webkit.org/show_bug.cgi?id=128476

Reviewed by Anders Carlsson.

• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

4:46 PM Changeset in webkit [163730] by mark.lam@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Rename a field and some variables in JSLock to better describe what they contain.
<​https://webkit.org/b/128475>

Reviewed by Oliver Hunt.

• runtime/JSLock.cpp:

(JSC::JSLock::dropAllLocks):
(JSC::JSLock::dropAllLocksUnconditionally):
(JSC::JSLock::grabAllLocks):
(JSC::JSLock::DropAllLocks::DropAllLocks):
(JSC::JSLock::DropAllLocks::~DropAllLocks):

• runtime/JSLock.h:

4:01 PM Changeset in webkit [163729] by beidson@apple.com

• 4 edits in trunk

IDB: storage/indexeddb/mozilla/versionchange-abort.html fails
<rdar://problem/16018887> and ​https://bugs.webkit.org/show_bug.cgi?id=128442

Reviewed by Dan Bernstein.

Source/WebCore:

Tested by storage/indexeddb/mozilla/versionchange-abort.html (and probably others)

• Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::version): If the version is NoIntVersion, return DefaultIntVersion to script.

LayoutTests:

• platform/mac-wk2/TestExpectations: Enable the test. Also add all the other storage/indexeddb/mozilla test with expectations as they are what I’m focusing on right now.

4:00 PM Changeset in webkit [163728] by beidson@apple.com

• 8 edits in trunk

IDB: storage/indexeddb/mozilla/cursors.html fails
<rdar://problem/16017998> and ​https://bugs.webkit.org/show_bug.cgi?id=128423

Reviewed by Dan Bernstein.

Source/WebCore:

Tested by storage/indexeddb/mozilla/cursors.html (And probably others)

• Modules/indexeddb/IDBTransactionBackendOperations.cpp:

(WebCore::OpenCursorOperation::perform): Distinguish between an error while opening the cursor

and opening a cursor that points to no records.

Source/WebKit2:

• DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:

(WebKit::SQLiteIDBCursor::internalAdvanceOnce): Store the primary key for object store cursors.
(WebKit::SQLiteIDBCursor::iterate): We’re not supposed to check for equality to the target key.

Depending on the direction of the cursor we should check for the next highest or next lowest key.

LayoutTests:

• platform/mac-wk2/TestExpectations: Unskip storage/indexeddb/mozilla/cursors.html.

Revert the change to storage/indexeddb/mozilla/clear.html as it is now clear how a
null cursor might be returned from openCursor:

• storage/indexeddb/mozilla/clear-expected.txt:
• storage/indexeddb/mozilla/resources/clear.js:

3:31 PM Changeset in webkit [163727] by andersca@apple.com

• 5 edits in trunk/Source

Stop using getCharactersWithUpconvert in JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=128457

Reviewed by Andreas Kling.

Source/JavaScriptCore:

Change substituteBackreferencesSlow to take StringViews and use a StringBuilder instead of upconverting
if the source or replacement strings area 16-bit.

• runtime/StringPrototype.cpp:

(JSC::substituteBackreferencesSlow):
(JSC::substituteBackreferences):

Source/WTF:

• wtf/text/StringBuilder.h:

(WTF::StringBuilder::append):
Add a new overload that takes a StringView.

• wtf/text/StringView.h:

(WTF::StringView::find):
Add new find member function.

2:29 PM Changeset in webkit [163726] by akling@apple.com

• 5 edits in trunk/Source/WebCore

Remove unused ChromeClient::layoutUpdated().
<​https://webkit.org/b/128470>

Nobody listens for this callback anymore so remove it.

Reviewed by Anders Carlsson.

• page/Chrome.cpp:
• page/Chrome.h:
• page/ChromeClient.h:
• page/FrameView.cpp:

(WebCore::FrameView::layout):

2:26 PM Changeset in webkit [163725] by mitz@apple.com

• 71 edits in trunk/Source/WebCore

Stop using PLATFORM(MAC) in WebCore except where it means “OS X but not iOS”
​https://bugs.webkit.org/show_bug.cgi?id=128464

Reviewed by Anders Carlsson.

• Modules/webaudio/AudioContext.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).

(WebCore::AudioContext::constructCommon):

• accessibility/AccessibilityNodeObject.cpp: Ditto.

(WebCore::AccessibilityNodeObject::visibleText):

• accessibility/AccessibilityObject.h: Ditto.
• accessibility/AccessibilityRenderObject.cpp: Ditto.

(WebCore::AccessibilityRenderObject::clickPoint):
(WebCore::AccessibilityRenderObject::visiblePositionForPoint):
(WebCore::AccessibilityRenderObject::addChildren):

• accessibility/AccessibilityRenderObject.h: Ditto.
• bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::JSInspectorFrontendHost::platform): Made it explicit that this function returns
"mac" when built for iOS.

• bindings/js/ScriptController.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).

(WebCore::ScriptController::ScriptController):

• bindings/js/ScriptController.h: Ditto.
• crypto/CryptoKey.cpp: Changed PLATFORM(MAC) to OS(DARWIN) && !PLATFORM(EFL) &&

!PLATFORM(GTK) when checking for whether to use CoreCrypto.

• crypto/keys/CryptoKeyRSA.h: Ditto.
• dom/Clipboard.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
• dom/Document.cpp: Ditto.

(WebCore::Document::implicitClose):

• dom/KeyboardEvent.h: Ditto.
• editing/Editor.cpp: Ditto.

(WebCore::Editor::cut):
(WebCore::Editor::copy):
(WebCore::Editor::copyImage):

• editing/Editor.h: Ditto.
• editing/FrameSelection.h: Ditto.
• editing/TypingCommand.cpp: Ditto.

(WebCore::TypingCommand::typingAddedToOpenCommand):

• history/HistoryItem.h: Ditto.
• html/HTMLMediaElement.cpp: Ditto.

(WebCore::HTMLMediaElement::parseAttribute):

• html/HTMLMediaElement.h: Ditto.
• html/HTMLPlugInElement.cpp: Ditto.

(WebCore::registeredPluginReplacements):

• html/HTMLPlugInImageElement.cpp: Ditto.

(WebCore::HTMLPlugInImageElement::setDisplayState):

• html/HTMLSelectElement.cpp: Ditto.

(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):

• html/shadow/MediaControlElements.cpp: Ditto.

(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):

• html/shadow/MediaControlElements.h: Ditto.
• inspector/InspectorIndexedDBAgent.cpp: Ditto.
• loader/CookieJar.cpp: Ditto.
• loader/DocumentLoader.cpp: Ditto.

(WebCore::DocumentLoader::dataReceived):

• loader/DocumentLoader.h: Ditto.

(WebCore::DocumentLoader::didTellClientAboutLoad):

• loader/EmptyClients.h: Ditto.
• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadArchive): Added !PLATFORM(IOS) around Mac-only workaround.
(WebCore::FrameLoader::defaultObjectContentType): Changed PLATFORM(MAC) to PLATFORM(COCOA).
(WebCore::FrameLoader::subresourceCachePolicy): Ditto.

• loader/ResourceBuffer.h: Changed PLATFORM(MAC) to USE(FOUNDATION) around functions that

are implemented using Foundation.

• loader/ResourceLoadScheduler.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).

(WebCore::ResourceLoadScheduler::scheduleLoad):

• loader/ResourceLoader.cpp: Ditto.

(WebCore::ResourceLoader::didReceiveAuthenticationChallenge):

• loader/ResourceLoader.h: Ditto.
• loader/archive/cf/LegacyWebArchive.cpp: Ditto.
• loader/cache/CachedResource.cpp: Changed PLATFORM(MAC) to USE(FOUNDATION) around function

that is implemented using other USE(FOUNDATION)-guarded code.

• loader/cache/CachedResource.h: Ditto.
• page/Chrome.h: Changed PLATFORM(MAC) to PLATFORM(COCOA).
• page/ChromeClient.h: Ditto.
• page/ContextMenuClient.h: Ditto.
• page/ContextMenuController.cpp: Ditto.

(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::createAndAppendFontSubMenu):
(WebCore::ContextMenuController::createAndAppendSpellingAndGrammarSubMenu):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded):

• page/DragClient.h: Ditto.
• page/DragController.cpp: Ditto.

(WebCore::dragLocForDHTMLDrag):
(WebCore::dragLocForSelectionDrag):
(WebCore::DragController::startDrag):
(WebCore::DragController::doImageDrag):

• page/EditorClient.h: Ditto.
• page/EventHandler.cpp: Ditto.

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::logicalScrollRecursively):
(WebCore::EventHandler::clearDragState):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::defaultWheelEventHandler):
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::eventInvertsTabsToLinksClientCallResult):

• page/EventHandler.h: Ditto.
• page/FrameView.cpp: Ditto.

(WebCore::FrameView::layout):

• page/Page.h: Ditto.
• page/Settings.cpp: Ditto.
• page/Settings.h: Ditto.
• page/scrolling/ScrollingCoordinator.cpp: Ditto.
• page/scrolling/ScrollingCoordinator.h: Ditto.
• page/scrolling/ScrollingStateNode.h: Removed unused #include.
• page/scrolling/ScrollingThread.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).

(WebCore::ScrollingThread::createThreadIfNeeded):

• page/scrolling/ScrollingThread.h: Ditto.
• platform/network/cf/ResourceRequest.h: Added !PLATFORM(IOS) around

applyWebArchiveHackForMail.

• platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::applyWebArchiveHackForMail): Ditto.

• platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::applyWebArchiveHackForMail): Ditto.

• plugins/PluginViewNone.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA)
• rendering/RenderBox.cpp: Ditto.

(WebCore::RenderBox::logicalScroll):

• rendering/RenderLayerBacking.cpp: Ditto.

(WebCore::RenderLayerBacking::createGraphicsLayer):
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):

• rendering/RenderMenuList.h: Ditto.
• rendering/RenderText.cpp: Ditto.

(WebCore::RenderText::previousOffsetForBackwardDeletion):

• rendering/break_lines.cpp: Removed unused #include.
• testing/js/WebCoreTestSupport.h: Changed PLATFORM(MAC) to PLATFORM(COCOA).
• xml/XSLStyleSheetLibxslt.cpp: Changed PLATFORM(MAC) to OS(DARWIN) && !PLATFORM(EFL) &&

!PLATFORM(GTK) around soft-linking libxslt.

• xml/XSLTExtensions.cpp: Ditto.
• xml/XSLTProcessorLibxslt.cpp: Ditto.
• xml/XSLTUnicodeSort.cpp: Ditto.

2:20 PM Changeset in webkit [163724] by akling@apple.com

• 19 edits in trunk/Source

Remove unused ChromeClient::formStateDidChange().
<​https://webkit.org/b/128469>

Nobody listens for this callback anymore so remove it and stop
spamming no-op virtual dispatches in forms code.

Reviewed by Anders Carlsson.

• html/FileInputType.cpp:

(WebCore::FileInputType::setFiles):

• html/HTMLFormControlElementWithState.cpp:
• html/HTMLFormControlElementWithState.h:
• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):
(WebCore::HTMLInputElement::setValue):
(WebCore::HTMLInputElement::setValueFromRenderer):

• html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::selectOption):

• html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updateValue):
(WebCore::HTMLTextAreaElement::setValueCommon):

• loader/EmptyClients.h:
• page/ChromeClient.h:

2:11 PM Changeset in webkit [163723] by commit-queue@webkit.org

• 5 edits in trunk

Web Inspector: Find evaluates attributes in a case sensitive manner
​https://bugs.webkit.org/show_bug.cgi?id=128405

Patch by Chris J. Shull <​chrisjshull@gmail.com> on 2014-02-08
Reviewed by Timothy Hatcher.

Source/WebCore:

Changed matchesAttribute to ignore case.

Updated existing test with additional cases:
inspector-protocol/dom/dom-search.html

• inspector/InspectorNodeFinder.cpp:

(WebCore::InspectorNodeFinder::matchesAttribute):

LayoutTests:

Added checks for searches where capitalization in the attributes did not match the capitalization in the search. Also fleshed out other search types with checks for valid capitalization differences.

• inspector-protocol/dom/dom-search-expected.txt:
• inspector-protocol/dom/resources/dom-search-queries.js:

2:05 PM Changeset in webkit [163722] by akling@apple.com

• 3 edits in trunk/Source/WebCore

Remove unused FrameLoaderClient::dispatchWillOpenSocketStream().
<​https://webkit.org/b/128472>

Nobody listens for this callback anymore so remove it.

Reviewed by Anders Carlsson.

• Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::willOpenSocketStream):

• loader/FrameLoaderClient.h:

1:40 PM Changeset in webkit [163721] by rniwa@webkit.org

• 8 edits in trunk/Source/WebCore

Split UserTriggered into FireSelectEvent and RevealSelection for selection options
​https://bugs.webkit.org/show_bug.cgi?id=128441

Reviewed by Darin Adler.

Split UserTriggered by FireSelectEvent and RevealSelection for selection options.

Also added defaultSetSelectionOptions() to abstract away the default options.

• editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::respondToUnappliedSpellCorrection):

• editing/Editor.cpp:

(WebCore::Editor::unappliedEditing):
(WebCore::Editor::reappliedEditing):

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::moveTo):
(WebCore::FrameSelection::setSelectionByMouseIfDifferent): UserTriggered | DoNotRevealSelection
is replaced by FireSelectEvent.
(WebCore::FrameSelection::setSelectionWithoutUpdatingAppearance): Check options & FireSelectEvent
instead of options & UserTriggered.
(WebCore::FrameSelection::setSelection): Check options & RevealSelection instead of
options & UserTriggered && !(options & DoNotRevealSelection).
(WebCore::FrameSelection::prepareForDestruction):
(WebCore::FrameSelection::setBase):
(WebCore::FrameSelection::setExtent):
(WebCore::FrameSelection::selectAll):
(WebCore::FrameSelection::wordSelectionContainingCaretSelection):

• editing/FrameSelection.h:

(WebCore::FrameSelection::defaultSetSelectionOptions): Added.

• editing/SpellingCorrectionCommand.cpp:

(WebCore::SpellingCorrectionCommand::doApply):

• html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::selectionChanged): Renamed the argument.

• html/HTMLTextFormControlElement.h:

12:58 PM Changeset in webkit [163720] by mitz@apple.com

• 1 edit in trunk/Source/ThirdParty/gtest/xcode/gtest.xcodeproj

Added project.xcworkspace to the svn:ignore property of gtest.xcodeproj.

12:10 PM Changeset in webkit [163719] by zandobersek@gmail.com

• 5 edits in trunk/Source/WebCore

Move TreeScope, IdTargetObserverRegistry to std::unique_ptr
​https://bugs.webkit.org/show_bug.cgi?id=127276

Reviewed by Andreas Kling.

Replace uses of OwnPtr in the TreeScope and IdTargetObserverRegistry classes with std::unique_ptr.

• dom/IdTargetObserverRegistry.cpp:

(WebCore::IdTargetObserverRegistry::addObserver):

• dom/IdTargetObserverRegistry.h:

(WebCore::IdTargetObserverRegistry::IdTargetObserverRegistry):

• dom/TreeScope.cpp:

(WebCore::TreeScope::TreeScope):
(WebCore::TreeScope::destroyTreeScopeData):
(WebCore::TreeScope::addElementById):
(WebCore::TreeScope::addElementByName):
(WebCore::TreeScope::addImageMap):
(WebCore::TreeScope::labelElementForId):

• dom/TreeScope.h:

(WebCore::TreeScope::shouldCacheLabelsByForAttribute):

12:02 PM Changeset in webkit [163718] by andersca@apple.com

• 8 edits in trunk/Source/WebCore

Slight CTTE in PingLoader
​https://bugs.webkit.org/show_bug.cgi?id=128462

Reviewed by Dan Bernstein.

PingLoader always wants a non-null frame.

• html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::sendPings):

• html/parser/XSSAuditorDelegate.cpp:

(WebCore::XSSAuditorDelegate::didBlockScript):

• inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::continueAfterPingLoader):

• loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
(WebCore::PingLoader::createPingLoader):
(WebCore::PingLoader::PingLoader):

• loader/PingLoader.h:
• loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestImage):

• page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::reportViolation):

11:58 AM Changeset in webkit [163717] by mitz@apple.com

• 38 edits in trunk

Remove client-drawn highlights (-webkit-highlight, WebHTMLHighlighter)
​https://bugs.webkit.org/show_bug.cgi?id=128456

Reviewed by Anders Carlsson.

Source/WebCore:

Updated fast/css/getComputedStyle and svg/css results.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue): Removed CSSPropertyWebKitHighlight case.

• css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Ditto.

• css/CSSPropertyNames.in: Removed -webkit-highlight.
• css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): Removed
CSSPropertyWebKitHighlight handler.

• css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty): Removed CSSPropertyWebKitHighlight case.

• page/Chrome.cpp: Removed customHighlightRect and paintCustomHighlight.
• page/ChromeClient.h: Ditto.
• rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint): Removed painting custom highlight.

• rendering/InlineTextBox.h:
• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::createLineBoxesFromBidiRuns): Removed adding overflow for custom
highlights.

• rendering/RenderBox.cpp: Removed paintCustomHighlight.
• rendering/RenderBox.h:
• rendering/RenderImage.cpp:

(WebCore::RenderImage::paintReplaced): Removed painting custom highlight.

• rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::paint): Ditto.

• rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::paintSnapshot): Ditto.

• rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paint): Ditto.

• rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::paint): Ditto.

• rendering/RootInlineBox.h:
• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresLayout): Removed highlight comparison.

• rendering/style/RenderStyle.h:
• rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData): Removed initializer.
(WebCore::StyleRareInheritedData::operator==): Removed highlight comparison.

• rendering/style/StyleRareInheritedData.h: Removed highlight member variable.

Source/WebInspectorUI:

• UserInterface/CSSKeywordCompletions.js: Removed -webkit-highlight.

Source/WebKit/mac:

• WebCoreSupport/WebChromeClient.h:
• WebCoreSupport/WebChromeClient.mm: Removed customHighlightRect and paintCustomHighlight.
• WebView/WebHTMLView.mm:

(-[WebHTMLViewPrivate dealloc]): Removed highlighters ivar.
(-[WebHTMLViewPrivate clear]): Ditto.

• WebView/WebHTMLViewInternal.h: Removed declaration.
• WebView/WebHTMLViewPrivate.h: Removed WebHTMLHighlighter protocol and method declarations.

Source/WebKit2:

• WebProcess/WebCoreSupport/WebChromeClient.cpp: Removed customHighlightRect and

paintCustomHighlight.

• WebProcess/WebCoreSupport/WebChromeClient.h:

LayoutTests:

• fast/css/getComputedStyle/computed-style-expected.txt:
• fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
• svg/css/getComputedStyle-basic-expected.txt:

10:37 AM Changeset in webkit [163716] by mitz@apple.com

• 2 edits in trunk/Source/WebCore

One more build fix fix.

• accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper arrayOfTextForTextMarkers:attributed:]):

10:35 AM Changeset in webkit [163715] by mitz@apple.com

• 6 edits in trunk/Source

Source/WebCore: More (and more correct) iOS build fix after r163712.

• accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(AXAttributedStringAppendText):
(-[WebAccessibilityObjectWrapper arrayOfTextForTextMarkers:attributed:]):

• page/ios/FrameIOS.mm:

(WebCore::Frame::wordsInCurrentParagraph):

Source/WebKit/mac: iOS build fix after r163712.

• WebCoreSupport/WebEditorClient.h:
• WebCoreSupport/WebEditorClient.mm:

10:06 AM Changeset in webkit [163714] by mitz@apple.com

• 2 edits in trunk/Source/WebCore

iOS build fix after r163712

• page/ios/FrameIOS.mm:

(WebCore::Frame::indexCountOfWordPrecedingSelection):
(WebCore::Frame::wordsInCurrentParagraph):

9:08 AM Changeset in webkit [163713] by zandobersek@gmail.com

• 12 edits
  18 adds
  19 deletes in trunk/LayoutTests

Convert current MHTML tests into reftests
​https://bugs.webkit.org/show_bug.cgi?id=116443

Reviewed by Andreas Kling.

Convert the current set of MHTML tests into reference tests. Reference files are copied from the *_original files
where available (with the *_original files removed) or from the source markup and code that's stored in the archive.
Both the archives and the reference files are adjusted to now dump pixel output instead of text.

• mhtml/check_domain-expected.html: Added.
• mhtml/check_domain-expected.txt: Removed.
• mhtml/check_domain.mht:
• mhtml/frame_4.html_original: Removed.
• mhtml/multi_frames.html_original: Removed.
• mhtml/multi_frames_binary-expected.html: Added.
• mhtml/multi_frames_binary-expected.txt: Removed.
• mhtml/multi_frames_binary.mht:
• mhtml/multi_frames_ie-expected.html: Added.
• mhtml/multi_frames_ie-expected.txt: Removed.
• mhtml/multi_frames_ie.mht:
• mhtml/multi_frames_unmht-expected.html: Added.
• mhtml/multi_frames_unmht-expected.txt: Removed.
• mhtml/multi_frames_unmht.mht:
• mhtml/page_with_css_and_js_ie-expected.html: Copied from LayoutTests/mhtml/page_with_css_and_js.html_original.
• mhtml/page_with_css_and_js_ie-expected.txt: Removed.
• mhtml/page_with_css_and_js_ie.mht:
• mhtml/page_with_css_and_js_unmht-expected.html: Renamed from LayoutTests/mhtml/page_with_css_and_js.html_original.
• mhtml/page_with_css_and_js_unmht-expected.txt: Removed.
• mhtml/page_with_css_and_js_unmht.mht:
• mhtml/page_with_image.html_original: Removed.
• mhtml/page_with_image_ie-expected.html: Added.
• mhtml/page_with_image_ie-expected.txt: Removed.
• mhtml/page_with_image_ie.mht:
• mhtml/page_with_image_unmht-expected.html: Added.
• mhtml/page_with_image_unmht-expected.txt: Removed.
• mhtml/page_with_image_unmht.mht:
• mhtml/resources/frame_0.html: Renamed from LayoutTests/mhtml/frame_0.html_original.
• mhtml/resources/frame_1.html: Renamed from LayoutTests/mhtml/frame_1.html_original.
• mhtml/resources/frame_2.html: Renamed from LayoutTests/mhtml/frame_2.html_original.
• mhtml/resources/frame_4.html: Added.
• mhtml/resources/hide_image.css: Added.

(#secondDiv):

• mhtml/resources/remove_image_script.js: Added.

(onLoad):

• mhtml/resources/style.css: Copied from LayoutTests/mhtml/shared_buffer_bug.mht.

(h1):

• mhtml/shared_buffer_bug-expected.html: Added.
• mhtml/shared_buffer_bug-expected.txt: Removed.
• mhtml/shared_buffer_bug.mht:
• mhtml/simple_page_ie-expected.html: Copied from LayoutTests/mhtml/simple_page.html_original.
• mhtml/simple_page_ie-expected.txt: Removed.
• mhtml/simple_page_ie.mht:
• mhtml/simple_page_unmht-expected.html: Renamed from LayoutTests/mhtml/simple_page.html_original.
• mhtml/simple_page_unmht-expected.txt: Removed.
• mhtml/simple_page_unmht.mht:

8:32 AM Changeset in webkit [163712] by Darin Adler

• 51 edits
  2 copies in trunk/Source

Change TextIterator to use StringView, preparing to wean it from deprecatedCharacters
​https://bugs.webkit.org/show_bug.cgi?id=128233

Reviewed by Anders Carlsson.

Source/WebCore:

• accessibility/AccessibilityNodeObject.cpp: Removed unneeded TextIterator.h include.

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::hasMisspelling): Updated to use StringView for checkSpelling.

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(AXAttributeStringSetSpelling): Changed to take a StringView.
(AXAttributedStringAppendText): Ditto.
(-[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]): Pass StringView.

• editing/Editor.cpp:

(WebCore::Editor::misspelledWordAtCaretOrRange): Pass StringView.
(WebCore::Editor::misspelledSelectionString): Ditto.
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Ditto.

• editing/TextCheckingHelper.cpp:

(WebCore::findGrammaticalErrors): Renamed this function. Changed to use StringView.
(WebCore::findMisspellings): Use StringView.
(WebCore::TextCheckingHelper::findFirstMisspelling): Ditto. Also separated out assertions
that were asserting multiple things with &&.
(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar): Ditto.
(WebCore::TextCheckingHelper::findFirstGrammarDetail): Ditto.
(WebCore::TextCheckingHelper::findFirstBadGrammar): Ditto.
(WebCore::TextCheckingHelper::isUngrammatical): Ditto.
(WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): Ditto.
(WebCore::checkTextOfParagraph): Ditto.

• editing/TextCheckingHelper.h: Made TextCheckingParagraph::text public. Deleted

TextCheckingParagraph::textDeprecatedCharacters. Added comments about additional
TextCheckingParagraph refinements. Changed checkTextOfParagraph to take a client
reference instead of pointer and StringView instead of characters pointer with length.

• editing/TextIterator.cpp:

(WebCore::TextIterator::appendTextToStringBuilder): Use data members directly,
rather than using functions, since we already checked m_textCharacters for null.
(WebCore::CharacterIterator::string): Use text() instead of characters().
(WebCore::WordAwareIterator::WordAwareIterator): Removed initialization of
m_previousText now that it's a StringView rather than a pointer.
(WebCore::WordAwareIterator::advance): Use TextIterator::text instead of
TextIterator::characters. Also added a FIXME about a fundamental problem
with the implementation of this class!
(WebCore::WordAwareIterator::length): Updated for m_previousText change.
(WebCore::WordAwareIterator::text): Replaced WordAwareIterator::characters with this.
(WebCore::SearchBuffer::append): Changed to take a StringView.
(WebCore::SearchBuffer::prependContext): Ditto.
(WebCore::SearchBuffer::isWordStartMatch): Use StringView.
(WebCore::SearchBuffer::search): Ditto.
(WebCore::findPlainText): Ditto.

• editing/TextIterator.h: Added TextIterator::text that returns a StringView, and

renamed TextIterator::characters to TextIterator::deprecatedTextIteratorCharacters
(easy to search for in source code). Added SimplifiedBackwardsTextIterator::text
and removed SimplifiedBackwardsTextIterator::characters. Added CharacterIterator::text,
and removed CharacterIterator::characters. Added WordAwareIterator::text and removed
WorkdAwareIterator::characters. Changed WordAwareIterator data members to use StringView.

• editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::appendTrailingWhitespace): Use TextIterator::text instead
of TextIterator::characters.

• editing/VisibleUnits.cpp:

(WebCore::previousBoundary): Updated to use StringView.
(WebCore::nextBoundary): Ditto.
(WebCore::startWordBoundary): Ditto.
(WebCore::startOfWord): Ditto.
(WebCore::endWordBoundary): Ditto.
(WebCore::endOfWord): Fixed formatting.
(WebCore::previousWordPositionBoundary): Updated to use StringView.
(WebCore::previousWordPosition): Fixed formatting and got rid of local variable.
(WebCore::nextWordPositionBoundary): Updated to use StringView.
(WebCore::nextWordPosition): Fixed formatting and got rid of local variable.
(WebCore::inSameLine): Fixed formatting.
(WebCore::isStartOfLine): Ditto.
(WebCore::isEndOfLine): Ditto.
(WebCore::absoluteLineDirectionPointToLocalPointInBlock): Changed to take a reference.
(WebCore::previousLinePosition): Fixed formatting chand changed to pass a reference.
(WebCore::nextLinePosition): Ditto.
(WebCore::startSentenceBoundary): Updated to use StringView and got rid of a local.
(WebCore::startOfSentence): Fixed formatting.
(WebCore::endSentenceBoundary): Updated to use StringView and got rid of a local.
(WebCore::endOfSentence): Fixed formatting.
(WebCore::previousSentencePositionBoundary): Updated to use StringView and got rid of
a local.
(WebCore::previousSentencePosition): Ditto.
(WebCore::nextSentencePositionBoundary): Ditto.
(WebCore::nextSentencePosition): Fixed formatting.
(WebCore::endOfParagraph): Ditto.
(WebCore::inSameParagraph): Ditto.
(WebCore::isStartOfParagraph): Ditto.
(WebCore::isEndOfParagraph): Ditto.
(WebCore::inSameBlock): Ditto.
(WebCore::isStartOfBlock): Ditto.
(WebCore::isEndOfBlock): Ditto.
(WebCore::startOfDocument): Ditto.
(WebCore::endOfDocument): Ditto.
(WebCore::inSameDocument): Ditto.
(WebCore::isStartOfDocument): Ditto.
(WebCore::isEndOfDocument): Ditto.
(WebCore::isEndOfEditableOrNonEditableContent): Ditto.

• loader/EmptyClients.h: Use StringView.

• platform/mac/HTMLConverter.mm:

(+[WebHTMLConverter editingAttributedStringFromRange:]): Use StringView.

• platform/text/TextBoundaries.cpp:

(WebCore::endOfFirstWordBoundaryContext): Use StringView and unsigned.
(WebCore::startOfLastWordBoundaryContext): Ditto.

• platform/text/TextBoundaries.h: Change interfaces to use StringView,

and in some cases, unsigned instead of int. All call sites were better off
with unsigned.

• platform/text/TextCheckerClient.h: Use StringView.

• platform/text/mac/TextBoundaries.mm: Changed conditionals to say

USE(APPKIT) instead of PLATFORM(IOS), since that's the real issue.
(WebCore::isSkipCharacter): Tweaked formatting.
(WebCore::isWhitespaceCharacter): Ditto.
(WebCore::isWordDelimitingCharacter): Ditto, also removed local variable.
(WebCore::isSymbolCharacter): Ditto.
(WebCore::tokenizerForString): Ditto.
(WebCore::findSimpleWordBoundary): Use StringView. Also changed to mostly
use unsigned instead of int.
(WebCore::findComplexWordBoundary): Use StringView. Also restructured to
be much more readable, with early returns and such.
(WebCore::findWordBoundary): Use StringView and unsigned.
(WebCore::findEndWordBoundary): Removed redudant copy of the findWordBoundary
function and changed this to just call findWordBoundary. The reason this
function exists is to optimize this case for some non-Mac, non-iOS platforms.
We can always do that for Mac and/or iOS later if we like.
(WebCore::findNextWordFromIndex): Use StringView. Also use wordBreakIterator
instead of using UBreakIterator directly so we get a cached iterator instead
of creating and destroying a new one each time this function is called.

• bindings/objc/DOMUIKitExtensions.mm: Removed unneeded includes.
• dom/Element.cpp: Ditto.
• dom/PositionIterator.cpp: Ditto.
• editing/ApplyBlockElementCommand.cpp: Ditto.
• editing/IndentOutdentCommand.cpp: Ditto.
• editing/InsertListCommand.cpp: Ditto.
• editing/markup.cpp: Ditto.
• html/HTMLElement.cpp: Ditto.
• html/HTMLTextAreaElement.cpp: Ditto.
• page/Frame.cpp: Ditto.
• rendering/RenderTextControl.cpp: Ditto.

Source/WebKit/efl:

• WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::checkSpellingOfString): Use StringView.
(WebCore::EditorClientEfl::checkGrammarOfString): Ditto.

• WebCoreSupport/EditorClientEfl.h: Ditto.

Source/WebKit/gtk:

• WebCoreSupport/TextCheckerClientGtk.cpp:

(WebKit::TextCheckerClientGtk::checkSpellingOfString): Use StringView.
(WebKit::TextCheckerClientGtk::checkGrammarOfString): Ditto.

• WebCoreSupport/TextCheckerClientGtk.h: Ditto.

Source/WebKit/mac:

• WebCoreSupport/WebEditorClient.h: Made most data members private. Moved inlines

for iOS out of the class definition. Fixed formatting. Added missing virtual keyword.
Changed interfaces to use StringView.

• WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::checkTextOfParagraph): Use the new StringView::createNSStringWithoutCopying
function instead of a similar function that was local in this file.
(WebEditorClient::ignoreWordInSpellDocument): Tweaked formatting.
(WebEditorClient::checkSpellingOfString): Changed to take a StringView.
(WebEditorClient::checkGrammarOfString): Ditto.

• WebView/WebTextIterator.mm:

(-[WebTextIterator currentTextPointer]): Call TextIterator::deprecatedTextIteratorCharacters.
(-[WebTextIterator currentText]): Convert a the text to an NSString with TextIterator::text
instead of with TextIterator::characters/length.

Source/WebKit/win:

• WebCoreSupport/WebEditorClient.cpp:

(WebEditorClient::checkSpellingOfString): Use StringView.
(WebEditorClient::checkGrammarOfString): Ditto.

• WebCoreSupport/WebEditorClient.h: Ditto.

Source/WebKit/wince:

• WebCoreSupport/EditorClientWinCE.cpp:

(WebKit::EditorClientWinCE::checkSpellingOfString): Use StringView.
(WebKit::EditorClientWinCE::checkGrammarOfString): Ditto.

• WebCoreSupport/EditorClientWinCE.h: Ditto.

Source/WebKit2:

• WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.mm:

(-[WKDOMTextIterator currentTextPointer]): Call TextIterator::deprecatedTextIteratorCharacters.

• WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::checkSpellingOfString): Use StringView.
(WebKit::WebEditorClient::checkGrammarOfString): Ditto.

• WebProcess/WebCoreSupport/WebEditorClient.h: Ditto.

Source/WTF:

• WTF.xcodeproj/project.pbxproj: Added new source files.

• wtf/text/StringView.h: Added operator[], createCFStringWithoutCopying, and

createNSStringWithoutCopying.

• wtf/text/cf/StringViewCF.cpp:

(WTF::StringView::createCFStringWithoutCopying): Added.

• wtf/text/mac/StringViewObjC.mm:

(WTF::StringView::createNSString): Added.
(WTF::StringView::createNSStringWithoutCopying): Added.

8:14 AM Changeset in webkit [163711] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[GTK] Add stdlib include file to fix ImageDiff build with libc++
​https://bugs.webkit.org/show_bug.cgi?id=128454

Patch by Rajaram Gaunker <​zimbabao@gmail.com> on 2014-02-08
Reviewed by Darin Adler.

• ImageDiff/gtk/ImageDiff.cpp:

2:33 AM Changeset in webkit [163710] by mrowe@apple.com

• 2 edits in trunk/Source/JavaScriptCore

<​https://webkit.org/b/128452> Don't duplicate the list of input files for postprocess-headers.sh

Reviewed by Dan Bernstein.

• postprocess-headers.sh: Pull the list of headers to process out of the environment.

2:03 AM Changeset in webkit [163709] by mrowe@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Fix the iOS build.

• API/WebKitAvailability.h: Skip the workarounds specific to OS X when we're building for iOS.

1:26 AM Changeset in webkit [163708] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[GTK] Build break in WebKitWebViewBase.cpp::webkitWebViewBaseCreateWebPage
​https://bugs.webkit.org/show_bug.cgi?id=128449

Patch by Piotr Grad <​p.grad@samsung.com> on 2014-02-08
Reviewed by Carlos Garcia Campos.

Parameter passed to context->createWebPage was inproper.

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseCreateWebPage):

1:01 AM Changeset in webkit [163707] by mrowe@apple.com

• 5 edits
  1 add in trunk/Source/JavaScriptCore

<​https://webkit.org/b/128448> Fix use of availability macros on recently-added APIs

Reviewed by Dan Bernstein.

• API/JSContext.h: Remove some #ifs.
• API/JSManagedValue.h: Ditto.
• API/WebKitAvailability.h: #define the macros that availability macros mentioning

newer OS X versions would expand to when building on older OS versions.

• JavaScriptCore.xcodeproj/project.pbxproj: Call the new postprocess-headers.sh.
• postprocess-headers.sh: Extracted from the Xcode project. Updated to remove content

from headers based on the MAC_OS_X_VERSION_MIN_REQUIRED macro, and to
process WebKitAvailability.h.

12:53 AM Changeset in webkit [163706] by akling@apple.com

• 3 edits in trunk/Source/WebCore

Remove two unused function declarations.

Scrub "highQualityRepaintTimerFired" declarations from RenderImage
and RenderBoxModelObject since they're not actually defined.

• rendering/RenderBoxModelObject.h:
• rendering/RenderImage.h:

12:50 AM Changeset in webkit [163705] by akling@apple.com

• 3 edits in trunk/Source/WebCore

CTTE: SVGTRefTargetEventListener is always owned by SVGTRefElement.
<​https://webkit.org/b/128432>

Tighten up the relationship between SVGTRefElement and its internal
event listener helper by storing the listener in a Ref, and making
the listeners backpointer to the element be a reference.

Reviewed by Anders Carlsson.

• svg/SVGTRefElement.cpp:

(WebCore::SVGTRefTargetEventListener::create):
(WebCore::SVGTRefTargetEventListener::SVGTRefTargetEventListener):
(WebCore::SVGTRefTargetEventListener::operator==):
(WebCore::SVGTRefTargetEventListener::handleEvent):
(WebCore::SVGTRefElement::SVGTRefElement):

• svg/SVGTRefElement.h:

12:48 AM Changeset in webkit [163704] by akling@apple.com

• 2 edits in trunk/Source/WebCore

Devirtualize RenderBlockFlowRareData.
<​https://webkit.org/b/128427>

This class had a virtual destructor for no reason. Removing it
shrinks RenderBlockFlowRareData by 8 bytes.

Reviewed by Anders Carlsson.

• rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::RenderBlockFlowRareData::~RenderBlockFlowRareData):

12:45 AM Changeset in webkit [163703] by akling@apple.com

• 3 edits in trunk/Source/WebCore

Use renderer iterators in two more places.
<​https://webkit.org/b/128371>

Reviewed by Antti Koivisto.

• dom/Position.cpp:

(WebCore::Position::primaryDirection):

Use lineageOfType instead of walking the parent chain.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::insertOnlyThisLayer):

Use childrenOfType instead of walking the children.

12:42 AM Changeset in webkit [163702] by mitz@apple.com

• 5 edits in trunk/Source/WebKit2

Font size-related preference values should be CGFloats backed by doubles
​https://bugs.webkit.org/show_bug.cgi?id=128445

Reviewed by Filip Pizlo.

• Shared/WebPreferencesStore.h: Changed minimumFontSize, minimumLogicalFontSize,

defaultFontSize, and defaultFixedFontSize into double-value preferences.

• UIProcess/API/Cocoa/WKPreferences.h: Changed minimumFontSize into CGFloat.
• UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences minimumFontSize]): Changed return type.
(-[WKPreferences setMinimumFontSize:]): Changed parameter type.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Changed to use double getters.

12:36 AM Changeset in webkit [163701] by akling@apple.com

• 5 edits in trunk

Remove unused ENABLE(REPAINT_THROTTLING) flag.
<​https://webkit.org/b/128329>

Reviewed by Antti Koivisto.

.:

• Source/cmake/WebKitFeatures.cmake:
• Source/cmakeconfig.h.cmake:

Source/WTF:

• wtf/FeatureDefines.h:

12:27 AM Changeset in webkit [163700] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

JSLock should not "restore" VM stack values if it did not re-grab locks.
<​https://webkit.org/b/128447>

Reviewed by Geoffrey Garen.

In the existing code, if DropAllLocks is instantiate with DontAlwaysDropLocks
in a thread that does not own the JSLock, then a bug will manifest where:

1. The DropAllLocks constructor will save the VM's stackPointerAtEntry, lastStackTop, and reservedZoneSize even though it will not drop the JSLock.
2. The DropAllLocks destructor will restore those 3 values to the VM even though the JSLock will not grab its internal lock.

The former only causes busy work but does not impact correctness. The latter
however, will corrupt those 3 VM values which belong to the thread that
actually owns the JSLock.

The fix is to only save the values when the JSLock will actually drop its
internal lock, and only restore the values if it did re-grab the internal lock.

• runtime/JSLock.cpp:

(JSC::JSLock::dropAllLocks):
(JSC::JSLock::dropAllLocksUnconditionally):
(JSC::JSLock::grabAllLocks):
(JSC::JSLock::DropAllLocks::DropAllLocks):

• Moved the saving of VM stack values to dropAllLocks() and dropAllLocksUnconditionally().

(JSC::JSLock::DropAllLocks::~DropAllLocks):

• Moved the restoring of VM stack values to grabAllLocks().

12:26 AM Changeset in webkit [163699] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[GTK] Minibrowser: Matched words of a searched text are not highlighted after reopening search bar
​https://bugs.webkit.org/show_bug.cgi?id=128380

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-02-08
Reviewed by Carlos Garcia Campos.

When open the search bar, perform last search if there is any.

• MiniBrowser/gtk/BrowserSearchBar.c:

(browser_search_bar_open):

12:25 AM Changeset in webkit [163698] by commit-queue@webkit.org

• 6 edits in trunk

[GTK] Make process model names properly meaningful
​https://bugs.webkit.org/show_bug.cgi?id=128389

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2014-02-08
Reviewed by Carlos Garcia Campos.

The name WEBKIT_PROCESS_MODEL_ONE_SECONDARY_PROCESS_PER_WEB_VIEW
is misleading because there are situations in which web views may
share the same web process even when multi-process mode is enabled;
for example when opening a related view and both interact using JS.

Source/WebKit2:

• UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_set_process_model):
(webkit_web_context_get_process_model):
Update names of WebKitProcessModel enum values.

• UIProcess/API/gtk/WebKitWebContext.h:

Ditto.

Tools:

• MiniBrowser/gtk/main.c:

(main):
Update usage of WebKitProcessModel enum values.

• TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:

(beforeAll):
Ditto.

12:24 AM Changeset in webkit [163697] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[GTK] build-webkit script always generate-gtk-doc even if '--disable-gtk-doc' param is passed
​https://bugs.webkit.org/show_bug.cgi?id=128376

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-02-08
Reviewed by Carlos Garcia Campos.

• Scripts/webkitdirs.pm:

(buildAutotoolsProject):

12:21 AM Changeset in webkit [163696] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[GTK] Build break in WebKitSettings
​https://bugs.webkit.org/show_bug.cgi?id=128446

Patch by Piotr Grad <​p.grad@samsung.com> on 2014-02-08
Reviewed by Ryosuke Niwa.

Argument for WebPreferences::create was missing

• UIProcess/API/gtk/WebKitSettings.cpp:

(_WebKitSettingsPrivate::_WebKitSettingsPrivate):

Feb 7, 2014:

10:56 PM Changeset in webkit [163695] by fpizlo@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Don't throw away code if there is code on the worklists
​https://bugs.webkit.org/show_bug.cgi?id=128443

Reviewed by Joseph Pecoraro.

If we throw away compiled code and there is code currently being JITed then the JIT
will get confused after it resumes: it will see a code block that had claimed to belong
to an executable except that it doesn't belong to any executables anymore.

• dfg/DFGWorklist.h:

(JSC::DFG::Worklist::isActive):

• heap/Heap.cpp:

(JSC::Heap::deleteAllCompiledCode):

9:59 PM Changeset in webkit [163694] by jinwoo7.song@samsung.com

• 2 edits in trunk/Source/WebKit2

Unreviewed EFL WebKit2 build fix after r163671.

• UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::WebView): Use WebPageConfiguration in creating WebPage.

9:33 PM Changeset in webkit [163693] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebCore

[ASan] Use new/delete in PODFreeListArena
<​http://webkit.org/b/128437>

Reviewed by Oliver Hunt.

• platform/PODFreeListArena.h:

(WebCore::PODFreeListArena::allocateObject): Use new when
ADDRESS_SANITIZER is defined.
(WebCore::PODFreeListArena::freeObject): Use delete when
ADDRESS_SANITIZER is defined.

9:27 PM Changeset in webkit [163692] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

Merge updateSelectionCachesIfSelectionIsInsideTextFormControl into setSelectionWithoutUpdatingAppearance
​https://bugs.webkit.org/show_bug.cgi?id=128439

Reviewed by Anders Carlsson.

FrameSelection::selectAll had a superfluous call to updateSelectionCachesIfSelectionIsInsideTextFormControl
because it wasn't setting UserTriggered option to avoid revealing selection.

Call setSelection with UserTriggered and recently added DoNotRevealSelection option and merge
updateSelectionCachesIfSelectionIsInsideTextFormControl into setSelectionWithoutUpdatingAppearance.

Also rename local variables in setSelectionWithoutUpdatingAppearance, newSelection to
newSelectionPossiblyWithoutDirection and s to newSelection so that they're self explanatory.

In addition, we now update the input element's selection caches before calling
selectFrameElementInParentIfFullySelected but this should be fine because selection cannot simultaneously
select the entire document and be inside a text form control.

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelectionWithoutUpdatingAppearance):
(WebCore::FrameSelection::selectAll):

9:06 PM Changeset in webkit [163691] by fpizlo@apple.com

• 21 edits in trunk/Source/JavaScriptCore

GC should safepoint the DFG worklist in a smarter way rather than just waiting for everything to complete
​https://bugs.webkit.org/show_bug.cgi?id=128297

Reviewed by Oliver Hunt.

This makes DFG worklist threads have a rightToRun lock that gives them the ability to
be safepointed by the GC in much the same way as you'd expect from a fully
multithreaded VM.

The idea is that the worklist threads's roots are the DFG::Plan. They only touch those
roots when holding the rightToRun lock. They currently grab that lock to run the
compiler, but relinquish it when accessing - and waiting on - the worklist.

• bytecode/CodeBlock.h:

(JSC::CodeBlockSet::mark):

• dfg/DFGCompilationKey.cpp:

(JSC::DFG::CompilationKey::visitChildren):

• dfg/DFGCompilationKey.h:
• dfg/DFGDesiredStructureChains.cpp:

(JSC::DFG::DesiredStructureChains::visitChildren):

• dfg/DFGDesiredStructureChains.h:
• dfg/DFGDesiredTransitions.cpp:

(JSC::DFG::DesiredTransition::visitChildren):
(JSC::DFG::DesiredTransitions::visitChildren):

• dfg/DFGDesiredTransitions.h:
• dfg/DFGDesiredWeakReferences.cpp:

(JSC::DFG::DesiredWeakReferences::visitChildren):

• dfg/DFGDesiredWeakReferences.h:
• dfg/DFGDesiredWriteBarriers.cpp:

(JSC::DFG::DesiredWriteBarrier::visitChildren):
(JSC::DFG::DesiredWriteBarriers::visitChildren):

• dfg/DFGDesiredWriteBarriers.h:
• dfg/DFGPlan.cpp:

(JSC::DFG::Plan::visitChildren):

• dfg/DFGPlan.h:
• dfg/DFGWorklist.cpp:

(JSC::DFG::Worklist::~Worklist):
(JSC::DFG::Worklist::finishCreation):
(JSC::DFG::Worklist::suspendAllThreads):
(JSC::DFG::Worklist::resumeAllThreads):
(JSC::DFG::Worklist::visitChildren):
(JSC::DFG::Worklist::runThread):
(JSC::DFG::Worklist::threadFunction):

• dfg/DFGWorklist.h:

(JSC::DFG::numberOfWorklists):
(JSC::DFG::worklistForIndexOrNull):

• heap/CodeBlockSet.h:
• heap/Heap.cpp:

(JSC::Heap::markRoots):
(JSC::Heap::collect):

• runtime/IntendedStructureChain.cpp:

(JSC::IntendedStructureChain::visitChildren):

• runtime/IntendedStructureChain.h:
• runtime/VM.cpp:

(JSC::VM::~VM):
(JSC::VM::prepareToDiscardCode):

7:54 PM Changeset in webkit [163690] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

EFL build fix attempt after r163662.

• Modules/indexeddb/leveldb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::encodeIDBKey):

7:50 PM Changeset in webkit [163689] by rniwa@webkit.org

• 3 edits in trunk/Source/WebCore

FrameSelection's destructor shouldn't notify accessibility
​https://bugs.webkit.org/show_bug.cgi?id=128421

Reviewed by Benjamin Poulain.

Extracted setSelectionWithoutUpdatingAppearance out of setSelection and called it in prepareForDestruction
instead of setting DoNotUpdateAppearance option. This new function doesn't reveal selection or notify
accessibility code in addition to not updating appearance.

Note that all implementations of notifyAccessibilityForSelectionChange in FrameSelectionAtk.cpp and
FrameSelectionMac.mm exit early when the selection type is not caret or either start or end is null,
which is already the case inside FrameSelection's destructor. In addition, revealSelection is never called
when selection change was not triggered by user so there should be no behavioral change from this patch.

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelectionWithoutUpdatingAppearance):
(WebCore::FrameSelection::setSelection):
(WebCore::FrameSelection::prepareForDestruction):

• editing/FrameSelection.h:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange): Added the trivial implementation in the case
accessibility is disabled to tidy up call sites.

7:11 PM Changeset in webkit [163688] by rniwa@webkit.org

• 61 adds in trunk/Websites/perf.webkit.org

Merge database-common.js and utility.js into run-tests.js.

Reviewed by Matthew Hanson.

Now that run-tests is the only node.js script, merged database-common.js and utility.js into it.
Also moved init-database.sql out of the database directory and removed the directory entirely.

• database: Removed.
• database/database-common.js: Removed.
• database/utility.js: Removed.
• init-database.sql: Moved from database/init-database.sql.
• run-tests.js:

(connect): Moved from database-common.js.
(pathToDatabseSQL): Extracted from pathToLocalScript.
(pathToTests): Moved from database-common.js.
(config): Ditto.
(TaskQueue): Ditto.
(SerializedTaskQueue): Ditto.
(main):
(initializeDatabase):
(TestEnvironment.it):
(TestEnvironment.queryAndFetchAll):
(sendHttpRequest):

7:11 PM Changeset in webkit [163687] by Martin Robinson

• 2 edits in trunk/Source/WebCore

Build fix for the GTK+ CMake build

• PlatformGTK.cmake: VTTCue.idl was unintentionally added to the list of GObject DOM bindings

output files. Remove it.

7:01 PM Changeset in webkit [163686] by krit@webkit.org

• 4 edits in trunk

Per CSSOM, computed rect() function values must be comma separated
​https://bugs.webkit.org/show_bug.cgi?id=128401

Reviewed by Simon Fraser.

Updated tests.

• css/Rect.h:

(WebCore::Rect::generateCSSString):

6:52 PM Changeset in webkit [163685] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unify JSLock implementation for iOS and non-iOS ports.
<​https://webkit.org/b/128409>

Reviewed by Michael Saboff.

The iOS and non-iOS implementations of dropAllLocks(),
dropAllLocksUnconditionally(), and grabAllLocks() effectively do the
same work. The main difference is that the iOS implementation acquires
the JSLock spin lock in the DropAllLocks class while the other ports
acquire it when it calls JSLock::lock() and unlock().

The other difference is that the iOS implementation will only increment
m_locksDropDepth if it actually drops locks, whereas other ports will
increment it unconditionally. Analogously, iOS decrements the depth only
when needed while other ports will decrement it unconditionally when
re-grabbing locks.

We can unify the 2 implementations by having both use the iOS
implementation for a start.

• runtime/JSLock.cpp:

(JSC::JSLock::dropAllLocks):
(JSC::JSLock::dropAllLocksUnconditionally):
(JSC::JSLock::grabAllLocks):
(JSC::JSLock::DropAllLocks::DropAllLocks):
(JSC::JSLock::DropAllLocks::~DropAllLocks):

6:51 PM Changeset in webkit [163684] by barraclough@apple.com

• 4 edits in trunk/Source/WebKit2

Add better comments to code that boosts the NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=128431

Rubber stamped by Tim Horton

• Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:

(WebKit::XPCServiceEventHandler):

• Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:

(WebKit::XPCServiceEventHandler):

• UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::connectToService):

6:42 PM Changeset in webkit [163683] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

Build fix.

• UIProcess/API/ios/WKContentView.mm:

(-[WKContentView initWithFrame:configuration:]):

6:39 PM Changeset in webkit [163682] by zoltan@webkit.org

• 2 edits
  2 adds in trunk/PerformanceTests

[CSS Shapes] Add initial performance tests for inset shape
​https://bugs.webkit.org/show_bug.cgi?id=128378

Reviewed by Ryosuke Niwa.

• Layout/Shapes/ShapeOutsideContentBox.html: Move js to shapes.js.
• Layout/Shapes/ShapeOutsideInset.html: Added.
• Layout/Shapes/resources/shapes.js: Added.

(.):

6:38 PM Changeset in webkit [163681] by andersca@apple.com

• 8 edits in trunk/Source/WebKit2

Pass the preferences through from the WKWebViewConfiguration object
​https://bugs.webkit.org/show_bug.cgi?id=128430

Reviewed by Tim Horton.

• UIProcess/API/Cocoa/WKPreferences.h:
• UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences init]):
Don't return nil if [super init] returns a valid object.

(-[WKPreferences minimumFontSize]):
(-[WKPreferences setMinimumFontSize:]):
Change this property to be unsigned.

• UIProcess/API/Cocoa/WKPreferencesInternal.h:

Use @package.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):
Set up a WebKit::WebPageConfiguration and use the new -[WKView initWithFrame:context:configuration:] method.

• UIProcess/API/ios/WKContentView.mm:

(-[WKContentView initWithFrame:configuration:]):
Set the preferences.

• UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:context:configuration:]):
Add a new initializer that takes a WebContext and a WebPageConfiguration.

(-[WKView _registerDraggedTypes]):
This shouldn't be in the private category.

(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
Call the new initializer.

• UIProcess/API/mac/WKViewInternal.h:

6:28 PM Changeset in webkit [163680] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

Fix the WebKit2 build after r163671.

• UIProcess/API/ios/WKContentView.mm:

(-[WKContentView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):

6:25 PM Changeset in webkit [163679] by barraclough@apple.com

• 16 edits in trunk

Remove isInitialState flag from Page::setViewState
​https://bugs.webkit.org/show_bug.cgi?id=128428

Reviewed by Sam Weinig.

Source/WebCore:

• WebCore.exp.in:
  • removed isInitialState.
• page/Page.cpp:

(WebCore::Page::setViewState):

• removed isInitialState.

(WebCore::Page::setIsVisible):

• removed isInitialState.

(WebCore::Page::setIsVisibleInternal):

• removed isInitialState.

• page/Page.h:
  • removed isInitialState.

Source/WebKit/efl:

• ewk/ewk_view.cpp:

(ewk_view_visibility_state_set):

• don't pass isInitialState to setViewState.

Source/WebKit/gtk:

• WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setPageVisibility):

• don't pass isInitialState to setViewState.

Source/WebKit/mac:

• WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _updateVisibilityState]):
(-[WebView _setIsVisible:]):
(-[WebView _setVisibilityState:isInitialState:]):
(-[WebView _windowWillOrderOnScreen:]):
(-[WebView _windowWillOrderOffScreen:]):

• don't pass isInitialState to setViewState.

Source/WebKit2:

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

• don't pass isInitialState to setViewState.

(WebKit::WebPage::reinitializeWebPage):

• if the viewState changes this should fire a visibility event.

(WebKit::WebPage::setViewState):

• merged with setViewStateInternal.

• WebProcess/WebPage/WebPage.h:
  • removed setViewStateInternal.

LayoutTests:

• fast/events/page-visibility-iframe-delete-test.html:
• fast/events/page-visibility-iframe-move-test.html:
  • resetPageVisibility will now cause additional visibiliy events to fire; clean up the event listeners to avoid this affecting the test results.

6:23 PM Changeset in webkit [163678] by Lucas Forschler

• 13 edits in tags/Safari-538.16.3

Merged r163674.

6:19 PM Changeset in webkit [163677] by Simon Fraser

• 6 edits in trunk/Source

Encode requestedScrollPosition on ScrollingStateScrollingNodes to send to the UI process
​https://bugs.webkit.org/show_bug.cgi?id=128416

Source/WebCore:

Reviewed by Tim Horton.

Change requestedScrollPosition() to be a FloatPoint, and export
ScrollingStateScrollingNode::setRequestedScrollPosition(WebCore::FloatPoint const&, bool)
for WK2.

• WebCore.exp.in:
• page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::setRequestedScrollPosition):

• page/scrolling/ScrollingStateScrollingNode.h:

Source/WebKit2:

Reviewed by Tim Horton.

Encode and decode requestedScrollPosition() and requestedScrollPositionRepresentsProgrammaticScroll(),
which can't use the macros because the setter takes both arguments.

The UI process needs this to notice programmatic scrolls.

• Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:

(ArgumentCoder<ScrollingStateScrollingNode>::encode):
(ArgumentCoder<ScrollingStateScrollingNode>::decode):

6:19 PM Changeset in webkit [163676] by Simon Fraser

• 7 edits in trunk/Source/WebKit2

Add typesafe casts for DrawingAreaProxy classes
​https://bugs.webkit.org/show_bug.cgi?id=128419

Reviewed by Andreas Kling.

Add typesafe casts, and use one in RemoteScrollingCoordinatorProxy::layerTreeHost().

• UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::layerTreeHost):

• UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
• UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::contentsSizeChanged):

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

6:12 PM Changeset in webkit [163675] by Beth Dakin

• 12 edits in trunk

Should get rid of TileController's CoverageForSlowScrolling mode
​https://bugs.webkit.org/show_bug.cgi?id=128339

Reviewed by Simon Fraser.

Source/WebCore:

This patch gets rid of CoverageForSlowScrolling in the TileController. It also
makes sure that margin tiles are properly invalidated on pages with slow repaint
objects that cause slow scrolling.

When we invalidate because of slow scrolling, don’t clip the update rect to the
layer bounds.

• page/FrameView.cpp:

(WebCore::FrameView::scrollContentsSlowPath):

Call new RenderObject paint function repaintSlowRepaintObject() instead of the
more-generic repaint().
(WebCore::FrameView::repaintSlowRepaintObjects):

Remove CoverageForSlowScrolling.

• platform/graphics/TiledBacking.h:
• platform/graphics/ca/mac/TileController.h:
• platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::tilesWouldChangeForVisibleRect):
(WebCore::TileController::computeTileCoverageRect):
(WebCore::TileController::revalidateTiles):

• rendering/RenderLayerBacking.cpp:

(WebCore::computeTileCoverage):

Handle repainting a slow repaint object. Don’t clip when we shouldn’t, use the
RenderView’s backgroundRect as a repaintRect when this is the root background
since that will take the extended background rect into consideration.

• rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintSlowRepaintObject):

• rendering/RenderObject.h:

LayoutTests:

Slow scrolling no longer creates tiles of a different size.

• platform/mac-wk2/tiled-drawing/fixed-background/fixed-non-propagated-body-background-expected.txt:
• platform/mac-wk2/tiled-drawing/tile-coverage-slow-scrolling-expected.txt:
• platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed-expected.txt:

6:11 PM Changeset in webkit [163674] by fpizlo@apple.com

• 13 edits in trunk

More FTL build scaffolding
​https://bugs.webkit.org/show_bug.cgi?id=128330

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:
• llvm/library/LLVMAnchor.cpp:

Source/WebCore:

The FTL already has tests.

• Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

• Configurations/FeatureDefines.xcconfig:

Source/WTF:

• wtf/Platform.h:

Tools:

• Scripts/copy-webkitlibraries-to-product-directory:

6:02 PM Changeset in webkit [163673] by timothy_horton@apple.com

• 4 edits in trunk/Source/WebKit2

Move allowsBackForwardNavigationGestures back to private because apparently our build systems are broken.

• UIProcess/API/Cocoa/WKView.h:
• UIProcess/API/Cocoa/WKViewPrivate.h:
• UIProcess/API/mac/WKView.mm:

(-[WKView setAllowsBackForwardNavigationGestures:]):
(-[WKView allowsBackForwardNavigationGestures]):

6:01 PM Changeset in webkit [163672] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

iOS port needs to clear VM::stackPointerAtVMEntry when it drops locks.
<​https://webkit.org/b/128424>

Reviewed by Geoffrey Garen.

The iOS code path for dropping locks differ from the non-iOS code path
in that it (iOS) does not clear m_vm->stackPointerAtVMEntry nor reset the
VM stack limit. This is now fixed by copying that snippit from
JSLock::unlock().

• runtime/JSLock.cpp:

(JSC::JSLock::dropAllLocks):
(JSC::JSLock::dropAllLocksUnconditionally):

5:57 PM Changeset in webkit [163671] by andersca@apple.com

• 9 edits in trunk/Source/WebKit2

Simplify web page creation
​https://bugs.webkit.org/show_bug.cgi?id=128425

Reviewed by Andreas Kling.

Add a WebPageConfiguration class and stick the page group, preferences, session etc there
instead of adding more and more parameters to the WebPageProxy constructor.

Make WebContext::createWebPage fill in the missing pieces in the WebPageConfiguration object.

• UIProcess/API/ios/WKContentView.mm:

(-[WKContentView initWithFrame:configuration:]):
(-[WKContentView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):

• UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

• UIProcess/WebContext.cpp:

(WebKit::WebContext::createWebPage):

• UIProcess/WebContext.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):

• UIProcess/WebPageProxy.h:
• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createWebPage):

• UIProcess/WebProcessProxy.h:

5:49 PM Changeset in webkit [163670] by timothy_horton@apple.com

• 2 edits in trunk/Tools

Touch Minibrowser for a hopeful build fix.

• MiniBrowser/mac/WK2BrowserWindowController.m:

5:25 PM Changeset in webkit [163669] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

Build fix. Wrong section of the file.

• UIProcess/API/mac/WKView.mm:

(-[WKView setAllowsBackForwardNavigationGestures:]):
(-[WKView allowsBackForwardNavigationGestures]):

5:10 PM Changeset in webkit [163668] by benjamin@webkit.org

• 2 edits in trunk/Source/WebKit2

[WK2] The WebPageProxy's copy of pageScaleFactor is not update when the scale is changed from the viewport configuration
​https://bugs.webkit.org/show_bug.cgi?id=128415

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-02-07
Reviewed by Simon Fraser.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::viewportConfigurationChanged):
The scale needs to be updated through WebPage::scalePage().

5:09 PM Changeset in webkit [163667] by ap@apple.com

• 3 edits in trunk/Source/WebCore

Remove some unused functions from SerializedScriptValue
​https://bugs.webkit.org/show_bug.cgi?id=128407

Reviewed by Anders Carlsson.

• bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::nullValue):

• bindings/js/SerializedScriptValue.h:

4:58 PM Changeset in webkit [163666] by timothy_horton@apple.com

• 18 edits
  1 add in trunk/Source/WebKit2

WebKit2 View Gestures (Swipe): Support for iOS
​https://bugs.webkit.org/show_bug.cgi?id=128363
<rdar://problem/15194194>

Reviewed by Anders Carlsson.

• Shared/mac/RemoteLayerTreeTransaction.h:

(WebKit::RemoteLayerTreeTransaction::renderTreeSize):
(WebKit::RemoteLayerTreeTransaction::setRenderTreeSize):

• Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):

• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
Send the render tree size along with remote layer tree commits,
so that we can act upon it (to hide snapshots) in the UI process
in sync with layer commits.

• UIProcess/API/Cocoa/WKViewPrivate.h:

We want allowsBackForwardNavigationGestures for both platforms.

• UIProcess/API/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::takeViewSnapshot):

• UIProcess/API/ios/WKContentView.h:
• UIProcess/API/ios/WKContentView.mm:

(-[WKContentView _takeViewSnapshot]):

• UIProcess/API/ios/WKContentViewInternal.h:

Plumb snapshotting through to WKViewIOS.

• UIProcess/API/ios/WKViewIOS.mm:

(-[WKView setAllowsBackForwardNavigationGestures:]):
(-[WKView allowsBackForwardNavigationGestures]):
Create/destroy the gesture controller when we turn on/off back-forward swipe.
Tell WebPageProxy to save snapshots if swipe is enabled.

(-[WKView contentView:didCommitLayerTree:]):
Forward the current transaction's render tree size to ViewGestureController.

(-[WKView takeViewSnapshotForContentView:]):
Snapshot the view. This is not the best SPI to use, we should consider
using one of those which returns an IOSurface and plumbing it through
to ViewSnapshotStore, but all of our PageClient abstraction makes that annoying.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::recordNavigationSnapshot):
Record snapshots on iOS as well.

• UIProcess/ios/ViewGestureControllerIOS.mm: Added.

(-[WKSwipeInteractiveTransitionDelegate initWithViewGestureController:WebKit::swipingView:]):
(-[WKSwipeInteractiveTransitionDelegate WebKit::ViewGestureController::directionForTransition:]):
(-[WKSwipeInteractiveTransitionDelegate startInteractiveTransition:]):
(-[WKSwipeInteractiveTransitionDelegate shouldBeginInteractiveTransition:]):
(-[WKSwipeInteractiveTransitionDelegate interactiveTransition:gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKSwipeInteractiveTransitionDelegate interactiveTransition:gestureRecognizer:shouldReceiveTouch:]):
(-[WKSwipeInteractiveTransitionDelegate gestureRecognizerForInteractiveTransition:WithTarget:action:]):
(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::~ViewGestureController):
(WebKit::ViewGestureController::installSwipeHandler):
(WebKit::ViewGestureController::beginSwipeGesture):
(WebKit::ViewGestureController::canSwipeInDirection):
(WebKit::ViewGestureController::endSwipeGesture):
(WebKit::ViewGestureController::setRenderTreeSize):
(WebKit::ViewGestureController::swipeSnapshotWatchdogTimerFired):
(WebKit::ViewGestureController::removeSwipeSnapshot):

• UIProcess/mac/ViewGestureController.h:

Add iOS-specific methods, and don't include all of the Mac-specific code.
We can move towards sharing more logic in the future.

• UIProcess/mac/ViewGestureController.messages.in:
• UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::ViewGestureController):

• UIProcess/mac/ViewSnapshotStore.h:
• UIProcess/mac/ViewSnapshotStore.mm:

(WebKit::ViewSnapshotStore::recordSnapshot):
(WebKit::ViewSnapshotStore::snapshotAndRenderTreeSize):
Make ViewSnapshotStore build/work without IOSurface.

• WebKit2.xcodeproj/project.pbxproj:

4:55 PM Changeset in webkit [163665] by mark.lam@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Removed superflous JSLock::entryStackPointer field.
<​https://webkit.org/b/128413>

Reviewed by Geoffrey Garen.

• runtime/JSLock.cpp:

(JSC::JSLock::lock):

• runtime/JSLock.h:

4:46 PM Changeset in webkit [163664] by mark.lam@apple.com

• 5 edits in trunk/Source/JavaScriptCore

Revert workaround committed in ​http://trac.webkit.org/r163595.
<​https://webkit.org/b/128408>

Reviewed by Geoffrey Garen.

Now that we have fixed the bugs in JSLock's stack limit adjusments
in ​https://bugs.webkit.org/show_bug.cgi?id=128406, we can revert the
workaround in r163595.

• API/JSContextRef.cpp:

(JSContextGroupCreate):
(JSGlobalContextCreateInGroup):

• API/tests/testapi.js:
• runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::updateStackLimitWithReservedZoneSize):

• runtime/VM.h:

4:37 PM Changeset in webkit [163663] by andersca@apple.com

• 6 edits
  1 copy in trunk/Source/WebKit2

Implement more of WKPreferences
​https://bugs.webkit.org/show_bug.cgi?id=128411

Reviewed by Tim Horton.

Give WKPreferences an underlying WebKit::WebPreferences object, add a minimumFontSize preference
and make sure that WKWebView's initializer creates a WKPreferences object if the configuration doesn't specify one.

• UIProcess/API/Cocoa/WKPreferences.h:
• UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences init]):
(-[WKPreferences minimumFontSize]):
(-[WKPreferences setMinimumFontSize:]):

• UIProcess/API/Cocoa/WKPreferencesInternal.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm.
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):

• UIProcess/WebPageProxy.h:
• WebKit2.xcodeproj/project.pbxproj:

4:30 PM Changeset in webkit [163662] by beidson@apple.com

• 21 edits in trunk

IDB: Some Mozilla cursor mutation tests fail
<rdar://problem/16011680> and ​https://bugs.webkit.org/show_bug.cgi?id=128374

Reviewed by Sam Weinig.

Source/WebCore:

Tested by:
storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html
storage/indexeddb/mozilla/cursor-mutation.html

The previous comment about LevelDB was wrong.
Apparently calling onSuccess() with a null SharedBuffer means the cursor reached the end.
Update to distinguish between an error and reaching the end:

• Modules/indexeddb/IDBCursorBackendOperations.cpp:

(WebCore::CursorAdvanceOperation::perform):
(WebCore::CursorIterationOperation::perform):

Add a new IDBKey type - Maximum - To be used in comparisons between keys.
This will allow the DatabaseProcess to operate on the range of all keys:

• Modules/indexeddb/IDBKey.cpp:

(WebCore::IDBKey::compare):

• Modules/indexeddb/IDBKey.h:

• Modules/indexeddb/IDBKeyData.cpp:

(WebCore::IDBKeyData::IDBKeyData):
(WebCore::IDBKeyData::maybeCreateIDBKey):
(WebCore::IDBKeyData::isolatedCopy):
(WebCore::IDBKeyData::encode):
(WebCore::IDBKeyData::decode):
(WebCore::IDBKeyData::compare):
(WebCore::IDBKeyData::loggingString):

• Modules/indexeddb/IDBKeyData.h:

(WebCore::IDBKeyData::minimum):
(WebCore::IDBKeyData::maximum):

• bindings/js/IDBBindingUtilities.cpp:

(WebCore::idbKeyToJSValue):

Remove an unused callback:

• Modules/indexeddb/IDBCallbacks.h:
• Modules/indexeddb/IDBRequest.h:

Source/WebKit2:

After a SQLite statement is prepared, stepping it will not pick up any subsequent changes
to the object store.

By keeping track of the current record we’re looking at in the object store and being told
that the object store changed its contents, we can reset the statement to pick up where it
left off but with the new object store contents.

• DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::putRecordInBackingStore): Tell the backing store to notify

its cursors that the object store changed its records.

(WebKit::UniqueIDBDatabase::deleteRangeInBackingStore): Ditto.

• DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
• DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::notifyCursorsOfChanges): Tell the transaction

to notify its cursors that the object store changed its records.

• DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:

• DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.cpp:

(WebKit::SQLiteIDBTransaction::notifyCursorsOfChanges): Tell the relevant cursors that their

object store changed its records.

• DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.h:

• DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:

(WebKit::SQLiteIDBCursor::SQLiteIDBCursor):
(WebKit::getIndexStatement): All statements now have a lower and upper range. By default we bind

IDBKey::Minimum to the lower range and IDBKey::Maximum to the upper range.

(WebKit::getObjectStoreStatement): Ditto.
(WebKit::SQLiteIDBCursor::establishStatement):
(WebKit::SQLiteIDBCursor::createSQLiteStatement):
(WebKit::SQLiteIDBCursor::objectStoreRecordsChanged): Set the flag indicating the statement

needs to be reset and rebound.

(WebKit::SQLiteIDBCursor::resetAndRebindStatement):
(WebKit::SQLiteIDBCursor::bindArguments): Factored out to be shared between statement prepare()

and statement reset().

(WebKit::SQLiteIDBCursor::advance):
(WebKit::SQLiteIDBCursor::advanceOnce): If the statement needs to be reset, do so before advancing it.
(WebKit::SQLiteIDBCursor::internalAdvanceOnce): In a few cases, tell advanceOnce that it needs to

try again because it is on a missing record or is repeating a record.

• DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.h:

(WebKit::SQLiteIDBCursor::objectStoreID):

Make sure Maximum and Minimum keys are never sent across IPC, as that doesn’t make sense:

• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<IDBKeyData>::encode):
(IPC::ArgumentCoder<IDBKeyData>::decode):

LayoutTests:

• platform/mac-wk2/TestExpectations: Add two tests that now pass.

4:24 PM Changeset in webkit [163661] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Fix bug in stack limit adjustments in JSLock.
<​https://webkit.org/b/128406>

Reviewed by Geoffrey Garen.

1. JSLock::unlock() was only clearing the VM::stackPointerAtEntry when m_vm->stackPointerAtVMEntry == entryStackPointer. FYI, entryStackPointer is a field in JSLock.

When DropAllLocks::~DropAllLocks() will call JSLock::grabAllLocks()
to relock the JSLock, JSLock::grabAllLocks() will set a new
entryStackPointer value. Thereafter, DropAllLocks::~DropAllLocks() will
restore the saved VM::stackPointerAtEntry, which will now defer from
the JSLock's entryStackPointer value.

It turns out that when m_vm->stackPointerAtVMEntry was initialized,
it was set to whatever value entryStackPointer is set to. At no time
do we ever expect the 2 values to differ. The only time it differs is
when this bug manifests.

The fix is to remove the entryStackPointer field in JSLock and its uses
altogether.

2. DropAllLocks was unconditionally clearing VM::stackPointerAtEntry in its constructor instead of letting JSLock::unlock() do the clearing.

However, DropAllLocks will not actually drop locks if it isn't required
to (e.g. when alwaysDropLocks is DontAlwaysDropLocks), and when we've
already drop locks once (i.e. JSLock::m_lockDropDepth is not 0).

We should not have cleared VM::stackPointerAtEntry here if we don't
actually drop the locks.

• runtime/JSLock.cpp:

(JSC::JSLock::unlock):
(JSC::JSLock::DropAllLocks::DropAllLocks):

4:19 PM Changeset in webkit [163660] by mitz@apple.com

• 2 edits in trunk/Source/WebKit/mac

iOS build fix.

• Misc/WebElementDictionary.mm:

(+[WebElementDictionary initializeLookupTable]):
(-[WebElementDictionary _image]):
(-[WebElementDictionary _imageRect]):

4:16 PM Changeset in webkit [163659] by roger_fong@apple.com

• 2 edits in trunk/Source/WebCore

CGContextGetUserSpaceToDeviceSpaceTransform returns the wrong value on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=128395.

Rubberstamped by Zalan Bujtas.

The call essentially returns 0 and causes an assertion failure when running many layout tests.

• platform/graphics/cg/GraphicsContextCG.cpp: Don't make the call on Windows. We default to 1.

(WebCore::GraphicsContext::platformInit):

4:07 PM Changeset in webkit [163658] by mitz@apple.com

• 2 edits in trunk/Source/WebCore

iOS build fix.

• platform/PlatformKeyboardEvent.h: Fixed a typo.

3:37 PM Changeset in webkit [163657] by mitz@apple.com

• 104 edits in trunk/Source/WebCore

Stop using PLATFORM(MAC) in WebCore/platform except where it means “OS X but not iOS”
​https://bugs.webkit.org/show_bug.cgi?id=128404

Reviewed by Anders Carlsson.

• Configurations/WebCore.xcconfig: Removed KeyEventMac.mm from

EXCLUDED_SOURCE_FILE_NAMES_iphoneos, because that file contains !PLATFORM(IOS) guards.
Removed WheelEventMac.mm from the same definition, because that file no longer exists.

• platform/ContentFilter.h: Changed PLATFORM(MAC) to PLATFORM(COCOA).
• platform/ContextMenu.h: Ditto.
• platform/ContextMenuItem.h: Ditto.
• platform/Cursor.cpp: Ditto.
• platform/Cursor.h: Ditto.
• platform/DragData.cpp: Ditto.
• platform/DragImage.cpp: Ditto.
• platform/Language.cpp:

(WebCore::displayNameForLanguageLocale): Changed PLATFORM(MAC) to USE(CF) && !PLATFORM(WIN).

• platform/LocalizedStrings.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).

(WebCore::contextMenuItemTagSearchWeb):

• platform/LocalizedStrings.h: Ditto.
• platform/MIMETypeRegistry.cpp: Ditto.

(WebCore::initializeSupportedImageMIMETypesForEncoding):

• platform/PasteboardStrategy.h: Ditto.
• platform/PlatformKeyboardEvent.h: Ditto.
• platform/PlatformMenuDescription.h: Ditto.
• platform/PlatformSpeechSynthesizer.h: Ditto.
• platform/PlatformWheelEvent.h: Ditto.

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

• platform/SchemeRegistry.cpp: Ditto.

(WebCore::localURLSchemes):
(WebCore::SchemeRegistry::removeURLSchemeRegisteredAsLocal):
(WebCore::SchemeRegistry::shouldCacheResponsesFromURLSchemeIndefinitely):

• platform/ScrollAnimator.cpp: Ditto.

(WebCore::ScrollAnimator::handleWheelEvent):

• platform/ScrollAnimator.h: Ditto.
• platform/ScrollView.cpp: Ditto.
• platform/ScrollView.h: Ditto.
• platform/ScrollbarThemeComposite.h: Ditto.
• platform/SharedBuffer.h: Changed PLATFORM(MAC) to USE(FOUNDATION) around NSData-related

code.

• platform/URL.h: Changed PLATFORM(MAC) to USE(FOUNDATION) around NSURL-related code.
• platform/Widget.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
• platform/Widget.h: Ditto.
• platform/audio/AudioSession.cpp: Changed !PLATFORM(MAC) && !PLATFORM(IOS) to

!PLATFORM(COCOA).

• platform/audio/HRTFElevation.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
• platform/audio/MediaSessionManager.cpp: Ditto.
• platform/audio/mac/AudioSessionMac.cpp: Updated comment.
• platform/audio/mac/MediaSessionManagerMac.cpp: Removed PLATFORM(MAC) from Cocoa-only file.
• platform/cf/SharedBufferCF.cpp: Changed !PLATFORM(MAC) to !USE(FOUNDATION) and updated

comment.

• platform/cf/URLCF.cpp: Changed !PLATFORM(MAC) to !USE(FOUNDATION).
• platform/graphics/BitmapImage.h: Changed one instance of PLATFORM(MAC) to

USE(CG)

USE(APPKIT), and another to PLATFORM(COCOA).

• platform/graphics/DisplayRefreshMonitor.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).

(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):

• platform/graphics/DisplayRefreshMonitor.h: Ditto.
• platform/graphics/FloatPoint.h: Collapsed nested #ifs into a single #if.
• platform/graphics/FloatRect.h: Ditto.
• platform/graphics/FloatSize.h: Ditto.
• platform/graphics/Font.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
• platform/graphics/Font.h: Ditto.
• platform/graphics/FontCache.cpp: Ditto.

(WebCore::FontCache::getFontData):

• platform/graphics/FontCache.h: Ditto. Also removed redundant friend class declaration.
• platform/graphics/FontGlyphs.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).

(WebCore::FontGlyphs::glyphDataAndPageForCharacter):

• platform/graphics/GlyphPage.h: Ditto.
• platform/graphics/GraphicsContext3D.h: Ditto.
• platform/graphics/Image.h: Changed PLATFORM(MAC) to USE(APPKIT) around use of NSImage.

Changed another PLATFORM(MAC) to PLATFORM(COCOA).

• platform/graphics/IntRect.h: Collapsed nested #ifs into a single #if.
• platform/graphics/IntSize.h: Ditto.
• platform/graphics/MediaPlayer.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).

(WebCore::installedMediaEngines):
(WebCore::MediaPlayer::supportsType):

• platform/graphics/SimpleFontData.cpp: Ditto.

(WebCore::SimpleFontData::nonSyntheticItalicFontData):
(WebCore::SimpleFontData::DerivedFontData::~DerivedFontData):

• platform/graphics/SimpleFontData.h: Ditto.
• platform/graphics/TiledBacking.h: Ditto.
• platform/graphics/ca/GraphicsLayerCA.cpp: Ditto.

(WebCore::GraphicsLayerCA::filtersCanBeComposited):
(WebCore::GraphicsLayerCA::createPlatformCALayer):

• platform/graphics/ca/LayerFlushScheduler.h: Ditto.
• platform/graphics/ca/PlatformCAAnimation.h: Ditto.
• platform/graphics/ca/PlatformCAFilters.h: Ditto.
• platform/graphics/ca/PlatformCALayer.h: Ditto.
• platform/graphics/cg/BitmapImageCG.cpp: Ditto.
• platform/graphics/cg/GraphicsContextCG.cpp: Ditto.

(WebCore::GraphicsContext::setAllowsFontSmoothing):

• platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: Ditto.
• platform/graphics/cg/ImageBufferCG.cpp: Ditto.
• platform/graphics/cg/ImageBufferDataCG.h: Ditto.
• platform/graphics/cg/ImageCG.cpp: Ditto.
• platform/graphics/cg/ImageSourceCG.cpp: Ditto.

(WebCore::ImageSource::setData):

• platform/graphics/cg/ImageSourceCG.h: Ditto.
• platform/graphics/cg/PathCG.cpp: Ditto.

(WebCore::Path::platformAddPathForRoundedRect):

• platform/graphics/cg/PatternCG.cpp: Ditto.
• platform/graphics/gpu/DrawingBuffer.h: Ditto.
• platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::createQTMovieView): Removed PLATFORM(MAC) guards, since
this file is only used on Mac and iOS.

• platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::supportsExtension): Changed the GL_EXT_draw_buffers check to
match the implementation.

• platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: Changed PLATFORM(MAC) to

PLATFORM(COCOA).

• platform/mac/KeyEventMac.mm: Added !PLATFORM(IOS).
• platform/mac/PlatformEventFactoryMac.h: Changed PLATFORM(MAC) to PLATFORM(COCOA).
• platform/mac/WebCoreSystemInterface.h: Ditto. Removed redundant check for PLATFORM(MAC).
• platform/mac/WebCoreSystemInterface.mm: Removed redundant check for PLATFORM(MAC).

platform/network/Credential.h: Changed PLATFORM(IOS)

PLATFORM(MAC) to PLATFORM(COCOA).

• platform/network/NetworkStateNotifier.h: Changed PLATFORM(MAC) to PLATFORM(COCOA).
• platform/network/NetworkStorageSession.h: Ditto.
• platform/network/NetworkingContext.h: Ditto.
• platform/network/ProtectionSpace.cpp: Ditto.

(WebCore::ProtectionSpace::receivesCredentialSecurely):

• platform/network/ResourceHandle.cpp: Ditto.

(WebCore::ResourceHandle::clearAuthentication):
(WebCore::ResourceHandle::shouldContentSniffURL):

• platform/network/ResourceHandle.h: Ditto.
• platform/network/ResourceHandleClient.cpp: Ditto.
• platform/network/ResourceHandleClient.h: Ditto.
• platform/network/ResourceHandleInternal.h: Ditto.

(WebCore::ResourceHandleInternal::ResourceHandleInternal):

• platform/network/ResourceRequestBase.cpp: Ditto.
• platform/network/cf/AuthenticationCF.h: Ditto.
• platform/network/cf/CookieStorageCFNet.cpp: Ditto.
• platform/network/cf/CredentialStorageCFNet.cpp: Ditto.
• platform/network/cf/FormDataStreamCFNet.cpp: Ditto.
• platform/network/cf/NetworkStorageSessionCFNet.cpp: Ditto.

(WebCore::NetworkStorageSession::switchToNewTestingSession):
(WebCore::NetworkStorageSession::createPrivateBrowsingSession):

• platform/network/cf/ResourceError.h: Ditto.
• platform/network/cf/ResourceHandleCFNet.cpp: Ditto.

(WebCore::ResourceHandle::createCFURLConnection):

• platform/network/cf/ResourceHandleCFURLConnectionDelegate.cpp:
• platform/network/cf/ResourceRequest.h: Ditto.

(WebCore::ResourceRequest::ResourceRequest):

• platform/network/cf/ResourceRequestCFNet.cpp: Ditto.

(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
(WebCore::ResourceRequest::setStorageSession):

• platform/network/cf/ResourceResponse.h: Ditto.
• platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp:

(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveResponse):

• platform/network/mac/ResourceResponseMac.mm: Ditto.
• platform/posix/FileSystemPOSIX.cpp: Changed PLATFORM(MAC) to OS(DARWIN) &&

!PLATFORM(EFL) && !PLATFORM(GTK).

• platform/text/TextBoundaries.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).

3:26 PM Changeset in webkit [163656] by andersca@apple.com

• 9 edits in trunk/Source/WebKit2

Make it possible for each web page to have different preferences
​https://bugs.webkit.org/show_bug.cgi?id=128403

Reviewed by Tim Horton.

• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesCreate):

• UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureNetworkProcess):
(WebKit::WebContext::createNewWebProcess):

• UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::setDatabasePath):

• UIProcess/WebPageGroup.cpp:

(WebKit::WebPageGroup::WebPageGroup):
(WebKit::WebPageGroup::~WebPageGroup):
(WebKit::WebPageGroup::setPreferences):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::~WebPageProxy):
(WebKit::WebPageProxy::setPreferences):
(WebKit::WebPageProxy::preferencesDidChange):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::~WebPreferences):
(WebKit::WebPreferences::addPage):
(WebKit::WebPreferences::removePage):
(WebKit::WebPreferences::update):
(WebKit::WebPreferences::updatePrivateBrowsingValue):
(WebKit::WebPreferences::anyPagesAreUsingPrivateBrowsing):

• UIProcess/WebPreferences.h:

3:07 PM Changeset in webkit [163655] by rniwa@webkit.org

• 7 edits
  3 deletes in trunk

Revert r154384 and r154674 as they broke selection rect computations for text with ligatures.

Source/WebCore:

• platform/graphics/Font.cpp:

(WebCore::Font::drawText):
(WebCore::Font::drawEmphasisMarks):
(WebCore::Font::selectionRectForText):
(WebCore::Font::offsetForPosition):

• platform/graphics/FontFastPath.cpp:

(WebCore::Font::getGlyphsAndAdvancesForSimpleText):
(WebCore::Font::selectionRectForSimpleText):
(WebCore::Font::offsetForPositionForSimpleText):

• platform/graphics/GlyphBuffer.h:
• platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator):
(WebCore::WidthIterator::advanceInternal):
(WebCore::WidthIterator::advanceOneCharacter):

• platform/graphics/WidthIterator.h:

LayoutTests:

• fast/text/partial-textruns-expected.html: Removed.
• fast/text/partial-textruns.html: Removed.
• fast/text/resources/PTS55F-webfont.ttf: Removed.

3:03 PM Changeset in webkit [163654] by benjamin@webkit.org

• 10 edits in trunk/Source

[WK2] Add support for text document viewport configuration
​https://bugs.webkit.org/show_bug.cgi?id=128359

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-02-07
Reviewed by Simon Fraser.

Source/WebCore:

Define a set of ViewportParameters suitable for displaying text documents.
Add a documents class for text document to differentiate them from other type of documents.

• WebCore.exp.in:
• dom/Document.h:

(WebCore::Document::isTextDocument):

• html/TextDocument.cpp:

(WebCore::TextDocument::TextDocument):

• page/ViewportConfiguration.cpp:

(WebCore::ViewportConfiguration::ViewportConfiguration):
(WebCore::ViewportConfiguration::webpageParameters):
(WebCore::ViewportConfiguration::plainTextParameters):

• page/ViewportConfiguration.h:

Source/WebKit2:

When a text document is being loaded, use the plainText viewport parameters.

• UIProcess/API/ios/WKContentView.h:
• UIProcess/API/ios/WKContentView.mm:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didCommitLoad):

3:02 PM Changeset in webkit [163653] by Lucas Forschler

• 2 edits in tags/Safari-538.16.3/Source/JavaScriptCore

Merged r163342.

3:01 PM Changeset in webkit [163652] by Lucas Forschler

• 5 edits in tags/Safari-538.16.3/Source

Versioning.

3:01 PM Changeset in webkit [163651] by Bem Jones-Bey

• 2 edits in trunk/Source/WebCore

FloatingObject::unsafeClone should not copy m_originatingLine
​https://bugs.webkit.org/show_bug.cgi?id=128381

Reviewed by Andreas Kling.

Copying the originatingLine allows to break the invariant that the
floating object must only contain lines that are owned by the renderer
it is attached to.

• rendering/FloatingObjects.cpp:

(WebCore::FloatingObject::unsafeClone):

2:56 PM Changeset in webkit [163650] by Lucas Forschler

• 1 copy in tags/Safari-538.16.3

New Tag.

2:32 PM Changeset in webkit [163649] by b.long@cablelabs.com

• 41 edits
  3 copies
  2 moves
  2 adds in trunk

Update TextTrack API to current spec
​https://bugs.webkit.org/show_bug.cgi?id=122218

Refactoring VTTCue out of TextTrackCue.

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/track-vttcue.html

• CMakeLists.txt: Add VTTCue and rename RenderTextTrackCue to RenderVTTCue.
• DerivedSources.cpp: Same.
• DerivedSources.make: Same.
• GNUmakefile.list.am: Same.
• PlatformGTK.cmake: Same.
• WebCore.vcxproj/WebCore.vcxproj: Same.
• WebCore.vcxproj/WebCore.vcxproj.filters: Same.
• WebCore.xcodeproj/project.pbxproj: Same.
• bindings/js/JSTextTrackCueCustom.cpp:

(WebCore::toJS): Use VTTCue DOM wrapper for VTTCue and its subclasses.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Convert to VTTCue as needed.
(WebCore::HTMLMediaElement::textTrackRemoveCue): Same.

• html/HTMLMediaElement.h: Only print cue.text in debug output if the cue type has a .text attribute
• html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Convert to VTTCue as needed, and fix TextTrackCueBox to VTTCueBox.
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired): Convert to VTTCue as needed.

• html/track/InbandGenericTextTrack.cpp:

(WebCore::InbandGenericTextTrack::addGenericCue): Use refactored VTTCue attributes.

• html/track/InbandWebVTTTextTrack.cpp:

(WebCore::InbandWebVTTTextTrack::newCuesParsed): Use VTTCue's constructor instead of deprecated TextTrackCue constructor.

• html/track/TextTrack.cpp:

(WebCore::TextTrack::setMode): Convert to VTTCue as needed.
(WebCore::TextTrack::hasCue): Make this function only accept VTTCues, since it's only used for them anyway, and convert existing cues to VTTCues as needed.

• html/track/TextTrack.h: Same as hasCue above.
• html/track/TextTrackCue.cpp: Refactor a lot of code out. Everything that was removed went to VTTCue.cpp.

(WebCore::TextTrackCue::create): For backwards compatibility, just call VTTCue::create().
(WebCore::TextTrackCue::TextTrackCue): Refactor a lot of code out.
(WebCore::TextTrackCue::~TextTrackCue): Same.
(WebCore::TextTrackCue::didChange): Same.
(WebCore::TextTrackCue::setIsActive): Same.

• html/track/TextTrackCue.h: Same.
• html/track/TextTrackCue.idl: Remove VTTCue attributes and add custom toJS function.
• html/track/TextTrackCueGeneric.cpp: Use VTTCue instead of TextTrackCue.
• html/track/TextTrackCueGeneric.h: Same.
• html/track/VTTCue.cpp: Copied from Source/WebCore/html/track/TextTrackCue.cpp.
• html/track/VTTCue.h: Copied from Source/WebCore/html/track/TextTrackCue.h.
• html/track/VTTCue.idl: Copied from Source/WebCore/html/track/TextTrackCue.idl.
• loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::getNewCues): Use VTTCue instead of TextTrackCue.

• page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::captionsStyleSheetOverride): Use VTTCueBox instead of TextTrackCueBox.

• rendering/RenderVTTCue.cpp: Renamed from Source/WebCore/rendering/RenderTextTrackCue.cpp. Changed to use VTTCue instead of TextTrackCue.
• rendering/RenderVTTCue.h: Renamed from Source/WebCore/rendering/RenderTextTrackCue.h. Changed to use VTTCue instead of TextTrackCue.
• rendering/RenderingAllInOne.cpp: Rename RenderTextTrackCue to RenderVTTCue.

LayoutTests:

• js/dom/constructor-length.html: Add VTTCue constructor.
• platform/efl/js/dom/global-constructors-attributes-expected.txt: Same.
• platform/efl/js/dom/constructor-length-expected.txt: Same.
• js/dom/global-constructors-attributes-expected.txt: Same.
• platform/gtk-wk2/js/dom/constructor-length-expected.txt: Same.
• platform/gtk-wk2/js/dom/global-constructors-attributes-expected.txt: Same.
• platform/gtk/js/dom/constructor-length-expected.txt: Same.
• platform/gtk/js/dom/global-constructors-attributes-expected.txt: Same.
• platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt: Same.
• platform/mac/js/dom/constructor-length-expected.txt: Same.
• platform/mac/js/dom/global-constructors-attributes-expected.txt: Same.
• platform/win/js/dom/global-constructors-attributes-expected.txt: Same.
• media/track/track-cues-cuechange-expected.txt: Cues are of type VTTCue now.
• media/track/track-cues-enter-exit-expected.txt: Same.
• media/track/track-vttcue-expected.txt: Test VTTCue interface.
• media/track/track-vttcue.html: Same.
• media/video-test.js:

(testExpected): Add "instanceof" as a valid operator.

2:31 PM Changeset in webkit [163648] by commit-queue@webkit.org

• 5 edits in trunk/Source/JavaScriptCore

[iOS] Eliminate race between XPC connection queue and Notification queue
​https://bugs.webkit.org/show_bug.cgi?id=128384

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-02-07
Reviewed by Timothy Hatcher.

• inspector/remote/RemoteInspector.h:
• inspector/remote/RemoteInspector.mm:

(Inspector::RemoteInspector::RemoteInspector):
(Inspector::RemoteInspector::start):
(Inspector::RemoteInspector::setupXPCConnectionIfNeeded):
Create the queue to use for RemoteInspector xpc connection
management and the connection itself.

• inspector/remote/RemoteInspectorXPCConnection.h:
• inspector/remote/RemoteInspectorXPCConnection.mm:

(Inspector::RemoteInspectorXPCConnection::RemoteInspectorXPCConnection):
Use the passed in queue instead of creating one for itself.

2:27 PM Changeset in webkit [163647] by barraclough@apple.com

• 5 edits in trunk/Source

Should report user input to PageThrottler
​https://bugs.webkit.org/show_bug.cgi?id=128398

Reviewed by Tim Horton.

Make sure we wake from AppNap if there is user interaction.

Source/WebCore:

• page/PageThrottler.h:

(WebCore::PageThrottler::didReceiveUserInput):
(WebCore::PageThrottler::pluginDidEvaluate):

• added, these call reportInterestingEvent()

Source/WebKit2:

• WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::evaluate):

• reportInterestingEvent() -> pluginDidEvaluate()

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::wheelEvent):
(WebKit::WebPage::keyEvent):

• call didReceiveUserInput()

2:12 PM Changeset in webkit [163646] by dino@apple.com

• 3 edits in trunk/Source/WebKit2

WebGL doesn't update with remotely hosted layers
​https://bugs.webkit.org/show_bug.cgi?id=128390

Reviewed by Simon Fraser.

PlatformCALayerRemote was intercepting the setNeedsDisplay calls to
WebGL layers, and thus causing them to not draw. Fix this by adding an
override in PlatformCALayerRemoteCustom to check if it is a WebGLLayer
and call setNeedsDisplay directly.

• WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:
• WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:

(PlatformCALayerRemoteCustom::PlatformCALayerRemoteCustom):
(PlatformCALayerRemoteCustom::setNeedsDisplay):

2:01 PM Changeset in webkit [163645] by benjamin@webkit.org

• 3 edits in trunk/Source/WebKit2

[WK2] Fitler touch events only based on touch start
​https://bugs.webkit.org/show_bug.cgi?id=128354

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-02-07
Reviewed by Simon Fraser.

Touch Events track their target, we should not test the touch regions
again after a touch sequence starts.

This patch adds a boolean flag to know if we are sending events to the WebProcess
(m_isTrackingTouchEvents). The flag is updated every time a touch sequence starts.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::shouldStartTrackingTouchEvents):
(WebKit::WebPageProxy::handleTouchEvent):

• UIProcess/WebPageProxy.h:

1:42 PM Changeset in webkit [163644] by andersca@apple.com

• 3 edits in trunk/Source/WebKit2

Simplify WebPreferences creation inside WebPageGroup
​https://bugs.webkit.org/show_bug.cgi?id=128392

Reviewed by Andreas Kling.

Always create a WebPreferences object when creating the web page group.
This is another step towards letting WebPageProxy manage web preferences.

• UIProcess/WebPageGroup.cpp:

(WebKit::pageGroupData):
(WebKit::WebPageGroup::WebPageGroup):
(WebKit::WebPageGroup::~WebPageGroup):
(WebKit::WebPageGroup::setPreferences):
(WebKit::WebPageGroup::preferences):

• UIProcess/WebPageGroup.h:

1:39 PM Changeset in webkit [163643] by barraclough@apple.com

• 2 edits in trunk/Source/WebKit2

Reenable AppNap
​https://bugs.webkit.org/show_bug.cgi?id=128394

Reviewed by Tim Horton.

• Shared/WebPreferencesStore.h:
  • pageVisibilityBasedProcessSuppressionEnabled shoud default to true.

1:23 PM Changeset in webkit [163642] by k.czech@samsung.com

• 2 edits in trunk/Tools

Build fix after r163632

Unreviewed EFL build fix

Added empty stub to WKTR to not break EFL build.

• WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::selectTextWithCriteria):

1:17 PM Changeset in webkit [163641] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

Unreviewed build fix for 32-bit iOS.

Use magic ? values to allow the exported symbol to be different on 32- and 64-bit builds.

• WebCore.exp.in:

12:14 PM Changeset in webkit [163640] by timothy_horton@apple.com

• 2 edits
  1 move in trunk/Source/WebKit2

Rename ViewGestureController.mm to ViewGestureControllerMac.mm
​https://bugs.webkit.org/show_bug.cgi?id=128387

Reviewed by Anders Carlsson.

As a precursor to having a second nearly completely divergent
ViewGestureController implementation for iOS.

• UIProcess/mac/ViewGestureControllerMac.mm: Renamed from Source/WebKit2/UIProcess/mac/ViewGestureController.mm.
• WebKit2.xcodeproj/project.pbxproj:

Rename ViewGestureController.mm to ViewGestureControllerMac.mm.
Unfortunately, since we're not renaming the class, the header
has to keep its name (and will be the recipient of a giant #if in a later
patch), because the message receiver generated code will try to import
ViewGestureController.h (without the Mac suffix).

11:59 AM Changeset in webkit [163639] by oliver@apple.com

• 2 edits in trunk/Source/JavaScriptCore

REGRESSION (r160628): LLint does not appear to handle impure get own property properly
​https://bugs.webkit.org/show_bug.cgi?id=127943

Reviewed by Filip Pizlo.

Make sure the LLINT doesn't attempt to cache property
access on structures with impureGetOwnPropertySlot set.

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

11:57 AM Changeset in webkit [163638] by andersca@apple.com

• 3 edits in trunk/Source/WebCore

Convert ProgressTracker to std::chrono
​https://bugs.webkit.org/show_bug.cgi?id=128377

Reviewed by Andreas Kling.

• loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::ProgressTracker):
(WebCore::ProgressTracker::reset):
(WebCore::ProgressTracker::progressStarted):
(WebCore::ProgressTracker::finalProgressComplete):
(WebCore::ProgressTracker::incrementProgress):

• loader/ProgressTracker.h:

11:49 AM Changeset in webkit [163637] by BJ Burg

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Clean up DataGrid and add table columns incrementally
​https://bugs.webkit.org/show_bug.cgi?id=128332

Reviewed by Timothy Hatcher.

Miscellaneous improvements to DataGrid to make it more maintainable.
In particular, it now uses a Map to store column settings, and the
construction sequence has been simplified so that it is safe to add
columns at the end of the constructor (or any later time).

DataGrid stores a bunch of settings per-column, but before this was done
by both storing properties on the provided column objects as well as
keeping several columnIdentifier-keyed maps for properties like group
and hidden.

Improve code readability by using for..of loops, destructuring assignment,
Node.createElement, and updating variable names. All variables that refer
to DOM nodes now have a Element suffix to distinguish them from model objects.

• UserInterface/DataGrid.js:

(.sortDataGrid):
(WebInpector.DataGrid): Create all DOM elements before populating columns.
Remove redundant objects for storing per-column values. Copy column settings
into a map rather than mutating the passed-in JSON-like settings data structure.

(WebInspector.DataGrid.createSortableDataGrid):
(WebInspector.DataGrid.prototype.get length):
(WebInspector.DataGrid.prototype.updateLayout):
(WebInspector.DataGrid.prototype.get scrollContainer):
(WebInspector.DataGrid.prototype.isScrolledToLastRow):
(WebInspector.DataGrid.prototype.scrollToLastRow):
(WebInspector.DataGrid.prototype._positionResizerElements):
(WebInspector.DataGrid.prototype.addCreationNode):
(WebInspector.DataGrid.prototype.):
(WebInspector.DataGrid.prototype.sortNodes):
(WebInspector.DataGrid.prototype.dataGridNodeFromPoint):
(WebInspector.DataGrid.prototype._clickInHeaderCell):
(WebInspector.DataGrid.prototype.isColumnSortColumn):
(WebInspector.DataGrid.prototype.headerTableHeader):
(WebInspector.DataGrid.prototype._copyTextForDataGridNode):
(WebInspector.DataGrid.prototype._resizerDragging):
(WebInspector.DataGridNode.prototype.createCells):
(WebInspector.DataGridNode.prototype.createCell.get var):
(WebInspector.DataGridNode.prototype.elementWithColumnIdentifier):
(WebInspector.DataGridNode.prototype._attach):

• UserInterface/TimelineDataGrid.js:

(WebInspector.TimelineDataGrid.prototype.treeElementMatchesActiveScopeFilters.scopeBar.this.columns.get scopeBar):
(WebInspector.TimelineDataGrid.prototype.treeElementMatchesActiveScopeFilters):

11:43 AM Changeset in webkit [163636] by andersca@apple.com

• 4 edits in trunk/Source/WebKit2

Copying a WebPreferences object should be done through a member function
​https://bugs.webkit.org/show_bug.cgi?id=128385

Reviewed by Andreas Kling.

• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesCreateCopy):

• UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::copy):

• UIProcess/WebPreferences.h:

11:10 AM Changeset in webkit [163635] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

WebPageGroup::setPreferences should set the preferences on all pages in the group
​https://bugs.webkit.org/show_bug.cgi?id=128383

Reviewed by Alexey Proskuryakov.

• UIProcess/WebPageGroup.cpp:

(WebKit::WebPageGroup::setPreferences):

10:53 AM Changeset in webkit [163634] by ap@apple.com

• 2 edits in trunk/Source/WebCore

32-bit build fix.

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(accessibilitySelectTextCriteriaForCriteriaParameterizedAttribute):

10:46 AM Changeset in webkit [163633] by commit-queue@webkit.org

• 50 edits in trunk

[CSS Background Blending] Unprefix the -webkit-background-blend-mode property

​https://bugs.webkit.org/show_bug.cgi?id=128270

Patch by Mihai Tica <​mitica@adobe.com> on 2014-02-07
Reviewed by Dean Jackson.

Source/WebCore:

This patch consist of unprefixing the -webkit-background-blend-mode.
The property now changes to background-blend-mode.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

• css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillProperty):

• css/CSSPropertyNames.in:
• css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):

Source/WebInspectorUI:

• UserInterface/CSSKeywordCompletions.js: Refactor -webkit-background-blend-mode to background-blend-mode.

LayoutTests:

This patch consist of unprefixing the -webkit-background-blend-mode.
The property now changes to background-blend-mode.

• css3/compositing/background-blend-mode-background-attachement-fixed-expected.html:
• css3/compositing/background-blend-mode-background-attachement-fixed.html:
• css3/compositing/background-blend-mode-background-clip-content-box-expected.html:
• css3/compositing/background-blend-mode-background-clip-content-box.html:
• css3/compositing/background-blend-mode-background-clip-padding-box-expected.html:
• css3/compositing/background-blend-mode-background-clip-padding-box.html:
• css3/compositing/background-blend-mode-background-origin-border-box-expected.html:
• css3/compositing/background-blend-mode-background-origin-border-box.html:
• css3/compositing/background-blend-mode-background-position-percentage-expected.html:
• css3/compositing/background-blend-mode-background-position-percentage.html:
• css3/compositing/background-blend-mode-background-repeat-no-repeat-expected.html:
• css3/compositing/background-blend-mode-background-repeat-no-repeat.html:
• css3/compositing/background-blend-mode-background-size-contain-expected.html:
• css3/compositing/background-blend-mode-background-size-contain.html:
• css3/compositing/background-blend-mode-background-size-cover-expected.html:
• css3/compositing/background-blend-mode-background-size-cover.html:
• css3/compositing/background-blend-mode-crossfade-image.html:
• css3/compositing/background-blend-mode-data-uri-svg-image.html:
• css3/compositing/background-blend-mode-default-value.html:
• css3/compositing/background-blend-mode-different-image-formats.html:
• css3/compositing/background-blend-mode-gif-color-2.html:
• css3/compositing/background-blend-mode-gif-color.html:
• css3/compositing/background-blend-mode-gradient-color.html:
• css3/compositing/background-blend-mode-gradient-gradient.html:
• css3/compositing/background-blend-mode-gradient-image.html:
• css3/compositing/background-blend-mode-image-color.html:
• css3/compositing/background-blend-mode-image-image.html:
• css3/compositing/background-blend-mode-image-svg.html:
• css3/compositing/background-blend-mode-multiple-background-layers.html:
• css3/compositing/background-blend-mode-property-expected.txt:
• css3/compositing/background-blend-mode-property-parsing-expected.txt:
• css3/compositing/background-blend-mode-separate-layer-declaration.html:
• css3/compositing/background-blend-mode-single-layer-no-blending.html:
• css3/compositing/background-blend-mode-svg-color.html:
• css3/compositing/background-blend-mode-svg.html:
• css3/compositing/background-blend-mode-tiled-layers.html:
• css3/compositing/blend-mode-layers.html:
• css3/compositing/effect-background-blend-mode-stacking.html:
• css3/compositing/effect-background-blend-mode-tiled.html:
• css3/compositing/effect-background-blend-mode.html:
• css3/compositing/script-tests/background-blend-mode-property-parsing.js:

(testBlendModeRule):

• css3/compositing/script-tests/background-blend-mode-property.js:

(testblendmode):

10:43 AM Changeset in webkit [163632] by Samuel White

• 20 edits
  2 adds in trunk

AX: Find and select text with respect to insertion point using accessibility API.
​https://bugs.webkit.org/show_bug.cgi?id=128026

Reviewed by Chris Fleizach.

Source/WebCore:

Added facilities to support semi-ambiguous text selection through the accessibility API. All
requests are handled with respect to the current selection. The requests are disambiguated in
WebCore using passed parameters such as: SelectStringAfterSelection , ..Before.., ..ClosestTo...,
etc. Callers can also supply an array of strings to select and the closest that matches the
disambiguation criteria will be used.

Test: platform/mac/accessibility/select-text.html

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::rangeClosestToRange):
(WebCore::AccessibilityObject::rangeOfStringClosestToRangeInDirection):
(WebCore::AccessibilityObject::selectionRange):
(WebCore::AccessibilityObject::selectText):
(WebCore::AccessibilityObject::frame):

• accessibility/AccessibilityObject.h:

(WebCore::AccessibilitySelectTextCriteria::AccessibilitySelectTextCriteria):

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(accessibilitySelectTextCriteriaForCriteriaParameterizedAttribute):
(-[WebAccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

• dom/Position.cpp:

(WebCore::Position::positionCountBetweenPositions):

• dom/Position.h:

Tools:

Added method to AccessibilityUIElement to enable testing of accessibility text selection.

• DumpRenderTree/AccessibilityUIElement.cpp:

(selectTextWithCriteriaCallback):
(AccessibilityUIElement::getJSClass):

• DumpRenderTree/AccessibilityUIElement.h:
• DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::selectTextWithCriteria):

• DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(AccessibilityUIElement::selectTextWithCriteria):

• DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(selectTextParameterizedAttributeForCriteria):
(AccessibilityUIElement::selectTextWithCriteria):

• DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::selectTextWithCriteria):

• WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::selectTextWithCriteria):

• WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
• WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
• WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:

(WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
(WTR::AccessibilityUIElement::selectTextWithCriteria):

• WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::selectTextParameterizedAttributeForCriteria):
(WTR::AccessibilityUIElement::selectTextWithCriteria):

LayoutTests:

Tests that text selection via the accessibility API works as expected.

• platform/mac/accessibility/bounds-for-range-expected.txt:
• platform/mac/accessibility/select-text-expected.txt: Added.
• platform/mac/accessibility/select-text.html: Added.

10:37 AM Changeset in webkit [163631] by Bem Jones-Bey

• 3 edits in trunk/Source/WebCore

FloatingObject m_paginationStrut should be LayoutUnit
​https://bugs.webkit.org/show_bug.cgi?id=119808

Reviewed by Andreas Kling.

Make the paginationStrut in FloatingObject have the same type as all
of the other paginationStruts in the code.

• rendering/FloatingObjects.h:

(WebCore::FloatingObject::paginationStrut):
(WebCore::FloatingObject::setPaginationStrut):

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::positionNewFloatOnLine):

10:32 AM Changeset in webkit [163630] by mitz@apple.com

• 3 edits in trunk/Source/WebKit2

[Cocoa] WKRemoteObjectInterface doesn’t support aribtrary argument classes
​https://bugs.webkit.org/show_bug.cgi?id=128368

Reviewed by Anders Carlsson.

• Shared/API/Cocoa/WKRemoteObjectInterface.h: Declared new methods.
• Shared/API/Cocoa/WKRemoteObjectInterface.mm:

(propertyListClasses): Removed NSNull, which is not really a property list class.
(classesForSelectorArgument): Added helper function.
(-[WKRemoteObjectInterface classesForSelector:argumentIndex:]): Added.
(-[WKRemoteObjectInterface setClasses:forSelector:argumentIndex:]): Added.

10:32 AM Changeset in webkit [163629] by mitz@apple.com

• 8 edits
  4 adds in trunk/Source/WebKit2

[Cocoa] API::FrameHandle has a generic wrapper
​https://bugs.webkit.org/show_bug.cgi?id=128366

Reviewed by Anders Carlsson.

Added WKFrameHandle.

• Shared/API/Cocoa/WKFrameHandle.h: Added.
• Shared/API/Cocoa/WKFrameHandle.mm: Added.

(-[WKFrameHandle dealloc]): Calls the API::FrameHandle destructor.
(-[WKFrameHandle isEqual:]): Checks for frame ID equality.
(-[WKFrameHandle hash]): Returns the frame ID.
(-[WKFrameHandle _frameID]): Ditto.
(-[WKFrameHandle copyWithZone:]): Retains self.
(+[WKFrameHandle supportsSecureCoding]): Returns YES.
(-[WKFrameHandle initWithCoder:]): Decodes the frame ID and constructs an API::FrameHandle
with it.
(-[WKFrameHandle encodeWithCoder:]): Encodes the frame ID.
(-[WKFrameHandle _apiObject]): Returns the wrapped API::FrameHandle.

• Shared/API/Cocoa/WKFrameHandleInternal.h: Added.

(WebKit::wrapper): Added. Returns an API::FrameHandle’s wrapper as a WKFrameHandle.

• Shared/APIFrameHandle.cpp:

(API::FrameHandle::create): Changed to return a PassRefPtr.

• Shared/APIFrameHandle.h: Made the constructor public for -[WKFrameHandle initWithCoder:].

• Shared/Cocoa/APIObject.mm:

(API::Object::newObject): Allocate a WKFrameHandle if the object is an API::FrameHandle.

• WebKit2.xcodeproj/project.pbxproj: Added references to new files.

• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h: Declared handle property.
• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:

(+[WKWebProcessPlugInFrame lookUpFrameFromHandle:]): Added. Calls WebProcess::webFrame to
look up a frame with the given handle’s frame ID.
(-[WKWebProcessPlugInFrame handle]): Added. Returns a new handle with the frame’s ID.

• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrameInternal.h: Updated #import.
• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h: Added.

10:31 AM Changeset in webkit [163628] by mitz@apple.com

• 2 edits in trunk/Source/WebKit2

[Cocoa] WKWebProcessPlugInNodeHandle methods leak and may crash
​https://bugs.webkit.org/show_bug.cgi?id=128365

Reviewed by Anders Carlsson.

• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:

(+[WKWebProcessPlugInNodeHandle nodeHandleWithJSValue:inContext:]): Null-check the result
of InjectedBundleNodeHandle::getOrCreate, and autorelease the return value.
(-[WKWebProcessPlugInNodeHandle htmlIFrameElementContentFrame]): Null-check the result of
InjectedBundleNodeHandle::htmlIFrameElementContentFrame, and autorelease the return value.

10:26 AM Changeset in webkit [163627] by beidson@apple.com

• 20 edits in trunk

IDB: storage/indexeddb/create-index-with-integer-keys.html fails
<rdar://problem/16002857> and ​https://bugs.webkit.org/show_bug.cgi?id=128316

Reviewed by Geoff Garen.

Source/WebCore:

Tested by storage/indexeddb/create-index-with-integer-keys.html (and probably some others)

• Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::update): Update createIDBKeyFromScriptValueAndKeyPath usage.
(WebCore::IDBCursor::setValueReady): Update createIDBKeyFromScriptValueAndKeyPath usage.

• Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::put): Update usage of binding utilities.

• Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess): Update createIDBKeyFromScriptValueAndKeyPath usage.

• bindings/js/IDBBindingUtilities.cpp:

(WebCore::internalCreateIDBKeyFromScriptValueAndKeyPath):
(WebCore::createIDBKeyFromScriptValueAndKeyPath): Changed to take an ExecState*.
(WebCore::deserializeIDBValueBuffer): Added new version that starts with ExecState* and Vector<uint8_t>

instead of RequestState and SharedBuffer.

(WebCore::generateIndexKeysForValue): Moved from IDBObjectStore.cpp and changed to take an ExecState*

• bindings/js/IDBBindingUtilities.h:

Added new blob fetcher that works with uint8_t buffers:

• platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::getColumnBlobAsVector):

• platform/sql/SQLiteStatement.h:

• WebCore.exp.in:

Source/WebKit2:

Update Vector<char> to Vector<uint8_t> throughout:

• DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::openCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didOpenCursorInBackingStore):
(WebKit::UniqueIDBDatabase::advanceCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didAdvanceCursorInBackingStore):
(WebKit::UniqueIDBDatabase::iterateCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didIterateCursorInBackingStore):

• DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:

Update Vector<char> to Vector<uint8_t> throughout:

• DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:

(WebKit::SQLiteIDBCursor::advanceOnce):

• DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.h:

(WebKit::SQLiteIDBCursor::currentValueBuffer):

• DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
• DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createIndex): Create a script value from the value data, use

generateIndexKeysForValue to get the index keys, and then write the resulting index records.

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::putIndexRecord): Call through to uncheckedPutIndexRecord.
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::uncheckedPutIndexRecord): Version of putIndexRecord that doesn’t

validate the transaction or its mode.

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::openCursor): Update Vector<char> to Vector<uint8_t>.
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::advanceCursor): Ditto.
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::iterateCursor): Ditto.

• DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:

LayoutTests:

• platform/mac-wk2/TestExpectations: Enable the test.

10:20 AM Changeset in webkit [163626] by commit-queue@webkit.org

• 3 edits
  4 adds in trunk

childShouldCreateRenderer should return false for the mspace element
​https://bugs.webkit.org/show_bug.cgi?id=128325

Patch by Frédéric Wang <​fred.wang@free.fr> on 2014-02-07
Reviewed by Chris Fleizach.

Source/WebCore:

The mspace element can not have children so this makes its
childShouldCreateRenderer always return false.

Test: mathml/presentation/mspace-children.html

• mathml/MathMLTextElement.cpp:

(WebCore::MathMLTextElement::childShouldCreateRenderer):

LayoutTests:

Add tests to ensure that the mspace element does not have renderer
children.

• mathml/presentation/mspace-children-expected.png: Added.
• mathml/presentation/mspace-children-expected.txt: Added.
• mathml/presentation/mspace-children.html: Added.
• platform/mathml/presentation/mspace-children-expected.txt: Added.

9:45 AM Changeset in webkit [163625] by commit-queue@webkit.org

• 90 edits in trunk

[CSS Grid Layout] Rename grid-definition-{columns|rows} to match the new syntax
​https://bugs.webkit.org/show_bug.cgi?id=127989

Patch by Javier Fernandez <​jfernandez@igalia.com> on 2014-02-07
Reviewed by Andreas Kling.

In the latest WD, grid-definition-{columns|rows} were renamed to grid-template-{columns|rows}.

Source/WebCore:

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::isLayoutDependent):
(WebCore::ComputedStyleExtractor::propertyValue):

• css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

• css/CSSPropertyNames.in:
• css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

LayoutTests:

• fast/css-grid-layout/auto-content-resolution-columns.html:
• fast/css-grid-layout/auto-content-resolution-rows.html:
• fast/css-grid-layout/breadth-size-resolution-grid.html:
• fast/css-grid-layout/calc-resolution-grid-item.html:
• fast/css-grid-layout/flex-and-minmax-content-resolution-columns.html:
• fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html:
• fast/css-grid-layout/flex-content-resolution-columns.html:
• fast/css-grid-layout/flex-content-resolution-rows.html:
• fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution.html:
• fast/css-grid-layout/grid-auto-columns-rows-resolution.html:
• fast/css-grid-layout/grid-auto-columns-rows-update.html:
• fast/css-grid-layout/grid-auto-flow-resolution.html:
• fast/css-grid-layout/grid-auto-flow-update.html:
• fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
• fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
• fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
• fast/css-grid-layout/grid-columns-rows-get-set.html:
• fast/css-grid-layout/grid-dynamic-updates-relayout.html:
• fast/css-grid-layout/grid-element-border-grid-item.html:
• fast/css-grid-layout/grid-element-border-padding-grid-item.html:
• fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt:
• fast/css-grid-layout/grid-element-change-columns-repaint.html:
• fast/css-grid-layout/grid-element-change-rows-repaint-expected.txt:
• fast/css-grid-layout/grid-element-change-rows-repaint.html:
• fast/css-grid-layout/grid-element-empty-row-column.html:
• fast/css-grid-layout/grid-element-min-max-width.html:
• fast/css-grid-layout/grid-element-padding-grid-item.html:
• fast/css-grid-layout/grid-element-padding-margin.html:
• fast/css-grid-layout/grid-element-repeat-get-set-expected.txt:
• fast/css-grid-layout/grid-element-repeat-get-set.html:
• fast/css-grid-layout/grid-item-addition-auto-placement-update.html:
• fast/css-grid-layout/grid-item-addition-track-breadth-update.html:
• fast/css-grid-layout/grid-item-bad-named-area-auto-placement.html:
• fast/css-grid-layout/grid-item-bad-resolution-double-span.html:
• fast/css-grid-layout/grid-item-change-column-repaint.html:
• fast/css-grid-layout/grid-item-change-row-repaint.html:
• fast/css-grid-layout/grid-item-margin-resolution.html:
• fast/css-grid-layout/grid-item-multiple-minmax-content-resolution.html:
• fast/css-grid-layout/grid-item-named-grid-area-resolution.html:
• fast/css-grid-layout/grid-item-named-grid-line-resolution.html:
• fast/css-grid-layout/grid-item-negative-integer-explicit-grid-resolution.html:
• fast/css-grid-layout/grid-item-negative-position-resolution.html:
• fast/css-grid-layout/grid-item-order-auto-flow-resolution.html:
• fast/css-grid-layout/grid-item-order-paint-order.html:
• fast/css-grid-layout/grid-item-removal-auto-placement-update.html:
• fast/css-grid-layout/grid-item-removal-track-breadth-update.html:
• fast/css-grid-layout/grid-item-spanning-resolution.html:
• fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html:
• fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html:
• fast/css-grid-layout/grid-preferred-logical-widths.html:
• fast/css-grid-layout/implicit-columns-auto-resolution.html:
• fast/css-grid-layout/implicit-position-dynamic-change.html:
• fast/css-grid-layout/implicit-rows-auto-resolution.html:
• fast/css-grid-layout/minmax-fixed-logical-height-only.html:
• fast/css-grid-layout/minmax-fixed-logical-width-only.html:
• fast/css-grid-layout/minmax-max-content-resolution-columns.html:
• fast/css-grid-layout/minmax-max-content-resolution-rows.html:
• fast/css-grid-layout/minmax-min-content-column-resolution-columns.html:
• fast/css-grid-layout/minmax-min-content-column-resolution-rows.html:
• fast/css-grid-layout/minmax-spanning-resolution-columns.html:
• fast/css-grid-layout/minmax-spanning-resolution-rows.html:
• fast/css-grid-layout/named-grid-line-get-set-expected.txt:
• fast/css-grid-layout/named-grid-line-get-set.html:
• fast/css-grid-layout/non-grid-columns-rows-get-set-expected.txt:
• fast/css-grid-layout/non-grid-columns-rows-get-set-multiple-expected.txt:
• fast/css-grid-layout/non-grid-columns-rows-get-set-multiple.html:
• fast/css-grid-layout/non-grid-columns-rows-get-set.html:
• fast/css-grid-layout/non-grid-element-repeat-get-set-expected.txt:
• fast/css-grid-layout/non-grid-element-repeat-get-set.html:
• fast/css-grid-layout/non-named-grid-line-get-set-expected.txt:
• fast/css-grid-layout/non-named-grid-line-get-set.html:
• fast/css-grid-layout/percent-grid-item-in-percent-grid-track-in-percent-grid.html:
• fast/css-grid-layout/percent-grid-item-in-percent-grid-track-update.html:
• fast/css-grid-layout/percent-grid-item-in-percent-grid-track.html:
• fast/css-grid-layout/percent-padding-margin-resolution-grid-item-update.html:
• fast/css-grid-layout/percent-padding-margin-resolution-grid-item.html:
• fast/css-grid-layout/percent-resolution-grid-item.html:
• fast/css-grid-layout/place-cell-by-index.html:
• fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:

(testInherit):
(testInitial):

• fast/css-grid-layout/resources/grid-columns-rows-get-set.js:

(testInherit):
(testInitial):

• fast/css-grid-layout/resources/grid-definitions-parsing-utils.js:

(testGridTemplatesValues):
(testGridTemplatesSetJSValues):
(testNonGridTemplatesSetJSValues):
(checkGridTemplatesSetJSValues):
(testGridTemplatesSetBadJSValues):

• fast/css-grid-layout/resources/non-grid-columns-rows-get-set-multiple.js:

(testInherit):
(testInitial):

• fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js:

(testInherit):
(testInitial):

• ietestcenter/css3/grid/display-grid-001-expected.htm:

9:43 AM Changeset in webkit [163624] by dino@apple.com

• 2 edits in trunk/LayoutTests

animations/suspend-resume-animation.html is flakey
​https://bugs.webkit.org/show_bug.cgi?id=128379

Marking it as such.

• platform/mac/TestExpectations:

8:11 AM Changeset in webkit [163623] by Michał Pakuła vel Rutka

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening

Remove test expectations after r163586 and skip two http tests.

• platform/efl-wk2/TestExpectations:

4:02 AM Changeset in webkit [163622] by akling@apple.com

• 5 edits in trunk/Source/WebCore

CTTE: DocumentThreadableLoader always has a Document.
<​https://webkit.org/b/128364>

DocumentThreadableLoader always has an "owner" Document, so store
that as a reference instead of a pointer. Removed some unnecessary
assertions exposed by this change.

Reviewed by Antti Koivisto.

• loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadResourceSynchronously):
(WebCore::DocumentThreadableLoader::create):
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::didReceiveResponse):
(WebCore::DocumentThreadableLoader::didReceiveData):
(WebCore::DocumentThreadableLoader::didFinishLoading):
(WebCore::DocumentThreadableLoader::didFail):
(WebCore::DocumentThreadableLoader::preflightFailure):
(WebCore::DocumentThreadableLoader::loadRequest):
(WebCore::DocumentThreadableLoader::securityOrigin):

• loader/DocumentThreadableLoader.h:
• loader/ThreadableLoader.cpp:

(WebCore::ThreadableLoader::create):
(WebCore::ThreadableLoader::loadResourceSynchronously):

• loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):

3:44 AM Changeset in webkit [163621] by Manuel Rego Casasnovas

• 3 edits in trunk/Tools

[GTK] Disable gtk-doc in EWS
​https://bugs.webkit.org/show_bug.cgi?id=128370

Reviewed by Carlos Garcia Campos.

Disable gtk-doc generation in EWS due to ​http://webkit.org/b/128369.

• Scripts/webkitpy/common/config/ports.py:

(GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
(GtkWK2Port.build_webkit_command): Ditto.

• Scripts/webkitpy/common/config/ports_unittest.py:

(DeprecatedPortTest.test_gtk_port): Ditto.
(DeprecatedPortTest.test_gtk_wk2_port): Ditto.

2:52 AM Changeset in webkit [163620] by commit-queue@webkit.org

• 4 edits in trunk/LayoutTests

[EFL] editing/style/block-style-005.html failing
​https://bugs.webkit.org/show_bug.cgi?id=114612

Patch by Lukasz Bialek <​l.bialek@samsung.com> on 2014-02-07
Reviewed by Ryosuke Niwa.

After r148378 editing/style/block-style-005.htm test stopped passing.
Number of "moveSelectionByLineCommand" is changed to 4 to match intended
test behaviour. Test is confirmed to pass in EFL and GTK ports now.

• editing/style/block-style-005.html:
• platform/efl/TestExpectations:
• platform/gtk/TestExpectations:

2:49 AM Changeset in webkit [163619] by mihnea@adobe.com

• 7 edits
  1 delete in trunk/LayoutTests

[CSSRegions] Remove style-scoped tests
​https://bugs.webkit.org/show_bug.cgi?id=128361

Reviewed by Andrei Bucur.

Remove tests combining style-scoped and regions. The support was removed from code base
and the tests were skipped from a long time.

• fast/regions/style-scoped/style-scoped-in-flow-expected.html: Removed.
• fast/regions/style-scoped/style-scoped-in-flow-override-container-style-expected.html: Removed.
• fast/regions/style-scoped/style-scoped-in-flow-override-container-style.html: Removed.
• fast/regions/style-scoped/style-scoped-in-flow-override-region-styling-expected.html: Removed.
• fast/regions/style-scoped/style-scoped-in-flow-override-region-styling-multiple-regions-expected.html: Removed.
• fast/regions/style-scoped/style-scoped-in-flow-override-region-styling-multiple-regions.html: Removed.
• fast/regions/style-scoped/style-scoped-in-flow-override-region-styling.html: Removed.
• fast/regions/style-scoped/style-scoped-in-flow.html: Removed.
• platform/efl/TestExpectations:
• platform/gtk-wk2/TestExpectations:
• platform/gtk/TestExpectations:
• platform/mac/TestExpectations:
• platform/win/TestExpectations:
• platform/wincairo/TestExpectations:

2:44 AM Changeset in webkit [163618] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

Vector-effect updates require a re-layout
​https://bugs.webkit.org/show_bug.cgi?id=127553

Patch by Peter Molnar <​pmolnar.u-szeged@partner.samsung.com> on 2014-02-07
Reviewed by Andreas Kling.

As noted in the stale SVGRenderStyle::diff() comment, now that layout() observes vector-effect
we need to trigger a re-layout on attribute changes.

Merged from Blink: ​https://src.chromium.org/viewvc/blink?revision=152570&view=revision

Source/WebCore:

Tests: svg/custom/non-scaling-stroke-update-expected.svg

svg/custom/non-scaling-stroke-update.svg

• rendering/style/SVGRenderStyle.cpp:

(WebCore::SVGRenderStyle::diff):

LayoutTests:

• svg/custom/non-scaling-stroke-update-expected.svg: Added.
• svg/custom/non-scaling-stroke-update.svg: Added.

2:21 AM Changeset in webkit [163617] by commit-queue@webkit.org

• 9 edits in trunk/Source/WebCore

Renaming isTableElement() to isRenderedTable() as per the FIXME comment
​https://bugs.webkit.org/show_bug.cgi?id=127769

Patch by Laszlo Vidacs <​lvidacs.u-szeged@partner.samsung.com> on 2014-02-07
Reviewed by Andreas Kling.

Rename method and use IsTable() instead of local type checking.

• dom/Position.cpp:

(WebCore::Position::parentAnchoredEquivalent):
(WebCore::Position::upstream):
(WebCore::Position::downstream):
(WebCore::Position::isCandidate):

• dom/PositionIterator.cpp:

(WebCore::PositionIterator::isCandidate):

• editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
(WebCore::CompositeEditCommand::moveParagraphWithClones):

• editing/FrameSelection.cpp:

(WebCore::caretRendersInsideNode):

• editing/VisibleUnits.cpp:

(WebCore::startOfParagraph):
(WebCore::endOfParagraph):

• editing/htmlediting.cpp:

(WebCore::firstInSpecialElement):
(WebCore::lastInSpecialElement):
(WebCore::isRenderedTable):

• editing/htmlediting.h:
• rendering/RenderBox.cpp:

(WebCore::RenderBox::localCaretRect):

2:10 AM Changeset in webkit [163616] by ChangSeok Oh

• 3 edits in trunk/LayoutTests

Unreviewed GTK port gardening

• platform/gtk-wk2/TestExpectations:
• platform/gtk/TestExpectations:

1:20 AM Changeset in webkit [163615] by g.czajkowski@samsung.com

• 5 edits in trunk/LayoutTests

Verify misspellings after lines merge/split asynchronously
​https://bugs.webkit.org/show_bug.cgi?id=128305

Reviewed by Ryosuke Niwa.

Adapt two spelling tests to use asynchronous spellchecking.

• editing/spelling/script-tests/spelling-backspace-between-lines.js:

(testTwoLinesMisspellings):
(testMisspellingsAfterLineMergeUsingDelete):
(testMisspellingsAfterLineMergeUsingForwardDelete):
Group test cases into separated methods.
Use shouldBeEqualToString to compare strings.
Add newly created div elements instead of overriding
the previous one in order that non DumpRenderTree users
can see what has been tested.

• editing/spelling/spelling-backspace-between-lines-expected.txt:
• editing/spelling/spelling-linebreak-expected.txt:
• editing/spelling/spelling-linebreak.html:

12:32 AM Changeset in webkit [163614] by jinwoo7.song@samsung.com

• 6 edits in trunk

[EFL][WK2] WebView should be able to configure to set fixed layout
​https://bugs.webkit.org/show_bug.cgi?id=128300

Reviewed by Gyuyoung Kim.

Source/WebKit2:

Currently, webview is created by setting fixed layout as true and there is no way to change the setting.
But some applications may do not want to use fixed layout so I'd like to add ewk APIs to configure to it.

• UIProcess/API/efl/ewk_view.cpp:

(EWKViewCreate): Do not set to use fixed layout as default.
(ewk_view_layout_fixed_set):
(ewk_view_layout_fixed_get):

• UIProcess/API/efl/ewk_view.h: Add ewk APIs to set fixed layout.
• UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

Tools:

• MiniBrowser/efl/main.c:

(window_create):
(elm_main): Add command argument option to use fixed layout.