Timeline

Feb 10, 2014:

11:48 PM Changeset in webkit [163867] by Carlos Garcia Campos

• 5 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2

Merge r163799 - [GTK] Create the inspector view using the same web process as the inspected page
​https://bugs.webkit.org/show_bug.cgi?id=128539

Reviewed by Martin Robinson.

• UIProcess/API/C/gtk/WKView.cpp:

(WKViewCreate): Pass nullptr as the related page.

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseCreate): Add related page argument and pass it
to webkitWebViewBaseCreateWebPage() instead of nullptr.

• UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
• UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage): Pass
m_page as related page to webkitWebViewBaseCreate().

11:48 PM Changeset in webkit [163866] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r163856.
​http://trac.webkit.org/changeset/163856
​https://bugs.webkit.org/show_bug.cgi?id=128585

The build fix depends on r163848, which has been reverted
(Requested by notbenjamin on #webkit).

• UIProcess/ios/TextCheckerIOS.mm:

(WebKit::TextChecker::checkTextOfParagraph):
(WebKit::TextChecker::checkSpellingOfString):
(WebKit::TextChecker::checkGrammarOfString):

11:42 PM WebKitGTK/2.4.x edited by Carlos Garcia Campos

(diff)

11:35 PM Changeset in webkit [163865] by Carlos Garcia Campos

• 65 edits
  4 deletes in releases/WebKitGTK/webkit-2.4

Merge r163797 - [GLIB] Add GUniqueOutPtr and use it instead of GOwnPtr
​https://bugs.webkit.org/show_bug.cgi?id=127554

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Use GUniqueOutPtr instead of GOwnPtr.

• GNUmakefile.list.am:
• PlatformEfl.cmake:
• PlatformGTK.cmake:
• platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestinationGStreamer::handleMessage):

• platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::handleMessage):

• platform/glib/BatteryProviderUPower.cpp:

(BatteryProviderUPower::startUpdating):

• platform/graphics/gstreamer/GStreamerUtilities.cpp:

(WebCore::initializeGStreamer):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::handleMessage):

• platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:

(WebCore::TrackPrivateBaseGStreamer::getTag):

• platform/graphics/gtk/ImageBufferGtk.cpp:

(WebCore::encodeImage):
(WebCore::ImageBuffer::toDataURL):

• platform/graphics/gtk/ImageGtk.cpp:

(WebCore::loadResourceSharedBuffer):

• platform/gtk/DataObjectGtk.cpp:

(WebCore::DataObjectGtk::setURIList):

• platform/gtk/FileSystemGtk.cpp:

(WebCore::readFromFile):

• platform/gtk/GamepadsGtk.cpp:

(WebCore::GamepadDeviceGtk::readCallback):

• platform/gtk/GtkInputMethodFilter.cpp:

(WebCore::GtkInputMethodFilter::handlePreeditChanged):

• platform/gtk/PasteboardHelper.cpp:

(WebCore::PasteboardHelper::fillDataObjectFromDropData):

• platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::systemFont):

• platform/gtk/SharedBufferGtk.cpp:

(WebCore::SharedBuffer::createWithContentsOfFile):

• platform/network/gtk/CredentialBackingStore.cpp:

(WebCore::credentialForChallengeAsyncReadyCallback):

• platform/network/soup/GOwnPtrSoup.cpp: Removed.
• platform/network/soup/GOwnPtrSoup.h: Removed.
• platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::redirectSkipCallback):
(WebCore::nextMultipartResponsePartCallback):
(WebCore::sendRequestCallback):
(WebCore::addFileToSoupMessageBody):
(WebCore::createSoupRequestAndMessageForHandle):
(WebCore::readCallback):

• platform/network/soup/SocketStreamHandleSoup.cpp:

(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):
(WebCore::connectedCallback):
(WebCore::readReadyCallback):

• platform/network/soup/SoupNetworkSession.cpp:

(WebCore::SoupNetworkSession::httpProxy):

Source/WebKit/gtk:

Use GUniqueOutPtr instead of GOwnPtr.

• WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidFailLoad):

• WebCoreSupport/TextCheckerClientGtk.cpp:
• webkit/webkitdownload.cpp:

(webkit_download_open_stream_for_uri):
(webkit_download_set_destination_uri):
(webkit_download_received_data):

• webkit/webkitwebplugin.cpp:

(webkit_web_plugin_get_path):

• webkit/webkitwebview.cpp:

(webkit_web_view_expose_event):

Source/WebKit2:

Use GUniqueOutPtr instead of GOwnPtr.

• NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::getCacheDiskFreeSize):

• Shared/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::didReceiveResponse):
(WebKit::DownloadClient::didReceiveData):
(WebKit::DownloadClient::didFinishLoading):

• UIProcess/API/gtk/WebKitFaviconDatabase.cpp:

(processPendingIconsForPageURL):
(webkit_favicon_database_get_favicon):

• UIProcess/API/gtk/WebKitURISchemeRequest.cpp:

(webkitURISchemeRequestReadCallback):

• UIProcess/API/gtk/WebKitWebView.cpp:

(gotFaviconCallback):

• UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:

(WebKit::WebInspectorServer::platformResourceForPath):

• UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::ProcessLauncher::launchProcess):

• UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:

(WebKit::PluginProcessProxy::scanPlugin):

• WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
• WebProcess/soup/WebProcessSoup.cpp:

(WebKit::getCacheDiskFreeSize):

Source/WTF:

GUniqueOutPtr is a simplified version of GOwnPtr for the cases
where we need the address of the contained pointer. GUniqueOutPtr
uses GUniquePtr to free the contained object and to release the
container pointer. The API is very simple to make sure this is
only used when outPtr() is needed. It can't be constructed with a
pointer, and there's not method to set a new pointer. Another
difference with the old GOwnPtr is that outPtr() can be used
multiple times, because it frees any pointer previously set.

• GNUmakefile.list.am:
• wtf/PlatformEfl.cmake:
• wtf/PlatformGTK.cmake:
• wtf/gobject/GOwnPtr.cpp: Removed.
• wtf/gobject/GOwnPtr.h: Removed.
• wtf/gobject/GUniquePtr.h:

(WTF::GUniqueOutPtr::GUniqueOutPtr):
(WTF::GUniqueOutPtr::~GUniqueOutPtr):
(WTF::GUniqueOutPtr::outPtr):
(WTF::GUniqueOutPtr::reset):
(WTF::GUniqueOutPtr::release):
(WTF::GUniqueOutPtr::operator*):
(WTF::GUniqueOutPtr::operator->):
(WTF::GUniqueOutPtr::get):
(WTF::GUniqueOutPtr::operator!):
(WTF::GUniqueOutPtr::operator UnspecifiedBoolType):

Tools:

Use GUniqueOutPtr instead of GOwnPtr.

• DumpRenderTree/gtk/DumpRenderTree.cpp:
• DumpRenderTree/gtk/EventSender.cpp:

(createKeyPressEvent):

• TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp:

(TestWebKitAPI::returnOutChar):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
• TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:

(testInspectorServerPageList):
(openRemoteDebuggingSession):
(sendIncompleteRequest):

• TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
• TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:

(testWebExtensionWindowObjectCleared):
(testWebExtensionIsolatedWorld):

• TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
• TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:

(testWebViewRunJavaScript):
(testWebViewSave):
(testWebViewPageVisibility):

• TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:

(isStyleSheetInjectedForURLAtPath):

• TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
• TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
• TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
• TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:

(TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):

• TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:

(TestWebKitAPI::doKeyStroke):

• TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
• TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:

(WebKitTestBus::run):

• TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:

(resourceGetDataCallback):
(WebViewTest::keyStroke):
(onSnapshotReady):

• WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::EventSenderProxy::keyDown):

10:37 PM Changeset in webkit [163864] by beidson@apple.com

• 4 edits in trunk

IndexedDB assertion at IDBTransactionBackend::~IDBTransactionBackend()
​https://bugs.webkit.org/show_bug.cgi?id=128341

Reviewed by Maciej Stachowiak.

Source/WebCore:

• Modules/indexeddb/IDBTransactionBackend.cpp:

(WebCore::IDBTransactionBackend::~IDBTransactionBackend): "Finished" is not the only

valid value here - In WK2, "Unused" is also valid. Update the ASSERT.

LayoutTests:

• platform/mac-wk2/TestExpectations: Reenable the indexeddb tests that are known to pass.

10:32 PM Changeset in webkit [163863] by ap@apple.com

• 17 edits in trunk/Source

Add hooks for wrapping CryptoKeys in SerializedScriptValue
​https://bugs.webkit.org/show_bug.cgi?id=128567

Reviewed by Anders Carlsson.

Source/WebCore:

• bindings/js/SerializedScriptValue.cpp: Changed SerializedScriptValue to serialize

wrapped keys. Added a version number to crypto key serialization.

• dom/Document.cpp:

(WebCore::Document::wrapCryptoKey):
(WebCore::Document::unwrapCryptoKey):

• dom/Document.h:
• dom/ScriptExecutionContext.h:
• page/ChromeClient.h:

(WebCore::ChromeClient::wrapCryptoKey):
(WebCore::ChromeClient::unwrapCryptoKey):
Hand wrapping/unwrapping over to client code.

• workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::wrapCryptoKey):
(WebCore::WorkerGlobalScope::unwrapCryptoKey):

• workers/WorkerGlobalScope.h:

Not implemented in workers. SubtleCrypto is currently not exposed in workers. It used
to be possible in WebKit implementation to post a CryptoKey to a worker anyway,
but this doesn't work any more.

Source/WebKit/mac:

• WebCoreSupport/WebChromeClient.h:
• WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::wrapCryptoKey):
(WebChromeClient::unwrapCryptoKey):
Dummy implementation, to be filled in later.

Source/WebKit2:

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::wrapCryptoKey):
(WebKit::WebPageProxy::unwrapCryptoKey):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::wrapCryptoKey):
(WebKit::WebChromeClient::unwrapCryptoKey):

• WebProcess/WebCoreSupport/WebChromeClient.h:

Dummy implementation, to be filled in later.

10:21 PM Changeset in webkit [163862] by mitz@apple.com

• 7 edits
  2 moves
  2 adds in trunk/Source/WebKit2

Stop using PLATFORM(MAC) in WebKit2/platform except where it means “OS X but not iOS”
​https://bugs.webkit.org/show_bug.cgi?id=128513

Reviewed by Dean Jackson.

• Platform/IPC/Connection.cpp:

(IPC::Connection::waitForSyncReply): Changed PLATFORM(MAC) to PLATFORM(COCOA) around use of
RunLoop::runForDuration, matching the guard around that function.

• Platform/Logging.cpp: Deleted unused definition of logLevelString.
• Platform/Module.cpp:

(WebKit::Module::Module): Changed PLATFORM(MAC) to USE(CF).

• Platform/Module.h: Changed PLATFORM(MAC) to USE(CF), since the “Mac” implementation is

just a CFBundle-based implementation.

• Platform/PlatformProcessIdentifier.h: Changed PLATFORM(MAC) to PLATFORM(COCOA). Arguably

this should be OS(DARWIN) && !PLATFORM(EFL) && !PLATFORM(GTK).

• Platform/cf: Added.
• Platform/cf/ModuleCF.cpp: Renamed from Platform/mac/ModuleMac.mm. This file did not

contain any Objective-C code.

• Platform/foundation: Added.
• Platform/foundation/LoggingFoundation.mm: Renamed from Platform/mac/Logging.mac.mm.
• Platform/mac/Logging.mac.mm: Removed.
• Platform/mac/ModuleMac.mm: Removed.
• WebKit2.xcodeproj/project.pbxproj: Updated for renames.

10:20 PM Changeset in webkit [163861] by ap@apple.com

• 2 edits in trunk/LayoutTests

svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures.html and svg/css/font-face-crash.html
frequently assert in ComplexTextController::offsetForPosition
​https://bugs.webkit.org/show_bug.cgi?id=119747

• platform/mac/TestExpectations: Skipped the latter test in debug builds.

10:17 PM Changeset in webkit [163860] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebKit2

Unreviewed, rolling out r163848.
​http://trac.webkit.org/changeset/163848
​https://bugs.webkit.org/show_bug.cgi?id=128580

Caused a lot of crashes on tests (Requested by ap on #webkit).

• Shared/APIString.h:
• UIProcess/TextChecker.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::checkTextOfParagraph):
(WebKit::WebPageProxy::checkSpellingOfString):
(WebKit::WebPageProxy::checkGrammarOfString):

• UIProcess/mac/TextCheckerMac.mm:

(WebKit::TextChecker::checkTextOfParagraph):
(WebKit::TextChecker::checkSpellingOfString):
(WebKit::TextChecker::checkGrammarOfString):

9:43 PM Changeset in webkit [163859] by msaboff@apple.com

• 5 edits in trunk/Source

Re-enable ARM Thumb2 disassembler
​https://bugs.webkit.org/show_bug.cgi?id=128577

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Changed signature of tryToDisassemble() to match updates.
Fixed typo in disassembler.

• disassembler/ARMv7/ARMv7DOpcode.cpp:
• disassembler/ARMv7Disassembler.cpp:

(JSC::tryToDisassemble):

Source/WTF:

Added definition of WTF_USE_ARMV7_DISASSEMBLER back to Platform.h

• wtf/Platform.h:

9:24 PM Changeset in webkit [163858] by ChangSeok Oh

• 6 edits in trunk/Source/WebCore

Support ANGLE_instanced_arrays for linux
​https://bugs.webkit.org/show_bug.cgi?id=127465

Reviewed by Martin Robinson.

Support the instanced drawing WebGL extension, ANGLE_instanced_arrays for linux platform.
This is a following patch for r162565. Relevant opengl APIs are exposed
for WebGLRenderingContext to access them.

Covered by fast/canvas/webgl/angle-instanced-arrays.html

• html/canvas/ANGLEInstancedArrays.cpp:

(WebCore::ANGLEInstancedArrays::supported):

• platform/graphics/OpenGLShims.cpp:

(WebCore::initializeOpenGLShims):

• platform/graphics/OpenGLShims.h:
• platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::supportsExtension):

• platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::drawArraysInstanced):
(WebCore::GraphicsContext3D::drawElementsInstanced):
(WebCore::GraphicsContext3D::vertexAttribDivisor):

9:17 PM Changeset in webkit [163857] by beidson@apple.com

• 4 edits in trunk

IDB: storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html fails
<rdar://problem/16033286> and ​https://bugs.webkit.org/show_bug.cgi?id=128574

Reviewed by Maciej Stachowiak.

Source/WebKit2:

• DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::getRecordFromBackingStore): If there is no value in an object-store get,

don’t return *any* results.

LayoutTests:

• platform/mac-wk2/TestExpectations: Add the test (still skipped for now due to unrelated reasons).

9:09 PM Changeset in webkit [163856] by benjamin@webkit.org

• 2 edits in trunk/Source/WebKit2

Fix the iOS build after r163848

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-02-10

• UIProcess/ios/TextCheckerIOS.mm:

(WebKit::TextChecker::checkTextOfParagraph):
(WebKit::TextChecker::checkSpellingOfString):
(WebKit::TextChecker::checkGrammarOfString):

8:48 PM Changeset in webkit [163855] by mark.lam@apple.com

• 6 edits in trunk/Source

Source/JavaScriptCore: Removing limitation on JSLock's lockDropDepth.
<​https://webkit.org/b/128570>

Reviewed by Geoffrey Garen.

Now that we've switched to using the C stack, we no longer need to limit
the JSLock::lockDropDepth to 2.

For C loop builds which still use the separate JSStack, the JSLock will
enforce ordering for re-grabbing the lock after dropping it. Re-grabbing
must occur in the reverse order of the dropping of the locks.

Ordering is achieved by JSLock::dropAllLocks() stashing away the
JSLock:: m_lockDropDepth in its DropAllLocks instance's m_dropDepth
before unlocking the lock. Subsequently, JSLock::grabAllLocks() will
ensure that JSLocks::m_lockDropDepth equals its DropAllLocks instance's
m_dropDepth before allowing the lock to be re-grabbed. Otherwise, it
will yield execution and retry again later.

Note: because JSLocks::m_lockDropDepth is protected by the JSLock's
mutex, grabAllLocks() will optimistically lock the JSLock before doing
the check on m_lockDropDepth. If the check fails, it will unlock the
JSLock, yield, and then relock it again later before retrying the check.
This ensures that m_lockDropDepth remains under the protection of the
JSLock's mutex.

• runtime/JSLock.cpp:

(JSC::JSLock::dropAllLocks):
(JSC::JSLock::grabAllLocks):
(JSC::JSLock::DropAllLocks::DropAllLocks):
(JSC::JSLock::DropAllLocks::~DropAllLocks):

• runtime/JSLock.h:

(JSC::JSLock::DropAllLocks::setDropDepth):
(JSC::JSLock::DropAllLocks::dropDepth):

Source/WebCore: Removing limitation on JSLock’s lockDropDepth.
<​https://webkit.org/b/128570>

Reviewed by Geoffrey Garen.

No new tests.

• bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::runEventLoopWhilePaused):

• platform/ios/wak/WebCoreThread.mm:

(SendDelegateMessage):
(WebThreadRunOnMainThread):

• No longer need to specify AlwaysDropLocks, because DropAllLocks is now always unconditional.

6:47 PM Changeset in webkit [163854] by benjamin@webkit.org

• 3 edits in trunk/Source/WebCore

Clean up MarkupAccumulator::appendCharactersReplacingEntities
​https://bugs.webkit.org/show_bug.cgi?id=128440

Reviewed by Ryosuke Niwa.

Some cleanup:
-Remove the copied code for the loops. Instead, use a template with the loop

parametrized by the characters type.

-Move EntityDescription from the header to the implementation.
-Make the 5 substitution strings compile-time literals. Replacement is not hot enough

to justify the static here.

• editing/MarkupAccumulator.cpp:

(WebCore::appendCharactersReplacingEntitiesInternal):
(WebCore::MarkupAccumulator::appendCharactersReplacingEntities):

• editing/MarkupAccumulator.h:

6:46 PM Changeset in webkit [163853] by benjamin@webkit.org

• 11 edits
  1 add in trunk/Source/WebCore

Add a few pseudo type to the selector compiler through function calls
​https://bugs.webkit.org/show_bug.cgi?id=128514

Reviewed by Dean Jackson.

Certain pseudo type checkers rely on virtual function calls. Since those types
are uncommon, and this code generator cannot currently make virtual function calls,
the checker are added by generating a function call to a wrapper function.

To avoid code duplication between SelectorChecker and the compiler, all the relevant checking
code has been moved to a common header, SelectorCheckerTestFunctions.h.
SelectorChecker still inline the functions, while the SelectorCompiler generate local static functions
and generate calls to them as needed.

• GNUmakefile.list.am:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

• css/SelectorCheckerTestFunctions.h: Added.

(WebCore::isAutofilled):
(WebCore::isDefaultButtonForForm):
(WebCore::isDisabled):
(WebCore::isEnabled):
(WebCore::isChecked):
(WebCore::isInvalid):
(WebCore::isOptionalFormControl):
(WebCore::isRequiredFormControl):
(WebCore::isValid):
(WebCore::matchesReadOnlyPseudoClass):
(WebCore::matchesReadWritePseudoClass):
(WebCore::shouldAppearIndeterminate):
(WebCore::matchesFullScreenPseudoClass):
(WebCore::matchesFutureCuePseudoClass):
(WebCore::matchesPastCuePseudoClass):

• cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoType):
(WebCore::SelectorCompiler::nonConstTestFunctionWrapper):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementFunctionCallTest):

• dom/Element.h:

(WebCore::Element::isValidFormControlElement):

• dom/Node.h:

(WebCore::Node::toInputElement):

• html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::isValidFormControlElement):

• html/HTMLFormControlElement.h:

6:45 PM Changeset in webkit [163852] by fpizlo@apple.com

• 2 edits in trunk/Tools

Make it possible to run tests with --llvmSimpleOpt=false
​https://bugs.webkit.org/show_bug.cgi?id=128571

Reviewed by Mark Lam.

This also makes it so all run functions for the FTL are safe to call with FTL disabled,
because they do their own $enableFTL check.

• Scripts/run-jsc-stress-tests:

6:41 PM Changeset in webkit [163851] by fpizlo@apple.com

• 4 edits
  1 add in trunk/Source/JavaScriptCore

FTL should support ToThis
​https://bugs.webkit.org/show_bug.cgi?id=127751

Reviewed by Oliver Hunt.

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLIntrinsicRepository.h:
• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileToThis):

• tests/stress/to-this-polymorphic.js: Added.

(foo):

6:41 PM Changeset in webkit [163850] by benjamin@webkit.org

• 13 edits
  8 adds in trunk

Add the basic infrastructure to compile attributes matching in selectors
​https://bugs.webkit.org/show_bug.cgi?id=128484

Reviewed by Gavin Barraclough.

Source/WebCore:

Tests: fast/selectors/querySelector-attribute-match-with-child-backtracking.html

fast/selectors/querySelector-long-attribute-match-with-child-backtracking.html
fast/selectors/querySelector-long-multiple-attribute-match-with-child-backtracking.html
fast/selectors/querySelector-multiple-attribute-match-with-child-backtracking.html

Add the infrastructure to match attributes. This only add basic support for the 'Set' match
type, the other match types will have to be built on top.

• cssjit/RegisterAllocator.h:

(WebCore::RegisterAllocator::availableRegisterCount):
(WebCore::RegisterAllocator::allocateRegister):
(WebCore::RegisterAllocator::deallocateRegister):
(WebCore::RegisterAllocator::reserveCalleeSavedRegisters):
(WebCore::RegisterAllocator::restoreCalleeSavedRegisters):
(WebCore::RegisterAllocator::allocatedRegisters):
(WebCore::RegisterAllocator::RegisterAllocator):
(WebCore::RegisterAllocator::~RegisterAllocator):
In the worst case, matching attributes can take up to 10 registers. On x86_64, we have
8 caller-saved registers. The extra 2 registers are simply added by taking callee-saved registers.

RegisterAllocator is modified to know support saving and restoring callee saved registers.
The list of available registers is changed from a vector to a HashSet because the registers
are removed from arbitrary locations in restoreCalleeSavedRegisters(). The m_allocatedRegisters
remain a vector since the allocation/release pattern remain ordered.

• cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::SelectorCodeGenerator):

(WebCore::SelectorCompiler::minimumRegisterRequirements):
This new utility finds the minimum number of registers needed to compile the input. In most
cases we have plenty enough. In rare cases we need to saved a few registers to the stack.

(WebCore::SelectorCompiler::SelectorCodeGenerator::compile):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementDataMatching):
(WebCore::SelectorCompiler::testIsHTMLFlagOnNode):
(WebCore::SelectorCompiler::canMatchStyleAttribute):

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSynchronizeStyleAttribute):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSynchronizeAllAnimatedSVGAttribute):
The style attribute and certain SVG attributes can be modified lazily. In those cases,
the element needs to be updated before querying the attributes.

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributesMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributeMatching):
Generate the attribute matching. For each CSSSelector matching an attribute, we generate
a loop over all the attributes of the element, maching the particular CSSSelector.
This makes no attempt at grouping related queries since those do not seem to happen a lot
in practice.

• dom/Attribute.h:

(WebCore::Attribute::nameMemoryOffset):
(WebCore::Attribute::nameMatchesFilter):
(WebCore::Attribute::matches):

• dom/ElementData.h:

(WebCore::ElementData::isUniqueFlag):
(WebCore::ElementData::arraySizeAndFlagsMemoryOffset):
(WebCore::ElementData::styleAttributeIsDirtyFlag):
(WebCore::ElementData::animatedSVGAttributesAreDirtyFlag):
(WebCore::ElementData::arraySizeOffset):
(WebCore::ShareableElementData::attributeArrayMemoryOffset):
(WebCore::UniqueElementData::attributeVectorMemoryOffset):

• dom/Node.h:

(WebCore::Node::flagIsHTML):

• dom/StyledElement.cpp:

(WebCore::StyledElement::synchronizeStyleAttributeInternal):

• dom/StyledElement.h:

(WebCore::StyledElement::synchronizeStyleAttributeInternal):

• svg/SVGElement.cpp:

(WebCore::SVGElement::synchronizeAllAnimatedSVGAttribute):
(WebCore::SVGElement::synchronizeAnimatedSVGAttribute):

• svg/SVGElement.h:

Source/WTF:

• wtf/Vector.h:

(WTF::VectorBufferBase::bufferMemoryOffset):
(WTF::Vector::sizeMemoryOffset):
(WTF::Vector::dataMemoryOffset):
Expose the memory offsets of Vector::size() and the memory buffer pointer for the JIT.

LayoutTests:

Tests the various cases requiring more register than what is available from the caller-saved pool.

• fast/selectors/querySelector-attribute-match-with-child-backtracking-expected.txt: Added.
• fast/selectors/querySelector-attribute-match-with-child-backtracking.html: Added.
• fast/selectors/querySelector-long-attribute-match-with-child-backtracking-expected.txt: Added.
• fast/selectors/querySelector-long-attribute-match-with-child-backtracking.html: Added.
• fast/selectors/querySelector-long-multiple-attribute-match-with-child-backtracking-expected.txt: Added.
• fast/selectors/querySelector-long-multiple-attribute-match-with-child-backtracking.html: Added.
• fast/selectors/querySelector-multiple-attribute-match-with-child-backtracking-expected.txt: Added.
• fast/selectors/querySelector-multiple-attribute-match-with-child-backtracking.html: Added.

6:29 PM Changeset in webkit [163849] by beidson@apple.com

• 11 edits in trunk

IDB: storage/indexeddb/mozilla/indexes.html fails
<rdar://problem/16031590> and ​https://bugs.webkit.org/show_bug.cgi?id=128563

Reviewed by Tim Horton.

Source/WebCore:

Tested by storage/indexeddb/mozilla/indexes.html (and probably others)

• Modules/indexeddb/IDBGetResult.h:

(WebCore::IDBGetResult::IDBGetResult): Add a constructor that takes an IDBKeyData argument.

• Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess): If there’s no keyPath then skip the injection step.

Source/WebKit2:

• DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::getRecordFromBackingStore): Pass the cursor type to the backing store.

• DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
• DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getIndexRecord): If it’s a key-only cursor,

return only the key result.

• DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:

• DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:

(WebKit::getIndexStatement): Fix index statement selection so ascending, unique cursors sort correctly.

LayoutTests:

• platform/mac-wk2/TestExpectations: Add the test (still skipped for now due to unrelated reasons).

6:12 PM Changeset in webkit [163848] by andersca@apple.com

• 5 edits in trunk/Source/WebKit2

Remove a couple of deprecatedCharacters() from WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=128569

Reviewed by Andreas Kling.

• Shared/APIString.h:
• UIProcess/TextChecker.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::checkTextOfParagraph):
(WebKit::WebPageProxy::checkSpellingOfString):
(WebKit::WebPageProxy::checkGrammarOfString):

• UIProcess/mac/TextCheckerMac.mm:

(WebKit::TextChecker::checkTextOfParagraph):
(WebKit::TextChecker::checkSpellingOfString):
(WebKit::TextChecker::checkGrammarOfString):

6:11 PM Changeset in webkit [163847] by benjamin@webkit.org

• 3 edits in trunk/Source/WebCore

Speed up DatasetDOMStringMap::item() when the element has multiple attributes
​https://bugs.webkit.org/show_bug.cgi?id=128058

Reviewed by Darin Adler.

Accessing data attributes by name through DatasetDOMStringMap involes the conversion
from JavaScript property name to attribute name (done with propertyNameMatchesAttributeName()).

When there is a single data attribute, that method is efficient. When there are several attributes,
comparing names character by character becomes a bottleneck.

This patch add an efficent path for this case: instead of converting the attribute name on the fly,
the JavaScript property name is converted to an attribute name so that it can compared by its
AtomicStringImpl pointer.

This method puts a lot more pressure on convertPropertyNameToAttributeName()'s speed. The method was
improved accordingly to compensate for its new caller.

When enumerating multiple attributes by name, this patch provides about 80% speedup.
I could not measure any slow down on the simple cases.

• dom/DatasetDOMStringMap.cpp:

(WebCore::convertPropertyNameToAttributeName):
(WebCore::DatasetDOMStringMap::item):

• dom/ElementData.h:

(WebCore::AttributeIteratorAccessor::attributeCount):

5:56 PM Changeset in webkit [163846] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

Address the review comments for r163825.

• html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::indexForVisiblePosition):
(WebCore::positionForIndex):

5:46 PM Changeset in webkit [163845] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Try to fix the 32-bit build.

• WebCore.exp.in:

5:45 PM Changeset in webkit [163844] by fpizlo@apple.com

• 388 edits
  1 copy
  1 add in trunk/Source

Rename Operations.h to JSCInlines.h
​https://bugs.webkit.org/show_bug.cgi?id=128543

Source/JavaScriptCore:

Rubber stamped by Geoffrey Garen.

Well, what this actually does is it splits Operations.h into a real Operations.h that
actually contains "operations", and JSCInlines.h, which serves the role of being an
inlines umbrella.

• API/JSBase.cpp:
• API/JSCTestRunnerUtils.cpp:
• API/JSCallbackConstructor.cpp:
• API/JSCallbackFunction.cpp:
• API/JSCallbackObject.cpp:
• API/JSClassRef.cpp:
• API/JSContext.mm:
• API/JSContextRef.cpp:
• API/JSManagedValue.mm:
• API/JSObjectRef.cpp:
• API/JSScriptRef.cpp:
• API/JSValue.mm:
• API/JSValueRef.cpp:
• API/JSWeakObjectMapRefPrivate.cpp:
• API/JSWrapperMap.mm:
• GNUmakefile.list.am:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
• JavaScriptCore.xcodeproj/project.pbxproj:
• assembler/LinkBuffer.cpp:
• bindings/ScriptFunctionCall.cpp:
• bindings/ScriptObject.cpp:
• bytecode/ArrayAllocationProfile.cpp:
• bytecode/ArrayProfile.cpp:
• bytecode/BytecodeBasicBlock.cpp:
• bytecode/CallLinkInfo.cpp:
• bytecode/CallLinkStatus.cpp:
• bytecode/CodeBlock.cpp:
• bytecode/CodeBlockJettisoningWatchpoint.cpp:
• bytecode/CodeOrigin.cpp:
• bytecode/ExecutionCounter.cpp:
• bytecode/GetByIdStatus.cpp:
• bytecode/LazyOperandValueProfile.cpp:
• bytecode/MethodOfGettingAValueProfile.cpp:
• bytecode/PreciseJumpTargets.cpp:
• bytecode/ProfiledCodeBlockJettisoningWatchpoint.cpp:
• bytecode/PutByIdStatus.cpp:
• bytecode/SamplingTool.cpp:
• bytecode/SpecialPointer.cpp:
• bytecode/SpeculatedType.cpp:
• bytecode/StructureStubClearingWatchpoint.cpp:
• bytecode/UnlinkedCodeBlock.cpp:
• bytecode/ValueRecovery.cpp:
• bytecompiler/BytecodeGenerator.cpp:
• bytecompiler/NodesCodegen.cpp:
• debugger/Debugger.cpp:
• debugger/DebuggerActivation.cpp:
• debugger/DebuggerCallFrame.cpp:
• dfg/DFGAbstractHeap.cpp:
• dfg/DFGAbstractValue.cpp:
• dfg/DFGArgumentsSimplificationPhase.cpp:
• dfg/DFGArithMode.cpp:
• dfg/DFGArrayMode.cpp:
• dfg/DFGAtTailAbstractState.cpp:
• dfg/DFGAvailability.cpp:
• dfg/DFGBackwardsPropagationPhase.cpp:
• dfg/DFGBasicBlock.cpp:
• dfg/DFGBinarySwitch.cpp:
• dfg/DFGBlockInsertionSet.cpp:
• dfg/DFGByteCodeParser.cpp:
• dfg/DFGCFAPhase.cpp:
• dfg/DFGCFGSimplificationPhase.cpp:
• dfg/DFGCPSRethreadingPhase.cpp:
• dfg/DFGCSEPhase.cpp:
• dfg/DFGCapabilities.cpp:
• dfg/DFGClobberSet.cpp:
• dfg/DFGClobberize.cpp:
• dfg/DFGCommon.cpp:
• dfg/DFGCommonData.cpp:
• dfg/DFGCompilationKey.cpp:
• dfg/DFGCompilationMode.cpp:
• dfg/DFGConstantFoldingPhase.cpp:
• dfg/DFGCriticalEdgeBreakingPhase.cpp:
• dfg/DFGDCEPhase.cpp:
• dfg/DFGDesiredIdentifiers.cpp:
• dfg/DFGDesiredStructureChains.cpp:
• dfg/DFGDesiredTransitions.cpp:
• dfg/DFGDesiredWatchpoints.cpp:
• dfg/DFGDesiredWeakReferences.cpp:
• dfg/DFGDesiredWriteBarriers.cpp:
• dfg/DFGDisassembler.cpp:
• dfg/DFGDominators.cpp:
• dfg/DFGDriver.cpp:
• dfg/DFGEdge.cpp:
• dfg/DFGFailedFinalizer.cpp:
• dfg/DFGFinalizer.cpp:
• dfg/DFGFixupPhase.cpp:
• dfg/DFGFlushFormat.cpp:
• dfg/DFGFlushLivenessAnalysisPhase.cpp:
• dfg/DFGFlushedAt.cpp:
• dfg/DFGGraph.cpp:
• dfg/DFGGraphSafepoint.cpp:
• dfg/DFGInPlaceAbstractState.cpp:
• dfg/DFGInvalidationPointInjectionPhase.cpp:
• dfg/DFGJITCode.cpp:
• dfg/DFGJITCompiler.cpp:
• dfg/DFGJITFinalizer.cpp:
• dfg/DFGJumpReplacement.cpp:
• dfg/DFGLICMPhase.cpp:
• dfg/DFGLazyJSValue.cpp:
• dfg/DFGLivenessAnalysisPhase.cpp:
• dfg/DFGLongLivedState.cpp:
• dfg/DFGLoopPreHeaderCreationPhase.cpp:
• dfg/DFGMinifiedNode.cpp:
• dfg/DFGNaturalLoops.cpp:
• dfg/DFGNode.cpp:
• dfg/DFGNodeFlags.cpp:
• dfg/DFGOSRAvailabilityAnalysisPhase.cpp:
• dfg/DFGOSREntry.cpp:
• dfg/DFGOSREntrypointCreationPhase.cpp:
• dfg/DFGOSRExit.cpp:
• dfg/DFGOSRExitBase.cpp:
• dfg/DFGOSRExitCompiler.cpp:
• dfg/DFGOSRExitCompiler32_64.cpp:
• dfg/DFGOSRExitCompiler64.cpp:
• dfg/DFGOSRExitCompilerCommon.cpp:
• dfg/DFGOSRExitJumpPlaceholder.cpp:
• dfg/DFGOSRExitPreparation.cpp:
• dfg/DFGOperations.cpp:
• dfg/DFGPhase.cpp:
• dfg/DFGPlan.cpp:
• dfg/DFGPredictionInjectionPhase.cpp:
• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGResurrectionForValidationPhase.cpp:
• dfg/DFGSSAConversionPhase.cpp:
• dfg/DFGSSALoweringPhase.cpp:
• dfg/DFGSafepoint.cpp:
• dfg/DFGSpeculativeJIT.cpp:
• dfg/DFGSpeculativeJIT32_64.cpp:
• dfg/DFGSpeculativeJIT64.cpp:
• dfg/DFGStackLayoutPhase.cpp:
• dfg/DFGStoreBarrierElisionPhase.cpp:
• dfg/DFGStrengthReductionPhase.cpp:
• dfg/DFGThreadData.cpp:
• dfg/DFGThunks.cpp:
• dfg/DFGTierUpCheckInjectionPhase.cpp:
• dfg/DFGToFTLDeferredCompilationCallback.cpp:
• dfg/DFGToFTLForOSREntryDeferredCompilationCallback.cpp:
• dfg/DFGTypeCheckHoistingPhase.cpp:
• dfg/DFGUnificationPhase.cpp:
• dfg/DFGUseKind.cpp:
• dfg/DFGValidate.cpp:
• dfg/DFGValueSource.cpp:
• dfg/DFGVariableAccessDataDump.cpp:
• dfg/DFGVariableEvent.cpp:
• dfg/DFGVariableEventStream.cpp:
• dfg/DFGVirtualRegisterAllocationPhase.cpp:
• dfg/DFGWatchpointCollectionPhase.cpp:
• dfg/DFGWorklist.cpp:
• ftl/FTLAbstractHeap.cpp:
• ftl/FTLAbstractHeapRepository.cpp:
• ftl/FTLExitValue.cpp:
• ftl/FTLLink.cpp:
• ftl/FTLLowerDFGToLLVM.cpp:
• ftl/FTLOSREntry.cpp:
• ftl/FTLOSRExit.cpp:
• ftl/FTLOSRExitCompiler.cpp:
• ftl/FTLSlowPathCall.cpp:
• heap/BlockAllocator.cpp:
• heap/CodeBlockSet.cpp:
• heap/ConservativeRoots.cpp:
• heap/CopiedSpace.cpp:
• heap/CopyVisitor.cpp:
• heap/DeferGC.cpp:
• heap/GCThread.cpp:
• heap/GCThreadSharedData.cpp:
• heap/HandleSet.cpp:
• heap/HandleStack.cpp:
• heap/Heap.cpp:
• heap/HeapStatistics.cpp:
• heap/HeapTimer.cpp:
• heap/IncrementalSweeper.cpp:
• heap/JITStubRoutineSet.cpp:
• heap/MachineStackMarker.cpp:
• heap/MarkStack.cpp:
• heap/MarkedAllocator.cpp:
• heap/MarkedBlock.cpp:
• heap/MarkedSpace.cpp:
• heap/SlotVisitor.cpp:
• heap/SuperRegion.cpp:
• heap/Weak.cpp:
• heap/WeakBlock.cpp:
• heap/WeakHandleOwner.cpp:
• heap/WeakSet.cpp:
• heap/WriteBarrierBuffer.cpp:
• heap/WriteBarrierSupport.cpp:
• inspector/InjectedScript.cpp:
• inspector/InjectedScriptBase.cpp:
• inspector/JSGlobalObjectScriptDebugServer.cpp:
• inspector/JSInjectedScriptHost.cpp:
• inspector/ScriptArguments.cpp:
• inspector/ScriptCallStackFactory.cpp:
• interpreter/AbstractPC.cpp:
• interpreter/CallFrame.cpp:
• interpreter/Interpreter.cpp:
• interpreter/JSStack.cpp:
• interpreter/ProtoCallFrame.cpp:
• interpreter/StackVisitor.cpp:
• interpreter/VMInspector.cpp:
• jit/ArityCheckFailReturnThunks.cpp:
• jit/AssemblyHelpers.cpp:
• jit/ClosureCallStubRoutine.cpp:
• jit/ExecutableAllocator.cpp:
• jit/ExecutableAllocatorFixedVMPool.cpp:
• jit/GCAwareJITStubRoutine.cpp:
• jit/HostCallReturnValue.cpp:
• jit/JIT.cpp:
• jit/JITArithmetic.cpp:
• jit/JITArithmetic32_64.cpp:
• jit/JITCall.cpp:
• jit/JITCall32_64.cpp:
• jit/JITCode.cpp:
• jit/JITDisassembler.cpp:
• jit/JITExceptions.cpp:
• jit/JITInlineCacheGenerator.cpp:
• jit/JITInlines.h:
• jit/JITOperations.cpp:
• jit/JITOperationsMSVC64.cpp:
• jit/JITStubRoutine.cpp:
• jit/JITStubs.cpp:
• jit/JITThunks.cpp:
• jit/JITToDFGDeferredCompilationCallback.cpp:
• jit/RegisterPreservationWrapperGenerator.cpp:
• jit/RegisterSet.cpp:
• jit/Repatch.cpp:
• jit/TempRegisterSet.cpp:
• jit/ThunkGenerators.cpp:
• jsc.cpp:
• llint/LLIntExceptions.cpp:
• llint/LLIntSlowPaths.cpp:
• llint/LowLevelInterpreter.cpp:
• parser/Lexer.cpp:
• parser/Nodes.cpp:
• parser/Parser.cpp:
• parser/ParserArena.cpp:
• parser/SourceCode.cpp:
• parser/SourceProvider.cpp:
• parser/SourceProviderCache.cpp:
• profiler/LegacyProfiler.cpp:
• profiler/ProfileGenerator.cpp:
• profiler/ProfilerBytecode.cpp:
• profiler/ProfilerBytecodeSequence.cpp:
• profiler/ProfilerBytecodes.cpp:
• profiler/ProfilerCompilation.cpp:
• profiler/ProfilerCompiledBytecode.cpp:
• profiler/ProfilerDatabase.cpp:
• profiler/ProfilerOSRExit.cpp:
• profiler/ProfilerOSRExitSite.cpp:
• profiler/ProfilerOrigin.cpp:
• profiler/ProfilerOriginStack.cpp:
• profiler/ProfilerProfiledBytecodes.cpp:
• runtime/ArgList.cpp:
• runtime/Arguments.cpp:
• runtime/ArgumentsIteratorPrototype.cpp:
• runtime/ArrayBuffer.cpp:
• runtime/ArrayBufferNeuteringWatchpoint.cpp:
• runtime/ArrayConstructor.cpp:
• runtime/ArrayPrototype.cpp:
• runtime/BooleanConstructor.cpp:
• runtime/BooleanObject.cpp:
• runtime/BooleanPrototype.cpp:
• runtime/CallData.cpp:
• runtime/CodeCache.cpp:
• runtime/CommonSlowPaths.cpp:
• runtime/CommonSlowPathsExceptions.cpp:
• runtime/Completion.cpp:
• runtime/ConstructData.cpp:
• runtime/DateConstructor.cpp:
• runtime/DateInstance.cpp:
• runtime/DatePrototype.cpp:
• runtime/Error.cpp:
• runtime/ErrorConstructor.cpp:
• runtime/ErrorInstance.cpp:
• runtime/ErrorPrototype.cpp:
• runtime/ExceptionHelpers.cpp:
• runtime/Executable.cpp:
• runtime/FunctionConstructor.cpp:
• runtime/FunctionPrototype.cpp:
• runtime/GetterSetter.cpp:
• runtime/Identifier.cpp:
• runtime/IntendedStructureChain.cpp:
• runtime/InternalFunction.cpp:
• runtime/JSActivation.cpp:
• runtime/JSArgumentsIterator.cpp:
• runtime/JSArray.cpp:
• runtime/JSArrayBuffer.cpp:
• runtime/JSArrayBufferConstructor.cpp:
• runtime/JSArrayBufferPrototype.cpp:
• runtime/JSArrayBufferView.cpp:
• runtime/JSBoundFunction.cpp:
• runtime/JSCInlines.h: Copied from Source/JavaScriptCore/runtime/Operations.h.
• runtime/JSCell.cpp:
• runtime/JSDataView.cpp:
• runtime/JSDataViewPrototype.cpp:
• runtime/JSDateMath.cpp:
• runtime/JSFunction.cpp:
• runtime/JSGlobalObject.cpp:
• runtime/JSGlobalObjectFunctions.cpp:
• runtime/JSLock.cpp:
• runtime/JSNameScope.cpp:
• runtime/JSNotAnObject.cpp:
• runtime/JSONObject.cpp:
• runtime/JSObject.cpp:
• runtime/JSPropertyNameIterator.cpp:
• runtime/JSPropertyNameIterator.h:
• runtime/JSProxy.cpp:
• runtime/JSScope.cpp:
• runtime/JSSegmentedVariableObject.cpp:
• runtime/JSString.cpp:
• runtime/JSStringJoiner.cpp:
• runtime/JSSymbolTableObject.cpp:
• runtime/JSTypedArrayConstructors.cpp:
• runtime/JSTypedArrayPrototypes.cpp:
• runtime/JSTypedArrays.cpp:
• runtime/JSVariableObject.cpp:
• runtime/JSWithScope.cpp:
• runtime/JSWrapperObject.cpp:
• runtime/LiteralParser.cpp:
• runtime/Lookup.cpp:
• runtime/MathObject.cpp:
• runtime/NameConstructor.cpp:
• runtime/NameInstance.cpp:
• runtime/NamePrototype.cpp:
• runtime/NativeErrorConstructor.cpp:
• runtime/NativeErrorPrototype.cpp:
• runtime/NumberConstructor.cpp:
• runtime/NumberObject.cpp:
• runtime/NumberPrototype.cpp:
• runtime/ObjectConstructor.cpp:
• runtime/ObjectPrototype.cpp:
• runtime/Operations.cpp:
• runtime/Operations.h:
• runtime/PropertyDescriptor.cpp:
• runtime/PrototypeMap.cpp:
• runtime/RegExp.cpp:
• runtime/RegExpCache.cpp:
• runtime/RegExpCachedResult.cpp:
• runtime/RegExpConstructor.cpp:
• runtime/RegExpMatchesArray.cpp:
• runtime/RegExpObject.cpp:
• runtime/RegExpPrototype.cpp:
• runtime/SimpleTypedArrayController.cpp:
• runtime/SmallStrings.cpp:
• runtime/SparseArrayValueMap.cpp:
• runtime/StrictEvalActivation.cpp:
• runtime/StringConstructor.cpp:
• runtime/StringObject.cpp:
• runtime/StringPrototype.cpp:
• runtime/StringRecursionChecker.cpp:
• runtime/Structure.cpp:
• runtime/StructureChain.cpp:
• runtime/StructureRareData.cpp:
• runtime/SymbolTable.cpp:
• runtime/TestRunnerUtils.cpp:
• runtime/VM.cpp:
• testRegExp.cpp:

Source/WebCore:

Rubber stamped by Geoffrey Garen.

No new tests because no change in behavior.

• ForwardingHeaders/runtime/JSCInlines.h: Added.
• bindings/js/JSCryptoAlgorithmBuilder.cpp:
• bindings/js/JSCryptoKeySerializationJWK.cpp:
• bindings/js/JSCustomXPathNSResolver.h:
• bindings/js/JSDOMBinding.h:
• bindings/js/JSDOMGlobalObject.h:
• bindings/js/JSDictionary.h:
• bindings/js/JSMessagePortCustom.cpp:
• bindings/js/JSMessagePortCustom.h:
• bindings/js/JSNodeFilterCondition.h:
• bindings/js/SerializedScriptValue.cpp:
• bindings/js/WebCoreTypedArrayController.cpp:
• bridge/c/c_utility.h:
• bridge/jsc/BridgeJSC.h:
• dom/CustomEvent.cpp:
• dom/Node.cpp:
• html/HTMLCanvasElement.cpp:
• html/HTMLImageLoader.cpp:
• html/canvas/WebGLRenderingContext.cpp:
• inspector/InspectorDOMAgent.cpp:
• inspector/WebConsoleAgent.cpp:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
• platform/graphics/filters/FEGaussianBlur.cpp:
• platform/graphics/filters/FilterEffect.cpp:
• testing/MockCDM.cpp:
• xml/XMLHttpRequest.cpp:

Source/WebKit2:

Rubber stamped by Geoffrey Garen.

• Shared/linux/WebMemorySamplerLinux.cpp:
• UIProcess/WebContext.cpp:
• WebProcess/WebPage/WebPage.cpp:
• WebProcess/efl/WebProcessMainEfl.cpp:

5:41 PM Changeset in webkit [163843] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Removes the inline assert from SpeculativeJIT's ReallocatePropertyStorage
​https://bugs.webkit.org/show_bug.cgi?id=128566

Patch by Matthew Mirman <​mmirman@apple.com> on 2014-02-10
Reviewed by Filip Pizlo.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):

5:33 PM Changeset in webkit [163842] by fpizlo@apple.com

• 5 edits in trunk/Source/JavaScriptCore

Rename getRecordMap to computeRecordMap.

Rubber stamped by Michael Saboff.

"get" is such a weird prefix. It implies a getter. We don't prefix our getters with
anything in WebKit. Also, this isn't a getter. It actually does work to transform
the stackmaps into a hashmap. So, computeRecordMap is a much better name.

• ftl/FTLCompile.cpp:

(JSC::FTL::compile):

• ftl/FTLJITFinalizer.cpp:

(JSC::FTL::JITFinalizer::finalizeFunction):

• ftl/FTLStackMaps.cpp:

(JSC::FTL::StackMaps::computeRecordMap):

• ftl/FTLStackMaps.h:

5:31 PM Changeset in webkit [163841] by commit-queue@webkit.org

• 4 edits
  1 add in trunk/Source/JavaScriptCore

ReallocatePropertyStorage in FTL
​https://bugs.webkit.org/show_bug.cgi?id=128352

Patch by Matthew Mirman <​mmirman@apple.com> on 2014-02-10
Reviewed by Filip Pizlo.

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLIntrinsicRepository.h:
• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileReallocatePropertyStorage):

• tests/stress/ftl-reallocatepropertystorage.js: Added.

(foo):

5:20 PM Changeset in webkit [163840] by dino@apple.com

• 14 edits in trunk

Update aspect-ratio property to have constraining keywords
​https://bugs.webkit.org/show_bug.cgi?id=128262

Reviewed by Simon Fraser.

Source/WebCore:

Add support for "from-dimensions" and "from-intrinsic"
property values to "-webkit-aspect-ratio". I also changed
the default value from "none" to "auto", because "none" doesn't
make sense any more.

Covered by enhancing existing tests.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue): New keywords.

• css/CSSParser.cpp:

(WebCore::CSSParser::parseAspectRatio): Support new keywords.

• css/CSSValueKeywords.in: Add from-dimensions and from-intrinsic.
• css/DeprecatedStyleBuilder.cpp: This now has to handle the new

values. I also changed "none" to "auto".
(WebCore::ApplyPropertyAspectRatio::applyInheritValue):
(WebCore::ApplyPropertyAspectRatio::applyInitialValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):

• rendering/style/RenderStyle.h: hasAspectRatio is now aspectRatioType

and indicates one of the three keywords, or a specified number.

• rendering/style/RenderStyleConstants.h: New enum.
• rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

• rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

Add tests for new from-intrinsic and from-dimensions
property values.

• fast/css/aspect-ratio-inheritance-expected.txt:
• fast/css/aspect-ratio-inheritance.html:
• fast/css/aspect-ratio-parsing-tests-expected.txt:
• fast/css/aspect-ratio-parsing-tests.html:

5:10 PM Changeset in webkit [163839] by benjamin@webkit.org

• 7 edits in trunk/Source

[WK2] Add support for image document viewport configuration
​https://bugs.webkit.org/show_bug.cgi?id=128565

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-02-10
Reviewed by Simon Fraser.

Source/WebCore:

Add proper default settings for displaying images.

• WebCore.exp.in:
• page/ViewportConfiguration.cpp:

(WebCore::ViewportConfiguration::imageDocumentParameters):
(WebCore::ViewportConfiguration::textDocumentParameters):

• page/ViewportConfiguration.h:

Source/WebKit2:

• UIProcess/API/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::screenToWindow):
(WebKit::PageClientImpl::windowToScreen):
Add the implementation for ImageDocument.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didCommitLoad):
Use the right default settings when dealing with image documents.

4:47 PM Changeset in webkit [163838] by msaboff@apple.com

• 5 edits in trunk/Source/JavaScriptCore

Fail FTL compilation if the required stack is too big
​https://bugs.webkit.org/show_bug.cgi?id=128560

Reviewed by Filip Pizlo.

Added StackSize struct to FTLStackMaps and populated it. Added and updated
related dump functions. Use the stack size found at the end of the compilation
to compare against the value of a new option, llvmMaxStackSize. We fail the
compile if the function's stack size is greater than llvmMaxStackSize.

• dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

• ftl/FTLStackMaps.cpp:

(JSC::FTL::StackMaps::StackSize::parse):
(JSC::FTL::StackMaps::StackSize::dump):
(JSC::FTL::StackMaps::parse):
(JSC::FTL::StackMaps::dump):
(JSC::FTL::StackMaps::dumpMultiline):
(JSC::FTL::StackMaps::getStackSize):

• ftl/FTLStackMaps.h:
• runtime/Options.h:

4:24 PM Changeset in webkit [163837] by Simon Fraser

• 7 edits in trunk/Source/WebKit2

Show a debug tile map indicator for UI-side compositing
​https://bugs.webkit.org/show_bug.cgi?id=128553

Reviewed by Tim Horton.

Implement a tiled scrolling indicator for UI-side compositing.

The indicator is created by making another RemoteLayerTreeHost,
and decoding the transaction in it a second time to create a cloned
layer tree. In that clone commit, we modify some layer properties to
make things easier to see.

The cloned layer tree is hosted in the root layer of the main
RemoteLayerTreeHost.

RemoteLayerTreeHost was changed to not need a pointer to the WebPageProxy,
which it only used in the "root layer changed" case; instead, it now just
returns a bool from updateLayerTree() in that situation.

• UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp: Explanatory comment.
• UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
• UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::RemoteLayerTreeDrawingAreaProxy):
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::setExposedRect):
(WebKit::RemoteLayerTreeDrawingAreaProxy::indicatorLocation):
(WebKit::RemoteLayerTreeDrawingAreaProxy::updateDebugIndicatorPosition):
(WebKit::RemoteLayerTreeDrawingAreaProxy::indicatorScale):
(WebKit::RemoteLayerTreeDrawingAreaProxy::updateDebugIndicator):
(WebKit::RemoteLayerTreeDrawingAreaProxy::showDebugIndicator):

• UIProcess/mac/RemoteLayerTreeHost.h:

(WebKit::RemoteLayerTreeHost::rootLayer):
(WebKit::RemoteLayerTreeHost::setIsDebugLayerTreeHost):
(WebKit::RemoteLayerTreeHost::isDebugLayerTreeHost):

• UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::RemoteLayerTreeHost):
(WebKit::RemoteLayerTreeHost::updateLayerTree):
(WebKit::RemoteLayerTreeHost::createLayer):

4:24 PM Changeset in webkit [163836] by Simon Fraser

• 4 edits in trunk/Source/WebKit2

Put a delegatesScrolling flag on WebPageProxy so that the UI process knows when scrolling is delegated
​https://bugs.webkit.org/show_bug.cgi?id=128429

Reviewed by Sam Weinig.

Add delegatesScrolling() which defaults to false, but is set to true for iOS
by WKContentView.

• UIProcess/API/ios/WKContentView.mm:

(-[WKContentView initWithFrame:configuration:]):
(-[WKContentView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):

• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::setDelegatesScrolling):
(WebKit::WebPageProxy::delegatesScrolling):

4:20 PM Changeset in webkit [163835] by Lucas Forschler

• 2 edits in branches/safari-537.75-branch/Source/WebCore

Merged r162486.

4:19 PM Changeset in webkit [163834] by zoltan@webkit.org

• 1 edit
  1 add in trunk/PerformanceTests

[CSS Shapes] Add initial performance tests for polygon shape
​https://bugs.webkit.org/show_bug.cgi?id=128554

Reviewed by Ryosuke Niwa.

This patch adds performance testing for simple polygon shape-outside.
The Shapes performance tests directory is skipped by default.

• Layout/Shapes/ShapeOutsideSimplePolygon.html: Added.

4:17 PM Changeset in webkit [163833] by Lucas Forschler

• 2 edits in branches/safari-537.75-branch/Source/WebCore

Merged r158870.

4:08 PM Changeset in webkit [163832] by Lucas Forschler

• 2 edits in branches/safari-537.75-branch/Source/WebCore

Merged r154036.

4:03 PM Changeset in webkit [163831] by Lucas Forschler

• 3 edits
  2 copies in branches/safari-537.75-branch

Merged r156082.

3:59 PM Changeset in webkit [163830] by Lucas Forschler

• 2 edits in branches/safari-537.75-branch/Source/WebCore

Merged r153507.

3:55 PM Changeset in webkit [163829] by mark.lam@apple.com

• 4 edits in trunk/LayoutTests

REGRESSION(r163660-r163664): js/dom/stack-trace.html fails.
<​https://webkit.org/b/128544>

Reviewed by Alexey Proskuryakov.

The failing test is fragile. The test intends to test a recursion pattern
i.e. the top of the stack trace should show a repeated cycle of certain
function calls. However, the test makes a faulty assumption about which
function in that recursion pattern will be the one that overflows the
stack.

The fix is to make the test check for repetition of that recursion pattern
instead of making a specific assumption as to which function within that
recursion pattern will overflow the stack.

• TestExpectations: reverted skipped test.
• js/dom/script-tests/stack-trace.js:

(stackTraceLineFor):

• refactored this code to generated the stack trace line out of printStack.

(printStack):

• updated to use stackTraceLineFor.

(dumpPattern):

• utility function to dump the recursion pattern being matched.

(matchesPatternAtLine):
(matchPattern):
(checkStackForPattern):

• utility functions for testing if the stack trace matches the expected recursion pattern. The pattern is an array of stack trace lines that we should see repeated in the stack trace starting from the top.

The top line of the stack trace may match any line in the pattern.
Thereafter, subsequent lines much patch lines in the pattern starting
with the line after the first match. When we run out of pattern lines,
we'll go back to the first pattern line and continue the matching test
until we run out of stack trace lines to match.

If any mismatch is found, the test fails.

• js/dom/stack-trace-expected.txt:
• updates baseline for expected results.

3:48 PM Changeset in webkit [163828] by b.long@cablelabs.com

• 2 edits in trunk/Source/WebCore

Unreviewed GTK build fix after r163816.

• GNUmakefile.list.am: Remove HTMLMediaSource.h and HTMLMediaSource.cpp

3:40 PM Changeset in webkit [163827] by Lucas Forschler

• 3 edits
  3 copies in branches/safari-537.75-branch

Merged r158676.

3:34 PM Changeset in webkit [163826] by jinwoo7.song@samsung.com

• 2 edits in trunk/Source/WebCore

Unreviewed EFL WebKit2 build fix after r163816.

• CMakeLists.txt: Remove HTMLMediaSource.cpp

3:05 PM Changeset in webkit [163825] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

HTMLTextFormControlElement::setSelectionRange shouldn't use VisiblePosition
​https://bugs.webkit.org/show_bug.cgi?id=128478

Reviewed by Darin Adler.

Added positionForIndex to compute Position given a selection index. This function doesn't
synchronously trigger like visiblePositionForIndex.

Also added assertions in visiblePositionForIndex and visiblePositionForIndex to make sure
they are inverse of one another.

• html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::setSelectionRange): Use positionForIndex. Also removed
the now tautological assertions since we would never create a position outside the inner text
element.

(WebCore::HTMLTextFormControlElement::indexForVisiblePosition): Fixed the bug where this
function could return a selection index beyond innerTextElement in some types of input
elements such as search fields. fast/forms/search-disabled-readonly.html hits the newly
added assertion without this change. Note we can't use visiblePositionForIndex here as that
would result in a mutual recursion with the assertion in visiblePositionForIndex.

(WebCore::HTMLTextFormControlElement::visiblePositionForIndex): Added an assertion.

(WebCore::positionForIndex): Added. It's here with prototype at the beginning of the file
so that it's right next to HTMLTextFormControlElement::innerText() where we do a similar
DOM traversal to obtain the inner text value.

2:58 PM Changeset in webkit [163824] by ap@apple.com

• 2 edits in trunk/LayoutTests

svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures.html frequently asserts
in ComplexTextController::offsetForPosition
​https://bugs.webkit.org/show_bug.cgi?id=119747

• platform/mac/TestExpectations: Skipped it in debug builds.

2:55 PM Changeset in webkit [163823] by jpfau@apple.com

• 4 edits
  5 adds in trunk

Disable access to application cache when in private browsing
​https://bugs.webkit.org/show_bug.cgi?id=128426

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Tests: http/tests/security/appcache-in-private-browsing.html

http/tests/security/appcache-switching-private-browsing.html

• loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::cacheForMainRequest):
(WebCore::ApplicationCacheGroup::selectCache):
(WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):
(WebCore::ApplicationCacheGroup::update):

• loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::isApplicationCacheEnabled):

LayoutTests:

• http/tests/security/appcache-in-private-browsing-expected.txt: Added.
• http/tests/security/appcache-in-private-browsing.html: Added.
• http/tests/security/appcache-switching-private-browsing-expected.txt: Added.
• http/tests/security/appcache-switching-private-browsing.html: Added.
• http/tests/security/resources/frame-for-appcache-in-private-browsing.html: Added.

2:46 PM Changeset in webkit [163822] by ap@apple.com

• 2 edits in trunk/LayoutTests

Move animation tests that have similar failing behavior in debug builds together,
and mark them as passing in release.

• platform/mac/TestExpectations:

2:30 PM Changeset in webkit [163821] by barraclough@apple.com

• 17 edits in trunk

Remove WKPageSetVisibilityState
​https://bugs.webkit.org/show_bug.cgi?id=128551

Reviewed by Anders Carlsson.

Source/WebKit2:

Made prerender state automatic. We should move this further
up into WebCore, but this requires refactoring for the Page
construction order.

• Shared/API/c/WKDeprecatedFunctions.cpp:

(WKPageSetVisibilityState):

• deprecated.

• UIProcess/API/C/WKPage.cpp:
  • removed WKPageSetVisibilityState.
• UIProcess/API/C/WKPage.h:
  • removed WKPageSetVisibilityState.
• UIProcess/WebPageProxy.cpp:
  • removed setVisibilityStatePrerender.
• UIProcess/WebPageProxy.h:
  • removed setVisibilityStatePrerender.
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

• removed setVisibilityStatePrerender.
• When creating a Page, automatically set the prerender state.

• WebProcess/WebPage/WebPage.h:
  • removed setVisibilityStatePrerender.
• WebProcess/WebPage/WebPage.messages.in:
  • removed SetVisibilityStatePrerender.

Tools:

• TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:

(TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
(TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):

• visibilityState of offs-creen WKView is automatically prerender.

• WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::setHidden):

• WebKitTestRunner/InjectedBundle/InjectedBundle.h:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setPageVisibility):
(WTR::TestRunner::resetPageVisibility):

• WebKitTestRunner/TestController.cpp:
• WebKitTestRunner/TestController.h:
• WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

• removed calls to WKPageSetVisibilityState.

2:27 PM Changeset in webkit [163820] by mark.lam@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Change JSLock::dropAllLocks() and friends to use lock() and unlock().
<​https://webkit.org/b/128451>

Reviewed by Geoffrey Garen.

Currently, JSLock's dropAllLocks(), dropAllLocksUnconditionally(), and
grabAllLocks() implement locking / unlocking by duplicating the code from
lock() and unlock(). Instead, they should just call lock() and unlock().

• runtime/JSLock.cpp:

(JSC::JSLock::lock):
(JSC::JSLock::unlock):

• Modified lock() and unlock() into a version that takes an entry count to lock / unlock. The previous lock() and unlock() now calls these new versions with an entry count of 1.

(JSC::JSLock::dropAllLocks):
(JSC::JSLock::dropAllLocksUnconditionally):
(JSC::JSLock::grabAllLocks):

• Delegate to unlock() and lock() instead of duplicating the lock / unlock code.
• There a some differences with calling lock() instead of duplicating its code in grabAllLock() i.e. lock() does the following additional work:

1. lock() does a re-entry check that is not needed by grabAllLocks(). However, this is effectively a no-op since we never own the JSLock before calling grabAllLocks().

2. set VM stackPointerAtVMEntry.
3. update VM stackLimit and reservedZoneSize.
4. set VM lastStackTop. These 3 steps are just busy work which are also effective no-ops because immediately after lock() returns, grabAllLocks() will write over those values with their saved versions in the threadData.

• runtime/JSLock.h:

2:24 PM Changeset in webkit [163819] by ap@apple.com

• 2 edits in trunk/LayoutTests

Flaky Test: animations/play-state-suspend.html
​https://bugs.webkit.org/show_bug.cgi?id=50959

• platform/mac/TestExpectations: Marked it as such.

2:19 PM Changeset in webkit [163818] by beidson@apple.com

• 2 edits in trunk/Source/WebKit2

IDB: storage/indexeddb/mozilla/object-store-remove-values.html fails
<rdar://problem/16029319> and ​https://bugs.webkit.org/show_bug.cgi?id=128487

Missed one piece of review feedback before landing.

• DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::~UniqueIDBDatabaseBackingStoreSQLite):

2:15 PM Changeset in webkit [163817] by beidson@apple.com

• 10 edits in trunk

IDB: storage/indexeddb/mozilla/object-store-remove-values.html fails
<rdar://problem/16029319> and ​https://bugs.webkit.org/show_bug.cgi?id=128487

Reviewed by Tim Horton.

Source/WebKit2:

• DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

(WebKit::DatabaseProcessIDBConnection::disconnectedFromWebProcess):
(WebKit::DatabaseProcessIDBConnection::getOrEstablishIDBDatabaseMetadata): Update logging.
(WebKit::DatabaseProcessIDBConnection::deleteDatabase): If deleteDatabase succeeds,

also disconnect from the UniqueIDBDatabase so it can be cleaned up properly.

(WebKit::DatabaseProcessIDBConnection::close): New message from the WebProcess to handle

clean closures.

• DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
• DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:

• DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::shutdown): Move most of the cleanup to didShutdownBackingStore.
(WebKit::UniqueIDBDatabase::didShutdownBackingStore): Execute all remaining mainThreadTasks

(as they represent real results from the backing store thread).

(WebKit::UniqueIDBDatabase::deleteDatabase): Add an ASSERT.
(WebKit::UniqueIDBDatabase::performNextMainThreadTask): Call through to performNextMainThreadTaskWithoutAdoptRef.
(WebKit::UniqueIDBDatabase::performNextMainThreadTaskWithoutAdoptRef): Execute a task,

returning true if there are more tasks left to execute.

• DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:

• DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::~UniqueIDBDatabaseBackingStoreSQLite): Properly

handle JSC cleanup.

• WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::close): Implement this.

LayoutTests:

• platform/mac-wk2/TestExpectations: Add the now-passing test (skipped because of unrelated flakiness in IDB tests)

2:08 PM Changeset in webkit [163816] by jer.noble@apple.com

• 23 edits
  1 add
  2 deletes in trunk/Source/WebCore

[MSE] Fix layering violations in MediaSource
​https://bugs.webkit.org/show_bug.cgi?id=128546

Reviewed by Eric Carlson.

Code in Modules should be considered part of html/ and should have the
same layering properties. Get rid of HTMLMediaSource (which was intended
to allow Modules/mediasource to be considered part of platform/) and add
a new client interface allowing communication from platform/ ->
Modules/mediasource.

Replace HTMLMediaSource -> MediaSourcePrivateClient:

• html/HTMLMediaSource.cpp: Removed.
• html/HTMLMediaSource.h: Removed.
• platform/graphics/MediaSourcePrivateClient.h: Added.

(WebCore::MediaSourcePrivateClient::~MediaSourcePrivateClient):

Move registry support from HTMLMediaSource -> MediaSource.

• Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::setRegistry): Moved from HTMLMediaSource.cpp.

• Modules/mediasource/MediaSource.h:

(WebCore::MediaSource::lookup): Ditto.

Update references to HTMLMediaSource -> MediaSource:

• Modules/mediasource/MediaSourceRegistry.cpp:

(WebCore::MediaSourceRegistry::MediaSourceRegistry):

• WebCore.xcodeproj/project.pbxproj:
• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadResource):

• html/HTMLMediaElement.h:

Update references to HTMLMediaSource -> MediaSourcePrivateClient:

• platform/graphics/MediaPlayer.cpp:

(WebCore::NullMediaPlayerPrivate::load):
(WebCore::MediaPlayer::load): Ditto.
(WebCore::MediaPlayer::loadWithNextMediaEngine):

• platform/graphics/MediaPlayer.h:
• platform/graphics/MediaPlayerPrivate.h:
• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::load):

• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::load):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::load):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
• platform/graphics/gstreamer/MediaSourceGStreamer.cpp:

(WebCore::MediaSourceGStreamer::open):

• platform/graphics/gstreamer/MediaSourceGStreamer.h:
• platform/graphics/ios/MediaPlayerPrivateIOS.h:
• platform/graphics/mac/MediaPlayerPrivateQTKit.h:
• platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::load):

• platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:

(WebCore::MockMediaPlayerMediaSource::load):

• platform/mock/mediasource/MockMediaPlayerMediaSource.h:

2:04 PM Changeset in webkit [163815] by andersca@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Try to fix the Windows build.

• heap/UnconditionalFinalizer.h:
• runtime/SymbolTable.h:

1:57 PM Changeset in webkit [163814] by benjamin@webkit.org

• 5 edits in trunk/Source/WebKit2

[iOS][WK2] Add empty definition for an API allowing clients to define obscured edges over the scrollview
​https://bugs.webkit.org/show_bug.cgi?id=128396

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-02-10
Reviewed by Simon Fraser.

ObscuredInset defines the area of the scrollview unusable for positioning content.
The API is unused in this patch.

• UIProcess/API/Cocoa/WKViewPrivate.h:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _obscuredInset]):
(-[WKWebView _setObscuredInset:]):
(-[WKWebView _commitObscuredInset]):

• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/API/ios/WKViewIOS.mm:

(-[WKView _obscuredInset]):
(-[WKView _setObscuredInset:]):
(-[WKView _commitObscuredInset]):

1:45 PM Changeset in webkit [163813] by Bem Jones-Bey

• 2 edits in trunk/Websites/webkit.org

Change tools.html to say Xcode 5 is required to build
​https://bugs.webkit.org/show_bug.cgi?id=128545

Reviewed by Andreas Kling.

The Mac port doesn't build with Xcode 4.6 anymore, so update to tell
people to get Xcode 5. It looks like Xcode 5 doesn't have the command
line tools in the downloads pane anymore, so direct folks to use
xcode-select to install the command line tools as well.

• building/tools.html:

1:43 PM Changeset in webkit [163812] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Update License copyrights in minified JavaScript
​https://bugs.webkit.org/show_bug.cgi?id=128547

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-02-10
Reviewed by Timothy Hatcher.

• Scripts/copy-user-interface-resources.sh:

1:37 PM Changeset in webkit [163811] by commit-queue@webkit.org

• 1 edit
  2 adds in trunk/LayoutTests

Web Inspector: add test for hitting breakpoints from functions called via console
​https://bugs.webkit.org/show_bug.cgi?id=126845

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-02-10
Reviewed by Timothy Hatcher.

• inspector-protocol/debugger/hit-breakpoint-from-console-expected.txt: Added.
• inspector-protocol/debugger/hit-breakpoint-from-console.html: Added.

1:37 PM Changeset in webkit [163810] by ap@apple.com

• 5 edits in trunk/Source/WebCore

Remove some unused functions from SerializedScriptValue
​https://bugs.webkit.org/show_bug.cgi?id=128407

Reviewed by Oliver Hunt.

Removed functions that used Deprecated::ScriptValue

• Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::put):

• bindings/js/IDBBindingUtilities.cpp:

(WebCore::deserializeIDBValue):
(WebCore::deserializeIDBValueBuffer):

• bindings/js/SerializedScriptValue.cpp:
• bindings/js/SerializedScriptValue.h:

1:11 PM Changeset in webkit [163809] by enrica@apple.com

• 2 edits in trunk/Source/WTF

copyShortASCIIString crashes on iOS after r163793.
​https://bugs.webkit.org/show_bug.cgi?id=128548.

Reviewed by Alexey Proskuryakov.

Adding null check.

• wtf/unicode/icu/CollatorICU.cpp:

(WTF::copyShortASCIIString):

12:39 PM Changeset in webkit [163808] by akling@apple.com

• 4 edits in trunk/Source/JavaScriptCore

Make the Identifier::add() family return PassRef<StringImpl>.
<​https://webkit.org/b/128542>

This knocks one branch off of creating an Identifier from another
string source.

Reviewed by Oliver Hunt.

• runtime/Identifier.cpp:

(JSC::Identifier::add):
(JSC::Identifier::add8):
(JSC::Identifier::addSlowCase):

• runtime/Identifier.h:

(JSC::Identifier::add):

• runtime/Lookup.cpp:

(JSC::HashTable::createTable):

12:18 PM WebKitGTK/2.4.x edited by Carlos Garcia Campos

(diff)

12:07 PM Changeset in webkit [163807] by roger_fong@apple.com

• 2 edits in trunk/Source/WebCore

[Windows] Unreviewed test fix.

• platform/graphics/cg/GraphicsContextCG.cpp: m_pixelSnappingFactor was not set to 1.

(WebCore::GraphicsContext::platformInit):

11:59 AM Changeset in webkit [163806] by mhahnenberg@apple.com

• 1 edit
  2 adds in trunk/LayoutTests

Handling of opaque roots is wrong in EdenCollections
​https://bugs.webkit.org/show_bug.cgi?id=128210

Reviewed by Geoffrey Garen.

Forgot to svn add the regression tests for this bug.

• js/generational-opaque-roots-expected.txt: Added.
• js/script-tests/generational-opaque-roots.js: Added.

11:43 AM Changeset in webkit [163805] by beidson@apple.com

• 2 edits in trunk/LayoutTests

Skip indexeddb tests for now until somebody can explore 128341.
​https://bugs.webkit.org/show_bug.cgi?id=128341

• platform/mac-wk2/TestExpectations:

11:39 AM Changeset in webkit [163804] by mark.lam@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Remove unnecessary spinLock in JSLock.
<​https://webkit.org/b/128450>

Reviewed by Filip Pizlo.

The JSLock's mutex already provides protection for write access to
JSLock's internal state. The only JSLock state that needs to be read
from any thread including threads that don't own the JSLock is
m_ownerThread, which is used in currentThreadIsHoldingLock() to do an
ownership test on the lock.

It is safe for other threads to read from m_ownerThread because they
only need to know whether its value matches their own thread id
(provided by WTF::currentThread()).

Here are the scenarios for how the ownership test can go:

1. The JSLock has just been initialized and is not owned by any thread.

In this case, m_ownerThread will be 0 and will not match any thread's
thread id. The checking thread will know that it needs to lock the
JSLock before using the VM.

2. The JSLock was previously locked, but now is unlocked.

When we unlock it in JSLock::unlock(), the owner thread clears
m_ownerThread to 0. Hence, this case is the same as (1) above.

3. The JSLock is locked by Thread A. Thread B is checking ownership.

In this case, m_ownerThread will contains the Thread A's thread id.
Thread B will see that the thread id does not match its own and will
proceed to block on the JSLock's mutex to wait for its turn to use
the VM.

With Weak Memory Ordering architectures, Thread A's thread id may
not get written out to memory before Thread B inspects m_ownerThread.
However, though Thread B may not see Thread A's thread id in
m_ownerThread, it will see 0 which is the last value written to it
before the JSLock mutex was unlocked. The mutex unlock would have
executed a memory fence which would have flushed the 0 to
m_ownerThread in memory. Hence, Thread B will know that it does not
own the lock.

Apart from removing the unneeded spin lock code, I also changed the
JSLock code to use currentThreadIsHoldingLock() and setOwnerThread()
instead of accessing m_ownerThread directly.

• runtime/JSLock.cpp:

(JSC::JSLock::JSLock):

(JSC::JSLock::lock):

• Removed spinLock but left the indentation as is to keep the diff to a minimum for better readability. Will unindent in a subsequent patch.

(JSC::JSLock::unlock):

• Before unlocking the mutex, clear m_ownerThread to indicate that the lock is no longer owned.

(JSC::JSLock::currentThreadIsHoldingLock):

• Removed the check of m_lockCount for determining ownership. Checking m_ownerThread is sufficient.

(JSC::JSLock::dropAllLocks):
(JSC::JSLock::dropAllLocksUnconditionally):

• Renamed local locksToDrop to the better name droppedLockCount.
• Clear m_ownerThread since we're unlocking the JSLock.

(JSC::JSLock::grabAllLocks):

• Removed unneeded lock ownership test for lock re-entry case because grabAllLocks() is never used to re-enter a locked JSLock.

(JSC::JSLock::DropAllLocks::DropAllLocks):
(JSC::JSLock::DropAllLocks::~DropAllLocks):

• runtime/JSLock.h:

(JSC::JSLock::setOwnerThread):

11:32 AM Changeset in webkit [163803] by fpizlo@apple.com

• 1 edit in trunk/Source/JavaScriptCore/ChangeLog

Unbreak ChangeLog after r163802

11:27 AM HackingWebInspector edited by BJ Burg

Update to use new paths, webkit-patch, etc (diff)

11:26 AM Changeset in webkit [163802] by fpizlo@apple.com

• 91 edits in trunk/Source/JavaScriptCore

Unreviewed, roll out ​http://trac.webkit.org/changeset/163796

The change was not justified in any way and it has a net negative effect on the code.

• dfg/DFGAbstractInterpreter.h:
• dfg/DFGAbstractValue.h:
• dfg/DFGAdjacencyList.h:
• dfg/DFGArgumentPosition.h:
• dfg/DFGArgumentsSimplificationPhase.cpp:
• dfg/DFGArrayMode.cpp:
• dfg/DFGArrayifySlowPathGenerator.h:
• dfg/DFGAtTailAbstractState.h:
• dfg/DFGAvailability.h:
• dfg/DFGBackwardsPropagationPhase.cpp:
• dfg/DFGBasicBlock.h:
• dfg/DFGBasicBlockInlines.h:
• dfg/DFGByteCodeParser.cpp:
• dfg/DFGCFAPhase.cpp:
• dfg/DFGCFGSimplificationPhase.cpp:
• dfg/DFGCPSRethreadingPhase.cpp:
• dfg/DFGCSEPhase.cpp:
• dfg/DFGCallArrayAllocatorSlowPathGenerator.h:
• dfg/DFGCapabilities.cpp:
• dfg/DFGCapabilities.h:
• dfg/DFGClobberize.h:
• dfg/DFGCommonData.cpp:
• dfg/DFGConstantFoldingPhase.cpp:
• dfg/DFGCriticalEdgeBreakingPhase.cpp:
• dfg/DFGDCEPhase.cpp:
• dfg/DFGDominators.h:
• dfg/DFGDriver.cpp:
• dfg/DFGDriver.h:
• dfg/DFGFixupPhase.cpp:
• dfg/DFGFlushLivenessAnalysisPhase.cpp:
• dfg/DFGGenerationInfo.h:
• dfg/DFGGraph.cpp:
• dfg/DFGGraph.h:
• dfg/DFGInPlaceAbstractState.cpp:
• dfg/DFGInPlaceAbstractState.h:
• dfg/DFGInlineCacheWrapperInlines.h:
• dfg/DFGInvalidationPointInjectionPhase.cpp:
• dfg/DFGJITCode.h:
• dfg/DFGJITCompiler.cpp:
• dfg/DFGJITCompiler.h:
• dfg/DFGJITFinalizer.cpp:
• dfg/DFGJITFinalizer.h:
• dfg/DFGLICMPhase.cpp:
• dfg/DFGLivenessAnalysisPhase.cpp:
• dfg/DFGLoopPreHeaderCreationPhase.cpp:
• dfg/DFGMinifiedNode.h:
• dfg/DFGNaturalLoops.h:
• dfg/DFGNode.cpp:
• dfg/DFGNode.h:
• dfg/DFGOSRAvailabilityAnalysisPhase.cpp:
• dfg/DFGOSREntry.cpp:
• dfg/DFGOSREntrypointCreationPhase.cpp:
• dfg/DFGOSRExit.cpp:
• dfg/DFGOSRExit.h:
• dfg/DFGOSRExitBase.cpp:
• dfg/DFGOSRExitCompilationInfo.h:
• dfg/DFGOSRExitCompiler.cpp:
• dfg/DFGOSRExitCompiler32_64.cpp:
• dfg/DFGOSRExitCompiler64.cpp:
• dfg/DFGOSRExitJumpPlaceholder.cpp:
• dfg/DFGOperations.cpp:
• dfg/DFGPhase.h:
• dfg/DFGPlan.h:
• dfg/DFGPredictionInjectionPhase.cpp:
• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGResurrectionForValidationPhase.cpp:
• dfg/DFGSSAConversionPhase.cpp:
• dfg/DFGSSALoweringPhase.cpp:
• dfg/DFGSaneStringGetByValSlowPathGenerator.h:
• dfg/DFGSlowPathGenerator.h:
• dfg/DFGSpeculativeJIT.cpp:
• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:
• dfg/DFGSpeculativeJIT64.cpp:
• dfg/DFGStackLayoutPhase.cpp:
• dfg/DFGStoreBarrierElisionPhase.cpp:
• dfg/DFGStrengthReductionPhase.cpp:
• dfg/DFGThunks.cpp:
• dfg/DFGTierUpCheckInjectionPhase.cpp:
• dfg/DFGTypeCheckHoistingPhase.cpp:
• dfg/DFGUnificationPhase.cpp:
• dfg/DFGValidate.h:
• dfg/DFGValueSource.h:
• dfg/DFGVariableAccessData.h:
• dfg/DFGVariableAccessDataDump.cpp:
• dfg/DFGVariableEvent.h:
• dfg/DFGVariableEventStream.h:
• dfg/DFGVirtualRegisterAllocationPhase.cpp:
• dfg/DFGWatchpointCollectionPhase.cpp:
• dfg/DFGWorklist.cpp:

11:25 AM Changeset in webkit [163801] by Michał Pakuła vel Rutka

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening

Add test expectations for crashing tests.

• platform/efl-wk2/TestExpectations:

11:03 AM WikiStart edited by BJ Burg

fix Web Inspector link names (diff)

10:59 AM Changeset in webkit [163800] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebKit2

Add API for accessing session ephemerality from a page bundle
​https://bugs.webkit.org/show_bug.cgi?id=128410

Patch by Martin Hock <​mhock@apple.com> on 2014-02-10
Reviewed by Alexey Proskuryakov.

• WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageIsUsingEphemeralSession):

• WebProcess/InjectedBundle/API/c/WKBundlePage.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::isUsingEphemeralSession):

• WebProcess/WebPage/WebPage.h:

10:54 AM Changeset in webkit [163799] by Carlos Garcia Campos

• 5 edits in trunk/Source/WebKit2

[GTK] Create the inspector view using the same web process as the inspected page
​https://bugs.webkit.org/show_bug.cgi?id=128539

Reviewed by Martin Robinson.

• UIProcess/API/C/gtk/WKView.cpp:

(WKViewCreate): Pass nullptr as the related page.

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseCreate): Add related page argument and pass it
to webkitWebViewBaseCreateWebPage() instead of nullptr.

• UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
• UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage): Pass
m_page as related page to webkitWebViewBaseCreate().

10:51 AM Changeset in webkit [163798] by ap@apple.com

• 2 edits in trunk/LayoutTests

REGRESSION(r163660-r163664): js/dom/stack-trace.html fails
​https://bugs.webkit.org/show_bug.cgi?id=128544

• TestExpectations: Marked as such (possibly passing on other platforms?)

10:22 AM Changeset in webkit [163797] by Carlos Garcia Campos

• 65 edits
  4 deletes in trunk

[GLIB] Add GUniqueOutPtr and use it instead of GOwnPtr
​https://bugs.webkit.org/show_bug.cgi?id=127554

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Use GUniqueOutPtr instead of GOwnPtr.

• GNUmakefile.list.am:
• PlatformEfl.cmake:
• PlatformGTK.cmake:
• platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestinationGStreamer::handleMessage):

• platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::handleMessage):

• platform/glib/BatteryProviderUPower.cpp:

(BatteryProviderUPower::startUpdating):

• platform/graphics/gstreamer/GStreamerUtilities.cpp:

(WebCore::initializeGStreamer):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::handleMessage):

• platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:

(WebCore::TrackPrivateBaseGStreamer::getTag):

• platform/graphics/gtk/ImageBufferGtk.cpp:

(WebCore::encodeImage):
(WebCore::ImageBuffer::toDataURL):

• platform/graphics/gtk/ImageGtk.cpp:

(WebCore::loadResourceSharedBuffer):

• platform/gtk/DataObjectGtk.cpp:

(WebCore::DataObjectGtk::setURIList):

• platform/gtk/FileSystemGtk.cpp:

(WebCore::readFromFile):

• platform/gtk/GamepadsGtk.cpp:

(WebCore::GamepadDeviceGtk::readCallback):

• platform/gtk/GtkInputMethodFilter.cpp:

(WebCore::GtkInputMethodFilter::handlePreeditChanged):

• platform/gtk/PasteboardHelper.cpp:

(WebCore::PasteboardHelper::fillDataObjectFromDropData):

• platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::systemFont):

• platform/gtk/SharedBufferGtk.cpp:

(WebCore::SharedBuffer::createWithContentsOfFile):

• platform/network/gtk/CredentialBackingStore.cpp:

(WebCore::credentialForChallengeAsyncReadyCallback):

• platform/network/soup/GOwnPtrSoup.cpp: Removed.
• platform/network/soup/GOwnPtrSoup.h: Removed.
• platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::redirectSkipCallback):
(WebCore::nextMultipartResponsePartCallback):
(WebCore::sendRequestCallback):
(WebCore::addFileToSoupMessageBody):
(WebCore::createSoupRequestAndMessageForHandle):
(WebCore::readCallback):

• platform/network/soup/SocketStreamHandleSoup.cpp:

(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):
(WebCore::connectedCallback):
(WebCore::readReadyCallback):

• platform/network/soup/SoupNetworkSession.cpp:

(WebCore::SoupNetworkSession::httpProxy):

Source/WebKit/gtk:

Use GUniqueOutPtr instead of GOwnPtr.

• WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidFailLoad):

• WebCoreSupport/TextCheckerClientGtk.cpp:
• webkit/webkitdownload.cpp:

(webkit_download_open_stream_for_uri):
(webkit_download_set_destination_uri):
(webkit_download_received_data):

• webkit/webkitwebplugin.cpp:

(webkit_web_plugin_get_path):

• webkit/webkitwebview.cpp:

(webkit_web_view_expose_event):

Source/WebKit2:

Use GUniqueOutPtr instead of GOwnPtr.

• NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::getCacheDiskFreeSize):

• Shared/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::didReceiveResponse):
(WebKit::DownloadClient::didReceiveData):
(WebKit::DownloadClient::didFinishLoading):

• UIProcess/API/gtk/WebKitFaviconDatabase.cpp:

(processPendingIconsForPageURL):
(webkit_favicon_database_get_favicon):

• UIProcess/API/gtk/WebKitURISchemeRequest.cpp:

(webkitURISchemeRequestReadCallback):

• UIProcess/API/gtk/WebKitWebView.cpp:

(gotFaviconCallback):

• UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:

(WebKit::WebInspectorServer::platformResourceForPath):

• UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::ProcessLauncher::launchProcess):

• UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:

(WebKit::PluginProcessProxy::scanPlugin):

• WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
• WebProcess/soup/WebProcessSoup.cpp:

(WebKit::getCacheDiskFreeSize):

Source/WTF:

GUniqueOutPtr is a simplified version of GOwnPtr for the cases
where we need the address of the contained pointer. GUniqueOutPtr
uses GUniquePtr to free the contained object and to release the
container pointer. The API is very simple to make sure this is
only used when outPtr() is needed. It can't be constructed with a
pointer, and there's not method to set a new pointer. Another
difference with the old GOwnPtr is that outPtr() can be used
multiple times, because it frees any pointer previously set.

• GNUmakefile.list.am:
• wtf/PlatformEfl.cmake:
• wtf/PlatformGTK.cmake:
• wtf/gobject/GOwnPtr.cpp: Removed.
• wtf/gobject/GOwnPtr.h: Removed.
• wtf/gobject/GUniquePtr.h:

(WTF::GUniqueOutPtr::GUniqueOutPtr):
(WTF::GUniqueOutPtr::~GUniqueOutPtr):
(WTF::GUniqueOutPtr::outPtr):
(WTF::GUniqueOutPtr::reset):
(WTF::GUniqueOutPtr::release):
(WTF::GUniqueOutPtr::operator*):
(WTF::GUniqueOutPtr::operator->):
(WTF::GUniqueOutPtr::get):
(WTF::GUniqueOutPtr::operator!):
(WTF::GUniqueOutPtr::operator UnspecifiedBoolType):

Tools:

Use GUniqueOutPtr instead of GOwnPtr.

• DumpRenderTree/gtk/DumpRenderTree.cpp:
• DumpRenderTree/gtk/EventSender.cpp:

(createKeyPressEvent):

• TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp:

(TestWebKitAPI::returnOutChar):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
• TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:

(testInspectorServerPageList):
(openRemoteDebuggingSession):
(sendIncompleteRequest):

• TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
• TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:

(testWebExtensionWindowObjectCleared):
(testWebExtensionIsolatedWorld):

• TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
• TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:

(testWebViewRunJavaScript):
(testWebViewSave):
(testWebViewPageVisibility):

• TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:

(isStyleSheetInjectedForURLAtPath):

• TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
• TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
• TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
• TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:

(TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):

• TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:

(TestWebKitAPI::doKeyStroke):

• TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
• TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:

(WebKitTestBus::run):

• TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:

(resourceGetDataCallback):
(WebViewTest::keyStroke):
(onSnapshotReady):

• WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::EventSenderProxy::keyDown):

10:20 AM Changeset in webkit [163796] by commit-queue@webkit.org

• 91 edits in trunk/Source/JavaScriptCore

Remove extra includes from DFG
​https://bugs.webkit.org/show_bug.cgi?id=126983

Patch by Peter Molnar <​pmolnar.u-szeged@partner.samsung.com> on 2014-02-10
Reviewed by Andreas Kling.

• dfg/DFGAbstractInterpreter.h:
• dfg/DFGAbstractValue.h:
• dfg/DFGAdjacencyList.h:
• dfg/DFGArgumentPosition.h:
• dfg/DFGArgumentsSimplificationPhase.cpp:
• dfg/DFGArrayMode.cpp:
• dfg/DFGArrayifySlowPathGenerator.h:
• dfg/DFGAtTailAbstractState.h:
• dfg/DFGAvailability.h:
• dfg/DFGBackwardsPropagationPhase.cpp:
• dfg/DFGBasicBlock.h:
• dfg/DFGBasicBlockInlines.h:
• dfg/DFGByteCodeParser.cpp:
• dfg/DFGCFAPhase.cpp:
• dfg/DFGCFGSimplificationPhase.cpp:
• dfg/DFGCPSRethreadingPhase.cpp:
• dfg/DFGCSEPhase.cpp:
• dfg/DFGCallArrayAllocatorSlowPathGenerator.h:
• dfg/DFGCapabilities.cpp:
• dfg/DFGCapabilities.h:
• dfg/DFGClobberize.h:
• dfg/DFGCommonData.cpp:
• dfg/DFGConstantFoldingPhase.cpp:
• dfg/DFGCriticalEdgeBreakingPhase.cpp:
• dfg/DFGDCEPhase.cpp:
• dfg/DFGDominators.h:
• dfg/DFGDriver.cpp:
• dfg/DFGDriver.h:
• dfg/DFGFixupPhase.cpp:
• dfg/DFGFlushLivenessAnalysisPhase.cpp:
• dfg/DFGGenerationInfo.h:
• dfg/DFGGraph.cpp:
• dfg/DFGGraph.h:
• dfg/DFGInPlaceAbstractState.cpp:
• dfg/DFGInPlaceAbstractState.h:
• dfg/DFGInlineCacheWrapperInlines.h:
• dfg/DFGInvalidationPointInjectionPhase.cpp:
• dfg/DFGJITCode.h:
• dfg/DFGJITCompiler.cpp:
• dfg/DFGJITCompiler.h:
• dfg/DFGJITFinalizer.cpp:
• dfg/DFGJITFinalizer.h:
• dfg/DFGLICMPhase.cpp:
• dfg/DFGLivenessAnalysisPhase.cpp:
• dfg/DFGLoopPreHeaderCreationPhase.cpp:
• dfg/DFGMinifiedNode.h:
• dfg/DFGNaturalLoops.h:
• dfg/DFGNode.cpp:
• dfg/DFGNode.h:
• dfg/DFGOSRAvailabilityAnalysisPhase.cpp:
• dfg/DFGOSREntry.cpp:
• dfg/DFGOSREntrypointCreationPhase.cpp:
• dfg/DFGOSRExit.cpp:
• dfg/DFGOSRExit.h:
• dfg/DFGOSRExitBase.cpp:
• dfg/DFGOSRExitCompilationInfo.h:
• dfg/DFGOSRExitCompiler.cpp:
• dfg/DFGOSRExitCompiler32_64.cpp:
• dfg/DFGOSRExitCompiler64.cpp:
• dfg/DFGOSRExitJumpPlaceholder.cpp:
• dfg/DFGOperations.cpp:
• dfg/DFGPhase.h:
• dfg/DFGPlan.h:
• dfg/DFGPredictionInjectionPhase.cpp:
• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGResurrectionForValidationPhase.cpp:
• dfg/DFGSSAConversionPhase.cpp:
• dfg/DFGSSALoweringPhase.cpp:
• dfg/DFGSaneStringGetByValSlowPathGenerator.h:
• dfg/DFGSlowPathGenerator.h:
• dfg/DFGSpeculativeJIT.cpp:
• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:
• dfg/DFGSpeculativeJIT64.cpp:
• dfg/DFGStackLayoutPhase.cpp:
• dfg/DFGStoreBarrierElisionPhase.cpp:
• dfg/DFGStrengthReductionPhase.cpp:
• dfg/DFGThunks.cpp:
• dfg/DFGTierUpCheckInjectionPhase.cpp:
• dfg/DFGTypeCheckHoistingPhase.cpp:
• dfg/DFGUnificationPhase.cpp:
• dfg/DFGValidate.h:
• dfg/DFGValueSource.h:
• dfg/DFGVariableAccessData.h:
• dfg/DFGVariableAccessDataDump.cpp:
• dfg/DFGVariableEvent.h:
• dfg/DFGVariableEventStream.h:
• dfg/DFGVirtualRegisterAllocationPhase.cpp:
• dfg/DFGWatchpointCollectionPhase.cpp:
• dfg/DFGWorklist.cpp:

10:09 AM Changeset in webkit [163795] by timothy_horton@apple.com

• 4 edits in trunk/Source/WebKit2

[iOS][wk2] WebKit2 View Gestures (Swipe): Forward swipe gesture
​https://bugs.webkit.org/show_bug.cgi?id=128523
<rdar://problem/16020378>

Reviewed by Darin Adler.

We can't install the gesture recognizer on a view that's going to be
reparented during the swipe, because the gesture will be cancelled.
Install the recognizer on the WKView and move the WKView's scrollview
child around instead.

• UIProcess/API/ios/WKViewIOS.mm:

(-[WKView setAllowsBackForwardNavigationGestures:]):
We'll install the gesture recognizer on the WKView, but swipe the scrollview.

• UIProcess/ios/ViewGestureControllerIOS.mm:

(-[WKSwipeTransitionController initWithViewGestureController:gestureRecognizerView:]):
Clarify that WKSwipeTransitionController gets handed only the view to install the gesture recognizer on.
(-[WKSwipeTransitionController gestureRecognizerForInteractiveTransition:WithTarget:action:]):
Use public enum values so we can get rid of one private header.

(WebKit::ViewGestureController::installSwipeHandler):
Separate out the gesture recognizer view from the one that gets swiped.

(WebKit::ViewGestureController::beginSwipeGesture):
Record a snapshot before beginning the swipe. This is important for the back-then-forward
swipe case, and matches the behavior of the Mac implementation.

(WebKit::ViewGestureController::endSwipeGesture):

• UIProcess/mac/ViewGestureController.h:

Slight geometry adjustments due to the change in targetted view.

10:02 AM Changeset in webkit [163794] by fpizlo@apple.com

• 5 edits in trunk/Source

JSC environment variables should override other mechanisms for setting options
​https://bugs.webkit.org/show_bug.cgi?id=128511

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

• runtime/Options.cpp:

(JSC::Options::setOption):

• runtime/Options.h:

Source/WebKit2:

• WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

9:58 AM Changeset in webkit [163793] by Darin Adler

• 29 edits in trunk/Source/WebCore

Automatically generate isRendererOfType in RENDER_OBJECT_TYPE_CASTS
​https://bugs.webkit.org/show_bug.cgi?id=128520

Reviewed by Andreas Kling.

• rendering/RenderObject.h: Updated the RENDER_OBJECT_TYPE_CASTS macro so

that it generates isRendererOfType specializations as well as type casts
and also have the type casts use the isRendererOfType function. The macro
also now uses an argument name of "renderer" and allows for a predicate
that is more than just a single function call (see RenderTextFragment.h).

• rendering/RenderBlock.h:
• rendering/RenderBlockFlow.h:
• rendering/RenderBox.h:
• rendering/RenderBoxModelObject.h:
• rendering/RenderCounter.h:
• rendering/RenderElement.h:
• rendering/RenderFrameSet.h:
• rendering/RenderLayerModelObject.h:
• rendering/RenderMenuList.h:
• rendering/RenderNamedFlowThread.h:
• rendering/RenderRubyRun.h:
• rendering/RenderTableSection.h:
• rendering/RenderText.h:
• rendering/mathml/RenderMathMLBlock.h:
• rendering/mathml/RenderMathMLOperator.h:
• rendering/mathml/RenderMathMLToken.h:
• rendering/svg/RenderSVGRoot.h:
• rendering/svg/RenderSVGText.h:

Removed specialization of isRendererOfType, since the RENDER_OBJECT_TYPE_CASTS
macro handles that now. Also removed some unneeded semicolons.

• rendering/RenderTextFragment.h: Use RENDER_OBJECT_TYPE_CASTS instead of

hand written casts, now that it can handle a non-trivial predicate.

• rendering/RenderCombineText.h:
• rendering/RenderDetailsMarker.h:
• rendering/RenderListMarker.h:
• rendering/RenderVideo.h:
• rendering/RenderView.h:
• rendering/mathml/RenderMathMLFraction.h:
• rendering/mathml/RenderMathMLScripts.h:
• rendering/mathml/RenderMathMLSpace.h:

Removed unneeded semicolons.

9:46 AM Changeset in webkit [163792] by Darin Adler

• 8 edits in trunk/Source

Stop using String::deprecatedCharacters to call WTF::Collator
​https://bugs.webkit.org/show_bug.cgi?id=128517

Source/JavaScriptCore:

Reviewed by Alexey Proskuryakov.

• runtime/StringPrototype.cpp:

(JSC::stringProtoFuncLocaleCompare): Use the default constructor for Collator, which now
gives the default locale collation rules. Use the new arguments for Collator::collate, which
are now StringView. These two changes together eliminate the need for a separate helper function.

Source/WebCore:

Reviewed by Alexey Proskuryakov.

• xml/XSLTUnicodeSort.cpp:

(WebCore::xsltUnicodeSortFunction): Create the collator in a single line using the
new constructor that takes a shouldSortLowercaseFirst boolean. Use the new
collateUTF8 function instead of upconverting UTF-8 strings to UTF-16 as the old code did.

Source/WTF:

WTF passes ICU’s deprecated ULOC_REQUESTED_LOCALE to ucol_getLocaleByType()
rdar://problem/15183390

Reviewed by Alexey Proskuryakov.

This patch fixes both bugs above by reworking WTF::Collator.

• wtf/unicode/Collator.h: Fixed formatting. Got rid of the Collator::Result type,

since the collator uses the same return value scheme as strcmp and as ICU; an int
will do for the return type. Simplified the support for UCONFIG_NO_COLLATION by
using a separate copy of the class definition. (We should check if anyone needs
UCONFIG_NO_COLLATION support, and remove it if not.) Changed the lower-first flag
from a separate function to a constructor argument. Changed the arguments to
the collate function to StringView. Added a collate UTF8 function. Changed the
m_collate data member to no longer be mutable since we no longer allocate it lazily.

• wtf/unicode/CollatorDefault.cpp:

(WTF::Collator::collate): Rewrote to be simpler.
(WTF::Collator::collateUTF8): Added. Converts from UTF-8 to a String and then calls
the collate function above.

• wtf/unicode/icu/CollatorICU.cpp: Added a FIXME about the fact that this file

has the wrong name and location. Since we always use ICU, there's no need to mention
it in the file name.
(WTF::copyASCIIString): Added.
(WTF::copyDefaultLocale): Added.
(WTF::resolveDefaultLocale): Added. Maps null locale to a default on Mac and iOS,
since on those platforms ICU does not use the correct default locale when passed null.
(WTF::localesMatch): Added.
(WTF::Collator::Collator): Moved most of the code from createCollator here.
Simplified it by storing the collator configuration along with the collator in globals.
(WTF::Collator::~Collator): Moved most of the code from releaseCollator here.
(WTF::getIndexLatin1): Added.
(WTF::moveLatin1): Added.
(WTF::hasNextLatin1): Added.
(WTF::hasPreviousLatin1): Added.
(WTF::currentLatin1): Added.
(WTF::nextLatin1): Added.
(WTF::previousLatin1): Added.
(WTF::getStateLatin1): Added.
(WTF::setStateLatin1): Added.
(WTF::createLatin1Iterator): Added. Uses the functions above to make a UCharIterator
that works for a WTF::StringView-style Latin-1 string.
(WTF::createIterator): Added. Uses either createLatin1Iterator or uiter_setString to
make a UCharIterator that works for a WTF::StringView.
(WTF::Collator::collate): Changed to use ucol_strcollIter.
(WTF::createIteratorUTF8): Added. Uses uiter_setUTF8.
(WTF::Collator::collateUTF8): Added. Like collate, but for null-terminated UTF-8 strings.

9:37 AM Changeset in webkit [163791] by fpizlo@apple.com

• 2 edits in trunk/LayoutTests

Skip fast/workers/dedicated-worker-lifecycle
​https://bugs.webkit.org/show_bug.cgi?id=128537

• TestExpectations:

9:06 AM Changeset in webkit [163790] by fpizlo@apple.com

• 2 edits in trunk/PerformanceTests/SunSpider

Unreviewed, revert the accidental change from r163789.

• tests/v8-v6/v8-deltablue.js:

9:04 AM Changeset in webkit [163789] by fpizlo@apple.com

• 7 edits
  2 adds in trunk

<1/100 probability FTL failure: v8-v6/v8-deltablue.js.ftl-eager: Exception: TypeError: undefined is not an object (evaluating 'c.isInput')
​https://bugs.webkit.org/show_bug.cgi?id=128278

Reviewed by Mark Hahnenberg.

Fix another FTL flake due to bytecode liveness corner cases. Hopefully it's the last
one.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock): Make sure that inside a constructor, the 'this' result is always set. This makes it easier to unify the treatment of 'this' for OSR exit: we just say that it's always live.

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::isLiveInBytecode): Assume that 'this' is live. We were already sort of doing this for calls because the callsite would claim it to be live. But we didn't do it for constructors. It's true that *at the callsite* 'this' won't be live, but inside the inlined constructor, it almost certainly will be.

• dfg/DFGTierUpCheckInjectionPhase.cpp:

(JSC::DFG::TierUpCheckInjectionPhase::run): I just noticed this benign bug. We should only return 'true' if we actually injected checks.

• ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub): Make it easier to just dump disassembly for FTL OSR exits.

• runtime/Options.h: Ditto.
• tests/stress/inlined-constructor-this-liveness.js: Added.

(Foo):
(foo):

• tests/stress/inlined-function-this-liveness.js: Added.

(bar):
(foo):

8:53 AM Changeset in webkit [163788] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Remove unnecessary comment lines.
​https://bugs.webkit.org/show_bug.cgi?id=127894

Patch by Changhun Kang <​temoochin@company100.net> on 2014-02-10
Reviewed by Darin Adler.

No new tests. No change in behavior.

• Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::clientHandshakeRequest):

8:50 AM Changeset in webkit [163787] by fpizlo@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Actually register those DFG::Safepoints
​https://bugs.webkit.org/show_bug.cgi?id=128521

Reviewed by Mark Hahnenberg.

No test because GC + thread + JIT = ???.

• dfg/DFGSafepoint.cpp:

(JSC::DFG::Safepoint::~Safepoint):
(JSC::DFG::Safepoint::begin):

8:02 AM Changeset in webkit [163786] by commit-queue@webkit.org

• 3 edits in trunk

Add the CSS_SHAPE_INSIDE to CMake feature list
​https://bugs.webkit.org/show_bug.cgi?id=128530

Patch by Krzysztof Wolanski <​k.wolanski@samsung.com> on 2014-02-10
Reviewed by Gyuyoung Kim.

CSS_SHAPE_INSIDE flag was added in r163333,
this patch is adding this flag to CMake feature list.

• Source/cmake/WebKitFeatures.cmake:
• Source/cmakeconfig.h.cmake:

7:41 AM Changeset in webkit [163785] by mihnea@adobe.com

• 1 edit
  4 adds in trunk/LayoutTests

[CSSRegions] Add tests for scrolling composited content
​https://bugs.webkit.org/show_bug.cgi?id=128527

Reviewed by Andrei Bucur.

Add tests take simulate scrolling in the context of regions and composited content:

1. scroll an empty region that is composited
2. scroll a region that displays composited content

• compositing/regions/composited-content-fixed-region-scrolled-expected.txt: Added.
• compositing/regions/composited-content-fixed-region-scrolled.html: Added.
• compositing/regions/fixed-empty-region-scrolled-expected.txt: Added.
• compositing/regions/fixed-empty-region-scrolled.html: Added.

7:00 AM Changeset in webkit [163784] by Carlos Garcia Campos

• 11 edits in releases/WebKitGTK/webkit-2.4

Merge r163781 - [GTK] Add API to create a webview related to another one
​https://bugs.webkit.org/show_bug.cgi?id=128498

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

Add webkit_web_view_new_with_related_view() to create a new
WebView sharing the same web process as the given one.

• UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextCreatePageForWebView): Use the given related
WebView to pass a related WebPageProxy to webkitWebViewBaseCreateWebPage().

• UIProcess/API/gtk/WebKitWebContextPrivate.h:
• UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed): Pass the related web view to webkitWebContextCreatePageForWebView().
(webkitWebViewSetProperty):
(webkit_web_view_class_init): Add related-view construct-only property.
(webkit_web_view_new_with_related_view): New public method to
create a web view with a related one.

• UIProcess/API/gtk/WebKitWebView.h:
• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseCreate): Pass nullptr as related page to webkitWebViewBaseCreateWebPage().
(webkitWebViewBaseCreateWebPage): Use the given related
WebPageProxy to initialize the web page configuration.

• UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
• UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.

Tools:

• MiniBrowser/gtk/BrowserWindow.c:

(webViewCreate): Use webkit_web_view_new_with_related_view() when
creating a new web view for window.open().

• TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:

(testMultiprocessWebViewCreateReadyClose): Add test case to check
that window.open() works when creating the new WebView related to
the existing one, and that no new web process is spawned when
using webkit_web_view_new_with_related_view().
(beforeAll):

6:55 AM Changeset in webkit [163783] by Carlos Garcia Campos

• 10 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2

Merge r163671 - Simplify web page creation
​https://bugs.webkit.org/show_bug.cgi?id=128425

Reviewed by Andreas Kling.

Add a WebPageConfiguration class and stick the page group, preferences, session etc there
instead of adding more and more parameters to the WebPageProxy constructor.

Make WebContext::createWebPage fill in the missing pieces in the WebPageConfiguration object.

• UIProcess/API/ios/WKContentView.mm:

(-[WKContentView initWithFrame:configuration:]):
(-[WKContentView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):

• UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

• UIProcess/WebContext.cpp:

(WebKit::WebContext::createWebPage):

• UIProcess/WebContext.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):

• UIProcess/WebPageProxy.h:
• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createWebPage):

• UIProcess/WebProcessProxy.h:

6:22 AM Changeset in webkit [163782] by Carlos Garcia Campos

• 6 edits in releases/WebKitGTK/webkit-2.4

Merge r163698 - [GTK] Make process model names properly meaningful
​https://bugs.webkit.org/show_bug.cgi?id=128389

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2014-02-08
Reviewed by Carlos Garcia Campos.

The name WEBKIT_PROCESS_MODEL_ONE_SECONDARY_PROCESS_PER_WEB_VIEW
is misleading because there are situations in which web views may
share the same web process even when multi-process mode is enabled;
for example when opening a related view and both interact using JS.

Source/WebKit2:

• UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_set_process_model):
(webkit_web_context_get_process_model):
Update names of WebKitProcessModel enum values.

• UIProcess/API/gtk/WebKitWebContext.h:

Ditto.

Tools:

• MiniBrowser/gtk/main.c:

(main):
Update usage of WebKitProcessModel enum values.

• TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:

(beforeAll):
Ditto.

6:19 AM WebKitGTK/StartHacking edited by Andres Gomez

(diff)

6:18 AM WebKitGTK/StartHacking edited by Andres Gomez

(diff)

5:46 AM Changeset in webkit [163781] by Carlos Garcia Campos

• 11 edits in trunk

[GTK] Add API to create a webview related to another one
​https://bugs.webkit.org/show_bug.cgi?id=128498

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

Add webkit_web_view_new_with_related_view() to create a new
WebView sharing the same web process as the given one.

• UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextCreatePageForWebView): Use the given related
WebView to pass a related WebPageProxy to webkitWebViewBaseCreateWebPage().

• UIProcess/API/gtk/WebKitWebContextPrivate.h:
• UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed): Pass the related web view to webkitWebContextCreatePageForWebView().
(webkitWebViewSetProperty):
(webkit_web_view_class_init): Add related-view construct-only property.
(webkit_web_view_new_with_related_view): New public method to
create a web view with a related one.

• UIProcess/API/gtk/WebKitWebView.h:
• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseCreate): Pass nullptr as related page to webkitWebViewBaseCreateWebPage().
(webkitWebViewBaseCreateWebPage): Use the given related
WebPageProxy to initialize the web page configuration.

• UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
• UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.

Tools:

• MiniBrowser/gtk/BrowserWindow.c:

(webViewCreate): Use webkit_web_view_new_with_related_view() when
creating a new web view for window.open().

• TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:

(testMultiprocessWebViewCreateReadyClose): Add test case to check
that window.open() works when creating the new WebView related to
the existing one, and that no new web process is spawned when
using webkit_web_view_new_with_related_view().
(beforeAll):

5:16 AM Changeset in webkit [163780] by commit-queue@webkit.org

• 3 edits in trunk/Tools

If not running on Mac, build-webkit should not print Safari related output
​https://bugs.webkit.org/show_bug.cgi?id=127169

Patch by Eva Balazsfalvi <​balazsfalvi.eva@stud.u-szeged.hu> on 2014-02-10
Reviewed by Darin Adler.

• Scripts/build-webkit:

(writeCongrats):

• Scripts/webkitdirs.pm:

(isAppleWebKit):
(isAppleMacWebKit):
(isAppleWinWebKit):
(launcherName):

5:04 AM Changeset in webkit [163779] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebKit2

[EFL] Spelling unit tests should use ecore_main_loop_iterate()
​https://bugs.webkit.org/show_bug.cgi?id=127427

Patch by Lukasz Bialek <​l.bialek@samsung.com> on 2014-02-10
Reviewed by Gyuyoung Kim.

r148670 gets rid of EFL's idlers in a favor of timers to load languages.
ecore_main_loop_iterate() can be used now.

Add function that loads spellchecking languages and waits for loading
to be finished:

• UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:

(EWK2UnitTest::EWK2UnitTestBase::waitForLanguageLoading):

• UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:

Apply added function to tests that should wait for languages to be loaded:

• UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:

(EWK2TextCheckerTest::resetCallbacksExecutionStats):
(TEST_F):

5:02 AM Changeset in webkit [163778] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[GTK] Minibrowser: During text search, make navigation through list of matched words circular
​https://bugs.webkit.org/show_bug.cgi?id=128463

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-02-10
Reviewed by Carlos Garcia Campos.

Initialize search options to WEBKIT_FIND_OPTIONS_WRAP_AROUND to make navigation
circular.

• MiniBrowser/gtk/BrowserSearchBar.c:

(doSearch):

3:41 AM Changeset in webkit [163777] by commit-queue@webkit.org

• 11 edits in trunk/Source

Fix EFL build with INSPECTOR disabled
​https://bugs.webkit.org/show_bug.cgi?id=125064

Patch by Peter Molnar <​pmolnar.u-szeged@partner.samsung.com> on 2014-02-10
Reviewed by Csaba Osztrogonác.

Source/JavaScriptCore:

• inspector/InjectedScriptManager.h:
• inspector/ScriptDebugServer.cpp:
• inspector/agents/InspectorAgent.h:
• inspector/scripts/CodeGeneratorInspectorStrings.py:

(Inspector):

Source/WebCore:

• bindings/js/PageScriptDebugServer.cpp:
• bindings/js/PageScriptDebugServer.h:
• bindings/js/WorkerScriptDebugServer.cpp:
• bindings/js/WorkerScriptDebugServer.h:
• inspector/PageInjectedScriptManager.h:

3:25 AM Changeset in webkit [163776] by commit-queue@webkit.org

• 4 edits in trunk

Code cleanup: Remove BUILDING_ON / TARGETING definitions.
​https://bugs.webkit.org/show_bug.cgi?id=128242

Patch by Tamas Gergely <​tgergely.u-szeged@partner.samsung.com> on 2014-02-10
Reviewed by Brent Fulgham.

The BUILDING_ON_* and TARGETING_* macros have not been used for a while.
According to the FIXME: they are removed.

Source/WTF:

• wtf/Platform.h:

Tools:

• DumpRenderTree/config.h:

1:31 AM Changeset in webkit [163775] by Carlos Garcia Campos

• 28 edits
  3 copies in releases/WebKitGTK/webkit-2.4

Merge r163749 - [GTK] Enable touch features
​https://bugs.webkit.org/show_bug.cgi?id=98931

Patch by Carlos Garnacho <​carlosg@gnome.org> on 2014-02-09
Reviewed by Carlos Garcia Campos.

• Source/autotools/SetupWebKitFeatures.m4:
• Source/cmake/OptionsGTK.cmake: set ENABLE_TOUCH_EVENTS to 1 if building with GTK+.

Source/WebCore: [GTK] Add touch-events related code to build
​https://bugs.webkit.org/show_bug.cgi?id=98931

Patch by Carlos Garnacho <​carlosg@gnome.org> on 2014-02-09
Reviewed by Carlos Garcia Campos.

Tests in fast/events/touch have been enabled on GTK+ now that touch
support is implemented, and thus all expected bits are there.

• platform/gtk/GtkTouchContextHelper.cpp:
• platform/gtk/GtkTouchContextHelper.h: Add helper object to track all touchpoints, handy

when creating WebTouchEvents.

• GNUmakefile.list.am:
• PlatformGTK.cmake:
• bindings/gobject/GNUmakefile.am: Add touch related code and idls to build, those are

necessary now that GTK+ implements touch events.

Source/WebKit/gtk: [GTK] Allow building with touch events enabled
​https://bugs.webkit.org/show_bug.cgi?id=98931

Patch by Carlos Garnacho <​carlosg@gnome.org> on 2014-02-09
Reviewed by Carlos Garcia Campos.

Even though WebKit1 GTK code doesn't implement touch events,
Fix build if ENABLE_TOUCH_EVENTS is present for WK2.

• WebCoreSupport/ChromeClientGtk.h:

(WebKit::ChromeClient::needTouchEvents): Add empty stub

Source/WebKit2: [GTK] Implement support touch events
​https://bugs.webkit.org/show_bug.cgi?id=98931

Patch by Carlos Garnacho <​carlosg@gnome.org> on 2014-02-09
Reviewed by Carlos Garcia Campos.

In GTK+ >= 3.4.0, GdkEventTouch is available to inform about multitouch events. Use these to implement
touch events on this platform. If a touch is left unhandled and is the "pointer emulating" one, mouse
events will be generated as a fallback.

• GNUmakefile.list.am:
• PlatformGTK.cmake:
• Shared/gtk/NativeWebTouchEventGtk.cpp:
• Shared/NativeWebTouchEvent.h:

(WebKit::NativeWebTouchEvent::nativeEvent):
(WebKit::NativeWebTouchEvent::touchContext): Add GTK+ implementation of NativeWebTouchEvent.

• Shared/gtk/WebEventFactory.cpp:

(WebKit::touchPhaseFromEvents):
(WebKit::WebEventFactory::createWebTouchEvent): Add methods to generate WebTouchEvents out
of GdkEventTouch events, a GtkTouchContextHelper object is used to hold information about all current
touches, in order to build information about all individual touchpoints.

• Shared/gtk/WebEventFactory.h:
• UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::doneWithTouchEvent): Implement pointer emulation. If a touch event was unhandled
in DOM and pertains to the touch sequence that emulates pointer events. The event gets transformed to its
mouse event counterpart and handled by the widget again.

• UIProcess/API/gtk/PageClientImpl.h:
• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseRealize): Listen for touch events
(webkitWebViewBaseTouchEvent):
(webkit_web_view_base_class_init): Add implementation for the touch_events() handler, this merely
lets the pageProxy handle the NativeWebTouchEvent we create to wrap the GdkEvent received.

Tools: [GTK] Enable touch features
​https://bugs.webkit.org/show_bug.cgi?id=98931

Patch by Carlos Garnacho <​carlosg@gnome.org> on 2014-02-09
Reviewed by Carlos Garcia Campos.

• WebKitTestRunner/EventSenderProxy.h:
• WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::updateEventCoordinates):
(WTR::EventSenderProxy::createTouchEvent):
(WTR::EventSenderProxy::addTouchPoint):
(WTR::EventSenderProxy::updateTouchPoint):
(WTR::EventSenderProxy::sendUpdatedTouchEvents):
(WTR::EventSenderProxy::setTouchPointRadius):
(WTR::EventSenderProxy::setTouchModifier): Implement touch event proxying.

LayoutTests: [GTK] Enable touch features
​https://bugs.webkit.org/show_bug.cgi?id=98931

Patch by Carlos Garnacho <​carlosg@gnome.org> on 2014-02-09
Reviewed by Carlos Garcia Campos.

• platform/gtk/TestExpectations: remove fast/events/touch
• platform/gtk-wk2/TestExpectations: Add new expectations on

fast/events/touch events.

1:08 AM Changeset in webkit [163774] by zandobersek@gmail.com

• 4 edits in trunk

Fix a few mistakes that landed with r163749.

Rubber-stamped by Carlos Garcia Campos.

Source/WebCore:

• platform/gtk/GtkTouchContextHelper.cpp:

(WebCore::GtkTouchContextHelper::handleEvent): When handling GDK_TOUCH_BEGIN, the assertion
should ensure that the sequence-to-event map doesn't yet contain pairs with the specific
sequence as the key.

Tools:

• WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::EventSenderProxy::addTouchPoint): Avoid using the GUniquePtr<GdkEvent> after it's been moved
into the event vector since moving it invalidates the variable.

12:32 AM Changeset in webkit [163773] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.4/Tools

Merge r163375 - [Automake] Add missing $(feature_defines) when generating InjectedBundle bindings
​https://bugs.webkit.org/show_bug.cgi?id=128170

Patch by Carlos Garnacho <​carlosg@gnome.org> on 2014-02-04
Reviewed by Carlos Garcia Campos.

• WebKitTestRunner/GNUmakefile.am: Add missing $(feature_defines) when

generating the InjectedBundle bindings. So the various ENABLE_* defines
are available there.

12:28 AM Changeset in webkit [163772] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.4/Tools

Merge r163373 - [GTK] Ensure generated events have given modifiers GDK understands
​https://bugs.webkit.org/show_bug.cgi?id=128171

Patch by Carlos Garnacho <​carlosg@gnome.org> on 2014-02-04
Reviewed by Carlos Garcia Campos.

• WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::webkitModifiersToGDKModifiers): Move around
(WTR::EventSenderProxy::createMouseButtonEvent):

12:27 AM Changeset in webkit [163771] by mihnea@adobe.com

• 1 edit
  2 adds in trunk/LayoutTests

[CSS Regions] Fix Propagating Border and Padding for Inline Replaced Elements Flowed in Regions
​https://bugs.webkit.org/show_bug.cgi?id=123143

Reviewed by Andrei Bucur.

Add test to make sure that outlines and borders are properly painted for inline replaced
transformed elements, having margins and paddings, displayed in region.

• compositing/regions/inline-replaced-transformed-in-region-expected.html: Added.
• compositing/regions/inline-replaced-transformed-in-region.html: Added.

12:23 AM Changeset in webkit [163770] by ddkilzer@apple.com

• 6 edits in trunk/Source/WebCore

Add type-safe casts for ContentData subclasses
<​http://webkit.org/b/128510>

Reviewed by Darin Adler.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::contentToCSSValue):

• css/StyleResolver.cpp:

(WebCore::StyleResolver::loadPendingImages):

• rendering/RenderElement.cpp:

(WebCore::RenderElement::createFor):

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setContent):

• Switch to toFooContentData() methods.

• rendering/style/ContentData.h:
• Define toFooContentData() methods.
• Extract FooContentData::equals() methods so that the toFooContentData() methods can be used.

12:15 AM WebKitGTK/2.4.x edited by Carlos Garcia Campos

(diff)

12:13 AM Changeset in webkit [163769] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2

Merge r163748 - Unreviewed, rolling out r162768.
​http://trac.webkit.org/changeset/162768
​https://bugs.webkit.org/show_bug.cgi?id=128495

Causes crashes on GTK WK2 in three fast/forms tests.
(Requested by zdobersek on #webkit).

• UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::showPopupMenu):

12:10 AM Changeset in webkit [163768] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

Merge r163435 - MediaPlayerPrivateGStreamerBase should have virtual destructor
​https://bugs.webkit.org/show_bug.cgi?id=128238

Reviewed by Carlos Garcia Campos.

MediaPlayerPrivateGStreamer inherit MediaPlayerPrivateGStreamerBase.
So MediaPlayerPrivateGStreamerBase should have virtual destructor.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h: Made destructor as virtual.

12:04 AM Changeset in webkit [163767] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2

Merge r163292 - Fix wrong mix of fcntl commands and flags
​https://bugs.webkit.org/show_bug.cgi?id=127842

Reviewed by Darin Adler.

We are mixing the commands to set file descriptor and file status
flags in a couple of fcntl() calls. FD_CLOEXEC must be set using
F_SETFD, and the access mode flags (O_RDONLY, O_WRONLY, O_RDWR)
with F_SETFL.

This combines patches by Guillem Jover and Sergio Correia.

• Platform/IPC/unix/ConnectionUnix.cpp:

(IPC::readBytesFromSocket):

• Platform/unix/SharedMemoryUnix.cpp:

(WebKit::SharedMemory::createHandle):

12:04 AM WebKitGTK/2.4.x edited by Carlos Garcia Campos

(diff)

Feb 9, 2014:

11:59 PM WebKitGTK/2.4.x edited by Carlos Garcia Campos

(diff)

11:41 PM Changeset in webkit [163766] by mrowe@apple.com

• 2 edits in trunk/Source/WebKit

Stop relinking WebKit on every build.

• WebKit.xcodeproj/project.pbxproj: Fix the case on an input file for the Generate Export Files

script phase so it will run only when the inputs change rather than on every build.

11:23 PM WebKitGTK/2.4.x edited by Carlos Garcia Campos

(diff)

11:21 PM Changeset in webkit [163765] by fpizlo@apple.com

• 16 edits
  7 adds in trunk/Source/JavaScriptCore

GC blocks on FTL and then badness
​https://bugs.webkit.org/show_bug.cgi?id=128291

Reviewed by Oliver Hunt.

Introduce the notion of a DFG::Safepoint, which allows you to unlock the rightToRun
mutex for your JIT thread, while supplying the GC with all of the information it would
need to scan you at that moment in time. The default way of using this is
DFG::GraphSafepoint, where you just supply the Graph. There's a lot of machinery in
this patch just to make the Graph scannable.

We then use DFG::GraphSafepoint in just two places for now: (1) while initializing LLVM
and (2) while invoking LLVM' optimizer and backend.

This is a 30% speed-up on Octane/typescript and a 10% speed-up on Octane/gbemu. 2-3%
speed-up overall on Octane.

• CMakeLists.txt:
• GNUmakefile.list.am:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
• JavaScriptCore.xcodeproj/project.pbxproj:
• dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::visitChildren):

• dfg/DFGGraph.h:
• dfg/DFGGraphSafepoint.cpp: Added.

(JSC::DFG::GraphSafepoint::GraphSafepoint):
(JSC::DFG::GraphSafepoint::~GraphSafepoint):

• dfg/DFGGraphSafepoint.h: Added.
• dfg/DFGOperations.h:
• dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThread):
(JSC::DFG::Plan::compileInThreadImpl):

• dfg/DFGPlan.h:
• dfg/DFGSafepoint.cpp: Added.

(JSC::DFG::Safepoint::Safepoint):
(JSC::DFG::Safepoint::~Safepoint):
(JSC::DFG::Safepoint::add):
(JSC::DFG::Safepoint::begin):
(JSC::DFG::Safepoint::visitChildren):

• dfg/DFGSafepoint.h: Added.
• dfg/DFGScannable.h: Added.

(JSC::DFG::Scannable::Scannable):
(JSC::DFG::Scannable::~Scannable):

• dfg/DFGThreadData.cpp: Added.

(JSC::DFG::ThreadData::ThreadData):
(JSC::DFG::ThreadData::~ThreadData):

• dfg/DFGThreadData.h: Added.
• dfg/DFGWorklist.cpp:

(JSC::DFG::Worklist::finishCreation):
(JSC::DFG::Worklist::visitChildren):
(JSC::DFG::Worklist::runThread):

• dfg/DFGWorklist.h:
• ftl/FTLCompile.cpp:

(JSC::FTL::compile):

• heap/SlotVisitor.h:
• heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::appendUnbarrieredReadOnlyPointer):
(JSC::SlotVisitor::appendUnbarrieredReadOnlyValue):

10:02 PM Changeset in webkit [163764] by commit-queue@webkit.org

• 12 edits
  6 adds
  3 deletes in trunk

-webkit-clip-path should support fill, stroke, view-box keywords
​https://bugs.webkit.org/show_bug.cgi?id=128393

Source/WebCore:

Patch by Dirk Schulze <​dschulze@chromium.org> on 2014-02-09
Reviewed by Dean Jackson.

CSS Masking uses the keywords fill, stroke and view-box for SVG shapes.
This patch updates the parser, style resolver and SVG implementation of
the prefixed clip-path property.

Remove the unexposed and obsolete keyword bounding-box.

Tests: svg/clip-path/clip-path-shape-fill-expected.svg

svg/clip-path/clip-path-shape-fill.svg
svg/clip-path/clip-path-shape-stroke-expected.svg
svg/clip-path/clip-path-shape-stroke.svg
svg/clip-path/clip-path-shape-view-box-expected.svg
svg/clip-path/clip-path-shape-view-box.svg

• css/CSSParser.cpp: Parse fill, stroke, view-box. Remove bounding-box.

(WebCore::isBoxValue):

• css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator LayoutBox):

• css/CSSValueKeywords.in:
• css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyClipPath::applyValue):

• rendering/RenderLayer.cpp:

(WebCore::computeReferenceBox):

• rendering/shapes/ShapeInfo.h:

(WebCore::ShapeInfo::setShapeSize):
(WebCore::ShapeInfo::logicalTopOffset):
(WebCore::ShapeInfo::logicalLeftOffset):

• rendering/style/RenderStyleConstants.h:
• rendering/svg/SVGRenderingContext.cpp: Use different reference boxes per keyword.

(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

LayoutTests:

Patch by Dirk Schulze <​krit@webkit.org> on 2014-02-09
Reviewed by Dean Jackson.

Update or add new tests for changed clip-path keywords.

• css3/masking/clip-path-circle-bounding-box.html: Removed.
• fast/masking/parsing-clip-path-shape.html:
• platform/mac/css3/masking/clip-path-circle-bounding-box-expected.png: Removed.
• platform/mac/css3/masking/clip-path-circle-bounding-box-expected.txt: Removed.
• svg/clip-path/clip-path-shape-fill-expected.svg: Added.
• svg/clip-path/clip-path-shape-fill.svg: Added.
• svg/clip-path/clip-path-shape-stroke-expected.svg: Added.
• svg/clip-path/clip-path-shape-stroke.svg: Added.
• svg/clip-path/clip-path-shape-view-box-expected.svg: Added.
• svg/clip-path/clip-path-shape-view-box.svg: Added.

9:40 PM Changeset in webkit [163763] by dino@apple.com

• 4 edits in trunk/Source/WebCore

[WebGL] Remove state restorer code
​https://bugs.webkit.org/show_bug.cgi?id=128516

Reviewed by Dirk Schulze.

I'm not sure what the point of the WebGLStateRestorer class was. It was
always constructed with a false parameter, and then wasn't even retained
in local scope (so wouldn't have worked anyway). Meanwhile there were
also LOTS of calls to cleanupAfterGraphicsCall, the majority of which
were a no-op. I replaced the handful of cleanupAfterGraphicsCall(true)
with the call to markContextChanged().

• html/canvas/OESVertexArrayObject.cpp:

(WebCore::OESVertexArrayObject::bindVertexArrayOES):

• html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::activeTexture):
(WebCore::WebGLRenderingContext::attachShader):
(WebCore::WebGLRenderingContext::bindAttribLocation):
(WebCore::WebGLRenderingContext::bindBuffer):
(WebCore::WebGLRenderingContext::bindFramebuffer):
(WebCore::WebGLRenderingContext::bindRenderbuffer):
(WebCore::WebGLRenderingContext::bindTexture):
(WebCore::WebGLRenderingContext::blendColor):
(WebCore::WebGLRenderingContext::blendEquation):
(WebCore::WebGLRenderingContext::blendEquationSeparate):
(WebCore::WebGLRenderingContext::blendFunc):
(WebCore::WebGLRenderingContext::blendFuncSeparate):
(WebCore::WebGLRenderingContext::bufferData):
(WebCore::WebGLRenderingContext::bufferSubData):
(WebCore::WebGLRenderingContext::checkFramebufferStatus):
(WebCore::WebGLRenderingContext::clear):
(WebCore::WebGLRenderingContext::clearColor):
(WebCore::WebGLRenderingContext::clearDepth):
(WebCore::WebGLRenderingContext::clearStencil):
(WebCore::WebGLRenderingContext::colorMask):
(WebCore::WebGLRenderingContext::compileShader):
(WebCore::WebGLRenderingContext::compressedTexImage2D):
(WebCore::WebGLRenderingContext::compressedTexSubImage2D):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::cullFace):
(WebCore::WebGLRenderingContext::depthFunc):
(WebCore::WebGLRenderingContext::depthMask):
(WebCore::WebGLRenderingContext::depthRange):
(WebCore::WebGLRenderingContext::detachShader):
(WebCore::WebGLRenderingContext::disable):
(WebCore::WebGLRenderingContext::disableVertexAttribArray):
(WebCore::WebGLRenderingContext::validateDrawArrays):
(WebCore::WebGLRenderingContext::drawArrays):
(WebCore::WebGLRenderingContext::validateDrawElements):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::enable):
(WebCore::WebGLRenderingContext::enableVertexAttribArray):
(WebCore::WebGLRenderingContext::finish):
(WebCore::WebGLRenderingContext::flush):
(WebCore::WebGLRenderingContext::framebufferRenderbuffer):
(WebCore::WebGLRenderingContext::framebufferTexture2D):
(WebCore::WebGLRenderingContext::frontFace):
(WebCore::WebGLRenderingContext::generateMipmap):
(WebCore::WebGLRenderingContext::getBufferParameter):
(WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getProgramParameter):
(WebCore::WebGLRenderingContext::getProgramInfoLog):
(WebCore::WebGLRenderingContext::getRenderbufferParameter):
(WebCore::WebGLRenderingContext::getShaderParameter):
(WebCore::WebGLRenderingContext::getShaderInfoLog):
(WebCore::WebGLRenderingContext::getTexParameter):
(WebCore::WebGLRenderingContext::getUniform):
(WebCore::WebGLRenderingContext::getUniformLocation):
(WebCore::WebGLRenderingContext::getVertexAttrib):
(WebCore::WebGLRenderingContext::getVertexAttribOffset):
(WebCore::WebGLRenderingContext::hint):
(WebCore::WebGLRenderingContext::lineWidth):
(WebCore::WebGLRenderingContext::linkProgram):
(WebCore::WebGLRenderingContext::pixelStorei):
(WebCore::WebGLRenderingContext::polygonOffset):
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::releaseShaderCompiler):
(WebCore::WebGLRenderingContext::renderbufferStorage):
(WebCore::WebGLRenderingContext::sampleCoverage):
(WebCore::WebGLRenderingContext::scissor):
(WebCore::WebGLRenderingContext::shaderSource):
(WebCore::WebGLRenderingContext::stencilFunc):
(WebCore::WebGLRenderingContext::stencilFuncSeparate):
(WebCore::WebGLRenderingContext::stencilMask):
(WebCore::WebGLRenderingContext::stencilMaskSeparate):
(WebCore::WebGLRenderingContext::stencilOp):
(WebCore::WebGLRenderingContext::stencilOpSeparate):
(WebCore::WebGLRenderingContext::texImage2DBase):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texParameter):
(WebCore::WebGLRenderingContext::texSubImage2DBase):
(WebCore::WebGLRenderingContext::uniform1f):
(WebCore::WebGLRenderingContext::uniform1fv):
(WebCore::WebGLRenderingContext::uniform1i):
(WebCore::WebGLRenderingContext::uniform1iv):
(WebCore::WebGLRenderingContext::uniform2f):
(WebCore::WebGLRenderingContext::uniform2fv):
(WebCore::WebGLRenderingContext::uniform2i):
(WebCore::WebGLRenderingContext::uniform2iv):
(WebCore::WebGLRenderingContext::uniform3f):
(WebCore::WebGLRenderingContext::uniform3fv):
(WebCore::WebGLRenderingContext::uniform3i):
(WebCore::WebGLRenderingContext::uniform3iv):
(WebCore::WebGLRenderingContext::uniform4f):
(WebCore::WebGLRenderingContext::uniform4fv):
(WebCore::WebGLRenderingContext::uniform4i):
(WebCore::WebGLRenderingContext::uniform4iv):
(WebCore::WebGLRenderingContext::uniformMatrix2fv):
(WebCore::WebGLRenderingContext::uniformMatrix3fv):
(WebCore::WebGLRenderingContext::uniformMatrix4fv):
(WebCore::WebGLRenderingContext::useProgram):
(WebCore::WebGLRenderingContext::validateProgram):
(WebCore::WebGLRenderingContext::vertexAttribPointer):
(WebCore::WebGLRenderingContext::viewport):
(WebCore::WebGLRenderingContext::vertexAttribfImpl):
(WebCore::WebGLRenderingContext::vertexAttribfvImpl):
(WebCore::WebGLRenderingContext::drawArraysInstanced):
(WebCore::WebGLRenderingContext::drawElementsInstanced):

• html/canvas/WebGLRenderingContext.h:

9:40 PM Changeset in webkit [163762] by dino@apple.com

• 3 edits in trunk/Source/WebCore

Remove unused layer owner from WebGLLayer
​https://bugs.webkit.org/show_bug.cgi?id=128512

Reviewed by Dirk Schulze.

The m_layerOwner and ObjC category were not
used anywhere.

• platform/graphics/mac/WebGLLayer.h:
• platform/graphics/mac/WebGLLayer.mm:

(-[WebGLLayer display]):

8:10 PM Changeset in webkit [163761] by ryuan.choi@samsung.com

• 10 edits
  2 deletes in trunk/Source

[EFL] Remove PageClientEfl
​https://bugs.webkit.org/show_bug.cgi?id=128508

Reviewed by Andreas Kling.

Source/WebCore:

PageClientEfl was introduced for accelerated compositing of WebKit1, but
it's bad idea because it's layer violation.
Indeed, it has never been used since introduced.

• platform/Widget.h: Back to PlatformPageClient to Evas_Object.
• platform/graphics/efl/GraphicsContext3DPrivate.cpp:

Removed empty method which use PageClientEfl.

• platform/graphics/efl/GraphicsContext3DPrivate.h: Ditto.

Source/WebKit:

• PlatformEfl.cmake: Removed PageClientEfl.cpp

Source/WebKit/efl:

• WebCoreSupport/AcceleratedCompositingContextEfl.cpp:

Removed dependencies of PageClientEfl.
(WebCore::AcceleratedCompositingContext::initialize):

• WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::platformPageClient):

• WebCoreSupport/PageClientEfl.cpp: Removed.
• WebCoreSupport/PageClientEfl.h: Removed.
• ewk/ewk_view.cpp:

(_ewk_view_priv_new):

6:51 PM Changeset in webkit [163760] by fpizlo@apple.com

• 181 edits in trunk/Source/JavaScriptCore

Never include *Inlines.h files in interface headers, and never include *Inlines.h when you could include Operations.h instead
​https://bugs.webkit.org/show_bug.cgi?id=128505

Reviewed by Mark Hahnenberg and Oliver Hunt.

• API/JSContextRef.cpp:
• assembler/LinkBuffer.cpp:
• bytecode/ArrayProfile.cpp:
• bytecode/BytecodeBasicBlock.cpp:
• bytecode/BytecodeLivenessAnalysisInlines.h:
• bytecode/CallLinkInfo.cpp:
• bytecode/CodeBlock.cpp:
• bytecode/CodeBlock.h:
• bytecode/CodeBlockJettisoningWatchpoint.cpp:
• bytecode/ExecutionCounter.cpp:
• bytecode/MethodOfGettingAValueProfile.cpp:
• bytecode/PreciseJumpTargets.cpp:
• bytecode/ProfiledCodeBlockJettisoningWatchpoint.cpp:
• bytecode/SamplingTool.cpp:
• bytecode/SpecialPointer.cpp:
• bytecode/StructureStubClearingWatchpoint.cpp:
• debugger/DebuggerCallFrame.cpp:
• dfg/DFGAbstractHeap.cpp:
• dfg/DFGAbstractValue.cpp:
• dfg/DFGArgumentsSimplificationPhase.cpp:
• dfg/DFGArithMode.cpp:
• dfg/DFGArrayMode.cpp:
• dfg/DFGAtTailAbstractState.cpp:
• dfg/DFGAvailability.cpp:
• dfg/DFGBackwardsPropagationPhase.cpp:
• dfg/DFGBasicBlock.cpp:
• dfg/DFGBinarySwitch.cpp:
• dfg/DFGBlockInsertionSet.cpp:
• dfg/DFGByteCodeParser.cpp:
• dfg/DFGCFAPhase.cpp:
• dfg/DFGCFGSimplificationPhase.cpp:
• dfg/DFGCPSRethreadingPhase.cpp:
• dfg/DFGCSEPhase.cpp:
• dfg/DFGCapabilities.cpp:
• dfg/DFGClobberSet.cpp:
• dfg/DFGClobberize.cpp:
• dfg/DFGCommon.cpp:
• dfg/DFGCommonData.cpp:
• dfg/DFGCompilationKey.cpp:
• dfg/DFGCompilationMode.cpp:
• dfg/DFGConstantFoldingPhase.cpp:
• dfg/DFGCriticalEdgeBreakingPhase.cpp:
• dfg/DFGDCEPhase.cpp:
• dfg/DFGDesiredIdentifiers.cpp:
• dfg/DFGDesiredStructureChains.cpp:
• dfg/DFGDesiredTransitions.cpp:
• dfg/DFGDesiredWatchpoints.cpp:
• dfg/DFGDisassembler.cpp:
• dfg/DFGDisassembler.h:
• dfg/DFGDominators.cpp:
• dfg/DFGEdge.cpp:
• dfg/DFGFailedFinalizer.cpp:
• dfg/DFGFinalizer.cpp:
• dfg/DFGFixupPhase.cpp:
• dfg/DFGFlushFormat.cpp:
• dfg/DFGFlushLivenessAnalysisPhase.cpp:
• dfg/DFGFlushedAt.cpp:
• dfg/DFGGraph.cpp:
• dfg/DFGInPlaceAbstractState.cpp:
• dfg/DFGInvalidationPointInjectionPhase.cpp:
• dfg/DFGJITCode.cpp:
• dfg/DFGJITCompiler.cpp:
• dfg/DFGJITCompiler.h:
• dfg/DFGJITFinalizer.cpp:
• dfg/DFGJumpReplacement.cpp:
• dfg/DFGLICMPhase.cpp:
• dfg/DFGLazyJSValue.cpp:
• dfg/DFGLivenessAnalysisPhase.cpp:
• dfg/DFGLongLivedState.cpp:
• dfg/DFGLoopPreHeaderCreationPhase.cpp:
• dfg/DFGMinifiedNode.cpp:
• dfg/DFGNaturalLoops.cpp:
• dfg/DFGNode.cpp:
• dfg/DFGNodeFlags.cpp:
• dfg/DFGOSRAvailabilityAnalysisPhase.cpp:
• dfg/DFGOSREntry.cpp:
• dfg/DFGOSREntrypointCreationPhase.cpp:
• dfg/DFGOSRExit.cpp:
• dfg/DFGOSRExitBase.cpp:
• dfg/DFGOSRExitCompiler.cpp:
• dfg/DFGOSRExitCompiler32_64.cpp:
• dfg/DFGOSRExitCompiler64.cpp:
• dfg/DFGOSRExitCompilerCommon.cpp:
• dfg/DFGOSRExitJumpPlaceholder.cpp:
• dfg/DFGOSRExitPreparation.cpp:
• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGPhase.cpp:
• dfg/DFGPlan.cpp:
• dfg/DFGPredictionInjectionPhase.cpp:
• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGResurrectionForValidationPhase.cpp:
• dfg/DFGSSAConversionPhase.cpp:
• dfg/DFGSSALoweringPhase.cpp:
• dfg/DFGSpeculativeJIT.cpp:
• dfg/DFGSpeculativeJIT32_64.cpp:
• dfg/DFGSpeculativeJIT64.cpp:
• dfg/DFGStackLayoutPhase.cpp:
• dfg/DFGStoreBarrierElisionPhase.cpp:
• dfg/DFGStrengthReductionPhase.cpp:
• dfg/DFGThunks.cpp:
• dfg/DFGTierUpCheckInjectionPhase.cpp:
• dfg/DFGToFTLDeferredCompilationCallback.cpp:
• dfg/DFGToFTLForOSREntryDeferredCompilationCallback.cpp:
• dfg/DFGTypeCheckHoistingPhase.cpp:
• dfg/DFGUnificationPhase.cpp:
• dfg/DFGUseKind.cpp:
• dfg/DFGValidate.cpp:
• dfg/DFGValueSource.cpp:
• dfg/DFGVariableAccessDataDump.cpp:
• dfg/DFGVariableEvent.cpp:
• dfg/DFGVariableEventStream.cpp:
• dfg/DFGVirtualRegisterAllocationPhase.cpp:
• dfg/DFGWatchpointCollectionPhase.cpp:
• dfg/DFGWorklist.cpp:
• disassembler/Disassembler.cpp:
• ftl/FTLLink.cpp:
• ftl/FTLOSRExitCompiler.cpp:
• ftl/FTLSlowPathCall.cpp:
• ftl/FTLThunks.cpp:

(JSC::FTL::slowPathCallThunkGenerator):

• heap/BlockAllocator.cpp:
• heap/CodeBlockSet.cpp:
• heap/ConservativeRoots.cpp:
• heap/DeferGC.cpp:
• heap/GCThread.cpp:
• heap/GCThreadSharedData.cpp:
• heap/HeapTimer.cpp:
• heap/IncrementalSweeper.cpp:
• heap/JITStubRoutineSet.cpp:
• heap/MachineStackMarker.cpp:
• heap/MarkStack.cpp:
• heap/MarkedAllocator.cpp:
• heap/MarkedSpace.cpp:
• heap/SuperRegion.cpp:
• heap/Weak.cpp:
• heap/WeakHandleOwner.cpp:
• heap/WeakSet.cpp:
• heap/WriteBarrierBuffer.cpp:
• heap/WriteBarrierSupport.cpp:
• inspector/ScriptCallStackFactory.cpp:
• interpreter/AbstractPC.cpp:
• interpreter/JSStack.cpp:
• interpreter/ProtoCallFrame.cpp:
• interpreter/VMInspector.cpp:
• jit/ArityCheckFailReturnThunks.cpp:
• jit/AssemblyHelpers.cpp:
• jit/ExecutableAllocator.cpp:
• jit/ExecutableAllocatorFixedVMPool.cpp:
• jit/GCAwareJITStubRoutine.cpp:
• jit/HostCallReturnValue.cpp:
• jit/JITDisassembler.cpp:
• jit/JITDisassembler.h:
• jit/JITExceptions.cpp:
• jit/JITInlines.h:
• jit/JITOperations.cpp:
• jit/JITOperationsMSVC64.cpp:
• jit/JITStubRoutine.cpp:
• jit/JITStubs.cpp:
• jit/JITToDFGDeferredCompilationCallback.cpp:
• jit/RegisterPreservationWrapperGenerator.cpp:
• jit/RegisterSet.cpp:
• jit/Repatch.cpp:
• jit/TempRegisterSet.cpp:
• jsc.cpp:
• parser/Lexer.cpp:
• parser/Parser.cpp:
• parser/ParserArena.cpp:
• parser/SourceCode.cpp:
• parser/SourceProvider.cpp:
• parser/SourceProviderCache.cpp:
• profiler/ProfileGenerator.cpp:
• runtime/Arguments.cpp:
• runtime/ArgumentsIteratorPrototype.cpp:
• runtime/CommonSlowPathsExceptions.cpp:
• runtime/JSArgumentsIterator.cpp:
• runtime/JSFunction.cpp:
• runtime/JSGlobalObjectFunctions.cpp:
• runtime/ObjectConstructor.cpp:
• runtime/Operations.h:
• runtime/VM.cpp:

5:09 PM Changeset in webkit [163759] by fpizlo@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, don't mark isHostFunction() inline in the header file because that really confuses EFL.

• runtime/JSFunction.h:

4:26 PM Changeset in webkit [163758] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebCore

[iOS][wk2] ASSERT(WebThreadIsCurrent()) in [WebDisplayLinkHandler handleDisplayLink:]
​https://bugs.webkit.org/show_bug.cgi?id=128490

Reviewed by Simon Fraser.

• platform/graphics/ios/DisplayRefreshMonitorIOS.mm:

(-[WebDisplayLinkHandler handleDisplayLink:]):
[WebDisplayLinkHandler handleDisplayLink:] has an ASSERT(WebThreadIsCurrent()).

We don't use the Web Thread in WebKit2, but it looks like isMainThread()
does the right thing (main thread if web thread is disabled, web thread
otherwise), so use that instead.

3:52 PM Changeset in webkit [163757] by andersca@apple.com

• 17 edits in trunk/Source

Add WTF_MAKE_FAST_ALLOCATED to more classes
​https://bugs.webkit.org/show_bug.cgi?id=128506

Reviewed by Andreas Kling.

Source/JavaScriptCore:

• bytecode/UnlinkedInstructionStream.h:
• runtime/SymbolTable.h:
• runtime/WriteBarrier.h:

Source/WebCore:

• dom/Node.h:
• dom/ScriptElement.h:
• loader/ImageLoader.h:
• loader/cache/CachedResourceClient.h:
• platform/TreeShared.h:
• platform/graphics/GlyphMetricsMap.h:
• rendering/InlineBox.h:
• rendering/RenderLayer.h:
• rendering/RenderObject.h:

Source/WTF:

• wtf/Bag.h:
• wtf/ListHashSet.h:

3:32 PM Changeset in webkit [163756] by mhahnenberg@apple.com

• 4 edits
  2 adds in trunk/Source/JavaScriptCore

Objective-C API NSDate conversion is off by 1000x (ms vs s)
​https://bugs.webkit.org/show_bug.cgi?id=128386

Reviewed by Michael Saboff.

• API/JSValue.mm:

(valueToObjectWithoutCopy):
(valueToDate):
(objectToValueWithoutCopy):

• API/tests/DateTests.h: Added.
• API/tests/DateTests.mm: Added.

(+[DateTests NSDateToJSDateTest]):
(+[DateTests JSDateToNSDateTest]):
(+[DateTests roundTripThroughJSDateTest]):
(+[DateTests roundTripThroughObjCDateTest]):

• API/tests/testapi.mm:

(checkResult):

• JavaScriptCore.xcodeproj/project.pbxproj:

1:33 PM Changeset in webkit [163755] by akling@apple.com

• 6 edits in trunk/Source/JavaScriptCore

Pass VM instead of ExecState to JSCell::fastGetOwnProperty().
<​https://webkit.org/b/128497>

Knocks off a couple of instructions.

Reviewed by Anders Carlsson.

• dfg/DFGOperations.cpp:
• jit/JITOperations.cpp:

(JSC::getByVal):

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::getByVal):

• runtime/JSCell.h:
• runtime/JSCellInlines.h:

(JSC::JSCell::fastGetOwnProperty):

1:32 PM Changeset in webkit [163754] by akling@apple.com

• 2 edits in trunk/Source/WebCore

Reduce ref churn in ChildNodesLazySnapshot iteration.
<​https://webkit.org/b/128492>

Add a missing release() in ChildNodesLazySnapshot::nextNode()
so we don't have to churn the ref count.

Reviewed by Sam Weinig.

• dom/ContainerNode.h:

(WebCore::ChildNodesLazySnapshot::nextNode):

1:31 PM Changeset in webkit [163753] by akling@apple.com

• 2 edits in trunk/Source/WebCore

Reduce ref churn in ChildInsertionNotifier.
<​https://webkit.org/b/128494>

All callers of notifyNodeInsertedIntoDocument() already hold a strong
reference on the Node, so there's no need to ref it again inside.

Reviewed by Anders Carlsson.

• dom/ContainerNodeAlgorithms.h:

(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoDocument):

10:47 AM Changeset in webkit [163752] by andersca@apple.com

• 10 edits in trunk/Source/JavaScriptCore

Convert some JSC code over to std::mutex
​https://bugs.webkit.org/show_bug.cgi?id=128500

Reviewed by Dan Bernstein.

• API/JSVirtualMachine.mm:

(wrapperCacheMutex):
(+[JSVMWrapperCache addWrapper:forJSContextGroupRef:]):
(+[JSVMWrapperCache wrapperForJSContextGroupRef:]):

• heap/GCThreadSharedData.h:
• heap/SlotVisitor.cpp:

(JSC::SlotVisitor::mergeOpaqueRoots):

• heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::containsOpaqueRootTriState):

• inspector/remote/RemoteInspector.h:
• inspector/remote/RemoteInspector.mm:

(Inspector::RemoteInspector::registerDebuggable):
(Inspector::RemoteInspector::unregisterDebuggable):
(Inspector::RemoteInspector::updateDebuggable):
(Inspector::RemoteInspector::sendMessageToRemoteFrontend):
(Inspector::RemoteInspector::start):
(Inspector::RemoteInspector::stop):
(Inspector::RemoteInspector::setupXPCConnectionIfNeeded):
(Inspector::RemoteInspector::xpcConnectionReceivedMessage):
(Inspector::RemoteInspector::xpcConnectionFailed):
(Inspector::RemoteInspector::pushListingSoon):
(Inspector::RemoteInspector::receivedIndicateMessage):

• inspector/remote/RemoteInspectorDebuggableConnection.h:
• inspector/remote/RemoteInspectorDebuggableConnection.mm:

(Inspector::RemoteInspectorDebuggableConnection::setup):
(Inspector::RemoteInspectorDebuggableConnection::closeFromDebuggable):
(Inspector::RemoteInspectorDebuggableConnection::close):
(Inspector::RemoteInspectorDebuggableConnection::sendMessageToBackend):

• jit/ExecutableAllocator.cpp:

(JSC::DemandExecutableAllocator::DemandExecutableAllocator):
(JSC::DemandExecutableAllocator::~DemandExecutableAllocator):
(JSC::DemandExecutableAllocator::bytesAllocatedByAllAllocators):
(JSC::DemandExecutableAllocator::bytesCommittedByAllocactors):
(JSC::DemandExecutableAllocator::dumpProfileFromAllAllocators):
(JSC::DemandExecutableAllocator::allocatorsMutex):

4:11 AM Changeset in webkit [163751] by zandobersek@gmail.com

• 15 edits in trunk/Source/WebCore

Manage ShadowData through std::unique_ptr
​https://bugs.webkit.org/show_bug.cgi?id=128466

Reviewed by Andreas Kling.

Use std::unique_ptr instead of OwnPtr to manage ShadowData objects.

• css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

• css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

• page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):
(WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
(WebCore::PropertyWrapperShadow::blendSimpleOrMatchedShadowLists):
(WebCore::PropertyWrapperShadow::blendMismatchedShadowLists):

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setTextShadow):
(WebCore::RenderStyle::setBoxShadow):

• rendering/style/RenderStyle.h:
• rendering/style/SVGRenderStyle.h:

(WebCore::SVGRenderStyle::setShadow):

• rendering/style/SVGRenderStyleDefs.cpp:

(WebCore::StyleShadowSVGData::StyleShadowSVGData):

• rendering/style/SVGRenderStyleDefs.h:
• rendering/style/ShadowData.cpp:

(WebCore::ShadowData::ShadowData):

• rendering/style/ShadowData.h:

(WebCore::ShadowData::setNext):

• rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):

• rendering/style/StyleRareInheritedData.h:
• rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):

• rendering/style/StyleRareNonInheritedData.h:

3:39 AM Changeset in webkit [163750] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[GTK] Fix modifiers on EventSenderProxy::keyDown
​https://bugs.webkit.org/show_bug.cgi?id=128496

Patch by Carlos Garnacho <​carlosg@gnome.org> on 2014-02-09
Reviewed by Carlos Garcia Campos.

• WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::EventSenderProxy::keyDown): do not attempt to doubly transform modifiers
into GTK+ ones.

2:55 AM Changeset in webkit [163749] by commit-queue@webkit.org

• 28 edits
  3 copies in trunk

.: [GTK] Enable touch features
​https://bugs.webkit.org/show_bug.cgi?id=98931

Patch by Carlos Garnacho <​carlosg@gnome.org> on 2014-02-09
Reviewed by Carlos Garcia Campos.

• Source/autotools/SetupWebKitFeatures.m4:
• Source/cmake/OptionsGTK.cmake: set ENABLE_TOUCH_EVENTS to 1 if building with GTK+.

Source/WebCore: [GTK] Add touch-events related code to build
​https://bugs.webkit.org/show_bug.cgi?id=98931

Patch by Carlos Garnacho <​carlosg@gnome.org> on 2014-02-09
Reviewed by Carlos Garcia Campos.

Tests in fast/events/touch have been enabled on GTK+ now that touch
support is implemented, and thus all expected bits are there.

• platform/gtk/GtkTouchContextHelper.cpp:
• platform/gtk/GtkTouchContextHelper.h: Add helper object to track all touchpoints, handy

when creating WebTouchEvents.

• GNUmakefile.list.am:
• PlatformGTK.cmake:
• bindings/gobject/GNUmakefile.am: Add touch related code and idls to build, those are

necessary now that GTK+ implements touch events.

Source/WebKit/gtk: [GTK] Allow building with touch events enabled
​https://bugs.webkit.org/show_bug.cgi?id=98931

Patch by Carlos Garnacho <​carlosg@gnome.org> on 2014-02-09
Reviewed by Carlos Garcia Campos.

Even though WebKit1 GTK code doesn't implement touch events,
Fix build if ENABLE_TOUCH_EVENTS is present for WK2.

• WebCoreSupport/ChromeClientGtk.h:

(WebKit::ChromeClient::needTouchEvents): Add empty stub

Source/WebKit2: [GTK] Implement support touch events
​https://bugs.webkit.org/show_bug.cgi?id=98931

Patch by Carlos Garnacho <​carlosg@gnome.org> on 2014-02-09
Reviewed by Carlos Garcia Campos.

In GTK+ >= 3.4.0, GdkEventTouch is available to inform about multitouch events. Use these to implement
touch events on this platform. If a touch is left unhandled and is the "pointer emulating" one, mouse
events will be generated as a fallback.

• GNUmakefile.list.am:
• PlatformGTK.cmake:
• Shared/gtk/NativeWebTouchEventGtk.cpp:
• Shared/NativeWebTouchEvent.h:

(WebKit::NativeWebTouchEvent::nativeEvent):
(WebKit::NativeWebTouchEvent::touchContext): Add GTK+ implementation of NativeWebTouchEvent.

• Shared/gtk/WebEventFactory.cpp:

(WebKit::touchPhaseFromEvents):
(WebKit::WebEventFactory::createWebTouchEvent): Add methods to generate WebTouchEvents out
of GdkEventTouch events, a GtkTouchContextHelper object is used to hold information about all current
touches, in order to build information about all individual touchpoints.

• Shared/gtk/WebEventFactory.h:
• UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::doneWithTouchEvent): Implement pointer emulation. If a touch event was unhandled
in DOM and pertains to the touch sequence that emulates pointer events. The event gets transformed to its
mouse event counterpart and handled by the widget again.

• UIProcess/API/gtk/PageClientImpl.h:
• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseRealize): Listen for touch events
(webkitWebViewBaseTouchEvent):
(webkit_web_view_base_class_init): Add implementation for the touch_events() handler, this merely
lets the pageProxy handle the NativeWebTouchEvent we create to wrap the GdkEvent received.

Tools: [GTK] Enable touch features
​https://bugs.webkit.org/show_bug.cgi?id=98931

Patch by Carlos Garnacho <​carlosg@gnome.org> on 2014-02-09
Reviewed by Carlos Garcia Campos.

• WebKitTestRunner/EventSenderProxy.h:
• WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::updateEventCoordinates):
(WTR::EventSenderProxy::createTouchEvent):
(WTR::EventSenderProxy::addTouchPoint):
(WTR::EventSenderProxy::updateTouchPoint):
(WTR::EventSenderProxy::sendUpdatedTouchEvents):
(WTR::EventSenderProxy::setTouchPointRadius):
(WTR::EventSenderProxy::setTouchModifier): Implement touch event proxying.

LayoutTests: [GTK] Enable touch features
​https://bugs.webkit.org/show_bug.cgi?id=98931

Patch by Carlos Garnacho <​carlosg@gnome.org> on 2014-02-09
Reviewed by Carlos Garcia Campos.

• platform/gtk/TestExpectations: remove fast/events/touch
• platform/gtk-wk2/TestExpectations: Add new expectations on

fast/events/touch events.

2:31 AM Changeset in webkit [163748] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r162768.
​http://trac.webkit.org/changeset/162768
​https://bugs.webkit.org/show_bug.cgi?id=128495

Causes crashes on GTK WK2 in three fast/forms tests.
(Requested by zdobersek on #webkit).

• UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::showPopupMenu):

2:28 AM WebKitGTK/2.4.x edited by zandobersek@gmail.com

Add the rollout in r163748 to the list of necessary merges. (diff)

12:58 AM Changeset in webkit [163747] by zandobersek@gmail.com

• 13 edits in trunk/Source/WebCore

Switch the rest of CSS code from OwnPtr over to std::unique_ptr
​https://bugs.webkit.org/show_bug.cgi?id=128471

Reviewed by Andreas Kling.

Replace the remaining uses of OwnPtr in the CSS code with std::unique_ptr, covering
the CSSParser, CSSParserSelector and CSSSelector classes and a few additional, closely related classes.

• css/CSSGrammar.y.in:
• css/CSSParser.cpp:

(WebCore::CSSParser::parseSheet):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::markSupportsRuleHeaderStart):
(WebCore::CSSParser::createKeyframesRule):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::rewriteSpecifiersWithElementName):
(WebCore::CSSParser::rewriteSpecifiers):

• css/CSSParser.h:
• css/CSSParserValues.cpp:

(WebCore::CSSParserSelector::CSSParserSelector):
(WebCore::CSSParserSelector::~CSSParserSelector):
(WebCore::CSSParserSelector::adoptSelectorVector):
(WebCore::CSSParserSelector::insertTagHistory):
(WebCore::CSSParserSelector::appendTagHistory):
(WebCore::CSSParserSelector::prependTagSelector):

• css/CSSParserValues.h:

(WebCore::CSSParserSelector::releaseSelector):
(WebCore::CSSParserSelector::setTagHistory):
(WebCore::CSSParserSelector::clearTagHistory):

• css/CSSSelector.cpp:

(WebCore::CSSSelector::setSelectorList):

• css/CSSSelector.h:
• css/CSSSelectorList.cpp:

(WebCore::CSSSelectorList::adoptSelectorVector):

• css/CSSSelectorList.h:
• css/CSSValueList.cpp:
• css/StyleRule.cpp:

(WebCore::StyleRuleRegion::StyleRuleRegion):

• css/StyleRule.h:

(WebCore::StyleRule::parserAdoptSelectorVector):
(WebCore::StyleRulePage::parserAdoptSelectorVector):
(WebCore::StyleRuleRegion::create):

12:33 AM Changeset in webkit [163746] by zandobersek@gmail.com

• 8 edits in trunk/Source/WebCore

Manage MutationObserverInterestGroup through std::unique_ptr
​https://bugs.webkit.org/show_bug.cgi?id=128468

Reviewed by Andreas Kling.

Use std::unique_ptr instead of OwnPtr for managing MutationObserverInterestGroup objects.

• css/PropertySetCSSStyleDeclaration.cpp:
• dom/CharacterData.cpp:

(WebCore::CharacterData::dispatchModifiedEvent):

• dom/ChildListMutationScope.cpp:

(WebCore::ChildListMutationAccumulator::ChildListMutationAccumulator):

• dom/ChildListMutationScope.h:

(WebCore::ChildListMutationAccumulator::hasObservers):

• dom/Element.cpp:

(WebCore::Element::willModifyAttribute):

• dom/MutationObserverInterestGroup.cpp:

(WebCore::MutationObserverInterestGroup::createIfNeeded):

• dom/MutationObserverInterestGroup.h:

(WebCore::MutationObserverInterestGroup::createForChildListMutation):
(WebCore::MutationObserverInterestGroup::createForCharacterDataMutation):
(WebCore::MutationObserverInterestGroup::createForAttributesMutation):

12:19 AM Changeset in webkit [163745] by commit-queue@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r163737.
​http://trac.webkit.org/changeset/163737
​https://bugs.webkit.org/show_bug.cgi?id=128491

Caused 8+ tests to fail on Mavericks and Mountain Lion bots
(Requested by rniwa on #webkit).

• runtime/JSString.h:

(JSC::jsSingleCharacterString):
(JSC::jsSingleCharacterSubstring):
(JSC::jsString):
(JSC::jsSubstring8):

• runtime/SmallStrings.cpp:

(JSC::SmallStringsStorage::SmallStringsStorage):
(JSC::SmallStrings::SmallStrings):

12:18 AM Changeset in webkit [163744] by zandobersek@gmail.com

• 22 edits in trunk/Source/WebCore

Manage MessagePort, MessagePortChannel and friends through std::unique_ptr
​https://bugs.webkit.org/show_bug.cgi?id=128467

Reviewed by Andreas Kling.

Use std::unique_ptr instead of OwnPtr to manage MessagePort, MessagePortArray, MessagePortChannel
and MessagePortChannelArray objects.

• bindings/js/JSMessageEventCustom.cpp:

(WebCore::handleInitMessageEvent):

• dom/MessageEvent.cpp:

(WebCore::MessageEvent::MessageEvent):
(WebCore::MessageEvent::initMessageEvent):

• dom/MessageEvent.h:

(WebCore::MessageEvent::create):

• dom/MessagePort.cpp:

(WebCore::MessagePort::postMessage):
(WebCore::MessagePort::disentangle):
(WebCore::MessagePort::entangle):
(WebCore::MessagePort::dispatchMessages):
(WebCore::MessagePort::disentanglePorts):
(WebCore::MessagePort::entanglePorts):

• dom/MessagePort.h:
• dom/MessagePortChannel.h:
• dom/default/PlatformMessagePortChannel.cpp:

(WebCore::PlatformMessagePortChannel::EventData::EventData):
(WebCore::MessagePortChannel::createChannel):
(WebCore::MessagePortChannel::postMessageToRemote):
(WebCore::MessagePortChannel::tryGetMessageFromRemote):

• dom/default/PlatformMessagePortChannel.h:

(WebCore::PlatformMessagePortChannel::EventData::channels):

• page/DOMWindow.cpp:

(WebCore::PostMessageTimer::PostMessageTimer):
(WebCore::PostMessageTimer::event):
(WebCore::DOMWindow::postMessage):

• workers/DedicatedWorkerGlobalScope.cpp:

(WebCore::DedicatedWorkerGlobalScope::postMessage):

• workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerConnectTask::create):
(WebCore::SharedWorkerConnectTask::SharedWorkerConnectTask):
(WebCore::SharedWorkerConnectTask::performTask):
(WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader):
(WebCore::SharedWorkerScriptLoader::notifyFinished):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
(WebCore::DefaultSharedWorkerRepository::connectToWorker):

• workers/DefaultSharedWorkerRepository.h:
• workers/SharedWorker.cpp:

(WebCore::SharedWorker::create):

• workers/SharedWorkerGlobalScope.cpp:

(WebCore::createConnectEvent):

• workers/SharedWorkerRepository.cpp:

(WebCore::SharedWorkerRepository::connect):

• workers/SharedWorkerRepository.h:
• workers/Worker.cpp:

(WebCore::Worker::postMessage):

• workers/WorkerGlobalScopeProxy.h:
• workers/WorkerMessagingProxy.cpp:

(WebCore::MessageWorkerGlobalScopeTask::create):
(WebCore::MessageWorkerGlobalScopeTask::MessageWorkerGlobalScopeTask):
(WebCore::MessageWorkerGlobalScopeTask::performTask):
(WebCore::MessageWorkerTask::create):
(WebCore::MessageWorkerTask::MessageWorkerTask):
(WebCore::MessageWorkerTask::performTask):
(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope):

• workers/WorkerMessagingProxy.h:
• workers/WorkerObjectProxy.h: