Timeline

Feb 22, 2014:

9:44 PM Changeset in webkit [164554] by mitz@apple.com

• 25 edits in trunk/Source

REGRESSION (r164507): Crash beneath JSGlobalObjectInspectorController::reportAPIException at facebook.com, twitter.com, youtube.com
​https://bugs.webkit.org/show_bug.cgi?id=129227

Reviewed by Eric Carlson.

Reverted r164507.

Source/JavaScriptCore:

• API/JSBase.cpp:

(JSEvaluateScript):
(JSCheckScriptSyntax):

• API/JSObjectRef.cpp:

(JSObjectMakeFunction):
(JSObjectMakeArray):
(JSObjectMakeDate):
(JSObjectMakeError):
(JSObjectMakeRegExp):
(JSObjectGetProperty):
(JSObjectSetProperty):
(JSObjectGetPropertyAtIndex):
(JSObjectSetPropertyAtIndex):
(JSObjectDeleteProperty):
(JSObjectCallAsFunction):
(JSObjectCallAsConstructor):

• API/JSValue.mm:

(valueToArray):
(valueToDictionary):

• API/JSValueRef.cpp:

(JSValueIsEqual):
(JSValueIsInstanceOfConstructor):
(JSValueCreateJSONString):
(JSValueToNumber):
(JSValueToStringCopy):
(JSValueToObject):

• inspector/ConsoleMessage.cpp:

(Inspector::ConsoleMessage::ConsoleMessage):
(Inspector::ConsoleMessage::autogenerateMetadata):

• inspector/ConsoleMessage.h:
• inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):

• inspector/JSGlobalObjectInspectorController.h:
• inspector/ScriptCallStack.cpp:
• inspector/ScriptCallStack.h:
• inspector/ScriptCallStackFactory.cpp:

(Inspector::createScriptCallStack):
(Inspector::createScriptCallStackForConsole):
(Inspector::createScriptCallStackFromException):

• inspector/ScriptCallStackFactory.h:
• inspector/agents/InspectorConsoleAgent.cpp:

(Inspector::InspectorConsoleAgent::enable):
(Inspector::InspectorConsoleAgent::addMessageToConsole):
(Inspector::InspectorConsoleAgent::count):

• inspector/agents/JSGlobalObjectDebuggerAgent.cpp:

(Inspector::JSGlobalObjectDebuggerAgent::breakpointActionLog):

Source/WebCore:

• bindings/js/JSDOMBinding.cpp:

(WebCore::reportException):

• inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::buildInitiatorObject):

• inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::breakpointActionLog):

• inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createGenericRecord):

• page/Console.cpp:

(WebCore::internalAddMessage):
(WebCore::Console::profile):
(WebCore::Console::profileEnd):
(WebCore::Console::timeEnd):

• page/ContentSecurityPolicy.cpp:

(WebCore::gatherSecurityPolicyViolationEventData):
(WebCore::ContentSecurityPolicy::reportViolation):

• page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessage):

Source/WebInspectorUI:

• UserInterface/Views/ConsoleMessageImpl.js:

(WebInspector.ConsoleMessageImpl.prototype._formatMessage):
(WebInspector.ConsoleMessageImpl.prototype._populateStackTraceTreeElement):

5:38 PM Changeset in webkit [164553] by commit-queue@webkit.org

• 13 edits in trunk/Source

Remove some unreachable code (-Wunreachable-code)
​https://bugs.webkit.org/show_bug.cgi?id=129220

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-02-22
Reviewed by Eric Carlson.

Source/JavaScriptCore:

• API/tests/testapi.c:

(EvilExceptionObject_convertToType):

• disassembler/udis86/udis86_decode.c:

(decode_operand):

Source/WebCore:

• html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processCharacterBuffer):
(WebCore::HTMLTreeBuilder::processEndTag):
The only tricky case. Here there was a break inside the
#if, but not the #else, and a break after the #endif.
Remove the break inside the #if, and always use the
break after the #endif.

• Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::modeToString):

• bindings/js/JSTrackCustom.cpp:

(WebCore::toJS):

• bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::functionForUniform):

• css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

• page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::captionDisplayMode):

Source/WebKit2:

• WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:

(WebKit::toAPI):

3:59 PM Changeset in webkit [164552] by dino@apple.com

• 2 edits in trunk/Source/WebCore

Letterpress effect disabled for synthetic italic
​https://bugs.webkit.org/show_bug.cgi?id=129218
<rdar://problem/15997846>

Reviewed by Dan Bernstein.

There was no need to guard against synthetic italics and letterpress.

• platform/graphics/mac/FontMac.mm:

(WebCore::Font::drawGlyphs): Remove !useLetterpressEffect from conditional.

3:56 PM Changeset in webkit [164551] by weinig@apple.com

• 10 edits in trunk/Source

Expose phase and momentum phase as SPI on DOMWheelEvent
<rdar://problem/16110871>
​https://bugs.webkit.org/show_bug.cgi?id=129184

Reviewed by Anders Carlsson.

../WebCore:

• WebCore.exp.in:

Export core(DOMWheelEvent).

• WebCore.xcodeproj/project.pbxproj:

Make DOMWheelEventInternal.h available in WebKit.

• dom/Element.cpp:

(WebCore::Element::dispatchWheelEvent):

• dom/WheelEvent.cpp:

(WebCore::determineDeltaMode):
(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):
(WebCore::WheelEvent::initWebKitWheelEvent):
Move PlatformWheelEvent -> DOMWheelEvent conversion to DOMWheelEvent.

• dom/WheelEvent.h:

(WebCore::WheelEvent::create):
(WebCore::WheelEvent::phase):
(WebCore::WheelEvent::momentumPhase):
Store phase and momentumPhase on the WheelEvent.

../WebKit/mac:

• DOM/WebDOMOperations.mm:

(toNSEventPhase):
(-[DOMWheelEvent _phase]):
(-[DOMWheelEvent _momentumPhase]):

• DOM/WebDOMOperationsPrivate.h:

Expose _phase and _momentumPhase as SPI.

• MigrateHeaders.make:

Make DOMWheelEventInternal.h to WebKit.

2:39 PM Changeset in webkit [164550] by mitz@apple.com

• 2 edits in trunk/Source/WebKit2

[Cocoa] WKUIDelegate.h is a project header
​https://bugs.webkit.org/show_bug.cgi?id=129215

Reviewed by Anders Carlsson.

• WebKit2.xcodeproj/project.pbxproj: Make it a public header.

12:03 PM Changeset in webkit [164549] by fpizlo@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, ARMv7 build fix.

• assembler/ARMv7Assembler.h:

11:55 AM Changeset in webkit [164548] by fpizlo@apple.com

• 8 edits in trunk/Source/JavaScriptCore

It should be possible for a LinkBuffer to outlive the MacroAssembler and still be useful
​https://bugs.webkit.org/show_bug.cgi?id=124733

Reviewed by Oliver Hunt.

This also takes the opportunity to de-duplicate some branch compaction code.

• assembler/ARM64Assembler.h:
• assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::buffer):

• assembler/AssemblerBuffer.h:

(JSC::AssemblerData::AssemblerData):
(JSC::AssemblerBuffer::AssemblerBuffer):
(JSC::AssemblerBuffer::storage):
(JSC::AssemblerBuffer::grow):

• assembler/LinkBuffer.h:

(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::executableOffsetFor):
(JSC::LinkBuffer::applyOffset):

• assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::link):

• assembler/MacroAssemblerARMv7.h:

10:44 AM Changeset in webkit [164547] by mitz@apple.com

• 11 edits in trunk/Source/WebKit2

<rdar://problem/12500358> [Cocoa] Development variants of XPC services should not be installed in WebKit2.framework/XPCServices
​https://bugs.webkit.org/show_bug.cgi?id=129197

Reviewed by Sam Weinig.

• Configurations/BaseXPCService.xcconfig: Made INSTALL_PATH vary based on

WK_XPC_SERVICE_VARIANT. For the Development variant, use an install path outside the
framework. Note that engineering builds using the build action continue to have the
Development variants copied into the framework by a script build phase.

• Configurations/DatabaseService.Development.xcconfig: Set WK_XPC_SERVICE_VARIANT.
• Configurations/DatabaseService.xcconfig: Ditto.
• Configurations/NetworkService.Development.xcconfig: Ditto.
• Configurations/NetworkService.xcconfig: Ditto.
• Configurations/PluginService.32.xcconfig: Ditto.
• Configurations/PluginService.64.xcconfig: Ditto.
• Configurations/PluginService.Development.xcconfig: Ditto.
• Configurations/WebContentService.Development.xcconfig: Ditto.
• Configurations/WebContentService.xcconfig: Ditto.

10:10 AM Changeset in webkit [164546] by ap@apple.com

• 11 edits in trunk

Rename JWK key_ops values from wrap/unwrap to wrapKey/unwrapKey
​https://bugs.webkit.org/show_bug.cgi?id=129121

Reviewed by Sam Weinig.

Source/WebCore:

• bindings/js/JSCryptoKeySerializationJWK.cpp:

(WebCore::JSCryptoKeySerializationJWK::reconcileUsages): Updated to newer names.
(WebCore::addUsagesToJSON): Ditto.
(WebCore::JSCryptoKeySerializationJWK::serialize): rsa-oaep-key-manipulation test
started ot fail, because RSA-OAEP with 2048 bit key and sha-1 can only encrypt
214 bytes, and the new longer names made JSON serialization slightly longer.
Compensate by not doing any indentation in JSON.

LayoutTests:

• crypto/subtle/aes-export-key-expected.txt:
• crypto/subtle/aes-export-key.html:
• crypto/subtle/jwk-export-use-values-expected.txt:
• crypto/subtle/jwk-export-use-values.html:
• crypto/subtle/jwk-import-use-values-expected.txt:
• crypto/subtle/jwk-import-use-values.html:
• crypto/subtle/rsa-oaep-key-manipulation-expected.txt:
• crypto/subtle/rsa-oaep-key-manipulation.html:

9:50 AM Changeset in webkit [164545] by timothy@apple.com

• 1 edit in trunk/LayoutTests/http/tests/inspector-protocol/resources/InspectorTest.js

Fix tests.

9:48 AM Changeset in webkit [164544] by timothy@apple.com

• 2 edits in trunk

Fix production builds and tests.

9:33 AM Changeset in webkit [164543] by timothy@apple.com

• 5 edits
  416 moves
  5 adds
  7 deletes in trunk/Source/WebInspectorUI

Organize WebInspectorUI/UserInterface into sub-directories.

​https://bugs.webkit.org/show_bug.cgi?id=129194

Rubber-stamped by Joseph Pecoraro.

• Scripts/copy-user-interface-resources.sh: Fix Image URLs and Protocol paths.
• UserInterface/Base: Added.
• UserInterface/Controllers: Added.
• UserInterface/Images: Added.
• UserInterface/Main.html: Updated.
• UserInterface/Models Added.
• UserInterface/Protocol Added.
• UserInterface/Views: Added.

9:31 AM Changeset in webkit [164542] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKit/mac

Revert r164434 since it actually broke ASan builds
<​http://webkit.org/b/128871>

• Configurations/WebKit.xcconfig: This caused -asan-blacklist to

be included twice on every compiler command, which caused clang
to error out.

8:06 AM Changeset in webkit [164541] by timothy@apple.com

• 16 edits
  13 adds in trunk

Add inspection user interface for IndexedDB.

​https://bugs.webkit.org/show_bug.cgi?id=129162

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

• Localizations/en.lproj/localizedStrings.js: Updated.
• UserInterface/ContentView.js:

(WebInspector.ContentView):
(WebInspector.ContentView.isViewable):

• UserInterface/IndexedDatabase.js: Added.

(WebInspector.IndexedDatabase):
(WebInspector.IndexedDatabase.prototype.get name):
(WebInspector.IndexedDatabase.prototype.get securityOrigin):
(WebInspector.IndexedDatabase.prototype.get host):
(WebInspector.IndexedDatabase.prototype.get version):
(WebInspector.IndexedDatabase.prototype.get objectStores):
(WebInspector.IndexedDatabase.prototype.saveIdentityToCookie):

• UserInterface/IndexedDatabaseEntryDataGridNode.js: Added.

(WebInspector.IndexedDatabaseEntryDataGridNode):
(WebInspector.IndexedDatabaseEntryDataGridNode.prototype.get entry):
(WebInspector.IndexedDatabaseEntryDataGridNode.prototype.createCellContent):

• UserInterface/IndexedDatabaseHostTreeElement.js: Added.

(WebInspector.IndexedDatabaseHostTreeElement):
(WebInspector.IndexedDatabaseHostTreeElement.prototype.get name):
(WebInspector.IndexedDatabaseHostTreeElement.prototype.get categoryName):

• UserInterface/IndexedDatabaseObjectStore.js: Added.

(WebInspector.IndexedDatabaseObjectStore):
(WebInspector.IndexedDatabaseObjectStore.prototype.get name):
(WebInspector.IndexedDatabaseObjectStore.prototype.get keyPath):
(WebInspector.IndexedDatabaseObjectStore.prototype.get autoIncrement):
(WebInspector.IndexedDatabaseObjectStore.prototype.get parentDatabase):
(WebInspector.IndexedDatabaseObjectStore.prototype.get indexes):
(WebInspector.IndexedDatabaseObjectStore.prototype.saveIdentityToCookie):
(WebInspector.IndexedDatabaseObjectStore.prototype.establishRelationship):

• UserInterface/IndexedDatabaseObjectStoreContentView.css: Added.

(.content-view.indexed-database-object-store > .data-grid):
(.content-view.indexed-database-object-store > .data-grid td .section .header):
(.content-view.indexed-database-object-store > .data-grid td .section .header::before):
(.content-view.indexed-database-object-store > .data-grid td .section .header .title):
(.content-view.indexed-database-object-store > .data-grid table.data):
(.content-view.indexed-database-object-store > .data-grid table.data tr:nth-child(even)):
(.content-view.indexed-database-object-store > .data-grid table.data tr:nth-child(odd)):
(.content-view.indexed-database-object-store > .data-grid table.data tr.filler):
(.content-view.indexed-database-object-store > .data-grid :focus tr.selected td .section .header::before):
(.content-view.indexed-database-object-store > .data-grid :focus tr.selected td .section.expanded .header::before):
(.content-view.indexed-database-object-store > .data-grid :focus tr.selected td .properties-tree li.parent::before):
(.content-view.indexed-database-object-store > .data-grid :focus tr.selected td .properties-tree li.parent.expanded::before):
(.content-view.indexed-database-object-store > .data-grid :focus tr.selected td .properties-tree li *):

• UserInterface/IndexedDatabaseObjectStoreContentView.js: Added.

(WebInspector.IndexedDatabaseObjectStoreContentView.displayKeyPath):
(WebInspector.IndexedDatabaseObjectStoreContentView):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype.closed):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype.saveToCookie):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype.updateLayout):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype._reset):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype._dataGridScrolled):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype._fetchMoreData.processEntries):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype._fetchMoreData):

• UserInterface/IndexedDatabaseObjectStoreIndex.js: Added.

(WebInspector.IndexedDatabaseObjectStoreIndex):
(WebInspector.IndexedDatabaseObjectStoreIndex.prototype.get name):
(WebInspector.IndexedDatabaseObjectStoreIndex.prototype.get keyPath):
(WebInspector.IndexedDatabaseObjectStoreIndex.prototype.get unique):
(WebInspector.IndexedDatabaseObjectStoreIndex.prototype.get multiEntry):
(WebInspector.IndexedDatabaseObjectStoreIndex.prototype.get parentObjectStore):
(WebInspector.IndexedDatabaseObjectStoreIndex.prototype.saveIdentityToCookie):
(WebInspector.IndexedDatabaseObjectStoreIndex.prototype.establishRelationship):

• UserInterface/IndexedDatabaseObjectStoreIndexTreeElement.js: Added.

(WebInspector.IndexedDatabaseObjectStoreIndexTreeElement):
(WebInspector.IndexedDatabaseObjectStoreIndexTreeElement.prototype.get objectStoreIndex):

• UserInterface/IndexedDatabaseObjectStoreTreeElement.js: Added.

(WebInspector.IndexedDatabaseObjectStoreTreeElement):
(WebInspector.IndexedDatabaseObjectStoreTreeElement.prototype.get objectStore):
(WebInspector.IndexedDatabaseObjectStoreTreeElement.prototype.oncollapse):
(WebInspector.IndexedDatabaseObjectStoreTreeElement.prototype.onpopulate):

• UserInterface/IndexedDatabaseTreeElement.js: Added.

(WebInspector.IndexedDatabaseTreeElement):
(WebInspector.IndexedDatabaseTreeElement.prototype.get indexedDatabase):
(WebInspector.IndexedDatabaseTreeElement.prototype.oncollapse):
(WebInspector.IndexedDatabaseTreeElement.prototype.onpopulate):

• UserInterface/Main.html:
• UserInterface/Main.js:

(WebInspector.sidebarPanelForRepresentedObject):

• UserInterface/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel):
(WebInspector.ResourceSidebarPanel.prototype._treeElementSelected):
(WebInspector.ResourceSidebarPanel.prototype._indexedDatabaseWasAdded):
(WebInspector.ResourceSidebarPanel.prototype._storageCleared):

• UserInterface/StorageManager.js:

(WebInspector.StorageManager):
(WebInspector.StorageManager.prototype.initialize):
(WebInspector.StorageManager.prototype.processData):
(WebInspector.StorageManager.prototype.requestIndexedDatabaseData):
(WebInspector.StorageManager.prototype._mainResourceDidChange):
(WebInspector.StorageManager.prototype._addIndexedDBDatabasesIfNeeded.processDatabaseNames):
(WebInspector.StorageManager.prototype._addIndexedDBDatabasesIfNeeded.processDatabase):
(WebInspector.StorageManager.prototype._addIndexedDBDatabasesIfNeeded):
(WebInspector.StorageManager.prototype._addIndexedDBDatabasesIfNeeded.processObjectStore):
(WebInspector.StorageManager.prototype._addIndexedDBDatabasesIfNeeded.processObjectStoreIndex):
(WebInspector.StorageManager.prototype._securityOriginDidChange):

• UserInterface/URLUtilities.js:

(parseSecurityOrigin):

LayoutTests:

• http/tests/inspector-protocol/resources/InspectorTest.js:

(InspectorTest.initializeInspectorModels): Add IndexedDatabase models and StorageManager.

• inspector-protocol/indexeddb/basics-expected.txt: Added.
• inspector-protocol/indexeddb/basics.html: Added.

7:29 AM Changeset in webkit [164540] by graouts@webkit.org

• 4 edits
  2 moves
  1 add in trunk/Source/WebInspectorUI

Web Inspector: allow drag-to-adjust on angle input of gradients editor
​https://bugs.webkit.org/show_bug.cgi?id=129095

Reviewed by Timothy Hatcher.

Rename CodeMirrorDragToAlterNumberController to CodeMirrorDragToAdjustNumberController and move
the core logic of a drag-to-adjust behavior out of it to a new generic class DragToAdjustController.
We use this new class from CodeMirrorGradientEditingController to provide drag-to-adjust behavior
in the angle input field of the gradient editor and also as a supporting object for the CodeMirror-
specific class.

• UserInterface/CodeMirrorDragToAdjustNumberController.css: Renamed from Source/WebInspectorUI/UserInterface/CodeMirrorDragToAlterNumberController.css.

(.CodeMirror.drag-to-adjust .CodeMirror-lines):

• UserInterface/CodeMirrorDragToAdjustNumberController.js: Added.

Removed the UI logic and use the new DragToAdjustController as a supporting object instead. We implement
the various DragToAdjustController delegate methods in order to customize its behavior to work within the
context of a CodeMirror editor, specifically to prevent activation when the editor is read-only and to
prevent adjustment when the hovered token isn't a number.

(WebInspector.CodeMirrorDragToAdjustNumberController):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.get enabled):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.set enabled):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerActiveStateChanged):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerCanBeActivated):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerCanBeAdjusted):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerWasAdjustedByAmount):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerDidReset):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerCanAdjustObjectAtPoint):

• UserInterface/CodeMirrorGradientEditingController.css:

(.gradient-editing-controller > label.drag-to-adjust > input):

• UserInterface/CodeMirrorGradientEditingController.js:

Adopt the new DragToAdjustController to make the angle input field value adjustable by dragging.

(WebInspector.CodeMirrorGradientEditingController.prototype.popoverWillPresent):
(WebInspector.CodeMirrorGradientEditingController.prototype.dragToAdjustControllerWasAdjustedByAmount):
(WebInspector.CodeMirrorGradientEditingController.prototype._handleInputEvent):
(WebInspector.CodeMirrorGradientEditingController.prototype._angleInputValueDidChange):

• UserInterface/DragToAdjustController.js: Renamed from Source/WebInspectorUI/UserInterface/CodeMirrorDragToAlterNumberController.js.

New DragToAdjustController class exposing only the core UI logic of a drag-to-adjust behavior in the context
of a DOM element, exposing a few delegation methods to customize the controller's behavior:

• dragToAdjustControllerActiveStateChanged() notifies that the .active property has changed, allowing bringup

and cleanup work to be performed.

• dragToAdjustControllerDidReset() notifies that the various tracking states of the controller have been reset

allowing other state objects used by clients to be cleared.

• dragToAdjustControllerCanBeActivated() is used to check whether the controller may enter the active state upon

first hovering the target element.

• dragToAdjustControllerCanBeAdjusted() is used to check whether adjustment can be performed at the moment when

the user actually is about to engage in a drag-to-adjust interaction.

• dragToAdjustControllerCanAdjustObjectAtPoint() is used to check whether the object at the provided point (mouse

location) is an adjustable value.

• dragToAdjustControllerWasAdjustedByAmount() notifies that there is a new amount to add to the current value

following a drag-to-adjust interaction.

(WebInspector.DragToAdjustController):
(WebInspector.DragToAdjustController.prototype.get element):
(WebInspector.DragToAdjustController.prototype.set element):
(WebInspector.DragToAdjustController.prototype.set enabled):
(WebInspector.DragToAdjustController.prototype.get active):
(WebInspector.DragToAdjustController.prototype.set active):
(WebInspector.DragToAdjustController.prototype.reset):
(WebInspector.DragToAdjustController.prototype.handleEvent):
(WebInspector.DragToAdjustController.prototype._setDragging):
(WebInspector.DragToAdjustController.prototype._setTracksMouseClickAndDrag):
(WebInspector.DragToAdjustController.prototype._modifiersDidChange):
(WebInspector.DragToAdjustController.prototype._mouseMoved):
(WebInspector.DragToAdjustController.prototype._mouseWasPressed):
(WebInspector.DragToAdjustController.prototype._mouseWasDragged):
(WebInspector.DragToAdjustController.prototype._mouseWasReleased):

• UserInterface/Main.html:

Link in new source files.

5:58 AM Changeset in webkit [164539] by krit@webkit.org

• 1 edit
  114 deletes in trunk/LayoutTests

Replace svg/clip-path pixel tests by reference tests
​https://bugs.webkit.org/show_bug.cgi?id=129177

Patch by Dirk Schulze <​krit@webkit.org> on 2014-02-21
Rubber-stamped by Ryosuke Niwa.

This patch removes all pixel tests.

• platform/efl/svg/clip-path/clip-in-mask-expected.png: Removed.
• platform/efl/svg/clip-path/clip-path-childs-clipped-expected.png: Removed.
• platform/efl/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png: Removed.
• platform/efl/svg/clip-path/clip-path-clipped-expected.png: Removed.
• platform/efl/svg/clip-path/clip-path-clipped-nonzero-expected.png: Removed.
• platform/efl/svg/clip-path/clip-path-css-transform-1-expected.png: Removed.
• platform/efl/svg/clip-path/clip-path-css-transform-2-expected.png: Removed.
• platform/efl/svg/clip-path/clip-path-objectBoundingBox-expected.png: Removed.
• platform/efl/svg/clip-path/clip-path-on-clipped-use-expected.png: Removed.
• platform/efl/svg/clip-path/clip-path-on-g-and-child-expected.png: Removed.
• platform/efl/svg/clip-path/clip-path-on-g-expected.png: Removed.
• platform/efl/svg/clip-path/clip-path-on-svg-and-child-expected.png: Removed.
• platform/efl/svg/clip-path/clip-path-on-svg-expected.png: Removed.
• platform/efl/svg/clip-path/clip-path-pixelation-expected.png: Removed.
• platform/efl/svg/clip-path/clip-path-text-and-stroke-expected.png: Removed.
• platform/efl/svg/clip-path/clip-path-text-expected.png: Removed.
• platform/efl/svg/clip-path/clip-path-transform-2-expected.png: Removed.
• platform/efl/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Removed.
• platform/efl/svg/clip-path/clip-path-use-as-child-expected.png: Removed.
• platform/efl/svg/clip-path/clip-path-userSpaceOnUse-expected.png: Removed.
• platform/efl/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png: Removed.
• platform/efl/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt: Removed.
• platform/efl/svg/clip-path/deep-nested-clip-in-mask-expected.png: Removed.
• platform/efl/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png: Removed.
• platform/efl/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png: Removed.
• platform/efl/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png: Removed.
• platform/efl/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png: Removed.
• platform/gtk/svg/clip-path/clip-in-mask-expected.png: Removed.
• platform/gtk/svg/clip-path/clip-path-child-clipped-expected.png: Removed.
• platform/gtk/svg/clip-path/clip-path-childs-clipped-expected.png: Removed.
• platform/gtk/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png: Removed.
• platform/gtk/svg/clip-path/clip-path-clipped-expected.png: Removed.
• platform/gtk/svg/clip-path/clip-path-clipped-nonzero-expected.png: Removed.
• platform/gtk/svg/clip-path/clip-path-css-transform-1-expected.png: Removed.
• platform/gtk/svg/clip-path/clip-path-css-transform-2-expected.png: Removed.
• platform/gtk/svg/clip-path/clip-path-evenodd-expected.png: Removed.
• platform/gtk/svg/clip-path/clip-path-evenodd-nonzero-expected.png: Removed.
• platform/gtk/svg/clip-path/clip-path-nonzero-evenodd-expected.png: Removed.
• platform/gtk/svg/clip-path/clip-path-nonzero-expected.png: Removed.
• platform/gtk/svg/clip-path/clip-path-objectBoundingBox-expected.png: Removed.
• platform/gtk/svg/clip-path/clip-path-on-clipped-use-expected.png: Removed.
• platform/gtk/svg/clip-path/clip-path-on-g-and-child-expected.png: Removed.
• platform/gtk/svg/clip-path/clip-path-on-g-expected.png: Removed.
• platform/gtk/svg/clip-path/clip-path-on-svg-and-child-expected.png: Removed.
• platform/gtk/svg/clip-path/clip-path-on-svg-expected.png: Removed.
• platform/gtk/svg/clip-path/clip-path-pixelation-expected.png: Removed.
• platform/gtk/svg/clip-path/clip-path-text-and-shape-expected.png: Removed.
• platform/gtk/svg/clip-path/clip-path-text-and-stroke-expected.png: Removed.
• platform/gtk/svg/clip-path/clip-path-text-expected.png: Removed.
• platform/gtk/svg/clip-path/clip-path-transform-2-expected.png: Removed.
• platform/gtk/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Removed.
• platform/gtk/svg/clip-path/clip-path-use-as-child-expected.png: Removed.
• platform/gtk/svg/clip-path/clip-path-userSpaceOnUse-expected.png: Removed.
• platform/gtk/svg/clip-path/clip-path-with-text-clipped-expected.png: Removed.
• platform/gtk/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png: Removed.
• platform/gtk/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt: Removed.
• platform/gtk/svg/clip-path/deep-nested-clip-in-mask-expected.png: Removed.
• platform/gtk/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png: Removed.
• platform/gtk/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png: Removed.
• platform/gtk/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png: Removed.
• platform/gtk/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png: Removed.
• platform/mac/svg/clip-path/clip-in-clip-expected.png: Removed.
• platform/mac/svg/clip-path/clip-in-mask-expected.png: Removed.
• platform/mac/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png: Removed.
• platform/mac/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-child-clipped-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-childs-clipped-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-clipped-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-clipped-no-content-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-clipped-nonzero-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-css-transform-1-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-css-transform-2-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-evenodd-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-evenodd-nonzero-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-nonzero-evenodd-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-nonzero-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-objectBoundingBox-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-on-clipped-use-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-on-g-and-child-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-on-g-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-on-svg-and-child-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-on-svg-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-pixelation-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-pixelation-expected.txt: Removed.
• platform/mac/svg/clip-path/clip-path-recursive-call-by-child-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-recursive-call-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-text-and-shape-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-text-and-shape-expected.txt: Removed.
• platform/mac/svg/clip-path/clip-path-text-and-stroke-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-text-and-stroke-expected.txt: Removed.
• platform/mac/svg/clip-path/clip-path-text-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-text-expected.txt: Removed.
• platform/mac/svg/clip-path/clip-path-transform-1-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-transform-2-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Removed.
• platform/mac/svg/clip-path/clip-path-use-as-child-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-use-as-child2-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-use-as-child3-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-use-as-child4-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-use-as-child5-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-userSpaceOnUse-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-with-container-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-with-different-unittypes-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-with-different-unittypes2-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-with-text-clipped-expected.png: Removed.
• platform/mac/svg/clip-path/clip-path-with-text-clipped-expected.txt: Removed.
• platform/mac/svg/clip-path/clipper-placement-issue-expected.png: Removed.
• platform/mac/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png: Removed.
• platform/mac/svg/clip-path/deep-nested-clip-in-mask-expected.png: Removed.
• platform/mac/svg/clip-path/deep-nested-clip-in-mask-expected.txt: Removed.
• platform/mac/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png: Removed.
• platform/mac/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Removed.
• platform/mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png: Removed.
• platform/mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png: Removed.
• platform/mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png: Removed.
• svg/clip-path/clip-in-clip-expected.png: Removed.
• svg/clip-path/clip-in-clip-expected.txt: Removed.
• svg/clip-path/clip-in-clip.svg: Removed.
• svg/clip-path/clip-in-mask-expected.txt: Removed.
• svg/clip-path/clip-in-mask-objectBoundingBox-expected.txt: Removed.
• svg/clip-path/clip-in-mask-objectBoundingBox.svg: Removed.
• svg/clip-path/clip-in-mask-userSpaceOnUse-expected.txt: Removed.
• svg/clip-path/clip-in-mask-userSpaceOnUse.svg: Removed.
• svg/clip-path/clip-in-mask.svg: Removed.
• svg/clip-path/clip-path-child-clipped-expected.txt: Removed.
• svg/clip-path/clip-path-child-clipped.svg: Removed.
• svg/clip-path/clip-path-childs-clipped-expected.txt: Removed.
• svg/clip-path/clip-path-childs-clipped.svg: Removed.
• svg/clip-path/clip-path-clipped-evenodd-twice-expected.txt: Removed.
• svg/clip-path/clip-path-clipped-evenodd-twice.svg: Removed.
• svg/clip-path/clip-path-clipped-expected.txt: Removed.
• svg/clip-path/clip-path-clipped-no-content-expected.png: Removed.
• svg/clip-path/clip-path-clipped-no-content-expected.txt: Removed.
• svg/clip-path/clip-path-clipped-no-content.svg: Removed.
• svg/clip-path/clip-path-clipped-nonzero-expected.txt: Removed.
• svg/clip-path/clip-path-clipped-nonzero.svg: Removed.
• svg/clip-path/clip-path-clipped.svg: Removed.
• svg/clip-path/clip-path-css-transform-1-expected.txt: Removed.
• svg/clip-path/clip-path-css-transform-1.svg: Removed.
• svg/clip-path/clip-path-css-transform-2-expected.txt: Removed.
• svg/clip-path/clip-path-css-transform-2.svg: Removed.
• svg/clip-path/clip-path-evenodd-expected.txt: Removed.
• svg/clip-path/clip-path-evenodd-nonzero-expected.txt: Removed.
• svg/clip-path/clip-path-evenodd-nonzero.svg: Removed.
• svg/clip-path/clip-path-evenodd.svg: Removed.
• svg/clip-path/clip-path-nonzero-evenodd-expected.txt: Removed.
• svg/clip-path/clip-path-nonzero-evenodd.svg: Removed.
• svg/clip-path/clip-path-nonzero-expected.txt: Removed.
• svg/clip-path/clip-path-nonzero.svg: Removed.
• svg/clip-path/clip-path-objectBoundingBox-expected.txt: Removed.
• svg/clip-path/clip-path-objectBoundingBox.svg: Removed.
• svg/clip-path/clip-path-on-clipped-use-expected.txt: Removed.
• svg/clip-path/clip-path-on-clipped-use.svg: Removed.
• svg/clip-path/clip-path-on-g-and-child-expected.txt: Removed.
• svg/clip-path/clip-path-on-g-and-child.svg: Removed.
• svg/clip-path/clip-path-on-g-expected.txt: Removed.
• svg/clip-path/clip-path-on-g.svg: Removed.
• svg/clip-path/clip-path-on-svg-and-child-expected.txt: Removed.
• svg/clip-path/clip-path-on-svg-and-child.svg: Removed.
• svg/clip-path/clip-path-on-svg-expected.txt: Removed.
• svg/clip-path/clip-path-on-svg.svg: Removed.
• svg/clip-path/clip-path-pixelation-expected.txt: Removed.
• svg/clip-path/clip-path-pixelation.svg: Removed.
• svg/clip-path/clip-path-recursive-call-by-child-expected.png: Removed.
• svg/clip-path/clip-path-recursive-call-by-child-expected.txt: Removed.
• svg/clip-path/clip-path-recursive-call-by-child.svg: Removed.
• svg/clip-path/clip-path-recursive-call-expected.png: Removed.
• svg/clip-path/clip-path-recursive-call-expected.txt: Removed.
• svg/clip-path/clip-path-recursive-call.svg: Removed.
• svg/clip-path/clip-path-text-and-shape-expected.txt: Removed.
• svg/clip-path/clip-path-text-and-shape.svg: Removed.
• svg/clip-path/clip-path-text-and-stroke-expected.txt: Removed.
• svg/clip-path/clip-path-text-and-stroke.svg: Removed.
• svg/clip-path/clip-path-text-expected.txt: Removed.
• svg/clip-path/clip-path-text.svg: Removed.
• svg/clip-path/clip-path-transform-1-expected.txt: Removed.
• svg/clip-path/clip-path-transform-1.svg: Removed.
• svg/clip-path/clip-path-transform-2-expected.txt: Removed.
• svg/clip-path/clip-path-transform-2.svg: Removed.
• svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Removed.
• svg/clip-path/clip-path-tspan-and-stroke.svg: Removed.
• svg/clip-path/clip-path-use-as-child-expected.txt: Removed.
• svg/clip-path/clip-path-use-as-child.svg: Removed.
• svg/clip-path/clip-path-use-as-child2-expected.png: Removed.
• svg/clip-path/clip-path-use-as-child2-expected.txt: Removed.
• svg/clip-path/clip-path-use-as-child2.svg: Removed.
• svg/clip-path/clip-path-use-as-child3-expected.png: Removed.
• svg/clip-path/clip-path-use-as-child3-expected.txt: Removed.
• svg/clip-path/clip-path-use-as-child3.svg: Removed.
• svg/clip-path/clip-path-use-as-child4-expected.png: Removed.
• svg/clip-path/clip-path-use-as-child4-expected.txt: Removed.
• svg/clip-path/clip-path-use-as-child4.svg: Removed.
• svg/clip-path/clip-path-use-as-child5-expected.png: Removed.
• svg/clip-path/clip-path-use-as-child5-expected.txt: Removed.
• svg/clip-path/clip-path-use-as-child5.svg: Removed.
• svg/clip-path/clip-path-userSpaceOnUse-expected.txt: Removed.
• svg/clip-path/clip-path-userSpaceOnUse.svg: Removed.
• svg/clip-path/clip-path-with-container-expected.png: Removed.
• svg/clip-path/clip-path-with-container-expected.txt: Removed.
• svg/clip-path/clip-path-with-container.svg: Removed.
• svg/clip-path/clip-path-with-different-unittypes-expected.png: Removed.
• svg/clip-path/clip-path-with-different-unittypes-expected.txt: Removed.
• svg/clip-path/clip-path-with-different-unittypes.svg: Removed.
• svg/clip-path/clip-path-with-different-unittypes2-expected.png: Removed.
• svg/clip-path/clip-path-with-different-unittypes2-expected.txt: Removed.
• svg/clip-path/clip-path-with-different-unittypes2.svg: Removed.
• svg/clip-path/clip-path-with-invisibile-child-expected.png: Removed.
• svg/clip-path/clip-path-with-invisibile-child-expected.txt: Removed.
• svg/clip-path/clip-path-with-invisibile-child.svg: Removed.
• svg/clip-path/clip-path-with-text-clipped-expected.txt: Removed.
• svg/clip-path/clip-path-with-text-clipped.svg: Removed.
• svg/clip-path/clipper-placement-issue-expected.png: Removed.
• svg/clip-path/clipper-placement-issue-expected.txt: Removed.
• svg/clip-path/clipper-placement-issue.svg: Removed.
• svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt: Removed.
• svg/clip-path/deep-nested-clip-in-mask-different-unitTypes.svg: Removed.
• svg/clip-path/deep-nested-clip-in-mask-expected.txt: Removed.
• svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Removed.
• svg/clip-path/deep-nested-clip-in-mask-panning.svg: Removed.
• svg/clip-path/deep-nested-clip-in-mask.svg: Removed.
• svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt: Removed.
• svg/clip-path/nested-clip-in-mask-image-based-clipping.svg: Removed.
• svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt: Removed.
• svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping.svg: Removed.
• svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt: Removed.
• svg/clip-path/nested-clip-in-mask-path-based-clipping.svg: Removed.

2:21 AM Changeset in webkit [164538] by fred.wang@free.fr

• 5 edits in trunk

Only skip stretchy operators when determining the stretch height.
​https://bugs.webkit.org/show_bug.cgi?id=126842

Reviewed by Chris Fleizach.

Source/WebCore:

The MathML code only takes into account non-mo children for the computation of the stretch size. This change includes non-stretchy mo in that computation. A new test is added into mathml/presentation/stretchy-depth-height.html.

• rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::layout):

LayoutTests:

• mathml/presentation/stretchy-depth-height.html: Add a test with non-stretchy mo siblings.

2:14 AM Changeset in webkit [164537] by fred.wang@free.fr

• 4 edits
  2 adds in trunk

Implement asymmetric/symmetric stretching of vertical operators.
​https://bugs.webkit.org/show_bug.cgi?id=124827.

Reviewed by Chris Fleizach.

Source/WebCore:

The MathML code stretches vertical operators asymmetrically by default. This patch takes into account the symmetric attribute or the symmetric property of the operator dictionary to stretch operators symmetrically.

Test: mathml/presentation/stretchy-depth-height-symmetric.html

• rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::stretchTo):
(WebCore::RenderMathMLOperator::updateFromElement):
(WebCore::RenderMathMLOperator::updateStyle):

LayoutTests:

Add a new test to verify the symmetric property of operators (either implicit by the operator dictionary or explicit via an mo attribute).

• LayoutTests/platform/mac/mathml/presentation/mo-stretch-expected.txt: rebased.
• mathml/presentation/stretchy-depth-height-symmetric-expected.txt: Added.
• mathml/presentation/stretchy-depth-height-symmetric.html: Added.

2:08 AM Changeset in webkit [164536] by fred.wang@free.fr

• 8 edits
  2 adds in trunk

Bug 119043 - Large stretch size error for MathML operators.
​https://bugs.webkit.org/show_bug.cgi?id=119043

Reviewed by Chris Fleizach.

Source/WebCore:

The MathML code used some arbitrary gOperatorExpansion factor for the
stretch size and 2/3 1/2 constants for the baseline. This change tries
to consider height/depth of siblings of the stretchy operator so that
the stretchy operator now matches its target.

Test: mathml/presentation/stretchy-depth-height.html

• rendering/RenderObject.h:

(WebCore::RenderObject::isRenderMathMLTable):

• rendering/mathml/RenderMathMLBlock.h:
• rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::RenderMathMLOperator):
(WebCore::RenderMathMLOperator::stretchTo):
(WebCore::RenderMathMLOperator::findAcceptableStretchyCharacter):
(WebCore::RenderMathMLOperator::updateStyle):
(WebCore::RenderMathMLOperator::firstLineBaseline):
(WebCore::RenderMathMLOperator::computeLogicalHeight):

• rendering/mathml/RenderMathMLOperator.h:
• rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::layout):

LayoutTests:

This adds a test to check that the depth/height of stretchy operators match the maximum of their siblings. This also fixes the reference of mo-stretch.html to ignore the stretch error.

• mathml/presentation/stretchy-depth-height-expected.txt: Added.
• mathml/presentation/stretchy-depth-height.html: Added.
• platform/mac/mathml/presentation/mo-stretch-expected.txt:

1:57 AM Changeset in webkit [164535] by fred.wang@free.fr

• 8 edits
  2 deletes in trunk

Unreviewed, rolling out r164534.
​http://trac.webkit.org/changeset/164534
​https://bugs.webkit.org/show_bug.cgi?id=119043

missing tests

Source/WebCore:

• rendering/RenderObject.h:
• rendering/mathml/RenderMathMLBlock.h:
• rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::RenderMathMLOperator):
(WebCore::RenderMathMLOperator::expandedStretchHeight):
(WebCore::RenderMathMLOperator::stretchToHeight):
(WebCore::RenderMathMLOperator::findAcceptableStretchyCharacter):
(WebCore::RenderMathMLOperator::updateStyle):
(WebCore::RenderMathMLOperator::firstLineBaseline):
(WebCore::RenderMathMLOperator::computeLogicalHeight):

• rendering/mathml/RenderMathMLOperator.h:
• rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::layout):

LayoutTests:

• mathml/presentation/stretchy-depth-height-expected.txt: Removed.
• mathml/presentation/stretchy-depth-height.html: Removed.
• platform/mac/mathml/presentation/mo-stretch-expected.txt:

1:50 AM Changeset in webkit [164534] by fred.wang@free.fr

• 8 edits
  2 adds in trunk

Bug 119043 - Large stretch size error for MathML operators.
​https://bugs.webkit.org/show_bug.cgi?id=119043

Reviewed by Chris Fleizach.

Source/WebCore:

The MathML code used some arbitrary gOperatorExpansion factor for the
stretch size and 2/3 1/2 constants for the baseline. This change tries
to consider height/depth of siblings of the stretchy operator so that
the stretchy operator now matches its target.

Test: mathml/presentation/stretchy-depth-height.html

• rendering/RenderObject.h:

(WebCore::RenderObject::isRenderMathMLTable):

• rendering/mathml/RenderMathMLBlock.h:
• rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::RenderMathMLOperator):
(WebCore::RenderMathMLOperator::stretchTo):
(WebCore::RenderMathMLOperator::findAcceptableStretchyCharacter):
(WebCore::RenderMathMLOperator::updateStyle):
(WebCore::RenderMathMLOperator::firstLineBaseline):
(WebCore::RenderMathMLOperator::computeLogicalHeight):

• rendering/mathml/RenderMathMLOperator.h:
• rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::layout):

LayoutTests:

This adds a test to check that the depth/height of stretchy operators match the maximum of their siblings. This also fixes the reference of mo-stretch.html to ignore the stretch error.

• mathml/presentation/stretchy-depth-height-expected.txt: Added.
• mathml/presentation/stretchy-depth-height.html: Added.
• platform/mac/mathml/presentation/mo-stretch-expected.txt:

1:23 AM Changeset in webkit [164533] by gyuyoung.kim@samsung.com

• 2 edits in trunk/LayoutTests

Unreviewed, EFL WK2 gardening. Skip a webgl test because of crashing.
Besides a bug is filed and assigned to those crash tests.

• platform/efl-wk2/TestExpectations:

Feb 21, 2014:

11:24 PM Changeset in webkit [164532] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

REGRESSION(r164412): Pixel cracks when zooming in to any web content.
​https://bugs.webkit.org/show_bug.cgi?id=129195

Reviewed by Simon Fraser.

Integral clipping of the repaint rect was prematurely removed in RenderLayerBacking::paintContents().
Repaint rects needs a uniform, device pixel precise clipping across the painting flow including RenderLayer,
RenderView and TileController.

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintContents):
(WebCore::RenderLayerBacking::compositedBoundsIncludingMargin):

11:20 PM Changeset in webkit [164531] by krit@webkit.org

• 5 edits
  128 adds in trunk/LayoutTests

Replace svg/clip-path pixel tests by reference tests
​https://bugs.webkit.org/show_bug.cgi?id=129177

Reviewed by Dean Jackson.

New reference tests for SVG clip-path.

• platform/efl/TestExpectations:
• platform/gtk/TestExpectations:
• platform/mac/TestExpectations:
• platform/win/TestExpectations:
• svg/clip-path/clip-path-clip-expected.svg: Added.
• svg/clip-path/clip-path-clip-nested-twice-expected.svg: Added.
• svg/clip-path/clip-path-clip-nested-twice.svg: Added.
• svg/clip-path/clip-path-clip-rule-001-expected.svg: Added.
• svg/clip-path/clip-path-clip-rule-001.svg: Added.
• svg/clip-path/clip-path-clip-rule-002-expected.svg: Added.
• svg/clip-path/clip-path-clip-rule-002.svg: Added.
• svg/clip-path/clip-path-clip-rule-003-expected.svg: Added.
• svg/clip-path/clip-path-clip-rule-003.svg: Added.
• svg/clip-path/clip-path-clip-rule-004-expected.svg: Added.
• svg/clip-path/clip-path-clip-rule-004.svg: Added.
• svg/clip-path/clip-path-clip-rule-005-expected.svg: Added.
• svg/clip-path/clip-path-clip-rule-005.svg: Added.
• svg/clip-path/clip-path-clip-rule-006-expected.svg: Added.
• svg/clip-path/clip-path-clip-rule-006.svg: Added.
• svg/clip-path/clip-path-clip-rule-007-expected.svg: Added.
• svg/clip-path/clip-path-clip-rule-007.svg: Added.
• svg/clip-path/clip-path-clip-rule-008-expected.svg: Added.
• svg/clip-path/clip-path-clip-rule-008.svg: Added.
• svg/clip-path/clip-path-clip-rule-009-expected.svg: Added.
• svg/clip-path/clip-path-clip-rule-009.svg: Added.
• svg/clip-path/clip-path-clip-rule-010-expected.svg: Added.
• svg/clip-path/clip-path-clip-rule-010.svg: Added.
• svg/clip-path/clip-path-clip.svg: Added.
• svg/clip-path/clip-path-content-clip-001-expected.svg: Added.
• svg/clip-path/clip-path-content-clip-001.svg: Added.
• svg/clip-path/clip-path-content-clip-002-expected.svg: Added.
• svg/clip-path/clip-path-content-clip-002.svg: Added.
• svg/clip-path/clip-path-content-clip-003-expected.svg: Added.
• svg/clip-path/clip-path-content-clip-003.svg: Added.
• svg/clip-path/clip-path-content-invisible-expected.svg: Added.
• svg/clip-path/clip-path-content-invisible.svg: Added.
• svg/clip-path/clip-path-content-syling-expected.svg: Added.
• svg/clip-path/clip-path-content-syling.svg: Added.
• svg/clip-path/clip-path-content-use-001-expected.svg: Added.
• svg/clip-path/clip-path-content-use-001.svg: Added.
• svg/clip-path/clip-path-content-use-002-expected.svg: Added.
• svg/clip-path/clip-path-content-use-002.svg: Added.
• svg/clip-path/clip-path-content-use-003-expected.svg: Added.
• svg/clip-path/clip-path-content-use-003.svg: Added.
• svg/clip-path/clip-path-content-use-004-expected.svg: Added.
• svg/clip-path/clip-path-content-use-004.svg: Added.
• svg/clip-path/clip-path-content-use-005-expected.svg: Added.
• svg/clip-path/clip-path-content-use-005.svg: Added.
• svg/clip-path/clip-path-content-use-006-expected.svg: Added.
• svg/clip-path/clip-path-content-use-006.svg: Added.
• svg/clip-path/clip-path-css-transform-001-expected.svg: Added.
• svg/clip-path/clip-path-css-transform-001.svg: Added.
• svg/clip-path/clip-path-css-transform-002-expected.svg: Added.
• svg/clip-path/clip-path-css-transform-002.svg: Added.
• svg/clip-path/clip-path-invalid-expected.svg: Added.
• svg/clip-path/clip-path-invalid.svg: Added.
• svg/clip-path/clip-path-no-content-001-expected.svg: Added.
• svg/clip-path/clip-path-no-content-001.svg: Added.
• svg/clip-path/clip-path-no-content-002-expected.svg: Added.
• svg/clip-path/clip-path-no-content-002.svg: Added.
• svg/clip-path/clip-path-no-content-003-expected.svg: Added.
• svg/clip-path/clip-path-no-content-003.svg: Added.
• svg/clip-path/clip-path-objectboundingbox-001-expected.svg: Added.
• svg/clip-path/clip-path-objectboundingbox-001.svg: Added.
• svg/clip-path/clip-path-objectboundingbox-002-expected.svg: Added.
• svg/clip-path/clip-path-objectboundingbox-002.svg: Added.
• svg/clip-path/clip-path-objectboundingbox-003-expected.svg: Added.
• svg/clip-path/clip-path-objectboundingbox-003.svg: Added.
• svg/clip-path/clip-path-objectboundingbox-004-expected.svg: Added.
• svg/clip-path/clip-path-objectboundingbox-004.svg: Added.
• svg/clip-path/clip-path-on-g-001-expected.svg: Added.
• svg/clip-path/clip-path-on-g-001.svg: Added.
• svg/clip-path/clip-path-on-g-002-expected.svg: Added.
• svg/clip-path/clip-path-on-g-002.svg: Added.
• svg/clip-path/clip-path-on-g-003-expected.svg: Added.
• svg/clip-path/clip-path-on-g-003.svg: Added.
• svg/clip-path/clip-path-on-g-004-expected.svg: Added.
• svg/clip-path/clip-path-on-g-004.svg: Added.
• svg/clip-path/clip-path-on-g-005-expected.svg: Added.
• svg/clip-path/clip-path-on-g-005.svg: Added.
• svg/clip-path/clip-path-on-svg-001-expected.svg: Added.
• svg/clip-path/clip-path-on-svg-001.svg: Added.
• svg/clip-path/clip-path-on-svg-002-expected.svg: Added.
• svg/clip-path/clip-path-on-svg-002.svg: Added.
• svg/clip-path/clip-path-on-use-001-expected.svg: Added.
• svg/clip-path/clip-path-on-use-001.svg: Added.
• svg/clip-path/clip-path-on-use-002-expected.svg: Added.
• svg/clip-path/clip-path-on-use-002.svg: Added.
• svg/clip-path/clip-path-precision-001-expected.svg: Added.
• svg/clip-path/clip-path-precision-001.svg: Added.
• svg/clip-path/clip-path-text-001-expected.svg: Added.
• svg/clip-path/clip-path-text-001.svg: Added.
• svg/clip-path/clip-path-text-002-expected.svg: Added.
• svg/clip-path/clip-path-text-002.svg: Added.
• svg/clip-path/clip-path-text-003-expected.svg: Added.
• svg/clip-path/clip-path-text-003.svg: Added.
• svg/clip-path/clip-path-text-004-expected.svg: Added.
• svg/clip-path/clip-path-text-004.svg: Added.
• svg/clip-path/clip-path-text-005-expected.svg: Added.
• svg/clip-path/clip-path-text-005.svg: Added.
• svg/clip-path/clip-path-userspaceonuse-001-expected.svg: Added.
• svg/clip-path/clip-path-userspaceonuse-001.svg: Added.
• svg/clip-path/mask-nested-clip-path-001-expected.svg: Added.
• svg/clip-path/mask-nested-clip-path-001.svg: Added.
• svg/clip-path/mask-nested-clip-path-002-expected.svg: Added.
• svg/clip-path/mask-nested-clip-path-002.svg: Added.
• svg/clip-path/mask-nested-clip-path-003-expected.svg: Added.
• svg/clip-path/mask-nested-clip-path-003.svg: Added.
• svg/clip-path/mask-nested-clip-path-004-expected.svg: Added.
• svg/clip-path/mask-nested-clip-path-004.svg: Added.
• svg/clip-path/mask-nested-clip-path-005-expected.svg: Added.
• svg/clip-path/mask-nested-clip-path-005.svg: Added.
• svg/clip-path/mask-nested-clip-path-006-expected.svg: Added.
• svg/clip-path/mask-nested-clip-path-006.svg: Added.
• svg/clip-path/mask-nested-clip-path-007-expected.svg: Added.
• svg/clip-path/mask-nested-clip-path-007.svg: Added.
• svg/clip-path/mask-nested-clip-path-008-expected.svg: Added.
• svg/clip-path/mask-nested-clip-path-008.svg: Added.
• svg/clip-path/mask-nested-clip-path-009-expected.svg: Added.
• svg/clip-path/mask-nested-clip-path-009.svg: Added.
• svg/clip-path/mask-nested-clip-path-panning-001-expected.svg: Added.
• svg/clip-path/mask-nested-clip-path-panning-001.svg: Added.
• svg/clip-path/mask-nested-clip-path-panning-002-expected.svg: Added.
• svg/clip-path/mask-nested-clip-path-panning-002.svg: Added.
• svg/clip-path/mask-objectboundingbox-content-clip-expected.svg: Added.
• svg/clip-path/mask-objectboundingbox-content-clip-transform-expected.svg: Added.
• svg/clip-path/mask-objectboundingbox-content-clip-transform.svg: Added.
• svg/clip-path/mask-objectboundingbox-content-clip.svg: Added.
• svg/clip-path/mask-userspaceonuse-content-clip-expected.svg: Added.
• svg/clip-path/mask-userspaceonuse-content-clip-transform-expected.svg: Added.
• svg/clip-path/mask-userspaceonuse-content-clip-transform.svg: Added.
• svg/clip-path/mask-userspaceonuse-content-clip.svg: Added.

10:56 PM Changeset in webkit [164530] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

Unreviewed Mac build fix after r164529.

Replace the string-to-array algorithm with a archictecture-independant
one.

• platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:

(WebCore::CDMSessionMediaSourceAVFObjC::generateKeyRequest):

10:17 PM Changeset in webkit [164529] by jer.noble@apple.com

• 8 edits
  2 adds in trunk/Source/WebCore

[EME] Add a CDMSession for MediaPlayerPrivateMediaSourceAVFObjC
​https://bugs.webkit.org/show_bug.cgi?id=129166

Reviewed by Eric Carlson.

Add a new CDMSession, cerated by MediaPlayerPrivateMediaSourceAVFObjC allowing
media-source-backed media elements to play protected content.

Add a new CDMSessionMediaSourceAVFObjC class:

• platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h: Added.

(WebCore::CDMSessionMediaSourceAVFObjC::~CDMSessionMediaSourceAVFObjC):

• platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm: Added.

(WebCore::CDMSessionMediaSourceAVFObjC::CDMSessionMediaSourceAVFObjC):
(WebCore::CDMSessionMediaSourceAVFObjC::generateKeyRequest): Do not actually generate a

key request until the certificate data has been added via update();

(WebCore::CDMSessionMediaSourceAVFObjC::releaseKeys): No-op.
(WebCore::CDMSessionMediaSourceAVFObjC::update): If no certificate data has yet been

added, assume the incoming message contains it.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::registerMediaEngine): Add supportsKeySystem.
(WebCore::keySystemIsSupported): Use "com.apple.fps.2_0" to distinguish from the not-media-source scheme.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::supportsType): Check the keySystem type.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::supportsKeySystem): Added.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::createSession): Added, pass through to MediaSourcePrivate.

• platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h:
• platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:

(WebCore::MediaSourcePrivateAVFObjC::createSession): Added.
(WebCore::MediaSourcePrivateAVFObjC::sourceBufferKeyNeeded): Pass through to MediaPlayer.

• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(-[WebAVStreamDataParserListener streamDataParser:didProvideContentKeyRequestInitializationData:forTrackID:]):

Added, pass through to SourceBufferPrivate.

(WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::didProvideContentKeyRequestInitializationDataForTrackID): Remember

which track is requesting the key, and pass the request to MediaSourcePrivate.

Add new files to the project.

• WebCore.xcodeproj/project.pbxproj:

10:07 PM Changeset in webkit [164528] by ap@apple.com

• 2 edits in trunk/Source/WebCore

CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify contains seemingly accidental unreachable code
​https://bugs.webkit.org/show_bug.cgi?id=129193

Reviewed by Joseph Pecoraro.

• crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify): Fix the accidental code.

9:05 PM Changeset in webkit [164527] by Brent Fulgham

• 14 edits in trunk/Source

Extend media support for WebVTT sources
​https://bugs.webkit.org/show_bug.cgi?id=129156

Reviewed by Eric Carlson.

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig: Add new feature define for AVF_CAPTIONS

Source/WebCore:

• Configurations/FeatureDefines.xcconfig: Add new feature define for AVF_CAPTIONS
• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::outOfBandTrackSources): Added.

• html/HTMLMediaElement.h:
• platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::outOfBandTrackSources): Added.

• platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::outOfBandTrackSources): Added.

• platform/graphics/PlatformTextTrack.h:

(WebCore::PlatformTextTrack::create): Update for new constructor signature.
(WebCore::PlatformTextTrack::createOutOfBand): Added.
(WebCore::PlatformTextTrack::url): Added.
(WebCore::PlatformTextTrack::isDefault): Added.
(WebCore::PlatformTextTrack::PlatformTextTrack): Revised to take new URL and
'isDefault' arguments.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::mediaDescriptionForKind): Added.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Tell AVFoundation about any
WebVTT tracks supplied by the web page.
(WebCore::MediaPlayerPrivateAVFoundationObjC::processMediaSelectionOptions): Filter out any out-of-band
WebVTT tracks returned by the media engine to avoid double-counting tracks.

Source/WebKit/mac:

• Configurations/FeatureDefines.xcconfig: Add new feature define for AVF_CAPTIONS

Source/WebKit2:

• Configurations/FeatureDefines.xcconfig: Add new feature define for AVF_CAPTIONS

8:09 PM Changeset in webkit [164526] by rniwa@webkit.org

• 23 edits in trunk

Inner text element should not use -webkit-user-modify
​https://bugs.webkit.org/show_bug.cgi?id=129035

Reviewed by Andreas Kling.

Source/WebCore:

To eliminate the internal use of -webkit-user-modify, use contenteditable attribute in the inner text elements
instead of manually inspecting disabled-ness and readonly-ness in RenderTextControl.

Unfortunately, we still have to manually set UserModify value in RenderTextControl::adjustInnerTextStyle since
RenderTextControl::styleDidChange creates RenderStyle for its inner text from scratch via createInnerTextStyle.

• html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::disabledStateChanged): Don't use childrenOfType iterator which asserts that DOM
isn't mutated during the traversal since we now set contenteditable attribute inside disabledStateChanged via
updateFromControlElementsAncestorDisabledStateUnder.

• html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::parseAttribute): Extracted readOnlyAttributeChanged out of this function so
that HTMLTextFormControl could override it to call updateInnerTextElementEditability.
(WebCore::HTMLFormControlElement::readOnlyAttributeChanged): Ditto.

• html/HTMLFormControlElement.h:

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::didAddUserAgentShadowRoot): Call updateInnerTextElementEditability after creating
shadow DOM for the current input type.
(WebCore::HTMLInputElement::updateType): Ditto.
(WebCore::HTMLInputElement::parseAttribute): Ditto.

• html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::didAddUserAgentShadowRoot): Call updateInnerTextElementEditability.

• html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::disabledStateChanged): Added to update contenteditable attribute since
the editability of the inner text element depends on disabled-ness of the element.
(WebCore::HTMLTextFormControlElement::readOnlyAttributeChanged): Ditto for the readonly-ness of the element.
(WebCore::HTMLTextFormControlElement::updateInnerTextElementEditability): Added.

• html/HTMLTextFormControlElement.h:

• rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::adjustInnerTextStyle): Use the inner text element's presentationAttributeStyle() to
compute the appropriate EUserModify value instead of hard-coding it here.

• rendering/RenderTextControl.h:

LayoutTests:

Rebaselined tests as the user agent shadow DOM of input and textarea elements now have contenteditable attribute.

• editing/input/paste-text-ending-with-interchange-newline-expected.txt:
• editing/inserting/5607069-2-expected.txt:
• editing/inserting/5607069-3-expected.txt:
• editing/pasteboard/copy-image-with-alt-text-expected.txt:
• editing/pasteboard/copy-null-characters-expected.txt:
• editing/pasteboard/nested-blocks-with-text-area-expected.txt:
• editing/pasteboard/nested-blocks-with-text-field-expected.txt:
• editing/selection/dump-as-markup-expected.txt:
• editing/selection/dump-as-markup-form-text-expected.txt:
• fast/forms/suggested-value-after-setvalue-expected.txt:
• fast/forms/suggested-value-expected.txt:
• fast/parser/object-with-textarea-fallback-expected.txt:

7:56 PM Changeset in webkit [164525] by ChangSeok Oh

• 4 edits in trunk/Source/WebCore

[GTK] Support WEBGL_draw_buffers extension.
​https://bugs.webkit.org/show_bug.cgi?id=129143

Reviewed by Dean Jackson.

Support the WEBGL_draw_buffers WebGL extension for gtk port. Relevant opengl APIs
are exposed for WebGLRenderingContext to access them properly.

Covered by fast/canvas/webgl/webgl-draw-buffers.html

• platform/graphics/OpenGLShims.cpp:

(WebCore::initializeOpenGLShims):

• platform/graphics/OpenGLShims.h:
• platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::supportsExtension):
(WebCore::Extensions3DOpenGL::drawBuffersEXT):

7:53 PM Changeset in webkit [164524] by ChangSeok Oh

• 4 edits in trunk/Source/WebCore

Mac port uses ANGLE_instanced_arrays related apis through those in GraphicsContext3DCommon.cpp
​https://bugs.webkit.org/show_bug.cgi?id=128803

Reviewed by Dean Jackson.

Merge mac port implementation of ANGLE_instanced_arrays into common code.

No new tests, no functionality changed.

• platform/graphics/mac/GraphicsContext3DMac.mm:
• platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::drawArraysInstanced):
(WebCore::Extensions3DOpenGL::drawElementsInstanced):
(WebCore::Extensions3DOpenGL::vertexAttribDivisor):

• platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::vertexAttribDivisor):

7:39 PM Changeset in webkit [164523] by enrica@apple.com

• 2 edits in trunk/Source/WebKit2

[iOS WebKit2] Keyboard appears every time a link is tapped after searching Google
<rdar://problem/16072563>.

Reviewed by Benjamin Poulain.

We need to stop assisting the node if we have
navigated to a different page.

• UIProcess/API/ios/WKContentView.mm:

(-[WKContentView _didCommitLoadForMainFrame]):

7:15 PM Changeset in webkit [164522] by mitz@apple.com

• 4 edits in trunk/Source/WebKit2

Made WKWebView implement all WKContentViewDelegate methods.

Reviewed by Anders Carlsson.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView takeViewSnapshotForContentView:]): Moved from WKViewIOS.mm.

• UIProcess/API/ios/WKContentView.h: Made all protocol methods required.
• UIProcess/API/ios/WKViewIOS.mm:

(-[WKView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]): Removed code
to set self as the delegate on the content view.

7:14 PM Changeset in webkit [164521] by mmaxfield@apple.com

• 5 edits
  2 adds in trunk

After copy and paste, cursor may appear to be above the bottom of content
​https://bugs.webkit.org/show_bug.cgi?id=129167

Reviewed by Ryosuke Niwa.

Source/WebCore:

Adding a clear:both to the end of content.

I can't handle the case of the cursor appearing above the bottom of
absolutely positioned divs (of the case of floats inside absolutely
positioned divs) because you can't know where the bottom of a div
will end up being rendered (it is affected by things like browser
window width and text size settings). Therefore, the only case I
can handle is the case where there is a floating div in the same
level as the document itself.

Test: editing/pasteboard/copy-paste-inserts-clearing-div.html

• editing/EditingStyle.cpp:

(WebCore::EditingStyle::isFloating):

• editing/EditingStyle.h:
• editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::StyledMarkupAccumulator):
(WebCore::StyledMarkupAccumulator::appendElement):
(WebCore::createMarkupInternal):

LayoutTests:

Makes sure that the clearing div is inserted.

• editing/pasteboard/copy-paste-inserts-clearing-div-expected.txt: Added.
• editing/pasteboard/copy-paste-inserts-clearing-div.html: Added.

6:58 PM Changeset in webkit [164520] by Brent Fulgham

• 2 edits in trunk/Source/WebKit

Unreviewed build fix after r164505

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Update exports

definition for TreeScope::getElementById.

6:45 PM Changeset in webkit [164519] by dino@apple.com

• 3 edits in trunk/Source/WebCore

[iOS Media] Wireless target UI
​https://bugs.webkit.org/show_bug.cgi?id=129189
<rdar://problem/15349928>
<rdar://problem/16100060>

Reviewed by Eric Carlson.

Implement a prototype UI for wireless playback targets. The UI
doesn't currently work, but can be simulated via a class variable
in ControllerIOS.

• Modules/mediacontrols/mediaControlsiOS.css:

(audio::-webkit-media-controls-panel button): Reset the default style of
button elements, to avoid getting a border.
(audio::-webkit-media-controls-wireless-playback-status): Holds the UI showing
the user that the media is playing on another target.
(audio::-webkit-media-controls-wireless-playback-status.hidden):
(audio::-webkit-media-controls-wireless-playback-picker-button): The button to
trigger selection of targets.
(audio::-webkit-media-controls-wireless-playback-picker-button.active):
(audio::-webkit-media-controls-panel): This needs to be position absolute for
the wireless playback status to fill the viewport.

• Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS): Check for targets.
(ControllerIOS.prototype.addVideoListeners):
(ControllerIOS.prototype.removeVideoListeners):
(ControllerIOS.prototype.UIString): New method to return localized strings (with
a FIXME).
(ControllerIOS.prototype.shouldHaveAnyUI): Needs to display if there is a wireless
target.
(ControllerIOS.prototype.currentPlaybackTargetIsWireless):
(ControllerIOS.prototype.updateWirelessPlaybackStatus): Create the status content,
replacing the device name if it is available.
(ControllerIOS.prototype.updateWirelessTargetAvailable):
(ControllerIOS.prototype.createControls):
(ControllerIOS.prototype.configureInlineControls):
(ControllerIOS.prototype.handleWirelessPlaybackChange):
(ControllerIOS.prototype.handleWirelessTargetAvailableChange):
(ControllerIOS.prototype.handleWirelessPickerButtonClicked):

5:58 PM Changeset in webkit [164518] by BJ Burg

• 10 edits
  789 moves
  32 adds
  8 deletes in trunk/LayoutTests

Move unported Web Inspector tests to LayoutTests/inspector-obsolete
​https://bugs.webkit.org/show_bug.cgi?id=129183

Rubber-stamped by Timothy Hatcher.

Move inspector/ to inspector-obsolete/.
Move http/tests/inspector/ to inspector-obsolete/http-tests/.
Fold http/tests/inspector-enabled/ into inspector-obsolete/http-tests/.

I have elided about 1100 lines of rename Changelog spew;
no filenames have been altered in this reorganization.

Remove mentions of obsolete tests from TestExpectations. Remove skips
for inspector-obsolete/ from port-specific expectations, and just
put it in the generic expectations file.

Remove inspector-protocol/heap-profiler tests, as they are obsolete.

• TestExpectations:
  • inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree-expected.txt: Removed.
• inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html: Removed.
• inspector-protocol/heap-profiler/heap-snapshot-with-event-listener-expected.txt: Removed.
• inspector-protocol/heap-profiler/heap-snapshot-with-event-listener.html: Removed.
• inspector-protocol/heap-profiler/resources/heap-snapshot-common.js: Removed.
• inspector-protocol/heap-profiler/resources/page-with-function.html: Removed.
• inspector-protocol/heap-profiler/take-heap-snapshot-expected.txt: Removed.
• inspector-protocol/heap-profiler/take-heap-snapshot.html: Removed.
• platform/efl/TestExpectations:
• platform/gtk/TestExpectations:
• platform/mac-wk2/TestExpectations:
• platform/mac/TestExpectations:
• platform/win-xp/TestExpectations:
• platform/win/TestExpectations:
• platform/wincairo/TestExpectations:
• platform/wk2/TestExpectations:

5:03 PM Changeset in webkit [164517] by weinig@apple.com

• 3 edits in trunk/Source/WebKit2

<rdar://problem/16073882> Please add _AbandonCoalition key to plugin XPC service Info.plist

Anders Carlsson.

• PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist:
• PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist:

4:31 PM Changeset in webkit [164516] by jpfau@apple.com

• 6 edits in trunk

[Mac] Cache callbacks for cache partitioning may be passed null
​https://bugs.webkit.org/show_bug.cgi?id=129175

Reviewed by Brady Eidson.

Source/WebKit2:

• WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp:

(WebKit::WebResourceCacheManager::cfURLCacheHostNamesWithCallback):

WebKitLibraries:

• libWebKitSystemInterfaceLion.a:
• libWebKitSystemInterfaceMavericks.a:
• libWebKitSystemInterfaceMountainLion.a:

4:28 PM Changeset in webkit [164515] by BJ Burg

• 1 edit
  356 deletes in trunk/LayoutTests

Web Inspector: remove old inspector tests that cannot be ported
​https://bugs.webkit.org/show_bug.cgi?id=129168

Reviewed by Timothy Hatcher.

Remove many tests that were specific to the old inspector user interface.
These cannot be ported either because they were specific to the UI, or
they test features that no longer exist in the Web Inspector.

• inspector/audits/audits-panel-functional-expected.txt: Removed.
• inspector/audits/audits-panel-functional.html: Removed.
• inspector/audits/audits-panel-noimages-functional-expected.txt: Removed.
• inspector/audits/audits-panel-noimages-functional.html: Removed.
• inspector/audits/audits-test.js: Removed.
• inspector/audits/resources/audits-script1.js: Removed.
• inspector/audits/resources/audits-script2.js: Removed.
• inspector/audits/resources/audits-style1.css: Removed.
• inspector/console/command-line-api-getEventListeners-expected.txt: Removed.
• inspector/console/command-line-api-getEventListeners.html: Removed.
• inspector/console/console-big-array-expected.txt: Removed.
• inspector/console/console-big-array.html: Removed.
• inspector/console/console-clear-expected.txt: Removed.
• inspector/console/console-clear.html: Removed.
• inspector/console/console-dirxml-expected.txt: Removed.
• inspector/console/console-dirxml.html: Removed.
• inspector/console/console-filter-test-expected.txt: Removed.
• inspector/console/console-filter-test.html: Removed.
• inspector/console/console-format-collections-expected.txt: Removed.
• inspector/console/console-format-collections.html: Removed.
• inspector/console/console-format-expected.txt: Removed.
• inspector/console/console-format-style-expected.txt: Removed.
• inspector/console/console-format-style-whitelist-expected.txt: Removed.
• inspector/console/console-format-style-whitelist.html: Removed.
• inspector/console/console-format-style.html: Removed.
• inspector/console/console-format-table-expected.txt: Removed.
• inspector/console/console-format-table.html: Removed.
• inspector/console/console-format.html: Removed.
• inspector/console/console-trim-long-urls-expected.txt: Removed.
• inspector/console/console-trim-long-urls.html: Removed.
• inspector/cookie-parser-expected.txt: Removed.
• inspector/cookie-parser.html: Removed.
• inspector/cookie-resource-match-expected.txt: Removed.
• inspector/cookie-resource-match.html: Removed.
• inspector/curl-command-expected.txt: Removed.
• inspector/curl-command.html: Removed.
• inspector/database-table-name-excaping-expected.txt: Removed.
• inspector/database-table-name-excaping.html: Removed.
• inspector/datagrid-autosize-expected.txt: Removed.
• inspector/datagrid-autosize.html: Removed.
• inspector/debugger/breakpoint-manager-listeners-count-expected.txt: Removed.
• inspector/debugger/breakpoint-manager-listeners-count.html: Removed.
• inspector/debugger/callstack-placards-discarded-expected.txt: Removed.
• inspector/debugger/callstack-placards-discarded.html: Removed.
• inspector/debugger/content-providers-expected.txt: Removed.
• inspector/debugger/content-providers.html: Removed.
• inspector/debugger/debug-inlined-scripts-expected.txt: Removed.
• inspector/debugger/debug-inlined-scripts.html-disabled: Removed.
• inspector/debugger/debugger-expand-scope-expected.txt: Removed.
• inspector/debugger/debugger-expand-scope.html: Removed.
• inspector/debugger/debugger-proto-property-expected.txt: Removed.
• inspector/debugger/debugger-proto-property.html: Removed.
• inspector/debugger/debugger-script-preprocessor-expected.txt: Removed.
• inspector/debugger/debugger-script-preprocessor.html: Removed.
• inspector/debugger/debugger-step-into-event-listener-expected.txt: Removed.
• inspector/debugger/debugger-step-into-event-listener.html: Removed.
• inspector/debugger/disable-script-expected.txt: Removed.
• inspector/debugger/disable-script.html: Removed.
• inspector/debugger/dom-breakpoints-expected.txt: Removed.
• inspector/debugger/dom-breakpoints.html: Removed.
• inspector/debugger/dynamic-script-tag-expected.txt: Removed.
• inspector/debugger/dynamic-script-tag.html: Removed.
• inspector/debugger/dynamic-scripts-expected.txt: Removed.
• inspector/debugger/dynamic-scripts.html: Removed.
• inspector/debugger/error-in-watch-expressions-expected.txt: Removed.
• inspector/debugger/error-in-watch-expressions.html: Removed.
• inspector/debugger/event-listener-breakpoints-expected.txt: Removed.
• inspector/debugger/event-listener-breakpoints.html: Removed.
• inspector/debugger/file-system-project-mapping-expected.txt: Removed.
• inspector/debugger/file-system-project-mapping.html: Removed.
• inspector/debugger/linkifier-expected.txt: Removed.
• inspector/debugger/linkifier.html: Removed.
• inspector/debugger/live-edit-breakpoints-expected.txt: Removed.
• inspector/debugger/live-edit-breakpoints.html: Removed.
• inspector/debugger/live-edit-expected.txt: Removed.
• inspector/debugger/live-edit.html: Removed.
• inspector/debugger/mutation-observer-suspend-while-paused-expected.txt: Removed.
• inspector/debugger/mutation-observer-suspend-while-paused.html: Removed.
• inspector/debugger/navigator-view-expected.txt: Removed.
• inspector/debugger/navigator-view.html: Removed.
• inspector/debugger/network-uisourcecode-provider-expected.txt: Removed.
• inspector/debugger/network-uisourcecode-provider.html: Removed.
• inspector/debugger/properties-special-expected.txt: Removed.
• inspector/debugger/properties-special.html: Removed.
• inspector/debugger/resource-script-mapping-expected.txt: Removed.
• inspector/debugger/resource-script-mapping.html: Removed.
• inspector/debugger/reveal-execution-line-expected.txt: Removed.
• inspector/debugger/reveal-execution-line.html: Removed.
• inspector/debugger/script-extract-outline-expected.txt: Removed.
• inspector/debugger/script-extract-outline.html: Removed.
• inspector/debugger/script-formatter-breakpoints-expected.txt: Removed.
• inspector/debugger/script-formatter-breakpoints.html: Removed.
• inspector/debugger/script-formatter-console-expected.txt: Removed.
• inspector/debugger/script-formatter-console.html: Removed.
• inspector/debugger/script-snippet-model-expected.txt: Removed.
• inspector/debugger/script-snippet-model.html: Removed.
• inspector/debugger/scripts-panel-expected.txt: Removed.
• inspector/debugger/scripts-panel.html: Removed.
• inspector/debugger/scripts-sorting-expected.txt: Removed.
• inspector/debugger/scripts-sorting.html: Removed.
• inspector/debugger/selected-call-frame-after-formatting-source-expected.txt: Removed.
• inspector/debugger/selected-call-frame-after-formatting-source.html: Removed.
• inspector/debugger/set-breakpoint-expected.txt: Removed.
• inspector/debugger/set-breakpoint.html: Removed.
• inspector/debugger/source-frame-count-expected.txt: Removed.
• inspector/debugger/source-frame-count.html: Removed.
• inspector/debugger/source-frame-expected.txt: Removed.
• inspector/debugger/source-frame.html: Removed.
• inspector/debugger/step-through-event-listeners-expected.txt: Removed.
• inspector/debugger/step-through-event-listeners.html: Removed.
• inspector/debugger/ui-source-code-display-name-expected.txt: Removed.
• inspector/debugger/ui-source-code-display-name.html: Removed.
• inspector/debugger/ui-source-code-expected.txt: Removed.
• inspector/debugger/ui-source-code.html: Removed.
• inspector/debugger/watch-expressions-panel-switch-expected.txt: Removed.
• inspector/debugger/watch-expressions-panel-switch.html: Removed.
• inspector/debugger/watch-expressions-preserve-expansion-expected.txt: Removed.
• inspector/debugger/watch-expressions-preserve-expansion.html: Removed.
• inspector/debugger/xhr-breakpoints-expected.txt: Removed.
• inspector/debugger/xhr-breakpoints.html: Removed.
• inspector/dom-statistics-expected.txt: Removed.
• inspector/dom-statistics.html-disabled: Removed.
• inspector/editor/brace-matcher-expected.txt: Removed.
• inspector/editor/brace-matcher.html: Removed.
• inspector/editor/editor-test.js: Removed.
• inspector/editor/highlighter-basics-expected.txt: Removed.
• inspector/editor/highlighter-basics.html: Removed.
• inspector/editor/highlighter-chunk-limit-expected.txt: Removed.
• inspector/editor/highlighter-chunk-limit.html: Removed.
• inspector/editor/highlighter-long-line-expected.txt: Removed.
• inspector/editor/highlighter-long-line.html: Removed.
• inspector/editor/highlighter-paste-in-comment-expected.txt: Removed.
• inspector/editor/highlighter-paste-in-comment.html: Removed.
• inspector/editor/highlighter-test.js: Removed.
• inspector/editor/indentation-expected.txt: Removed.
• inspector/editor/indentation.html: Removed.
• inspector/editor/text-editor-brace-highlighter-expected.txt: Removed.
• inspector/editor/text-editor-brace-highlighter.html: Removed.
• inspector/editor/text-editor-char-to-coordinates-expected.txt: Removed.
• inspector/editor/text-editor-char-to-coordinates.html: Removed.
• inspector/editor/text-editor-formatter-expected.txt: Removed.
• inspector/editor/text-editor-formatter.html: Removed.
• inspector/editor/text-editor-highlight-api-expected.txt: Removed.
• inspector/editor/text-editor-highlight-api.html: Removed.
• inspector/editor/text-editor-highlight-token-expected.txt: Removed.
• inspector/editor/text-editor-highlight-token.html: Removed.
• inspector/editor/text-editor-home-button-expected.txt: Removed.
• inspector/editor/text-editor-home-button.html: Removed.
• inspector/editor/text-editor-line-breaks-expected.txt: Removed.
• inspector/editor/text-editor-line-breaks.html: Removed.
• inspector/editor/text-editor-long-line-expected.txt: Removed.
• inspector/editor/text-editor-long-line.html: Removed.
• inspector/editor/text-editor-model-expected.txt: Removed.
• inspector/editor/text-editor-model.html: Removed.
• inspector/editor/text-editor-remove-chunks-from-dom-expected.txt: Removed.
• inspector/editor/text-editor-remove-chunks-from-dom.html: Removed.
• inspector/editor/text-editor-selection-expected.txt: Removed.
• inspector/editor/text-editor-selection-to-search-expected.txt: Removed.
• inspector/editor/text-editor-selection-to-search.html: Removed.
• inspector/editor/text-editor-selection.html: Removed.
• inspector/editor/text-editor-show-whitespace-expected.txt: Removed.
• inspector/editor/text-editor-show-whitespace.html: Removed.
• inspector/editor/text-editor-smart-braces-expected.txt: Removed.
• inspector/editor/text-editor-smart-braces.html: Removed.
• inspector/editor/text-editor-token-at-position-expected.txt: Removed.
• inspector/editor/text-editor-token-at-position.html: Removed.
• inspector/editor/text-editor-type-over-decoration-expected.txt: Removed.
• inspector/editor/text-editor-type-over-decoration.html: Removed.
• inspector/editor/text-editor-undo-redo-expected.txt: Removed.
• inspector/editor/text-editor-undo-redo.html: Removed.
• inspector/editor/text-editor-word-jumps-expected.txt: Removed.
• inspector/editor/text-editor-word-jumps.html: Removed.
• inspector/elements/breadcrumb-updates-expected.txt: Removed.
• inspector/elements/breadcrumb-updates.html: Removed.
• inspector/elements/delete-from-document-expected.txt: Removed.
• inspector/elements/delete-from-document.html: Removed.
• inspector/elements/edit-dom-actions-expected.txt: Removed.
• inspector/elements/edit-dom-actions.html: Removed.
• inspector/elements/elements-delete-inline-style-expected.txt: Removed.
• inspector/elements/elements-delete-inline-style.html: Removed.
• inspector/elements/elements-img-tooltip-expected.txt: Removed.
• inspector/elements/elements-img-tooltip.html: Removed.
• inspector/elements/elements-inspect-iframe-from-different-domain-expected.txt: Removed.
• inspector/elements/elements-inspect-iframe-from-different-domain.html: Removed.
• inspector/elements/elements-panel-limited-children-expected.txt: Removed.
• inspector/elements/elements-panel-limited-children.html: Removed.
• inspector/elements/elements-panel-rewrite-href-expected.txt: Removed.
• inspector/elements/elements-panel-rewrite-href.html: Removed.
• inspector/elements/elements-panel-selection-on-refresh-expected.txt: Removed.
• inspector/elements/elements-panel-selection-on-refresh.html: Removed.
• inspector/elements/elements-panel-structure-expected.txt: Removed.
• inspector/elements/elements-panel-structure.html: Removed.
• inspector/elements/elements-panel-xhtml-structure-expected.txt: Removed.
• inspector/elements/elements-panel-xhtml-structure.xhtml-disabled: Removed.
• inspector/elements/event-listener-sidebar-expected.txt: Removed.
• inspector/elements/event-listener-sidebar.html: Removed.
• inspector/elements/event-listeners-about-blank-expected.txt: Removed.
• inspector/elements/event-listeners-about-blank.html: Removed.
• inspector/elements/expand-recursively-expected.txt: Removed.
• inspector/elements/expand-recursively.html: Removed.
• inspector/elements/hide-shortcut-expected.txt: Removed.
• inspector/elements/hide-shortcut.html: Removed.
• inspector/elements/iframe-load-event-expected.txt: Removed.
• inspector/elements/iframe-load-event.html: Removed.
• inspector/elements/insert-node-collapsed-expected.txt: Removed.
• inspector/elements/insert-node-collapsed.html: Removed.
• inspector/elements/insert-node-expected.txt: Removed.
• inspector/elements/insert-node.html: Removed.
• inspector/elements/modify-chardata-expected.txt: Removed.
• inspector/elements/modify-chardata.html: Removed.
• inspector/elements/move-node-expected.txt: Removed.
• inspector/elements/move-node.html: Removed.
• inspector/elements/node-xpath-expected.txt: Removed.
• inspector/elements/node-xpath.xhtml: Removed.
• inspector/elements/remove-node-expected.txt: Removed.
• inspector/elements/remove-node.html: Removed.
• inspector/elements/resources/iframe-load-event-iframe-1.html: Removed.
• inspector/elements/resources/iframe-load-event-iframe-2.html: Removed.
• inspector/elements/resources/iframe-load-event-iframe.js: Removed.
• inspector/elements/resources/user-properties.js: Removed.
• inspector/elements/set-html-via-resource-expected.txt: Removed.
• inspector/elements/shadow-dom-modify-chardata-expected.txt: Removed.
• inspector/elements/shadow-dom-modify-chardata.html: Removed.
• inspector/elements/shadow-root-expected.txt: Removed.
• inspector/elements/shadow-root.html: Removed.
• inspector/elements/undo-dom-edits-2-expected.txt: Removed.
• inspector/elements/undo-dom-edits-2.html: Removed.
• inspector/elements/undo-dom-edits-expected.txt: Removed.
• inspector/elements/undo-dom-edits.html: Removed.
• inspector/elements/update-shadowdom-expected.txt: Removed.
• inspector/elements/update-shadowdom.html: Removed.
• inspector/elements/user-properties-expected.txt: Removed.
• inspector/elements/user-properties.html: Removed.
• inspector/evaluate-in-page-expected.txt: Removed.
• inspector/evaluate-in-page.html: Removed.
• inspector/extensions/extensions-api-expected.txt: Removed.
• inspector/extensions/extensions-api.html: Removed.
• inspector/extensions/extensions-audits-api-expected.txt: Removed.
• inspector/extensions/extensions-audits-api.html: Removed.
• inspector/extensions/extensions-audits-content-script-expected.txt: Removed.
• inspector/extensions/extensions-audits-content-script.html: Removed.
• inspector/extensions/extensions-audits-expected.txt: Removed.
• inspector/extensions/extensions-audits-tests.js: Removed.
• inspector/extensions/extensions-audits.html: Removed.
• inspector/extensions/extensions-console-expected.txt: Removed.
• inspector/extensions/extensions-console.html: Removed.
• inspector/extensions/extensions-eval-content-script-expected.txt: Removed.
• inspector/extensions/extensions-eval-content-script.html: Removed.
• inspector/extensions/extensions-eval-expected.txt: Removed.
• inspector/extensions/extensions-eval.html: Removed.
• inspector/extensions/extensions-events-expected.txt: Removed.
• inspector/extensions/extensions-events.html: Removed.
• inspector/extensions/extensions-network-expected.txt: Removed.
• inspector/extensions/extensions-network.html: Removed.
• inspector/extensions/extensions-panel-expected.txt: Removed.
• inspector/extensions/extensions-panel.html: Removed.
• inspector/extensions/extensions-reload-expected.txt: Removed.
• inspector/extensions/extensions-reload.html: Removed.
• inspector/extensions/extensions-resources-expected.txt: Removed.
• inspector/extensions/extensions-resources.html: Removed.
• inspector/extensions/extensions-sidebar-expected.txt: Removed.
• inspector/extensions/extensions-sidebar.html: Removed.
• inspector/extensions/resources/abe.png: Removed.
• inspector/extensions/resources/audits-style1.css: Removed.
• inspector/extensions/resources/test-script.js: Removed.
• inspector/file-mapping-expected.txt: Removed.
• inspector/file-mapping.html: Removed.
• inspector/file-system-mapping-expected.txt: Removed.
• inspector/file-system-mapping.html: Removed.
• inspector/file-system-project-expected.txt: Removed.
• inspector/file-system-project.html: Removed.
• inspector/filtered-item-selection-dialog-filtering-expected.txt: Removed.
• inspector/filtered-item-selection-dialog-filtering.html: Removed.
• inspector/inspector-backend-commands-generation-expected.txt: Removed.
• inspector/inspector-backend-commands-generation.html: Removed.
• inspector/map-expected.txt: Removed.
• inspector/map.html: Removed.
• inspector/network-status-non-http-expected.txt: Removed.
• inspector/network-status-non-http.html: Removed.
• inspector/profiler/canvas-profiler-test.js: Removed.
• inspector/profiler/canvas2d/canvas-has-uninstrumented-canvases-expected.txt: Removed.
• inspector/profiler/canvas2d/canvas-has-uninstrumented-canvases.html: Removed.
• inspector/profiler/canvas2d/canvas-replay-log-grid-expected.txt: Removed.
• inspector/profiler/canvas2d/canvas-replay-log-grid.html: Removed.
• inspector/profiler/canvas2d/canvas-stack-trace-expected.txt: Removed.
• inspector/profiler/canvas2d/canvas-stack-trace.html: Removed.
• inspector/profiler/canvas2d/canvas2d-api-changes-expected.txt: Removed.
• inspector/profiler/canvas2d/canvas2d-api-changes.html: Removed.
• inspector/profiler/canvas2d/canvas2d-gradient-capturing-expected.txt: Removed.
• inspector/profiler/canvas2d/canvas2d-gradient-capturing.html: Removed.
• inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics-expected.txt: Removed.
• inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html: Removed.
• inspector/profiler/heap-snapshot-comparison-dom-groups-change-expected.txt: Removed.
• inspector/profiler/heap-snapshot-comparison-dom-groups-change.html: Removed.
• inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting-expected.txt: Removed.
• inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html: Removed.
• inspector/profiler/heap-snapshot-comparison-show-all-expected.txt: Removed.
• inspector/profiler/heap-snapshot-comparison-show-all.html: Removed.
• inspector/profiler/heap-snapshot-comparison-show-next-expected.txt: Removed.
• inspector/profiler/heap-snapshot-comparison-show-next.html: Removed.
• inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting-expected.txt: Removed.
• inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html: Removed.
• inspector/profiler/heap-snapshot-comparison-sorting-expected.txt: Removed.
• inspector/profiler/heap-snapshot-comparison-sorting.html: Removed.
• inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting-expected.txt: Removed.
• inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting.html: Removed.
• inspector/profiler/heap-snapshot-containment-show-all-expected.txt: Removed.
• inspector/profiler/heap-snapshot-containment-show-all.html: Removed.
• inspector/profiler/heap-snapshot-containment-show-next-expected.txt: Removed.
• inspector/profiler/heap-snapshot-containment-show-next.html: Removed.
• inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting-expected.txt: Removed.
• inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting.html: Removed.
• inspector/profiler/heap-snapshot-containment-sorting-expected.txt: Removed.
• inspector/profiler/heap-snapshot-containment-sorting.html: Removed.
• inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting-expected.txt: Removed.
• inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting.html: Removed.
• inspector/profiler/heap-snapshot-dominators-show-all-expected.txt: Removed.
• inspector/profiler/heap-snapshot-dominators-show-all.html: Removed.
• inspector/profiler/heap-snapshot-dominators-show-next-actual.txt: Removed.
• inspector/profiler/heap-snapshot-dominators-show-next-expected.txt: Removed.
• inspector/profiler/heap-snapshot-dominators-show-next.html: Removed.
• inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting-expected.txt: Removed.
• inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting.html: Removed.
• inspector/profiler/heap-snapshot-dominators-sorting-expected.txt: Removed.
• inspector/profiler/heap-snapshot-dominators-sorting.html: Removed.
• inspector/profiler/heap-snapshot-expected.txt: Removed.
• inspector/profiler/heap-snapshot-get-profile-crash-expected.txt: Removed.
• inspector/profiler/heap-snapshot-get-profile-crash.html: Removed.
• inspector/profiler/heap-snapshot-inspect-dom-wrapper-expected.txt: Removed.
• inspector/profiler/heap-snapshot-inspect-dom-wrapper.html: Removed.
• inspector/profiler/heap-snapshot-loader-expected.txt: Removed.
• inspector/profiler/heap-snapshot-loader.html: Removed.
• inspector/profiler/heap-snapshot-reveal-in-dominators-view-expected.txt: Removed.
• inspector/profiler/heap-snapshot-reveal-in-dominators-view.html: Removed.
• inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting-expected.txt: Removed.
• inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting.html: Removed.
• inspector/profiler/heap-snapshot-summary-retainers-expected.txt: Removed.
• inspector/profiler/heap-snapshot-summary-retainers.html: Removed.
• inspector/profiler/heap-snapshot-summary-show-all-expected.txt: Removed.
• inspector/profiler/heap-snapshot-summary-show-all.html: Removed.
• inspector/profiler/heap-snapshot-summary-show-next-expected.txt: Removed.
• inspector/profiler/heap-snapshot-summary-show-next.html: Removed.
• inspector/profiler/heap-snapshot-summary-show-ranges-expected.txt: Removed.
• inspector/profiler/heap-snapshot-summary-show-ranges.html: Removed.
• inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting-expected.txt: Removed.
• inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting.html: Removed.
• inspector/profiler/heap-snapshot-summary-sorting-expected.txt: Removed.
• inspector/profiler/heap-snapshot-summary-sorting-fields-expected.txt: Removed.
• inspector/profiler/heap-snapshot-summary-sorting-fields.html: Removed.
• inspector/profiler/heap-snapshot-summary-sorting-instances-expected.txt: Removed.
• inspector/profiler/heap-snapshot-summary-sorting-instances.html: Removed.
• inspector/profiler/heap-snapshot-summary-sorting.html: Removed.
• inspector/profiler/heap-snapshot-test.js: Removed.
• inspector/profiler/heap-snapshot.html: Removed.
• inspector/profiler/resources/image.jpeg: Removed.
• inspector/profiler/selector-profiler-url-expected.txt: Removed.
• inspector/profiler/selector-profiler-url.html: Removed.
• inspector/profiler/webgl/webgl-profiler-api-changes-expected.txt: Removed.
• inspector/profiler/webgl/webgl-profiler-api-changes.html: Removed.
• inspector/profiler/webgl/webgl-profiler-get-error-expected.txt: Removed.
• inspector/profiler/webgl/webgl-profiler-get-error.html: Removed.
• inspector/progress-bar-expected.txt: Removed.
• inspector/progress-bar.html: Removed.
• inspector/snippet-storage-expected.txt: Removed.
• inspector/snippet-storage.html: Removed.
• inspector/styles/commit-selector-expected.txt: Removed.
• inspector/styles/commit-selector.html: Removed.
• inspector/styles/css-live-edit-expected.txt: Removed.
• inspector/styles/css-live-edit.html: Removed.
• inspector/styles/edit-inspector-stylesheet-expected.txt: Removed.
• inspector/styles/edit-inspector-stylesheet.html: Removed.
• inspector/styles/edit-value-with-trimmed-url-expected.txt: Removed.
• inspector/styles/edit-value-with-trimmed-url.html: Removed.
• inspector/styles/force-pseudo-state-expected.txt: Removed.
• inspector/styles/force-pseudo-state.html: Removed.
• inspector/styles/inactive-properties-expected.txt: Removed.
• inspector/styles/inactive-properties.html: Removed.
• inspector/styles/lazy-computed-style-expected.txt: Removed.
• inspector/styles/lazy-computed-style.html: Removed.
• inspector/styles/media-emulation-expected.txt: Removed.
• inspector/styles/media-emulation.html: Removed.
• inspector/styles/media-queries-expected.txt: Removed.
• inspector/styles/media-queries.html: Removed.
• inspector/styles/metrics-box-sizing-expected.txt: Removed.
• inspector/styles/metrics-box-sizing.html: Removed.
• inspector/styles/paste-property-expected.txt: Removed.
• inspector/styles/paste-property.html: Removed.
• inspector/styles/perform-undo-perform-of-mergable-action-expected.txt: Removed.
• inspector/styles/perform-undo-perform-of-mergable-action.html: Removed.
• inspector/styles/protocol-css-regions-commands-expected.txt: Removed.
• inspector/styles/protocol-css-regions-commands.html: Removed.
• inspector/styles/selector-line-expected.txt: Removed.
• inspector/styles/selector-line.html: Removed.
• inspector/styles/show-user-agent-styles-expected.txt: Removed.
• inspector/styles/show-user-agent-styles.html: Removed.
• inspector/styles/styles-add-new-rule-expected.txt: Removed.
• inspector/styles/styles-add-new-rule.html: Removed.
• inspector/styles/styles-cancel-editing-expected.txt: Removed.
• inspector/styles/styles-cancel-editing.html: Removed.
• inspector/styles/styles-change-node-while-editing-expected.txt: Removed.
• inspector/styles/styles-change-node-while-editing.html: Removed.
• inspector/styles/styles-commit-editing-expected.txt: Removed.
• inspector/styles/styles-commit-editing.html: Removed.
• inspector/styles/styles-edit-property-after-invalid-rule-expected.txt: Removed.
• inspector/styles/styles-edit-property-after-invalid-rule.html: Removed.
• inspector/styles/styles-update-from-js-expected.txt: Removed.
• inspector/styles/styles-update-from-js.html: Removed.
• inspector/styles/styles-url-linkify-expected.txt: Removed.
• inspector/styles/styles-url-linkify.html: Removed.
• inspector/styles/svg-style-expected.txt: Removed.
• inspector/styles/svg-style.xhtml: Removed.
• inspector/styles/up-down-numerics-and-colors-expected.txt: Removed.
• inspector/styles/up-down-numerics-and-colors.html: Removed.
• inspector/styles/updates-during-dom-traversal-expected.txt: Removed.
• inspector/styles/updates-during-dom-traversal.html: Removed.
• inspector/styles/updates-throttled-expected.txt: Removed.
• inspector/styles/updates-throttled.html: Removed.
• inspector/styles/url-color-swatch-expected.txt: Removed.
• inspector/styles/url-color-swatch.html: Removed.
• inspector/styles/variables/css-variables-expected.txt: Removed.
• inspector/styles/variables/css-variables.html: Removed.
• inspector/styles/vendor-prefixes-expected.txt: Removed.
• inspector/styles/vendor-prefixes.html: Removed.
• inspector/syntax-highlight-css-expected.txt: Removed.
• inspector/syntax-highlight-css.html: Removed.
• inspector/syntax-highlight-html-expected.txt: Removed.
• inspector/syntax-highlight-html.html: Removed.
• inspector/syntax-highlight-javascript-expected.txt: Removed.
• inspector/syntax-highlight-javascript.html: Removed.
• inspector/syntax-highlight.js: Removed.
• inspector/tabbed-editors-history-expected.txt: Removed.
• inspector/tabbed-editors-history.html: Removed.
• inspector/tabbed-pane-max-tab-width-calculation-expected.txt: Removed.
• inspector/tabbed-pane-max-tab-width-calculation.html: Removed.
• inspector/tabbed-pane-tabs-to-show-expected.txt: Removed.
• inspector/tabbed-pane-tabs-to-show.html: Removed.
• inspector/timeline-dfs-expected.txt: Removed.
• inspector/timeline-dfs.html: Removed.
• inspector/timeline/timeline-coalescing-expected.txt: Removed.
• inspector/timeline/timeline-coalescing.html: Removed.
• inspector/timeline/timeline-enum-stability-expected.txt: Removed.
• inspector/timeline/timeline-enum-stability.html: Removed.
• inspector/uisourcecode-revisions-expected.txt: Removed.
• inspector/uisourcecode-revisions.html: Removed.
• inspector/user-metrics-expected.txt: Removed.
• inspector/user-metrics.html: Removed.
• inspector/utilities-highlight-results-expected.txt: Removed.
• inspector/utilities-highlight-results.html: Removed.
• inspector/version-controller-expected.txt: Removed.
• inspector/version-controller.html: Removed.
• inspector/view-css-expected.txt: Removed.
• inspector/view-css.html: Removed.
• inspector/view-events-expected.txt: Removed.
• inspector/view-events.html: Removed.
• inspector/workspace-mapping-expected.txt: Removed.
• inspector/workspace-mapping.html: Removed.

4:13 PM Changeset in webkit [164514] by jer.noble@apple.com

• 14 edits
  3 copies
  1 move
  1 add
  1 delete in trunk/Source/WebCore

Make a generic CDMPrivateMediaPlayer and move its CDMSession into platform/.
​https://bugs.webkit.org/show_bug.cgi?id=129164

Reviewed by Eric Carlson.

Move the session created by CDMPrivateAVFoundation into platform, and rename
CDMPrivateAVFoundation to CDMPrivateMediaPlayer. Future media engines who want
to support a keysystem from within the media engine can create their own
CDMSession as part of the MediaPlayerPrivate interface.

• Modules/encryptedmedia/CDM.cpp:

(WebCore::installedCDMFactories):
(WebCore::CDM::createSession):

• Modules/encryptedmedia/CDM.h:
• Modules/encryptedmedia/CDMPrivate.h:
• Modules/encryptedmedia/MediaKeySession.cpp:
• Modules/encryptedmedia/MediaKeySession.h:
• Modules/encryptedmedia/CDMPrivateAVFoundation.mm: Removed.
• Modules/encryptedmedia/CDMPrivateMediaPlayer.cpp: Renamed from Source/WebCore/Modules/encryptedmedia/CDMPrivateAVFoundation.cpp.

(WebCore::CDMPrivateMediaPlayer::supportsKeySystem):
(WebCore::CDMPrivateMediaPlayer::supportsKeySystemAndMimeType):
(WebCore::CDMPrivateMediaPlayer::supportsMIMEType):
(WebCore::CDMPrivateMediaPlayer::createSession):

• Modules/encryptedmedia/CDMPrivateMediaPlayer.h: Renamed from Source/WebCore/Modules/encryptedmedia/CDMPrivateAVFoundation.h.

(WebCore::CDMPrivateMediaPlayer::create):
(WebCore::CDMPrivateMediaPlayer::~CDMPrivateMediaPlayer):
(WebCore::CDMPrivateMediaPlayer::cdm):
(WebCore::CDMPrivateMediaPlayer::CDMPrivateMediaPlayer):

• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/CDMSession.h: Extracted from CDMPrivateAVFoundation.h.

(WebCore::CDMSessionClient::~CDMSessionClient):
(WebCore::CDMSession::CDMSession):
(WebCore::CDMSession::~CDMSession):

• platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::createSession):

• platform/graphics/MediaPlayer.h:
• platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::createSession):

• platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.h: Renamed from Source/WebCore/Modules/encryptedmedia/CDMPrivateAVFoundation.h.

(WebCore::CDMSessionAVFoundationObjC::~CDMSessionAVFoundationObjC):

• platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm: Renamed from Source/WebCore/Modules/encryptedmedia/CDMPrivateAVFoundation.mm.

(WebCore::CDMSessionAVFoundationObjC::CDMSessionAVFoundationObjC):
(WebCore::CDMSessionAVFoundationObjC::generateKeyRequest):
(WebCore::CDMSessionAVFoundationObjC::releaseKeys):
(WebCore::CDMSessionAVFoundationObjC::update):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createSession):

• testing/MockCDM.cpp:

(WebCore::MockCDMSession::setClient):
(WebCore::MockCDM::createSession):

• testing/MockCDM.h:

4:12 PM Changeset in webkit [164513] by jer.noble@apple.com

• 13 edits in trunk/Source/WebCore

Add a supportsKeySystem media engine factory parameter.
​https://bugs.webkit.org/show_bug.cgi?id=129161

Reviewed by Eric Carlson.

Add a new parameter to the MediaPlayerFactory to allow registered media
engines to be queried for keySystem support:

• platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayerFactory::MediaPlayerFactory):
(WebCore::MediaPlayer::supportsKeySystem):

• platform/graphics/MediaPlayer.h:

Support this new field in MediaPlayerPrivateAVFoundationObjC:

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::registerMediaEngine):
(WebCore::keySystemIsSupported):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsKeySystem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):

Add an empty field for SupportsKeySystem to the remaining media engines:

• platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::registerMediaEngine):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::registerMediaEngine):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::registerMediaEngine):

• platform/graphics/ios/MediaPlayerPrivateIOS.mm:

(WebCore::MediaPlayerPrivateIOS::registerMediaEngine):

• platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::registerMediaEngine):

• platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::registerMediaEngine):

• platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:

(WebCore::MockMediaPlayerMediaSource::registerMediaEngine):

4:10 PM Changeset in webkit [164512] by commit-queue@webkit.org

• 8 edits
  1 delete in trunk

Web Inspector: Replace binarySearch with lowerBound and upperBound functions
​https://bugs.webkit.org/show_bug.cgi?id=118609

Patch by Chi Wai Lau <​clau@apple.com> on 2014-02-21
Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

This makes insertionIndexForObjectInListSortedByFunction work in O(log(n)) time instead of O(n).

• UserInterface/BinarySearch.js: Removed.
• UserInterface/Main.html:
• UserInterface/Utilities.js:
• WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
• WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:

LayoutTests:

• inspector/utilities-expected.txt:
• inspector/utilities.html:

4:05 PM Changeset in webkit [164511] by dbates@webkit.org

• 1 edit
  1 add in trunk/LayoutTests

[Win] fast/table/col-and-colgroup-offsets.html - offsetHeight differs from Mac results
​https://bugs.webkit.org/show_bug.cgi?id=129179

The test col-and-colgroup-offsets.html is failing on the Apple Win Debug (Tests) bot due
to platform-specific numeric differences in the computed offsetHeight of the table cells.
For now, I am landing Windows-specific expected results as the behavior tested by the test
is correct despite the numerical differences. I'll further investigate the Window-specific
difference in <​https://bugs.webkit.org/show_bug.cgi?id=129179>.

• platform/win/fast/table/col-and-colgroup-offsets-expected.txt: Added.

4:01 PM Changeset in webkit [164510] by BJ Burg

• 11 edits
  1 delete in trunk

Web Inspector: animate breakpoint tree elements when probe samples are received
​https://bugs.webkit.org/show_bug.cgi?id=128334

Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

• UserInterface/BreakpointIcons.css: Removed, rules migrated to the following file.

• UserInterface/BreakpointTreeElement.css: When we want to animateon top of the

static icon, we set the icon image as the icon element's background, and animate
a span on top of the icon element.

(.breakpoint-exception-icon .icon): Moved.
(.breakpoint-generic-line-icon .icon):
(.breakpoint-generic-line-icon .icon > span): Added.
(.data-updated.breakpoint-generic-line-icon .icon > span): Added.

• UserInterface/BreakpointTreeElement.js:

(WebInspector.BreakpointTreeElement): Rewrite event listener add/remove to use EventListenerSet.
(WebInspector.BreakpointTreeElement.prototype.ondetach): Override to unregister the instance's listeners.
(WebInspector.BreakpointTreeElement.prototype._addProbeSet): Added.
(WebInspector.BreakpointTreeElement.prototype._removeProbeSet): Added.
(WebInspector.BreakpointTreeElement.prototype._probeSetAdded): Added.
(WebInspector.BreakpointTreeElement.prototype._probeSetRemoved): Added.
Add/remove listeners when probe sets change.

(WebInspector.BreakpointTreeElement.prototype._samplesCleared): Listeners should follow
the active data table.

(WebInspector.BreakpointTreeElement.prototype._dataUpdated): Run the animation when probe data changes.
(WebInspector.BreakpointTreeElement.prototype._breakpointLocationDidChange): Fix a listener leak.

• UserInterface/Main.html: Remove BreakpointIcons.css.
• UserInterface/NavigationSidebarPanel.css:

(.navigation-sidebar-panel-content-tree-outline .item .icon): give icons
'position: relative' so child spans can be absolutely positioned.

• UserInterface/ProbeDetailsSidebarPanel.js: Get probeSet out of the event data

container. The probe set used to be passed as the data container itself.
(WebInspector.ProbeDetailsSidebarPanel.prototype._probeSetAdded):

• UserInterface/ProbeManager.js:

(WebInspector.ProbeManager.prototype._breakpointActionsChanged.set get knownProbeIdentifiers):
(WebInspector.ProbeManager.prototype._breakpointActionsChanged):
(WebInspector.ProbeManager.prototype.get _probeSetForBreakpoint.set this):

• UserInterface/ProbeSet.js:

(WebInspector.ProbeSet.prototype.clearSamples): include the old data table as the SamplesCleared event data.

• UserInterface/TextResourceContentView.js:

(WebInspector.TextResourceContentView.prototype._probeSetsChanged):

LayoutTests:

Adjust probe manager tracing listeners to access the correct data container property.

• inspector-protocol/resources/probe-helper.js:

(ProbeHelper.installTracingListeners):

3:44 PM Changeset in webkit [164509] by benjamin@webkit.org

• 2 edits in trunk/Source/WebCore

Fix WebCore's internals after r164505

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-02-21

• testing/Internals.cpp:

(WebCore::Internals::findEditingDeleteButton): The call became ambiguous after r164505.

3:38 PM Changeset in webkit [164508] by benjamin@webkit.org

• 3 edits in trunk/Source/WebKit2

[iOS][WK2] Update the visible content rects on zoom
​https://bugs.webkit.org/show_bug.cgi?id=129174

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-02-21
Reviewed by Simon Fraser.

Generalize _updateVisibleContentRects to also act during the zoom and not only at the end.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView scrollViewDidZoom:]):

• UIProcess/API/ios/WKViewIOS.mm:

(-[WKView scrollViewDidZoom:]):

3:35 PM Changeset in webkit [164507] by Joseph Pecoraro

• 25 edits in trunk/Source

Web Inspector: JSContext inspection should report exceptions in the console
​https://bugs.webkit.org/show_bug.cgi?id=128776

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

When JavaScript API functions have an exception, let the inspector
know so it can log the JavaScript and Native backtrace that caused
the exception.

Include some clean up of ConsoleMessage and ScriptCallStack construction.

• API/JSBase.cpp:

(JSEvaluateScript):
(JSCheckScriptSyntax):

• API/JSObjectRef.cpp:

(JSObjectMakeFunction):
(JSObjectMakeArray):
(JSObjectMakeDate):
(JSObjectMakeError):
(JSObjectMakeRegExp):
(JSObjectGetProperty):
(JSObjectSetProperty):
(JSObjectGetPropertyAtIndex):
(JSObjectSetPropertyAtIndex):
(JSObjectDeleteProperty):
(JSObjectCallAsFunction):
(JSObjectCallAsConstructor):

• API/JSValue.mm:

(reportExceptionToInspector):
(valueToArray):
(valueToDictionary):

• API/JSValueRef.cpp:

(JSValueIsEqual):
(JSValueIsInstanceOfConstructor):
(JSValueCreateJSONString):
(JSValueToNumber):
(JSValueToStringCopy):
(JSValueToObject):
When seeing an exception, let the inspector know there was an exception.

• inspector/JSGlobalObjectInspectorController.h:
• inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::appendAPIBacktrace):
(Inspector::JSGlobalObjectInspectorController::reportAPIException):
Log API exceptions by also grabbing the native backtrace.

• inspector/ScriptCallStack.h:
• inspector/ScriptCallStack.cpp:

(Inspector::ScriptCallStack::firstNonNativeCallFrame):
(Inspector::ScriptCallStack::append):
Minor extensions to ScriptCallStack to make it easier to work with.

• inspector/ConsoleMessage.cpp:

(Inspector::ConsoleMessage::ConsoleMessage):
(Inspector::ConsoleMessage::autogenerateMetadata):
Provide better default information if the first call frame was native.

• inspector/ScriptCallStackFactory.cpp:

(Inspector::createScriptCallStack):
(Inspector::extractSourceInformationFromException):
(Inspector::createScriptCallStackFromException):
Perform the handling here of inserting a fake call frame for exceptions
if there was no call stack (e.g. a SyntaxError) or if the first call
frame had no information.

• inspector/ConsoleMessage.cpp:

(Inspector::ConsoleMessage::ConsoleMessage):
(Inspector::ConsoleMessage::autogenerateMetadata):

• inspector/ConsoleMessage.h:
• inspector/ScriptCallStackFactory.cpp:

(Inspector::createScriptCallStack):
(Inspector::createScriptCallStackForConsole):

• inspector/ScriptCallStackFactory.h:
• inspector/agents/InspectorConsoleAgent.cpp:

(Inspector::InspectorConsoleAgent::enable):
(Inspector::InspectorConsoleAgent::addMessageToConsole):
(Inspector::InspectorConsoleAgent::count):

• inspector/agents/JSGlobalObjectDebuggerAgent.cpp:

(Inspector::JSGlobalObjectDebuggerAgent::breakpointActionLog):
ConsoleMessage cleanup.

Source/WebCore:

Include some clean up of ConsoleMessage and ScriptCallStack construction.

Covered by existing tests.

• bindings/js/JSDOMBinding.cpp:

(WebCore::reportException):
Simplify code now that createStackTraceFromException handles it.

• page/ContentSecurityPolicy.cpp:

(WebCore::gatherSecurityPolicyViolationEventData):
(WebCore::ContentSecurityPolicy::reportViolation):
ScriptCallStack can give us the first non-native callframe.

• inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::buildInitiatorObject):

• inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::breakpointActionLog):

• inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createGenericRecord):

• page/Console.cpp:

(WebCore::internalAddMessage):
(WebCore::Console::profile):
(WebCore::Console::profileEnd):
(WebCore::Console::timeEnd):

• page/ContentSecurityPolicy.cpp:

(WebCore::gatherSecurityPolicyViolationEventData):
(WebCore::ContentSecurityPolicy::reportViolation):

• page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessage):

Source/WebInspectorUI:

• UserInterface/ConsoleMessageImpl.js:

(WebInspector.ConsoleMessageImpl.prototype._formatMessage):
(WebInspector.ConsoleMessageImpl.prototype._shouldHideURL):
(WebInspector.ConsoleMessageImpl.prototype._firstNonNativeCallFrame):
(WebInspector.ConsoleMessageImpl.prototype._populateStackTraceTreeElement):
Provide better handling for "[native code]" and legacy "undefined"
call frame URLs. Never linkify these. Also, when showing a link
for an exception, always use the first non-native call frame as
the link location.

3:30 PM Changeset in webkit [164506] by dfarler@apple.com

• 4 edits in trunk/Tools

Make old-run-webkit-tests work with iOS Simulator WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=128622

Reviewed by Simon Fraser.

With this change, we now have layout tests running in both DumpRenderTree
and WebKitTestRunner, with WebKit and WebKit2 used respectively in the iOS
simulator.

• Scripts/old-run-webkit-tests:

In general, make any specific reference to DumpRenderTree
able to refer to WebKitTestRunner wherever possible:

• Rename functions to remove DRT-specific naming.
• Name FIFOs after the tool that is being used.

-- Clean up FIFO creation code
Other necessary changes:

• Allow use of an ios-sim-wk2 platform.
• Clean up platform hierarchy creation where the simulator platform behavior differed.
• WebKitTestRunner/TestController.cpp:

Open FIFOs to get dumps out of the simulator as we do in DumpRenderTree.
(WTR::TestController::TestController):

• WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

Copy the injected bundle into the app bundle.

2:47 PM Changeset in webkit [164505] by benjamin@webkit.org

• 18 edits in trunk/Source

jsDocumentPrototypeFunctionGetElementById should not create an AtomicString for the function argument
​https://bugs.webkit.org/show_bug.cgi?id=128893

Reviewed by Darin Adler.

Source/WebCore:

The declaration of TreeScope::getElementById() was taking an AtomicString as the parameter.
Because of this, all the call sites manipulating String were creating and keeping alive an AtomicString
to make the call.

This had two negative consequences:
-The call sites were ref-ing the ID's atomic string for no reason.
-When there is no ID associated with the input string, an atomic string was created for the sole

purpose of failing the query. Since IDs are stored as AtomicString, if there is not an existing
AtomicString for the input, there is no reason to query anything.

• WebCore.exp.in:
• bindings/js/JSDOMBinding.cpp:

(WebCore::findAtomicString): Update this after the rename.

• bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation):

• bindings/scripts/IDLAttributes.txt:

Now that there are two overloads for TreeScope::getElementById(), the conversion from NSString*
is ambiguous. I add the keyword ObjCExplicitAtomicString to force an explicit conversion to AtomicString.

• dom/Document.idl:
• dom/TreeScope.cpp:

(WebCore::TreeScope::getElementById):
When getting an AtomicString, the case of a empty string is not important, use isNull() instead.
When getting a String, get the corresponding AtomicString if any and use that for getting the element.

• dom/TreeScope.h:
• html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
Solve the ambiguous call.

• svg/SVGAElement.cpp:

(WebCore::SVGAElement::defaultEventHandler):
This is a wonderful candidate for substringSharingImpl. The substring does not survive the call since
the new getElementById never create any AtomicString.

• svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::getElementById):
It looks like there are opportunities to get faster here, Ryosuke should have a look.

• svg/SVGSVGElement.h:
• xml/XMLTreeViewer.cpp:

(WebCore::XMLTreeViewer::transformDocumentToTreeView):
Unrelated cleanup: noStyleMessage was useless.

Source/WebKit2:

• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::pageNumberForElementById): Remove the explicit conversion to use the right overload.

Source/WTF:

AtomicString::find() is a special case optimized for the JavaScript bindings. The method can only
be called under specific conditions.
The method is renamed to findStringWithHash().

The new AtomicString::find is generic and does not require any propery on the input.

• wtf/text/AtomicString.cpp:

(WTF::AtomicString::findStringWithHash):
(WTF::AtomicString::findSlowCase):

• wtf/text/AtomicString.h:

(WTF::AtomicString::find):

2:38 PM Changeset in webkit [164504] by dbates@webkit.org

• 6 edits
  2 adds in trunk

COL element in table has 0 for offsetWidth
​https://bugs.webkit.org/show_bug.cgi?id=15277

Reviewed by David Hyatt.

Source/WebCore:

Implements offset{Left, Top, Width, Height} for table columns and column groups
per section Extensions to the HTMLElement Interface of the CSSOM View spec,
<​http://www.w3.org/TR/cssom-view/#extensions-to-the-htmlelement-interface> (Draft 17 December 2013).

For now, we fail almost all of the offset{Height, Top} sub-tests in the included test
for the separate border model as we need to fix <​https://bugs.webkit.org/show_bug.cgi?id=128988>.

Test: fast/table/col-and-colgroup-offsets.html

• rendering/RenderTable.cpp:

(WebCore::RenderTable::RenderTable): Initialize cached column offset top and offset height.
We cache these offsets since they are the same for all columns in the table.
(WebCore::RenderTable::invalidateCachedColumns): Clear cached effective column index map.
(WebCore::RenderTable::invalidateCachedColumnOffsets): Added.
(WebCore::RenderTable::layout): Invalidate cached column offsets as the location or height
of one or more sections may have changed.
(WebCore::RenderTable::updateColumnCache): Modified to build effective column index map.
(WebCore::RenderTable::effectiveIndexOfColumn): Added.
(WebCore::RenderTable::offsetTopForColumn): Added.
(WebCore::RenderTable::offsetLeftForColumn): Added.
(WebCore::RenderTable::offsetWidthForColumn): Added.
(WebCore::RenderTable::offsetHeightForColumn): Added.

• rendering/RenderTable.h: Make isTableColumnGroupWithColumnChildren() const.
• rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::offsetLeft): Added; turns around and calls RenderTable::offsetLeftForColumn().
(WebCore::RenderTableCol::offsetTop): Added; turns around and calls RenderTable::offsetTopForColumn().
(WebCore::RenderTableCol::offsetWidth): Added; turns around and calls RenderTable::offsetWidthForColumn().
(WebCore::RenderTableCol::offsetHeight): Added; turns around and calls RenderTable::offsetHeightForColumn().

• rendering/RenderTableCol.h:

LayoutTests:

Added test to ensure that offset{Left, Top, Width, Height} return correct results
for table columns and column groups.

For now, we fail almost all of the offset{Height, Top} sub-tests for the separate
border model as we need to fix <​https://bugs.webkit.org/show_bug.cgi?id=128988>.

• fast/table/col-and-colgroup-offsets-expected.txt: Added.
• fast/table/col-and-colgroup-offsets.html: Added.

2:37 PM Changeset in webkit [164503] by oliver@apple.com

• 10 edits in trunk/Source/JavaScriptCore

Add extra space to op_call and related opcodes
​https://bugs.webkit.org/show_bug.cgi?id=129170

Reviewed by Mark Lam.

No change in behaviour, just some refactoring to add an extra
slot to the op_call instructions, and refactoring to make similar
changes easier in future.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printCallOp):

• bytecode/Opcode.h:

(JSC::padOpcodeName):

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitConstruct):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsic):

• jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

• jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCall):

• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:

2:34 PM Changeset in webkit [164502] by enrica@apple.com

• 2 edits in trunk/Source/WebCore

Build fix for iOS after r164498.

Unreviewed.

• platform/graphics/ios/MediaPlayerPrivateIOS.mm:

(WebCore::MediaPlayerPrivateIOS::buffered):

2:33 PM Changeset in webkit [164501] by rniwa@webkit.org

• 3 edits in trunk/Source/WebCore

Disallow the use of -webkit-user-modify on shadow pseudo elements
​https://bugs.webkit.org/show_bug.cgi?id=129144

Reviewed by Geoffrey Garen.

Completely disallow -webkit-user-modify on user agent (builtin) pseudo elements.

We've already had rules to do this in html.css but just hard code it into the engine
in order to eliminate the all uses of -webkit-user-modify in html.css.

• css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):

• css/html.css:

(input::-webkit-textfield-decoration-container):
(input::-webkit-clear-button):
(input[type="search"]::-webkit-search-cancel-button):
(input[type="search"]::-webkit-search-decoration):
(input[type="search"]::-webkit-search-results-decoration):
(input[type="search"]::-webkit-search-results-button):
(input::-webkit-inner-spin-button):
(input::-webkit-input-speech-button):
(input::-webkit-input-placeholder, isindex::-webkit-input-placeholder):
(input[type="file"]::-webkit-file-upload-button):
(input[type="range"]::-webkit-slider-container, input[type="range"]::-webkit-media-slider-container):
(input[type="range"]::-webkit-slider-runnable-track):
(input[type="range"]::-webkit-slider-thumb, input[type="range"]::-webkit-media-slider-thumb):
(input[type="color"]::-webkit-color-swatch-wrapper):
(input[type="color"]::-webkit-color-swatch):
(::-webkit-validation-bubble):
(::-webkit-validation-bubble-message):
(::-webkit-validation-bubble-text-block):
(::-webkit-validation-bubble-heading):
(::-webkit-validation-bubble-arrow):
(::-webkit-validation-bubble-arrow-clipper):
(meter::-webkit-meter-inner-element):
(meter::-webkit-meter-bar):
(meter::-webkit-meter-optimum-value):
(meter::-webkit-meter-suboptimum-value):
(meter::-webkit-meter-even-less-good-value):
(progress::-webkit-progress-inner-element):
(progress::-webkit-progress-bar):
(progress::-webkit-progress-value):

2:27 PM Changeset in webkit [164500] by mark.lam@apple.com

• 3 edits in trunk/Source/JavaScriptCore

gatherFromOtherThread() needs to align the sp before gathering roots.
<​https://webkit.org/b/129169>

Reviewed by Geoffrey Garen.

The GC scans the stacks of other threads using MachineThreads::gatherFromOtherThread().
gatherFromOtherThread() defines the range of the other thread's stack as
being bounded by the other thread's stack pointer and stack base. While
the stack base will always be aligned to sizeof(void*), the stack pointer
may not be. This is because the other thread may have just pushed a 32-bit
value on its stack before we suspended it for scanning.

The fix is to round the stack pointer up to the next aligned address of
sizeof(void*) and start scanning from there. On 64-bit systems, we will
effectively ignore the 32-bit word at the bottom of the stack (top of the
stack for stacks growing up) because it cannot be a 64-bit pointer anyway.
64-bit pointers should always be stored on 64-bit aligned boundaries (our
conservative scan algorithm already depends on this assumption).

On 32-bit systems, the rounding is effectively a no-op.

• heap/ConservativeRoots.cpp:

(JSC::ConservativeRoots::genericAddSpan):

• Hardened somne assertions so that we can catch misalignment issues on release builds as well.
• heap/MachineStackMarker.cpp:

(JSC::MachineThreads::gatherFromOtherThread):

2:26 PM Changeset in webkit [164499] by Joseph Pecoraro

• 2 edits in trunk/Tools

run-webkit-httpd fails to find httpd configuation file.

Reviewed by Ryosuke Niwa.

• Scripts/webkitperl/httpd.pm:

(getHTTPDConfigPathForTestDirectory):

2:04 PM Changeset in webkit [164498] by eric.carlson@apple.com

• 41 edits
  2 adds in trunk

Fix TimeRanges layering violations
​https://bugs.webkit.org/show_bug.cgi?id=128717

Reviewed by NOBODY (OOPS!).

Source/WebCore:

No new tests, no functionality changed.

• CMakeLists.txt:
• GNUmakefile.list.am: Add PlatformTimeRanges.

• Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::buffered): TimeRanges -> PlatformTimeRanges.

• Modules/mediasource/MediaSource.h:

• Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): TimeRanges* -> TimeRanges&.

• WebCore.exp.in: Update for signature changes.

• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj: Add PlatformTimeRanges.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::percentLoaded): Create TimeRanges from PlatformTimeRanges.
(WebCore::HTMLMediaElement::buffered): Ditto.
(WebCore::HTMLMediaElement::seekable): Ditto.

• html/MediaController.cpp:

(MediaController::buffered): TimeRanges* -> TimeRanges&.
(MediaController::seekable): Ditto.
(MediaController::played): Ditto.

Move all of the logic into PlatformTimeRanges. Change API to take TimeRanges& instead of TimeRanges*.

• html/TimeRanges.cpp:

(WebCore::TimeRanges::create): Move to .cpp from .h.
(WebCore::TimeRanges::TimeRanges): Initialize the PlatformTimeRanges member variable.
(WebCore::TimeRanges::start): Passthrough to PlatformTimeRanges.
(WebCore::TimeRanges::end): Ditto.
(WebCore::TimeRanges::invert): Ditto.
(WebCore::TimeRanges::copy): Ditto.
(WebCore::TimeRanges::intersectWith): Ditto.
(WebCore::TimeRanges::unionWith): Ditto.
(WebCore::TimeRanges::length): Ditto.
(WebCore::TimeRanges::add): Ditto.
(WebCore::TimeRanges::contain): Ditto.
(WebCore::TimeRanges::find): Ditto.
(WebCore::TimeRanges::nearest): Ditto.
(WebCore::TimeRanges::totalDuration): Ditto.

• html/TimeRanges.h:

• platform/graphics/MediaPlayer.cpp:

(WebCore::NullMediaPlayerPrivate::buffered): TimeRanges -> PlatformTimeRanges.
(WebCore::MediaPlayer::buffered): Ditto.
(WebCore::MediaPlayer::seekable): Ditto.

• platform/graphics/MediaPlayer.h:
• platform/graphics/MediaPlayerPrivate.h:

• platform/graphics/MediaSourcePrivateClient.h:

• platform/graphics/PlatformTimeRanges.cpp: Added.
• platform/graphics/PlatformTimeRanges.h: Added.

• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::buffered): TimeRanges -> PlatformTimeRanges.
(WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged): Drive-by fix to log

FunctionType notifications. ASSERT when passed an unknown notification.

• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
• platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::platformBufferedTimeRanges): TimeRanges -> PlatformTimeRanges.

• platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::currentTime): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformBufferedTimeRanges): Ditto.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekable): Ditto.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::buffered): Ditto.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::buffered): Ditto.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

• platform/graphics/ios/MediaPlayerPrivateIOS.h:
• platform/graphics/ios/MediaPlayerPrivateIOS.mm:

(WebCore::MediaPlayerPrivateIOS::buffered): Ditto.

• platform/graphics/mac/MediaPlayerPrivateQTKit.h:
• platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::buffered): Ditto.

• platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::buffered): Ditto.

• platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:

• platform/graphics/wince/MediaPlayerPrivateWinCE.h:

• platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:

(WebCore::MockMediaPlayerMediaSource::buffered): Ditto.
(WebCore::MockMediaPlayerMediaSource::advanceCurrentTime): Ditto.

• platform/mock/mediasource/MockMediaPlayerMediaSource.h:

Source/WebKit:

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: TimeRanges::create(void) for Internals.

Tools:

• TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: TimeRanges* -> TimeRanges&.

(TestWebKitAPI::TEST):

1:56 PM Changeset in webkit [164497] by enrica@apple.com

• 18 edits in trunk/Source

Support WebSelections in WK2 on iOS.
​https://bugs.webkit.org/show_bug.cgi?id=127015
<rdar://problem/15211964>

Reviewed by Benjamin Poulain.

../WebCore:

Adding some exports.

• WebCore.exp.in:

../WebKit2:

This is the remaining work on block selections for iOS in WK2.
Once a block selection has been created with a long press gesture
on a selectable area, we can interact with it by touching the four
handles at the top, right, bottom and left side of the selection box.
Expanding or shrinking a block selection requires finding the next/previous
block in the direction of the movement, depending on the handle we
are interacting with.
Every time a new block is selected, we compute the thresholds required
to trigger another block change. The thresholds are sent back to the
UIProcess that will use this information to decide when to activate
the new selection, either bigger or smaller.
This patch also fixes a bug in selectWithTwoTouches where the points
were not mapped to the active frame.

• Shared/ios/WKGestureTypes.h:
• UIProcess/API/ios/PageClientImplIOS.h:
• UIProcess/API/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::didUpdateBlockSelectionWithTouches):

• UIProcess/API/ios/WKContentView.mm:

(-[WKContentView _didUpdateBlockSelectionWithTouches:withFlags:growThreshold:shrinkThreshold:]):

• UIProcess/API/ios/WKContentViewInternal.h:
• UIProcess/API/ios/WKInteractionView.h:
• UIProcess/API/ios/WKInteractionView.mm:

(-[WKInteractionView hasSelectablePositionAtPoint:]):
(-[WKInteractionView clearSelection]):
(toWKHandlePosition):
(-[WKInteractionView _didUpdateBlockSelectionWithTouches:WebKit::withFlags:WebKit::growThreshold:shrinkThreshold:]):
(-[WKInteractionView changeBlockSelectionWithTouchAt:withSelectionTouch:forHandle:]):

• UIProcess/PageClient.h:
• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::updateBlockSelectionWithTouches):
(WebKit::WebPageProxy::didUpdateBlockSelectionWithTouches):

• WebProcess/WebPage/WebPage.cpp:
• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::rangeForWebSelectionAtPosition):
(WebKit::WebPage::rangeForBlockAtPoint):
(WebKit::WebPage::selectWithGesture):
(WebKit::distanceBetweenRectsForPosition):
(WebKit::rectsEssentiallyTheSame):
(WebKit::containsRange):
(WebKit::unionDOMRanges):
(WebKit::computeEdgeCenter):
(WebKit::WebPage::expandedRangeFromHandle):
(WebKit::WebPage::contractedRangeFromHandle):
(WebKit::WebPage::computeExpandAndShrinkThresholdsForHandle):
(WebKit::shouldExpand):
(WebKit::WebPage::changeBlockSelection):
(WebKit::WebPage::updateBlockSelectionWithTouches):
(WebKit::WebPage::clearSelection):
(WebKit::WebPage::selectWithTwoTouches):
(WebKit::WebPage::getPositionInformation):

1:52 PM Changeset in webkit [164496] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Added a GetMyArgumentsLengthSafe and added a speculation check.
​https://bugs.webkit.org/show_bug.cgi?id=129051

Patch by Matthew Mirman <​mmirman@apple.com> on 2014-02-21
Reviewed by Filip Pizlo.

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileGetMyArgumentsLength):

1:29 PM Changeset in webkit [164495] by benjamin@webkit.org

• 9 edits in trunk

'mouseenter' mouse compat event not fired when listeners for touch events
​https://bugs.webkit.org/show_bug.cgi?id=128534

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-02-21
Reviewed by Andreas Kling.

Source/WebCore:

The code dispatching mouseenter and mouseleave events was making the assumption that
only mouse move would cause Document::updateHoverActiveState.

This is not true in some cases. In the case of this bug, the first touch handler sets
the hover state. From there, the code handling enter/leave is in an inconsistent state.

This patch changes the delivery of mouse enter/leave events to be done through the regular
processing of mouse events. The update is done with the mouseover and mouseout events.

• dom/Document.cpp:

(WebCore::Document::prepareMouseEvent):
(WebCore::Document::updateHoverActiveState):

• dom/Document.h:
• page/EventHandler.cpp:

(WebCore::nearestCommonHoverAncestor):
(WebCore::hierarchyHasCapturingEventListeners):
(WebCore::EventHandler::updateMouseEventTargetNode):

LayoutTests:

The existing tests for mouseenter/mouseleave had very poor readability which made them
useless for debugging.
This updates them to log what cause the events, and log all the events everywhere on the page.

• fast/events/mouseenter-mouseleave-capture-expected.txt:
• fast/events/mouseenter-mouseleave-capture.html:
• fast/events/mouseenter-mouseleave-expected.txt:
• fast/events/mouseenter-mouseleave.html:

1:26 PM Changeset in webkit [164494] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

[Win][LLINT] Many JSC stress test failures.
​https://bugs.webkit.org/show_bug.cgi?id=129155

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-02-21
Reviewed by Michael Saboff.

Intel syntax has reversed operand order compared to AT&T syntax, so we need to swap the operand order, in this case on floating point operations.
Also avoid using the reverse opcode (e.g. fdivr), as this puts the result at the wrong position in the floating point stack.
E.g. "divd ft0, ft1" would translate to fdivr st, st(1) (Intel syntax) on Windows, but this puts the result in st, when it should be in st(1).

• offlineasm/x86.rb: Swap operand order on Windows.

12:37 PM Changeset in webkit [164493] by fpizlo@apple.com

• 7 edits in trunk/Source/JavaScriptCore

DFG write barriers should do more speculations
​https://bugs.webkit.org/show_bug.cgi?id=129160

Reviewed by Mark Hahnenberg.

Replace ConditionalStoreBarrier with the cheapest speculation that you could do
instead.

Miniscule speed-up on some things. It's a decent difference in code size, though.

• bytecode/SpeculatedType.cpp:

(JSC::speculationToAbbreviatedString):

• bytecode/SpeculatedType.h:

(JSC::isNotCellSpeculation):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::insertStoreBarrier):
(JSC::DFG::FixupPhase::insertPhantomCheck):

• dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateOther):
(JSC::DFG::Node::shouldSpeculateNotCell):

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compareEqObjectOrOtherToObject):
(JSC::FTL::LowerDFGToLLVM::equalNullOrUndefined):
(JSC::FTL::LowerDFGToLLVM::isNotOther):
(JSC::FTL::LowerDFGToLLVM::isOther):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::speculateObjectOrOther):
(JSC::FTL::LowerDFGToLLVM::speculateOther):
(JSC::FTL::LowerDFGToLLVM::speculateNotCell):

12:37 PM Changeset in webkit [164492] by jhoneycutt@apple.com

• 3 edits
  2 adds in trunk

Crash reloading page with position: fixed content
​https://bugs.webkit.org/show_bug.cgi?id=129119
<rdar://problem/16127090>

Reviewed by Brent Fulgham.

Source/WebCore:

Test: platform/mac-wk2/tiled-drawing/crash-reloading-with-position-fixed-content.html

• page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::removeDestroyedNodes):
Check the node's ID against the latched node's ID before the node is
removed from the tree.

LayoutTests:

• platform/mac-wk2/tiled-drawing/crash-reloading-with-position-fixed-content-expected.txt: Added.
• platform/mac-wk2/tiled-drawing/crash-reloading-with-position-fixed-content.html: Added.

12:18 PM Changeset in webkit [164491] by Joseph Pecoraro

• 25 edits in trunk/Source

Revert r164486, causing a number of test failures.

Source/JavaScriptCore:

Unreviewed rollout.

Source/WebCore:

Unreviewed rollout.

Source/WebInspectorUI:

Unreviewed rollout.

11:51 AM WebInspectorTests created by BJ Burg

explain how inspector protocol tests work

11:48 AM Changeset in webkit [164490] by fpizlo@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Revive SABI (aka shouldAlwaysBeInlined)
​https://bugs.webkit.org/show_bug.cgi?id=129159

Reviewed by Mark Hahnenberg.

This is a small Octane speed-up.

• jit/Repatch.cpp:

(JSC::linkFor): This code was assuming that if it's invoked then the caller is a DFG code block. That's wrong, since it's now used by all of the JITs.

11:38 AM Changeset in webkit [164489] by ddkilzer@apple.com

• 3 edits in trunk/Source/WebCore

StyleResolver::loadPendingImage() should take a reference to StylePendingImage
<​http://webkit.org/b/129021>

Reviewed by Brent Fulgham.

• css/StyleResolver.cpp:

(WebCore::StyleResolver::loadPendingImage): Change pendingImage
parameter to a reference.
(WebCore::StyleResolver::loadPendingShapeImage): Update to use
references.
(WebCore::StyleResolver::loadPendingImages): Ditto.

• css/StyleResolver.h:

(WebCore::StyleResolver::loadPendingImage): Change pendingImage
parameter to a reference.

11:28 AM Changeset in webkit [164488] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Make sure to invoke the completion handler for JS alerts
​https://bugs.webkit.org/show_bug.cgi?id=129158

Reviewed by Alexey Proskuryakov.

• UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

11:17 AM Changeset in webkit [164487] by commit-queue@webkit.org

• 3 edits in trunk/Tools

Web Inspector: update check-webkit-style to flag single quotes in WebInspectorUI projects
​https://bugs.webkit.org/show_bug.cgi?id=128422

Patch by Diego Pino García <Diego Pino Garcia> on 2014-02-21
Reviewed by Joseph Pecoraro.

• Scripts/webkitpy/style/checkers/js.py:

(JSChecker.init):
(JSChecker.check):
(SingleQuoteChecker):
(SingleQuoteChecker.init):
(SingleQuoteChecker.check):

• Scripts/webkitpy/style/checkers/js_unittest.py:

(JSTestCase.assertError.error_for_test):
(JSTestCase.assertError):
(JSTestCase.test_no_error):
(JSTestCase.test_error):

11:14 AM Changeset in webkit [164486] by Joseph Pecoraro

• 25 edits in trunk/Source

Web Inspector: JSContext inspection should report exceptions in the console
​https://bugs.webkit.org/show_bug.cgi?id=128776

Source/JavaScriptCore:

Reviewed by Timothy Hatcher.

When JavaScript API functions have an exception, let the inspector
know so it can log the JavaScript and Native backtrace that caused
the exception.

Include some clean up of ConsoleMessage and ScriptCallStack construction.

• API/JSBase.cpp:

(JSEvaluateScript):
(JSCheckScriptSyntax):

• API/JSObjectRef.cpp:

(JSObjectMakeFunction):
(JSObjectMakeArray):
(JSObjectMakeDate):
(JSObjectMakeError):
(JSObjectMakeRegExp):
(JSObjectGetProperty):
(JSObjectSetProperty):
(JSObjectGetPropertyAtIndex):
(JSObjectSetPropertyAtIndex):
(JSObjectDeleteProperty):
(JSObjectCallAsFunction):
(JSObjectCallAsConstructor):

• API/JSValue.mm:

(reportExceptionToInspector):
(valueToArray):
(valueToDictionary):

• API/JSValueRef.cpp:

(JSValueIsEqual):
(JSValueIsInstanceOfConstructor):
(JSValueCreateJSONString):
(JSValueToNumber):
(JSValueToStringCopy):
(JSValueToObject):
When seeing an exception, let the inspector know there was an exception.

• inspector/JSGlobalObjectInspectorController.h:
• inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::appendAPIBacktrace):
(Inspector::JSGlobalObjectInspectorController::reportAPIException):
Log API exceptions by also grabbing the native backtrace.

• inspector/ScriptCallStack.h:
• inspector/ScriptCallStack.cpp:

(Inspector::ScriptCallStack::firstNonNativeCallFrame):
(Inspector::ScriptCallStack::append):
Minor extensions to ScriptCallStack to make it easier to work with.

• inspector/ConsoleMessage.cpp:

(Inspector::ConsoleMessage::ConsoleMessage):
(Inspector::ConsoleMessage::autogenerateMetadata):
Provide better default information if the first call frame was native.

• inspector/ScriptCallStackFactory.cpp:

(Inspector::createScriptCallStack):
(Inspector::extractSourceInformationFromException):
(Inspector::createScriptCallStackFromException):
Perform the handling here of inserting a fake call frame for exceptions
if there was no call stack (e.g. a SyntaxError) or if the first call
frame had no information.

• inspector/ConsoleMessage.cpp:

(Inspector::ConsoleMessage::ConsoleMessage):
(Inspector::ConsoleMessage::autogenerateMetadata):

• inspector/ConsoleMessage.h:
• inspector/ScriptCallStackFactory.cpp:

(Inspector::createScriptCallStack):
(Inspector::createScriptCallStackForConsole):

• inspector/ScriptCallStackFactory.h:
• inspector/agents/InspectorConsoleAgent.cpp:

(Inspector::InspectorConsoleAgent::enable):
(Inspector::InspectorConsoleAgent::addMessageToConsole):
(Inspector::InspectorConsoleAgent::count):

• inspector/agents/JSGlobalObjectDebuggerAgent.cpp:

(Inspector::JSGlobalObjectDebuggerAgent::breakpointActionLog):
ConsoleMessage cleanup.

Source/WebCore:

Include some clean up of ConsoleMessage and ScriptCallStack construction.

Covered by existing tests.

• bindings/js/JSDOMBinding.cpp:

(WebCore::reportException):
Simplify code now that createStackTraceFromException handles it.

• page/ContentSecurityPolicy.cpp:

(WebCore::gatherSecurityPolicyViolationEventData):
(WebCore::ContentSecurityPolicy::reportViolation):
ScriptCallStack can give us the first non-native callframe.

• inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::buildInitiatorObject):

• inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::breakpointActionLog):

• inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createGenericRecord):

• page/Console.cpp:

(WebCore::internalAddMessage):
(WebCore::Console::profile):
(WebCore::Console::profileEnd):
(WebCore::Console::timeEnd):

• page/ContentSecurityPolicy.cpp:

(WebCore::gatherSecurityPolicyViolationEventData):
(WebCore::ContentSecurityPolicy::reportViolation):

• page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessage):

Source/WebInspectorUI:

Reviewed by Timothy Hatcher.

• UserInterface/ConsoleMessageImpl.js:

(WebInspector.ConsoleMessageImpl.prototype._formatMessage):
(WebInspector.ConsoleMessageImpl.prototype._shouldHideURL):
(WebInspector.ConsoleMessageImpl.prototype._firstNonNativeCallFrame):
(WebInspector.ConsoleMessageImpl.prototype._populateStackTraceTreeElement):
Provide better handling for "[native code]" and legacy "undefined"
call frame URLs. Never linkify these. Also, when showing a link
for an exception, always use the first non-native call frame as
the link location.

11:12 AM WikiStart edited by BJ Burg

add web inspector tests link (diff)

8:51 AM Changeset in webkit [164485] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

Fixing the !ENABLE(SVG_FONTS) build
​https://bugs.webkit.org/show_bug.cgi?id=129150

Patch by Martin Hodovan <​mhodovan@inf.u-szeged.hu> on 2014-02-21
Reviewed by Anders Carlsson.

No new tests required.

• svg/SVGAltGlyphElement.cpp:
• svg/SVGAltGlyphElement.h:
• svg/svgtags.in:

8:45 AM Changeset in webkit [164484] by andersca@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Modernize JSGlobalLock and JSLockHolder
​https://bugs.webkit.org/show_bug.cgi?id=129105

Reviewed by Michael Saboff.

Use std::mutex and std::thread::id where possible.

• runtime/JSLock.cpp:

(JSC::GlobalJSLock::GlobalJSLock):
(JSC::GlobalJSLock::~GlobalJSLock):
(JSC::GlobalJSLock::initialize):
(JSC::JSLock::JSLock):
(JSC::JSLock::lock):
(JSC::JSLock::unlock):
(JSC::JSLock::currentThreadIsHoldingLock):

• runtime/JSLock.h:

7:53 AM Changeset in webkit [164483] by graouts@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: scrollbar may appear when selecting a stop in gradient editor
​https://bugs.webkit.org/show_bug.cgi?id=129149

Reviewed by Timothy Hatcher.

Ensure the angle input is not focused as we update the size of the gradient editor's
popover content since, if it were, it'd make a scrollbar appear as we animate the
popover's frame to fit its new content.

• UserInterface/CodeMirrorGradientEditingController.js:

(WebInspector.CodeMirrorGradientEditingController.prototype.gradientSliderStopWasSelected):

7:29 AM Changeset in webkit [164482] by stavila@adobe.com

• 23 edits in trunk/Source/WebCore

[CSS Regions] Use the named-flow-specific object RenderNamedFlowFragment instead of the generic RenderRegion whenever possible
​https://bugs.webkit.org/show_bug.cgi?id=128599

Reviewed by Andrei Bucur.

Use the named flow specific RenderNamedFlowFragment instead of the generic RenderRegion, whenever possible.
Move named flow specific methods from RenderRegion to RenderNamedFlowFragment.

No new tests required.

• dom/Element.cpp:

(WebCore::Element::renderNamedFlowFragment):
(WebCore::Element::webkitRegionOverset):
(WebCore::Element::webkitGetRegionFlowRanges):

• dom/Element.h:
• inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildArrayForRegions):

• rendering/PaintInfo.h:

(WebCore::PaintInfo::PaintInfo):

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paint):
(WebCore::RenderBlock::paintObject):

• rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::pushContentsClip):
(WebCore::RenderBox::layoutOverflowRectForPropagation):

• rendering/RenderBox.h:
• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintMaskForTextFillBox):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):

• rendering/RenderBoxModelObject.h:
• rendering/RenderInline.h:
• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintLayerByApplyingTransform):
(WebCore::RenderLayer::updatePaintingInfoForFragments):
(WebCore::RenderLayer::paintTransformedLayerIntoFragments):
(WebCore::RenderLayer::paintBackgroundForFragments):
(WebCore::RenderLayer::paintForegroundForFragmentsWithPhase):
(WebCore::RenderLayer::paintOutlineForFragments):
(WebCore::RenderLayer::paintMaskForFragments):
(WebCore::RenderLayer::mapLayerClipRectsToFragmentationLayer):
(WebCore::RenderLayer::calculateClipRects):

• rendering/RenderLayer.h:
• rendering/RenderNamedFlowFragment.cpp:

(WebCore::RenderNamedFlowFragment::getRanges):

• rendering/RenderNamedFlowFragment.h:
• rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::updateWritingMode):
(WebCore::compareRenderNamedFlowFragments):
(WebCore::addFragmentToList):
(WebCore::RenderNamedFlowThread::addFragmentToNamedFlowThread):
(WebCore::RenderNamedFlowThread::addRegionToThread):
(WebCore::RenderNamedFlowThread::removeRegionFromThread):
(WebCore::RenderNamedFlowThread::computeOversetStateForRegions):
(WebCore::RenderNamedFlowThread::checkInvalidRegions):
(WebCore::RenderNamedFlowThread::getRanges):
(WebCore::RenderNamedFlowThread::checkRegionsWithStyling):
(WebCore::RenderNamedFlowThread::clearRenderObjectCustomStyle):

• rendering/RenderNamedFlowThread.h:
• rendering/RenderRegion.cpp:
• rendering/RenderRegion.h:
• rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::shouldPaint):

• rendering/RenderReplica.cpp:

(WebCore::RenderReplica::paint):

• rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::paint):

• rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paintReplaced):

3:26 AM Changeset in webkit [164481] by abucur@adobe.com

• 4 edits
  14 adds in trunk

[CSS Regions] Regions don't paint correctly in new-multicol elements
​https://bugs.webkit.org/show_bug.cgi?id=120711

Reviewed by David Hyatt.

Source/WebCore:

This patch implements basic support for regions inside multi-column elements.
Currently, the painting and hit-testing logic of CSS Regions is not aware of
enclosing multi-column elements. The change is integrated at a layer level by
making use of the pre-computed layer fragments during the painting and hit-testing
phases for regions.

There are limitations such that self painting layers found inside the named flow
thread layer will not be correctly processed because they don't go through the
layer fragment collection step. This is not trivial to implement because the enclosing
pagination layer provided by the multi-column element is not visibile from inside
the named flow thread layer and they reside in different coordinate systems.

A side effect of this patch is the fix of regions incorrect clipping in certain
cases (when both a region and its container clip their overflow, the region's
content is visible outside the container).

Tests: fast/regions/region-clipping.html

fast/regions/regions-in-multicol-bt.html
fast/regions/regions-in-multicol-hover-overflow.html
fast/regions/regions-in-multicol-hover.html
fast/regions/regions-in-multicol-lr.html
fast/regions/regions-in-multicol-rl.html
fast/regions/regions-in-multicol.html

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::paintFlowThreadIfRegionForFragments):
(WebCore::RenderLayer::hitTestFlowThreadIfRegionForFragments):

• rendering/RenderLayer.h:

LayoutTests:

Add tests for regions in multi-column elements and a test that verifies
regions are correctly clipped by their containers when both have hidden
overflow.
For the non horizontal-tb writing modes tests there's no overflow after the
last region because it's not rendered correctly yet in a new column.

• fast/regions/region-clipping-expected.html: Added.
• fast/regions/region-clipping.html: Added.
• fast/regions/regions-in-multicol-bt-expected.html: Added.
• fast/regions/regions-in-multicol-bt.html: Added.
• fast/regions/regions-in-multicol-expected.html: Added.
• fast/regions/regions-in-multicol-hover-expected.html: Added.
• fast/regions/regions-in-multicol-hover-overflow-expected.html: Added.
• fast/regions/regions-in-multicol-hover-overflow.html: Added.
• fast/regions/regions-in-multicol-hover.html: Added.
• fast/regions/regions-in-multicol-lr-expected.html: Added.
• fast/regions/regions-in-multicol-lr.html: Added.
• fast/regions/regions-in-multicol-rl-expected.html: Added.
• fast/regions/regions-in-multicol-rl.html: Added.
• fast/regions/regions-in-multicol.html: Added.

1:19 AM Changeset in webkit [164480] by commit-queue@webkit.org

• 46 edits in trunk

[CSS Blending] Refactor -webkit-blend-mode to -webkit-mix-blend-mode
​https://bugs.webkit.org/show_bug.cgi?id=128805

Patch by Mihai Tica <​mitica@adobe.com> on 2014-02-21
Reviewed by Dean Jackson.

Source/WebCore:

The spec defines the mix-blend-mode property. This means that the
prefixed version should be -webkit-mix-blend-mode, instead of
-webkit-blend-mode.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

• css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):

• css/CSSPropertyNames.in:
• css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):

LayoutTests:

The spec defines the mix-blend-mode property. This means that the
prefixed version should be -webkit-mix-blend-mode, instead of
-webkit-blend-mode. Update all tests accordingly.

• css3/compositing/blend-mode-blended-element-overlapping-composited-sibling-should-have-compositing-layer.html:
• css3/compositing/blend-mode-layers.html:
• css3/compositing/blend-mode-overflow.html:
• css3/compositing/blend-mode-parent-of-composited-blended-has-layer.html:
• css3/compositing/blend-mode-property-expected.txt:
• css3/compositing/blend-mode-property-parsing-expected.txt:
• css3/compositing/blend-mode-property-parsing-invalid-expected.txt:
• css3/compositing/blend-mode-reflection.html:
• css3/compositing/blend-mode-simple-composited.html:
• css3/compositing/blend-mode-simple.html:
• css3/compositing/blend-mode-with-composited-descendant-should-have-layer.html:
• css3/compositing/resources/red-circle.svg:
• css3/compositing/script-tests/blend-mode-property-parsing-invalid.js:

(testInvalidFilterRule):

• css3/compositing/script-tests/blend-mode-property-parsing.js:

(testBlendModeRule):

• css3/compositing/script-tests/blend-mode-property.js:

(testblendmode):

• css3/compositing/svg-blend-color-burn.html:
• css3/compositing/svg-blend-color-dodge.html:
• css3/compositing/svg-blend-color.html:
• css3/compositing/svg-blend-darken.html:
• css3/compositing/svg-blend-difference.html:
• css3/compositing/svg-blend-exclusion.html:
• css3/compositing/svg-blend-hard-light.html:
• css3/compositing/svg-blend-hue.html:
• css3/compositing/svg-blend-layer-blend.html:
• css3/compositing/svg-blend-layer-clip-path.html:
• css3/compositing/svg-blend-layer-filter.html:
• css3/compositing/svg-blend-layer-mask.html:
• css3/compositing/svg-blend-layer-opacity.html:
• css3/compositing/svg-blend-layer-shadow.html:
• css3/compositing/svg-blend-lighten.html:
• css3/compositing/svg-blend-luminosity.html:
• css3/compositing/svg-blend-multiply-alpha.html:
• css3/compositing/svg-blend-multiply.html:
• css3/compositing/svg-blend-normal.html:
• css3/compositing/svg-blend-overlay.html:
• css3/compositing/svg-blend-saturation.html:
• css3/compositing/svg-blend-screen.html:
• css3/compositing/svg-blend-soft-light.html:
• transitions/blendmode-transitions-expected.txt:
• transitions/blendmode-transitions.html:

12:57 AM Changeset in webkit [164479] by rniwa@webkit.org

• 3 edits in trunk/Source/WebCore

Bindings tests rebaseline after r164473.

• bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj mutablePoint]):
(-[DOMTestObj immutablePoint]):
(-[DOMTestObj mutablePointFunction]):
(-[DOMTestObj immutablePointFunction]):

• bindings/scripts/test/ObjC/DOMTestTypedefs.mm:

(-[DOMTestTypedefs immutablePointFunction]):

12:29 AM Changeset in webkit [164478] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebCore

Remove removed symbol from exports list.

• WebCore.exp.in: