⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 23, 2014:

9:29 PM Changeset in webkit [164576] by mitz@apple.com
  • 6 edits in trunk/Source/WebKit2

<rdar://problem/16144508> [iOS] Some definitions of INSTALL_PATH don’t account for INSTALL_PATH_PREFIX
​https://bugs.webkit.org/show_bug.cgi?id=129241

Reviewed by Mark Rowe.

  • Configurations/Base.xcconfig: Define INSTALL_PATH here in terms of INSTALL_PATH_ACTUAL.
  • Configurations/BaseLegacyProcess.xcconfig: Define only INSTALL_PATH_ACTUAL.
  • Configurations/BaseTarget.xcconfig: Simplify the definition of

NORMAL_WEBKIT2_FRAMEWORKS_DIR, now that it shouldn’t include SDKROOT for the Simulator.

  • Configurations/BaseXPCService.xcconfig: Define only INSTALL_PATH_ACTUAL.
  • Configurations/WebKit2.xcconfig: Ditto.
6:24 PM Changeset in webkit [164575] by Brent Fulgham
  • 11 edits in trunk/Source/ThirdParty/ANGLE

[WinCairo] Unreviewed build fix after r164565.

  • ANGLE.vcxproj/libEGL.vcxproj: Use correct path to files.
  • ANGLE.vcxproj/libGLESv2.vcxproj: Ditto.
  • ANGLE.vcxproj/libGLESv2.vcxproj.filters: Ditto.
  • ANGLE.vcxproj/preprocessor.vcxproj: Ditto.
  • ANGLE.vcxproj/translator_common.vcxproj: Ditto.
  • ANGLE.vcxproj/translator_common.vcxproj.filters: Ditto.
  • ANGLE.vcxproj/translator_glsl.vcxproj: Ditto.
  • ANGLE.vcxproj/translator_glsl.vcxproj.filters: Ditto.
  • ANGLE.vcxproj/translator_hlsl.vcxproj: Ditto.
  • ANGLE.vcxproj/translator_hlsl.vcxproj.filters: Ditto.
6:11 PM Changeset in webkit [164574] by dino@apple.com
  • 4 edits in trunk

[WebGL] Allow ANGLE to initialize unused varyings
​https://bugs.webkit.org/show_bug.cgi?id=129240
<rdar://problem/15203342>

Reviewed by Sam Weinig.

Source/WebCore:

Covered by: conformance/glsl/misc/shaders-with-varyings.html

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):
Add SH_INIT_VARYINGS_WITHOUT_STATIC_USE to compiler flags.

LayoutTests:

Unskip conformance/glsl/misc/shaders-with-varyings.html.

  • platform/mac/TestExpectations:
6:01 PM Changeset in webkit [164573] by weinig@apple.com
  • 8 edits in trunk/Source

Update FeatureDefines.xcconfig

Rubber-stamped by Anders Carlsson.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
5:59 PM Changeset in webkit [164572] by dino@apple.com
  • 4 edits in trunk/Source

Sort the project file with sort-Xcode-project-file.

Rubber-stamped by Sam Weinig.

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:
5:54 PM Changeset in webkit [164571] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

[WebKit2] Add C-SPI to enable/disable telephone number detection
​https://bugs.webkit.org/show_bug.cgi?id=129239

Reviewed by Dean Jackson.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetTelephoneNumberParsingEnabled):
(WKPreferencesGetTelephoneNumberParsingEnabled):

  • UIProcess/API/C/WKPreferencesPrivate.h:
5:43 PM Changeset in webkit [164570] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix incorrectly commented out code.

  • platform/TelephoneNumberDetector.h:
5:35 PM Changeset in webkit [164569] by weinig@apple.com
  • 3 edits
    2 adds in trunk/Source/WebCore

Extract platform specific parts of telephone number detection
​https://bugs.webkit.org/show_bug.cgi?id=129238

Reviewed by Dean Jackson.

  • WebCore.xcodeproj/project.pbxproj:

Add new files.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::linkifyPhoneNumbers):
(WebCore::HTMLTreeBuilder::processCharacterBufferForInBody):

  • platform/TelephoneNumberDetector.h: Added.
  • platform/cocoa/TelephoneNumberDetectorCocoa.cpp: Added.

(WebCore::TelephoneNumberDetector::phoneNumbersScanner):
(WebCore::TelephoneNumberDetector::isSupported):
(WebCore::TelephoneNumberDetector::find):
Move code to TelephoneNumberDetector.

5:23 PM Changeset in webkit [164568] by gyuyoung.kim@samsung.com
  • 11 edits in trunk/Source

Change a url parameter type with URL in NavigatorContentUtils
​https://bugs.webkit.org/show_bug.cgi?id=129202

Reviewed by Sam Weinig.

It would be good if we use *URL* for url parameters instead of using String.

Merge from blink. ​https://src.chromium.org/viewvc/blink?view=rev&revision=165458.

Source/WebCore:

  • Modules/navigatorcontentutils/NavigatorContentUtils.cpp:

(WebCore::verifyCustomHandlerURL):
(WebCore::NavigatorContentUtils::registerProtocolHandler):
(WebCore::NavigatorContentUtils::isProtocolHandlerRegistered):
(WebCore::NavigatorContentUtils::unregisterProtocolHandler):

  • Modules/navigatorcontentutils/NavigatorContentUtilsClient.h:

Source/WebKit/efl:

  • WebCoreSupport/NavigatorContentUtilsClientEfl.cpp:

(WebCore::NavigatorContentUtilsClientEfl::registerProtocolHandler):
(WebCore::NavigatorContentUtilsClientEfl::isProtocolHandlerRegistered):
(WebCore::NavigatorContentUtilsClientEfl::unregisterProtocolHandler):

  • WebCoreSupport/NavigatorContentUtilsClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/NavigatorContentUtilsClientGtk.cpp:

(WebKit::NavigatorContentUtilsClient::registerProtocolHandler):

  • WebCoreSupport/NavigatorContentUtilsClientGtk.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebNavigatorContentUtilsClient.h:

(WebKit::WebNavigatorContentUtilsClient::isProtocolHandlerRegistered):
(WebKit::WebNavigatorContentUtilsClient::unregisterProtocolHandler):

4:58 PM Changeset in webkit [164567] by dino@apple.com
  • 1 edit
    197 adds in trunk/Source/ThirdParty/ANGLE

Missing files from previous commit.

4:51 PM Changeset in webkit [164566] by mitz@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Removed -Wno-format-y2k from WARNING_CFLAGS

Rubber-stamped by Sam Weinig.

  • Configurations/Base.xcconfig:
4:43 PM Changeset in webkit [164565] by dino@apple.com
  • 51 edits
    192 deletes in trunk/Source

Update ANGLE to 836bd2176e5607b14846cf1fbc5932dbc91318f4
​https://bugs.webkit.org/show_bug.cgi?id=129232

Reviewed by Brent Fulgham.

Source/ThirdParty/ANGLE:

I also reapplied some of our changes from previous updates, including disabling the clang deprecation
warnings in some files, adding the Apple note about license and defining YY_NO_INPUT.

Huge list of source changes omitted.

Source/WebCore:

New files added, derived sources compiled directly, and generated
steps removed for both EFL and GTK, with much-needed help from
Sergio Correia.

  • CMakeLists.txt:
  • GNUMakefile.am:
3:43 PM Changeset in webkit [164564] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Move RenderMathMLMenclose.h/cpp to the right place in the Xcode project and sort.

Rubber-stamped by Anders Carlsson.

  • WebCore.xcodeproj/project.pbxproj:
3:37 PM Changeset in webkit [164563] by weinig@apple.com
  • 14 edits in trunk/Source

Move telephone number detection behind its own ENABLE macro
​https://bugs.webkit.org/show_bug.cgi?id=129236

Reviewed by Dean Jackson.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Add ENABLE_TELEPHONE_NUMBER_DETECTION.

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Add ENABLE_TELEPHONE_NUMBER_DETECTION.

  • dom/Document.cpp:

(WebCore::Document::Document):

  • dom/Document.h:
  • html/parser/HTMLConstructionSite.h:
  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processCharacterBufferForInBody):

  • html/parser/HTMLTreeBuilder.h:

Use ENABLE(TELEPHONE_NUMBER_DETECTION).

  • platform/mac/SoftLinking.h:

Remove PLATOFORM(IOS) from SOFT_LINK_PRIVATE_FRAMEWORK_OPTIONAL, it is not iOS specific.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Add ENABLE_TELEPHONE_NUMBER_DETECTION.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Add ENABLE_TELEPHONE_NUMBER_DETECTION.

2:44 PM Changeset in webkit [164562] by commit-queue@webkit.org
  • 6 edits in trunk

[GTK] Fix build after Web Inspector code reorganization (r164543)
​https://bugs.webkit.org/show_bug.cgi?id=129231

Patch by Diego Pino García <Diego Pino Garcia> on 2014-02-23
Reviewed by Dean Jackson.

Source/WebInspectorUI:

  • GNUmakefile.am:

Modify paths to Web Inspector code.

Source/WebKit2:

  • PlatformGTK.cmake:

Modify paths to Web Inspector code.

Tools:

  • gtk/generate-inspector-gresource-manifest.py:

Modify paths to Web Inspector code.

1:43 PM Changeset in webkit [164561] by graouts@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: color picker sliders aren't laid out correctly
​https://bugs.webkit.org/show_bug.cgi?id=129234

Reviewed by Joseph Pecoraro.

While it's unclear to me what happened, the "position" property for the color picker sliders
wasn't being computed as expected and used relative positioning. I assume this is related to
r164543 when the order of CSS files changed.

  • UserInterface/Views/Slider.css:

(.slider):

1:41 PM Changeset in webkit [164560] by Martin Robinson
  • 3 edits in trunk/Tools

[GTK] generate-gtkdoc should use argparse
​https://bugs.webkit.org/show_bug.cgi?id=128418

Reviewed by Carlos Garcia Campos.

  • gtk/generate-gtkdoc: Get all arguments from argparse, pass then as parameters

to all functions, and guard the main routine with a name == main check.

1:39 PM Changeset in webkit [164559] by Martin Robinson
  • 2 edits in trunk/Tools

[GTK][CMake] Many plugin tests fail when running WebKit1 layout tests
​https://bugs.webkit.org/show_bug.cgi?id=129191

Reviewed by Anders Carlsson.

  • DumpRenderTree/PlatformGTK.cmake: Properly specify the library build directory

for the GTK+ DumpRenderTree build. We could manually construct this path, but the
name of the directory is "lib" and not "libs". Instead we should use the CMake
variable specifically assigned to this task.

10:48 AM Changeset in webkit [164558] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Refine DFG+FTL inlining and compilation limits
​https://bugs.webkit.org/show_bug.cgi?id=129212

Reviewed by Mark Hahnenberg.

Allow larger functions to be DFG-compiled. Institute a limit on FTL compilation,
and set that limit quite high. Institute a limit on inlining-into. The idea here is
that large functions tend to be autogenerated, and code generators like emscripten
appear to leave few inlining opportunities anyway. Also, we don't want the code
size explosion that we would risk if we allowed compilation of a large function and
then inlined a ton of stuff into it.

This is a 0.5% speed-up on Octane v2 and almost eliminates the typescript
regression. This is a 9% speed-up on AsmBench.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::noticeIncomingCall):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):

  • dfg/DFGCapabilities.h:

(JSC::DFG::isSmallEnoughToInlineCodeInto):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLState.h:

(JSC::FTL::shouldShowDisassembly):

  • runtime/Options.h:
10:06 AM Changeset in webkit [164557] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

[ASan] Add JSC::DFG::prepareOSREntry() to ignore list
<​http://webkit.org/b/129209>

Reviewed by Geoffrey Garen.

  • asan/webkit-asan-ignore.txt: Add DFG::prepareOSREntry() to the

ignore list to make ASan builds usable again. Follow-up
investigation is tracked by <rdar://problem/16055903>.

8:25 AM Changeset in webkit [164556] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

Subpixel rendering: Fix bleed avoidance subpixel calculation.
​https://bugs.webkit.org/show_bug.cgi?id=129225

Reviewed by Simon Fraser.

static_cast<LayoutUnit>(int value) only produces the desired result when subpixel is off.

Currently not testable.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::getBackgroundRoundedRect):
(WebCore::shrinkRectByOneDevicePixel):
(WebCore::RenderBoxModelObject::borderInnerRectAdjustedForBleedAvoidance):
(WebCore::RenderBoxModelObject::backgroundRoundedRectAdjustedForBleedAvoidance):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):

  • rendering/RenderBoxModelObject.h:
8:22 AM Changeset in webkit [164555] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Subpixel rendering: Add devicepixel based computation to BorderEdge class.
​https://bugs.webkit.org/show_bug.cgi?id=129224

Reviewed by Simon Fraser.

To produce correct width (and type) results, BorderEdge class needs to take device pixel ratio into account.

Currently not testable.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::BorderEdge::BorderEdge):
(WebCore::BorderEdge::obscuresBackgroundEdge):
(WebCore::BorderEdge::getDoubleBorderStripeWidths): this does not always produce the same
result as before, but the sum of inner and outer is not different.
(WebCore::BorderEdge::borderWidthInDevicePixel):
(WebCore::RenderBoxModelObject::getBorderEdgeInfo):

6:30 AM UpdatingANGLE edited by dino@apple.com
(diff)

Feb 22, 2014:

9:44 PM Changeset in webkit [164554] by mitz@apple.com
  • 25 edits in trunk/Source

REGRESSION (r164507): Crash beneath JSGlobalObjectInspectorController::reportAPIException at facebook.com, twitter.com, youtube.com
​https://bugs.webkit.org/show_bug.cgi?id=129227

Reviewed by Eric Carlson.

Reverted r164507.

Source/JavaScriptCore:

  • API/JSBase.cpp:

(JSEvaluateScript):
(JSCheckScriptSyntax):

  • API/JSObjectRef.cpp:

(JSObjectMakeFunction):
(JSObjectMakeArray):
(JSObjectMakeDate):
(JSObjectMakeError):
(JSObjectMakeRegExp):
(JSObjectGetProperty):
(JSObjectSetProperty):
(JSObjectGetPropertyAtIndex):
(JSObjectSetPropertyAtIndex):
(JSObjectDeleteProperty):
(JSObjectCallAsFunction):
(JSObjectCallAsConstructor):

  • API/JSValue.mm:

(valueToArray):
(valueToDictionary):

  • API/JSValueRef.cpp:

(JSValueIsEqual):
(JSValueIsInstanceOfConstructor):
(JSValueCreateJSONString):
(JSValueToNumber):
(JSValueToStringCopy):
(JSValueToObject):

  • inspector/ConsoleMessage.cpp:

(Inspector::ConsoleMessage::ConsoleMessage):
(Inspector::ConsoleMessage::autogenerateMetadata):

  • inspector/ConsoleMessage.h:
  • inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):

  • inspector/JSGlobalObjectInspectorController.h:
  • inspector/ScriptCallStack.cpp:
  • inspector/ScriptCallStack.h:
  • inspector/ScriptCallStackFactory.cpp:

(Inspector::createScriptCallStack):
(Inspector::createScriptCallStackForConsole):
(Inspector::createScriptCallStackFromException):

  • inspector/ScriptCallStackFactory.h:
  • inspector/agents/InspectorConsoleAgent.cpp:

(Inspector::InspectorConsoleAgent::enable):
(Inspector::InspectorConsoleAgent::addMessageToConsole):
(Inspector::InspectorConsoleAgent::count):

  • inspector/agents/JSGlobalObjectDebuggerAgent.cpp:

(Inspector::JSGlobalObjectDebuggerAgent::breakpointActionLog):

Source/WebCore:

  • bindings/js/JSDOMBinding.cpp:

(WebCore::reportException):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::buildInitiatorObject):

  • inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::breakpointActionLog):

  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createGenericRecord):

  • page/Console.cpp:

(WebCore::internalAddMessage):
(WebCore::Console::profile):
(WebCore::Console::profileEnd):
(WebCore::Console::timeEnd):

  • page/ContentSecurityPolicy.cpp:

(WebCore::gatherSecurityPolicyViolationEventData):
(WebCore::ContentSecurityPolicy::reportViolation):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessage):

Source/WebInspectorUI:

  • UserInterface/Views/ConsoleMessageImpl.js:

(WebInspector.ConsoleMessageImpl.prototype._formatMessage):
(WebInspector.ConsoleMessageImpl.prototype._populateStackTraceTreeElement):

5:38 PM Changeset in webkit [164553] by commit-queue@webkit.org
  • 13 edits in trunk/Source

Remove some unreachable code (-Wunreachable-code)
​https://bugs.webkit.org/show_bug.cgi?id=129220

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-02-22
Reviewed by Eric Carlson.

Source/JavaScriptCore:

  • API/tests/testapi.c:

(EvilExceptionObject_convertToType):

  • disassembler/udis86/udis86_decode.c:

(decode_operand):

Source/WebCore:

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processCharacterBuffer):
(WebCore::HTMLTreeBuilder::processEndTag):
The only tricky case. Here there was a break inside the
#if, but not the #else, and a break after the #endif.
Remove the break inside the #if, and always use the
break after the #endif.

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::modeToString):

  • bindings/js/JSTrackCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::functionForUniform):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

  • page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::captionDisplayMode):

Source/WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:

(WebKit::toAPI):

3:59 PM Changeset in webkit [164552] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Letterpress effect disabled for synthetic italic
​https://bugs.webkit.org/show_bug.cgi?id=129218
<rdar://problem/15997846>

Reviewed by Dan Bernstein.

There was no need to guard against synthetic italics and letterpress.

  • platform/graphics/mac/FontMac.mm:

(WebCore::Font::drawGlyphs): Remove !useLetterpressEffect from conditional.

3:56 PM Changeset in webkit [164551] by weinig@apple.com
  • 10 edits in trunk/Source

Expose phase and momentum phase as SPI on DOMWheelEvent
<rdar://problem/16110871>
​https://bugs.webkit.org/show_bug.cgi?id=129184

Reviewed by Anders Carlsson.

../WebCore:

  • WebCore.exp.in:

Export core(DOMWheelEvent).

  • WebCore.xcodeproj/project.pbxproj:

Make DOMWheelEventInternal.h available in WebKit.

  • dom/Element.cpp:

(WebCore::Element::dispatchWheelEvent):

  • dom/WheelEvent.cpp:

(WebCore::determineDeltaMode):
(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):
(WebCore::WheelEvent::initWebKitWheelEvent):
Move PlatformWheelEvent -> DOMWheelEvent conversion to DOMWheelEvent.

  • dom/WheelEvent.h:

(WebCore::WheelEvent::create):
(WebCore::WheelEvent::phase):
(WebCore::WheelEvent::momentumPhase):
Store phase and momentumPhase on the WheelEvent.

../WebKit/mac:

  • DOM/WebDOMOperations.mm:

(toNSEventPhase):
(-[DOMWheelEvent _phase]):
(-[DOMWheelEvent _momentumPhase]):

  • DOM/WebDOMOperationsPrivate.h:

Expose _phase and _momentumPhase as SPI.

  • MigrateHeaders.make:

Make DOMWheelEventInternal.h to WebKit.

2:39 PM Changeset in webkit [164550] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

[Cocoa] WKUIDelegate.h is a project header
​https://bugs.webkit.org/show_bug.cgi?id=129215

Reviewed by Anders Carlsson.

  • WebKit2.xcodeproj/project.pbxproj: Make it a public header.
12:03 PM Changeset in webkit [164549] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, ARMv7 build fix.

  • assembler/ARMv7Assembler.h:
11:55 AM Changeset in webkit [164548] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

It should be possible for a LinkBuffer to outlive the MacroAssembler and still be useful
​https://bugs.webkit.org/show_bug.cgi?id=124733

Reviewed by Oliver Hunt.

This also takes the opportunity to de-duplicate some branch compaction code.

  • assembler/ARM64Assembler.h:
  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::buffer):

  • assembler/AssemblerBuffer.h:

(JSC::AssemblerData::AssemblerData):
(JSC::AssemblerBuffer::AssemblerBuffer):
(JSC::AssemblerBuffer::storage):
(JSC::AssemblerBuffer::grow):

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::executableOffsetFor):
(JSC::LinkBuffer::applyOffset):

  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::link):

  • assembler/MacroAssemblerARMv7.h:
10:44 AM Changeset in webkit [164547] by mitz@apple.com
  • 11 edits in trunk/Source/WebKit2

<rdar://problem/12500358> [Cocoa] Development variants of XPC services should not be installed in WebKit2.framework/XPCServices
​https://bugs.webkit.org/show_bug.cgi?id=129197

Reviewed by Sam Weinig.

  • Configurations/BaseXPCService.xcconfig: Made INSTALL_PATH vary based on

WK_XPC_SERVICE_VARIANT. For the Development variant, use an install path outside the
framework. Note that engineering builds using the build action continue to have the
Development variants copied into the framework by a script build phase.

  • Configurations/DatabaseService.Development.xcconfig: Set WK_XPC_SERVICE_VARIANT.
  • Configurations/DatabaseService.xcconfig: Ditto.
  • Configurations/NetworkService.Development.xcconfig: Ditto.
  • Configurations/NetworkService.xcconfig: Ditto.
  • Configurations/PluginService.32.xcconfig: Ditto.
  • Configurations/PluginService.64.xcconfig: Ditto.
  • Configurations/PluginService.Development.xcconfig: Ditto.
  • Configurations/WebContentService.Development.xcconfig: Ditto.
  • Configurations/WebContentService.xcconfig: Ditto.
10:10 AM Changeset in webkit [164546] by ap@apple.com
  • 11 edits in trunk

Rename JWK key_ops values from wrap/unwrap to wrapKey/unwrapKey
​https://bugs.webkit.org/show_bug.cgi?id=129121

Reviewed by Sam Weinig.

Source/WebCore:

  • bindings/js/JSCryptoKeySerializationJWK.cpp:

(WebCore::JSCryptoKeySerializationJWK::reconcileUsages): Updated to newer names.
(WebCore::addUsagesToJSON): Ditto.
(WebCore::JSCryptoKeySerializationJWK::serialize): rsa-oaep-key-manipulation test
started ot fail, because RSA-OAEP with 2048 bit key and sha-1 can only encrypt
214 bytes, and the new longer names made JSON serialization slightly longer.
Compensate by not doing any indentation in JSON.

LayoutTests:

  • crypto/subtle/aes-export-key-expected.txt:
  • crypto/subtle/aes-export-key.html:
  • crypto/subtle/jwk-export-use-values-expected.txt:
  • crypto/subtle/jwk-export-use-values.html:
  • crypto/subtle/jwk-import-use-values-expected.txt:
  • crypto/subtle/jwk-import-use-values.html:
  • crypto/subtle/rsa-oaep-key-manipulation-expected.txt:
  • crypto/subtle/rsa-oaep-key-manipulation.html:
9:50 AM Changeset in webkit [164545] by timothy@apple.com
  • 1 edit in trunk/LayoutTests/http/tests/inspector-protocol/resources/InspectorTest.js

Fix tests.

9:48 AM Changeset in webkit [164544] by timothy@apple.com
  • 2 edits in trunk

Fix production builds and tests.

9:33 AM Changeset in webkit [164543] by timothy@apple.com
  • 5 edits
    416 moves
    5 adds
    7 deletes in trunk/Source/WebInspectorUI

Organize WebInspectorUI/UserInterface into sub-directories.

​https://bugs.webkit.org/show_bug.cgi?id=129194

Rubber-stamped by Joseph Pecoraro.

  • Scripts/copy-user-interface-resources.sh: Fix Image URLs and Protocol paths.
  • UserInterface/Base: Added.
  • UserInterface/Controllers: Added.
  • UserInterface/Images: Added.
  • UserInterface/Main.html: Updated.
  • UserInterface/Models Added.
  • UserInterface/Protocol Added.
  • UserInterface/Views: Added.
9:31 AM Changeset in webkit [164542] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Revert r164434 since it actually broke ASan builds
<​http://webkit.org/b/128871>

  • Configurations/WebKit.xcconfig: This caused -asan-blacklist to

be included twice on every compiler command, which caused clang
to error out.

8:06 AM Changeset in webkit [164541] by timothy@apple.com
  • 16 edits
    13 adds in trunk

Add inspection user interface for IndexedDB.

​https://bugs.webkit.org/show_bug.cgi?id=129162

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js: Updated.
  • UserInterface/ContentView.js:

(WebInspector.ContentView):
(WebInspector.ContentView.isViewable):

  • UserInterface/IndexedDatabase.js: Added.

(WebInspector.IndexedDatabase):
(WebInspector.IndexedDatabase.prototype.get name):
(WebInspector.IndexedDatabase.prototype.get securityOrigin):
(WebInspector.IndexedDatabase.prototype.get host):
(WebInspector.IndexedDatabase.prototype.get version):
(WebInspector.IndexedDatabase.prototype.get objectStores):
(WebInspector.IndexedDatabase.prototype.saveIdentityToCookie):

  • UserInterface/IndexedDatabaseEntryDataGridNode.js: Added.

(WebInspector.IndexedDatabaseEntryDataGridNode):
(WebInspector.IndexedDatabaseEntryDataGridNode.prototype.get entry):
(WebInspector.IndexedDatabaseEntryDataGridNode.prototype.createCellContent):

  • UserInterface/IndexedDatabaseHostTreeElement.js: Added.

(WebInspector.IndexedDatabaseHostTreeElement):
(WebInspector.IndexedDatabaseHostTreeElement.prototype.get name):
(WebInspector.IndexedDatabaseHostTreeElement.prototype.get categoryName):

  • UserInterface/IndexedDatabaseObjectStore.js: Added.

(WebInspector.IndexedDatabaseObjectStore):
(WebInspector.IndexedDatabaseObjectStore.prototype.get name):
(WebInspector.IndexedDatabaseObjectStore.prototype.get keyPath):
(WebInspector.IndexedDatabaseObjectStore.prototype.get autoIncrement):
(WebInspector.IndexedDatabaseObjectStore.prototype.get parentDatabase):
(WebInspector.IndexedDatabaseObjectStore.prototype.get indexes):
(WebInspector.IndexedDatabaseObjectStore.prototype.saveIdentityToCookie):
(WebInspector.IndexedDatabaseObjectStore.prototype.establishRelationship):

  • UserInterface/IndexedDatabaseObjectStoreContentView.css: Added.

(.content-view.indexed-database-object-store > .data-grid):
(.content-view.indexed-database-object-store > .data-grid td .section .header):
(.content-view.indexed-database-object-store > .data-grid td .section .header::before):
(.content-view.indexed-database-object-store > .data-grid td .section .header .title):
(.content-view.indexed-database-object-store > .data-grid table.data):
(.content-view.indexed-database-object-store > .data-grid table.data tr:nth-child(even)):
(.content-view.indexed-database-object-store > .data-grid table.data tr:nth-child(odd)):
(.content-view.indexed-database-object-store > .data-grid table.data tr.filler):
(.content-view.indexed-database-object-store > .data-grid :focus tr.selected td .section .header::before):
(.content-view.indexed-database-object-store > .data-grid :focus tr.selected td .section.expanded .header::before):
(.content-view.indexed-database-object-store > .data-grid :focus tr.selected td .properties-tree li.parent::before):
(.content-view.indexed-database-object-store > .data-grid :focus tr.selected td .properties-tree li.parent.expanded::before):
(.content-view.indexed-database-object-store > .data-grid :focus tr.selected td .properties-tree li *):

  • UserInterface/IndexedDatabaseObjectStoreContentView.js: Added.

(WebInspector.IndexedDatabaseObjectStoreContentView.displayKeyPath):
(WebInspector.IndexedDatabaseObjectStoreContentView):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype.closed):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype.saveToCookie):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype.updateLayout):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype._reset):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype._dataGridScrolled):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype._fetchMoreData.processEntries):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype._fetchMoreData):

  • UserInterface/IndexedDatabaseObjectStoreIndex.js: Added.

(WebInspector.IndexedDatabaseObjectStoreIndex):
(WebInspector.IndexedDatabaseObjectStoreIndex.prototype.get name):
(WebInspector.IndexedDatabaseObjectStoreIndex.prototype.get keyPath):
(WebInspector.IndexedDatabaseObjectStoreIndex.prototype.get unique):
(WebInspector.IndexedDatabaseObjectStoreIndex.prototype.get multiEntry):
(WebInspector.IndexedDatabaseObjectStoreIndex.prototype.get parentObjectStore):
(WebInspector.IndexedDatabaseObjectStoreIndex.prototype.saveIdentityToCookie):
(WebInspector.IndexedDatabaseObjectStoreIndex.prototype.establishRelationship):

  • UserInterface/IndexedDatabaseObjectStoreIndexTreeElement.js: Added.

(WebInspector.IndexedDatabaseObjectStoreIndexTreeElement):
(WebInspector.IndexedDatabaseObjectStoreIndexTreeElement.prototype.get objectStoreIndex):

  • UserInterface/IndexedDatabaseObjectStoreTreeElement.js: Added.

(WebInspector.IndexedDatabaseObjectStoreTreeElement):
(WebInspector.IndexedDatabaseObjectStoreTreeElement.prototype.get objectStore):
(WebInspector.IndexedDatabaseObjectStoreTreeElement.prototype.oncollapse):
(WebInspector.IndexedDatabaseObjectStoreTreeElement.prototype.onpopulate):

  • UserInterface/IndexedDatabaseTreeElement.js: Added.

(WebInspector.IndexedDatabaseTreeElement):
(WebInspector.IndexedDatabaseTreeElement.prototype.get indexedDatabase):
(WebInspector.IndexedDatabaseTreeElement.prototype.oncollapse):
(WebInspector.IndexedDatabaseTreeElement.prototype.onpopulate):

  • UserInterface/Main.html:
  • UserInterface/Main.js:

(WebInspector.sidebarPanelForRepresentedObject):

  • UserInterface/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel):
(WebInspector.ResourceSidebarPanel.prototype._treeElementSelected):
(WebInspector.ResourceSidebarPanel.prototype._indexedDatabaseWasAdded):
(WebInspector.ResourceSidebarPanel.prototype._storageCleared):

  • UserInterface/StorageManager.js:

(WebInspector.StorageManager):
(WebInspector.StorageManager.prototype.initialize):
(WebInspector.StorageManager.prototype.processData):
(WebInspector.StorageManager.prototype.requestIndexedDatabaseData):
(WebInspector.StorageManager.prototype._mainResourceDidChange):
(WebInspector.StorageManager.prototype._addIndexedDBDatabasesIfNeeded.processDatabaseNames):
(WebInspector.StorageManager.prototype._addIndexedDBDatabasesIfNeeded.processDatabase):
(WebInspector.StorageManager.prototype._addIndexedDBDatabasesIfNeeded):
(WebInspector.StorageManager.prototype._addIndexedDBDatabasesIfNeeded.processObjectStore):
(WebInspector.StorageManager.prototype._addIndexedDBDatabasesIfNeeded.processObjectStoreIndex):
(WebInspector.StorageManager.prototype._securityOriginDidChange):

  • UserInterface/URLUtilities.js:

(parseSecurityOrigin):

LayoutTests:

  • http/tests/inspector-protocol/resources/InspectorTest.js:

(InspectorTest.initializeInspectorModels): Add IndexedDatabase models and StorageManager.

  • inspector-protocol/indexeddb/basics-expected.txt: Added.
  • inspector-protocol/indexeddb/basics.html: Added.
7:29 AM Changeset in webkit [164540] by graouts@webkit.org
  • 4 edits
    2 moves
    1 add in trunk/Source/WebInspectorUI

Web Inspector: allow drag-to-adjust on angle input of gradients editor
​https://bugs.webkit.org/show_bug.cgi?id=129095

Reviewed by Timothy Hatcher.

Rename CodeMirrorDragToAlterNumberController to CodeMirrorDragToAdjustNumberController and move
the core logic of a drag-to-adjust behavior out of it to a new generic class DragToAdjustController.
We use this new class from CodeMirrorGradientEditingController to provide drag-to-adjust behavior
in the angle input field of the gradient editor and also as a supporting object for the CodeMirror-
specific class.

  • UserInterface/CodeMirrorDragToAdjustNumberController.css: Renamed from Source/WebInspectorUI/UserInterface/CodeMirrorDragToAlterNumberController.css.

(.CodeMirror.drag-to-adjust .CodeMirror-lines):

  • UserInterface/CodeMirrorDragToAdjustNumberController.js: Added.

Removed the UI logic and use the new DragToAdjustController as a supporting object instead. We implement
the various DragToAdjustController delegate methods in order to customize its behavior to work within the
context of a CodeMirror editor, specifically to prevent activation when the editor is read-only and to
prevent adjustment when the hovered token isn't a number.

(WebInspector.CodeMirrorDragToAdjustNumberController):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.get enabled):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.set enabled):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerActiveStateChanged):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerCanBeActivated):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerCanBeAdjusted):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerWasAdjustedByAmount):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerDidReset):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerCanAdjustObjectAtPoint):

  • UserInterface/CodeMirrorGradientEditingController.css:

(.gradient-editing-controller > label.drag-to-adjust > input):

  • UserInterface/CodeMirrorGradientEditingController.js:

Adopt the new DragToAdjustController to make the angle input field value adjustable by dragging.

(WebInspector.CodeMirrorGradientEditingController.prototype.popoverWillPresent):
(WebInspector.CodeMirrorGradientEditingController.prototype.dragToAdjustControllerWasAdjustedByAmount):
(WebInspector.CodeMirrorGradientEditingController.prototype._handleInputEvent):
(WebInspector.CodeMirrorGradientEditingController.prototype._angleInputValueDidChange):

  • UserInterface/DragToAdjustController.js: Renamed from Source/WebInspectorUI/UserInterface/CodeMirrorDragToAlterNumberController.js.

New DragToAdjustController class exposing only the core UI logic of a drag-to-adjust behavior in the context
of a DOM element, exposing a few delegation methods to customize the controller's behavior:

  • dragToAdjustControllerActiveStateChanged() notifies that the .active property has changed, allowing bringup

and cleanup work to be performed.

  • dragToAdjustControllerDidReset() notifies that the various tracking states of the controller have been reset

allowing other state objects used by clients to be cleared.

  • dragToAdjustControllerCanBeActivated() is used to check whether the controller may enter the active state upon

first hovering the target element.

  • dragToAdjustControllerCanBeAdjusted() is used to check whether adjustment can be performed at the moment when

the user actually is about to engage in a drag-to-adjust interaction.

  • dragToAdjustControllerCanAdjustObjectAtPoint() is used to check whether the object at the provided point (mouse

location) is an adjustable value.

  • dragToAdjustControllerWasAdjustedByAmount() notifies that there is a new amount to add to the current value

following a drag-to-adjust interaction.

(WebInspector.DragToAdjustController):
(WebInspector.DragToAdjustController.prototype.get element):
(WebInspector.DragToAdjustController.prototype.set element):
(WebInspector.DragToAdjustController.prototype.set enabled):
(WebInspector.DragToAdjustController.prototype.get active):
(WebInspector.DragToAdjustController.prototype.set active):
(WebInspector.DragToAdjustController.prototype.reset):
(WebInspector.DragToAdjustController.prototype.handleEvent):
(WebInspector.DragToAdjustController.prototype._setDragging):
(WebInspector.DragToAdjustController.prototype._setTracksMouseClickAndDrag):
(WebInspector.DragToAdjustController.prototype._modifiersDidChange):
(WebInspector.DragToAdjustController.prototype._mouseMoved):
(WebInspector.DragToAdjustController.prototype._mouseWasPressed):
(WebInspector.DragToAdjustController.prototype._mouseWasDragged):
(WebInspector.DragToAdjustController.prototype._mouseWasReleased):

  • UserInterface/Main.html:

Link in new source files.

5:58 AM Changeset in webkit [164539] by krit@webkit.org
  • 1 edit
    114 deletes in trunk/LayoutTests

Replace svg/clip-path pixel tests by reference tests
​https://bugs.webkit.org/show_bug.cgi?id=129177

Patch by Dirk Schulze <​krit@webkit.org> on 2014-02-21
Rubber-stamped by Ryosuke Niwa.

This patch removes all pixel tests.

  • platform/efl/svg/clip-path/clip-in-mask-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-childs-clipped-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-clipped-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-clipped-nonzero-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-css-transform-1-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-css-transform-2-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-objectBoundingBox-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-on-clipped-use-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-on-g-and-child-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-on-g-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-on-svg-and-child-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-on-svg-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-pixelation-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-text-and-stroke-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-text-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-transform-2-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-use-as-child-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-userSpaceOnUse-expected.png: Removed.
  • platform/efl/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png: Removed.
  • platform/efl/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt: Removed.
  • platform/efl/svg/clip-path/deep-nested-clip-in-mask-expected.png: Removed.
  • platform/efl/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png: Removed.
  • platform/efl/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png: Removed.
  • platform/efl/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png: Removed.
  • platform/efl/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-in-mask-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-child-clipped-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-childs-clipped-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-clipped-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-clipped-nonzero-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-css-transform-1-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-css-transform-2-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-evenodd-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-evenodd-nonzero-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-nonzero-evenodd-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-nonzero-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-objectBoundingBox-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-on-clipped-use-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-on-g-and-child-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-on-g-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-on-svg-and-child-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-on-svg-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-pixelation-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-text-and-shape-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-text-and-stroke-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-text-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-transform-2-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-use-as-child-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-userSpaceOnUse-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-with-text-clipped-expected.png: Removed.
  • platform/gtk/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png: Removed.
  • platform/gtk/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt: Removed.
  • platform/gtk/svg/clip-path/deep-nested-clip-in-mask-expected.png: Removed.
  • platform/gtk/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png: Removed.
  • platform/gtk/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png: Removed.
  • platform/gtk/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png: Removed.
  • platform/gtk/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-in-clip-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-in-mask-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-child-clipped-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-childs-clipped-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-clipped-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-clipped-no-content-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-clipped-nonzero-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-css-transform-1-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-css-transform-2-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-evenodd-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-evenodd-nonzero-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-nonzero-evenodd-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-nonzero-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-objectBoundingBox-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-on-clipped-use-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-on-g-and-child-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-on-g-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-on-svg-and-child-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-on-svg-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-pixelation-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-pixelation-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-recursive-call-by-child-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-recursive-call-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-text-and-shape-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-text-and-shape-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-text-and-stroke-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-text-and-stroke-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-text-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-text-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-transform-1-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-transform-2-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-use-as-child-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-use-as-child2-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-use-as-child3-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-use-as-child4-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-use-as-child5-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-userSpaceOnUse-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-with-container-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-with-different-unittypes-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-with-different-unittypes2-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-with-text-clipped-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-with-text-clipped-expected.txt: Removed.
  • platform/mac/svg/clip-path/clipper-placement-issue-expected.png: Removed.
  • platform/mac/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png: Removed.
  • platform/mac/svg/clip-path/deep-nested-clip-in-mask-expected.png: Removed.
  • platform/mac/svg/clip-path/deep-nested-clip-in-mask-expected.txt: Removed.
  • platform/mac/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png: Removed.
  • platform/mac/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Removed.
  • platform/mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png: Removed.
  • platform/mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png: Removed.
  • platform/mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png: Removed.
  • svg/clip-path/clip-in-clip-expected.png: Removed.
  • svg/clip-path/clip-in-clip-expected.txt: Removed.
  • svg/clip-path/clip-in-clip.svg: Removed.
  • svg/clip-path/clip-in-mask-expected.txt: Removed.
  • svg/clip-path/clip-in-mask-objectBoundingBox-expected.txt: Removed.
  • svg/clip-path/clip-in-mask-objectBoundingBox.svg: Removed.
  • svg/clip-path/clip-in-mask-userSpaceOnUse-expected.txt: Removed.
  • svg/clip-path/clip-in-mask-userSpaceOnUse.svg: Removed.
  • svg/clip-path/clip-in-mask.svg: Removed.
  • svg/clip-path/clip-path-child-clipped-expected.txt: Removed.
  • svg/clip-path/clip-path-child-clipped.svg: Removed.
  • svg/clip-path/clip-path-childs-clipped-expected.txt: Removed.
  • svg/clip-path/clip-path-childs-clipped.svg: Removed.
  • svg/clip-path/clip-path-clipped-evenodd-twice-expected.txt: Removed.
  • svg/clip-path/clip-path-clipped-evenodd-twice.svg: Removed.
  • svg/clip-path/clip-path-clipped-expected.txt: Removed.
  • svg/clip-path/clip-path-clipped-no-content-expected.png: Removed.
  • svg/clip-path/clip-path-clipped-no-content-expected.txt: Removed.
  • svg/clip-path/clip-path-clipped-no-content.svg: Removed.
  • svg/clip-path/clip-path-clipped-nonzero-expected.txt: Removed.
  • svg/clip-path/clip-path-clipped-nonzero.svg: Removed.
  • svg/clip-path/clip-path-clipped.svg: Removed.
  • svg/clip-path/clip-path-css-transform-1-expected.txt: Removed.
  • svg/clip-path/clip-path-css-transform-1.svg: Removed.
  • svg/clip-path/clip-path-css-transform-2-expected.txt: Removed.
  • svg/clip-path/clip-path-css-transform-2.svg: Removed.
  • svg/clip-path/clip-path-evenodd-expected.txt: Removed.
  • svg/clip-path/clip-path-evenodd-nonzero-expected.txt: Removed.
  • svg/clip-path/clip-path-evenodd-nonzero.svg: Removed.
  • svg/clip-path/clip-path-evenodd.svg: Removed.
  • svg/clip-path/clip-path-nonzero-evenodd-expected.txt: Removed.
  • svg/clip-path/clip-path-nonzero-evenodd.svg: Removed.
  • svg/clip-path/clip-path-nonzero-expected.txt: Removed.
  • svg/clip-path/clip-path-nonzero.svg: Removed.
  • svg/clip-path/clip-path-objectBoundingBox-expected.txt: Removed.
  • svg/clip-path/clip-path-objectBoundingBox.svg: Removed.
  • svg/clip-path/clip-path-on-clipped-use-expected.txt: Removed.
  • svg/clip-path/clip-path-on-clipped-use.svg: Removed.
  • svg/clip-path/clip-path-on-g-and-child-expected.txt: Removed.
  • svg/clip-path/clip-path-on-g-and-child.svg: Removed.
  • svg/clip-path/clip-path-on-g-expected.txt: Removed.
  • svg/clip-path/clip-path-on-g.svg: Removed.
  • svg/clip-path/clip-path-on-svg-and-child-expected.txt: Removed.
  • svg/clip-path/clip-path-on-svg-and-child.svg: Removed.
  • svg/clip-path/clip-path-on-svg-expected.txt: Removed.
  • svg/clip-path/clip-path-on-svg.svg: Removed.
  • svg/clip-path/clip-path-pixelation-expected.txt: Removed.
  • svg/clip-path/clip-path-pixelation.svg: Removed.
  • svg/clip-path/clip-path-recursive-call-by-child-expected.png: Removed.
  • svg/clip-path/clip-path-recursive-call-by-child-expected.txt: Removed.
  • svg/clip-path/clip-path-recursive-call-by-child.svg: Removed.
  • svg/clip-path/clip-path-recursive-call-expected.png: Removed.
  • svg/clip-path/clip-path-recursive-call-expected.txt: Removed.
  • svg/clip-path/clip-path-recursive-call.svg: Removed.
  • svg/clip-path/clip-path-text-and-shape-expected.txt: Removed.
  • svg/clip-path/clip-path-text-and-shape.svg: Removed.
  • svg/clip-path/clip-path-text-and-stroke-expected.txt: Removed.
  • svg/clip-path/clip-path-text-and-stroke.svg: Removed.
  • svg/clip-path/clip-path-text-expected.txt: Removed.
  • svg/clip-path/clip-path-text.svg: Removed.
  • svg/clip-path/clip-path-transform-1-expected.txt: Removed.
  • svg/clip-path/clip-path-transform-1.svg: Removed.
  • svg/clip-path/clip-path-transform-2-expected.txt: Removed.
  • svg/clip-path/clip-path-transform-2.svg: Removed.
  • svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Removed.
  • svg/clip-path/clip-path-tspan-and-stroke.svg: Removed.
  • svg/clip-path/clip-path-use-as-child-expected.txt: Removed.
  • svg/clip-path/clip-path-use-as-child.svg: Removed.
  • svg/clip-path/clip-path-use-as-child2-expected.png: Removed.
  • svg/clip-path/clip-path-use-as-child2-expected.txt: Removed.
  • svg/clip-path/clip-path-use-as-child2.svg: Removed.
  • svg/clip-path/clip-path-use-as-child3-expected.png: Removed.
  • svg/clip-path/clip-path-use-as-child3-expected.txt: Removed.
  • svg/clip-path/clip-path-use-as-child3.svg: Removed.
  • svg/clip-path/clip-path-use-as-child4-expected.png: Removed.
  • svg/clip-path/clip-path-use-as-child4-expected.txt: Removed.
  • svg/clip-path/clip-path-use-as-child4.svg: Removed.
  • svg/clip-path/clip-path-use-as-child5-expected.png: Removed.
  • svg/clip-path/clip-path-use-as-child5-expected.txt: Removed.
  • svg/clip-path/clip-path-use-as-child5.svg: Removed.
  • svg/clip-path/clip-path-userSpaceOnUse-expected.txt: Removed.
  • svg/clip-path/clip-path-userSpaceOnUse.svg: Removed.
  • svg/clip-path/clip-path-with-container-expected.png: Removed.
  • svg/clip-path/clip-path-with-container-expected.txt: Removed.
  • svg/clip-path/clip-path-with-container.svg: Removed.
  • svg/clip-path/clip-path-with-different-unittypes-expected.png: Removed.
  • svg/clip-path/clip-path-with-different-unittypes-expected.txt: Removed.
  • svg/clip-path/clip-path-with-different-unittypes.svg: Removed.
  • svg/clip-path/clip-path-with-different-unittypes2-expected.png: Removed.
  • svg/clip-path/clip-path-with-different-unittypes2-expected.txt: Removed.
  • svg/clip-path/clip-path-with-different-unittypes2.svg: Removed.
  • svg/clip-path/clip-path-with-invisibile-child-expected.png: Removed.
  • svg/clip-path/clip-path-with-invisibile-child-expected.txt: Removed.
  • svg/clip-path/clip-path-with-invisibile-child.svg: Removed.
  • svg/clip-path/clip-path-with-text-clipped-expected.txt: Removed.
  • svg/clip-path/clip-path-with-text-clipped.svg: Removed.
  • svg/clip-path/clipper-placement-issue-expected.png: Removed.
  • svg/clip-path/clipper-placement-issue-expected.txt: Removed.
  • svg/clip-path/clipper-placement-issue.svg: Removed.
  • svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt: Removed.
  • svg/clip-path/deep-nested-clip-in-mask-different-unitTypes.svg: Removed.
  • svg/clip-path/deep-nested-clip-in-mask-expected.txt: Removed.
  • svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Removed.
  • svg/clip-path/deep-nested-clip-in-mask-panning.svg: Removed.
  • svg/clip-path/deep-nested-clip-in-mask.svg: Removed.
  • svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt: Removed.
  • svg/clip-path/nested-clip-in-mask-image-based-clipping.svg: Removed.
  • svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt: Removed.
  • svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping.svg: Removed.
  • svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt: Removed.
  • svg/clip-path/nested-clip-in-mask-path-based-clipping.svg: Removed.
2:21 AM Changeset in webkit [164538] by fred.wang@free.fr
  • 5 edits in trunk

Only skip stretchy operators when determining the stretch height.
​https://bugs.webkit.org/show_bug.cgi?id=126842

Reviewed by Chris Fleizach.

Source/WebCore:

The MathML code only takes into account non-mo children for the computation of the stretch size. This change includes non-stretchy mo in that computation. A new test is added into mathml/presentation/stretchy-depth-height.html.

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::layout):

LayoutTests:

  • mathml/presentation/stretchy-depth-height.html: Add a test with non-stretchy mo siblings.
2:14 AM Changeset in webkit [164537] by fred.wang@free.fr
  • 4 edits
    2 adds in trunk

Implement asymmetric/symmetric stretching of vertical operators.
​https://bugs.webkit.org/show_bug.cgi?id=124827.

Reviewed by Chris Fleizach.

Source/WebCore:

The MathML code stretches vertical operators asymmetrically by default. This patch takes into account the symmetric attribute or the symmetric property of the operator dictionary to stretch operators symmetrically.

Test: mathml/presentation/stretchy-depth-height-symmetric.html

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::stretchTo):
(WebCore::RenderMathMLOperator::updateFromElement):
(WebCore::RenderMathMLOperator::updateStyle):

LayoutTests:

Add a new test to verify the symmetric property of operators (either implicit by the operator dictionary or explicit via an mo attribute).

  • LayoutTests/platform/mac/mathml/presentation/mo-stretch-expected.txt: rebased.
  • mathml/presentation/stretchy-depth-height-symmetric-expected.txt: Added.
  • mathml/presentation/stretchy-depth-height-symmetric.html: Added.
2:08 AM Changeset in webkit [164536] by fred.wang@free.fr
  • 8 edits
    2 adds in trunk

Bug 119043 - Large stretch size error for MathML operators.
​https://bugs.webkit.org/show_bug.cgi?id=119043

Reviewed by Chris Fleizach.

Source/WebCore:

The MathML code used some arbitrary gOperatorExpansion factor for the
stretch size and 2/3 1/2 constants for the baseline. This change tries
to consider height/depth of siblings of the stretchy operator so that
the stretchy operator now matches its target.

Test: mathml/presentation/stretchy-depth-height.html

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRenderMathMLTable):

  • rendering/mathml/RenderMathMLBlock.h:
  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::RenderMathMLOperator):
(WebCore::RenderMathMLOperator::stretchTo):
(WebCore::RenderMathMLOperator::findAcceptableStretchyCharacter):
(WebCore::RenderMathMLOperator::updateStyle):
(WebCore::RenderMathMLOperator::firstLineBaseline):
(WebCore::RenderMathMLOperator::computeLogicalHeight):

  • rendering/mathml/RenderMathMLOperator.h:
  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::layout):

LayoutTests:

This adds a test to check that the depth/height of stretchy operators match the maximum of their siblings. This also fixes the reference of mo-stretch.html to ignore the stretch error.

  • mathml/presentation/stretchy-depth-height-expected.txt: Added.
  • mathml/presentation/stretchy-depth-height.html: Added.
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
1:57 AM Changeset in webkit [164535] by fred.wang@free.fr
  • 8 edits
    2 deletes in trunk

Unreviewed, rolling out r164534.
​http://trac.webkit.org/changeset/164534
​https://bugs.webkit.org/show_bug.cgi?id=119043

missing tests

Source/WebCore:

  • rendering/RenderObject.h:
  • rendering/mathml/RenderMathMLBlock.h:
  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::RenderMathMLOperator):
(WebCore::RenderMathMLOperator::expandedStretchHeight):
(WebCore::RenderMathMLOperator::stretchToHeight):
(WebCore::RenderMathMLOperator::findAcceptableStretchyCharacter):
(WebCore::RenderMathMLOperator::updateStyle):
(WebCore::RenderMathMLOperator::firstLineBaseline):
(WebCore::RenderMathMLOperator::computeLogicalHeight):

  • rendering/mathml/RenderMathMLOperator.h:
  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::layout):

LayoutTests:

  • mathml/presentation/stretchy-depth-height-expected.txt: Removed.
  • mathml/presentation/stretchy-depth-height.html: Removed.
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
1:50 AM Changeset in webkit [164534] by fred.wang@free.fr
  • 8 edits
    2 adds in trunk

Bug 119043 - Large stretch size error for MathML operators.
​https://bugs.webkit.org/show_bug.cgi?id=119043

Reviewed by Chris Fleizach.

Source/WebCore:

The MathML code used some arbitrary gOperatorExpansion factor for the
stretch size and 2/3 1/2 constants for the baseline. This change tries
to consider height/depth of siblings of the stretchy operator so that
the stretchy operator now matches its target.

Test: mathml/presentation/stretchy-depth-height.html

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRenderMathMLTable):

  • rendering/mathml/RenderMathMLBlock.h:
  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::RenderMathMLOperator):
(WebCore::RenderMathMLOperator::stretchTo):
(WebCore::RenderMathMLOperator::findAcceptableStretchyCharacter):
(WebCore::RenderMathMLOperator::updateStyle):
(WebCore::RenderMathMLOperator::firstLineBaseline):
(WebCore::RenderMathMLOperator::computeLogicalHeight):

  • rendering/mathml/RenderMathMLOperator.h:
  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::layout):

LayoutTests:

This adds a test to check that the depth/height of stretchy operators match the maximum of their siblings. This also fixes the reference of mo-stretch.html to ignore the stretch error.

  • mathml/presentation/stretchy-depth-height-expected.txt: Added.
  • mathml/presentation/stretchy-depth-height.html: Added.
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
1:23 AM Changeset in webkit [164533] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, EFL WK2 gardening. Skip a webgl test because of crashing.
Besides a bug is filed and assigned to those crash tests.

  • platform/efl-wk2/TestExpectations:
Note: See TracTimeline for information about the timeline view.