Context Navigation

Extracted CollectionNamedElementCache, like CollectionIndexCache, out of HTMLCollection.
We can move more named item related functions into this class in the future.

HTMLCollection's member variables m_isNameCacheValid, m_idCache, and m_nameCache were replaced by
a single unique_ptr that holds an instance of CollectionNamedElementCache since this object rarely
exists in most HTMLCollections.

Also removed m_isItemRefElementsCacheValid since it was only used by Microdata API removed in r153772
and renamed a whole bunch of member functions and variables for consistency.

dom/Document.cpp:

(WebCore::Document::collectionCachedIdNameMap):
(WebCore::Document::collectionWillClearIdNameMap):

dom/Document.h:
dom/NodeRareData.h:

(WebCore::NodeListsNodeData::adoptDocument):

html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::namedItemWithIndex):

html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::~HTMLCollection):
(WebCore::HTMLCollection::invalidateCache):
(WebCore::HTMLCollection::invalidateNamedElementCache): Renamed from invalidateIdNameCacheMaps.
(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNamedElementCache): Renamed from updateNameCache.
(WebCore::HTMLCollection::namedItems):

html/HTMLCollection.h:

(WebCore::CollectionNamedElementCache::findElementsWithId): Renamed from HTMLCollection::idCache.
(WebCore::CollectionNamedElementCache::findElementsWithName): Renamed from HTMLCollection::nameCache.
(WebCore::CollectionNamedElementCache::appendIdCache): Moved from HTMLCollection.
(WebCore::CollectionNamedElementCache::appendNameCache): Ditto.
(WebCore::CollectionNamedElementCache::find): Ditto.
(WebCore::CollectionNamedElementCache::append): Ditto.

(WebCore::HTMLCollection::invalidateCache):
(WebCore::HTMLCollection::hasNamedElementCache): Renamed from hasIdNameCache.
(WebCore::HTMLCollection::createNameItemCache): Added.
(WebCore::HTMLCollection::namedItemCaches): Added.

html/HTMLFormControlsCollection.cpp:

(WebCore::HTMLFormControlsCollection::updateNamedElementCache):

html/HTMLFormControlsCollection.h:

7:01 PM Changeset in webkit [164771] by Bem Jones-Bey

2 edits in trunk/Websites/webkit.org

Update style guide to use nullptr instead of 0 for C++ null pointers.
https://bugs.webkit.org/show_bug.cgi?id=129413

Reviewed by Ryosuke Niwa.

coding/coding-style.html:

6:23 PM Changeset in webkit [164770] by rniwa@webkit.org

5 edits
2 adds in trunk

Indenting an indented image element resulted in an extra indentation
https://bugs.webkit.org/show_bug.cgi?id=129201

Reviewed by Enrica Casucci.

Source/WebCore:

The bug was caused by endOfParagraph returning a position at the beginning of a block when the position
passed into the function was at the beginning of the block. Consider the following DOM:
<blockquote><img></blockquote>

When endOfParagraph is called on (blockquote, 0), the condition r->isBR()

isBlock(n) in endOfParagraph

matches immediately on startNode and it returns (blockquote, 0) again.

This resulted in moveParagraphWithClones invoked by indentIntoBlockquote to erroneously clone the inner
blockquote. Worked around this bug in ApplyBlockElementCommand::formatSelection by checking this specific
condition and moving the position to the end of the block. Unfortunately, a lot of existing code depends
on the current behavior of endOfParagraph so fixing the function itself was not possible.

There was another bug in indentIntoBlockquote to incorrectly insert a new blockquote into the existing
blockquote due to the code introduced in r99594 to avoid inserting before the root editable element.
Since this happens only if outerBlock is the root editable element, which is nodeToSplitTo or an ancestor
of nodeToSplitTo, explicitly look for this condition.

Test: editing/execCommand/indent-img-twice.html

editing/ApplyBlockElementCommand.cpp:

(WebCore::ApplyBlockElementCommand::formatSelection):
(WebCore::isNewLineAtPosition):

editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::indentIntoBlockquote):

editing/VisibleUnits.cpp:

(WebCore::endOfParagraph): Added a FIXME.

LayoutTests:

Added a regression test.

editing/execCommand/indent-img-twice-expected.txt: Added.
editing/execCommand/indent-img-twice.html: Added.

6:16 PM Changeset in webkit [164769] by Simon Fraser

2 edits in trunk/Source/WebCore

Fix two assertions/crashes in compositing code
https://bugs.webkit.org/show_bug.cgi?id=129414

Reviewed by Dean Jackson.

Fix two issues introduced in r164759.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::removeFromScrollCoordinatedLayers): Don't call
ourselves recursively!
(WebCore::RenderLayerCompositor::detachScrollCoordinatedLayer): We call this
function unconditionally on layer teardown, so this assertion is bogus.

6:08 PM Changeset in webkit [164768] by andersca@apple.com

4 edits in trunk/Source/WebKit2

VisitedLinkProvider should know which pages it belongs to
https://bugs.webkit.org/show_bug.cgi?id=129410

Reviewed by Dan Bernstein.

UIProcess/VisitedLinkProvider.cpp:

(WebKit::VisitedLinkProvider::~VisitedLinkProvider):
(WebKit::VisitedLinkProvider::addPage):
(WebKit::VisitedLinkProvider::removePage):

UIProcess/VisitedLinkProvider.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):

5:57 PM Changeset in webkit [164767] by Simon Fraser

2 edits in trunk/Source/WebCore

Fix the build with some compiler configurations.

platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):

5:53 PM Changeset in webkit [164766] by mhahnenberg@apple.com

2 edits in trunk/Source/JavaScriptCore

EFL build fix

dfg/DFGSpeculativeJIT32_64.cpp: Remove unused variables.

(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):

5:46 PM Changeset in webkit [164765] by enrica@apple.com

2 edits in trunk/Source/WebKit2

Build fix.

Unexpected line break.

Configurations/WebKit2.xcconfig:

5:27 PM Changeset in webkit [164764] by mhahnenberg@apple.com

105 edits
3 adds in trunk/Source/JavaScriptCore

Make JSCells have 32-bit Structure pointers
https://bugs.webkit.org/show_bug.cgi?id=123195

Reviewed by Filip Pizlo.

This patch changes JSCells such that they no longer have a full 64-bit Structure
pointer in their header. Instead they now have a 32-bit index into
a per-VM table of Structure pointers. 32-bit platforms still use normal Structure
pointers.

This change frees up an additional 32 bits of information in our object headers.
We then use this extra space to store the indexing type of the object, the JSType
of the object, some various type flags, and garbage collection data (e.g. mark bit).
Because this inline type information is now faster to read, it pays for the slowdown
incurred by having to perform an extra indirection through the StructureIDTable.

This patch also threads a reference to the current VM through more of the C++ runtime
to offset the cost of having to look up the VM to get the actual Structure pointer.

API/JSContext.mm:

(-[JSContext setException:]):
(-[JSContext wrapperForObjCObject:]):
(-[JSContext wrapperForJSObject:]):

API/JSContextRef.cpp:

(JSContextGroupRelease):
(JSGlobalContextRelease):

API/JSObjectRef.cpp:

(JSObjectIsFunction):
(JSObjectCopyPropertyNames):

API/JSValue.mm:

(containerValueToObject):

API/JSWrapperMap.mm:

(tryUnwrapObjcObject):

JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:
assembler/AbstractMacroAssembler.h:
assembler/MacroAssembler.h:

(JSC::MacroAssembler::patchableBranch32WithPatch):
(JSC::MacroAssembler::patchableBranch32):

assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::branchPtrWithPatch):
(JSC::MacroAssemblerARM64::patchableBranch32WithPatch):
(JSC::MacroAssemblerARM64::canJumpReplacePatchableBranch32WithPatch):
(JSC::MacroAssemblerARM64::startOfPatchableBranch32WithPatchOnAddress):
(JSC::MacroAssemblerARM64::revertJumpReplacementToPatchableBranch32WithPatch):

assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::store8):
(JSC::MacroAssemblerARMv7::branch32WithPatch):
(JSC::MacroAssemblerARMv7::patchableBranch32WithPatch):
(JSC::MacroAssemblerARMv7::canJumpReplacePatchableBranch32WithPatch):
(JSC::MacroAssemblerARMv7::startOfPatchableBranch32WithPatchOnAddress):
(JSC::MacroAssemblerARMv7::revertJumpReplacementToPatchableBranch32WithPatch):

assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::branch32WithPatch):
(JSC::MacroAssemblerX86::canJumpReplacePatchableBranch32WithPatch):
(JSC::MacroAssemblerX86::startOfPatchableBranch32WithPatchOnAddress):
(JSC::MacroAssemblerX86::revertJumpReplacementToPatchableBranch32WithPatch):

assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::store32):
(JSC::MacroAssemblerX86_64::moveWithPatch):
(JSC::MacroAssemblerX86_64::branch32WithPatch):
(JSC::MacroAssemblerX86_64::canJumpReplacePatchableBranch32WithPatch):
(JSC::MacroAssemblerX86_64::startOfBranch32WithPatchOnRegister):
(JSC::MacroAssemblerX86_64::startOfPatchableBranch32WithPatchOnAddress):
(JSC::MacroAssemblerX86_64::revertJumpReplacementToPatchableBranch32WithPatch):

assembler/RepatchBuffer.h:

(JSC::RepatchBuffer::startOfPatchableBranch32WithPatchOnAddress):
(JSC::RepatchBuffer::revertJumpReplacementToPatchableBranch32WithPatch):

assembler/X86Assembler.h:

(JSC::X86Assembler::revertJumpTo_movq_i64r):
(JSC::X86Assembler::revertJumpTo_movl_i32r):

bytecode/ArrayProfile.cpp:

(JSC::ArrayProfile::computeUpdatedPrediction):

bytecode/ArrayProfile.h:

(JSC::ArrayProfile::ArrayProfile):
(JSC::ArrayProfile::addressOfLastSeenStructureID):
(JSC::ArrayProfile::observeStructure):

bytecode/CodeBlock.h:

(JSC::CodeBlock::heap):

bytecode/UnlinkedCodeBlock.h:
debugger/Debugger.h:
dfg/DFGAbstractHeap.h:
dfg/DFGArrayifySlowPathGenerator.h:
dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::branchWeakStructure):
(JSC::DFG::JITCompiler::branchStructurePtr):

dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::osrWriteBarrier):
(JSC::DFG::adjustAndJumpToTarget):

dfg/DFGOperations.cpp:

(JSC::DFG::putByVal):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArray):
(JSC::DFG::SpeculativeJIT::arrayify):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compileInstanceOfForObject):
(JSC::DFG::SpeculativeJIT::compileInstanceOf):
(JSC::DFG::SpeculativeJIT::compileToStringOnCell):
(JSC::DFG::SpeculativeJIT::speculateObject):
(JSC::DFG::SpeculativeJIT::speculateFinalObject):
(JSC::DFG::SpeculativeJIT::speculateObjectOrOther):
(JSC::DFG::SpeculativeJIT::speculateString):
(JSC::DFG::SpeculativeJIT::speculateStringObject):
(JSC::DFG::SpeculativeJIT::speculateStringOrStringObject):
(JSC::DFG::SpeculativeJIT::emitSwitchChar):
(JSC::DFG::SpeculativeJIT::emitSwitchString):
(JSC::DFG::SpeculativeJIT::genericWriteBarrier):
(JSC::DFG::SpeculativeJIT::writeBarrier):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::emitAllocateJSCell):
(JSC::DFG::SpeculativeJIT::speculateStringObjectForStructure):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::writeBarrier):

dfg/DFGSpeculativeJIT64.cpp:

dfg/DFGWorklist.cpp:
ftl/FTLAbstractHeapRepository.cpp:

(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):

ftl/FTLAbstractHeapRepository.h:
ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileCheckStructure):
(JSC::FTL::LowerDFGToLLVM::compileArrayifyToStructure):
(JSC::FTL::LowerDFGToLLVM::compilePutStructure):
(JSC::FTL::LowerDFGToLLVM::compileToString):
(JSC::FTL::LowerDFGToLLVM::compileMultiGetByOffset):
(JSC::FTL::LowerDFGToLLVM::compileMultiPutByOffset):
(JSC::FTL::LowerDFGToLLVM::speculateTruthyObject):
(JSC::FTL::LowerDFGToLLVM::allocateCell):
(JSC::FTL::LowerDFGToLLVM::equalNullOrUndefined):
(JSC::FTL::LowerDFGToLLVM::isObject):
(JSC::FTL::LowerDFGToLLVM::isString):
(JSC::FTL::LowerDFGToLLVM::isArrayType):
(JSC::FTL::LowerDFGToLLVM::hasClassInfo):
(JSC::FTL::LowerDFGToLLVM::isType):
(JSC::FTL::LowerDFGToLLVM::speculateStringOrStringObject):
(JSC::FTL::LowerDFGToLLVM::speculateStringObjectForCell):
(JSC::FTL::LowerDFGToLLVM::speculateStringObjectForStructureID):
(JSC::FTL::LowerDFGToLLVM::speculateNonNullObject):
(JSC::FTL::LowerDFGToLLVM::loadMarkByte):
(JSC::FTL::LowerDFGToLLVM::loadStructure):
(JSC::FTL::LowerDFGToLLVM::weakStructure):

ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

ftl/FTLOutput.h:

(JSC::FTL::Output::store8):

heap/GCAssertions.h:
heap/Heap.cpp:

(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::collect):
(JSC::Heap::writeBarrier):

heap/Heap.h:

(JSC::Heap::structureIDTable):

heap/MarkedSpace.h:

(JSC::MarkedSpace::forEachBlock):

heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::internalAppend):

jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::branchIfCellNotObject):
(JSC::AssemblyHelpers::genericWriteBarrier):
(JSC::AssemblyHelpers::emitLoadStructure):
(JSC::AssemblyHelpers::emitStoreStructureWithTypeInfo):

jit/JIT.h:
jit/JITCall.cpp:

(JSC::JIT::compileOpCall):
(JSC::JIT::privateCompileClosureCall):

jit/JITCall32_64.cpp:

(JSC::JIT::emit_op_ret_object_or_this):
(JSC::JIT::compileOpCall):
(JSC::JIT::privateCompileClosureCall):

jit/JITInlineCacheGenerator.cpp:

(JSC::JITByIdGenerator::generateFastPathChecks):

jit/JITInlineCacheGenerator.h:
jit/JITInlines.h:

(JSC::JIT::emitLoadCharacterString):
(JSC::JIT::checkStructure):
(JSC::JIT::emitJumpIfCellNotObject):
(JSC::JIT::emitAllocateJSObject):
(JSC::JIT::emitArrayProfilingSiteWithCell):
(JSC::JIT::emitArrayProfilingSiteForBytecodeIndexWithCell):
(JSC::JIT::branchStructure):
(JSC::branchStructure):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_check_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emit_op_is_undefined):
(JSC::JIT::emit_op_is_string):
(JSC::JIT::emit_op_ret_object_or_this):
(JSC::JIT::emit_op_to_primitive):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_next_pname):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
(JSC::JIT::emit_op_to_this):
(JSC::JIT::emitSlow_op_to_this):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_check_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emit_op_is_undefined):
(JSC::JIT::emit_op_is_string):
(JSC::JIT::emit_op_to_primitive):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_next_pname):
(JSC::JIT::emit_op_to_this):

jit/JITOperations.cpp:
jit/JITPropertyAccess.cpp:

(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_get_by_pname):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitLoadWithStructureCheck):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::emitSlow_op_put_to_scope):
(JSC::JIT::checkMarkWord):
(JSC::JIT::emitWriteBarrier):
(JSC::JIT::addStructureTransitionCheck):
(JSC::JIT::emitIntTypedArrayGetByVal):
(JSC::JIT::emitFloatTypedArrayGetByVal):
(JSC::JIT::emitIntTypedArrayPutByVal):
(JSC::JIT::emitFloatTypedArrayPutByVal):

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_get_by_pname):
(JSC::JIT::emitLoadWithStructureCheck):

jit/JSInterfaceJIT.h:

(JSC::JSInterfaceJIT::emitJumpIfNotType):

jit/Repatch.cpp:

(JSC::repatchByIdSelfAccess):
(JSC::addStructureTransitionCheck):
(JSC::replaceWithJump):
(JSC::generateProtoChainAccessStub):
(JSC::tryCacheGetByID):
(JSC::tryBuildGetByIDList):
(JSC::writeBarrier):
(JSC::emitPutReplaceStub):
(JSC::emitPutTransitionStub):
(JSC::tryBuildPutByIdList):
(JSC::tryRepatchIn):
(JSC::linkClosureCall):
(JSC::resetGetByID):
(JSC::resetPutByID):

jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::loadJSStringArgument):
(JSC::SpecializedThunkJIT::loadArgumentWithSpecificClass):

jit/ThunkGenerators.cpp:

(JSC::virtualForThunkGenerator):
(JSC::arrayIteratorNextThunkGenerator):

jit/UnusedPointer.h:
llint/LowLevelInterpreter.asm:
llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
runtime/Arguments.cpp:

(JSC::Arguments::createStrictModeCallerIfNecessary):
(JSC::Arguments::createStrictModeCalleeIfNecessary):

runtime/Arguments.h:

(JSC::Arguments::createStructure):

runtime/ArrayPrototype.cpp:

(JSC::shift):
(JSC::unshift):
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncReverse):
(JSC::performSlowSort):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):

runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

runtime/Executable.h:

(JSC::ExecutableBase::isFunctionExecutable):
(JSC::ExecutableBase::clearCodeVirtual):
(JSC::ScriptExecutable::unlinkCalls):

runtime/GetterSetter.cpp:

(JSC::callGetter):
(JSC::callSetter):

runtime/InitializeThreading.cpp:
runtime/JSArray.cpp:

(JSC::JSArray::unshiftCountSlowCase):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::shiftCountWithArrayStorage):
(JSC::JSArray::shiftCountWithAnyIndexingType):
(JSC::JSArray::unshiftCountWithArrayStorage):
(JSC::JSArray::unshiftCountWithAnyIndexingType):
(JSC::JSArray::sortNumericVector):
(JSC::JSArray::sortNumeric):
(JSC::JSArray::sortCompactedVector):
(JSC::JSArray::sort):
(JSC::JSArray::sortVector):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToArguments):
(JSC::JSArray::compactForSorting):

runtime/JSCJSValueInlines.h:

(JSC::JSValue::toThis):
(JSC::JSValue::put):
(JSC::JSValue::putByIndex):
(JSC::JSValue::equalSlowCaseInline):

runtime/JSCell.cpp:

(JSC::JSCell::put):
(JSC::JSCell::putByIndex):
(JSC::JSCell::deleteProperty):
(JSC::JSCell::deletePropertyByIndex):

runtime/JSCell.h:

(JSC::JSCell::clearStructure):
(JSC::JSCell::mark):
(JSC::JSCell::isMarked):
(JSC::JSCell::structureIDOffset):
(JSC::JSCell::typeInfoFlagsOffset):
(JSC::JSCell::typeInfoTypeOffset):
(JSC::JSCell::indexingTypeOffset):
(JSC::JSCell::gcDataOffset):

runtime/JSCellInlines.h:

(JSC::JSCell::JSCell):
(JSC::JSCell::finishCreation):
(JSC::JSCell::type):
(JSC::JSCell::indexingType):
(JSC::JSCell::structure):
(JSC::JSCell::visitChildren):
(JSC::JSCell::isObject):
(JSC::JSCell::isString):
(JSC::JSCell::isGetterSetter):
(JSC::JSCell::isProxy):
(JSC::JSCell::isAPIValueWrapper):
(JSC::JSCell::setStructure):
(JSC::JSCell::methodTable):
(JSC::Heap::writeBarrier):

runtime/JSDataView.cpp:

(JSC::JSDataView::createStructure):

runtime/JSDestructibleObject.h:

(JSC::JSCell::classInfo):

runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnNonIndexPropertyNames):
(JSC::JSFunction::put):
(JSC::JSFunction::defineOwnProperty):

runtime/JSGenericTypedArrayView.h:

(JSC::JSGenericTypedArrayView::createStructure):

runtime/JSObject.cpp:

(JSC::getCallableObjectSlow):
(JSC::JSObject::copyButterfly):
(JSC::JSObject::visitButterfly):
(JSC::JSFinalObject::visitChildren):
(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::put):
(JSC::JSObject::putByIndex):
(JSC::JSObject::enterDictionaryIndexingModeWhenArrayStorageAlreadyExists):
(JSC::JSObject::enterDictionaryIndexingMode):
(JSC::JSObject::notifyPresenceOfIndexedAccessors):
(JSC::JSObject::createInitialIndexedStorage):
(JSC::JSObject::createInitialUndecided):
(JSC::JSObject::createInitialInt32):
(JSC::JSObject::createInitialDouble):
(JSC::JSObject::createInitialContiguous):
(JSC::JSObject::createArrayStorage):
(JSC::JSObject::convertUndecidedToInt32):
(JSC::JSObject::convertUndecidedToDouble):
(JSC::JSObject::convertUndecidedToContiguous):
(JSC::JSObject::constructConvertedArrayStorageWithoutCopyingElements):
(JSC::JSObject::convertUndecidedToArrayStorage):
(JSC::JSObject::convertInt32ToDouble):
(JSC::JSObject::convertInt32ToContiguous):
(JSC::JSObject::convertInt32ToArrayStorage):
(JSC::JSObject::genericConvertDoubleToContiguous):
(JSC::JSObject::convertDoubleToArrayStorage):
(JSC::JSObject::convertContiguousToArrayStorage):
(JSC::JSObject::ensureInt32Slow):
(JSC::JSObject::ensureDoubleSlow):
(JSC::JSObject::ensureContiguousSlow):
(JSC::JSObject::ensureArrayStorageSlow):
(JSC::JSObject::ensureArrayStorageExistsAndEnterDictionaryIndexingMode):
(JSC::JSObject::switchToSlowPutArrayStorage):
(JSC::JSObject::setPrototype):
(JSC::JSObject::setPrototypeWithCycleCheck):
(JSC::JSObject::putDirectNonIndexAccessor):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::hasOwnProperty):
(JSC::JSObject::deletePropertyByIndex):
(JSC::JSObject::getPrimitiveNumber):
(JSC::JSObject::hasInstance):
(JSC::JSObject::getPropertySpecificValue):
(JSC::JSObject::getPropertyNames):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::getOwnNonIndexPropertyNames):
(JSC::JSObject::seal):
(JSC::JSObject::freeze):
(JSC::JSObject::preventExtensions):
(JSC::JSObject::reifyStaticFunctionsForDelete):
(JSC::JSObject::removeDirect):
(JSC::JSObject::putByIndexBeyondVectorLengthWithoutAttributes):
(JSC::JSObject::putByIndexBeyondVectorLength):
(JSC::JSObject::putDirectIndexBeyondVectorLengthWithArrayStorage):
(JSC::JSObject::putDirectIndexBeyondVectorLength):
(JSC::JSObject::getNewVectorLength):
(JSC::JSObject::countElements):
(JSC::JSObject::increaseVectorLength):
(JSC::JSObject::ensureLengthSlow):
(JSC::JSObject::growOutOfLineStorage):
(JSC::JSObject::getOwnPropertyDescriptor):
(JSC::putDescriptor):
(JSC::JSObject::defineOwnNonIndexProperty):

runtime/JSObject.h:

(JSC::getJSFunction):
(JSC::JSObject::getArrayLength):
(JSC::JSObject::getVectorLength):
(JSC::JSObject::putByIndexInline):
(JSC::JSObject::canGetIndexQuickly):
(JSC::JSObject::getIndexQuickly):
(JSC::JSObject::tryGetIndexQuickly):
(JSC::JSObject::getDirectIndex):
(JSC::JSObject::canSetIndexQuickly):
(JSC::JSObject::canSetIndexQuicklyForPutDirect):
(JSC::JSObject::setIndexQuickly):
(JSC::JSObject::initializeIndex):
(JSC::JSObject::hasSparseMap):
(JSC::JSObject::inSparseIndexingMode):
(JSC::JSObject::getDirect):
(JSC::JSObject::getDirectOffset):
(JSC::JSObject::isSealed):
(JSC::JSObject::isFrozen):
(JSC::JSObject::flattenDictionaryObject):
(JSC::JSObject::ensureInt32):
(JSC::JSObject::ensureDouble):
(JSC::JSObject::ensureContiguous):
(JSC::JSObject::rageEnsureContiguous):
(JSC::JSObject::ensureArrayStorage):
(JSC::JSObject::arrayStorage):
(JSC::JSObject::arrayStorageOrNull):
(JSC::JSObject::ensureLength):
(JSC::JSObject::currentIndexingData):
(JSC::JSObject::getHolyIndexQuickly):
(JSC::JSObject::currentRelevantLength):
(JSC::JSObject::isGlobalObject):
(JSC::JSObject::isVariableObject):
(JSC::JSObject::isStaticScopeObject):
(JSC::JSObject::isNameScopeObject):
(JSC::JSObject::isActivationObject):
(JSC::JSObject::isErrorInstance):
(JSC::JSObject::inlineGetOwnPropertySlot):
(JSC::JSObject::fastGetOwnPropertySlot):
(JSC::JSObject::getPropertySlot):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::setStructureAndReallocateStorageIfNecessary):

runtime/JSPropertyNameIterator.h:

(JSC::JSPropertyNameIterator::createStructure):

runtime/JSProxy.cpp:

(JSC::JSProxy::getOwnPropertySlot):
(JSC::JSProxy::getOwnPropertySlotByIndex):
(JSC::JSProxy::put):
(JSC::JSProxy::putByIndex):
(JSC::JSProxy::defineOwnProperty):
(JSC::JSProxy::deleteProperty):
(JSC::JSProxy::deletePropertyByIndex):
(JSC::JSProxy::getPropertyNames):
(JSC::JSProxy::getOwnPropertyNames):

runtime/JSScope.cpp:

(JSC::JSScope::objectAtScope):

runtime/JSString.h:

(JSC::JSString::createStructure):
(JSC::isJSString):

runtime/JSType.h:
runtime/JSTypeInfo.h:

(JSC::TypeInfo::TypeInfo):
(JSC::TypeInfo::isObject):
(JSC::TypeInfo::structureIsImmortal):
(JSC::TypeInfo::zeroedGCDataOffset):
(JSC::TypeInfo::inlineTypeFlags):

runtime/MapData.h:
runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorKeys):
(JSC::objectConstructorDefineProperty):
(JSC::defineProperties):
(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):
(JSC::objectConstructorIsSealed):
(JSC::objectConstructorIsFrozen):

runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
(JSC::objectProtoFuncToString):

runtime/Operations.cpp:

(JSC::jsTypeStringForValue):
(JSC::jsIsObjectType):

runtime/Operations.h:

(JSC::normalizePrototypeChainForChainAccess):
(JSC::normalizePrototypeChain):

runtime/PropertyMapHashTable.h:

(JSC::PropertyTable::createStructure):

runtime/RegExp.h:

(JSC::RegExp::createStructure):

runtime/SparseArrayValueMap.h:
runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::~Structure):
(JSC::Structure::prototypeChainMayInterceptStoreTo):

runtime/Structure.h:

(JSC::Structure::id):
(JSC::Structure::idBlob):
(JSC::Structure::objectInitializationFields):
(JSC::Structure::structureIDOffset):

runtime/StructureChain.h:

(JSC::StructureChain::createStructure):

runtime/StructureIDTable.cpp: Added.

(JSC::StructureIDTable::StructureIDTable):
(JSC::StructureIDTable::~StructureIDTable):
(JSC::StructureIDTable::resize):
(JSC::StructureIDTable::flushOldTables):
(JSC::StructureIDTable::allocateID):
(JSC::StructureIDTable::deallocateID):

runtime/StructureIDTable.h: Added.

(JSC::StructureIDTable::base):
(JSC::StructureIDTable::get):

runtime/SymbolTable.h:
runtime/TypedArrayType.cpp:

(JSC::typeForTypedArrayType):

runtime/TypedArrayType.h:
runtime/WeakMapData.h:

5:26 PM Changeset in webkit [164763] by mmaxfield@apple.com

2 edits in trunk/Source/WebCore

Ranges given to createMarkupInternal might not be canonicalized
https://bugs.webkit.org/show_bug.cgi?id=129408

Reviewed by Ryosuke Niwa.

When WebKit clients (such as Mail) call WKWebArchiveCreateFromRange() with a range,
that range is not necessarily canonicalized. Therefore, comparing it for equality
with a canonicalized range might return a false negative. Instead, we should compare
canonicalized ranges.

No new tests because this codepath will only be reached via SPI.

editing/markup.cpp:

(WebCore::createMarkupInternal):

5:21 PM Changeset in webkit [164762] by enrica@apple.com

2 edits in trunk/Source/WebKit2

Build fix.

WKFormInputControl.mm and WKFormPopover.mm should be excluded from OS X builds.

Configurations/WebKit2.xcconfig:

5:09 PM Changeset in webkit [164761] by mhahnenberg@apple.com

2 edits in trunk/Source/JavaScriptCore

Unconditional logging in compileFTLOSRExit
https://bugs.webkit.org/show_bug.cgi?id=129407

Reviewed by Michael Saboff.

This was causing tests to fail with the FTL enabled.

ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileFTLOSRExit):

5:06 PM Changeset in webkit [164760] by enrica@apple.com

11 edits
7 adds in trunk/Source

[iOS WebKit2] Form controls handling: implement date and time controls.
https://bugs.webkit.org/show_bug.cgi?id=129344

Reviewed by Simon Fraser and Joseph Pecoraro.

../WebCore:

Adding one localizable string.

English.lproj/Localizable.strings:

../WebKit2:

This is another step in the implementation of form controls on iOS
for WebKit2. This adds support for date and time input elements supporting
the different look and feel for iPhone and iPad.
WKDateTimePicker implements iPhone UI and
WKDateTimePopover implements iPad UI.
WKFormRotatingAccessoryPopover and WKRotatingPopover are
classes that implement the popover object handling the rotation
and they will be used as base class for the select controls as well.

UIProcess/WebPageProxy.h:
UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _displayFormNodeInputView]):
(-[WKContentView inputView]):
(-[WKContentView _startAssistingNode:]):
(-[WKContentView _stopAssistingNode]):

UIProcess/ios/WKFormInputControl.h: Added.
UIProcess/ios/WKFormInputControl.mm: Added.

(-[WKDateTimePicker datePicker]):
(-[WKDateTimePicker initWithView:datePickerMode:]):
(-[WKDateTimePicker dealloc]):
(-[WKDateTimePicker controlView]):
(-[WKDateTimePicker _timeZoneOffsetFromGMT:]):
(-[WKDateTimePicker _sanitizeInputValueForFormatter:]):
(-[WKDateTimePicker _dateChangedSetAsNumber]):
(-[WKDateTimePicker _dateChangedSetAsString]):
(-[WKDateTimePicker _dateChanged]):
(-[WKDateTimePicker _dateChangeHandler:]):
(-[WKDateTimePicker controlBeginEditing]):
(-[WKDateTimePicker controlEndEditing]):
(-[WKFormInputControl initWithView:]):
(+[WKFormInputControl createPeripheralWithView:]):
(-[WKFormInputControl beginEditing]):
(-[WKFormInputControl endEditing]):
(-[WKFormInputControl assistantView]):
(-[WKDateTimePopoverViewController initWithView:datePickerMode:]):
(-[WKDateTimePopoverViewController innerControl]):
(-[WKDateTimePopoverViewController loadView]):
(-[WKDateTimePopover clear:]):
(-[WKDateTimePopover initWithView:datePickerMode:]):
(-[WKDateTimePopover viewController]):
(-[WKDateTimePopover controlBeginEditing]):
(-[WKDateTimePopover controlEndEditing]):
(-[WKDateTimePopover controlView]):

UIProcess/ios/WKFormPeripheral.h: Added.
UIProcess/ios/WKFormPopover.h: Added.
UIProcess/ios/WKFormPopover.mm: Added.

(-[WKFormRotatingAccessoryPopover initWithView:]):
(-[WKFormRotatingAccessoryPopover accessoryDone]):
(-[WKFormRotatingAccessoryPopover popoverArrowDirections]):
(-[WKFormRotatingAccessoryPopover popoverWasDismissed:]):
(-[WKRotatingPopover initWithView:]):
(-[WKRotatingPopover dealloc]):
(-[WKRotatingPopover popoverController]):
(-[WKRotatingPopover setPopoverController:]):
(-[WKRotatingPopover popoverArrowDirections]):
(-[WKRotatingPopover presentPopoverAnimated:]):
(-[WKRotatingPopover dismissPopoverAnimated:]):
(-[WKRotatingPopover willRotate:]):
(-[WKRotatingPopover didRotate:]):
(-[WKRotatingPopover popoverControllerDidDismissPopover:]):

UIProcess/ios/WKFormSelectControl.h: Added.
UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::setAssistedNodeValue):
(WebKit::WebPageProxy::setAssistedNodeValueAsNumber):

WebKit2.xcodeproj/project.pbxproj:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::setAssistedNodeValue):
(WebKit::WebPage::setAssistedNodeValueAsNumber):

5:04 PM Changeset in webkit [164759] by Simon Fraser

7 edits in trunk/Source/WebCore

Prepare for overflow scrolling nodes in the scrolling tree
https://bugs.webkit.org/show_bug.cgi?id=129398

Reviewed by Tim Horton.

Lay some groundwork for overflow:scrolling nodes in the scrolling tree.
Change terminology to refer to "scroll-coordinatored" layers now, not just viewport-constrained
layers.

A given layer can be both viewport-constrained and overflow-scrolling (e.g. position:fixed,
overflow:scroll), so handle that in RenderLayerBacking, and use some "reason" flags
in RenderLayerCompositor.

page/FrameView.cpp:

(WebCore::FrameView::scrollLayerID): Rename

page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::attachNode): Remove invalid assertion.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::updateScrollingLayers): Simplify the logic with
an early return.
(WebCore::RenderLayerBacking::detachFromScrollingCoordinator):
Allow a layer to play both viewport-constrained and scrolling roles
in the scrolling tree.

rendering/RenderLayerBacking.h:

(WebCore::RenderLayerBacking::viewportConstrainedNodeID):
(WebCore::RenderLayerBacking::setViewportConstrainedNodeID):
(WebCore::RenderLayerBacking::scrollingNodeID):
(WebCore::RenderLayerBacking::setScrollingNodeID):
(WebCore::RenderLayerBacking::scrollingNodeIDForChildren):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::didFlushChangesForLayer):
(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::layerWillBeRemoved):
(WebCore::RenderLayerCompositor::fixedRootBackgroundLayerChanged):
(WebCore::RenderLayerCompositor::clearBackingForLayerIncludingDescendants):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore):
(WebCore::RenderLayerCompositor::reasonsForCompositing):
(WebCore::RenderLayerCompositor::requiresCompositingForScrolling):
(WebCore::isViewportConstrainedFixedOrStickyLayer):
(WebCore::isMainFrameScrollingOrOverflowScrolling):
(WebCore::RenderLayerCompositor::rootLayerAttachmentChanged):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedStatus):
(WebCore::RenderLayerCompositor::removeFromScrollCoordinatedLayers):
(WebCore::nearestScrollCoordinatedAncestor):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):
(WebCore::RenderLayerCompositor::detachScrollCoordinatedLayer):
(WebCore::RenderLayerCompositor::registerAllViewportConstrainedLayers):
(WebCore::RenderLayerCompositor::willRemoveScrollingLayer):
(WebCore::RenderLayerCompositor::didAddScrollingLayer):

rendering/RenderLayerCompositor.h:

4:52 PM Changeset in webkit [164758] by psolanki@apple.com

2 edits in trunk/Source/WebKit2

[iOS][Webkit2] Enable codesigning entitlement for web process
https://bugs.webkit.org/show_bug.cgi?id=129401
<rdar://problem/16173873>

Reviewed by Geoffrey Garen.

Configurations/WebContent-iOS.entitlements:

4:19 PM Changeset in webkit [164757] by aestes@apple.com

10 edits
1 add
1 delete in trunk/Source

[iOS] Support network state notification using CPNetworkObserver
https://bugs.webkit.org/show_bug.cgi?id=129358

Reviewed by Dan Bernstein.

Source/WebCore:

Add iOS support for navigator.onLine and online/offline events. Since
it can be expensive to query CPNetworkObserver, wait to do so until
someone calls NetworkStateObserver::onLine() or
NetworkStateObserver::addNetworkStateChangeListener(). For clients that
don't wish to observe network reachability at all, add a global opt-out.
These clients will only pay the cost of CPNetworkObserver if they load
a page that explicitly accesses navigator.onLine.

No new tests. Covered by existing tests.

WebCore.exp.in: Stopped exporting NetworkStateNotifier::setIsOnLine()

and started exporting Settings::gShouldOptOutOfNetworkStateObservation.

WebCore.xcodeproj/project.pbxproj: Renamed NetworkStateNotifierIOS.cpp

to NetworkStateNotifierIOS.mm.

page/Settings.cpp: Defaulted gShouldOptOutOfNetworkStateObservation

to false.

page/Settings.h:

(WebCore::Settings::setShouldOptOutOfNetworkStateObservation):
(WebCore::Settings::shouldOptOutOfNetworkStateObservation):

platform/network/NetworkStateNotifier.cpp:

(WebCore::NetworkStateNotifier::addNetworkStateChangeListener): Ignored
the listener if Settings::shouldOptOutOfNetworkStateObservation().
Called registerObserverIfNecessary() and added the listener otherwise.
(WebCore::NetworkStateNotifier::notifyNetworkStateChange): Const qualified.

platform/network/NetworkStateNotifier.h

(NetworkStateNotifier::onLine):

platform/network/ios/NetworkStateNotifierIOS.cpp: Removed.
platform/network/ios/NetworkStateNotifierIOS.mm: Added.

(-[NetworkStateObserver initWithNotifier:WebCore::]): Registered self
as a network reachable observer on CPNetworkObserver.
(-[NetworkStateObserver dealloc]): Removed self as a network reachable
observer.
(-[NetworkStateObserver networkStateChanged:]): Called setOnLine() on
the web thread, passing the reachability value from the notification.
(WebCore::NetworkStateNotifier::NetworkStateNotifier):
(WebCore::NetworkStateNotifier::~NetworkStateNotifier): Cleared
m_observer's pointer back to us.
(WebCore::NetworkStateNotifier::registerObserverIfNecessary): Initialized
m_observer if necessary.
(WebCore::NetworkStateNotifier::onLine): Called
registerObserverIfNecessary() and set an initial value for m_isOnLine
if m_isOnLineInitialized is false. Returned m_isOnLine.
(WebCore::setOnLine): Set m_isOnLine and called
notifyNetworkStateChange() if needed. Unconditionally set
m_isOnLineInitialized to true.

Source/WebKit/mac:

WebView/WebView.mm:

(-[WebView _setNetworkStateIsOnline:]): Retained an empty
implementation for binary compatibility for UIKit.
(+[WebView _doNotStartObservingNetworkReachability]): Called
Settings::setShouldOptOutOfNetworkStateObservation(true).

WebView/WebViewPrivate.h: Removed declaration of

_setNetworkStateIsOnline: and declared
_doNotStartObservingNetworkReachability.

3:48 PM Changeset in webkit [164756] by andersca@apple.com

11 edits in trunk/Source/WebKit2

Give VisitedLinkProviders an identifier and send them to the web process
https://bugs.webkit.org/show_bug.cgi?id=129400

Reviewed by Dan Bernstein.

Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

Shared/WebPageCreationParameters.h:
UIProcess/API/Cocoa/WKVisitedLinkProviderInternal.h:
UIProcess/VisitedLinkProvider.cpp:

(WebKit::generateIdentifier):
(WebKit::VisitedLinkProvider::VisitedLinkProvider):

UIProcess/VisitedLinkProvider.h:

(WebKit::VisitedLinkProvider::identifier):

UIProcess/WebContext.cpp:

(WebKit::WebContext::createWebPage):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::internalShowContextMenu):

UIProcess/WebPageProxy.h:

3:43 PM Changeset in webkit [164755] by Julien Brianceau

2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

Scripts/webkitpy/common/config/contributors.json:

3:25 PM Changeset in webkit [164754] by jinwoo7.song@samsung.com

2 edits in trunk/Source/WebKit2

Unreviewed CMAKE build fix after r164751.

CMakeLists.txt: Renamed WebVisitedLinkProvider.cpp to VisitedLinkTableController.cpp.

3:20 PM Changeset in webkit [164753] by BJ Burg

4 edits in trunk/Source/WebCore

Unreviewed build fix for !ENABLE(CONTEXT_MENUS).

I forgot to add guards to handleContextMenuEvent().

replay/UserInputBridge.cpp:
replay/UserInputBridge.h:

3:14 PM Changeset in webkit [164752] by dino@apple.com

2 edits in trunk/Source/WebCore

[WebGL] Only skip context error retrieval if a pending context
https://bugs.webkit.org/show_bug.cgi?id=129397

Reviewed by Tim Horton.

A lost context should still ask the GC3D what the error is. Only
a pending context should return early.

html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getError):

3:01 PM Changeset in webkit [164751] by andersca@apple.com

3 edits
2 moves in trunk/Source/WebKit2

Rename WebVisitedLinkProvider to VisitedLinkTableController
https://bugs.webkit.org/show_bug.cgi?id=129396

Reviewed by Dan Bernstein.

WebKit2.xcodeproj/project.pbxproj:
WebProcess/WebPage/VisitedLinkTableController.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/WebVisitedLinkProvider.cpp.

(WebKit::VisitedLinkTableController::create):
(WebKit::VisitedLinkTableController::VisitedLinkTableController):
(WebKit::VisitedLinkTableController::~VisitedLinkTableController):
(WebKit::VisitedLinkTableController::isLinkVisited):
(WebKit::VisitedLinkTableController::addVisitedLink):

WebProcess/WebPage/VisitedLinkTableController.h: Renamed from Source/WebKit2/WebProcess/WebPage/WebVisitedLinkProvider.h.
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

2:30 PM Changeset in webkit [164750] by enrica@apple.com

2 edits in trunk/Source/WebKit2

Keyboard keeps showing up when clicking links after being shown once.
https://bugs.webkit.org/show_bug.cgi?id=129392

Reviewed by Benjamin Poulain.

This is a regression introduced by http://trac.webkit.org/changeset/164690.
_requiresKeyboardWhenFirstResponder should always return NO, if there is
no assisted node.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _requiresKeyboardWhenFirstResponder]):

2:20 PM Changeset in webkit [164749] by mmaxfield@apple.com

2 edits in trunk/Source/WebKit2

WebProcessProxy::updateProcessState() is causing duplicate symbol linker errors
https://bugs.webkit.org/show_bug.cgi?id=129390

Reviewed by Tim Horton.

Caused by r164737. WebProcessProxy::updateProcessState() is defined in a header, outside of
a class, but isn't inlined.

UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::updateProcessState):

2:10 PM Changeset in webkit [164748] by lvidacs.u-szeged@partner.samsung.com

2 edits in trunk/Tools

Unreviewed. Moved myself to the list of committers.

Scripts/webkitpy/common/config/contributors.json:

1:49 PM Changeset in webkit [164747] by oliver@apple.com

4 edits in trunk/Source/JavaScriptCore

Remove unused access types
https://bugs.webkit.org/show_bug.cgi?id=129385

Reviewed by Filip Pizlo.

Remove unused cruft.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printGetByIdCacheStatus):

bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::deref):

bytecode/StructureStubInfo.h:

(JSC::isGetByIdAccess):
(JSC::isPutByIdAccess):

1:44 PM Changeset in webkit [164746] by mrowe@apple.com

19 edits
2 deletes in trunk/Source

Roll out r164732 since it broke Production Mac builds.

1:41 PM Changeset in webkit [164745] by BJ Burg

13 edits
2 adds in trunk/Source

Web Replay: route through UserInputBridge when delivering user inputs to WebCore
https://bugs.webkit.org/show_bug.cgi?id=128150

Reviewed by Timothy Hatcher.

Source/WebCore:

Add an UserInputBridge instance to each Page. WebKit2 routes a page's user inputs through
the WebCore page's user input bridge so that the inputs can be selectively captured, filtered,
and replayed using instrumentation inside the UserInputBridge.

For now, the routing methods of UserInputBridge have no replay-specific code paths, and just
put the input delivery code inside WebCore rather than its external clients. Replay-specific
code paths will be added once https://bugs.webkit.org/show_bug.cgi?id=128782 is fixed. However,
once complete the code will work as follows:

When neither capturing or replaying, behavior is unchanged.

When capturing user inputs, each external input is saved into a replay log as it crosses

the bridge from outside WebCore.

When replaying, the bridge closes and user inputs from WebKit2 are not accepted. Instead,

the saved inputs from the replay log are re-dispatched as if they had crossed the bridge.

CMakeLists.txt:
GNUmakefile.am:
GNUmakefile.list.am:
WebCore.exp.in: Add symbols for input routing methods.
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
page/Page.cpp:

(WebCore::Page::Page): Initialize the owned UserInputBridge in the Page constructor.

page/Page.h:

(WebCore::Page::inputBridge): Added a by-reference getter.

replay/UserInputBridge.cpp: Added.

(WebCore::UserInputBridge::UserInputBridge):
(WebCore::UserInputBridge::~UserInputBridge):
(WebCore::UserInputBridge::handleContextMenuEvent):
(WebCore::UserInputBridge::handleMousePressEvent):
(WebCore::UserInputBridge::handleMouseReleaseEvent):
(WebCore::UserInputBridge::handleMouseMoveEvent):
(WebCore::UserInputBridge::handleMouseMoveOnScrollbarEvent):
(WebCore::UserInputBridge::handleKeyEvent):
(WebCore::UserInputBridge::handleAccessKeyEvent):
(WebCore::UserInputBridge::handleWheelEvent):
(WebCore::UserInputBridge::focusSetActive):
(WebCore::UserInputBridge::focusSetFocused):
(WebCore::UserInputBridge::scrollRecursively):
(WebCore::UserInputBridge::logicalScrollRecursively):
(WebCore::UserInputBridge::loadRequest):
(WebCore::UserInputBridge::reloadFrame):
(WebCore::UserInputBridge::stopLoadingFrame):
(WebCore::UserInputBridge::tryClosePage):

replay/UserInputBridge.h: Added.

Source/WebKit2:

When delivering user inputs to WebCore, route calls through the page's UserInputBridge.
This allows us to capture and replay user inputs from WebKit2 solely within WebCore.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::tryClose):
(WebKit::WebPage::loadRequest):
(WebKit::WebPage::stopLoadingFrame):
(WebKit::WebPage::stopLoading):
(WebKit::WebPage::reload):
(WebKit::WebPage::contextMenuAtPointInWindow):
(WebKit::handleContextMenuEvent):
(WebKit::handleMouseEvent):
(WebKit::handleWheelEvent):
(WebKit::handleKeyEvent):
(WebKit::WebPage::scroll):
(WebKit::WebPage::logicalScroll):

1:31 PM Changeset in webkit [164744] by dino@apple.com

2 edits in trunk/Source/WebCore

[WebGL] Protect more WebGL entry points for pending contexts
https://bugs.webkit.org/show_bug.cgi?id=129386

Reviewed by Tim Horton.

There are entry points into a WebGLRenderingContext that don't
come from the web-exposed API directly, such as drawImage with
the WebGL canvas. Protect these by returning early if we're
a pending context.

Also a bunch of drive-by 0 -> nullptr changes.

html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::markLayerComposited):
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContext::paintRenderingResultsToImageData):
(WebCore::WebGLRenderingContext::reshape):
(WebCore::WebGLRenderingContext::createBuffer):
(WebCore::WebGLRenderingContext::createFramebuffer):
(WebCore::WebGLRenderingContext::createTexture):
(WebCore::WebGLRenderingContext::createProgram):
(WebCore::WebGLRenderingContext::createRenderbuffer):
(WebCore::WebGLRenderingContext::createShader):
(WebCore::WebGLRenderingContext::getActiveAttrib):
(WebCore::WebGLRenderingContext::getActiveUniform):
(WebCore::WebGLRenderingContext::getContextAttributes):
(WebCore::WebGLRenderingContext::getError):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getShaderPrecisionFormat):
(WebCore::WebGLRenderingContext::getUniformLocation):
(WebCore::WebGLRenderingContext::drawImageIntoBuffer):
(WebCore::WebGLRenderingContext::videoFrameToImage):
(WebCore::WebGLRenderingContext::validateBufferDataParameters):
(WebCore::WebGLRenderingContext::LRUImageBufferCache::imageBuffer):

1:27 PM Changeset in webkit [164743] by Bem Jones-Bey

3 edits
4 adds in trunk

[CSS Shapes] inset and inset-rectangle trigger assert with replaced element and large percentage dimension
https://bugs.webkit.org/show_bug.cgi?id=129060

Reviewed by Simon Fraser.

Source/WebCore:

A bounds check was omitted when computing the width and height for inset
rectangles, making it possible for the width or height to end up being
negative. This patch adds in that check for both. It seems that only
replaced elements like iframe and img trigger this problem.

Tests: fast/shapes/shape-outside-floats/shape-outside-floats-img-inset-negative-width-crash.html

fast/shapes/shape-outside-floats/shape-outside-floats-img-inset-rectangle-negative-width-crash.html

rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape):

LayoutTests:

fast/shapes/shape-outside-floats/shape-outside-floats-img-inset-negative-width-crash-expected.txt: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-img-inset-negative-width-crash.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-img-inset-rectangle-negative-width-crash-expected.txt: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-img-inset-rectangle-negative-width-crash.html: Added.

1:17 PM Changeset in webkit [164742] by barraclough@apple.com

2 edits in trunk/Source/WTF

FastMalloc should use vm_page_shift intead of PAGE_SHIFT.
https://bugs.webkit.org/show_bug.cgi?id=129370

Reviewed by Mark Rowe.

"Doesn't this lead to the page map using fewer bits than it was before?
It seems like this will cause some page addresses to no longer be
representable in the map when using 4K pages. Am I missing something?"

wtf/FastMalloc.cpp:
- bdash raises a valid point. This should make the TCMalloc_PageMap larger than absolutely necessary, rather than potentially too small.

1:13 PM Changeset in webkit [164741] by mmaxfield@apple.com

3 edits
2 adds in trunk

Underlines are too thick when zoomed in
https://bugs.webkit.org/show_bug.cgi?id=129352

Reviewed by Dean Jackson.

Source/WebCore:

The input to the underline drawing code is in user-space, not device-space.
The underlines were getting scaled twice, once in InlineTextBox and the other
in GraphicsContext.

Test: fast/css3-text/css3-text-decoration/text-decoration-scaled.html

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):

LayoutTests:

This test changes the page scale factor to a very large value, simulating
the user zooming in with a trackpad. It then positions the viewport
to a place where the underline should not be drawn. It then compares this
to a completely white page.

This explanation cannot be in the test itself because the test sets the
scale factor too high for the tester to be able to read text.

fast/css3-text/css3-text-decoration/text-decoration-scaled-expected.html: Added.
fast/css3-text/css3-text-decoration/text-decoration-scaled.html: Added.

12:58 PM Changeset in webkit [164740] by timothy@apple.com

2 edits in trunk/Source/WebInspectorUI

Fix an issue where the Timeline filter scope bars were not applying.

Reviewed by Joseph Pecoraro.

UserInterface/Views/TimelineDataGrid.js:

(TimelineDataGrid.prototype.treeElementMatchesActiveScopeFilters): Use .get() to access the ScopeBar.

12:54 PM Changeset in webkit [164739] by Martin Robinson

6 edits in trunk/Tools

[GTK] Reduplicate common.top_level_path in scripts
https://bugs.webkit.org/show_bug.cgi?id=129291

Reviewed by Philippe Normand.

Duplicate common.top_level_path and avoid polluting many scripts with awkward system
path manipulation and weird dependencies on the jhbuild infrastructure.

Scripts/run-gtk-tests: Use common again.

(TestRunner._setup_testing_environment): Ditto.

gtk/check-gdom-symbols: Ditto.
gtk/common.py:

(top_level_path): Re-add top_level_path..
(get_build_path): Use the builtin top_level_path again.

gtk/find-make-dist-errors: Use common again.

(get_missing_headers): Ditto.

gtk/generate-inspector-gresource-manifest.py: Ditto.

12:40 PM Changeset in webkit [164738] by oliver@apple.com

3 edits
3 adds in trunk

Function.prototype.apply has a bad time with the spread operator
https://bugs.webkit.org/show_bug.cgi?id=129381

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

Make sure our apply logic handle the spread operator correctly.
To do this we simply emit the enumeration logic that we'd normally
use for other enumerations, but only store the first two results
to registers. Then perform a varargs call.

bytecompiler/NodesCodegen.cpp:

(JSC::ApplyFunctionCallDotNode::emitBytecode):

LayoutTests:

Add tests

js/regress/call-spread-apply-expected.txt: Added.
js/regress/call-spread-apply.html: Added.
js/regress/script-tests/call-spread-apply.js: Added.

(testFunction):
(test2):
(test3):

12:39 PM Changeset in webkit [164737] by psolanki@apple.com

7 edits in trunk/Source/WebKit2

[iOS][WebKit2] Adopt SPI for managing tabs
https://bugs.webkit.org/show_bug.cgi?id=129188
<rdar://problem/15939827>

Reviewed by Gavin Barraclough.

Call into assertions SPI to mark tabs as foreground and background.

Configurations/WebKit2.xcconfig:
Platform/IPC/Connection.h:

(IPC::Connection::xpcConnection): Expose the xpc_connection_t.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::viewStateDidChange):

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didFinishLaunching):

UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::updateProcessState):

UIProcess/ios/WebProcessProxyIOS.mm:

(WebKit::WebProcessProxy::updateProcessState): Added. This goes through the list of
WebPageProxies and sets the process state to foreground if one of them is in a window.
Otherwise, it sets it to background.

12:18 PM Changeset in webkit [164736] by commit-queue@webkit.org

3 edits
2 adds in trunk/Source/WebKit2

Unreviewed, rolling out r164725 and r164731.
http://trac.webkit.org/changeset/164725
http://trac.webkit.org/changeset/164731
https://bugs.webkit.org/show_bug.cgi?id=129382

WebKitTestRunner build is broken on IOS (Requested by smfr on
#webkit).

UIProcess/API/Cocoa/WKView.h:
UIProcess/API/ios/WKViewIOS.mm: Added.

(-[WKView initWithCoder:]):
(-[WKView initWithFrame:processGroup:browsingContextGroup:]):
(-[WKView initWithFrame:processGroup:browsingContextGroup:relatedToView:]):
(-[WKView dealloc]):
(-[WKView setFrame:]):
(-[WKView setBounds:]):
(-[WKView scrollView]):
(-[WKView browsingContextController]):
(-[WKView setAllowsBackForwardNavigationGestures:]):
(-[WKView allowsBackForwardNavigationGestures]):
(-[WKView viewForZoomingInScrollView:]):
(-[WKView scrollViewWillBeginZooming:withView:]):
(-[WKView scrollViewWillBeginDragging:]):
(-[WKView _didFinishScrolling]):
(-[WKView scrollViewDidEndDragging:willDecelerate:]):
(-[WKView scrollViewDidEndDecelerating:]):
(-[WKView scrollViewDidScrollToTop:]):
(-[WKView scrollViewDidScroll:]):
(-[WKView scrollViewDidZoom:]):
(-[WKView scrollViewDidEndZooming:withView:atScale:]):
(-[WKView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):
(-[WKView _frameOrBoundsChanged]):
(-[WKView _updateVisibleContentRects]):
(-[WKView _keyboardChangedWithInfo:adjustScrollView:]):
(-[WKView _keyboardWillChangeFrame:]):
(-[WKView _keyboardDidChangeFrame:]):
(-[WKView _keyboardWillShow:]):
(-[WKView _keyboardWillHide:]):
(-[WKView pageRef]):
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
(-[WKView minimumLayoutSizeOverride]):
(-[WKView setMinimumLayoutSizeOverride:]):
(-[WKView _obscuredInsets]):
(-[WKView _setObscuredInsets:]):
(-[WKView _beginInteractiveObscuredInsetsChange]):
(-[WKView _endInteractiveObscuredInsetsChange]):
(-[WKView _pageExtendedBackgroundColor]):
(-[WKView _setBackgroundExtendsBeyondPage:]):
(-[WKView _backgroundExtendsBeyondPage]):

WebKit2.xcodeproj/project.pbxproj:

12:15 PM Changeset in webkit [164735] by akling@apple.com

20 edits
2 deletes in trunk/Source

Remove unused InspectorCounters.
<https://webkit.org/b/129367>

The InspectorCounters code was only used to implement two layout test
APIs (window.internals.numberOfLive{Nodes,Documents}) yet it had hooks
in crazy places like Node construction and destruction.

Rewrote the internals APIs to iterate over all live Documents instead,
totaling up their referencing Node count. Added a process-global
Document::allDocuments() HashSet to make this whole thing possible.

Reviewed by Sam Weinig.

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.exp.in:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSEventListener.cpp:
dom/Document.cpp:

(WebCore::Document::allDocuments):
(WebCore::Document::Document):
(WebCore::Document::~Document):

dom/Document.h:

(WebCore::Node::Node):

dom/Node.cpp:

(WebCore::Node::~Node):

inspector/InspectorAllInOne.cpp:
inspector/InspectorCounters.cpp: Removed.
inspector/InspectorCounters.h: Removed.
inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):

inspector/InspectorTimelineAgent.h:
inspector/protocol/Timeline.json:
platform/ThreadGlobalData.cpp:
testing/Internals.cpp:

(WebCore::Internals::numberOfLiveNodes):
(WebCore::Internals::numberOfLiveDocuments):

testing/Internals.h:
testing/Internals.idl:

12:13 PM Changeset in webkit [164734] by mark.lam@apple.com

5 edits in trunk/Source/JavaScriptCore

Compilation policy management belongs in operationOptimize(), not the DFG Driver.
<https://webkit.org/b/129355>

Reviewed by Filip Pizlo.

By compilation policy, I mean the rules for determining whether to
compile, when to compile, when to attempt compilation again, etc. The
few of these policy decisions that were previously being made in the
DFG driver are now moved to operationOptimize() where we keep the rest
of the policy logic. Decisions that are based on the capabilities
supported by the DFG are moved to DFG capabiliityLevel().

I've run the following benchmarks:

the collection of jsc benchmarks on the jsc executable vs. its baseline.
Octane 2.0 in browser without the WebInspector.
Octane 2.0 in browser with the WebInspector open and a breakpoint set somewhere where it won't break.

In all of these, the results came out to be a wash as expected.

dfg/DFGCapabilities.cpp:

(JSC::DFG::isSupported):
(JSC::DFG::mightCompileEval):
(JSC::DFG::mightCompileProgram):
(JSC::DFG::mightCompileFunctionForCall):
(JSC::DFG::mightCompileFunctionForConstruct):
(JSC::DFG::mightInlineFunctionForCall):
(JSC::DFG::mightInlineFunctionForClosureCall):
(JSC::DFG::mightInlineFunctionForConstruct):

dfg/DFGCapabilities.h:
dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):

jit/JITOperations.cpp:

11:54 AM Changeset in webkit [164733] by Simon Fraser

2 edits in trunk/Source/WebKit2

Build fix: ContextMenuContextData.* should not be in the Copy Files
phase.

WebKit2.xcodeproj/project.pbxproj:

11:45 AM Changeset in webkit [164732] by msaboff@apple.com

19 edits
2 adds in trunk/Source

Auto generate bytecode information for bytecode parser and LLInt
https://bugs.webkit.org/show_bug.cgi?id=129181

Reviewed by Mark Lam.

Source/JavaScriptCore:

Added new bytecode/BytecodeList.json that contains a list of bytecodes and related
helpers. It also includes bytecode length and other information used to generate files.
Added a new generator, generate-bytecode-files that generates Bytecodes.h and InitBytecodes.asm
in DerivedSources/JavaScriptCore/.

Added the generation of these files to the "DerivedSource" build step.
Slighty changed the build order, since the Bytecodes.h file is needed by
JSCLLIntOffsetsExtractor. Moved the offline assembly to a separate step since it needs
to be run after JSCLLIntOffsetsExtractor.

Made related changes to OPCODE macros and their use.

CMakeLists.txt:
DerivedSources.make:
GNUmakefile.am:
GNUmakefile.list.am:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.vcxproj/copy-files.cmd:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/BytecodeList.json: Added.
bytecode/Opcode.h:

(JSC::padOpcodeName):

generate-bytecode-files: Added.
llint/LLIntCLoop.cpp:

(JSC::LLInt::CLoop::initialize):

llint/LLIntCLoop.h:
llint/LLIntData.cpp:

(JSC::LLInt::initialize):

llint/LLIntOpcode.h:
llint/LowLevelInterpreter.asm:

Source/WebKit:

Added ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR} to WebKit_INCLUDE_DIRECTORIES due to new
generated Bytecodes.h include file.

CMakeLists.txt:

Source/WebKit2:

Added ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR} to WebKit2_INCLUDE_DIRECTORIES due to new
generated Bytecodes.h include file.

CMakeLists.txt:

11:44 AM Changeset in webkit [164731] by Simon Fraser

2 edits in trunk/Source/WebKit2

Fix MiniBrowser/WebKitTestRunner link errors; WKView still
needs to be exported while these tools are using it.

UIProcess/API/Cocoa/WKView.h:

11:34 AM Changeset in webkit [164730] by Joseph Pecoraro

12 edits in trunk

Web Inspector: Remove console.profiles from window.console API
https://bugs.webkit.org/show_bug.cgi?id=116883

Reviewed by Timothy Hatcher.

Source/WebCore:

console.profiles has been removed or never implemented by other
browsers. We should remove it as well. However, since tests
rely on it, keep it as window.internals.consoleProfiles.

WebCore.exp.in:
page/Console.idl:
testing/Internals.cpp:

(WebCore::Internals::consoleProfiles):

testing/Internals.h:
testing/Internals.idl:

Source/WebKit:

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

LayoutTests:

fast/profiler/resources/profiler-test-JS-resources.js:

(printHeavyProfilesDataWithoutTime):
(printProfilesDataWithoutTime):

11:22 AM Changeset in webkit [164729] by Simon Fraser

2 edits in trunk/Source/WebKit2

Fix the iOS build by wrapping some context menu stuff in #if ENABLE(CONTEXT_MENUS)

UIProcess/WebPageProxy.h:

11:17 AM Changeset in webkit [164728] by barraclough@apple.com

2 edits in trunk/Source/WTF

FastMalloc should use vm_page_shift intead of PAGE_SHIFT.
https://bugs.webkit.org/show_bug.cgi?id=129370

Reviewed by Geoff Garen.

Previously we used PAGE_SHIFT to initialize kPageShift.
Since this was a constant, it could be used to calculate other
contants used in the code. Some of these values are used in the
definition of certain data structures (specifiying the length of
some array members).

Make kPageShift & dependent properties variables setup during
initialization. Add upper bound values (K_PAGE_SHIFT_MAX,
K_NUM_CLASSES_MAX) for use in cases where we need a constant.

wtf/FastMalloc.cpp:

(WTF::InitSizeClasses):

initialize kPageShift, kNumClasses, kPageSize, kMaxValidPages.

(WTF::pages):

added ASSERT.

(WTF::AllocationSize):

added ASSERT.

(WTF::TCMalloc_PageHeap::FreeBytes):

added ASSERT.

(WTF::TCMalloc_PageHeap::init):

COMPILE_ASSERT -> ASSERT

(WTF::TCMalloc_PageHeap::scavenge):

added ASSERT.

(WTF::TCMalloc_PageHeap::Carve):

added ASSERT.

(WTF::mergeDecommittedStates):

added ASSERT.

(WTF::TCMalloc_PageHeap::IncrementalScavenge):

added ASSERT.

(WTF::TCMalloc_PageHeap::ReturnedBytes):

added ASSERT.

(WTF::PagesToMB):

added ASSERT.

(WTF::TCMalloc_PageHeap::GrowHeap):

added ASSERT.

(WTF::TCMalloc_PageHeap::ReleaseFreeList):

kNumClasses -> K_NUM_CLASSES_MAX

(WTF::TCMalloc_ThreadCache::enumerateFreeObjects):

added ASSERT.

(WTF::TCMalloc_Central_FreeList::Init):

added ASSERT.

(WTF::TCMalloc_Central_FreeList::ReleaseToSpans):

added ASSERT.

(WTF::TCMalloc_Central_FreeList::EvictRandomSizeClass):

added ASSERT.

(WTF::TCMalloc_Central_FreeList::MakeCacheSpace):

added ASSERT.

(WTF::TCMalloc_Central_FreeList::InsertRange):

added ASSERT.

(WTF::TCMalloc_Central_FreeList::Populate):

added ASSERT.

(WTF::TCMalloc_ThreadCache::Init):

added ASSERT.

(WTF::TCMalloc_ThreadCache::Cleanup):

added ASSERT.

(WTF::TCMalloc_ThreadCache::Scavenge):

added ASSERT.

(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):

added ASSERT.

11:16 AM Changeset in webkit [164727] by mhahnenberg@apple.com

2 edits in trunk/Tools

runscript: line 42: /bin/ls: Argument list too long
https://bugs.webkit.org/show_bug.cgi?id=129376

Reviewed by Michael Saboff.

The "test_script_*" can expand to more things than can be passed as arguments on the command line.
We should use find instead, which generates the list of files rather than expanding them all on
the command line and spitting them back out.

Scripts/jsc-stress-test-helpers/shell-runner.sh:

11:05 AM Changeset in webkit [164726] by commit-queue@webkit.org

42 edits
2 copies in trunk/Source

Create SessionID value-style class for session IDs.
https://bugs.webkit.org/show_bug.cgi?id=129141

Source/WebCore:

Patch by Martin Hock <mhock@apple.com> on 2014-02-26
Reviewed by Sam Weinig.

GNUmakefile.list.am:
WebCore.exp.in:
WebCore.xcodeproj/project.pbxproj:
page/Page.cpp: Add SessionID member.

(WebCore::Page::Page):
(WebCore::Page::sessionID): Retrieve sessionID or use settings if not set.

page/Page.h:

(WebCore::Page::isSessionIDSet):
(WebCore::Page::setSessionID):

page/SessionID.h: Session ID class consisting solely of its uint64_t session ID.

(WebCore::SessionID::SessionID):
(WebCore::SessionID::isValid): Not empty.
(WebCore::SessionID::isEphemeral):
(WebCore::SessionID::sessionID):
(WebCore::SessionID::operator==): Value-based equality.
(WebCore::SessionID::operator!=):
(WebCore::SessionID::emptySessionID): Zero value also used for HashTraits emptyValue.
(WebCore::SessionID::defaultSessionID):
(WebCore::SessionID::legacyPrivateSessionID):

page/SessionIDHash.h:

(WTF::SessionIDHash::hash): Just the casted session ID (low order bytes)
(WTF::SessionIDHash::equal):
(WTF::HashTraits<WebCore::SessionID>::emptyValue): Equal to emptySessionID.
(WTF::HashTraits<WebCore::SessionID>::constructDeletedValue): -1 value.
(WTF::HashTraits<WebCore::SessionID>::isDeletedValue):

Source/WebKit2:

The below changes deal solely with mechanical changes to use the SessionID value class instead of uint64_t except where noted.

Patch by Martin Hock <mhock@apple.com> on 2014-02-26
Reviewed by Sam Weinig.

NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::storageSession):
(WebKit::NetworkConnectionToWebProcess::startDownload):
(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
(WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
(WebKit::NetworkConnectionToWebProcess::cookiesEnabled):
(WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue):
(WebKit::NetworkConnectionToWebProcess::getRawCookies):
(WebKit::NetworkConnectionToWebProcess::deleteCookie):

NetworkProcess/NetworkConnectionToWebProcess.h:
NetworkProcess/NetworkConnectionToWebProcess.messages.in:
NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::ensurePrivateBrowsingSession):
(WebKit::NetworkProcess::destroyPrivateBrowsingSession):

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkProcess.messages.in:
NetworkProcess/NetworkResourceLoader.h:
NetworkProcess/RemoteNetworkingContext.h:
NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):

NetworkProcess/soup/RemoteNetworkingContextSoup.cpp:

(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):

Shared/Network/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::NetworkResourceLoadParameters):

Shared/Network/NetworkResourceLoadParameters.h:
Shared/SessionTracker.cpp:

(WebKit::staticSessionMap):
(WebKit::storageSessionToID):
(WebKit::SessionTracker::sessionMap):
(WebKit::SessionTracker::session):
(WebKit::SessionTracker::sessionID):
(WebKit::SessionTracker::setSession):
(WebKit::SessionTracker::destroySession):

Shared/SessionTracker.h: Move code to SessionID class.
Shared/WebCoreArgumentCoders.cpp: Add encode and decode for SessionID.

(IPC::ArgumentCoder<SessionID>::encode):
(IPC::ArgumentCoder<SessionID>::decode):

Shared/WebCoreArgumentCoders.h:
Shared/mac/CookieStorageShim.mm:

(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL):

UIProcess/APISession.cpp:

(API::generateID):
(API::Session::defaultSession):
(API::Session::legacyPrivateSession):
(API::Session::Session):
(API::Session::isEphemeral):
(API::Session::getID):

UIProcess/APISession.h:
UIProcess/WebContext.cpp:

(WebKit::WebContext::setAnyPageGroupMightHavePrivateBrowsingEnabled):
(WebKit::WebContext::createNewWebProcess):

UIProcess/WebContext.h:
UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::sessionID):

WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setPrivateBrowsingEnabled):

WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::scheduleLoad):

WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::loadResourceSynchronously):

WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::storageSession):

WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:

(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::storageSession):

WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
WebProcess/WebPage/WebPage.cpp: Move sessionID to Page to allow WebCore to access it.

(WebKit::WebPage::WebPage):
(WebKit::WebPage::sessionID):
(WebKit::WebPage::isUsingEphemeralSession):
(WebKit::WebPage::setSessionID):
(WebKit::WebPage::updatePreferences):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebProcess.cpp:

(WebKit::WebProcess::ensurePrivateBrowsingSession):
(WebKit::WebProcess::destroyPrivateBrowsingSession):

WebProcess/WebProcess.h:
WebProcess/WebProcess.messages.in:

10:59 AM Changeset in webkit [164725] by andersca@apple.com

3 edits
1 delete in trunk/Source/WebKit2

Get rid of WKViewIOS.mm
https://bugs.webkit.org/show_bug.cgi?id=129378

Reviewed by Simon Fraser.

UIProcess/API/Cocoa/WKView.h:
UIProcess/API/ios/WKViewIOS.mm: Removed.
WebKit2.xcodeproj/project.pbxproj:

10:48 AM Changeset in webkit [164724] by eric.carlson@apple.com

2 edits in trunk/Source/WebCore

Fix builds that don't define IMAGE_CONTROLS.

page/ContextMenuContext.cpp:

(WebCore::ContextMenuContext::ContextMenuContext):

10:36 AM Changeset in webkit [164723] by eric.carlson@apple.com

2 edits in trunk/Source/WebCore

Build fix for OS X after r164720.

page/ContextMenuContext.cpp:

10:35 AM Changeset in webkit [164722] by Martin Robinson

2 edits in trunk/Tools

ENABLE_PROMISES is improperly specified as ENABLE_PROMISE in Features.pm
https://bugs.webkit.org/show_bug.cgi?id=129377

Reviewed by Csaba Osztrogonác.

Scripts/webkitperl/FeatureList.pm: Properly specify the promises feature as ENABLE_PROMISES.

10:15 AM Changeset in webkit [164721] by ap@apple.com

2 edits in trunk/Source/WebKit2

[iOS] Remove some erroneously captured blocks
https://bugs.webkit.org/show_bug.cgi?id=129362

Reviewed by Sam Weinig.

Remove unused captured Objective-C block variables (capturing these doesn't work anyway).

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView requestAutocorrectionRectsForString:withCompletionHandler:]):
(-[WKContentView requestAutocorrectionContextWithCompletionHandler:]):

10:02 AM Changeset in webkit [164720] by beidson@apple.com

17 edits
4 adds in trunk/Source

Pipe experimental image controls menu up to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=129339

Reviewed by Simon Fraser.

Source/WebCore:

Handle events for the image control, starting down the context menu code path if appropriate:

html/shadow/mac/ImageControlsRootElementMac.cpp:

(WebCore::ImageControlsRootElementMac::defaultEventHandler):

html/shadow/mac/ImageControlsRootElementMac.h:

Add a class to hold a HitTestResult and addition info about the current ContextMenu invocation:

page/ContextMenuContext.cpp: Added.

(WebCore::ContextMenuContext::ContextMenuContext):

page/ContextMenuContext.h: Added.

(WebCore::ContextMenuContext::hitTestResult):
(WebCore::ContextMenuContext::isImageControl):

Update ContextMenuController to work with ContextMenuContext instead of HitTestResult directly:

page/ContextMenuController.cpp:

(WebCore::ContextMenuController::showContextMenu):
(WebCore::ContextMenuController::createContextMenu):
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::addInspectElementItem):
(WebCore::ContextMenuController::checkOrEnableIfNeeded):
(WebCore::ContextMenuController::showImageControlsMenu):

page/ContextMenuController.h:

(WebCore::ContextMenuController::contextMenu):
(WebCore::ContextMenuController::setContextMenuContext):
(WebCore::ContextMenuController::context):
(WebCore::ContextMenuController::hitTestResult):

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

Add a WebKit object to represent the data from a ContextMenuContext object that can be shared via IPC:

Shared/ContextMenuContextData.cpp: Added.

(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::encode):
(WebKit::ContextMenuContextData::decode):

Shared/ContextMenuContextData.h: Added.

(WebKit::ContextMenuContextData::webHitTestResultData):
(WebKit::ContextMenuContextData::isImageControl):

Update the rest of WK2 to use this object instead of WebHitTestResult::Data directly:

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showContextMenu):
(WebKit::WebPageProxy::internalShowContextMenu): Also make an ENABLE(IMAGE_CONTROLS) change here.

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:

WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::show):

CMakeLists.txt:
GNUmakefile.list.am:
WebKit2.xcodeproj/project.pbxproj:

10:00 AM Changeset in webkit [164719] by svillar@igalia.com

5 edits in trunk/LayoutTests

[CSS Grid Layout] Check default getComputedStyle() return values for grid properties
https://bugs.webkit.org/show_bug.cgi?id=129092

Reviewed by Darin Adler.

Added checks for several CSS Grid Layout properties. According to
the specs, the ones we have implemented so far should be all of
them "auto" but grid-template-{rows|columns}, grid-auto-flow and
grid-template-areas that should be "none" by default.

fast/css/getComputedStyle/computed-style-expected.txt:
fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
fast/css/getComputedStyle/resources/property-names.js:
svg/css/getComputedStyle-basic-expected.txt:

9:54 AM Changeset in webkit [164718] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

REGRESSION(r162947): Document::topDocument() returns an incorrect reference for cached Documents
https://bugs.webkit.org/show_bug.cgi?id=128175

Reviewed by Antti Koivisto.

dom/Document.cpp:

(WebCore::Document::topDocument): Fall back to pre-r162947 way of determining the top document
when the Document is in page cache or is in the middle of having its render tree destroyed.
In the first case, the determined top document is actually the document currently loaded in the
Frame to which the cached document is still connected, which is obviously not desired. In the
second case the top document is similarly incorrectly deduced, leading to non-deletion of the
proper top document's AXObjectCache. Because of this AccessibilityRenderObjects are not detached
which results in assertions in RenderObject destructor where the objects are found to be still
flagged as in use by the AX cache.

8:42 AM Changeset in webkit [164717] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

ASSERTION FAILED: m_heap->vm()->currentThreadIsHoldingAPILock() in inspector-protocol/*.
<https://webkit.org/b/129364>

Reviewed by Alexey Proskuryakov.

InjectedScriptModule::ensureInjected() needs an APIEntryShim.

inspector/InjectedScriptModule.cpp:

(Inspector::InjectedScriptModule::ensureInjected):

Added the needed but missing APIEntryShim.

7:12 AM WebKitGTK/2.4.x edited by desrt@desrt.ca

add missing libgen.h bug to 'changes on track' (diff)

6:01 AM Changeset in webkit [164716] by mihnea@adobe.com

2 edits in trunk/Source/WebCore

[CSSRegions] Remove unused method RenderFlowThread::updateLayerToRegionMappings()
https://bugs.webkit.org/show_bug.cgi?id=129368

Reviewed by Andrei Bucur.

Remove unused code, no new tests.

rendering/RenderFlowThread.h:

5:51 AM Changeset in webkit [164715] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

WebKitFindOptions shouldn't expose WEBKIT_FIND_OPTIONS_SHOW_{OVERLAY,FIND_INDICATOR,HIGHLIGHT}
https://bugs.webkit.org/show_bug.cgi?id=129263

Patch by Enrique Ocaña González <eocanha@igalia.com> on 2014-02-26
Reviewed by Sergio Villar Senin.

Avoided the need of WEBKIT_FIND_OPTIONS_SHOW_* fields by changing the semantics
of the findOptions field in WebKitFindOptions.

UIProcess/API/gtk/WebKitFindController.cpp: Now

_WebKitFindControllerPrivate.findOptions is interpreted as WebKit::FindOptions
instead of WebKitFindOptions like before. Now the conversion has to be done in
both ways.
(toWebKitFindOptions): Added conversion function from WebKit::FindOptions to
WebKitFindOptions.
(webkit_find_controller_get_options):
(webKitFindControllerPerform):
(webkit_find_controller_search):
(webkit_find_controller_search_next):
(webkit_find_controller_search_previous):
(webkit_find_controller_count_matches):

UIProcess/API/gtk/WebKitFindController.h: Removed values that shouldn't be

exposed.

5:40 AM Changeset in webkit [164714] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

Inspector server should be enabled only when the web sockets is enabled too.
https://bugs.webkit.org/show_bug.cgi?id=129304

Patch by Gergo Balogh <gbalogh.u-szeged@partner.samsung.com> on 2014-02-26
Reviewed by Csaba Osztrogonác.

config.h:

3:32 AM Changeset in webkit [164713] by Manuel Rego Casasnovas

3 edits in trunk/Tools

[GTK] Re-enable gtk-doc in EWS
https://bugs.webkit.org/show_bug.cgi?id=128369

Reviewed by Carlos Garcia Campos.

Enable again gtk-doc generation in EWS once bug #128417 has been fixed.

Scripts/webkitpy/common/config/ports.py:

(GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
(GtkWK2Port.build_webkit_command): Ditto.

Scripts/webkitpy/common/config/ports_unittest.py:

(DeprecatedPortTest.test_gtk_port): Ditto.
(DeprecatedPortTest.test_gtk_wk2_port): Ditto.

3:24 AM Changeset in webkit [164712] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2

Merge r164583 - Remove unused error.h header.
https://bugs.webkit.org/show_bug.cgi?id=126774

Patch by Koop Mast <kwm@FreeBSD.org> on 2014-02-24
Reviewed by Anders Carlsson.

This header doesn't exists on FreeBSD. According to
https://www.gnu.org/software/gnulib/manual/html_node/error_002eh.html
the function that this header implements are not present in the file.
So there isn't any need for this header.

NetworkProcess/unix/NetworkProcessMainUnix.cpp:

3:19 AM WebKitGTK/2.4.x edited by Carlos Garcia Campos

(diff)

3:16 AM WebKitGTK/2.4.x edited by Carlos Garcia Campos

(diff)

1:41 AM Changeset in webkit [164711] by calvaris@igalia.com

5 edits in trunk

[GTK] Regression when showing the captions menu
https://bugs.webkit.org/show_bug.cgi?id=129106

Reviewed by Martin Robinson.

Source/WebCore:

In some cases, when clicking the captions button the menu was not
shown.

Updated test: media/video-controls-captions-trackmenu.html

Modules/mediacontrols/mediaControlsGtk.js:

(ControllerGtk.prototype.buildCaptionMenu):
(ControllerGtk.prototype.showCaptionMenu): Specify sizes in
pixels.

LayoutTests:

Checked in an existing test that the menu is shown then the
captions button is clicked.

media/trackmenu-test.js:

(startTrackMenuTest): Deactivated animations

media/video-controls-captions-trackmenu.html: Added check for

the regression we are testing.

1:02 AM Changeset in webkit [164710] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit2

Unreviewed. Fix GTK+ build after r164702.

UIProcess/DrawingAreaProxy.cpp:

12:42 AM Changeset in webkit [164709] by bshafiei@apple.com

5 edits in branches/safari-537.75-branch/Source

Versioning.

12:37 AM Changeset in webkit [164708] by bshafiei@apple.com

1 copy in tags/Safari-537.75.2

New tag.

12:26 AM Changeset in webkit [164707] by rniwa@webkit.org

7 edits in trunk/Source/WebCore

Avoid unnecessary HTML Collection invalidations for id and name attribute changes
https://bugs.webkit.org/show_bug.cgi?id=129361

Reviewed by Benjamin Poulain.

Before this patch, setting id and name attributes resulted in traversing all the ancestors to invalidate
HTML collections on those nodes whenever we had more than one HTMLCollection alive.

Avoid the traversal when HTMLCollections don't have any valid id and name map caches by making each
HTMLCollection explicitly call collectionCachedIdNameMap and collectionWillClearIdNameMap when it caches
or clears the id and name map.

Inspired by https://chromium.googlesource.com/chromium/blink/+/5b06b91b79098f7d42e480f85be32198315d2440

dom/Document.cpp:

(WebCore::Document::registerCollection): Takes a boolean to indicate whether collection has a valid cache
for the id and name map.
(WebCore::Document::unregisterCollection): Ditto.
(WebCore::Document::collectionCachedIdNameMap): Added.
(WebCore::Document::collectionWillClearIdNameMap): Added.

dom/Document.h:

dom/NodeRareData.h:

(WebCore::NodeListsNodeData::adoptDocument): Call invalidateCache on HTML collections after, not before,
calling unregisterCollection and registerCollection since collections' owner nodes have already been
moved to the new document here and invalidateCache uses owner node's document to call
collectionWillClearIdNameMap. So calling invalidateCache before calling unregister/registerCollection
would result in collectionWillClearIdNameMap getting called on a wrong document.

html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::~HTMLCollection):
(WebCore::HTMLCollection::invalidateCache):
(WebCore::HTMLCollection::invalidateIdNameCacheMaps): Added the code to uncount itself from the number
of live node lists and HTML collections that need to be invalidated upon id and name attribute changes.
(WebCore::HTMLCollection::updateNameCache):

html/HTMLCollection.h:

(WebCore::HTMLCollection::invalidateCache):
(WebCore::HTMLCollection::hasIdNameCache): Renamed from hasNameCache.
(WebCore::HTMLCollection::setHasIdNameCache): Renamed from setHasIdNameCache.

html/HTMLFormControlsCollection.cpp:

(WebCore::HTMLFormControlsCollection::updateNameCache):

12:23 AM Changeset in webkit [164706] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.4/Source/WTF

Merge r164220 - Enable DFG_JIT on FreeBSD
https://bugs.webkit.org/show_bug.cgi?id=128898

Patch by Ryan Lortie <desrt@desrt.ca> on 2014-02-17
Reviewed by Csaba Osztrogonác.

wtf/Platform.h:

12:12 AM Changeset in webkit [164705] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

Merge r163534 - Use system default compiler instead of gcc, as final fall through.
https://bugs.webkit.org/show_bug.cgi?id=126773

Patch by Koop Mast <kwm@FreeBSD.org> on 2014-02-06
Reviewed by Alexey Proskuryakov.

dom/make_names.pl:

12:12 AM WebKitGTK/2.4.x edited by Carlos Garcia Campos

(diff)

12:11 AM Changeset in webkit [164704] by commit-queue@webkit.org

6 edits in trunk

[GTK] generate-gtkdoc can fail with WebKit1 or WebKit2 only builds
https://bugs.webkit.org/show_bug.cgi?id=129319

Patch by Martin Robinson <mrobinson@igalia.com> on 2014-02-26
Reviewed by Carlos Garcia Campos.

Source/WebKit/gtk:

GNUmakefile.am: Do not generate the documentation configuration file if the port

is disabled.

Source/WebKit2:

GNUmakefile.am: Do not generate the documentation configuration file if the port

is disabled.

Tools:

gtk/generate-gtkdoc:

(get_generator_for_config): Properly handle the situation where the pkgconfig file is missing.

12:06 AM WebKitGTK/2.4.x edited by Carlos Garcia Campos

(diff)

Feb 25, 2014:

11:53 PM Changeset in webkit [164703] by Carlos Garcia Campos

3 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2

Merge r164578 - [GTK] Remove unneeded method webkitWebViewBaseRequestExitFullScreen
https://bugs.webkit.org/show_bug.cgi?id=129245

Reviewed by Sergio Villar Senin.

UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseKeyPressEvent): Call FullscreenManager::requestExitFullScreen() directly.

UIProcess/API/gtk/WebKitWebViewBasePrivate.h:

11:43 PM Changeset in webkit [164702] by benjamin@webkit.org

22 edits
5 adds in trunk/Source/WebKit2

[iOS][WK2] Split the rects/scale updates in 3 internally consistent groups
https://bugs.webkit.org/show_bug.cgi?id=129354

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-25
Reviewed by Sam Weinig.

During scaling, the scale and rect of UIScrollView, WebPageProxy, DrawingAreaProxy,
DrawingArea and WebPage were in completely inconsistent states.

Some of those disconnect were temporary (like when setting the rect and scale in two different
messages), some were lasting the time of a tile update (like the UIProcess view of the scale).
This was causing various visual glitches.

To fix this, all the updates from the UIProcess are funneled through a single path and the values
are split into 3 different groups/types.
When updating the scale/rects, the UIProcess sends the new information to the WebProcess on a queue
through ViewUpdateDispatcher. There, the updates are accumulated until the MainThread is available.
Once the main thread is "unblocked" from the previous frame, all the data are updated at once from
the last known state in ViewUpdateDispatcher. The new tiles are created for the new converage information
and they are sent to the UIProcess.

At any point, there are 3 types of scale and rects used for different purpose:
-In the UIProcess, there is the UIScrollView scale and rects which represent the "true" state or what

is currently on screen.
That information is mirrored into WebPageProxy for the other classes needing it like DrawingAreaProxy.

-In the WebProcess, there is the last known state. That state is always lagging a little behind the "true"

state.

-Back in the UIProcess, we have the tile states that is attached to RemoteLayerTreeTransaction. It is used

to setup the rendering.

With this change, there are two paths for updating the page scale factor:
-The UI drives the change, the updates goes WKWebView->WKContentView->WebPageProxy->ViewUpdateDispatcher

->WebPage->RemoteLayerTreeDrawingArea->RemoteLayerTreeDrawingAreaProxy->WKContentView->WKWebView.

-If changes in the content force scaling parameters, the updates goes: WebPage->RemoteLayerTreeDrawingArea

->RemoteLayerTreeDrawingAreaProxy->WKContentView->WKWebView.

The two kind of updates frequently conflicts during loading. We differentiate those through the flag
scaleWasSetByUIProcess passed with the updates. In cases of conflicts, the user always wins.

DerivedSources.make:
Scripts/webkit2/messages.py:

(struct_or_class):

Shared/VisibleContentRectUpdateInfo.cpp: Added.

(WebKit::VisibleContentRectUpdateInfo::encode):
(WebKit::VisibleContentRectUpdateInfo::decode):

Shared/VisibleContentRectUpdateInfo.h: Added.

(WebKit::VisibleContentRectUpdateInfo::VisibleContentRectUpdateInfo):
(WebKit::VisibleContentRectUpdateInfo::exposedRect):
(WebKit::VisibleContentRectUpdateInfo::unobscuredRect):
(WebKit::VisibleContentRectUpdateInfo::scale):
(WebKit::operator==):

Shared/mac/RemoteLayerTreeTransaction.h:

(WebKit::RemoteLayerTreeTransaction::scaleWasSetByUIProcess):
(WebKit::RemoteLayerTreeTransaction::setScaleWasSetByUIProcess):

Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView contentView:didCommitLayerTree:WebKit::]):
(-[WKWebView _didFinishScrolling]):
(-[WKWebView scrollViewDidScroll:]):
(-[WKWebView scrollViewDidZoom:]):
(-[WKWebView scrollViewDidEndZooming:withView:atScale:]):
(-[WKWebView _frameOrBoundsChanged]):
(-[WKWebView _updateVisibleContentRectsWithStableState:]):
(-[WKWebView _setObscuredInsets:]):
(-[WKWebView _endInteractiveObscuredInsetsChange]):

UIProcess/API/ios/WKViewIOS.mm:

(-[WKView _updateVisibleContentRects]):

UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::DrawingAreaProxy):
(WebKit::DrawingAreaProxy::setCustomFixedPositionRect):

UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::updateDebugIndicator):

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::displayedContentScale):
(WebKit::WebPageProxy::exposedContentRect):
(WebKit::WebPageProxy::unobscuredContentRect):

UIProcess/ios/WKContentView.h:
UIProcess/ios/WKContentView.mm:

(-[WKContentView didUpdateVisibleRect:unobscuredRect:scale:inStableState:]):
(-[WKContentView didFinishScrolling]):
(-[WKContentView didZoomToScale:]):

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::updateVisibleContentRects):

UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::scaledExposedRect):
(WebKit::RemoteLayerTreeDrawingAreaProxy::indicatorLocation):
(WebKit::RemoteLayerTreeDrawingAreaProxy::indicatorScale):
(WebKit::RemoteLayerTreeDrawingAreaProxy::updateDebugIndicator):

WebKit2.xcodeproj/project.pbxproj:
WebProcess/WebPage/ViewUpdateDispatcher.cpp: Added.

(WebKit::ViewUpdateDispatcher::create):
(WebKit::ViewUpdateDispatcher::ViewUpdateDispatcher):
(WebKit::ViewUpdateDispatcher::~ViewUpdateDispatcher):
(WebKit::ViewUpdateDispatcher::initializeConnection):
(WebKit::ViewUpdateDispatcher::visibleContentRectUpdate):
(WebKit::ViewUpdateDispatcher::dispatchVisibleContentRectUpdate):

WebProcess/WebPage/ViewUpdateDispatcher.h: Added.
WebProcess/WebPage/ViewUpdateDispatcher.messages.in: Added.
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::scalePage):

WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::scaleWasSetByUIProcess):

WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::tapHighlightAtPosition):
(WebKit::WebPage::updateVisibleContentRects):
(WebKit::WebPage::willStartUserTriggeredZooming):

WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::flushLayers):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeConnection):

WebProcess/WebProcess.h:

11:35 PM Changeset in webkit [164701] by Mihai Maerean

2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

10:52 PM Changeset in webkit [164700] by fred.wang@free.fr

6 edits
4 adds in trunk

Add support for minsize/maxsize attributes.
https://bugs.webkit.org/show_bug.cgi?id=122567

Reviewed by Chris Fleizach.

Source/WebCore:

This change implements the minsize/maxsize attributes of the mo element.
We also switch stretch sizes from int to LayoutUnit to improve accuracy.

Tests: mathml/presentation/stretchy-minsize-maxsize-dynamic.html

mathml/presentation/stretchy-minsize-maxsize.html

rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::SetOperatorProperties):
(WebCore::RenderMathMLOperator::stretchTo):

rendering/mathml/RenderMathMLOperator.h:
rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::layout):

LayoutTests:

Add some reftests for the minsize/maxsize attributes of the mo element.

platform/mac/mathml/presentation/mo-stretch-expected.txt:
mathml/presentation/stretchy-minsize-maxsize-dynamic-expected.html: Added.
mathml/presentation/stretchy-minsize-maxsize-dynamic.html: Added.
mathml/presentation/stretchy-minsize-maxsize-expected.html: Added.
mathml/presentation/stretchy-minsize-maxsize.html: Added.

10:43 PM Changeset in webkit [164699] by mihnea@adobe.com

5 edits in trunk/Source/WebCore

[CSSRegions] Small clean-up of flow threads accelerated compositing code
https://bugs.webkit.org/show_bug.cgi?id=129312

Reviewed by Andrei Bucur.

Some clean-up for the code used for regions in accelerated compositing functionality:

Rename updateRenderFlowThreadLayersIfNeeded -> updateFlowThreadsLayerToRegionMappingsIfNeeded

as the function updates the mapping between the flow threads layers and their corresponding regions

Remove RenderLayerCompositor::updateRenderFlowThreadLayersIfNeeded and move the code in place

at call site since the function body does not require a dedicated function.

No new functionality, no new tests.

rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::updateFlowThreadsLayerToRegionMappingsIfNeeded):
Now that the regions are always layers, we do not need to iterate backwards.

rendering/FlowThreadController.h:
rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers):

rendering/RenderLayerCompositor.h:

10:24 PM Changeset in webkit [164698] by Alan Bujtas

2 edits in trunk/Source/WebCore

Subpixel rendering: Ensure consistent border painting width.
https://bugs.webkit.org/show_bug.cgi?id=129259

Reviewed by Simon Fraser.

Border edges are painted as (semi)independent rectangles. When snapping an edge rectangle
to device pixels, its painted dimensions depend on its size and its fractional position.
Specific combination of position and border width can result in painting edges sized differently.
Using device snapped border width to calculate inner/outer rectangles helps to maintain
uniform border width.

Currently not testable.

rendering/RenderBoxModelObject.cpp:

(WebCore::BorderEdge::BorderEdge):
(WebCore::BorderEdge::shouldRender):
(WebCore::BorderEdge::presentButInvisible):
(WebCore::BorderEdge::widthForPainting):
(WebCore::BorderEdge::getDoubleBorderStripeWidths):
(WebCore::RenderBoxModelObject::paintOneBorderSide):
(WebCore::calculateSideRect):
(WebCore::RenderBoxModelObject::paintBorderSides):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::drawBoxSideFromPath):
(WebCore::calculateSideRectIncludingInner):

10:23 PM Changeset in webkit [164697] by Alan Bujtas

15 edits in trunk/Source/WebCore

Subpixel layout: Remove explicit static_cast<LayoutUnit> conversions.
https://bugs.webkit.org/show_bug.cgi?id=129359

Reviewed by Simon Fraser.

No testable change in behavior.

css/LengthFunctions.cpp:

(WebCore::minimumValueForLength):

page/FrameView.cpp:

(WebCore::FrameView::forceLayoutForPagination):

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintFillLayer):

rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::logicalLeftVisualOverflow):
(WebCore::InlineFlowBox::logicalRightVisualOverflow):

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::isSelected):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeColumnCountAndWidth):
(WebCore::getBPMWidth):

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::adjustForBorderFit):

rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):

rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBoxDecorations):

rendering/RenderTable.h:

(WebCore::RenderTable::borderSpacingInRowDirection):

rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::preferredContentLogicalWidth):

rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::preferredContentLogicalWidth):

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::beforeAnnotationsAdjustment):
(WebCore::RootInlineBox::ascentAndDescentForBox):

rendering/svg/RenderSVGRoot.cpp:

(WebCore::resolveLengthAttributeForSVG):

10:01 PM Changeset in webkit [164696] by andersca@apple.com

5 edits in trunk/Source/WebCore

Build fixes.

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:

9:03 PM Changeset in webkit [164695] by bshafiei@apple.com

5 edits in branches/safari-537.75-branch/Source

Versioning.

8:33 PM Changeset in webkit [164694] by bshafiei@apple.com

5 edits in branches/safari-537.60-branch/Source

Versioning.

8:19 PM Changeset in webkit [164693] by bshafiei@apple.com

1 copy in tags/Safari-537.60.16

New tag.

7:51 PM Changeset in webkit [164692] by benjamin@webkit.org

2 edits in trunk/Source/WebCore

Build fix for OS X after r164690

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-25

WebCore.exp.in:

7:23 PM Changeset in webkit [164691] by andersca@apple.com

12 edits
4 moves in trunk/Source

Rename WebCore::VisitedLinkProvider to WebCore::VisitedLinkStore
https://bugs.webkit.org/show_bug.cgi?id=129357

Reviewed by Sam Weinig.

Source/WebCore:

WebCore.exp.in:
WebCore.xcodeproj/project.pbxproj:
dom/VisitedLinkState.cpp:

(WebCore::VisitedLinkState::determineLinkStateSlowCase):

loader/HistoryController.cpp:

(WebCore::addVisitedLink):

page/DefaultVisitedLinkStore.cpp: Renamed from Source/WebCore/page/DefaultVisitedLinkProvider.cpp.

(WebCore::DefaultVisitedLinkStore::create):
(WebCore::DefaultVisitedLinkStore::DefaultVisitedLinkStore):
(WebCore::DefaultVisitedLinkStore::~DefaultVisitedLinkStore):
(WebCore::DefaultVisitedLinkStore::isLinkVisited):
(WebCore::DefaultVisitedLinkStore::addVisitedLink):

page/DefaultVisitedLinkStore.h: Renamed from Source/WebCore/page/DefaultVisitedLinkProvider.h.
page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::visitedLinkStore):

page/Page.h:
page/PageGroup.cpp:

(WebCore::PageGroup::visitedLinkStore):

page/PageGroup.h:
page/VisitedLinkStore.cpp: Renamed from Source/WebCore/page/VisitedLinkProvider.cpp.

(WebCore::VisitedLinkStore::VisitedLinkStore):
(WebCore::VisitedLinkStore::~VisitedLinkStore):

page/VisitedLinkStore.h: Renamed from Source/WebCore/page/VisitedLinkProvider.h.

Source/WebKit2:

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

WebProcess/WebPage/WebVisitedLinkProvider.h:

7:05 PM Changeset in webkit [164690] by enrica@apple.com

15 edits
2 adds in trunk/Source

[WebKit2] Form controls handling.
https://bugs.webkit.org/show_bug.cgi?id=129344
<rdar://problem/16053643>

Reviewed by Simon Fraser and Joseph Pecoraro.

../WebCore:

Adding some exports.

WebCore.exp.in:

../WebKit2:

This is the step toward adding support for
form controls iOS style. It adds the logic to
select the appropriate keyboard type based on the
element type and introduces the AssistedNodeInformation
structure used currently for the keyboard type selection
and that will be used to populate pickers and popovers.
It also provides information to enable/disable next/previous
buttons in the accessory view.

Scripts/webkit2/messages.py:

(struct_or_class):

Shared/AssistedNodeInformation.cpp: Added.

(WebKit::AssistedNodeInformation::encode):
(WebKit::AssistedNodeInformation::decode):

Shared/AssistedNodeInformation.h: Added.

(WebKit::AssistedNodeInformation::AssistedNodeInformation):

UIProcess/PageClient.h:
UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/ios/PageClientImplIOS.h:
UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::startAssistingNode):

UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _requiresKeyboardWhenFirstResponder]):
(-[WKContentView _updateAccessory]):
(toUITextAutocapitalize):
(-[WKContentView textInputTraits]):
(-[WKContentView assistedNodeInformation]):
(-[WKContentView _startAssistingNode:]):
(-[WKContentView _stopAssistingNode]):

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::startAssistingNode):

WebKit2.xcodeproj/project.pbxproj:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::isAssistableNode):
(WebKit::hasFocusableNode):
(WebKit::WebPage::getAssistedNodeInformation):
(WebKit::WebPage::elementDidFocus):

6:50 PM Changeset in webkit [164689] by commit-queue@webkit.org

1 edit
5 adds
4 deletes in trunk/LayoutTests

Web Inspector: Port some profiler tests to inspector-protocol
https://bugs.webkit.org/show_bug.cgi?id=129353

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-02-25
Reviewed by Timothy Hatcher.

inspector-obsolete/profiler/cpu-profiler-parameterless-profile-end-crash-expected.txt: Removed.
inspector-obsolete/profiler/cpu-profiler-parameterless-profile-end-crash.html: Removed.
inspector-obsolete/profiler/cpu-profiler-profiling-without-inspector-expected.txt: Removed.
inspector-obsolete/profiler/cpu-profiler-profiling-without-inspector.html: Removed.
inspector-protocol/profiler/console-profile-expected.txt: Added.
inspector-protocol/profiler/console-profile.html: Added.
inspector-protocol/profiler/console-profileEnd-parameterless-expected.txt: Added.
inspector-protocol/profiler/console-profileEnd-parameterless.html: Added.

6:28 PM Changeset in webkit [164688] by Brent Fulgham

3 edits in branches/safari-537.60-branch/Source/WebCore

Merge r164660

2014-02-25 Brent Fulgham <Brent Fulgham>

[Win] Gracefully recover from missing 'naturalSize' parameter for media
https://bugs.webkit.org/show_bug.cgi?id=129278

Reviewed by Eric Carlson.

platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Add declaration for missing function call.
platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: (WebCore::createMetadataKeyNames): (WebCore::MediaPlayerPrivateAVFoundationCF::assetStatus): Don't treat missing 'naturalSize' as a fatal error. (WebCore::MediaPlayerPrivateAVFoundationCF::tracksChanged): Handle case of asset track not being available yet. (WebCore::MediaPlayerPrivateAVFoundationCF::sizeChanged): If the 'naturalSize' is empty, use the Player Item's 'presentationSize' instead. (WebCore::AVFWrapper::processNotification): Add missing handler for duration changed.

6:12 PM Changeset in webkit [164687] by mark.lam@apple.com

3 edits in trunk/Source/JavaScriptCore

Web Inspector: CRASH when evaluating in console of JSContext RWI with disabled breakpoints.
<https://webkit.org/b/128766>

Reviewed by Geoffrey Garen.

Make the JSLock::grabAllLocks() work the same way as for the C loop LLINT.
The reasoning is that we don't know of any clients that need unordered
re-entry into the VM from different threads. So, we're enforcing ordered
re-entry i.e. we must re-grab locks in the reverse order of dropping locks.

The crash in this bug happened because we were allowing unordered re-entry,
and the following type of scenario occurred:

Thread T1 locks the VM, and enters the VM to execute some JS code.
On entry, T1 detects that VM::m_entryScope is null i.e. this is the first time it entered the VM. T1 sets VM::m_entryScope to T1's entryScope.
T1 drops all locks.

Thread T2 locks the VM, and enters the VM to execute some JS code. On entry, T2 sees that VM::m_entryScope is NOT null, and therefore does not set the entryScope.
T2 drops all locks.

T1 re-grabs locks.
T1 returns all the way out of JS code. On exit from the outer most JS function, T1 clears VM::m_entryScope (because T1 was the one who set it).
T1 unlocks the VM.

T2 re-grabs locks.
T2 proceeds to execute some code and expects VM::m_entryScope to be

NOT null, but it turns out to be null. Assertion failures and
crashes ensue.

With ordered re-entry, at step 6, T1 will loop and yield until T2 exits
the VM. Hence, the issue will no longer manifest.

runtime/JSLock.cpp:

(JSC::JSLock::dropAllLocks):
(JSC::JSLock::grabAllLocks):

runtime/JSLock.h:

(JSC::JSLock::DropAllLocks::dropDepth):

5:45 PM Changeset in webkit [164686] by andersca@apple.com

5 edits in trunk/Source/WebKit2

VisitedLinkProvider should be refcounted
https://bugs.webkit.org/show_bug.cgi?id=129351

Reviewed by Sam Weinig.

UIProcess/VisitedLinkProvider.cpp:

(WebKit::VisitedLinkProvider::create):
(WebKit::VisitedLinkProvider::~VisitedLinkProvider):

UIProcess/VisitedLinkProvider.h:
UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::processDidFinishLaunching):
(WebKit::WebContext::disconnectProcess):
(WebKit::WebContext::addVisitedLinkHash):

UIProcess/WebContext.h:

5:27 PM Changeset in webkit [164685] by Samuel White

7 edits in trunk

Add accessibility search predicate support for AXOutlines
https://bugs.webkit.org/show_bug.cgi?id=123748

Reviewed by Chris Fleizach.

Source/WebCore:

Added new AXOutlineSearchKey to support finding elements with aria role=tree.

No new tests, updated existing search-predicate.html test to cover AXOutlineSearchKey.

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatchAtIndex):

accessibility/AccessibilityObject.h:
accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(createAccessibilitySearchKeyMap):

LayoutTests:

Updated test to validate support for AXOutlineSearchKey (elements with aria role=tree).

platform/mac/accessibility/search-predicate-expected.txt:
platform/mac/accessibility/search-predicate.html:

5:06 PM Changeset in webkit [164684] by andersca@apple.com

5 edits in trunk/Source/WebKit2

Make WebContext handle populating visited links
https://bugs.webkit.org/show_bug.cgi?id=129348

Reviewed by Tim Horton.

This makes it possible to decouple VisitedLinkProvider from WebContext.

UIProcess/VisitedLinkProvider.cpp:

(WebKit::VisitedLinkProvider::VisitedLinkProvider):
(WebKit::VisitedLinkProvider::processDidFinishLaunching):

UIProcess/VisitedLinkProvider.h:
UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::processDidFinishLaunching):

UIProcess/WebContext.h:

5:03 PM Changeset in webkit [164683] by mark.lam@apple.com

10 edits in trunk/Source

Need to initialize VM stack data even when the VM is on an exclusive thread.
<https://webkit.org/b/129265>

Not reviewed.

Source/JavaScriptCore:

Relanding r164627 now that <https://webkit.org/b/129341> is fixed.

API/APIShims.h:

(JSC::APIEntryShim::APIEntryShim):
(JSC::APICallbackShim::shouldDropAllLocks):

heap/MachineStackMarker.cpp:

(JSC::MachineThreads::addCurrentThread):

runtime/JSLock.cpp:

(JSC::JSLockHolder::JSLockHolder):
(JSC::JSLockHolder::init):
(JSC::JSLockHolder::~JSLockHolder):
(JSC::JSLock::JSLock):
(JSC::JSLock::setExclusiveThread):
(JSC::JSLock::lock):
(JSC::JSLock::unlock):
(JSC::JSLock::currentThreadIsHoldingLock):
(JSC::JSLock::dropAllLocks):
(JSC::JSLock::grabAllLocks):

runtime/JSLock.h:

(JSC::JSLock::hasExclusiveThread):
(JSC::JSLock::exclusiveThread):

runtime/VM.cpp:

(JSC::VM::VM):

runtime/VM.h:

(JSC::VM::hasExclusiveThread):
(JSC::VM::exclusiveThread):
(JSC::VM::setExclusiveThread):
(JSC::VM::currentThreadIsHoldingAPILock):

Source/WebCore:

No new tests.

Relanding r164627 now that <https://webkit.org/b/129341> is fixed.

bindings/js/JSDOMBinding.cpp:

(WebCore::reportException):

bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::commonVM):

4:44 PM Changeset in webkit [164682] by andersca@apple.com

3 edits in trunk/Source/WebKit2

DrawingAreaProxy is using WebCore's Timer
https://bugs.webkit.org/show_bug.cgi?id=129347
<rdar://problem/16078133>

Reviewed by Tim Horton.

Use a RunLoop::Timer instead.

UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::DrawingAreaProxy):
(WebKit::DrawingAreaProxy::exposedRectChangedTimerFired):

UIProcess/DrawingAreaProxy.h:

4:38 PM Changeset in webkit [164681] by andersca@apple.com

5 edits
4 copies in trunk/Source/WebKit2

Add WKVisitedLinkProvider
https://bugs.webkit.org/show_bug.cgi?id=129343

Reviewed by Sam Weinig.

UIProcess/API/Cocoa/WKVisitedLinkProvider.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.h.
UIProcess/API/Cocoa/WKVisitedLinkProvider.mm: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.h.
UIProcess/API/Cocoa/WKVisitedLinkProviderInternal.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.h.
UIProcess/API/Cocoa/WKVisitedLinkProviderPrivate.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.h.
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):

UIProcess/API/Cocoa/WKWebViewConfiguration.h:
UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration visitedLinkProvider]):
(-[WKWebViewConfiguration setVisitedLinkProvider:]):

WebKit2.xcodeproj/project.pbxproj:

4:12 PM Changeset in webkit [164680] by Brent Fulgham

3 edits in branches/safari-537.75-branch/Source/WebCore

Merge r164660

2014-02-25 Brent Fulgham <Brent Fulgham>

[Win] Gracefully recover from missing 'naturalSize' parameter for media
https://bugs.webkit.org/show_bug.cgi?id=129278

Reviewed by Eric Carlson.

platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Add declaration for missing function call.
platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: (WebCore::createMetadataKeyNames): (WebCore::MediaPlayerPrivateAVFoundationCF::assetStatus): Don't treat missing 'naturalSize' as a fatal error. (WebCore::MediaPlayerPrivateAVFoundationCF::tracksChanged): Handle case of asset track not being available yet. (WebCore::MediaPlayerPrivateAVFoundationCF::sizeChanged): If the 'naturalSize' is empty, use the Player Item's 'presentationSize' instead. (WebCore::AVFWrapper::processNotification): Add missing handler for duration changed.

3:53 PM Changeset in webkit [164679] by mark.lam@apple.com

2 edits in trunk/Source/WebCore

JSDOMPromise methods should acquire VM lock before calling into JS.
<https://webkit.org/b/129341>

Reviewed by Geoffrey Garen.

No new tests.

bindings/js/JSDOMPromise.h:

(WebCore::DeferredWrapper::resolve):
(WebCore::DeferredWrapper::reject):
(WebCore::DeferredWrapper::resolve<String>):
(WebCore::DeferredWrapper::resolve<bool>):
(WebCore::char>>):
(WebCore::DeferredWrapper::reject<String>):

3:28 PM Changeset in webkit [164678] by andersca@apple.com

7 edits in trunk/Source

Simplify visited link style invalidation
https://bugs.webkit.org/show_bug.cgi?id=129340

Reviewed by Dan Bernstein.

Source/WebCore:

Get rid of the static Page::allVisitedStateChanged and Page::visitedStateChanged
member functions and add functions to invalidate all styles on a single page or the style
for a single link hash on a single page.

WebCore.exp.in:
page/Page.cpp:

(WebCore::Page::invalidateStylesForAllLinks):
(WebCore::Page::invalidateStylesForLink):

page/Page.h:
page/PageGroup.cpp:

(WebCore::PageGroup::addVisitedLink):
(WebCore::PageGroup::removeVisitedLink):
(WebCore::PageGroup::removeVisitedLinks):

Source/WebKit2:

UIProcess/VisitedLinkProvider.cpp:

(WebKit::VisitedLinkProvider::addVisitedLink):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::visitedLinkStateChanged):
(WebKit::WebProcess::allVisitedLinkStateChanged):

3:17 PM Changeset in webkit [164677] by akling@apple.com

8 edits in trunk/Source/WebCore

Remove unused ThreadSpecificInspectorCounters.
<https://webkit.org/b/129337>

We were keeping count of all the JS event listeners in every thread
to support an old Chromium feature that's no longer relevant.

Removing this gets rid of expensive thread-local storage lookups.

Reviewed by Anders Carlsson.

bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::~JSEventListener):

inspector/InspectorCounters.cpp:
inspector/InspectorCounters.h:
inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::setDOMCounters):

inspector/protocol/Timeline.json:
platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::destroy):

platform/ThreadGlobalData.h:

3:03 PM Changeset in webkit [164676] by Brent Fulgham

2 edits in branches/safari-537.75-branch/WebKitLibraries

Unreviewed build fix.

win/tools/vsprops/production.props: Production build needs to have 'OFFICIAL_BUILD' set

in the environment for build sub-processes.

3:02 PM Changeset in webkit [164675] by Brent Fulgham

2 edits in branches/safari-537.75-branch/Source/WTF

Unreviewed build fix.

WTF.vcxproj/work-around-vs-dependency-tracking-bugs.py: Handle unset 'WEBKIT_LIBRARIES' properly

since this is expected to be unset in the production build environmenet.

2:31 PM Changeset in webkit [164674] by lvidacs.u-szeged@partner.samsung.com

3 edits
8 adds in trunk

display:table with padding and/or borders in border-box calculates height incorrectly
https://bugs.webkit.org/show_bug.cgi?id=126576

Reviewed by David Hyatt.

Based on blink issue https://codereview.chromium.org/25206002/

Source/WebCore:

Tests: fast/box-sizing/css-table-collapse.html

fast/box-sizing/css-table-no-collapse.html
fast/box-sizing/table-collapse.html
fast/box-sizing/table-no-collapse.html

rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalHeightUsing):

LayoutTests:

fast/box-sizing/css-table-collapse-expected.txt: Added.
fast/box-sizing/css-table-collapse.html: Added.
fast/box-sizing/css-table-no-collapse-expected.txt: Added.
fast/box-sizing/css-table-no-collapse.html: Added.
fast/box-sizing/table-collapse-expected.txt: Added.
fast/box-sizing/table-collapse.html: Added.
fast/box-sizing/table-no-collapse-expected.txt: Added.
fast/box-sizing/table-no-collapse.html: Added.

2:18 PM Changeset in webkit [164673] by fpizlo@apple.com

7 edits in trunk/Source/JavaScriptCore

Inline caching in the FTL on ARM64 should "work"
https://bugs.webkit.org/show_bug.cgi?id=129334

Reviewed by Mark Hahnenberg.

Gets us to the point where simple tests that use inline caching are passing.

assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::copyCompactAndLinkCode):
(JSC::LinkBuffer::shrink):

ftl/FTLInlineCacheSize.cpp:

(JSC::FTL::sizeOfGetById):
(JSC::FTL::sizeOfPutById):
(JSC::FTL::sizeOfCall):

ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileFTLOSRExit):

ftl/FTLThunks.cpp:

(JSC::FTL::osrExitGenerationThunkGenerator):

jit/GPRInfo.h:
offlineasm/arm64.rb:

1:42 PM Changeset in webkit [164672] by andersca@apple.com

5 edits in trunk/Source/WebKit2

Fix build.

Remove VisitedLinkStrategy.

NetworkProcess/NetworkProcessPlatformStrategies.cpp:
NetworkProcess/NetworkProcessPlatformStrategies.h:
WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
WebProcess/WebCoreSupport/WebPlatformStrategies.h:

1:37 PM Changeset in webkit [164671] by ap@apple.com

2 edits in trunk/LayoutTests

inspector-protocol/page/deny-X-FrameOption.html is very flaky
https://bugs.webkit.org/show_bug.cgi?id=129331

TestExpectations: Marking as such.

1:35 PM Changeset in webkit [164670] by andersca@apple.com

18 edits
1 delete in trunk/Source

Get rid of VisitedLinkStrategy
https://bugs.webkit.org/show_bug.cgi?id=129324

Reviewed by Dan Bernstein.

Source/WebCore:

GNUmakefile.list.am:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
platform/PlatformStrategies.h:

(WebCore::PlatformStrategies::PlatformStrategies):

platform/VisitedLinkStrategy.h: Removed.

Source/WebKit/efl:

WebCoreSupport/PlatformStrategiesEfl.cpp:

(PlatformStrategiesEfl::getPluginInfo):

WebCoreSupport/PlatformStrategiesEfl.h:

Source/WebKit/gtk:

WebCoreSupport/PlatformStrategiesGtk.cpp:

(PlatformStrategiesGtk::getPluginInfo):

WebCoreSupport/PlatformStrategiesGtk.h:

Source/WebKit/mac:

WebCoreSupport/WebPlatformStrategies.h:
WebCoreSupport/WebPlatformStrategies.mm:

Source/WebKit/win:

WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::getPluginInfo):

WebCoreSupport/WebPlatformStrategies.h:

1:29 PM Changeset in webkit [164669] by ap@apple.com

42 edits
2 deletes in trunk/Source

Rolling out http://trac.webkit.org/changeset/164611, because it broke
WebKit2.PrivateBrowsingPushStateNoHistoryCallback API test

The change was for:

Source/WebCore:

https://bugs.webkit.org/show_bug.cgi?id=129141
Create SessionID class

Source/WebKit2:

https://bugs.webkit.org/show_bug.cgi?id=129141
Create SessionID class

1:24 PM Changeset in webkit [164668] by ap@apple.com

2 edits in trunk/LayoutTests

REGRESSION: All inspector-protocol/model very frequently assert in IDBRequest::~IDBRequest
https://bugs.webkit.org/show_bug.cgi?id=129328

inspector-protocol/indexeddb/basics.html fails
https://bugs.webkit.org/show_bug.cgi?id=129327

TestExpectations: Updating test expectations.

1:18 PM Changeset in webkit [164667] by commit-queue@webkit.org

10 edits in trunk/Source

Unreviewed, rolling out r164627.
http://trac.webkit.org/changeset/164627
https://bugs.webkit.org/show_bug.cgi?id=129325

Broke SubtleCrypto tests (Requested by ap on #webkit).

Source/JavaScriptCore:

API/APIShims.h:

(JSC::APIEntryShim::APIEntryShim):
(JSC::APICallbackShim::shouldDropAllLocks):

heap/MachineStackMarker.cpp:

(JSC::MachineThreads::addCurrentThread):

runtime/JSLock.cpp:

(JSC::JSLockHolder::JSLockHolder):
(JSC::JSLockHolder::init):
(JSC::JSLockHolder::~JSLockHolder):
(JSC::JSLock::JSLock):
(JSC::JSLock::lock):
(JSC::JSLock::unlock):
(JSC::JSLock::currentThreadIsHoldingLock):
(JSC::JSLock::dropAllLocks):
(JSC::JSLock::grabAllLocks):

runtime/JSLock.h:
runtime/VM.cpp:

(JSC::VM::VM):

runtime/VM.h:

(JSC::VM::currentThreadIsHoldingAPILock):

Source/WebCore:

bindings/js/JSDOMBinding.cpp:

(WebCore::reportException):

bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::commonVM):

1:10 PM Changeset in webkit [164666] by mitz@apple.com

8 edits
1 add in trunk/Source/WebKit2

[Cocoa] Add delegate method for customizing actions on activated elements
https://bugs.webkit.org/show_bug.cgi?id=129290

Reviewed by Anders Carlsson.

UIProcess/API/Cocoa/WKUIDelegatePrivate.h: Added. Declared new delegate method.

UIProcess/API/Cocoa/_WKActivatedElementInfo.h:

(_WKActivatedElementType): Defined enum of element types.

UIProcess/API/Cocoa/_WKActivatedElementInfo.mm:

(-[_WKActivatedElementInfo _initWithType:URL:location:title:rect:]): Added type parameter
to the initializer, used to set the new type property.

UIProcess/API/Cocoa/_WKActivatedElementInfoInternal.h:

UIProcess/Cocoa/UIClient.h:
UIProcess/Cocoa/UIClient.mm:

(WebKit::UIClient::setDelegate): Initialize webViewActionsForElementDefaultActions member
of m_delegateMethods.
(WebKit::UIClient::actionsForElement): Added. Calls out to the new delegate method if
implemented. Otherwise returns the default actions.

UIProcess/ios/WKActionSheetAssistant.mm:

(-[WKActionSheetAssistant actionSheet:clickedButtonAtIndex:]): Use new _elementInfo ivar
instead of creating element info here.
(-[WKActionSheetAssistant showImageSheet]): Create element info here and assign it to
_elementInfo ivar if presenting a sheet. Call the UI client to get custom actions.
(-[WKActionSheetAssistant showLinkSheet]): Ditto.
(-[WKActionSheetAssistant cleanupSheet]): Clear _elementInfo ivar.

WebKit2.xcodeproj/project.pbxproj: Added reference to WKUIDelegatePrivate.h.

12:56 PM Changeset in webkit [164665] by andersca@apple.com

2 edits in trunk/Source/WebCore

DefaultVisitedLinkProvider can just call into the page group directly
https://bugs.webkit.org/show_bug.cgi?id=129320

Reviewed by Andreas Kling.

page/DefaultVisitedLinkProvider.cpp:

(WebCore::DefaultVisitedLinkProvider::isLinkVisited):
(WebCore::DefaultVisitedLinkProvider::addVisitedLink):

12:55 PM Changeset in webkit [164664] by Michał Pakuła vel Rutka

2 edits in trunk/Source/WebKit2

Unreviewed EFL build fix attempt after r164562

CMakeLists.txt: Added WebVisitedLinkProvider.cpp.

12:48 PM Changeset in webkit [164663] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

ARM64 rshift64 should be an arithmetic shift
https://bugs.webkit.org/show_bug.cgi?id=129323

Reviewed by Mark Hahnenberg.

assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::rshift64):

12:42 PM Changeset in webkit [164662] by commit-queue@webkit.org

12 edits in trunk/Source/WebCore

Unreviewed, rolling out r164638.
http://trac.webkit.org/changeset/164638
https://bugs.webkit.org/show_bug.cgi?id=129321

Broke Windows build. (Requested by bfulgham on #webkit).

dom/ContainerNode.h:

(WebCore::ChildNodesLazySnapshot::takeSnapshot):
(WebCore::ChildNodesLazySnapshot::hasSnapshot):

dom/Element.cpp:

(WebCore::ensureAttrNodeListForElement):
(WebCore::Element::attributes):

dom/ElementIteratorAssertions.h:

(WebCore::ElementIteratorAssertions::ElementIteratorAssertions):

dom/ElementRareData.h:

(WebCore::ElementRareData::create):
(WebCore::ElementRareData::setAttributeMap):

dom/MutationObserverRegistration.cpp:

(WebCore::MutationObserverRegistration::create):
(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach):
(WebCore::MutationObserverRegistration::clearTransientRegistrations):
(WebCore::MutationObserverRegistration::addRegistrationNodesToSet):

dom/MutationObserverRegistration.h:
dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::create):
(WebCore::NamedNodeMap::NamedNodeMap):

dom/Node.cpp:

(WebCore::Node::ensureRareData):
(WebCore::Node::didMoveToNewDocument):
(WebCore::Node::ensureEventTargetData):
(WebCore::Node::mutationObserverRegistry):
(WebCore::Node::registerMutationObserver):
(WebCore::Node::unregisterMutationObserver):
(WebCore::Node::notifyMutationObserversNodeWillDetach):

dom/Node.h:
dom/NodeRareData.h:

(WebCore::NodeListsNodeData::create):
(WebCore::NodeListsNodeData::NodeListsNodeData):
(WebCore::NodeMutationObserverData::create):
(WebCore::NodeMutationObserverData::NodeMutationObserverData):
(WebCore::NodeRareData::create):
(WebCore::NodeRareData::clearNodeLists):
(WebCore::NodeRareData::ensureNodeLists):
(WebCore::NodeRareData::ensureMutationObserverData):
(WebCore::NodeRareData::NodeRareData):

dom/StyledElement.cpp:

(WebCore::StyledElement::rebuildPresentationAttributeStyle):

12:29 PM Changeset in webkit [164661] by eric.carlson@apple.com

14 edits in trunk/Source/WebCore

[iOS] Show status image when playing video to external device
https://bugs.webkit.org/show_bug.cgi?id=129277

Reviewed by Jer Noble.

Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.handleEvent): Restructure the code so it is possible to handle events

that target the video element which aren't in the HandledVideoEvents array.

Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.currentPlaybackTargetIsWireless): webkitCurrentPlaybackTargetIsWireless

is an attribute, not a function.

(ControllerIOS.prototype.updateWirelessPlaybackStatus): Fix style.
(ControllerIOS.prototype.updateWirelessTargetAvailable): Ditto.
(ControllerIOS.prototype.updateProgress): Ditto.
(ControllerIOS.prototype.handleWrapperTouchStart): Show the controls if the wireless status

display is touched.

(ControllerIOS.prototype.handleFullscreenButtonClicked): Fix style
(ControllerIOS.prototype.handleWirelessPlaybackChange): Ditto.
(ControllerIOS.prototype.handleWirelessTargetAvailableChange):
(ControllerIOS.prototype.handleWirelessPickerButtonClicked): Ditto. Stop even propagation.

Move "playback target" logic into HTMLMediaSession.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement): Call media session.
(WebCore::HTMLMediaElement::loadResource): Tell media session to apply media player

restrictions now that it has a url.

(WebCore::HTMLMediaElement::invalidateCachedTime): Only log when cached time is not

already invalie.

(WebCore::HTMLMediaElement::webkitShowPlaybackTargetPicker): Call media session.
(WebCore::HTMLMediaElement::webkitCurrentPlaybackTargetIsWireless): Ditto.
(WebCore::HTMLMediaElement::mediaPlayerCurrentPlaybackTargetIsWirelessChanged): Ditto.
(WebCore::HTMLMediaElement::addEventListener): Ditto.
(WebCore::HTMLMediaElement::removeEventListen): Ditto.
(WebCore::HTMLMediaElement::enqueuePlaybackTargetAvailabilityChangedEvent): Ditto.
(WebCore::HTMLMediaElement::createMediaPlayer): Ditto.

html/HTMLMediaSession.cpp:

(WebCore::restrictionName): Log new WirelessVideoPlaybackDisabled restriction.
(WebCore::HTMLMediaSession::showingPlaybackTargetPickerPermitted): Return false if there

is no page, or if wireless playback is disabled.

(WebCore::HTMLMediaSession::currentPlaybackTargetIsWireless): New, logic from HTMLMediaElement.
(WebCore::HTMLMediaSession::showPlaybackTargetPicker): Ditto.
(WebCore::HTMLMediaSession::hasWirelessPlaybackTargets): Ditto.
(WebCore::HTMLMediaSession::wirelessVideoPlaybackDisabled): Ditto.
(WebCore::HTMLMediaSession::setWirelessVideoPlaybackDisabled): Ditto.
(WebCore::HTMLMediaSession::setHasPlaybackTargetAvailabilityListeners): Ditto.
(WebCore::HTMLMediaSession::applyMediaPlayerRestrictions): New, apply media player specific

restriction.

html/HTMLMediaSession.h:

Move "playback target" logic into HTMLMediaSession.

html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::parseAttribute): Call media session.
(WebCore::HTMLVideoElement::webkitWirelessVideoPlaybackDisabled): Call media session.

platform/audio/MediaSessionManager.h:

(WebCore::MediaSessionManager::showPlaybackTargetPicker): New method, does nothing in base class.

platform/audio/ios/MediaSessionManagerIOS.h:
platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::MediaSessionManageriOS::showPlaybackTargetPicker): Add non-functional stub.

Implement wireless playback control and status API.

platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Dispatch TargetIsWirelessChanged.
(WebCore::MediaPlayerPrivateAVFoundation::playbackTargetIsWirelessChanged): Pass through to

media element.

platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Initialize

m_allowsWirelessVideoPlayback.

(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Remove "externalPlaybackActive" observer.
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyVideoLayer): Fix broken logging.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Add "externalPlaybackActive" observer,

set initial wireless playback.

(WebCore::MediaPlayerPrivateAVFoundationObjC::createPixelBuffer): Fix broken logging.
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::isCurrentPlaybackTargetWireless): New.
(WebCore::MediaPlayerPrivateAVFoundationObjC::wirelessVideoPlaybackDisabled): New.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setWirelessVideoPlaybackDisabled): New.
(WebCore::MediaPlayerPrivateAVFoundationObjC::playbackTargetIsWirelessDidChange): New.
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]): Deal with

externalPlaybackActive.

11:47 AM Changeset in webkit [164660] by Brent Fulgham

3 edits in trunk/Source/WebCore

[Win] Gracefully recover from missing 'naturalSize' parameter for media
https://bugs.webkit.org/show_bug.cgi?id=129278

Reviewed by Eric Carlson.

platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Add declaration for

missing function call.

platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::assetStatus): Don't treat missing 'naturalSize'
as a fatal error.
(WebCore::MediaPlayerPrivateAVFoundationCF::tracksChanged): Handle case of asset track
not being available yet.
(WebCore::MediaPlayerPrivateAVFoundationCF::sizeChanged): If the 'naturalSize' is empty,
use the Player Item's 'presentationSize' instead.
(WebCore::AVFWrapper::processNotification): Add missing handler for duration changed.

11:10 AM Changeset in webkit [164659] by svillar@igalia.com

50 edits in trunk

[CSS Grid Layout] Add ENABLE flag
https://bugs.webkit.org/show_bug.cgi?id=129153

Reviewed by Simon Fraser.

Added the ENABLE_CSS_GRID_LAYOUT feature flag to the cmake and
autotools build systems. The feature is disabled by default for
production builds.

Source/autotools/SetupWebKitFeatures.m4:
Source/cmake/OptionsEfl.cmake:
Source/cmake/OptionsGTK.cmake:
Source/cmake/WebKitFeatures.cmake:
Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig: added ENABLE_CSS_GRID_LAYOUT feature flag.

Source/WebCore:

Added ENABLE_CSS_GRID_LAYOUT feature flag.

Configurations/FeatureDefines.xcconfig:
css/CSSComputedStyleDeclaration.cpp:

(WebCore::isLayoutDependent):
(WebCore::ComputedStyleExtractor::propertyValue):

css/CSSGridTemplateAreasValue.cpp:
css/CSSGridTemplateAreasValue.h:
css/CSSParser.cpp:

(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):

css/CSSParser.h:
css/CSSParserMode.h:
css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

css/CSSPropertyNames.in:
css/CSSValue.cpp:

(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):

css/StyleProperties.cpp:

(WebCore::StyleProperties::getPropertyValue):

css/StylePropertyShorthand.cpp:

(WebCore::shorthandForProperty):
(WebCore::matchingShorthandsForLonghand):

css/StyleResolver.cpp:

(WebCore::equivalentBlockDisplay):
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::applyProperty):

css/StyleResolver.h:
dom/Document.cpp:
dom/Document.h:
rendering/RenderElement.cpp:

(WebCore::RenderElement::createFor):

rendering/RenderGrid.cpp:
rendering/RenderGrid.h:
rendering/style/GridCoordinate.h:
rendering/style/GridLength.h:
rendering/style/GridPosition.h:
rendering/style/GridTrackSize.h:
rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresLayout):

rendering/style/RenderStyle.h:
rendering/style/RenderStyleConstants.h:
rendering/style/StyleAllInOne.cpp:
rendering/style/StyleGridData.cpp:
rendering/style/StyleGridData.h:
rendering/style/StyleGridItemData.cpp:
rendering/style/StyleGridItemData.h:
rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

rendering/style/StyleRareNonInheritedData.h:

Source/WebKit/mac:

Added ENABLE_CSS_GRID_LAYOUT feature flag.

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Added ENABLE_CSS_GRID_LAYOUT feature flag.

Configurations/FeatureDefines.xcconfig:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

Added ENABLE_CSS_GRID_LAYOUT feature flag. It's on by default for
all ports for developer builds.

Scripts/webkitperl/FeatureList.pm:

10:53 AM Changeset in webkit [164658] by zandobersek@gmail.com

2 edits in trunk/Source/WebKit2

Unreviewed GTK build fix after r164652.

GNUmakefile.list.am: Add WebVisitedLinkProvider build targets.

10:38 AM WebKitOrgShortLinks created by BJ Burg

10:34 AM WikiStart edited by BJ Burg

syntax is hard (diff)

10:33 AM Changeset in webkit [164657] by Dániel Bátyai

2 edits in trunk/Tools

Added myself as a committer.

Unreviewed.

Scripts/webkitpy/common/config/contributors.json:

10:33 AM WikiStart edited by BJ Burg

Start an index of all the webkit.org/shortlinks (diff)

10:24 AM Changeset in webkit [164656] by jer.noble@apple.com

3 edits in trunk/Source/WebCore

[EME][Mac] Fix a few issues in CDMSessionMediaSourceAVFObjC.
https://bugs.webkit.org/show_bug.cgi?id=129310

Reviewed by Eric Carlson.

Only send a 'keyerror' event if an actual error code was returned, not just
when no key was added:

Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::addKeyTimerFired):

The 'length' parameter to a typed ArrayBufferView is the number of entries
in the array, not the byte length:

platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:

(WebCore::CDMSessionMediaSourceAVFObjC::generateKeyRequest):

The return value of streamingContentKeyRequestDataForApp:contentIdentifier:trackId:options:error
is autoreleased; do not wrap it in an adoptNS:

platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:

(WebCore::CDMSessionMediaSourceAVFObjC::update):

10:18 AM Changeset in webkit [164655] by thiago.lacerda@openbossa.org

2 edits
1 add in trunk/Source/WebCore

[MediaStream] Adding mock implementation of UserMediaClient
https://bugs.webkit.org/show_bug.cgi?id=129274

Reviewed by Eric Carlson.

platform/mock/UserMediaClientMock.h: Added.

(WebCore::UserMediaClientRequestNotifier::UserMediaClientRequestNotifier):

testing/Internals.cpp:

(WebCore::Internals::Internals):

9:57 AM Changeset in webkit [164654] by rniwa@webkit.org

16 edits in trunk/Source/WebCore

Tighten bitfields in live NodeLists and HTMLCollections
https://bugs.webkit.org/show_bug.cgi?id=129300

Reviewed by Geoffrey Garen.

Reduce the number of bits used for m_rootType and m_type in LiveNodeList.
Also use enum class for LiveNodeList types. We keep "Type" suffix not to
confuse old-ish compilers.

dom/ClassNodeList.cpp:

(WebCore::ClassNodeList::ClassNodeList):

dom/ContainerNode.cpp:

(WebCore::ContainerNode::getElementsByTagName):
(WebCore::ContainerNode::getElementsByName):
(WebCore::ContainerNode::getElementsByClassName):
(WebCore::ContainerNode::radioNodeList):

dom/LiveNodeList.cpp:

(WebCore::LiveNodeList::collectionFirst):
(WebCore::LiveNodeList::collectionTraverseForward):

dom/LiveNodeList.h:

(WebCore::LiveNodeList::LiveNodeList):

dom/NameNodeList.cpp:

(WebCore::NameNodeList::NameNodeList):

dom/NameNodeList.h:

(WebCore::NameNodeList::create):

dom/NodeRareData.h:

(WebCore::NodeListsNodeData::namedNodeListKey):

dom/TagNodeList.cpp:

(WebCore::HTMLTagNodeList::HTMLTagNodeList):

dom/TagNodeList.h:

(WebCore::TagNodeList::create):
(WebCore::HTMLTagNodeList::create):

html/HTMLCollection.h:
html/LabelableElement.cpp:

(WebCore::LabelableElement::labels):

html/LabelsNodeList.cpp:

(WebCore::LabelsNodeList::LabelsNodeList):

html/LabelsNodeList.h:
html/RadioNodeList.cpp:

(WebCore::RadioNodeList::RadioNodeList):

html/RadioNodeList.h:

(WebCore::RadioNodeList::create):

9:53 AM Changeset in webkit [164653] by msaboff@apple.com

6 edits in trunk/Source/JavaScriptCore

JIT Engines use the wrong stack limit for stack checks
https://bugs.webkit.org/show_bug.cgi?id=129314

Reviewed by Filip Pizlo.

Change the Baseline and DFG code to use VM::m_stackLimit for stack limit checks.

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileFunction):

jit/JIT.cpp:

(JSC::JIT::privateCompile):

jit/JITCall.cpp:

(JSC::JIT::compileLoadVarargs):

jit/JITCall32_64.cpp:

(JSC::JIT::compileLoadVarargs):

runtime/VM.h:

(JSC::VM::addressOfStackLimit):

9:48 AM Changeset in webkit [164652] by andersca@apple.com

8 edits
2 adds in trunk/Source

Make it possible to set the visited link provider on a per page basis
https://bugs.webkit.org/show_bug.cgi?id=129288

Reviewed by Andreas Kling.

Source/WebCore:

WebCore.exp.in:

Export symbols needed by WebKit2.

WebCore.xcodeproj/project.pbxproj:

Make VisitedLinkProvider a private header.

page/Page.cpp:

(WebCore::Page::Page):
Take the visited link provider from the PageClients object.

(WebCore::Page::visitedLinkProvider):
If the page has a visited link provider set, return it.

page/Page.h:

Add VisitedLinkProvider to Page and PageClients.

Source/WebKit2:

Add WebVisitedLinkProvider which just calls the web process.

WebKit2.xcodeproj/project.pbxproj:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

WebProcess/WebPage/WebVisitedLinkProvider.cpp: Added.

(WebKit::WebVisitedLinkProvider::create):
(WebKit::WebVisitedLinkProvider::WebVisitedLinkProvider):
(WebKit::WebVisitedLinkProvider::~WebVisitedLinkProvider):
(WebKit::WebVisitedLinkProvider::isLinkVisited):
(WebKit::WebVisitedLinkProvider::addVisitedLink):

WebProcess/WebPage/WebVisitedLinkProvider.h: Added.

9:47 AM Changeset in webkit [164651] by fpizlo@apple.com

7 edits in trunk/Source/JavaScriptCore

Unreviewed, roll out http://trac.webkit.org/changeset/164493.

It causes crashes, apparently because it's removing too many barriers. I will investigate
later.

bytecode/SpeculatedType.cpp:

(JSC::speculationToAbbreviatedString):

bytecode/SpeculatedType.h:
dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::insertStoreBarrier):

dfg/DFGNode.h:
ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compareEqObjectOrOtherToObject):
(JSC::FTL::LowerDFGToLLVM::equalNullOrUndefined):
(JSC::FTL::LowerDFGToLLVM::isNotNully):
(JSC::FTL::LowerDFGToLLVM::isNully):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::speculateObjectOrOther):
(JSC::FTL::LowerDFGToLLVM::speculateNotCell):

9:15 AM Changeset in webkit [164650] by Brent Fulgham

2 edits in branches/safari-537.60-branch/Source/WTF

Merge r152973

2013-07-22 Brent Fulgham <Brent Fulgham>

[Windows] Unreviewed build fix.

WTF.vcxproj/WTFGenerated.make: Stop triggering a "Build All" when things have not changed.

8:10 AM Changeset in webkit [164649] by commit-queue@webkit.org

3 edits
2 adds in trunk

[New Multicolumn] -webkit-column-break-inside:avoid doesn't work
https://bugs.webkit.org/show_bug.cgi?id=129299

Patch by Morten Stenshorne <mstensho@opera.com> on 2014-02-25
Reviewed by Andrei Bucur.

Source/WebCore:

adjustForUnsplittableChild() simply forgot to check whether we
were inside flow thread based multicol.

Test: fast/multicol/newmulticol/avoid-column-break-inside.html

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::adjustForUnsplittableChild):

LayoutTests:

fast/multicol/newmulticol/avoid-column-break-inside-expected.html: Added.
fast/multicol/newmulticol/avoid-column-break-inside.html: Added.

7:08 AM Changeset in webkit [164648] by tgergely.u-szeged@partner.samsung.com

2 edits in trunk/Tools

Unreviewed. Moved myself to the list of committers.

Scripts/webkitpy/common/config/contributors.json:

6:53 AM Changeset in webkit [164647] by pmolnar.u-szeged@partner.samsung.com

2 edits in trunk/Tools

Move myself to the committers list.

Unreviewed.

Scripts/webkitpy/common/config/contributors.json:

6:51 AM Changeset in webkit [164646] by mihnea@adobe.com

2 edits in trunk/Source/WebCore

[CSSRegions] Remove unused function RenderFlowThread::regionForCompositedLayer
https://bugs.webkit.org/show_bug.cgi?id=129303

Reviewed by Andrei Bucur.

Cleanup, no funtionality change, no new tests.

rendering/RenderFlowThread.h:

6:48 AM Changeset in webkit [164645] by llango.u-szeged@partner.samsung.com

2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

Scripts/webkitpy/common/config/contributors.json:

6:07 AM Changeset in webkit [164644] by Manuel Rego Casasnovas

3 edits in trunk/Tools

Unreviewed, rolling out r164639.
http://trac.webkit.org/changeset/164639
https://bugs.webkit.org/show_bug.cgi?id=129302

gtk-doc still have problems in EWS (Requested by rego on
#webkit).

Patch by Commit Queue <commit-queue@webkit.org> on 2014-02-25

Scripts/webkitpy/common/config/ports.py:

(GtkPort.build_webkit_command):
(GtkWK2Port.build_webkit_command):

Scripts/webkitpy/common/config/ports_unittest.py:

(DeprecatedPortTest.test_gtk_port):
(DeprecatedPortTest.test_gtk_wk2_port):

5:31 AM Changeset in webkit [164643] by g.czajkowski@samsung.com

7 edits
3 adds
9 deletes in trunk/LayoutTests

Refactoring inline_spelling_markers.html to use asynchronous spellchecking
https://bugs.webkit.org/show_bug.cgi?id=127284

Reviewed by Ryosuke Niwa.

Use asynchronous text checking in inline-spelling-markers.html and
inline-spelling-markers-hidpi.html

Rename the test to inline-spelling-markers.html to match the naming convention.

editing/spelling/inline-spelling-markers-expected.txt: Added.

Make cross platform text expectation by dumping spelling/grammar markers
instead of whole tree which in terms of spellchecking says nothing.

editing/spelling/inline-spelling-markers.html: Added.

Remove unnecessary new lines from div elements so position of markers can be given from 0.
Activate text checking by adding a word separator so WebKit starts performing spell and grammar
checking. Selection change does not invoke grammar checking unless we start editing the input
element's content.

platform/efl/editing/spelling/inline_spelling_markers-expected.png: Removed.
platform/efl/editing/spelling/inline_spelling_markers-expected.txt: Removed.
platform/gtk/editing/spelling/inline_spelling_markers-expected.png: Removed.
platform/gtk/editing/spelling/inline_spelling_markers-expected.txt: Removed.
platform/mac/editing/spelling/inline_spelling_markers-expected.png: Removed.
platform/mac/editing/spelling/inline_spelling_markers-expected.txt: Removed.

Those are not needed as pixel tests don't introduce anything special here.
Let's keep them in hidpi test only.

editing/spelling/inline-spelling-markers-hidpi-expected.txt:
editing/spelling/inline-spelling-markers-hidpi.html:

Apply changes from inline-spelling-markers.html

platform/mac/editing/spelling/inline-spelling-markers-hidpi-expected.png: Added.

platform/efl/editing/spelling/inline-spelling-markers-hidpi-expected.png: Removed.
platform/gtk/editing/spelling/inline-spelling-markers-hidpi-expected.png: Removed.

Remove wrong baselines due to missing grammar markers.

platform/efl-wk2/TestExpectations:
platform/gtk/TestExpectations:

Mark inline-spelling-markers.html and its hidpi version as failures
since EFL and GTK do not implement grammar checking.

platform/mac-wk2/TestExpectations:
platform/win/TestExpectations:

Mark inline-spelling-markers.html and its hidpi version as failures
due to missing TextChecker::requestCheckingOfString() implementation.

5:27 AM WebKitGTK/2.4.x edited by desrt@desrt.ca

BSD DFG JIT PLZ (diff)

4:44 AM Changeset in webkit [164642] by commit-queue@webkit.org

2 edits in trunk/Websites/bugs.webkit.org

PrettyPatch.rb should be more descriptive for "git diff -M" styled patches
https://bugs.webkit.org/show_bug.cgi?id=125514

Patch by Jozsef Berta <jberta.u-szeged@partner.samsung.com> on 2014-02-25
Reviewed by Csaba Osztrogonác.

PrettyPatch/PrettyPatch.rb: PrettyPatch.rb is modified to show which file was renamed or moved.

2:33 AM Changeset in webkit [164641] by stavila@adobe.com

1 edit
4 adds in trunk/LayoutTests

[CSS Regions] scrollIntoView for elements flowed into regions
https://bugs.webkit.org/show_bug.cgi?id=129151

Reviewed by Mihnea Ovidenie.

Added tests for scrollIntoView on elements flowed inside regions.

fast/regions/scroll-into-view-expected.html: Added.
fast/regions/scroll-into-view-relative-expected.html: Added.
fast/regions/scroll-into-view-relative.html: Added.
fast/regions/scroll-into-view.html: Added.

2:16 AM Changeset in webkit [164640] by commit-queue@webkit.org

3 edits
2 adds in trunk

[CSS Blending] -webkit-mix-blend-mode should force transform-style: flat.
https://bugs.webkit.org/show_bug.cgi?id=126158

Patch by Mihai Tica <mitica@adobe.com> on 2014-02-25
Reviewed by Mihnea Ovidenie.

Source/WebCore:

As stated in the http://www.w3.org/TR/css3-transforms/#propdef-transform-style, an element with blending
should force transform-style: flat.

Test: css3/compositing/blend-mode-transform-style.html

css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle): If blending is detected, set transform-style to flat.

LayoutTests:

For an element with -webkit-mix-blend-mode, test that the value of -webkit-transform-style computes to flat.

css3/compositing/blend-mode-transform-style-expected.txt: Added.
css3/compositing/blend-mode-transform-style.html: Added.

2:05 AM Changeset in webkit [164639] by Manuel Rego Casasnovas

3 edits in trunk/Tools

[GTK] Re-enable gtk-doc in EWS
https://bugs.webkit.org/show_bug.cgi?id=128369

Reviewed by Carlos Garcia Campos.

Enable again gtk-doc generation in EWS once bug #128417 has been fixed.

Scripts/webkitpy/common/config/ports.py:

(GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
(GtkWK2Port.build_webkit_command): Ditto.

Scripts/webkitpy/common/config/ports_unittest.py:

(DeprecatedPortTest.test_gtk_port): Ditto.
(DeprecatedPortTest.test_gtk_wk2_port): Ditto.

12:47 AM Changeset in webkit [164638] by zandobersek@gmail.com

12 edits in trunk/Source/WebCore

Move to using std::unique_ptr for Element, Node and related classes
https://bugs.webkit.org/show_bug.cgi?id=129058

Reviewed by Anders Carlsson.

Replace uses of OwnPtr and PassOwnPtr in Element, Node and the related
classes with std::unique_ptr and move semantics.

dom/ContainerNode.h:

(WebCore::ChildNodesLazySnapshot::takeSnapshot):
(WebCore::ChildNodesLazySnapshot::hasSnapshot):

dom/Element.cpp:

(WebCore::ensureAttrNodeListForElement):
(WebCore::Element::attributes):

dom/ElementIteratorAssertions.h:

(WebCore::ElementIteratorAssertions::ElementIteratorAssertions):

dom/ElementRareData.h:

(WebCore::ElementRareData::setAttributeMap):

dom/MutationObserverRegistration.cpp:

(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach):
(WebCore::MutationObserverRegistration::clearTransientRegistrations):
(WebCore::MutationObserverRegistration::addRegistrationNodesToSet):

dom/MutationObserverRegistration.h:
dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::NamedNodeMap):

dom/Node.cpp:

dom/Node.h:
dom/NodeRareData.h:

(WebCore::NodeListsNodeData::NodeListsNodeData):
(WebCore::NodeRareData::NodeRareData):
(WebCore::NodeRareData::clearNodeLists):
(WebCore::NodeRareData::ensureNodeLists):
(WebCore::NodeRareData::ensureMutationObserverData):

dom/StyledElement.cpp:

(WebCore::StyledElement::rebuildPresentationAttributeStyle):

12:19 AM Changeset in webkit [164637] by akling@apple.com

16 edits
3 deletes in trunk/Source

Prune dead code for Web Inspector memory instrumentation.
<https://webkit.org/b/129286>

Source/WebCore:

This was leftover code from Chromium's inspector. It's not used by
today's WebKit inspector.

Reviewed by Sam Weinig.

CMakeLists.txt:
DerivedSources.make:
GNUmakefile.am:
GNUmakefile.list.am:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
inspector/InspectorAllInOne.cpp:
inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

inspector/InspectorController.h:
inspector/InspectorMemoryAgent.cpp: Removed.
inspector/InspectorMemoryAgent.h: Removed.
inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):

inspector/InspectorTimelineAgent.h:
inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):

inspector/protocol/Memory.json: Removed.

Source/WebInspectorUI:

Reviewed by Sam Weinig.

UserInterface/Protocol/InspectorWebBackendCommands.js:

12:09 AM Changeset in webkit [164636] by mitz@apple.com

2 edits in trunk/Source/WebKit2

Build fix for case-sensitive filesystems.

WebProcess/ios/WebVideoFullscreenManager.cpp:

12:08 AM Changeset in webkit [164635] by Chris Fleizach

9 edits
2 adds in trunk

AX: Support abbr, acronym
https://bugs.webkit.org/show_bug.cgi?id=128860

Reviewed by Mario Sanchez Prada.

Source/WebCore:

Expose the data in <abbr>, <acronym> and <th abbr=""> as an
alternateTextValue() parameter.

Test: platform/mac/accessibility/abbr-acronym-tags.html

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::hasTagName):

accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::alternateTextValue):
(WebCore::AccessibilityObject::supportsAlternateTextValue):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::alternateTextValue):
(WebCore::AccessibilityRenderObject::supportsAlternateTextValue):

accessibility/AccessibilityRenderObject.h:
accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::alternateTextValue):
(WebCore::AccessibilityTableCell::supportsAlternateTextValue):

accessibility/AccessibilityTableCell.h:
accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(AXAttributeStringSetAlternateTextValue):
(AXAttributedStringAppendText):
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

Context Navigation

Timeline

Feb 26, 2014:

Feb 25, 2014:

Download in other formats: