Timeline



Mar 8, 2014:

9:28 PM Changeset in webkit [165349] by Simon Fraser
  • 4 edits in trunk/Source

[iOS WK2] Get position:fixed working slighlty better
​https://bugs.webkit.org/show_bug.cgi?id=129988

Source/WebCore:

Reviewed by Dan Bernstein.

On iOS we want to use the viewport-constrained visible rect, not
just the visible rect.

  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated):

Source/WebKit2:

Reviewed by Dan Bernstein.

iOS uses fixed layout, but does not want fixed elements laid
out relative to the frame.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setUseFixedLayout):

9:03 PM Changeset in webkit [165348] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

[iOS] Don't call scrollOffsetForFixedPosition a second time if we have no header and footer layers
​https://bugs.webkit.org/show_bug.cgi?id=129912

Reviewed by Tim Horton.

Avoid extra work if we have no header or footer layers.

  • page/scrolling/ios/ScrollingTreeScrollingNodeIOS.mm:

(WebCore::ScrollingTreeScrollingNodeIOS::setScrollLayerPosition):

8:32 PM Changeset in webkit [165347] by jonlee@apple.com
  • 2 edits in trunk/Source/WebKit2

iOS broken after r165342
​https://bugs.webkit.org/show_bug.cgi?id=129987

Reviewed by Simon Fraser.

  • NetworkProcess/ios/NetworkProcessIOS.mm:

(WebKit::NetworkProcess::platformLowMemoryHandler): Add missing stub implementation for
platformLowMemoryHandler().

6:38 PM Changeset in webkit [165346] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

RenderElement::valueForLength() callers misuse bool parameter.
​https://bugs.webkit.org/show_bug.cgi?id=129982

Reviewed by Andreas Kling.

Remove bogus RenderView* parameter.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePercentageLogicalHeight):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::repaintAfterLayoutIfNeeded):

6:18 PM Changeset in webkit [165345] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS] media preferences not initialized correctly in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=129983

Reviewed by Dan Bernstein.

  • Shared/WebPreferencesStore.h: Initialize mediaPlaybackAllowsInline and

mediaPlaybackRequiresUserGesture correctly for iOS.

6:16 PM Changeset in webkit [165344] by commit-queue@webkit.org
  • 26 edits
    1 move in trunk/Source

Allow media element to supply the video layer after fullscreen transition has already begun.
​https://bugs.webkit.org/show_bug.cgi?id=129870

Patch by Jeremy Jones <​jeremyj@apple.com> on 2014-03-08
Reviewed by Eric Carlson.

Source/WebCore:

Instead of borrowing the videolayer from the HTMLMediaElement, WebVideoFullscreen now supplies a layer to HTMLMediaElement to fill in as needed and at the appropriate time.

This allows fullscreen even if the video layer hasn't yet been created. And in the future it allows MediaPlayer to supply other layers such as closed captions.

  • WebCore.exp.in:

Remove exports related to borrowing and lend the video layer.
Add exports for supplying a layer to fullscreen and keepying the frame and gravity properties in sync.

  • html/HTMLMediaElement.cpp:

Remove the concept of borrowing the platform layer.
Add the concept of a supplied m_videoFullscreenLayer, into which the media player can add layers.
When the m_videoFullscreenFrame is supplied, don't show the video layer inline any more.
Stash video layer properties in case the media player is not yet created.

(WebCore::HTMLMediaElement::HTMLMediaElement):
Initialize gravity to the default. Remove m_platformLayerBorrowed.

(WebCore::HTMLMediaElement::platformLayer):
When we have a m_videoFullscreenLayer, don't show video inline.

(WebCore::HTMLMediaElement::setVideoFullscreenLayer):
Pass along the m_videoFullscreenLayer to the MediaPlayer if available or just stash it for later.

(WebCore::HTMLMediaElement::createMediaPlayer):
Pass along video fullscreen properties that we may have accumulated before the MediaPlayer was created.

(WebCore::HTMLMediaElement::setVideoFullscreenGravity):
Stash the gravity property, pass it along to the media player if possible.

  • html/HTMLMediaElement.h:

Remove concept of borrowing the video layer. Add properties for a supplied videoFullscreenLayer.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::setVideoFullscreenLayer):
Forward on to internal implementation.

(WebCore::MediaPlayer::setVideoFullscreenFrame):
Forward on to internal implementation.

(WebCore::MediaPlayer::setVideoFullscreenGravity):
Forward on to internal implementation.

  • platform/graphics/MediaPlayer.h:

Add methods for video fullscreen Layer, Frame and Gravity.

  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::setVideoFullscreenLayer):
Add default implementation.

(WebCore::MediaPlayerPrivateInterface::setVideoFullscreenFrame):
Add default implementation.

(WebCore::MediaPlayerPrivateInterface::setVideoFullscreenGravity):
Add default implementation.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:

Add support for fullscreen video layer, frame and gravity.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
Init m_videoFullscreenGravity.

(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer):
Apply cached properties once video layer is created and add to the fullscreen layer.

(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenLayer):
Cache the property value. Add video layer right away available.

(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenFrame):
Cache the property value. Apply to video layer right away if available.

(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenGravity):
Cache the property value. Apply to video layer right away if available.

  • platform/ios/WebVideoFullscreenControllerAVKit.mm:

Supply a fullscreen video layer to the WebVideoFullscreenModel and to the WebVideoFullscreenInterface.

(-[WebVideoFullscreenController enterFullscreen:]):
Supply a fullscreen video layer to the WebVideoFullscreenModel and to the WebVideoFullscreenInterface.

(-[WebVideoFullscreenController didExitFullscreen]):
Clean up the videoFullscreenLayer.

  • platform/ios/WebVideoFullscreenInterface.h:

Remove methods related to lending the video layer.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.h:

Rename WebAVPlayer layer to WebAVVideoLayer to match the AVKit name.
Remove functions related to lending the video layer.
Supply a layer directly to enterFullscreen.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(+[WebAVVideoLayer videoLayer]):
Rename WebAVPlayer layer to WebAVVideoLayer to match the AVKit name.

(-[WebAVVideoLayer setPlayerController:]):
Store the AVPlayerController to prevent AVKit's default behavior.

(-[WebAVVideoLayer setBounds:]):
Forward this onto the WebVideoFullscreenModel

(-[WebAVVideoLayer setVideoLayerGravity:]):
Forward this onto the WebVideoFullscreenModel

(-[WebAVVideoLayer videoLayerGravity]):
Forward this onto the WebVideoFullscreenModel

(WebVideoFullscreenInterfaceAVKit::enterFullscreen):
Supply a video layer directly instead of relying on one being previously loaned.

(WebVideoFullscreenInterfaceAVKit::exitFullscreen):
Clean-up now assumes there is a video layer.

  • platform/ios/WebVideoFullscreenModel.h:

Remove methods for borrowing and returning video layers.
Add methods for keeping video layer state in sync.

  • platform/ios/WebVideoFullscreenModelMediaElement.h:

Remove methods for borrowing and returning video layers.
Add method for supplying a video fullscreen layer.
Add methods for keeping video layer state in sync.

  • platform/ios/WebVideoFullscreenModelMediaElement.mm:

(WebVideoFullscreenModelMediaElement::setMediaElement):
Handle audio element case by setting hasVideo to false.

(WebVideoFullscreenModelMediaElement::setVideoFullscreenLayer):
Pass along the video fullscreen layer to the media element.

(WebVideoFullscreenModelMediaElement::setVideoLayerFrame):
Pass along the video layer frame to the media element.

(WebVideoFullscreenModelMediaElement::setVideoLayerGravity):
Pass along the video layer gravity to the media element.

Source/WebKit2:

WebVideoFullscreenManager and WebVideoFullscreenManagerProxy do their own remote hosting of the video layer instead of needing the video layer to have already been hosted elsewhere. This allows the removal of the coordination with WebPageProxy via a RemoteLayerTreeTransaction.

  • Shared/mac/RemoteLayerTreeTransaction.h:

Remove m_videoLayerIDsPendingFullscreen and accessors.

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::encode):
Don't encode m_videoLayerIDsPendingFullscreen

(WebKit::RemoteLayerTreeTransaction::decode):
Don't decode m_videoLayerIDsPendingFullscreen

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::didCommitLayerTree):
Don't forward didCommitLayerTree to m_videoFullscreenManager.

  • UIProcess/ios/WebVideoFullscreenManagerProxy.h:

Remove code for synchronizing with the RenderTree.
Add a hosting layer and methods to keep video layer frame and video gravity synchronized.

  • UIProcess/ios/WebVideoFullscreenManagerProxy.messages.in:

Change IPC interface to fascilitate rehosting video layer with a instead of coordinating with the RenderTree by PlatformLayerID.

  • UIProcess/ios/WebVideoFullscreenManagerProxy.mm:

(WebKit::WebVideoFullscreenManagerProxy::WebVideoFullscreenManagerProxy):
Remove initialization for removed members.

(WebKit::WebVideoFullscreenManagerProxy::enterFullscreenWithID):
Rehost the video layer by id and pass on the layer.
This replaces didCommitLayerTree() and willLendVideoLayerWithID().

(WebKit::WebVideoFullscreenManagerProxy::didExitFullscreen):
Cleanup the hosting layer.

(WebKit::WebVideoFullscreenManagerProxy::setVideoLayerFrame):
Forward on the video layer's frame to keep the hosted layer in sync with the interface.

(WebKit::WebVideoFullscreenManagerProxy::setVideoLayerGravity):
Forward the videolayer gravity.

  • WebKit2.xcodeproj/project.pbxproj:

Rename WebVideoFullscreenManager.cpp to WebVideoFullscreenManager.mm

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::willCommitLayerTree):
Don't invovle the m_videoFullscreenManager in layer tree transactions.

  • WebProcess/ios/WebVideoFullscreenManager.h:

Remove code that synchronizes with the render tree via RemoteLayerTreeTransaction.
Instead rehost the video layer directly.
Instead of hoping the WebVideoFullscreenModel has a videoLayer, supply one into which
it can add whatever it likes as needed.

  • WebProcess/ios/WebVideoFullscreenManager.messages.in:

No more explicit borrowing and returning video layers.
Add functions to keep video layer bounds and gravity in sync with the UI.

  • WebProcess/ios/WebVideoFullscreenManager.mm: Renamed from Source/WebKit2/WebProcess/ios/WebVideoFullscreenManager.cpp.

Removed code for synchronizing via RemoteLAyerTreeTransaction.

(WebKit::WebVideoFullscreenManager::WebVideoFullscreenManager):
Remove initialization for removed memeber m_sendUnparentVideoLayerTransaction.

(WebKit::WebVideoFullscreenManager::enterFullscreenForNode):
Creates a fullscreen layer, gives it to the WebVideoFullscreenModel to fill in,
and hosts it in a context to send to the UIProcess.

(WebKit::WebVideoFullscreenManager::exitFullscreenForNode):
remove enterFullscreen() and just directly send the IPC message.

(WebKit::WebVideoFullscreenManager::didExitFullscreen):
Clean up the hosting context.

(WebKit::WebVideoFullscreenManager::setVideoLayerGravityEnum):
Forward on the video gravity. Type convert from unsigned to MediaPlayer::VideoGravity.

5:47 PM Changeset in webkit [165343] by jaepark@webkit.org
  • 2 edits in trunk/Source/WebCore

Clean up PlatformLayer.h
​https://bugs.webkit.org/show_bug.cgi?id=129967

Reviewed by Martin Robinson.

  • platform/graphics/PlatformLayer.h:

Remove duplicated declaration of PlatformLayer when using TextureMapper.

4:49 PM Changeset in webkit [165342] by akling@apple.com
  • 4 edits in trunk/Source/WebKit2

[WK2] Improve the network process low memory handler.
<​https://webkit.org/b/129977>

Split the network process low memory handler into platform-specific
and shared parts. The shared part tells FastMalloc to release freed
pages back to the OS.

For Mac, added a call to purge the in-memory part of CFURLCache.
Remove the malloc_zone_pressure_relief() since that is now taken care
of by the shared MemoryPressureHandler code.

Reviewed by Darin Adler.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::lowMemoryHandler):
(WebKit::NetworkProcess::platformLowMemoryHandler):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/mac/NetworkProcessMac.mm:

(WebKit::NetworkProcess::platformLowMemoryHandler):
(WebKit::NetworkProcess::platformInitializeNetworkProcess):

4:14 PM Changeset in webkit [165341] by Alan Bujtas
  • 15 edits
    2 adds in trunk

Subpixel rendering: Simple compositing container layer (isSimpleContainerCompositingLayer) paints to wrong position.
​https://bugs.webkit.org/show_bug.cgi?id=129861

Reviewed by Simon Fraser.

This patch ensures that both the simple and non-simple cases paint to the same position.
Simple compositing container layer codepath needs to take the fractional device pixel offset
into account when painting. Without the fractional value, the final paint rounding could push the
paint offset to a different position.
retina example:
compositing top-left: 0px 0px.
fractional offset: 0.3px 0.3px
painting coords without offseting: 0px 0px

with offseting: 0.5px 0.5px

Source/WebCore:

Tests: compositing/hidpi-simple-container-layer-on-device-pixel.html

  • WebCore.exp.in:
  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::contentsRect):
(WebCore::GraphicsLayer::setContentsRect):
(WebCore::GraphicsLayer::contentsClippingRect):
(WebCore::GraphicsLayer::setContentsClippingRect):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setContentsRect):
(WebCore::GraphicsLayerCA::setContentsClippingRect):
(WebCore::GraphicsLayerCA::updateContentsRects):

  • platform/graphics/ca/GraphicsLayerCA.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundColor):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundImage):
(WebCore::RenderLayerBacking::contentOffsetInCompostingLayer):
(WebCore::RenderLayerBacking::backgroundBoxForPainting):

  • rendering/RenderLayerBacking.h:

LayoutTests:

  • compositing/hidpi-simple-container-layer-on-device-pixel-expected.html: Added.
  • compositing/hidpi-simple-container-layer-on-device-pixel.html: Added.
2:33 PM Changeset in webkit [165340] by Martin Robinson
  • 2 edits in trunk/LayoutTests

Skip tests on GTK+ for unimplemented features

  • platform/gtk/TestExpectations: When a feature is unimplemented, the tests may fail or

they may timeout, or perhaps they will crash. We just skip them here, so that we don't
have to micromanage expectations for tests against incomplete features.

2:29 PM Changeset in webkit [165339] by oliver@apple.com
  • 5 edits
    3 adds in trunk

SerializedScriptValue may move Identifiers between worlds
​https://bugs.webkit.org/show_bug.cgi?id=129979

Reviewed by Andreas Kling.

Source/WebCore:

Test: fast/workers/worker-copy-shared-blob-url.html

Don't use Strings to store blob URLs as String's may be Identifiers
and they can only exist in one world/thread at a time.

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::put):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::deserializeString):
(WebCore::SerializedScriptValue::addBlobURL):
(WebCore::SerializedScriptValue::SerializedScriptValue):

  • bindings/js/SerializedScriptValue.h:

LayoutTests:

Add test cases

  • fast/workers/resources/worker-copy-shared-blob-url-worker.js: Added.

(count.0.onmessage):

  • fast/workers/worker-copy-shared-blob-url-expected.txt: Added.
  • fast/workers/worker-copy-shared-blob-url.html: Added.
2:14 PM Changeset in webkit [165338] by zoltan@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Update perf.webkit.org json example
​https://bugs.webkit.org/show_bug.cgi?id=129907

Reviewed by Andreas Kling.

The current example is not valid json syntax. I fixed the syntax errors and indented the code properly.

  • ReadMe.md:
2:09 PM Changeset in webkit [165337] by commit-queue@webkit.org
  • 2 edits in trunk

Don't check for shm_open on librt on OpenBSD, lib doesnt exist.
​https://bugs.webkit.org/show_bug.cgi?id=129973

Patch by Landry Breuil <​landry@openbsd.org> on 2014-03-08
Reviewed by Martin Robinson.

  • Source/autotools/FindDependencies.m4:
2:07 PM Changeset in webkit [165336] by jaepark@webkit.org
  • 2 edits in trunk/Source/WebKit2

Remove unnecessary casting in NetworkProcessMainUnix.cpp
​https://bugs.webkit.org/show_bug.cgi?id=129968

Reviewed by Andreas Kling.

  • NetworkProcess/unix/NetworkProcessMainUnix.cpp:

Since socket is an int, int casting is not necessary.

(WebKit::NetworkProcessMain):

1:49 PM Changeset in webkit [165335] by Martin Robinson
  • 4 edits
    43 adds
    4 deletes in trunk/LayoutTests

Lots of cleanups for the GTK+ TestExpectations

Updated TestExpectations, adding bug standins where appropriate, skipping tests that
expected to fail and prone to timeout or crash. Removed some unused expectations. Added
new baselines for some tests.

  • platform/gtk-wk1/TestExpectations: Updated expectations.
  • platform/gtk-wk2/TestExpectations: Ditto.
  • platform/gtk/TestExpectations: Ditto.
11:23 AM Changeset in webkit [165334] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

32-bit x86 handleUncaughtException returns to wrong location after a stack overflow.
<​https://webkit.org/b/129969>

Reviewed by Geoffrey Garen.

The 32-bit version of handleUncaughtException was missing the handling of an
edge case for stack overflows where the current frame may already be the
sentinel frame. This edge case was handled in the 64-bit version. The fix
is to bring the 32-bit version up to parity.

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • llint/LowLevelInterpreter32_64.asm:
11:12 AM Changeset in webkit [165333] by Martin Robinson
  • 2 edits in trunk/LayoutTests

Add and update some test expectations for GTK+

  • platform/gtk/TestExpectations: These all seem to be failing because of the same bug.
5:31 AM Changeset in webkit [165332] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: update-InspectorBackendCommands.rb is putting legacy protocol files in the wrong place
​https://bugs.webkit.org/show_bug.cgi?id=129959

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-03-08
Reviewed by Timothy Hatcher.

The script was putting legacy generated files into UserInterface
instead of UserInterface/Protocol.

  • Scripts/update-InspectorBackendCommands.rb:
4:56 AM Changeset in webkit [165331] by timothy@apple.com
  • 12 edits in trunk/Source

Load source maps and their resources asynchronously.

​https://bugs.webkit.org/show_bug.cgi?id=112071

Reviewed by Joseph Pecoraro.

Source/WebCore:

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::buildObjectForFrameTree):
Honor the hiddenFromInspector flag.

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::markResourceAsCached):
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::didReceiveData):
(WebCore::InspectorResourceAgent::didFinishLoading):
(WebCore::InspectorResourceAgent::didFailLoading):
(WebCore::InspectorResourceAgent::replayXHR):
(WebCore::InspectorResourceAgent::loadResource):

  • inspector/InspectorResourceAgent.h:

Honor the hiddenFromInspector flag by keeping track of
hidden identifiers in a HashSet.

  • inspector/protocol/Network.json:

(Network.loadResource): Added.

  • platform/network/ResourceRequestBase.h:

(WebCore::ResourceRequestBase::hiddenFromInspector): Added.
(WebCore::ResourceRequestBase::setHiddenFromInspector): Added.
(WebCore::ResourceRequestBase::ResourceRequestBase):
Add a flag to hide the request from the Inspector.

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::sendForInspector): Added.
(WebCore::XMLHttpRequest::sendForInspectorXHRReplay): Renamed.
(WebCore::XMLHttpRequest::createRequest):

  • xml/XMLHttpRequest.h:

Make Inspector loads allow cross-origins and hide their request
from the Inspector itself.

Source/WebInspectorUI:

  • UserInterface/Controllers/SourceMapManager.js:

(WebInspector.SourceMapManager.prototype.loadAndParseSourceMap):
(WebInspector.SourceMapManager.prototype.downloadSourceMap):
(WebInspector.SourceMapManager.prototype.sourceMapLoaded):
(WebInspector.SourceMapManager.prototype._loadAndParseSourceMap):
Use NetworkAgent.loadResource.

  • UserInterface/Models/SourceMapResource.js:

(WebInspector.SourceMapResource.prototype.requestContentFromBackend.sourceMapResourceLoaded):
(WebInspector.SourceMapResource.prototype.createSourceCodeTextRange):
Use NetworkAgent.loadResource.

  • UserInterface/Protocol/InspectorWebBackendCommands.js: Updated.
4:43 AM WebKitGTK/2.4.x edited by berto@igalia.com
(diff)
1:40 AM Changeset in webkit [165330] by mmaxfield@apple.com
  • 2 edits in trunk/LayoutTests

Mountain Lion WK1 test bots are crashing often
​https://bugs.webkit.org/show_bug.cgi?id=129962

Marking the following tests as flakey:
js/dom/cross-frame-bad-time.html
js/dom/create-lots-of-workers.html

Unreviewed.

Patch by Myles C. Maxfield <​mmaxfield@apple.com> on 2014-03-08

  • platform/mac-wk1/TestExpectations:
12:33 AM Changeset in webkit [165329] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Prevent processes spawned by WebProcess from trying to insert the SecItem shim.
​https://bugs.webkit.org/show_bug.cgi?id=129864

Patch by Aaron Golden <​golden@inkling.com> on 2014-03-08
Reviewed by Anders Carlsson.

  • WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:

(WebKit::WebContentProcessMainDelegate::doPreInitializationWork):

12:08 AM Changeset in webkit [165328] by Martin Robinson
  • 2 edits in trunk/Tools

Unreviewed build fix for GTKbuild after the switch to CMake

  • gtk/common.py:

(is_cmake_build): Like r165284, we need to assume CMake by default, since the
test-only bot doesn't have any build files.

Mar 7, 2014:

10:36 PM Changeset in webkit [165327] by timothy_horton@apple.com
  • 8 edits
    2 adds in trunk/Source

[WebKit2][iOS] PDF
​https://bugs.webkit.org/show_bug.cgi?id=129600
<rdar://problem/15260216>

Reviewed by Anders Carlsson.

Add a single custom content provider which installs a very primitive PDF view
in place of the WKContentView if a PDF is loaded in the main frame.

  • Configurations/WebKit2.xcconfig:

Link against CorePDF, for UIPDFPageView.

  • UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm:

(-[WKWebViewContentProviderRegistry init]):
Initialize the registry, using WKPDFView for all PDF MIME types.

  • WebKit2.xcodeproj/project.pbxproj:
  • UIProcess/ios/WKPDFView.h: Added.
  • UIProcess/ios/WKPDFView.mm: Added.

Add a very simple PDF view based on UIPDFPageView. Additional functionality
can come in the future; right now, we just create one view for each page, and
depend on CATiledLayer to only paint the pages that are being displayed.

  • WebCore.exp.in:
  • platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializePDFMIMETypes):
(WebCore::initializePostScriptMIMETypes):
(WebCore::initializeMIMETypeRegistry):
(WebCore::MIMETypeRegistry::getPDFMIMETypes):

  • platform/MIMETypeRegistry.h:

Split PDF and PostScript MIME types, so WebKit2 can retrieve just the PDF ones
without PostScript included.

10:34 PM Changeset in webkit [165326] by akling@apple.com
  • 3 edits in trunk/Source/WebKit2

ArgumentEncoder and ArgumentDecoder should be fastmalloced.
<​https://webkit.org/b/129960>

Reviewed by Ryosuke Niwa.

  • Platform/IPC/ArgumentDecoder.h:
  • Platform/IPC/ArgumentEncoder.h:
10:26 PM Changeset in webkit [165325] by mark.lam@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Fix bugs in 32-bit Structure implementation.
<​https://webkit.org/b/129947>

Reviewed by Mark Hahnenberg.

Added the loading of the Structure (from the JSCell) before use that was
missing in a few places. Also added more test cases to equals-masquerader.js.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • llint/LowLevelInterpreter32_64.asm:
  • tests/stress/equals-masquerader.js:

(equalsNull):
(notEqualsNull):
(strictEqualsNull):
(strictNotEqualsNull):
(equalsUndefined):
(notEqualsUndefined):
(strictEqualsUndefined):
(strictNotEqualsUndefined):
(isFalsey):
(test):

9:25 PM Changeset in webkit [165324] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Comment in RenderStyle is no longer accurate
​https://bugs.webkit.org/show_bug.cgi?id=129956

Reviewed by Simon Fraser.

RenderStyle::createStyleInheritingFromPseudoStyle was moved from RenderImage. Before it
was moved, there was an image-specific comment in the function. However, that comment
is both irrelevant to RenderStyle, and incorrect as the function is necessary for
RenderQuotes as well.

No new tests are necessary because there is no behavior change.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::createStyleInheritingFromPseudoStyle):

9:10 PM Changeset in webkit [165323] by Martin Robinson
  • 2 edits in trunk/LayoutTests

Mark some more tests as failing on WebKitGTK+ and file bugs for them

  • platform/gtk/TestExpectations: Update test expectations.
8:09 PM Changeset in webkit [165322] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Temporarily disable repeat-out-of-bounds stress tests pending fix for 129953.
​https://bugs.webkit.org/show_bug.cgi?id=129954

Patch by Andrew Trick <​atrick@apple.com> on 2014-03-07
Reviewed by Filip Pizlo.

  • tests/stress/float32-repeat-out-of-bounds.js:
  • tests/stress/int8-repeat-out-of-bounds.js:
7:36 PM Changeset in webkit [165321] by thiago.lacerda@openbossa.org
  • 5 edits in trunk

[WebRTC] Throw SYNTAX_ERROR when maxRetransmits and maxRetransmitTime are both set in RTCDataChannelInit
​https://bugs.webkit.org/show_bug.cgi?id=129894

Reviewed by Eric Carlson.

Source/WebCore:

Existing test was updated.

  • Modules/mediastream/RTCDataChannel.cpp:

(WebCore::RTCDataChannel::create):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-datachannel-expected.txt:
  • fast/mediastream/RTCPeerConnection-datachannel.html:
7:33 PM Changeset in webkit [165320] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

.cfi directives in LowLevelInterpreter.cpp are providing no benefit
​https://bugs.webkit.org/show_bug.cgi?id=129945

Reviewed by Mark Lam.

Removed .cfi directive. Verified that stack traces didn't regress in crash reporter
or in lldb.

  • llint/LowLevelInterpreter.cpp:
7:05 PM Changeset in webkit [165319] by Martin Robinson
  • 3 edits in trunk/Source/WebKit2

Fix the GTK+ build after the recent iOS merge.

  • UIProcess/API/gtk/PageClientImpl.cpp: Make some methods available to non-Cocoa ports and fix some signatures.
  • UIProcess/WebPageProxy.h: Ditto.
7:02 PM Changeset in webkit [165318] by bshafiei@apple.com
  • 1 copy in tags/Safari-537.75.7

New tag.

6:59 PM Changeset in webkit [165317] by bshafiei@apple.com
  • 5 edits in branches/safari-537.75-branch/Source

Versioning.

6:40 PM Changeset in webkit [165316] by Brent Fulgham
  • 3 edits in branches/safari-537.75-branch/Source/WebKit

[Win] Build fix for combined 32-bit and 64-bit target.

  • WebKit.vcxproj/WebKit/WebKitDirectX.props: Use PlatformTarget so that path matches

what DirectX uses.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Correct some symbols to

match sources in branch.

6:33 PM Changeset in webkit [165315] by alex.christensen@flexsim.com
  • 2 edits in trunk/Source/WebKit

[Win] Unreviewed build fix after r165310.

  • WebKit.vcxproj/WebKit/WebKitDirectX.props:

Replaced Platform macro, which is either "Win32" or "x64"
with PlatformShortName macro, which is either "x86" or "x64".
This is correct for finding the DirectX libraries.

6:23 PM Changeset in webkit [165314] by ryuan.choi@samsung.com
  • 5 edits in trunk/Source/WebKit/efl

[EFL] Replace GraphicsContext3D with Evas_GL in AcceleratedCompositingContext.
​https://bugs.webkit.org/show_bug.cgi?id=129676

Patch by Hyowon Kim <​hw1008.kim@samsung.com> on 2014-03-07
Reviewed by Gyuyoung Kim.

TextureMapperGL has its own GraphicsContext3D created by createForCurrentGLContext().
So AcceleratedCompositingContext doesn't need to create and set it to TextureMapperGL.

We now should do 'makeCurrentContext' with a platform specific context before createForCurrentGLContext().
This patch removes GraphicsContext3D related codes in AcceleratedCompositingContext
and adds EvasGLContext/Surface to it instead.

  • WebCoreSupport/AcceleratedCompositingContextEfl.cpp:

(WebCore::AcceleratedCompositingContext::initialize):
(WebCore::AcceleratedCompositingContext::resize):
(WebCore::AcceleratedCompositingContext::renderLayers):

  • WebCoreSupport/AcceleratedCompositingContextEfl.h:
  • ewk/ewk_view.cpp:
  • ewk/ewk_view_private.h:
6:20 PM Changeset in webkit [165313] by ryuan.choi@samsung.com
  • 6 edits in trunk/Source/WebKit2

Unreviewed. Fix build on the EFL port after r165303

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::didCommitLoadForMainFrame): Added new parameters.

  • UIProcess/CoordinatedGraphics/WebView.h: Ditto.
  • UIProcess/WebPageProxy.h:
  • UIProcess/efl/WebViewEfl.cpp: Added dummy didFinishLoadingDataForCustomContentProvider()

(WebKit::WebViewEfl::exitFullScreen):
(WebKit::WebViewEfl::didFinishLoadingDataForCustomContentProvider):

  • UIProcess/efl/WebViewEfl.h: Ditto.
6:16 PM Changeset in webkit [165312] by Brent Fulgham
  • 3 edits in branches/safari-537.75-branch/Tools

[Win] Unreviewed 64-bit build fix.

  • DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:

Do not attempt to use the /SAFESEH flag on 64-bit builds.

  • DumpRenderTree/win/UIDelegate.cpp: Add a missing include file.
6:08 PM Changeset in webkit [165311] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS WebKit2] Keyboard accessory comes up when I click a link.
​https://bugs.webkit.org/show_bug.cgi?id=129949
<rdar://problem/16265305>

Reviewed by Simon Fraser.

We need to create the accessory view only when needed.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView requiresAccessoryView]):
(-[WKContentView inputAccessoryView]):

6:05 PM Changeset in webkit [165310] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[Win] Unreviewed gardening (for 64-bit)

  • WebKit.vcxproj/WebKit/WebKitDirectX.props: Use Platform macro, rather than

hard-coded path. This allows it to work on 32-bit or 64-bit builds.

5:59 PM Changeset in webkit [165309] by Martin Robinson
  • 23 edits
    8 adds in trunk/LayoutTests

Rebaseline some tests for WebKitGTK+

  • platform/gtk: Rebaseline tests.
5:58 PM Changeset in webkit [165308] by Brent Fulgham
  • 4 edits
    1 delete in branches/safari-537.75-branch/Source/WebKit

Merge r152930.

2013-07-19 Alex Christensen <​achristensen@apple.com>


Added 64-bit symbols to WebKitExports.def.in for 64-bit Windows builds
and a macro to only use them for 64-bit builds.
​https://bugs.webkit.org/show_bug.cgi?id=118887

Reviewed by Brent Fulgham.

  • WebKit.vcxproj/WebKit.make: Removed.
  • WebKit.vcxproj/WebKit/WebKitDirectX.props: Correct link path for 64-bit DirectX.
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Added 64-bit symbols.
  • WebKit.vcxproj/WebKitExportGenerator/make-export-file-generator: Added support for new symbolWithPointer macro.
5:28 PM Changeset in webkit [165307] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Add the remaining WebKit2 headers to WEBKIT2_HEADERS
​https://bugs.webkit.org/show_bug.cgi?id=129942
<rdar://problem/15920020>

Reviewed by Tim Horton.

  • MigrateHeaders.make:
5:17 PM Changeset in webkit [165306] by oliver@apple.com
  • 3 edits
    3 adds in trunk

Continue hangs when performing for-of over arguments
​https://bugs.webkit.org/show_bug.cgi?id=129915

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Put the continue label in the right place

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitEnumeration):

LayoutTests:

Add tests

  • js/for-of-arguments-continue-hang-expected.txt: Added.
  • js/for-of-arguments-continue-hang.html: Added.
  • js/script-tests/for-of-arguments-continue-hang.js: Added.

(test):

5:17 PM Changeset in webkit [165305] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS WebKit2] Long-press on a link shows just "Copy".
​https://bugs.webkit.org/show_bug.cgi?id=129938
<rdar://problem/16266054>

Reviewed by Benjamin Poulain.

When adding a FIXME comment, I accidentally removed the ! on
the if (!element) condition.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getPositionInformation):

5:13 PM Changeset in webkit [165304] by Martin Robinson
  • 2 edits in trunk/Tools

[GTK] built-product-archive does not handle GTK+ CMake build
​https://bugs.webkit.org/show_bug.cgi?id=129941

  • BuildSlaveSupport/built-product-archive:

(archiveBuiltProduct): Fix the build by adding support to built-product-archive for
the CMake build.

5:06 PM Changeset in webkit [165303] by timothy_horton@apple.com
  • 21 edits
    4 adds in trunk/Source/WebKit2

[WebKit2][iOS] Main-frame custom content providers
​https://bugs.webkit.org/show_bug.cgi?id=129809

Reviewed by Dan Bernstein.

Re-introduce custom content providers to WebKit2 (removed in r152841), but
for iOS this time.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):
Send the initial MIME types that have custom content providers to the WebProcess.

(-[WKWebView dealloc]):
Unregister our page from the content provider registry.

(-[WKWebView _setHasCustomContentView:loadedMIMEType:]):
Install/uninstall the custom content provider. Create a view, if needed,
based on the class that the registry has associated with the given MIME type.
We unparent the WKContentView while the custom content provider is active,
and re-use the existing WKScrollView to contain the custom content provider.

(-[WKWebView _didFinishLoadingDataForCustomContentProviderWithSuggestedFilename:dataReference:]):
Forward loaded data on to the custom content provider for display.

(-[WKWebView _didCommitLayerTree:WebKit::]):
Assert that we aren't getting layer tree commits while using a custom content provider.

(-[WKWebView viewForZoomingInScrollView:]):
If we're using a custom content provider, its view should be used for zooming
instead of the (unparented) web content view.

(-[WKWebView hasContentView]):
(-[WKWebView scrollViewWillBeginZooming:withView:]):
(-[WKWebView scrollViewWillBeginDragging:]):
(-[WKWebView _didFinishScrolling]):
(-[WKWebView _updateVisibleContentRects]):
If we do not have a parented WKContentView because we are using a custom
content provider, we should not forward scroll view related changes to it.

(-[WKWebView _frameOrBoundsChanged]):
Update the minimum size of the custom content provider if the web view size changes.

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _contentProviderRegistry]):
(-[WKWebViewConfiguration _setContentProviderRegistry:]):

  • UIProcess/API/Cocoa/WKWebViewConfigurationInternal.h: Added.

Add an internal WKWebViewConfiguration property, the WKWebViewContentProviderRegistry.

  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/Cocoa/WKWebViewContentProvider.h: Added.

A minimal protocol for informing custom content providers of changes to
the size of the view, the represented data, and the owning scroll view.

  • UIProcess/Cocoa/WKWebViewContentProviderRegistry.h: Added.
  • UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm: Added.

(-[WKWebViewContentProviderRegistry addPage:]):
(-[WKWebViewContentProviderRegistry removePage:]):
(-[WKWebViewContentProviderRegistry registerProvider:forMIMEType:]):
(-[WKWebViewContentProviderRegistry providerForMIMEType:]):
(-[WKWebViewContentProviderRegistry mimeTypesWithContentProviders]):
New class, keeps track of a mapping from MIME types to UIViews that
conform to the WKWebViewContentProvider protocol.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::didCommitLoadForFrame):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/PageClient.h:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::didCommitLoadForMainFrame):
(WebKit::PageClientImpl::didFinishLoadingDataForCustomContentProvider):

  • UIProcess/mac/PageClientImpl.h:
  • UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didCommitLoadForMainFrame):
(WebKit::PageClientImpl::didFinishLoadingDataForCustomContentProvider):
Add parameters to didCommitLoadForMainFrame, indicating if we should use
a custom content provider to display the main frame, and what MIME type
was loaded in said frame, and add didFinishLoadingDataForCustomContentProvider.
On iOS, forward these to the WKWebView.
Also, give PageClientImplIOS a reference to the WKWebView.

  • UIProcess/ios/WKContentView.mm:

(-[WKContentView initWithFrame:context:WebKit::configuration:WebKit::webView:]):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:

(-[WKWebProcessPlugInFrame _hasCustomContentProvider]):

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h:

Expose whether or not a given frame has a custom content provider to the plug-in.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::WebFrameLoaderClient):
(WebKit::WebFrameLoaderClient::hasHTMLView):
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
(WebKit::WebFrameLoaderClient::committedLoad):
(WebKit::WebFrameLoaderClient::finishedLoading):
(WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
(WebKit::WebFrameLoaderClient::canCachePage):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

(WebKit::WebFrameLoaderClient::frameHasCustomContentProvider):
Restore WebFrameLoaderClient custom representation code, which ensures
that data is routed correctly (to the UI process, and not to WebCore) and
that we don't try to use the page cache for frames with content providers.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::mainFrameHasCustomContentProvider):
(WebKit::WebPage::addMIMETypeWithCustomContentProvider):
(WebKit::WebPage::shouldUseCustomContentProviderForResponse):
(WebKit::WebPage::canShowMIMEType):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Keep a list of MIME types which can be displayed via custom content providers
in WebPage, which will be pushed down from the registry as new providers
are added. Plug-ins still take precendence over custom content providers.

5:02 PM Changeset in webkit [165302] by andersca@apple.com
  • 4 edits in trunk/Source

MigrateHeaders.make should remove C SPI includes from WebKit2 headers
​https://bugs.webkit.org/show_bug.cgi?id=129937
<rdar://problem/15920020>

Reviewed by Tim Horton.

Source/WebKit/mac:

  • MigrateHeaders.make:

Add WKPreferences.h to WEBKIT2_HEADERS.
Add a sed rule that deletes all lines that start with a # and contain <WebKit/*Ref.h>.

Source/WebKit2:

  • WebKit2.xcodeproj/project.pbxproj:

Make WKPreferences.h and all headers it includes public. Update the post processing of WKBase.h
to account for WKBase.h now being a public header again.

4:41 PM Changeset in webkit [165301] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the regression introduced by r165288
​https://bugs.webkit.org/show_bug.cgi?id=129934

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-03-07
Reviewed by Ryosuke Niwa.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::scrollX):
(WebCore::DOMWindow::scrollY):
We need to return the new value after layout, not the value from the dirty tree.

4:40 PM Changeset in webkit [165300] by benjamin@webkit.org
  • 3 edits
    2 adds in trunk

Traversal failure in a direct adjacent chain with tail backtracking lacks the path to clear the tail
​https://bugs.webkit.org/show_bug.cgi?id=129863

Reviewed by Gavin Barraclough.

Source/WebCore:

Direct adjacent backtracking use the stack to push the backtracking entry point and recover from there.
In case of traversal failure, their is no point in recovering from the indirect adjancent entry point and
we should clear entry point from the stack (which is the purpose of the tail).

The adjancent tail was missing the part for clearing the stack in one case.

The case with adjancent backtracking inside descendant backtracing was doing everything right. This patch
generalize this code and the correct tail is fully generated by generateAdjacentBacktrackingTail().

JumpToClearAdjacentDescendantTail becomes JumpToClearAdjacentTail, and this new backtracking state is added
to the missing traversal action.

Test: fast/selectors/long-adjacent-backtracking.html

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::solveBacktrackingAction):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::linkFailures):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateAdjacentBacktrackingTail):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateBacktrackingTailsIfNeeded):

LayoutTests:

Test the faulty case.

  • fast/selectors/long-adjacent-backtracking-expected.txt: Added.
  • fast/selectors/long-adjacent-backtracking.html: Added.
4:33 PM Changeset in webkit [165299] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Include CMake into install-dependencies script
​https://bugs.webkit.org/show_bug.cgi?id=129909

Patch by Lorenzo Tilve <​ltilve@igalia.com> on 2014-03-07
Reviewed by Martin Robinson.

As since r165267 buid-webkit uses CMake by default, the dependency
with 'cmake' package should be introduced.

  • gtk/install-dependencies: Ditto.
4:18 PM Changeset in webkit [165298] by andersca@apple.com
  • 4 edits
    1 add in trunk/Source/WebKit

Source/WebKit: Make it possible to copy WebKit2 headers to WebKit.framework
​https://bugs.webkit.org/show_bug.cgi?id=129935

Reviewed by Dan Bernstein.

  • WebKit.xcodeproj/project.pbxproj:

Move the migrate headers script out into its own file.

Source/WebKit/mac: Make it possible to copy WebKit2 headers to WebKit.framework
​https://bugs.webkit.org/show_bug.cgi?id=129935
<rdar://problem/15920020>

Reviewed by Dan Bernstein.

  • MigrateHeaders.make:

Gather a list of public and private WebKit2 headers and filter them against the WEBKIT2_HEADERS list.
The matching headers are copied to the respective Headers or PrivateHeaders directories under WebKit.framework,
and also have their #imports rewritten to reference WebKit instead of WebKit2.

  • migrate-headers.sh: Added.

Set up the WEBKIT2_FRAMEWORKS_DIR if needed.

3:43 PM Changeset in webkit [165297] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

REGRESSION (r164847): Pressing the command key while hovering an element causes it to un-hover
​https://bugs.webkit.org/show_bug.cgi?id=129872

Reviewed by Tim Horton.

  • UIProcess/API/Cocoa/WKViewPrivate.h: Changes in performDictionaryLookupAtCurrentMouseLocation

were also not correct, because the current event could be a keyboard one (Cmd+Ctrl+D).
But this SPI is unused, and can be simply removed.

  • UIProcess/API/mac/WKView.mm: (-[WKView _postFakeMouseMovedEventForFlagsChangedEvent:]):

locationInWindow is undefined for keyboard events, so we have to use current location.
Thankfully, there is a method that returns the location in appropriate coordinate
space, unlike +[NSEvent mouseLocation] that we used before.

3:21 PM Changeset in webkit [165296] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[Win64] Compile error after r165128.
​https://bugs.webkit.org/show_bug.cgi?id=129807

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-03-07
Reviewed by Mark Lam.

Source/JavaScriptCore:

Check platform environment variable to determine if an assembler file should be generated.

Source/WTF:

  • wtf/Platform.h: MSVC does not support computed goto.

Also enabled COMPUTED_GOTO_OPCODES when !ENABLE(LLINT_C_LOOP). This is needed because the ASM LLINT operates like COMPUTED_GOTO_OPCODES,
and relies on the related data structures being defined to support this. On Win32, the platform does not HAVE_COMPUTED_GOTO support,
but does want ENABLE_COMPUTED_GOTO_OPCODES because it uses the ASM LLINT.

2:53 PM Changeset in webkit [165295] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS] Install WebKit2 XPC services to the correct place during iOS Simulator builds
​https://bugs.webkit.org/show_bug.cgi?id=129914

Reviewed by Dan Bernstein.

We weren't specifying INSTALL_PATH for iOS Simulator builds in
BaseXPCService.xcconfig, and r164576 changed INSTALL_PATH to
INSTALL_PATH_ACTUAL. This caused XPC services to start being installed
to the root of the iOS Simulator SDK. Fix this by setting
INSTALL_PATH_ACTUAL for iphonesimulator.

  • Configurations/BaseXPCService.xcconfig:
2:52 PM Changeset in webkit [165294] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Fix a typo
<rdar://problem/15920020>

Rubber-stamped by Dan Bernstein.

  • Configurations/WebKit.xcconfig:
2:22 PM Changeset in webkit [165293] by msaboff@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Clarify how we deal with "special" registers
​https://bugs.webkit.org/show_bug.cgi?id=129806

Already reviewed change being relanded.

Relanding change set r165196 as it wasn't responsible for the breakage reported in
​https://bugs.webkit.org/show_bug.cgi?id=129822. That appears to be a build or

Reviewed by Michael Saboff.
configuration issue.

  • assembler/ARM64Assembler.h:

(JSC::ARM64Assembler::lastRegister):

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::nextRegister):

  • ftl/FTLLocation.cpp:

(JSC::FTL::Location::restoreInto):

  • ftl/FTLSaveRestore.cpp:

(JSC::FTL::saveAllRegisters):
(JSC::FTL::restoreAllRegisters):

  • ftl/FTLSlowPathCall.cpp:
  • jit/RegisterSet.cpp:

(JSC::RegisterSet::reservedHardwareRegisters):
(JSC::RegisterSet::runtimeRegisters):
(JSC::RegisterSet::specialRegisters):
(JSC::RegisterSet::calleeSaveRegisters):

  • jit/RegisterSet.h:
2:16 PM Changeset in webkit [165292] by akling@apple.com
  • 4 edits in trunk/Source

[Mac] Notify system malloc of fake memory pressure.
<​https://webkit.org/b/129908>

Source/WebCore:

After fixing the leak in r165252, I was surprised to find that it didn't
show up on memory test bots. It turns out that while the memory is now
getting freed, the system malloc implementation doesn't actually release
pages back to the OS until there is memory pressure.

Since we are just faking the memory pressure on bots, we have to let
system malloc in on the fun, so we can get representative numbers.
With this change, we should finally see the effect of not leaking the
URLRequest object tree.

Reviewed by Anders Carlsson.

  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::install):

Tell system malloc that we are under fake memory pressure.

Source/WebKit2:

Reviewed by Anders Carlsson.

  • NetworkProcess/mac/NetworkProcessMac.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcess):

Listen for the fake memory pressure notification and respond by
just forwarding to system malloc. We don't do the full WebCore
memory pressure handling here, since that will cause stuff that
the network process doesn't need to get instantiated.

2:06 PM Changeset in webkit [165291] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Tweak the WebKit2 frameworks directories
​https://bugs.webkit.org/show_bug.cgi?id=129910
<rdar://problem/15920020>

Reviewed by Dan Bernstein.

Use an SDK relative directory for production builds.

  • Configurations/WebKit.xcconfig:
2:01 PM Changeset in webkit [165290] by matthew_hanson@apple.com
  • 4 edits
    3 copies in branches/safari-537.75-branch

Merge r165138.

1:57 PM Changeset in webkit [165289] by matthew_hanson@apple.com
  • 2 edits in branches/safari-537.75-branch/Source/WebCore

Merged r164876.

1:56 PM Changeset in webkit [165288] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

[iOS] WebKit1 scroll position is incorrect
​https://bugs.webkit.org/show_bug.cgi?id=129905

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-03-07
Reviewed by Simon Fraser.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::scrollX):
(WebCore::DOMWindow::scrollY):
A new optimization was avoiding layout if the position is zero. This was using the scrollX/Y instead
of actualScrollX/Y which caused us to always bail out instead of returning the value to JavaScript.

  • platform/ScrollView.h:

(WebCore::ScrollView::actualScrollX):
(WebCore::ScrollView::actualScrollY):
(WebCore::ScrollView::actualScrollPosition):
This was accidentally changed to the iOS compat document visible rect at some point.

1:53 PM Changeset in webkit [165287] by dino@apple.com
  • 2 edits in trunk/Source/WebKit2

Attempt to fix the iOS build.

  • Configurations/WebKit2.xcconfig: Add -framework OpenGLES to linking.
1:49 PM Changeset in webkit [165286] by matthew_hanson@apple.com
  • 3 edits in branches/safari-537.75-branch/Source/WebCore

Merge r165206.

1:33 PM Changeset in webkit [165285] by cavalcantii@gmail.com
  • 2 edits in trunk/Source/WebCore

Remove unused StdDeviation from Drop shadow effect
​https://bugs.webkit.org/show_bug.cgi?id=129891

Reviewed by Dirk Schulze.

No new tests, no change on behavior.

  • platform/graphics/filters/FEDropShadow.h:
1:32 PM Changeset in webkit [165284] by Martin Robinson
  • 2 edits in trunk/Tools

REGRESSION(165267): Broke a webkitpy unit tests
​https://bugs.webkit.org/show_bug.cgi?id=129904

Reviewed by Jon Honeycutt.

  • Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.

(GtkPort._is_cmake_build):

1:30 PM Changeset in webkit [165283] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Link WebKit.framework against WebKit2.framework and re-export all WebKit2 symbols
​https://bugs.webkit.org/show_bug.cgi?id=129901
<rdar://problem/15920020>

Reviewed by Andreas Kling.

  • Configurations/WebKit.xcconfig:
1:28 PM Changeset in webkit [165282] by mhahnenberg@apple.com
  • 6 edits
    2 moves in trunk/Source/JavaScriptCore

Move GCActivityCallback to heap
​https://bugs.webkit.org/show_bug.cgi?id=129457

Reviewed by Geoffrey Garen.

All the other GC timer related stuff is there already.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • heap/GCActivityCallback.cpp: Copied from Source/JavaScriptCore/runtime/GCActivityCallback.cpp.
  • heap/GCActivityCallback.h: Copied from Source/JavaScriptCore/runtime/GCActivityCallback.h.
  • runtime/GCActivityCallback.cpp: Removed.
  • runtime/GCActivityCallback.h: Removed.
1:15 PM Changeset in webkit [165281] by matthew_hanson@apple.com
  • 2 edits in branches/safari-537.75-branch/Source/WTF

Merge r164408.

1:10 PM Changeset in webkit [165280] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

Correct out-of-band track selection logic.
​https://bugs.webkit.org/show_bug.cgi?id=129900

Reviewed by Jer Noble.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::synchronizeTextTrackState): Correct test to
use inequality.

12:52 PM Changeset in webkit [165279] by Simon Fraser
  • 10 edits in trunk/Source/WebKit2

[iOS] Add an updateID to visibleContentRect updates which is passed back in layer transactions, so we know whether transactions are stale
​https://bugs.webkit.org/show_bug.cgi?id=129897

Reviewed by Benjamin Poulain.

In WebKit2 on iOS we need to know when layer updates from the web process
are stale with respect to visible rect updates from the UI process. Do so
by adding an updateID to VisibleContentRectUpdateInfo, and storing it
on each side, returning it in RemoteLayerTreeTransaction.

Did some re-ordering of members and encoding order in RemoteLayerTreeTransaction
to group like data members together.

  • Shared/VisibleContentRectUpdateInfo.cpp:

(WebKit::VisibleContentRectUpdateInfo::encode):
(WebKit::VisibleContentRectUpdateInfo::decode):

  • Shared/VisibleContentRectUpdateInfo.h:

(WebKit::VisibleContentRectUpdateInfo::VisibleContentRectUpdateInfo):
(WebKit::VisibleContentRectUpdateInfo::updateID):
(WebKit::operator==):

  • Shared/mac/RemoteLayerTreeTransaction.h:

(WebKit::RemoteLayerTreeTransaction::setLastVisibleContentRectUpdateID):
(WebKit::RemoteLayerTreeTransaction::lastVisibleContentRectUpdateID):

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::nextVisibleContentRectUpdateID):
(WebKit::WebPageProxy::lastVisibleContentRectUpdateID):

  • UIProcess/ios/WKContentView.mm:

(-[WKContentView didUpdateVisibleRect:unobscuredRect:scale:inStableState:]):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::willCommitLayerTree):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::updateVisibleContentRects):

12:39 PM Changeset in webkit [165278] by Andres Gomez
  • 2 edits in trunk/Tools

[GTK] webkit-patch setup-git-clone fails even after running Tools/gtk/install-dependencies
​https://bugs.webkit.org/show_bug.cgi?id=129893

Reviewed by Martin Robinson.

Added "git-svn" as dependency for deb based distros and,
additionally, "subversion" for rpm based distros.

  • gtk/install-dependencies:
12:29 PM Changeset in webkit [165277] by betravis@adobe.com
  • 6 edits in trunk

[CSS Shapes] Correctly serialize ellipse positions
​https://bugs.webkit.org/show_bug.cgi?id=129700

Reviewed by Dirk Schulze.

Source/WebCore:

Updating ellipse serialization to be in line with
the CSS Shapes spec. Positions should serialize as
2 or 4-value positions, converting keywords to
percentages where possible. This uses the same method
as circle position serialization (bug 129404).

Updated existing parsing tests.

  • css/CSSBasicShapes.cpp:

(WebCore::CSSBasicShapeEllipse::cssText): Use the
normalization / serialization helpers for shape position.

LayoutTests:

Update tests to use the new position serialization for
ellipse.

  • fast/shapes/parsing/parsing-shape-inside-expected.txt:
  • fast/shapes/parsing/parsing-shape-outside-expected.txt:
  • fast/shapes/parsing/parsing-test-utils.js:
12:20 PM Changeset in webkit [165276] by roger_fong@apple.com
  • 12 edits in trunk

Replace setSystemWebGLLoadPolicy API with methods to query for WebGL blocking policy.
​https://bugs.webkit.org/show_bug.cgi?id=129873.

Reviewed by Dean Jackson.

Remove setSystemWebGLLoadPolicy API.

  • UIProcess/API/APILoaderClient.h:

(API::LoaderClient::resolveWebGLLoadPolicy):

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageLoaderClient):

  • UIProcess/API/C/WKPageLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::resolveWebGLPolicyForURL):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::webGLPolicyForURL):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):

Add API to directly query the WebGL blocking policies from WKSI.

  • UIProcess/API/C/mac/WKContextPrivateMac.h:
  • UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextShouldBlockWebGL):
(WKContextShouldSuggestBlockWebGL):

12:19 PM Changeset in webkit [165275] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Correct a comment typo from:
FLT should call fmod directly on platforms where LLVM cannot relocate the libcall
​https://bugs.webkit.org/show_bug.cgi?id=129865

Patch by Andrew Trick <​atrick@apple.com> on 2014-03-07
Reviewed by Mark Lam.

  • ftl/FTLOutput.h:

(JSC::FTL::Output::doubleRem):

11:40 AM Changeset in webkit [165274] by mhahnenberg@apple.com
  • 3 edits in trunk/Tools

run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
​https://bugs.webkit.org/show_bug.cgi?id=129886

Reviewed by Mark Lam.

  • Scripts/jsc-stress-test-helpers/shell-runner.sh: Added a "verbose" mode to the shell runner.

If we're in verbose mode, then we don't redirect any output when running each test. If we're not
in verbose mode then we redirect stdout to /dev/null and allow any stderr output through.

  • Scripts/run-jsc-stress-tests: Redirect any sort of error output to stderr so that it will

make it through when in non-verbose mode.

11:25 AM WebKitGTK/StartHacking edited by Andres Gomez
(diff)
11:02 AM Changeset in webkit [165273] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebKit2

Initialize new WKSI functions for WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=129889

Reviewed by Simon Fraser.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

10:48 AM Changeset in webkit [165272] by BJ Burg
  • 3 edits in trunk/Source/WebCore

Unreviewed, rebaseline run-binding-tests results after r165242.

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg):

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::jsTestTypedefsPrototypeFunctionCallWithSequenceThatRequiresInclude):

10:47 AM WebKitGTK/StartHacking edited by Andres Gomez
(diff)
10:47 AM Changeset in webkit [165271] by Brent Fulgham
  • 1 edit
    1 add in branches/safari-537.75-branch/Source/WebKit

Merge r165270.

2014-03-07 Brent Fulgham <Brent Fulgham>

[Win] Convert WebKit.make to an MSBuild file.
​https://bugs.webkit.org/show_bug.cgi?id=129888

Reviewed by Dean Jackson.

  • WebKit.vcxproj/WebKit.proj: Added.
10:43 AM Changeset in webkit [165270] by Brent Fulgham
  • 1 edit
    1 add in trunk/Source/WebKit

[Win] Convert WebKit.make to an MSBuild file.
​https://bugs.webkit.org/show_bug.cgi?id=129888

Reviewed by Dean Jackson.

  • WebKit.vcxproj/WebKit.proj: Added.
9:51 AM Changeset in webkit [165269] by Darin Adler
  • 4 edits in trunk/Source/WebCore

Remove non-working optimization that was attempted on iOS only
​https://bugs.webkit.org/show_bug.cgi?id=129595
<rdar://problem/15798825>

Reviewed by Sam Weinig.

Code in GCController tried to optimize cases where the controller
was used, but no JavaScript had been run in the current process.
The code was never effective, and was iOS-only. Another way to fix
the problem would be to change the code so it works, and if we do
that we should do it for all platforms, not just iOS.

  • bindings/js/GCController.cpp:

(WebCore::GCController::garbageCollectNow): Remove check of
JSDOMWindow::commonVMExists, since it's called just after a call
to JSDOMWindow::commonVM, which will create it as a side effect.
(WebCore::GCController::releaseExecutableMemory): Ditto.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::commonVM): Removed iOS-specific code
that pulled the commonVM global out into another function so we
can check for its existence without creating it as a side effect.

  • bindings/js/JSDOMWindowBase.h: Ditto.
9:33 AM Changeset in webkit [165268] by Michał Pakuła vel Rutka
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening

Clear test expectations for passing tests.

  • platform/efl/TestExpectations:
9:27 AM Changeset in webkit [165267] by Martin Robinson
  • 3 edits in trunk/Tools

[GTK] buid-webkit should use CMake by default
​https://bugs.webkit.org/show_bug.cgi?id=129855

Reviewed by Carlos Garcia Campos.

Make the CMake build the default GTK+ build when using build-webkit. This will
ensure that all bots are using CMake. We do this by swapping --gtk and --gtkcmake,
so that we have --gtk and --gtkautotools.

  • Scripts/webkitdirs.pm: Swap --gtkcmake/--gtk for --gtk/--gtkautotools.
  • Scripts/webkitpy/port/gtk.py: Ditto.
9:21 AM Changeset in webkit [165266] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r165262.
​http://trac.webkit.org/changeset/165262
​https://bugs.webkit.org/show_bug.cgi?id=129887

Fix wrong commit message (Requested by mpakula on #webkit).

  • platform/efl/TestExpectations:
9:13 AM Changeset in webkit [165265] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Use OwnPtr in StructureIDTable
​https://bugs.webkit.org/show_bug.cgi?id=129828

Reviewed by Geoffrey Garen.

This reduces the amount of boilerplate and fixes a memory leak.

  • runtime/StructureIDTable.cpp:

(JSC::StructureIDTable::StructureIDTable):
(JSC::StructureIDTable::resize):
(JSC::StructureIDTable::flushOldTables):
(JSC::StructureIDTable::allocateID):
(JSC::StructureIDTable::deallocateID):

  • runtime/StructureIDTable.h:

(JSC::StructureIDTable::table):
(JSC::StructureIDTable::get):

9:03 AM Changeset in webkit [165264] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

FLT should call fmod directly on platforms where LLVM cannot relocate the libcall
​https://bugs.webkit.org/show_bug.cgi?id=129865

Patch by Andrew Trick <​atrick@apple.com> on 2014-03-07
Reviewed by Filip Pizlo.

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLOutput.h:

(JSC::FTL::Output::doubleRem):

9:00 AM Changeset in webkit [165263] by Martin Robinson
  • 2 edits in trunk/Tools

[CMake] [GTK] Build with ninja when it is available
​https://bugs.webkit.org/show_bug.cgi?id=129805

Reviewed by Philippe Normand.

  • Scripts/webkitdirs.pm:

(canUseNinja): Added this helper which tries to execute Ninja, in an effort to determine
if it's available on the system.
(cmakeGeneratedBuildfile): Return the path to the generated build file. Only Unix support ATM.
(generateBuildSystemFromCMakeProject): For GTK+ compile with Ninja when possible.

8:49 AM Changeset in webkit [165262] by Michał Pakuła vel Rutka
  • 2 edits in trunk/LayoutTests

[CSS Shapes] inset does not properly clamp large corner radii
​https://bugs.webkit.org/show_bug.cgi?id=129726

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2014-03-07
Reviewed by Dirk Schulze.

  • fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-large-radius-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-large-radius.html: Added.
8:25 AM Changeset in webkit [165261] by Bem Jones-Bey
  • 5 edits
    2 adds in trunk

[CSS Shapes] inset does not properly clamp large corner radii
​https://bugs.webkit.org/show_bug.cgi?id=129726

Reviewed by Dirk Schulze.

Source/WebCore:

Make sure that radii that are larger than 50% of the associated shape
dimension (height or width) are properly reduced the same way as
border-radius radii are.

Test: fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-large-radius.html

  • rendering/shapes/Shape.cpp:

(WebCore::ensureRadiiDoNotOverlap): Drive by style fix.
(WebCore::Shape::createShape): Scale radii the same way as border

radii are scaled.

  • platform/graphics/FloatRoundedRect.h:

(WebCore::calcBorderRadiiConstraintScaleFor): Move border radii

constraint calculation function out so that it can be shared by
the shape code.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getRoundedBorderFor): Call renamed scale function.

LayoutTests:

  • fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-large-radius-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-large-radius.html: Added.
5:39 AM Changeset in webkit [165260] by Michał Pakuła vel Rutka
  • 3 edits in trunk/LayoutTests

Unreviewed EFL gardening

Remove wrong test expectations.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
5:37 AM Changeset in webkit [165259] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Use final and override in WebPrintOperationGtk
​https://bugs.webkit.org/show_bug.cgi?id=129868

Reviewed by Sergio Villar Senin.

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
5:35 AM Changeset in webkit [165258] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebCore

[GST] Set name to several timeout sources
​https://bugs.webkit.org/show_bug.cgi?id=129878

Reviewed by Philippe Normand.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::videoChanged):
(WebCore::MediaPlayerPrivateGStreamer::videoCapsChanged):
(WebCore::MediaPlayerPrivateGStreamer::audioChanged):
(WebCore::MediaPlayerPrivateGStreamer::textChanged):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::volumeChanged):
(WebCore::MediaPlayerPrivateGStreamerBase::muteChanged):

5:27 AM Changeset in webkit [165257] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

[GTK] Timeout sources not correctly removed
​https://bugs.webkit.org/show_bug.cgi?id=129877

Reviewed by Philippe Normand.

Set source ID variables to 0 after removing the sources from the
context. Also give a name to the sources.

  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:

(WebCore::TrackPrivateBaseGStreamer::disconnect):
(WebCore::TrackPrivateBaseGStreamer::activeChanged):
(WebCore::TrackPrivateBaseGStreamer::tagsChanged):
(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfActiveChanged):

4:02 AM Changeset in webkit [165256] by commit-queue@webkit.org
  • 3 edits
    1 delete in trunk/Source/WebCore

Remove FFTFrameMKL.
​https://bugs.webkit.org/show_bug.cgi?id=129866

Patch by Gergo Balogh <​gbalogh.u-szeged@partner.samsung.com> on 2014-03-07
Reviewed by Csaba Osztrogonác.

  • platform/audio/FFTFrame.h:
  • platform/audio/FFTFrameStub.cpp:
  • platform/audio/mkl/FFTFrameMKL.cpp: Removed, it is never used.
3:46 AM Changeset in webkit [165255] by thiago.lacerda@openbossa.org
  • 8 edits
    4 adds in trunk

[WebRTC] Adding getConfiguration method to RTCPeerConnection
​https://bugs.webkit.org/show_bug.cgi?id=129845

Reviewed by Eric Carlson.

Source/WebCore:

Test: fast/mediastream/RTCPeerConnection-getConfiguration.html

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • Modules/mediastream/RTCConfiguration.idl: Added.
  • Modules/mediastream/RTCIceServer.idl: Added.
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::updateIce):
(WebCore::RTCPeerConnection::getConfiguration):

  • Modules/mediastream/RTCPeerConnection.h:
  • Modules/mediastream/RTCPeerConnection.idl:

LayoutTests:

  • fast/mediastream/RTCPeerConnection-getConfiguration-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-getConfiguration.html: Added.
2:42 AM Changeset in webkit [165254] by jinwoo7.song@samsung.com
  • 2 edits in trunk/Source/WebCore

Optimize collectionLast() and collectionTraverseBackward() in LiveNodeList
​https://bugs.webkit.org/show_bug.cgi?id=129775

Reviewed by Ryosuke Niwa.

Check the LiveNodeList type if it is HTMLTagNodeListType and ClassNodeListType then
apply inlined matching methods for each type.

  • dom/LiveNodeList.cpp:

(WebCore::lastMatchingElement): Added.
(WebCore::previousMatchingElement): Added.
(WebCore::traverseMatchingElementsBackward): Added.
(WebCore::LiveNodeList::collectionLast): Apply lastMatchingElement() with LiveNodeList type.
(WebCore::LiveNodeList::collectionTraverseBackward): Apply traverseMatchingElementsBackward()
with LiveNodeList type.

2:00 AM Changeset in webkit [165253] by zandobersek@gmail.com
  • 7 edits in trunk/Source/WebKit/gtk

Move GTK WebKit1 code to std::unique_ptr
​https://bugs.webkit.org/show_bug.cgi?id=129675

Reviewed by Anders Carlsson.

Replace uses of OwnPtr and PassOwnPtr in GTK-specific WebKit1 code with std::unique_ptr.

  • WebCoreSupport/AcceleratedCompositingContext.h:
  • WebCoreSupport/NavigatorContentUtilsClientGtk.cpp:
  • WebCoreSupport/NavigatorContentUtilsClientGtk.h:
  • webkit/webkitfavicondatabase.cpp:

(getIconPixbufCancelled):
(webkit_favicon_database_get_favicon_pixbuf):

  • webkit/webkitwebview.cpp:

(webkit_web_view_init):

  • webkit/webkitwebviewprivate.h:
1:40 AM GRefPtr edited by Manuel Rego Casasnovas
Add link to RefPtr and PassRefPtr documentation at webkit.org (diff)
Note: See TracTimeline for information about the timeline view.