Timeline
Mar 16, 2014:
- 11:49 PM Changeset in webkit [165722] by
-
- 4 edits in trunk
.: [EFL] Enable TOUCH_SLIDER macro.
https://bugs.webkit.org/show_bug.cgi?id=130186
Patch by Kim Byung Jun <bj1987.kim@samsung.com> on 2014-03-16
Reviewed by Gyuyoung Kim.
- Source/cmake/OptionsEfl.cmake:
Tools: [EFL] Enable TOUCH_SLIDER macro
https://bugs.webkit.org/show_bug.cgi?id=130185
Patch by Kim Byung Jun <bj1987.kim@samsung.com> on 2014-03-16
Reviewed by Gyuyoung Kim.
- Scripts/webkitperl/FeatureList.pm:
- 11:37 PM Changeset in webkit [165721] by
-
- 6 edits in trunk/Source/WTF
Remove most uses of deprecatedCharacter in WTF
https://bugs.webkit.org/show_bug.cgi?id=130317
Reviewed by Andreas Kling.
- wtf/text/AtomicString.cpp:
(WTF::HashAndUTF8CharactersTranslator::equal): Add an 8-bit code path to the
non-ASCII path.
(WTF::SubstringTranslator8::hash): Added.
(WTF::SubstringTranslator8::equal): Added.
(WTF::SubstringTranslator16::hash): Renamed class.
(WTF::SubstringTranslator16::equal): Ditto.
(WTF::AtomicString::add): Added an 8-bit code path to the substring case.
- wtf/text/Base64.cpp:
(WTF::base64Decode): Added an 8 bit code path.
(WTF::base64URLDecode): Ditto.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::find): Fixed a case that was incorrectly using characters16
without first using is8Bit. Need to return later to remove use of deprecatedCharacters.
- wtf/unicode/UTF8.cpp:
(WTF::Unicode::equalUTF16WithUTF8): Added a case for when the UTF-16 characters
are ASCII. Also removed the aEnd argument, since the caller only calls this when the
lengths are equal.
(WTF::Unicode::equalLatin1WithUTF8): Added.
- wtf/unicode/UTF8.h: Updated as described above.
- 11:35 PM Changeset in webkit [165720] by
-
- 4 edits2 adds in trunk
[CSSRegions]Do not compute region range for a box unless the parent has one
https://bugs.webkit.org/show_bug.cgi?id=130249
Reviewed by Andrei Bucur.
Source/WebCore:
If the containing block does not have a region range computed, do not attempt to compute
a region range for a child. In such cases, the range computation for a child can lead to
a result that is wrong, possibly leading to an incorrect clipping.
Test: fast/regions/inline-block-flowed-in-regions.html
- rendering/RenderBlock.cpp:
(WebCore::canComputeRegionRangeForBox):
(WebCore::RenderBlock::computeRegionRangeForBoxChild):
(WebCore::RenderBlock::estimateRegionRangeForBoxChild):
(WebCore::RenderBlock::updateRegionRangeForBoxChild):
- rendering/RenderFlowThread.h:
LayoutTests:
- fast/regions/inline-block-flowed-in-regions-expected.html: Added.
- fast/regions/inline-block-flowed-in-regions.html: Added.
- 11:15 PM Changeset in webkit [165719] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(r165703): JSC tests crashing in StringImpl::destroy().
<https://webkit.org/b/130304>
Reviewed by Anders Carlsson.
Unreviewed, restoring the old behavior of OpaqueJSString::identifier()
that doesn't put a potentially unwanted string into the Identifier table.
- API/OpaqueJSString.cpp:
(OpaqueJSString::identifier):
- 10:46 PM Changeset in webkit [165718] by
-
- 9 edits4 adds in trunk/Source/WebKit2
[EFL][WK2] Add ewk_application_cache_manager APIs
https://bugs.webkit.org/show_bug.cgi?id=102853
Reviewed by Gyuyoung Kim.
Implemented application cache manager to get list of origins which stores
application cache and remove specified origin or all.
- PlatformEfl.cmake: Added newly added files.
- UIProcess/API/efl/ewk_application_cache_manager.cpp: Added.
(EwkApplicationCacheManager::EwkApplicationCacheManager):
(EwkApplicationCacheManager::~EwkApplicationCacheManager):
(Get_Origins_Data::Get_Origins_Data):
(getApplicationCacheOriginsCallback):
(ewk_application_cache_manager_origins_get):
(ewk_application_cache_origins_free):
(ewk_application_cache_manager_delete_all):
(ewk_application_cache_manager_delete):
- UIProcess/API/efl/ewk_application_cache_manager.h: Added.
- UIProcess/API/efl/ewk_application_cache_manager_private.h: Added.
(EwkApplicationCacheManager::impl):
- UIProcess/API/efl/ewk_context.cpp:
(EwkContext::applicationCacheManager):
(ewk_context_application_cache_manager_get):
- UIProcess/API/efl/ewk_context.h:
- UIProcess/API/efl/ewk_context_private.h:
- UIProcess/API/efl/ewk_security_origin_private.h:
(EwkSecurityOrigin::wkSecurityOrigin):
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.cpp:
(EWK2UnitTestServer::port):
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.h:
- UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp:
Added to test application_cache_manager.
(serverCallback):
(getOriginsCallback):
(timerCallback):
(TEST_F):
- UIProcess/API/efl/tests/test_ewk2_context.cpp:
Added test case to test getter of application_cache_manager.
(TEST_F):
- 9:31 PM Changeset in webkit [165717] by
-
- 3 edits in trunk/Source/WebCore
CSSValueList should assert that no null values are added to it.
<https://webkit.org/b/130315>
Add assertions in CSSValueList's append() and prepend() that we are
not adding a null value. This caught a single place in CSSParser
that was appending an alread-released RefPtr to a CSSValueList.
That list was eventually discarded anyway (due to "foundClip" now
being true), so the fix is simply to remove the adding.
Eventually we should use Ref and PassRef all over for CSSValueList,
this is just a first step on the way.
Reviewed by Darin Adler.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFillShorthand):
- css/CSSValueList.h:
(WebCore::CSSValueList::append):
(WebCore::CSSValueList::prepend):
- 8:41 PM Changeset in webkit [165716] by
-
- 2 edits in trunk/Source/WebCore
AudioBufferSourceNode stop attribute shouldn't throw exception in finished state.
https://bugs.webkit.org/show_bug.cgi?id=130000.
Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2014-03-16
Reviewed by Jer Noble.
AudioBufferSourceNode may go to FINISHED_STATE even before "stop" method is called
as silence rendered after audio data is played out when its not looping.
A call to "stop" method after this shouldn't throw exception.
- Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::stop):
- 7:44 PM Changeset in webkit [165715] by
-
- 18 edits in trunk/Source/WebKit
Source/WebKit/mac: Remove all deprecatedCharacters use from WebKit directory
https://bugs.webkit.org/show_bug.cgi?id=130305
Reviewed by Andreas Kling.
- History/BinaryPropertyList.cpp:
(BinaryPropertyListSerializer::appendStringObject): Use operator[]
instead of deprecatedCharacters.
Source/WebKit/win: Remove all deprecatedCharacters use from WebKit
https://bugs.webkit.org/show_bug.cgi?id=130305
Reviewed by Andreas Kling.
- AccessibleTextImpl.cpp:
(AccessibleText::get_text): Use BString instead of SysAllocStringLen,
which handles String directly.
(AccessibleText::get_textBeforeOffset): Ditto.
(AccessibleText::get_textAfterOffset): Ditto.
(AccessibleText::get_textAtOffset): Ditto.
(AccessibleText::get_attributes): Ditto.
- DOMCSSClasses.cpp:
(DOMCSSStyleDeclaration::getPropertyValue): Ditto.
- DOMCoreClasses.cpp:
(DOMNode::nodeValue): Ditto.
(DOMElement::getAttribute): Ditto.
(DOMElement::font): Rework this to leak a string, since it returns a
pointer to a font family name's characters with no defined lifetime.
- DOMHTMLClasses.cpp:
(DOMHTMLElement::innerText): Use BString's String-based constructor,
instead of explicitly passing a character pointer.
(DOMHTMLFormElement::action): Ditto.
(DOMHTMLFormElement::method): Ditto.
(DOMHTMLInputElement::value): Ditto.
(DOMHTMLTextAreaElement::value): Ditto.
- MarshallingHelpers.cpp:
(MarshallingHelpers::PathStringToFileCFURLRef): Use String::createCFString.
- WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::checkSpellingOfString): Use StringView::upconvertedCharacters.
(WebEditorClient::checkGrammarOfString): Ditto.
- WebDataSource.cpp:
(WebDataSource::unreachableURL): Use BString's String-based constructor,
instead of explicitly passing a character pointer.
- WebDownload.cpp:
(WebDownload::bundlePathForTargetPath): Use BString instead of SysAllocStringLen.
- WebDownloadCFNet.cpp:
(WebDownload::didFinish): Use BString's String-based constructor,
instead of explicitly passing a character pointer.
- WebDownloadCurl.cpp:
(WebDownload::didReceiveResponse): Ditto.
- WebElementPropertyBag.cpp:
(convertStringToVariant): Use BString instead of SysAllocStringLen.
- WebFrame.cpp:
(WebFrame::searchForLabelsBeforeElement): Ditto.
(WebFrame::matchLabelsAgainstElement): Ditto.
- WebHistory.cpp:
(WebHistory::addVisitedLinksToPageGroup): Use a better loop and call
visitedLinkHash, since it can take a String.
- WebKitGraphics.cpp:
(CenterTruncateStringToWidth): Use StringView::getCharactersWithUpconvert.
(RightTruncateStringToWidth): Ditto.
- WebView.cpp:
(WebView::applicationNameForUserAgent): Use BString instead of SysAllocStringLen.
(WebView::customUserAgent): Ditto.
(WebView::groupName): Ditto.
(WebView::selectedText): Ditto.
(WebView::onIMERequestReconvertString): Use StringView::getCharactersWithUpconvert.
- 4:09 PM Changeset in webkit [165714] by
-
- 7 edits in trunk/Source
Web Inspector: generated backend commands should reflect build system ENABLE settings
https://bugs.webkit.org/show_bug.cgi?id=130111
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- CMakeLists.txt:
Combine only the Inspector domains listed in INSPECTOR_DOMAINS,
instead of globbing any .json file.
- DerivedSources.make:
Force the combined inspector protocol file to be regenerated if
the content or list of domains itself changes.
Source/WebCore:
Add guards for conditional inspector domains.
For Makefile-based build systems, force regeneration of the
combined file if the list of domains has changed.
Combine only the Inspector domains listed in INSPECTOR_DOMAINS,
instead of globbing any .json file.
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.am:
- 3:42 PM Changeset in webkit [165713] by
-
- 5 edits in branches/safari-537.75-branch/Source
Versioning.
- 3:39 PM Changeset in webkit [165712] by
-
- 1 copy in tags/Safari-537.75.10
New tag.
- 2:41 PM Changeset in webkit [165711] by
-
- 2 edits in trunk/Source/WebCore
Follow-up: Double values passed to fabsf() in maxScaleFromTransform()
<http://webkit.org/b/130297>
Reviewed by Darin Adler.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::maxScaleFromTransform): Use narrowPrecisionToFloat()
instead of static_cast<float>().
- 1:21 PM Changeset in webkit [165710] by
-
- 11 edits in trunk/Source
ScriptExecutionContext::vm() should return a reference.
<https://webkit.org/b/129611>
Every ScriptExecutionContext has a VM, so this can never return null.
Made WorkerScriptController::vm() return a reference as well, since
that was needed for this change.
Reviewed by Geoffrey Garen.
- bindings/js/WorkerScriptController.h:
(WebCore::WorkerScriptController::vm):
- bindings/js/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::recompileAllJSFunctions):
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::ruleMatches):
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::vm):
- dom/ScriptExecutionContext.h:
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::execute):
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::dropProtection):
- testing/Internals.cpp:
(WebCore::Internals::parserMetaData):
- 1:13 PM Changeset in webkit [165709] by
-
- 6 edits in trunk
[GTK][CMake] Build with -fno-rtti
https://bugs.webkit.org/show_bug.cgi?id=130261
Reviewed by Martin Robinson.
.:
- Source/cmake/OptionsCommon.cmake: List the -fno-exceptions, -fno-strict-aliasing
and -fno-rtti options in the global CMAKE_C_FLAGS and CMAKE_CXX_FLAGS (-fno-rtti
is only listed in the latter). Replace -std=gnu++0x with the official -std=c++11 option.
- Source/cmake/WebKitHelpers.cmake: Stop -fno-exceptions and -fno-strict-aliasing
from being set through the WEBKIT_SET_EXTRA_COMPILER_FLAGS macro, they are now listed
in CMAKE_C_FLAGS and CMAKE_CXX_FLAGS.
- Source/cmake/gtest/CMakeLists.txt: Build GTest code with GTEST_HAS_RTTI macro defined to 0.
Tools:
- TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
defined to 0 to prevent typeid use in included GTest headers.
- 12:57 PM Changeset in webkit [165708] by
-
- 6 edits in trunk/Source/WebCore
Remove OwnPtr.h, PassOwnPtr.h header inclusions in Source/WebCore/html/parser/ code
https://bugs.webkit.org/show_bug.cgi?id=129667
Reviewed by Anders Carlsson.
Remove unnecessary inclusions of the OwnPtr.h and PassOwnPtr.h headers
in the code under Source/WebCore/html/parser/.
- html/parser/HTMLParserScheduler.h:
- html/parser/HTMLToken.h:
- html/parser/HTMLTreeBuilder.h:
- html/parser/XSSAuditor.h:
- html/parser/XSSAuditorDelegate.h:
- 12:47 PM Changeset in webkit [165707] by
-
- 14 edits in trunk/Source/WebKit2
Move GTK WebKit2 code to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=129672
Reviewed by Anders Carlsson.
Repace uses of OwnPtr and PassOwnPtr in GTK-specific WebKit2 code with std::unique_ptr.
- Shared/Downloads/Download.h:
- Shared/Downloads/soup/DownloadSoup.cpp:
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::platformInvalidate):
- UIProcess/API/gtk/PageClientImpl.cpp:
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/API/gtk/WebKitContextMenuItem.cpp:
(webkitContextMenuItemCreate):
(webkitContextMenuItemCreateForGtkItem):
(webkit_context_menu_item_new):
(webkit_context_menu_item_new_from_stock_action):
(webkit_context_menu_item_new_from_stock_action_with_label):
(webkit_context_menu_item_new_with_submenu):
(webkit_context_menu_item_new_separator):
- UIProcess/API/gtk/WebKitTextChecker.h:
- UIProcess/API/gtk/WebKitWebContext.cpp:
(createDefaultWebContext):
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseConstructed):
- WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
(WebKit::WebPrintOperationGtk::print):
- WebProcess/gtk/WebGtkExtensionManager.cpp:
(WebKit::WebGtkExtensionManager::initialize):
- WebProcess/soup/WebKitSoupRequestInputStream.cpp:
(webkitSoupRequestInputStreamPendingReadAsyncComplete):
(webkitSoupRequestInputStreamReadAsync):
- WebProcess/soup/WebSoupRequestManager.cpp:
(WebKit::WebSoupRequestManager::send):
- WebProcess/soup/WebSoupRequestManager.h:
- 12:25 PM Changeset in webkit [165706] by
-
- 2 edits in trunk/Source/WTF
Follow-up: Fix undefined behavior in WTF::equal() in StringImpl.h for i386/x86_64
<http://webkit.org/b/130283>
<rdar://problem/16281477>
Reviewed by Darin Adler.
- wtf/text/StringImpl.h:
(WTF::loadUnaligned): Restore behavior prior to r165681 for
compilers other than clang.
- 11:50 AM Changeset in webkit [165705] by
-
- 2 edits in trunk/Source/WebCore
Remove uses of "cat" in DerivedSources.make outside platform-specific rules
https://bugs.webkit.org/show_bug.cgi?id=130307
Reviewed by Anders Carlsson.
- DerivedSources.make: Use "perl -pe " instead of "cat".
- 11:43 AM Changeset in webkit [165704] by
-
- 19 edits2 deletes in trunk
Web Inspector: vended backend commands file should be generated as part of the build
https://bugs.webkit.org/show_bug.cgi?id=130110
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- JavaScriptCore.xcodeproj/project.pbxproj: Copy InspectorJSBackendCommands.js to the
private headers directory.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj: Copy InspectorWebBackendCommands.js to the
private headers directory.
Source/WebInspectorUI:
Copy the backend commands generated in other frameworks into our built products directory.
- Configurations/WebInspectorUIFramework.xcconfig: Set up variables so we can pull backend
commands files from the private headers directory of other frameworks.
- Scripts/copy-user-interface-resources.sh: Always ditto inspector backend commands.
- UserInterface/Protocol/InspectorJSBackendCommands.js: Removed.
- UserInterface/Protocol/InspectorWebBackendCommands.js: Removed.
- WebInspectorUI.vcxproj/WebInspectorUIPostBuild.cmd: Copy over the generated
backend commands files from the other frameworks.
- WebInspectorUI.xcodeproj/project.pbxproj: Add JavaScriptCore and WebCore as
framework dependencies so Xcode builds them first.
Source/WebKit2:
- PlatformGTK.cmake: Copy over generated inspector backend commands files.
Tools:
- Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
- 10:35 AM Changeset in webkit [165703] by
-
- 16 edits in trunk/Source
Remove all uses of deprecatedCharacters from JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=130304
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
- API/JSValueRef.cpp:
(JSValueMakeFromJSONString): Use characters16 in the 16-bit code path.
- API/OpaqueJSString.cpp:
(OpaqueJSString::~OpaqueJSString): Use characters 16 in the 16-bit code path.
(OpaqueJSString::identifier): Get rid of custom Identifier constructor, and
juse use the standard one that takes a String.
(OpaqueJSString::characters): Use getCharactersWithUpconvert instead of a
hand-written alternative.
- bindings/ScriptValue.cpp:
(Deprecated::jsToInspectorValue): Create InspectorString from String directly
instead of involving a character pointer. Use the String from Identifier
directly instead of making a new String.
- inspector/ContentSearchUtilities.cpp:
(Inspector::ContentSearchUtilities::createSearchRegexSource): Use StringBuilder
instead of building a String a character at a time. This is still a very slow
way to do this. Also use strchr to search for a character instead of building
a String every time just to use find on it.
- inspector/InspectorValues.cpp:
(Inspector::doubleQuoteString): Remove unnecessary trip through a
character pointer. This is still a really slow way to do this.
(Inspector::InspectorValue::parseJSON): Use StringView::upconvertedCharacters
instead of String::deprecatedCharacters. Still slow to always upconvert.
- runtime/DateConstructor.cpp: Removed unneeded include.
- runtime/DatePrototype.cpp: Ditto.
- runtime/Identifier.h: Removed deprecatedCharacters function.
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode): Added a type cast to avoid ambiguity with the two character-
appending functions from JSStringBuilder. Removed unneeded code duplicating
what JSStringBuilder already does in its character append function.
(JSC::decode): Deleted code that creates a JSStringBuilder that is never used.
(JSC::parseIntOverflow): Changed lengths to unsigned. Made only the overload that
is used outside this file have external linkage. Added a new overload that takes
a StringView.
(JSC::parseInt): Use StringView::substring to call parseIntOverflow.
(JSC::globalFuncEscape): Use JSBuilder::append in a more efficient way for a
single character.
- runtime/JSGlobalObjectFunctions.h: Removed unused overloads of parseIntOverflow.
- runtime/JSStringBuilder.h: Marked this "lightly deprecated".
(JSC::JSStringBuilder::append): Overloaded for better speed with 8-bit characters.
Made one overload private. Fixed a performance bug where we would reserve capacity
in the 8-bit buffer but then append to the 16-bit buffer.
- runtime/ObjectPrototype.cpp: Removed unneeded include.
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncFontsize): Use StringView::getCharactersWithUpconvert.
(JSC::stringProtoFuncLink): Ditto.
Source/WTF:
- wtf/dtoa.h:
(WTF::parseDouble): Added an overload that takes a StringView.
- 10:33 AM Changeset in webkit [165702] by
-
- 7 edits10 adds in trunk
[regression] foreign content not displayed in MathML
<https://webkit.org/b/124128>
Reviewed by Chris Fleizach.
Source/WebCore:
This restores foreign content in <mtext>, <mn> and <mi> elements, but only when it is "phrasing content" as defined per the HTML5 specification. Other token elements are not handled here. This change makes mspace-units.html work again on Linux.
Tests: mathml/presentation/foreign-mi-dynamic.html
mathml/presentation/foreign-mi.html
mathml/presentation/foreign-mn.html
mathml/presentation/foreign-mtext-rejected.html
mathml/presentation/foreign-mtext.html
- mathml/MathMLTextElement.cpp:
(WebCore::MathMLTextElement::createElementRenderer): create a RenderMathMLToken for mn, ms and mtext.
(WebCore::isPhrasingContent): helper function to check phrasing content, as defined by the HTML spec.
(WebCore::MathMLTextElement::childShouldCreateRenderer): <mi>, <mn>, <mtext> and, <ms> now accepts phrasing content.
- rendering/mathml/RenderMathMLToken.cpp:
(WebCore::RenderMathMLToken::RenderMathMLToken):
(WebCore::RenderMathMLToken::updateTokenContent): initialize the m_containsElement boolean when updating the token content.
(WebCore::RenderMathMLToken::updateStyle): move <mi> specific handling in its own section and only apply the single-char rule when it does not contain elements.
- rendering/mathml/RenderMathMLToken.h: add an m_containsElement boolean to handle token element specifically.
LayoutTests:
- mathml/presentation/foreign-mi-dynamic-expected.html: Added.
- mathml/presentation/foreign-mi-dynamic.html: Added.
- mathml/presentation/foreign-mi-expected-mismatch.html: Added.
- mathml/presentation/foreign-mi.html: Added.
- mathml/presentation/foreign-mn-expected-mismatch.html: Added.
- mathml/presentation/foreign-mn.html: Added.
- mathml/presentation/foreign-mtext-expected-mismatch.html: Added.
- mathml/presentation/foreign-mtext-rejected-expected.html: Added.
- mathml/presentation/foreign-mtext-rejected.html: Added.
- mathml/presentation/foreign-mtext.html: Added.
- platform/efl/TestExpectations: reenable the test.
- platform/gtk/TestExpectations: ditto.
- 10:05 AM Changeset in webkit [165701] by
-
- 2 edits in trunk/Source/WebCore
PlatformTimeRanges::nearest() truncates closestDelta values from double to float
<http://webkit.org/b/130298>
Reviewed by Darin Adler.
Fixes the following build failures using trunk clang:
WebCore/platform/graphics/PlatformTimeRanges.cpp:210:28: error: absolute value function 'fabsf' given an argument of type 'double' but has parameter of type 'float' which may cause truncation of value [-Werror,-Wabsolute-value]
closestDelta = fabsf(startTime - time);
WebCore/platform/graphics/PlatformTimeRanges.cpp:210:28: note: use function 'fabs' instead
closestDelta = fabsf(startTime - time);
fabs
WebCore/platform/graphics/PlatformTimeRanges.cpp:214:28: error: absolute value function 'fabsf' given an argument of type 'double' but has parameter of type 'float' which may cause truncation of value [-Werror,-Wabsolute-value]
closestDelta = fabsf(endTime - time);
WebCore/platform/graphics/PlatformTimeRanges.cpp:214:28: note: use function 'fabs' instead
closestDelta = fabsf(endTime - time);
fabs
- platform/graphics/PlatformTimeRanges.cpp:
(WebCore::PlatformTimeRanges::nearest): Extract start and end
time deltas into local variables so they don't have to be
computed twice, using fabs() instead of fabsf().
- 9:49 AM Changeset in webkit [165700] by
-
- 2 edits in trunk/Source/JavaScriptCore
FTL ArrayifyToStructure shouldn't fail every time that it actually arrayifies
https://bugs.webkit.org/show_bug.cgi?id=130296
Reviewed by Andreas Kling.
During the 32-bit structure ID work, the second load of the structure was removed.
That's wrong. The whole point of loading the structure ID again is that the structure
ID would have been changed by the arrayification call, and we're verifying that the
arrayification succeeded in changing the structure. If we check the old structure - as
the code was doing after the 32-bit structure ID work - then this check is guaranteed
to fail, causing a significant performance regression.
It's actually amazing that the regression wasn't bigger. The reason is that if FTL
code pathologically exits but the equivalent DFG code doesn't, then the exponential
backoff almost perfectly guarantees that we just end up in the DFG. For this code, at
the time at least, the DFG wasn't much slower so this didn't cause too much pain.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileArrayifyToStructure):
- 9:38 AM Changeset in webkit [165699] by
-
- 57 edits in trunk/Source
Optimize hasTagName when called on an HTMLElement
https://bugs.webkit.org/show_bug.cgi?id=130090
Reviewed by Antti Koivisto.
Source/WebCore:
Added new hasTagName functions that have the efficiency of hasLocalName.
but are safe.
Now we can always use hasTagName, and we'll get a compile time error if
we try to use an SVG tag name with an HTML element. All call sites that
use the more specific tag name types are more efficient, and call sites
that have a specific pointer type will get even more efficient checking
that is exactly what we used to get by calling hasLocalName.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::hasTagName): Cast explicitly to Element
since Node::hasTagName no longer works on a general QualifiedName.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isDescendantOfElementType): Use
more specific type, RenderElement, so we can call hasTagName on Element
instead of Node; eliminates an unnecessary branch.
- accessibility/AccessibilityTableColumn.cpp: Added now-needed include.
- accessibility/atk/AccessibilityObjectAtk.cpp: Ditto.
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets): Use
new for loop and full words for variable names. Also use nullptr instead
of 0. Call toHTMLElement and toSVGElement in code that checks hasTagName
since it's already checking isHTMLElement and isSVGElement.
- dom/Element.cpp:
(WebCore::attrNodeListMap): Use NeverDestroyed and put the vectors into
the map rather than putting pointers to a vector into the map.
(WebCore::attrNodeListForElement): Take a reference rather than a pointer,
and update for the change above.
(WebCore::ensureAttrNodeListForElement): Ditto.
(WebCore::removeAttrNodeListForElement): Ditto.
(WebCore::findAttrNodeInList): Ditto.
(WebCore::Element::isFocusable): Use lineageOfType<HTMLCanvasElement>
to fine the canvas rather than a hand-written loop.
(WebCore::Element::attrNodeList): Update for above changes.
(WebCore::Element::setAttributeNode): Ditto.
(WebCore::Element::attrIfExists): Ditto.
(WebCore::Element::ensureAttr): Ditto.
(WebCore::Element::detachAttrNodeFromElementWithValue): Ditto.
(WebCore::Element::detachAllAttrNodesFromElement): Ditto.
- dom/Element.h: Removed the overload of hasLocalName that takes a
QualifiedName and ignores the non-local-name parts of it. Callers should
use hasTagName instead, now that it's optimized appropriately. Added
overloads of hasTagName for all the specific qualified name types. It's
more efficient to use the Node versions of these functions rather than
using QualifiedName::matches to do the check. Removed the hasTagName and
hasLocalName functions from the Node class; the only convenience functions
needed in Node are the specific checks for tags from HTML, MathML, and SVG,
not the general purpose ones.
- dom/Node.h: Removed hasLocalName and replaced the single hasTagName
that takes a QualifiedName with three faster ones that take HTML, MathML,
and SVG qualified names instead. Also updated to use nullptr instead of 0.
- dom/PositionIterator.cpp: Added now-needed include.
- dom/Text.cpp: Ditto.
- dom/make_names.pl:
(printHeaderHead): Renamed an argument for clarity and added a definitions
argument, which is where we insert the classes derived from QualifiedName.
(printCppHead): Renamed an argument for clarity.
(printTypeHelpers): Use hasTagName rather than hasLocalName, since the
former is now optimized to be the same as what the latter was.
(printNamesHeaderFile): Define a class derived from QualifiedName that can
be used at compile time to avoid having to check the namespace.
(printNamesCppFile): Use the new more-specific type as needed.
- editing/ApplyStyleCommand.cpp:
(WebCore::isLegacyAppleStyleSpan): Use hasTagName instead of hasLocalName,
and references instead of pointers.
(WebCore::ApplyStyleCommand::ApplyStyleCommand): Removed uneeded explicit
construction of a smart pointer.
(WebCore::ApplyStyleCommand::shouldApplyInlineStyleToRun): Updated to use
the enclosingElementWithTag function by its new name.
- editing/Editor.cpp:
(WebCore::Editor::selectionUnorderedListState): Updated to use the
enclosingElementWithTag function by its new name.
(WebCore::Editor::selectionOrderedListState): Ditto.
- editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApply): Use a more-specific type for the list tag.
(WebCore::InsertListCommand::doApplyForSingleParagraph): Ditto.
- editing/InsertListCommand.h: Ditto.
- editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::serializeNodesWithNamespaces): Added an explicit
cast to Element in the loop that is already guarded by an isElementNode check.
Also use a modern C++ for loop.
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::makeInsertedContentRoundTrippableWithHTMLTreeBuilder):
Updated to use the enclosingElementWithTag function by its new name.
(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds): Ditto.
(WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent): Ditto.
- editing/TypingCommand.cpp: Added now-needed includes.
- editing/VisibleUnits.cpp: Ditto.
- editing/htmlediting.cpp:
(WebCore::enclosingElementWithTag): Changed to return an Element instead of a Node,
since nodes other than elements do not have tags.
- editing/htmlediting.h: Ditto.
- editing/mac/EditorMac.mm:
(WebCore::Editor::adjustedSelectionRange): Updated to use the enclosingElementWithTag
function by its new name.
- editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendText): Ditto.
(WebCore::StyledMarkupAccumulator::traverseNodesForSerialization): Ditto.
(WebCore::highestAncestorToWrapMarkup): Ditto.
(WebCore::createMarkupInternal): Ditto.
(WebCore::createContextualFragment): Ditto. Use hasTagName instead of hasLocalName,
since the former is now optimized to be the same as the latter was before.
- html/HTMLCollection.cpp:
(WebCore::isMatchingElement): Use hasTagName instead of hasLocalName,
since the former is now optimized to be the same as the latter was before.
(WebCore::nameShouldBeVisibleInDocumentAll): Ditto.
- html/HTMLElement.cpp:
(WebCore::HTMLElement::ieForbidsInsertHTML): Ditto.
(WebCore::unicodeBidiAttributeForDirAuto): Ditto.
(WebCore::HTMLElement::parseBorderWidthAttribute): Ditto.
(WebCore::HTMLElement::setInnerHTML): Ditto.
(WebCore::shouldProhibitSetInnerOuterText): Ditto. Added this to share code between
setInnerText and setOuterText.
(WebCore::HTMLElement::setInnerText): Ditto.
(WebCore::HTMLElement::setOuterText): Ditto.
(WebCore::HTMLElement::rendererIsNeeded): Ditto.
(WebCore::HTMLElement::createElementRenderer): Ditto.
- html/HTMLElement.h: Added hasTagName, which hides the one inherited from Element
and takes the more-specific HTMLQualifiedName type. This means we don't need to check
the namespace at runtime because it's known at compile time. Also put the
implementation of Node::hasTagName for HTMLQualifiedName into this header.
- html/HTMLObjectElement.cpp:
(WebCore::isRecognizedTagName): Updated for change in return type of
HTMLNames::getHTMLTags.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::add): Use hasTagName inastead of hasLocalName.
(WebCore::HTMLSelectElement::value): Use isHTMLOptionElement instead of hasTagName.
Also use a new style for loop and emptyString() instead of "".
(WebCore::HTMLSelectElement::setValue): Ditto.
(WebCore::HTMLSelectElement::setLength): Ditto.
(WebCore::HTMLSelectElement::searchOptionsForValue): Ditto.
(WebCore::HTMLSelectElement::restoreFormControlState): Ditto.
- html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::additionalPresentationAttributeStyle): Use hasTagName
instead of hasLocalName.
- html/HTMLTableRowsCollection.cpp:
(WebCore::isInSection): Updated to use hasTagName and take a reference.
(WebCore::HTMLTableRowsCollection::rowAfter): Pass a reference.
- html/parser/HTMLConstructionSite.cpp: Added now-needed include.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::createCaseMap): Updated to return a map rather than filling one in, and to
be flxible about the type of the table being used.
(WebCore::adjustSVGTagNameCase): Updated to use NeverDestroyed.
(WebCore::adjustAttributes): Added new helper so we can share more code. Updated
template argument names for clarity.
(WebCore::adjustSVGAttributes): Marked this inline, since it just turns around and
calls a single non-inline function.
(WebCore::adjustMathMLAttributes): Ditto.
(WebCore::addNamesWithPrefix): Changed to take argument by reference instead of pointer.
(WebCore::createForeignAttributesMap): Added. Factors out the map creation from the
function below.
(WebCore::adjustForeignAttributes): Updated for above changes.
(WebCore::HTMLTreeBuilder::processStartTagForInBody): Updated to pass reference.
(WebCore::HTMLTreeBuilder::processTokenInForeignContent): Ditto.
- inspector/InspectorStyleSheet.cpp: Added now-needed include.
- mathml/MathMLElement.h: Added hasTagName, which hides the one inherited from Element
and takes the more-specific MathMLQualifiedName type. This means we don't need to check
the namespace at runtime because it's known at compile time. Also put the
implementation of Node::hasTagName for MathMLQualifiedName into this header.
- mathml/MathMLInlineContainerElement.cpp:
(WebCore::MathMLInlineContainerElement::createElementRenderer): Use hasTagName.
- mathml/MathMLSelectElement.cpp:
(WebCore::MathMLSelectElement::attributeChanged): Use hasTagName.
(WebCore::MathMLSelectElement::getSelectedActionChildAndIndex): Ditto.
(WebCore::MathMLSelectElement::getSelectedActionChild): Ditto.
(WebCore::MathMLSelectElement::getSelectedSemanticsChild): Ditto.
(WebCore::MathMLSelectElement::updateSelectedChild): Ditto.
- mathml/MathMLTextElement.cpp:
(WebCore::MathMLTextElement::createElementRenderer): Ditto.
(WebCore::MathMLTextElement::childShouldCreateRenderer): Ditto.
- platform/gtk/PasteboardGtk.cpp: Added now-needed include.
- platform/mac/HTMLConverter.mm: Ditto.
- rendering/RenderBlockFlow.cpp: Ditto.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended): Use hasTagName.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::rendererForRootBackground): Ditto.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): Ditto.
- rendering/RenderReplaced.cpp: Added now-needed include.
- rendering/mathml/RenderMathMLScripts.cpp:
(WebCore::RenderMathMLScripts::RenderMathMLScripts): Use hasTagName.
- rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::RenderMathMLUnderOver): Ditto.
- svg/SVGElement.h: Added hasTagName, which hides the one inherited from Element
and takes the more-specific SVGQualifiedName type. This means we don't need to check
the namespace at runtime because it's known at compile time. Also put the
implementation of Node::hasTagName for SVGQualifiedName into this header.
- svg/SVGFontFaceSrcElement.cpp:
(WebCore::SVGFontFaceSrcElement::childrenChanged): Use isSVGFontFaceElement instead
of calling hasTagName.
- svg/SVGUseElement.cpp:
(WebCore::isDirectReference): Changed to take a reference and a more specific type.
(WebCore::SVGUseElement::toClipPath): Added a type cast.
(WebCore::SVGUseElement::rendererClipChild): Use more specific types so we don't
need a type cast.
- xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::parseDocumentFragment): Added explicit calls to this
unusual call site that has a good reason to use hasLocalName instead of hasTagName.
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Updated exports for QualifiedName -> HTMLQualifiedName change.
- 8:15 AM Changeset in webkit [165698] by
-
- 2 edits in trunk/Source/WebKit2
Try to fix 32-bit Mac build.
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: Add missing include.
- 4:23 AM Changeset in webkit [165697] by
-
- 2 edits in trunk/Tools
[GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
https://bugs.webkit.org/show_bug.cgi?id=128999
Patch by Diego Pino García <Diego Pino Garcia> on 2014-03-16
Reviewed by Philippe Normand.
- MiniBrowser/gtk/BrowserWindow.c:
(reloadPage):
(reloadPageIgnoringCache):
(browser_window_init):
- 4:01 AM Changeset in webkit [165696] by
-
- 2 edits in trunk
[GStreamer] CMake doesn't find the include path for gstreamer-base
https://bugs.webkit.org/show_bug.cgi?id=130098
Reviewed by Philippe Normand.
- Source/cmake/FindGStreamer.cmake: Look for a header in gstreamer-base instead of looking for gst/gst.h twice.
- 3:06 AM Changeset in webkit [165695] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, GTK build fix after r165692.
- UIProcess/gtk/TextCheckerGtk.cpp:
(WebKit::TextChecker::checkSpellingOfString):
(WebKit::TextChecker::checkGrammarOfString):
- 1:33 AM Changeset in webkit [165694] by
-
- 4 edits in trunk/Source
Stop pulling in JSDOMBinding.h via JSEventListener.h
<https://webkit.org/b/130299>
Just chippin' away at the compile time monster.
Reviewed by Darin Adler.
- bindings/js/IDBBindingUtilities.cpp:
- bindings/js/JSEventListener.h:
- 1:27 AM Changeset in webkit [165693] by
-
- 2 edits in trunk/Source/WebCore
Double values passed to fabsf() in maxScaleFromTransform()
<http://webkit.org/b/130297>
Reviewed by Darin Adler.
Fixes the following build failures using trunk clang:
WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:287:21: error: absolute value function 'fabsf' given an argument of type 'double' but has parameter of type 'float' which may cause truncation of value [-Werror,-Wabsolute-value]
return std::max(fabsf(decomposeData.scaleX), fabsf(decomposeData.scaleY));
WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:287:21: note: use function 'fabs' instead
return std::max(fabsf(decomposeData.scaleX), fabsf(decomposeData.scaleY));
fabs
WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:287:50: error: absolute value function 'fabsf' given an argument of type 'double' but has parameter of type 'float' which may cause truncation of value [-Werror,-Wabsolute-value]
return std::max(fabsf(decomposeData.scaleX), fabsf(decomposeData.scaleY));
WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:287:50: note: use function 'fabs' instead
return std::max(fabsf(decomposeData.scaleX), fabsf(decomposeData.scaleY));
fabs
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::maxScaleFromTransform): Use static_cast<float>() to
convert float values to double values.
Mar 15, 2014:
- 11:22 PM Changeset in webkit [165692] by
-
- 12 edits in trunk/Source
Remove all uses of deprecatedCharacters from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=130197
Reviewed by Andreas Kling.
Source/WebKit2:
- Shared/APIString.h: Rewrote getCharacters to use StringView,
substring, and getCharactersWithUpconvert. Added an 8-bit case
to getUTF8CString.
- Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
(WebKit::writeByte): Added.
(WebKit::writeCharacter): Added.
(WebKit::writeLine): Added. Uses operator[] instead of characters16 to get
the UTF-16 characters out of the string.
(WebKit::NetscapePluginModule::scanPlugin): Replaced code that writes out
text to stdout with much simpler version using the functions above.
- UIProcess/TextChecker.h: Changed text arguments to use StringView instead
of UChar/int pairs.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::internalShowContextMenu): Updated to pass StringView.
- UIProcess/efl/TextCheckerEfl.cpp:
(WebKit::nextWordOffset): Changed function to use StringView and unsigned.
(WebKit::TextChecker::checkTextOfParagraph): Changed to use StringView and
substring.
(WebKit::TextChecker::checkSpellingOfString): Ditto.
(WebKit::TextChecker::checkGrammarOfString): Ditto.
(WebKit::TextChecker::requestCheckingOfString): Pass in a StringView, so no
need to call deprecatedCharacters.
- UIProcess/ios/TextCheckerIOS.mm:
(WebKit::TextChecker::checkTextOfParagraph): Changed to take StringView.
(WebKit::TextChecker::checkSpellingOfString): Ditto.
(WebKit::TextChecker::checkGrammarOfString): Ditto.
- UIProcess/mac/TextCheckerMac.mm:
(WebKit::TextChecker::checkTextOfParagraph): Changed to take StringView and
use StringView::createNSStringWithoutCopying.
(WebKit::TextChecker::checkSpellingOfString): CHanged to take StringView.
(WebKit::TextChecker::checkGrammarOfString): Ditto.
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::convertStringToKeyCodes): Changed to take StringView and use
upconvertedCharacters instead of deprecatedCharacters. Also use move instead
of swap.
(WebKit::NetscapePlugin::sendComplexTextInput): Updated to new style for loop.
- WebProcess/WebPage/EncoderAdapter.cpp:
(WebKit::EncoderAdapter::encodeString): Use StringView::upconvertedCharacters
instead of String::deprecatedCharacters.
Source/WTF:
- wtf/text/StringView.h: Added new getCharactersWithUpconvert and upconvertedCharacters
functions. These are useful for callers that need UTF-16.
- 11:06 PM Changeset in webkit [165691] by
-
- 2 edits in trunk/Source/WTF
Try to fix EFL build.
- wtf/ThreadingPthreads.cpp: (WTF::changeThreadPriority): Code in this function was setting the priority of the current thread instead of the passed-in thread. That was triggering an unused variable warning in the compiler used to build for EFL. Fixed by using the thread handle instead of pthread_self.
- 11:02 PM Changeset in webkit [165690] by
-
- 6 edits2 adds in trunk/Source/JavaScriptCore
FTL should support CheckHasInstance/InstanceOf
https://bugs.webkit.org/show_bug.cgi?id=130285
Reviewed by Sam Weinig.
Fairly straightforward; I also discovered an inaccurate FIXME in the process.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- ftl/FTLAbstractHeapRepository.h:
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCheckHasInstance):
(JSC::FTL::LowerDFGToLLVM::compileInstanceOf):
- ftl/FTLOutput.h:
(JSC::FTL::Output::phi):
- tests/stress/instanceof.js: Added.
- tests/stress/instanceof-not-cell.js: Added.
- 9:57 PM Changeset in webkit [165689] by
-
- 9 edits2 adds in trunk/Source/WebCore
Move BorderEdge class to its own file.
https://bugs.webkit.org/show_bug.cgi?id=130294
Reviewed by Sam Weinig.
This is in preparation to have better encapsulation for border box decoration painting.
No change in functionality.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- rendering/BorderEdge.cpp: Added.
(WebCore::BorderEdge::BorderEdge):
(WebCore::BorderEdge::getBorderEdgeInfo):
(WebCore::BorderEdge::includesAdjacentEdges):
(WebCore::BorderEdge::obscuresBackgroundEdge):
(WebCore::BorderEdge::obscuresBackground):
(WebCore::BorderEdge::getDoubleBorderStripeWidths):
- rendering/BorderEdge.h: Added.
(WebCore::BorderEdge::edgeFlagForSide):
(WebCore::BorderEdge::includesEdge):
(WebCore::BorderEdge::edgesShareColor):
(WebCore::BorderEdge::hasVisibleColorAndStyle):
(WebCore::BorderEdge::shouldRender):
(WebCore::BorderEdge::presentButInvisible):
(WebCore::BorderEdge::widthForPainting):
(WebCore::BorderEdge::borderWidthInDevicePixel):
- rendering/RenderBoxModelObject.cpp:
(WebCore::borderStyleHasUnmatchedColorsAtCorner):
(WebCore::colorsMatchAtCorner):
(WebCore::colorNeedsAntiAliasAtCorner):
(WebCore::willBeOverdrawn):
(WebCore::joinRequiresMitre):
(WebCore::RenderBoxModelObject::paintBorderSides):
(WebCore::RenderBoxModelObject::paintTranslucentBorderSides):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::borderObscuresBackgroundEdge):
(WebCore::RenderBoxModelObject::borderObscuresBackground):
- rendering/RenderBoxModelObject.h:
- 6:27 PM Changeset in webkit [165688] by
-
- 28 edits in trunk/Source/WebCore
Fix WebCore unused parameter warnings for WebKitGTK+ CMake build
https://bugs.webkit.org/show_bug.cgi?id=130252
Reviewed by Carlos Garcia Campos.
- Modules/mediastream/HTMLMediaElementMediaStream.cpp: Fix unused parameters.
- html/RangeInputType.cpp: Ditto.
- page/gtk/EventHandlerGtk.cpp: Ditto.
- platform/graphics/cairo/GraphicsContextCairo.cpp: Ditto.
- platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp: Ditto.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: Ditto.
- platform/graphics/opengl/Extensions3DOpenGLES.cpp: Ditto.
- platform/gtk/GamepadsGtk.cpp: Ditto.
- platform/gtk/GtkClickCounter.cpp: Ditto.
- platform/gtk/GtkPopupMenu.cpp: Ditto.
- platform/gtk/GtkTouchContextHelper.cpp: Ditto.
- platform/gtk/GtkVersioning.c: Ditto.
- platform/gtk/MainFrameScrollbarGtk.cpp: Ditto.
- platform/gtk/PasteboardGtk.cpp: Ditto.
- platform/gtk/PasteboardHelper.cpp: Ditto.
- platform/gtk/RedirectedXCompositeWindow.cpp: Ditto.
- platform/gtk/RenderThemeGtk.cpp: Ditto.
- platform/gtk/RenderThemeGtk.h: Ditto.
- platform/gtk/RenderThemeGtk2.cpp: Ditto.
- platform/gtk/ScrollbarThemeGtk.cpp: Ditto.
- platform/gtk/ScrollbarThemeGtk2.cpp: Ditto.
- platform/gtk/WidgetGtk.cpp: Ditto.
- platform/network/gtk/CredentialBackingStore.cpp: Ditto.
- platform/soup/SharedBufferSoup.cpp: Ditto.
- plugins/gtk/PluginViewGtk.cpp: Ditto.
- plugins/gtk/gtk2xtbin.c: Ditto.
- rendering/InlineTextBox.cpp: Ditto.
- 5:44 PM Changeset in webkit [165687] by
-
- 10 edits in trunk/Source
It should be possible to adjust DFG and FTL compiler thread priorities
https://bugs.webkit.org/show_bug.cgi?id=130288
Reviewed by Filip Pizlo.
Added ability to change thread priorities relative to its current priority.
Created options to adjust the priority of the DFG and FTL compilation work thread
pools. For two core systems, there might be three runnable threads, the main thread,
the DFG compilation thread and the FTL compilation thread. With the same priority,
the scheduler is free to schedule whatever thread it wants. By lowering the
compilation threads, the main thread can run. Further tests may suggest better values
for the new options, priorityDeltaOfDFGCompilerThreads and priorityDeltaOfFTLCompilerThreads.
For a two-core device, this change has a net positive improvement of 1-3% across
SunSpider, Octane, Kraken and AsmBench.
- 5:17 PM Changeset in webkit [165686] by
-
- 9 edits in trunk/Source/WebCore
RenderTextControl::hasValidAvgCharWidth doesn't detect System Font
https://bugs.webkit.org/show_bug.cgi?id=130168
Reviewed by Dean Jackson.
No new tests.
- platform/graphics/Font.cpp: Moved functions from RenderTextControl
(WebCore::Font::hasValidAverageCharWidth):
(WebCore::Font::fastAverageCharWidthIfAvailable):
- platform/graphics/Font.h:
- rendering/RenderTextControl.cpp: Moved functions to Font.cpp
(WebCore::RenderTextControl::getAverageCharWidth): Removed redundant function argument
(WebCore::RenderTextControl::computeIntrinsicLogicalWidths):
- rendering/RenderTextControl.h:
- rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::getAverageCharWidth): Removed redundant function argument
- rendering/RenderTextControlMultiLine.h:
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::getAverageCharWidth): Removed redundant function argument
(WebCore::RenderTextControlSingleLine::preferredContentLogicalWidth):
- rendering/RenderTextControlSingleLine.h:
- 4:17 PM Changeset in webkit [165685] by
-
- 8 edits in trunk/Source
[iOS] Define SYSTEM_VERSION_PREFIX consistently
<http://webkit.org/b/130293>
<rdar://problem/15926359>
Reviewed by Dan Bernstein.
Source/JavaScriptCore:
- Configurations/Version.xcconfig:
(SYSTEM_VERSION_PREFIX_iphoneos): Sync with
Source/WebKit/mac/Version.xcconfig.
Source/WebCore:
- Configurations/Version.xcconfig:
(SYSTEM_VERSION_PREFIX_iphoneos): Sync with
Source/WebKit/mac/Version.xcconfig.
Source/WebInspectorUI:
- Configurations/Version.xcconfig:
(SYSTEM_VERSION_PREFIX): Sync with
Source/WebKit/mac/Version.xcconfig.
Source/WebKit2:
- Configurations/Version.xcconfig:
(SYSTEM_VERSION_PREFIX): Sync with
Source/WebKit/mac/Version.xcconfig.
- 3:44 PM Changeset in webkit [165684] by
-
- 2 edits in trunk/Tools
[GTK] Improve ninja detection in webkitdirs.pm
https://bugs.webkit.org/show_bug.cgi?id=129902
Reviewed by Daniel Bates.
- Scripts/webkitdirs.pm:
(canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
us to look for ninja-build as well.
- 3:24 PM Changeset in webkit [165683] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix build: using integer absolute value function 'abs' when argument is of floating point type
<http://webkit.org/b/130286>
Reviewed by Filip Pizlo.
Fixes the following build failure using trunk clang:
JavaScriptCore/assembler/MacroAssembler.h:992:17: error: using integer absolute value function 'abs' when argument is of floating point type [-Werror,-Wabsolute-value]
value = abs(value);
JavaScriptCore/assembler/MacroAssembler.h:992:17: note: use function 'fabs' instead
value = abs(value);
fabs
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::shouldBlindDouble): Switch from abs() to
fabs().
- 11:48 AM Changeset in webkit [165682] by
-
- 7 edits in trunk
Reinstate intialiser syntax in for-in loops
https://bugs.webkit.org/show_bug.cgi?id=130269
Reviewed by Michael Saboff.
Source/JavaScriptCore:
Disallowing the initialiser broke some sites so this patch re-allows
the syntax. We still disallow the syntax in 'of' and pattern based
enumeration.
- parser/ASTBuilder.h:
(JSC::ASTBuilder::isBindingNode):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseVarDeclarationList):
(JSC::Parser<LexerType>::parseForStatement):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::operatorStackPop):
LayoutTests:
Update and add test.
- js/parser-syntax-check-expected.txt:
- js/script-tests/parser-syntax-check.js:
- 8:21 AM Changeset in webkit [165681] by
-
- 2 edits in trunk/Source/WTF
Fix undefined behavior in WTF::equal() in StringImpl.h for i386/x86_64
<http://webkit.org/b/130283>
<rdar://problem/16281477>
Reviewed by Geoff Garen.
- wtf/text/StringImpl.h:
(WTF::loadUnaligned): Add template method.
(WTF::equal): Switch to using loadUnaligned<>().
