Timeline
Mar 17, 2014:
- 9:55 PM Changeset in webkit [165800] by
-
- 2 edits in trunk/Source/WebKit
Revert the erroneous change made by Xcode.
- WebKit.xcodeproj/project.pbxproj:
- 9:55 PM Changeset in webkit [165799] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Build fix for debug build
Unreviewed.
finalizedListItem was actually used in ASSERT. So, use ASSERT_UNUSED
instead of ASSERT.
- UIProcess/API/gtk/WebKitBackForwardListItem.cpp:
(webkitBackForwardListItemFinalized):
- 9:04 PM Changeset in webkit [165798] by
-
- 2 edits in branches/safari-537.75-branch/Source/WebKit/mac
Unreviewed build fix.
- 8:46 PM Changeset in webkit [165797] by
-
- 2 edits in trunk/Source/JavaScriptCore
V8 regexp spends most of its time in operationGetById
https://bugs.webkit.org/show_bug.cgi?id=130380
Reviewed by Filip Pizlo.
Added String.length case to tryCacheGetByID that will only help the BaseLine JIT.
When V8 regexp is run from the command line, this nets a 2% performance improvement.
When the test is run for a longer amount of time, there is much less benefit as the
DFG will emit the appropriate code for String.length. This does remove
operationGetById as the hottest function whne run from the command line.
- jit/Repatch.cpp:
(JSC::tryCacheGetByID):
- 8:28 PM Changeset in webkit [165796] by
-
- 3 edits1 add in trunk/Source/JavaScriptCore
Add one-deep cache to opaque roots hashset.
<https://webkit.org/b/130357>
The vast majority of WebCore JS wrappers will have their Document*
as the root(). This change adds a simple optimization where we cache
the last lookup and avoid going to the hashset for repeated queries.
Looks like 0.4% progression on DYEB on my MBP.
Reviewed by Mark Hahnenberg.
- JavaScriptCore.xcodeproj/project.pbxproj:
- heap/OpaqueRootSet.h: Added.
(JSC::OpaqueRootSet::OpaqueRootSet):
(JSC::OpaqueRootSet::contains):
(JSC::OpaqueRootSet::isEmpty):
(JSC::OpaqueRootSet::clear):
(JSC::OpaqueRootSet::add):
(JSC::OpaqueRootSet::size):
(JSC::OpaqueRootSet::begin):
(JSC::OpaqueRootSet::end):
- heap/SlotVisitor.h:
- 8:21 PM Changeset in webkit [165795] by
-
- 7 edits in trunk
Implement Math.hypot
https://bugs.webkit.org/show_bug.cgi?id=129486
Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-03-17
Reviewed by Darin Adler.
Source/JavaScriptCore:
- runtime/MathObject.cpp:
(JSC::MathObject::finishCreation):
(JSC::mathProtoFuncHypot):
LayoutTests:
- js/Object-getOwnPropertyNames-expected.txt:
- js/math-expected.txt:
- js/script-tests/Object-getOwnPropertyNames.js:
- js/script-tests/math.js:
- 8:17 PM Changeset in webkit [165794] by
-
- 8 edits in trunk/Source/WebKit2
[WK2] Getting rid of compilation warnings
https://bugs.webkit.org/show_bug.cgi?id=130348
Reviewed by Benjamin Poulain.
- UIProcess/API/APIHistoryClient.h:
(API::HistoryClient::didPerformClientRedirect):
(API::HistoryClient::didPerformServerRedirect):
(API::HistoryClient::didUpdateHistoryTitle):
- UIProcess/API/APILoaderClient.h:
(API::LoaderClient::didStartProvisionalLoadForFrame):
(API::LoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(API::LoaderClient::didFailProvisionalLoadWithErrorForFrame):
(API::LoaderClient::didCommitLoadForFrame):
(API::LoaderClient::didFinishLoadForFrame):
(API::LoaderClient::didFailLoadWithErrorForFrame):
(API::LoaderClient::didChangeBackForwardList):
- UIProcess/API/APIPolicyClient.h:
(API::PolicyClient::decidePolicyForNavigationAction):
(API::PolicyClient::decidePolicyForNewWindowAction):
(API::PolicyClient::decidePolicyForResponse):
(API::PolicyClient::unableToImplementPolicy):
- UIProcess/API/APIUIClient.h:
(API::UIClient::exceededDatabaseQuota):
(API::UIClient::saveDataToFileInDownloadsFolder):
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageLoaderClient):
- UIProcess/APISession.cpp:
(API::generateID):
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::viewStateDidChange):
- 8:16 PM Changeset in webkit [165793] by
-
- 7 edits in trunk/Source/WebCore
Add RemoteCommandListener support to MediaSessionManager.
https://bugs.webkit.org/show_bug.cgi?id=130354
Reviewed by Eric Carlson.
Listen for remote commands in MediaSessionManager.
- platform/audio/MediaSessionManager.cpp:
(WebCore::MediaSessionManager::addSession):
(WebCore::MediaSessionManager::removeSession):
- platform/audio/MediaSessionManager.h:
Add RemoteCommandListener to the project files:
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- 8:00 PM Changeset in webkit [165792] by
-
- 6 edits in trunk/Source/WTF
Remove most uses of deprecatedCharacter in WTF
https://bugs.webkit.org/show_bug.cgi?id=130317
Reviewed by Andreas Kling.
Re-landing after fixing the "80 instead of 0x80" typo in equalLatin1WithUTF8.
- wtf/text/AtomicString.cpp:
(WTF::HashAndUTF8CharactersTranslator::equal): Add an 8-bit code path to the
non-ASCII path.
(WTF::SubstringTranslator8::hash): Added.
(WTF::SubstringTranslator8::equal): Added.
(WTF::SubstringTranslator16::hash): Renamed class.
(WTF::SubstringTranslator16::equal): Ditto.
(WTF::AtomicString::add): Added an 8-bit code path to the substring case.
- wtf/text/Base64.cpp:
(WTF::base64Decode): Added an 8 bit code path.
(WTF::base64URLDecode): Ditto.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::find): Fixed a case that was incorrectly using characters16
without first using is8Bit. Need to return later to remove use of deprecatedCharacters.
- wtf/unicode/UTF8.cpp:
(WTF::Unicode::equalUTF16WithUTF8): Added a case for when the UTF-16 characters
are ASCII. Also removed the aEnd argument, since the caller only calls this when the
lengths are equal.
(WTF::Unicode::equalLatin1WithUTF8): Added.
- wtf/unicode/UTF8.h: Updated as described above.
- 7:45 PM Changeset in webkit [165791] by
-
- 2 edits in trunk/Tools
webkitpy test rebaseline.
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.test_default_args):
- 7:30 PM Changeset in webkit [165790] by
-
- 25 edits in branches/safari-537.75-branch/Source
Merge r165753.
- 6:52 PM Changeset in webkit [165789] by
-
- 9 edits in trunk/Source/WebKit2
Update the bundle parameters dictionary and send out KVO notifications
https://bugs.webkit.org/show_bug.cgi?id=130379
<rdar://problem/16213914>
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _setObject:forBundleParameter:]):
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.h:
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.mm:
(-[WKWebProcessBundleParameters setParameter:forKey:]):
- WebProcess/InjectedBundle/InjectedBundle.h:
- WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
(WebKit::InjectedBundle::setBundleParameter):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setInjectedBundleParameter):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- 6:44 PM Changeset in webkit [165788] by
-
- 2 edits in trunk/Source/WebCore
Rewrite WebHTMLConverter::_elementHasOwnBackgroundColor in C++
https://bugs.webkit.org/show_bug.cgi?id=130291
Reviewed by Andreas Kling.
Extracted HTMLConverterCaches::elementHasOwnBackgroundColor.
- platform/mac/HTMLConverter.mm:
(HTMLConverterCaches::elementHasOwnBackgroundColor):
(-[WebHTMLConverter _elementHasOwnBackgroundColor:]):
- 6:38 PM Changeset in webkit [165787] by
-
- 3 edits in trunk/Source/WebCore
Rewrite WebHTMLConverter::_elementIsBlockLevel in C++
https://bugs.webkit.org/show_bug.cgi?id=130287
Reviewed by Andreas Kling.
Rewrote _elementIsBlockLevel as HTMLConverterCaches::isBlockElement. Also removed the code to update
_elementIsBlockLevel in _traverseNode as computing the value of _elementIsBlockLevel is now fast.
- platform/mac/HTMLConverter.h:
- platform/mac/HTMLConverter.mm:
(HTMLConverterCaches::isBlockElement):
(-[WebHTMLConverter _elementIsBlockLevel:]):
(-[WebHTMLConverter _traverseNode:depth:embedded:]):
(-[WebHTMLConverter dealloc]):
(-[WebHTMLConverter init]):
- 6:35 PM Changeset in webkit [165786] by
-
- 4 edits in trunk/Source
Rewrite WebHTMLConverter::_getComputedFloat in C++
https://bugs.webkit.org/show_bug.cgi?id=130284
Reviewed by Andreas Kling.
Rewrote _getComputedFloat as HTMLConverterCaches::floatPropertyValueForNode.
- platform/mac/HTMLConverter.h:
- platform/mac/HTMLConverter.mm:
(HTMLConverterCaches::floatPropertyValueForNode):
(-[WebHTMLConverter _getFloat:forNode:property:]): Now that computing the float value is fast, we don't need to
store it in the cache.
(-[WebHTMLConverter dealloc]):
(-[WebHTMLConverter init]):
- 6:26 PM Changeset in webkit [165785] by
-
- 1 edit in trunk/Source/WebKit/mac/ChangeLog
Fix a bad URL in the ChangeLog of the previous commit.
- WebView/WebView.mm:
- 6:24 PM Changeset in webkit [165784] by
-
- 2 edits in trunk/Source/WebKit/mac
Remove staging code added for <http://webkit.org/b/164757> [iOS] Support network state notification using CPNetworkObserver
Reviewed by Enrica Casucci.
- WebView/WebView.mm:
- 6:21 PM Changeset in webkit [165783] by
-
- 10 edits in branches/safari-537.75-branch/Source
- 5:58 PM Changeset in webkit [165782] by
-
- 2 edits in trunk/Tools
--profile should imply --test-runner-count=1 in run-perf-tests
https://bugs.webkit.org/show_bug.cgi?id=130375
Reviewed by Benjamin Poulain.
Use the test runner count of 1 when --profile is specified but not --test-runner-count.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args): Use -1 as the default value.
(PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
should be 1.
- 5:42 PM Changeset in webkit [165781] by
-
- 5 edits in tags/Safari-538.23.1/Source
Versioning.
- 5:38 PM Changeset in webkit [165780] by
-
- 1 copy in tags/Safari-538.23.1
New tag.
- 5:34 PM Changeset in webkit [165779] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Uncaught Exception in JSContext Inspector
https://bugs.webkit.org/show_bug.cgi?id=130368
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-03-17
Reviewed by Timothy Hatcher.
- UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
(WebInspector.DOMNodeDetailsSidebarPanel.prototype._accessibilitySupported):
Feature check DOMAgent as well as the function.
- 5:05 PM Changeset in webkit [165778] by
-
- 2 edits in trunk/Source/WebKit/mac
WebKitLegacy headers should #import the relevant WebKit headers
https://bugs.webkit.org/show_bug.cgi?id=130372
<rdar://problem/16349094>
Reviewed by Dan Bernstein.
Create forwarding headers instead.
- WebKitLegacy/MigrateHeadersToLegacy.make:
- 4:53 PM Changeset in webkit [165777] by
-
- 2 edits in trunk/Source/WebKit2
Address some style nits.
- UIProcess/API/Cocoa/_WKThumbnailViewInternal.h:
- 4:49 PM Changeset in webkit [165776] by
-
- 4 edits in trunk
Address some style nits.
Source/WebKit2:
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
Tools:
- MiniBrowser/mac/WK2BrowserWindowController.m:
- 4:45 PM Changeset in webkit [165775] by
-
- 5 edits in trunk
Add transparent window support back into MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=130363
Source/WebKit2:
Reviewed by Anders Carlsson.
Expose SPI for transparent window support.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _drawsTransparentBackground]):
(-[WKWebView _setDrawsTransparentBackground:]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
Tools:
Reviewed by Anders Carlsson.
Re-enable transparent window support for WK2.
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController validateMenuItem:]):
(-[WK2BrowserWindowController toggleTransparentWindow:]):
- 4:13 PM Changeset in webkit [165774] by
-
- 9 edits in branches/safari-537.75-branch/Source/WebKit2
Merged r165657.
- 4:13 PM Changeset in webkit [165773] by
-
- 3 edits in trunk/Source/WebCore
HTMLInputElement::defaultEventHandler() shouldn't force style updates.
<https://webkit.org/b/130303>
Move the updateStyleIfNeeded() call down to TextFieldInputType instead
of doing it for every HTMLInputEvent.
There might be a better way to do this; we only want to know about this
specific element's renderer, and don't need the rest of the tree.
This is still an easy hack to avoid a lot of unnecessary work.
Reviewed by Anders Carlsson.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::forwardEvent):
- 4:04 PM Changeset in webkit [165772] by
-
- 6 edits in trunk/Source/WTF
Unreviewed, rolling out r165721.
https://bugs.webkit.org/show_bug.cgi?id=130367
It makes the debug bots flaky (Requested by benjaminp on
#webkit).
Reverted changeset:
"Remove most uses of deprecatedCharacter in WTF"
https://bugs.webkit.org/show_bug.cgi?id=130317
http://trac.webkit.org/changeset/165721
- 3:58 PM Changeset in webkit [165771] by
-
- 2 edits in branches/safari-537.75-branch/Source/WebCore
Merged r165548.
- 3:47 PM Changeset in webkit [165770] by
-
- 3 edits in branches/safari-537.75-branch/Source/WebCore
Reverse merge r165286.
- 3:42 PM Changeset in webkit [165769] by
-
- 3 edits in trunk/Source/WebKit2
Undo some accidental Gtk changes from http://trac.webkit.org/changeset/165759
- UIProcess/WebPageProxy.cpp:
- WebProcess/WebPage/WebPage.messages.in:
- 3:30 PM Changeset in webkit [165768] by
-
- 3 edits in trunk/Source/WebKit2
[WK2] URTBF after r165755 for non Apple platforms, stub functions added.
- WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:
(WebKit::InjectedBundle::platformInitialize):
- WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
(WebKit::InjectedBundle::platformInitialize):
- 3:28 PM Changeset in webkit [165767] by
-
- 5 edits in trunk/Source/WebKit2
Move convertToRange() helper to cross-platform WebPage.cpp
https://bugs.webkit.org/show_bug.cgi?id=130365
Reviewed by Tim Horton.
Also renamed it to rangeFromEditingLocationAndLength().
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::rangeFromEditingLocationAndLength):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::insertText):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::setComposition):
(WebKit::WebPage::insertText):
(WebKit::WebPage::insertDictatedText):
(WebKit::WebPage::getAttributedSubstringFromRange):
(WebKit::WebPage::characterIndexForPoint):
(WebKit::WebPage::firstRectForCharacterRange):
- 3:25 PM Changeset in webkit [165766] by
-
- 2 edits in trunk/Source/WebKit2
Follow-up fix.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.h:
- 3:15 PM Changeset in webkit [165765] by
-
- 12 edits in trunk/Source/WebCore
[WebVTT] Extending WebVTT Rendering with Regions
https://bugs.webkit.org/show_bug.cgi?id=109822
Reviewed by Eric Carlson.
Merged from Blink (patch by Victor Carbune vcarbune@chromium.org):
https://chromium.googlesource.com/chromium/blink/+/0cdebc1d76d41bfcb9c4b022e54a4fbff132225d
No new tests, as this feature is not active in default builds. New tests will be added
in an upcoming bug.
- css/mediaControls.css:
(video::-webkit-media-text-track-region):
(video::-webkit-media-text-track-region-container):
(video::-webkit-media-text-track-region-container.scrolling):
(video::-webkit-media-text-track-display):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay):
- html/track/TextTrack.cpp:
(WebCore::TextTrack::~TextTrack):
- html/track/TextTrackCue.cpp:
- html/track/TextTrackRegion.cpp:
(WebCore::TextTrackRegion::TextTrackRegion):
(WebCore::TextTrackRegion::textTrackCueContainerScrollingClass):
(WebCore::TextTrackRegion::textTrackCueContainerShadowPseudoId):
(WebCore::TextTrackRegion::textTrackRegionShadowPseudoId):
(WebCore::TextTrackRegion::appendTextTrackCueBox):
(WebCore::TextTrackRegion::displayLastTextTrackCueBox):
(WebCore::TextTrackRegion::willRemoveTextTrackCueBox):
(WebCore::TextTrackRegion::getDisplayTree):
(WebCore::TextTrackRegion::prepareRegionDisplayTree):
(WebCore::TextTrackRegion::startTimer):
(WebCore::TextTrackRegion::stopTimer):
(WebCore::TextTrackRegion::scrollTimerFired):
- html/track/TextTrackRegion.h:
(WebCore::TextTrackRegion::create):
(WebCore::TextTrackRegion::isScrollingRegion):
(WebCore::TextTrackRegion::ownerDocument):
- html/track/TextTrackRegion.idl:
- html/track/TextTrackRegionList.cpp:
(WebCore::TextTrackRegionList::getRegionById):
- html/track/VTTCue.cpp:
(WebCore::VTTCueBox::applyCSSProperties):
(WebCore::VTTCue::~VTTCue):
(WebCore::VTTCue::setIsActive):
(WebCore::VTTCue::removeDisplayTree):
- html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::createNewRegion):
- rendering/RenderVTTCue.cpp:
(WebCore::RenderVTTCue::layout):
- 3:14 PM Changeset in webkit [165764] by
-
- 2 edits in trunk/Source/WebKit2
WK2: support data detectors driven action sheet..
https://bugs.webkit.org/show_bug.cgi?id=130362
<rdar://problem/16319711>
Reviewed by Benjamin Poulain.
- UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant showDataDetectorsSheet]):
- 3:13 PM Changeset in webkit [165763] by
-
- 10 edits in trunk
[GStreamer] human readable language code for tracks
https://bugs.webkit.org/show_bug.cgi?id=124514
Reviewed by Martin Robinson.
.:
- Source/autotools/FindDependencies.m4: Add gstreamer-tag-1.0.
- Source/cmake/FindGStreamer.cmake: Same.
- Source/cmake/OptionsEfl.cmake: Same.
- Source/cmake/OptionsGTK.cmake: Same.
Source/WebCore:
- PlatformEfl.cmake: Add GSTREAMER_TAG_INCLUDE_DIRS and GSTREAMER_TAG_LIBRARIES.
- PlatformGTK.cmake: Same.
- platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
(WebCore::TrackPrivateBaseGStreamer::getLanguageCode): Run language codes though gst_tag_get_language_code_iso_639_1() to make sure they're valid.
(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfTagsChanged): Use getLanguageCode() for languages instead of just getTag().
- 2:58 PM Changeset in webkit [165762] by
-
- 5 edits in trunk/Source/WebKit2
Fix 32-bit OS X build.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.h:
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.mm:
- WebProcess/InjectedBundle/InjectedBundle.h:
- WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
(WebKit::InjectedBundle::platformInitialize):
- 2:36 PM Changeset in webkit [165761] by
-
- 3 edits in trunk/Source/WebCore
[Mac] Rewrite WebHTMLConverter::_computedStringForNode in C++
https://bugs.webkit.org/show_bug.cgi?id=130274
Reviewed by Andreas Kling.
Rewrote WebHTMLConverter::_computedStringForNode as HTMLConverterCaches::propertyValueForNode.
- platform/mac/HTMLConverter.h: Removed unused caches.
- platform/mac/HTMLConverter.mm:
(HTMLConverterCaches::computedStylePropertyForElement): Added use const String& instead of String& on property name.
(HTMLConverterCaches::inlineStylePropertyForElement): Ditto.
(HTMLConverterCaches::propertyValueForNode): Renamed and rewritten from _computedStringForNode.
(-[WebHTMLConverter _stringForNode:property:]): Simply return the computed value instead of storing it in the cache
now that the computing the value is fast.
(-[WebHTMLConverter dealloc]):
(-[WebHTMLConverter init]):
- 2:33 PM Changeset in webkit [165760] by
-
- 32 edits in trunk/Source/WebKit2
[GTK][CMake] Fix WebKit2 unused parameter warnings
https://bugs.webkit.org/show_bug.cgi?id=130316
Reviewed by Martin Robinson.
- Platform/gtk/WorkQueueGtk.cpp: Fix unused parameter warnings.
- UIProcess/API/gtk/PageClientImpl.cpp: Ditto.
- UIProcess/API/gtk/WebKitBackForwardListItem.cpp: Ditto.
- UIProcess/API/gtk/WebKitContextMenuClient.cpp: Ditto.
- UIProcess/API/gtk/WebKitContextMenuItem.cpp: Ditto.
- UIProcess/API/gtk/WebKitDownloadClient.cpp: Ditto.
- UIProcess/API/gtk/WebKitFaviconDatabase.cpp: Ditto.
- UIProcess/API/gtk/WebKitFindController.cpp: Ditto.
- UIProcess/API/gtk/WebKitFormClient.cpp: Ditto.
- UIProcess/API/gtk/WebKitGeolocationProvider.cpp: Ditto.
- UIProcess/API/gtk/WebKitLoaderClient.cpp: Ditto.
- UIProcess/API/gtk/WebKitPlugin.cpp: Ditto.
- UIProcess/API/gtk/WebKitPolicyClient.cpp: Ditto.
- UIProcess/API/gtk/WebKitRequestManagerClient.cpp: Ditto.
- UIProcess/API/gtk/WebKitTextChecker.cpp: Ditto.
- UIProcess/API/gtk/WebKitUIClient.cpp: Ditto.
- UIProcess/API/gtk/WebKitURISchemeRequest.cpp: Ditto.
- UIProcess/API/gtk/WebKitWebContext.cpp: Ditto.
- UIProcess/API/gtk/WebKitWebInspector.cpp: Ditto.
- UIProcess/API/gtk/WebKitWebView.cpp: Ditto.
- UIProcess/API/gtk/WebKitWebViewBase.cpp: Ditto.
- UIProcess/API/gtk/WebKitWebViewBaseAccessible.cpp: Ditto.
- UIProcess/API/gtk/WebViewBaseInputMethodFilter.cpp: Ditto.
- UIProcess/gtk/TextCheckerGtk.cpp: Ditto.
- UIProcess/gtk/WebContextMenuProxyGtk.cpp: Ditto.
- UIProcess/gtk/WebPopupMenuProxyGtk.cpp: Ditto.
- WebProcess/InjectedBundle/API/gtk/WebKitFrame.cpp: Ditto.
- WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp: Ditto.
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp: Ditto.
- WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp: Ditto.
- WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp: Ditto.
- 2:31 PM Changeset in webkit [165759] by
-
- 11 edits in trunk/Source/WebKit2
[Mac] Standardize on start/length in text input IPC methods
https://bugs.webkit.org/show_bug.cgi?id=130359
Reviewed by Anders Carlsson.
Some IPC methods used start/length, and others use start/end. This was confusing.
While here, changed WebPageMac.mm to not use NSMakeRange where we don't need it
(I want to move this code to WebPage.cpp, where it could be shared with iOS and
other platforms, as it doesn't depend on Foundation much).
- UIProcess/API/mac/WKView.mm:
(-[WKView insertText:replacementRange:]):
(-[WKView setMarkedText:selectedRange:replacementRange:]):
(-[WKView attributedSubstringForProposedRange:actualRange:]):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::internalShowContextMenu):
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::setComposition):
(WebKit::WebPageProxy::insertText):
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::setComposition):
(WebKit::WebPageProxy::insertText):
(WebKit::WebPageProxy::insertDictatedText):
(WebKit::WebPageProxy::getAttributedSubstringFromRange):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setComposition):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::setComposition):
(WebKit::WebPage::insertText):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::setComposition):
(WebKit::WebPage::insertText):
(WebKit::WebPage::insertDictatedText):
(WebKit::WebPage::getAttributedSubstringFromRange):
(WebKit::convertToRange):
(WebKit::WebPage::firstRectForCharacterRange):
- 2:29 PM Changeset in webkit [165758] by
-
- 7 edits3 adds3 deletes in trunk/Source
Rename WKThumbnailView to _WKThumbnailView
https://bugs.webkit.org/show_bug.cgi?id=130361
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/_WKThumbnailView.h: Renamed from Source/WebKit2/UIProcess/API/Cocoa/WKThumbnailView.h.
- UIProcess/API/Cocoa/_WKThumbnailView.mm: Renamed from Source/WebKit2/UIProcess/API/Cocoa/WKThumbnailView.mm.
(-[_WKThumbnailView initWithFrame:fromWKView:]):
(-[_WKThumbnailView _viewWasUnparented]):
(-[_WKThumbnailView _viewWasParented]):
(-[_WKThumbnailView _requestSnapshotIfNeeded]):
(-[_WKThumbnailView _didTakeSnapshot:]):
(-[_WKThumbnailView viewDidMoveToWindow]):
(-[_WKThumbnailView setScale:]):
(-[_WKThumbnailView setUsesSnapshot:]):
(-[_WKThumbnailView _setThumbnailLayer:]):
(-[_WKThumbnailView _thumbnailLayer]):
- UIProcess/API/Cocoa/_WKThumbnailViewInternal.h: Renamed from Source/WebKit2/UIProcess/API/Cocoa/WKThumbnailViewInternal.h.
- UIProcess/API/mac/WKView.mm:
(-[WKView _setThumbnailView:]):
(-[WKView _thumbnailView]):
(-[WKView _updateThumbnailViewLayer]):
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/mac/PageClientImpl.mm:
- WebKit2.xcodeproj/project.pbxproj:
- MigrateHeaders.make:
- 2:24 PM Changeset in webkit [165757] by
-
- 25 edits in trunk/Source/WebCore
Remove unnecessary JSC::Handle null checks in bindings code.
<https://webkit.org/b/130356>
Use Handle::slot() directly instead of going through Handle::get().
This avoids null checking the HandleSlot, which isn't necessary here
anyway, and the code already assumes it'll never be null.
Reviewed by Gavin Barraclough.
- bindings/js/JSCSSRuleListCustom.cpp:
(WebCore::JSCSSRuleListOwner::isReachableFromOpaqueRoots):
- bindings/js/JSCSSValueCustom.cpp:
(WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots):
(WebCore::JSCSSValueOwner::finalize):
- bindings/js/JSMutationObserverCustom.cpp:
(WebCore::JSMutationObserverOwner::isReachableFromOpaqueRoots):
- bindings/js/JSNodeCustom.cpp:
(WebCore::JSNodeOwner::isReachableFromOpaqueRoots):
- bindings/js/JSNodeListCustom.cpp:
(WebCore::JSNodeListOwner::isReachableFromOpaqueRoots):
- bindings/js/JSTextTrackCueCustom.cpp:
(WebCore::JSTextTrackCueOwner::isReachableFromOpaqueRoots):
- bindings/js/WebCoreTypedArrayController.cpp:
(WebCore::WebCoreTypedArrayController::JSArrayBufferOwner::isReachableFromOpaqueRoots):
(WebCore::WebCoreTypedArrayController::JSArrayBufferOwner::finalize):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::finalize):
- 2:11 PM Changeset in webkit [165756] by
-
- 3 edits in trunk/Source/WebCore
AX: Reducing some code by using helper function ariaElementsFromAttribute
https://bugs.webkit.org/show_bug.cgi?id=130344
Reviewed by Chris Fleizach.
Change visibility of ariaElementsFromAttribute function from private to protected
so that other classes that derives from AccessibilityRenderObject can use it.
No new tests. No behaviour change.
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::columnHeaders):
- 1:38 PM Changeset in webkit [165755] by
-
- 9 edits2 copies in trunk/Source/WebKit2
Add SPI for getting bundle parameters from the injected bundle
https://bugs.webkit.org/show_bug.cgi?id=130355
Reviewed by Dan Bernstein.
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.h: Copied from Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.mm: Copied from Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h.
(-[WKWebProcessBundleParameters initWithDictionary:]):
(-[WKWebProcessBundleParameters valueForKey:]):
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
(-[WKWebProcessPlugInController parameters]):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::InjectedBundle):
- WebProcess/InjectedBundle/InjectedBundle.h:
(WebKit::InjectedBundle::create):
- WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
(WebKit::InjectedBundle::bundleParameters):
(WebKit::InjectedBundle::platformInitialize):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
- 1:34 PM Changeset in webkit [165754] by
-
- 2 edits in trunk/Source/WebKit/mac
REGRESSION: WebKitLegacy causes ASan build to fail
<rdar://problem/16344326>
Patch by David Farler <dfarler@apple.com> on 2014-03-17
Reviewed by David Kilzer.
- Configurations/DebugRelease.xcconfig: Remove $(inherited) from
OTHER_CFLAGS, OTHER_CPLUSPLUSFLAGS, OTHER_LDFLAGS to prevent
double complete ASAN flags.
- 1:33 PM Changeset in webkit [165753] by
-
- 26 edits in trunk/Source
Provide preference to enable additional AVFoundation options
https://bugs.webkit.org/show_bug.cgi?id=130275
Reviewed by Eric Carlson.
../WebCore:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::doesHaveAttribute): Added.
- html/HTMLMediaElement.h:
- page/Settings.in: Add new attribute.
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::doesHaveAttribute): Added stub to call private player object's
implementation of doesHaveAttribute.
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::doesHaveAttribute):
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::AVFWrapper::createAssetForURL): Check the <media> object,
and notify AVFoundationCF to use URI option if relevant.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Check the <media> object,
and notify AVFoundation to use URI option if relevant.
../WebKit/mac:
- WebView/WebPreferenceKeysPrivate.h: Added new preference.
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Initialize preference to false.
(-[WebPreferences isInheritURIQueryComponentEnabled]): Added.
(-[WebPreferences setEnableInheritURIQueryComponent:]): Added.
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Handle new preference.
../WebKit/win:
- Interfaces/IWebPreferencesPrivate.idl: Added new preference.
- WebPreferenceKeysPrivate.h: Ditto.
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings): Initialize preference to false.
(WebPreferences::isInheritURIQueryComponentEnabled): Added.
(WebPreferences::setEnableInheritURIQueryComponent): Added.
- WebPreferences.h:
- WebView.cpp:
(WebView::notifyPreferencesChanged): Handle new preference.
../WebKit2:
- Shared/WebPreferencesStore.h: Added new preference.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetEnableInheritURIQueryComponent): Added.
(WKPreferencesGetEnableInheritURIQueryComponent): Added.
- UIProcess/API/C/WKPreferencesPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Handle new preference.
- 1:32 PM Changeset in webkit [165752] by
-
- 2 edits in trunk/Tools
Fix the 32-bit build; make the open panel make a WK1 window.
- MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate openDocument:]):
- 1:23 PM Changeset in webkit [165751] by
-
- 3 edits in trunk/Source/WebCore
[EME] Add NULL protections in SourceBuffer and MediaSource.
https://bugs.webkit.org/show_bug.cgi?id=130266
Reviewed by Eric Carlson.
Add NULL checks in places which may be called after a SourceBuffer has been removed:
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::monitorSourceBuffers): Protect against a SourceBuffer being removed
(and thus activeSourceBuffers being empty) when monitoring source buffer state.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::appendBufferTimerFired): Protect against SourceBuffer being removed.
(WebCore::SourceBuffer::videoTracks): Ditto.
(WebCore::SourceBuffer::audioTracks): Ditto.
(WebCore::SourceBuffer::textTracks): Ditto.
(WebCore::SourceBuffer::setActive): Ditto.
(WebCore::SourceBuffer::sourceBufferPrivateDidEndStream): Ditto.
(WebCore::SourceBuffer::hasCurrentTime): Ditto.
(WebCore::SourceBuffer::canPlayThrough): Ditto.
(WebCore::SourceBuffer::hasFutureTime): Ditto, and check for an empty buffered ranges.
- 1:19 PM Changeset in webkit [165750] by
-
- 6 edits in trunk/Source/WebKit2
[Mac] getAttributedSubstringFromRange arguments are incorrectly named
https://bugs.webkit.org/show_bug.cgi?id=130349
Reviewed by Tim Horton.
There is a mess of start/end and start/length pairs in IPC. One day we'll fix them
all, but now, let's at least name them correctly.
No behavior change.
- UIProcess/WebPageProxy.h:
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::getAttributedSubstringFromRange):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::getAttributedSubstringFromRange):
- 1:10 PM Changeset in webkit [165749] by
-
- 5 edits in trunk/Tools
Convert MiniBrowser to use WKWebView API
https://bugs.webkit.org/show_bug.cgi?id=130061
Reviewed by Anders Carlsson.
Convert the MiniBrowser WK2 window to use WebKit2 API as much
as possible.
Some functionality was removed temporarily:
- text zoom, page zoom
- reload
- pagination mode
- transparent window
- dumping source
- window.open support
- beforeUnload panel
- find in page
- MiniBrowser/mac/AppDelegate.h:
- MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate init]):
(-[BrowserAppDelegate newWindow:]):
(-[BrowserAppDelegate applicationWillTerminate:]):
(-[BrowserAppDelegate openDocument:]):
- MiniBrowser/mac/WK2BrowserWindowController.h:
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
(-[WK2BrowserWindowController dealloc]):
(-[WK2BrowserWindowController fetch:]):
(-[WK2BrowserWindowController validateMenuItem:]):
(-[WK2BrowserWindowController reload:]):
(-[WK2BrowserWindowController goBack:]):
(-[WK2BrowserWindowController goForward:]):
(-[WK2BrowserWindowController toggleZoomMode:]):
(-[WK2BrowserWindowController resetZoom:]):
(-[WK2BrowserWindowController canResetZoom]):
(-[WK2BrowserWindowController dumpSourceToConsole:]):
(-[WK2BrowserWindowController togglePaginationMode:]):
(-[WK2BrowserWindowController validateUserInterfaceItem:]):
(-[WK2BrowserWindowController windowShouldClose:]):
(-[WK2BrowserWindowController applicationTerminating]):
(-[WK2BrowserWindowController currentZoomFactor]):
(-[WK2BrowserWindowController setCurrentZoomFactor:]):
(-[WK2BrowserWindowController toggleTransparentWindow:]):
(-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
(-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
(-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
(-[WK2BrowserWindowController find:]):
(-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
(-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
(-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
(-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
(-[WK2BrowserWindowController webView:didCommitNavigation:]):
(-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
(-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
- WebKitTestRunner/PlatformWebView.h:
- WebKitTestRunner/ios/PlatformWebViewIOS.mm:
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
- 1:04 PM Changeset in webkit [165748] by
-
- 17 edits in trunk/Source
WKThumbnailView should support snapshots
https://bugs.webkit.org/show_bug.cgi?id=130335
<rdar://problem/16255139>
Reviewed by Simon Fraser.
Add a mode where WKThumbnailView takes a software snapshot of the web content,
replacing the live layer tree with said snapshot once it returns from the
web process. This may improve animation performance in cases where the
layer tree would otherwise be very complex.
- UIProcess/API/Cocoa/WKThumbnailView.h:
Add a property, usesSnapshot, which determines whether the thumbnail view
should use the live layer tree or a snapshot of the content.
- UIProcess/API/Cocoa/WKThumbnailView.mm:
(-[WKThumbnailView initWithFrame:fromWKView:]):
(-[WKThumbnailView _viewWasUnparented]):
Clear the snapshot when unparented.
(-[WKThumbnailView _viewWasParented]):
Take a snapshot of the web content when parented, if needed.
(-[WKThumbnailView _requestSnapshotIfNeeded]):
If we're using snapshots, and haven't already dispatched an async snapshot request,
and don't already have a snapshot, request a snapshot from the web process.
When it returns, use it as the contents of the WKThumbnailView layer, and
unparent the live layer tree.
(-[WKThumbnailView setScale:]):
(-[WKThumbnailView setUsesSnapshot:]):
(-[WKThumbnailView _setThumbnailLayer:]):
(-[WKThumbnailView _thumbnailLayer]):
- UIProcess/API/Cocoa/WKThumbnailViewInternal.h:
- UIProcess/API/mac/WKView.mm:
(-[WKView _setAcceleratedCompositingModeRootLayer:]):
(-[WKView _acceleratedCompositingModeRootLayer]):
WKView should always keep track of the current root layer, instead of totally
handing control over to WKThumbnailView when it is used.
(-[WKView _setThumbnailView:]):
(-[WKView _updateThumbnailViewLayer]):
(-[WKView _reparentLayerTreeInThumbnailView]):
If needed (either we're not using snapshots, or still waiting for the snapshot to be painted),
push the WKView's live layer tree into the thumbnail view.
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::internalShowContextMenu):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::takeThumbnailSnapshot):
Add a message that asynchronously returns a snapshot that respects the
current thumbnail scale and position.
(WebKit::WebPage::scaledSnapshotWithOptions):
Use some nullptr.
- WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::transform):
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
Add a getter for the DrawingArea's transform.
Rename it to rootLayerTransform.
- WebCore.exp.in:
- 12:27 PM Changeset in webkit [165747] by
-
- 3 edits in trunk/LayoutTests
Layout Test mathml/wbr-in-mroot-crash.html crashes
https://bugs.webkit.org/show_bug.cgi?id=130353
Unreviewed TestExpectations update.
- platform/efl/TestExpectations:
- platform/mac/TestExpectations:
- 11:47 AM Changeset in webkit [165746] by
-
- 29 edits in trunk
Use RunLoop objects through references instead of pointers
https://bugs.webkit.org/show_bug.cgi?id=130313
Reviewed by Andreas Kling.
Source/WebKit2:
Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
return RunLoop reference instead of a pointer.
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::didClose):
(WebKit::DatabaseProcess::didReceiveInvalidMessage):
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
(WebKit::UniqueIDBDatabase::postMainThreadTask):
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::didClose):
(WebKit::NetworkProcess::didReceiveInvalidMessage):
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::continueWillSendRequest):
- Platform/IPC/Connection.cpp:
(IPC::Connection::SyncMessageState::getOrCreate):
(IPC::Connection::SyncMessageState::SyncMessageState):
(IPC::Connection::SyncMessageState::~SyncMessageState):
(IPC::Connection::SyncMessageState::processIncomingMessage):
(IPC::Connection::SyncMessageState::dispatchMessages):
(IPC::Connection::createServerConnection):
(IPC::Connection::createClientConnection):
(IPC::Connection::Connection):
(IPC::Connection::addWorkQueueMessageReceiver):
(IPC::Connection::removeWorkQueueMessageReceiver):
(IPC::Connection::sendSyncMessage):
(IPC::Connection::sendSyncMessageFromSecondaryThread):
(IPC::Connection::waitForSyncReply):
(IPC::Connection::processIncomingMessage):
(IPC::Connection::connectionDidClose):
(IPC::Connection::dispatchDidReceiveInvalidMessage):
(IPC::Connection::enqueueIncomingMessage):
(IPC::Connection::wakeUpRunLoop):
- Platform/IPC/Connection.h:
- Platform/IPC/mac/ConnectionMac.cpp:
(IPC::Connection::receiveSourceEventHandler):
- Shared/ChildProcess.cpp:
(WebKit::ChildProcess::stopRunLoop):
- Shared/Plugins/NPObjectProxy.cpp:
(WebKit::NPObjectProxy::NP_Deallocate):
- UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
(WebKit::ProcessLauncher::launchProcess):
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::launchProcess):
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::connectToService):
(WebKit::tryPreexistingProcess):
(WebKit::createProcess):
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::getOrigins):
(WebKit::StorageManager::getStorageDetailsByOrigin):
- UIProcess/Storage/StorageManager.h:
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::pluginThreadAsyncCall):
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::unprotectPluginFromDestruction):
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::wheelEvent):
- WebProcess/WebPage/ViewUpdateDispatcher.cpp:
(WebKit::ViewUpdateDispatcher::visibleContentRectUpdate):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close):
Source/WTF:
Make RunLoop::current() and RunLoop::main() return a RunLoop reference instead
of a pointer. RunLoop::Holder now uses a Ref<RunLoop> member. Timer and TimerBase
constructors take in a RunLoop reference, with TimerBase now storing a RunLoop
reference member instead of a pointer. Platform-specific bits of the RunLoop
class are updated accordingly.
- wtf/RunLoop.cpp:
(WTF::RunLoop::Holder::Holder):
(WTF::RunLoop::Holder::runLoop):
(WTF::RunLoop::initializeMainRunLoop):
(WTF::RunLoop::current):
(WTF::RunLoop::main):
(WTF::RunLoop::isMain):
- wtf/RunLoop.h:
(WTF::RunLoop::Timer::Timer):
- wtf/cf/RunLoopCF.cpp:
(WTF::RunLoop::run):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::start):
- wtf/efl/RunLoopEfl.cpp:
(WTF::RunLoop::TimerBase::TimerBase):
- wtf/gtk/RunLoopGtk.cpp:
(WTF::RunLoop::run):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::start):
- wtf/win/RunLoopWin.cpp:
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):
Tools:
Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
return RunLoop reference instead of a pointer.
- TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
(loadedCallback):
(clickedCallback):
- 11:20 AM Changeset in webkit [165745] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Don't busy loop when the socket is full
https://bugs.webkit.org/show_bug.cgi?id=129802
Patch by Giovanni Campagna <gcampagna@src.gnome.org> on 2014-03-17
Reviewed by Carlos Garcia Campos.
When the socket is full and we see EAGAIN or EWOULDBLOCK
(because the socket is non blocking), don't busy loop by
tring to write again, instead poll() until the socket
becomes writable.
- Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::Connection::sendOutgoingMessage):
- 10:50 AM Changeset in webkit [165744] by
-
- 2 edits in trunk/Tools
sort-export-file --help doesn't work (missing 'use')
https://bugs.webkit.org/show_bug.cgi?id=130338
Reviewed by Anders Carlsson.
- Scripts/sort-export-file:
Add a missing 'use', and fix a typo in an error message.
- 10:48 AM Changeset in webkit [165743] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[GTK] Update Korean translations - Jan 15, 2014
https://bugs.webkit.org/show_bug.cgi?id=127001
Reviewed by Gustavo Noronha Silva.
- ko.po: Updated korean translations.
- 10:30 AM Changeset in webkit [165742] by
-
- 11 edits in trunk
[CSS Grid Layout] getComputedStyle() not using author's order when showing named grid lines
https://bugs.webkit.org/show_bug.cgi?id=127837
Reviewed by David Hyatt.
Source/WebCore:
Added a couple of new Vectors to store the names of the grid lines
respecting their order. They will be used to get the right outcome
for getComputedStyle().
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::addValuesForNamedGridLinesAtIndex):
(WebCore::valueForGridTrackList):
- css/StyleResolver.cpp:
(WebCore::createGridTrackList):
(WebCore::StyleResolver::applyProperty):
- rendering/style/RenderStyle.h:
- rendering/style/StyleGridData.cpp:
(WebCore::StyleGridData::StyleGridData):
- rendering/style/StyleGridData.h:
(WebCore::StyleGridData::operator==):
LayoutTests:
Grid line names are now shown using the exact same order as the one used in the CSS.
- fast/css-grid-layout/named-grid-line-get-set-expected.txt:
- fast/css-grid-layout/named-grid-line-get-set.html:
- fast/css-grid-layout/non-named-grid-line-get-set-expected.txt:
- 10:29 AM Changeset in webkit [165741] by
-
- 12 edits in trunk/Source
Fix the !ENABLE(PROMISES) build
https://bugs.webkit.org/show_bug.cgi?id=130328
Patch by Zsolt Borbely <borbezs@inf.u-szeged.hu> on 2014-03-17
Reviewed by Darin Adler.
Add missing ENABLE(PROMISES) guards.
Source/JavaScriptCore:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h:
- runtime/JSPromiseDeferred.cpp:
- runtime/JSPromiseDeferred.h:
- runtime/JSPromiseReaction.cpp:
- runtime/JSPromiseReaction.h:
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
Source/WebCore:
- bindings/js/JSDOMPromise.cpp:
- bindings/js/JSDOMPromise.h:
- 10:28 AM Changeset in webkit [165740] by
-
- 3 edits4 adds in trunk
Safari should not render a cell if the <td> is empty
https://bugs.webkit.org/show_bug.cgi?id=15273
Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2014-03-17
Reviewed by Darin Adler.
Source/WebCore:
When table cell has no children and the doctype is not present or not
correct the border for that cell should not be drawn. Firefox also
follows the same behaviour hence making the changes to make it similiar
to Firefox behaviour.
Tests: fast/table/table-cell-border-doctype.html
fast/table/table-cell-border-no-doctype.html
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintBoxDecorations):
Added condition for not drawing the border when table cell has no child
and doctype.
LayoutTests:
- fast/table/table-cell-border-doctype-expected.html: Added.
- fast/table/table-cell-border-doctype.html: Added.
- fast/table/table-cell-border-no-doctype-expected.html: Added.
- fast/table/table-cell-border-no-doctype.html: Added.
Added new test cases to check the behaviour of table cell border when
table has doctype/no doctype and table cell has child/nochild.
- 9:52 AM Changeset in webkit [165739] by
-
- 2 edits in trunk/Source/WebCore
Fix handling of <annotation> in MathMLTextElement.
https://bugs.webkit.org/show_bug.cgi?id=124128.
Reviewed by Darin Adler.
No new tests.
- mathml/MathMLTextElement.cpp:
(WebCore::MathMLTextElement::createElementRenderer): do not create the special RenderMathMLToken for the <annotation> tag.
(WebCore::MathMLTextElement::childShouldCreateRenderer): only allow text inside <annotation>.
- 9:42 AM Changeset in webkit [165738] by
-
- 5 edits1 add in trunk
[GTK][CMake] Credential storage is not enabled
https://bugs.webkit.org/show_bug.cgi?id=130149
Reviewed by Philippe Normand.
.:
- Source/cmake/OptionsGTK.cmake: Add an ENABLE_CREDENTIAL_STORAGE option to the configuration
and look libsecret when it's enabled.
- Source/cmakeconfig.h.cmake: Expose the ENABLE_CREDENTIAL_STORAGE option to the build.
Source/WebCore:
- PlatformGTK.cmake: Add the libsecret include directories and link line to the build.
- 9:40 AM Changeset in webkit [165737] by
-
- 7 edits1 add in trunk
[GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
https://bugs.webkit.org/show_bug.cgi?id=130155
Reviewed by Philippe Normand.
.:
- Source/cmake/FindGTKUnixPrint.cmake: Added.
- Source/cmake/OptionsGTK.cmake: Look for gtk+-unix-print and use it to turn on HAVE_GTK_UNIX_PRINTING.
- Source/cmakeconfig.h.cmake: Add the HAVE_GTK_UNIX_PRINTING define.
Source/WebKit2:
- PlatformGTK.cmake: Add GTK_UNIX_PRINT flags to the build.
Tools:
- TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
- 9:26 AM Changeset in webkit [165736] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed.
Addressing reviewing comments by Darin in bug #130310 that I forgot
to address before landing the changes in r165732.
https://bugs.webkit.org/show_bug.cgi?id=130310
- rendering/InlineTextBox.cpp:
- rendering/RenderLayer.cpp:
- rendering/RenderObject.cpp:
- 9:14 AM Changeset in webkit [165735] by
-
- 2 edits in trunk/Tools
[GTK] MiniBrowser fails to load injected bundle lib
https://bugs.webkit.org/show_bug.cgi?id=130332
Reviewed by Anders Carlsson.
This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
- MiniBrowser/gtk/main.c:
(main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
process is spawn.
- 8:38 AM Changeset in webkit [165734] by
-
- 2 edits in trunk/Source/WebCore
Speculative build fix for ENABLE(TELEPHONE_NUMBER_DETECTION) after r165724.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::linkifyPhoneNumbers):
- 8:02 AM Changeset in webkit [165733] by
-
- 2 edits in trunk/Source/WebCore
Only supplement Page with UserMediaController once
https://bugs.webkit.org/show_bug.cgi?id=130311
Reviewed by Darin Adler.
Don't supplement the Page with an UserMediaController object if that Page was
already supplemented with one. This avoids triggering an assertion in
Supplementable::provideSupplement() that ensures no supplement with the same key
exists yet. The cause of this is calling provideUserMediaTo() in the Internals
constructor that's using the same Page for two subsequent tests.
- Modules/mediastream/UserMediaController.cpp:
(WebCore::provideUserMediaTo):
- 7:59 AM Changeset in webkit [165732] by
-
- 4 edits in trunk/Source/WebCore
Explicitly include cstdio header for debug builds in InlineTextBox, RenderLayer, RenderObject
https://bugs.webkit.org/show_bug.cgi?id=130310
Reviewed by Darin Adler.
Building the GTK port with Clang through CMake falls into a configuration where
the cstdio header is not indirectly included in InlineTextBox, RenderLayer and
RenderObject source files. fprintf() is required for helper functions that print
out helpful debugging information in debug builds, so the cstdio header should
be included explicitly in that case.
- rendering/InlineTextBox.cpp:
- rendering/RenderLayer.cpp:
- rendering/RenderObject.cpp:
- 6:45 AM Changeset in webkit [165731] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Cleanup WebKitDOMObject
https://bugs.webkit.org/show_bug.cgi?id=130246
Reviewed by Martin Robinson.
Remove unneeded getter and fix coding style.
- bindings/gobject/WebKitDOMObject.cpp:
(webkitDOMObjectSetProperty):
(webkit_dom_object_class_init):
- 5:40 AM Changeset in webkit [165730] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][WK2] Restore cursor when moving mouse into webview
https://bugs.webkit.org/show_bug.cgi?id=130182
Reviewed by Gyuyoung Kim.
We changed mouse cursor when the type of cursor is changed.
But once mouse is moved out of webview, ewebkit will not know whether cursor
is changed or not.
So, this patch added a logic to restore the last applied type of cursor when
mouse is moved into webview again.
- UIProcess/API/efl/EwkView.cpp:
(EwkViewEventHandler<EVAS_CALLBACK_MOUSE_IN>::handleEvent):
Call updateCursor to restore the last applied type of cursor.
(EwkView::EwkView):
(EwkView::updateCursor): Extracted from setCursor.
(EwkView::setCursor):
(EwkView::handleEvasObjectAdd):
- UIProcess/API/efl/EwkView.h:
- 2:50 AM Changeset in webkit [165729] by
-
- 3 edits in trunk/Source/WTF
One more fix after r165725.
Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2014-03-17
Reviewed by Csaba Osztrogonác.
- wtf/WTFThreadData.h:
- 2:46 AM Changeset in webkit [165728] by
-
- 1 copy in releases/WebKitGTK/webkit-2.3.92
Tagging the WebKitGTK+ 2.3.92 release
- 2:45 AM Changeset in webkit [165727] by
-
- 4 edits in releases/WebKitGTK/webkit-2.4
Unreviewed. Update NEWS and Versions.m4 for 2.3.92 release.
.:
- Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Added release notes for 2.3.92.
- 2:38 AM Changeset in webkit [165726] by
-
- 2 edits in trunk/Source/WTF
Buildfix after r165725 for non Mac platforms.
Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2014-03-17
Reviewed by Csaba Osztrogonác.
- wtf/WTFThreadData.h:
- 1:29 AM Changeset in webkit [165725] by
-
- 4 edits in trunk/Source/WTF
[Mac] WTFThreadData should use _pthread_getspecific_direct().
<https://webkit.org/b/130320>
Hack WTFThreadData to use a direct key for TLS access when available.
This mechanism uses a dedicated segment register and is the same way
we implement the fast path in FastMalloc.
Reviewed by Darin Adler.
- wtf/FastMalloc.cpp:
- wtf/WTFThreadData.cpp:
(WTF::WTFThreadData::createAndRegisterForGetspecificDirect):
- wtf/WTFThreadData.h:
(WTF::wtfThreadData):
- 1:01 AM Changeset in webkit [165724] by
-
- 2 edits in trunk/Source/WebCore
Stop using deprecatedCharacters in HTMLTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=130323
Reviewed by Andreas Kling.
Keeping this separate from other patches because of concern that this could affect
page load performance.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::ExternalCharacterTokenBuffer):
Use a StringView instead of a character pointer.
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::isEmpty): Ditto.
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipAtMostOneLeadingNewline):
Ditto.
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeRemaining): Ditto.
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::giveRemainingTo): Ditto.
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeRemainingWhitespace): Ditto.
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipLeading): Ditto.
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeading): Ditto.
(WebCore::HTMLTreeBuilder::linkifyPhoneNumbers): Use StringView::upconvertedCharacters.
- 12:52 AM Changeset in webkit [165723] by
-
- 13 edits in trunk/Source/WebCore
Make some Module class constructors return PassRef.
https://bugs.webkit.org/show_bug.cgi?id=130282
Reviewed by Andreas Kling.
Make the constructor helpers for the following classes return PassRef
instead of PassRefPtr since they will never return null.
- GamepadList
- Geolocation
- NavigatorContentUtils
- NetworkInfoConnection
- Notification
- NotificationCenter
- DeviceProximityEvent
- Modules/gamepad/GamepadList.h:
(WebCore::GamepadList::create):
- Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::create):
- Modules/geolocation/Geolocation.h:
(WebCore::Geolocation::GeoNotifier::create):
- Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
(WebCore::NavigatorContentUtils::create):
- Modules/navigatorcontentutils/NavigatorContentUtils.h:
- Modules/networkinfo/NetworkInfoConnection.cpp:
(WebCore::NetworkInfoConnection::create):
- Modules/networkinfo/NetworkInfoConnection.h:
- Modules/notifications/Notification.cpp:
(WebCore::Notification::create):
- Modules/notifications/Notification.h:
- Modules/notifications/NotificationCenter.cpp:
(WebCore::NotificationCenter::create):
- Modules/notifications/NotificationCenter.h:
- Modules/proximity/DeviceProximityEvent.h:
(WebCore::DeviceProximityEvent::create):
Mar 16, 2014:
- 11:49 PM Changeset in webkit [165722] by
-
- 4 edits in trunk
.: [EFL] Enable TOUCH_SLIDER macro.
https://bugs.webkit.org/show_bug.cgi?id=130186
Patch by Kim Byung Jun <bj1987.kim@samsung.com> on 2014-03-16
Reviewed by Gyuyoung Kim.
- Source/cmake/OptionsEfl.cmake:
Tools: [EFL] Enable TOUCH_SLIDER macro
https://bugs.webkit.org/show_bug.cgi?id=130185
Patch by Kim Byung Jun <bj1987.kim@samsung.com> on 2014-03-16
Reviewed by Gyuyoung Kim.
- Scripts/webkitperl/FeatureList.pm:
- 11:37 PM Changeset in webkit [165721] by
-
- 6 edits in trunk/Source/WTF
Remove most uses of deprecatedCharacter in WTF
https://bugs.webkit.org/show_bug.cgi?id=130317
Reviewed by Andreas Kling.
- wtf/text/AtomicString.cpp:
(WTF::HashAndUTF8CharactersTranslator::equal): Add an 8-bit code path to the
non-ASCII path.
(WTF::SubstringTranslator8::hash): Added.
(WTF::SubstringTranslator8::equal): Added.
(WTF::SubstringTranslator16::hash): Renamed class.
(WTF::SubstringTranslator16::equal): Ditto.
(WTF::AtomicString::add): Added an 8-bit code path to the substring case.
- wtf/text/Base64.cpp:
(WTF::base64Decode): Added an 8 bit code path.
(WTF::base64URLDecode): Ditto.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::find): Fixed a case that was incorrectly using characters16
without first using is8Bit. Need to return later to remove use of deprecatedCharacters.
- wtf/unicode/UTF8.cpp:
(WTF::Unicode::equalUTF16WithUTF8): Added a case for when the UTF-16 characters
are ASCII. Also removed the aEnd argument, since the caller only calls this when the
lengths are equal.
(WTF::Unicode::equalLatin1WithUTF8): Added.
- wtf/unicode/UTF8.h: Updated as described above.
- 11:35 PM Changeset in webkit [165720] by
-
- 4 edits2 adds in trunk
[CSSRegions]Do not compute region range for a box unless the parent has one
https://bugs.webkit.org/show_bug.cgi?id=130249
Reviewed by Andrei Bucur.
Source/WebCore:
If the containing block does not have a region range computed, do not attempt to compute
a region range for a child. In such cases, the range computation for a child can lead to
a result that is wrong, possibly leading to an incorrect clipping.
Test: fast/regions/inline-block-flowed-in-regions.html
- rendering/RenderBlock.cpp:
(WebCore::canComputeRegionRangeForBox):
(WebCore::RenderBlock::computeRegionRangeForBoxChild):
(WebCore::RenderBlock::estimateRegionRangeForBoxChild):
(WebCore::RenderBlock::updateRegionRangeForBoxChild):
- rendering/RenderFlowThread.h:
LayoutTests:
- fast/regions/inline-block-flowed-in-regions-expected.html: Added.
- fast/regions/inline-block-flowed-in-regions.html: Added.
- 11:15 PM Changeset in webkit [165719] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(r165703): JSC tests crashing in StringImpl::destroy().
<https://webkit.org/b/130304>
Reviewed by Anders Carlsson.
Unreviewed, restoring the old behavior of OpaqueJSString::identifier()
that doesn't put a potentially unwanted string into the Identifier table.
- API/OpaqueJSString.cpp:
(OpaqueJSString::identifier):
- 10:46 PM Changeset in webkit [165718] by
-
- 9 edits4 adds in trunk/Source/WebKit2
[EFL][WK2] Add ewk_application_cache_manager APIs
https://bugs.webkit.org/show_bug.cgi?id=102853
Reviewed by Gyuyoung Kim.
Implemented application cache manager to get list of origins which stores
application cache and remove specified origin or all.
- PlatformEfl.cmake: Added newly added files.
- UIProcess/API/efl/ewk_application_cache_manager.cpp: Added.
(EwkApplicationCacheManager::EwkApplicationCacheManager):
(EwkApplicationCacheManager::~EwkApplicationCacheManager):
(Get_Origins_Data::Get_Origins_Data):
(getApplicationCacheOriginsCallback):
(ewk_application_cache_manager_origins_get):
(ewk_application_cache_origins_free):
(ewk_application_cache_manager_delete_all):
(ewk_application_cache_manager_delete):
- UIProcess/API/efl/ewk_application_cache_manager.h: Added.
- UIProcess/API/efl/ewk_application_cache_manager_private.h: Added.
(EwkApplicationCacheManager::impl):
- UIProcess/API/efl/ewk_context.cpp:
(EwkContext::applicationCacheManager):
(ewk_context_application_cache_manager_get):
- UIProcess/API/efl/ewk_context.h:
- UIProcess/API/efl/ewk_context_private.h:
- UIProcess/API/efl/ewk_security_origin_private.h:
(EwkSecurityOrigin::wkSecurityOrigin):
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.cpp:
(EWK2UnitTestServer::port):
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.h:
- UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp:
Added to test application_cache_manager.
(serverCallback):
(getOriginsCallback):
(timerCallback):
(TEST_F):
- UIProcess/API/efl/tests/test_ewk2_context.cpp:
Added test case to test getter of application_cache_manager.
(TEST_F):
- 9:31 PM Changeset in webkit [165717] by
-
- 3 edits in trunk/Source/WebCore
CSSValueList should assert that no null values are added to it.
<https://webkit.org/b/130315>
Add assertions in CSSValueList's append() and prepend() that we are
not adding a null value. This caught a single place in CSSParser
that was appending an alread-released RefPtr to a CSSValueList.
That list was eventually discarded anyway (due to "foundClip" now
being true), so the fix is simply to remove the adding.
Eventually we should use Ref and PassRef all over for CSSValueList,
this is just a first step on the way.
Reviewed by Darin Adler.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFillShorthand):
- css/CSSValueList.h:
(WebCore::CSSValueList::append):
(WebCore::CSSValueList::prepend):
- 8:41 PM Changeset in webkit [165716] by
-
- 2 edits in trunk/Source/WebCore
AudioBufferSourceNode stop attribute shouldn't throw exception in finished state.
https://bugs.webkit.org/show_bug.cgi?id=130000.
Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2014-03-16
Reviewed by Jer Noble.
AudioBufferSourceNode may go to FINISHED_STATE even before "stop" method is called
as silence rendered after audio data is played out when its not looping.
A call to "stop" method after this shouldn't throw exception.
- Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::stop):
- 7:44 PM Changeset in webkit [165715] by
-
- 18 edits in trunk/Source/WebKit
Source/WebKit/mac: Remove all deprecatedCharacters use from WebKit directory
https://bugs.webkit.org/show_bug.cgi?id=130305
Reviewed by Andreas Kling.
- History/BinaryPropertyList.cpp:
(BinaryPropertyListSerializer::appendStringObject): Use operator[]
instead of deprecatedCharacters.
Source/WebKit/win: Remove all deprecatedCharacters use from WebKit
https://bugs.webkit.org/show_bug.cgi?id=130305
Reviewed by Andreas Kling.
- AccessibleTextImpl.cpp:
(AccessibleText::get_text): Use BString instead of SysAllocStringLen,
which handles String directly.
(AccessibleText::get_textBeforeOffset): Ditto.
(AccessibleText::get_textAfterOffset): Ditto.
(AccessibleText::get_textAtOffset): Ditto.
(AccessibleText::get_attributes): Ditto.
- DOMCSSClasses.cpp:
(DOMCSSStyleDeclaration::getPropertyValue): Ditto.
- DOMCoreClasses.cpp:
(DOMNode::nodeValue): Ditto.
(DOMElement::getAttribute): Ditto.
(DOMElement::font): Rework this to leak a string, since it returns a
pointer to a font family name's characters with no defined lifetime.
- DOMHTMLClasses.cpp:
(DOMHTMLElement::innerText): Use BString's String-based constructor,
instead of explicitly passing a character pointer.
(DOMHTMLFormElement::action): Ditto.
(DOMHTMLFormElement::method): Ditto.
(DOMHTMLInputElement::value): Ditto.
(DOMHTMLTextAreaElement::value): Ditto.
- MarshallingHelpers.cpp:
(MarshallingHelpers::PathStringToFileCFURLRef): Use String::createCFString.
- WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::checkSpellingOfString): Use StringView::upconvertedCharacters.
(WebEditorClient::checkGrammarOfString): Ditto.
- WebDataSource.cpp:
(WebDataSource::unreachableURL): Use BString's String-based constructor,
instead of explicitly passing a character pointer.
- WebDownload.cpp:
(WebDownload::bundlePathForTargetPath): Use BString instead of SysAllocStringLen.
- WebDownloadCFNet.cpp:
(WebDownload::didFinish): Use BString's String-based constructor,
instead of explicitly passing a character pointer.
- WebDownloadCurl.cpp:
(WebDownload::didReceiveResponse): Ditto.
- WebElementPropertyBag.cpp:
(convertStringToVariant): Use BString instead of SysAllocStringLen.
- WebFrame.cpp:
(WebFrame::searchForLabelsBeforeElement): Ditto.
(WebFrame::matchLabelsAgainstElement): Ditto.
- WebHistory.cpp:
(WebHistory::addVisitedLinksToPageGroup): Use a better loop and call
visitedLinkHash, since it can take a String.
- WebKitGraphics.cpp:
(CenterTruncateStringToWidth): Use StringView::getCharactersWithUpconvert.
(RightTruncateStringToWidth): Ditto.
- WebView.cpp:
(WebView::applicationNameForUserAgent): Use BString instead of SysAllocStringLen.
(WebView::customUserAgent): Ditto.
(WebView::groupName): Ditto.
(WebView::selectedText): Ditto.
(WebView::onIMERequestReconvertString): Use StringView::getCharactersWithUpconvert.
- 4:09 PM Changeset in webkit [165714] by
-
- 7 edits in trunk/Source
Web Inspector: generated backend commands should reflect build system ENABLE settings
https://bugs.webkit.org/show_bug.cgi?id=130111
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- CMakeLists.txt:
Combine only the Inspector domains listed in INSPECTOR_DOMAINS,
instead of globbing any .json file.
- DerivedSources.make:
Force the combined inspector protocol file to be regenerated if
the content or list of domains itself changes.
Source/WebCore:
Add guards for conditional inspector domains.
For Makefile-based build systems, force regeneration of the
combined file if the list of domains has changed.
Combine only the Inspector domains listed in INSPECTOR_DOMAINS,
instead of globbing any .json file.
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.am:
- 3:42 PM Changeset in webkit [165713] by
-
- 5 edits in branches/safari-537.75-branch/Source
Versioning.
- 3:39 PM Changeset in webkit [165712] by
-
- 1 copy in tags/Safari-537.75.10
New tag.
- 2:41 PM Changeset in webkit [165711] by
-
- 2 edits in trunk/Source/WebCore
Follow-up: Double values passed to fabsf() in maxScaleFromTransform()
<http://webkit.org/b/130297>
Reviewed by Darin Adler.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::maxScaleFromTransform): Use narrowPrecisionToFloat()
instead of static_cast<float>().
- 1:21 PM Changeset in webkit [165710] by
-
- 11 edits in trunk/Source
ScriptExecutionContext::vm() should return a reference.
<https://webkit.org/b/129611>
Every ScriptExecutionContext has a VM, so this can never return null.
Made WorkerScriptController::vm() return a reference as well, since
that was needed for this change.
Reviewed by Geoffrey Garen.
- bindings/js/WorkerScriptController.h:
(WebCore::WorkerScriptController::vm):
- bindings/js/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::recompileAllJSFunctions):
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::ruleMatches):
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::vm):
- dom/ScriptExecutionContext.h:
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::execute):
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::dropProtection):
- testing/Internals.cpp:
(WebCore::Internals::parserMetaData):
- 1:13 PM Changeset in webkit [165709] by
-
- 6 edits in trunk
[GTK][CMake] Build with -fno-rtti
https://bugs.webkit.org/show_bug.cgi?id=130261
Reviewed by Martin Robinson.
.:
- Source/cmake/OptionsCommon.cmake: List the -fno-exceptions, -fno-strict-aliasing
and -fno-rtti options in the global CMAKE_C_FLAGS and CMAKE_CXX_FLAGS (-fno-rtti
is only listed in the latter). Replace -std=gnu++0x with the official -std=c++11 option.
- Source/cmake/WebKitHelpers.cmake: Stop -fno-exceptions and -fno-strict-aliasing
from being set through the WEBKIT_SET_EXTRA_COMPILER_FLAGS macro, they are now listed
in CMAKE_C_FLAGS and CMAKE_CXX_FLAGS.
- Source/cmake/gtest/CMakeLists.txt: Build GTest code with GTEST_HAS_RTTI macro defined to 0.
Tools:
- TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
defined to 0 to prevent typeid use in included GTest headers.
- 12:57 PM Changeset in webkit [165708] by
-
- 6 edits in trunk/Source/WebCore
Remove OwnPtr.h, PassOwnPtr.h header inclusions in Source/WebCore/html/parser/ code
https://bugs.webkit.org/show_bug.cgi?id=129667
Reviewed by Anders Carlsson.
Remove unnecessary inclusions of the OwnPtr.h and PassOwnPtr.h headers
in the code under Source/WebCore/html/parser/.
- html/parser/HTMLParserScheduler.h:
- html/parser/HTMLToken.h:
- html/parser/HTMLTreeBuilder.h:
- html/parser/XSSAuditor.h:
- html/parser/XSSAuditorDelegate.h:
- 12:47 PM Changeset in webkit [165707] by
-
- 14 edits in trunk/Source/WebKit2
Move GTK WebKit2 code to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=129672
Reviewed by Anders Carlsson.
Repace uses of OwnPtr and PassOwnPtr in GTK-specific WebKit2 code with std::unique_ptr.
- Shared/Downloads/Download.h:
- Shared/Downloads/soup/DownloadSoup.cpp:
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::platformInvalidate):
- UIProcess/API/gtk/PageClientImpl.cpp:
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/API/gtk/WebKitContextMenuItem.cpp:
(webkitContextMenuItemCreate):
(webkitContextMenuItemCreateForGtkItem):
(webkit_context_menu_item_new):
(webkit_context_menu_item_new_from_stock_action):
(webkit_context_menu_item_new_from_stock_action_with_label):
(webkit_context_menu_item_new_with_submenu):
(webkit_context_menu_item_new_separator):
- UIProcess/API/gtk/WebKitTextChecker.h:
- UIProcess/API/gtk/WebKitWebContext.cpp:
(createDefaultWebContext):
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseConstructed):
- WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
(WebKit::WebPrintOperationGtk::print):
- WebProcess/gtk/WebGtkExtensionManager.cpp:
(WebKit::WebGtkExtensionManager::initialize):
- WebProcess/soup/WebKitSoupRequestInputStream.cpp:
(webkitSoupRequestInputStreamPendingReadAsyncComplete):
(webkitSoupRequestInputStreamReadAsync):
- WebProcess/soup/WebSoupRequestManager.cpp:
(WebKit::WebSoupRequestManager::send):
- WebProcess/soup/WebSoupRequestManager.h:
- 12:25 PM Changeset in webkit [165706] by
-
- 2 edits in trunk/Source/WTF
Follow-up: Fix undefined behavior in WTF::equal() in StringImpl.h for i386/x86_64
<http://webkit.org/b/130283>
<rdar://problem/16281477>
Reviewed by Darin Adler.
- wtf/text/StringImpl.h:
(WTF::loadUnaligned): Restore behavior prior to r165681 for
compilers other than clang.
- 11:50 AM Changeset in webkit [165705] by
-
- 2 edits in trunk/Source/WebCore
Remove uses of "cat" in DerivedSources.make outside platform-specific rules
https://bugs.webkit.org/show_bug.cgi?id=130307
Reviewed by Anders Carlsson.
- DerivedSources.make: Use "perl -pe " instead of "cat".
- 11:43 AM Changeset in webkit [165704] by
-
- 19 edits2 deletes in trunk
Web Inspector: vended backend commands file should be generated as part of the build
https://bugs.webkit.org/show_bug.cgi?id=130110
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- JavaScriptCore.xcodeproj/project.pbxproj: Copy InspectorJSBackendCommands.js to the
private headers directory.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj: Copy InspectorWebBackendCommands.js to the
private headers directory.
Source/WebInspectorUI:
Copy the backend commands generated in other frameworks into our built products directory.
- Configurations/WebInspectorUIFramework.xcconfig: Set up variables so we can pull backend
commands files from the private headers directory of other frameworks.
- Scripts/copy-user-interface-resources.sh: Always ditto inspector backend commands.
- UserInterface/Protocol/InspectorJSBackendCommands.js: Removed.
- UserInterface/Protocol/InspectorWebBackendCommands.js: Removed.
- WebInspectorUI.vcxproj/WebInspectorUIPostBuild.cmd: Copy over the generated
backend commands files from the other frameworks.
- WebInspectorUI.xcodeproj/project.pbxproj: Add JavaScriptCore and WebCore as
framework dependencies so Xcode builds them first.
Source/WebKit2:
- PlatformGTK.cmake: Copy over generated inspector backend commands files.
Tools:
- Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
- 10:35 AM Changeset in webkit [165703] by
-
- 16 edits in trunk/Source
Remove all uses of deprecatedCharacters from JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=130304
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
- API/JSValueRef.cpp:
(JSValueMakeFromJSONString): Use characters16 in the 16-bit code path.
- API/OpaqueJSString.cpp:
(OpaqueJSString::~OpaqueJSString): Use characters 16 in the 16-bit code path.
(OpaqueJSString::identifier): Get rid of custom Identifier constructor, and
juse use the standard one that takes a String.
(OpaqueJSString::characters): Use getCharactersWithUpconvert instead of a
hand-written alternative.
- bindings/ScriptValue.cpp:
(Deprecated::jsToInspectorValue): Create InspectorString from String directly
instead of involving a character pointer. Use the String from Identifier
directly instead of making a new String.
- inspector/ContentSearchUtilities.cpp:
(Inspector::ContentSearchUtilities::createSearchRegexSource): Use StringBuilder
instead of building a String a character at a time. This is still a very slow
way to do this. Also use strchr to search for a character instead of building
a String every time just to use find on it.
- inspector/InspectorValues.cpp:
(Inspector::doubleQuoteString): Remove unnecessary trip through a
character pointer. This is still a really slow way to do this.
(Inspector::InspectorValue::parseJSON): Use StringView::upconvertedCharacters
instead of String::deprecatedCharacters. Still slow to always upconvert.
- runtime/DateConstructor.cpp: Removed unneeded include.
- runtime/DatePrototype.cpp: Ditto.
- runtime/Identifier.h: Removed deprecatedCharacters function.
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode): Added a type cast to avoid ambiguity with the two character-
appending functions from JSStringBuilder. Removed unneeded code duplicating
what JSStringBuilder already does in its character append function.
(JSC::decode): Deleted code that creates a JSStringBuilder that is never used.
(JSC::parseIntOverflow): Changed lengths to unsigned. Made only the overload that
is used outside this file have external linkage. Added a new overload that takes
a StringView.
(JSC::parseInt): Use StringView::substring to call parseIntOverflow.
(JSC::globalFuncEscape): Use JSBuilder::append in a more efficient way for a
single character.
- runtime/JSGlobalObjectFunctions.h: Removed unused overloads of parseIntOverflow.
- runtime/JSStringBuilder.h: Marked this "lightly deprecated".
(JSC::JSStringBuilder::append): Overloaded for better speed with 8-bit characters.
Made one overload private. Fixed a performance bug where we would reserve capacity
in the 8-bit buffer but then append to the 16-bit buffer.
- runtime/ObjectPrototype.cpp: Removed unneeded include.
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncFontsize): Use StringView::getCharactersWithUpconvert.
(JSC::stringProtoFuncLink): Ditto.
Source/WTF:
- wtf/dtoa.h:
(WTF::parseDouble): Added an overload that takes a StringView.
- 10:33 AM Changeset in webkit [165702] by
-
- 7 edits10 adds in trunk
[regression] foreign content not displayed in MathML
<https://webkit.org/b/124128>
Reviewed by Chris Fleizach.
Source/WebCore:
This restores foreign content in <mtext>, <mn> and <mi> elements, but only when it is "phrasing content" as defined per the HTML5 specification. Other token elements are not handled here. This change makes mspace-units.html work again on Linux.
Tests: mathml/presentation/foreign-mi-dynamic.html
mathml/presentation/foreign-mi.html
mathml/presentation/foreign-mn.html
mathml/presentation/foreign-mtext-rejected.html
mathml/presentation/foreign-mtext.html
- mathml/MathMLTextElement.cpp:
(WebCore::MathMLTextElement::createElementRenderer): create a RenderMathMLToken for mn, ms and mtext.
(WebCore::isPhrasingContent): helper function to check phrasing content, as defined by the HTML spec.
(WebCore::MathMLTextElement::childShouldCreateRenderer): <mi>, <mn>, <mtext> and, <ms> now accepts phrasing content.
- rendering/mathml/RenderMathMLToken.cpp:
(WebCore::RenderMathMLToken::RenderMathMLToken):
(WebCore::RenderMathMLToken::updateTokenContent): initialize the m_containsElement boolean when updating the token content.
(WebCore::RenderMathMLToken::updateStyle): move <mi> specific handling in its own section and only apply the single-char rule when it does not contain elements.
- rendering/mathml/RenderMathMLToken.h: add an m_containsElement boolean to handle token element specifically.
LayoutTests:
- mathml/presentation/foreign-mi-dynamic-expected.html: Added.
- mathml/presentation/foreign-mi-dynamic.html: Added.
- mathml/presentation/foreign-mi-expected-mismatch.html: Added.
- mathml/presentation/foreign-mi.html: Added.
- mathml/presentation/foreign-mn-expected-mismatch.html: Added.
- mathml/presentation/foreign-mn.html: Added.
- mathml/presentation/foreign-mtext-expected-mismatch.html: Added.
- mathml/presentation/foreign-mtext-rejected-expected.html: Added.
- mathml/presentation/foreign-mtext-rejected.html: Added.
- mathml/presentation/foreign-mtext.html: Added.
- platform/efl/TestExpectations: reenable the test.
- platform/gtk/TestExpectations: ditto.
- 10:05 AM Changeset in webkit [165701] by
-
- 2 edits in trunk/Source/WebCore
PlatformTimeRanges::nearest() truncates closestDelta values from double to float
<http://webkit.org/b/130298>
Reviewed by Darin Adler.
Fixes the following build failures using trunk clang:
WebCore/platform/graphics/PlatformTimeRanges.cpp:210:28: error: absolute value function 'fabsf' given an argument of type 'double' but has parameter of type 'float' which may cause truncation of value [-Werror,-Wabsolute-value]
closestDelta = fabsf(startTime - time);
WebCore/platform/graphics/PlatformTimeRanges.cpp:210:28: note: use function 'fabs' instead
closestDelta = fabsf(startTime - time);
fabs
WebCore/platform/graphics/PlatformTimeRanges.cpp:214:28: error: absolute value function 'fabsf' given an argument of type 'double' but has parameter of type 'float' which may cause truncation of value [-Werror,-Wabsolute-value]
closestDelta = fabsf(endTime - time);
WebCore/platform/graphics/PlatformTimeRanges.cpp:214:28: note: use function 'fabs' instead
closestDelta = fabsf(endTime - time);
fabs
- platform/graphics/PlatformTimeRanges.cpp:
(WebCore::PlatformTimeRanges::nearest): Extract start and end
time deltas into local variables so they don't have to be
computed twice, using fabs() instead of fabsf().
- 9:49 AM Changeset in webkit [165700] by
-
- 2 edits in trunk/Source/JavaScriptCore
FTL ArrayifyToStructure shouldn't fail every time that it actually arrayifies
https://bugs.webkit.org/show_bug.cgi?id=130296
Reviewed by Andreas Kling.
During the 32-bit structure ID work, the second load of the structure was removed.
That's wrong. The whole point of loading the structure ID again is that the structure
ID would have been changed by the arrayification call, and we're verifying that the
arrayification succeeded in changing the structure. If we check the old structure - as
the code was doing after the 32-bit structure ID work - then this check is guaranteed
to fail, causing a significant performance regression.
It's actually amazing that the regression wasn't bigger. The reason is that if FTL
code pathologically exits but the equivalent DFG code doesn't, then the exponential
backoff almost perfectly guarantees that we just end up in the DFG. For this code, at
the time at least, the DFG wasn't much slower so this didn't cause too much pain.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileArrayifyToStructure):
- 9:38 AM Changeset in webkit [165699] by
-
- 57 edits in trunk/Source
Optimize hasTagName when called on an HTMLElement
https://bugs.webkit.org/show_bug.cgi?id=130090
Reviewed by Antti Koivisto.
Source/WebCore:
Added new hasTagName functions that have the efficiency of hasLocalName.
but are safe.
Now we can always use hasTagName, and we'll get a compile time error if
we try to use an SVG tag name with an HTML element. All call sites that
use the more specific tag name types are more efficient, and call sites
that have a specific pointer type will get even more efficient checking
that is exactly what we used to get by calling hasLocalName.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::hasTagName): Cast explicitly to Element
since Node::hasTagName no longer works on a general QualifiedName.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isDescendantOfElementType): Use
more specific type, RenderElement, so we can call hasTagName on Element
instead of Node; eliminates an unnecessary branch.
- accessibility/AccessibilityTableColumn.cpp: Added now-needed include.
- accessibility/atk/AccessibilityObjectAtk.cpp: Ditto.
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets): Use
new for loop and full words for variable names. Also use nullptr instead
of 0. Call toHTMLElement and toSVGElement in code that checks hasTagName
since it's already checking isHTMLElement and isSVGElement.
- dom/Element.cpp:
(WebCore::attrNodeListMap): Use NeverDestroyed and put the vectors into
the map rather than putting pointers to a vector into the map.
(WebCore::attrNodeListForElement): Take a reference rather than a pointer,
and update for the change above.
(WebCore::ensureAttrNodeListForElement): Ditto.
(WebCore::removeAttrNodeListForElement): Ditto.
(WebCore::findAttrNodeInList): Ditto.
(WebCore::Element::isFocusable): Use lineageOfType<HTMLCanvasElement>
to fine the canvas rather than a hand-written loop.
(WebCore::Element::attrNodeList): Update for above changes.
(WebCore::Element::setAttributeNode): Ditto.
(WebCore::Element::attrIfExists): Ditto.
(WebCore::Element::ensureAttr): Ditto.
(WebCore::Element::detachAttrNodeFromElementWithValue): Ditto.
(WebCore::Element::detachAllAttrNodesFromElement): Ditto.
- dom/Element.h: Removed the overload of hasLocalName that takes a
QualifiedName and ignores the non-local-name parts of it. Callers should
use hasTagName instead, now that it's optimized appropriately. Added
overloads of hasTagName for all the specific qualified name types. It's
more efficient to use the Node versions of these functions rather than
using QualifiedName::matches to do the check. Removed the hasTagName and
hasLocalName functions from the Node class; the only convenience functions
needed in Node are the specific checks for tags from HTML, MathML, and SVG,
not the general purpose ones.
- dom/Node.h: Removed hasLocalName and replaced the single hasTagName
that takes a QualifiedName with three faster ones that take HTML, MathML,
and SVG qualified names instead. Also updated to use nullptr instead of 0.
- dom/PositionIterator.cpp: Added now-needed include.
- dom/Text.cpp: Ditto.
- dom/make_names.pl:
(printHeaderHead): Renamed an argument for clarity and added a definitions
argument, which is where we insert the classes derived from QualifiedName.
(printCppHead): Renamed an argument for clarity.
(printTypeHelpers): Use hasTagName rather than hasLocalName, since the
former is now optimized to be the same as what the latter was.
(printNamesHeaderFile): Define a class derived from QualifiedName that can
be used at compile time to avoid having to check the namespace.
(printNamesCppFile): Use the new more-specific type as needed.
- editing/ApplyStyleCommand.cpp:
(WebCore::isLegacyAppleStyleSpan): Use hasTagName instead of hasLocalName,
and references instead of pointers.
(WebCore::ApplyStyleCommand::ApplyStyleCommand): Removed uneeded explicit
construction of a smart pointer.
(WebCore::ApplyStyleCommand::shouldApplyInlineStyleToRun): Updated to use
the enclosingElementWithTag function by its new name.
- editing/Editor.cpp:
(WebCore::Editor::selectionUnorderedListState): Updated to use the
enclosingElementWithTag function by its new name.
(WebCore::Editor::selectionOrderedListState): Ditto.
- editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApply): Use a more-specific type for the list tag.
(WebCore::InsertListCommand::doApplyForSingleParagraph): Ditto.
- editing/InsertListCommand.h: Ditto.
- editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::serializeNodesWithNamespaces): Added an explicit
cast to Element in the loop that is already guarded by an isElementNode check.
Also use a modern C++ for loop.
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::makeInsertedContentRoundTrippableWithHTMLTreeBuilder):
Updated to use the enclosingElementWithTag function by its new name.
(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds): Ditto.
(WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent): Ditto.
- editing/TypingCommand.cpp: Added now-needed includes.
- editing/VisibleUnits.cpp: Ditto.
- editing/htmlediting.cpp:
(WebCore::enclosingElementWithTag): Changed to return an Element instead of a Node,
since nodes other than elements do not have tags.
- editing/htmlediting.h: Ditto.
- editing/mac/EditorMac.mm:
(WebCore::Editor::adjustedSelectionRange): Updated to use the enclosingElementWithTag
function by its new name.
- editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendText): Ditto.
(WebCore::StyledMarkupAccumulator::traverseNodesForSerialization): Ditto.
(WebCore::highestAncestorToWrapMarkup): Ditto.
(WebCore::createMarkupInternal): Ditto.
(WebCore::createContextualFragment): Ditto. Use hasTagName instead of hasLocalName,
since the former is now optimized to be the same as the latter was before.
- html/HTMLCollection.cpp:
(WebCore::isMatchingElement): Use hasTagName instead of hasLocalName,
since the former is now optimized to be the same as the latter was before.
(WebCore::nameShouldBeVisibleInDocumentAll): Ditto.
- html/HTMLElement.cpp:
(WebCore::HTMLElement::ieForbidsInsertHTML): Ditto.
(WebCore::unicodeBidiAttributeForDirAuto): Ditto.
(WebCore::HTMLElement::parseBorderWidthAttribute): Ditto.
(WebCore::HTMLElement::setInnerHTML): Ditto.
(WebCore::shouldProhibitSetInnerOuterText): Ditto. Added this to share code between
setInnerText and setOuterText.
(WebCore::HTMLElement::setInnerText): Ditto.
(WebCore::HTMLElement::setOuterText): Ditto.
(WebCore::HTMLElement::rendererIsNeeded): Ditto.
(WebCore::HTMLElement::createElementRenderer): Ditto.
- html/HTMLElement.h: Added hasTagName, which hides the one inherited from Element
and takes the more-specific HTMLQualifiedName type. This means we don't need to check
the namespace at runtime because it's known at compile time. Also put the
implementation of Node::hasTagName for HTMLQualifiedName into this header.
- html/HTMLObjectElement.cpp:
(WebCore::isRecognizedTagName): Updated for change in return type of
HTMLNames::getHTMLTags.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::add): Use hasTagName inastead of hasLocalName.
(WebCore::HTMLSelectElement::value): Use isHTMLOptionElement instead of hasTagName.
Also use a new style for loop and emptyString() instead of "".
(WebCore::HTMLSelectElement::setValue): Ditto.
(WebCore::HTMLSelectElement::setLength): Ditto.
(WebCore::HTMLSelectElement::searchOptionsForValue): Ditto.
(WebCore::HTMLSelectElement::restoreFormControlState): Ditto.
- html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::additionalPresentationAttributeStyle): Use hasTagName
instead of hasLocalName.
- html/HTMLTableRowsCollection.cpp:
(WebCore::isInSection): Updated to use hasTagName and take a reference.
(WebCore::HTMLTableRowsCollection::rowAfter): Pass a reference.
- html/parser/HTMLConstructionSite.cpp: Added now-needed include.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::createCaseMap): Updated to return a map rather than filling one in, and to
be flxible about the type of the table being used.
(WebCore::adjustSVGTagNameCase): Updated to use NeverDestroyed.
(WebCore::adjustAttributes): Added new helper so we can share more code. Updated
template argument names for clarity.
(WebCore::adjustSVGAttributes): Marked this inline, since it just turns around and
calls a single non-inline function.
(WebCore::adjustMathMLAttributes): Ditto.
(WebCore::addNamesWithPrefix): Changed to take argument by reference instead of pointer.
(WebCore::createForeignAttributesMap): Added. Factors out the map creation from the
function below.
(WebCore::adjustForeignAttributes): Updated for above changes.
(WebCore::HTMLTreeBuilder::processStartTagForInBody): Updated to pass reference.
(WebCore::HTMLTreeBuilder::processTokenInForeignContent): Ditto.
- inspector/InspectorStyleSheet.cpp: Added now-needed include.
- mathml/MathMLElement.h: Added hasTagName, which hides the one inherited from Element
and takes the more-specific MathMLQualifiedName type. This means we don't need to check
the namespace at runtime because it's known at compile time. Also put the
implementation of Node::hasTagName for MathMLQualifiedName into this header.
- mathml/MathMLInlineContainerElement.cpp:
(WebCore::MathMLInlineContainerElement::createElementRenderer): Use hasTagName.
- mathml/MathMLSelectElement.cpp:
(WebCore::MathMLSelectElement::attributeChanged): Use hasTagName.
(WebCore::MathMLSelectElement::getSelectedActionChildAndIndex): Ditto.
(WebCore::MathMLSelectElement::getSelectedActionChild): Ditto.
(WebCore::MathMLSelectElement::getSelectedSemanticsChild): Ditto.
(WebCore::MathMLSelectElement::updateSelectedChild): Ditto.
- mathml/MathMLTextElement.cpp:
(WebCore::MathMLTextElement::createElementRenderer): Ditto.
(WebCore::MathMLTextElement::childShouldCreateRenderer): Ditto.
- platform/gtk/PasteboardGtk.cpp: Added now-needed include.
- platform/mac/HTMLConverter.mm: Ditto.
- rendering/RenderBlockFlow.cpp: Ditto.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended): Use hasTagName.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::rendererForRootBackground): Ditto.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): Ditto.
- rendering/RenderReplaced.cpp: Added now-needed include.
- rendering/mathml/RenderMathMLScripts.cpp:
(WebCore::RenderMathMLScripts::RenderMathMLScripts): Use hasTagName.
- rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::RenderMathMLUnderOver): Ditto.
- svg/SVGElement.h: Added hasTagName, which hides the one inherited from Element
and takes the more-specific SVGQualifiedName type. This means we don't need to check
the namespace at runtime because it's known at compile time. Also put the
implementation of Node::hasTagName for SVGQualifiedName into this header.
- svg/SVGFontFaceSrcElement.cpp:
(WebCore::SVGFontFaceSrcElement::childrenChanged): Use isSVGFontFaceElement instead
of calling hasTagName.
- svg/SVGUseElement.cpp:
(WebCore::isDirectReference): Changed to take a reference and a more specific type.
(WebCore::SVGUseElement::toClipPath): Added a type cast.
(WebCore::SVGUseElement::rendererClipChild): Use more specific types so we don't
need a type cast.
- xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::parseDocumentFragment): Added explicit calls to this
unusual call site that has a good reason to use hasLocalName instead of hasTagName.
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Updated exports for QualifiedName -> HTMLQualifiedName change.
- 8:15 AM Changeset in webkit [165698] by
-
- 2 edits in trunk/Source/WebKit2
Try to fix 32-bit Mac build.
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: Add missing include.
- 4:23 AM Changeset in webkit [165697] by
-
- 2 edits in trunk/Tools
[GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
https://bugs.webkit.org/show_bug.cgi?id=128999
Patch by Diego Pino García <Diego Pino Garcia> on 2014-03-16
Reviewed by Philippe Normand.
- MiniBrowser/gtk/BrowserWindow.c:
(reloadPage):
(reloadPageIgnoringCache):
(browser_window_init):
- 4:01 AM Changeset in webkit [165696] by
-
- 2 edits in trunk
[GStreamer] CMake doesn't find the include path for gstreamer-base
https://bugs.webkit.org/show_bug.cgi?id=130098
Reviewed by Philippe Normand.
- Source/cmake/FindGStreamer.cmake: Look for a header in gstreamer-base instead of looking for gst/gst.h twice.
- 3:06 AM Changeset in webkit [165695] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, GTK build fix after r165692.
- UIProcess/gtk/TextCheckerGtk.cpp:
(WebKit::TextChecker::checkSpellingOfString):
(WebKit::TextChecker::checkGrammarOfString):
- 1:33 AM Changeset in webkit [165694] by
-
- 4 edits in trunk/Source
Stop pulling in JSDOMBinding.h via JSEventListener.h
<https://webkit.org/b/130299>
Just chippin' away at the compile time monster.
Reviewed by Darin Adler.
- bindings/js/IDBBindingUtilities.cpp:
- bindings/js/JSEventListener.h:
- 1:27 AM Changeset in webkit [165693] by
-
- 2 edits in trunk/Source/WebCore
Double values passed to fabsf() in maxScaleFromTransform()
<http://webkit.org/b/130297>
Reviewed by Darin Adler.
Fixes the following build failures using trunk clang:
WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:287:21: error: absolute value function 'fabsf' given an argument of type 'double' but has parameter of type 'float' which may cause truncation of value [-Werror,-Wabsolute-value]
return std::max(fabsf(decomposeData.scaleX), fabsf(decomposeData.scaleY));
WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:287:21: note: use function 'fabs' instead
return std::max(fabsf(decomposeData.scaleX), fabsf(decomposeData.scaleY));
fabs
WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:287:50: error: absolute value function 'fabsf' given an argument of type 'double' but has parameter of type 'float' which may cause truncation of value [-Werror,-Wabsolute-value]
return std::max(fabsf(decomposeData.scaleX), fabsf(decomposeData.scaleY));
WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:287:50: note: use function 'fabs' instead
return std::max(fabsf(decomposeData.scaleX), fabsf(decomposeData.scaleY));
fabs
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::maxScaleFromTransform): Use static_cast<float>() to
convert float values to double values.
