Context Navigation

← Previous Period
Next Period →

Timeline

Mar 18, 2014:

11:57 PM Changeset in webkit [165873] by abucur@adobe.com

5 edits
2 adds in trunk

[CSS Regions] Strange layout for content with region breaks
https://bugs.webkit.org/show_bug.cgi?id=121318

Reviewed by Mihnea Ovidenie.

Source/WebCore:

When break-inside: avoid is used on an element, the implementation tries to
force it inside a single fragmentation container even though the descendants
of the element specify forced breaks. This leads to unexpected results and
unstable layout.

The change extends the definition of unsplittable elements for flow threads
using the same conditions found inside RenderBlockFlow::adjustForUnsplittableChild.
This change forces elements that require break avoidance to have a single region
in the region range. As a result, forced breaks have no effect inside them.

It should be noted this may not the behavior defined by the CSS3 Fragmentation spec.
From my understanding of the text, forced breaks override any avoidance specified
by ancestor elements. However, implementing this is a larger change that will require
a fundamental new approach in handling break avoidance. This patch just brings
consistency to the API.

Test: fast/regions/forced-break-inside-avoid-break.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::childBoxIsUnsplittableForFragmentation):
(WebCore::RenderBlock::computeRegionRangeForBoxChild):
(WebCore::RenderBlock::estimateRegionRangeForBoxChild):

rendering/RenderBlock.h:
rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::adjustForUnsplittableChild): Move the avoidance conditions inside
a helper method RenderBlock::childBoxIsUnsplittableForFragmentation.

LayoutTests:

The test verifies that elements specifying break-inside: avoid can't
be splitted by forced breaks applied inside of them.

fast/regions/forced-break-inside-avoid-break-expected.txt: Added.
fast/regions/forced-break-inside-avoid-break.html: Added.

11:55 PM Changeset in webkit [165872] by timothy_horton@apple.com

10 edits in trunk/Source/WebKit2

[iOS][WebKit2] Provide generic software-snapshotting API
https://bugs.webkit.org/show_bug.cgi?id=130385
<rdar://problem/16005957>

Reviewed by Sam Weinig.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLayerTree:WebKit::]):
(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):

UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/API/Cocoa/_WKThumbnailView.mm:

(-[_WKThumbnailView initWithFrame:fromWKView:]):
(-[_WKThumbnailView _requestSnapshotIfNeeded]):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::internalShowContextMenu):

UIProcess/WebPageProxy.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::takeSnapshot):
(WebKit::WebPage::scaledSnapshotWithOptions):
(WebKit::WebPage::snapshotAtSize):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Rename TakeThumbnailSnapshot message to TakeSnapshot.

Fill the snapshot image with the FrameView's background color, to avoid
half-pixel alpha around the edges.

Factor snapshotAtSize out of scaledSnapshotWithOptions.

Don't apply both the custom and device scale factor to the base CTM,
only the device scale factor. Custom scale factor should only be
applied to the user CTM.

Shared/ImageOptions.h:

Add a snapshot option, RespectDrawingAreaTransform, that maps
the rect through the drawing area's root layer transform.
Use this in place of the thumbnail-specific code in TakeThumbnailSnapshot.
Add a snapshot option, ExcludeDeviceScaleFactor, which means that
snapshotting will not factor the device scale in (useful for drawing
to a bitmap at an exact requested size).

11:22 PM Changeset in webkit [165871] by jer.noble@apple.com

4 edits in branches/safari-537.75-branch/Source

Unreviewed Win64 build fix; explicit operators are not valid in VS2010.

Source/WebCore:

With the 'explicit bool' operator removed, just test weakThis.get() explicitly.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::checkPlayability):

Source/WTF:

wtf/WeakPtr.h: Remove the 'explicit bool' operator.

11:16 PM Changeset in webkit [165870] by Samuel White

22 edits
2 adds in trunk

AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
https://bugs.webkit.org/show_bug.cgi?id=130250

Reviewed by Chris Fleizach.

Source/WebCore:

If initial selection isn't set when we handle selection movement for accessibility, we need to set it. If we don't, using arrow
keys to read text with VoiceOver doesn't work as expected. Things will only start working after the user holds shift and arrows
around to select any arbitrary thing to force selection to get set. This logic handles that special case more gracefully.

Test: platform/mac/accessibility/selection-initial.html

page/EventHandler.cpp:

(WebCore::handleKeyboardSelectionMovement):
(WebCore::EventHandler::handleKeyboardSelectionMovementForAccessibility):

testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):

Source/WebKit:

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/mac:

Added ability to toggle enhanced accessibility on and off to support tests that require it.

WebView/WebFrame.mm:

(-[WebFrame enhancedAccessibilityEnabled]):
(-[WebFrame setEnhancedAccessibility:]):

WebView/WebFramePrivate.h:

Source/WebKit2:

Added ability to toggle enhanced accessibility on and off to support tests that require it.

WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKAccessibilityEnableEnhancedAccessibility):
(WKAccessibilityEnhancedAccessibilityEnabled):

WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:

Tools:

Added ability to toggle enhanced accessibility on and off to support tests that require it.

DumpRenderTree/AccessibilityController.cpp:

(enableEnhancedAccessibilityCallback):
(getEnhancedAccessibilityEnabledCallback):
(AccessibilityController::getJSClass):

DumpRenderTree/AccessibilityController.h:
DumpRenderTree/atk/AccessibilityControllerAtk.cpp:

(AccessibilityController::enableEnhancedAccessibility):
(AccessibilityController::enhancedAccessibilityEnabled):

DumpRenderTree/ios/AccessibilityControllerIOS.mm:

(AccessibilityController::enableEnhancedAccessibility):
(AccessibilityController::enhancedAccessibilityEnabled):

DumpRenderTree/mac/AccessibilityControllerMac.mm:

(AccessibilityController::enableEnhancedAccessibility):
(AccessibilityController::enhancedAccessibilityEnabled):

DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::enableEnhancedAccessibility):
(AccessibilityController::enhancedAccessibilityEnabled):

WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:

(WTR::AccessibilityController::enableEnhancedAccessibility):
(WTR::AccessibilityController::enhancedAccessibilityEnabled):

WebKitTestRunner/InjectedBundle/AccessibilityController.h:
WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:

LayoutTests:

Added test to ensure that initial selection gets set when enhanced accessibility is enabled and an arrow key is pressed.

platform/mac/accessibility/selection-initial-expected.txt: Added.
platform/mac/accessibility/selection-initial.html: Added.

9:44 PM Changeset in webkit [165869] by fpizlo@apple.com

11 edits
2 deletes in trunk/Source/JavaScriptCore

Get rid of Flush in SSA
https://bugs.webkit.org/show_bug.cgi?id=130440

Reviewed by Sam Weinig.

This is basically a red patch. We used to use backwards flow for determining what was
flushed, until it became clear that this doesn't make sense. Now the Flush nodes don't
accomplish anything. Keeping them around in SSA can only make things hard.

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.xcodeproj/project.pbxproj:
dfg/DFGBasicBlock.cpp:

(JSC::DFG::BasicBlock::SSAData::SSAData):

dfg/DFGBasicBlock.h:
dfg/DFGFlushLivenessAnalysisPhase.cpp: Removed.
dfg/DFGFlushLivenessAnalysisPhase.h: Removed.
dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

dfg/DFGSSAConversionPhase.cpp:

(JSC::DFG::SSAConversionPhase::run):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):

8:07 PM Changeset in webkit [165868] by fpizlo@apple.com

2 edits in trunk/Tools

Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
yet).

Scripts/webkitpy/common/config/contributors.json:

7:54 PM Changeset in webkit [165867] by Brent Fulgham

16 edits
5 adds in trunk

TextTrackRegion Not Implemented
https://bugs.webkit.org/show_bug.cgi?id=116546

Reviewed by Eric Carlson.

Merged from Blink (patch by vcarbune@chromium.org):
https://chromium.googlesource.com/chromium/blink/+/4940f89a087fea5b5ea628e98d0b355d398a9eea
http://crbug.com/25798003

Source/WebCore:

Tests: media/track/regions-webvtt/text-track-region-display.html

media/track/regions-webvtt/text-track-region-dom-layout.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::newRegionsAvailable):

html/track/TextTrack.cpp:
html/track/TextTrack.h:
html/track/TextTrackRegion.cpp:

(WebCore::TextTrackRegion::TextTrackRegion):
(WebCore::TextTrackRegion::appendTextTrackCueBox):

html/track/TextTrackRegion.h:
html/track/VTTCue.cpp:

(WebCore::VTTCue::VTTCue):
(WebCore::VTTCue::notifyRegionWhenRemovingDisplayTree):
(WebCore::VTTCue::removeDisplayTree):

html/track/VTTCue.h:
html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::parseBytes):
(WebCore::WebVTTParser::collectMetadataHeader):

html/track/WebVTTParser.h:

LayoutTests:

media/track/captions-webvtt/captions-regions.vtt: Added.
media/track/regions-webvtt/text-track-cue-region-attribute-expected.txt: Rebaseline.
media/track/regions-webvtt/text-track-region-display-expected.txt: Added.
media/track/regions-webvtt/text-track-region-display.html: Added.
media/track/regions-webvtt/text-track-region-dom-layout-expected.txt: Added.
media/track/regions-webvtt/text-track-region-dom-layout.html: Added.
media/track/regions-webvtt/text-track-region-list-expected.txt: Rebaseline.
media/track/regions-webvtt/text-track-region-parser-expected.txt: Rebaseline.

7:33 PM Changeset in webkit [165866] by akling@apple.com

4 edits in trunk/Source/WebCore

Share MemoryPressureHandler::releaseMemory() between platforms.
<https://webkit.org/b/130416>

Move the code that scours WebKit for things we can free up right now
to the common part of MemoryPressureHandler. This will enable other
platforms to do the same thing under pressure.

There's now also a platformReleaseMemory() where platform-specific
pressure relief stuff can go.

Reviewed by Antti Koivisto.

platform/MemoryPressureHandler.cpp:

(WebCore::MemoryPressureHandler::releaseMemory):
(WebCore::MemoryPressureHandler::platformReleaseMemory):

platform/MemoryPressureHandler.h:
platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::respondToMemoryPressure):
(WebCore::MemoryPressureHandler::platformReleaseMemory):

7:02 PM Changeset in webkit [165865] by dino@apple.com

2 edits in trunk/Source/WebCore

[WebGL] Destroy EAGLContext's backing store
https://bugs.webkit.org/show_bug.cgi?id=130439
<rdar://problem/16295217>

Reviewed by Tim Horton.

When a GraphicsContext3D is being destroyed, we should
also remove any EAGLContext backing store.

platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::~GraphicsContext3D):

6:57 PM Changeset in webkit [165864] by ryuan.choi@samsung.com

13 edits in trunk/Source/WebKit2

[EFL][WK2] Rename async APIs for better consistency with EFL
https://bugs.webkit.org/show_bug.cgi?id=130319

Reviewed by Gyuyoung Kim.

There are inconsistency with async keyword in several ewebkit2 APIs.
This patch rename them to {module/feature}_async_{verb} for better consistency with EFL.
In addition, added Async keyword into their callback name.

UIProcess/API/efl/ewk_application_cache_manager.cpp:

(EwkApplicationCacheOriginsAsyncData::EwkApplicationCacheOriginsAsyncData):
(getApplicationCacheOriginsCallback):
(ewk_application_cache_manager_origins_async_get):

UIProcess/API/efl/ewk_application_cache_manager.h:
UIProcess/API/efl/ewk_cookie_manager.cpp:

(EwkCookiePolicyAsyncData::EwkCookiePolicyAsyncData):
(getAcceptPolicyCallback):
(ewk_cookie_manager_accept_policy_async_get):
(EwkCookieHostnamesAsyncData::EwkCookieHostnamesAsyncData):
(getHostnamesWithCookiesCallback):
(ewk_cookie_manager_hostnames_with_cookies_async_get):

UIProcess/API/efl/ewk_cookie_manager.h:
UIProcess/API/efl/ewk_database_manager.cpp:

(EwkDatabaseOriginsAsyncData::EwkDatabaseOriginsAsyncData):
(getDatabaseOriginsCallback):
(ewk_database_manager_origins_async_get):

UIProcess/API/efl/ewk_database_manager.h:
UIProcess/API/efl/ewk_storage_manager.cpp:

(EwkStorageOriginsAsyncData::EwkStorageOriginsAsyncData):
(getStorageOriginsCallback):
(ewk_storage_manager_origins_async_get):

UIProcess/API/efl/ewk_storage_manager.h:
UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp:

(timerCallback):

UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:

(EWK2CookieManagerTest::getAcceptPolicy):
(EWK2CookieManagerTest::getHostnamesWithCookies):

UIProcess/API/efl/tests/test_ewk2_database_manager.cpp:

(EWK2DatabaseManagerTest::timerCallback):
(TEST_F):

UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:

(EWK2StorageManagerTest::timerCallback):
(TEST_F):

6:51 PM Changeset in webkit [165863] by timothy_horton@apple.com

11 edits in trunk/Source

[iOS][WebKit2] Mark layer contents as being opaque if they are
https://bugs.webkit.org/show_bug.cgi?id=130427
<rdar://problem/15540434>

Reviewed by Simon Fraser.

Shared/mac/RemoteLayerBackingStore.h:

(WebKit::RemoteLayerBackingStore::isOpaque):

Shared/mac/RemoteLayerBackingStore.mm:

(RemoteLayerBackingStore::RemoteLayerBackingStore):
(RemoteLayerBackingStore::ensureBackingStore):
(RemoteLayerBackingStore::encode):
(RemoteLayerBackingStore::decode):
(RemoteLayerBackingStore::display):
(RemoteLayerBackingStore::applyBackingStoreToLayer):
Move the code to set a RemoteLayerBackingStore as a CALayer's contents
from RemoteLayerTreePropertyApplier to RemoteLayerBackingStore (mostly
as a way to keep the USE(IOSURFACE) #ifs in one place).
Remove the surface() getter, because it's no longer needed, and make
image() private as it can be now (and rename it to createImageForFrontBuffer
for clarity's sake).

Add an isOpaque argument to ensureBackingStore, encode/decode it, and
add a getter. If isOpaque is true when applying backing store to the
CALayer on the UI process side, set CALayer.contentsOpaque to let CA know.

Make opaque bitmaps if not using accelerated drawing. For the IOSurface
case, we can't make opaque IOSurfaces, but telling CA that we have filled
the whole bitmap still enables similar optimizations.

Shared/mac/RemoteLayerTreePropertyApplier.mm:

(WebKit::applyPropertiesToLayer):
Reset contentsOpaque if the layer loses its backing store.

Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTextStream::operator<<):
(WebKit::dumpChangedLayers):
Add a bit more logging about RemoteLayerBackingStore's opaqueness
and acceleratedness.

WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::updateBackingStore):
(PlatformCALayerRemote::setOpaque):
Invalidate the RemoteLayerBackingStore if layer opaqueness changes.

platform/graphics/GraphicsLayerClient.h:

(WebCore::GraphicsLayerClient::paintsOpaquelyAtNonIntegralScales):

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateContentsOpaque):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintsOpaquelyAtNonIntegralScales):

rendering/RenderLayerBacking.h:

r159463 stopped us from setting layers opaque if they were being painted
at non-integral scale. This makes sense for compositing layers, which
are painted by arbitrary elements, but the main frame's RenderView
will always paint its entire contents. To restore the opaque contents
optimization to the main frame's tiles, don't de-opaquify layers
belonging to the main frame's RenderView.

6:48 PM Changeset in webkit [165862] by jpfau@apple.com

3 edits in trunk/Source/WebCore

Unify <media> element callback registration and unregistration
https://bugs.webkit.org/show_bug.cgi?id=130417

Reviewed by Eric Carlson.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::registerWithDocument):
(WebCore::HTMLMediaElement::unregisterWithDocument):
(WebCore::HTMLMediaElement::didMoveToNewDocument):

html/HTMLMediaElement.h:

6:38 PM Changeset in webkit [165861] by fpizlo@apple.com

2 edits in tags/Safari-538.23.1/Source/JavaScriptCore

Merge r165860.

2014-03-18 Filip Pizlo <fpizlo@apple.com>

Unreviewed, fix iOS production build.

JavaScriptCore.xcodeproj/project.pbxproj:

6:36 PM Changeset in webkit [165860] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix iOS production build.

JavaScriptCore.xcodeproj/project.pbxproj:

5:38 PM Changeset in webkit [165859] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

MediaDocument should set a max-width on its <video> element.
https://bugs.webkit.org/show_bug.cgi?id=114691

Reviewed by Eric Carlson.

Set a style attribute containing max-width:100% and max-height:100% so that large videos
are entirely visible within the browser window bounds.

html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):

5:28 PM Changeset in webkit [165858] by thiago.lacerda@openbossa.org

5 edits in trunk/Source/WebCore

[WebRTC] Fix layering violation in RTCStatsRequest
https://bugs.webkit.org/show_bug.cgi?id=130426

Reviewed by Eric Carlson.

RTCStatsRequest::track() should return a MediaStreamTrackPrivate*.

No new tests needed.

Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::getStats):

Modules/mediastream/RTCStatsRequestImpl.cpp:

(WebCore::RTCStatsRequestImpl::create):
(WebCore::RTCStatsRequestImpl::RTCStatsRequestImpl):
(WebCore::RTCStatsRequestImpl::track):

Modules/mediastream/RTCStatsRequestImpl.h:
platform/mediastream/RTCStatsRequest.h:

5:01 PM Changeset in webkit [165857] by timothy@apple.com

1 edit in trunk/Source/WebInspectorUI/Configurations/WebInspectorUIFramework.xcconfig

Attempt to fix the Production build.

4:54 PM Changeset in webkit [165856] by beidson@apple.com

22 edits in trunk/Source/WebKit2

Make image controls menu work in WK2
<rdar://problem/16294412> and https://bugs.webkit.org/show_bug.cgi?id=130424

Reviewed by Tim Horton.

Platform/SharedMemory.h:
Platform/mac/SharedMemoryMac.cpp:

(WebKit::SharedMemory::Handle::~Handle):
(WebKit::SharedMemory::Handle::clear):

Platform/unix/SharedMemoryUnix.cpp:

(WebKit::SharedMemory::Handle::~Handle):
(WebKit::SharedMemory::Handle::clear):

Shared/ContextMenuContextData.cpp:

(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::operator=):
(WebKit::ContextMenuContextData::encode):
(WebKit::ContextMenuContextData::decode):

Shared/ContextMenuContextData.h:

(WebKit::ContextMenuContextData::controlledImageHandle):

Shared/ShareableBitmap.cpp:

(WebKit::ShareableBitmap::Handle::clear):

Shared/ShareableBitmap.h:
UIProcess/WebContextMenuProxy.h:

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::internalShowContextMenu):
(WebKit::WebPageProxy::replaceControlledImage):

UIProcess/WebPageProxy.h:

UIProcess/efl/WebContextMenuProxyEfl.cpp:

(WebKit::WebContextMenuProxyEfl::showContextMenu):

UIProcess/efl/WebContextMenuProxyEfl.h:

UIProcess/gtk/WebContextMenuProxyGtk.cpp:

(WebKit::WebContextMenuProxyGtk::showContextMenu):

UIProcess/gtk/WebContextMenuProxyGtk.h:

Add a sharing service context menu that lives side-by-side with the normal one:

UIProcess/mac/WebContextMenuProxyMac.h:
UIProcess/mac/WebContextMenuProxyMac.mm:

(+[WKSharingServicePickerDelegate sharedSharingServicePickerDelegate]):
(-[WKSharingServicePickerDelegate setMenuProxy:WebKit::]):
(-[WKSharingServicePickerDelegate setPicker:]):
(-[WKSharingServicePickerDelegate sharingServicePicker:delegateForSharingService:]):
(-[WKSharingServicePickerDelegate sharingService:willShareItems:]):
(-[WKSharingServicePickerDelegate sharingService:didShareItems:]):
(-[WKSharingServicePickerDelegate sharingService:sourceFrameOnScreenForShareItem:]):
(-[WKSharingServicePickerDelegate sharingService:transitionImageForShareItem:contentRect:]):
(-[WKSharingServicePickerDelegate sharingService:sourceWindowForShareItems:sharingContentScope:]):
(WebKit::WebContextMenuProxyMac::contextMenuItemSelected):
(WebKit::WebContextMenuProxyMac::setupImageServicesMenu):
(WebKit::WebContextMenuProxyMac::clearImageServicesMenu):
(WebKit::WebContextMenuProxyMac::populate):
(WebKit::WebContextMenuProxyMac::showContextMenu):
(WebKit::WebContextMenuProxyMac::window):
(WebKit::WebContextMenuProxyMac::replaceControlledImage):

WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::show):
(WebKit::WebContextMenu::replaceControlledImage):

WebProcess/WebPage/WebContextMenu.h:

Teach the WebProcess how to accept the replaced image.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::replaceControlledImage):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

4:53 PM Changeset in webkit [165855] by msaboff@apple.com

6 edits in trunk/Source/JavaScriptCore

Update RegExp Tracing code
https://bugs.webkit.org/show_bug.cgi?id=130381

Reviewed by Andreas Kling.

Updated the regular expression tracing code for 8/16 bit JIT as
well as match only entry points. Also added average string length
metric.

runtime/RegExp.cpp:

(JSC::RegExp::RegExp):
(JSC::RegExp::match):
(JSC::RegExp::printTraceData):

runtime/RegExp.h:
runtime/VM.cpp:

(JSC::VM::addRegExpToTrace):
(JSC::VM::dumpRegExpTrace):

runtime/VM.h:
yarr/YarrJIT.h:

(JSC::Yarr::YarrCodeBlock::get8BitMatchOnlyAddr):
(JSC::Yarr::YarrCodeBlock::get16BitMatchOnlyAddr):
(JSC::Yarr::YarrCodeBlock::get8BitMatchAddr):
(JSC::Yarr::YarrCodeBlock::get16BitMatchAddr):

4:09 PM Changeset in webkit [165854] by andersca@apple.com

2 edits in trunk/Source/WebCore

Fix a trivial FIXME
https://bugs.webkit.org/show_bug.cgi?id=130432

Reviewed by Tim Horton.

history/HistoryItem.cpp:

(WebCore::HistoryItem::encodeBackForwardTreeNode):

3:56 PM Changeset in webkit [165853] by andersca@apple.com

8 edits in trunk/Source

Begin cleaning up KeyedDecoder and KeyedEncoder
https://bugs.webkit.org/show_bug.cgi?id=130431

Reviewed by Tim Horton.

Source/WebCore:

Rename KeyedDecoder::decodeVerifiedEnum to decodeEnum to match the encode function,
and sort the decode functions to be in the same logical order as the encode functions.

Modules/indexeddb/IDBKeyData.cpp:

(WebCore::IDBKeyData::decode):

Modules/indexeddb/IDBKeyPath.cpp:

(WebCore::IDBKeyPath::decode):

platform/KeyedCoding.h:

(WebCore::KeyedDecoder::decodeEnum):

Source/WebKit2:

Shared/cf/KeyedDecoder.cpp:

(WebKit::KeyedDecoder::KeyedDecoder):
If we can't parse the property list data, just add an empty dictionary to the stack.

(WebKit::KeyedDecoder::decodeBool):
Remove unneeded m_dictionaryStack.last() null check. m_dictionaryStack would either be empty
or at least have a root element; it would never have a null element.

(WebKit::KeyedDecoder::decodeDouble):
Remove the same check as above and remove the CFNumberGetType checks since CFNumberGetValue will
do the type conversion for us and return false if it's lossy.

(WebKit::KeyedDecoder::decodeInt64):
Remove the m_dictionaryStack.last() check.

(WebKit::KeyedDecoder::decodeUInt32):
Ditto.

(WebKit::KeyedDecoder::decodeString):
Ditto.

(WebKit::KeyedDecoder::beginObject):
Ditto.

(WebKit::KeyedDecoder::beginArray):
Ditto.

(WebKit::KeyedDecoder::beginArrayElement):
Ditto.

Shared/cf/KeyedDecoder.h:

Sort functions to be in the same logical order as the base class.

Shared/cf/KeyedEncoder.cpp:

(WebKit::KeyedEncoder::finishEncoding):
Don't check for a non-null CFErrorRef here (which we incidentally never released on error). Instead,
just null check the returned CFDataRef object.

3:41 PM Changeset in webkit [165852] by alex.christensen@flexsim.com

2 edits in trunk/WebKitLibraries

[WinCairo] Unreviewed build fix after r165763.

win/tools/vsprops/GStreamerCommon.props:

Link to gsttag-1.0.lib in addition to other GStreamer libraries.

3:24 PM Changeset in webkit [165851] by matthew_hanson@apple.com

1 edit in branches/safari-537.75-branch/LayoutTests/fast/ruby/ruby-illegal-combined-expected.txt

Reverted r165567 to the same expectation as trunk.

3:08 PM Changeset in webkit [165850] by Joseph Pecoraro

2 edits in trunk/Source/WebKit2

Unreviewed typo build fix for r165846.

Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::decode):

3:05 PM Changeset in webkit [165849] by commit-queue@webkit.org

1 edit
5 copies
1 delete in trunk/LayoutTests

Unreviewed GTK Gardening.

Move expected accesibility results to the right path and update them.

Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-03-18

platform/gtk/accessibility/aria-help-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/accessibility/aria-help-expected.txt.
platform/gtk/accessibility/aria-hidden-false-works-in-subtrees-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/accessibility/aria-hidden-false-works-in-subtrees-expected.txt.
platform/gtk/accessibility/fieldset-element-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/accessibility/fieldset-element-expected.txt.
platform/gtk/accessibility/meter-element-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/accessibility/meter-element-expected.txt.
platform/gtk/accessibility/negative-tabindex-does-not-expose-label-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/accessibility/negative-tabindex-does-not-expose-label-expected.txt.

2:57 PM Changeset in webkit [165848] by Darin Adler

76 edits in trunk/Source

Reduce use of deprecatedCharacters in WebCore
https://bugs.webkit.org/show_bug.cgi?id=130318

Reviewed by Andreas Kling.

Source/WebCore:

Modules/indexeddb/IDBKeyPath.cpp:

(WebCore::IDBKeyPathLexer::IDBKeyPathLexer): Use StringView for parsing.
(WebCore::IDBKeyPathLexer::lex): Ditto.
(WebCore::IDBKeyPathLexer::lexIdentifier): Ditto.

Modules/indexeddb/leveldb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::encodeString): Index directly into string instead of
using deprecatedCharacters.

Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::setSubprotocol): Use
StringView::getCharactersWithUpconvert.
(WebCore::ThreadableWebSocketChannelClientWrapper::setExtensions): Ditto.

accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper arrayOfTextForTextMarkers:attributed:]):
Use operator NSString * instead of explicitly creating an NSString.

bindings/js/SerializedScriptValue.cpp:

(WebCore::writeLittleEndianUInt16): Added.
(WebCore::CloneSerializer::serialize): Added a separate code path for 8-bit strings.
(WebCore::CloneSerializer::write): Ditto.

bindings/objc/WebScriptObject.mm:

(+[WebScriptObject _convertValueToObjcValue:JSC::originRootObject:rootObject:]):
Use operator NSString * instead of explicitly creating an NSString.

dom/Document.cpp:

(WebCore::Document::parseQualifiedName): Index directly into string instead of
using deprecatedCharacters.

editing/CompositeEditCommand.cpp:

(WebCore::containsOnlyWhitespace): Ditto.

editing/SmartReplace.cpp:

(WebCore::addAllCodePoints): Ditto.
(WebCore::getSmartSet): Use StringView::upconvertedCharacters.

editing/TextIterator.cpp:

(WebCore::foldQuoteMarksAndSoftHyphens): Changed to return a value so it can be
used in initialization rather than assignment.
(WebCore::SearchBuffer::SearchBuffer): Use StringView::upconvertedCharacters.

editing/TypingCommand.cpp:

(WebCore::TypingCommand::insertText): Index directly into string instead of using
deprecatedCharacters.

editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::characterAfter): Ditto.

editing/VisibleUnits.cpp:

(WebCore::startOfParagraph): Ditto.
(WebCore::endOfParagraph): Ditto.

fileapi/WebKitBlobBuilder.cpp:

(WebCore::BlobBuilder::append): Pass a StringView to TextEncoding::encode.

html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::parseToDateComponents): Use
StringView::upconvertedCharacters.

html/FormDataList.cpp:

(WebCore::FormDataList::appendString): Pass a StringView to TextEncoding::encode.

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::normalizeSpaces): Use StringView::getCharactersWithUpconvert.

html/parser/HTMLParserIdioms.cpp:

(WebCore::stripLeadingAndTrailingHTMLSpaces): Use characters16 for a code path
that already handled 8-bit characters separately.
(WebCore::parseHTMLNonNegativeInteger): Ditto.
(WebCore::parseDescriptors): Added an 8-bit code path.

inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::newLineAndWhitespaceDelimiters): Index directly into
string instead of using deprecatedCharacters.

inspector/InspectorStyleTextEditor.cpp:

(WebCore::InspectorStyleTextEditor::insertProperty): Ditto.
(WebCore::InspectorStyleTextEditor::internalReplaceProperty): Ditto.

page/ContentSecurityPolicy.cpp:

(WebCore::isSourceListNone): Use StringView::upconvertedCharacters.
(WebCore::CSPSourceList::parse): Ditto.
(WebCore::NonceDirective::parse): Ditto.
(WebCore::MediaListDirective::parse): Ditto.
(WebCore::CSPDirectiveList::parse): Ditto.
(WebCore::CSPDirectiveList::parseReportURI): Ditto.
(WebCore::CSPDirectiveList::parseReflectedXSS): Ditto.
(WebCore::ContentSecurityPolicy::didReceiveHeader): Ditto.

page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame): Pass a StringView into
TextEncoding::encode.
(WebCore::PageSerializer::serializeCSSStyleSheet): Ditto.

platform/Length.cpp:

(WebCore::countCharacter): Index directly into string instead of using
deprecatedCharacters. Also changed to take a StringImpl&.
(WebCore::newCoordsArray): Ditto. Call countCharacter the new way, and
use StringView::upconvertedCharacters.
(WebCore::newLengthArray): Ditto.

platform/LinkHash.cpp:

(WebCore::visitedLinkHash): Use characters16 for the 16-bit path.
Also removed unused visitedURL function.

platform/LinkHash.h: Removed unused visitedURL function.

platform/SharedBuffer.cpp:

(WebCore::utf8Buffer): Added an 8-bit code path.

platform/URL.cpp:

(WebCore::URL::port): Ditto.
(WebCore::encodeRelativeString): Use StringView to call TextEncoding::encode.

platform/graphics/Color.cpp:

(WebCore::Color::parseHexColor): Use characters16 in the 16-bit path.
(WebCore::Color::Color): Ditto.

platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:

(WebCore::harfBuzzGetGlyph): Use StringView to call TextEncoding::encode.

platform/graphics/StringTruncator.cpp:

(WebCore::centerTruncateToBuffer): Use StringView::getCharactersWithUpconvert.
(WebCore::rightTruncateToBuffer): Ditto.
(WebCore::rightClipToCharacterBuffer): Ditto.
(WebCore::rightClipToWordBuffer): Ditto.
(WebCore::leftTruncateToBuffer): Ditto.
(WebCore::truncateString): Ditto.

platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun): Use characters16 in the 16-bit code path.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):
Use StringView::upconvertedCharacters.

platform/network/DataURL.cpp:

(WebCore::handleDataURL): Use StringView to call TextEncoding::encode.

platform/network/FormDataBuilder.cpp:

(WebCore::FormDataBuilder::addFilenameToMultiPartHeader): Ditto.

platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::bindBlob): Use StringView::upconvertedCharacters.
(WebCore::SQLiteStatement::bindText): Ditto.

platform/text/DecodeEscapeSequences.h:

(WebCore::Unicode16BitEscapeSequence::decodeRun): Changed to take a StringView.
(WebCore::URLEscapeSequence::decodeRun): Ditto.
(WebCore::decodeEscapeSequences): Pass StringView to decodeRun.

platform/text/Hyphenation.cpp:

(WebCore::lastHyphenLocation): Take a StringView.

platform/text/Hyphenation.h: Make lastHyphenLocation take a StringView.

platform/text/TextBreakIterator.cpp:

(WebCore::initializeIteratorWithRules): Use StringView::upconvertedCharacters.

platform/text/TextEncoding.cpp:

(WebCore::TextEncoding::encode): Use StringView::upconvertedCharacters.
Change argument type to StringView.

platform/text/TextEncoding.h: Ditto.

platform/text/TextEncodingRegistry.cpp:

(WebCore::atomicCanonicalTextEncodingName): Use characters16 for the 16-bit path.

platform/text/cf/HyphenationCF.cpp:

(WebCore::lastHyphenLocation): Use StringView::text.createCFStringWithoutCopying.
Change argument type to StringView.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::constructTextRun): Use characters16 for the 16-bit path.

rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::width): Removed check for null characters pointer,
since the pointer will never be null, and even if it was there would be no need
for an early exit.

rendering/RenderText.cpp:

(WebCore::maxWordFragmentWidth): Take a StringView.
(WebCore::RenderText::computePreferredLogicalWidths): Pass in a StringView.

rendering/line/BreakingContextInlineHeaders.h:

(WebCore::tryHyphenating): Ditto.

rendering/svg/SVGTextLayoutEngine.cpp:

(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath): Use
StringView::upconvertedCharacters.

rendering/svg/SVGTextMetrics.cpp:

(WebCore::SVGTextMetrics::SVGTextMetrics): Use String::substring.

svg/SVGAngle.cpp:

(WebCore::SVGAngle::setValueAsString): Use StringView::upconvertedCharacters.

svg/SVGAnimateMotionElement.cpp:

(WebCore::parsePoint): Ditto.

svg/SVGAnimationElement.cpp:

(WebCore::parseKeySplines): Ditto.

svg/SVGFitToViewBox.cpp:

(WebCore::SVGFitToViewBox::parseViewBox): Ditto.

svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection): Pass StringView to
createStringWIthMirroredCharacters.
(WebCore::createStringWithMirroredCharacters): Changed to use StringView and
use indexing into that instead of a characters pointer.

svg/SVGFontData.h: Removed createStringWithMirroredCharacters member function,

since it has nothing to do with the SVGFontData object. Now it's just a private
helper function in the SVGFontData.cpp source file.

svg/SVGFontElement.cpp:

(WebCore::SVGFontElement::registerLigaturesInGlyphCache): Index into the string
instead of using deprecatedCharacters.

svg/SVGGlyphMap.h:

(WebCore::SVGGlyphMap::addGlyph): Use StringView::upconvertedCharacters.
(WebCore::SVGGlyphMap::collectGlyphsForString): Ditto.

svg/SVGGlyphRefElement.cpp:

(WebCore::SVGGlyphRefElement::parseAttribute): Ditto.

svg/SVGLength.cpp:

(WebCore::SVGLength::setValueAsString): Ditto.

svg/SVGLengthList.cpp:

(WebCore::SVGLengthList::parse): Ditto.

svg/SVGNumberList.cpp:

(WebCore::SVGNumberList::parse): Ditto.

svg/SVGParserUtilities.cpp:

(WebCore::parseNumberFromString): Ditto.
(WebCore::parseNumberOptionalNumber): Ditto.
(WebCore::parseRect): Ditto.
(WebCore::pointsListFromSVGData): Ditto.
(WebCore::parseGlyphName): Ditto.
(WebCore::parseKerningUnicodeString): Ditto.
(WebCore::parseDelimitedString): Ditto.

svg/SVGPreserveAspectRatio.cpp:

(WebCore::SVGPreserveAspectRatio::parse): Ditto.

svg/SVGStringList.cpp:

(WebCore::SVGStringList::parse): Ditto.

svg/SVGTransformList.cpp:

(WebCore::SVGTransformList::parse): Ditto.

svg/SVGTransformable.cpp:

(WebCore::SVGTransformable::parseTransformType): Ditto.

svg/SVGViewSpec.cpp:

(WebCore::SVGViewSpec::parseViewSpec): Ditto.

svg/SVGZoomAndPan.h:

(WebCore::SVGZoomAndPan::parseAttribute): Ditto.

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send): Pass a StringView to TextEncoding::encode.

xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::parseString): Use StringView::upconvertedCharacters.

Source/WTF:

wtf/text/WTFString.h: Export another overload of charactersToFloat since it's used

in WebCore now.

wtf/text/cf/StringViewCF.cpp: Change so this can build on Windows.

WTF.vcxproj/WTF.vcxproj: Added StringViewCF.cpp.
WTF.vcxproj/WTF.vcxproj.filters: Added StringViewCF.cpp.

2:53 PM Changeset in webkit [165847] by matthew_hanson@apple.com

2 edits in branches/safari-537.75-branch/Source/WebKit2

Add a newline to the end of WKPreferences.cpp to suppress -Werror, -pedantic, and -Wnewline-eof.

2:46 PM Changeset in webkit [165846] by Joseph Pecoraro

12 edits in trunk/Source/WebKit2

WebKit2 SPI to disable remote inspection on a WKWebView / WKPage
https://bugs.webkit.org/show_bug.cgi?id=130371

Reviewed by Dan Bernstein.

Shared/WebPageCreationParameters.h:
Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
Add allowsRemoteInspection bool.

UIProcess/API/C/WKPagePrivate.h:
UIProcess/API/C/WKPage.cpp:

(WKPageGetAllowsRemoteInspection):
(WKPageSetAllowsRemoteInspection):

UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _allowsRemoteInspection]):
(-[WKWebView _setAllowsRemoteInspection:]):
Getter and setter for allowing remote inspection state.

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::allowsRemoteInspection):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setAllowsRemoteInspection):
(WebKit::WebPageProxy::creationParameters):
Cached allows remote inspection state, with getter and setter.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setAllowsRemoteInspection):
When setting, call into WebCore to adjust the Page's setting.

2:38 PM Changeset in webkit [165845] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Test fast/events/touch/touch-target-limited.html crashes.

Some tests on editing/spelling are timing out, but not longer failing:
editing/spelling/spellcheck-paste.html
editing/spelling/spelling-changed-text.html
editing/spelling/spellcheck-paste-disabled.html
editing/spelling/spellcheck-paste-continuous-disabled.html

Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-03-18

platform/gtk-wk2/TestExpectations:
platform/gtk/TestExpectations:

2:22 PM Changeset in webkit [165844] by jer.noble@apple.com

5 edits in branches/safari-537.75-branch/Source

Merge r165478 and r165425.

Source/WebCore: Merge r165478.

2014-03-12 Jer Noble <jer.noble@apple.com>

[Mac] Crash when running media/fallback.html test in MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification()
https://bugs.webkit.org/show_bug.cgi?id=130136

Reviewed by Eric Carlson.

MediaPlayerPrivateAVFoundation is trying to lock its m_queueMutex from an async thread after
while being destroyed in the main thread. To resolve this race condition, redispatch from
the async thread to the main thread, and use a WeakPtr to determine whether the object has
been destroyed or not.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::checkPlayability):

Source/WTF: Merge r165425.

2014-03-10 Jer Noble <jer.noble@apple.com>

Improve WeakPtr operators.
https://bugs.webkit.org/show_bug.cgi?id=130053

Reviewed by Andreas Kling.

Replace the "operator!()" with an explicit bool operator. Add an "operator->()".

wtf/WeakPtr.h: (WTF::WeakPtr::operator bool): (WTF::WeakPtr::operator->):

1:58 PM Changeset in webkit [165843] by Bem Jones-Bey

19 edits in trunk/Source/WebCore

LayoutBox is a terrible name
https://bugs.webkit.org/show_bug.cgi?id=130351

Reviewed by Simon Fraser.

Rename LayoutBox to CSSBoxType. Also rename the functions and methods
that mention "LayoutBox" to something that makes sense for each
specific situation.

No new tests, no behavior change.

css/BasicShapeFunctions.cpp:

(WebCore::valueForBasicShape):
(WebCore::basicShapeForValue):

css/CSSBasicShapes.cpp:

(WebCore::CSSBasicShapeCircle::cssText):
(WebCore::CSSBasicShapeCircle::equals):
(WebCore::CSSBasicShapeEllipse::cssText):
(WebCore::CSSBasicShapeEllipse::equals):
(WebCore::CSSBasicShapePolygon::cssText):
(WebCore::CSSBasicShapePolygon::equals):
(WebCore::CSSBasicShapeInset::cssText):

css/CSSBasicShapes.h:

(WebCore::CSSBasicShape::referenceBox):
(WebCore::CSSBasicShape::setReferenceBox):

css/CSSComputedStyleDeclaration.cpp:

(WebCore::shapePropertyValue):

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator CSSBoxType):

css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyShape::applyValue):

page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):

rendering/ClipPathOperation.h:

(WebCore::ShapeClipPathOperation::setReferenceBox):
(WebCore::ShapeClipPathOperation::referenceBox):
(WebCore::BoxClipPathOperation::create):
(WebCore::BoxClipPathOperation::referenceBox):
(WebCore::BoxClipPathOperation::BoxClipPathOperation):

rendering/shapes/Shape.cpp:

(WebCore::Shape::createBoxShape):

rendering/shapes/Shape.h:
rendering/shapes/ShapeInfo.cpp:

(WebCore::ShapeInfo<RenderType>::computedShape):

rendering/shapes/ShapeInfo.h:
rendering/shapes/ShapeInsideInfo.h:
rendering/shapes/ShapeOutsideInfo.h:
rendering/style/BasicShapes.cpp:

(WebCore::BasicShape::canBlend):

rendering/style/BasicShapes.h:

(WebCore::BasicShape::referenceBox):
(WebCore::BasicShape::setReferenceBox):
(WebCore::BasicShape::BasicShape):

rendering/style/RenderStyleConstants.h:
rendering/style/ShapeValue.h:

(WebCore::ShapeValue::createShapeValue):
(WebCore::ShapeValue::createBoxShapeValue):
(WebCore::ShapeValue::cssBox):
(WebCore::ShapeValue::ShapeValue):

1:53 PM Changeset in webkit [165842] by fpizlo@apple.com

15 edits
1 add in trunk/Source/JavaScriptCore

Add CompareStrictEq(StringIdent:, NotStringVar:) and CompareStrictEq(String:, Untyped:)
https://bugs.webkit.org/show_bug.cgi?id=130300

Reviewed by Mark Hahnenberg.

We can quickly strictly compare StringIdent's to NotStringVar's and String's to Untyped's.
This makes the DFG aware of this.

Also adds StringIdent-to-StringIdent and StringIdent-to-NotStringVar strict comparisons to
the FTL. Also adds StringIdent-to-StringIdent non-strict comparisons to the FTL.

This also gives the DFG some abstractions for checking something is a cell or is other.
This made this patch easier to write and also simplified a bunch of other stuff.

1% speed-up on Octane.

assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::JumpList::JumpList):

bytecode/SpeculatedType.h:

(JSC::isNotStringVarSpeculation):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGNode.h:

(JSC::DFG::Node::childFor):
(JSC::DFG::Node::shouldSpeculateNotStringVar):

dfg/DFGSafeToExecute.h:

(JSC::DFG::SafeToExecuteEdge::operator()):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileIn):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileInstanceOfForObject):
(JSC::DFG::SpeculativeJIT::compileInstanceOf):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::compileBooleanCompare):
(JSC::DFG::SpeculativeJIT::compileStringEquality):
(JSC::DFG::SpeculativeJIT::compileStringToUntypedEquality):
(JSC::DFG::SpeculativeJIT::compileStringIdentEquality):
(JSC::DFG::SpeculativeJIT::compileStringIdentToNotStringVarEquality):
(JSC::DFG::SpeculativeJIT::compileStringZeroLength):
(JSC::DFG::SpeculativeJIT::speculateObjectOrOther):
(JSC::DFG::SpeculativeJIT::speculateString):
(JSC::DFG::SpeculativeJIT::speculateStringIdentAndLoadStorage):
(JSC::DFG::SpeculativeJIT::speculateNotStringVar):
(JSC::DFG::SpeculativeJIT::speculateNotCell):
(JSC::DFG::SpeculativeJIT::speculateOther):
(JSC::DFG::SpeculativeJIT::speculate):
(JSC::DFG::SpeculativeJIT::emitSwitchChar):
(JSC::DFG::SpeculativeJIT::emitSwitchString):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::blessedBooleanResult):
(JSC::DFG::SpeculativeJIT::unblessedBooleanResult):
(JSC::DFG::SpeculativeJIT::booleanResult):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::branchIsCell):
(JSC::DFG::branchNotCell):
(JSC::DFG::SpeculativeJIT::branchIsOther):
(JSC::DFG::SpeculativeJIT::branchNotOther):
(JSC::DFG::SpeculativeJIT::moveTrueTo):
(JSC::DFG::SpeculativeJIT::moveFalseTo):
(JSC::DFG::SpeculativeJIT::blessBoolean):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::branchIsCell):
(JSC::DFG::SpeculativeJIT::branchNotCell):
(JSC::DFG::SpeculativeJIT::branchIsOther):
(JSC::DFG::SpeculativeJIT::branchNotOther):
(JSC::DFG::SpeculativeJIT::moveTrueTo):
(JSC::DFG::SpeculativeJIT::moveFalseTo):
(JSC::DFG::SpeculativeJIT::blessBoolean):

dfg/DFGUseKind.cpp:

(WTF::printInternal):

dfg/DFGUseKind.h:

(JSC::DFG::typeFilterFor):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEq):
(JSC::FTL::LowerDFGToLLVM::lowString):
(JSC::FTL::LowerDFGToLLVM::lowStringIdent):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::speculateString):
(JSC::FTL::LowerDFGToLLVM::speculateStringIdent):
(JSC::FTL::LowerDFGToLLVM::speculateNotStringVar):

runtime/JSCJSValue.h:
tests/stress/string-ident-to-not-string-var-equality.js: Added.

(foo):
(bar):
(test):

1:45 PM Changeset in webkit [165841] by andersca@apple.com

2 edits in trunk/Source/WebKit2

REGRESSION: Visited link coloring seems to be completely broken in tip of tree
https://bugs.webkit.org/show_bug.cgi?id=130419
<rdar://problem/16337850>

Reviewed by Dan Bernstein.

Make sure to send any queued up messages before calling connectionWillOpen so we'll ensure
FIFO ordering if any messages are sent from within connectionWillOpen.

Shared/ChildProcessProxy.cpp:

(WebKit::ChildProcessProxy::didFinishLaunching):

1:36 PM Changeset in webkit [165840] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Add Copyright to framework.sb
https://bugs.webkit.org/show_bug.cgi?id=130413

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-03-18
Reviewed by Timothy Hatcher.

Other sb files got the copyright. Follow suit.

framework.sb:

1:18 PM Changeset in webkit [165839] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

WebPageCreationParameters colorSpace should be MAC not COCOA
https://bugs.webkit.org/show_bug.cgi?id=130414

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-03-18
Reviewed by Dan Bernstein.

The colorSpace param was only set and used on Mac, not iOS.

Shared/WebPageCreationParameters.h:
Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

1:07 PM Changeset in webkit [165838] by commit-queue@webkit.org

1 edit
1 move in trunk/Source/WebInspectorUI

Web Inspector: Make update-InspectorBackendCommands.rb only update legacy protocol versions
https://bugs.webkit.org/show_bug.cgi?id=130412

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-03-18
Reviewed by Timothy Hatcher.

Rename the script and simplify to only update Legacy protocol versions.

Scripts/update-LegacyInspectorBackendCommands.rb: Renamed from Source/WebInspectorUI/Scripts/update-InspectorBackendCommands.rb.

1:00 PM Changeset in webkit [165837] by dbates@webkit.org

5 edits
2 adds in trunk

REGRESSION (r162334): RenderTableCol::styleDidChange uses out-of-date table information
https://bugs.webkit.org/show_bug.cgi?id=129561

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/table/update-col-width-and-remove-table-cell-crash.html

Fixes an issue where a table column or table column group may query an out-
of-date model of its associated table as part of its process to propagate
style changes to affected table cells.

rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::styleDidChange): Ensure that all sections in the table
are up-to-date before querying for a table cell.

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::recalcCells): Update comment to read well. In
particular, remove the reference to RenderTableSection::fillRowsWithDefaultStartingAtPosition()
as this function was removed in <http://trac.webkit.org/changeset/99919>.
(WebCore::RenderTableSection::setNeedsCellRecalc): Clear the grid preemptively to
to ensure that accessors cannot access stale data. We'll build the grid again
in RenderTableSection::recalcCells().
(WebCore::RenderTableSection::numColumns): Add ASSERT(!m_needsCellRecalc) to assert
that the grid cells are up-to-date. That is, we don't need to calculate them again.

rendering/RenderTableSection.h: Add ASSERT(!m_needsCellRecalc) or call recalcCellsIfNeeded()

before accessing the grid to ensure that it's up-to-date.

LayoutTests:

Add a test to ensure that a table column propagates a style change to applicable
table cells.

fast/table/update-col-width-and-remove-table-cell-crash-expected.txt: Added.
fast/table/update-col-width-and-remove-table-cell-crash.html: Added.

12:59 PM Changeset in webkit [165836] by dbates@webkit.org

6 edits
4 adds in trunk

REGRESSION (r163560): ASSERTION FAILED: childrenInline() in WebCore::RenderSVGText::layout
https://bugs.webkit.org/show_bug.cgi?id=130346

Reviewed by Andreas Kling.

Source/WebCore:

Following <http://trac.webkit.org/changeset/163560>, SVG inline elements may be treated as block-
level elements depending on their CSS styles (e.g. display: block). But such elements should always
be treated as inline-level elements.

Partially revert <http://trac.webkit.org/changeset/164368> as it addressed a similar issue for
<tspan> and <tref>. Instead we should implement RenderSVGInline::updateFromStyle() to ensure that
RenderSVGInline and any derived classes (e.g. RenderSVGTSpan) are always treated as inline elements
regardless of their CSS style because the SVG text layout code depends on this assumption as part
of a performance optimization. We may want to revaluate the benefits of this optimization with respect
to code clarity and ensuring the code is less error prone.

Test: svg/text/a-display-block.html

svg/text/tref-display-inherit.html

css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle): Revert changes from <http://trac.webkit.org/changeset/164368>.

rendering/RenderInline.h:
rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::updateFromStyle): Added; ensure that RenderSVGInline and any derived
classes are treated as inline elements because the SVG text layout code depends on this assumption.

rendering/svg/RenderSVGInline.h:

LayoutTests:

Added tests to ensure that SVG <a> and <tref> are always treated as inline-level elements.

svg/text/a-display-block-expected.txt: Added.
svg/text/a-display-block.html: Added.
svg/text/tref-display-inherit-expected.txt: Added.
svg/text/tref-display-inherit.html: Added.

12:50 PM Changeset in webkit [165835] by hmuller@adobe.com

6 edits in trunk

[CSS Shapes] shape-outside: ellipse(50% 50% at) causes crash
https://bugs.webkit.org/show_bug.cgi?id=130366

Reviewed by Andreas Kling.

Source/WebCore:

The BasicShape ellipse and circle functions now report a syntax error
if the "at" keyword is not followed by a position.

The existing parsing tests have been updated to include this case.

css/CSSParser.cpp:

(WebCore::CSSParser::parseBasicShapeCircle):
(WebCore::CSSParser::parseBasicShapeEllipse):

LayoutTests:

Added invalid syntax tests for ellipse(.. at), circle(.. at) variations.

fast/shapes/parsing/parsing-shape-inside-expected.txt:
fast/shapes/parsing/parsing-shape-outside-expected.txt:
fast/shapes/parsing/parsing-test-utils.js:

12:47 PM Changeset in webkit [165834] by thiago.lacerda@openbossa.org

4 edits in trunk/Source/WebCore

Removing MediaStreamVector typedef
https://bugs.webkit.org/show_bug.cgi?id=130402

Reviewed by Eric Carlson.

Modules/mediastream/MediaStream.h:
Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::getLocalStreams):
(WebCore::RTCPeerConnection::getRemoteStreams):
(WebCore::RTCPeerConnection::getStreamById):
(WebCore::RTCPeerConnection::hasLocalStreamWithTrackId):

Modules/mediastream/RTCPeerConnection.h:

12:46 PM Changeset in webkit [165833] by commit-queue@webkit.org

1 edit
1 delete in trunk/Tools

Web Inspector: Remove stale ReportMemoryUsagePlugin
https://bugs.webkit.org/show_bug.cgi?id=130405

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-03-18
Reviewed by Andreas Kling.

This clang plugin looks like it was used for the old Inspector memory
instrumentation that was removed. So the tool can be removed.

clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
clang/ReportMemoryUsagePlugin/Makefile: Removed.
clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.

12:45 PM Changeset in webkit [165832] by Brent Fulgham

3 edits in branches/safari-537.75-branch/Source/WebKit/win

Build correction after last merge.

WebPreferences.cpp:

(WebPreferences::isInheritURIQueryComponentEnabled): Must use CFSTR wrappers
on key names in this code.
(WebPreferences::setEnableInheritURIQueryComponent): Ditto.

WebView.cpp:

(WebView::notifyPreferencesChanged): This version of the code used pointers
for the preference instance.

12:39 PM Changeset in webkit [165831] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Removed extra parens from if statement in a preprocessor define.
https://bugs.webkit.org/show_bug.cgi?id=130408

Patch by Matthew Mirman <mmirman@apple.com> on 2014-03-18
Reviewed by Filip Pizlo.

parser/Parser.cpp:

12:30 PM Changeset in webkit [165830] by matthew_hanson@apple.com

2 edits in branches/safari-537.75-branch/Source/WebCore

Follow-up fix for the merge of r163579.

12:16 PM Changeset in webkit [165829] by commit-queue@webkit.org

15 edits
5 deletes in trunk

Unreviewed, rolling out r165815.
https://bugs.webkit.org/show_bug.cgi?id=130410

Broke many VTT tests (Requested by bfulgham on #webkit).

Reverted changeset:

Source/WebCore:

"TextTrackRegion Not Implemented"
https://bugs.webkit.org/show_bug.cgi?id=116546
http://trac.webkit.org/changeset/165815

LayoutTests:

"TextTrackRegion Not Implemented"
https://bugs.webkit.org/show_bug.cgi?id=116546
http://trac.webkit.org/changeset/165815

12:07 PM Changeset in webkit [165828] by matthew_hanson@apple.com

2 edits in branches/safari-537.75-branch/Source/WebKit2

Remove consecutive single quotations, as the C compiler does not recognize scheme comments.

12:05 PM Changeset in webkit [165827] by jer.noble@apple.com

2 edits in branches/safari-537.75-branch/Source/WebKit2

Unreviewed Mountain Lion build fix. Work around "empty character constant" error
by replacing double single-quotes with single double-quotes.

NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:

11:57 AM Changeset in webkit [165826] by reni@webkit.org

3 edits
2 adds in trunk

Bad cast with toRenderBox in WebCore::RenderView::repaintViewRectangle
https://bugs.webkit.org/show_bug.cgi?id=129104

Reviewed by Simon Fraser.

Source/WebCore:

We should not cast the renderer of a RenderView's owner to RenderBox
unless we are sure it is one.

Test: plugins/crash-invalid-data-reference.html

rendering/RenderView.cpp:

(WebCore::RenderView::repaintViewRectangle):

LayoutTests:

plugins/crash-invalid-data-reference-expected.txt: Added.
plugins/crash-invalid-data-reference.html: Added.

11:30 AM Changeset in webkit [165825] by Simon Fraser

2 edits in trunk/Source/WebKit2

Dan says that options should be unsigned, and enums should be signed.

Reviewed by Dan Bernstein.

UIProcess/API/Cocoa/WKWebViewPrivate.h:

(NS_ENUM):

11:30 AM Changeset in webkit [165824] by commit-queue@webkit.org

3 edits in trunk/Tools

webkit-patch land shouldn't add a reviewer for unreviewed build fixes
https://bugs.webkit.org/show_bug.cgi?id=130220

Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-03-18
Reviewed by Csaba Osztrogonác.

Scripts/webkitpy/common/checkout/changelog.py:

(ChangeLog.set_reviewer):

Scripts/webkitpy/common/checkout/changelog_unittest.py:

(test_set_reviewer):

11:13 AM Changeset in webkit [165823] by ap@apple.com

13 edits
1 add in trunk/Source/WebKit2

[WK2] Pass ranges over IPC in a cross-platform manner
https://bugs.webkit.org/show_bug.cgi?id=130376

Reviewed by Anders Carlsson.

Added an EditingRange class for IPC, which automatically converts to and from
NSRanges, knowing the difference between notFound and NSNotFound.

Manually applied the same fix to characterIndexForPoint.

Scripts/webkit2/messages.py:

(struct_or_class):

Shared/EditingRange.h: Added.

(WebKit::EditingRange::EditingRange):
(WebKit::EditingRange::isValid):
(WebKit::EditingRange::operator NSRange):

UIProcess/API/mac/WKView.mm:

(-[WKView insertText:replacementRange:]):
(-[WKView selectedRange]):
(-[WKView hasMarkedText]):
(-[WKView setMarkedText:selectedRange:replacementRange:]):
(-[WKView markedRange]):
(-[WKView attributedSubstringForProposedRange:actualRange:]):
(-[WKView characterIndexForPoint:]):
(-[WKView firstRectForCharacterRange:actualRange:]):

UIProcess/WebPageProxy.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setMarkedText:selectedRange:]):
(-[WKContentView insertText:]):

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::setComposition):
(WebKit::WebPageProxy::insertText):
(WebKit::WebPageProxy::insertDictatedText):
(WebKit::WebPageProxy::getMarkedRange):
(WebKit::WebPageProxy::getSelectedRange):
(WebKit::WebPageProxy::getAttributedSubstringFromRange):
(WebKit::WebPageProxy::firstRectForCharacterRange):

UIProcess/mac/WebPageProxyMac.mm:

WebKit2.xcodeproj/project.pbxproj:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::rangeFromEditingRange):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::setComposition):
(WebKit::WebPage::insertText):
(WebKit::WebPage::insertDictatedText):
(WebKit::WebPage::getMarkedRange):
(WebKit::WebPage::getSelectedRange):
(WebKit::WebPage::getAttributedSubstringFromRange):
(WebKit::WebPage::firstRectForCharacterRange):

WebProcess/WebPage/mac/WebPageMac.mm:

11:11 AM Changeset in webkit [165822] by akling@apple.com

3 edits
1 add in trunk/Source/WebCore

Micro-optimize element descendant iterator.
<https://webkit.org/b/130384>

Add a slightly more efficient ElementDescendantIterator that keeps a stack
of relevant ancestor siblings instead of walking up the parent chain every
time we run out of children.

Reviewed by Antti Koivisto.

WebCore.xcodeproj/project.pbxproj:
dom/ElementDescendantIterator.h: Added.

(WebCore::ElementDescendantIterator::ElementDescendantIterator):
(WebCore::ElementDescendantIterator::operator++):
(WebCore::ElementDescendantConstIterator::ElementDescendantConstIterator):
(WebCore::ElementDescendantConstIterator::operator++):
(WebCore::ElementDescendantIteratorAdapter::ElementDescendantIteratorAdapter):
(WebCore::ElementDescendantIteratorAdapter::begin):
(WebCore::ElementDescendantIteratorAdapter::end):
(WebCore::ElementDescendantConstIteratorAdapter::ElementDescendantConstIteratorAdapter):
(WebCore::ElementDescendantConstIteratorAdapter::begin):
(WebCore::ElementDescendantConstIteratorAdapter::end):
(WebCore::elementDescendants):

dom/ElementIterator.h:
dom/SelectorQuery.cpp:

(WebCore::elementsForLocalName):
(WebCore::anyElement):
(WebCore::SelectorDataList::executeSingleTagNameSelectorData):
(WebCore::SelectorDataList::executeSingleClassNameSelectorData):
(WebCore::SelectorDataList::executeSingleSelectorData):
(WebCore::SelectorDataList::executeSingleMultiSelectorData):
(WebCore::SelectorDataList::executeCompiledSimpleSelectorChecker):

11:06 AM Changeset in webkit [165821] by Antti Koivisto

5 edits
4 adds in trunk

Mutating rules returned by getMatchedCSSRules can result in crash
https://bugs.webkit.org/show_bug.cgi?id=130209

Source/WebCore:

Reviewed by Andreas Kling.

The non-standard getMatchedCSSRules API returns CSSStyleRule objects that don't
have parent stylesheet pointer (as we don't know which sheet the rule originated from).
Mutating the rule via such wrapper can lead to crashes later as we fail to invalidate
the underlying stylesheet.

Fix by disallowing mutation of style rules that don't have parent sheet pointer. CSSStyleRule
has two mutable properties selectorText and style. The latter gives back CSSStyleDeclaration.
This patch disallows mutations in both cases for CSSStyleRules that don't have parent stylesheet
pointer.

While it is technically possible to have CSSRules that are legitimately disconnected
from stylesheet (by removing rule from sheet while holding a reference to it) it never
makes sense to mutate such rule as there is no way to do anything with it afterwards.

Tests: fast/css/getMatchedCSSProperties-rule-mutation.html

fast/css/getMatchedCSSRules-crash.html

css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):

Bail out if parent stylesheet is null.

css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):

Allow StyleRuleCSSStyleDeclaration subclass cancel the mutation via
boolean return value from willMutate.

(WebCore::StyleRuleCSSStyleDeclaration::willMutate):

Disallow mutation if the owning CSSStyleRule is null or has null stylesheet.

(WebCore::StyleRuleCSSStyleDeclaration::didMutate):

We never get here with null rule or stylesheet anymore.

css/PropertySetCSSStyleDeclaration.h:

(WebCore::PropertySetCSSStyleDeclaration::willMutate):

LayoutTests:

Reviewed by Andreas Kling.

fast/css/getMatchedCSSProperties-rule-mutation-expected.txt: Added.
fast/css/getMatchedCSSProperties-rule-mutation.html: Added.
fast/css/getMatchedCSSRules-crash-expected.txt: Added.
fast/css/getMatchedCSSRules-crash.html: Added.

11:05 AM Changeset in webkit [165820] by jpfau@apple.com

2 edits in trunk/Source/WebCore

<media> elements are not properly moved to new documents' visibility callback lists
https://bugs.webkit.org/show_bug.cgi?id=127711

Reviewed by David Kilzer.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::didMoveToNewDocument):

11:02 AM Changeset in webkit [165819] by fpizlo@apple.com

19 edits in tags/Safari-538.23.1

More FTL enabling.

Source/JavaScriptCore:

Rubber stamped by Dan Bernstein and Mark Hahnenberg.

Configurations/FeatureDefines.xcconfig:
ftl/FTLCompile.cpp:

(JSC::FTL::compile):

Source/WebCore:

Reviewed by Dan Bernstein.

No new tests because this already has ample test coverage in JSC.

Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Reviewed by Dan Bernstein.

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Reviewed by Dan Bernstein.

Configurations/FeatureDefines.xcconfig:

Source/WTF:

Rubber stamped by Dan Bernstein and Mark Hahnenberg.

wtf/Platform.h:

Tools:

Rubber stamped by Dan Bernstein.

Tools/Scripts/build-webkit:

10:59 AM Changeset in webkit [165818] by fpizlo@apple.com

13 edits in trunk

More FTL enabling.

Source/JavaScriptCore:

Rubber stamped by Dan Bernstein and Mark Hahnenberg.

Configurations/FeatureDefines.xcconfig:
ftl/FTLCompile.cpp:

(JSC::FTL::compile):

Source/WebCore:

Rubber stamped by Dan Bernstein and Mark Hahnenberg.

No new tests.

Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Rubber stamped by Dan Bernstein.

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Rubber stamped by Dan Bernstein.

Configurations/FeatureDefines.xcconfig:

Source/WTF:

Rubber stamped by Dan Bernstein and Mark Hahnenberg.

wtf/Platform.h:

Tools:

Rubber stamped by Dan Bernstein.

Tools/Scripts/build-webkit:

10:57 AM Changeset in webkit [165817] by Simon Fraser

5 edits in trunk

Renable pagination mode in WK2 MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=130374

Source/WebKit2:

Reviewed by Anders Carlsson.

Add SPI for pagination mode.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _paginationMode]):
(-[WKWebView _setPaginationMode:]):
(-[WKWebView _paginationBehavesLikeColumns]):
(-[WKWebView _setPaginationBehavesLikeColumns:]):
(-[WKWebView _pageLength]):
(-[WKWebView _setPageLength:]):
(-[WKWebView _gapBetweenPages]):
(-[WKWebView _setGapBetweenPages:]):
(-[WKWebView _pageCount]):

UIProcess/API/Cocoa/WKWebViewPrivate.h:

(NS_ENUM):

Tools:

Reviewed by Anders Carlsson.

Put the implementation of togglePaginationMode: back, and correctly
enable the menu item.

MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController validateMenuItem:]):
(-[WK2BrowserWindowController isPaginated]):
(-[WK2BrowserWindowController togglePaginationMode:]):

10:54 AM Changeset in webkit [165816] by commit-queue@webkit.org

2 edits in trunk/Tools

Add --reset option to Tools/Scripts/set-webkit-configuration script
https://bugs.webkit.org/show_bug.cgi?id=130401

Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-03-18
Reviewed by Csaba Osztrogonác.

Scripts/set-webkit-configuration:

10:40 AM Changeset in webkit [165815] by Brent Fulgham

15 edits
5 adds in trunk

TextTrackRegion Not Implemented
https://bugs.webkit.org/show_bug.cgi?id=116546

Reviewed by Eric Carlson.

Merged from Blink (patch by vcarbune@chromium.org):
https://chromium.googlesource.com/chromium/blink/+/4940f89a087fea5b5ea628e98d0b355d398a9eea
http://crbug.com/25798003

Source/WebCore:

Tests: media/track/regions-webvtt/text-track-region-display.html

media/track/regions-webvtt/text-track-region-dom-layout.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::newRegionsAvailable):

html/track/TextTrack.cpp:
html/track/TextTrack.h:
html/track/TextTrackRegion.cpp:

(WebCore::TextTrackRegion::TextTrackRegion):
(WebCore::TextTrackRegion::appendTextTrackCueBox):

html/track/TextTrackRegion.h:
html/track/VTTCue.cpp:

(WebCore::VTTCue::VTTCue):
(WebCore::VTTCue::notifyRegionWhenRemovingDisplayTree):
(WebCore::VTTCue::removeDisplayTree):

html/track/VTTCue.h:
html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::parseBytes):
(WebCore::WebVTTParser::collectMetadataHeader):

html/track/WebVTTParser.h:

LayoutTests:

media/track/captions-webvtt/captions-regions.vtt: Added.
media/track/regions-webvtt/text-track-cue-region-attribute-expected.txt: Rebaseline.
media/track/regions-webvtt/text-track-region-display-expected.txt: Added.
media/track/regions-webvtt/text-track-region-display.html: Added.
media/track/regions-webvtt/text-track-region-dom-layout-expected.txt: Added.
media/track/regions-webvtt/text-track-region-dom-layout.html: Added.
media/track/regions-webvtt/text-track-region-list-expected.txt: Rebaseline.
media/track/regions-webvtt/text-track-region-parser-expected.txt: Rebaseline.

8:37 AM Changeset in webkit [165814] by Philippe Normand

1 edit
1 delete in trunk/Source/WebCore

[GTK] ResourceLoaderSoup.cpp was added by mistake
https://bugs.webkit.org/show_bug.cgi?id=130396

Reviewed by Carlos Garcia Campos.

This file was committed by mistake in r152778 and is not built by
any port.

loader/soup/ResourceLoaderSoup.cpp: Removed.

8:03 AM Changeset in webkit [165813] by ryuan.choi@samsung.com

4 edits in trunk/Source/WebKit2

[CMAKE][WK2]Move CoordinatedGraphics related files out of WebKit2/CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=130390

Reviewed by Martin Robinson.

Now, only EFL port use CoordinatedGraphics among CMake based ports.

CMakeLists.txt:
PlatformEfl.cmake:
PlatformGTK.cmake: Removed CoordinatedGraphics related files.

8:02 AM Changeset in webkit [165812] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit2

[GTK] Race condition when the socket event source is cancelled
https://bugs.webkit.org/show_bug.cgi?id=130395

Reviewed by Martin Robinson.

In some cases when the socket event source is cancelled the socket
event source callback is called with the condition of the previous
poll instead of 0. This can happen sometimes when the source is
cancelled from the socket event source callback. Once the socket
event source is cancelled, it's dispatched by glib without
polling, so the condition is never reset again and the callback is
called again and again with the previous condition. When the
condition is G_IO_IN, the source is re-scheduled entering into an
infinite loop. We should always check if the source has been
cancelled at the beginning of the callback to destroy the source
instead of relying on the condition being 0.

Platform/gtk/WorkQueueGtk.cpp:

(WorkQueue::SocketEventSource::isCancelled):
(WorkQueue::SocketEventSource::eventCallback):

7:33 AM Changeset in webkit [165811] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: sourceMapResourceLoaded expects statusCode parameter
https://bugs.webkit.org/show_bug.cgi?id=130377

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-03-18
Reviewed by Timothy Hatcher.

UserInterface/Models/SourceMapResource.js:

7:08 AM Changeset in webkit [165810] by jaepark@webkit.org

19 edits in trunk/Source/WebKit/gtk

[GTK][CMake] Fix WebKit unused parameter warnings
https://bugs.webkit.org/show_bug.cgi?id=130383

Reviewed by Martin Robinson.

WebCoreSupport/AcceleratedCompositingContextGL.cpp: Fix unused parameters warning.
WebCoreSupport/ChromeClientGtk.cpp: Ditto.
WebCoreSupport/DragClientGtk.cpp: Ditto.
WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Ditto.
WebCoreSupport/EditorClientGtk.cpp: Ditto.
WebCoreSupport/FrameLoaderClientGtk.cpp: Ditto.
WebCoreSupport/InspectorClientGtk.cpp: Ditto.
WebCoreSupport/PlatformStrategiesGtk.cpp: Ditto.
WebCoreSupport/ProgressTrackerClientGtk.cpp: Ditto.
WebCoreSupport/WebViewInputMethodFilter.cpp: Ditto.
webkit/webkitdownload.cpp: Ditto.
webkit/webkitfavicondatabase.cpp: Ditto.
webkit/webkitsoupauthdialog.cpp: Ditto.
webkit/webkitspellchecker.cpp: Ditto.
webkit/webkitspellcheckerenchant.cpp: Ditto.
webkit/webkitwebframe.cpp: Ditto.
webkit/webkitwebinspector.cpp: Ditto.
webkit/webkitwebview.cpp: Ditto.

6:44 AM Changeset in webkit [165809] by berto@igalia.com

2 edits in trunk/Tools

[GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
https://bugs.webkit.org/show_bug.cgi?id=130388

Reviewed by Sergio Villar Senin.

Scripts/webkitdirs.pm:

(shouldRemoveCMakeCache): make sure that the build directory
exists before attempting to create a file in it.

5:51 AM Changeset in webkit [165808] by commit-queue@webkit.org

2 edits
1 add in trunk/Tools

[EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
https://bugs.webkit.org/show_bug.cgi?id=130336

Patch by Robert Plociennik <r.plociennik@samsung.com> on 2014-03-18
Reviewed by Gyuyoung Kim.

Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
requires a space between literal and string macro [-Wliteral-suffix]'
warning treated as error.

This patch applies a solution from r162448 to the EFL port.

efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
efl/jhbuild.modules: Added appropriate patch section.

4:56 AM Changeset in webkit [165807] by ryuan.choi@samsung.com

1 edit in trunk/LayoutTests/ChangeLog

[EFL] Update baselines and test expectations
https://bugs.webkit.org/show_bug.cgi?id=130387

Unreviewed EFL gardening.

Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2014-03-18

fast/events/touch/touch-slider-expected.txt:
fast/events/touch/touch-slider-no-js-touch-listener-expected.txt:

Update baselines after enabling TOUCH_SLIDER macro (r165722).

platform/efl-wk2/TestExpectations:

fast/css/cascade/box-shadow-and-webkit-box-shadow-cascade-order.html
is failing after adding in r165587

platform/efl/js/dom/global-constructors-attributes-expected.txt:

Update baselines after refactoring Path to Path2D (r165651).

3:06 AM Changeset in webkit [165806] by commit-queue@webkit.org

5 edits in trunk/LayoutTests

[EFL] Update baselines and test expectations
https://bugs.webkit.org/show_bug.cgi?id=130249111

Unreviewed EFL gardening.

Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2014-03-18

fast/events/touch/touch-slider-expected.txt:
fast/events/touch/touch-slider-no-js-touch-listener-expected.txt:

Update baselines after enabling TOUCH_SLIDER macro (r165722).

platform/efl-wk2/TestExpectations:

fast/css/cascade/box-shadow-and-webkit-box-shadow-cascade-order.html
is failing after adding in r165587

platform/efl/js/dom/global-constructors-attributes-expected.txt:

Update baselines after refactoring Path to Path2D (r165651).

2:42 AM Changeset in webkit [165805] by akling@apple.com

6 edits
1 add
1 delete in trunk/Source/WebCore

Rename ElementDescendantIterator to TypedElementDescendantIterator.
Romper-stubbed by Antti "Latte Lung" Koivisto.

GNUmakefile.list.am:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
dom/ElementDescendantIterator.h: Removed.
dom/ElementIterator.h:
dom/TypedElementDescendantIterator.h: Added.

(WebCore::TypedElementDescendantIterator<ElementType>::TypedElementDescendantIterator):
(WebCore::TypedElementDescendantIterator<ElementType>::operator):
(WebCore::TypedElementDescendantConstIterator<ElementType>::TypedElementDescendantConstIterator):
(WebCore::TypedElementDescendantConstIterator<ElementType>::operator):
(WebCore::TypedElementDescendantIteratorAdapter<ElementType>::TypedElementDescendantIteratorAdapter):
(WebCore::TypedElementDescendantIteratorAdapter<ElementType>::begin):
(WebCore::TypedElementDescendantIteratorAdapter<ElementType>::end):
(WebCore::TypedElementDescendantIteratorAdapter<ElementType>::beginAt):
(WebCore::TypedElementDescendantIteratorAdapter<ElementType>::from):
(WebCore::TypedElementDescendantIteratorAdapter<ElementType>::first):
(WebCore::TypedElementDescendantIteratorAdapter<ElementType>::last):
(WebCore::TypedElementDescendantConstIteratorAdapter<ElementType>::TypedElementDescendantConstIteratorAdapter):
(WebCore::TypedElementDescendantConstIteratorAdapter<ElementType>::begin):
(WebCore::TypedElementDescendantConstIteratorAdapter<ElementType>::end):
(WebCore::TypedElementDescendantConstIteratorAdapter<ElementType>::beginAt):
(WebCore::TypedElementDescendantConstIteratorAdapter<ElementType>::from):
(WebCore::TypedElementDescendantConstIteratorAdapter<ElementType>::first):
(WebCore::TypedElementDescendantConstIteratorAdapter<ElementType>::last):
(WebCore::descendantsOfType):

1:51 AM Changeset in webkit [165804] by commit-queue@webkit.org

6 edits in trunk

Add blend mode property to dumped information in GraphicsLayer.
https://bugs.webkit.org/show_bug.cgi?id=130331

Patch by Ion Rosca <Ion Rosca> on 2014-03-18
Reviewed by Simon Fraser.

Source/WebCore:

Functionality is not changed, therefore no new tests added.
I adjusted the affected test results generated with layerTreeAsText.

platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::dumpProperties):

LayoutTests:

css3/compositing/blend-mode-blended-element-overlapping-composited-sibling-should-have-compositing-layer-expected.txt:
css3/compositing/blend-mode-parent-of-composited-blended-has-layer-expected.txt:
css3/compositing/blend-mode-with-composited-descendant-should-have-layer-expected.txt:

1:50 AM Changeset in webkit [165803] by svillar@igalia.com

2 edits in trunk/Source/WebCore

webdatabase: Replace DEPRECATED_DEFINE_STATIC_LOCAL by static NeverDestroyed<T>
https://bugs.webkit.org/show_bug.cgi?id=130347

Reviewed by Darin Adler.

Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::openDatabaseMutex):
(WebCore::notificationMutex):
(WebCore::notificationQueue):

12:15 AM Changeset in webkit [165802] by Csaba Osztrogonác

2 edits in trunk/Source/WebKit2

[GTK] URTFB after r165789. Stub function added.

WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:

(WebKit::InjectedBundle::setBundleParameter):

12:02 AM Changeset in webkit [165801] by ljaehun.lim@samsung.com

2 edits in trunk/Source/WebKit2

Unreviewed, EFL build fix after r165789

WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:

(WebKit::InjectedBundle::setBundleParameter): Implemented.

Mar 17, 2014:

9:55 PM Changeset in webkit [165800] by rniwa@webkit.org

2 edits in trunk/Source/WebKit

Revert the erroneous change made by Xcode.

WebKit.xcodeproj/project.pbxproj:

9:55 PM Changeset in webkit [165799] by jaepark@webkit.org

2 edits in trunk/Source/WebKit2

[GTK] Build fix for debug build

Unreviewed.

finalizedListItem was actually used in ASSERT. So, use ASSERT_UNUSED
instead of ASSERT.

UIProcess/API/gtk/WebKitBackForwardListItem.cpp:

(webkitBackForwardListItemFinalized):

9:04 PM Changeset in webkit [165798] by matthew_hanson@apple.com

2 edits in branches/safari-537.75-branch/Source/WebKit/mac

Unreviewed build fix.

8:46 PM Changeset in webkit [165797] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

V8 regexp spends most of its time in operationGetById
https://bugs.webkit.org/show_bug.cgi?id=130380

Reviewed by Filip Pizlo.

Added String.length case to tryCacheGetByID that will only help the BaseLine JIT.
When V8 regexp is run from the command line, this nets a 2% performance improvement.
When the test is run for a longer amount of time, there is much less benefit as the
DFG will emit the appropriate code for String.length. This does remove
operationGetById as the hottest function whne run from the command line.

jit/Repatch.cpp:

(JSC::tryCacheGetByID):

8:28 PM Changeset in webkit [165796] by akling@apple.com

3 edits
1 add in trunk/Source/JavaScriptCore

Add one-deep cache to opaque roots hashset.
<https://webkit.org/b/130357>

The vast majority of WebCore JS wrappers will have their Document*
as the root(). This change adds a simple optimization where we cache
the last lookup and avoid going to the hashset for repeated queries.

Looks like 0.4% progression on DYEB on my MBP.

Reviewed by Mark Hahnenberg.

JavaScriptCore.xcodeproj/project.pbxproj:
heap/OpaqueRootSet.h: Added.

(JSC::OpaqueRootSet::OpaqueRootSet):
(JSC::OpaqueRootSet::contains):
(JSC::OpaqueRootSet::isEmpty):
(JSC::OpaqueRootSet::clear):
(JSC::OpaqueRootSet::add):
(JSC::OpaqueRootSet::size):
(JSC::OpaqueRootSet::begin):
(JSC::OpaqueRootSet::end):

heap/SlotVisitor.h:

8:21 PM Changeset in webkit [165795] by commit-queue@webkit.org

7 edits in trunk

Implement Math.hypot
https://bugs.webkit.org/show_bug.cgi?id=129486

Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-03-17
Reviewed by Darin Adler.

Source/JavaScriptCore:

runtime/MathObject.cpp:

(JSC::MathObject::finishCreation):
(JSC::mathProtoFuncHypot):

LayoutTests:

js/Object-getOwnPropertyNames-expected.txt:
js/math-expected.txt:
js/script-tests/Object-getOwnPropertyNames.js:
js/script-tests/math.js:

8:17 PM Changeset in webkit [165794] by thiago.lacerda@openbossa.org

8 edits in trunk/Source/WebKit2

[WK2] Getting rid of compilation warnings
https://bugs.webkit.org/show_bug.cgi?id=130348

Reviewed by Benjamin Poulain.

UIProcess/API/APIHistoryClient.h:

(API::HistoryClient::didPerformClientRedirect):
(API::HistoryClient::didPerformServerRedirect):
(API::HistoryClient::didUpdateHistoryTitle):

UIProcess/API/APILoaderClient.h:

(API::LoaderClient::didStartProvisionalLoadForFrame):
(API::LoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(API::LoaderClient::didFailProvisionalLoadWithErrorForFrame):
(API::LoaderClient::didCommitLoadForFrame):
(API::LoaderClient::didFinishLoadForFrame):
(API::LoaderClient::didFailLoadWithErrorForFrame):
(API::LoaderClient::didChangeBackForwardList):

UIProcess/API/APIPolicyClient.h:

(API::PolicyClient::decidePolicyForNavigationAction):
(API::PolicyClient::decidePolicyForNewWindowAction):
(API::PolicyClient::decidePolicyForResponse):
(API::PolicyClient::unableToImplementPolicy):

UIProcess/API/APIUIClient.h:

(API::UIClient::exceededDatabaseQuota):
(API::UIClient::saveDataToFileInDownloadsFolder):

UIProcess/API/C/WKPage.cpp:

(WKPageSetPageLoaderClient):

UIProcess/APISession.cpp:

(API::generateID):

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::viewStateDidChange):

8:16 PM Changeset in webkit [165793] by jer.noble@apple.com

7 edits in trunk/Source/WebCore

Add RemoteCommandListener support to MediaSessionManager.
https://bugs.webkit.org/show_bug.cgi?id=130354

Reviewed by Eric Carlson.

Listen for remote commands in MediaSessionManager.

platform/audio/MediaSessionManager.cpp:

(WebCore::MediaSessionManager::addSession):
(WebCore::MediaSessionManager::removeSession):

platform/audio/MediaSessionManager.h:

Add RemoteCommandListener to the project files:

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:

8:00 PM Changeset in webkit [165792] by Darin Adler

6 edits in trunk/Source/WTF

Remove most uses of deprecatedCharacter in WTF
https://bugs.webkit.org/show_bug.cgi?id=130317

Reviewed by Andreas Kling.

Re-landing after fixing the "80 instead of 0x80" typo in equalLatin1WithUTF8.

wtf/text/AtomicString.cpp:

(WTF::HashAndUTF8CharactersTranslator::equal): Add an 8-bit code path to the
non-ASCII path.
(WTF::SubstringTranslator8::hash): Added.
(WTF::SubstringTranslator8::equal): Added.
(WTF::SubstringTranslator16::hash): Renamed class.
(WTF::SubstringTranslator16::equal): Ditto.
(WTF::AtomicString::add): Added an 8-bit code path to the substring case.

wtf/text/Base64.cpp:

(WTF::base64Decode): Added an 8 bit code path.
(WTF::base64URLDecode): Ditto.

wtf/text/StringImpl.cpp:

(WTF::StringImpl::find): Fixed a case that was incorrectly using characters16
without first using is8Bit. Need to return later to remove use of deprecatedCharacters.

wtf/unicode/UTF8.cpp:

(WTF::Unicode::equalUTF16WithUTF8): Added a case for when the UTF-16 characters
are ASCII. Also removed the aEnd argument, since the caller only calls this when the
lengths are equal.
(WTF::Unicode::equalLatin1WithUTF8): Added.

wtf/unicode/UTF8.h: Updated as described above.

7:45 PM Changeset in webkit [165791] by rniwa@webkit.org

2 edits in trunk/Tools

webkitpy test rebaseline.

Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(MainTest.test_default_args):

7:30 PM Changeset in webkit [165790] by matthew_hanson@apple.com

25 edits in branches/safari-537.75-branch/Source

Merge r165753.

6:52 PM Changeset in webkit [165789] by andersca@apple.com

9 edits in trunk/Source/WebKit2

Update the bundle parameters dictionary and send out KVO notifications
https://bugs.webkit.org/show_bug.cgi?id=130379
<rdar://problem/16213914>

Reviewed by Dan Bernstein.

UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _setObject:forBundleParameter:]):

WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.h:
WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.mm:

(-[WKWebProcessBundleParameters setParameter:forKey:]):

WebProcess/InjectedBundle/InjectedBundle.h:
WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::setBundleParameter):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setInjectedBundleParameter):

WebProcess/WebProcess.h:
WebProcess/WebProcess.messages.in:

6:44 PM Changeset in webkit [165788] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Rewrite WebHTMLConverter::_elementHasOwnBackgroundColor in C++
https://bugs.webkit.org/show_bug.cgi?id=130291

Reviewed by Andreas Kling.

Extracted HTMLConverterCaches::elementHasOwnBackgroundColor.

platform/mac/HTMLConverter.mm:

(HTMLConverterCaches::elementHasOwnBackgroundColor):
(-[WebHTMLConverter _elementHasOwnBackgroundColor:]):

6:38 PM Changeset in webkit [165787] by rniwa@webkit.org

3 edits in trunk/Source/WebCore

Rewrite WebHTMLConverter::_elementIsBlockLevel in C++
https://bugs.webkit.org/show_bug.cgi?id=130287

Reviewed by Andreas Kling.

Rewrote _elementIsBlockLevel as HTMLConverterCaches::isBlockElement. Also removed the code to update
_elementIsBlockLevel in _traverseNode as computing the value of _elementIsBlockLevel is now fast.

platform/mac/HTMLConverter.h:
platform/mac/HTMLConverter.mm:

(HTMLConverterCaches::isBlockElement):
(-[WebHTMLConverter _elementIsBlockLevel:]):
(-[WebHTMLConverter _traverseNode:depth:embedded:]):
(-[WebHTMLConverter dealloc]):
(-[WebHTMLConverter init]):

6:35 PM Changeset in webkit [165786] by rniwa@webkit.org

4 edits in trunk/Source

Rewrite WebHTMLConverter::_getComputedFloat in C++
https://bugs.webkit.org/show_bug.cgi?id=130284

Reviewed by Andreas Kling.

Rewrote _getComputedFloat as HTMLConverterCaches::floatPropertyValueForNode.

platform/mac/HTMLConverter.h:
platform/mac/HTMLConverter.mm:

(HTMLConverterCaches::floatPropertyValueForNode):
(-[WebHTMLConverter _getFloat:forNode:property:]): Now that computing the float value is fast, we don't need to
store it in the cache.
(-[WebHTMLConverter dealloc]):
(-[WebHTMLConverter init]):

6:26 PM Changeset in webkit [165785] by aestes@apple.com

1 edit in trunk/Source/WebKit/mac/ChangeLog

Fix a bad URL in the ChangeLog of the previous commit.

WebView/WebView.mm:

6:24 PM Changeset in webkit [165784] by aestes@apple.com

2 edits in trunk/Source/WebKit/mac

Remove staging code added for <http://webkit.org/b/164757> [iOS] Support network state notification using CPNetworkObserver

Reviewed by Enrica Casucci.

WebView/WebView.mm:

6:21 PM Changeset in webkit [165783] by matthew_hanson@apple.com

10 edits in branches/safari-537.75-branch/Source

Merge r165582 and r165583.

5:58 PM Changeset in webkit [165782] by rniwa@webkit.org

2 edits in trunk/Tools

--profile should imply --test-runner-count=1 in run-perf-tests
https://bugs.webkit.org/show_bug.cgi?id=130375

Reviewed by Benjamin Poulain.

Use the test runner count of 1 when --profile is specified but not --test-runner-count.

Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._parse_args): Use -1 as the default value.
(PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
should be 1.

5:42 PM Changeset in webkit [165781] by bshafiei@apple.com

5 edits in tags/Safari-538.23.1/Source

Versioning.

5:38 PM Changeset in webkit [165780] by bshafiei@apple.com

1 copy in tags/Safari-538.23.1

New tag.

5:34 PM Changeset in webkit [165779] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught Exception in JSContext Inspector
https://bugs.webkit.org/show_bug.cgi?id=130368

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-03-17
Reviewed by Timothy Hatcher.

UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WebInspector.DOMNodeDetailsSidebarPanel.prototype._accessibilitySupported):
Feature check DOMAgent as well as the function.

5:05 PM Changeset in webkit [165778] by andersca@apple.com

2 edits in trunk/Source/WebKit/mac

WebKitLegacy headers should #import the relevant WebKit headers
https://bugs.webkit.org/show_bug.cgi?id=130372
<rdar://problem/16349094>

Reviewed by Dan Bernstein.

Create forwarding headers instead.

WebKitLegacy/MigrateHeadersToLegacy.make:

4:53 PM Changeset in webkit [165777] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Address some style nits.

UIProcess/API/Cocoa/_WKThumbnailViewInternal.h:

4:49 PM Changeset in webkit [165776] by Simon Fraser

4 edits in trunk

Address some style nits.

Source/WebKit2:

UIProcess/API/Cocoa/WKWebViewPrivate.h:

Tools:

MiniBrowser/mac/WK2BrowserWindowController.m:

4:45 PM Changeset in webkit [165775] by Simon Fraser

5 edits in trunk

Add transparent window support back into MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=130363

Source/WebKit2:

Reviewed by Anders Carlsson.

Expose SPI for transparent window support.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _drawsTransparentBackground]):
(-[WKWebView _setDrawsTransparentBackground:]):

UIProcess/API/Cocoa/WKWebViewPrivate.h:

Tools:

Reviewed by Anders Carlsson.

Re-enable transparent window support for WK2.

MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController validateMenuItem:]):
(-[WK2BrowserWindowController toggleTransparentWindow:]):

4:13 PM Changeset in webkit [165774] by matthew_hanson@apple.com

9 edits in branches/safari-537.75-branch/Source/WebKit2

Merged r165657.

4:13 PM Changeset in webkit [165773] by akling@apple.com

3 edits in trunk/Source/WebCore

HTMLInputElement::defaultEventHandler() shouldn't force style updates.
<https://webkit.org/b/130303>

Move the updateStyleIfNeeded() call down to TextFieldInputType instead
of doing it for every HTMLInputEvent.

There might be a better way to do this; we only want to know about this
specific element's renderer, and don't need the rest of the tree.
This is still an easy hack to avoid a lot of unnecessary work.

Reviewed by Anders Carlsson.

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::defaultEventHandler):

html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::forwardEvent):

4:04 PM Changeset in webkit [165772] by commit-queue@webkit.org

6 edits in trunk/Source/WTF

Unreviewed, rolling out r165721.
https://bugs.webkit.org/show_bug.cgi?id=130367

It makes the debug bots flaky (Requested by benjaminp on
#webkit).

Reverted changeset:

"Remove most uses of deprecatedCharacter in WTF"
https://bugs.webkit.org/show_bug.cgi?id=130317
http://trac.webkit.org/changeset/165721

3:58 PM Changeset in webkit [165771] by matthew_hanson@apple.com

2 edits in branches/safari-537.75-branch/Source/WebCore

Merged r165548.

3:47 PM Changeset in webkit [165770] by matthew_hanson@apple.com

3 edits in branches/safari-537.75-branch/Source/WebCore

Reverse merge r165286.

3:42 PM Changeset in webkit [165769] by ap@apple.com

3 edits in trunk/Source/WebKit2

Undo some accidental Gtk changes from http://trac.webkit.org/changeset/165759

UIProcess/WebPageProxy.cpp:
WebProcess/WebPage/WebPage.messages.in:

3:30 PM Changeset in webkit [165768] by Csaba Osztrogonác

3 edits in trunk/Source/WebKit2

[WK2] URTBF after r165755 for non Apple platforms, stub functions added.

WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:

(WebKit::InjectedBundle::platformInitialize):

WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:

(WebKit::InjectedBundle::platformInitialize):

3:28 PM Changeset in webkit [165767] by ap@apple.com

5 edits in trunk/Source/WebKit2

Move convertToRange() helper to cross-platform WebPage.cpp
https://bugs.webkit.org/show_bug.cgi?id=130365

Reviewed by Tim Horton.

Also renamed it to rangeFromEditingLocationAndLength().

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::rangeFromEditingLocationAndLength):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::insertText):

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::setComposition):
(WebKit::WebPage::insertText):
(WebKit::WebPage::insertDictatedText):
(WebKit::WebPage::getAttributedSubstringFromRange):
(WebKit::WebPage::characterIndexForPoint):
(WebKit::WebPage::firstRectForCharacterRange):

3:25 PM Changeset in webkit [165766] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Follow-up fix.

WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.h:

3:15 PM Changeset in webkit [165765] by Brent Fulgham

12 edits in trunk/Source/WebCore

[WebVTT] Extending WebVTT Rendering with Regions
https://bugs.webkit.org/show_bug.cgi?id=109822

Reviewed by Eric Carlson.

Merged from Blink (patch by Victor Carbune vcarbune@chromium.org):
https://chromium.googlesource.com/chromium/blink/+/0cdebc1d76d41bfcb9c4b022e54a4fbff132225d

No new tests, as this feature is not active in default builds. New tests will be added
in an upcoming bug.

css/mediaControls.css:

(video::-webkit-media-text-track-region):
(video::-webkit-media-text-track-region-container):
(video::-webkit-media-text-track-region-container.scrolling):
(video::-webkit-media-text-track-display):

html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateDisplay):

html/track/TextTrack.cpp:

(WebCore::TextTrack::~TextTrack):

html/track/TextTrackCue.cpp:
html/track/TextTrackRegion.cpp:

(WebCore::TextTrackRegion::TextTrackRegion):
(WebCore::TextTrackRegion::textTrackCueContainerScrollingClass):
(WebCore::TextTrackRegion::textTrackCueContainerShadowPseudoId):
(WebCore::TextTrackRegion::textTrackRegionShadowPseudoId):
(WebCore::TextTrackRegion::appendTextTrackCueBox):
(WebCore::TextTrackRegion::displayLastTextTrackCueBox):
(WebCore::TextTrackRegion::willRemoveTextTrackCueBox):
(WebCore::TextTrackRegion::getDisplayTree):
(WebCore::TextTrackRegion::prepareRegionDisplayTree):
(WebCore::TextTrackRegion::startTimer):
(WebCore::TextTrackRegion::stopTimer):
(WebCore::TextTrackRegion::scrollTimerFired):

html/track/TextTrackRegion.h:

(WebCore::TextTrackRegion::create):
(WebCore::TextTrackRegion::isScrollingRegion):
(WebCore::TextTrackRegion::ownerDocument):

html/track/TextTrackRegion.idl:
html/track/TextTrackRegionList.cpp:

(WebCore::TextTrackRegionList::getRegionById):

html/track/VTTCue.cpp:

(WebCore::VTTCueBox::applyCSSProperties):
(WebCore::VTTCue::~VTTCue):
(WebCore::VTTCue::setIsActive):
(WebCore::VTTCue::removeDisplayTree):

html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::createNewRegion):

rendering/RenderVTTCue.cpp:

(WebCore::RenderVTTCue::layout):

3:14 PM Changeset in webkit [165764] by enrica@apple.com

2 edits in trunk/Source/WebKit2

WK2: support data detectors driven action sheet..
https://bugs.webkit.org/show_bug.cgi?id=130362
<rdar://problem/16319711>

Reviewed by Benjamin Poulain.

UIProcess/ios/WKActionSheetAssistant.mm:

(-[WKActionSheetAssistant showDataDetectorsSheet]):

3:13 PM Changeset in webkit [165763] by b.long@cablelabs.com

10 edits in trunk

[GStreamer] human readable language code for tracks
https://bugs.webkit.org/show_bug.cgi?id=124514

Reviewed by Martin Robinson.

Source/autotools/FindDependencies.m4: Add gstreamer-tag-1.0.
Source/cmake/FindGStreamer.cmake: Same.
Source/cmake/OptionsEfl.cmake: Same.
Source/cmake/OptionsGTK.cmake: Same.

Source/WebCore:

PlatformEfl.cmake: Add GSTREAMER_TAG_INCLUDE_DIRS and GSTREAMER_TAG_LIBRARIES.
PlatformGTK.cmake: Same.
platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:

(WebCore::TrackPrivateBaseGStreamer::getLanguageCode): Run language codes though gst_tag_get_language_code_iso_639_1() to make sure they're valid.
(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfTagsChanged): Use getLanguageCode() for languages instead of just getTag().

2:58 PM Changeset in webkit [165762] by andersca@apple.com

5 edits in trunk/Source/WebKit2

Fix 32-bit OS X build.

WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.h:
WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.mm:
WebProcess/InjectedBundle/InjectedBundle.h:
WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::platformInitialize):

2:36 PM Changeset in webkit [165761] by rniwa@webkit.org

3 edits in trunk/Source/WebCore

[Mac] Rewrite WebHTMLConverter::_computedStringForNode in C++
https://bugs.webkit.org/show_bug.cgi?id=130274

Reviewed by Andreas Kling.

Rewrote WebHTMLConverter::_computedStringForNode as HTMLConverterCaches::propertyValueForNode.

platform/mac/HTMLConverter.h: Removed unused caches.
platform/mac/HTMLConverter.mm:

(HTMLConverterCaches::computedStylePropertyForElement): Added use const String& instead of String& on property name.
(HTMLConverterCaches::inlineStylePropertyForElement): Ditto.
(HTMLConverterCaches::propertyValueForNode): Renamed and rewritten from _computedStringForNode.
(-[WebHTMLConverter _stringForNode:property:]): Simply return the computed value instead of storing it in the cache
now that the computing the value is fast.
(-[WebHTMLConverter dealloc]):
(-[WebHTMLConverter init]):

2:33 PM Changeset in webkit [165760] by jaepark@webkit.org

32 edits in trunk/Source/WebKit2

[GTK][CMake] Fix WebKit2 unused parameter warnings
https://bugs.webkit.org/show_bug.cgi?id=130316

Reviewed by Martin Robinson.

Platform/gtk/WorkQueueGtk.cpp: Fix unused parameter warnings.
UIProcess/API/gtk/PageClientImpl.cpp: Ditto.
UIProcess/API/gtk/WebKitBackForwardListItem.cpp: Ditto.
UIProcess/API/gtk/WebKitContextMenuClient.cpp: Ditto.
UIProcess/API/gtk/WebKitContextMenuItem.cpp: Ditto.
UIProcess/API/gtk/WebKitDownloadClient.cpp: Ditto.
UIProcess/API/gtk/WebKitFaviconDatabase.cpp: Ditto.
UIProcess/API/gtk/WebKitFindController.cpp: Ditto.
UIProcess/API/gtk/WebKitFormClient.cpp: Ditto.
UIProcess/API/gtk/WebKitGeolocationProvider.cpp: Ditto.
UIProcess/API/gtk/WebKitLoaderClient.cpp: Ditto.
UIProcess/API/gtk/WebKitPlugin.cpp: Ditto.
UIProcess/API/gtk/WebKitPolicyClient.cpp: Ditto.
UIProcess/API/gtk/WebKitRequestManagerClient.cpp: Ditto.
UIProcess/API/gtk/WebKitTextChecker.cpp: Ditto.
UIProcess/API/gtk/WebKitUIClient.cpp: Ditto.
UIProcess/API/gtk/WebKitURISchemeRequest.cpp: Ditto.
UIProcess/API/gtk/WebKitWebContext.cpp: Ditto.
UIProcess/API/gtk/WebKitWebInspector.cpp: Ditto.
UIProcess/API/gtk/WebKitWebView.cpp: Ditto.
UIProcess/API/gtk/WebKitWebViewBase.cpp: Ditto.
UIProcess/API/gtk/WebKitWebViewBaseAccessible.cpp: Ditto.
UIProcess/API/gtk/WebViewBaseInputMethodFilter.cpp: Ditto.
UIProcess/gtk/TextCheckerGtk.cpp: Ditto.
UIProcess/gtk/WebContextMenuProxyGtk.cpp: Ditto.
UIProcess/gtk/WebPopupMenuProxyGtk.cpp: Ditto.
WebProcess/InjectedBundle/API/gtk/WebKitFrame.cpp: Ditto.
WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp: Ditto.
WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp: Ditto.
WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp: Ditto.
WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp: Ditto.

2:31 PM Changeset in webkit [165759] by ap@apple.com

11 edits in trunk/Source/WebKit2

[Mac] Standardize on start/length in text input IPC methods
https://bugs.webkit.org/show_bug.cgi?id=130359

Reviewed by Anders Carlsson.

Some IPC methods used start/length, and others use start/end. This was confusing.

While here, changed WebPageMac.mm to not use NSMakeRange where we don't need it
(I want to move this code to WebPage.cpp, where it could be shared with iOS and
other platforms, as it doesn't depend on Foundation much).

UIProcess/API/mac/WKView.mm:

(-[WKView insertText:replacementRange:]):
(-[WKView setMarkedText:selectedRange:replacementRange:]):
(-[WKView attributedSubstringForProposedRange:actualRange:]):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::internalShowContextMenu):

UIProcess/WebPageProxy.h:
UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::setComposition):
(WebKit::WebPageProxy::insertText):

UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::setComposition):
(WebKit::WebPageProxy::insertText):
(WebKit::WebPageProxy::insertDictatedText):
(WebKit::WebPageProxy::getAttributedSubstringFromRange):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setComposition):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::setComposition):
(WebKit::WebPage::insertText):

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::setComposition):
(WebKit::WebPage::insertText):
(WebKit::WebPage::insertDictatedText):
(WebKit::WebPage::getAttributedSubstringFromRange):
(WebKit::convertToRange):
(WebKit::WebPage::firstRectForCharacterRange):

2:29 PM Changeset in webkit [165758] by timothy_horton@apple.com

7 edits
3 adds
3 deletes in trunk/Source

Rename WKThumbnailView to _WKThumbnailView
https://bugs.webkit.org/show_bug.cgi?id=130361

Reviewed by Anders Carlsson.

UIProcess/API/Cocoa/_WKThumbnailView.h: Renamed from Source/WebKit2/UIProcess/API/Cocoa/WKThumbnailView.h.
UIProcess/API/Cocoa/_WKThumbnailView.mm: Renamed from Source/WebKit2/UIProcess/API/Cocoa/WKThumbnailView.mm.

(-[_WKThumbnailView initWithFrame:fromWKView:]):
(-[_WKThumbnailView _viewWasUnparented]):
(-[_WKThumbnailView _viewWasParented]):
(-[_WKThumbnailView _requestSnapshotIfNeeded]):
(-[_WKThumbnailView _didTakeSnapshot:]):
(-[_WKThumbnailView viewDidMoveToWindow]):
(-[_WKThumbnailView setScale:]):
(-[_WKThumbnailView setUsesSnapshot:]):
(-[_WKThumbnailView _setThumbnailLayer:]):
(-[_WKThumbnailView _thumbnailLayer]):

UIProcess/API/Cocoa/_WKThumbnailViewInternal.h: Renamed from Source/WebKit2/UIProcess/API/Cocoa/WKThumbnailViewInternal.h.
UIProcess/API/mac/WKView.mm:

(-[WKView _setThumbnailView:]):
(-[WKView _thumbnailView]):
(-[WKView _updateThumbnailViewLayer]):

UIProcess/API/mac/WKViewInternal.h:
UIProcess/mac/PageClientImpl.mm:
WebKit2.xcodeproj/project.pbxproj:

MigrateHeaders.make:

2:24 PM Changeset in webkit [165757] by akling@apple.com

25 edits in trunk/Source/WebCore

Remove unnecessary JSC::Handle null checks in bindings code.
<https://webkit.org/b/130356>

Use Handle::slot() directly instead of going through Handle::get().
This avoids null checking the HandleSlot, which isn't necessary here
anyway, and the code already assumes it'll never be null.

Reviewed by Gavin Barraclough.

bindings/js/JSCSSRuleListCustom.cpp:

(WebCore::JSCSSRuleListOwner::isReachableFromOpaqueRoots):

bindings/js/JSCSSValueCustom.cpp:

(WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots):
(WebCore::JSCSSValueOwner::finalize):

bindings/js/JSMutationObserverCustom.cpp:

(WebCore::JSMutationObserverOwner::isReachableFromOpaqueRoots):

bindings/js/JSNodeCustom.cpp:

(WebCore::JSNodeOwner::isReachableFromOpaqueRoots):

bindings/js/JSNodeListCustom.cpp:

(WebCore::JSNodeListOwner::isReachableFromOpaqueRoots):

bindings/js/JSTextTrackCueCustom.cpp:

(WebCore::JSTextTrackCueOwner::isReachableFromOpaqueRoots):

bindings/js/WebCoreTypedArrayController.cpp:

(WebCore::WebCoreTypedArrayController::JSArrayBufferOwner::isReachableFromOpaqueRoots):
(WebCore::WebCoreTypedArrayController::JSArrayBufferOwner::finalize):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

bridge/runtime_root.cpp:

(JSC::Bindings::RootObject::finalize):

2:11 PM Changeset in webkit [165756] by k.czech@samsung.com

3 edits in trunk/Source/WebCore

AX: Reducing some code by using helper function ariaElementsFromAttribute
https://bugs.webkit.org/show_bug.cgi?id=130344

Reviewed by Chris Fleizach.

Change visibility of ariaElementsFromAttribute function from private to protected
so that other classes that derives from AccessibilityRenderObject can use it.

No new tests. No behaviour change.

accessibility/AccessibilityRenderObject.h:
accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::columnHeaders):

1:38 PM Changeset in webkit [165755] by andersca@apple.com

9 edits
2 copies in trunk/Source/WebKit2

Add SPI for getting bundle parameters from the injected bundle
https://bugs.webkit.org/show_bug.cgi?id=130355

Reviewed by Dan Bernstein.

UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):

WebKit2.xcodeproj/project.pbxproj:
WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.h: Copied from Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h.
WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.mm: Copied from Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h.

(-[WKWebProcessBundleParameters initWithDictionary:]):
(-[WKWebProcessBundleParameters valueForKey:]):

WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h:
WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:

(-[WKWebProcessPlugInController parameters]):

WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::InjectedBundle):

WebProcess/InjectedBundle/InjectedBundle.h:

(WebKit::InjectedBundle::create):

WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::bundleParameters):
(WebKit::InjectedBundle::platformInitialize):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

1:34 PM Changeset in webkit [165754] by ddkilzer@apple.com

2 edits in trunk/Source/WebKit/mac

REGRESSION: WebKitLegacy causes ASan build to fail
<rdar://problem/16344326>

Patch by David Farler <dfarler@apple.com> on 2014-03-17
Reviewed by David Kilzer.

Configurations/DebugRelease.xcconfig: Remove $(inherited) from

OTHER_CFLAGS, OTHER_CPLUSPLUSFLAGS, OTHER_LDFLAGS to prevent
double complete ASAN flags.

1:33 PM Changeset in webkit [165753] by Brent Fulgham

26 edits in trunk/Source

Provide preference to enable additional AVFoundation options
https://bugs.webkit.org/show_bug.cgi?id=130275

Reviewed by Eric Carlson.

../WebCore:

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::doesHaveAttribute): Added.

html/HTMLMediaElement.h:
page/Settings.in: Add new attribute.
platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::doesHaveAttribute): Added stub to call private player object's
implementation of doesHaveAttribute.

platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::doesHaveAttribute):

platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::AVFWrapper::createAssetForURL): Check the <media> object,
and notify AVFoundationCF to use URI option if relevant.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Check the <media> object,
and notify AVFoundation to use URI option if relevant.

../WebKit/mac:

WebView/WebPreferenceKeysPrivate.h: Added new preference.
WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Initialize preference to false.
(-[WebPreferences isInheritURIQueryComponentEnabled]): Added.
(-[WebPreferences setEnableInheritURIQueryComponent:]): Added.

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Handle new preference.

../WebKit/win:

Interfaces/IWebPreferencesPrivate.idl: Added new preference.
WebPreferenceKeysPrivate.h: Ditto.
WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings): Initialize preference to false.
(WebPreferences::isInheritURIQueryComponentEnabled): Added.
(WebPreferences::setEnableInheritURIQueryComponent): Added.

WebPreferences.h:
WebView.cpp:

(WebView::notifyPreferencesChanged): Handle new preference.

../WebKit2:

Shared/WebPreferencesStore.h: Added new preference.
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetEnableInheritURIQueryComponent): Added.
(WKPreferencesGetEnableInheritURIQueryComponent): Added.

UIProcess/API/C/WKPreferencesPrivate.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Handle new preference.

1:32 PM Changeset in webkit [165752] by Simon Fraser

2 edits in trunk/Tools

Fix the 32-bit build; make the open panel make a WK1 window.

MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate openDocument:]):

1:23 PM Changeset in webkit [165751] by jer.noble@apple.com

3 edits in trunk/Source/WebCore

[EME] Add NULL protections in SourceBuffer and MediaSource.
https://bugs.webkit.org/show_bug.cgi?id=130266

Reviewed by Eric Carlson.

Add NULL checks in places which may be called after a SourceBuffer has been removed:

Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::monitorSourceBuffers): Protect against a SourceBuffer being removed

(and thus activeSourceBuffers being empty) when monitoring source buffer state.

Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::appendBufferTimerFired): Protect against SourceBuffer being removed.
(WebCore::SourceBuffer::videoTracks): Ditto.
(WebCore::SourceBuffer::audioTracks): Ditto.
(WebCore::SourceBuffer::textTracks): Ditto.
(WebCore::SourceBuffer::setActive): Ditto.
(WebCore::SourceBuffer::sourceBufferPrivateDidEndStream): Ditto.
(WebCore::SourceBuffer::hasCurrentTime): Ditto.
(WebCore::SourceBuffer::canPlayThrough): Ditto.
(WebCore::SourceBuffer::hasFutureTime): Ditto, and check for an empty buffered ranges.

1:19 PM Changeset in webkit [165750] by ap@apple.com

6 edits in trunk/Source/WebKit2

[Mac] getAttributedSubstringFromRange arguments are incorrectly named
https://bugs.webkit.org/show_bug.cgi?id=130349

Reviewed by Tim Horton.

There is a mess of start/end and start/length pairs in IPC. One day we'll fix them
all, but now, let's at least name them correctly.

No behavior change.

UIProcess/WebPageProxy.h:
UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::getAttributedSubstringFromRange):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::getAttributedSubstringFromRange):

1:10 PM Changeset in webkit [165749] by Simon Fraser

5 edits in trunk/Tools

Convert MiniBrowser to use WKWebView API
https://bugs.webkit.org/show_bug.cgi?id=130061

Reviewed by Anders Carlsson.

Convert the MiniBrowser WK2 window to use WebKit2 API as much
as possible.

Some functionality was removed temporarily:

text zoom, page zoom
reload
pagination mode
transparent window
dumping source
window.open support
beforeUnload panel
find in page

MiniBrowser/mac/AppDelegate.h:
MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate init]):
(-[BrowserAppDelegate newWindow:]):
(-[BrowserAppDelegate applicationWillTerminate:]):
(-[BrowserAppDelegate openDocument:]):

MiniBrowser/mac/WK2BrowserWindowController.h:
MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]):
(-[WK2BrowserWindowController dealloc]):
(-[WK2BrowserWindowController fetch:]):
(-[WK2BrowserWindowController validateMenuItem:]):
(-[WK2BrowserWindowController reload:]):
(-[WK2BrowserWindowController goBack:]):
(-[WK2BrowserWindowController goForward:]):
(-[WK2BrowserWindowController toggleZoomMode:]):
(-[WK2BrowserWindowController resetZoom:]):
(-[WK2BrowserWindowController canResetZoom]):
(-[WK2BrowserWindowController dumpSourceToConsole:]):
(-[WK2BrowserWindowController togglePaginationMode:]):
(-[WK2BrowserWindowController validateUserInterfaceItem:]):
(-[WK2BrowserWindowController windowShouldClose:]):
(-[WK2BrowserWindowController applicationTerminating]):
(-[WK2BrowserWindowController currentZoomFactor]):
(-[WK2BrowserWindowController setCurrentZoomFactor:]):
(-[WK2BrowserWindowController toggleTransparentWindow:]):
(-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
(-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
(-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
(-[WK2BrowserWindowController find:]):
(-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
(-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
(-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
(-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
(-[WK2BrowserWindowController webView:didCommitNavigation:]):
(-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
(-[WK2BrowserWindowController webView:didFailNavigation:withError:]):

WebKitTestRunner/PlatformWebView.h:
WebKitTestRunner/ios/PlatformWebViewIOS.mm:
WebKitTestRunner/mac/PlatformWebViewMac.mm:

1:04 PM Changeset in webkit [165748] by timothy_horton@apple.com

17 edits in trunk/Source

WKThumbnailView should support snapshots
https://bugs.webkit.org/show_bug.cgi?id=130335
<rdar://problem/16255139>

Reviewed by Simon Fraser.

Add a mode where WKThumbnailView takes a software snapshot of the web content,
replacing the live layer tree with said snapshot once it returns from the
web process. This may improve animation performance in cases where the
layer tree would otherwise be very complex.

UIProcess/API/Cocoa/WKThumbnailView.h:

Add a property, usesSnapshot, which determines whether the thumbnail view
should use the live layer tree or a snapshot of the content.

UIProcess/API/Cocoa/WKThumbnailView.mm:

(-[WKThumbnailView initWithFrame:fromWKView:]):
(-[WKThumbnailView _viewWasUnparented]):
Clear the snapshot when unparented.

(-[WKThumbnailView _viewWasParented]):
Take a snapshot of the web content when parented, if needed.

(-[WKThumbnailView _requestSnapshotIfNeeded]):
If we're using snapshots, and haven't already dispatched an async snapshot request,
and don't already have a snapshot, request a snapshot from the web process.

When it returns, use it as the contents of the WKThumbnailView layer, and
unparent the live layer tree.

(-[WKThumbnailView setScale:]):
(-[WKThumbnailView setUsesSnapshot:]):
(-[WKThumbnailView _setThumbnailLayer:]):
(-[WKThumbnailView _thumbnailLayer]):

UIProcess/API/Cocoa/WKThumbnailViewInternal.h:

UIProcess/API/mac/WKView.mm:

(-[WKView _setAcceleratedCompositingModeRootLayer:]):
(-[WKView _acceleratedCompositingModeRootLayer]):
WKView should always keep track of the current root layer, instead of totally
handing control over to WKThumbnailView when it is used.

(-[WKView _setThumbnailView:]):
(-[WKView _updateThumbnailViewLayer]):
(-[WKView _reparentLayerTreeInThumbnailView]):
If needed (either we're not using snapshots, or still waiting for the snapshot to be painted),
push the WKView's live layer tree into the thumbnail view.

UIProcess/API/mac/WKViewInternal.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::internalShowContextMenu):

UIProcess/WebPageProxy.h:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::takeThumbnailSnapshot):
Add a message that asynchronously returns a snapshot that respects the
current thumbnail scale and position.

(WebKit::WebPage::scaledSnapshotWithOptions):
Use some nullptr.

WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::transform):

WebProcess/WebPage/DrawingArea.h:
WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

Add a getter for the DrawingArea's transform.
Rename it to rootLayerTransform.

WebCore.exp.in:

12:27 PM Changeset in webkit [165747] by jer.noble@apple.com

3 edits in trunk/LayoutTests

Layout Test mathml/wbr-in-mroot-crash.html crashes
https://bugs.webkit.org/show_bug.cgi?id=130353

Unreviewed TestExpectations update.

platform/efl/TestExpectations:
platform/mac/TestExpectations:

11:47 AM Changeset in webkit [165746] by zandobersek@gmail.com

29 edits in trunk

Use RunLoop objects through references instead of pointers
https://bugs.webkit.org/show_bug.cgi?id=130313

Reviewed by Andreas Kling.

Source/WebKit2:

Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
return RunLoop reference instead of a pointer.

DatabaseProcess/DatabaseProcess.cpp:

(WebKit::DatabaseProcess::didClose):
(WebKit::DatabaseProcess::didReceiveInvalidMessage):

DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::postMainThreadTask):

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::didClose):
(WebKit::NetworkProcess::didReceiveInvalidMessage):

NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::continueWillSendRequest):

Platform/IPC/Connection.cpp:

(IPC::Connection::SyncMessageState::getOrCreate):
(IPC::Connection::SyncMessageState::SyncMessageState):
(IPC::Connection::SyncMessageState::~SyncMessageState):
(IPC::Connection::SyncMessageState::processIncomingMessage):
(IPC::Connection::SyncMessageState::dispatchMessages):
(IPC::Connection::createServerConnection):
(IPC::Connection::createClientConnection):
(IPC::Connection::Connection):
(IPC::Connection::addWorkQueueMessageReceiver):
(IPC::Connection::removeWorkQueueMessageReceiver):
(IPC::Connection::sendSyncMessage):
(IPC::Connection::sendSyncMessageFromSecondaryThread):
(IPC::Connection::waitForSyncReply):
(IPC::Connection::processIncomingMessage):
(IPC::Connection::connectionDidClose):
(IPC::Connection::dispatchDidReceiveInvalidMessage):
(IPC::Connection::enqueueIncomingMessage):
(IPC::Connection::wakeUpRunLoop):

Platform/IPC/Connection.h:
Platform/IPC/mac/ConnectionMac.cpp:

(IPC::Connection::receiveSourceEventHandler):

Shared/ChildProcess.cpp:

(WebKit::ChildProcess::stopRunLoop):

Shared/Plugins/NPObjectProxy.cpp:

(WebKit::NPObjectProxy::NP_Deallocate):

UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:

(WebKit::ProcessLauncher::launchProcess):

UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::ProcessLauncher::launchProcess):

UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::connectToService):
(WebKit::tryPreexistingProcess):
(WebKit::createProcess):

UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::getOrigins):
(WebKit::StorageManager::getStorageDetailsByOrigin):

UIProcess/Storage/StorageManager.h:
WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::pluginThreadAsyncCall):

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::unprotectPluginFromDestruction):

WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::wheelEvent):

WebProcess/WebPage/ViewUpdateDispatcher.cpp:

(WebKit::ViewUpdateDispatcher::visibleContentRectUpdate):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::close):

Source/WTF:

Make RunLoop::current() and RunLoop::main() return a RunLoop reference instead
of a pointer. RunLoop::Holder now uses a Ref<RunLoop> member. Timer and TimerBase
constructors take in a RunLoop reference, with TimerBase now storing a RunLoop
reference member instead of a pointer. Platform-specific bits of the RunLoop
class are updated accordingly.

wtf/RunLoop.cpp:

(WTF::RunLoop::Holder::Holder):
(WTF::RunLoop::Holder::runLoop):
(WTF::RunLoop::initializeMainRunLoop):
(WTF::RunLoop::current):
(WTF::RunLoop::main):
(WTF::RunLoop::isMain):

wtf/RunLoop.h:

(WTF::RunLoop::Timer::Timer):

wtf/cf/RunLoopCF.cpp:

(WTF::RunLoop::run):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::start):

wtf/efl/RunLoopEfl.cpp:

(WTF::RunLoop::TimerBase::TimerBase):

wtf/gtk/RunLoopGtk.cpp:

(WTF::RunLoop::run):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::start):

wtf/win/RunLoopWin.cpp:

(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):

Tools:

Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
return RunLoop reference instead of a pointer.

TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:

(loadedCallback):
(clickedCallback):

11:20 AM Changeset in webkit [165745] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[GTK] Don't busy loop when the socket is full
https://bugs.webkit.org/show_bug.cgi?id=129802

Patch by Giovanni Campagna <gcampagna@src.gnome.org> on 2014-03-17
Reviewed by Carlos Garcia Campos.

When the socket is full and we see EAGAIN or EWOULDBLOCK
(because the socket is non blocking), don't busy loop by
tring to write again, instead poll() until the socket
becomes writable.

Platform/IPC/unix/ConnectionUnix.cpp:

(IPC::Connection::sendOutgoingMessage):

10:50 AM Changeset in webkit [165744] by timothy_horton@apple.com

2 edits in trunk/Tools

sort-export-file --help doesn't work (missing 'use')
https://bugs.webkit.org/show_bug.cgi?id=130338

Reviewed by Anders Carlsson.

Scripts/sort-export-file:

Add a missing 'use', and fix a typo in an error message.

10:48 AM Changeset in webkit [165743] by ChangSeok Oh

2 edits in trunk/Source/WebCore/platform/gtk/po

[GTK] Update Korean translations - Jan 15, 2014
https://bugs.webkit.org/show_bug.cgi?id=127001

Reviewed by Gustavo Noronha Silva.

ko.po: Updated korean translations.

10:30 AM Changeset in webkit [165742] by svillar@igalia.com

11 edits in trunk

[CSS Grid Layout] getComputedStyle() not using author's order when showing named grid lines
https://bugs.webkit.org/show_bug.cgi?id=127837

Reviewed by David Hyatt.

Source/WebCore:

Added a couple of new Vectors to store the names of the grid lines
respecting their order. They will be used to get the right outcome
for getComputedStyle().

css/CSSComputedStyleDeclaration.cpp:

(WebCore::addValuesForNamedGridLinesAtIndex):
(WebCore::valueForGridTrackList):

css/StyleResolver.cpp:

(WebCore::createGridTrackList):
(WebCore::StyleResolver::applyProperty):

rendering/style/RenderStyle.h:
rendering/style/StyleGridData.cpp:

(WebCore::StyleGridData::StyleGridData):

rendering/style/StyleGridData.h:

(WebCore::StyleGridData::operator==):

LayoutTests:

Grid line names are now shown using the exact same order as the one used in the CSS.

fast/css-grid-layout/named-grid-line-get-set-expected.txt:
fast/css-grid-layout/named-grid-line-get-set.html:
fast/css-grid-layout/non-named-grid-line-get-set-expected.txt:

10:29 AM Changeset in webkit [165741] by commit-queue@webkit.org

12 edits in trunk/Source

Fix the !ENABLE(PROMISES) build
https://bugs.webkit.org/show_bug.cgi?id=130328

Patch by Zsolt Borbely <borbezs@inf.u-szeged.hu> on 2014-03-17
Reviewed by Darin Adler.

Add missing ENABLE(PROMISES) guards.

Source/JavaScriptCore:

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):

runtime/JSGlobalObject.h:
runtime/JSPromiseDeferred.cpp:
runtime/JSPromiseDeferred.h:
runtime/JSPromiseReaction.cpp:
runtime/JSPromiseReaction.h:
runtime/VM.cpp:

(JSC::VM::VM):

runtime/VM.h:

Source/WebCore:

bindings/js/JSDOMPromise.cpp:
bindings/js/JSDOMPromise.h:

10:28 AM Changeset in webkit [165740] by commit-queue@webkit.org

3 edits
4 adds in trunk

Safari should not render a cell if the <td> is empty
https://bugs.webkit.org/show_bug.cgi?id=15273

Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2014-03-17
Reviewed by Darin Adler.

Source/WebCore:

When table cell has no children and the doctype is not present or not
correct the border for that cell should not be drawn. Firefox also
follows the same behaviour hence making the changes to make it similiar
to Firefox behaviour.

Tests: fast/table/table-cell-border-doctype.html

fast/table/table-cell-border-no-doctype.html

rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintBoxDecorations):
Added condition for not drawing the border when table cell has no child
and doctype.

LayoutTests:

fast/table/table-cell-border-doctype-expected.html: Added.
fast/table/table-cell-border-doctype.html: Added.
fast/table/table-cell-border-no-doctype-expected.html: Added.
fast/table/table-cell-border-no-doctype.html: Added.

Added new test cases to check the behaviour of table cell border when
table has doctype/no doctype and table cell has child/nochild.

9:52 AM Changeset in webkit [165739] by fred.wang@free.fr

2 edits in trunk/Source/WebCore

Fix handling of <annotation> in MathMLTextElement.
https://bugs.webkit.org/show_bug.cgi?id=124128.

Reviewed by Darin Adler.

No new tests.

mathml/MathMLTextElement.cpp:

(WebCore::MathMLTextElement::createElementRenderer): do not create the special RenderMathMLToken for the <annotation> tag.
(WebCore::MathMLTextElement::childShouldCreateRenderer): only allow text inside <annotation>.

9:42 AM Changeset in webkit [165738] by Martin Robinson

5 edits
1 add in trunk

[GTK][CMake] Credential storage is not enabled
https://bugs.webkit.org/show_bug.cgi?id=130149

Reviewed by Philippe Normand.

Source/cmake/OptionsGTK.cmake: Add an ENABLE_CREDENTIAL_STORAGE option to the configuration

and look libsecret when it's enabled.

Source/cmakeconfig.h.cmake: Expose the ENABLE_CREDENTIAL_STORAGE option to the build.

Source/WebCore:

PlatformGTK.cmake: Add the libsecret include directories and link line to the build.

9:40 AM Changeset in webkit [165737] by Martin Robinson

7 edits
1 add in trunk

[GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
https://bugs.webkit.org/show_bug.cgi?id=130155

Reviewed by Philippe Normand.

Source/cmake/FindGTKUnixPrint.cmake: Added.
Source/cmake/OptionsGTK.cmake: Look for gtk+-unix-print and use it to turn on HAVE_GTK_UNIX_PRINTING.
Source/cmakeconfig.h.cmake: Add the HAVE_GTK_UNIX_PRINTING define.

Source/WebKit2:

PlatformGTK.cmake: Add GTK_UNIX_PRINT flags to the build.

Tools:

TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.

9:26 AM Changeset in webkit [165736] by zandobersek@gmail.com

4 edits in trunk/Source/WebCore

Unreviewed.

Addressing reviewing comments by Darin in bug #130310 that I forgot
to address before landing the changes in r165732.
https://bugs.webkit.org/show_bug.cgi?id=130310

rendering/InlineTextBox.cpp:
rendering/RenderLayer.cpp:
rendering/RenderObject.cpp:

9:14 AM Changeset in webkit [165735] by Carlos Garcia Campos

2 edits in trunk/Tools

[GTK] MiniBrowser fails to load injected bundle lib
https://bugs.webkit.org/show_bug.cgi?id=130332

Reviewed by Anders Carlsson.

This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.

MiniBrowser/gtk/main.c:

(main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
process is spawn.

8:38 AM Changeset in webkit [165734] by jberlin@webkit.org

2 edits in trunk/Source/WebCore

Speculative build fix for ENABLE(TELEPHONE_NUMBER_DETECTION) after r165724.

html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::linkifyPhoneNumbers):

8:02 AM Changeset in webkit [165733] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

Only supplement Page with UserMediaController once
https://bugs.webkit.org/show_bug.cgi?id=130311

Reviewed by Darin Adler.

Don't supplement the Page with an UserMediaController object if that Page was
already supplemented with one. This avoids triggering an assertion in
Supplementable::provideSupplement() that ensures no supplement with the same key
exists yet. The cause of this is calling provideUserMediaTo() in the Internals
constructor that's using the same Page for two subsequent tests.

Modules/mediastream/UserMediaController.cpp:

(WebCore::provideUserMediaTo):

7:59 AM Changeset in webkit [165732] by zandobersek@gmail.com

4 edits in trunk/Source/WebCore

Explicitly include cstdio header for debug builds in InlineTextBox, RenderLayer, RenderObject
https://bugs.webkit.org/show_bug.cgi?id=130310

Reviewed by Darin Adler.

Building the GTK port with Clang through CMake falls into a configuration where
the cstdio header is not indirectly included in InlineTextBox, RenderLayer and
RenderObject source files. fprintf() is required for helper functions that print
out helpful debugging information in debug builds, so the cstdio header should
be included explicitly in that case.

rendering/InlineTextBox.cpp:
rendering/RenderLayer.cpp:
rendering/RenderObject.cpp:

6:45 AM Changeset in webkit [165731] by Carlos Garcia Campos

2 edits in trunk/Source/WebCore

[GTK] Cleanup WebKitDOMObject
https://bugs.webkit.org/show_bug.cgi?id=130246

Reviewed by Martin Robinson.

Remove unneeded getter and fix coding style.

bindings/gobject/WebKitDOMObject.cpp:

(webkitDOMObjectSetProperty):
(webkit_dom_object_class_init):

5:40 AM Changeset in webkit [165730] by ryuan.choi@samsung.com

3 edits in trunk/Source/WebKit2

[EFL][WK2] Restore cursor when moving mouse into webview
https://bugs.webkit.org/show_bug.cgi?id=130182

Reviewed by Gyuyoung Kim.

We changed mouse cursor when the type of cursor is changed.
But once mouse is moved out of webview, ewebkit will not know whether cursor
is changed or not.

So, this patch added a logic to restore the last applied type of cursor when
mouse is moved into webview again.

UIProcess/API/efl/EwkView.cpp:

(EwkViewEventHandler<EVAS_CALLBACK_MOUSE_IN>::handleEvent):
Call updateCursor to restore the last applied type of cursor.
(EwkView::EwkView):
(EwkView::updateCursor): Extracted from setCursor.
(EwkView::setCursor):
(EwkView::handleEvasObjectAdd):

UIProcess/API/efl/EwkView.h:

2:50 AM Changeset in webkit [165729] by Csaba Osztrogonác

3 edits in trunk/Source/WTF

One more fix after r165725.

Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2014-03-17
Reviewed by Csaba Osztrogonác.

wtf/WTFThreadData.h:

2:46 AM Changeset in webkit [165728] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-2.3.92

Tagging the WebKitGTK+ 2.3.92 release

2:45 AM Changeset in webkit [165727] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.4

Unreviewed. Update NEWS and Versions.m4 for 2.3.92 release.

Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

NEWS: Added release notes for 2.3.92.

2:38 AM Changeset in webkit [165726] by Csaba Osztrogonác

2 edits in trunk/Source/WTF

Buildfix after r165725 for non Mac platforms.

Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2014-03-17
Reviewed by Csaba Osztrogonác.

wtf/WTFThreadData.h:

1:29 AM Changeset in webkit [165725] by akling@apple.com

4 edits in trunk/Source/WTF

[Mac] WTFThreadData should use _pthread_getspecific_direct().
<https://webkit.org/b/130320>

Hack WTFThreadData to use a direct key for TLS access when available.
This mechanism uses a dedicated segment register and is the same way
we implement the fast path in FastMalloc.

Reviewed by Darin Adler.

wtf/FastMalloc.cpp:
wtf/WTFThreadData.cpp:

(WTF::WTFThreadData::createAndRegisterForGetspecificDirect):

wtf/WTFThreadData.h:

(WTF::wtfThreadData):

1:01 AM Changeset in webkit [165724] by Darin Adler

2 edits in trunk/Source/WebCore

Stop using deprecatedCharacters in HTMLTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=130323

Reviewed by Andreas Kling.

Keeping this separate from other patches because of concern that this could affect
page load performance.

html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::ExternalCharacterTokenBuffer):
Use a StringView instead of a character pointer.
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::isEmpty): Ditto.
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipAtMostOneLeadingNewline):
Ditto.
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeRemaining): Ditto.
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::giveRemainingTo): Ditto.
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeRemainingWhitespace): Ditto.
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipLeading): Ditto.
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeading): Ditto.
(WebCore::HTMLTreeBuilder::linkifyPhoneNumbers): Use StringView::upconvertedCharacters.

12:52 AM Changeset in webkit [165723] by jinwoo7.song@samsung.com

13 edits in trunk/Source/WebCore

Make some Module class constructors return PassRef.
https://bugs.webkit.org/show_bug.cgi?id=130282

Reviewed by Andreas Kling.

Make the constructor helpers for the following classes return PassRef
instead of PassRefPtr since they will never return null.

GamepadList
Geolocation
NavigatorContentUtils
NetworkInfoConnection
Notification
NotificationCenter
DeviceProximityEvent

Modules/gamepad/GamepadList.h:

(WebCore::GamepadList::create):

Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::create):

Modules/geolocation/Geolocation.h:

(WebCore::Geolocation::GeoNotifier::create):

Modules/navigatorcontentutils/NavigatorContentUtils.cpp:

(WebCore::NavigatorContentUtils::create):

Modules/navigatorcontentutils/NavigatorContentUtils.h:
Modules/networkinfo/NetworkInfoConnection.cpp:

(WebCore::NetworkInfoConnection::create):

Modules/networkinfo/NetworkInfoConnection.h:
Modules/notifications/Notification.cpp:

(WebCore::Notification::create):

Modules/notifications/Notification.h:
Modules/notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::create):

Modules/notifications/NotificationCenter.h:
Modules/proximity/DeviceProximityEvent.h:

(WebCore::DeviceProximityEvent::create):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed