Context Navigation

← Previous Period
Next Period →

Timeline

Mar 19, 2014:

11:39 PM Changeset in webkit [165949] by oliver@apple.com

2 edits in branches/safari-537.75-branch/LayoutTests

Skip fast/workers/worker-copy-shared-blob-url.html in webkit2

11:34 PM Changeset in webkit [165948] by matthew_hanson@apple.com

5 edits in branches/safari-537.75-branch/Source

Versioning.

11:31 PM Changeset in webkit [165947] by matthew_hanson@apple.com

1 copy in tags/Safari-537.75.11

New tag.

11:21 PM Changeset in webkit [165946] by barraclough@apple.com

8 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=130494
EmptyUnique strings are Identifiers/Atomic

Reviewed by Geoff Garen.

EmptyUnique strings should set the Identifier/Atomic flag.

Source/JavaScriptCore:

This fixes an unreproducible bug we believe exists in Identifier handling.
Expected behaviour is that while Identifiers may reference EmptyUniques
(StringImpls allocated as UIDs for PrivateNames), these are not created
through the main Identifier constructor, the Identifier flag is not set
on PrivateNames, and we should never lookup EmptyUnique strings in the
IdentifierTable.

Unfortunately that was happening. Some tables used to implement property
access in the JIT hold StringImpl*s, and turn these back into Identifiers
using the identfiier constructor. Since the code generator will now plant
by-id (cachable) accesses to PrivateNames we can end up passing an
EmptyUnique to Identifier::add, potentially leading to PrivateNames being
uniqued together (though hard to prove, since the hash codes are random).

runtime/PropertyName.h:

(JSC::PropertyName::PropertyName):
(JSC::PropertyName::uid):
(JSC::PropertyName::publicName):
(JSC::PropertyName::asIndex):

PropertyName assumed that PrivateNames are not Identifiers - instead check isEmptyUnique().

runtime/Structure.cpp:

(JSC::Structure::getPropertyNamesFromStructure):

Structure assumed that PrivateNames are not Identifiers - instead check isEmptyUnique().

Source/WTF:

wtf/text/AtomicString.h:

(WTF::AtomicString::add):

Previously we assumed the only StringImpl that was validly allowed to claim to be Atomic but not be in a table was the canonical empty string. Now that EmptyUniques are also marked Atomic, all empty strings may pass this condition.

wtf/text/StringImpl.cpp:

(WTF::StringImpl::~StringImpl):

EmptyUnique strings are not in the Atomic/Identfiier tabels, so don't need removing.

wtf/text/StringImpl.h:

(WTF::StringImpl::StringImpl):

Change EmptyUnique constructor to call hashAndFlagsForEmptyUnique.

wtf/text/StringStatics.cpp:

(WTF::StringImpl::hashAndFlagsForEmptyUnique):

Allocate a sequential hash code (this should be just as good for distribution & better for debugging than the random value) and set flags, now including Atomic & Identifier.

11:17 PM Changeset in webkit [165945] by matthew_hanson@apple.com

2 edits in branches/safari-537.75-branch/Source/JavaScriptCore

Merge r165902.

10:10 PM Changeset in webkit [165944] by psolanki@apple.com

16 edits in trunk/Source

[iOS] Get code to compile on older iOS versions
https://bugs.webkit.org/show_bug.cgi?id=130142
<rdar://problem/16302908>

Reviewed by Darin Adler.

Source/WebCore:

WebCore.exp.in:
platform/ios/WebVideoFullscreenControllerAVKit.mm:

(-[WebVideoFullscreenController WebCore::]):
(-[WebVideoFullscreenController enterFullscreen:]):
(-[WebVideoFullscreenController exitFullscreen]):

platform/ios/WebVideoFullscreenInterfaceAVKit.h:
platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
platform/mac/HTMLConverter.mm:

(_dateForString):

platform/network/cf/CookieJarCFNet.cpp:

(WebCore::copyCookiesForURLWithFirstPartyURL):

platform/text/ios/LocalizedDateCache.mm:

(WebCore::LocalizedDateCache::calculateMaximumWidth):

platform/text/mac/LocaleMac.mm:

(WebCore::LocaleMac::LocaleMac):

Source/WebKit/mac:

History/WebHistory.mm:

(getDayBoundaries):

Plugins/WebPluginController.h:
Plugins/WebPluginController.mm:

(+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):

WebCoreSupport/WebFrameLoaderClient.mm:

(pluginView):

WebView/WebPreferences.mm:

(-[WebPreferences _setAllowCompositingLayerVisualDegradation:]):

WebView/WebPreferencesPrivate.h:

8:12 PM Changeset in webkit [165943] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix "WEBKIT_WEBGL_compressed_texture_pvrtc" extension support
https://bugs.webkit.org/show_bug.cgi?id=130292

Patch by Byungseon Shin <sun.shin@lge.com> on 2014-03-19
Reviewed by Dean Jackson.

WebGLRenderingContext::getExtension was not returning WEBGL_compressed_texture_pvrtc extension.

html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):

7:53 PM Changeset in webkit [165942] by Brent Fulgham

10 edits
3 adds in trunk

Merge Misc. WebVTT Updates from Blink.
https://bugs.webkit.org/show_bug.cgi?id=130491

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/track-webvtt-tc030-interspersed-non-cue.html

html/track/TextTrackRegion.cpp:

(WebCore::TextTrackRegion::parseSettingValue):

html/track/VTTCue.cpp:

(WebCore::VTTCue::markFutureAndPastNodes):
(WebCore::VTTCue::setCueSettings):

html/track/WebVTTParser.cpp:

(WebCore::scanDigits):
(WebCore::WebVTTParser::collectDigitsToInt):
(WebCore::WebVTTParser::parseFloatPercentageValue):
(WebCore::WebVTTParser::parseBytes):
(WebCore::WebVTTParser::collectMetadataHeader):
(WebCore::WebVTTParser::collectTimingsAndSettings):
(WebCore::WebVTTParser::createDocumentFragmentFromCueText):
(WebCore::WebVTTParser::createNewCue):
(WebCore::WebVTTParser::createNewRegion):
(WebCore::WebVTTParser::collectTimeStamp):
(WebCore::tokenToNodeType):
(WebCore::WebVTTParser::constructTreeFromToken):

html/track/WebVTTParser.h:
html/track/WebVTTToken.h:

(WebCore::WebVTTToken::name):
(WebCore::WebVTTToken::characters):
(WebCore::WebVTTToken::appendToCharacter):
(WebCore::WebVTTToken::addNewClass):
(WebCore::WebVTTToken::classes):
(WebCore::WebVTTToken::addNewAnnotation):
(WebCore::WebVTTToken::annotation):

html/track/WebVTTTokenizer.cpp:

(WebCore::equalLiteral):
(WebCore::WebVTTTokenizer::WebVTTTokenizer):
(WebCore::WebVTTTokenizer::nextToken):

html/track/WebVTTTokenizer.h:

LayoutTests:

media/track/captions-webvtt/tc030-interspersed-non-cue.vtt: Added.
media/track/track-webvtt-tc027-empty-cue-expected.txt: Mark one test as expected to fail, since

the test (incorrectly) expects to fail on empty cues. The test will be updated in a future patch.

media/track/track-webvtt-tc030-interspersed-non-cue-expected.txt: Added.
media/track/track-webvtt-tc030-interspersed-non-cue.html: Added.

7:00 PM Changeset in webkit [165941] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed, revert the DFGCommon.h change in r165938. It was not intentional.

dfg/DFGCommon.h:

6:56 PM Changeset in webkit [165940] by mhahnenberg@apple.com

18 edits
4 adds in trunk/Source

GC timer should intelligently choose between EdenCollections and FullCollections
https://bugs.webkit.org/show_bug.cgi?id=128261

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Most of the GCs while browsing the web are due to the GC timer. Currently the GC timer
always does FullCollections. To reduce the impact of the GC timer on the system this patch
changes Heap so that it has two timers, one for each type of collection. The FullCollection
timer is notified at the end of EdenCollections how much the Heap has grown since the last
FullCollection and when somebody notifies the Heap of abandoned memory (which usually wouldn't
be detected by an EdenCollection).

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:
heap/EdenGCActivityCallback.cpp: Added.

(JSC::EdenGCActivityCallback::EdenGCActivityCallback):
(JSC::EdenGCActivityCallback::doCollection):
(JSC::EdenGCActivityCallback::lastGCLength):
(JSC::EdenGCActivityCallback::deathRate):
(JSC::EdenGCActivityCallback::gcTimeSlice):

heap/EdenGCActivityCallback.h: Added.

(JSC::GCActivityCallback::createEdenTimer):

heap/FullGCActivityCallback.cpp: Added.

(JSC::FullGCActivityCallback::FullGCActivityCallback):
(JSC::FullGCActivityCallback::doCollection):
(JSC::FullGCActivityCallback::lastGCLength):
(JSC::FullGCActivityCallback::deathRate):
(JSC::FullGCActivityCallback::gcTimeSlice):

heap/FullGCActivityCallback.h: Added.

(JSC::GCActivityCallback::createFullTimer):

heap/GCActivityCallback.cpp:

(JSC::GCActivityCallback::GCActivityCallback):
(JSC::GCActivityCallback::doWork):
(JSC::GCActivityCallback::scheduleTimer):
(JSC::GCActivityCallback::cancelTimer):
(JSC::GCActivityCallback::didAllocate):
(JSC::GCActivityCallback::willCollect):
(JSC::GCActivityCallback::cancel):

heap/GCActivityCallback.h:
heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::reportAbandonedObjectGraph):
(JSC::Heap::didAbandon):
(JSC::Heap::collectAllGarbage):
(JSC::Heap::collect):
(JSC::Heap::willStartCollection):
(JSC::Heap::updateAllocationLimits):
(JSC::Heap::didFinishCollection):
(JSC::Heap::setFullActivityCallback):
(JSC::Heap::setEdenActivityCallback):
(JSC::Heap::fullActivityCallback):
(JSC::Heap::edenActivityCallback):
(JSC::Heap::setGarbageCollectionTimerEnabled):
(JSC::Heap::didAllocate):
(JSC::Heap::shouldDoFullCollection):

heap/Heap.h:

(JSC::Heap::lastFullGCLength):
(JSC::Heap::lastEdenGCLength):
(JSC::Heap::increaseLastFullGCLength):
(JSC::Heap::sizeBeforeLastEdenCollection):
(JSC::Heap::sizeAfterLastEdenCollection):
(JSC::Heap::sizeBeforeLastFullCollection):
(JSC::Heap::sizeAfterLastFullCollection):

heap/HeapOperation.h:
heap/HeapStatistics.cpp:

(JSC::HeapStatistics::showObjectStatistics):

heap/HeapTimer.cpp:

(JSC::HeapTimer::timerDidFire):

jsc.cpp:

(functionFullGC):
(functionEdenGC):

runtime/Options.h:

Source/WebCore:

No new tests.

Updated WebSafeGCActivityCallbacks for both Eden and Full timers.

bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::commonVM):

platform/ios/WebSafeGCActivityCallbackIOS.h:

6:54 PM Changeset in webkit [165939] by Alan Bujtas

2 edits in trunk/LayoutTests

Generated hidpi- images (actual) on ML WK2 Debug are blurry/color shifted.

Unreviewed TestExpectations update on ML WK2 debug.

platform/mac-wk2/TestExpectations:

6:49 PM Changeset in webkit [165938] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Fix JavaScriptCore ChangeLog

6:05 PM Changeset in webkit [165937] by eric.carlson@apple.com

2 edits in trunk/LayoutTests

media/video-remote-control-playpause.html frequently fails on the bots
https://bugs.webkit.org/show_bug.cgi?id=130490

Unreviewed TestExpectations update.

platform/mac/TestExpectations: Mark test as flakey while I try to reproduce it.

5:50 PM Changeset in webkit [165936] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Address late review comment and style nit after r165934.

UIProcess/ios/ViewGestureControllerIOS.mm:

(WebKit::ViewGestureController::beginSwipeGesture):

5:37 PM Changeset in webkit [165935] by aestes@apple.com

2 edits in trunk/Source/WebCore

Fix the iOS build after r165917.

platform/ios/WebCoreSystemInterfaceIOS.mm:

5:32 PM Changeset in webkit [165934] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

[iOS][WebKit2] Back-forward swipe doesn't always complete with fingers down
https://bugs.webkit.org/show_bug.cgi?id=130489
<rdar://problem/16027007>

Reviewed by Simon Fraser.

UIProcess/ios/ViewGestureControllerIOS.mm:

(WebKit::ViewGestureController::beginSwipeGesture):
In order to have fingers-down swipe completion work correctly, we need
to give UIKit an empty interactive update block.

5:18 PM Changeset in webkit [165933] by commit-queue@webkit.org

17 edits
4 deletes in trunk/Source

Unreviewed, rolling out r165926.
https://bugs.webkit.org/show_bug.cgi?id=130488

broke the iOS build (Requested by estes on #webkit).

Reverted changeset:

Source/JavaScriptCore:

"GC timer should intelligently choose between EdenCollections
and FullCollections"
https://bugs.webkit.org/show_bug.cgi?id=128261
http://trac.webkit.org/changeset/165926

Source/WebCore:

"GC timer should intelligently choose between EdenCollections
and FullCollections"
https://bugs.webkit.org/show_bug.cgi?id=128261
http://trac.webkit.org/changeset/165926

5:13 PM Changeset in webkit [165932] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Unreviewed, rolling out r165929.
https://bugs.webkit.org/show_bug.cgi?id=130487

in order to roll out r165926 (Requested by estes on #webkit).

Reverted changeset:

http://trac.webkit.org/changeset/165929

4:45 PM Changeset in webkit [165931] by andersca@apple.com

3 edits in trunk/Source/WebKit2

Get rid of two IPC::Connection functions by folding them into lambdas
https://bugs.webkit.org/show_bug.cgi?id=130482

Reviewed by Tim Horton.

Platform/IPC/Connection.cpp:

(IPC::Connection::addWorkQueueMessageReceiver):
(IPC::Connection::removeWorkQueueMessageReceiver):

Platform/IPC/Connection.h:

4:44 PM Changeset in webkit [165930] by Simon Fraser

6 edits in trunk

Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=130476

Source/WebKit2:

Reviewed by Anders Carlsson.

Expose page and text zoom as SPI.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _supportsTextZoom]):
(-[WKWebView _textZoomFactor]):
(-[WKWebView _setTextZoomFactor:]):
(-[WKWebView _pageZoomFactor]):
(-[WKWebView _setPageZoomFactor:]):

UIProcess/API/Cocoa/WKWebViewPrivate.h:

Tools:

Reviewed by Anders Carlsson.

Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.

MiniBrowser/mac/WK1BrowserWindowController.m:

(-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
Remove log.

MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]):
(-[WK2BrowserWindowController validateMenuItem:]):
(-[WK2BrowserWindowController reload:]):
Hook up reload.
(-[WK2BrowserWindowController toggleZoomMode:]):
(-[WK2BrowserWindowController resetZoom:]):
(-[WK2BrowserWindowController canResetZoom]):
(-[WK2BrowserWindowController currentZoomFactor]):
(-[WK2BrowserWindowController setCurrentZoomFactor:]):
(-[WK2BrowserWindowController canZoomIn]):
(-[WK2BrowserWindowController canZoomOut]):

4:27 PM Changeset in webkit [165929] by mhahnenberg@apple.com

3 edits in trunk/Source/WebCore

Build fix for iOS after r165926

bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::commonVM):

platform/ios/WebSafeGCActivityCallbackIOS.h:

3:42 PM Changeset in webkit [165928] by eric.carlson@apple.com

5 edits in trunk/Source/WebCore

Allow media engine to update HTMLMediaElement state when playing to external device
https://bugs.webkit.org/show_bug.cgi?id=130480

Reviewed by Jer Noble.

html/HTMLMediaElement.h: Add mediaPlayerHandlePlaybackCommand.

platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::handlePlaybackCommand): New.

platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerHandlePlaybackCommand):

platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::rateChanged): Send Play and Pause commands when

playing to an external device.

3:39 PM Changeset in webkit [165927] by krit@webkit.org

5 edits
6 adds in trunk

Implement isPointInPath and isPointInStroke with Path2D argument
https://bugs.webkit.org/show_bug.cgi?id=130473

Reviewed by Dean Jackson.

Source/WebCore:

Implement isPointInPath and isPointInStroke for 2D Canvas contxts
with Path2D argument.

Tests: fast/canvas/canvas-path-isPointInPath.html

fast/canvas/canvas-path-isPointInStroke.html

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::isPointInPath):
(WebCore::CanvasRenderingContext2D::isPointInStroke):
(WebCore::CanvasRenderingContext2D::isPointInPathInternal):
(WebCore::CanvasRenderingContext2D::isPointInStrokeInternal):

html/canvas/CanvasRenderingContext2D.h:
html/canvas/CanvasRenderingContext2D.idl:

LayoutTests:

Test isPointInPath and isPointInStroke with Path2D argument.

fast/canvas/canvas-path-isPointInPath-expected.txt: Added.
fast/canvas/canvas-path-isPointInPath.html: Added.
fast/canvas/canvas-path-isPointInStroke-expected.txt: Added.
fast/canvas/canvas-path-isPointInStroke.html: Added.
fast/canvas/script-tests/canvas-path-isPointInPath.js: Added.
fast/canvas/script-tests/canvas-path-isPointInStroke.js: Added.

3:21 PM Changeset in webkit [165926] by mhahnenberg@apple.com

17 edits
4 adds in trunk/Source

GC timer should intelligently choose between EdenCollections and FullCollections
https://bugs.webkit.org/show_bug.cgi?id=128261

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

heap/GCActivityCallback.cpp:

(JSC::GCActivityCallback::GCActivityCallback):
(JSC::GCActivityCallback::doWork):
(JSC::FullGCActivityCallback::FullGCActivityCallback):
(JSC::FullGCActivityCallback::doCollection):
(JSC::EdenGCActivityCallback::EdenGCActivityCallback):
(JSC::EdenGCActivityCallback::doCollection):
(JSC::GCActivityCallback::scheduleTimer):
(JSC::GCActivityCallback::cancelTimer):
(JSC::GCActivityCallback::didAllocate):
(JSC::GCActivityCallback::willCollect):
(JSC::GCActivityCallback::cancel):

heap/GCActivityCallback.h:

(JSC::GCActivityCallback::GCActivityCallback):
(JSC::GCActivityCallback::createFullTimer):
(JSC::GCActivityCallback::createEdenTimer):

heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::didAbandon):
(JSC::Heap::willStartCollection):
(JSC::Heap::updateAllocationLimits):
(JSC::Heap::setFullActivityCallback):
(JSC::Heap::setEdenActivityCallback):
(JSC::Heap::fullActivityCallback):
(JSC::Heap::edenActivityCallback):
(JSC::Heap::setGarbageCollectionTimerEnabled):
(JSC::Heap::didAllocate):

heap/Heap.h:
heap/HeapTimer.cpp:

(JSC::HeapTimer::timerDidFire):

Source/WebCore:

No new tests.

platform/ios/WebSafeGCActivityCallbackIOS.h: Update WebSafeGCActivityCallback

appropriately for the introduction of another type of GCActivityCallback.

2:57 PM Changeset in webkit [165925] by benjamin@webkit.org

2 edits in trunk/Source/WebKit2

[iOS][WK2] Reduce the extended background's opacity when WKContentView is smaller than its WKWebView
https://bugs.webkit.org/show_bug.cgi?id=130436

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-03-19
Reviewed by Beth Dakin.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _updateScrollViewBackground]):

2:55 PM Changeset in webkit [165924] by benjamin@webkit.org

2 edits in trunk/Source/WebKit2

[iOS][WebKit2] <rdar://problem/16330387> Do not use the keyboard rect for computing the general unobscuredRect, only use it for centering
https://bugs.webkit.org/show_bug.cgi?id=130382

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-03-19
Reviewed by Simon Fraser.

Always accumulating the keyboard rect out of the exposedRect caused some issues (see <rdar://problem/16330387>).
This patch split the rect in two: unobscured rect for WebCore, and unobscuredContentRectIncludingKeyboard for centering
UI Elements in view.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _zoomToRect:WebCore::atScale:origin:WebCore::]):
(-[WKWebView _scrollToRect:WebCore::origin:WebCore::minimumScrollDistance:]):
(-[WKWebView _zoomToRect:WebCore::withOrigin:WebCore::fitEntireRect:minimumScale:maximumScale:minimumScrollDistance:]):
(-[WKWebView _contentRectForUserInteraction]):
(-[WKWebView _updateVisibleContentRects]):

2:50 PM Changeset in webkit [165923] by timothy@apple.com

1 edit in trunk/Source/WebInspectorUI/Configurations/WebInspectorUIFramework.xcconfig

Attempt to fix the Production build.

2:48 PM Changeset in webkit [165922] by andersca@apple.com

2 edits
7 deletes in trunk/Source/WebKit2

Get rid of WKProcessClass
https://bugs.webkit.org/show_bug.cgi?id=130478

Reviewed by Dan Bernstein.

UIProcess/API/Cocoa/WKProcessClass.h: Removed.
UIProcess/API/Cocoa/WKProcessClass.mm: Removed.
UIProcess/API/Cocoa/WKProcessClassConfiguration.h: Removed.
UIProcess/API/Cocoa/WKProcessClassConfiguration.mm: Removed.
UIProcess/API/Cocoa/WKProcessClassConfigurationPrivate.h: Removed.
UIProcess/API/Cocoa/WKProcessClassPrivate.h: Removed.
UIProcess/API/Cocoa/WKWebViewConfigurationToBeRemoved.mm: Removed.
WebKit2.xcodeproj/project.pbxproj:

2:43 PM Changeset in webkit [165921] by Antti Koivisto

4 edits
2 adds in trunk

Crash with long selector list
https://bugs.webkit.org/show_bug.cgi?id=123006

Reviewed by Andreas Kling.

Source/WebCore:

Test: fast/css/long-selector-list-crash.html

css/CSSSelectorList.cpp:

(WebCore::CSSSelectorList::CSSSelectorList):
(WebCore::CSSSelectorList::adoptSelectorVector):
(WebCore::CSSSelectorList::operator=):

css/StyleRule.cpp:

(WebCore::StyleRule::create):

Add a bunch of asserts.

(WebCore::StyleRule::splitIntoMultipleRulesWithMaximumSelectorComponentCount):

This could produce a zero-length selector list.

LayoutTests:

fast/css/long-selector-list-crash-expected.txt: Added.
fast/css/long-selector-list-crash.html: Added.

2:42 PM Changeset in webkit [165920] by akling@apple.com

16 edits in trunk/Source/WebCore

Rebaseline bindings tests.

bindings/scripts/test/JS/*:

2:38 PM Changeset in webkit [165919] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

[iOS][MediaControls] Reverse-pinching using the built-in controls should enter full screen
https://bugs.webkit.org/show_bug.cgi?id=129707

Reviewed by Eric Carlson.

The default controls on iOS should respond to a pinch gesture by entering fullscreen. Add a gesture
event listener, and enter full screen if the user does a quick (>2 velocity) reverse (>1.25 scale) pinch.

Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.createBase):
(ControllerIOS.prototype.handlePlayButtonTouchEnd):
(ControllerIOS.prototype.handleBaseGestureStart):
(ControllerIOS.prototype.handleBaseGestureChange):
(ControllerIOS.prototype.handleBaseGestureEnd):

2:36 PM Changeset in webkit [165918] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

REGRESSION(r156316): Scrollbar on a large document is broken
https://bugs.webkit.org/show_bug.cgi?id=130474
<rdar://problem/16371523>

Reviewed by Anders Carlsson.

The bug was caused by updateArrowPlacement() doing the work even though Scrollbar Overlay API is available.
Prior to r156316, this function exited early:
http://trac.webkit.org/browser/trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.mm?rev=156315#L147

Fixed the bug by deleting updateArrowPlacement() entirely.

platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::preferencesChanged):

2:27 PM Changeset in webkit [165917] by jer.noble@apple.com

13 edits in trunk

[Mac][EME] Query whether decoder support exists before creating a new MediaKeys object.
https://bugs.webkit.org/show_bug.cgi?id=130459

Reviewed by Eric Carlson.

Source/WebCore:

WebCore.exp.in: Export the new WCSI method.
platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::supportsKeySystem): Bail early if we have no decoder support.

platform/mac/WebCoreSystemInterface.h: Provide a WCSI wrapper for WKSI.
platform/mac/WebCoreSystemInterface.mm: Ditto.

Source/WebKit/mac:

WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Initialize the new WCSI method.

Source/WebKit2:

WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Initialize the new WCSI method.

WebKitLibraries:

WebKitSystemInterface.h:
libWebKitSystemInterfaceMavericks.a:
libWebKitSystemInterfaceMountainLion.a:

2:08 PM Changeset in webkit [165916] by eric.carlson@apple.com

11 edits
2 adds in trunk

Make Remote Control commands testable
https://bugs.webkit.org/show_bug.cgi?id=130358

Reviewed by Jer Noble.

Source/WebCore:

Test: media/video-remote-control-playpause.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Call session->clientWillPausePlayback.
(WebCore::HTMLMediaElement::didReceiveRemoteControlCommand): Log the command.

platform/audio/MediaSession.cpp:

(WebCore::MediaSessionClient::mediaSessionTitle): Move from header file.
(WebCore::MediaSessionClient::mediaSessionDuration): Ditto.
(WebCore::MediaSessionClient::mediaSessionCurrentTime): Ditto.

platform/audio/MediaSession.h:

platform/audio/MediaSessionManager.cpp:

(WebCore::MediaSessionManager::MediaSessionManager): Get rid of m_activeSession.
(WebCore::MediaSessionManager::removeSession): No need to clear m_activeSession because

we use the m_sessions vector.

(WebCore::MediaSessionManager::sessionWillBeginPlayback): setCurrentSession takes a

MediaSession&.

(WebCore::MediaSessionManager::sessionWillEndPlayback): Keep m_sessions sorted so playing

sessions are before paused sessions.

(WebCore::MediaSessionManager::setCurrentSession): Move the session that is beginning to

play to the head of m_sessions.

(WebCore::MediaSessionManager::currentSession): Return m_sessions[0] or nullptr.
(WebCore::MediaSessionManager::didReceiveRemoteControlCommand):

platform/audio/MediaSessionManager.h:

platform/audio/ios/MediaSessionManagerIOS.mm: Include MediaPlayer.h.

testing/Internals.cpp:

(WebCore::Internals::postRemoteControlCommand): New.

testing/Internals.h:
testing/Internals.idl:

LayoutTests:

media/video-remote-control-playpause-expected.txt: Added.
media/video-remote-control-playpause.html: Added.

2:06 PM Changeset in webkit [165915] by thiago.lacerda@openbossa.org

6 edits
1 add in trunk

Improving webkitGetUserMedia error handling and error messages
https://bugs.webkit.org/show_bug.cgi?id=130452

Reviewed by Eric Carlson.

Checking if first argument of webkitGetUserMedia is a valid Dictionary. If not, throw an exception with a
clearer message of the error.

Source/WebCore:

Test updated.

Modules/mediastream/NavigatorMediaStream.idl:
UseJSC.cmake:
bindings/js/JSNavigatorCustom.cpp: Added.

LayoutTests:

fast/mediastream/argument-types-expected.txt:
fast/mediastream/script-tests/argument-types.js:

1:42 PM Changeset in webkit [165914] by akling@apple.com

20 edits in trunk/Source/WebCore

JSC bindings should use the passed-in global object for wrapper caching.
<https://webkit.org/b/130458>

Take a shorter path to the DOMWrapperWorld by using the passed-in
global object instead of getting the lexical global from ExecState.
Removed an old FIXME that no longer applies since JSObjects can
always find the right global object these days.

Reviewed by Geoff Garen.

bindings/js/JSCSSRuleCustom.cpp:

(WebCore::toJS):

bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):

bindings/js/JSCSSValueCustom.cpp:

(WebCore::toJS):

bindings/js/JSDOMBinding.h:

(WebCore::createWrapper):
(WebCore::wrap):
(WebCore::getExistingWrapper):
(WebCore::createNewWrapper):
(WebCore::toJS):

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::setTimeout):
(WebCore::JSDOMWindow::setInterval):
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):

bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::location):
(WebCore::toJS):

bindings/js/JSElementCustom.cpp:

(WebCore::toJSNewlyCreated):

bindings/js/JSEventCustom.cpp:

(WebCore::toJS):

bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::toJS):

bindings/js/JSHTMLTemplateElementCustom.cpp:

(WebCore::JSHTMLTemplateElement::content):

bindings/js/JSImageDataCustom.cpp:

(WebCore::toJS):

bindings/js/JSNodeCustom.cpp:

(WebCore::createWrapperInline):

bindings/js/JSNodeCustom.h:

(WebCore::toJS):

bindings/js/JSSVGPathSegCustom.cpp:

(WebCore::toJS):

bindings/js/JSStyleSheetCustom.cpp:

(WebCore::toJS):

bindings/js/JSTextTrackCueCustom.cpp:

(WebCore::toJS):

bindings/js/JSTrackCustom.cpp:

(WebCore::toJS):

bindings/js/JSWorkerGlobalScopeCustom.cpp:

(WebCore::JSWorkerGlobalScope::setTimeout):
(WebCore::JSWorkerGlobalScope::setInterval):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

1:41 PM Changeset in webkit [165913] by benjamin@webkit.org

2 edits in trunk/Source/WebCore

Page::setPageScaleFactor should not force the scroll view position when using delegatesScrolling()
https://bugs.webkit.org/show_bug.cgi?id=130429

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-03-19
Reviewed by Simon Fraser.

When setting the same scale mutliple time (for example on load), Page was asking the top scrollview
to scroll to the origin. This is bogus since the scroll view is driving Page::setDeviceScaleFactor,
not the other way around.

Simon fixed the general case in http://trac.webkit.org/changeset/165652/trunk/Source/WebCore/page/Page.cpp
but this branch was still scrolling content.

page/Page.cpp:

(WebCore::Page::setPageScaleFactor):

1:36 PM Changeset in webkit [165912] by fpizlo@apple.com

6 edits in trunk/Source/JavaScriptCore

REGRESSION(r165459): It broke 109 jsc stress test on ARM Thumb2 and Mac 32 bit
https://bugs.webkit.org/show_bug.cgi?id=130134

Reviewed by Mark Hahnenberg.

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode): Can't do some optimizations if you don't have a lot of registers.

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById): Move stuff around before going into the IC code to ensure that we give the IC code the invariants it needs. This only happens in case of GetByIdFlush, where we are forced into using weird combinations of registers because the results have to be in t0/t1.
(JSC::DFG::SpeculativeJIT::compile): For a normal GetById, the register allocator should just do the right thing so nobody has to move anything around.

jit/JITInlineCacheGenerator.cpp:

(JSC::JITGetByIdGenerator::JITGetByIdGenerator): Assert the things we want.

jit/JITInlineCacheGenerator.h:
jit/Repatch.cpp:

(JSC::generateGetByIdStub): Remove a previous incomplete hack to try to work around the DFG's problem.

1:12 PM Changeset in webkit [165911] by beidson@apple.com

9 edits in trunk/Source

Filter out editable services from image menu for non-contenteditable images
<rdar://problem/16319645> and https://bugs.webkit.org/show_bug.cgi?id=130437

Reviewed by Tim Horton.

Source/WebCore:

WebCore.exp.in:

Source/WebKit/mac:

Misc/WebSharingServicePickerController.h:
Misc/WebSharingServicePickerController.mm:

(-[WebSharingServicePickerController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):

Filter out editing services based on the includeEditorServices flag.

WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::contextMenuForEvent):

Source/WebKit2:

UIProcess/mac/WebContextMenuProxyMac.h:
UIProcess/mac/WebContextMenuProxyMac.mm:

(-[WKSharingServicePickerDelegate setIncludeEditorServices:]):
(-[WKSharingServicePickerDelegate sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):

Filter out editing services based on the includeEditorServices flag.

(WebKit::WebContextMenuProxyMac::setupImageServicesMenu):
(WebKit::WebContextMenuProxyMac::populate):

12:54 PM Changeset in webkit [165910] by krit@webkit.org

10 edits
3 adds in trunk

Implement method addPath for Path2D
https://bugs.webkit.org/show_bug.cgi?id=130461

Reviewed by Dean Jackson.

Source/WebCore:

Add support for the Path2D method addPath. The method allows
to append and existing Path2D object to another one. It can be
combined with a transformation matrix SVGMatrix.

Test: fast/canvas/canvas-path-addPath.html

html/canvas/DOMPath.h: Add new method addPath().

(WebCore::DOMPath::addPath):

html/canvas/DOMPath.idl:
platform/graphics/Path.h: Add support for appending paths.
platform/graphics/cairo/PathCairo.cpp:

(WebCore::Path::addPath):

platform/graphics/cg/PathCG.cpp:

(WebCore::Path::addPath):

platform/graphics/wince/PathWinCE.cpp:

(WebCore::Path::addPath):

LayoutTests:

Test the addPath Path2D method.

platform/efl/TestExpectations:
platform/gtk/TestExpectations:
fast/canvas/canvas-path-addPath-expected.txt: Added.
fast/canvas/canvas-path-addPath.html: Added.

12:32 PM Changeset in webkit [165909] by mhahnenberg@apple.com

2 edits in trunk/Source/JavaScriptCore

Normalize some of the older JSC options
https://bugs.webkit.org/show_bug.cgi?id=128753

Reviewed by Michael Saboff.

runtime/Options.cpp:

(JSC::Options::initialize):

12:24 PM Changeset in webkit [165908] by commit-queue@webkit.org

9 edits
1 add in trunk/Source

[iOS] WebKit2 Quicklook.
https://bugs.webkit.org/show_bug.cgi?id=130360

Source/WebCore:

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-03-19
Reviewed by Tim Horton.

Since ResourceLoaders using WebKit2 network process don't have ResourceHandle any more, we
need to make it possible to create QuickLookHandle from ResourceLoader.

WebCore.exp.in: Make some QuickLookHandle methods visible from WebKit2.
loader/ResourceLoader.h: Add m_quickLookHandle data member to ResourceLoader.

(WebCore::ResourceLoader::quickLookHandle):
(WebCore::ResourceLoader::setQuickLookHandle):

platform/network/ios/QuickLook.h: Add a new method to create QuickLookHandle from ResourceLoader.
platform/network/ios/QuickLook.mm:

(WebCore::QuickLookHandle::create):

Source/WebKit2:

For WebKit2 resource loads, if we detect a quicklook content that QLConverter is able to
convert, handle the response data to QLConverter and use its delegate WKWebResourceQuickLookDelegate
to rounte the converted results (HTML) back into WebCore. Thie similiar logic has been in place
for WebKit1.

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-03-19
Reviewed by Tim Horton.

WebKit2.xcodeproj/project.pbxproj: Add WebResourceLoaderIOS.mm to the project.
WebProcess/Network/WebResourceLoadScheduler.cpp:
WebProcess/ios/WebResourceLoaderIOS.mm: Added.

(-[WKWebResourceQuickLookDelegate initWithWebResourceLoader:WebKit::]): WKWebResourceQuickLookDelegate holds

the original WebResourceLoader so that we could send converted result to WebCore.

(-[WKWebResourceQuickLookDelegate connection:didReceiveDataArray:]):
(-[WKWebResourceQuickLookDelegate connection:didReceiveData:lengthReceived:]):
(-[WKWebResourceQuickLookDelegate connectionDidFinishLoading:]):
(-[WKWebResourceQuickLookDelegate connection:didFailWithError:]):
(-[WKWebResourceQuickLookDelegate clearHandle]):
(WebKit::WebResourceLoader::setUpQuickLookHandleIfNeeded):

12:21 PM Changeset in webkit [165907] by jer.noble@apple.com

2 edits in trunk/Source/WebKit/mac

[iOS] Disable the video plugin proxy by default on WK1.
https://bugs.webkit.org/show_bug.cgi?id=130460

Reviewed by Eric Carlson.

Update the defaults to universally enable the AVFoundationEnabled preference, disable the
VideoPluginProxyEnabled preference, and on iOS only enable the AVKitEnabled preference.

WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

12:00 PM Changeset in webkit [165906] by barraclough@apple.com

4 edits in trunk/Source/WTF

Small cleanup of empty string
https://bugs.webkit.org/show_bug.cgi?id=130438

Reviewed by Anders Carlson.

The empty string is weird becuase it is used as the impl for an AtomicString, but isAtomic()
returns false.
Also, we set a valid pointer for the characters pointer due to an old PCRE bug; remove this.
Also, we currently only create one 'static' string, the empty string. Adding more might break
assumtions, inhibit the constructor from being used to create other static strings for now.

wtf/text/AtomicString.h:

(WTF::AtomicString::add):

update assert.

wtf/text/StringImpl.h:

(WTF::StringImpl::StringImpl):

Merge ConstructStaticString constructors, only allow the empty static string to be constructed.

wtf/text/StringStatics.cpp:

(WTF::StringImpl::empty):

ConstructStaticString -> ConstructEmptyString, remove arguments, DEPRECATED_DEFINE_STATIC_LOCAL -> NeverDestroyed.

12:00 PM Changeset in webkit [165905] by Brent Fulgham

7 edits in trunk

Fix cue rendering test and include support for left/right alignment
https://bugs.webkit.org/show_bug.cgi?id=130406

Reviewed by Eric Carlson.

Merged from Blink (patch by vcarbune@chromium.org):
https://chromium.googlesource.com/chromium/blink/+/e695703cb603421c741e59a557a7989113c13b94
http://crbug.com/25155003

Source/WebCore:

No new tests. Covered by media/track/track-cue-rendering-snap-to-lines-not-set.html.

html/track/VTTCue.cpp:

(WebCore::leftKeyword): Added.
(WebCore::rightKeyword): Added.
(WebCore::VTTCueBox::applyCSSProperties): Added.
(WebCore::VTTCue::VTTCue):
(WebCore::VTTCue::align): Handle left/right alignment.
(WebCore::VTTCue::setAlign): Ditto.
(WebCore::VTTCue::calculateDisplayParameters): Refactored and revised for left/right tokens.
(WebCore::VTTCue::setCueSettings): Ditto.
(WebCore::VTTCue::getCSSAlignment): Added.
(WebCore::VTTCue::getCSSWritingMode): Added.

html/track/VTTCue.h:

LayoutTests:

media/track/captions-webvtt/captions-snap-to-lines-not-set.vtt: Revised for left/right alignment tags.
media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt: Ditto.
media/track/track-cue-rendering-snap-to-lines-not-set.html: Ditto.

11:27 AM Changeset in webkit [165904] by oliver@apple.com

2 edits in branches/safari-537.75-branch/LayoutTests

Don't use ES6 features in testcase.

10:56 AM Changeset in webkit [165903] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

WebKit2 View Gestures: Swipe gesture can track vertical movement instead of horizontal movement
https://bugs.webkit.org/show_bug.cgi?id=130441
<rdar://problem/16337279>

Reviewed by Simon Fraser.

UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::scrollEventCanBecomeSwipe):
Factor logic that determines if a scroll event can become a swipe
out into scrollEventCanBecomeSwipe.
Use <= instead of < when comparing the axes, because we don't want
to start a swipe on a completely diagonal scroll either (because AppKit
can start tracking a vertical swipe in that case).

(WebKit::ViewGestureController::handleScrollWheelEvent):
(WebKit::ViewGestureController::wheelEventWasNotHandledByWebCore):
Make use of scrollEventCanBecomeSwipe.

10:53 AM Changeset in webkit [165902] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

Update type of local vars to match the type of String length.
<https://webkit.org/b/130077>

Reviewed by Geoffrey Garen.

runtime/JSStringJoiner.cpp:

(JSC::JSStringJoiner::join):

10:51 AM Changeset in webkit [165901] by bshafiei@apple.com

3 edits in tags/Safari-538.23.1/Source/WebKit2

Merged r165632.

10:36 AM Changeset in webkit [165900] by andersca@apple.com

5 edits in trunk/Source

Add new functionality that will be required by the history item decoding
https://bugs.webkit.org/show_bug.cgi?id=130433

Reviewed by Sam Weinig.

Source/WebCore:

platform/KeyedCoding.h:

(WebCore::KeyedDecoder::decodeConditionalObject):

Source/WebKit2:

Shared/cf/KeyedDecoder.cpp:

(WebKit::KeyedDecoder::decodeUInt32):
(WebKit::KeyedDecoder::decodeInt32):
(WebKit::KeyedDecoder::decodeFloat):

Shared/cf/KeyedDecoder.h:

10:27 AM Changeset in webkit [165899] by ap@apple.com

2 edits in trunk/Tools

REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
https://bugs.webkit.org/show_bug.cgi?id=130463

TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.

9:47 AM Changeset in webkit [165898] by Brent Fulgham

2 edits in trunk/LayoutTests

Unreviewed test system fix.

TestExpectations: I mistakenly checked in the region-webvtt tests as enabled. This feature is not

ready to be turned on for all platforms yet.

9:00 AM Changeset in webkit [165897] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

Fix the iOS build.

html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::parseToDateComponents):
Missing a StringView().

8:39 AM Changeset in webkit [165896] by timothy_horton@apple.com

5 edits in trunk/Source

[iOS] WebPDFViewPlaceholder divides-by-zero with an empty document
https://bugs.webkit.org/show_bug.cgi?id=130444
<rdar://problem/15580682>

Reviewed by Sam Weinig.

WebView/WebPDFViewPlaceholder.h:
WebView/WebPDFViewPlaceholder.mm:

(-[WebPDFViewPlaceholder layout]):
Get rid of boundingSize, it's never assigned to anything but CGSizeZero,
which is confusing.

Don't divide by zero if we have no pages, instead return an empty bounding size.

(-[WebPDFViewPlaceholder _computePageRects:]):
If we have an empty document, set the background color to white.
Otherwise, set it to black. It's not clear that black is the ideal
background color, but this retains existing behavior.

UIProcess/ios/WKPDFView.mm:

(-[WKPDFView web_setContentProviderData:]):
Don't make UIPDFPageViews for null pages.

8:32 AM Changeset in webkit [165895] by fred.wang@free.fr

3 edits
2 moves in trunk/LayoutTests

Unreviewed gardening.

platform/efl/TestExpectations: remove failures for mo/row since they are already in skipped in the main TestExpectations.
platform/gtk/mathml/presentation/mspace-children-expected.png: Move mspace-children-expected.png to platform/gtk.
platform/gtk/mathml/presentation/mspace-children-expected.txt: Move mspace-children-expected.txt to platform/gtk.
platform/win/TestExpectations: remove failures for mo/row/roots since they are already in skipped in the main TestExpectations.

8:19 AM Changeset in webkit [165894] by Antti Koivisto

9 edits in trunk/Source/WebCore

Tighten ElementRuleCollector::m_matchedRuleList typing
https://bugs.webkit.org/show_bug.cgi?id=130446

Reviewed by Anders Carlsson.

StyleRuleBase -> StyleRule.

css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::matchedRuleList):

css/ElementRuleCollector.h:
css/StyleResolver.cpp:

(WebCore::StyleResolver::styleRulesForElement):
(WebCore::StyleResolver::pseudoStyleRulesForElement):

css/StyleResolver.h:
editing/EditingStyle.cpp:

(WebCore::styleFromMatchedRulesForElement):

inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::buildArrayForMatchedRuleList):

inspector/InspectorCSSAgent.h:
page/DOMWindow.cpp:

(WebCore::DOMWindow::getMatchedCSSRules):

8:11 AM Changeset in webkit [165893] by mihnea@adobe.com

2 edits in trunk/Source/WebCore

[CSSRegions] An unsplittable box is always displayed in a single region
https://bugs.webkit.org/show_bug.cgi?id=130451

Reviewed by Andrei Bucur.

Add an ASSERT stating that an unsplittable box region range always contains 1 region.
No new functionality, no new tests.

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::getRegionRangeForBox):

7:25 AM Changeset in webkit [165892] by Alan Bujtas

9 edits
2 adds in trunk

Subpixel rendering: Transform origin is miscalculated when RenderLayer's
offsetfromRenderer has device pixel fraction value.
https://bugs.webkit.org/show_bug.cgi?id=129859

Reviewed by Simon Fraser.

We need to calculate the transformed origin using the painting coordinates to produce
pixel precise result.

Source/WebCore:

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::computeTransformOriginForPainting):

rendering/RenderLayerBacking.h:

LayoutTests:

compositing/columns/composited-columns-expected.txt:
compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt:
compositing/repaint/resize-repaint-expected.txt:
platform/mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
platform/mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt:

7:04 AM WebKitGTK/2.4.x edited by Claudio Saavedra

(diff)

6:49 AM Changeset in webkit [165891] by Claudio Saavedra

2 edits in trunk/Source/WebCore

[GStreamer] Clean timeout source ids
https://bugs.webkit.org/show_bug.cgi?id=130450

Reviewed by Philippe Normand.

Sources IDs need to be cleaned up if the callback removes the
source, otherwise we'll be attempting to remove an empty source at
some point.

platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:

(webKitMediaVideoSrcStart): Clean the source id.
(webKitMediaAudioSrcStart): Ditto.
(webKitMediaVideoSrcSeekMainCb): Ditto.
(webKitMediaAudioSrcSeekMainCb): Ditto.

5:38 AM Changeset in webkit [165890] by mihnea@adobe.com

13 edits
8 adds in trunk

[CSSRegions] Compute region ranges for children of inline blocks
https://bugs.webkit.org/show_bug.cgi?id=130392

Reviewed by Andrei Bucur.

Source/WebCore:

Extend the region ranges computation for children of inline blocks.
When we cannot retrieve the region range for a box using cached information,
either from region range map or from the region cached on the RootInlineBox,
try to find the top most unsplittable box up to the flow thread boundary.
If we find such unsplittable box and the box has a region range, then return
this range.

Before this patch, method getRegionRangeForBox did not return true/false
if it was able to retrieve the range and the caller checked the returned
region values. I modified the method to return true if we were able to compute
the range.

Tests: fast/regions/inline-block-inline-children-flowed-in-regions.html

fast/regions/inline-blocks-dyn-enlarged-regions.html
fast/regions/inline-blocks-dyn-shrunk-regions.html
fast/regions/inline-blocks-in-two-regions.html

inspector/InspectorOverlay.cpp:

(WebCore::buildObjectForRendererFragments):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateRegionRangeForBoxChild):

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::hasNextPage):

rendering/RenderBox.cpp:

(WebCore::RenderBox::clampToStartAndEndRegions):
(WebCore::RenderBox::borderBoxRectInRegion):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::layoutOverflowRectForPropagation):

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint):

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::regionForCompositedLayer):
(WebCore::RenderFlowThread::adjustedPositionRelativeToOffsetParent):
(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
(WebCore::RenderFlowThread::logicalWidthChangedInRegionsForBlock):
(WebCore::RenderFlowThread::getRegionRangeForBoxFromCachedInfo):
(WebCore::RenderFlowThread::getRegionRangeForBox):
(WebCore::RenderFlowThread::objectShouldPaintInFlowRegion):
(WebCore::RenderFlowThread::objectInFlowRegion):
(WebCore::RenderFlowThread::addRegionsVisualEffectOverflow):
(WebCore::RenderFlowThread::addRegionsVisualOverflowFromTheme):
(WebCore::RenderFlowThread::addRegionsOverflowFromChild):
(WebCore::RenderFlowThread::addRegionsLayoutOverflow):
(WebCore::RenderFlowThread::addRegionsVisualOverflow):
(WebCore::RenderFlowThread::clearRegionsOverflow):

rendering/RenderFlowThread.h:
rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::fragmentFromAbsolutePointAndBox):

rendering/RenderObject.cpp:

(WebCore::RenderObject::locateFlowThreadContainingBlock):
Make sure we return the right render flow thread in the case of
region-based multicolumn inside named flows.

rendering/RenderRegion.cpp:

(WebCore::RenderRegion::rectFlowPortionForBox):

LayoutTests:

fast/regions/inline-block-inline-children-flowed-in-regions-expected.html: Added.
fast/regions/inline-block-inline-children-flowed-in-regions.html: Added.
fast/regions/inline-blocks-dyn-enlarged-regions-expected.html: Added.
fast/regions/inline-blocks-dyn-enlarged-regions.html: Added.
fast/regions/inline-blocks-dyn-shrunk-regions-expected.html: Added.
fast/regions/inline-blocks-dyn-shrunk-regions.html: Added.
fast/regions/inline-blocks-in-two-regions-expected.html: Added.
fast/regions/inline-blocks-in-two-regions.html: Added.

5:21 AM Changeset in webkit [165889] by fred.wang@free.fr

5 edits in trunk/LayoutTests

Fix reftest failure of mathml/presentation/bug95404.html.

Unreviewed gardering.

After bug 116600, the test is only failing because of some difference
invisible by the naked eye, due to antialiasing of the radical symbol.

mathml/presentation/bug95404-expected.html: add a 2px border to prevent antialiasing.
mathml/presentation/bug95404.html: ditto.
platform/efl/TestExpectations: remove test failure.
platform/gtk/TestExpectations: ditto.

3:58 AM Changeset in webkit [165888] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-2.2.6

Tagging the WebKitGTK+ 2.2.6 release

3:55 AM Changeset in webkit [165887] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.2

Unreviewed. Update NEWS and Versions.m4 for 2.2.6 release.

Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

NEWS: Add release notes.

2:47 AM Changeset in webkit [165886] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r165812 - [GTK] Race condition when the socket event source is cancelled
https://bugs.webkit.org/show_bug.cgi?id=130395

Reviewed by Martin Robinson.

In some cases when the socket event source is cancelled the socket
event source callback is called with the condition of the previous
poll instead of 0. This can happen sometimes when the source is
cancelled from the socket event source callback. Once the socket
event source is cancelled, it's dispatched by glib without
polling, so the condition is never reset again and the callback is
called again and again with the previous condition. When the
condition is G_IO_IN, the source is re-scheduled entering into an
infinite loop. We should always check if the source has been
cancelled at the beginning of the callback to destroy the source
instead of relying on the condition being 0.

Platform/gtk/WorkQueueGtk.cpp:

(WorkQueue::SocketEventSource::isCancelled):
(WorkQueue::SocketEventSource::eventCallback):

2:40 AM Changeset in webkit [165885] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r165550 - [GTK] Close the connection when we fail to read from the socket for any unhandled error
https://bugs.webkit.org/show_bug.cgi?id=130191

Reviewed by Martin Robinson.

We currently show an error message, but we should close the
connection avoid entering an infinite loop. Also provide more
information in the error message to help when debugging the issue.

Platform/IPC/unix/ConnectionUnix.cpp:

(IPC::Connection::readyReadHandler):

2:34 AM Changeset in webkit [165884] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r165371 - [GTK] The web process can finish while a print operation is still ongoing
https://bugs.webkit.org/show_bug.cgi?id=129871

Reviewed by Martin Robinson.

This can happen when the last page is closed while the print job
is sending data to the printer.

WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp: Disable web

process termination when the print job is sending data to the
printer and enable it again when job finishes.

2:19 AM Changeset in webkit [165883] by Carlos Garcia Campos

5 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r165489 - [GTK] Runtime error when page is closed while print operation is in progress
https://bugs.webkit.org/show_bug.cgi?id=129869

Reviewed by Anders Carlsson.

Sometimes when the page is closed right after printing the web
process aborts with the runtime message "pure virtual method
called terminate called without an active exception".
This happens because the page is closed when the pages have been
printed, but print job is still ongoing sending the data to the
printer. When print job finishes, we try to notify the UI process
sending the print callback message using WebPage::send(), but the
web page object has been destroyed. The virtual method it complains
about is probably MessageSender::messageSenderDestinationID() used
by send(). Since our print operation is always asynchronous, we
need a way to notify the web page when the print operation has
actually finished to clean it up, but also notify the print
operation when the page has been closed to not try to notify the
UI process in that case.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::close): Call disconnectFromPage to notify the
print operation in case there's an ongoing print job.
(WebKit::WebPage::endPrinting): Do not cleanup the print operation
here, since the print opertation might not have finished yet.
(WebKit::WebPage::didFinishPrintOperation): Send
PrintFinishedCallback message to the Ui process and cleanup the
print operation.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::WebPrintOperationGtk::disconnectFromPage): Set m_webPage
to nullptr.
(WebKit::WebPrintOperationGtk::printDone): Call
didFinishPrintOperation() is the web page hasn't been closed.

WebProcess/WebPage/gtk/WebPrintOperationGtk.h:

2:16 AM Changeset in webkit [165882] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[EFL] vibration/cancelVibration-during-pattern-vibrating.html is failing after r165598
https://bugs.webkit.org/show_bug.cgi?id=130333

Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2014-03-19
Reviewed by Gyuyoung Kim.

Added setting m_state when calling Vibration::vibrate. It was missing after
refactoring Vibration (r165598).

Modules/vibration/Vibration.cpp:

(WebCore::Vibration::vibrate):

1:53 AM Changeset in webkit [165881] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r165182 - [GTK] Close the page when the view is disposed instead of when finalized
https://bugs.webkit.org/show_bug.cgi?id=129783

Reviewed by Sergio Villar Senin.

Source/WebKit2:

When a GtkWidget is destroyed, the GObject is disposed, but not
finalized if it has additional references. When the destroyed
widget is leaked by the application, we leak the page proxy and
what is more important the web process in multi-process mode.

UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseDispose): Close the WebPageProxy.

1:49 AM Changeset in webkit [165880] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore

Merge r164980 - [GTK] webkit_dom_range_compare_boundary_points fails when 0 is passed as how parameter
https://bugs.webkit.org/show_bug.cgi?id=129145

Patch by Tomas Popela <tpopela@redhat.com> on 2014-03-03
Reviewed by Carlos Garcia Campos.

While generating GObject DOM API the generator should skip non pointer
types while generating the g_return_val_if_fail macro.
This will avoid the situation when Range.START_TO_START is defined as 0,
thus the webkit_dom_range_compare_boundary_points function will fail
everytime it is called with 0 as how value.

bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunction):

1:38 AM Changeset in webkit [165879] by Carlos Garcia Campos

6 edits
3 adds in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r164808 - [GTK][WK2] Blocks when fetching plugins information
https://bugs.webkit.org/show_bug.cgi?id=115650

Reviewed by Gustavo Noronha Silva.

Use a persistent cache to store the plugins metadata to avoid
having to load all the plugins everytime a plugin is used for the
first time.

GNUmakefile.am:
GNUmakefile.list.am:
PlatformGTK.cmake:
Shared/Plugins/Netscape/NetscapePluginModule.h:
Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(WebKit::NetscapePluginModule::parseMIMEDescription): Make this
method public.
(WebKit::NetscapePluginModule::buildMIMEDescription): Added this
helper to build the MIME description string.

UIProcess/Plugins/gtk/PluginInfoCache.cpp: Added.

(WebKit::PluginInfoCache::shared):
(WebKit::PluginInfoCache::PluginInfoCache):
(WebKit::PluginInfoCache::~PluginInfoCache):
(WebKit::PluginInfoCache::saveToFileIdleCallback):
(WebKit::PluginInfoCache::saveToFile):
(WebKit::PluginInfoCache::getPluginInfo):
(WebKit::PluginInfoCache::updatePluginInfo):

UIProcess/Plugins/gtk/PluginInfoCache.h: Added.
UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:

(WebKit::PluginInfoStore::getPluginInfo): Check first if we have
metadata of the plugin in the cache and update the cache if we
loaded the plugin to get its metadata.

1:23 AM Changeset in webkit [165878] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r165745 - [GTK] Don't busy loop when the socket is full
https://bugs.webkit.org/show_bug.cgi?id=129802

Patch by Giovanni Campagna <gcampagna@src.gnome.org> on 2014-03-17
Reviewed by Carlos Garcia Campos.

When the socket is full and we see EAGAIN or EWOULDBLOCK
(because the socket is non blocking), don't busy loop by
tring to write again, instead poll() until the socket
becomes writable.

Platform/IPC/unix/ConnectionUnix.cpp:

(IPC::Connection::sendOutgoingMessage):

1:04 AM Changeset in webkit [165877] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Rewrite WebHTMLConverter::_colorForNode in C++
https://bugs.webkit.org/show_bug.cgi?id=130443

Patch by Sam Weinig <sam@webkit.org> on 2014-03-19
Reviewed by Andreas Kling.

platform/mac/HTMLConverter.mm:

(_platformColor):
Rename from _colorForRGBColor and simplify to just do the platform conversion.

(normalizedColor):
Extract normalization out of _colorForRGBColor and remove cases that are impossible to hit
due to us only ever using the device color space.

(HTMLConverterCaches::colorPropertyValueForNode):
(-[WebHTMLConverter _colorForNode:property:]):
Convert to C++.

(-[WebHTMLConverter dealloc]):
(-[WebHTMLConverter init]):
Remove caches, we already cache in ColorMac.

12:14 AM Changeset in webkit [165876] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2

Merge r165812 - [GTK] Race condition when the socket event source is cancelled
https://bugs.webkit.org/show_bug.cgi?id=130395

Reviewed by Martin Robinson.

Platform/gtk/WorkQueueGtk.cpp:

(WorkQueue::SocketEventSource::isCancelled):
(WorkQueue::SocketEventSource::eventCallback):

12:13 AM Changeset in webkit [165875] by berto@igalia.com

2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=130334

Patch by Piotr Drąg <piotrdrag@gmail.com> on 2014-03-19
Reviewed by Gustavo Noronha Silva.

pl.po: updated.

12:12 AM Changeset in webkit [165874] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2

Merge r165745 - [GTK] Don't busy loop when the socket is full
https://bugs.webkit.org/show_bug.cgi?id=129802

Patch by Giovanni Campagna <gcampagna@src.gnome.org> on 2014-03-17
Reviewed by Carlos Garcia Campos.

When the socket is full and we see EAGAIN or EWOULDBLOCK
(because the socket is non blocking), don't busy loop by
tring to write again, instead poll() until the socket
becomes writable.

Platform/IPC/unix/ConnectionUnix.cpp:

(IPC::Connection::sendOutgoingMessage):

Mar 18, 2014:

11:57 PM Changeset in webkit [165873] by abucur@adobe.com

5 edits
2 adds in trunk

[CSS Regions] Strange layout for content with region breaks
https://bugs.webkit.org/show_bug.cgi?id=121318

Reviewed by Mihnea Ovidenie.

Source/WebCore:

When break-inside: avoid is used on an element, the implementation tries to
force it inside a single fragmentation container even though the descendants
of the element specify forced breaks. This leads to unexpected results and
unstable layout.

The change extends the definition of unsplittable elements for flow threads
using the same conditions found inside RenderBlockFlow::adjustForUnsplittableChild.
This change forces elements that require break avoidance to have a single region
in the region range. As a result, forced breaks have no effect inside them.

It should be noted this may not the behavior defined by the CSS3 Fragmentation spec.
From my understanding of the text, forced breaks override any avoidance specified
by ancestor elements. However, implementing this is a larger change that will require
a fundamental new approach in handling break avoidance. This patch just brings
consistency to the API.

Test: fast/regions/forced-break-inside-avoid-break.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::childBoxIsUnsplittableForFragmentation):
(WebCore::RenderBlock::computeRegionRangeForBoxChild):
(WebCore::RenderBlock::estimateRegionRangeForBoxChild):

rendering/RenderBlock.h:
rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::adjustForUnsplittableChild): Move the avoidance conditions inside
a helper method RenderBlock::childBoxIsUnsplittableForFragmentation.

LayoutTests:

The test verifies that elements specifying break-inside: avoid can't
be splitted by forced breaks applied inside of them.

fast/regions/forced-break-inside-avoid-break-expected.txt: Added.
fast/regions/forced-break-inside-avoid-break.html: Added.

11:55 PM Changeset in webkit [165872] by timothy_horton@apple.com

10 edits in trunk/Source/WebKit2

[iOS][WebKit2] Provide generic software-snapshotting API
https://bugs.webkit.org/show_bug.cgi?id=130385
<rdar://problem/16005957>

Reviewed by Sam Weinig.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLayerTree:WebKit::]):
(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):

UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/API/Cocoa/_WKThumbnailView.mm:

(-[_WKThumbnailView initWithFrame:fromWKView:]):
(-[_WKThumbnailView _requestSnapshotIfNeeded]):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::internalShowContextMenu):

UIProcess/WebPageProxy.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::takeSnapshot):
(WebKit::WebPage::scaledSnapshotWithOptions):
(WebKit::WebPage::snapshotAtSize):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Rename TakeThumbnailSnapshot message to TakeSnapshot.

Fill the snapshot image with the FrameView's background color, to avoid
half-pixel alpha around the edges.

Factor snapshotAtSize out of scaledSnapshotWithOptions.

Don't apply both the custom and device scale factor to the base CTM,
only the device scale factor. Custom scale factor should only be
applied to the user CTM.

Shared/ImageOptions.h:

Add a snapshot option, RespectDrawingAreaTransform, that maps
the rect through the drawing area's root layer transform.
Use this in place of the thumbnail-specific code in TakeThumbnailSnapshot.
Add a snapshot option, ExcludeDeviceScaleFactor, which means that
snapshotting will not factor the device scale in (useful for drawing
to a bitmap at an exact requested size).

11:22 PM Changeset in webkit [165871] by jer.noble@apple.com

4 edits in branches/safari-537.75-branch/Source

Unreviewed Win64 build fix; explicit operators are not valid in VS2010.

Source/WebCore:

With the 'explicit bool' operator removed, just test weakThis.get() explicitly.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::checkPlayability):

Source/WTF:

wtf/WeakPtr.h: Remove the 'explicit bool' operator.

11:16 PM Changeset in webkit [165870] by Samuel White

22 edits
2 adds in trunk

AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
https://bugs.webkit.org/show_bug.cgi?id=130250

Reviewed by Chris Fleizach.

Source/WebCore:

If initial selection isn't set when we handle selection movement for accessibility, we need to set it. If we don't, using arrow
keys to read text with VoiceOver doesn't work as expected. Things will only start working after the user holds shift and arrows
around to select any arbitrary thing to force selection to get set. This logic handles that special case more gracefully.

Test: platform/mac/accessibility/selection-initial.html

page/EventHandler.cpp:

(WebCore::handleKeyboardSelectionMovement):
(WebCore::EventHandler::handleKeyboardSelectionMovementForAccessibility):

testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):

Source/WebKit:

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/mac:

Added ability to toggle enhanced accessibility on and off to support tests that require it.

WebView/WebFrame.mm:

(-[WebFrame enhancedAccessibilityEnabled]):
(-[WebFrame setEnhancedAccessibility:]):

WebView/WebFramePrivate.h:

Source/WebKit2:

Added ability to toggle enhanced accessibility on and off to support tests that require it.

WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKAccessibilityEnableEnhancedAccessibility):
(WKAccessibilityEnhancedAccessibilityEnabled):

WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:

Tools:

Added ability to toggle enhanced accessibility on and off to support tests that require it.

DumpRenderTree/AccessibilityController.cpp:

(enableEnhancedAccessibilityCallback):
(getEnhancedAccessibilityEnabledCallback):
(AccessibilityController::getJSClass):

DumpRenderTree/AccessibilityController.h:
DumpRenderTree/atk/AccessibilityControllerAtk.cpp:

(AccessibilityController::enableEnhancedAccessibility):
(AccessibilityController::enhancedAccessibilityEnabled):

DumpRenderTree/ios/AccessibilityControllerIOS.mm:

(AccessibilityController::enableEnhancedAccessibility):
(AccessibilityController::enhancedAccessibilityEnabled):

DumpRenderTree/mac/AccessibilityControllerMac.mm:

(AccessibilityController::enableEnhancedAccessibility):
(AccessibilityController::enhancedAccessibilityEnabled):

DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::enableEnhancedAccessibility):
(AccessibilityController::enhancedAccessibilityEnabled):

WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:

(WTR::AccessibilityController::enableEnhancedAccessibility):
(WTR::AccessibilityController::enhancedAccessibilityEnabled):

WebKitTestRunner/InjectedBundle/AccessibilityController.h:
WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:

LayoutTests:

Added test to ensure that initial selection gets set when enhanced accessibility is enabled and an arrow key is pressed.

platform/mac/accessibility/selection-initial-expected.txt: Added.
platform/mac/accessibility/selection-initial.html: Added.

9:44 PM Changeset in webkit [165869] by fpizlo@apple.com

11 edits
2 deletes in trunk/Source/JavaScriptCore

Get rid of Flush in SSA
https://bugs.webkit.org/show_bug.cgi?id=130440

Reviewed by Sam Weinig.

This is basically a red patch. We used to use backwards flow for determining what was
flushed, until it became clear that this doesn't make sense. Now the Flush nodes don't
accomplish anything. Keeping them around in SSA can only make things hard.

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.xcodeproj/project.pbxproj:
dfg/DFGBasicBlock.cpp:

(JSC::DFG::BasicBlock::SSAData::SSAData):

dfg/DFGBasicBlock.h:
dfg/DFGFlushLivenessAnalysisPhase.cpp: Removed.
dfg/DFGFlushLivenessAnalysisPhase.h: Removed.
dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

dfg/DFGSSAConversionPhase.cpp:

(JSC::DFG::SSAConversionPhase::run):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):

8:07 PM Changeset in webkit [165868] by fpizlo@apple.com

2 edits in trunk/Tools

Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
yet).

Scripts/webkitpy/common/config/contributors.json:

7:54 PM Changeset in webkit [165867] by Brent Fulgham

16 edits
5 adds in trunk

TextTrackRegion Not Implemented
https://bugs.webkit.org/show_bug.cgi?id=116546

Reviewed by Eric Carlson.

Merged from Blink (patch by vcarbune@chromium.org):
https://chromium.googlesource.com/chromium/blink/+/4940f89a087fea5b5ea628e98d0b355d398a9eea
http://crbug.com/25798003

Source/WebCore:

Tests: media/track/regions-webvtt/text-track-region-display.html

media/track/regions-webvtt/text-track-region-dom-layout.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::newRegionsAvailable):

html/track/TextTrack.cpp:
html/track/TextTrack.h:
html/track/TextTrackRegion.cpp:

(WebCore::TextTrackRegion::TextTrackRegion):
(WebCore::TextTrackRegion::appendTextTrackCueBox):

html/track/TextTrackRegion.h:
html/track/VTTCue.cpp:

(WebCore::VTTCue::VTTCue):
(WebCore::VTTCue::notifyRegionWhenRemovingDisplayTree):
(WebCore::VTTCue::removeDisplayTree):

html/track/VTTCue.h:
html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::parseBytes):
(WebCore::WebVTTParser::collectMetadataHeader):

html/track/WebVTTParser.h:

LayoutTests:

media/track/captions-webvtt/captions-regions.vtt: Added.
media/track/regions-webvtt/text-track-cue-region-attribute-expected.txt: Rebaseline.
media/track/regions-webvtt/text-track-region-display-expected.txt: Added.
media/track/regions-webvtt/text-track-region-display.html: Added.
media/track/regions-webvtt/text-track-region-dom-layout-expected.txt: Added.
media/track/regions-webvtt/text-track-region-dom-layout.html: Added.
media/track/regions-webvtt/text-track-region-list-expected.txt: Rebaseline.
media/track/regions-webvtt/text-track-region-parser-expected.txt: Rebaseline.

7:33 PM Changeset in webkit [165866] by akling@apple.com

4 edits in trunk/Source/WebCore

Share MemoryPressureHandler::releaseMemory() between platforms.
<https://webkit.org/b/130416>

Move the code that scours WebKit for things we can free up right now
to the common part of MemoryPressureHandler. This will enable other
platforms to do the same thing under pressure.

There's now also a platformReleaseMemory() where platform-specific
pressure relief stuff can go.

Reviewed by Antti Koivisto.

platform/MemoryPressureHandler.cpp:

(WebCore::MemoryPressureHandler::releaseMemory):
(WebCore::MemoryPressureHandler::platformReleaseMemory):

platform/MemoryPressureHandler.h:
platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::respondToMemoryPressure):
(WebCore::MemoryPressureHandler::platformReleaseMemory):

7:02 PM Changeset in webkit [165865] by dino@apple.com

2 edits in trunk/Source/WebCore

[WebGL] Destroy EAGLContext's backing store
https://bugs.webkit.org/show_bug.cgi?id=130439
<rdar://problem/16295217>

Reviewed by Tim Horton.

When a GraphicsContext3D is being destroyed, we should
also remove any EAGLContext backing store.

platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::~GraphicsContext3D):

6:57 PM Changeset in webkit [165864] by ryuan.choi@samsung.com

13 edits in trunk/Source/WebKit2

[EFL][WK2] Rename async APIs for better consistency with EFL
https://bugs.webkit.org/show_bug.cgi?id=130319

Reviewed by Gyuyoung Kim.

There are inconsistency with async keyword in several ewebkit2 APIs.
This patch rename them to {module/feature}_async_{verb} for better consistency with EFL.
In addition, added Async keyword into their callback name.

UIProcess/API/efl/ewk_application_cache_manager.cpp:

(EwkApplicationCacheOriginsAsyncData::EwkApplicationCacheOriginsAsyncData):
(getApplicationCacheOriginsCallback):
(ewk_application_cache_manager_origins_async_get):

UIProcess/API/efl/ewk_application_cache_manager.h:
UIProcess/API/efl/ewk_cookie_manager.cpp:

(EwkCookiePolicyAsyncData::EwkCookiePolicyAsyncData):
(getAcceptPolicyCallback):
(ewk_cookie_manager_accept_policy_async_get):
(EwkCookieHostnamesAsyncData::EwkCookieHostnamesAsyncData):
(getHostnamesWithCookiesCallback):
(ewk_cookie_manager_hostnames_with_cookies_async_get):

UIProcess/API/efl/ewk_cookie_manager.h:
UIProcess/API/efl/ewk_database_manager.cpp:

(EwkDatabaseOriginsAsyncData::EwkDatabaseOriginsAsyncData):
(getDatabaseOriginsCallback):
(ewk_database_manager_origins_async_get):

UIProcess/API/efl/ewk_database_manager.h:
UIProcess/API/efl/ewk_storage_manager.cpp:

(EwkStorageOriginsAsyncData::EwkStorageOriginsAsyncData):
(getStorageOriginsCallback):
(ewk_storage_manager_origins_async_get):

UIProcess/API/efl/ewk_storage_manager.h:
UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp:

(timerCallback):

UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:

(EWK2CookieManagerTest::getAcceptPolicy):
(EWK2CookieManagerTest::getHostnamesWithCookies):

UIProcess/API/efl/tests/test_ewk2_database_manager.cpp:

(EWK2DatabaseManagerTest::timerCallback):
(TEST_F):

UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:

(EWK2StorageManagerTest::timerCallback):
(TEST_F):

6:51 PM Changeset in webkit [165863] by timothy_horton@apple.com

11 edits in trunk/Source

[iOS][WebKit2] Mark layer contents as being opaque if they are
https://bugs.webkit.org/show_bug.cgi?id=130427
<rdar://problem/15540434>

Reviewed by Simon Fraser.

Shared/mac/RemoteLayerBackingStore.h:

(WebKit::RemoteLayerBackingStore::isOpaque):

Shared/mac/RemoteLayerBackingStore.mm:

(RemoteLayerBackingStore::RemoteLayerBackingStore):
(RemoteLayerBackingStore::ensureBackingStore):
(RemoteLayerBackingStore::encode):
(RemoteLayerBackingStore::decode):
(RemoteLayerBackingStore::display):
(RemoteLayerBackingStore::applyBackingStoreToLayer):
Move the code to set a RemoteLayerBackingStore as a CALayer's contents
from RemoteLayerTreePropertyApplier to RemoteLayerBackingStore (mostly
as a way to keep the USE(IOSURFACE) #ifs in one place).
Remove the surface() getter, because it's no longer needed, and make
image() private as it can be now (and rename it to createImageForFrontBuffer
for clarity's sake).

Add an isOpaque argument to ensureBackingStore, encode/decode it, and
add a getter. If isOpaque is true when applying backing store to the
CALayer on the UI process side, set CALayer.contentsOpaque to let CA know.

Make opaque bitmaps if not using accelerated drawing. For the IOSurface
case, we can't make opaque IOSurfaces, but telling CA that we have filled
the whole bitmap still enables similar optimizations.

Shared/mac/RemoteLayerTreePropertyApplier.mm:

(WebKit::applyPropertiesToLayer):
Reset contentsOpaque if the layer loses its backing store.

Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTextStream::operator<<):
(WebKit::dumpChangedLayers):
Add a bit more logging about RemoteLayerBackingStore's opaqueness
and acceleratedness.

WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::updateBackingStore):
(PlatformCALayerRemote::setOpaque):
Invalidate the RemoteLayerBackingStore if layer opaqueness changes.

platform/graphics/GraphicsLayerClient.h:

(WebCore::GraphicsLayerClient::paintsOpaquelyAtNonIntegralScales):

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateContentsOpaque):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintsOpaquelyAtNonIntegralScales):

rendering/RenderLayerBacking.h:

r159463 stopped us from setting layers opaque if they were being painted
at non-integral scale. This makes sense for compositing layers, which
are painted by arbitrary elements, but the main frame's RenderView
will always paint its entire contents. To restore the opaque contents
optimization to the main frame's tiles, don't de-opaquify layers
belonging to the main frame's RenderView.

6:48 PM Changeset in webkit [165862] by jpfau@apple.com

3 edits in trunk/Source/WebCore

Unify <media> element callback registration and unregistration
https://bugs.webkit.org/show_bug.cgi?id=130417

Reviewed by Eric Carlson.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::registerWithDocument):
(WebCore::HTMLMediaElement::unregisterWithDocument):
(WebCore::HTMLMediaElement::didMoveToNewDocument):

html/HTMLMediaElement.h:

6:38 PM Changeset in webkit [165861] by fpizlo@apple.com

2 edits in tags/Safari-538.23.1/Source/JavaScriptCore

Merge r165860.

2014-03-18 Filip Pizlo <fpizlo@apple.com>

Unreviewed, fix iOS production build.

JavaScriptCore.xcodeproj/project.pbxproj:

6:36 PM Changeset in webkit [165860] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix iOS production build.

JavaScriptCore.xcodeproj/project.pbxproj:

5:38 PM Changeset in webkit [165859] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

MediaDocument should set a max-width on its <video> element.
https://bugs.webkit.org/show_bug.cgi?id=114691

Reviewed by Eric Carlson.

Set a style attribute containing max-width:100% and max-height:100% so that large videos
are entirely visible within the browser window bounds.

html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):

5:28 PM Changeset in webkit [165858] by thiago.lacerda@openbossa.org

5 edits in trunk/Source/WebCore

[WebRTC] Fix layering violation in RTCStatsRequest
https://bugs.webkit.org/show_bug.cgi?id=130426

Reviewed by Eric Carlson.

RTCStatsRequest::track() should return a MediaStreamTrackPrivate*.

No new tests needed.

Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::getStats):

Modules/mediastream/RTCStatsRequestImpl.cpp:

(WebCore::RTCStatsRequestImpl::create):
(WebCore::RTCStatsRequestImpl::RTCStatsRequestImpl):
(WebCore::RTCStatsRequestImpl::track):

Modules/mediastream/RTCStatsRequestImpl.h:
platform/mediastream/RTCStatsRequest.h:

5:01 PM Changeset in webkit [165857] by timothy@apple.com

1 edit in trunk/Source/WebInspectorUI/Configurations/WebInspectorUIFramework.xcconfig

Attempt to fix the Production build.

4:54 PM Changeset in webkit [165856] by beidson@apple.com

22 edits in trunk/Source/WebKit2

Make image controls menu work in WK2
<rdar://problem/16294412> and https://bugs.webkit.org/show_bug.cgi?id=130424

Reviewed by Tim Horton.

Platform/SharedMemory.h:
Platform/mac/SharedMemoryMac.cpp:

(WebKit::SharedMemory::Handle::~Handle):
(WebKit::SharedMemory::Handle::clear):

Platform/unix/SharedMemoryUnix.cpp:

(WebKit::SharedMemory::Handle::~Handle):
(WebKit::SharedMemory::Handle::clear):

Shared/ContextMenuContextData.cpp:

(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::operator=):
(WebKit::ContextMenuContextData::encode):
(WebKit::ContextMenuContextData::decode):

Shared/ContextMenuContextData.h:

(WebKit::ContextMenuContextData::controlledImageHandle):

Shared/ShareableBitmap.cpp:

(WebKit::ShareableBitmap::Handle::clear):

Shared/ShareableBitmap.h:
UIProcess/WebContextMenuProxy.h:

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::internalShowContextMenu):
(WebKit::WebPageProxy::replaceControlledImage):

UIProcess/WebPageProxy.h:

UIProcess/efl/WebContextMenuProxyEfl.cpp:

(WebKit::WebContextMenuProxyEfl::showContextMenu):

UIProcess/efl/WebContextMenuProxyEfl.h:

UIProcess/gtk/WebContextMenuProxyGtk.cpp:

(WebKit::WebContextMenuProxyGtk::showContextMenu):

UIProcess/gtk/WebContextMenuProxyGtk.h:

Add a sharing service context menu that lives side-by-side with the normal one:

UIProcess/mac/WebContextMenuProxyMac.h:
UIProcess/mac/WebContextMenuProxyMac.mm:

(+[WKSharingServicePickerDelegate sharedSharingServicePickerDelegate]):
(-[WKSharingServicePickerDelegate setMenuProxy:WebKit::]):
(-[WKSharingServicePickerDelegate setPicker:]):
(-[WKSharingServicePickerDelegate sharingServicePicker:delegateForSharingService:]):
(-[WKSharingServicePickerDelegate sharingService:willShareItems:]):
(-[WKSharingServicePickerDelegate sharingService:didShareItems:]):
(-[WKSharingServicePickerDelegate sharingService:sourceFrameOnScreenForShareItem:]):
(-[WKSharingServicePickerDelegate sharingService:transitionImageForShareItem:contentRect:]):
(-[WKSharingServicePickerDelegate sharingService:sourceWindowForShareItems:sharingContentScope:]):
(WebKit::WebContextMenuProxyMac::contextMenuItemSelected):
(WebKit::WebContextMenuProxyMac::setupImageServicesMenu):
(WebKit::WebContextMenuProxyMac::clearImageServicesMenu):
(WebKit::WebContextMenuProxyMac::populate):
(WebKit::WebContextMenuProxyMac::showContextMenu):
(WebKit::WebContextMenuProxyMac::window):
(WebKit::WebContextMenuProxyMac::replaceControlledImage):

WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::show):
(WebKit::WebContextMenu::replaceControlledImage):

WebProcess/WebPage/WebContextMenu.h:

Teach the WebProcess how to accept the replaced image.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::replaceControlledImage):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

4:53 PM Changeset in webkit [165855] by msaboff@apple.com

6 edits in trunk/Source/JavaScriptCore

Update RegExp Tracing code
https://bugs.webkit.org/show_bug.cgi?id=130381

Reviewed by Andreas Kling.

Updated the regular expression tracing code for 8/16 bit JIT as
well as match only entry points. Also added average string length
metric.

runtime/RegExp.cpp:

(JSC::RegExp::RegExp):
(JSC::RegExp::match):
(JSC::RegExp::printTraceData):

runtime/RegExp.h:
runtime/VM.cpp:

(JSC::VM::addRegExpToTrace):
(JSC::VM::dumpRegExpTrace):

runtime/VM.h:
yarr/YarrJIT.h:

(JSC::Yarr::YarrCodeBlock::get8BitMatchOnlyAddr):
(JSC::Yarr::YarrCodeBlock::get16BitMatchOnlyAddr):
(JSC::Yarr::YarrCodeBlock::get8BitMatchAddr):
(JSC::Yarr::YarrCodeBlock::get16BitMatchAddr):

4:09 PM Changeset in webkit [165854] by andersca@apple.com

2 edits in trunk/Source/WebCore

Fix a trivial FIXME
https://bugs.webkit.org/show_bug.cgi?id=130432

Reviewed by Tim Horton.

history/HistoryItem.cpp:

(WebCore::HistoryItem::encodeBackForwardTreeNode):

3:56 PM Changeset in webkit [165853] by andersca@apple.com

8 edits in trunk/Source

Begin cleaning up KeyedDecoder and KeyedEncoder
https://bugs.webkit.org/show_bug.cgi?id=130431

Reviewed by Tim Horton.

Source/WebCore:

Rename KeyedDecoder::decodeVerifiedEnum to decodeEnum to match the encode function,
and sort the decode functions to be in the same logical order as the encode functions.

Modules/indexeddb/IDBKeyData.cpp:

(WebCore::IDBKeyData::decode):

Modules/indexeddb/IDBKeyPath.cpp:

(WebCore::IDBKeyPath::decode):

platform/KeyedCoding.h:

(WebCore::KeyedDecoder::decodeEnum):

Source/WebKit2:

Shared/cf/KeyedDecoder.cpp:

(WebKit::KeyedDecoder::KeyedDecoder):
If we can't parse the property list data, just add an empty dictionary to the stack.

(WebKit::KeyedDecoder::decodeBool):
Remove unneeded m_dictionaryStack.last() null check. m_dictionaryStack would either be empty
or at least have a root element; it would never have a null element.

(WebKit::KeyedDecoder::decodeDouble):
Remove the same check as above and remove the CFNumberGetType checks since CFNumberGetValue will
do the type conversion for us and return false if it's lossy.

(WebKit::KeyedDecoder::decodeInt64):
Remove the m_dictionaryStack.last() check.

(WebKit::KeyedDecoder::decodeUInt32):
Ditto.

(WebKit::KeyedDecoder::decodeString):
Ditto.

(WebKit::KeyedDecoder::beginObject):
Ditto.

(WebKit::KeyedDecoder::beginArray):
Ditto.

(WebKit::KeyedDecoder::beginArrayElement):
Ditto.

Shared/cf/KeyedDecoder.h:

Sort functions to be in the same logical order as the base class.

Shared/cf/KeyedEncoder.cpp:

(WebKit::KeyedEncoder::finishEncoding):
Don't check for a non-null CFErrorRef here (which we incidentally never released on error). Instead,
just null check the returned CFDataRef object.

3:41 PM Changeset in webkit [165852] by alex.christensen@flexsim.com

2 edits in trunk/WebKitLibraries

[WinCairo] Unreviewed build fix after r165763.

win/tools/vsprops/GStreamerCommon.props:

Link to gsttag-1.0.lib in addition to other GStreamer libraries.

3:24 PM Changeset in webkit [165851] by matthew_hanson@apple.com

1 edit in branches/safari-537.75-branch/LayoutTests/fast/ruby/ruby-illegal-combined-expected.txt

Reverted r165567 to the same expectation as trunk.

3:08 PM Changeset in webkit [165850] by Joseph Pecoraro

2 edits in trunk/Source/WebKit2

Unreviewed typo build fix for r165846.

Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::decode):

3:05 PM Changeset in webkit [165849] by commit-queue@webkit.org

1 edit
5 copies
1 delete in trunk/LayoutTests

Unreviewed GTK Gardening.

Move expected accesibility results to the right path and update them.

Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-03-18

platform/gtk/accessibility/aria-help-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/accessibility/aria-help-expected.txt.
platform/gtk/accessibility/aria-hidden-false-works-in-subtrees-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/accessibility/aria-hidden-false-works-in-subtrees-expected.txt.
platform/gtk/accessibility/fieldset-element-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/accessibility/fieldset-element-expected.txt.
platform/gtk/accessibility/meter-element-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/accessibility/meter-element-expected.txt.
platform/gtk/accessibility/negative-tabindex-does-not-expose-label-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/accessibility/negative-tabindex-does-not-expose-label-expected.txt.

2:57 PM Changeset in webkit [165848] by Darin Adler

76 edits in trunk/Source

Reduce use of deprecatedCharacters in WebCore
https://bugs.webkit.org/show_bug.cgi?id=130318

Reviewed by Andreas Kling.

Source/WebCore:

Modules/indexeddb/IDBKeyPath.cpp:

(WebCore::IDBKeyPathLexer::IDBKeyPathLexer): Use StringView for parsing.
(WebCore::IDBKeyPathLexer::lex): Ditto.
(WebCore::IDBKeyPathLexer::lexIdentifier): Ditto.

Modules/indexeddb/leveldb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::encodeString): Index directly into string instead of
using deprecatedCharacters.

Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::setSubprotocol): Use
StringView::getCharactersWithUpconvert.
(WebCore::ThreadableWebSocketChannelClientWrapper::setExtensions): Ditto.

accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper arrayOfTextForTextMarkers:attributed:]):
Use operator NSString * instead of explicitly creating an NSString.

bindings/js/SerializedScriptValue.cpp:

(WebCore::writeLittleEndianUInt16): Added.
(WebCore::CloneSerializer::serialize): Added a separate code path for 8-bit strings.
(WebCore::CloneSerializer::write): Ditto.

bindings/objc/WebScriptObject.mm:

(+[WebScriptObject _convertValueToObjcValue:JSC::originRootObject:rootObject:]):
Use operator NSString * instead of explicitly creating an NSString.

dom/Document.cpp:

(WebCore::Document::parseQualifiedName): Index directly into string instead of
using deprecatedCharacters.

editing/CompositeEditCommand.cpp:

(WebCore::containsOnlyWhitespace): Ditto.

editing/SmartReplace.cpp:

(WebCore::addAllCodePoints): Ditto.
(WebCore::getSmartSet): Use StringView::upconvertedCharacters.

editing/TextIterator.cpp:

(WebCore::foldQuoteMarksAndSoftHyphens): Changed to return a value so it can be
used in initialization rather than assignment.
(WebCore::SearchBuffer::SearchBuffer): Use StringView::upconvertedCharacters.

editing/TypingCommand.cpp:

(WebCore::TypingCommand::insertText): Index directly into string instead of using
deprecatedCharacters.

editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::characterAfter): Ditto.

editing/VisibleUnits.cpp:

(WebCore::startOfParagraph): Ditto.
(WebCore::endOfParagraph): Ditto.

fileapi/WebKitBlobBuilder.cpp:

(WebCore::BlobBuilder::append): Pass a StringView to TextEncoding::encode.

html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::parseToDateComponents): Use
StringView::upconvertedCharacters.

html/FormDataList.cpp:

(WebCore::FormDataList::appendString): Pass a StringView to TextEncoding::encode.

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::normalizeSpaces): Use StringView::getCharactersWithUpconvert.

html/parser/HTMLParserIdioms.cpp:

(WebCore::stripLeadingAndTrailingHTMLSpaces): Use characters16 for a code path
that already handled 8-bit characters separately.
(WebCore::parseHTMLNonNegativeInteger): Ditto.
(WebCore::parseDescriptors): Added an 8-bit code path.

inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::newLineAndWhitespaceDelimiters): Index directly into
string instead of using deprecatedCharacters.

inspector/InspectorStyleTextEditor.cpp:

(WebCore::InspectorStyleTextEditor::insertProperty): Ditto.
(WebCore::InspectorStyleTextEditor::internalReplaceProperty): Ditto.

page/ContentSecurityPolicy.cpp:

(WebCore::isSourceListNone): Use StringView::upconvertedCharacters.
(WebCore::CSPSourceList::parse): Ditto.
(WebCore::NonceDirective::parse): Ditto.
(WebCore::MediaListDirective::parse): Ditto.
(WebCore::CSPDirectiveList::parse): Ditto.
(WebCore::CSPDirectiveList::parseReportURI): Ditto.
(WebCore::CSPDirectiveList::parseReflectedXSS): Ditto.
(WebCore::ContentSecurityPolicy::didReceiveHeader): Ditto.

page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame): Pass a StringView into
TextEncoding::encode.
(WebCore::PageSerializer::serializeCSSStyleSheet): Ditto.

platform/Length.cpp:

(WebCore::countCharacter): Index directly into string instead of using
deprecatedCharacters. Also changed to take a StringImpl&.
(WebCore::newCoordsArray): Ditto. Call countCharacter the new way, and
use StringView::upconvertedCharacters.
(WebCore::newLengthArray): Ditto.

platform/LinkHash.cpp:

(WebCore::visitedLinkHash): Use characters16 for the 16-bit path.
Also removed unused visitedURL function.

platform/LinkHash.h: Removed unused visitedURL function.

platform/SharedBuffer.cpp:

(WebCore::utf8Buffer): Added an 8-bit code path.

platform/URL.cpp:

(WebCore::URL::port): Ditto.
(WebCore::encodeRelativeString): Use StringView to call TextEncoding::encode.

platform/graphics/Color.cpp:

(WebCore::Color::parseHexColor): Use characters16 in the 16-bit path.
(WebCore::Color::Color): Ditto.

platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:

(WebCore::harfBuzzGetGlyph): Use StringView to call TextEncoding::encode.

platform/graphics/StringTruncator.cpp:

(WebCore::centerTruncateToBuffer): Use StringView::getCharactersWithUpconvert.
(WebCore::rightTruncateToBuffer): Ditto.
(WebCore::rightClipToCharacterBuffer): Ditto.
(WebCore::rightClipToWordBuffer): Ditto.
(WebCore::leftTruncateToBuffer): Ditto.
(WebCore::truncateString): Ditto.

platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun): Use characters16 in the 16-bit code path.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):
Use StringView::upconvertedCharacters.

platform/network/DataURL.cpp:

(WebCore::handleDataURL): Use StringView to call TextEncoding::encode.

platform/network/FormDataBuilder.cpp:

(WebCore::FormDataBuilder::addFilenameToMultiPartHeader): Ditto.

platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::bindBlob): Use StringView::upconvertedCharacters.
(WebCore::SQLiteStatement::bindText): Ditto.

platform/text/DecodeEscapeSequences.h:

(WebCore::Unicode16BitEscapeSequence::decodeRun): Changed to take a StringView.
(WebCore::URLEscapeSequence::decodeRun): Ditto.
(WebCore::decodeEscapeSequences): Pass StringView to decodeRun.

platform/text/Hyphenation.cpp:

(WebCore::lastHyphenLocation): Take a StringView.

platform/text/Hyphenation.h: Make lastHyphenLocation take a StringView.

platform/text/TextBreakIterator.cpp:

(WebCore::initializeIteratorWithRules): Use StringView::upconvertedCharacters.

platform/text/TextEncoding.cpp:

(WebCore::TextEncoding::encode): Use StringView::upconvertedCharacters.
Change argument type to StringView.

platform/text/TextEncoding.h: Ditto.

platform/text/TextEncodingRegistry.cpp:

(WebCore::atomicCanonicalTextEncodingName): Use characters16 for the 16-bit path.

platform/text/cf/HyphenationCF.cpp:

(WebCore::lastHyphenLocation): Use StringView::text.createCFStringWithoutCopying.
Change argument type to StringView.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::constructTextRun): Use characters16 for the 16-bit path.

rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::width): Removed check for null characters pointer,
since the pointer will never be null, and even if it was there would be no need
for an early exit.

rendering/RenderText.cpp:

(WebCore::maxWordFragmentWidth): Take a StringView.
(WebCore::RenderText::computePreferredLogicalWidths): Pass in a StringView.

rendering/line/BreakingContextInlineHeaders.h:

(WebCore::tryHyphenating): Ditto.

rendering/svg/SVGTextLayoutEngine.cpp:

(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath): Use
StringView::upconvertedCharacters.

rendering/svg/SVGTextMetrics.cpp:

(WebCore::SVGTextMetrics::SVGTextMetrics): Use String::substring.

svg/SVGAngle.cpp:

(WebCore::SVGAngle::setValueAsString): Use StringView::upconvertedCharacters.

svg/SVGAnimateMotionElement.cpp:

(WebCore::parsePoint): Ditto.

svg/SVGAnimationElement.cpp:

(WebCore::parseKeySplines): Ditto.

svg/SVGFitToViewBox.cpp:

(WebCore::SVGFitToViewBox::parseViewBox): Ditto.

svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection): Pass StringView to
createStringWIthMirroredCharacters.
(WebCore::createStringWithMirroredCharacters): Changed to use StringView and
use indexing into that instead of a characters pointer.

svg/SVGFontData.h: Removed createStringWithMirroredCharacters member function,

since it has nothing to do with the SVGFontData object. Now it's just a private
helper function in the SVGFontData.cpp source file.

svg/SVGFontElement.cpp:

(WebCore::SVGFontElement::registerLigaturesInGlyphCache): Index into the string
instead of using deprecatedCharacters.

svg/SVGGlyphMap.h:

(WebCore::SVGGlyphMap::addGlyph): Use StringView::upconvertedCharacters.
(WebCore::SVGGlyphMap::collectGlyphsForString): Ditto.

svg/SVGGlyphRefElement.cpp:

(WebCore::SVGGlyphRefElement::parseAttribute): Ditto.

svg/SVGLength.cpp:

(WebCore::SVGLength::setValueAsString): Ditto.

svg/SVGLengthList.cpp:

(WebCore::SVGLengthList::parse): Ditto.

svg/SVGNumberList.cpp:

(WebCore::SVGNumberList::parse): Ditto.

svg/SVGParserUtilities.cpp:

(WebCore::parseNumberFromString): Ditto.
(WebCore::parseNumberOptionalNumber): Ditto.
(WebCore::parseRect): Ditto.
(WebCore::pointsListFromSVGData): Ditto.
(WebCore::parseGlyphName): Ditto.
(WebCore::parseKerningUnicodeString): Ditto.
(WebCore::parseDelimitedString): Ditto.

svg/SVGPreserveAspectRatio.cpp:

(WebCore::SVGPreserveAspectRatio::parse): Ditto.

svg/SVGStringList.cpp:

(WebCore::SVGStringList::parse): Ditto.

svg/SVGTransformList.cpp:

(WebCore::SVGTransformList::parse): Ditto.

svg/SVGTransformable.cpp:

(WebCore::SVGTransformable::parseTransformType): Ditto.

svg/SVGViewSpec.cpp:

(WebCore::SVGViewSpec::parseViewSpec): Ditto.

svg/SVGZoomAndPan.h:

(WebCore::SVGZoomAndPan::parseAttribute): Ditto.

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send): Pass a StringView to TextEncoding::encode.

xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::parseString): Use StringView::upconvertedCharacters.

Source/WTF:

wtf/text/WTFString.h: Export another overload of charactersToFloat since it's used

in WebCore now.

wtf/text/cf/StringViewCF.cpp: Change so this can build on Windows.

WTF.vcxproj/WTF.vcxproj: Added StringViewCF.cpp.
WTF.vcxproj/WTF.vcxproj.filters: Added StringViewCF.cpp.

2:53 PM Changeset in webkit [165847] by matthew_hanson@apple.com

2 edits in branches/safari-537.75-branch/Source/WebKit2

Add a newline to the end of WKPreferences.cpp to suppress -Werror, -pedantic, and -Wnewline-eof.

2:46 PM Changeset in webkit [165846] by Joseph Pecoraro

12 edits in trunk/Source/WebKit2

WebKit2 SPI to disable remote inspection on a WKWebView / WKPage
https://bugs.webkit.org/show_bug.cgi?id=130371

Reviewed by Dan Bernstein.

Shared/WebPageCreationParameters.h:
Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
Add allowsRemoteInspection bool.

UIProcess/API/C/WKPagePrivate.h:
UIProcess/API/C/WKPage.cpp:

(WKPageGetAllowsRemoteInspection):
(WKPageSetAllowsRemoteInspection):

UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _allowsRemoteInspection]):
(-[WKWebView _setAllowsRemoteInspection:]):
Getter and setter for allowing remote inspection state.

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::allowsRemoteInspection):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setAllowsRemoteInspection):
(WebKit::WebPageProxy::creationParameters):
Cached allows remote inspection state, with getter and setter.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setAllowsRemoteInspection):
When setting, call into WebCore to adjust the Page's setting.

2:38 PM Changeset in webkit [165845] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Test fast/events/touch/touch-target-limited.html crashes.

Some tests on editing/spelling are timing out, but not longer failing:
editing/spelling/spellcheck-paste.html
editing/spelling/spelling-changed-text.html
editing/spelling/spellcheck-paste-disabled.html
editing/spelling/spellcheck-paste-continuous-disabled.html

Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-03-18

platform/gtk-wk2/TestExpectations:
platform/gtk/TestExpectations:

2:22 PM Changeset in webkit [165844] by jer.noble@apple.com

5 edits in branches/safari-537.75-branch/Source

Merge r165478 and r165425.

Source/WebCore: Merge r165478.

2014-03-12 Jer Noble <jer.noble@apple.com>

[Mac] Crash when running media/fallback.html test in MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification()
https://bugs.webkit.org/show_bug.cgi?id=130136

Reviewed by Eric Carlson.

MediaPlayerPrivateAVFoundation is trying to lock its m_queueMutex from an async thread after
while being destroyed in the main thread. To resolve this race condition, redispatch from
the async thread to the main thread, and use a WeakPtr to determine whether the object has
been destroyed or not.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::checkPlayability):

Source/WTF: Merge r165425.

2014-03-10 Jer Noble <jer.noble@apple.com>

Improve WeakPtr operators.
https://bugs.webkit.org/show_bug.cgi?id=130053

Reviewed by Andreas Kling.

Replace the "operator!()" with an explicit bool operator. Add an "operator->()".

wtf/WeakPtr.h: (WTF::WeakPtr::operator bool): (WTF::WeakPtr::operator->):

1:58 PM Changeset in webkit [165843] by Bem Jones-Bey

19 edits in trunk/Source/WebCore

LayoutBox is a terrible name
https://bugs.webkit.org/show_bug.cgi?id=130351

Reviewed by Simon Fraser.

Rename LayoutBox to CSSBoxType. Also rename the functions and methods
that mention "LayoutBox" to something that makes sense for each
specific situation.

No new tests, no behavior change.

css/BasicShapeFunctions.cpp:

(WebCore::valueForBasicShape):
(WebCore::basicShapeForValue):

css/CSSBasicShapes.cpp:

(WebCore::CSSBasicShapeCircle::cssText):
(WebCore::CSSBasicShapeCircle::equals):
(WebCore::CSSBasicShapeEllipse::cssText):
(WebCore::CSSBasicShapeEllipse::equals):
(WebCore::CSSBasicShapePolygon::cssText):
(WebCore::CSSBasicShapePolygon::equals):
(WebCore::CSSBasicShapeInset::cssText):

css/CSSBasicShapes.h:

(WebCore::CSSBasicShape::referenceBox):
(WebCore::CSSBasicShape::setReferenceBox):

css/CSSComputedStyleDeclaration.cpp:

(WebCore::shapePropertyValue):

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator CSSBoxType):

css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyShape::applyValue):

page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):

rendering/ClipPathOperation.h:

(WebCore::ShapeClipPathOperation::setReferenceBox):
(WebCore::ShapeClipPathOperation::referenceBox):
(WebCore::BoxClipPathOperation::create):
(WebCore::BoxClipPathOperation::referenceBox):
(WebCore::BoxClipPathOperation::BoxClipPathOperation):

rendering/shapes/Shape.cpp:

(WebCore::Shape::createBoxShape):

rendering/shapes/Shape.h:
rendering/shapes/ShapeInfo.cpp:

(WebCore::ShapeInfo<RenderType>::computedShape):

rendering/shapes/ShapeInfo.h:
rendering/shapes/ShapeInsideInfo.h:
rendering/shapes/ShapeOutsideInfo.h:
rendering/style/BasicShapes.cpp:

(WebCore::BasicShape::canBlend):

rendering/style/BasicShapes.h:

(WebCore::BasicShape::referenceBox):
(WebCore::BasicShape::setReferenceBox):
(WebCore::BasicShape::BasicShape):

rendering/style/RenderStyleConstants.h:
rendering/style/ShapeValue.h:

(WebCore::ShapeValue::createShapeValue):
(WebCore::ShapeValue::createBoxShapeValue):
(WebCore::ShapeValue::cssBox):
(WebCore::ShapeValue::ShapeValue):

1:53 PM Changeset in webkit [165842] by fpizlo@apple.com

15 edits
1 add in trunk/Source/JavaScriptCore

Add CompareStrictEq(StringIdent:, NotStringVar:) and CompareStrictEq(String:, Untyped:)
https://bugs.webkit.org/show_bug.cgi?id=130300

Reviewed by Mark Hahnenberg.

We can quickly strictly compare StringIdent's to NotStringVar's and String's to Untyped's.
This makes the DFG aware of this.

Also adds StringIdent-to-StringIdent and StringIdent-to-NotStringVar strict comparisons to
the FTL. Also adds StringIdent-to-StringIdent non-strict comparisons to the FTL.

This also gives the DFG some abstractions for checking something is a cell or is other.
This made this patch easier to write and also simplified a bunch of other stuff.

1% speed-up on Octane.

assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::JumpList::JumpList):

bytecode/SpeculatedType.h:

(JSC::isNotStringVarSpeculation):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGNode.h:

(JSC::DFG::Node::childFor):
(JSC::DFG::Node::shouldSpeculateNotStringVar):

dfg/DFGSafeToExecute.h:

(JSC::DFG::SafeToExecuteEdge::operator()):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileIn):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileInstanceOfForObject):
(JSC::DFG::SpeculativeJIT::compileInstanceOf):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::compileBooleanCompare):
(JSC::DFG::SpeculativeJIT::compileStringEquality):
(JSC::DFG::SpeculativeJIT::compileStringToUntypedEquality):
(JSC::DFG::SpeculativeJIT::compileStringIdentEquality):
(JSC::DFG::SpeculativeJIT::compileStringIdentToNotStringVarEquality):
(JSC::DFG::SpeculativeJIT::compileStringZeroLength):
(JSC::DFG::SpeculativeJIT::speculateObjectOrOther):
(JSC::DFG::SpeculativeJIT::speculateString):
(JSC::DFG::SpeculativeJIT::speculateStringIdentAndLoadStorage):
(JSC::DFG::SpeculativeJIT::speculateNotStringVar):
(JSC::DFG::SpeculativeJIT::speculateNotCell):
(JSC::DFG::SpeculativeJIT::speculateOther):
(JSC::DFG::SpeculativeJIT::speculate):
(JSC::DFG::SpeculativeJIT::emitSwitchChar):
(JSC::DFG::SpeculativeJIT::emitSwitchString):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::blessedBooleanResult):
(JSC::DFG::SpeculativeJIT::unblessedBooleanResult):
(JSC::DFG::SpeculativeJIT::booleanResult):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::branchIsCell):
(JSC::DFG::branchNotCell):
(JSC::DFG::SpeculativeJIT::branchIsOther):
(JSC::DFG::SpeculativeJIT::branchNotOther):
(JSC::DFG::SpeculativeJIT::moveTrueTo):
(JSC::DFG::SpeculativeJIT::moveFalseTo):
(JSC::DFG::SpeculativeJIT::blessBoolean):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::branchIsCell):
(JSC::DFG::SpeculativeJIT::branchNotCell):
(JSC::DFG::SpeculativeJIT::branchIsOther):
(JSC::DFG::SpeculativeJIT::branchNotOther):
(JSC::DFG::SpeculativeJIT::moveTrueTo):
(JSC::DFG::SpeculativeJIT::moveFalseTo):
(JSC::DFG::SpeculativeJIT::blessBoolean):

dfg/DFGUseKind.cpp:

(WTF::printInternal):

dfg/DFGUseKind.h:

(JSC::DFG::typeFilterFor):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEq):
(JSC::FTL::LowerDFGToLLVM::lowString):
(JSC::FTL::LowerDFGToLLVM::lowStringIdent):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::speculateString):
(JSC::FTL::LowerDFGToLLVM::speculateStringIdent):
(JSC::FTL::LowerDFGToLLVM::speculateNotStringVar):

runtime/JSCJSValue.h:
tests/stress/string-ident-to-not-string-var-equality.js: Added.

(foo):
(bar):
(test):

1:45 PM Changeset in webkit [165841] by andersca@apple.com

2 edits in trunk/Source/WebKit2

REGRESSION: Visited link coloring seems to be completely broken in tip of tree
https://bugs.webkit.org/show_bug.cgi?id=130419
<rdar://problem/16337850>

Reviewed by Dan Bernstein.

Make sure to send any queued up messages before calling connectionWillOpen so we'll ensure
FIFO ordering if any messages are sent from within connectionWillOpen.

Shared/ChildProcessProxy.cpp:

(WebKit::ChildProcessProxy::didFinishLaunching):

1:36 PM Changeset in webkit [165840] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Add Copyright to framework.sb
https://bugs.webkit.org/show_bug.cgi?id=130413

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-03-18
Reviewed by Timothy Hatcher.

Other sb files got the copyright. Follow suit.

framework.sb:

1:18 PM Changeset in webkit [165839] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

WebPageCreationParameters colorSpace should be MAC not COCOA
https://bugs.webkit.org/show_bug.cgi?id=130414

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-03-18
Reviewed by Dan Bernstein.

The colorSpace param was only set and used on Mac, not iOS.

Shared/WebPageCreationParameters.h:
Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

1:07 PM Changeset in webkit [165838] by commit-queue@webkit.org

1 edit
1 move in trunk/Source/WebInspectorUI

Web Inspector: Make update-InspectorBackendCommands.rb only update legacy protocol versions
https://bugs.webkit.org/show_bug.cgi?id=130412

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-03-18
Reviewed by Timothy Hatcher.

Rename the script and simplify to only update Legacy protocol versions.

Scripts/update-LegacyInspectorBackendCommands.rb: Renamed from Source/WebInspectorUI/Scripts/update-InspectorBackendCommands.rb.

1:00 PM Changeset in webkit [165837] by dbates@webkit.org

5 edits
2 adds in trunk

REGRESSION (r162334): RenderTableCol::styleDidChange uses out-of-date table information
https://bugs.webkit.org/show_bug.cgi?id=129561

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/table/update-col-width-and-remove-table-cell-crash.html

Fixes an issue where a table column or table column group may query an out-
of-date model of its associated table as part of its process to propagate
style changes to affected table cells.

rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::styleDidChange): Ensure that all sections in the table
are up-to-date before querying for a table cell.

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::recalcCells): Update comment to read well. In
particular, remove the reference to RenderTableSection::fillRowsWithDefaultStartingAtPosition()
as this function was removed in <http://trac.webkit.org/changeset/99919>.
(WebCore::RenderTableSection::setNeedsCellRecalc): Clear the grid preemptively to
to ensure that accessors cannot access stale data. We'll build the grid again
in RenderTableSection::recalcCells().
(WebCore::RenderTableSection::numColumns): Add ASSERT(!m_needsCellRecalc) to assert
that the grid cells are up-to-date. That is, we don't need to calculate them again.

rendering/RenderTableSection.h: Add ASSERT(!m_needsCellRecalc) or call recalcCellsIfNeeded()

before accessing the grid to ensure that it's up-to-date.

LayoutTests:

Add a test to ensure that a table column propagates a style change to applicable
table cells.

fast/table/update-col-width-and-remove-table-cell-crash-expected.txt: Added.
fast/table/update-col-width-and-remove-table-cell-crash.html: Added.

12:59 PM Changeset in webkit [165836] by dbates@webkit.org

6 edits
4 adds in trunk

REGRESSION (r163560): ASSERTION FAILED: childrenInline() in WebCore::RenderSVGText::layout
https://bugs.webkit.org/show_bug.cgi?id=130346

Reviewed by Andreas Kling.

Source/WebCore:

Following <http://trac.webkit.org/changeset/163560>, SVG inline elements may be treated as block-
level elements depending on their CSS styles (e.g. display: block). But such elements should always
be treated as inline-level elements.

Partially revert <http://trac.webkit.org/changeset/164368> as it addressed a similar issue for
<tspan> and <tref>. Instead we should implement RenderSVGInline::updateFromStyle() to ensure that
RenderSVGInline and any derived classes (e.g. RenderSVGTSpan) are always treated as inline elements
regardless of their CSS style because the SVG text layout code depends on this assumption as part
of a performance optimization. We may want to revaluate the benefits of this optimization with respect
to code clarity and ensuring the code is less error prone.

Test: svg/text/a-display-block.html

svg/text/tref-display-inherit.html

css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle): Revert changes from <http://trac.webkit.org/changeset/164368>.

rendering/RenderInline.h:
rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::updateFromStyle): Added; ensure that RenderSVGInline and any derived
classes are treated as inline elements because the SVG text layout code depends on this assumption.

rendering/svg/RenderSVGInline.h:

LayoutTests:

Added tests to ensure that SVG <a> and <tref> are always treated as inline-level elements.

svg/text/a-display-block-expected.txt: Added.
svg/text/a-display-block.html: Added.
svg/text/tref-display-inherit-expected.txt: Added.
svg/text/tref-display-inherit.html: Added.

12:50 PM Changeset in webkit [165835] by hmuller@adobe.com

6 edits in trunk

[CSS Shapes] shape-outside: ellipse(50% 50% at) causes crash
https://bugs.webkit.org/show_bug.cgi?id=130366

Reviewed by Andreas Kling.

Source/WebCore:

The BasicShape ellipse and circle functions now report a syntax error
if the "at" keyword is not followed by a position.

The existing parsing tests have been updated to include this case.

css/CSSParser.cpp:

(WebCore::CSSParser::parseBasicShapeCircle):
(WebCore::CSSParser::parseBasicShapeEllipse):

LayoutTests:

Added invalid syntax tests for ellipse(.. at), circle(.. at) variations.

fast/shapes/parsing/parsing-shape-inside-expected.txt:
fast/shapes/parsing/parsing-shape-outside-expected.txt:
fast/shapes/parsing/parsing-test-utils.js:

12:47 PM Changeset in webkit [165834] by thiago.lacerda@openbossa.org

4 edits in trunk/Source/WebCore

Removing MediaStreamVector typedef
https://bugs.webkit.org/show_bug.cgi?id=130402

Reviewed by Eric Carlson.

Modules/mediastream/MediaStream.h:
Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::getLocalStreams):
(WebCore::RTCPeerConnection::getRemoteStreams):
(WebCore::RTCPeerConnection::getStreamById):
(WebCore::RTCPeerConnection::hasLocalStreamWithTrackId):

Modules/mediastream/RTCPeerConnection.h:

12:46 PM Changeset in webkit [165833] by commit-queue@webkit.org

1 edit
1 delete in trunk/Tools

Web Inspector: Remove stale ReportMemoryUsagePlugin
https://bugs.webkit.org/show_bug.cgi?id=130405

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-03-18
Reviewed by Andreas Kling.

This clang plugin looks like it was used for the old Inspector memory
instrumentation that was removed. So the tool can be removed.

clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
clang/ReportMemoryUsagePlugin/Makefile: Removed.
clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.

12:45 PM Changeset in webkit [165832] by Brent Fulgham

3 edits in branches/safari-537.75-branch/Source/WebKit/win

Build correction after last merge.

WebPreferences.cpp:

(WebPreferences::isInheritURIQueryComponentEnabled): Must use CFSTR wrappers
on key names in this code.
(WebPreferences::setEnableInheritURIQueryComponent): Ditto.

WebView.cpp:

(WebView::notifyPreferencesChanged): This version of the code used pointers
for the preference instance.

12:39 PM Changeset in webkit [165831] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Removed extra parens from if statement in a preprocessor define.
https://bugs.webkit.org/show_bug.cgi?id=130408

Patch by Matthew Mirman <mmirman@apple.com> on 2014-03-18
Reviewed by Filip Pizlo.

parser/Parser.cpp:

12:30 PM Changeset in webkit [165830] by matthew_hanson@apple.com

2 edits in branches/safari-537.75-branch/Source/WebCore

Follow-up fix for the merge of r163579.

12:16 PM Changeset in webkit [165829] by commit-queue@webkit.org

15 edits
5 deletes in trunk

Unreviewed, rolling out r165815.
https://bugs.webkit.org/show_bug.cgi?id=130410

Broke many VTT tests (Requested by bfulgham on #webkit).

Reverted changeset:

Source/WebCore:

"TextTrackRegion Not Implemented"
https://bugs.webkit.org/show_bug.cgi?id=116546
http://trac.webkit.org/changeset/165815

LayoutTests:

"TextTrackRegion Not Implemented"
https://bugs.webkit.org/show_bug.cgi?id=116546
http://trac.webkit.org/changeset/165815

12:07 PM Changeset in webkit [165828] by matthew_hanson@apple.com

2 edits in branches/safari-537.75-branch/Source/WebKit2

Remove consecutive single quotations, as the C compiler does not recognize scheme comments.

12:05 PM Changeset in webkit [165827] by jer.noble@apple.com

2 edits in branches/safari-537.75-branch/Source/WebKit2

Unreviewed Mountain Lion build fix. Work around "empty character constant" error
by replacing double single-quotes with single double-quotes.

NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:

11:57 AM Changeset in webkit [165826] by reni@webkit.org

3 edits
2 adds in trunk

Bad cast with toRenderBox in WebCore::RenderView::repaintViewRectangle
https://bugs.webkit.org/show_bug.cgi?id=129104

Reviewed by Simon Fraser.

Source/WebCore:

We should not cast the renderer of a RenderView's owner to RenderBox
unless we are sure it is one.

Test: plugins/crash-invalid-data-reference.html

rendering/RenderView.cpp:

(WebCore::RenderView::repaintViewRectangle):

LayoutTests:

plugins/crash-invalid-data-reference-expected.txt: Added.
plugins/crash-invalid-data-reference.html: Added.

11:30 AM Changeset in webkit [165825] by Simon Fraser

2 edits in trunk/Source/WebKit2

Dan says that options should be unsigned, and enums should be signed.

Reviewed by Dan Bernstein.

UIProcess/API/Cocoa/WKWebViewPrivate.h:

(NS_ENUM):

11:30 AM Changeset in webkit [165824] by commit-queue@webkit.org

3 edits in trunk/Tools

webkit-patch land shouldn't add a reviewer for unreviewed build fixes
https://bugs.webkit.org/show_bug.cgi?id=130220

Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-03-18
Reviewed by Csaba Osztrogonác.

Scripts/webkitpy/common/checkout/changelog.py:

(ChangeLog.set_reviewer):

Scripts/webkitpy/common/checkout/changelog_unittest.py:

(test_set_reviewer):

11:13 AM Changeset in webkit [165823] by ap@apple.com

13 edits
1 add in trunk/Source/WebKit2

[WK2] Pass ranges over IPC in a cross-platform manner
https://bugs.webkit.org/show_bug.cgi?id=130376

Reviewed by Anders Carlsson.

Added an EditingRange class for IPC, which automatically converts to and from
NSRanges, knowing the difference between notFound and NSNotFound.

Manually applied the same fix to characterIndexForPoint.

Scripts/webkit2/messages.py:

(struct_or_class):

Shared/EditingRange.h: Added.

(WebKit::EditingRange::EditingRange):
(WebKit::EditingRange::isValid):
(WebKit::EditingRange::operator NSRange):

UIProcess/API/mac/WKView.mm:

(-[WKView insertText:replacementRange:]):
(-[WKView selectedRange]):
(-[WKView hasMarkedText]):
(-[WKView setMarkedText:selectedRange:replacementRange:]):
(-[WKView markedRange]):
(-[WKView attributedSubstringForProposedRange:actualRange:]):
(-[WKView characterIndexForPoint:]):
(-[WKView firstRectForCharacterRange:actualRange:]):

UIProcess/WebPageProxy.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setMarkedText:selectedRange:]):
(-[WKContentView insertText:]):

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::setComposition):
(WebKit::WebPageProxy::insertText):
(WebKit::WebPageProxy::insertDictatedText):
(WebKit::WebPageProxy::getMarkedRange):
(WebKit::WebPageProxy::getSelectedRange):
(WebKit::WebPageProxy::getAttributedSubstringFromRange):
(WebKit::WebPageProxy::firstRectForCharacterRange):

UIProcess/mac/WebPageProxyMac.mm:

WebKit2.xcodeproj/project.pbxproj:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::rangeFromEditingRange):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::setComposition):
(WebKit::WebPage::insertText):
(WebKit::WebPage::insertDictatedText):
(WebKit::WebPage::getMarkedRange):
(WebKit::WebPage::getSelectedRange):
(WebKit::WebPage::getAttributedSubstringFromRange):
(WebKit::WebPage::firstRectForCharacterRange):

WebProcess/WebPage/mac/WebPageMac.mm:

11:11 AM Changeset in webkit [165822] by akling@apple.com

3 edits
1 add in trunk/Source/WebCore

Micro-optimize element descendant iterator.
<https://webkit.org/b/130384>

Add a slightly more efficient ElementDescendantIterator that keeps a stack
of relevant ancestor siblings instead of walking up the parent chain every
time we run out of children.

Reviewed by Antti Koivisto.

WebCore.xcodeproj/project.pbxproj:
dom/ElementDescendantIterator.h: Added.

(WebCore::ElementDescendantIterator::ElementDescendantIterator):
(WebCore::ElementDescendantIterator::operator++):
(WebCore::ElementDescendantConstIterator::ElementDescendantConstIterator):
(WebCore::ElementDescendantConstIterator::operator++):
(WebCore::ElementDescendantIteratorAdapter::ElementDescendantIteratorAdapter):
(WebCore::ElementDescendantIteratorAdapter::begin):
(WebCore::ElementDescendantIteratorAdapter::end):
(WebCore::ElementDescendantConstIteratorAdapter::ElementDescendantConstIteratorAdapter):
(WebCore::ElementDescendantConstIteratorAdapter::begin):
(WebCore::ElementDescendantConstIteratorAdapter::end):
(WebCore::elementDescendants):

dom/ElementIterator.h:
dom/SelectorQuery.cpp:

(WebCore::elementsForLocalName):
(WebCore::anyElement):
(WebCore::SelectorDataList::executeSingleTagNameSelectorData):
(WebCore::SelectorDataList::executeSingleClassNameSelectorData):
(WebCore::SelectorDataList::executeSingleSelectorData):
(WebCore::SelectorDataList::executeSingleMultiSelectorData):
(WebCore::SelectorDataList::executeCompiledSimpleSelectorChecker):

11:06 AM Changeset in webkit [165821] by Antti Koivisto

5 edits
4 adds in trunk

Mutating rules returned by getMatchedCSSRules can result in crash
https://bugs.webkit.org/show_bug.cgi?id=130209

Source/WebCore:

Reviewed by Andreas Kling.

The non-standard getMatchedCSSRules API returns CSSStyleRule objects that don't
have parent stylesheet pointer (as we don't know which sheet the rule originated from).
Mutating the rule via such wrapper can lead to crashes later as we fail to invalidate
the underlying stylesheet.

Fix by disallowing mutation of style rules that don't have parent sheet pointer. CSSStyleRule
has two mutable properties selectorText and style. The latter gives back CSSStyleDeclaration.
This patch disallows mutations in both cases for CSSStyleRules that don't have parent stylesheet
pointer.

While it is technically possible to have CSSRules that are legitimately disconnected
from stylesheet (by removing rule from sheet while holding a reference to it) it never
makes sense to mutate such rule as there is no way to do anything with it afterwards.

Tests: fast/css/getMatchedCSSProperties-rule-mutation.html

fast/css/getMatchedCSSRules-crash.html

css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):

Bail out if parent stylesheet is null.

css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):

Allow StyleRuleCSSStyleDeclaration subclass cancel the mutation via
boolean return value from willMutate.

(WebCore::StyleRuleCSSStyleDeclaration::willMutate):

Disallow mutation if the owning CSSStyleRule is null or has null stylesheet.

(WebCore::StyleRuleCSSStyleDeclaration::didMutate):

We never get here with null rule or stylesheet anymore.

css/PropertySetCSSStyleDeclaration.h:

(WebCore::PropertySetCSSStyleDeclaration::willMutate):

LayoutTests:

Reviewed by Andreas Kling.

fast/css/getMatchedCSSProperties-rule-mutation-expected.txt: Added.
fast/css/getMatchedCSSProperties-rule-mutation.html: Added.
fast/css/getMatchedCSSRules-crash-expected.txt: Added.
fast/css/getMatchedCSSRules-crash.html: Added.

11:05 AM Changeset in webkit [165820] by jpfau@apple.com

2 edits in trunk/Source/WebCore

<media> elements are not properly moved to new documents' visibility callback lists
https://bugs.webkit.org/show_bug.cgi?id=127711

Reviewed by David Kilzer.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::didMoveToNewDocument):

11:02 AM Changeset in webkit [165819] by fpizlo@apple.com

19 edits in tags/Safari-538.23.1

More FTL enabling.

Source/JavaScriptCore:

Rubber stamped by Dan Bernstein and Mark Hahnenberg.

Configurations/FeatureDefines.xcconfig:
ftl/FTLCompile.cpp:

(JSC::FTL::compile):

Source/WebCore:

Reviewed by Dan Bernstein.

No new tests because this already has ample test coverage in JSC.

Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Reviewed by Dan Bernstein.

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Reviewed by Dan Bernstein.

Configurations/FeatureDefines.xcconfig:

Source/WTF:

Rubber stamped by Dan Bernstein and Mark Hahnenberg.

wtf/Platform.h:

Tools:

Rubber stamped by Dan Bernstein.

Tools/Scripts/build-webkit:

10:59 AM Changeset in webkit [165818] by fpizlo@apple.com

13 edits in trunk

More FTL enabling.

Source/JavaScriptCore:

Rubber stamped by Dan Bernstein and Mark Hahnenberg.

Configurations/FeatureDefines.xcconfig:
ftl/FTLCompile.cpp:

(JSC::FTL::compile):

Source/WebCore:

Rubber stamped by Dan Bernstein and Mark Hahnenberg.

No new tests.

Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Rubber stamped by Dan Bernstein.

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Rubber stamped by Dan Bernstein.

Configurations/FeatureDefines.xcconfig:

Source/WTF:

Rubber stamped by Dan Bernstein and Mark Hahnenberg.

wtf/Platform.h:

Tools:

Rubber stamped by Dan Bernstein.

Tools/Scripts/build-webkit:

10:57 AM Changeset in webkit [165817] by Simon Fraser

5 edits in trunk

Renable pagination mode in WK2 MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=130374

Source/WebKit2:

Reviewed by Anders Carlsson.

Add SPI for pagination mode.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _paginationMode]):
(-[WKWebView _setPaginationMode:]):
(-[WKWebView _paginationBehavesLikeColumns]):
(-[WKWebView _setPaginationBehavesLikeColumns:]):
(-[WKWebView _pageLength]):
(-[WKWebView _setPageLength:]):
(-[WKWebView _gapBetweenPages]):
(-[WKWebView _setGapBetweenPages:]):
(-[WKWebView _pageCount]):

UIProcess/API/Cocoa/WKWebViewPrivate.h:

(NS_ENUM):

Tools:

Reviewed by Anders Carlsson.

Put the implementation of togglePaginationMode: back, and correctly
enable the menu item.

MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController validateMenuItem:]):
(-[WK2BrowserWindowController isPaginated]):
(-[WK2BrowserWindowController togglePaginationMode:]):

10:54 AM Changeset in webkit [165816] by commit-queue@webkit.org

2 edits in trunk/Tools

Add --reset option to Tools/Scripts/set-webkit-configuration script
https://bugs.webkit.org/show_bug.cgi?id=130401

Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-03-18
Reviewed by Csaba Osztrogonác.

Scripts/set-webkit-configuration:

10:40 AM Changeset in webkit [165815] by Brent Fulgham

15 edits
5 adds in trunk

TextTrackRegion Not Implemented
https://bugs.webkit.org/show_bug.cgi?id=116546

Reviewed by Eric Carlson.

Merged from Blink (patch by vcarbune@chromium.org):
https://chromium.googlesource.com/chromium/blink/+/4940f89a087fea5b5ea628e98d0b355d398a9eea
http://crbug.com/25798003

Source/WebCore:

Tests: media/track/regions-webvtt/text-track-region-display.html

media/track/regions-webvtt/text-track-region-dom-layout.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::newRegionsAvailable):

html/track/TextTrack.cpp:
html/track/TextTrack.h:
html/track/TextTrackRegion.cpp:

(WebCore::TextTrackRegion::TextTrackRegion):
(WebCore::TextTrackRegion::appendTextTrackCueBox):

html/track/TextTrackRegion.h:
html/track/VTTCue.cpp:

(WebCore::VTTCue::VTTCue):
(WebCore::VTTCue::notifyRegionWhenRemovingDisplayTree):
(WebCore::VTTCue::removeDisplayTree):

html/track/VTTCue.h:
html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::parseBytes):
(WebCore::WebVTTParser::collectMetadataHeader):

html/track/WebVTTParser.h:

LayoutTests:

media/track/captions-webvtt/captions-regions.vtt: Added.
media/track/regions-webvtt/text-track-cue-region-attribute-expected.txt: Rebaseline.
media/track/regions-webvtt/text-track-region-display-expected.txt: Added.
media/track/regions-webvtt/text-track-region-display.html: Added.
media/track/regions-webvtt/text-track-region-dom-layout-expected.txt: Added.
media/track/regions-webvtt/text-track-region-dom-layout.html: Added.
media/track/regions-webvtt/text-track-region-list-expected.txt: Rebaseline.
media/track/regions-webvtt/text-track-region-parser-expected.txt: Rebaseline.

8:37 AM Changeset in webkit [165814] by Philippe Normand

1 edit
1 delete in trunk/Source/WebCore

[GTK] ResourceLoaderSoup.cpp was added by mistake
https://bugs.webkit.org/show_bug.cgi?id=130396

Reviewed by Carlos Garcia Campos.

This file was committed by mistake in r152778 and is not built by
any port.

loader/soup/ResourceLoaderSoup.cpp: Removed.

8:03 AM Changeset in webkit [165813] by ryuan.choi@samsung.com

4 edits in trunk/Source/WebKit2

[CMAKE][WK2]Move CoordinatedGraphics related files out of WebKit2/CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=130390

Reviewed by Martin Robinson.

Now, only EFL port use CoordinatedGraphics among CMake based ports.

CMakeLists.txt:
PlatformEfl.cmake:
PlatformGTK.cmake: Removed CoordinatedGraphics related files.

8:02 AM Changeset in webkit [165812] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit2

[GTK] Race condition when the socket event source is cancelled
https://bugs.webkit.org/show_bug.cgi?id=130395

Reviewed by Martin Robinson.

Platform/gtk/WorkQueueGtk.cpp:

(WorkQueue::SocketEventSource::isCancelled):
(WorkQueue::SocketEventSource::eventCallback):

7:33 AM Changeset in webkit [165811] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: sourceMapResourceLoaded expects statusCode parameter
https://bugs.webkit.org/show_bug.cgi?id=130377

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-03-18
Reviewed by Timothy Hatcher.

UserInterface/Models/SourceMapResource.js:

7:08 AM Changeset in webkit [165810] by jaepark@webkit.org

19 edits in trunk/Source/WebKit/gtk

[GTK][CMake] Fix WebKit unused parameter warnings
https://bugs.webkit.org/show_bug.cgi?id=130383

Reviewed by Martin Robinson.

WebCoreSupport/AcceleratedCompositingContextGL.cpp: Fix unused parameters warning.
WebCoreSupport/ChromeClientGtk.cpp: Ditto.
WebCoreSupport/DragClientGtk.cpp: Ditto.
WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Ditto.
WebCoreSupport/EditorClientGtk.cpp: Ditto.
WebCoreSupport/FrameLoaderClientGtk.cpp: Ditto.
WebCoreSupport/InspectorClientGtk.cpp: Ditto.
WebCoreSupport/PlatformStrategiesGtk.cpp: Ditto.
WebCoreSupport/ProgressTrackerClientGtk.cpp: Ditto.
WebCoreSupport/WebViewInputMethodFilter.cpp: Ditto.
webkit/webkitdownload.cpp: Ditto.
webkit/webkitfavicondatabase.cpp: Ditto.
webkit/webkitsoupauthdialog.cpp: Ditto.
webkit/webkitspellchecker.cpp: Ditto.
webkit/webkitspellcheckerenchant.cpp: Ditto.
webkit/webkitwebframe.cpp: Ditto.
webkit/webkitwebinspector.cpp: Ditto.
webkit/webkitwebview.cpp: Ditto.

6:44 AM Changeset in webkit [165809] by berto@igalia.com

2 edits in trunk/Tools

[GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
https://bugs.webkit.org/show_bug.cgi?id=130388

Reviewed by Sergio Villar Senin.

Scripts/webkitdirs.pm:

(shouldRemoveCMakeCache): make sure that the build directory
exists before attempting to create a file in it.

5:51 AM Changeset in webkit [165808] by commit-queue@webkit.org

2 edits
1 add in trunk/Tools

[EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
https://bugs.webkit.org/show_bug.cgi?id=130336

Patch by Robert Plociennik <r.plociennik@samsung.com> on 2014-03-18
Reviewed by Gyuyoung Kim.

Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
requires a space between literal and string macro [-Wliteral-suffix]'
warning treated as error.

This patch applies a solution from r162448 to the EFL port.

efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
efl/jhbuild.modules: Added appropriate patch section.

4:56 AM Changeset in webkit [165807] by ryuan.choi@samsung.com

1 edit in trunk/LayoutTests/ChangeLog

[EFL] Update baselines and test expectations
https://bugs.webkit.org/show_bug.cgi?id=130387

Unreviewed EFL gardening.

Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2014-03-18

fast/events/touch/touch-slider-expected.txt:
fast/events/touch/touch-slider-no-js-touch-listener-expected.txt:

Update baselines after enabling TOUCH_SLIDER macro (r165722).

platform/efl-wk2/TestExpectations:

fast/css/cascade/box-shadow-and-webkit-box-shadow-cascade-order.html
is failing after adding in r165587

platform/efl/js/dom/global-constructors-attributes-expected.txt:

Update baselines after refactoring Path to Path2D (r165651).

3:06 AM Changeset in webkit [165806] by commit-queue@webkit.org

5 edits in trunk/LayoutTests

[EFL] Update baselines and test expectations
https://bugs.webkit.org/show_bug.cgi?id=130249111

Unreviewed EFL gardening.

Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2014-03-18

fast/events/touch/touch-slider-expected.txt:
fast/events/touch/touch-slider-no-js-touch-listener-expected.txt:

Update baselines after enabling TOUCH_SLIDER macro (r165722).

platform/efl-wk2/TestExpectations:

fast/css/cascade/box-shadow-and-webkit-box-shadow-cascade-order.html
is failing after adding in r165587

platform/efl/js/dom/global-constructors-attributes-expected.txt:

Update baselines after refactoring Path to Path2D (r165651).

2:42 AM Changeset in webkit [165805] by akling@apple.com

6 edits
1 add
1 delete in trunk/Source/WebCore

Rename ElementDescendantIterator to TypedElementDescendantIterator.
Romper-stubbed by Antti "Latte Lung" Koivisto.

GNUmakefile.list.am:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
dom/ElementDescendantIterator.h: Removed.
dom/ElementIterator.h:
dom/TypedElementDescendantIterator.h: Added.

(WebCore::TypedElementDescendantIterator<ElementType>::TypedElementDescendantIterator):
(WebCore::TypedElementDescendantIterator<ElementType>::operator):
(WebCore::TypedElementDescendantConstIterator<ElementType>::TypedElementDescendantConstIterator):
(WebCore::TypedElementDescendantConstIterator<ElementType>::operator):
(WebCore::TypedElementDescendantIteratorAdapter<ElementType>::TypedElementDescendantIteratorAdapter):
(WebCore::TypedElementDescendantIteratorAdapter<ElementType>::begin):
(WebCore::TypedElementDescendantIteratorAdapter<ElementType>::end):
(WebCore::TypedElementDescendantIteratorAdapter<ElementType>::beginAt):
(WebCore::TypedElementDescendantIteratorAdapter<ElementType>::from):
(WebCore::TypedElementDescendantIteratorAdapter<ElementType>::first):
(WebCore::TypedElementDescendantIteratorAdapter<ElementType>::last):
(WebCore::TypedElementDescendantConstIteratorAdapter<ElementType>::TypedElementDescendantConstIteratorAdapter):
(WebCore::TypedElementDescendantConstIteratorAdapter<ElementType>::begin):
(WebCore::TypedElementDescendantConstIteratorAdapter<ElementType>::end):
(WebCore::TypedElementDescendantConstIteratorAdapter<ElementType>::beginAt):
(WebCore::TypedElementDescendantConstIteratorAdapter<ElementType>::from):
(WebCore::TypedElementDescendantConstIteratorAdapter<ElementType>::first):
(WebCore::TypedElementDescendantConstIteratorAdapter<ElementType>::last):
(WebCore::descendantsOfType):

1:51 AM Changeset in webkit [165804] by commit-queue@webkit.org

6 edits in trunk

Add blend mode property to dumped information in GraphicsLayer.
https://bugs.webkit.org/show_bug.cgi?id=130331

Patch by Ion Rosca <Ion Rosca> on 2014-03-18
Reviewed by Simon Fraser.

Source/WebCore:

Functionality is not changed, therefore no new tests added.
I adjusted the affected test results generated with layerTreeAsText.

platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::dumpProperties):

LayoutTests:

css3/compositing/blend-mode-blended-element-overlapping-composited-sibling-should-have-compositing-layer-expected.txt:
css3/compositing/blend-mode-parent-of-composited-blended-has-layer-expected.txt:
css3/compositing/blend-mode-with-composited-descendant-should-have-layer-expected.txt:

1:50 AM Changeset in webkit [165803] by svillar@igalia.com