Context Navigation

(JSC::CallLinkInfo::unlink): VM& argument is superfluous.
(JSC::CallLinkInfo::visitWeak): Factor this out, it used to be in CodeBlock::finalizeUnconditionally().

bytecode/CallLinkInfo.h:
bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finalizeUnconditionally): Factor out some functionality into CallLinkInfo::visitWeak(), and make sure we pass RepatchBuffer& in more places.
(JSC::CodeBlock::unlinkCalls):
(JSC::CodeBlock::unlinkIncomingCalls):

bytecode/PolymorphicGetByIdList.cpp: Pass RepatchBuffer& through and call JITStubRoutine::visitWeak().

(JSC::GetByIdAccess::visitWeak):
(JSC::PolymorphicGetByIdList::visitWeak):

bytecode/PolymorphicGetByIdList.h:
bytecode/PolymorphicPutByIdList.cpp: Pass RepatchBuffer& through and call JITStubRoutine::visitWeak().

(JSC::PutByIdAccess::visitWeak):
(JSC::PolymorphicPutByIdList::visitWeak):

bytecode/PolymorphicPutByIdList.h:
bytecode/StructureStubInfo.cpp: Pass RepatchBuffer& through.

(JSC::StructureStubInfo::visitWeakReferences):

bytecode/StructureStubInfo.h:
jit/ClosureCallStubRoutine.cpp: isClosureCall is unused.

(JSC::ClosureCallStubRoutine::ClosureCallStubRoutine):

jit/GCAwareJITStubRoutine.cpp:

(JSC::GCAwareJITStubRoutine::GCAwareJITStubRoutine):
(JSC::createJITStubRoutine):

jit/GCAwareJITStubRoutine.h: Make it easier to construct one of these.

(JSC::GCAwareJITStubRoutine::isClosureCall): Deleted.

jit/JITStubRoutine.cpp:

(JSC::JITStubRoutine::visitWeak): This will allow future JITStubRoutine subclasses to have stubs recursively embedded inside them.

jit/JITStubRoutine.h:
jit/Repatch.cpp:

(JSC::generateGetByIdStub): Fix a possible GC bug where we weren't making the stub routine GC aware.
(JSC::emitCustomSetterStub): Clean up some code.

8:27 PM Changeset in webkit [166217] by ggaren@apple.com

4 edits in trunk/Source/JavaScriptCore

Safari crashes in JavaScriptCore: JSC::JSObject::growOutOfLineStorage
when WebKit is compiled with fcatch-undefined-behavior
https://bugs.webkit.org/show_bug.cgi?id=130652

Reviewed by Mark Hahnenberg.

Use a static member function because the butterfly we pass in might be
NULL, and passing NULL to a member function is undefined behavior.

Stylistically, I think this new way reads a little more clearly, since it
matches createOrGrowArrayRight, and it helps to convey that m_butterfly
might not exist yet.

runtime/Butterfly.h:
runtime/ButterflyInlines.h:

(JSC::Butterfly::createOrGrowPropertyStorage): Renamed from growPropertyStorage
because we might create. Split out the create path to avoid using NULL
in a member function expression.

Removed some unused versions of this function.

runtime/JSObject.cpp:

(JSC::JSObject::growOutOfLineStorage): Updated for interface change.

6:54 PM Changeset in webkit [166216] by oliver@apple.com

5 edits in trunk

Strict mode destructuring assignment crashes the parser.
https://bugs.webkit.org/show_bug.cgi?id=130538

Reviewed by Michael Saboff.

Source/JavaScriptCore:

The SyntaxChecker mode always return 1 for success, except
for a small subset of functions where we needed exact information.
This ends up just being a poor design decision as it means
the parser can get confused between a function return 1, and
the Resolve constant which was also 1. So we now use a unique
type for every creation method.

parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createSourceElements):
(JSC::SyntaxChecker::createFunctionBody):
(JSC::SyntaxChecker::createArguments):
(JSC::SyntaxChecker::createSpreadExpression):
(JSC::SyntaxChecker::createArgumentsList):
(JSC::SyntaxChecker::createPropertyList):
(JSC::SyntaxChecker::createElementList):
(JSC::SyntaxChecker::createFormalParameterList):
(JSC::SyntaxChecker::createClause):
(JSC::SyntaxChecker::createClauseList):
(JSC::SyntaxChecker::createFuncDeclStatement):
(JSC::SyntaxChecker::createBlockStatement):
(JSC::SyntaxChecker::createExprStatement):
(JSC::SyntaxChecker::createIfStatement):
(JSC::SyntaxChecker::createForLoop):
(JSC::SyntaxChecker::createForInLoop):
(JSC::SyntaxChecker::createForOfLoop):
(JSC::SyntaxChecker::createEmptyStatement):
(JSC::SyntaxChecker::createVarStatement):
(JSC::SyntaxChecker::createReturnStatement):
(JSC::SyntaxChecker::createBreakStatement):
(JSC::SyntaxChecker::createContinueStatement):
(JSC::SyntaxChecker::createTryStatement):
(JSC::SyntaxChecker::createSwitchStatement):
(JSC::SyntaxChecker::createWhileStatement):
(JSC::SyntaxChecker::createWithStatement):
(JSC::SyntaxChecker::createDoWhileStatement):
(JSC::SyntaxChecker::createLabelStatement):
(JSC::SyntaxChecker::createThrowStatement):
(JSC::SyntaxChecker::createDebugger):
(JSC::SyntaxChecker::createConstStatement):
(JSC::SyntaxChecker::appendConstDecl):
(JSC::SyntaxChecker::combineCommaNodes):
(JSC::SyntaxChecker::operatorStackPop):

LayoutTests:

Add tests

js/parser-syntax-check-expected.txt:
js/script-tests/parser-syntax-check.js:

6:21 PM Changeset in webkit [166215] by Simon Fraser

2 edits in trunk/Source/WebCore

Remove some unnecessary includes from PlatformCALayerClient.h
https://bugs.webkit.org/show_bug.cgi?id=130703

Reviewed by Andreas Kling.

No need for all these #includes.

platform/graphics/ca/PlatformCALayerClient.h:

6:14 PM Changeset in webkit [166214] by cavalcantii@gmail.com

5 edits in trunk/Source/WebCore

[core] FEGaussianBlur: use IntSize to simplify member function interface
https://bugs.webkit.org/show_bug.cgi?id=130695

Reviewed by Dean Jackson.

By returning an IntSize to store the calculated kernel size values
it is possible to have less function parameters. This patch also
streamlines a bit the code in calculateUnscaledKernelSize.

No new tests, no change in behavior.

platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::determineAbsolutePaintRect):

platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::calculateUnscaledKernelSize):
(WebCore::FEGaussianBlur::calculateKernelSize):
(WebCore::FEGaussianBlur::determineAbsolutePaintRect):
(WebCore::FEGaussianBlur::platformApplySoftware):

platform/graphics/filters/FEGaussianBlur.h:

(if): Deleted.

platform/graphics/filters/FilterOperations.cpp:

(WebCore::outsetSizeForBlur):

5:54 PM Changeset in webkit [166213] by benjamin@webkit.org

2 edits in trunk/Source/WebKit2

[WK2] SpinLock are not initialized by default, ViewUpdateDispatcher is missing an initializer
https://bugs.webkit.org/show_bug.cgi?id=130705

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-03-24
Reviewed by Simon Fraser.

WebProcess/WebPage/ViewUpdateDispatcher.cpp:

(WebKit::ViewUpdateDispatcher::ViewUpdateDispatcher):

5:52 PM Changeset in webkit [166212] by BJ Burg

7 edits
1 add in trunk

Web Replay: capture and replay keyboard events
https://bugs.webkit.org/show_bug.cgi?id=130314

Reviewed by Joseph Pecoraro.

ManualTests/inspector/replay-keyboard-events.html: Added.

Source/WebCore:

Upstream support for capturing and replaying non-IME keyboard input.
This works similarly to mouse events. It introduces optional fields and
macros to encode/decode them.

Test: ManualTests/inspector/replay-keyboard-events.html

replay/ReplayInputDispatchMethods.cpp:

(WebCore::HandleKeyPress::dispatch):

replay/SerializationMethods.cpp:

(JSC::EncodingTraits<NondeterministicInputBase>::encodeValue):
(JSC::EncodingTraits<NondeterministicInputBase>::decodeValue): Switch existing
encode/decode calls to use the shortening macros.
(JSC::EncodingTraits<KeypressCommand>::encodeValue): Added.
(JSC::EncodingTraits<KeypressCommand>::decodeValue): Added.
(JSC::PlatformKeyboardEventAppKit::PlatformKeyboardEventAppKit): Subclass
PlatformKeyboardEvent so that we can set AppKit-specific members not
initialized through the main constructors.
(JSC::EncodingTraits<PlatformKeyboardEvent>::encodeValue): Added.
(JSC::EncodingTraits<PlatformKeyboardEvent>::decodeValue): Added.

replay/SerializationMethods.h:
replay/UserInputBridge.cpp:

(WebCore::UserInputBridge::UserInputBridge): initialize m_state inside a guard.
(WebCore::UserInputBridge::handleKeyEvent): fill in the implementation.

replay/WebInputs.json:

5:17 PM Changeset in webkit [166211] by Lucas Forschler

5 edits in tags/Safari-538.24.1/Source

Versioning.

5:15 PM Changeset in webkit [166210] by Lucas Forschler

3 edits in tags/Safari-538.24.1/Source/WebKit2

Merged r166203.

5:12 PM Changeset in webkit [166209] by Lucas Forschler

1 copy in tags/Safari-538.24.1

New Tag.

4:51 PM Changeset in webkit [166208] by enrica@apple.com

10 edits in trunk/Source/WebKit2

[iOS WebKit2] Dictation support.
https://bugs.webkit.org/show_bug.cgi?id=130622
<rdar://problem/15337316>

Reviewed by Benjamin Poulain.

Adding support for dictation on iOS. There are two main types of interactions
with the dictation system:

initial request for context, which consists in retrieving the selected text

and 5 words before the selection and 5 words after, if available.

insertion of recognized chunks of text, providing the text

to replace.

UIProcess/AutoCorrectionCallback.h:

(WebKit::DictationContextCallback::create):
(WebKit::DictationContextCallback::~DictationContextCallback):
(WebKit::DictationContextCallback::performCallbackWithReturnValue):
(WebKit::DictationContextCallback::invalidate):
(WebKit::DictationContextCallback::DictationContextCallback):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView replaceDictatedText:withText:]):
(-[WKContentView requestDictationContext:]):

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::dictationContextCallback):
(WebKit::WebPageProxy::replaceDictatedText):
(WebKit::WebPageProxy::requestDictationContext):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::requestDictationContext):
(WebKit::WebPage::replaceDictatedText):

4:44 PM Changeset in webkit [166207] by thiago.lacerda@openbossa.org

2 edits in trunk/Source/WebCore

Optimizing string construction for type error in JSNavigatorCustom.cpp
https://bugs.webkit.org/show_bug.cgi?id=130683

Reviewed by Eric Carlson.

bindings/js/JSNavigatorCustom.cpp:

(WebCore::JSNavigator::webkitGetUserMedia):

4:30 PM Changeset in webkit [166206] by aestes@apple.com

2 edits in trunk/Source/WebKit2

Yet another iOS build fix, for the 32-bit build this time.

Shared/Downloads/ios/DownloadIOS.mm:

(WebKit::setUpDownloadClient):

4:23 PM Changeset in webkit [166205] by Beth Dakin

2 edits in trunk/Source/WebCore

Legacy-style scrollbars constantly redraw after scrolling
https://bugs.webkit.org/show_bug.cgi?id=130699

Reviewed by Simon Fraser.

The constant re-draw was happening because we were never calling [ScrollbarPainter
setUsePresentationValue:NO]. This is a silly bug where were should have been
looking at PlatformWheelEvent::momentumPhase() instead of
PlatformWheelEvent::phase()

page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::handleWheelEvent):

4:21 PM Changeset in webkit [166204] by aestes@apple.com

3 edits in trunk/Tools

Fix the iOS build of TestWebKitAPI.

TestWebKitAPI/Configurations/Base.xcconfig:
TestWebKitAPI/PlatformUtilities.h:

4:14 PM Changeset in webkit [166203] by timothy_horton@apple.com

3 edits in trunk/Source/WebKit2

REGRESSION (r165872): Double-applying device scale to snapshots
https://bugs.webkit.org/show_bug.cgi?id=130697
<rdar://problem/16396629>

Reviewed by Simon Fraser.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::scaledSnapshotWithOptions):
Drive-by, make scaledSnapshotWithOptions respect SnapshotOptionsExcludeDeviceScaleFactor.

(WebKit::WebPage::snapshotAtSize):
Divide the device scale out of the scale factor

WebProcess/WebPage/WebPage.h:

Rename the scale argument to scaledSnapshotWithOptions to clarify
that it is an additional scale on top of the device scale.

4:11 PM Changeset in webkit [166202] by dbates@webkit.org

4 edits
4 adds in trunk

XSS Auditor doesn't block <script> injected before an existing <script>
https://bugs.webkit.org/show_bug.cgi?id=130475

Merged from Blink (patch by Tom Sepez):
https://src.chromium.org/viewvc/blink?view=rev&revision=169697

Source/WebCore:

Tests: http/tests/security/xssAuditor/script-tag-expression-follows.html

http/tests/security/xssAuditor/script-tag-near-start.html

html/parser/XSSAuditor.cpp:

(WebCore::startsHTMLCommentAt):
(WebCore::startsSingleLineCommentAt):
(WebCore::startsMultiLineCommentAt):
(WebCore::startsOpeningScriptTagAt):
(WebCore::XSSAuditor::decodedSnippetForJavaScript):

LayoutTests:

http/tests/security/xssAuditor/resources/echo-intertag.pl:
http/tests/security/xssAuditor/script-tag-expression-follows-expected.txt: Added.
http/tests/security/xssAuditor/script-tag-expression-follows.html: Added.
http/tests/security/xssAuditor/script-tag-near-start-expected.txt: Added.
http/tests/security/xssAuditor/script-tag-near-start.html: Added.

4:01 PM Changeset in webkit [166201] by Brent Fulgham

15 edits in trunk

Activate WebVTT Tests Once Merging is Complete
https://bugs.webkit.org/show_bug.cgi?id=130420

Reviewed by Eric Carlson.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig: Turn on ENABLE(WEBVTT_REGIONS)

Source/WebCore:

Configurations/FeatureDefines.xcconfig: Turn on ENABLE(WEBVTT_REGIONS)

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig: Turn on ENABLE(WEBVTT_REGIONS)

Source/WebKit2:

Configurations/FeatureDefines.xcconfig: Turn on ENABLE(WEBVTT_REGIONS)

LayoutTests:

TestExpectations: Remove [Skip] for media/track/regions-webvtt
platform/efl/TestExpectations: Skip media/track/regions-webvtt
platform/gtk/TestExpectations: Skip media/track/regions-webvtt
platform/mac/js/dom/global-constructors-attributes.html: Add new VTTRegions cases.
platform/mac-mountainlion/js/dom/global-constructors-attributes.html: Ditto.
platform/win/TestExpectations: Skip media/track/regions-webvtt

3:59 PM Changeset in webkit [166200] by andersca@apple.com

2 edits in trunk/Source/WebCore

Re-fix the build.

WebCore.exp.in:

3:51 PM Changeset in webkit [166199] by thiago.lacerda@openbossa.org

4 edits in trunk/LayoutTests

Update some mediastream LayoutTests results
https://bugs.webkit.org/show_bug.cgi?id=130692

Reviewed by Eric Carlson.

Tests were not passing due to outdated expected files.

fast/mediastream/MediaStream-MediaElement-srcObject-expected.txt:
fast/mediastream/MediaStreamTrack-expected.txt:
fast/mediastream/RTCPeerConnection-ice-expected.txt:

3:32 PM Changeset in webkit [166198] by andersca@apple.com

2 edits in trunk/Source/WebCore

Fix build.

WebCore.exp.in:

Move a CFNetwork only symbol inside the USE(CFNETWORK) section.

3:27 PM Changeset in webkit [166197] by aestes@apple.com

2 edits in trunk/Source/WebKit2

Fix the iOS build.

Shared/Downloads/ios/DownloadIOS.mm:

(WebKit::setUpDownloadClient):

UIProcess/Cocoa/DownloadClient.mm:

2:54 PM Changeset in webkit [166196] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

mathml/presentation/tokenElements-background-color.html ImageOnlyFailure after 166170
https://bugs.webkit.org/show_bug.cgi?id=130693

Patch by Martin Hock <mhock@apple.com> on 2014-03-24
Reviewed by Tim Horton.

platform/mac/TestExpectations:

2:47 PM Changeset in webkit [166195] by mrowe@apple.com

2 edits in trunk/Source/WebKit2

Build fix after r166186.

UIProcess/Cocoa/DownloadClient.mm:

2:26 PM Changeset in webkit [166194] by Chris Fleizach

7 edits
1 move
2 adds in trunk

Regression: AX: Don't expose role or notifications for invalid menus
https://bugs.webkit.org/show_bug.cgi?id=129814

Reviewed by Mario Sanchez Prada.

Source/WebCore:

If a role=menu has no menuitem children, it should not be a menu.
This was a bit tricky to implement since we need to update the role after the children are created,
but it means we have to be a bit more aggressive about when to updateChildren, so that the role
is known to be valid.

Test: platform/mac/accessibility/invalid-menu-role-does-not-send-notification.html

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::notificationPostTimerFired):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::updateRoleAfterChildrenCreation):
(WebCore::AccessibilityRenderObject::addChildren):

accessibility/AccessibilityRenderObject.h:
accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(-[WebAccessibilityObjectWrapperBase updateObjectBackingStore]):

LayoutTests:

accessibility/table-with-aria-role.html:

Modify test so that tests only what we want (that the role is correct).
No longer use role=menu on the table, since the table won't have menuitems and won't be a valid menu.

platform/mac/accessibility/invalid-menu-role-does-not-send-notification-expected.txt: Added.
platform/mac/accessibility/invalid-menu-role-does-not-send-notification.html: Added.
platform/mac/accessibility/table-with-aria-role-expected.txt:

2:14 PM Changeset in webkit [166193] by aestes@apple.com

2 edits in trunk/Source/WTF

Fix the iOS build.

wtf/ThreadingPthreads.cpp:

(WTF::createThreadInternal):
(WTF::setCurrentThreadQOSUtility):

2:03 PM Changeset in webkit [166192] by akling@apple.com

2 edits in trunk/Source/JavaScriptCore

Stop pulling in all the macro assemblers from VM.h
<https://webkit.org/b/130691>

Remove #include of "GPRInfo.h". This breaks WebCore's dependency
on macro assemblers headers and removes 8 includes from every
.cpp file in the JS bindings.

Reviewed by Geoff Garen.

runtime/VM.h:

1:57 PM Changeset in webkit [166191] by benjamin@webkit.org

3 edits in trunk/Source/WebKit2

[WK2] Make updates on ViewUpdateDispatcher less heavy
https://bugs.webkit.org/show_bug.cgi?id=130626

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-03-24
Reviewed by Darin Adler.

WebProcess/WebPage/ViewUpdateDispatcher.cpp:

(WebKit::ViewUpdateDispatcher::visibleContentRectUpdate):
(WebKit::ViewUpdateDispatcher::dispatchVisibleContentRectUpdate):

WebProcess/WebPage/ViewUpdateDispatcher.h:

1:57 PM Changeset in webkit [166190] by timothy@apple.com

3 edits in trunk/Source/WebInspectorUI

Lazy load source code referred to from the source map, instead of when
the source code is revealed in the Resources sidebar.

https://bugs.webkit.org/show_bug.cgi?id=130625

Reviewed by Joseph Pecoraro.

UserInterface/Models/SourceMapResource.js:

(WebInspector.SourceMapResource): Set up the type info here so it can be used to
dispaly the right icon in the sidebar.
(WebInspector.SourceMapResource.prototype.canRequestContentFromBackend): Use _contentRequested.
(WebInspector.SourceMapResource.prototype.requestContentFromBackend.sourceMapResourceLoaded):
Reset finished and remove the type change dance we had before.

UserInterface/Views/SourceMapResourceTreeElement.js:

(WebInspector.SourceMapResourceTreeElement.prototype.onattach): Removed. Don't request content here.

1:51 PM Changeset in webkit [166189] by llango.u-szeged@partner.samsung.com

2 edits in trunk/Tools

Fix prepare-ChangeLog after r166156.
https://bugs.webkit.org/show_bug.cgi?id=130674

Reviewed by Darin Adler.

Scripts/prepare-ChangeLog:

(generateFunctionLists):
(extractLineRangeBeforeChange):

1:51 PM Changeset in webkit [166188] by benjamin@webkit.org

3 edits in trunk/Source/WebKit2

[iOS][WK2] Micro-optimize view state updates on the UIProcess side
https://bugs.webkit.org/show_bug.cgi?id=130631

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-03-24
Reviewed by Darin Adler.

UIProcess/API/Cocoa/WKWebView.mm:

(contentZoomScale):
[UIScrollView zoomScale] is not fast enough for -[WKWebView _updateVisibleContentRects]. Since we know what the zoom view is,
make a fast version hardcoding that.

(-[WKWebView _updateScrollViewBackground]):
(-[WKWebView _zoomToPoint:WebCore::atScale:]):
(-[WKWebView _scrollToRect:WebCore::origin:WebCore::minimumScrollDistance:]):
(-[WKWebView _zoomToRect:WebCore::withOrigin:WebCore::fitEntireRect:minimumScale:maximumScale:minimumScrollDistance:]):
(-[WKWebView _updateVisibleContentRects]):

UIProcess/ios/WKContentView.mm:

(fixedPositionRectFromExposedRect):
(-[WKContentView didUpdateVisibleRect:unobscuredRect:scale:inStableState:]):

1:29 PM Changeset in webkit [166187] by dino@apple.com

2 edits in trunk/Source/WebKit2

Remove WebGL asset entitlement
https://bugs.webkit.org/show_bug.cgi?id=130685

Reviewed by Simon Fraser.

No longer necessary on iOS.

Configurations/WebContent-iOS.entitlements:

12:44 PM Changeset in webkit [166186] by aestes@apple.com

15 edits
5 copies
2 adds in trunk

[iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
https://bugs.webkit.org/show_bug.cgi?id=129322

Reviewed by Anders Carlsson.

Source/WebCore:

platform/network/ResourceHandle.h:
platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::releaseConnectionForDownload): Changed to
return a RetainPtr that adopts the connection's retain count.

Source/WebKit/mac:

WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::convertMainResourceLoadToDownload): Use the
RetainPtr returned by releaseConnectionForDownload() rather than
manually releasing.

Source/WebKit2:

Based on an original patch by Yongjun Zhang <yongjun_zhang@apple.com>.

Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

Shared/Downloads/ios/DownloadIOS.mm:

(WebKit::dispatchOnMainThread):
(WebKit::toDownload):
(WebKit::setUpDownloadClient):
(WebKit::Download::startWithHandle):

UIProcess/API/APIDownloadClient.h:

(API::DownloadClient::~DownloadClient):

UIProcess/API/C/WKContext.cpp:

(WKContextSetDownloadClient):

UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _downloadDelegate]):
(-[WKProcessPool _setDownloadDelegate:]):

UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
UIProcess/API/Cocoa/_WKDownload.h: Added.
UIProcess/API/Cocoa/_WKDownload.mm: Added.

(WebKit::wrapper):
(WebKit::createAPIDownloadClient):
(-[_WKDownload dealloc]):
(-[_WKDownload API::]):

UIProcess/API/Cocoa/_WKDownloadDelegate.h: Added.
UIProcess/API/Cocoa/_WKDownloadInternal.h: Added.
UIProcess/Cocoa/DownloadClient.h: Added.
UIProcess/Cocoa/DownloadClient.mm: Added.
WebKit2.xcodeproj/project.pbxproj:

Tools:

Add an API test suite for _WKDownload.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.

(-[DownloadDelegate initWithSourceURL:]):
(-[DownloadDelegate sourceURL]):
(-[DownloadDelegate _downloadDidStart:]):
(-[DownloadDelegate _download:didReceiveResponse:]):
(-[DownloadDelegate _download:didReceiveData:]):
(-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
(-[DownloadDelegate _downloadDidFinish:]):
(TEST):
(runTestWithNavigationDelegate):
(-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
(-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):

12:31 PM Changeset in webkit [166185] by barraclough@apple.com

2 edits in trunk/Source/WTF

Add support for thread QoS
https://bugs.webkit.org/show_bug.cgi?id=130688

Speculative EFL build fix.

wtf/ThreadingPthreads.cpp:

(WTF::setCurrentThreadQOSUtility):

12:25 PM Changeset in webkit [166184] by barraclough@apple.com

7 edits in trunk/Source

Add support for thread QoS
https://bugs.webkit.org/show_bug.cgi?id=130688

Reviewed by Andreas Kling.

Source/JavaScriptCore:

heap/BlockAllocator.cpp:

(JSC::BlockAllocator::blockFreeingThreadStartFunc):

block freeing is a utility activity.

Source/WTF:

wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::runScavengerThread):

block freeing is a utility activity.

wtf/Threading.h:
- declaration.
wtf/ThreadingPthreads.cpp:

(WTF::createThreadInternal):

default to interactive.

(WTF::setCurrentThreadQOSUtility):

implementation.

wtf/ThreadingWin.cpp:

(WTF::setCurrentThreadQOSUtility):

no-op implementation.

11:58 AM Changeset in webkit [166183] by Chris Fleizach

3 edits in trunk/LayoutTests

<hr> should expose AXRole/AXSubrole, etc
https://bugs.webkit.org/show_bug.cgi?id=109015

Unreviewed. Update tests for ML platform.

platform/mac-mountainlion/accessibility/lists-expected.txt:
platform/mac-mountainlion/accessibility/roles-exposed-expected.txt:

11:56 AM Changeset in webkit [166182] by enrica@apple.com

2 edits in trunk/Source/WebCore

Update Hindi fallback font.
https://bugs.webkit.org/show_bug.cgi?id=130690
<rdar://problem/16391601>

Reviewed by Sam Weinig.

Using the new available font for Hindi in the fallback list.

platform/graphics/ios/FontCacheIOS.mm:

(WebCore::FontCache::systemFallbackForCharacters):

10:51 AM Changeset in webkit [166181] by matthew_hanson@apple.com

2 edits in branches/safari-537.75-branch/Source/WebCore

Remove a commented line of code introduced by r166104.

10:38 AM Changeset in webkit [166180] by Brent Fulgham

6 edits in trunk/Source/WebCore

Merge Minor WebVTT Cleanups from Blink
https://bugs.webkit.org/show_bug.cgi?id=130681

Reviewed by Eric Carlson.

Merged from Blink (patch by philipj@opera.com):
https://chromium.googlesource.com/chromium/blink/+/693eb5e2933dca0eab5bbd604e9f3406fe9fd1ab
http://crbug.com/52593009
https://chromium.googlesource.com/chromium/blink/+/40b3602feab34e9be829fd742b6ad6ded322a09f
http://crbug.com/104243003

html/track/TextTrack.cpp:

(WebCore::TextTrack::setMode):

html/track/TextTrack.idl:
html/track/TextTrackCue.h:
html/track/VTTCue.cpp:

(WebCore::VTTCue::VTTCue):

html/track/VTTCue.h:

10:37 AM Changeset in webkit [166179] by fred.wang@free.fr

12 edits
5 deletes in trunk/Source/WebCore

Unreviewed, rolling out r166169.
https://bugs.webkit.org/show_bug.cgi?id=130682

This patch broke tests on Apple Mavericks (Requested by fredw
on #webkit).

Reverted changeset:

"Operator stretching: expose a math data API"
https://bugs.webkit.org/show_bug.cgi?id=130572
http://trac.webkit.org/changeset/166169

Patch by Commit Queue <commit-queue@webkit.org> on 2014-03-24

10:29 AM Changeset in webkit [166178] by fpizlo@apple.com

4 edits in trunk/Source/JavaScriptCore

Unreviewed, fix CLOOP build.

bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeFor):

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::getCallLinkInfoForBytecodeIndex):
(JSC::CodeBlock::resetStubDuringGCInternal): Deleted.

bytecode/CodeBlock.h:

(JSC::CodeBlock::callLinkInfosEnd): Deleted.

10:21 AM Changeset in webkit [166177] by commit-queue@webkit.org

2 edits in trunk/Tools

filter-build-webkit: reduce unfiltered output
https://bugs.webkit.org/show_bug.cgi?id=130485

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-03-24
Reviewed by Brent Fulgham.

Scripts/filter-build-webkit:

(shouldIgnoreLine):

10:13 AM Changeset in webkit [166176] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

ENABLE(CSS_GRID_LAYOUT) guard for CSSGridLineNamesValue
https://bugs.webkit.org/show_bug.cgi?id=130669

Patch by Martin Hodovan <mhodovan@inf.u-szeged.hu> on 2014-03-24
Reviewed by Sergio Villar Senin.

No new tests. No new functionality.

css/CSSGridLineNamesValue.cpp:
css/CSSGridLineNamesValue.h:

10:08 AM Changeset in webkit [166175] by Chris Fleizach

16 edits
2 adds in trunk

<hr> should expose AXRole/AXSubrole, etc
https://bugs.webkit.org/show_bug.cgi?id=109015

Reviewed by Mario Sanchez Prada.

Source/WebCore:

Expose the <hr> element to Mac and iOS through the accessibility interface.

Test: platform/mac/accessibility/hr-element.html

English.lproj/Localizable.strings:
accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isEnabled):

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::computedRoleString):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):

accessibility/atk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
(-[WebAccessibilityObjectWrapper accessibilityLabel]):

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):

platform/LocalizedStrings.cpp:

(WebCore::AXHorizontalRuleDescriptionText):

platform/LocalizedStrings.h:

LayoutTests:

accessibility/lists.html:
- An errant <hr> element was in this test which changed results
accessibility/roles-computedRoleString-expected.txt:
accessibility/roles-exposed.html:
platform/gtk/accessibility/roles-exposed-expected.txt: Added.
platform/mac/accessibility/hr-element-expected.txt: Added.
platform/mac/accessibility/hr-element.html: Added.
platform/mac/accessibility/lists-expected.txt:
platform/mac/accessibility/roles-exposed-expected.txt:

9:52 AM Changeset in webkit [166174] by Antti Koivisto

4 edits in trunk/LayoutTests

Invalidate sibling text node style when needed instead of attaching synchronously
https://bugs.webkit.org/show_bug.cgi?id=130590

Reviewed by Andreas Kling.

Minor non-observable whitespace changes.

fast/forms/select-listbox-focus-displaynone-expected.txt:
fast/repaint/text-in-relative-positioned-inline-expected.txt:

9:49 AM Changeset in webkit [166173] by Antti Koivisto

2 edits in trunk/Source/WebCore

Invalidate sibling text node style when needed instead of attaching synchronously
https://bugs.webkit.org/show_bug.cgi?id=130590

Reviewed by Andreas Kling.

Make things simpler.

style/StyleResolveTree.cpp:

(WebCore::Style::invalidateWhitespaceOnlyTextSiblingsAfterAttachIfNeeded):

Just invalidate instead of calling attach directly.
Rename to match.

(WebCore::Style::textRendererIsNeeded):
(WebCore::Style::createTextRendererIfNeeded):

Move all testing to textRendererIsNeeded.

(WebCore::Style::updateTextRendererAfterContentChange):

Call resolveTextNode instead of re-implementing the same thing.

(WebCore::Style::resolveLocal):
(WebCore::Style::resolveTextNode):

Avoid unnecessary reattaching.
Rename for consistency.

(WebCore::Style::resolveShadowTree):
(WebCore::Style::resolveTree):

9:35 AM Changeset in webkit [166172] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Fix !ENABLE(VIDEO) build
https://bugs.webkit.org/show_bug.cgi?id=130671

Patch by Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com> on 2014-03-24
Reviewed by Eric Carlson.

Add missing ENABLE(VIDEO) guards because many functions use
the newly guarded functions.

testing/Internals.cpp:
testing/Internals.h:
testing/Internals.idl:

9:30 AM Changeset in webkit [166171] by Antti Koivisto

5 edits in trunk/Source/WebCore

Text autosizing does not determine line count correctly for simple line layout
https://bugs.webkit.org/show_bug.cgi?id=130673

Reviewed by Daniel Bates.

We don't count lines correctly in simple line layout case.

page/Frame.cpp:

(WebCore::Frame::textAutosizingWidth):
(WebCore::Frame::setTextAutosizingWidth):

page/ios/FrameIOS.mm:

(WebCore::Frame::textAutosizingWidth): Deleted.
(WebCore::Frame::setTextAutosizingWidth): Deleted.

Move to Frame.cpp to make enabling on non-iOS build easier.

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::lineCount):

Handle simple line layout case.

(WebCore::RenderBlockFlow::lineCountForTextAutosizing):

Call lineCount() if children are inline.
Rename for clarity.

(WebCore::RenderBlockFlow::adjustComputedFontSizes):
(WebCore::RenderBlockFlow::immediateLineCount): Deleted.

rendering/RenderBlockFlow.h:

9:27 AM Changeset in webkit [166170] by fred.wang@free.fr

3 edits
2 adds in trunk

[regression] background colors do not apply to <mo> elements.
https://bugs.webkit.org/show_bug.cgi?id=130470.

Source/WebCore:

Test: mathml/presentation/tokenElements-background-color.html

rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::paint): always call the parent painting to draw the background.
(WebCore::RenderMathMLOperator::paintChildren): move the special case for invisible operator here.

LayoutTests:

mathml/presentation/tokenElements-background-color.html: Added.
mathml/presentation/tokenElements-background-color-expected.html: Added.

9:20 AM Changeset in webkit [166169] by fred.wang@free.fr

12 edits
3 copies
2 adds in trunk/Source/WebCore

Operator stretching: expose a math data API
https://bugs.webkit.org/show_bug.cgi?id=130572

Reviewed by Chris Fleizach.

We expose a new SimpleFontData API to give access to the data from the
OpenType MATH table using a font cache. The class OpenTypeMathData will
be implemented in bug 130324. On Darwin platform, we also implement the
missing FontPlatformData::openTypeTable function which will be necessary
to load the OpenType MATH table. The changes are intended to be used
for MathML operator stretching (bug 130322) so tests are not added yet.

CMakeLists.txt: add new OpenTypeMathData files.
GNUmakefile.list.am: ditto.
WebCore.vcxproj/WebCore.vcxproj: ditto.
WebCore.vcxproj/WebCore.vcxproj.filters: ditto.
WebCore.xcodeproj/project.pbxproj: ditto.
platform/graphics/FontCache.cpp: We add a FontCache::getMathData function to implement a cache for the math data.

We make the math and vertical data share the same key for the cache.
(WebCore::fontMathDataCacheInstance):
(WebCore::FontCache::getMathData):
(WebCore::fontVerticalDataCacheInstance):

platform/graphics/FontCache.h: We declare FontCache::getMathData and FontFileKey on all platforms.
platform/graphics/FontPlatformData.cpp:

(WebCore::FontPlatformData::openTypeTable): We implement openTypeTable() on Darwin platform.

platform/graphics/FontPlatformData.h: We expose openTypeTable() on Darwin platform.
platform/graphics/SimpleFontData.cpp: We initialize m_mathData from the font cache.

(WebCore::SimpleFontData::SimpleFontData):

platform/graphics/SimpleFontData.h: We expose a mathData() function to access the MATH data.
platform/graphics/opentype/OpenTypeMathData.cpp: Added. This is a new class that will be used to parse the data from the OpenType MATH table.

(WebCore::OpenTypeMathData::OpenTypeMathData):

platform/graphics/opentype/OpenTypeMathData.h: Added.

(WebCore::OpenTypeMathData::create):
(WebCore::OpenTypeMathData::hasMathData):

9:09 AM Changeset in webkit [166168] by jonlee@apple.com

4 edits in trunk/Source

Build fixes.

Unreviewed.

Source/WebCore:

editing/ios/EditorIOS.mm:

(WebCore::Editor::writeSelectionToPasteboard): Convert to reference.

Source/WebKit/mac:

WebInspector/WebNodeHighlightView.mm: Missing include to GeometryUtilities.

8:27 AM Changeset in webkit [166167] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

ENABLE(VIDEO_TRACK) guard for CSSParserSelector::parsePseudoCueFunctionSelector
https://bugs.webkit.org/show_bug.cgi?id=130666

Patch by Martin Hodovan <mhodovan@inf.u-szeged.hu> on 2014-03-24
Reviewed by Andreas Kling.

No new tests. No new functionality.

css/CSSParserValues.cpp:

(WebCore::CSSParserSelector::parsePseudoCueFunctionSelector): Deleted.

8:24 AM Changeset in webkit [166166] by rgabor@webkit.org

2 edits in trunk/Source/JavaScriptCore

[ARM64] GNU assembler doesn't work with LLInt arm64 backend.
https://bugs.webkit.org/show_bug.cgi?id=130453

Reviewed by Filip Pizlo.

Change fp and lr to x29 and x30. Add both operand kinds to emitARM64()
at sxtw and uxtw instructions.

offlineasm/arm64.rb:

6:46 AM Changeset in webkit [166165] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-2.4.0

Tagging the WebKitGTK+ 2.4.0 release

5:03 AM Changeset in webkit [166164] by Michał Pakuła vel Rutka

3 edits in trunk/LayoutTests

Unreviewed EFL gardening

Add test expectations for failing tests. Skip crashing http tests.

platform/efl-wk2/TestExpectations:
platform/efl/TestExpectations:

4:50 AM Changeset in webkit [166163] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.4

Unreviewed. Update NEWS and Versions.m4 for 2.4.0 release.

Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

NEWS: Added release notes for 2.4.0.

4:39 AM Changeset in webkit [166162] by Csaba Osztrogonác

2 edits in trunk/Source/WebKit2

[EFL][WK2] Buildfix after r166159.

Patch by Dániel Bátyai <Dániel Bátyai> on 2014-03-24
Reviewed by Csaba Osztrogonác.

UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_file_access_from_file_urls_allowed_set):
(ewk_settings_file_access_from_file_urls_allowed_get):

4:01 AM Changeset in webkit [166161] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.4

Unreviewed. Race condition when closing pages with network process enabled
https://bugs.webkit.org/show_bug.cgi?id=129684

Source/WebKit2:

When the last page of a web process is closed with the network
process enabled, the UI process checks if the web process can be
terminated and closes the connection with that web process. But
right before that the Close message has been sent which also
enables the process termination in the web process. Sometimes
there's a race condition in the web process between the process
termination triggered by the Close message and the one triggered
by the socket being closed by the UI process.

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::shouldTerminate): Use a 1 second timeout so
that if the message is sent right the before the connection is
closed, we don't wait indefinitely for the sync reply keeping the
web process alive.

Tools:

Enable the test to check that web processes finish when the web
view is destroyed.

TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:

3:15 AM Changeset in webkit [166160] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2

Merge r166158 - [GTK][WK2] Guard NetscapePluginModule methods used in PluginInfoCache that are specific to X11 architecture
https://bugs.webkit.org/show_bug.cgi?id=130663

Reviewed by Carlos Garcia Campos.

The two used methods are specific to the X11 plugin architecture and are not declared when building for a
Wayland-only configuration. Guarding them prevents build failures, but does not ensure proper functionality
which isn't a problem anyway since there's no support yet for Netscape plugins on Wayland.

UIProcess/Plugins/gtk/PluginInfoCache.cpp:

(WebKit::PluginInfoCache::getPluginInfo): Guard NetscapePluginModule::parseMIMEDescription with PLUGIN_ARCHITECTURE(X11).
(WebKit::PluginInfoCache::updatePluginInfo): Ditto for NetscapePluginModule::buildMIMEDescription.

3:09 AM Changeset in webkit [166159] by jinwoo7.song@samsung.com

4 edits in trunk/Source/WebKit2

[EFL][WK2] Use C API inside ewk_settings
https://bugs.webkit.org/show_bug.cgi?id=107820

Reviewed by Gyuyoung Kim.

Use C API inside ewk_settings instead of accessing directly
internal C++ classes, to avoid violating API layering.

Original-author: Christophe Dumez <Christophe Dumez>

UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):

UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_fullscreen_enabled_set):
(ewk_settings_fullscreen_enabled_get):
(ewk_settings_javascript_enabled_set):
(ewk_settings_javascript_enabled_get):
(ewk_settings_loads_images_automatically_set):
(ewk_settings_loads_images_automatically_get):
(ewk_settings_developer_extras_enabled_set):
(ewk_settings_developer_extras_enabled_get):
(ewk_settings_file_access_from_file_urls_allowed_set):
(ewk_settings_file_access_from_file_urls_allowed_get):
(ewk_settings_frame_flattening_enabled_set):
(ewk_settings_frame_flattening_enabled_get):
(ewk_settings_dns_prefetching_enabled_set):
(ewk_settings_dns_prefetching_enabled_get):
(ewk_settings_encoding_detector_enabled_set):
(ewk_settings_encoding_detector_enabled_get):
(ewk_settings_preferred_minimum_contents_width_set):
(ewk_settings_preferred_minimum_contents_width_get):
(ewk_settings_offline_web_application_cache_enabled_set):
(ewk_settings_offline_web_application_cache_enabled_get):
(ewk_settings_scripts_can_open_windows_set):
(ewk_settings_scripts_can_open_windows_get):
(ewk_settings_local_storage_enabled_set):
(ewk_settings_local_storage_enabled_get):
(ewk_settings_plugins_enabled_set):
(ewk_settings_plugins_enabled_get):
(ewk_settings_default_font_size_set):
(ewk_settings_default_font_size_get):
(ewk_settings_private_browsing_enabled_set):
(ewk_settings_private_browsing_enabled_get):
(ewk_settings_text_autosizing_enabled_set):
(ewk_settings_text_autosizing_enabled_get):
(ewk_settings_spatial_navigation_enabled_set):
(ewk_settings_spatial_navigation_enabled_get):
(EwkSettings::setDefaultTextEncodingName):

UIProcess/API/efl/ewk_settings_private.h:

(EwkSettings::EwkSettings):
(EwkSettings::preferences):

3:03 AM Changeset in webkit [166158] by zandobersek@gmail.com

2 edits in trunk/Source/WebKit2

[GTK][WK2] Guard NetscapePluginModule methods used in PluginInfoCache that are specific to X11 architecture
https://bugs.webkit.org/show_bug.cgi?id=130663

Reviewed by Carlos Garcia Campos.

UIProcess/Plugins/gtk/PluginInfoCache.cpp:

2:42 AM Changeset in webkit [166157] by commit-queue@webkit.org

36 edits
2 adds in trunk

[CSS Grid Layout] Update named <grid-line> syntax to the last version of the specs
https://bugs.webkit.org/show_bug.cgi?id=129041

Patch by Javier Fernandez <jfernandez@igalia.com> on 2014-03-24
Reviewed by Sergio Villar Senin.

From Blink r162555 by <svillar@igalia.com>

Source/WebCore:

Names for grid lines are now specified as a list of whitespace separated
idents enclosed in parentheses instead of as a list of strings.

Updated tests to match the new <grid-line> syntax.

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.xcodeproj/project.pbxproj: Added info of the new file for the CSSGridLineNamesValue class.
css/CSSComputedStyleDeclaration.cpp:

(WebCore::addValuesForNamedGridLinesAtIndex): The named <grid-line> value is now a list.

css/CSSGrammar.y.in: New syntax for named <grid-line>.
css/CSSGridLineNamesValue.cpp: Added.

(WebCore::CSSGridLineNamesValue::customCSSText): String representation of the named <grid-line> as a list of Strings.
(WebCore::CSSGridLineNamesValue::CSSGridLineNamesValue): Constructor.
(WebCore::CSSGridLineNamesValue::cloneForCSSOM): Ref counted cloning function.

css/CSSGridLineNamesValue.h: Added.

(WebCore::CSSGridLineNamesValue::create): Ref counted constructor.

css/CSSParser.cpp:

(WebCore::CSSParser::parseGridLineNames): It replaces the old parseGrdTrackNames.
(WebCore::CSSParser::parseGridTrackList): Using the new named <grid-line> syntax.
(WebCore::CSSParser::parseGridTrackRepeatFunction): Using the new named <grid-line> syntax.

css/CSSParser.h:
css/CSSParserValues.cpp:

(WebCore::destroy): Handling the case of CSSValue being CSSValueList intances.
(WebCore::CSSParserValue::createCSSValue): Handling the case of CSSValue being CSSValueList intances.

css/CSSParserValues.h:

(WebCore::CSSParserValue::setFromValueList): Adds the named <grid-line> list to the CSSParserValueList instance.

css/CSSValue.cpp:

(WebCore::CSSValue::equals): Handling the case of the new CSSGridLineNamesValue class.
(WebCore::CSSValue::cssText): Handling the case of the new CSSGridLineNamesValue class.
(WebCore::CSSValue::destroy): Handling the case of the new CSSGridLineNamesValue class.

css/CSSValue.h:

(WebCore::CSSValue::isGridLineNamesValue): Type cast check for the new CSSGridLineNamesValue class.

css/StyleResolver.cpp:

(WebCore::createGridTrackList): Using the new named <grid-line> syntax.

LayoutTests:

Updated tests to match the new <grid-line> syntax.

fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
fast/css-grid-layout/grid-element-repeat-get-set-expected.txt:
fast/css-grid-layout/grid-element-repeat-get-set.html:
fast/css-grid-layout/grid-item-bad-resolution-double-span.html:
fast/css-grid-layout/grid-item-named-grid-area-resolution.html:
fast/css-grid-layout/grid-item-named-grid-line-resolution.html:
fast/css-grid-layout/grid-item-negative-position-resolution.html:
fast/css-grid-layout/grid-item-position-changed-dynamic.html:
fast/css-grid-layout/named-grid-line-get-set-expected.txt:
fast/css-grid-layout/named-grid-line-get-set.html:
fast/css-grid-layout/named-grid-lines-with-named-grid-areas-resolution.html:
fast/css-grid-layout/non-grid-columns-rows-get-set-expected.txt:
fast/css-grid-layout/non-grid-columns-rows-get-set-multiple-expected.txt:
fast/css-grid-layout/non-grid-element-repeat-get-set-expected.txt:
fast/css-grid-layout/non-grid-element-repeat-get-set.html:
fast/css-grid-layout/non-named-grid-line-get-set-expected.txt:
fast/css-grid-layout/non-named-grid-line-get-set.html:
fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:

(testInherit):
(testInitial):

fast/css-grid-layout/resources/grid-columns-rows-get-set.js:

(testInherit):
(testInitial):

fast/css-grid-layout/resources/non-grid-columns-rows-get-set-multiple.js:

(testInherit):
(testInitial):

fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js:

(testInherit):
(testInitial):

2:27 AM Changeset in webkit [166156] by llango.u-szeged@partner.samsung.com

2 edits in trunk/Tools

prepare-ChangeLog should list functions that have been removed too.
https://bugs.webkit.org/show_bug.cgi?id=130508

Reviewed by Darin Adler.

The prepare-ChangeLog does not list the deleted functions in the Changelog.
We have to read the functions and the line ranges of them from the source
before the change, then search for overlaps between them and the changed
line ranges from diff.

Scripts/prepare-ChangeLog:

(originalFile): Get original source command.
(generateFunctionLists): Collect deleted functions too.
(generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
(extractLineRangeBeforeChange): Extract line ranges from the original source to get
deleted functions ranges too.
(extractLineRange): Renamed to extractLineRangeAfterChange.

2:21 AM Changeset in webkit [166155] by ryuan.choi@samsung.com

8 edits in trunk/Source/WebKit2

[EFL][WK2] Convert some more OwnPtr/PassOwnPtr to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=130662

Reviewed by Gyuyoung Kim.

Replace uses of PassOwnPtr/OwnPtr with std::unique_ptr in remained WebKit2/Efl specific code.

UIProcess/API/efl/EwkView.h:
UIProcess/API/efl/ewk_cookie_manager.cpp:
UIProcess/API/efl/ewk_database_manager.cpp:

(getDatabaseOriginsCallback):

UIProcess/API/efl/ewk_error_private.h:
UIProcess/efl/DownloadManagerEfl.cpp:

(WebKit::DownloadManagerEfl::didFail):

UIProcess/efl/InputMethodContextEfl.h:

(WebKit::InputMethodContextEfl::create):

UIProcess/efl/PageLoadClientEfl.cpp:

(WebKit::PageLoadClientEfl::didFailLoadWithErrorForFrame):
(WebKit::PageLoadClientEfl::didFailProvisionalLoadWithErrorForFrame):

2:21 AM Changeset in webkit [166154] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Add expectations for flaky perf layout test.
https://bugs.webkit.org/show_bug.cgi?id=130584

Unreviewed EFL gardening.

Patch by Andrzej Badowski <a.badowski@samsung.com> on 2014-03-24

platform/efl/TestExpectations:

2:19 AM Changeset in webkit [166153] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Add expectations for flaky webgl layout test.
https://bugs.webkit.org/show_bug.cgi?id=130587

Unreviewed EFL gardening.

Patch by Andrzej Badowski <a.badowski@samsung.com> on 2014-03-24

platform/efl/TestExpectations:

2:10 AM Changeset in webkit [166152] by commit-queue@webkit.org

2 edits in trunk

[EFL] Inspector page is not loaded.
https://bugs.webkit.org/show_bug.cgi?id=130661

Patch by Sangyong Park <sy302.park@gmail.com> on 2014-03-24
Reviewed by Gyuyoung Kim.

Inspector page is not loaded, because some javascript files are not installed.
(InspectorJSBackendCommands.js, InspectorWebBackendCommands.js)

Source/PlatformEfl.cmake:

Mar 23, 2014:

11:42 PM Changeset in webkit [166151] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Convert WebHTMLConverter to C++
https://bugs.webkit.org/show_bug.cgi?id=130655

Patch by Sam Weinig <sam@webkit.org> on 2014-03-23
Reviewed by Andreas Kling.

Mechanically converts the Objective-C class WebHTMLConverter, to the C++ HTMLConverter (lots of cleanup to follow).
Removes unused members
- _standardFontFamily (never assigned to)
- _textSizeMultiplier (always exactly 1)
- _webViewTextSizeMultiplier (always exactly 0)
- _defaultFontSize (always exactly 12, changed to be constant)
- _minimumFontSize (always exactly 1, changed to be constant)
- _colorsForNodes (never assigned to)
- _indexingLimit (always exactly 0)
- _thumbnailLimit (always exactly 0)
- _flags.isIndexing (always false)
- _flags.isTesting (always false)

editing/cocoa/HTMLConverter.mm:

(HTMLConverter::convert):
(HTMLConverter::HTMLConverter):
(HTMLConverter::~HTMLConverter):
(defaultParagraphStyle):
(_childrenForNode):
(HTMLConverter::_stringForNode):
(HTMLConverter::_getFloat):
(_webKitBundle):
(HTMLConverter::_elementIsBlockLevel):
(HTMLConverter::_elementHasOwnBackgroundColor):
(HTMLConverter::_blockLevelElementForNode):
(HTMLConverter::_colorForNode):
(HTMLConverter::_computedAttributesForElement):
(HTMLConverter::_attributesForElement):
(HTMLConverter::_newParagraphForElement):
(HTMLConverter::_newLineForElement):
(HTMLConverter::_newTabForElement):
(_WebMessageDocumentClass):
(HTMLConverter::_addAttachmentForElement):
(HTMLConverter::_addQuoteForElement):
(HTMLConverter::_addValue):
(HTMLConverter::_fillInBlock):
(HTMLConverter::_processMetaElementWithName):
(HTMLConverter::_processHeadElement):
(HTMLConverter::_enterElement):
(HTMLConverter::_addTableForElement):
(HTMLConverter::_addTableCellForElement):
(HTMLConverter::_processElement):
(HTMLConverter::_addMarkersToList):
(HTMLConverter::_exitElement):
(HTMLConverter::_processText):
(HTMLConverter::_traverseNode):
(HTMLConverter::_traverseFooterNode):
(HTMLConverter::_adjustTrailingNewline):
(HTMLConverter::_loadFromDOMRange):
(fileWrapperForURL):
(fileWrapperForElement):
(WebCore::attributedStringFromRange):
(WebCore::editingAttributedStringFromRange):

10:16 PM Changeset in webkit [166150] by jinwoo7.song@samsung.com

3 edits in trunk/Source/WebCore

Remove Dead Stores from editing directory
https://bugs.webkit.org/show_bug.cgi?id=130634

Reviewed by Darin Adler.

Remove Dead Stores from editing directory which assigning a value to a variable
and never reading that value.

editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):

editing/markup.cpp:

(WebCore::createMarkupInternal):

9:51 PM Changeset in webkit [166149] by ryuan.choi@samsung.com

28 edits
1 add in trunk

Move all EFL typedefs into EflTypedefs.h.
https://bugs.webkit.org/show_bug.cgi?id=130511

Source/JavaScriptCore:

Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2014-03-23
Reviewed by Gyuyoung Kim

heap/HeapTimer.h: Remove EFL typedefs.

Source/WebCore: