Timeline
Mar 25, 2014:
- 10:37 PM Changeset in webkit [166284] by
-
- 2 edits in trunk/Source/WebCore
iOS build fix. Add missing semicolon.
- editing/cocoa/HTMLConverter.mm:
(HTMLConverter::_addAttachmentForElement):
- 9:22 PM Changeset in webkit [166283] by
-
- 2 edits in trunk/Source/WebCore
Speculative iOS build fix.
- editing/cocoa/HTMLConverter.mm:
(HTMLConverter::_addAttachmentForElement):
- 9:16 PM Changeset in webkit [166282] by
-
- 3 edits2 adds in trunk
[MSE] Duplicate 'seeked' events.
https://bugs.webkit.org/show_bug.cgi?id=130754
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/media-source/media-source-duplicate-seeked.html
During certain seek operations, HTMLMediaElement::finishSeek() can be called re-entrantly due to
the ready state changing as a result of MediaSource::monitorSourceBuffers(). Move this call to the
end of finishSeek() after m_seeking has been cleared.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
LayoutTests:
- media/media-source/media-source-duplicate-seeked-expected.txt: Added.
- media/media-source/media-source-duplicate-seeked.html: Added.
- 9:08 PM Changeset in webkit [166281] by
-
- 3 edits1 add in trunk/Source/JavaScriptCore
Arguments simplification phase should be fine with marking the arguments local itself as an arguments alias
https://bugs.webkit.org/show_bug.cgi?id=130764
<rdar://problem/16304788>
Reviewed by Sam Weinig.
Being an arguments alias just means that your OSR exit recovery should attempt arguments
creation. This is true of arguments locals. We had special cases that tried to make it not
true of arguments locals. The only consequence of those special cases was to cause crashes
in case of arguments that are also captured variables (i.e. we have SlowArguments). This
change just removes those special cases.
This change means that the FTL will now see SetLocals with a FlushedArguments format.
Previously you wouldn't see them because previously only non-captured variable would be
arguments aliases, and non-captured variables get completely SSAified - i.e. no SetLocals
left. Adding handling for FlushedArguments is a benign and simple change since its
behavior is identical to FlushedJSValue for that code's purposes.
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
- tests/stress/captured-arguments-variable.js: Added.
(foo):
(noInline):
- 8:35 PM Changeset in webkit [166280] by
-
- 1 edit8 adds in trunk/Websites/webkit.org
Add illustrations for a potential blog post
First version, let see how that works out.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-03-25
- blog-files/css-jit-introduction: Added.
- blog-files/css-jit-introduction/clicktostart.js: Added.
- blog-files/css-jit-introduction/css-jit-illustration.html: Added.
- blog-files/css-jit-introduction/html5-single-page-microbenchmark.html: Added.
- blog-files/css-jit-introduction/old-selectorchecker-illustration.html: Added.
- blog-files/css-jit-introduction/timing-illustration-eight-run.svg: Added.
- blog-files/css-jit-introduction/timing-illustration-five-run.svg: Added.
- blog-files/css-jit-introduction/timing-illustration-one-run.svg: Added.
- 8:03 PM Changeset in webkit [166279] by
-
- 10 edits in trunk
Web Inspector: AXI: add support for aria-activedescendant and reconcile UI/testing with parentNode
https://bugs.webkit.org/show_bug.cgi?id=130712
Patch by James Craig <jcraig@apple.com> on 2014-03-25
Reviewed by Timothy Hatcher.
Source/WebCore:
Test: inspector-protocol/dom/getAccessibilityPropertiesForNode.html
Support for @aria-activedescendant; code reuse changes w/ parentNode and activeDescendantNode.
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
- inspector/protocol/DOM.json:
Source/WebInspectorUI:
Support for @aria-activedescendant; code reuse changes w/ parentNode and activeDescendantNode.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Models/DOMNode.js:
- UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
LayoutTests:
Support for @aria-activedescendant; code reuse changes w/ parentNode and activeDescendantNode.
- inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt:
- inspector-protocol/dom/getAccessibilityPropertiesForNode.html:
- 7:37 PM Changeset in webkit [166278] by
-
- 10 edits1 add in trunk/Source/JavaScriptCore
Add HeapInlines
https://bugs.webkit.org/show_bug.cgi?id=130759
Reviewed by Filip Pizlo.
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- heap/Heap.cpp:
(JSC::MarkedBlockSnapshotFunctor::MarkedBlockSnapshotFunctor):
(JSC::MarkedBlockSnapshotFunctor::operator()):
- heap/Heap.h: Also reindented while we're here.
(JSC::Heap::writeBarrierBuffer):
(JSC::Heap::vm):
(JSC::Heap::objectSpace):
(JSC::Heap::machineThreads):
(JSC::Heap::operationInProgress):
(JSC::Heap::allocatorForObjectWithoutDestructor):
(JSC::Heap::allocatorForObjectWithNormalDestructor):
(JSC::Heap::allocatorForObjectWithImmortalStructureDestructor):
(JSC::Heap::storageAllocator):
(JSC::Heap::notifyIsSafeToCollect):
(JSC::Heap::isSafeToCollect):
(JSC::Heap::handleSet):
(JSC::Heap::handleStack):
(JSC::Heap::lastFullGCLength):
(JSC::Heap::lastEdenGCLength):
(JSC::Heap::increaseLastFullGCLength):
(JSC::Heap::sizeBeforeLastEdenCollection):
(JSC::Heap::sizeAfterLastEdenCollection):
(JSC::Heap::sizeBeforeLastFullCollection):
(JSC::Heap::sizeAfterLastFullCollection):
(JSC::Heap::jitStubRoutines):
(JSC::Heap::isDeferred):
(JSC::Heap::structureIDTable):
(JSC::Heap::removeCodeBlock):
- heap/HeapInlines.h: Added.
(JSC::Heap::shouldCollect):
(JSC::Heap::isBusy):
(JSC::Heap::isCollecting):
(JSC::Heap::heap):
(JSC::Heap::isLive):
(JSC::Heap::isInRememberedSet):
(JSC::Heap::isMarked):
(JSC::Heap::testAndSetMarked):
(JSC::Heap::setMarked):
(JSC::Heap::isWriteBarrierEnabled):
(JSC::Heap::writeBarrier):
(JSC::Heap::reportExtraMemoryCost):
(JSC::Heap::forEachProtectedCell):
(JSC::Heap::forEachCodeBlock):
(JSC::Heap::allocateWithNormalDestructor):
(JSC::Heap::allocateWithImmortalStructureDestructor):
(JSC::Heap::allocateWithoutDestructor):
(JSC::Heap::tryAllocateStorage):
(JSC::Heap::tryReallocateStorage):
(JSC::Heap::ascribeOwner):
(JSC::Heap::blockAllocator):
(JSC::Heap::releaseSoon):
(JSC::Heap::incrementDeferralDepth):
(JSC::Heap::decrementDeferralDepth):
(JSC::Heap::collectIfNecessaryOrDefer):
(JSC::Heap::decrementDeferralDepthAndGCIfNeeded):
(JSC::Heap::markListSet):
- runtime/JSCInlines.h:
- 7:30 PM Changeset in webkit [166277] by
-
- 5 edits in trunk
When the mouse is upped after dragged out of shadowDOM, it should lose :active.
https://bugs.webkit.org/show_bug.cgi?id=130660
Patch by Sanghyup Lee <sh53.lee@samsung.com> on 2014-03-25
Reviewed by Darin Adler.
Source/WebCore:
This caused a regression after r165037.
When we have to clear :active style of shadow DOM, we should clear host's style.
This patch replaces parentElement() by parentOrShadowHostElement().
- dom/Document.cpp:
(WebCore::Document::updateHoverActiveState):
LayoutTests:
- fast/css/hover-active-drag-expected.txt: Added a test for textarea.
- fast/css/hover-active-drag.html: Updated.
- 7:14 PM Changeset in webkit [166276] by
-
- 2 edits2 adds in trunk/Source/JavaScriptCore
DFG::ByteCodeParser::SetMode should distinguish between setting immediately without a flush and setting immediately with a flush
https://bugs.webkit.org/show_bug.cgi?id=130760
Reviewed by Mark Hahnenberg.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
- tests/stress/assign-argument-in-inlined-call.js: Added.
(f1):
(getF2Arguments):
(f2):
(f3):
- tests/stress/assign-captured-argument-in-inlined-call.js: Added.
(f1):
(f2):
(f3):
- 6:47 PM Changeset in webkit [166275] by
-
- 2 edits in trunk/Tools
Fix a failing API test on Mountain Lion and remove temporary debug logging.
- TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
(-[DownloadDelegate _download:didReceiveData:]):
(-[DownloadDelegate _downloadDidFinish:]):
- 5:57 PM Changeset in webkit [166274] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Always retry a failed MediaDocument as a PluginDocument
https://bugs.webkit.org/show_bug.cgi?id=130742
Reviewed by Jer Noble.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaLoadingFailedFatally): If the element is in a media document,
tell it that loading failed so it can retry as a plug-in.
- 5:49 PM Changeset in webkit [166273] by
-
- 2 edits in trunk/Source/WebCore
Replace HTMLConverter::_stringForNode by propertyValueForNode
https://bugs.webkit.org/show_bug.cgi?id=130711
Reviewed by Sam Weinig.
Replaced all calls to HTMLConverter::_stringForNode by that to propertyValueForNode.
- editing/cocoa/HTMLConverter.mm:
(HTMLConverter::_computedAttributesForElement):
(HTMLConverter::_addAttachmentForElement):
(HTMLConverter::_enterElement):
(HTMLConverter::_addTableForElement):
(HTMLConverter::_addTableCellForElement):
(HTMLConverter::_processElement):
(HTMLConverter::_exitElement):
(HTMLConverter::_processText):
(HTMLConverter::_traverseNode):
(HTMLConverter::_traverseFooterNode):
(HTMLConverter::_stringForNode): Deleted.
- 5:39 PM Changeset in webkit [166272] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix iOS build after r166261.
- WebCore.xcodeproj/project.pbxproj: Make SystemSleepListener.h a private header.
- 5:31 PM Changeset in webkit [166271] by
-
- 2 edits in trunk/Source/WebKit2
Remove PLATFORM(IOS) from NetworkProcessMac.mm
https://bugs.webkit.org/show_bug.cgi?id=130751
Reviewed by Alexey Proskuryakov.
Code in NetworkProcessMac.mm is guarded by PLATFORM(MAC) and so is not compiled on iOS.
Having PLATFORM(IOS) code in this file is unnecessary and confusing.
- NetworkProcess/mac/NetworkProcessMac.mm:
(WebKit::NetworkProcess::initializeProcessName):
(WebKit::overrideSystemProxies):
(WebKit::NetworkProcess::platformInitializeNetworkProcess):
- 5:01 PM Changeset in webkit [166270] by
-
- 6 edits in trunk/Source/WebKit2
Add a UI delegate callback for handling window.open
https://bugs.webkit.org/show_bug.cgi?id=130757
Reviewed by Sam Weinig.
- UIProcess/API/Cocoa/WKUIDelegate.h:
- UIProcess/API/Cocoa/WKWebView.mm:
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/Cocoa/UIClient.h:
- UIProcess/Cocoa/UIClient.mm:
(WebKit::UIClient::setDelegate):
(WebKit::UIClient::createNewPage):
- 5:00 PM Changeset in webkit [166269] by
-
- 3 edits in trunk/Source/WebKit2
Move stopLoading: back for now.
- UIProcess/API/Cocoa/WKWebView.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView stopLoading:]):
- 4:43 PM Changeset in webkit [166268] by
-
- 4 edits in trunk/Source/WebCore
[iOS] Enable caption support in full screen.
https://bugs.webkit.org/show_bug.cgi?id=130603
Reviewed by Eric Carlson.
Add TextTrackRepresentation support to MediaPlayerPrivateAVFoundationObjC.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): Add the m_textTrackRepresenationLayer if present.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenLayer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::requiresTextTrackRepresentation): True, if a m_videoFullscreenLayer is present.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setTextTrackRepresentation): Remove the old, and add the new m_textTrackRepresenationLayer.
Make the text track container a stacking context for painting purposes.
- Modules/mediacontrols/mediaControlsiOS.css:
(video::-webkit-media-text-track-container):
- 4:37 PM Changeset in webkit [166267] by
-
- 3 edits in trunk/Source/WebKit2
Change toolbarVisibility back to toolbarsVisibility
https://bugs.webkit.org/show_bug.cgi?id=130749
Reviewed by Tim Horton.
- UIProcess/API/Cocoa/WKWindowFeatures.h:
- UIProcess/API/Cocoa/WKWindowFeatures.mm:
(-[WKWindowFeatures _initWithWindowFeatures:WebCore::]):
- 4:28 PM Changeset in webkit [166266] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix 32-bit getter call alignment.
Reviewed by Mark Hahnenberg.
- jit/Repatch.cpp:
(JSC::generateGetByIdStub):
- 4:20 PM Changeset in webkit [166265] by
-
- 7 edits in trunk/Source/WebKit2
Pass the source frame to the CreateNewPage message
https://bugs.webkit.org/show_bug.cgi?id=130752
Reviewed by Tim Horton.
- UIProcess/API/APIUIClient.h:
(API::UIClient::createNewPage):
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::createNewPage):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow):
- 3:56 PM Changeset in webkit [166264] by
-
- 5 edits in trunk
Source/WebCore: Web Replay: resource unique identifiers should be unique-per-frame, not globally
https://bugs.webkit.org/show_bug.cgi?id=130632
Reviewed by Timothy Hatcher.
For replay purposes, we want to deterministically assign resource load identifiers
to resource loaders, provided that the resource loaders are created in the same
order.
To do this, we convert unique identifiers from being globally-unique to being
frame-unique. When a new frame is being loaded, unique identifiers for
subresources of that frame begin counting from 1.
No new tests. Identifier invariants are exercised by existing assertions and tests.
- loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::ProgressTracker):
(WebCore::ProgressTracker::reset):
(WebCore::ProgressTracker::createUniqueIdentifier):
- loader/ProgressTracker.h:
Tools: Web Replay: resource unique identifiers should be unique-per-frame, not globally
https://bugs.webkit.org/show_bug.cgi?id=130623
Reviewed by Timothy Hatcher.
The resource loader callback dumping routines assumed that resource identifiers
were globally unique. Its map of resource identifiers to URLs must also track the
frame associated with the resource.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
stable as long as the frame is valid.
(WTR::InjectedBundlePage::didInitiateLoadForResource):
(WTR::InjectedBundlePage::willSendRequestForFrame):
(WTR::InjectedBundlePage::didReceiveResponseForResource):
(WTR::InjectedBundlePage::didFinishLoadForResource):
(WTR::InjectedBundlePage::didFailLoadForResource):
- 3:38 PM Changeset in webkit [166263] by
-
- 10 edits8 adds in trunk
Repatch should plant calls to getters directly rather than through a C helper
https://bugs.webkit.org/show_bug.cgi?id=129589
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
As the title says. All of the superstructure for this was already in place, so now it
was just a matter of actually emitting the call.
8x speed-up for getter microbenchmarks.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/PolymorphicGetByIdList.h:
(JSC::GetByIdAccess::doesCalls):
- jit/AccessorCallJITStubRoutine.cpp: Added.
(JSC::AccessorCallJITStubRoutine::AccessorCallJITStubRoutine):
(JSC::AccessorCallJITStubRoutine::~AccessorCallJITStubRoutine):
(JSC::AccessorCallJITStubRoutine::visitWeak):
- jit/AccessorCallJITStubRoutine.h: Added.
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::storeCell):
- jit/GCAwareJITStubRoutine.h:
- jit/Repatch.cpp:
(JSC::generateGetByIdStub):
- runtime/GetterSetter.h:
(JSC::GetterSetter::offsetOfGetter):
(JSC::GetterSetter::offsetOfSetter):
LayoutTests:
Reviewed by Mark Hahnenberg.
- js/regress/getter-expected.txt: Added.
- js/regress/getter.html: Added.
- js/regress/script-tests/getter.js: Added.
- js/regress/script-tests/string-char-code-at.js: Added.
(foo):
- js/regress/string-char-code-at-expected.txt: Added.
- js/regress/string-char-code-at.html: Added.
- 3:34 PM Changeset in webkit [166262] by
-
- 12 edits in trunk/Source/WebKit2
Add a WebFrame::fromCoreFrame static member function and use it where possible
https://bugs.webkit.org/show_bug.cgi?id=130744
Reviewed by Tim Horton.
- WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
(WebKit::GeolocationPermissionRequestManager::startRequestForGeolocation):
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::documentFrame):
(WebKit::InjectedBundleNodeHandle::htmlFrameElementContentFrame):
(WebKit::InjectedBundleNodeHandle::htmlIFrameElementContentFrame):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
- WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
(WebKit::InjectedBundleDOMWindowExtension::frame):
- WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
(WebKit::InjectedBundleHitTestResult::frame):
(WebKit::InjectedBundleHitTestResult::targetFrame):
- WebProcess/Plugins/PluginView.cpp:
(WebKit::webPage):
(WebKit::PluginView::performFrameLoadURLRequest):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::focusedElementChanged):
(WebKit::WebChromeClient::focusedFrameChanged):
(WebKit::WebChromeClient::runBeforeUnloadConfirmPanel):
(WebKit::WebChromeClient::runJavaScriptAlert):
(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):
(WebKit::WebChromeClient::print):
(WebKit::WebChromeClient::exceededDatabaseQuota):
(WebKit::WebChromeClient::runOpenPanel):
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::textFieldDidBeginEditing):
(WebKit::WebEditorClient::textFieldDidEndEditing):
(WebKit::WebEditorClient::textDidChangeInTextField):
(WebKit::WebEditorClient::textDidChangeInTextArea):
(WebKit::WebEditorClient::doTextFieldCommandFromEvent):
(WebKit::WebEditorClient::textWillBeDeletedInTextField):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebKit::WebFrameLoaderClient::dispatchWillSendSubmitEvent):
(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::fromCoreFrame):
(WebKit::WebFrame::contentsAsString):
(WebKit::WebFrame::parentFrame):
(WebKit::WebFrame::childFrames):
(WebKit::WebFrame::frameForContext):
(WebKit::WebFrame::webArchiveData):
- WebProcess/WebPage/WebFrame.h:
- 3:26 PM Changeset in webkit [166261] by
-
- 12 edits6 adds in trunk
[Mac] Pause the media element during system sleep.
https://bugs.webkit.org/show_bug.cgi?id=130718
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/video-system-sleep.html
Relying on the platform media system to pause and restart playback during
system sleep can cause problems on some platforms, especially where hardware
decoders are concerned. Rather than implicitly pausing the media during
system sleep, explicitly pause the media before sleeping and resume (if
appropriate) upon waking.
Add a new class to be used for system sleep notifications:
- platform/SystemSleepListener.cpp: Added.
(WebCore::SystemSleepListener::create):
(WebCore::SystemSleepListener::SystemSleepListener):
- platform/SystemSleepListener.h: Added.
(WebCore::SystemSleepListener::Client::~Client):
(WebCore::SystemSleepListener::~SystemSleepListener):
(WebCore::SystemSleepListener::client):
Add a Mac-specific implementation:
- platform/mac/SystemSleepListenerMac.h: Added.
- platform/mac/SystemSleepListenerMac.mm: Added.
(WebCore::SystemSleepListener::create):
(WebCore::SystemSleepListenerMac::SystemSleepListenerMac):
(WebCore::SystemSleepListenerMac::~SystemSleepListenerMac):
Listen for system sleep notifications in MediaSessionManager:
- platform/audio/MediaSessionManager.cpp:
(WebCore::MediaSessionManager::MediaSessionManager):
(WebCore::MediaSessionManager::systemWillSleep):
(WebCore::MediaSessionManager::systemDidWake):
- platform/audio/MediaSessionManager.h:
Drive-by fix; notify the MediaSession that playback will begin
due to autoplay, but do not begin autoplaying if the session
is already interrupted:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
Add new files to project:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- CMakeLists.txt:
- GNUmakefile.list.am:
LayoutTests:
- media/video-system-sleep-expected.txt: Added.
- media/video-system-sleep.html: Added.
- 3:20 PM Changeset in webkit [166260] by
-
- 2 edits in trunk/Tools
Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
- TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
(-[DownloadDelegate _download:didReceiveResponse:]):
(-[DownloadDelegate _download:didReceiveData:]):
- 3:01 PM Changeset in webkit [166259] by
-
- 3 edits4 adds in trunk
[CSS Regions] The background of children of scrollable elements flowed into regions is not properly scrolled
https://bugs.webkit.org/show_bug.cgi?id=130574
Reviewed by David Hyatt.
Source/WebCore:
When computing the clip rect for painting the box decorations, the scrolled content offset
must be computed by going up the containing block tree, up to the region.
Tests: fast/regions/scrollable-region-scrollable-absolute-content-background.html
fast/regions/scrollable-region-scrollable-content-background.html
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::decorationsClipRectForBoxInNamedFlowFragment):
LayoutTests:
Added tests for properly painting background of children of scrollable elements flowed into regions.
- fast/regions/scrollable-region-scrollable-absolute-content-background-expected.html: Added.
- fast/regions/scrollable-region-scrollable-absolute-content-background.html: Added.
- fast/regions/scrollable-region-scrollable-content-background-expected.html: Added.
- fast/regions/scrollable-region-scrollable-content-background.html: Added.
- 2:53 PM Changeset in webkit [166258] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Schemes registered as cache partitioned are not properly registered in new web processes
https://bugs.webkit.org/show_bug.cgi?id=130739
Reviewed by Anders Carlsson.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
- 2:52 PM Changeset in webkit [166257] by
-
- 25 edits in trunk/Source
[iOS] Inspector View Indication Support
https://bugs.webkit.org/show_bug.cgi?id=130709
Reviewed by Simon Fraser.
Source/WebCore:
- inspector/InspectorClient.h:
(WebCore::InspectorClient::showInspectorIndication):
(WebCore::InspectorClient::hideInspectorIndication):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::setIndicating):
Rename indicate/hideIndication to show/hide names.
Source/WebKit/ios:
- WebCoreSupport/WebInspectorClientIOS.mm:
(WebInspectorClient::showInspectorIndication):
(WebInspectorClient::hideInspectorIndication):
Renamed methods.
Source/WebKit/mac:
- WebCoreSupport/WebInspectorClient.h:
- WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::didSetSearchingForNode): Deleted.
(WebInspectorClient::releaseFrontend): Deleted.
- WebView/WebView.mm:
(-[WebView setShowingInspectorIndication:]):
- WebView/WebViewPrivate.h:
Renamed methods.
Source/WebKit2:
- UIProcess/ios/WKContentView.h:
- UIProcess/ios/WKContentView.mm:
(-[WKInspectorIndicationView initWithFrame:]):
(-[WKContentView isShowingInspectorIndication]):
(-[WKContentView setShowingInspectorIndication:]):
(-[WKContentView _didCommitLayerTree:WebKit::]):
When indicating include a simple tinted UIView over the content.
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _showInspectorIndication]):
(-[WKWebView _hideInspectorIndication]):
Have the content view show or hide an indication.
- UIProcess/PageClient.h:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::showInspectorIndication):
(WebKit::PageClientImpl::hideInspectorIndication):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::showInspectorIndication):
(WebKit::WebPageProxy::hideInspectorIndication):
Pass WebProcess indication message up to the WKWebView.
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::indicate):
(WebKit::WebInspectorClient::hideIndication):
- WebProcess/WebCoreSupport/WebInspectorClient.h:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::indicate):
(WebKit::WebPage::hideIndication):
Pass WebCore / remote inspector indication message up to UIProcess.
- 2:34 PM Changeset in webkit [166256] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix. Typo on checkin.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Left an unmatched open bracket.
- 2:33 PM Changeset in webkit [166255] by
-
- 2 edits in trunk/Source/WebCore
Even further unreviewed build fix after r166247. Unprotect the implementation of HTMLMediaElement::shouldDisableSleep().
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
- 2:26 PM Changeset in webkit [166254] by
-
- 5 edits in trunk/Source/WebCore
Further unreviewed build fix after r166247. Add DisplaySleepDisabler to the windows project file and
move the definition of DisplaySleepDisabler's constructor and destructor into the cpp file.
- WebCore.vcxproj/WebCore.vcxproj:
- platform/DisplaySleepDisabler.cpp:
(WebCore::DisplaySleepDisabler::DisplaySleepDisabler):
(WebCore::DisplaySleepDisabler::~DisplaySleepDisabler):
- platform/DisplaySleepDisabler.h:
- 2:18 PM Changeset in webkit [166253] by
-
- 3 edits in trunk/Source/WebKit2
Add more properties to WKWindowFeatures
https://bugs.webkit.org/show_bug.cgi?id=130738
Reviewed by Tim Horton.
- UIProcess/API/Cocoa/WKWindowFeatures.h:
- UIProcess/API/Cocoa/WKWindowFeatures.mm:
(-[WKWindowFeatures _initWithWindowFeatures:WebCore::]):
(-[WKWindowFeatures menuBarVisibility]):
(-[WKWindowFeatures statusBarVisibility]):
(-[WKWindowFeatures toolbarsVisibility]):
(-[WKWindowFeatures allowsResizing]):
- 2:07 PM Changeset in webkit [166252] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed build fix after r166247. Un-platform-protect the declaration of HTMLMediaElement::shouldDisableSleep()
and make WebVideoFullscreenController's _displaySleepDisabler a std::unique_ptr.
- html/HTMLMediaElement.h:
- platform/mac/WebVideoFullscreenController.h:
- 2:03 PM Changeset in webkit [166251] by
-
- 3 edits in trunk/Source/WebKit2
Fix iOS build.
- UIProcess/API/Cocoa/WKWebView.h:
- UIProcess/API/Cocoa/WKWebView.mm:
Make WKIBActions OS X only for now.
- 2:00 PM Changeset in webkit [166250] by
-
- 6 edits in trunk/Source/WebCore
[iOS] Pass additional options to AVFoundation during playback.
https://bugs.webkit.org/show_bug.cgi?id=130624
Reviewed by Eric Carlson.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::doesHaveAttribute): Return attribute value if the user
passes a pointer to fill in.
- html/HTMLMediaElement.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::doesHaveAttribute):
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::doesHaveAttribute):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Pass additional
option if supplied by user.
- 1:43 PM Changeset in webkit [166249] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r166070.
Rollout r166070 due to 2% performance loss in page load times
Reverted changeset:
"Change CodeGeneratorJS.pm special cases for "DOMWindow" to be
general purpose"
https://bugs.webkit.org/show_bug.cgi?id=130553
http://trac.webkit.org/changeset/166070
- 1:40 PM Changeset in webkit [166248] by
-
- 13 edits3 deletes in trunk
Unreviewed, rolling out r166126.
Rollout r166126 in prepartion to roll out prerequisite r166070
Reverted changeset:
"toThis() on a JSWorkerGlobalScope should return a JSProxy and
not undefined"
https://bugs.webkit.org/show_bug.cgi?id=130554
http://trac.webkit.org/changeset/166126
- 1:25 PM Changeset in webkit [166247] by
-
- 6 edits2 moves2 adds in trunk/Source/WebCore
[iOS] Playing video does not disable display sleep.
https://bugs.webkit.org/show_bug.cgi?id=130729
Reviewed by Eric Carlson.
DisplaySleepDisabler was broken by r161589, which replaced the iOS implementation with
an empty one. Make a platform independent version with a Cocoa-platform subclass. Update
the APIs to non-deprecated ones.
- platform/DisplaySleepDisabler.cpp: Added.
(WebCore::DisplaySleepDisabler::create):
- platform/DisplaySleepDisabler.h: Added.
(WebCore::DisplaySleepDisabler::~DisplaySleepDisabler):
(WebCore::DisplaySleepDisabler::DisplaySleepDisabler):
- platform/cocoa/DisplaySleepDisablerCocoa.cpp: Renamed from Source/WebCore/platform/mac/DisplaySleepDisabler.cpp.
(WebCore::DisplaySleepDisabler::create):
(WebCore::DisplaySleepDisablerCocoa::DisplaySleepDisablerCocoa):
(WebCore::DisplaySleepDisablerCocoa::~DisplaySleepDisablerCocoa):
- platform/cocoa/DisplaySleepDisablerCocoa.h: Renamed from Source/WebCore/platform/mac/DisplaySleepDisabler.h.
Update m_sleepDisabler to be a std::unique_ptr, and unprotect the definition of methods which use it.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateSleepDisabling):
(WebCore::HTMLMediaElement::shouldDisableSleep):
- html/HTMLMediaElement.h:
Add the new and renamed files to the project:
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj:
- 1:24 PM Changeset in webkit [166246] by
-
- 7 edits3 adds2 deletes in trunk
Implement ImageData constructors and WebWorkers exposure
https://bugs.webkit.org/show_bug.cgi?id=130668
Reviewed by Dean Jackson.
Source/WebCore:
Add new constructors for ImageData.
Test: fast/canvas/canvas-imageData.html
- html/ImageData.cpp:
(WebCore::ImageData::create):
- html/ImageData.h:
- html/ImageData.idl:
LayoutTests:
Tests for ImageData constructors. Remove a false tests for constructors
from Philip's test suite.
- fast/canvas/canvas-imageData-expected.txt: Added.
- fast/canvas/canvas-imageData.html: Added.
- fast/canvas/script-tests/canvas-imageData.js: Added.
(testTransparentBlack):
- LayoutTests/canvas/philip/tests/2d.imageData.object.ctor.html: Removed.
- LayoutTests/canvas/philip/tests/2d.imageData.object.ctor-expected.txt: Removed.
- LayoutTests/js/dom/global-constructors-attributes-dedicated-worker-expected.txt
- LayoutTests/js/dom/global-constructors-attributes-shared-worker-expected.txt
- 1:15 PM Changeset in webkit [166245] by
-
- 6 edits2 adds in trunk
InlineIterator position (unsigned int) variable can wrap around
https://bugs.webkit.org/show_bug.cgi?id=130540
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2014-03-25
Reviewed by Simon Fraser.
Source/WebCore:
We trigger an ASSERT that occurs when we are ignoring spaces (to collapse them
into a single whitespace mark) but then encounter a line break. Because we don't ignore
the first space (but do ignore subsequent spaces), when we hit a newline in an RTL context
we want to ignore that first space as well (so as not to push the text away from the right
edge). We do this by decrementing the InlineIterator pointing to this first space, so all
the spaces get ignored. However, if that space is the first character in a Text node, the
decrement will try to go past the beginning of the node, and trigger an ASSERT.
This design is not great. At some point we should rework it to more elegantly handle
collapsing whitespace in both RTL and LTR writing modes.
This patch adds an ASSERT earlier in this codepath to catch potential problems earlier.
It also pulls our sentinel value out into a separate boolean to make it more clear what is
going on.
Test: fast/text/whitespace-only-text-in-rtl.html
- rendering/InlineIterator.h:
(WebCore::InlineIterator::moveTo): Use the set*() calls
(WebCore::InlineIterator::setOffset): ASSERT early that our math hasn't wrapped
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::appendRunsForObject): Use new boolean value
- rendering/line/BreakingContextInlineHeaders.h:
(WebCore::BreakingContext::handleText): Guard against wraps
(WebCore::checkMidpoints): Use new boolean value
- rendering/line/TrailingObjects.cpp:
(WebCore::TrailingObjects::updateMidpointsForTrailingBoxes): Use new boolean value
LayoutTests:
This test triggers an ASSERT that occurs when we are ignoring spaces (to collapse them
into a single whitespace mark) but then encounter a line break. Because we don't ignore
the first space (but do ignore subsequent spaces), when we hit a newline in an RTL context
we want to ignore that first space as well (so as not to push the text away from the right
edge). We do this by decrementing the InlineIterator pointing to this first space, so all
the spaces get ignored. However, if that space is the first character in a Text node, the
decrement will try to go past the beginning of the node, and trigger an ASSERT.
This design is not great. At some point we should rework it to more elegantly handle
collapsing whitespace in both RTL and LTR writing modes.
- fast/text/whitespace-only-text-in-rtl-expected.txt: Added.
- fast/text/whitespace-only-text-in-rtl.html: Added.
Conflicts:
LayoutTests/ChangeLog
Source/WebCore/ChangeLog
- 1:10 PM Changeset in webkit [166244] by
-
- 2 edits3 adds in trunk/Source/WebKit2
Begin stubbing out a WKWindowFeatures class
https://bugs.webkit.org/show_bug.cgi?id=130733
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKWindowFeatures.h: Added.
- UIProcess/API/Cocoa/WKWindowFeatures.mm: Added.
(-[WKWindowFeatures _initWithWindowFeatures:WebCore::]):
(-[WKWindowFeatures x]):
(-[WKWindowFeatures y]):
(-[WKWindowFeatures width]):
(-[WKWindowFeatures height]):
- UIProcess/API/Cocoa/WKWindowFeaturesInternal.h: Added.
- WebKit2.xcodeproj/project.pbxproj:
- 1:06 PM Changeset in webkit [166243] by
-
- 6 edits in trunk
AST incorrectly conflates readable and writable locations
https://bugs.webkit.org/show_bug.cgi?id=130734
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
We need to distinguish between "locations" that are valid for reading
and writing, vs those that may only be written.
- bytecompiler/NodesCodegen.cpp:
(JSC::ForInNode::emitBytecode):
(JSC::ForOfNode::emitBytecode):
- parser/Nodes.h:
(JSC::ExpressionNode::isAssignmentLocation):
LayoutTests:
More tests
- js/parser-syntax-check-expected.txt:
- js/script-tests/parser-syntax-check.js:
- 12:48 PM Changeset in webkit [166242] by
-
- 2 edits in trunk/Tools
Add some debug logging to an API test that's failing on Mountain Lion.
- TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
(-[DownloadDelegate _download:didReceiveResponse:]):
(-[DownloadDelegate _downloadDidFinish:]):
- 12:17 PM Changeset in webkit [166241] by
-
- 5 edits in trunk
Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
https://bugs.webkit.org/show_bug.cgi?id=130732
Reviewed by Tim Horton.
Source/WebKit2:
- UIProcess/API/Cocoa/WKWebView.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView goBack]):
(-[WKWebView goForward]):
(-[WKWebView validateUserInterfaceItem:]):
(-[WKWebView goBack:]):
(-[WKWebView goForward:]):
(-[WKWebView stopLoading:]):
Tools:
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController validateUserInterfaceItem:]):
- 11:00 AM Changeset in webkit [166240] by
-
- 5 edits in trunk
ASSERTION FAILED in Parser: dst != localReg
https://bugs.webkit.org/show_bug.cgi?id=130710
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Just make sure we don't try to write to a captured constant,
following the change to track captured variables separately.
- bytecompiler/NodesCodegen.cpp:
(JSC::PostfixNode::emitResolve):
(JSC::PrefixNode::emitResolve):
LayoutTests:
New testcases.
- js/parser-syntax-check-expected.txt:
- js/script-tests/parser-syntax-check.js:
- 10:45 AM Changeset in webkit [166239] by
-
- 35 edits1 copy22 deletes in trunk
[GTK] Remove the autotools build
https://bugs.webkit.org/show_bug.cgi?id=130717
Reviewed by Anders Carlsson.
.:
- .gitignore: Remove references to autotools files.
- GNUmakefile.am: Removed.
- Source/autotools/CheckSystemAndBasicDependencies.m4: Removed.
- Source/autotools/CustomMacros.m4: Removed.
- Source/autotools/FindDependencies.m4: Removed.
- Source/autotools/PrintBuildConfiguration.m4: Removed.
- Source/autotools/ReadCommandLineArguments.m4: Removed.
- Source/autotools/SetupAutoconfHeader.m4: Removed.
- Source/autotools/SetupAutomake.m4: Removed.
- Source/autotools/SetupCompilerFlags.m4: Removed.
- Source/autotools/SetupLibtool.m4: Removed.
- Source/autotools/SetupWebKitFeatures.m4: Removed.
- Source/autotools/Versions.m4: Removed.
- Source/autotools/acinclude.m4: Removed.
- Source/autotools/dolt.m4: Removed.
- Source/autotools/gsettings.m4: Removed.
- Source/cmake/OptionsGTK.cmake:
- autogen.sh: Removed.
- configure.ac: Removed.
Source/JavaScriptCore:
- GNUmakefile.am: Removed.
- config.h: Remove references to the autotools configure file.
Source/Platform:
- GNUmakefile.am: Removed.
Source/ThirdParty:
- gtest/GNUmakefile.am: Removed.
- leveldb/GNUmakefile.am: Removed.
Source/ThirdParty/ANGLE:
- GNUmakefile.am: Removed.
Source/WebCore:
- GNUmakefile.am: Removed.
- bindings/gobject/GNUmakefile.am: Removed.
- config.h: Removed references to autotools configure file.
Source/WebCore/platform/gtk/po:
- GNUmakefile.am: Removed.
Source/WebInspectorUI:
- GNUmakefile.am: Removed.
Source/WebKit/gtk:
- GNUmakefile.am: Removed.
Source/WebKit2:
- GNUmakefile.am: Removed.
- WebKit2Prefix.h: Removed references to the autotools configure file.
- config.h: Ditto.
Source/WTF:
- GNUmakefile.am: Removed.
- config.h: Removed references to the autotools configure file.
Tools:
- DumpRenderTree/config.h: Remove references to the autotools configure file.
- GNUmakefile.am: Removed.
- GtkLauncher/GNUmakefile.am: Removed.
- GtkLauncher/main.c: Remove references to the autotools configure file.
- MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
- MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
- MiniBrowser/gtk/BrowserWindow.c: Ditto.
- MiniBrowser/gtk/GNUmakefile.am: Removed.
- MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
- Scripts/build-webkit: No longer handle autotools.
- Scripts/run-gtk-tests: Ditto.
(TestRunner._setup_testing_environment):
- Scripts/run-launcher: Ditto.
- Scripts/webkitdirs.pm: Ditto.
- Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
- Scripts/webkitpy/common/config/contributors.json: Ditto.
- Scripts/webkitpy/port/gtk.py: No longer handle autotools.
- Scripts/webkitpy/style/checker.py:
- TestWebKitAPI/GNUmakefile.am: Removed.
- TestWebKitAPI/config.h: Remove references to the autotools configure file.
- WebKitTestRunner/GNUmakefile.am: Removed.
- WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
- gtk/GNUmakefile.am: Removed.
- gtk/common.py: Remove checks for the autotools build.
- gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
- 9:51 AM Changeset in webkit [166238] by
-
- 8 edits2 adds in trunk
Prevent 'removetrack' events from firing when all inband text tracks are removed.
https://bugs.webkit.org/show_bug.cgi?id=130704
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/track/track-remove-track.html
Based on the Blink change (patch by acolwell@chromium.org):
https://codereview.chromium.org/177243018/
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::prepareForLoad): Reorder steps to match W3C specification.
(WebCore::HTMLMediaElement::noneSupported): Forget tracks as required by specification.
(WebCore::HTMLMediaElement::mediaLoadingFailed): Forget tracks as required by specification.
(WebCore::HTMLMediaElement::removeTextTrack): Only request the 'removetracks' event if
requested by caller.
(WebCore::HTMLMediaElement::removeAllInbandTracks): Renamed to 'forgetResourceSpecificTracks'
(WebCore::HTMLMediaElement::noneSupported): Specify that we want the 'removetracks' event
fired for this use case.
(WebCore::HTMLMediaElement::prepareForLoad): Switch to new 'forgetResourceSpecificTracks' name.
- html/HTMLMediaElement.h:
- html/track/TextTrackList.cpp:
(TextTrackList::remove): Only fire the 'removetrack' event if the caller requests it.
- html/track/TextTrackList.h: Add default argument to fire the 'removetrack' event
when removing a track.
- html/track/TrackListBase.cpp:
(TrackListBase::remove): Only fire the 'removetrack' event if the caller requests it.
- html/track/TrackListBase.h: Add default argument to fire the 'removetrack' event.
LayoutTests:
Based on the Blink change (patch by acolwell@chromium.org):
https://codereview.chromium.org/177243018/
- media/track/track-remove-track-expected.txt: Added.
- media/track/track-remove-track.html: Added.
- 9:44 AM Changeset in webkit [166237] by
-
- 2 edits in trunk/LayoutTests
media/W3C/audio/canPlayType/canPlayType_application_octet_stream.html frequently fails on EWS
https://bugs.webkit.org/show_bug.cgi?id=130720
- platform/mac/TestExpectations: Marked as flaky.
- 9:42 AM Changeset in webkit [166236] by
-
- 3 edits2 adds in trunk
Hold a reference to firstSuccessfulSubmitButton in HTMLFormElement::submit
<http://webkit.org/b/130713>
<rdar://problem/15661876>
Reviewed by Darin Adler.
Merged from Blink (patch by Ian Beer):
http://crbug.com/303657
https://src.chromium.org/viewvc/blink?view=rev&revision=158938
Source/WebCore:
Test: fast/forms/form-submission-crash-successful-submit-button.html
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::submit):
LayoutTests:
- fast/forms/form-submission-crash-successful-submit-button-expected.txt: Added.
- fast/forms/form-submission-crash-successful-submit-button.html: Added.
- 8:53 AM Changeset in webkit [166235] by
-
- 2 edits in trunk/Tools
prepare-ChangeLog throws false positive warnings for modified files.
https://bugs.webkit.org/show_bug.cgi?id=130687
Reviewed by Darin Adler.
- Scripts/prepare-ChangeLog:
(originalFile): Ignore git commit paremeter.
We don't need this to get the unmodified file.
(extractLineRangeBeforeChange):
Simplify the if statement. Follow-up after r166189.
- 7:13 AM Changeset in webkit [166234] by
-
- 2 edits in trunk/Source/WTF
[ARM64] GCC generates wrong code with -O2 flag in WTF::weakCompareAndSwap
https://bugs.webkit.org/show_bug.cgi?id=130500
Reviewed by Filip Pizlo.
Set the first operand to the exact register in the inline assembly with GCC.
- wtf/Atomics.h:
(WTF::weakCompareAndSwap):
- 6:14 AM Changeset in webkit [166233] by
-
- 2 edits in trunk/Source/WebCore
[ARM64] GNU assembler fails in TransformationMatrix::multiply
https://bugs.webkit.org/show_bug.cgi?id=130454
Reviewed by Zoltan Herczeg.
Change the NEON intstructions to the proper style.
- platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::multiply):
- 6:08 AM Changeset in webkit [166232] by
-
- 8 edits in trunk
[EFL] Add ARM64 build support
https://bugs.webkit.org/show_bug.cgi?id=130506
Rubber stamped by Gyuyoung Kim.
.:
- CMakeLists.txt: Set WTF_CPU_ARM64 when aarch64 is defined.
Source/ThirdParty:
- leveldb/port/atomic_pointer.h: Set ARCH_CPU_ARM_FAMILY when aarch64 is defined.
Source/WTF:
- wtf/Platform.h: Set WTF_CPU_ARM64 when aarch64 is defined.
Tools:
- Scripts/webkitdirs.pm:
(isARM): Detect aarch64 as ARM.
- 5:43 AM Changeset in webkit [166231] by
-
- 3 edits2 moves in trunk
[CSS Grid Layout] Vertical rectangles not considered as valid grid areas
https://bugs.webkit.org/show_bug.cgi?id=130513
Reviewed by Andreas Kling.
Source/WebCore:
Grid areas sized as vertical rectangles were incorrectly
considered as invalid by the parser. That's because the condition
checking that each new row was adjacent to the previous one was
using the first row of the currently parsed grid area instead of
the last one.
Test: fast/css-grid-layout/grid-template-areas-get-set.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseGridTemplateAreas):
LayoutTests:
Added tests for grid areas sized as horizontal and vertical
rectangles. The tests were also renamed from grid-template to
grid-template-areas which better describe their nature.
- fast/css-grid-layout/grid-template-areas-get-set-expected.txt: Renamed from LayoutTests/fast/css-grid-layout/grid-template-get-set-expected.txt.
- fast/css-grid-layout/grid-template-areas-get-set.html: Renamed from LayoutTests/fast/css-grid-layout/grid-template-get-set.html.
- 5:13 AM Changeset in webkit [166230] by
-
- 4 edits in trunk
[EFL][WK2] Add NETWORK_PROCESS build option
https://bugs.webkit.org/show_bug.cgi?id=130131
Reviewed by Gyuyoung Kim.
.:
Add option to build EFL port with NETWORK_PROCESS set on. By default NETWORK_PROCESS is
set off.
- Source/cmake/OptionsEfl.cmake:
Source/WebKit2:
- PlatformEfl.cmake: Add file needed to build with NETWORK_PROCESS enabled.
- 5:13 AM Changeset in webkit [166229] by
-
- 4 edits in trunk/Tools
[webkitpy] Improve _parse_bug_description to recognize more descriptions
https://bugs.webkit.org/show_bug.cgi?id=130137
Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-03-25
Reviewed by Csaba Osztrogonác.
- Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLogEntry._parse_bug_description):
- Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_parse_log_entries_from_changelog):
- Scripts/webkitpy/common/checkout/checkout_unittest.py:
(CheckoutTest.test_commit_info_for_revision):
- 2:53 AM Changeset in webkit [166228] by
-
- 5 edits in trunk/Source/WebKit2
[EFL][WK2] Add an API to set process model
https://bugs.webkit.org/show_bug.cgi?id=130133
Reviewed by Gyuyoung Kim.
Implement an API to set and get process model in ewk_context.
By default process model enum value is set to EWK_PROCESS_MODEL_SHARED_SECONDARY
which keeps current behaviour. Setting EWK_PROCESS_MODEL_MULTIPLE_SECONDARY
will make each web view use separate web process, also enables network process.
- UIProcess/API/efl/ewk_context.cpp:
(toWKProcessModel):
(EwkContext::setProcessModel):
(toEwkProcessModel):
(EwkContext::processModel):
(ewk_context_process_model_set):
(ewk_context_process_model_get):
- UIProcess/API/efl/ewk_context.h:
- UIProcess/API/efl/ewk_context_private.h:
- UIProcess/API/efl/tests/test_ewk2_context.cpp:
(TEST_F):
- 2:10 AM Changeset in webkit [166227] by
-
- 4 edits2 adds in trunk
[GTK] Volume slider shows below the panel with videos in certain cases
https://bugs.webkit.org/show_bug.cgi?id=130608
Reviewed by Jer Noble.
Source/WebCore:
We need to delay the moment we check if the volume slider shows up
or down. If the video was not visible, the offsets were 0 and it
was forced to be shown below the panel.
Test: media/video-initially-hidden-volume-slider-up.html
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.createControls): Moved volumebox pseudo from
the subclass. The test checks for it and it would fail in Mac.
- Modules/mediacontrols/mediaControlsGtk.js:
(ControllerGtk.prototype.createControls): Moved volumebox pseudo
to the superclass.
(ControllerGtk.prototype.handleMuteButtonMouseOver): Check if
volume slider should show up or down.
(ControllerGtk.prototype.updateReadyState): Removed check for
volume slider direction.
LayoutTests:
- media/video-initially-hidden-volume-slider-up-expected.txt: Added.
- media/video-initially-hidden-volume-slider-up.html: Added.
- 12:13 AM Changeset in webkit [166226] by
-
- 5 edits in branches/safari-537.75-branch/Source
Versioning.
- 12:10 AM Changeset in webkit [166225] by
-
- 1 copy in tags/Safari-537.75.13
New tag.
Mar 24, 2014:
- 11:34 PM Changeset in webkit [166224] by
-
- 2 edits in trunk/Source/WebKit2
AX: hit-testing doesn't always work correctly with WK2
https://bugs.webkit.org/show_bug.cgi?id=130706
Reviewed by Simon Fraser.
Accessibility code was trying to do screenToRootView itself, and in
some cases with embedded WK2 views that did not work.
- WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:
(-[WKAccessibilityWebPageObject accessibilityHitTest:]):
- 11:24 PM Changeset in webkit [166223] by
-
- 10 edits1 copy in tags/Safari-538.24.2/Source/WebKit2
Merged r166103.
- 11:18 PM Changeset in webkit [166222] by
-
- 4 edits1 copy in tags/Safari-538.24.2/Source/WebKit2
Merged r165983.
- 10:30 PM Changeset in webkit [166221] by
-
- 9 edits in trunk
[Win] Enable WebVTT Regions on Windows.
https://bugs.webkit.org/show_bug.cgi?id=130680
Reviewed by Eric Carlson.
Source/WebCore:
- DerivedSources.cpp: Add new build components.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.props: Turn on WEBVTT_REGIONS
- win/tools/vsprops/FeatureDefinesCairo.props: Ditto.
LayoutTests:
- platform/win/TestExpectations: Turn on WebVTT tests.
- 9:59 PM Changeset in webkit [166220] by
-
- 5 edits in tags/Safari-538.24.2/Source
Versioning.
- 9:55 PM Changeset in webkit [166219] by
-
- 1 copy in tags/Safari-538.24.2
New tag.
- 8:44 PM Changeset in webkit [166218] by
-
- 16 edits in trunk/Source/JavaScriptCore
More scaffolding for a stub routine to have a stub recursively embedded inside it
https://bugs.webkit.org/show_bug.cgi?id=130770
Reviewed by Oliver Hunt.
- bytecode/CallLinkInfo.cpp:
(JSC::CallLinkInfo::unlink): VM& argument is superfluous.
(JSC::CallLinkInfo::visitWeak): Factor this out, it used to be in CodeBlock::finalizeUnconditionally().
- bytecode/CallLinkInfo.h:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finalizeUnconditionally): Factor out some functionality into CallLinkInfo::visitWeak(), and make sure we pass RepatchBuffer& in more places.
(JSC::CodeBlock::unlinkCalls):
(JSC::CodeBlock::unlinkIncomingCalls):
- bytecode/PolymorphicGetByIdList.cpp: Pass RepatchBuffer& through and call JITStubRoutine::visitWeak().
(JSC::GetByIdAccess::visitWeak):
(JSC::PolymorphicGetByIdList::visitWeak):
- bytecode/PolymorphicGetByIdList.h:
- bytecode/PolymorphicPutByIdList.cpp: Pass RepatchBuffer& through and call JITStubRoutine::visitWeak().
(JSC::PutByIdAccess::visitWeak):
(JSC::PolymorphicPutByIdList::visitWeak):
- bytecode/PolymorphicPutByIdList.h:
- bytecode/StructureStubInfo.cpp: Pass RepatchBuffer& through.
(JSC::StructureStubInfo::visitWeakReferences):
- bytecode/StructureStubInfo.h:
- jit/ClosureCallStubRoutine.cpp: isClosureCall is unused.
(JSC::ClosureCallStubRoutine::ClosureCallStubRoutine):
- jit/GCAwareJITStubRoutine.cpp:
(JSC::GCAwareJITStubRoutine::GCAwareJITStubRoutine):
(JSC::createJITStubRoutine):
- jit/GCAwareJITStubRoutine.h: Make it easier to construct one of these.
(JSC::GCAwareJITStubRoutine::isClosureCall): Deleted.
- jit/JITStubRoutine.cpp:
(JSC::JITStubRoutine::visitWeak): This will allow future JITStubRoutine subclasses to have stubs recursively embedded inside them.
- jit/JITStubRoutine.h:
- jit/Repatch.cpp:
(JSC::generateGetByIdStub): Fix a possible GC bug where we weren't making the stub routine GC aware.
(JSC::emitCustomSetterStub): Clean up some code.
- 8:27 PM Changeset in webkit [166217] by
-
- 4 edits in trunk/Source/JavaScriptCore
Safari crashes in JavaScriptCore: JSC::JSObject::growOutOfLineStorage
when WebKit is compiled with fcatch-undefined-behavior
https://bugs.webkit.org/show_bug.cgi?id=130652
Reviewed by Mark Hahnenberg.
Use a static member function because the butterfly we pass in might be
NULL, and passing NULL to a member function is undefined behavior.
Stylistically, I think this new way reads a little more clearly, since it
matches createOrGrowArrayRight, and it helps to convey that m_butterfly
might not exist yet.
- runtime/Butterfly.h:
- runtime/ButterflyInlines.h:
(JSC::Butterfly::createOrGrowPropertyStorage): Renamed from growPropertyStorage
because we might create. Split out the create path to avoid using NULL
in a member function expression.
Removed some unused versions of this function.
- runtime/JSObject.cpp:
(JSC::JSObject::growOutOfLineStorage): Updated for interface change.
- 6:54 PM Changeset in webkit [166216] by
-
- 5 edits in trunk
Strict mode destructuring assignment crashes the parser.
https://bugs.webkit.org/show_bug.cgi?id=130538
Reviewed by Michael Saboff.
Source/JavaScriptCore:
The SyntaxChecker mode always return 1 for success, except
for a small subset of functions where we needed exact information.
This ends up just being a poor design decision as it means
the parser can get confused between a function return 1, and
the Resolve constant which was also 1. So we now use a unique
type for every creation method.
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createSourceElements):
(JSC::SyntaxChecker::createFunctionBody):
(JSC::SyntaxChecker::createArguments):
(JSC::SyntaxChecker::createSpreadExpression):
(JSC::SyntaxChecker::createArgumentsList):
(JSC::SyntaxChecker::createPropertyList):
(JSC::SyntaxChecker::createElementList):
(JSC::SyntaxChecker::createFormalParameterList):
(JSC::SyntaxChecker::createClause):
(JSC::SyntaxChecker::createClauseList):
(JSC::SyntaxChecker::createFuncDeclStatement):
(JSC::SyntaxChecker::createBlockStatement):
(JSC::SyntaxChecker::createExprStatement):
(JSC::SyntaxChecker::createIfStatement):
(JSC::SyntaxChecker::createForLoop):
(JSC::SyntaxChecker::createForInLoop):
(JSC::SyntaxChecker::createForOfLoop):
(JSC::SyntaxChecker::createEmptyStatement):
(JSC::SyntaxChecker::createVarStatement):
(JSC::SyntaxChecker::createReturnStatement):
(JSC::SyntaxChecker::createBreakStatement):
(JSC::SyntaxChecker::createContinueStatement):
(JSC::SyntaxChecker::createTryStatement):
(JSC::SyntaxChecker::createSwitchStatement):
(JSC::SyntaxChecker::createWhileStatement):
(JSC::SyntaxChecker::createWithStatement):
(JSC::SyntaxChecker::createDoWhileStatement):
(JSC::SyntaxChecker::createLabelStatement):
(JSC::SyntaxChecker::createThrowStatement):
(JSC::SyntaxChecker::createDebugger):
(JSC::SyntaxChecker::createConstStatement):
(JSC::SyntaxChecker::appendConstDecl):
(JSC::SyntaxChecker::combineCommaNodes):
(JSC::SyntaxChecker::operatorStackPop):
LayoutTests:
Add tests
- js/parser-syntax-check-expected.txt:
- js/script-tests/parser-syntax-check.js:
- 6:21 PM Changeset in webkit [166215] by
-
- 2 edits in trunk/Source/WebCore
Remove some unnecessary includes from PlatformCALayerClient.h
https://bugs.webkit.org/show_bug.cgi?id=130703
Reviewed by Andreas Kling.
No need for all these #includes.
- platform/graphics/ca/PlatformCALayerClient.h:
- 6:14 PM Changeset in webkit [166214] by
-
- 5 edits in trunk/Source/WebCore
[core] FEGaussianBlur: use IntSize to simplify member function interface
https://bugs.webkit.org/show_bug.cgi?id=130695
Reviewed by Dean Jackson.
By returning an IntSize to store the calculated kernel size values
it is possible to have less function parameters. This patch also
streamlines a bit the code in calculateUnscaledKernelSize.
No new tests, no change in behavior.
- platform/graphics/filters/FEDropShadow.cpp:
(WebCore::FEDropShadow::determineAbsolutePaintRect):
- platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::calculateUnscaledKernelSize):
(WebCore::FEGaussianBlur::calculateKernelSize):
(WebCore::FEGaussianBlur::determineAbsolutePaintRect):
(WebCore::FEGaussianBlur::platformApplySoftware):
- platform/graphics/filters/FEGaussianBlur.h:
(if): Deleted.
- platform/graphics/filters/FilterOperations.cpp:
(WebCore::outsetSizeForBlur):
- 5:54 PM Changeset in webkit [166213] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] SpinLock are not initialized by default, ViewUpdateDispatcher is missing an initializer
https://bugs.webkit.org/show_bug.cgi?id=130705
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-03-24
Reviewed by Simon Fraser.
- WebProcess/WebPage/ViewUpdateDispatcher.cpp:
(WebKit::ViewUpdateDispatcher::ViewUpdateDispatcher):
- 5:52 PM Changeset in webkit [166212] by
-
- 7 edits1 add in trunk
Web Replay: capture and replay keyboard events
https://bugs.webkit.org/show_bug.cgi?id=130314
Reviewed by Joseph Pecoraro.
.:
- ManualTests/inspector/replay-keyboard-events.html: Added.
Source/WebCore:
Upstream support for capturing and replaying non-IME keyboard input.
This works similarly to mouse events. It introduces optional fields and
macros to encode/decode them.
Test: ManualTests/inspector/replay-keyboard-events.html
- replay/ReplayInputDispatchMethods.cpp:
(WebCore::HandleKeyPress::dispatch):
- replay/SerializationMethods.cpp:
(JSC::EncodingTraits<NondeterministicInputBase>::encodeValue):
(JSC::EncodingTraits<NondeterministicInputBase>::decodeValue): Switch existing
encode/decode calls to use the shortening macros.
(JSC::EncodingTraits<KeypressCommand>::encodeValue): Added.
(JSC::EncodingTraits<KeypressCommand>::decodeValue): Added.
(JSC::PlatformKeyboardEventAppKit::PlatformKeyboardEventAppKit): Subclass
PlatformKeyboardEvent so that we can set AppKit-specific members not
initialized through the main constructors.
(JSC::EncodingTraits<PlatformKeyboardEvent>::encodeValue): Added.
(JSC::EncodingTraits<PlatformKeyboardEvent>::decodeValue): Added.
- replay/SerializationMethods.h:
- replay/UserInputBridge.cpp:
(WebCore::UserInputBridge::UserInputBridge): initialize m_state inside a guard.
(WebCore::UserInputBridge::handleKeyEvent): fill in the implementation.
- replay/WebInputs.json:
- 5:17 PM Changeset in webkit [166211] by
-
- 5 edits in tags/Safari-538.24.1/Source
Versioning.
- 5:15 PM Changeset in webkit [166210] by
-
- 3 edits in tags/Safari-538.24.1/Source/WebKit2
Merged r166203.
- 5:12 PM Changeset in webkit [166209] by
-
- 1 copy in tags/Safari-538.24.1
New Tag.
- 4:51 PM Changeset in webkit [166208] by
-
- 10 edits in trunk/Source/WebKit2
[iOS WebKit2] Dictation support.
https://bugs.webkit.org/show_bug.cgi?id=130622
<rdar://problem/15337316>
Reviewed by Benjamin Poulain.
Adding support for dictation on iOS. There are two main types of interactions
with the dictation system:
- initial request for context, which consists in retrieving the selected text
and 5 words before the selection and 5 words after, if available.
- insertion of recognized chunks of text, providing the text
to replace.
- UIProcess/AutoCorrectionCallback.h:
(WebKit::DictationContextCallback::create):
(WebKit::DictationContextCallback::~DictationContextCallback):
(WebKit::DictationContextCallback::performCallbackWithReturnValue):
(WebKit::DictationContextCallback::invalidate):
(WebKit::DictationContextCallback::DictationContextCallback):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView replaceDictatedText:withText:]):
(-[WKContentView requestDictationContext:]):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::dictationContextCallback):
(WebKit::WebPageProxy::replaceDictatedText):
(WebKit::WebPageProxy::requestDictationContext):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::requestDictationContext):
(WebKit::WebPage::replaceDictatedText):
- 4:44 PM Changeset in webkit [166207] by
-
- 2 edits in trunk/Source/WebCore
Optimizing string construction for type error in JSNavigatorCustom.cpp
https://bugs.webkit.org/show_bug.cgi?id=130683
Reviewed by Eric Carlson.
- bindings/js/JSNavigatorCustom.cpp:
(WebCore::JSNavigator::webkitGetUserMedia):
- 4:30 PM Changeset in webkit [166206] by
-
- 2 edits in trunk/Source/WebKit2
Yet another iOS build fix, for the 32-bit build this time.
- Shared/Downloads/ios/DownloadIOS.mm:
(WebKit::setUpDownloadClient):
- 4:23 PM Changeset in webkit [166205] by
-
- 2 edits in trunk/Source/WebCore
Legacy-style scrollbars constantly redraw after scrolling
https://bugs.webkit.org/show_bug.cgi?id=130699
Reviewed by Simon Fraser.
The constant re-draw was happening because we were never calling [ScrollbarPainter
setUsePresentationValue:NO]. This is a silly bug where were should have been
looking at PlatformWheelEvent::momentumPhase() instead of
PlatformWheelEvent::phase()
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::handleWheelEvent):
- 4:21 PM Changeset in webkit [166204] by
-
- 3 edits in trunk/Tools
Fix the iOS build of TestWebKitAPI.
- TestWebKitAPI/Configurations/Base.xcconfig:
- TestWebKitAPI/PlatformUtilities.h:
- 4:14 PM Changeset in webkit [166203] by
-
- 3 edits in trunk/Source/WebKit2
REGRESSION (r165872): Double-applying device scale to snapshots
https://bugs.webkit.org/show_bug.cgi?id=130697
<rdar://problem/16396629>
Reviewed by Simon Fraser.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::scaledSnapshotWithOptions):
Drive-by, make scaledSnapshotWithOptions respect SnapshotOptionsExcludeDeviceScaleFactor.
(WebKit::WebPage::snapshotAtSize):
Divide the device scale out of the scale factor
- WebProcess/WebPage/WebPage.h:
Rename the scale argument to scaledSnapshotWithOptions to clarify
that it is an additional scale on top of the device scale.
- 4:11 PM Changeset in webkit [166202] by
-
- 4 edits4 adds in trunk
XSS Auditor doesn't block <script> injected before an existing <script>
https://bugs.webkit.org/show_bug.cgi?id=130475
Merged from Blink (patch by Tom Sepez):
https://src.chromium.org/viewvc/blink?view=rev&revision=169697
Source/WebCore:
Tests: http/tests/security/xssAuditor/script-tag-expression-follows.html
http/tests/security/xssAuditor/script-tag-near-start.html
- html/parser/XSSAuditor.cpp:
(WebCore::startsHTMLCommentAt):
(WebCore::startsSingleLineCommentAt):
(WebCore::startsMultiLineCommentAt):
(WebCore::startsOpeningScriptTagAt):
(WebCore::XSSAuditor::decodedSnippetForJavaScript):
LayoutTests:
- http/tests/security/xssAuditor/resources/echo-intertag.pl:
- http/tests/security/xssAuditor/script-tag-expression-follows-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-expression-follows.html: Added.
- http/tests/security/xssAuditor/script-tag-near-start-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-near-start.html: Added.
- 4:01 PM Changeset in webkit [166201] by
-
- 15 edits in trunk
Activate WebVTT Tests Once Merging is Complete
https://bugs.webkit.org/show_bug.cgi?id=130420
Reviewed by Eric Carlson.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig: Turn on ENABLE(WEBVTT_REGIONS)
Source/WebCore:
- Configurations/FeatureDefines.xcconfig: Turn on ENABLE(WEBVTT_REGIONS)
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig: Turn on ENABLE(WEBVTT_REGIONS)
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig: Turn on ENABLE(WEBVTT_REGIONS)
LayoutTests:
- TestExpectations: Remove [Skip] for media/track/regions-webvtt
- platform/efl/TestExpectations: Skip media/track/regions-webvtt
- platform/gtk/TestExpectations: Skip media/track/regions-webvtt
- platform/mac/js/dom/global-constructors-attributes.html: Add new VTTRegions cases.
- platform/mac-mountainlion/js/dom/global-constructors-attributes.html: Ditto.
- platform/win/TestExpectations: Skip media/track/regions-webvtt
- 3:59 PM Changeset in webkit [166200] by
-
- 2 edits in trunk/Source/WebCore
Re-fix the build.
- WebCore.exp.in:
- 3:51 PM Changeset in webkit [166199] by
-
- 4 edits in trunk/LayoutTests
Update some mediastream LayoutTests results
https://bugs.webkit.org/show_bug.cgi?id=130692
Reviewed by Eric Carlson.
Tests were not passing due to outdated expected files.
- fast/mediastream/MediaStream-MediaElement-srcObject-expected.txt:
- fast/mediastream/MediaStreamTrack-expected.txt:
- fast/mediastream/RTCPeerConnection-ice-expected.txt:
- 3:32 PM Changeset in webkit [166198] by
-
- 2 edits in trunk/Source/WebCore
Fix build.
- WebCore.exp.in:
Move a CFNetwork only symbol inside the USE(CFNETWORK) section.
- 3:27 PM Changeset in webkit [166197] by
-
- 2 edits in trunk/Source/WebKit2
Fix the iOS build.
- Shared/Downloads/ios/DownloadIOS.mm:
(WebKit::setUpDownloadClient):
- UIProcess/Cocoa/DownloadClient.mm:
- 2:54 PM Changeset in webkit [166196] by
-
- 2 edits in trunk/LayoutTests
mathml/presentation/tokenElements-background-color.html ImageOnlyFailure after 166170
https://bugs.webkit.org/show_bug.cgi?id=130693
Patch by Martin Hock <mhock@apple.com> on 2014-03-24
Reviewed by Tim Horton.
- platform/mac/TestExpectations:
- 2:47 PM Changeset in webkit [166195] by
-
- 2 edits in trunk/Source/WebKit2
Build fix after r166186.
- UIProcess/Cocoa/DownloadClient.mm:
- 2:26 PM Changeset in webkit [166194] by
-
- 7 edits1 move2 adds in trunk
Regression: AX: Don't expose role or notifications for invalid menus
https://bugs.webkit.org/show_bug.cgi?id=129814
Reviewed by Mario Sanchez Prada.
Source/WebCore:
If a role=menu has no menuitem children, it should not be a menu.
This was a bit tricky to implement since we need to update the role after the children are created,
but it means we have to be a bit more aggressive about when to updateChildren, so that the role
is known to be valid.
Test: platform/mac/accessibility/invalid-menu-role-does-not-send-notification.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::notificationPostTimerFired):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::updateRoleAfterChildrenCreation):
(WebCore::AccessibilityRenderObject::addChildren):
- accessibility/AccessibilityRenderObject.h:
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase updateObjectBackingStore]):
LayoutTests:
- accessibility/table-with-aria-role.html:
Modify test so that tests only what we want (that the role is correct).
No longer use role=menu on the table, since the table won't have menuitems and won't be a valid menu.
- platform/mac/accessibility/invalid-menu-role-does-not-send-notification-expected.txt: Added.
- platform/mac/accessibility/invalid-menu-role-does-not-send-notification.html: Added.
- platform/mac/accessibility/table-with-aria-role-expected.txt:
- 2:14 PM Changeset in webkit [166193] by
-
- 2 edits in trunk/Source/WTF
Fix the iOS build.
- wtf/ThreadingPthreads.cpp:
(WTF::createThreadInternal):
(WTF::setCurrentThreadQOSUtility):
- 2:03 PM Changeset in webkit [166192] by
-
- 2 edits in trunk/Source/JavaScriptCore
Stop pulling in all the macro assemblers from VM.h
<https://webkit.org/b/130691>
Remove #include of "GPRInfo.h". This breaks WebCore's dependency
on macro assemblers headers and removes 8 includes from every
.cpp file in the JS bindings.
Reviewed by Geoff Garen.
- runtime/VM.h:
- 1:57 PM Changeset in webkit [166191] by
-
- 3 edits in trunk/Source/WebKit2
[WK2] Make updates on ViewUpdateDispatcher less heavy
https://bugs.webkit.org/show_bug.cgi?id=130626
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-03-24
Reviewed by Darin Adler.
- WebProcess/WebPage/ViewUpdateDispatcher.cpp:
(WebKit::ViewUpdateDispatcher::visibleContentRectUpdate):
(WebKit::ViewUpdateDispatcher::dispatchVisibleContentRectUpdate):
- WebProcess/WebPage/ViewUpdateDispatcher.h:
- 1:57 PM Changeset in webkit [166190] by
-
- 3 edits in trunk/Source/WebInspectorUI
Lazy load source code referred to from the source map, instead of when
the source code is revealed in the Resources sidebar.
https://bugs.webkit.org/show_bug.cgi?id=130625
Reviewed by Joseph Pecoraro.
- UserInterface/Models/SourceMapResource.js:
(WebInspector.SourceMapResource): Set up the type info here so it can be used to
dispaly the right icon in the sidebar.
(WebInspector.SourceMapResource.prototype.canRequestContentFromBackend): Use _contentRequested.
(WebInspector.SourceMapResource.prototype.requestContentFromBackend.sourceMapResourceLoaded):
Reset finished and remove the type change dance we had before.
- UserInterface/Views/SourceMapResourceTreeElement.js:
(WebInspector.SourceMapResourceTreeElement.prototype.onattach): Removed. Don't request content here.
- 1:51 PM Changeset in webkit [166189] by
-
- 2 edits in trunk/Tools
Fix prepare-ChangeLog after r166156.
https://bugs.webkit.org/show_bug.cgi?id=130674
Reviewed by Darin Adler.
- Scripts/prepare-ChangeLog:
(generateFunctionLists):
(extractLineRangeBeforeChange):
- 1:51 PM Changeset in webkit [166188] by
-
- 3 edits in trunk/Source/WebKit2
[iOS][WK2] Micro-optimize view state updates on the UIProcess side
https://bugs.webkit.org/show_bug.cgi?id=130631
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-03-24
Reviewed by Darin Adler.
- UIProcess/API/Cocoa/WKWebView.mm:
(contentZoomScale):
[UIScrollView zoomScale] is not fast enough for -[WKWebView _updateVisibleContentRects]. Since we know what the zoom view is,
make a fast version hardcoding that.
(-[WKWebView _updateScrollViewBackground]):
(-[WKWebView _zoomToPoint:WebCore::atScale:]):
(-[WKWebView _scrollToRect:WebCore::origin:WebCore::minimumScrollDistance:]):
(-[WKWebView _zoomToRect:WebCore::withOrigin:WebCore::fitEntireRect:minimumScale:maximumScale:minimumScrollDistance:]):
(-[WKWebView _updateVisibleContentRects]):
- UIProcess/ios/WKContentView.mm:
(fixedPositionRectFromExposedRect):
(-[WKContentView didUpdateVisibleRect:unobscuredRect:scale:inStableState:]):
- 1:29 PM Changeset in webkit [166187] by
-
- 2 edits in trunk/Source/WebKit2
Remove WebGL asset entitlement
https://bugs.webkit.org/show_bug.cgi?id=130685
Reviewed by Simon Fraser.
No longer necessary on iOS.
- Configurations/WebContent-iOS.entitlements:
- 12:44 PM Changeset in webkit [166186] by
-
- 15 edits5 copies2 adds in trunk
[iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
https://bugs.webkit.org/show_bug.cgi?id=129322
Reviewed by Anders Carlsson.
Source/WebCore:
- platform/network/ResourceHandle.h:
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::releaseConnectionForDownload): Changed to
return a RetainPtr that adopts the connection's retain count.
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::convertMainResourceLoadToDownload): Use the
RetainPtr returned by releaseConnectionForDownload() rather than
manually releasing.
Source/WebKit2:
Based on an original patch by Yongjun Zhang <yongjun_zhang@apple.com>.
- Shared/Cocoa/APIObject.mm:
(API::Object::newObject):
- Shared/Downloads/ios/DownloadIOS.mm:
(WebKit::dispatchOnMainThread):
(WebKit::toDownload):
(WebKit::setUpDownloadClient):
(WebKit::Download::startWithHandle):
- UIProcess/API/APIDownloadClient.h:
(API::DownloadClient::~DownloadClient):
- UIProcess/API/C/WKContext.cpp:
(WKContextSetDownloadClient):
- UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _downloadDelegate]):
(-[WKProcessPool _setDownloadDelegate:]):
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
- UIProcess/API/Cocoa/_WKDownload.h: Added.
- UIProcess/API/Cocoa/_WKDownload.mm: Added.
(WebKit::wrapper):
(WebKit::createAPIDownloadClient):
(-[_WKDownload dealloc]):
(-[_WKDownload API::]):
- UIProcess/API/Cocoa/_WKDownloadDelegate.h: Added.
- UIProcess/API/Cocoa/_WKDownloadInternal.h: Added.
- UIProcess/Cocoa/DownloadClient.h: Added.
- UIProcess/Cocoa/DownloadClient.mm: Added.
- WebKit2.xcodeproj/project.pbxproj:
Tools:
Add an API test suite for _WKDownload.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
(-[DownloadDelegate initWithSourceURL:]):
(-[DownloadDelegate sourceURL]):
(-[DownloadDelegate _downloadDidStart:]):
(-[DownloadDelegate _download:didReceiveResponse:]):
(-[DownloadDelegate _download:didReceiveData:]):
(-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
(-[DownloadDelegate _downloadDidFinish:]):
(TEST):
(runTestWithNavigationDelegate):
(-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
(-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
- 12:31 PM Changeset in webkit [166185] by
-
- 2 edits in trunk/Source/WTF
Add support for thread QoS
https://bugs.webkit.org/show_bug.cgi?id=130688
Speculative EFL build fix.
- wtf/ThreadingPthreads.cpp:
(WTF::setCurrentThreadQOSUtility):
- 12:25 PM Changeset in webkit [166184] by
-
- 7 edits in trunk/Source
Add support for thread QoS
https://bugs.webkit.org/show_bug.cgi?id=130688
Reviewed by Andreas Kling.
Source/JavaScriptCore:
- heap/BlockAllocator.cpp:
(JSC::BlockAllocator::blockFreeingThreadStartFunc):
- block freeing is a utility activity.
Source/WTF:
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::runScavengerThread):
- block freeing is a utility activity.
- wtf/Threading.h:
- declaration.
- wtf/ThreadingPthreads.cpp:
(WTF::createThreadInternal):
- default to interactive.
(WTF::setCurrentThreadQOSUtility):
- implementation.
- wtf/ThreadingWin.cpp:
(WTF::setCurrentThreadQOSUtility):
- no-op implementation.
- 11:58 AM Changeset in webkit [166183] by
-
- 3 edits in trunk/LayoutTests
<hr> should expose AXRole/AXSubrole, etc
https://bugs.webkit.org/show_bug.cgi?id=109015
Unreviewed. Update tests for ML platform.
- platform/mac-mountainlion/accessibility/lists-expected.txt:
- platform/mac-mountainlion/accessibility/roles-exposed-expected.txt:
- 11:56 AM Changeset in webkit [166182] by
-
- 2 edits in trunk/Source/WebCore
Update Hindi fallback font.
https://bugs.webkit.org/show_bug.cgi?id=130690
<rdar://problem/16391601>
Reviewed by Sam Weinig.
Using the new available font for Hindi in the fallback list.
- platform/graphics/ios/FontCacheIOS.mm:
(WebCore::FontCache::systemFallbackForCharacters):
- 10:51 AM Changeset in webkit [166181] by
-
- 2 edits in branches/safari-537.75-branch/Source/WebCore
Remove a commented line of code introduced by r166104.
- 10:38 AM Changeset in webkit [166180] by
-
- 6 edits in trunk/Source/WebCore
Merge Minor WebVTT Cleanups from Blink
https://bugs.webkit.org/show_bug.cgi?id=130681
Reviewed by Eric Carlson.
Merged from Blink (patch by philipj@opera.com):
https://chromium.googlesource.com/chromium/blink/+/693eb5e2933dca0eab5bbd604e9f3406fe9fd1ab
http://crbug.com/52593009
https://chromium.googlesource.com/chromium/blink/+/40b3602feab34e9be829fd742b6ad6ded322a09f
http://crbug.com/104243003
- html/track/TextTrack.cpp:
(WebCore::TextTrack::setMode):
- html/track/TextTrack.idl:
- html/track/TextTrackCue.h:
- html/track/VTTCue.cpp:
(WebCore::VTTCue::VTTCue):
- html/track/VTTCue.h:
- 10:37 AM Changeset in webkit [166179] by
-
- 12 edits5 deletes in trunk/Source/WebCore
Unreviewed, rolling out r166169.
https://bugs.webkit.org/show_bug.cgi?id=130682
This patch broke tests on Apple Mavericks (Requested by fredw
on #webkit).
Reverted changeset:
"Operator stretching: expose a math data API"
https://bugs.webkit.org/show_bug.cgi?id=130572
http://trac.webkit.org/changeset/166169
Patch by Commit Queue <commit-queue@webkit.org> on 2014-03-24
- 10:29 AM Changeset in webkit [166178] by
-
- 4 edits in trunk/Source/JavaScriptCore
Unreviewed, fix CLOOP build.
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFor):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::getCallLinkInfoForBytecodeIndex):
(JSC::CodeBlock::resetStubDuringGCInternal): Deleted.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::callLinkInfosEnd): Deleted.
- 10:21 AM Changeset in webkit [166177] by
-
- 2 edits in trunk/Tools
filter-build-webkit: reduce unfiltered output
https://bugs.webkit.org/show_bug.cgi?id=130485
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-03-24
Reviewed by Brent Fulgham.
- Scripts/filter-build-webkit:
(shouldIgnoreLine):
- 10:13 AM Changeset in webkit [166176] by
-
- 3 edits in trunk/Source/WebCore
ENABLE(CSS_GRID_LAYOUT) guard for CSSGridLineNamesValue
https://bugs.webkit.org/show_bug.cgi?id=130669
Patch by Martin Hodovan <mhodovan@inf.u-szeged.hu> on 2014-03-24
Reviewed by Sergio Villar Senin.
No new tests. No new functionality.
- css/CSSGridLineNamesValue.cpp:
- css/CSSGridLineNamesValue.h:
- 10:08 AM Changeset in webkit [166175] by
-
- 16 edits2 adds in trunk
<hr> should expose AXRole/AXSubrole, etc
https://bugs.webkit.org/show_bug.cgi?id=109015
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Expose the <hr> element to Mac and iOS through the accessibility interface.
Test: platform/mac/accessibility/hr-element.html
- English.lproj/Localizable.strings:
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isEnabled):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::computedRoleString):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
- accessibility/atk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
(-[WebAccessibilityObjectWrapper accessibilityLabel]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):
- platform/LocalizedStrings.cpp:
(WebCore::AXHorizontalRuleDescriptionText):
- platform/LocalizedStrings.h:
LayoutTests:
- accessibility/lists.html:
- An errant <hr> element was in this test which changed results
- accessibility/roles-computedRoleString-expected.txt:
- accessibility/roles-exposed.html:
- platform/gtk/accessibility/roles-exposed-expected.txt: Added.
- platform/mac/accessibility/hr-element-expected.txt: Added.
- platform/mac/accessibility/hr-element.html: Added.
- platform/mac/accessibility/lists-expected.txt:
- platform/mac/accessibility/roles-exposed-expected.txt:
- 9:52 AM Changeset in webkit [166174] by
-
- 4 edits in trunk/LayoutTests
Invalidate sibling text node style when needed instead of attaching synchronously
https://bugs.webkit.org/show_bug.cgi?id=130590
Reviewed by Andreas Kling.
Minor non-observable whitespace changes.
- fast/forms/select-listbox-focus-displaynone-expected.txt:
- fast/repaint/text-in-relative-positioned-inline-expected.txt:
- 9:49 AM Changeset in webkit [166173] by
-
- 2 edits in trunk/Source/WebCore
Invalidate sibling text node style when needed instead of attaching synchronously
https://bugs.webkit.org/show_bug.cgi?id=130590
Reviewed by Andreas Kling.
Make things simpler.
- style/StyleResolveTree.cpp:
(WebCore::Style::invalidateWhitespaceOnlyTextSiblingsAfterAttachIfNeeded):
Just invalidate instead of calling attach directly.
Rename to match.
(WebCore::Style::textRendererIsNeeded):
(WebCore::Style::createTextRendererIfNeeded):
Move all testing to textRendererIsNeeded.
(WebCore::Style::updateTextRendererAfterContentChange):
Call resolveTextNode instead of re-implementing the same thing.
(WebCore::Style::resolveLocal):
(WebCore::Style::resolveTextNode):
Avoid unnecessary reattaching.
Rename for consistency.
(WebCore::Style::resolveShadowTree):
(WebCore::Style::resolveTree):
- 9:35 AM Changeset in webkit [166172] by
-
- 4 edits in trunk/Source/WebCore
Fix !ENABLE(VIDEO) build
https://bugs.webkit.org/show_bug.cgi?id=130671
Patch by Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com> on 2014-03-24
Reviewed by Eric Carlson.
Add missing ENABLE(VIDEO) guards because many functions use
the newly guarded functions.
- testing/Internals.cpp:
- testing/Internals.h:
- testing/Internals.idl:
- 9:30 AM Changeset in webkit [166171] by
-
- 5 edits in trunk/Source/WebCore
Text autosizing does not determine line count correctly for simple line layout
https://bugs.webkit.org/show_bug.cgi?id=130673
Reviewed by Daniel Bates.
We don't count lines correctly in simple line layout case.
- page/Frame.cpp:
(WebCore::Frame::textAutosizingWidth):
(WebCore::Frame::setTextAutosizingWidth):
- page/ios/FrameIOS.mm:
(WebCore::Frame::textAutosizingWidth): Deleted.
(WebCore::Frame::setTextAutosizingWidth): Deleted.
Move to Frame.cpp to make enabling on non-iOS build easier.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::lineCount):
Handle simple line layout case.
(WebCore::RenderBlockFlow::lineCountForTextAutosizing):
Call lineCount() if children are inline.
Rename for clarity.
(WebCore::RenderBlockFlow::adjustComputedFontSizes):
(WebCore::RenderBlockFlow::immediateLineCount): Deleted.
- rendering/RenderBlockFlow.h:
- 9:27 AM Changeset in webkit [166170] by
-
- 3 edits2 adds in trunk
[regression] background colors do not apply to <mo> elements.
https://bugs.webkit.org/show_bug.cgi?id=130470.
Source/WebCore:
Test: mathml/presentation/tokenElements-background-color.html
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::paint): always call the parent painting to draw the background.
(WebCore::RenderMathMLOperator::paintChildren): move the special case for invisible operator here.
LayoutTests:
- mathml/presentation/tokenElements-background-color.html: Added.
- mathml/presentation/tokenElements-background-color-expected.html: Added.
- 9:20 AM Changeset in webkit [166169] by
-
- 12 edits3 copies2 adds in trunk/Source/WebCore
Operator stretching: expose a math data API
https://bugs.webkit.org/show_bug.cgi?id=130572
Reviewed by Chris Fleizach.
We expose a new SimpleFontData API to give access to the data from the
OpenType MATH table using a font cache. The class OpenTypeMathData will
be implemented in bug 130324. On Darwin platform, we also implement the
missing FontPlatformData::openTypeTable function which will be necessary
to load the OpenType MATH table. The changes are intended to be used
for MathML operator stretching (bug 130322) so tests are not added yet.
- CMakeLists.txt: add new OpenTypeMathData files.
- GNUmakefile.list.am: ditto.
- WebCore.vcxproj/WebCore.vcxproj: ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: ditto.
- WebCore.xcodeproj/project.pbxproj: ditto.
- platform/graphics/FontCache.cpp: We add a FontCache::getMathData function to implement a cache for the math data.
We make the math and vertical data share the same key for the cache.
(WebCore::fontMathDataCacheInstance):
(WebCore::FontCache::getMathData):
(WebCore::fontVerticalDataCacheInstance):
- platform/graphics/FontCache.h: We declare FontCache::getMathData and FontFileKey on all platforms.
- platform/graphics/FontPlatformData.cpp:
(WebCore::FontPlatformData::openTypeTable): We implement openTypeTable() on Darwin platform.
- platform/graphics/FontPlatformData.h: We expose openTypeTable() on Darwin platform.
- platform/graphics/SimpleFontData.cpp: We initialize m_mathData from the font cache.
(WebCore::SimpleFontData::SimpleFontData):
- platform/graphics/SimpleFontData.h: We expose a mathData() function to access the MATH data.
- platform/graphics/opentype/OpenTypeMathData.cpp: Added. This is a new class that will be used to parse the data from the OpenType MATH table.
(WebCore::OpenTypeMathData::OpenTypeMathData):
- platform/graphics/opentype/OpenTypeMathData.h: Added.
(WebCore::OpenTypeMathData::create):
(WebCore::OpenTypeMathData::hasMathData):
- 9:09 AM Changeset in webkit [166168] by
-
- 4 edits in trunk/Source
Build fixes.
Unreviewed.
Source/WebCore:
- editing/ios/EditorIOS.mm:
(WebCore::Editor::writeSelectionToPasteboard): Convert to reference.
Source/WebKit/mac:
- WebInspector/WebNodeHighlightView.mm: Missing include to GeometryUtilities.
- 8:27 AM Changeset in webkit [166167] by
-
- 2 edits in trunk/Source/WebCore
ENABLE(VIDEO_TRACK) guard for CSSParserSelector::parsePseudoCueFunctionSelector
https://bugs.webkit.org/show_bug.cgi?id=130666
Patch by Martin Hodovan <mhodovan@inf.u-szeged.hu> on 2014-03-24
Reviewed by Andreas Kling.
No new tests. No new functionality.
- css/CSSParserValues.cpp:
(WebCore::CSSParserSelector::parsePseudoCueFunctionSelector): Deleted.
- 8:24 AM Changeset in webkit [166166] by
-
- 2 edits in trunk/Source/JavaScriptCore
[ARM64] GNU assembler doesn't work with LLInt arm64 backend.
https://bugs.webkit.org/show_bug.cgi?id=130453
Reviewed by Filip Pizlo.
Change fp and lr to x29 and x30. Add both operand kinds to emitARM64()
at sxtw and uxtw instructions.
- offlineasm/arm64.rb:
- 6:46 AM Changeset in webkit [166165] by
-
- 1 copy in releases/WebKitGTK/webkit-2.4.0
Tagging the WebKitGTK+ 2.4.0 release
- 5:03 AM Changeset in webkit [166164] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening
Add test expectations for failing tests. Skip crashing http tests.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 4:50 AM Changeset in webkit [166163] by
-
- 4 edits in releases/WebKitGTK/webkit-2.4
Unreviewed. Update NEWS and Versions.m4 for 2.4.0 release.
.:
- Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Added release notes for 2.4.0.
- 4:39 AM Changeset in webkit [166162] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Buildfix after r166159.
Patch by Dániel Bátyai <Dániel Bátyai> on 2014-03-24
Reviewed by Csaba Osztrogonác.
- UIProcess/API/efl/ewk_settings.cpp:
(ewk_settings_file_access_from_file_urls_allowed_set):
(ewk_settings_file_access_from_file_urls_allowed_get):
- 4:01 AM Changeset in webkit [166161] by
-
- 4 edits in releases/WebKitGTK/webkit-2.4
Unreviewed. Race condition when closing pages with network process enabled
https://bugs.webkit.org/show_bug.cgi?id=129684
Source/WebKit2:
When the last page of a web process is closed with the network
process enabled, the UI process checks if the web process can be
terminated and closes the connection with that web process. But
right before that the Close message has been sent which also
enables the process termination in the web process. Sometimes
there's a race condition in the web process between the process
termination triggered by the Close message and the one triggered
by the socket being closed by the UI process.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::shouldTerminate): Use a 1 second timeout so
that if the message is sent right the before the connection is
closed, we don't wait indefinitely for the sync reply keeping the
web process alive.
Tools:
Enable the test to check that web processes finish when the web
view is destroyed.
- TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
- 3:15 AM Changeset in webkit [166160] by
-
- 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2
Merge r166158 - [GTK][WK2] Guard NetscapePluginModule methods used in PluginInfoCache that are specific to X11 architecture
https://bugs.webkit.org/show_bug.cgi?id=130663
Reviewed by Carlos Garcia Campos.
The two used methods are specific to the X11 plugin architecture and are not declared when building for a
Wayland-only configuration. Guarding them prevents build failures, but does not ensure proper functionality
which isn't a problem anyway since there's no support yet for Netscape plugins on Wayland.
- UIProcess/Plugins/gtk/PluginInfoCache.cpp:
(WebKit::PluginInfoCache::getPluginInfo): Guard NetscapePluginModule::parseMIMEDescription with PLUGIN_ARCHITECTURE(X11).
(WebKit::PluginInfoCache::updatePluginInfo): Ditto for NetscapePluginModule::buildMIMEDescription.
- 3:09 AM Changeset in webkit [166159] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2] Use C API inside ewk_settings
https://bugs.webkit.org/show_bug.cgi?id=107820
Reviewed by Gyuyoung Kim.
Use C API inside ewk_settings instead of accessing directly
internal C++ classes, to avoid violating API layering.
Original-author: Christophe Dumez <Christophe Dumez>
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
- UIProcess/API/efl/ewk_settings.cpp:
(ewk_settings_fullscreen_enabled_set):
(ewk_settings_fullscreen_enabled_get):
(ewk_settings_javascript_enabled_set):
(ewk_settings_javascript_enabled_get):
(ewk_settings_loads_images_automatically_set):
(ewk_settings_loads_images_automatically_get):
(ewk_settings_developer_extras_enabled_set):
(ewk_settings_developer_extras_enabled_get):
(ewk_settings_file_access_from_file_urls_allowed_set):
(ewk_settings_file_access_from_file_urls_allowed_get):
(ewk_settings_frame_flattening_enabled_set):
(ewk_settings_frame_flattening_enabled_get):
(ewk_settings_dns_prefetching_enabled_set):
(ewk_settings_dns_prefetching_enabled_get):
(ewk_settings_encoding_detector_enabled_set):
(ewk_settings_encoding_detector_enabled_get):
(ewk_settings_preferred_minimum_contents_width_set):
(ewk_settings_preferred_minimum_contents_width_get):
(ewk_settings_offline_web_application_cache_enabled_set):
(ewk_settings_offline_web_application_cache_enabled_get):
(ewk_settings_scripts_can_open_windows_set):
(ewk_settings_scripts_can_open_windows_get):
(ewk_settings_local_storage_enabled_set):
(ewk_settings_local_storage_enabled_get):
(ewk_settings_plugins_enabled_set):
(ewk_settings_plugins_enabled_get):
(ewk_settings_default_font_size_set):
(ewk_settings_default_font_size_get):
(ewk_settings_private_browsing_enabled_set):
(ewk_settings_private_browsing_enabled_get):
(ewk_settings_text_autosizing_enabled_set):
(ewk_settings_text_autosizing_enabled_get):
(ewk_settings_spatial_navigation_enabled_set):
(ewk_settings_spatial_navigation_enabled_get):
(EwkSettings::setDefaultTextEncodingName):
- UIProcess/API/efl/ewk_settings_private.h:
(EwkSettings::EwkSettings):
(EwkSettings::preferences):
- 3:03 AM Changeset in webkit [166158] by
-
- 2 edits in trunk/Source/WebKit2
[GTK][WK2] Guard NetscapePluginModule methods used in PluginInfoCache that are specific to X11 architecture
https://bugs.webkit.org/show_bug.cgi?id=130663
Reviewed by Carlos Garcia Campos.
The two used methods are specific to the X11 plugin architecture and are not declared when building for a
Wayland-only configuration. Guarding them prevents build failures, but does not ensure proper functionality
which isn't a problem anyway since there's no support yet for Netscape plugins on Wayland.
- UIProcess/Plugins/gtk/PluginInfoCache.cpp:
(WebKit::PluginInfoCache::getPluginInfo): Guard NetscapePluginModule::parseMIMEDescription with PLUGIN_ARCHITECTURE(X11).
(WebKit::PluginInfoCache::updatePluginInfo): Ditto for NetscapePluginModule::buildMIMEDescription.
- 2:42 AM Changeset in webkit [166157] by
-
- 36 edits2 adds in trunk
[CSS Grid Layout] Update named <grid-line> syntax to the last version of the specs
https://bugs.webkit.org/show_bug.cgi?id=129041
Patch by Javier Fernandez <jfernandez@igalia.com> on 2014-03-24
Reviewed by Sergio Villar Senin.
From Blink r162555 by <svillar@igalia.com>
Source/WebCore:
Names for grid lines are now specified as a list of whitespace separated
idents enclosed in parentheses instead of as a list of strings.
Updated tests to match the new <grid-line> syntax.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj: Added info of the new file for the CSSGridLineNamesValue class.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::addValuesForNamedGridLinesAtIndex): The named <grid-line> value is now a list.
- css/CSSGrammar.y.in: New syntax for named <grid-line>.
- css/CSSGridLineNamesValue.cpp: Added.
(WebCore::CSSGridLineNamesValue::customCSSText): String representation of the named <grid-line> as a list of Strings.
(WebCore::CSSGridLineNamesValue::CSSGridLineNamesValue): Constructor.
(WebCore::CSSGridLineNamesValue::cloneForCSSOM): Ref counted cloning function.
- css/CSSGridLineNamesValue.h: Added.
(WebCore::CSSGridLineNamesValue::create): Ref counted constructor.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseGridLineNames): It replaces the old parseGrdTrackNames.
(WebCore::CSSParser::parseGridTrackList): Using the new named <grid-line> syntax.
(WebCore::CSSParser::parseGridTrackRepeatFunction): Using the new named <grid-line> syntax.
- css/CSSParser.h:
- css/CSSParserValues.cpp:
(WebCore::destroy): Handling the case of CSSValue being CSSValueList intances.
(WebCore::CSSParserValue::createCSSValue): Handling the case of CSSValue being CSSValueList intances.
- css/CSSParserValues.h:
(WebCore::CSSParserValue::setFromValueList): Adds the named <grid-line> list to the CSSParserValueList instance.
- css/CSSValue.cpp:
(WebCore::CSSValue::equals): Handling the case of the new CSSGridLineNamesValue class.
(WebCore::CSSValue::cssText): Handling the case of the new CSSGridLineNamesValue class.
(WebCore::CSSValue::destroy): Handling the case of the new CSSGridLineNamesValue class.
- css/CSSValue.h:
(WebCore::CSSValue::isGridLineNamesValue): Type cast check for the new CSSGridLineNamesValue class.
- css/StyleResolver.cpp:
(WebCore::createGridTrackList): Using the new named <grid-line> syntax.
LayoutTests:
Updated tests to match the new <grid-line> syntax.
- fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
- fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
- fast/css-grid-layout/grid-element-repeat-get-set-expected.txt:
- fast/css-grid-layout/grid-element-repeat-get-set.html:
- fast/css-grid-layout/grid-item-bad-resolution-double-span.html:
- fast/css-grid-layout/grid-item-named-grid-area-resolution.html:
- fast/css-grid-layout/grid-item-named-grid-line-resolution.html:
- fast/css-grid-layout/grid-item-negative-position-resolution.html:
- fast/css-grid-layout/grid-item-position-changed-dynamic.html:
- fast/css-grid-layout/named-grid-line-get-set-expected.txt:
- fast/css-grid-layout/named-grid-line-get-set.html:
- fast/css-grid-layout/named-grid-lines-with-named-grid-areas-resolution.html:
- fast/css-grid-layout/non-grid-columns-rows-get-set-expected.txt:
- fast/css-grid-layout/non-grid-columns-rows-get-set-multiple-expected.txt:
- fast/css-grid-layout/non-grid-element-repeat-get-set-expected.txt:
- fast/css-grid-layout/non-grid-element-repeat-get-set.html:
- fast/css-grid-layout/non-named-grid-line-get-set-expected.txt:
- fast/css-grid-layout/non-named-grid-line-get-set.html:
- fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:
(testInherit):
(testInitial):
- fast/css-grid-layout/resources/grid-columns-rows-get-set.js:
(testInherit):
(testInitial):
- fast/css-grid-layout/resources/non-grid-columns-rows-get-set-multiple.js:
(testInherit):
(testInitial):
- fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js:
(testInherit):
(testInitial):
- 2:27 AM Changeset in webkit [166156] by
-
- 2 edits in trunk/Tools
prepare-ChangeLog should list functions that have been removed too.
https://bugs.webkit.org/show_bug.cgi?id=130508
Reviewed by Darin Adler.
The prepare-ChangeLog does not list the deleted functions in the Changelog.
We have to read the functions and the line ranges of them from the source
before the change, then search for overlaps between them and the changed
line ranges from diff.
- Scripts/prepare-ChangeLog:
(originalFile): Get original source command.
(generateFunctionLists): Collect deleted functions too.
(generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
(extractLineRangeBeforeChange): Extract line ranges from the original source to get
deleted functions ranges too.
(extractLineRange): Renamed to extractLineRangeAfterChange.
- 2:21 AM Changeset in webkit [166155] by
-
- 8 edits in trunk/Source/WebKit2
[EFL][WK2] Convert some more OwnPtr/PassOwnPtr to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=130662
Reviewed by Gyuyoung Kim.
Replace uses of PassOwnPtr/OwnPtr with std::unique_ptr in remained WebKit2/Efl specific code.
- UIProcess/API/efl/EwkView.h:
- UIProcess/API/efl/ewk_cookie_manager.cpp:
- UIProcess/API/efl/ewk_database_manager.cpp:
(getDatabaseOriginsCallback):
- UIProcess/API/efl/ewk_error_private.h:
- UIProcess/efl/DownloadManagerEfl.cpp:
(WebKit::DownloadManagerEfl::didFail):
- UIProcess/efl/InputMethodContextEfl.h:
(WebKit::InputMethodContextEfl::create):
- UIProcess/efl/PageLoadClientEfl.cpp:
(WebKit::PageLoadClientEfl::didFailLoadWithErrorForFrame):
(WebKit::PageLoadClientEfl::didFailProvisionalLoadWithErrorForFrame):
- 2:21 AM Changeset in webkit [166154] by
-
- 2 edits in trunk/LayoutTests
[EFL] Add expectations for flaky perf layout test.
https://bugs.webkit.org/show_bug.cgi?id=130584
Unreviewed EFL gardening.
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2014-03-24
- platform/efl/TestExpectations:
- 2:19 AM Changeset in webkit [166153] by
-
- 2 edits in trunk/LayoutTests
[EFL] Add expectations for flaky webgl layout test.
https://bugs.webkit.org/show_bug.cgi?id=130587
Unreviewed EFL gardening.
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2014-03-24
- platform/efl/TestExpectations:
- 2:10 AM Changeset in webkit [166152] by
-
- 2 edits in trunk
[EFL] Inspector page is not loaded.
https://bugs.webkit.org/show_bug.cgi?id=130661
Patch by Sangyong Park <sy302.park@gmail.com> on 2014-03-24
Reviewed by Gyuyoung Kim.
Inspector page is not loaded, because some javascript files are not installed.
(InspectorJSBackendCommands.js, InspectorWebBackendCommands.js)
- Source/PlatformEfl.cmake:
