⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 27, 2014:

11:24 PM Changeset in webkit [166400] by psolanki@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS WebKit2] Tweak cache sizes for iOS
​https://bugs.webkit.org/show_bug.cgi?id=130871

Reviewed by Sam Weinig.

Bring over the tweaks we had made to memory cache size for WebKit1 on iOS to WebKit2. These
were made per findings in <rdar://8611638>.

  • Shared/CacheModel.cpp:

(WebKit::calculateCacheSizes):

11:21 PM Changeset in webkit [166399] by jinwoo7.song@samsung.com
  • 2 edits in trunk/Source/WebKit2

[WK2][EFL] Fix wrong parameter name in ewk_view_user_agent_set()
​https://bugs.webkit.org/show_bug.cgi?id=130888

Reviewed by Gyuyoung Kim.

  • UIProcess/API/efl/ewk_view.h:
11:00 PM Changeset in webkit [166398] by commit-queue@webkit.org
  • 12 edits in trunk

Web Inspector: AXI: expose selectedChildNodeIds of list boxes, tree controls, etc., and reconcile UI with childNodeIds
​https://bugs.webkit.org/show_bug.cgi?id=130827

Patch by James Craig <​jcraig@apple.com> on 2014-03-27
Reviewed by Timothy Hatcher.

Source/WebCore:

Test: inspector-protocol/dom/getAccessibilityPropertiesForNode.html

Support for selectedChildNodeIds in inspector-protocol: DOM.getAccessibilityPropertiesForNode.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):

  • inspector/protocol/DOM.json:

Source/WebInspectorUI:

UI updates for "Selected Item(s)" and "Child(ren)" rows in accessibility node inspector.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Models/DOMNode.js:
  • UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

Websites/webkit.org:

Updated demo files with attr refresh to show off selected children changing.
Long term fix will be ​http://webkit.org/b/130883

  • blog-files/aria1.0/combobox_with_live_region_status.html:

LayoutTests:

Tests selectedChildNodeIds in inspector-protocol: DOM.getAccessibilityPropertiesForNode.

  • inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt:
  • inspector-protocol/dom/getAccessibilityPropertiesForNode.html:
10:28 PM Changeset in webkit [166397] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r166376.
​https://bugs.webkit.org/show_bug.cgi?id=130887

This was a misguided optimization. (Requested by kling on
#webkit).

Reverted changeset:

"Avoid fetching JSObject::structure() repeatedly in
putDirectInternal."
​https://bugs.webkit.org/show_bug.cgi?id=130857
​http://trac.webkit.org/changeset/166376

9:06 PM Changeset in webkit [166396] by mrowe@apple.com
  • 6 edits in trunk

<​https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information

Tools:

Provide an implementation of WKContextHistoryClient that logs when called for tests in
the globalhistory directory.

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2014-03-27
Reviewed by Sam Weinig.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::initialize): Set the history client.
(WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
(WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
and we don't yet have API to access the data in question.
(WTR::TestController::didPerformClientRedirect):
(WTR::TestController::didPerformServerRedirect):
(WTR::TestController::didUpdateHistoryTitle):

  • WebKitTestRunner/TestController.h:

(WTR::TestController::setShouldLogHistoryClientCallbacks):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
(WTR::TestInvocation::invoke):

LayoutTests:

Reviewed by Sam Weinig.

  • platform/wk2/TestExpectations: Enable the two layout tests that pass. One test remains disabled

due to lack of testRunner API, and another due to an apparent bug in WebKit2's handling of
client redirects.

8:52 PM Changeset in webkit [166395] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

Specify Shadow DOM Pseudo IDs in Media Element Constructors
​https://bugs.webkit.org/show_bug.cgi?id=130882

Reviewed by Eric Carlson.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::MediaControlPanelElement): Call setPseudoId in constructor.
(WebCore::MediaControlPanelEnclosureElement::MediaControlPanelEnclosureElement): Ditto.
(WebCore::MediaControlTimelineContainerElement::MediaControlTimelineContainerElement): Ditto.
(WebCore::MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement): Ditto.
(WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement): Ditto.
(WebCore::MediaControlPanelMuteButtonElement::MediaControlPanelMuteButtonElement): Ditto.
(WebCore::MediaControlVolumeSliderMuteButtonElement::MediaControlVolumeSliderMuteButtonElement): Ditto.
(WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement): Ditto.
(WebCore::MediaControlOverlayPlayButtonElement::MediaControlOverlayPlayButtonElement): Ditto.
(WebCore::MediaControlSeekForwardButtonElement::MediaControlSeekForwardButtonElement): Ditto.
(WebCore::MediaControlSeekBackButtonElement::MediaControlSeekBackButtonElement): Ditto.
(WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement): Ditto.
(WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement): Ditto.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement): Ditto.
(WebCore::MediaControlClosedCaptionsContainerElement::MediaControlClosedCaptionsContainerElement): Ditto.
(WebCore::MediaControlClosedCaptionsTrackListElement::MediaControlClosedCaptionsTrackListElement): Ditto.
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement): Ditto.
(WebCore::MediaControlPanelVolumeSliderElement::MediaControlPanelVolumeSliderElement): Ditto.
(WebCore::MediaControlFullscreenVolumeSliderElement::MediaControlFullscreenVolumeSliderElement): Ditto.
(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement): Ditto.
(WebCore::MediaControlFullscreenVolumeMinButtonElement::MediaControlFullscreenVolumeMinButtonElement): Ditto.
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::MediaControlFullscreenVolumeMaxButtonElement): Ditto.
(WebCore::MediaControlTimeRemainingDisplayElement::MediaControlTimeRemainingDisplayElement): Ditto.
(WebCore::MediaControlCurrentTimeDisplayElement::MediaControlCurrentTimeDisplayElement): Ditto.
(WebCore::MediaControlTextTrackContainerElement::MediaControlTextTrackContainerElement): Ditto.

8:50 PM Changeset in webkit [166394] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

[iOS][WK2] Adjust the tile coverage on the scrollview's edges
​https://bugs.webkit.org/show_bug.cgi?id=130884

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-03-27
Reviewed by Dan Bernstein.

  • platform/ios/ScrollViewIOS.mm:

(WebCore::ScrollView::computeCoverageRect):
Pull back the future rect inside the contentRect if it goes outside.
There is no point in retiling for rubberbanding and the extra tiles should be always be
on the opposite side to the edges.

7:46 PM Changeset in webkit [166393] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove unused LocaleMac::create method
​https://bugs.webkit.org/show_bug.cgi?id=130870

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-03-27
Reviewed by Andreas Kling.

  • platform/text/mac/LocaleMac.h:
  • platform/text/mac/LocaleMac.mm:

(WebCore::LocaleMac::create): Deleted.
(WebCore::LocaleMac::shortDateFormatter): Deleted.

6:10 PM Changeset in webkit [166392] by oliver@apple.com
  • 20 edits
    6 adds in trunk

Support spread operand in |new| expressions
​https://bugs.webkit.org/show_bug.cgi?id=130877

Reviewed by Michael Saboff.

Source/JavaScriptCore:

Add support for the spread operator being applied in
|new| expressions. This required adding support for
a new opcode, op_construct_varargs. This is a relatively
simple refactoring of the call_varargs implementation.

  • bytecode/BytecodeList.json:
  • bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

  • bytecode/CallLinkInfo.cpp:

(JSC::CallLinkInfo::unlink):

  • bytecode/CallLinkInfo.h:

(JSC::CallLinkInfo::callTypeFor):
(JSC::CallLinkInfo::specializationKind):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitConstructVarargs):
(JSC::BytecodeGenerator::emitConstruct):

  • bytecompiler/BytecodeGenerator.h:
  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:
  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::emit_op_construct_varargs):
(JSC::JIT::emitSlow_op_construct_varargs):

  • jit/JITCall32_64.cpp:

(JSC::JIT::emitSlow_op_construct_varargs):
(JSC::JIT::emit_op_construct_varargs):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):

  • jit/JITOperations.cpp:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LLIntSlowPaths.h:
  • llint/LowLevelInterpreter.asm:
  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseMemberExpression):

LayoutTests:

Correctness and performance tests for spread operands

  • js/parser-syntax-check-expected.txt:
  • js/regress/call-spread-expected.txt: Added.
  • js/regress/call-spread.html: Added.
  • js/regress/new-spread-expected.txt: Added.
  • js/regress/new-spread.html: Added.
  • js/regress/script-tests/call-spread.js: Added.

(testFunction):
(test2):
(test3):

  • js/regress/script-tests/new-spread.js: Added.

(testFunction):
(test2):
(test3):

  • js/script-tests/parser-syntax-check.js:
6:00 PM Changeset in webkit [166391] by gyuyoung.kim@samsung.com
  • 4 edits in trunk/Source/WebCore

Clean up unneeded "mutable" keyword
​https://bugs.webkit.org/show_bug.cgi?id=130832

Reviewed by Andreas Kling.

As r166350, this patch cleans up unneeded "mutable" keywords.
Additionally, m_validatedSelectionCache is removed because it is not used anywhere else.

  • css/CSSFontFaceRule.h:
  • css/CSSStyleRule.h:
  • editing/FrameSelection.h:
5:51 PM Changeset in webkit [166390] by fpizlo@apple.com
  • 6 edits in trunk

Revert ​http://trac.webkit.org/changeset/166386 because it broke builds.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:
  • Configurations/LLVMForJSC.xcconfig:

Tools:

  • Scripts/build-webkit:
  • Scripts/copy-webkitlibraries-to-product-directory:
5:48 PM Changeset in webkit [166389] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, skip this test for now.

  • tests/stress/recurse-infinitely-on-getter.js:
5:36 PM Changeset in webkit [166388] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Confirm composition in resignFirstResponder, don't cancel it
​https://bugs.webkit.org/show_bug.cgi?id=130852

Reviewed by Darin Adler.

  • UIProcess/API/mac/WKView.mm: (-[WKView resignFirstResponder]):
5:27 PM Changeset in webkit [166387] by psolanki@apple.com
  • 3 edits in trunk/Source/WebKit2

[iOS WebKit2] Don't pass disk cache directory path on iOS
​https://bugs.webkit.org/show_bug.cgi?id=130862

Reviewed by Sam Weinig.

The diskPath passed to NSURLCache initializer is treated differently on Mac and iOS. Just
pass nil for now until we sort out the API.

  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

4:52 PM Changeset in webkit [166386] by fpizlo@apple.com
  • 6 edits in trunk

Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
​https://bugs.webkit.org/show_bug.cgi?id=130867
<rdar://problem/16432456>

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:
  • Configurations/LLVMForJSC.xcconfig:

Tools:

  • Scripts/build-webkit:
  • Scripts/copy-webkitlibraries-to-product-directory:
4:46 PM Changeset in webkit [166385] by psolanki@apple.com
  • 5 edits
    2 adds in trunk/Source/WebKit2

[iOS WebKit2] Share network process code between iOS and Mac
​https://bugs.webkit.org/show_bug.cgi?id=130861

Reviewed by Sam Weinig.

Implement network process functions for iOS by moving common code from NetworkProcessMac.mm
to a new shared file NetworkProcessCocoa.mm and sharing between iOS and Mac.

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/cocoa/NetworkProcessCocoa.mm: Added.

(WebKit::NetworkProcess::platformLowMemoryHandler):
(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
Common initialization code for iOS and Mac.
(WebKit::memorySize):
(WebKit::volumeFreeSize):
(WebKit::NetworkProcess::platformSetCacheModel):

  • NetworkProcess/ios/NetworkProcessIOS.mm:

(WebKit::NetworkProcess::initializeProcess):
Remove unnecessary #if PLATFORM(IOS).
(WebKit::NetworkProcess::platformInitializeNetworkProcess):

  • NetworkProcess/mac/NetworkProcessMac.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcess):

  • WebKit2.xcodeproj/project.pbxproj:
4:41 PM Changeset in webkit [166384] by enrica@apple.com
  • 28 edits
    2 adds in trunk/Source

Add support for AirPlay picker in WK2 for iOS.
​https://bugs.webkit.org/show_bug.cgi?id=130855
<rdar://problem/15349859>

Source/WebCore:

Reviewed by Eric Carlson, Joseph Pecoraro and Benjamin Poulain.

Adds support in HTMLMediaSession to display the airplay picker
and to monitor presence of available wireless targets.

  • html/HTMLMediaSession.cpp:

(WebCore::HTMLMediaSession::showPlaybackTargetPicker):
(WebCore::HTMLMediaSession::hasWirelessPlaybackTargets):
(WebCore::HTMLMediaSession::setHasPlaybackTargetAvailabilityListeners):

  • loader/EmptyClients.h:
  • page/ChromeClient.h:
  • platform/audio/MediaSessionManager.cpp:

(WebCore::MediaSessionManager::wirelessRoutesAvailableChanged):

  • platform/audio/MediaSessionManager.h:

(WebCore::MediaSessionManager::hasWirelessTargetsAvailable):
(WebCore::MediaSessionManager::startMonitoringAirPlayRoutes):
(WebCore::MediaSessionManager::stopMonitoringAirPlayRoutes):

  • platform/audio/ios/MediaSessionManagerIOS.h:
  • platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::MediaSessionManageriOS::hasWirelessTargetsAvailable):
(WebCore::MediaSessionManageriOS::startMonitoringAirPlayRoutes):
(WebCore::MediaSessionManageriOS::stopMonitoringAirPlayRoutes):
(-[WebMediaSessionHelper initWithCallback:]):
(-[WebMediaSessionHelper hasWirelessTargetsAvailable]):
(-[WebMediaSessionHelper startMonitoringAirPlayRoutes]):
(-[WebMediaSessionHelper stopMonitoringAirPlayRoutes]):
(-[WebMediaSessionHelper wirelessRoutesAvailableDidChange:]):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::wirelessVideoPlaybackDisabled):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setWirelessVideoPlaybackDisabled):

Source/WebKit/ios:

Reviewed by Eric Carlson, Joseph Pecoraro and Benjamin Poulain.

Adds stub for new WebKit chrome client method.

  • WebCoreSupport/WebChromeClientIOS.h:
  • WebCoreSupport/WebChromeClientIOS.mm:

(WebChromeClientIOS::showAirPlayRoutePicker):

Source/WebKit2:

Reviewed by Joseph Pecoraro and Benjamin Poulain.

Adds support to display the airplay picker for iPhone and iPad
in WK2.
The picker on iPad is displayed next to the airplay button.

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::showAirPlayRoutePicker):

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _showAirPlayRoutePicker:fromRect:]):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::showAirPlayRoutePicker):

  • UIProcess/ios/forms/WKAirPlayRoutePicker.h: Added.
  • UIProcess/ios/forms/WKAirPlayRoutePicker.mm: Added.

(-[WKAirPlayRoutePicker initWithView:]):
(-[WKAirPlayRoutePicker dealloc]):
(-[WKAirPlayRoutePicker popoverControllerDidDismissPopover:]):
(-[WKAirPlayRoutePicker _presentAirPlayPopoverAnimated:fromRect:]):
(-[WKAirPlayRoutePicker _windowWillRotate:]):
(-[WKAirPlayRoutePicker _windowDidRotate:]):
(-[WKAirPlayRoutePicker _dismissAirPlayRoutePickerIPad]):
(-[WKAirPlayRoutePicker showAirPlayPickerIPad:fromRect:]):
(-[WKAirPlayRoutePicker showAirPlayPickerIPhone:]):
(-[WKAirPlayRoutePicker show:fromRect:]):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:

(WebKit::WebChromeClient::showAirPlayRoutePicker):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::touchEvent):
(WebKit::WebPage::touchEventSyncForTesting):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::rectForElementAtInteractionLocation):
(WebKit::WebPage::handleTap):

4:40 PM Changeset in webkit [166383] by Bem Jones-Bey
  • 9 edits
    42 adds in trunk

[CSS Shapes][css clip-path] rounded corner calculation for box shapes is wrong
​https://bugs.webkit.org/show_bug.cgi?id=127982

Reviewed by Simon Fraser.

Source/WebCore:

Calculate rounded corners for box shapes as defined in the CSS Shapes
spec.

Tests: css3/masking/clip-path-border-radius-border-box-000.html

css3/masking/clip-path-border-radius-content-box-000.html
css3/masking/clip-path-border-radius-content-box-001.html
css3/masking/clip-path-border-radius-padding-box-000.html
css3/masking/clip-path-border-radius-padding-box-001.html
fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-border-box-000.html
fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-border-box-001.html
fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-border-box-002.html
fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-content-box-000.html
fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-content-box-001.html
fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-content-box-002.html
fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-content-box-003.html
fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-margin-box-000.html
fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-margin-box-001.html
fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-margin-box-002.html
fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-margin-box-003.html
fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-margin-box-004.html
fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-padding-box-000.html
fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-padding-box-001.html
fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-padding-box-002.html
fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-padding-box-003.html

  • platform/graphics/RoundedRect.h:

(WebCore::RoundedRect::Radii::transposedRadii): Transpose radii for

vertical writing modes.

(WebCore::RoundedRect::moveBy): Add method for use with clip path.
(WebCore::RoundedRect::transposedRect): Transpose rect for vertical

writing modes.

  • rendering/RenderBox.h:

(WebCore::RenderBox::marginBoxRect): Return the margin box rect for

the RenderBox.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::setupClipPath): Call the new function for the

rounded corner calculation.

  • rendering/shapes/ShapeInfo.cpp:

(WebCore::ShapeInfo<RenderType>::computedShape): Call the new function

for the rounded corner calculation.

  • rendering/shapes/BoxShape.cpp:

(WebCore::adjustRadiusForMarginBoxShape): Helper function for

computeRoundedRectForLayoutBoxShape.

(WebCore::computeMarginBoxShapeRadius): Ditto.
(WebCore::computeMarginBoxShapeRadii): Ditto.
(WebCore::computeRoundedRectForBoxShape): Utility function to do the

rounded corner calculation.

  • rendering/shapes/BoxShape.h: Add new function.
  • rendering/style/RenderStyle.h:

(WebCore::RenderStyle::getRoundedInnerBorderFor): Add default argument

values.

LayoutTests:

  • css3/masking/clip-path-border-radius-border-box-000-expected.html: Added.
  • css3/masking/clip-path-border-radius-border-box-000.html: Added.
  • css3/masking/clip-path-border-radius-content-box-000-expected.html: Added.
  • css3/masking/clip-path-border-radius-content-box-000.html: Added.
  • css3/masking/clip-path-border-radius-content-box-001-expected.html: Added.
  • css3/masking/clip-path-border-radius-content-box-001.html: Added.
  • css3/masking/clip-path-border-radius-padding-box-000-expected.html: Added.
  • css3/masking/clip-path-border-radius-padding-box-000.html: Added.
  • css3/masking/clip-path-border-radius-padding-box-001-expected.html: Added.
  • css3/masking/clip-path-border-radius-padding-box-001.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-border-box-000-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-border-box-000.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-border-box-001-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-border-box-001.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-border-box-002-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-border-box-002.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-content-box-000-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-content-box-000.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-content-box-001-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-content-box-001.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-content-box-002-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-content-box-002.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-content-box-003-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-content-box-003.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-margin-box-000-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-margin-box-000.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-margin-box-001-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-margin-box-001.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-margin-box-002-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-margin-box-002.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-margin-box-003-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-margin-box-003.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-margin-box-004-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-margin-box-004.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-padding-box-000-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-padding-box-000.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-padding-box-001-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-padding-box-001.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-padding-box-002-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-padding-box-002.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-padding-box-003-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-padding-box-003.html: Added.
4:37 PM Changeset in webkit [166382] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2][iOS] <rdar://problem/16414684> WKWebView should draw a white background before the page loads
​https://bugs.webkit.org/show_bug.cgi?id=130873

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-03-27
Reviewed by Simon Fraser.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):

4:23 PM Changeset in webkit [166381] by commit-queue@webkit.org
  • 11 edits
    2 deletes in trunk/Source/WebCore

Unreviewed, rolling out r166364.
​https://bugs.webkit.org/show_bug.cgi?id=130872

Caused a test assertion (Requested by smfr on #webkit).

Reverted changeset:

"Operator stretching: expose a math data API"
​https://bugs.webkit.org/show_bug.cgi?id=130572
​http://trac.webkit.org/changeset/166364

4:22 PM Changeset in webkit [166380] by benjamin@webkit.org
  • 9 edits in trunk/Source

[iOS][WK2] Compute a good exposed rect when scaling WKContentView
​https://bugs.webkit.org/show_bug.cgi?id=130761

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-03-27
Reviewed by Simon Fraser.

Source/WebCore:

  • WebCore.exp.in:
  • platform/ScrollView.h:
  • platform/ios/ScrollViewIOS.mm:

(WebCore::ScrollView::setScrollVelocity):
(WebCore::ScrollView::computeCoverageRect):
While scaling in, do not add margins tiles. When scaling out, add 1 margin tile size
all around.

Source/WebKit2:

Add a simple heuristic to improve tiling while zooming. In theory we could take the zoom
center and scaleRate to split the speed between scrolling and pinching. In practice,
zoom is transitory and is not as predictable as scrolling, so this patch just does a very
simple heuristic:
-When zooming in, do not expand coverage.
-When zooming out, add half a tile size on every side.

  • Shared/VisibleContentRectUpdateInfo.cpp:

(WebKit::VisibleContentRectUpdateInfo::encode):
(WebKit::VisibleContentRectUpdateInfo::decode):

  • Shared/VisibleContentRectUpdateInfo.h:

(WebKit::VisibleContentRectUpdateInfo::VisibleContentRectUpdateInfo):
(WebKit::VisibleContentRectUpdateInfo::timestamp):
(WebKit::VisibleContentRectUpdateInfo::horizontalVelocity):
(WebKit::VisibleContentRectUpdateInfo::verticalVelocity):
(WebKit::VisibleContentRectUpdateInfo::scaleChangeRate):

  • UIProcess/ios/WKContentView.mm:

(WebKit::HistoricalVelocityData::VelocityData::VelocityData):
(WebKit::HistoricalVelocityData::velocityForNewData):
(WebKit::HistoricalVelocityData::append):
(-[WKContentView didUpdateVisibleRect:unobscuredRect:scale:inStableState:]):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::adjustExposedRectForBoundedScale):
When zooming past the maximum size, adjust the exposed rect to continue tiling the area
at maximum size. Otherwise, we tile a tiny area, and have to retile larger when the animation
pull back the view to maximum scale.

(WebKit::adjustVelocityDataForBoundedScale):
Since we do not split the velocity from scrolling from the scaling, just clear the velocity when zooming.
Also clear the scaleChangeRate when the scale is out of bounds. There is no reason to add tiles for
temporary state.

(WebKit::WebPage::updateVisibleContentRects):

3:59 PM Changeset in webkit [166379] by andersca@apple.com
  • 19 edits
    5 copies
    2 moves in trunk/Source/WebKit2

Add _ prefix to WKRemoteObjectRegistery and WKRemoteObjectInterface
​https://bugs.webkit.org/show_bug.cgi?id=130868

Reviewed by Sam Weinig.

  • Shared/API/Cocoa/RemoteObjectRegistry.h:
  • Shared/API/Cocoa/RemoteObjectRegistry.mm:

(WebKit::RemoteObjectRegistry::RemoteObjectRegistry):

  • Shared/API/Cocoa/WKRemoteObject.h:
  • Shared/API/Cocoa/WKRemoteObject.mm:

(-[WKRemoteObject _initWithObjectRegistry:interface:]):

  • Shared/API/Cocoa/WKRemoteObjectCoder.h:
  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(-[WKRemoteObjectDecoder initWithInterface:rootObjectDictionary:WebKit::]):

  • Shared/API/Cocoa/WKRemoteObjectInterface.h:
  • Shared/API/Cocoa/WKRemoteObjectInterface.mm:

(isContainerClass): Deleted.
(propertyListClasses): Deleted.
(allowedArgumentClassesForMethod): Deleted.
(initializeAllowedArgumentClasses): Deleted.
(-[WKRemoteObjectInterface initWithProtocol:identifier:]): Deleted.
(+[WKRemoteObjectInterface remoteObjectInterfaceWithProtocol:]): Deleted.
(-[WKRemoteObjectInterface description]): Deleted.
(classesForSelectorArgument): Deleted.
(-[WKRemoteObjectInterface classesForSelector:argumentIndex:]): Deleted.
(-[WKRemoteObjectInterface setClasses:forSelector:argumentIndex:]): Deleted.
(methodArgumentTypeEncodingForSelector): Deleted.
(-[WKRemoteObjectInterface _methodSignatureForSelector:]): Deleted.
(-[WKRemoteObjectInterface _allowedArgumentClassesForSelector:]): Deleted.

  • Shared/API/Cocoa/WKRemoteObjectRegistry.h:
  • Shared/API/Cocoa/WKRemoteObjectRegistry.mm:

(-[WKRemoteObjectRegistry registerExportedObject:interface:]): Deleted.
(-[WKRemoteObjectRegistry unregisterExportedObject:interface:]): Deleted.
(-[WKRemoteObjectRegistry remoteObjectProxyWithInterface:]): Deleted.
(-[WKRemoteObjectRegistry _initWithMessageSender:IPC::]): Deleted.
(-[WKRemoteObjectRegistry _invalidate]): Deleted.
(-[WKRemoteObjectRegistry _sendInvocation:interface:]): Deleted.
(-[WKRemoteObjectRegistry WebKit::]): Deleted.
(-[WKRemoteObjectRegistry _invokeMethod:]): Deleted.
(-[WKRemoteObjectRegistry _invokeMessageWithInterfaceIdentifier:encodedInvocation:]): Deleted.

  • Shared/API/Cocoa/_WKRemoteObjectInterface.h: Copied from Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectInterface.h.
  • Shared/API/Cocoa/_WKRemoteObjectInterface.mm: Copied from Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectInterface.mm.

(isContainerClass):
(propertyListClasses):
(allowedArgumentClassesForMethod):
(initializeAllowedArgumentClasses):
(-[_WKRemoteObjectInterface initWithProtocol:identifier:]):
(+[_WKRemoteObjectInterface remoteObjectInterfaceWithProtocol:]):
(-[_WKRemoteObjectInterface description]):
(classesForSelectorArgument):
(-[_WKRemoteObjectInterface classesForSelector:argumentIndex:]):
(-[_WKRemoteObjectInterface setClasses:forSelector:argumentIndex:]):
(methodArgumentTypeEncodingForSelector):
(-[_WKRemoteObjectInterface _methodSignatureForSelector:]):
(-[_WKRemoteObjectInterface _allowedArgumentClassesForSelector:]):

  • Shared/API/Cocoa/_WKRemoteObjectInterfaceInternal.h: Renamed from Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectInterfaceInternal.h.
  • Shared/API/Cocoa/_WKRemoteObjectRegistry.h: Copied from Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectRegistry.h.
  • Shared/API/Cocoa/_WKRemoteObjectRegistry.mm: Copied from Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectRegistry.mm.

(-[_WKRemoteObjectRegistry registerExportedObject:interface:]):
(-[_WKRemoteObjectRegistry unregisterExportedObject:interface:]):
(-[_WKRemoteObjectRegistry remoteObjectProxyWithInterface:]):
(-[_WKRemoteObjectRegistry _initWithMessageSender:IPC::]):
(-[_WKRemoteObjectRegistry _invalidate]):
(-[_WKRemoteObjectRegistry _sendInvocation:interface:]):
(-[_WKRemoteObjectRegistry WebKit::]):
(-[_WKRemoteObjectRegistry _invokeMethod:]):
(-[_WKRemoteObjectRegistry _invokeMessageWithInterfaceIdentifier:encodedInvocation:]):

  • Shared/API/Cocoa/_WKRemoteObjectRegistryInternal.h: Renamed from Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectRegistryInternal.h.
  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController _remoteObjectRegistry]):
(-[WKBrowsingContextController remoteObjectRegistry]): Deleted.

  • UIProcess/API/Cocoa/WKBrowsingContextControllerPrivate.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _remoteObjectRegistry]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInBrowserContextControllerToBeRemoved.mm: Copied from Source/WebKit2/Shared/API/Cocoa/WKRemoteObject.h.

(-[WKWebProcessPlugInBrowserContextController remoteObjectRegistry]):

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController _remoteObjectRegistry]):
(-[WKWebProcessPlugInBrowserContextController remoteObjectRegistry]): Deleted.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:
3:49 PM Changeset in webkit [166378] by commit-queue@webkit.org
  • 32 edits
    3 deletes in trunk/Source

Unreviewed, rolling out r166360.
​https://bugs.webkit.org/show_bug.cgi?id=130869

Seems to have broken PLT (Requested by ap on #webkit).

Reverted changeset:

Source/WebCore:

"Connection::dispatchOneMessage() can be re-entered while
handling Cmd-key menu"
​https://bugs.webkit.org/show_bug.cgi?id=130767
​http://trac.webkit.org/changeset/166360

Source/WebKit/mac:

"Connection::dispatchOneMessage() can be re-entered while
handling Cmd-key menu"
​https://bugs.webkit.org/show_bug.cgi?id=130767
​http://trac.webkit.org/changeset/166360

Source/WebKit2:

"Connection::dispatchOneMessage() can be re-entered while
handling Cmd-key menu"
​https://bugs.webkit.org/show_bug.cgi?id=130767
​http://trac.webkit.org/changeset/166360

Source/WTF:

"Connection::dispatchOneMessage() can be re-entered while
handling Cmd-key menu"
​https://bugs.webkit.org/show_bug.cgi?id=130767
​http://trac.webkit.org/changeset/166360

3:47 PM Changeset in webkit [166377] by Antti Koivisto
  • 15 edits in trunk/Source/WebCore

Remove LiveNodeList::Type
​https://bugs.webkit.org/show_bug.cgi?id=130866

Reviewed by Andreas Kling.

We don't need dynamic type information anymore.

  • dom/ClassNodeList.cpp:

(WebCore::ClassNodeList::ClassNodeList):

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::getElementsByTagName):
(WebCore::ContainerNode::getElementsByName):
(WebCore::ContainerNode::getElementsByClassName):
(WebCore::ContainerNode::radioNodeList):

  • dom/LiveNodeList.cpp:

(WebCore::LiveNodeList::LiveNodeList):

  • dom/LiveNodeList.h:

(WebCore::LiveNodeList::invalidationType):
(WebCore::CachedLiveNodeList<NodeListType>::CachedLiveNodeList):
(WebCore::LiveNodeList::type): Deleted.

  • dom/NameNodeList.cpp:

(WebCore::NameNodeList::NameNodeList):
(WebCore::NameNodeList::nodeMatches): Deleted.

  • dom/NameNodeList.h:

(WebCore::NameNodeList::nodeMatches):

  • dom/NodeRareData.h:

(WebCore::NodeListTypeIdentifier<ClassNodeList>::value):
(WebCore::NodeListTypeIdentifier<NameNodeList>::value):
(WebCore::NodeListTypeIdentifier<TagNodeList>::value):
(WebCore::NodeListTypeIdentifier<HTMLTagNodeList>::value):
(WebCore::NodeListTypeIdentifier<RadioNodeList>::value):
(WebCore::NodeListTypeIdentifier<LabelsNodeList>::value):

Get unique id from type for key generation purposes only.

(WebCore::NodeListsNodeData::addCacheWithAtomicName):
(WebCore::NodeListsNodeData::addCacheWithName):
(WebCore::NodeListsNodeData::removeCacheWithAtomicName):
(WebCore::NodeListsNodeData::removeCacheWithName):
(WebCore::NodeListsNodeData::namedNodeListKey):

  • dom/TagNodeList.cpp:

(WebCore::TagNodeList::TagNodeList):
(WebCore::HTMLTagNodeList::HTMLTagNodeList):

  • dom/TagNodeList.h:
  • html/LabelableElement.cpp:

(WebCore::LabelableElement::labels):

  • html/LabelsNodeList.cpp:

(WebCore::LabelsNodeList::LabelsNodeList):

  • html/LabelsNodeList.h:
  • html/RadioNodeList.cpp:

(WebCore::RadioNodeList::RadioNodeList):

  • html/RadioNodeList.h:
3:39 PM Changeset in webkit [166376] by akling@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Avoid fetching JSObject::structure() repeatedly in putDirectInternal.
<​https://webkit.org/b/130857>

Use the cached Structure* instead of re-fetching it over and over since
that's a non-trivial operation these days.

Reviewed by Mark Hahnenberg.

  • runtime/JSObject.h:

(JSC::JSObject::putDirectInternal):

3:34 PM Changeset in webkit [166375] by mhahnenberg@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Check the remembered set bit faster
​https://bugs.webkit.org/show_bug.cgi?id=130860

Reviewed by Oliver Hunt.

Currently we look up the remembered set bit in the MarkedBlock in C++ code, but
that bit is also stored in the object. We should look it up there whenever possible.

  • heap/CopiedBlockInlines.h:

(JSC::CopiedBlock::shouldReportLiveBytes):

  • heap/Heap.cpp:

(JSC::Heap::addToRememberedSet):

  • heap/Heap.h:
  • heap/HeapInlines.h: Removed.
  • heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::reportExtraMemoryUsage):

3:30 PM Changeset in webkit [166374] by weinig@apple.com
  • 4 edits in trunk/Source/WebKit2

Support dynamic layer hosting context changes
<rdar://problem/16278019>
​https://bugs.webkit.org/show_bug.cgi?id=130863

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView addWindowObserversForWindow:]):
(-[WKView removeWindowObservers]):
(-[WKView _windowDidChangeLayerHosting:]):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::layerHostingModeDidChange):

  • UIProcess/WebPageProxy.h:
3:28 PM Changeset in webkit [166373] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

Don't leak the WKBrowsingContextController
​https://bugs.webkit.org/show_bug.cgi?id=130815

Reviewed by Tim Horton.

Use adoptNS to avoid leaking the WKBrowsingContextController.

  • UIProcess/ios/WKContentView.mm:

(-[WKContentView browsingContextController]):

3:28 PM Changeset in webkit [166372] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix crash when RenderView is cleared inside of frame flattening layout
​https://bugs.webkit.org/show_bug.cgi?id=130864

Reviewed by Dan Bernstein.

Navigating on ​http://wallstcheatsheet.com pages on iOS in WebKit1 would
sometimes crash when, inside the inChildFrameLayoutWithFrameFlattening clause,
our frame's RenderView would be null after doing a layout from the root frame,
possibly also when WebCore was being re-entered from another thread.

Add a null check to fix this.

Crash was timing-dependent and hard to test.

  • page/FrameView.cpp:

(WebCore::FrameView::layout):

3:00 PM Changeset in webkit [166371] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebKit2

Web Inspector: Give WebProcess a proxy application entitlement
​https://bugs.webkit.org/show_bug.cgi?id=130806

Reviewed by Timothy Hatcher.

  • Configurations/WebContent-iOS.entitlements:
2:21 PM Changeset in webkit [166370] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Add reload and reloadFromOrigin as API
​https://bugs.webkit.org/show_bug.cgi?id=130858

Reviewed by Simon Fraser.

  • UIProcess/API/Cocoa/WKWebView.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView reload]):
(-[WKWebView reloadFromOrigin]):
(-[WKWebView validateUserInterfaceItem:]):
(-[WKWebView reload:]):
(-[WKWebView reloadFromOrigin:]):

1:49 PM Changeset in webkit [166369] by Antti Koivisto
  • 14 edits in trunk/Source/WebCore

Remove some unnecessary branches from LiveNodeList traversal
​https://bugs.webkit.org/show_bug.cgi?id=130854

Reviewed by Andreas Kling.

Compile different traversal code paths for all NodeList subclasses.

  • dom/ClassNodeList.cpp:

(WebCore::ClassNodeList::ClassNodeList):
(WebCore::ClassNodeList::~ClassNodeList):
(WebCore::ClassNodeList::nodeMatches): Deleted.

  • dom/ClassNodeList.h:

(WebCore::ClassNodeList::nodeMatches):
(WebCore::ClassNodeList::nodeMatchesInlined): Deleted.

Remove separate nodeMatchesInlined functions.
We now rely on exact types and marking classes final.

  • dom/LiveNodeList.cpp:

(WebCore::LiveNodeList::LiveNodeList):
(WebCore::LiveNodeList::~LiveNodeList):
(WebCore::LiveNodeList::namedItem):
(WebCore::LiveNodeList::rootNode): Deleted.
(WebCore::isMatchingElement): Deleted.
(WebCore::firstMatchingElement): Deleted.
(WebCore::lastMatchingElement): Deleted.
(WebCore::nextMatchingElement): Deleted.
(WebCore::previousMatchingElement): Deleted.
(WebCore::traverseMatchingElementsForward): Deleted.
(WebCore::traverseMatchingElementsBackward): Deleted.
(WebCore::LiveNodeList::collectionFirst): Deleted.
(WebCore::LiveNodeList::collectionLast): Deleted.
(WebCore::LiveNodeList::collectionTraverseForward): Deleted.
(WebCore::LiveNodeList::collectionTraverseBackward): Deleted.
(WebCore::LiveNodeList::length): Deleted.
(WebCore::LiveNodeList::item): Deleted.
(WebCore::LiveNodeList::memoryCost): Deleted.
(WebCore::LiveNodeList::invalidateCache): Deleted.

  • dom/LiveNodeList.h:

(WebCore::LiveNodeList::invalidateCacheForAttribute):
(WebCore::CachedLiveNodeList::collectionCanTraverseBackward):
(WebCore::LiveNodeList::rootNode):
(WebCore::CachedLiveNodeList<NodeListType>::CachedLiveNodeList):

Add CachedLiveNodeList<NodeListType> utility type that interfaces with CollectionIndexCache.
It is the base class for all concrete LiveNodeLists.

(WebCore::CachedLiveNodeList<NodeListType>::~CachedLiveNodeList):
(WebCore::CachedLiveNodeList<NodeListType>::collectionFirst):
(WebCore::CachedLiveNodeList<NodeListType>::collectionLast):
(WebCore::nextMatchingElement):
(WebCore::CachedLiveNodeList<NodeListType>::collectionTraverseForward):
(WebCore::previousMatchingElement):
(WebCore::CachedLiveNodeList<NodeListType>::collectionTraverseBackward):
(WebCore::CachedLiveNodeList<NodeListType>::willValidateIndexCache):
(WebCore::CachedLiveNodeList<NodeListType>::invalidateCache):
(WebCore::CachedLiveNodeList<NodeListType>::length):
(WebCore::CachedLiveNodeList<NodeListType>::item):
(WebCore::CachedLiveNodeList<NodeListType>::memoryCost):

Templated code moves to header.

(WebCore::LiveNodeList::LiveNodeList): Deleted.
(WebCore::LiveNodeList::~LiveNodeList): Deleted.
(WebCore::LiveNodeList::invalidateCache): Deleted.
(WebCore::LiveNodeList::collectionCanTraverseBackward): Deleted.
(WebCore::LiveNodeList::willValidateIndexCache): Deleted.

  • dom/NameNodeList.cpp:

(WebCore::NameNodeList::NameNodeList):

  • dom/NameNodeList.h:
  • dom/Node.cpp:

(WebCore::Document::invalidateNodeListAndCollectionCaches):
(WebCore::NodeListsNodeData::invalidateCaches):

  • dom/TagNodeList.cpp:

(WebCore::TagNodeList::TagNodeList):
(WebCore::HTMLTagNodeList::HTMLTagNodeList):
(WebCore::HTMLTagNodeList::~HTMLTagNodeList):
(WebCore::TagNodeList::nodeMatches): Deleted.
(WebCore::HTMLTagNodeList::nodeMatches): Deleted.

  • dom/TagNodeList.h:

(WebCore::TagNodeList::nodeMatches):
(WebCore::HTMLTagNodeList::nodeMatches):
(WebCore::TagNodeList::create): Deleted.
(WebCore::HTMLTagNodeList::nodeMatchesInlined): Deleted.

  • html/LabelsNodeList.cpp:

(WebCore::LabelsNodeList::LabelsNodeList):

  • html/LabelsNodeList.h:
  • html/RadioNodeList.cpp:

(WebCore::RadioNodeList::RadioNodeList):

  • html/RadioNodeList.h:
1:07 PM Changeset in webkit [166368] by cavalcantii@gmail.com
  • 2 edits in trunk/Source/WebCore

Remove comment from Filter.h
​https://bugs.webkit.org/show_bug.cgi?id=130848

Reviewed by Simon Fraser.

Exploring the use of consts on applyScale() methods didn't yield
good results.

No new tests, no change on behavior.

  • platform/graphics/filters/Filter.h:
1:01 PM Changeset in webkit [166367] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Source/JavaScriptCore

Web Inspector: Provide SPI to disallow remote inspection of a JSContext
​https://bugs.webkit.org/show_bug.cgi?id=130853

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-03-27
Reviewed by Timothy Hatcher.

  • API/JSContextPrivate.h: Added.
  • API/JSContext.mm:

(-[JSContext _remoteInspectionEnabled]):
(-[JSContext _setRemoteInspectionEnabled:]):
ObjC SPI to enable/disable remote inspection.

  • API/JSContextRefPrivate.h:
  • API/JSContextRef.cpp:

(JSGlobalContextGetRemoteInspectionEnabled):
(JSGlobalContextSetRemoteInspectionEnabled):
C SPI to enable/disable remote inspection.

Add new private header, and export as a private header.

12:19 PM Changeset in webkit [166366] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Clean up questionable style in ScriptExecutable::prepareForExecutionImpl
​https://bugs.webkit.org/show_bug.cgi?id=130845

Reviewed by Filip Pizlo.

There was a hack added to make sure C Loop LLInt worked which included overriding the
global Options::useLLInt setting, which makes no sense to do here. We should put the
update of the global setting in Options::recomputeDependentOptions along with the other
execution engine flags.

  • runtime/Executable.cpp:

(JSC::ScriptExecutable::prepareForExecutionImpl):

  • runtime/Options.cpp:

(JSC::recomputeDependentOptions):

11:32 AM Changeset in webkit [166365] by graouts@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: clearing the console log doesn't update the activity viewer
​https://bugs.webkit.org/show_bug.cgi?id=130774

Reviewed by Joseph Pecoraro.

Ensure we take the changes made to the ivars into account on the view.

  • UserInterface/Models/DefaultDashboard.js:

(WebInspector.DefaultDashboard.prototype._consoleWasCleared):

11:06 AM Changeset in webkit [166364] by fred.wang@free.fr
  • 11 edits
    2 adds in trunk/Source/WebCore

Operator stretching: expose a math data API
​https://bugs.webkit.org/show_bug.cgi?id=130572

Reviewed by Chris Fleizach.

We expose a new SimpleFontData API to give access to the data from the
OpenType MATH table using a font cache. The class OpenTypeMathData will
be implemented in bug 130324. On Darwin platform, we also implement the
missing FontPlatformData::openTypeTable function which will be necessary
to load the OpenType MATH table. The changes are intended to be used
for MathML operator stretching (bug 130322) so tests are not added yet.

  • CMakeLists.txt: add new OpenTypeMathData files.
  • WebCore.vcxproj/WebCore.vcxproj: ditto.
  • WebCore.vcxproj/WebCore.vcxproj.filters: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • platform/graphics/FontCache.cpp: We add a FontCache::getMathData function to implement a cache for the math data.

We make the math and vertical data share the same key for the cache.
(WebCore::fontMathDataCacheInstance):
(WebCore::FontCache::getMathData):
(WebCore::fontVerticalDataCacheInstance):

  • platform/graphics/FontCache.h: We declare FontCache::getMathData and FontFileKey on all platforms.
  • platform/graphics/FontPlatformData.cpp:

(WebCore::FontPlatformData::openTypeTable): We implement openTypeTable() on Darwin platform.

  • platform/graphics/FontPlatformData.h: We expose openTypeTable() on Darwin platform.
  • platform/graphics/SimpleFontData.cpp: We initialize m_mathData from the font cache.

(WebCore::SimpleFontData::SimpleFontData):

  • platform/graphics/SimpleFontData.h: We expose a mathData() function to access the MATH data.
  • platform/graphics/opentype/OpenTypeMathData.cpp: Added. This is a new class that will be used to parse the data from the OpenType MATH table.

(WebCore::OpenTypeMathData::OpenTypeMathData):

  • platform/graphics/opentype/OpenTypeMathData.h: Added.

(WebCore::OpenTypeMathData::create):
(WebCore::OpenTypeMathData::hasMathData):

10:51 AM Changeset in webkit [166363] by Brent Fulgham
  • 2 edits in trunk/Source/WebInspectorUI

[Win] Correct handling of autogenerated WebInspectorUI files
​https://bugs.webkit.org/show_bug.cgi?id=130846

Reviewed by Joseph Pecoraro.

  • WebInspectorUI.vcxproj/WebInspectorUIPostBuild.cmd: Files need to be placed in the

'Protocol' subdirectory of the WebInspectorUI directory.

10:50 AM Changeset in webkit [166362] by Brent Fulgham
  • 3 edits
    2 adds in trunk

Fix a crash caused by track insertion after load()
​https://bugs.webkit.org/show_bug.cgi?id=130777

Reviewed by Eric Carlson.

Test: media/track/track-insert-after-load-crash.html

Based on the Blink change (patch by ​acolwell@chromium.org):
​https://codereview.chromium.org/211373009/

Source/WebCore:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute): Remove stale LoadMediaResource flag after explicit load.

LayoutTests:

  • media/track/track-insert-after-load-crash-expected.txt: Added.
  • media/track/track-insert-after-load-crash.html: Added.
10:42 AM Changeset in webkit [166361] by andersca@apple.com
  • 6 edits
    3 moves in trunk/Source/WebKit2

Rename WKFrameHandle to _WKFrameHandle
​https://bugs.webkit.org/show_bug.cgi?id=130847

Reviewed by Tim Horton.

  • Shared/API/Cocoa/_WKFrameHandle.h: Renamed from Source/WebKit2/Shared/API/Cocoa/WKFrameHandle.h.
  • Shared/API/Cocoa/_WKFrameHandle.mm: Renamed from Source/WebKit2/Shared/API/Cocoa/WKFrameHandle.mm.

(-[_WKFrameHandle dealloc]):
(-[_WKFrameHandle isEqual:]):
(-[_WKFrameHandle hash]):
(-[_WKFrameHandle _frameID]):
(-[_WKFrameHandle copyWithZone:]):
(+[_WKFrameHandle supportsSecureCoding]):
(-[_WKFrameHandle initWithCoder:]):
(-[_WKFrameHandle encodeWithCoder:]):
(-[_WKFrameHandle API::]):

  • Shared/API/Cocoa/_WKFrameHandleInternal.h: Renamed from Source/WebKit2/Shared/API/Cocoa/WKFrameHandleInternal.h.

(WebKit::wrapper):

  • Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h:
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:

(+[WKWebProcessPlugInFrame lookUpFrameFromHandle:]):
(-[WKWebProcessPlugInFrame handle]):

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h:
9:47 AM Changeset in webkit [166360] by ap@apple.com
  • 32 edits
    3 adds in trunk/Source

Connection::dispatchOneMessage() can be re-entered while handling Cmd-key menu
equivalents, ASSERT(!_data->_keyDownEventBeingResent)
​https://bugs.webkit.org/show_bug.cgi?id=130767
<rdar://problem/16307487>

Source/WebCore:

Added a wrapper for RunLoop::initializeMainThread that also adds modal run loop
mode to it on Mac.

  • CMakeLists.txt:
  • WebCore.exp.in:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/MainRunLoop.cpp: Added.

(WebCore::initializeMainRunLoop):

  • platform/MainRunLoop.h: Added.
  • platform/mac/MainRunLoop.mm: Added.

(WebCore::initializeMainRunLoop):

Source/WebKit/mac:

Reviewed by Darin Adler.

Switched to a WebCore wrapper for RunLoop::initializeMainRunLoop that adds
NSModalPanelRunLoopMode to RunLoop event source and timer modes.

  • Carbon/CarbonWindowAdapter.mm: (+[CarbonWindowAdapter initialize]):
  • History/WebBackForwardList.mm: (+[WebBackForwardList initialize]):
  • History/WebHistoryItem.mm: (+[WebHistoryItem initialize]):
  • Misc/WebCache.mm: (+[WebCache initialize]):
  • Misc/WebElementDictionary.mm: (+[WebElementDictionary initialize]):
  • Misc/WebIconDatabase.mm: (+[WebIconDatabase initialize]):
  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (+[WebHostedNetscapePluginView initialize]):
  • Plugins/WebBaseNetscapePluginView.mm:
  • Plugins/WebBasePluginPackage.mm:
  • Plugins/WebNetscapePluginView.mm: (+[WebNetscapePluginView initialize]):
  • WebCoreSupport/WebEditorClient.mm: (+[WebUndoStep initialize]):
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebView/WebArchive.mm: (+[WebArchivePrivate initialize]):
  • WebView/WebDataSource.mm: (+[WebDataSource initialize]):
  • WebView/WebHTMLView.mm:

(+[WebHTMLViewPrivate initialize]):
(+[WebHTMLView initialize]):

  • WebView/WebPreferences.mm: (+[WebPreferences initialize]):
  • WebView/WebResource.mm: (+[WebResourcePrivate initialize]):
  • WebView/WebTextIterator.mm: (+[WebTextIteratorPrivate initialize]):
  • WebView/WebView.mm: (+[WebView initialize]):
  • WebView/WebViewData.mm: (+[WebViewPrivate initialize]):

Source/WebKit2:

Reviewed by Darin Adler.

  • Shared/WebKit2Initialize.cpp: (WebKit::InitializeWebKit2): Added NSModalPanelRunLoopMode

to RunLoop event source and timer modes.

Source/WTF:

Reviewed by Darin Adler.

Changed RunLoop to wake up and fire timers only in default run loop mode by default,
and added an ability to add more modes (can't use AppKit symbols in WTF).

In addition to this bug, the change also blocks modal alerts from appearing under
menus during menu tracking.

  • wtf/RunLoop.h:
  • wtf/cf/RunLoopCF.cpp:

(WTF::RunLoop::RunLoop):
(WTF::RunLoop::addModeForWakeUpAndTimers):
(WTF::RunLoop::TimerBase::start):

9:43 AM Changeset in webkit [166359] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Enable LLVM stackmap liveOuts computation
​https://bugs.webkit.org/show_bug.cgi?id=130821

Reviewed by Andy Estes and Sam Weinig.

  • ftl/FTLStackMaps.cpp:

(JSC::FTL::StackMaps::Record::dump):

  • llvm/library/LLVMExports.cpp:

(initializeAndGetJSCLLVMAPI):

8:18 AM Changeset in webkit [166358] by k.czech@samsung.com
  • 3 edits in trunk/Source/WebCore

AX: Returns const reference to static string.
​https://bugs.webkit.org/show_bug.cgi?id=130835

Reviewed by Mario Sanchez Prada.

Avoiding some unnecessary copies by returning const reference to static string.

No new tests. No behaviour change.

  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaControl::controlTypeName):
(WebCore::AccessibilityMediaControlsContainer::elementTypeName):

  • accessibility/AccessibilityMediaControls.h:

Change-Id: I05357d107c0df944a65c7fb97c8bbdec549202c4

8:11 AM Changeset in webkit [166357] by jaepark@webkit.org
  • 1 edit
    1 delete in trunk/Source/WebKit2

Remove LayerTreeContextCairo.cpp
​https://bugs.webkit.org/show_bug.cgi?id=130807

Reviewed by Martin Robinson.

  • Shared/cairo/LayerTreeContextCairo.cpp: Removed.
7:39 AM Changeset in webkit [166356] by Manuel Rego Casasnovas
  • 2 edits in trunk/LayoutTests

[CSS Grid Layout] Remove unused variable in fast/css-grid-layout/implicit-position-dynamic-change.html
​https://bugs.webkit.org/show_bug.cgi?id=130833

Reviewed by Sergio Villar Senin.

  • fast/css-grid-layout/implicit-position-dynamic-change.html: Inside

method updateImplicitGridColumn() we define a variable gridItem that
is not used. This patch removes it.

5:56 AM WebKitGTK/2.4.x edited by berto@igalia.com
(diff)
4:33 AM Changeset in webkit [166355] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Add tests of the set process model API
​https://bugs.webkit.org/show_bug.cgi?id=130830

Patch by Maciej Florek <​m.florek@samsung.com> on 2014-03-27
Reviewed by Gyuyoung Kim.

Implement unit tests to check, if process model API works
properly. When process model is set to EWK_PROCESS_MODEL_SHARED_SECONDARY,
there should be only one WebProcess. In case of EWK_PROCESS_MODEL_MULTIPLE_SECONDARY
setting, each WebView should have own process, as well as the network process
should exist.

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:

(EWK2UnitTest::EWK2UnitTestBase::EWK2UnitTestBase):
(EWK2UnitTest::EWK2UnitTestBase::SetUp):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
  • UIProcess/API/efl/tests/test_ewk2_context.cpp:

(EWK2ContextTestMultipleProcesses::EWK2ContextTestMultipleProcesses):
(TEST_F):

2:45 AM Changeset in webkit [166354] by mihnea@adobe.com
  • 6 edits in trunk/Source/WebCore

[CSSRegions] Rename inNamedFlow flag to isNamedFlowContentNode flag
​https://bugs.webkit.org/show_bug.cgi?id=130731

Reviewed by Andrei Bucur.

Currently, the inNamedFlow flag in Node class tells if a node is a content node, one that has a style with flow-into.
Since it is used only for those nodes and not propagated through hierarchy, i want to renamed it to a more meaningful name.
No new functionality, no new tests.

  • dom/ContainerNode.cpp:

(WebCore::destroyRenderTreeIfNeeded):

  • dom/Element.cpp:

(WebCore::Element::~Element):
(WebCore::Element::unregisterNamedFlowContentElement):

  • dom/Node.h:

(WebCore::Node::isNamedFlowContentNode):
(WebCore::Node::setIsNamedFlowContentNode):
(WebCore::Node::clearIsNamedFlowContentNode):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::clearContentElements):
(WebCore::RenderNamedFlowThread::registerNamedFlowContentElement):
(WebCore::RenderNamedFlowThread::unregisterNamedFlowContentElement):
(WebCore::nextNodeInsideContentElement):

  • style/StyleResolveTree.cpp:

(WebCore::Style::attachChildren):
(WebCore::Style::resolveLocal):

1:03 AM Changeset in webkit [166353] by mihnea@adobe.com
  • 11 edits
    2 adds in trunk

[CSSRegions] Crash when cloning a region child with a content node child
​https://bugs.webkit.org/show_bug.cgi?id=129811

Reviewed by David Hyatt.

Source/WebCore:

Collecting the children of a region in another named flow will be supported
again in the future and it will be revisited when we will implement the content
keyword: ​http://dev.w3.org/csswg/css-regions-1/#the-flow-into-property.
Remove the support for now as it introduces unnecessary complexity in the code
and potential wrong behavior.

Test: fast/regions/region-content-node-child-clone-crash.html

  • dom/Element.cpp:

(WebCore::Element::shouldMoveToFlowThread):
(WebCore::Element::clearStyleDerivedDataBeforeDetachingRenderer):

  • dom/Element.h:
  • dom/ElementRareData.h:

(WebCore::ElementRareData::ElementRareData):

  • rendering/FlowThreadController.cpp:
  • rendering/FlowThreadController.h:
  • style/StyleResolveTree.cpp:

(WebCore::Style::moveToFlowThreadIfNeeded):
(WebCore::Style::createRendererIfNeeded):

LayoutTests:

Collecting the children of a region in another named flow will be supported
again in the future and it will be revisited when we will implement the content
keyword: ​http://dev.w3.org/csswg/css-regions-1/#the-flow-into-property.
For now, skip the tests for that use case.

  • TestExpectations:
  • fast/regions/overflow-region-inline-expected.html: Expected file should not be region based.
  • fast/regions/region-content-node-child-clone-crash-expected.txt: Added.
  • fast/regions/region-content-node-child-clone-crash.html: Added.
  • fast/regions/unsplittable-nested-region-expected.html: Expected file should not be region based.
1:00 AM Changeset in webkit [166352] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

12:57 AM Changeset in webkit [166351] by Lucas Forschler
  • 1 copy in tags/Safari-538.25

New Tag.

12:17 AM Changeset in webkit [166350] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebCore

Remove unneeded mutable keyword in some member variables
​https://bugs.webkit.org/show_bug.cgi?id=130813

Reviewed by Andreas Kling.

Some member variables have mutable keyword though they don't used by const function.
This patch removes them.

No new tests, no behavior changes. Just clean up.

  • storage/StorageAreaSync.h:
  • svg/animation/SVGSMILElement.h:
12:11 AM Changeset in webkit [166349] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Unreviewed, rolling out r166296 and r166331.
​https://bugs.webkit.org/show_bug.cgi?id=130822

caused some crashes and frequent assertion failures, and the
fix is going to take a little while (Requested by thorton on
#webkit).

Reverted changesets:

"[iOS WebKit2] Flush all surfaces after painting into all of
them, instead of after painting into each one"
​https://bugs.webkit.org/show_bug.cgi?id=130768
​http://trac.webkit.org/changeset/166296

Source/WebCore:

"Assertion failure in RemoteLayerBackingStore::flush"
​https://bugs.webkit.org/show_bug.cgi?id=130810
​http://trac.webkit.org/changeset/166331

Source/WebKit2:

"Assertion failure in RemoteLayerBackingStore::flush"
​https://bugs.webkit.org/show_bug.cgi?id=130810
​http://trac.webkit.org/changeset/166331

Mar 26, 2014:

11:50 PM Changeset in webkit [166348] by Simon Fraser
  • 6 edits in trunk/Source/WebCore

Fix failing scrolling tests by reverting to previous behavior where
the scrolling geometry for the main frame scrolling node was only
updated from frameViewLayoutUpdated() and no-where else.

  • WebCore.exp.in:
  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::updateScrollingNode):

  • page/scrolling/AsyncScrollingCoordinator.h:
  • page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::updateScrollingNode):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):
(WebCore::RenderLayerCompositor::detachScrollCoordinatedLayer): Deleted.

11:22 PM Changeset in webkit [166347] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

HTMLConverter::_processText is slow because it walks up ancestor elements
​https://bugs.webkit.org/show_bug.cgi?id=130820

Reviewed by Sam Weinig.

Avoid walking up the tree from each text node by caching the aggregated attributed strings for each element.
Also compute the attributed strings top-down to avoid calling mutableCopy in every iteration.

This reduces the runtime of Interactive/CopyAll.html from 15s to 13s (15%).

  • editing/cocoa/HTMLConverter.mm:

(HTMLConverter::_attributesForElement):
(HTMLConverter::attributesForElement):
(HTMLConverter::aggregatedAttributesForAncestors):
(HTMLConverter::_processText):

11:13 PM Changeset in webkit [166346] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Blind speculative iOS build fix.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::viewportConfigurationChanged):

10:05 PM Changeset in webkit [166345] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Parse stackmaps liveOuts
​https://bugs.webkit.org/show_bug.cgi?id=130801

Reviewed by Geoffrey Garen.

This just adds the code to parse them but doesn't do anything with them, yet.

  • ftl/FTLLocation.cpp:

(JSC::FTL::Location::forStackmaps):

  • ftl/FTLLocation.h:

(JSC::FTL::Location::forRegister):
(JSC::FTL::Location::forIndirect):

  • ftl/FTLStackMaps.cpp:

(JSC::FTL::StackMaps::Location::parse):
(JSC::FTL::StackMaps::Location::dump):
(JSC::FTL::StackMaps::LiveOut::parse):
(JSC::FTL::StackMaps::LiveOut::dump):
(JSC::FTL::StackMaps::Record::parse):
(JSC::FTL::StackMaps::Record::dump):

  • ftl/FTLStackMaps.h:
9:42 PM Changeset in webkit [166344] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix iOS build.

  • editing/cocoa/HTMLConverter.mm:

(_font):

9:31 PM Changeset in webkit [166343] by benjamin@webkit.org
  • 4 edits in trunk/Source/WebKit2

[iOS][WK2] <rdar://problem/16265272> REGRESSION (WebKit2): Some pages appear blank until you scroll
​https://bugs.webkit.org/show_bug.cgi?id=130819

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-03-26
Reviewed by Tim Horton.

When loading a new page, we never define the unobscured rect and exposed rect on the new frame.
As a result, there is nothing to render.

It uses to work thanks to dumb luck and a bug in Safari updating the visibleContentRects from
the UIProcess. Now that the bug is gone, "dumb luck" is not reliable enough to get the content rects :)

What this patch does is save if we have ever received new rects from the UI. If we have not, create them
based on the minimum layout size. This works because we know Safari shows the minimum layout size by default
and will tell us if it changes the obscured rects.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::didCommitLoad):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::viewportConfigurationChanged):
(WebKit::WebPage::updateVisibleContentRects):

9:16 PM Changeset in webkit [166342] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Make _processText and _traverseNode in HTMLConverter more efficient
​https://bugs.webkit.org/show_bug.cgi?id=130769

Reviewed by Sam Weinig.

Rewrote a bunch of code in C++ and avoided creating wrappers.
This reduces the runtime of Interactive/CopyAll.html from ~16.5s to 15s.

  • editing/cocoa/HTMLConverter.mm:

(HTMLConverterCaches::isAncestorsOfStartToBeConverted):
(HTMLConverter::HTMLConverter):
(HTMLConverter::~HTMLConverter):
(HTMLConverter::_processElement):
(HTMLConverter::_processText):
(HTMLConverter::_traverseNode):
(HTMLConverter::_traverseFooterNode):
(HTMLConverterCaches::cacheAncestorsOfStartToBeConverted):
(HTMLConverter::_loadFromDOMRange):

9:14 PM Changeset in webkit [166341] by cavalcantii@gmail.com
  • 15 edits in trunk/Source/WebCore

FEGaussianBlur: unify and const-ify calculateKernelSize
​https://bugs.webkit.org/show_bug.cgi?id=130779

Some methods can benefit of using const refs as also make sense to
unify the interface (i.e. parameters) in calculateKernelSize/Unscaled.

FilterEffect::filter() will now return a reference, which helps since
its descendants were accessing methods into the pointer without testing
for it.

Reviewed by Simon Fraser.

No new tests, no changes on behavior.

  • platform/graphics/filters/FEDisplacementMap.cpp:

(WebCore::FEDisplacementMap::platformApplySoftware):

  • platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::determineAbsolutePaintRect):
(WebCore::FEDropShadow::platformApplySoftware):

  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::calculateUnscaledKernelSize):
(WebCore::FEGaussianBlur::calculateKernelSize):
(WebCore::FEGaussianBlur::determineAbsolutePaintRect):
(WebCore::FEGaussianBlur::platformApplySoftware):

  • platform/graphics/filters/FEGaussianBlur.h:
  • platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::determineAbsolutePaintRect):
(WebCore::FEMorphology::platformApplySoftware):

  • platform/graphics/filters/FEOffset.cpp:

(WebCore::FEOffset::determineAbsolutePaintRect):
(WebCore::FEOffset::platformApplySoftware):

  • platform/graphics/filters/FETile.cpp:

(WebCore::FETile::platformApplySoftware):

  • platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::fillRegion):

  • platform/graphics/filters/Filter.h:

(WebCore::Filter::applyHorizontalScale):
(WebCore::Filter::applyVerticalScale):

  • platform/graphics/filters/FilterEffect.h:

(WebCore::FilterEffect::filter):

  • platform/graphics/filters/SourceAlpha.cpp:

(WebCore::SourceAlpha::determineAbsolutePaintRect):
(WebCore::SourceAlpha::platformApplySoftware):

  • platform/graphics/filters/SourceGraphic.cpp:

(WebCore::SourceGraphic::determineAbsolutePaintRect):
(WebCore::SourceGraphic::platformApplySoftware):

  • rendering/svg/RenderSVGResourceFilterPrimitive.cpp:

(WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):

  • svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::determineAbsolutePaintRect):
(WebCore::FEImage::platformApplySoftware):

8:55 PM Changeset in webkit [166340] by andersca@apple.com
  • 2 edits
    2 adds in trunk/Source/WebKit2

Add a _WKScriptWorld class
​https://bugs.webkit.org/show_bug.cgi?id=130817

Reviewed by Dan Bernstein.

  • UIProcess/API/Cocoa/_WKScriptWorld.h: Added.
  • UIProcess/API/Cocoa/_WKScriptWorld.mm: Added.

(generateWorldID):
(+[_WKScriptWorld defaultWorld]):
(-[_WKScriptWorld init]):
(-[_WKScriptWorld _initWithWorldID:]):

  • WebKit2.xcodeproj/project.pbxproj:
8:53 PM Changeset in webkit [166339] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Make sure childContainmentLayer is parented
​https://bugs.webkit.org/show_bug.cgi?id=130808

Reviewed by Tim Horton.

m_childContainmentLayer was never parented if the page
created no other compositing layers, which left a dangling
GraphicsLayer which in turn confused UI-side compositing a little.
Fix by always parenting this layer.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):

8:46 PM Changeset in webkit [166338] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Rename a delegate method to -webView:didFinishNavigation:
​https://bugs.webkit.org/show_bug.cgi?id=130814

Reviewed by Sam Weinig.

  • UIProcess/API/Cocoa/WKNavigationDelegate.h:
  • UIProcess/Cocoa/NavigationState.h:
  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::setNavigationDelegate):
(WebKit::NavigationState::LoaderClient::didFinishLoadForFrame):

8:45 PM Changeset in webkit [166337] by BJ Burg
  • 3 edits in trunk/Source/WebCore

Web Replay: disable page cache during capture/replay
​https://bugs.webkit.org/show_bug.cgi?id=130672

Reviewed by Timothy Hatcher.

Save, set, and restore page cache settings at the correct times.

No new tests. If this code fails, then the tests for network replay will fail.

  • replay/ReplayController.cpp:

(WebCore::ReplayController::setForceDeterministicSettings): Added.
(WebCore::ReplayController::startCapturing):
(WebCore::ReplayController::stopCapturing):
(WebCore::ReplayController::cancelPlayback):
(WebCore::ReplayController::replayToPosition):

  • replay/ReplayController.h:
8:41 PM Changeset in webkit [166336] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS WebKit2] Crashes on swipe
<rdar://problem/16440867>

Reviewed by Benjamin Poulain.

  • UIProcess/ios/ViewGestureControllerIOS.mm:

(WebKit::ViewGestureController::beginSwipeGesture):
Get the IOSurfaceRef from the WebCore::IOSurface.

8:22 PM Changeset in webkit [166335] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Convert more of HTMLConverter to C++
​https://bugs.webkit.org/show_bug.cgi?id=130811

Reviewed by Anders Carlsson.

  • editing/cocoa/HTMLConverter.mm:

(HTMLConverter::HTMLConverter):
(HTMLConverter::~HTMLConverter):
(HTMLConverter::_blockLevelElementForNode):
(HTMLConverter::_colorForElement):
(HTMLConverter::_computedAttributesForElement):
(HTMLConverter::_attributesForElement):
(HTMLConverter::_fillInBlock):
(HTMLConverter::_enterElement):
(HTMLConverter::_addTableForElement):
(HTMLConverter::_addTableCellForElement):
(HTMLConverter::_processElement):
(HTMLConverter::_exitElement):
(HTMLConverter::_getFloat): Deleted.
(HTMLConverter::_elementIsBlockLevel): Deleted.
(HTMLConverter::_elementHasOwnBackgroundColor): Deleted.
(HTMLConverter::_colorForNode): Deleted.

7:25 PM Changeset in webkit [166334] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

Fix the build: include UIKit headers inside the iOS #ifdef.

  • UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:
7:15 PM Changeset in webkit [166333] by Simon Fraser
  • 15 edits in trunk/Source

Hook up -webkit-overflow-scrolling:touch for iOS WK2
​https://bugs.webkit.org/show_bug.cgi?id=130809

Reviewed by Tim Horton.

Source/WebCore:

Get -webkit-overflow-scrolling: touch working for iOS WK2.

  • WebCore.exp.in:
  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::updateScrollingNode):
Send in ScrollingGeometry when we update scrolling nodes.

  • page/scrolling/AsyncScrollingCoordinator.h:
  • page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::updateScrollingNode):

  • page/scrolling/ios/ScrollingTreeScrollingNodeIOS.h:

Need to get to the scrolling layer in a subclass.
(WebCore::ScrollingTreeScrollingNodeIOS::scrollLayer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hasAcceleratedTouchScrolling): Remove code
that temporarily disabled touch-scrolling.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer): When we
update scrolling nodes, send in the right scrolling geometry.

Source/WebKit2:

  • UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.h:
  • UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:

(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateAfterChildren):
Set the content size of the UIScrollVIew based on the geometry.

  • UIProcess/ios/RemoteLayerTreeHostIOS.mm:

(WebKit::RemoteLayerTreeHost::createLayer): Make a UIScrollView if the
layer properties tell us that we have the scrolling behavior.

  • UIProcess/ios/WKContentView.mm:

(-[WKContentView initWithFrame:context:WebKit::configuration:WebKit::webView:]):
We need to allow user interaction in the _rootContentView so that events get to
nested UIScrollViews (this could be optimized in future).

  • UIProcess/mac/RemoteLayerTreeHost.h:
  • UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::updateLayerTree):
(WebKit::RemoteLayerTreeHost::createLayer): Need to pass RemoteLayerTreeTransaction::LayerProperties
in so we can get at the custom behavior.

6:54 PM Changeset in webkit [166332] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Add -[WKWebView stopLoading]
​https://bugs.webkit.org/show_bug.cgi?id=130812

Reviewed by Tim Horton.

  • UIProcess/API/Cocoa/WKWebView.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView stopLoading]):

6:48 PM Changeset in webkit [166331] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Assertion failure in RemoteLayerBackingStore::flush
​https://bugs.webkit.org/show_bug.cgi?id=130810
<rdar://problem/16439276>

Reviewed by Simon Fraser.

  • Shared/mac/RemoteLayerBackingStore.mm:

(RemoteLayerBackingStore::flush):
We don't always have backing store to flush, if platformCALayerDrawsContent() is false.
We also can't assert that we have a back surface, because the very first paint will not.

5:50 PM Changeset in webkit [166330] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix after r166307.

Not reviewed.

  • runtime/JSCell.h:
  • The inline function isAPIValueWrapper() should not be exported. This was causing a linkage error when building for 32-bit x86 on Mac.
4:58 PM Changeset in webkit [166329] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

Modernize the loops in InspectorPageAgent.cpp.

Also moves the check for hiddenFromInspector to a lower level.
This hides hidden resources from more places.

​https://bugs.webkit.org/show_bug.cgi?id=130803

Reviewed by Joseph Pecoraro.

  • inspector/InspectorPageAgent.cpp:

(WebCore::buildArrayForCookies):
(WebCore::cachedResourcesForFrame):
(WebCore::allResourcesURLsForFrame):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::loaderDetachedFromFrame):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):

4:51 PM Changeset in webkit [166328] by aestes@apple.com
  • 6 edits in trunk

[Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
​https://bugs.webkit.org/show_bug.cgi?id=130805

Reviewed by Dan Bernstein.

Source/WebKit2:

  • UIProcess/API/Cocoa/_WKDownloadDelegate.h:
  • UIProcess/Cocoa/DownloadClient.h:
  • UIProcess/Cocoa/DownloadClient.mm:

(WebKit::DownloadClient::DownloadClient):
(WebKit::DownloadClient::didFail):
(WebKit::DownloadClient::didCancel):

Tools:

  • TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:

(-[DownloadDelegate _download:didReceiveResponse:]):
(-[DownloadDelegate _downloadDidFinish:]):
(runTest):
(TEST):
(-[FailingDownloadDelegate _downloadDidFinish:]):
(-[FailingDownloadDelegate _download:didFailWithError:]):
(-[FailingDownloadDelegate _downloadDidCancel:]):
(-[CancelledDownloadDelegate _downloadDidStart:]):
(-[CancelledDownloadDelegate _downloadDidFinish:]):
(-[CancelledDownloadDelegate _download:didFailWithError:]):
(-[CancelledDownloadDelegate _downloadDidCancel:]):
(-[DownloadDelegate initWithSourceURL:]): Deleted.
(-[DownloadDelegate sourceURL]): Deleted.
(runTestWithNavigationDelegate): Deleted.

4:36 PM Changeset in webkit [166327] by andersca@apple.com
  • 3 edits in trunk/Tools

Change MiniBrowser to hold on to window controllers instead of windows
​https://bugs.webkit.org/show_bug.cgi?id=130797

Reviewed by Oliver Hunt.

  • MiniBrowser/mac/AppDelegate.h:
  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate init]):
(-[BrowserAppDelegate newWindow:]):
(-[BrowserAppDelegate browserWindowWillClose:]):
(-[BrowserAppDelegate applicationWillTerminate:]):
(-[BrowserAppDelegate frontmostBrowserWindowController]):

4:35 PM Changeset in webkit [166326] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

-[WKWebProcessPlugInNodeHandle HTMLInputElementIsUserEdited] and -HTMLTextAreaElementIsUserEdited do not return the correct values.

​https://bugs.webkit.org/show_bug.cgi?id=130804

Patch by Cody Krieger <​cjk@apple.com> on 2014-03-26
Reviewed by Dan Bernstein.

The existing implementations of these methods are mis-cased
("HTMLInputELementIsUserEdited" and "HTMLTextAreaELementIsUserEdited" —
note the "EL" in both cases). This results in us getting
auto-synthesized getters for the HTMLInputElementIsUserEdited and
HTMLTextAreaElementIsUserEdited properties, which will return NO
unconditionally.

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:

Fix the capitalization of -HTMLInputElementIsUserEdited and
-HTMLTextAreaElementIsUserEdited.

4:26 PM Changeset in webkit [166325] by thiago.lacerda@openbossa.org
  • 7 edits
    1 copy in trunk/Source/WebCore

Add platform implementation for RTCOfferAnswerOptions and RTCOfferOptions
​https://bugs.webkit.org/show_bug.cgi?id=130689

Reviewed by Eric Carlson.

RTCOfferAnswerOptions and RTCOfferOptions objects were being passed to platform class, causing a layer
violation.

  • Modules/mediastream/RTCOfferAnswerOptions.cpp:

(WebCore::RTCOfferAnswerOptions::initialize):
(WebCore::RTCOfferOptions::initialize):

  • Modules/mediastream/RTCOfferAnswerOptions.h:

(WebCore::RTCOfferAnswerOptions::requestIdentity):
(WebCore::RTCOfferAnswerOptions::privateOfferAnswerOptions):
(WebCore::RTCOfferAnswerOptions::RTCOfferAnswerOptions):
(WebCore::RTCOfferOptions::offerToReceiveVideo):
(WebCore::RTCOfferOptions::offerToReceiveAudio):
(WebCore::RTCOfferOptions::voiceActivityDetection):
(WebCore::RTCOfferOptions::iceRestart):
(WebCore::RTCOfferOptions::privateOfferOptions):
(WebCore::RTCOfferOptions::RTCOfferOptions):

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::createOffer):
(WebCore::RTCPeerConnection::createAnswer):

  • platform/mediastream/RTCOfferAnswerOptionsPrivate.h: Added.
  • platform/mediastream/RTCPeerConnectionHandler.h:
  • platform/mock/RTCPeerConnectionHandlerMock.cpp:

(WebCore::RTCPeerConnectionHandlerMock::createOffer):
(WebCore::RTCPeerConnectionHandlerMock::createAnswer):

  • platform/mock/RTCPeerConnectionHandlerMock.h:
4:17 PM Changeset in webkit [166324] by matthew_hanson@apple.com
  • 1 edit
    1 delete in branches/safari-537.75-branch/LayoutTests

Remove artifacts of local changes that made it into a versioning commit.

3:43 PM Changeset in webkit [166323] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Device scale factor should always be greater than 0.
​https://bugs.webkit.org/show_bug.cgi?id=130798

Reviewed by David Kilzer.

Rendering context requires a device scale factor > 0 so that we can map CSS pixels
to device pixels properly. Neither 0 nor a negative device pixel ratio are considered to be valid.

  • page/Page.cpp:

(WebCore::Page::setDeviceScaleFactor):

3:05 PM Changeset in webkit [166322] by mmaxfield@apple.com
  • 4 edits
    2 adds in trunk

Skipping underlines disregard points completely inside the underline rect
​https://bugs.webkit.org/show_bug.cgi?id=130800

Patch by Myles C. Maxfield <​mmaxfield@apple.com> on 2014-03-26
Reviewed by Dean Jackson.

Source/WebCore:

When determining bounds for underline skipping, endpoints of glyph contours
that lie entirely within the rect of the underline are ignored. This patch
makes these points affect the skipping regions the same way that intersections
do.

Test: fast/css3-text/css3-text-decoration/text-decoration-skip/glyph-inside-underline.html

  • platform/graphics/mac/FontMac.mm:

(WebCore::updateX): Refactored common code into a function
(WebCore::findPathIntersections): Test for endpoints which lie entirely within
the underline bounds

LayoutTests:

This test draws a glyph entire inside the underline. It should render the same
as it would without any underline at all.

  • fast/css3-text/css3-text-decoration/text-decoration-skip/resources/Litherum.svg: Added

an underscore glyph that would lie entirely within an underline

  • fast/css3-text/css3-text-decoration/text-decoration-skip/glyph-inside-underline.html:
3:02 PM Changeset in webkit [166321] by matthew_hanson@apple.com
  • 5 edits
    28 adds in branches/safari-537.75-branch

Versioning.

3:00 PM Changeset in webkit [166320] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-537.75.14

New tag.

2:45 PM Changeset in webkit [166319] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. iOS build fix after r166312. Soft link CMTimeRangeGetEnd.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
2:32 PM Changeset in webkit [166318] by aestes@apple.com
  • 3 edits in trunk/Source/WebKit2

[Cocoa] Expose DownloadProxy::cancel()
​https://bugs.webkit.org/show_bug.cgi?id=130799

Reviewed by Dan Bernstein.

  • UIProcess/API/Cocoa/_WKDownload.h:
  • UIProcess/API/Cocoa/_WKDownload.mm:

(-[_WKDownload cancel]):

2:20 PM Changeset in webkit [166317] by timothy@apple.com
  • 13 edits in trunk/Source

Propagate the hiddenFromInspector flag on ResourceRequest in
places when a new request a made or passed between processes.

​https://bugs.webkit.org/show_bug.cgi?id=130741

Reviewed by Joseph Pecoraro.

Source/WebCore:

  • WebCore.exp.in: Updated symbols for updateFromDelegatePreservingOldProperties.
  • platform/network/cf/ResourceRequest.h:
  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties): Added.
(WebCore::ResourceRequest::updateFromDelegatePreservingOldHTTPBody): Deleted.

  • platform/network/curl/ResourceRequest.h:

(WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties): Added.
(WebCore::ResourceRequest::updateFromDelegatePreservingOldHTTPBody): Deleted.

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties): Added.
(WebCore::ResourceRequest::updateFromDelegatePreservingOldHTTPBody): Deleted.

  • platform/network/soup/ResourceRequest.h:

(WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties): Added.
(WebCore::ResourceRequest::updateFromDelegatePreservingOldHTTPBody): Deleted.

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchWillSendRequest): Copy hiddenFromInspector to
the new request.

Source/WebKit2:

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::continueWillSendRequest): Use updateFromDelegatePreservingOldProperties.

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<ResourceRequest>::encode): Added hiddenFromInspector support.
(IPC::ArgumentCoder<ResourceRequest>::decode): Ditto.

  • WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp:

(WebKit::InjectedBundlePageResourceLoadClient::willSendRequestForFrame): Ditto.

2:06 PM Changeset in webkit [166316] by zoltan@webkit.org
  • 16 edits in trunk/Source/WebCore

[CSS Shapes] Remove no-longer-used shape-inside geometry code
​https://bugs.webkit.org/show_bug.cgi?id=130740

Reviewed by David Hyatt.

This patch removes shape-padding support, since it can be used only with shape-inside.
Shape-inside support has been removed in r166301.

No new tests needed, existing tests have been removed by r166301.

  • rendering/shapes/BoxShape.cpp:

(WebCore::BoxShape::shapePaddingLogicalBoundingBox): Deleted.
(WebCore::BoxShape::shapePaddingBounds): Deleted.
(WebCore::BoxShape::getIncludedIntervals): Deleted.
(WebCore::BoxShape::firstIncludedIntervalLogicalTop): Deleted.

  • rendering/shapes/BoxShape.h:
  • rendering/shapes/PolygonShape.cpp:

(WebCore::leftSide): Deleted.
(WebCore::isReflexVertex): Deleted.
(WebCore::computeShapePaddingBounds): Deleted.
(WebCore::PolygonShape::shapePaddingBounds): Deleted.
(WebCore::PolygonShape::getIncludedIntervals): Deleted.
(WebCore::firstFitRectInPolygon): Deleted.
(WebCore::aboveOrToTheLeft): Deleted.
(WebCore::PolygonShape::firstIncludedIntervalLogicalTop): Deleted.

  • rendering/shapes/PolygonShape.h:

(WebCore::PolygonShape::PolygonShape):

  • rendering/shapes/RasterShape.cpp:

(WebCore::RasterShapeIntervals::firstIncludedIntervalY): Deleted.
(WebCore::RasterShapeIntervals::getIncludedIntervals): Deleted.
(WebCore::RasterShape::paddingIntervals): Deleted.
(WebCore::RasterShape::getIncludedIntervals): Deleted.
(WebCore::RasterShape::firstIncludedIntervalLogicalTop): Deleted.

  • rendering/shapes/RasterShape.h:
  • rendering/shapes/RectangleShape.cpp:

(WebCore::ellipseYIntercept): Deleted.
(WebCore::RectangleShape::shapePaddingBounds): Deleted.
(WebCore::RectangleShape::getIncludedIntervals): Deleted.
(WebCore::cornerInterceptForWidth): Deleted.
(WebCore::RectangleShape::firstIncludedIntervalLogicalTop): Deleted.

  • rendering/shapes/RectangleShape.h:
  • rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape):
(WebCore::Shape::createRasterShape):
(WebCore::Shape::createBoxShape):

  • rendering/shapes/Shape.h:

(WebCore::Shape::lineOverlapsShapePaddingBounds): Deleted.
(WebCore::Shape::shapePadding): Deleted.

  • rendering/shapes/ShapeInfo.cpp:

(WebCore::ShapeInfo<RenderType>::computedShape):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresLayout):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:
2:04 PM Changeset in webkit [166315] by aestes@apple.com
  • 3 edits in trunk/Source/WebKit2

[Cocoa] Expose DownloadProxy::request()
​https://bugs.webkit.org/show_bug.cgi?id=130796

Reviewed by Anders Carlsson.

  • UIProcess/API/Cocoa/_WKDownload.h:
  • UIProcess/API/Cocoa/_WKDownload.mm:

(-[_WKDownload request]):

1:56 PM Changeset in webkit [166314] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Pass a real FrameLoadRequest to Chrome::createWindow
​https://bugs.webkit.org/show_bug.cgi?id=130795

Reviewed by Dan Bernstein.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchCreatePage):

1:49 PM Changeset in webkit [166313] by fpizlo@apple.com
  • 5 edits
    2 adds in trunk/Source/JavaScriptCore

Reasoning about DWARF register numbers should be moved out of FTL::Location
​https://bugs.webkit.org/show_bug.cgi?id=130792

Reviewed by Oliver Hunt.

Moving this code makes it possible for things other than FTL::Location to reason about
DWARF register encoding. This refactoring also appears to reduce some code duplication
and makes FTLLocation.cpp cleaner.

(JSC::FTL::fixFunctionBasedOnStackMaps):

  • ftl/FTLDWARFRegister.cpp: Added.

(JSC::FTL::DWARFRegister::reg):
(JSC::FTL::DWARFRegister::dump):

  • ftl/FTLDWARFRegister.h: Added.

(JSC::FTL::DWARFRegister::DWARFRegister):
(JSC::FTL::DWARFRegister::dwarfRegNum):

  • ftl/FTLLocation.cpp:

(JSC::FTL::Location::dump):
(JSC::FTL::Location::isGPR):
(JSC::FTL::Location::gpr):
(JSC::FTL::Location::isFPR):
(JSC::FTL::Location::fpr):

  • ftl/FTLLocation.h:

(JSC::FTL::Location::hasDwarfReg):
(JSC::FTL::Location::dwarfReg):

1:17 PM Changeset in webkit [166312] by commit-queue@webkit.org
  • 12 edits in trunk/Source

Implement hasLiveStreamingContent property in WebAVPlayerController
​https://bugs.webkit.org/show_bug.cgi?id=128684

Patch by Jeremy Jones <​jeremyj@apple.com> on 2014-03-26
Reviewed by Simon Fraser.

Source/WebCore:

  • WebCore.exp.in:

Add export for WebVideoFullscreenInterfaceAVKit::setSeekableRanges().

  • platform/ios/WebVideoFullscreenInterface.h:

Add setSeekableRanges()

  • platform/ios/WebVideoFullscreenInterfaceAVKit.h:

Add setSeekableRanges()

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

Remove vestigial playerLayer property. Add seekableTimeRanges property.

(-[WebAVPlayerController dealloc]):
Release _seekableTimeRanges.
Remove references to _playerLayer.

(-[WebAVPlayerController hasLiveStreamingContent]):
Implement based on duration. Live stream has an infinite duration.

(+[WebAVPlayerController keyPathsForValuesAffectingHasLiveStreamingContent]):
Describe dependent keys for computed property hasLiveStreamingContent.

(-[WebAVPlayerController skipBackwardThirtySeconds:]):
Seek back 30 seconds if that time is in the seekable ranges.

(-[WebAVPlayerController gotoEndOfSeekableRanges:]):
Jump to live by going to the of the seekable ranges.

(WebVideoFullscreenInterfaceAVKit::setSeekableRanges):
Convert TimeRange to CMTimeRange.

  • platform/ios/WebVideoFullscreenModelMediaElement.mm:

(WebVideoFullscreenModelMediaElement::setMediaElement):
Set initial seekable ranges.

(WebVideoFullscreenModelMediaElement::handleEvent):
Update seekable ranges when time changes.

Source/WebKit2:

Plumb through the seekable ranges to the fullscreen interface.

  • UIProcess/ios/WebVideoFullscreenManagerProxy.h:

Add declaration for setSeekableRangesVector()

  • UIProcess/ios/WebVideoFullscreenManagerProxy.messages.in:

Add interface SetSeekableRangesVector()

  • UIProcess/ios/WebVideoFullscreenManagerProxy.mm:

(WebKit::WebVideoFullscreenManagerProxy::setSeekableRangesVector):
Add setSeekableRangesVector that translates the vector into a TimeRanges and calls setSeekableRanges()

  • WebProcess/ios/WebVideoFullscreenManager.h:

Add setSeekableRanges()

  • WebProcess/ios/WebVideoFullscreenManager.mm:

(WebKit::WebVideoFullscreenManager::setSeekableRanges):
setSeekableRanges() converts TimeRanges to Vector and calls SetSeekableRangesVector()

12:52 PM Changeset in webkit [166311] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

Fix OS X build.

  • WebCore.exp.in: Add missing export symbol.
12:42 PM Changeset in webkit [166310] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Fix the Windows build. Add a no-op impl for Mac non-UI-side.

  • platform/graphics/ca/mac/PlatformCALayerMac.h:
  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayerWin::PlatformCALayerWin):

  • platform/graphics/ca/win/PlatformCALayerWin.h:
12:36 PM Changeset in webkit [166309] by Simon Fraser
  • 3 edits
    2 adds in trunk

REGRESSION (r155977): matrix animations no longer animate
​https://bugs.webkit.org/show_bug.cgi?id=130789
<rdar://problem/15650946>

Source/WebCore:

Reviewed by Dean Jackson.

r155977 erroneously removed two lines that set the end points for
matrix animations (used when transform lists don't match), so
put them back.

Also don't repaint when updateContentsScale()
is called and doesn't change the contents scale.

Test: compositing/animation/matrix-animation.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateRootRelativeScale):
(WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerCA::updateContentsScale):

LayoutTests:

Reviewed by Dean Jackson.

Add test for fill-fowards animation with mismatched transform lists.

  • compositing/animation/matrix-animation-expected.html: Added.
  • compositing/animation/matrix-animation.html: Added.
12:36 PM Changeset in webkit [166308] by Simon Fraser
  • 15 edits in trunk/Source

Add a custom behavior flag to GraphicsLayer, piped down to PlatformCALayer, for scrolling layers
​https://bugs.webkit.org/show_bug.cgi?id=130778

Reviewed by Tim Horton.

Make it possible to put a "custom behavior" flag on a layer so that,
with UI-side compositing, we know to create a specific type of
layer or view for that GraphicsLayer.

Source/WebCore:

  • WebCore.exp.in:
  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::GraphicsLayer):

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::setCustomBehavior):
(WebCore::GraphicsLayer::customBehavior):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::updateCustomBehavior):
(WebCore::GraphicsLayerCA::setCustomBehavior):

  • platform/graphics/ca/GraphicsLayerCA.h:
  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/mac/PlatformCALayerMac.h:
  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayerMac::PlatformCALayerMac):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateScrollingLayers):

Source/WebKit2:

  • Shared/mac/RemoteLayerTreeTransaction.h:
  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::dumpChangedLayers):

  • WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::customBehavior):
(PlatformCALayerRemote::updateCustomBehavior):

  • WebProcess/WebPage/mac/PlatformCALayerRemote.h:
12:21 PM Changeset in webkit [166307] by Brent Fulgham
  • 7 edits in trunk/Source

Source/JavaScriptCore: Unreviewed build fix.

  • runtime/JSCell.h: VS2013 confused about argument type.

Source/WebCore: Unreviewed test correction.

Because of the way DRT on Windows links to WebCore, having the implementaion of the update
method in the header caused a runtime failure due to duplicate symbols being bound to the
compilation unit.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::setEnhancedUserInterfaceAccessibility): Moved from header.

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::setEnhancedUserInterfaceAccessibility): Deleted.

Source/WebKit: Unreviewed build/test correction.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Export the AXObjectCache::setEnhancedUserInterfaceEnabled

set function.

12:20 PM Changeset in webkit [166306] by matthew_hanson@apple.com
  • 2 edits in branches/safari-537.75-branch/Source/WebCore

Remove extraneous ! from merge of r166304.

12:17 PM Changeset in webkit [166305] by matthew_hanson@apple.com
  • 2 edits in branches/safari-537.75-branch/Source/WebCore

Merge r166304.

11:37 AM Changeset in webkit [166304] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(r162679): Poster image visible under the video
​https://bugs.webkit.org/show_bug.cgi?id=130783

Reviewed by Simon Fraser.

In the listed revision, we started checking for isRenderImage()
instead of isImage(). RenderMedias return 'true' for the first
but 'false' for the second. Change the if() statement to check
for isRenderMedia() in addition to !isRenderImage().

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::isDirectlyCompositedImage):

11:35 AM Changeset in webkit [166303] by Antti Koivisto
  • 3 edits
    2 adds in trunk

Render tree construction is O(N2) in number of siblings
​https://bugs.webkit.org/show_bug.cgi?id=129065

Source/WebCore:

Reviewed by Darin Adler.

When adding a new renderer to the tree we would search for the correct render tree
position by traversing DOM children forward to find something that already has a renderer.
In common case there is no such renderer. This would be repeated for each inserted renderer
leading to O(n2) in respect to child node count.

This patch caches the computed render tree insertion position and passes it to siblings.
Until the cached position is reached it can be used for all new renderers.

Test: perf/sibling-renderer-On2.html

  • style/StyleResolveTree.cpp:

(WebCore::Style::RenderTreePosition::parent):
(WebCore::Style::RenderTreePosition::RenderTreePosition):
(WebCore::Style::RenderTreePosition::canInsert):
(WebCore::Style::RenderTreePosition::insert):
(WebCore::Style::RenderTreePosition::computeNextSibling):
(WebCore::Style::RenderTreePosition::invalidateNextSibling):
(WebCore::Style::styleForElement):
(WebCore::Style::elementInsideRegionNeedsRenderer):
(WebCore::Style::createRendererIfNeeded):
(WebCore::Style::createTextRendererIfNeeded):
(WebCore::Style::attachTextRenderer):
(WebCore::Style::updateTextRendererAfterContentChange):
(WebCore::Style::attachChildren):
(WebCore::Style::attachDistributedChildren):
(WebCore::Style::attachShadowRoot):
(WebCore::Style::attachBeforeOrAfterPseudoElementIfNeeded):
(WebCore::Style::attachRenderTree):
(WebCore::Style::resolveLocal):
(WebCore::Style::resolveTextNode):
(WebCore::Style::resolveShadowTree):
(WebCore::Style::updateBeforeOrAfterPseudoElement):
(WebCore::Style::resolveTree):

LayoutTests:

Reviewed by Darin Adler.

  • perf/sibling-renderer-On2-expected.txt: Added.
  • perf/sibling-renderer-On2.html: Added.


The test doesn't use magnitude-perf.js as this requires a relatively long-running test function and
it seemed unsuitable for that.

11:31 AM Changeset in webkit [166302] by commit-queue@webkit.org
  • 5 edits in trunk

Unreviewed, rolling out r166264.
​https://bugs.webkit.org/show_bug.cgi?id=130785

Broke some window.opener tests for WK2 Mavericks (Requested by
brrian on #webkit).

Reverted changeset:

Source/WebCore:

"Web Replay: resource unique identifiers should be unique-per-
frame, not globally"
​https://bugs.webkit.org/show_bug.cgi?id=130632
​http://trac.webkit.org/changeset/166264

Tools:

"Web Replay: resource unique identifiers should be unique-per-
frame, not globally"
​https://bugs.webkit.org/show_bug.cgi?id=130632
​http://trac.webkit.org/changeset/166264

11:20 AM Changeset in webkit [166301] by zoltan@webkit.org
  • 54 edits
    12 deletes in trunk

[CSS Shapes] Remove shape-inside support
​https://bugs.webkit.org/show_bug.cgi?id=130698

Reviewed by David Hyatt.

.:

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

CSS Shapes Level 1 (CR) only contains shape-outside. We are focusing our efforts on finalizing
the implementation of shape-outside, it's worth to remove shape-inside code at this point for now.

A list of reasons for the removal:

  • Shape-inside is only part of Shapes Level 2, which needs to be improved on some topics.
  • Shape-inside is lack of new shapes support (e.g. inset).
  • Deprecated shapes (r165472) are removed from the code (e.g. rectangle), which affects shape-inside.
  • The current shape-inside code spreads across the layout code.
  • The current shape-inside implementation is experimental in some areas, and the partially implemented code can have security implications.
  • Removal of shape-inside opens possibilities for code complexity and performance optimizations for shape-outside. (e.g. simpler geometry code)

No new tests are needed.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.list.am:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSParser.cpp:

(WebCore::isSimpleLengthPropertyID):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseShapeProperty):

  • css/CSSPropertyNames.in:
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::loadPendingImages):

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

  • rendering/LayoutState.h:

(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::shapeInsideInfo): Deleted.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::imageChanged):
(WebCore::RenderBlock::preparePaginationBeforeBlockLayout):
(WebCore::RenderBlock::relayoutShapeDescendantIfMoved): Deleted.
(WebCore::RenderBlock::logicalOffsetFromShapeAncestorContainer): Deleted.
(WebCore::RenderBlock::updateShapeInsideInfoAfterStyleChange): Deleted.
(WebCore::RenderBlock::ensureShapeInsideInfo): Deleted.
(WebCore::RenderBlock::shapeInsideInfo): Deleted.
(WebCore::RenderBlock::setShapeInsideInfo): Deleted.
(WebCore::RenderBlock::markShapeInsideDescendantsForLayout): Deleted.
(WebCore::RenderBlock::layoutShapeInsideInfo): Deleted.
(WebCore::shapeInfoRequiresRelayout): Deleted.
(WebCore::RenderBlock::computeShapeSize): Deleted.
(WebCore::RenderBlock::updateShapesBeforeBlockLayout): Deleted.
(WebCore::RenderBlock::updateShapesAfterBlockLayout): Deleted.
(WebCore::RenderBlock::prepareShapesAndPaginationBeforeBlockLayout): Deleted.

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::allowsShapeInsideInfoSharing): Deleted.

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::RenderBlockFlow::computeLogicalLocationForFloat):

  • rendering/RenderBlockFlow.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
(WebCore::constructBidiRunsForLine): Deleted.
(WebCore::pushShapeContentOverflowBelowTheContentBox): Deleted.
(WebCore::RenderBlockFlow::updateShapeAndSegmentsForCurrentLine): Deleted.
(WebCore::RenderBlockFlow::updateShapeAndSegmentsForCurrentLineInFlowThread): Deleted.
(WebCore::adjustLogicalLineTop): Deleted.
(WebCore::RenderBlockFlow::adjustLogicalLineTopAndLogicalHeightIfNeeded): Deleted.

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::~RenderElement):
(WebCore::RenderElement::initializeStyle):
(WebCore::RenderElement::setStyle):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):

  • rendering/RenderNamedFlowFragment.cpp:

(WebCore::RenderNamedFlowFragment::createStyle):

  • rendering/RenderView.h:
  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

  • rendering/line/BreakingContextInlineHeaders.h:

(WebCore::BreakingContext::handleText):
(WebCore::BreakingContext::handleEndOfLine):
(WebCore::updateSegmentsForShapes): Deleted.

  • rendering/line/LineBreaker.cpp:

(WebCore::LineBreaker::nextLineBreak):

  • rendering/line/LineWidth.cpp:

(WebCore::LineWidth::LineWidth):
(WebCore::LineWidth::updateAvailableWidth):
(WebCore::LineWidth::wrapNextToShapeOutside):
(WebCore::LineWidth::fitBelowFloats):
(WebCore::LineWidth::updateLineSegment): Deleted.
(WebCore::LineWidth::updateCurrentShapeSegment): Deleted.

  • rendering/line/LineWidth.h:
  • rendering/shapes/ShapeInsideInfo.cpp: Removed.
  • rendering/shapes/ShapeInsideInfo.h: Removed.
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresLayout):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

  • fast/regions/shape-inside/shape-inside-on-additional-regions-expected.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-additional-regions.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-first-region-block-content-expected.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-first-region-block-content.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-first-region-inline-content-expected.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-first-region-inline-content.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-multiple-autoheight-regions-expected.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-multiple-autoheight-regions.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-multiple-regions-bottom-adjustment-expected.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-multiple-regions-bottom-adjustment.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-regions-block-content-basic-overflow-shape-top-offset-expected.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-regions-block-content-basic-overflow-shape-top-offset.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-bottom-positioned-multiple-shapes-expected.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-bottom-positioned-multiple-shapes.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes-expected.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-regions-block-content-polygon-with-adjustment-expected.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-regions-block-content-polygon-with-adjustment.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-regions-expected.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-regions-inline-content-basic-overflow-shape-top-offset-expected.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-regions-inline-content-basic-overflow-shape-top-offset.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-regions-inline-content-expected.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-bottom-positioned-multiple-shapes-expected.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-bottom-positioned-multiple-shapes.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-multiple-shapes-expected.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-multiple-shapes.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-regions-inline-content-polygon-with-adjustment-expected.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-regions-inline-content-polygon-with-adjustment.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-regions-inline-content.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-regions.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-second-region-block-content-expected.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-second-region-block-content.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-second-region-inline-content-expected.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-second-region-inline-content.html: Removed.
  • fast/regions/shape-inside/shape-inside-recursive-layout-expected.html: Removed.
  • fast/regions/shape-inside/shape-inside-recursive-layout.html: Removed.
  • fast/regions/shape-inside/shape-inside-with-region-borders-expected.html: Removed.
  • fast/regions/shape-inside/shape-inside-with-region-borders.html: Removed.
  • fast/regions/shape-inside/shape-inside-with-region-padding-expected.html: Removed.
  • fast/regions/shape-inside/shape-inside-with-region-padding.html: Removed.
  • fast/shapes/css-shapes-disabled-expected.txt:
  • fast/shapes/css-shapes-disabled.html:
  • fast/shapes/css-shapes-enabled-expected.txt:
  • fast/shapes/css-shapes-enabled.html:
  • fast/shapes/parsing/parsing-shape-inside-expected.txt: Removed.
  • fast/shapes/parsing/parsing-shape-inside.html: Removed.
  • fast/shapes/parsing/parsing-shape-lengths-expected.txt:
  • fast/shapes/parsing/parsing-shape-lengths.html:
  • fast/shapes/parsing/parsing-shape-padding-expected.txt: Removed.
  • fast/shapes/parsing/parsing-shape-padding.html: Removed.
  • fast/shapes/parsing/parsing-test-utils.js:
  • fast/shapes/resources/multi-segment-polygon.js: Removed.
  • fast/shapes/resources/simple-polygon.js: Removed.
  • fast/shapes/resources/simple-rectangle.js: Removed.
  • fast/shapes/resources/svg-shape-001.svg: Removed.
  • fast/shapes/shape-inside/floats/shape-inside-floats-simple-expected.html: Removed.
  • fast/shapes/shape-inside/floats/shape-inside-floats-simple.html: Removed.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-left-triangle-block-content-expected.html: Removed.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-left-triangle-block-content.html: Removed.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-left-triangle-inline-content-expected.html: Removed.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-left-triangle-inline-content.html: Removed.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle-block-content-expected.html: Removed.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle-block-content.html: Removed.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle-expected.html: Removed.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle-inline-content-expected.html: Removed.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle-inline-content.html: Removed.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle.html: Removed.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-block-content-expected.html: Removed.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-block-content.html: Removed.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-inline-content-expected.html: Removed.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-inline-content.html: Removed.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content-expected.html: Removed.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content.html: Removed.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-right-triangle-block-content-expected.html: Removed.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-right-triangle-block-content.html: Removed.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-right-triangle-inline-content-expected.html: Removed.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-right-triangle-inline-content.html: Removed.
  • fast/shapes/shape-inside/shape-inside-animation-expected.txt: Removed.
  • fast/shapes/shape-inside/shape-inside-animation.html: Removed.
  • fast/shapes/shape-inside/shape-inside-bottom-edge-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-bottom-edge.html: Removed.
  • fast/shapes/shape-inside/shape-inside-box-sizing-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-box-sizing.html: Removed.
  • fast/shapes/shape-inside/shape-inside-calc-crash-expected.txt: Removed.
  • fast/shapes/shape-inside/shape-inside-calc-crash.html: Removed.
  • fast/shapes/shape-inside/shape-inside-circle-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-circle-padding-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-circle-padding.html: Removed.
  • fast/shapes/shape-inside/shape-inside-circle.html: Removed.
  • fast/shapes/shape-inside/shape-inside-coincident-vertices-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-coincident-vertices.html: Removed.
  • fast/shapes/shape-inside/shape-inside-collinear-vertices-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-collinear-vertices.html: Removed.
  • fast/shapes/shape-inside/shape-inside-complex-polygon-001-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-complex-polygon-001.html: Removed.
  • fast/shapes/shape-inside/shape-inside-complex-polygon-002-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-complex-polygon-002.html: Removed.
  • fast/shapes/shape-inside/shape-inside-complex-polygon-003-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-complex-polygon-003.html: Removed.
  • fast/shapes/shape-inside/shape-inside-complex-polygon-004-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-complex-polygon-004.html: Removed.
  • fast/shapes/shape-inside/shape-inside-content-box-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-content-box.html: Removed.
  • fast/shapes/shape-inside/shape-inside-counterclockwise-polygon-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-counterclockwise-polygon.html: Removed.
  • fast/shapes/shape-inside/shape-inside-dynamic-nested-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-dynamic-nested.html: Removed.
  • fast/shapes/shape-inside/shape-inside-dynamic-shape-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-dynamic-shape.html: Removed.
  • fast/shapes/shape-inside/shape-inside-dynamic-text-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-dynamic-text.html: Removed.
  • fast/shapes/shape-inside/shape-inside-ellipse-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-ellipse-padding-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-ellipse-padding.html: Removed.
  • fast/shapes/shape-inside/shape-inside-ellipse.html: Removed.
  • fast/shapes/shape-inside/shape-inside-empty-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-empty-polygon-crash-expected.txt: Removed.
  • fast/shapes/shape-inside/shape-inside-empty-polygon-crash.html: Removed.
  • fast/shapes/shape-inside/shape-inside-empty-segments-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-empty-segments.html: Removed.
  • fast/shapes/shape-inside/shape-inside-empty.html: Removed.
  • fast/shapes/shape-inside/shape-inside-first-fit-001-horizontal-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-first-fit-001-horizontal.html: Removed.
  • fast/shapes/shape-inside/shape-inside-first-fit-001-vertical-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-first-fit-001-vertical.html: Removed.
  • fast/shapes/shape-inside/shape-inside-first-fit-002-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-first-fit-002.html: Removed.
  • fast/shapes/shape-inside/shape-inside-first-fit-003-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-first-fit-003.html: Removed.
  • fast/shapes/shape-inside/shape-inside-first-fit-004-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-first-fit-004.html: Removed.
  • fast/shapes/shape-inside/shape-inside-first-fit-crash-expected.txt: Removed.
  • fast/shapes/shape-inside/shape-inside-first-fit-crash.html: Removed.
  • fast/shapes/shape-inside/shape-inside-first-fit-reflex-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-first-fit-reflex.html: Removed.
  • fast/shapes/shape-inside/shape-inside-image-001-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-image-001.html: Removed.
  • fast/shapes/shape-inside/shape-inside-image-002-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-image-002.html: Removed.
  • fast/shapes/shape-inside/shape-inside-image-003-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-image-003.html: Removed.
  • fast/shapes/shape-inside/shape-inside-image-004-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-image-004.html: Removed.
  • fast/shapes/shape-inside/shape-inside-image-005-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-image-005.html: Removed.
  • fast/shapes/shape-inside/shape-inside-image-set-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-image-set.html: Removed.
  • fast/shapes/shape-inside/shape-inside-multiple-blocks-dynamic-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-multiple-blocks-dynamic.html: Removed.
  • fast/shapes/shape-inside/shape-inside-multiple-blocks-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-multiple-blocks-vertical-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-multiple-blocks-vertical.html: Removed.
  • fast/shapes/shape-inside/shape-inside-multiple-blocks.html: Removed.
  • fast/shapes/shape-inside/shape-inside-multiple-segments-001-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-multiple-segments-001.html: Removed.
  • fast/shapes/shape-inside/shape-inside-multiple-segments-002-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-multiple-segments-002.html: Removed.
  • fast/shapes/shape-inside/shape-inside-multiple-segments-003-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-multiple-segments-003.html: Removed.
  • fast/shapes/shape-inside/shape-inside-multiple-segments-004-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-multiple-segments-004.html: Removed.
  • fast/shapes/shape-inside/shape-inside-offset-block-children-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-offset-block-children.html: Removed.
  • fast/shapes/shape-inside/shape-inside-on-nested-container-with-unresolved-height-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html: Removed.
  • fast/shapes/shape-inside/shape-inside-outside-shape-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-outside-shape.html: Removed.
  • fast/shapes/shape-inside/shape-inside-overflow-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-overflow-fixed-dimensions-block-content-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-overflow-fixed-dimensions-block-content.html: Removed.
  • fast/shapes/shape-inside/shape-inside-overflow-fixed-dimensions-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-overflow-fixed-dimensions.html: Removed.
  • fast/shapes/shape-inside/shape-inside-overflow.html: Removed.
  • fast/shapes/shape-inside/shape-inside-partial-fill-001-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-partial-fill-001.html: Removed.
  • fast/shapes/shape-inside/shape-inside-partial-fill-002-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-partial-fill-002.html: Removed.
  • fast/shapes/shape-inside/shape-inside-percentage-auto-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-percentage-auto.html: Removed.
  • fast/shapes/shape-inside/shape-inside-percentage-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-percentage.html: Removed.
  • fast/shapes/shape-inside/shape-inside-polygon-layout-expected.txt: Removed.
  • fast/shapes/shape-inside/shape-inside-polygon-layout.html: Removed.
  • fast/shapes/shape-inside/shape-inside-polygon-padding-001-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-polygon-padding-001.html: Removed.
  • fast/shapes/shape-inside/shape-inside-polygon-padding-002-expected.txt: Removed.
  • fast/shapes/shape-inside/shape-inside-polygon-padding-002.html: Removed.
  • fast/shapes/shape-inside/shape-inside-polygon-padding-003-expected.txt: Removed.
  • fast/shapes/shape-inside/shape-inside-polygon-padding-003.html: Removed.
  • fast/shapes/shape-inside/shape-inside-polygon-rectangle-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-polygon-rectangle.html: Removed.
  • fast/shapes/shape-inside/shape-inside-polygon-rounded-first-fit-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-polygon-rounded-first-fit.html: Removed.
  • fast/shapes/shape-inside/shape-inside-polygon-zoom-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-polygon-zoom.html: Removed.
  • fast/shapes/shape-inside/shape-inside-rectilinear-polygon-001-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-rectilinear-polygon-001.html: Removed.
  • fast/shapes/shape-inside/shape-inside-rectilinear-polygon-002-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-rectilinear-polygon-002.html: Removed.
  • fast/shapes/shape-inside/shape-inside-rectilinear-polygon-003-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-rectilinear-polygon-003.html: Removed.
  • fast/shapes/shape-inside/shape-inside-rectilinear-polygon-004-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-rectilinear-polygon-004.html: Removed.
  • fast/shapes/shape-inside/shape-inside-recursive-layout-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-recursive-layout.html: Removed.
  • fast/shapes/shape-inside/shape-inside-regular-polygon16-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-regular-polygon16.html: Removed.
  • fast/shapes/shape-inside/shape-inside-regular-polygon8-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-regular-polygon8.html: Removed.
  • fast/shapes/shape-inside/shape-inside-shape-logical-top-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-shape-logical-top.html: Removed.
  • fast/shapes/shape-inside/shape-inside-sibling-block-dimension-change-needs-relayout-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-sibling-block-dimension-change-needs-relayout.html: Removed.
  • fast/shapes/shape-inside/shape-inside-simple-polygon-001-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-simple-polygon-001.html: Removed.
  • fast/shapes/shape-inside/shape-inside-simple-polygon-002-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-simple-polygon-002.html: Removed.
  • fast/shapes/shape-inside/shape-inside-simple-polygon-003-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-simple-polygon-003.html: Removed.
  • fast/shapes/shape-inside/shape-inside-simple-polygon-004-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-simple-polygon-004.html: Removed.
  • fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html: Removed.
  • fast/shapes/shape-inside/shape-inside-subsequent-blocks-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-subsequent-blocks.html: Removed.
  • fast/shapes/shape-inside/shape-inside-subtract-intervals-crash-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-subtract-intervals-crash.html: Removed.
  • fast/shapes/shape-inside/shape-inside-text-align-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-text-align.html: Removed.
  • fast/shapes/shape-inside/shape-inside-text-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-text.html: Removed.
  • fast/shapes/shape-inside/shape-inside-vertical-text-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-vertical-text.html: Removed.
  • platform/gtk/TestExpectations:
  • platform/win/TestExpectations:
10:02 AM Changeset in webkit [166300] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

Avoid duplicate size checks when creating empty image
​https://bugs.webkit.org/show_bug.cgi?id=130730

Reviewed by Dean Jackson.

Merged from Blink (patch by ​ch.dumez@samsung.com):
​https://chromium.googlesource.com/chromium/blink/+/4861a71bc1f284fc97417f405ab7d08dc6947b88
​http://crbug.com/190633011

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::createEmptyImageData): Don't perform overflow calculation twice.

9:45 AM Changeset in webkit [166299] by svillar@igalia.com
  • 19 edits
    2 adds in trunk

[CSS Grid Layout] getComputedStyle() must return the specified value for positioning properties
​https://bugs.webkit.org/show_bug.cgi?id=130010

Reviewed by Darin Adler.

Source/WebCore:

According to the specs
​http://dev.w3.org/csswg/css-grid/#property-index and also to
​http://lists.w3.org/Archives/Public/www-style/2014Mar/0162.html
the function getComputedStyle() must return the specified values
for positioning properties, i.e, grid-{columns|rows}-{start|end}.

We were in some cases, adjusting the style in the StyleResolver
(for example with two opposing spans) something that is now done
in the RenderGrid because we cannot alter the original style.

The code moved to the renderer became more self explanatory and it
now supports named grid areas with names ending in "-start" and
"-end".

Test: fast/css-grid-layout/named-grid-lines-with-named-grid-areas-get-set.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::gridLineDefinedBeforeGridArea): Deleted.
(WebCore::StyleResolver::adjustNamedGridItemPosition): Deleted.
(WebCore::StyleResolver::adjustGridItemPosition): Deleted.

  • css/StyleResolver.h:
  • rendering/RenderGrid.cpp:

(WebCore::isColumnSide):
(WebCore::RenderGrid::explicitGridSizeForSide):
(WebCore::gridLineDefinedBeforeGridArea):
(WebCore::setNamedLinePositionIfDefinedBeforeArea):
(WebCore::RenderGrid::adjustNamedGridItemPosition):
(WebCore::RenderGrid::adjustGridPositionsFromStyle):
(WebCore::RenderGrid::resolveGridPositionsFromStyle):
(WebCore::RenderGrid::resolveNamedGridLinePositionFromStyle):
(WebCore::RenderGrid::resolveNamedGridLinePositionAgainstOppositePosition):

  • rendering/RenderGrid.h:
  • rendering/style/GridPosition.h:

(WebCore::GridPosition::setAutoPosition): New helper function.

LayoutTests:

Updated the return value of getComputedStyle(), it must be always
the specified value.

Added also a new test that verifies the resolution of names in
grid positioning properties, both grid area names and grid line
names (including any combination of the two).

  • fast/css-grid-layout/grid-item-area-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-area-get-set.html:
  • fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-column-row-get-set.html:
  • fast/css-grid-layout/grid-item-end-after-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-end-after-get-set.html:
  • fast/css-grid-layout/grid-item-spanning-resolution-expected.txt:
  • fast/css-grid-layout/grid-item-spanning-resolution.html:
  • fast/css-grid-layout/grid-item-start-before-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-start-before-get-set.html:
  • fast/css-grid-layout/named-grid-lines-with-named-grid-areas-get-set-expected.txt: Added.
  • fast/css-grid-layout/named-grid-lines-with-named-grid-areas-get-set.html: Added.
9:26 AM Changeset in webkit [166298] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix the iOS build.

  • WebCore.exp.in:
9:19 AM Changeset in webkit [166297] by Darin Adler
  • 5 edits in trunk/LayoutTests

Update LayoutTests to depend on load events rather than on starting loads synchronously
​https://bugs.webkit.org/show_bug.cgi?id=130776

Reviewed by Antti Koivisto.

These tests were depending on loads starting synchronously. Instead, they should simply
depend on proper load event behavior.

  • dom/html/level1/core/selfhtml.js:

(startTest): Call waitUntilDone immediately, not when the test starts.

  • dom/html/level2/core/selfhtml.js:

(startTest): Ditto.

  • dom/html/level2/events/selfhtml.js:

(startTest): Ditto.

  • dom/html/level2/html/selfhtml.js:

(startTest): Ditto.

8:25 AM Changeset in webkit [166296] by timothy_horton@apple.com
  • 6 edits in trunk/Source

[iOS WebKit2] Flush all surfaces after painting into all of them, instead of after painting into each one
​https://bugs.webkit.org/show_bug.cgi?id=130768
<rdar://problem/16421471>

Reviewed by Simon Fraser.

  • Shared/mac/RemoteLayerBackingStore.h:

Add flush(), which synchronously flushes painting operations on the underlying backing store.
Factor clearBackingStore() out of ensureBackingStore/display, which releases our reference to underlying backing store.
Add two members for storing the back surface and front buffer context until flush() is called.

  • We need to keep the back surface alive because the CGImageRef created from it is referenced by the front surface's drawing queue, and won't be freed until said queue is flushed. If we release the back surface (and its associated CGContextRef) *before* the CGImageRef is freed, we will do an expensive readback of the surface.
  • When not using accelerated drawing, we need to keep the front buffer's CGContextRef around until the flush occurs so that we can avoid re-creating it in order to perform the flush. This happens automatically in the accelerated drawing case via WebCore::IOSurface.
  • Shared/mac/RemoteLayerBackingStore.mm:

(RemoteLayerBackingStore::ensureBackingStore):
(RemoteLayerBackingStore::clearBackingStore):
(RemoteLayerBackingStore::display):
Factor clearBackingStore() out of ensureBackingStore() and display().
Update a comment about the above performance gotcha.
Store the current back surface/front buffer context.

(RemoteLayerBackingStore::drawInContext):
Don't flush the context immediately after painting.

(RemoteLayerBackingStore::applyBackingStoreToLayer):
Move things around to reduce duplicated code.

(RemoteLayerBackingStore::flush):
Flush the current front surface/buffer's context.
Clear the new pending-flush members.

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::flushBackingStoreChangesInTransaction):
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
Crawl through all of the valid changed backing stores in the transaction and flush them.
Remove a completely useless assertion.

  • platform/graphics/cocoa/IOSurface.h:

Add a non-ensuring platformContext() getter.

8:18 AM Changeset in webkit [166295] by commit-queue@webkit.org
  • 5 edits in trunk

Web Inspector: AXI: crash when inspecting "bar" text node in getAccessibilityPropertiesForNode layout test
​https://bugs.webkit.org/show_bug.cgi?id=130290

Patch by James Craig <​jcraig@apple.com> on 2014-03-26
Reviewed by Timothy Hatcher.

Source/WebCore:

Test: inspector-protocol/dom/getAccessibilityPropertiesForNode.html

Fixing regression from r165590. ​http://webkit.org/b/129779
Verify isElementNode to avoid calling toElement on document or text nodes.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):

LayoutTests:

Updating test to include properties for document node.

  • inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt:
  • inspector-protocol/dom/getAccessibilityPropertiesForNode.html:
8:12 AM Changeset in webkit [166294] by svillar@igalia.com
  • 7 edits in trunk/Source/WebCore

Replace DEPRECATED_DEFINE_STATIC_LOCAL by static NeverDestroyed<T> in editing/
​https://bugs.webkit.org/show_bug.cgi?id=130722

Reviewed by Antti Koivisto.

  • editing/AlternativeTextController.cpp:

(WebCore::markerTypesForAutocorrection):
(WebCore::markerTypesForReplacement):
(WebCore::markerTypesForAppliedDictationAlternative):

  • editing/EditingStyle.cpp:

(WebCore::htmlElementEquivalents):
(WebCore::htmlAttributeEquivalents):

  • editing/FormatBlockCommand.cpp:

(WebCore::isElementForFormatBlock):

  • editing/RemoveFormatCommand.cpp:

(WebCore::isElementForRemoveFormatCommand):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::isProhibitedParagraphChild):

  • editing/atk/FrameSelectionAtk.cpp:

(WebCore::maybeEmitTextFocusChange):

8:09 AM Changeset in webkit [166293] by Simon Fraser
  • 29 edits
    2 copies
    1 add in trunk/Source

Add a new type of scrolling tree node for overflow scrolling
​https://bugs.webkit.org/show_bug.cgi?id=130763

Reviewed by Tim Horton.

Prepare for overflow scrolling via the scrolling tree by adding
a new scrolling node type for overflow:scroll nodes. Mostly
this is a new ScrollingNodeType that gets mapped to the same
scrolling state nodes and scrolling nodes, but iOS creates
state and scrolling nodes specific to overflow:scroll.

Change the type checking on nodes to use virtual functions instead
of just checking the node type, to allow the macros to work with
the new scrolling node type.

Source/WebCore:

  • WebCore.exp.in:
  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::ensureRootStateNodeForFrameView):

  • page/scrolling/ScrollingCoordinator.h:
  • page/scrolling/ScrollingStateFixedNode.h:
  • page/scrolling/ScrollingStateNode.h:

(WebCore::ScrollingStateNode::isFixedNode):
(WebCore::ScrollingStateNode::isStickyNode):
(WebCore::ScrollingStateNode::isScrollingNode):

  • page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::create):
(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):

  • page/scrolling/ScrollingStateScrollingNode.h:
  • page/scrolling/ScrollingStateStickyNode.h:
  • page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::attachNode):

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::viewportChangedViaDelegatedScrolling):
(WebCore::ScrollingTree::updateTreeFromStateNode):

  • page/scrolling/ScrollingTreeNode.h:

(WebCore::ScrollingTreeNode::isFixedNode):
(WebCore::ScrollingTreeNode::isStickyNode):
(WebCore::ScrollingTreeNode::isScrollingNode):

  • page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::ScrollingTreeScrollingNode):

  • page/scrolling/ScrollingTreeScrollingNode.h:
  • page/scrolling/ios/ScrollingCoordinatorIOS.mm:

(WebCore::ScrollingCoordinatorIOS::createScrollingTreeNode):

  • page/scrolling/ios/ScrollingTreeScrollingNodeIOS.h:
  • page/scrolling/ios/ScrollingTreeScrollingNodeIOS.mm:

(WebCore::ScrollingTreeScrollingNodeIOS::create):
(WebCore::ScrollingTreeScrollingNodeIOS::ScrollingTreeScrollingNodeIOS):

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::createScrollingTreeNode):

  • page/scrolling/mac/ScrollingTreeFixedNode.h:
  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:
  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::create):
(WebCore::ScrollingTreeScrollingNodeMac::ScrollingTreeScrollingNodeMac):

  • page/scrolling/mac/ScrollingTreeStickyNode.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):

Source/WebKit2:

  • Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:

(WebKit::encodeNodeAndDescendants):
(WebKit::RemoteScrollingCoordinatorTransaction::decode):

  • UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers):

  • UIProcess/Scrolling/RemoteScrollingTree.cpp:

(WebKit::RemoteScrollingTree::createNode):

  • UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.h: Copied from Source/WebCore/page/scrolling/mac/ScrollingTreeFixedNode.h.
  • UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm: Copied from Source/WebCore/page/scrolling/mac/ScrollingTreeFixedNode.h.

(WebKit::ScrollingTreeOverflowScrollingNodeIOS::create):
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::ScrollingTreeOverflowScrollingNodeIOS):
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::~ScrollingTreeOverflowScrollingNodeIOS):

  • UIProcess/ios/RemoteScrollingCoordinatorProxyIOS.mm:

(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers):

  • WebKit2.xcodeproj/project.pbxproj:
8:08 AM Changeset in webkit [166292] by Dániel Bátyai
  • 15 edits in trunk/Source/JavaScriptCore

Rename hasFastArrayStorage to be more appropriate
​https://bugs.webkit.org/show_bug.cgi?id=130773

Reviewed by Filip Pizlo.

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::alreadyChecked):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGWatchpointCollectionPhase.cpp:

(JSC::DFG::WatchpointCollectionPhase::handle):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNewArray):
(JSC::FTL::LowerDFGToLLVM::compileNewArrayBuffer):
(JSC::FTL::LowerDFGToLLVM::compileNewArrayWithSize):

  • runtime/ButterflyInlines.h:

(JSC::Butterfly::unshift):
(JSC::Butterfly::shift):

  • runtime/IndexingHeaderInlines.h:

(JSC::IndexingHeader::preCapacity):

  • runtime/IndexingType.h:

(JSC::hasArrayStorage):
(JSC::hasAnyArrayStorage):
(JSC::hasFastArrayStorage): Deleted.

  • runtime/JSArray.cpp:

(JSC::JSArray::sortVector):
(JSC::JSArray::compactForSorting):

  • runtime/JSArray.h:

(JSC::JSArray::create):
(JSC::JSArray::tryCreateUninitialized):

  • runtime/JSGlobalObject.cpp:
  • runtime/JSObject.cpp:

(JSC::JSObject::putDirectIndexBeyondVectorLengthWithArrayStorage):

  • runtime/JSObject.h:

(JSC::JSObject::ensureArrayStorage):
(JSC::JSObject::arrayStorage):

  • runtime/StructureTransitionTable.h:

(JSC::newIndexingType):

8:03 AM Changeset in webkit [166291] by k.gurpreet@webkit.org
  • 2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

  • Scripts/webkitpy/common/config/contributors.json:
4:11 AM Changeset in webkit [166290] by Manuel Rego Casasnovas
  • 3 edits in trunk/LayoutTests

[CSS Grid Layout] Prevent issues with checkLayout() in grid items
​https://bugs.webkit.org/show_bug.cgi?id=130770

Reviewed by Sergio Villar Senin.

When we use checkLayout() on a grid item, the results (PASS or FAIL
messages) are added as new auto-placed items in the grid. Which might
cause some unexpected behavior in the tests.

This patch modifies the related layout tests to use a different
container (usually the parent node of the grid) for the test results.
Avoiding any kind of interference with the grid code.

  • fast/css-grid-layout/grid-item-addition-auto-placement-update.html: Use parent node of grid when checking grid items. Check layout of the whole grid instead of grid item.
  • fast/css-grid-layout/grid-item-removal-auto-placement-update.html: Check layout of the whole grid instead of grid item.
3:17 AM Changeset in webkit [166289] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

run-launcher is Perl script so use elsif and not elif
​https://bugs.webkit.org/show_bug.cgi?id=130771

Patch by Tomas Popela <​tpopela@redhat.com> on 2014-03-26
Reviewed by Carlos Garcia Campos.

  • Scripts/run-launcher:
3:16 AM Changeset in webkit [166288] by k.czech@samsung.com
  • 8 edits in trunk

[ATK] Utilize new AtkValue interface coming in ATK 2.11.92
​https://bugs.webkit.org/show_bug.cgi?id=130575

Reviewed by Mario Sanchez Prada.

Source/WebCore:

ATK 2.11.92 introduces some new API and deprecates an old one.
Adjust current implementation to meet requirements of the new API.

No new tests. Covered by existing ones.

  • accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

  • accessibility/atk/WebKitAccessibleInterfaceValue.cpp:

(webkitAccessibleSetNewValue):
(webkitAccessibleGetIncrementValue):
(webkitAccessibleGetValueAndText):
(webkitAccessibleGetIncrement):
(webkitAccessibleSetValue):
(webkitAccessibleGetRange):
(webkitAccessibleValueSetCurrentValue):
(webkitAccessibleValueGetMinimumIncrement):
(webkitAccessibleValueInterfaceInit):

Tools:

Change ATK version to 2.11.92. Adjust current implementation.

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::intValue):
(AccessibilityUIElement::minValue):
(AccessibilityUIElement::maxValue):

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::intValue):
(WTR::AccessibilityUIElement::minValue):
(WTR::AccessibilityUIElement::maxValue):

  • efl/jhbuild.modules:
  • gtk/jhbuild.modules:
2:09 AM Changeset in webkit [166287] by zandobersek@gmail.com
  • 4 edits
    4 deletes in trunk/Source

Unreviewed. Removing the remaining Automake cruft.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Removed.

Source/WebCore:

  • GNUmakefile.list.am: Removed.

Source/WebKit2:

  • GNUmakefile.list.am: Removed.

Source/WTF:

  • GNUmakefile.list.am: Removed.
12:33 AM Changeset in webkit [166286] by Philippe Normand
  • 2 edits
    2 deletes in trunk/Tools

[GTK] The gnumake package is no longer needed in jhbuild
​https://bugs.webkit.org/show_bug.cgi?id=130121

Reviewed by Martin Robinson.

For GTK build-webkit now relies on cmake and ninja/gnumake. Even
for a debug build cmake/system-gnumake worked just fine for me.

  • gtk/jhbuild.modules: Removed gnumake.
  • gtk/patches/make-3.82-arg-list-length.patch: Removed.
  • gtk/patches/make-3.82-parallel-build.patch: Removed.
12:03 AM Changeset in webkit [166285] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Blog-files: combobox demo needs aria-expanded support
​https://bugs.webkit.org/show_bug.cgi?id=130766

Patch by James Craig <​jcraig@apple.com> on 2014-03-25
Reviewed by Chris Fleizach.

  • blog-files/aria1.0/combobox_with_live_region_status.html: Added missing aria-expanded.
Note: See TracTimeline for information about the timeline view.