⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 8, 2014:

11:31 PM Changeset in webkit [167003] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

nil should only be used for objects
​https://bugs.webkit.org/show_bug.cgi?id=131431

Patch by Conrad Shultz <Conrad Shultz> on 2014-04-08
Reviewed by Chris Fleizach.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
nil -> NO.

  • platform/mac/WebVideoFullscreenController.mm:

(-[WebVideoFullscreenController setMediaElement:]):
nil -> 0; change a NULL to nullptr while we're here.

11:25 PM Changeset in webkit [167002] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

Fix EFL Build errors since r166975.
​https://bugs.webkit.org/show_bug.cgi?id=131421

Patch by Hyowon Kim <​hw1008.kim@samsung.com> on 2014-04-08
Reviewed by Gyuyoung Kim.

This patch is just for fixing EFL build errors.
The page overlay functionality is not working yet.

  • CMakeLists.txt:
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:

(WebKit::CoordinatedDrawingArea::display):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::paintLayerContents):

  • WebProcess/WebPage/PageOverlayController.cpp:
  • WebProcess/WebPage/TapHighlightController.cpp:

(WebKit::TapHighlightController::hideHighlight):

11:18 PM Changeset in webkit [167001] by mihnea@adobe.com
  • 4 edits
    2 adds in trunk

[CSSRegions] Crash when video in region exits fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=131366

Reviewed by Andrei Bucur.

Source/WebCore:

After fix for ​https://bugs.webkit.org/show_bug.cgi?id=130392, we compute the region ranges
information for inline elements collected in named flows with associated region chains.
The algorithm for this computation, implemented in RenderFlowThread::getRegionRangeForBox,
walks up the render tree trying to find the top-most unsplittable box under the named flow
in the case where the region ranges information is not available.

As this traversal works properly only when the starting box is not detached from the render tree,
i changed the named flow information clearing in RenderBlock::collapseAnonymousBoxChild
to occur before the child to be collapsed is removed from the render tree.

Test: fast/regions/full-screen-video-in-region-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::collapseAnonymousBoxChild):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::getRegionRangeForBox):

LayoutTests:

  • fast/regions/full-screen-video-in-region-crash-expected.txt: Added.
  • fast/regions/full-screen-video-in-region-crash.html: Added.
11:13 PM Changeset in webkit [167000] by ap@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Trying to unbreak flakiness dashboard after Gtk TextExpectations reshuffling.

  • platform/gtk-wk2/TestExpectations: Added.
10:25 PM Changeset in webkit [166999] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for iOS (redux).

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityARIAIsBusy]):
(-[WebAccessibilityObjectWrapper accessibilityARIALiveRegionIsAtomic]):

10:23 PM Changeset in webkit [166998] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for iOS.

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityElementCount]):

10:01 PM Changeset in webkit [166997] by Antti Koivisto
  • 7 edits
    2 adds in trunk/Source/WebCore

Factor tile coverage map into a class
​https://bugs.webkit.org/show_bug.cgi?id=131417

Reviewed by Tim Horton.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/ca/PlatformCALayerClient.h:

(WebCore::PlatformCALayerClient::platformCALayerLayoutSublayersOfLayer):
(WebCore::PlatformCALayerClient::platformCALayerRespondsToLayoutChanges):
(WebCore::PlatformCALayerClient::platformCALayerAnimationStarted):
(WebCore::PlatformCALayerClient::platformCALayerContentsOrientation):
(WebCore::PlatformCALayerClient::platformCALayerShowDebugBorders):
(WebCore::PlatformCALayerClient::platformCALayerShowRepaintCounter):
(WebCore::PlatformCALayerClient::platformCALayerIncrementRepaintCount):
(WebCore::PlatformCALayerClient::platformCALayerLayerDidDisplay):

Added default implementation to some of these to make clients less messy.

  • platform/graphics/ca/mac/TileController.h:
  • platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::~TileController):
(WebCore::TileController::platformCALayerPaintContents):
(WebCore::TileController::setTiledScrollingIndicatorPosition):
(WebCore::TileController::updateTileCoverageMap):
(WebCore::TileController::tiledScrollingIndicatorLayer):

  • platform/graphics/ca/mac/TileCoverageMap.h: Added.

(WebCore::TileCoverageMap::setPosition):
(WebCore::TileCoverageMap::layer):

  • platform/graphics/ca/mac/TileCoverageMap.mm: Added.


The new class.

(WebCore::TileCoverageMap::TileCoverageMap):
(WebCore::TileCoverageMap::~TileCoverageMap):
(WebCore::TileCoverageMap::update):
(WebCore::TileCoverageMap::platformCALayerPaintContents):
(WebCore::TileCoverageMap::platformCALayerDeviceScaleFactor):

  • platform/graphics/ca/mac/TileGrid.h:
  • platform/graphics/ca/mac/TileGrid.mm:

(WebCore::TileGrid::drawTileMapContents):

9:43 PM April 2014 Meeting edited by Simon Fraser
(diff)
9:07 PM April 2014 Meeting edited by bfulgham@webkit.org
(diff)
8:52 PM Changeset in webkit [166996] by Alan Bujtas
  • 3 edits
    2 adds in trunk

Subpixel rendering: Clip outer rounded border rect on device pixel boundaries.
​https://bugs.webkit.org/show_bug.cgi?id=131404

Reviewed by Simon Fraser.

Use device pixel snapped rectangle to clip out rounded rects, when not all sides are solid/double.
Snapping it to device pixel boundaries ensures that when we call drawRect(devicePixelSnappedRect) later,
it leaves no cruft behind.

Source/WebCore:

Test: fast/borders/hidpi-rounded-border-on-subpixel-position.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder):

LayoutTests:

  • fast/borders/hidpi-rounded-border-on-subpixel-position-expected.html: Added.
  • fast/borders/hidpi-rounded-border-on-subpixel-position.html: Added.
8:25 PM Changeset in webkit [166995] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Build fix after r166479. 'bytes' is now abbreviated as 'B'.

  • public/js/helper-classes.js:

(PerfTestRuns.smallerIsBetter):

7:54 PM Changeset in webkit [166994] by rniwa@webkit.org
  • 3 edits in trunk/Websites/perf.webkit.org

Some CSS teaks.

  • public/common.css:

(#title):

  • public/index.html:

(#charts .pane):
(#charts .arrow):

7:27 PM April 2014 Meeting edited by rniwa@webkit.org
Add a hackathon idea (diff)
7:18 PM Changeset in webkit [166993] by jonlee@apple.com
  • 12 edits in trunk/Source

Turn MSE on by default
​https://bugs.webkit.org/show_bug.cgi?id=131313
<rdar://problem/16525223>

Reviewed by Jer Noble.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • page/Settings.in: Add MEDIA_SOURCE conditional.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Set default to true.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
  • Shared/WebPreferencesStore.h: Set default to true.
  • UIProcess/API/C/WKPreferencesRefPrivate.h:
7:16 PM April 2014 Meeting edited by rniwa@webkit.org
Add a hackathon idea (diff)
6:45 PM Changeset in webkit [166992] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Remove an unused parameter from loadResource.

Reviewed by Darin Adler.

Since the CachedResourceRequest has the charset in it, we don't need to pass it separately to loadRequest.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::loadResource):

  • loader/cache/CachedResourceLoader.h:
6:25 PM Changeset in webkit [166991] by ryuan.choi@samsung.com
  • 5 edits in trunk/Source

Unreviewed EFL build fix attempt since r166956

Source/WebCore:

  • page/efl/DragControllerEfl.cpp: Rename Clipboard to DataTransfer.

(WebCore::DragController::declareAndWriteDragImage):

Source/WebKit/efl:

  • WebCoreSupport/DragClientEfl.cpp: Rename Clipboard to DataTransfer.

(WebCore::DragClientEfl::willPerformDragSourceAction):
(WebCore::DragClientEfl::startDrag): Ditto.

  • WebCoreSupport/DragClientEfl.h:
6:11 PM Changeset in webkit [166990] by Simon Fraser
  • 3 edits
    2 adds in trunk

Source/WebCore: REGRESSION (r155998): Elements render at very low resolution with some 3d transforms
​https://bugs.webkit.org/show_bug.cgi?id=131412
<rdar://problem/16525044>

Reviewed by Tim Horton.

In r155998 we started to compute a root-relative transform in order to choose
a good contentsScale to avoid blurring on scaling.

However, the code failed to update this transform when passing over
GraphicsLayerCAs with no uncommitted changes, which caused us to choose
an incorrect contentsScale sometimes, resulting in blurriness.

Fix by updating the root-relative transform on layers with no uncommitted
changes.

Test: compositing/contents-scale/incremental-change.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):

LayoutTests: REGRESSION (r155998): Elements render at very low resolution with some 3d transforms
​https://bugs.webkit.org/show_bug.cgi?id=131412

Reviewed by Tim Horton.

Test that makes an incremental change to a layer property in a tree with
interesting 3d transforms.

  • compositing/contents-scale/incremental-change-expected.html: Added.
  • compositing/contents-scale/incremental-change.html: Added.
6:11 PM Changeset in webkit [166989] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Don't call CGPathAddPath with invalid CGAffineTransform objects
​https://bugs.webkit.org/show_bug.cgi?id=131413
<rdar://problem/16399645>

Reviewed by Darin Adler.

Covered by existing tests.

  • platform/graphics/cg/PathCG.cpp:

(WebCore::Path::addPath):
Don't try to add the path if the affine transform isn't invertible.

  • platform/graphics/transforms/AffineTransform.cpp:

(WebCore::AffineTransform::isInvertible):
Handle infinite and NaN determinants.

(WebCore::AffineTransform::inverse):
Handle infinite and NaN determinants.

5:47 PM Changeset in webkit [166988] by ggaren@apple.com
  • 2 edits in trunk/Source/WTF

2014-04-08 Geoffrey Garen <​ggaren@apple.com>

Stop linking WTF against bmalloc.

Reviewed by Enrica Casucci.

This seems to have broken an iOS buildbot script. Disable it for now
until we can fix the script.

  • WTF.xcodeproj/project.pbxproj:
5:40 PM Changeset in webkit [166987] by ggaren@apple.com
  • 2 edits in trunk/Tools

Fix the build-jsc build
​https://bugs.webkit.org/show_bug.cgi?id=131410

Reviewed by Michael Saboff.

  • Scripts/build-jsc: Make sure to build bmalloc before WTF, since

WTF depends on it.

5:38 PM Changeset in webkit [166986] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix the typo in the previous commit.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::close):

5:37 PM Changeset in webkit [166985] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit2

REGRESSION(r 166890): Crash inside WebKit::WebEditorClient::textFieldDidEndEditing
​https://bugs.webkit.org/show_bug.cgi?id=131409

Reviewed by Anders Carlsson.

Create an empty API::InjectedBundle::FormClient to avoid crashing inside
m_mainFrame->coreFrame()->loader().detachFromParent().

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::close):

5:22 PM Changeset in webkit [166984] by Brian Burg
  • 3 edits
    1 add in trunk

Web Replay: memoize nondeterministic attributes of the Screen interface
​https://bugs.webkit.org/show_bug.cgi?id=131339

Reviewed by Timothy Hatcher.

.:

  • ManualTests/inspector/replay-window-screen.html: Added.

Source/WebCore:

The values from the screen interface are nondeterministic. Since we can't
change the physical screen dimensions, instead memoize values of attributes.

Test: ManualTests/inspector/replay-window-screen.html

  • page/Screen.idl: Add Nondeterministic attribute.
5:13 PM Changeset in webkit [166983] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=131408
Scrollbars layers don't dynamically update when device scale factor changes
-and corresponding-
<rdar://problem/16503875>

Reviewed by Tim Horton.

The scrollbar layers are not children of the RenderView's layer, so they were
completely skipped over by this function before. We need to start this higher up
the tree in the rootGraphicsLayer(), which will typically return the
m_overflowControlsHostLayer.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::deviceOrPageScaleFactorChanged):

5:12 PM Changeset in webkit [166982] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

Web Inspector: Prevent deadlocks receiving WIRPermissionDenied message
​https://bugs.webkit.org/show_bug.cgi?id=131406

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-04-08
Reviewed by Timothy Hatcher.

  • inspector/remote/RemoteInspector.h:
  • inspector/remote/RemoteInspector.mm:

(Inspector::RemoteInspector::stop):
(Inspector::RemoteInspector::stopInternal):
(Inspector::RemoteInspector::xpcConnectionReceivedMessage):
Provide a way to stop externally and a path to stop when in
the middle of handling a message already with the locked mutex.

  • inspector/remote/RemoteInspectorXPCConnection.h:
  • inspector/remote/RemoteInspectorXPCConnection.mm:

(Inspector::RemoteInspectorXPCConnection::close):
(Inspector::RemoteInspectorXPCConnection::closeFromMessage):
Provide a way to close externally and a path to close when in
the middle of handling a message already with a mutex.

5:06 PM Changeset in webkit [166981] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

HTMLConverter::aggregatedAttributesForAncestors should cache intermediate results
​https://bugs.webkit.org/show_bug.cgi?id=131400

Reviewed by Sam Weinig.

Instead of accumulating attributes from a character node to the highest ancestor,
recursively call aggregatedAttributesForElementAndItsAncestors so that aggregated
attributes are cached on each ancestor to eliminate the old O(n2) behavior.

  • editing/cocoa/HTMLConverter.mm:

(HTMLConverter::aggregatedAttributesForAncestors):
(HTMLConverter::aggregatedAttributesForElementAndItsAncestors): Extracted from aggregatedAttributesForAncestors.

4:53 PM Changeset in webkit [166980] by jinwoo7.song@samsung.com
  • 2 edits in trunk/Source/WebCore

Unreviewed CMake build fix after r166965.

  • UseJSC.cmake: Rename JSClipboardCustom.cpp to JSDataTransferCustom.cpp.
4:44 PM Changeset in webkit [166979] by Martin Robinson
  • 6 edits
    147 deletes in trunk

[GTK] Remove the WebKitGTK+ WebKit 1 code
​https://bugs.webkit.org/show_bug.cgi?id=131399

Reviewed by Anders Carlsson.

.:

  • Source/PlatformGTK.cmake: Remove WebKit1 dependency from dist target.
  • Source/cmake/OptionsGTK.cmake: Remove option to compile with GTK+2 or with WebKit2 disabled.

Source/WebCore/platform/gtk/po:

  • POTFILES.in: Remove references to WebKit1 source files from the list of

files with translatable strings.

Source/WebKit:

  • PlatformGTK.cmake: Removed.
  • gtk: Remove this entire directory.
4:40 PM Changeset in webkit [166978] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Unify and factor out page overlay implementations
​https://bugs.webkit.org/show_bug.cgi?id=131353

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/PageOverlayController.cpp:

(WebKit::PageOverlayController::uninstallPageOverlay):
Don't turn fast scrolling back off unless the last overlay is removed.

4:36 PM Changeset in webkit [166977] by Martin Robinson
  • 3 edits
    36 deletes in trunk/Tools

[GTK] Remove WebKit1 unit tests
​https://bugs.webkit.org/show_bug.cgi?id=131359

Reviewed by Anders Carlsson.

Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
they were inadvertently left in ​http://trac.webkit.org/changeset/166504.

  • CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
  • Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
  • TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
4:19 PM Changeset in webkit [166976] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

Add a WKNavigationAction property indicating whether it resulted from processing a user gesture
​https://bugs.webkit.org/show_bug.cgi?id=131405
<rdar://problem/16535453>

Reviewed by Tim Horton.

  • Shared/NavigationActionData.cpp:

(WebKit::NavigationActionData::NavigationActionData):
(WebKit::NavigationActionData::encode):
(WebKit::NavigationActionData::decode):

  • Shared/NavigationActionData.h:
  • UIProcess/API/Cocoa/WKNavigationActionInternal.h:
  • UIProcess/API/Cocoa/WKNavigationActionPrivate.h:
  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction):

  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::createNewPage):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createWindow):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

4:09 PM Changeset in webkit [166975] by timothy_horton@apple.com
  • 19 edits
    2 adds in trunk/Source/WebKit2

Unify and factor out page overlay implementations
​https://bugs.webkit.org/show_bug.cgi?id=131353

Reviewed by Anders Carlsson.

Bring all of the PageOverlay code together in a single cross-platform
PageOverlayController, including hit-testing code from WebPage and painting
and layer-tree manipulation code from the DrawingArea.

This also makes all PageOverlays a single GraphicsLayer tree which can be
flushed and plugged into any DrawingArea in a straightforward manner.
We no longer have to watch for individual layers flipping into/out of tiling,
because they're hidden underneath the root PageOverlay GraphicsLayer.
Additionally, because GraphicsLayer is cross-platform, we can share
all of the fairly trivial but oft-repeated overlay management code.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/PageOverlayController.cpp: Added.
  • WebProcess/WebPage/PageOverlayController.h: Added.

(WebKit::PageOverlayController::rootLayer):
Add PageOverlayController.

  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

Remove PageOverlay-related code from the DrawingAreas.

  • WebProcess/WebPage/PageOverlay.cpp:

(WebKit::PageOverlay::setNeedsDisplay):
(WebKit::PageOverlay::fadeAnimationTimerFired):
(WebKit::PageOverlay::clear):

  • WebProcess/WebPage/PageOverlay.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::didChangeScrollOffset):

  • WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:

(-[WKAccessibilityWebPageObject accessibilityParameterizedAttributeNames]):
(-[WKAccessibilityWebPageObject accessibilityAttributeValue:forParameter:]):
Use PageOverlayController instead of the DrawingArea/WebPage to manipulate page overlays.

  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::pageOverlayController):
Remove PageOverlay-related code from WebPage.

  • WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::outOfTreeLayerWasAdded): Deleted.
(WebKit::RemoteLayerTreeContext::outOfTreeLayerWillBeRemoved): Deleted.
(WebKit::RemoteLayerTreeContext::flushOutOfTreeLayers): Deleted.
Remove the no-longer-necessary out-of-tree layer code.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageInstallPageOverlayWithAnimation):
(WKBundlePageUninstallPageOverlayWithAnimation):

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::highlight):
(WebKit::WebInspectorClient::hideHighlight):

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindUIAfterPageScroll):
(WebKit::FindController::hideFindUI):

  • WebProcess/WebPage/TelephoneNumberOverlayController.cpp:

(WebKit::TelephoneNumberOverlayController::createOverlayIfNeeded):
(WebKit::TelephoneNumberOverlayController::destroyOverlay):
Make use of the FadeMode enum.

3:59 PM Changeset in webkit [166974] by Brent Fulgham
  • 2 edits in trunk/Tools

Unreviewed gardening (Take 2): Prevent users from attempting
to build with known invalid cURL.

  • Scripts/webkitdirs.pm:

(checkInstalledTools): Check for 7.34.0 (the broken version), not
7.33.0 (the known good version).

3:52 PM Changeset in webkit [166973] by Martin Robinson
  • 3 edits
    3 moves
    1 add
    22 deletes in trunk/Tools

[GTK] Remove DumpRenderTree and GtkLauncher
​https://bugs.webkit.org/show_bug.cgi?id=131373

Reviewed by Andreas Kling.

Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
no longer necessary now that WebKit1 GTK+ will be removed.

  • CMakeLists.txt:
  • DumpRenderTree/PlatformGTK.cmake: Removed.
  • DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
  • DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
  • DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
  • DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
  • DumpRenderTree/gtk/EditingCallbacks.h: Removed.
  • DumpRenderTree/gtk/EventSender.cpp: Removed.
  • DumpRenderTree/gtk/EventSender.h: Removed.
  • DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
  • DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
  • DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
  • DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
  • DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
  • DumpRenderTree/gtk/TextInputController.cpp: Removed.
  • DumpRenderTree/gtk/TextInputController.h: Removed.
  • DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
  • GtkLauncher/CMakeLists.txt: Removed.
  • GtkLauncher/LauncherInspectorWindow.c: Removed.
  • GtkLauncher/LauncherInspectorWindow.h: Removed.
  • GtkLauncher/main.c: Removed.
  • GtkLauncher/simple.svg: Removed.
  • GtkLauncher/text.html: Removed.
  • WebKitTestRunner/PlatformGTK.cmake:
  • WebKitTestRunner/gtk/fonts/AHEM.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM.TTF.
  • WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
  • WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
3:51 PM Changeset in webkit [166972] by ggaren@apple.com
  • 2 edits in trunk/Source/WTF

WTF should link against bmalloc
​https://bugs.webkit.org/show_bug.cgi?id=131403

Reviewed by Michael Saboff.

This is required to build successfullly with bmalloc enabled.

  • WTF.xcodeproj/project.pbxproj:
3:46 PM Changeset in webkit [166971] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

Web Inspector: Address stale FIXMEs concerning console in JSContext inspection
​https://bugs.webkit.org/show_bug.cgi?id=131398

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-04-08
Reviewed by Timothy Hatcher.

  • inspector/InjectedScriptSource.js:

The console object can be deleted from a page or JSContext,
so keep code that expects that it could have been deleted
to be resilient in those cases.

  • inspector/JSGlobalObjectScriptDebugServer.h:
  • inspector/agents/JSGlobalObjectDebuggerAgent.h:
  • inspector/agents/JSGlobalObjectRuntimeAgent.h:

Change the FIXMEs to NOTEs that explain why these functions
have empty implementations for JSContext inspection.

3:44 PM Changeset in webkit [166970] by enrica@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed iOS build fix.

Return false instead of nil in a function that returns BOOL.

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityCanFuzzyHitTest]):

3:37 PM Changeset in webkit [166969] by andersca@apple.com
  • 12 edits in trunk/Source/WebKit2

Change WebPageProxy::CreateNewPage to take a NavigationActionData object
​https://bugs.webkit.org/show_bug.cgi?id=131401

Reviewed by Dan Bernstein.

  • UIProcess/API/APIUIClient.h:

(API::UIClient::createNewPage):

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

  • UIProcess/API/Cocoa/WKNavigationAction.mm:

(toWKNavigationType):

  • UIProcess/API/Cocoa/WKNavigationActionInternal.h:
  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::toWKNavigationType): Deleted.

  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::createNewPage):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::createNewPage):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createWindow):

3:36 PM Changeset in webkit [166968] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Non-empty ranges misdetected as empty ranges, avoiding telephone number detection.
<rdar://problem/16553441> and ​https://bugs.webkit.org/show_bug.cgi?id=131397

Reviewed by Tim Horton.

No new tests (Only affects a currently untested Mac-only WK2 feature)

  • editing/Editor.cpp:

(WebCore::Editor::scanSelectionForTelephoneNumbers): Fix detection of empty ranges so we don’t

early return erroneously.

3:27 PM Changeset in webkit [166967] by cavalcantii@gmail.com
  • 3 edits
    2 adds in trunk

[SVG] Fix CSS transform handling when zoomed
​https://bugs.webkit.org/show_bug.cgi?id=125836

Reviewed by Tim Horton.

Source/WebCore:

Tests: svg/zoom/page/zoom-css-transforms-expected.svg

svg/zoom/page/zoom-css-transforms.svg

Adjusts CSS transforms when used in SVG to account for unexpected
translation scale. Backport from Chromium #174910.

  • svg/SVGGraphicsElement.cpp:

(WebCore::SVGGraphicsElement::animatedLocalTransform):

LayoutTests:

Adjusts CSS transforms when used in SVG to account for unexpected
translation scale. Backport from Chromium #174910.

  • svg/zoom/page/zoom-css-transforms-expected.svg: Added.
  • svg/zoom/page/zoom-css-transforms.svg: Added.
3:26 PM Changeset in webkit [166966] by hmuller@adobe.com
  • 3 edits
    4 adds in trunk

[CSS Shapes] large corner radius combined with 0 radius does not wrap properly
​https://bugs.webkit.org/show_bug.cgi?id=129739

Reviewed by Bem Jones-Bey.

Source/WebCore:

Corrected special case handling for shape-outside border-box values with border-radius
values that greater than or equal to the box's height.

Tests: fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-001.html

fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-002.html

  • rendering/shapes/BoxShape.cpp:

(WebCore::BoxShape::getExcludedIntervals):

LayoutTests:

  • fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-001-expected.txt: Added.
  • fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-001.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-002-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-002.html: Added.
3:06 PM Changeset in webkit [166965] by ap@apple.com
  • 64 edits
    6 moves in trunk

Source/WebCore: Rename Clipboard to DataTransfer
​https://bugs.webkit.org/show_bug.cgi?id=131371

Reviewed by Anders Carlsson.

This is the name used in HTML5, and it's much better than the confusing Clipboard one.

Renamed related enums too, and made DataTransferAccessPolicy an enum class.

  • CMakeLists.txt:
  • Configurations/WebCore.xcconfig:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • WebCore.exp.in:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSClipboardCustom.cpp: Removed.
  • bindings/js/JSDataTransferCustom.cpp: Copied from Source/WebCore/bindings/js/JSClipboardCustom.cpp.

(WebCore::JSDataTransfer::types):
(WebCore::JSClipboard::types): Deleted.

  • bindings/js/JSEventCustom.cpp:
  • dom/Clipboard.cpp: Removed.
  • dom/Clipboard.h: Removed.
  • dom/Clipboard.idl: Removed.
  • dom/ClipboardAccessPolicy.h: Removed.
  • dom/ClipboardEvent.cpp:

(WebCore::ClipboardEvent::ClipboardEvent):

  • dom/ClipboardEvent.h:

(WebCore::ClipboardEvent::create):
(WebCore::ClipboardEvent::clipboard): Deleted.

  • dom/ClipboardMac.mm: Removed.
  • dom/DOMAllInOne.cpp:
  • dom/DataTransfer.cpp: Copied from Source/WebCore/dom/Clipboard.cpp.

(WebCore::DataTransfer::DataTransfer):
(WebCore::DataTransfer::createForCopyAndPaste):
(WebCore::DataTransfer::~DataTransfer):
(WebCore::DataTransfer::setAccessPolicy):
(WebCore::DataTransfer::canReadTypes):
(WebCore::DataTransfer::canReadData):
(WebCore::DataTransfer::canWriteData):
(WebCore::DataTransfer::clearData):
(WebCore::DataTransfer::getData):
(WebCore::DataTransfer::setData):
(WebCore::DataTransfer::types):
(WebCore::DataTransfer::files):
(WebCore::DataTransfer::dropEffect):
(WebCore::DataTransfer::setDropEffect):
(WebCore::DataTransfer::effectAllowed):
(WebCore::DataTransfer::setEffectAllowed):
(WebCore::DataTransfer::setDragImage):
(WebCore::DataTransfer::createForDragAndDrop):
(WebCore::DataTransfer::canSetDragImage):
(WebCore::DataTransfer::updateDragImage):
(WebCore::DataTransfer::createDragImage):
(WebCore::DragImageLoader::DragImageLoader):
(WebCore::DragImageLoader::imageChanged):
(WebCore::DataTransfer::sourceOperation):
(WebCore::DataTransfer::destinationOperation):
(WebCore::DataTransfer::setSourceOperation):
(WebCore::DataTransfer::setDestinationOperation):
(WebCore::Clipboard::Clipboard): Deleted.
(WebCore::Clipboard::createForCopyAndPaste): Deleted.
(WebCore::Clipboard::~Clipboard): Deleted.
(WebCore::Clipboard::setAccessPolicy): Deleted.
(WebCore::Clipboard::canReadTypes): Deleted.
(WebCore::Clipboard::canReadData): Deleted.
(WebCore::Clipboard::canWriteData): Deleted.
(WebCore::Clipboard::clearData): Deleted.
(WebCore::Clipboard::getData): Deleted.
(WebCore::Clipboard::setData): Deleted.
(WebCore::Clipboard::types): Deleted.
(WebCore::Clipboard::files): Deleted.
(WebCore::Clipboard::dropEffect): Deleted.
(WebCore::Clipboard::setDropEffect): Deleted.
(WebCore::Clipboard::effectAllowed): Deleted.
(WebCore::Clipboard::setEffectAllowed): Deleted.
(WebCore::Clipboard::setDragImage): Deleted.
(WebCore::Clipboard::createForDragAndDrop): Deleted.
(WebCore::Clipboard::canSetDragImage): Deleted.
(WebCore::Clipboard::updateDragImage): Deleted.
(WebCore::Clipboard::createDragImage): Deleted.
(WebCore::Clipboard::sourceOperation): Deleted.
(WebCore::Clipboard::destinationOperation): Deleted.
(WebCore::Clipboard::setSourceOperation): Deleted.
(WebCore::Clipboard::setDestinationOperation): Deleted.

  • dom/DataTransfer.h: Copied from Source/WebCore/dom/Clipboard.h.
  • dom/DataTransfer.idl: Copied from Source/WebCore/dom/Clipboard.idl.
  • dom/DataTransferAccessPolicy.h: Copied from Source/WebCore/dom/ClipboardAccessPolicy.h.
  • dom/DataTransferItemList.h:
  • dom/DataTransferMac.mm: Copied from Source/WebCore/dom/ClipboardMac.mm.

(WebCore::DataTransfer::createDragImage):
(WebCore::Clipboard::createDragImage): Deleted.

  • dom/Event.h:

(WebCore::Event::clipboardData):
(WebCore::Event::internalDataTransfer):
(WebCore::Event::clipboard): Deleted.

  • dom/Event.idl:
  • dom/MouseEvent.cpp:

(WebCore::MouseEvent::create):
(WebCore::MouseEvent::MouseEvent):
(WebCore::MouseEvent::initMouseEvent):

  • dom/MouseEvent.h:

(WebCore::MouseEvent::dataTransfer):

  • dom/MouseEvent.idl:
  • dom/WheelEvent.cpp:
  • editing/Editor.cpp:

(WebCore::Editor::canDHTMLCut):
(WebCore::Editor::canDHTMLCopy):
(WebCore::Editor::canDHTMLPaste):
(WebCore::Editor::tryDHTMLCopy):
(WebCore::Editor::tryDHTMLCut):
(WebCore::Editor::tryDHTMLPaste):
(WebCore::Editor::dispatchCPPEvent):
(WebCore::Editor::performCutOrCopy):
(WebCore::Editor::selectedTextForDataTransfer):
(WebCore::Editor::selectedTextForClipboard): Deleted.

  • editing/Editor.h:
  • editing/ios/EditorIOS.mm:

(WebCore::Editor::stringSelectionForPasteboardWithImageAltText):

  • editing/mac/EditorMac.mm:

(WebCore::Editor::takeFindStringFromSelection):
(WebCore::Editor::stringSelectionForPasteboardWithImageAltText):

  • loader/EmptyClients.h:
  • page/DragClient.h:
  • page/DragController.cpp:

(WebCore::DragController::dragExited):
(WebCore::DragController::performDrag):
(WebCore::DragController::tryDHTMLDrag):
(WebCore::DragController::startDrag):
(WebCore::DragController::doImageDrag):
(WebCore::DragController::doSystemDrag):

  • page/DragController.h:
  • page/DragState.h:
  • page/EventHandler.cpp:

(WebCore::EventHandler::dispatchDragEvent):
(WebCore::hasFileOfType):
(WebCore::hasStringOfType):
(WebCore::hasDropZoneType):
(WebCore::findDropZone):
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::cancelDragAndDrop):
(WebCore::EventHandler::performDragAndDrop):
(WebCore::EventHandler::freeDataTransfer):
(WebCore::EventHandler::dragSourceEndedAt):
(WebCore::EventHandler::dispatchDragSrcEvent):
(WebCore::EventHandler::handleDrag):
(WebCore::EventHandler::freeClipboard): Deleted.

  • page/EventHandler.h:
  • page/efl/EventHandlerEfl.cpp:

(WebCore::EventHandler::createDraggingDataTransfer):
(WebCore::EventHandler::createDraggingClipboard): Deleted.

  • page/gtk/DragControllerGtk.cpp:

(WebCore::DragController::declareAndWriteDragImage):

  • page/gtk/EventHandlerGtk.cpp:

(WebCore::EventHandler::createDraggingDataTransfer):
(WebCore::EventHandler::createDraggingClipboard): Deleted.

  • page/mac/DragControllerMac.mm:

(WebCore::DragController::declareAndWriteDragImage):

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::createDraggingDataTransfer):
(WebCore::EventHandler::createDraggingClipboard): Deleted.

  • page/win/DragControllerWin.cpp:

(WebCore::DragController::declareAndWriteDragImage):

  • page/win/EventHandlerWin.cpp:

(WebCore::EventHandler::createDraggingataTransfer):
(WebCore::EventHandler::createDraggingClipboard): Deleted.

  • platform/Pasteboard.h:
  • platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::writeSelection):

  • platform/mac/PasteboardMac.mm:
  • platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::writeRangeToDataObject):
(WebCore::Pasteboard::writeSelection):

Source/WebKit/ios: Rename Clipboard to DataTransfer
​https://bugs.webkit.org/show_bug.cgi?id=131371

Reviewed by Anders Carlsson.

  • WebView/WebPDFViewPlaceholder.mm:

Source/WebKit/mac: Rename Clipboard to DataTransfer
​https://bugs.webkit.org/show_bug.cgi?id=131371

Reviewed by Anders Carlsson.

  • WebCoreSupport/WebDragClient.h:
  • WebCoreSupport/WebDragClient.mm:

(WebDragClient::willPerformDragSourceAction):
(WebDragClient::startDrag):

  • WebView/WebPDFView.mm:

Source/WebKit2: Fix build.

Patch by Anders Carlsson <​andersca@apple.com> on 2014-04-08

  • WebKit2Prefix.h:

LayoutTests: Rename Clipboard to DataTransfer
​https://bugs.webkit.org/show_bug.cgi?id=131371

Reviewed by Anders Carlsson.

  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/dom-constructors.html:
  • js/dom/global-constructors-attributes-expected.txt:
  • platform/efl/js/dom/global-constructors-attributes-expected.txt:
  • platform/gtk-wk1/js/dom/global-constructors-attributes-expected.txt:
  • platform/gtk-wk2/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
  • platform/win/js/dom/global-constructors-attributes-expected.txt:
2:41 PM Changeset in webkit [166964] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed iOS build fix. Pass 0 instead of nil to the options parameter of addObserver:forKeyPath:options:context.

  • platform/graphics/ios/TextTrackRepresentationIOS.mm:

(-[WebCoreTextTrackRepresentationIOSHelper setParent:]):

2:33 PM Changeset in webkit [166963] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix build.

  • WebKit2Prefix.h:
2:29 PM Changeset in webkit [166962] by Brent Fulgham
  • 5 edits
    1 move
    2 adds
    1 delete in trunk/Source/WebInspectorUI

[Windows] Generate Optimized WebInspectorUI in Release Build
​https://bugs.webkit.org/show_bug.cgi?id=120120

Reviewed by Timothy Hatcher.

  • Scripts/copy-user-interface-resources.pl: Copied from Scripts/copy-user-interface-resources.sh.
  • Scripts/copy-user-interface-resources.sh: Removed.
  • Scripts/remove-console-asserts.pl:
  • WebInspectorUI.vcxproj/WebInspectorUI.make: Added.
  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj: Switch to Makefile style.
  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters: Ditto.
  • WebInspectorUI.vcxproj/WebInspectorUIPostBuild.cmd: More work should

be done in the new build-webinspectorui.sh file.

  • WebInspectorUI.vcxproj/build-webinspectorui.sh: Added.
  • WebInspectorUI.xcodeproj/project.pbxproj:
2:22 PM Changeset in webkit [166961] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Use an explicit class when decoding individual bundle parameters
​https://bugs.webkit.org/show_bug.cgi?id=131392
<rdar://problem/16213914>

Reviewed by Dan Bernstein.

  • WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::setBundleParameter):

2:18 PM Changeset in webkit [166960] by Brent Fulgham
  • 13 edits in trunk/LayoutTests

[Mac] Unreviewed test gardening.

Rebaseline scrolling tests to remove flakiness introduced by slight differences in
pixel scroll counts between WK1 and WK2 test runners.

  • platform/mac/fast/scrolling/scroll-div-latched-div-expected.txt:
  • platform/mac/fast/scrolling/scroll-div-latched-div.html:
  • platform/mac/fast/scrolling/scroll-div-latched-mainframe-expected.txt:
  • platform/mac/fast/scrolling/scroll-div-latched-mainframe.html:
  • platform/mac/fast/scrolling/scroll-iframe-latched-iframe-expected.txt:
  • platform/mac/fast/scrolling/scroll-iframe-latched-iframe.html:
  • platform/mac/fast/scrolling/scroll-iframe-latched-mainframe-expected.txt:
  • platform/mac/fast/scrolling/scroll-iframe-latched-mainframe.html:
  • platform/mac/fast/scrolling/scroll-select-latched-mainframe-expected.txt:
  • platform/mac/fast/scrolling/scroll-select-latched-mainframe.html:
  • platform/mac/fast/scrolling/scroll-select-latched-select-expected.txt:
  • platform/mac/fast/scrolling/scroll-select-latched-select.html:
2:11 PM Changeset in webkit [166959] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

Move a Mountain Lion declaration to the WebKit2 prefix header
​https://bugs.webkit.org/show_bug.cgi?id=131391

Reviewed by Tim Horton.

  • UIProcess/API/Cocoa/WKProcessPool.mm:
  • UIProcess/ios/PageClientImplIOS.mm:
  • UIProcess/mac/WebContextMac.mm:
  • WebKit2Prefix.h:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
  • WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
1:50 PM Changeset in webkit [166958] by Antti Koivisto
  • 12 edits in trunk/Source

Remove exposedRect from TileController
​https://bugs.webkit.org/show_bug.cgi?id=131378

Reviewed by Simon Fraser.

Source/WebCore:

Having two separate visible rectangles is confusing. We should compute one on higher level.

  • page/FrameView.cpp:

(WebCore::FrameView::setExposedRect):

Push exposed rect to tile controller by doing a layer flush (like the changed visible rect is normally passed).

  • platform/graphics/TiledBacking.h:
  • platform/graphics/ca/mac/TileController.h:
  • platform/graphics/ca/mac/TileController.mm:


Remove exposedRect and just use visibleRect.

(WebCore::TileController::TileController):
(WebCore::TileController::setTiledScrollingIndicatorPosition):

Update the scrolling indicator position.

(WebCore::TileController::updateTileCoverageMap):
(WebCore::TileController::setExposedRect): Deleted.

  • platform/graphics/ca/mac/TileGrid.h:
  • platform/graphics/ca/mac/TileGrid.mm:

(WebCore::TileGrid::tilesWouldChangeForVisibleRect):
(WebCore::TileGrid::revalidateTiles):
(WebCore::TileGrid::scaledExposedRect): Deleted.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):

No need to push exposedRect anymore.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::flushPendingLayerChanges):

Integrate exposed rect to visible rect when flushing layers.

Source/WebKit2:

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::updateScrolledExposedRect):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updateScrolledExposedRect):

Update the visible rect for pageOverlayLayers by calling flushCompositingState. This way
tile controller visible rect updates always happens via compositing flush (we assert
for this in TileController::setVisibleRect).

1:36 PM Changeset in webkit [166957] by ggaren@apple.com
  • 2 edits in trunk/Source/WTF

Added a bmalloc back-end for FastMalloc
​https://bugs.webkit.org/show_bug.cgi?id=131387

Reviewed by Andreas Kling.

We'll need to rethink some things if we adopt this back-end. For example,
fastMallocSize() and fastMallocGoodSize() are no longer real things. But,
this is enough to test for now.

  • wtf/FastMalloc.cpp:

(WTF::fastMalloc):
(WTF::fastCalloc):
(WTF::fastRealloc):
(WTF::fastFree):
(WTF::fastMallocSize):
(WTF::fastMallocGoodSize):
(WTF::tryFastMalloc):
(WTF::tryFastRealloc):
(WTF::tryFastCalloc):
(WTF::releaseFastMallocFreeMemory):
(WTF::fastMallocStatistics):

1:36 PM Changeset in webkit [166956] by ggaren@apple.com
  • 24 edits in trunk/Source/bmalloc

Made bmalloc more #include friendly
​https://bugs.webkit.org/show_bug.cgi?id=131386

Reviewed by Andreas Kling.

Marked a bunch of headers private so they can be used from client code
that #includes bmalloc.h.

Renamed ASSERT macros to BASSERT. This matches their header, which already
had to be renamed, and fixes conflicts with WTF's ASSERT macros.

  • bmalloc.xcodeproj/project.pbxproj:
  • bmalloc/Allocator.cpp:

(bmalloc::Allocator::allocateSlowCase):

  • bmalloc/AsyncTask.h:

(bmalloc::Function>::runSlowCase):

  • bmalloc/BAssert.h:
  • bmalloc/BoundaryTag.h:

(bmalloc::BoundaryTag::setSize):

  • bmalloc/BoundaryTagInlines.h:

(bmalloc::validate):
(bmalloc::BoundaryTag::init):
(bmalloc::BoundaryTag::deallocate):
(bmalloc::BoundaryTag::splitLarge):
(bmalloc::BoundaryTag::allocate):

  • bmalloc/Chunk.h:
  • bmalloc/Deallocator.cpp:

(bmalloc::Deallocator::processObjectLog):
(bmalloc::Deallocator::deallocateSlowCase):

  • bmalloc/Deallocator.h:

(bmalloc::Deallocator::deallocateFastCase):

  • bmalloc/FixedVector.h:

(bmalloc::Capacity>::operator):
(bmalloc::Capacity>::push):
(bmalloc::Capacity>::pop):
(bmalloc::Capacity>::shrink):

  • bmalloc/Heap.cpp:

(bmalloc::Heap::allocateLarge):

  • bmalloc/LargeChunk.h:

(bmalloc::LargeChunk::get):
(bmalloc::LargeChunk::endTag):

  • bmalloc/Line.h:

(bmalloc::Line<Traits>::concurrentRef):
(bmalloc::Line<Traits>::deref):

  • bmalloc/MediumAllocator.h:

(bmalloc::MediumAllocator::allocate):

  • bmalloc/ObjectType.h:

(bmalloc::isSmall):

  • bmalloc/Page.h:

(bmalloc::Page<Traits>::ref):
(bmalloc::Page<Traits>::deref):

  • bmalloc/PerThread.h:

(bmalloc::PerThread<T>::getSlowCase):

  • bmalloc/SegregatedFreeList.cpp:

(bmalloc::SegregatedFreeList::SegregatedFreeList):
(bmalloc::SegregatedFreeList::insert):

  • bmalloc/SmallAllocator.h:

(bmalloc::SmallAllocator::allocate):
(bmalloc::SmallAllocator::refill):

  • bmalloc/Syscall.h:
  • bmalloc/VMAllocate.h:

(bmalloc::vmValidate):
(bmalloc::vmAllocate):
(bmalloc::vmDeallocatePhysicalPagesSloppy):

  • bmalloc/Vector.h:

(bmalloc::Vector<T>::operator):
(bmalloc::Vector<T>::pop):
(bmalloc::Vector<T>::shrink):

  • bmalloc/XLargeChunk.h:

(bmalloc::XLargeChunk::range):
(bmalloc::XLargeChunk::size):

1:32 PM Changeset in webkit [166955] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Fix corrupt APPLE_IMAGES_LICENSE.rtf after r165676.
​https://bugs.webkit.org/show_bug.cgi?id=131384

Reviewed by Joseph Pecoraro.

  • APPLE_IMAGES_LICENSE.rtf:
1:32 PM Changeset in webkit [166954] by mrowe@apple.com
  • 2 edits in trunk/Tools

XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
<​https://webkit.org/b/131388> / <rdar://problem/16291687>

Reviewed by Alexey Proskuryakov.

  • Scripts/webkitdirs.pm:

(runMacWebKitApp): Set XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
(execMacWebKitAppForDebugging): Ditto.

1:26 PM Changeset in webkit [166953] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] Always do a full GC when simulating memory pressure.
<​https://webkit.org/b/129790>

To get more consistent accounting on automated memory testers,
add a synchronous GC as part of the simulated memory pressure event.

Reviewed by Geoffrey Garen.

  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::install):

1:25 PM Changeset in webkit [166952] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix a goofy assertion to fix debug.

  • bytecode/PolymorphicPutByIdList.h:

(JSC::PutByIdAccess::isSetter):
(JSC::PutByIdAccess::oldStructure):
(JSC::PutByIdAccess::chain):
(JSC::PutByIdAccess::stubRoutine):
(JSC::PutByIdAccess::customSetter):

1:24 PM Changeset in webkit [166951] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed iOS build fix. Pass 0 instead of nil to setRate: when pausing.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::platformPause):

1:05 PM Changeset in webkit [166950] by mitz@apple.com
  • 4 edits in trunk

Added bmalloc to the WebKit workspace.
​https://bugs.webkit.org/show_bug.cgi?id=131362

Reviewed by Geoff Garen.

  • WebKit.xcworkspace/contents.xcworkspacedata:
  • WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme:
  • WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
1:04 PM Changeset in webkit [166949] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[GTK] Unreviewed GTK gardening.

Update text expectations for failing tests:

accessibility/children-changed-sends-notification.html
accessibility/notification-listeners.html
fast/repaint/blend-mode-isolate-stacking-context.html
fast/repaint/hidpi-absolute-positioned-element-wrong-cliprect-after-move.html

Rebaseline fast/multicol/client-rects-expected.txt after r165991

Patch by Carlos Alberto Lopez Perez <​clopez@igalia.com> on 2014-04-08

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/multicol/client-rects-expected.txt:
1:03 PM Changeset in webkit [166948] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Fail silently if the LLVM dylib isn't found
​https://bugs.webkit.org/show_bug.cgi?id=131385

Reviewed by Mark Hahnenberg.

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

  • llvm/InitializeLLVM.cpp:

(JSC::initializeLLVM):

  • llvm/InitializeLLVM.h:
  • llvm/InitializeLLVMPOSIX.cpp:

(JSC::initializeLLVMPOSIX):

12:56 PM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com
(diff)
12:52 PM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com
(diff)
12:48 PM Changeset in webkit [166947] by ggaren@apple.com
  • 4 edits in trunk

Build bmalloc on iOS too
​https://bugs.webkit.org/show_bug.cgi?id=131381

Reviewed by Andreas Kling.

.:

  • Source/Makefile: Build it.

Tools:

  • Scripts/build-webkit:
12:42 PM Changeset in webkit [166946] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

FlagsChanged events are not delivered to input methods when using async text input
​https://bugs.webkit.org/show_bug.cgi?id=131383

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm: (-[WKView _interpretKeyEvent:completionHandler:]):

The early return is no longer needed.

12:39 PM Changeset in webkit [166945] by fpizlo@apple.com
  • 9 edits
    4 adds in trunk

Repatch should support setters and plant calls to them directly
​https://bugs.webkit.org/show_bug.cgi?id=130750

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

All of the infrastructure was in place so this just enables setter optimization.

This is a 12x speed-up on setter microbenchmarks. This is a 1% speed-up on Octane.

  • bytecode/PolymorphicPutByIdList.cpp:

(JSC::PutByIdAccess::visitWeak):

  • bytecode/PolymorphicPutByIdList.h:

(JSC::PutByIdAccess::setter):
(JSC::PutByIdAccess::customSetter): Deleted.

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeForStubInfo):

  • jit/Repatch.cpp:

(JSC::toString):
(JSC::kindFor):
(JSC::customFor):
(JSC::generateByIdStub):
(JSC::tryCachePutByID):
(JSC::tryBuildPutByIdList):

  • runtime/JSObject.cpp:

(JSC::JSObject::put):

  • runtime/Lookup.h:

(JSC::putEntry):

  • runtime/PutPropertySlot.h:

(JSC::PutPropertySlot::setCacheableSetter):
(JSC::PutPropertySlot::isCacheableSetter):
(JSC::PutPropertySlot::isCacheableCustom):
(JSC::PutPropertySlot::setCacheableCustomProperty): Deleted.
(JSC::PutPropertySlot::isCacheableCustomProperty): Deleted.

  • tests/stress/setter.js: Added.

(foo):

LayoutTests:

Reviewed by Geoffrey Garen.

  • js/regress/script-tests/setter.js: Added.
  • js/regress/setter-expected.txt: Added.
  • js/regress/setter.html: Added.
12:26 PM Changeset in webkit [166944] by ggaren@apple.com
  • 1 edit
    1 delete in trunk/Source/bmalloc

2014-04-08 Geoffrey Garen <​ggaren@apple.com>

Removed an unused file.

Unreviewed.

  • bmalloc/AsyncTask.cpp: Removed.
12:12 PM Changeset in webkit [166943] by mark.lam@apple.com
  • 3 edits in trunk/Source/WebCore

Refactor to make JSMainThreadExecState's constructor and destructor private.
<​https://webkit.org/b/131372>

Reviewed by Mark Hahnenberg.

This is in preparation for subsequent patches to ensure that we don't
exit the VM with an exception still pending.

No new tests required. This is only a refactor of existing behavior.

  • bindings/js/JSDOMGlobalObjectTask.cpp:
  • bindings/js/JSMainThreadExecState.h:

(WebCore::JSMainThreadExecState::runTask):

12:07 PM Changeset in webkit [166942] by timothy@apple.com
  • 3 edits in trunk/Source/WebInspectorUI

Clean up old protocol JSON files to better match the latest
​https://bugs.webkit.org/show_bug.cgi?id=131308

Reviewed by Joseph Pecoraro.

  • Versions/Inspector-iOS-6.0.json:
  • Versions/Inspector-iOS-7.0.json:
12:00 PM Changeset in webkit [166941] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

WebKit2 View Gestures (Swipe): Swipe-start hysteresis
​https://bugs.webkit.org/show_bug.cgi?id=127393
<rdar://problem/15876822>

Reviewed by Anders Carlsson.

We shouldn't start a swipe immediately upon very small scrolls in the correct direction,
because we don't want to get the user trapped in a swipe when they want to scroll.

We'll accumulate the scroll deltas and wait until the user has scrolled at least 15px horizontally.
In addition, we'll drop the swipe completely if any event has a vertical delta equal to half (or more)
of the horizontal delta.

  • UIProcess/mac/ViewGestureController.h:
  • UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::deltaIsSufficientToBeginSwipe):
(WebKit::ViewGestureController::handleScrollWheelEvent):
(WebKit::ViewGestureController::wheelEventWasNotHandledByWebCore):

11:26 AM Changeset in webkit [166940] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

[Mac][WK2] Videos do not have access to session cookies
​https://bugs.webkit.org/show_bug.cgi?id=129687

Reviewed by Eric Carlson.

Update the CookieStorageShim to track changes in underlying networking stack.

  • Shared/mac/CookieStorageShim.mm:

(WebKit::CookieStorageShim::initialize):
(-[WKNSURLSessionLocal _getCookieHeadersForTask:completionHandler:]):

11:22 AM Changeset in webkit [166939] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

[WK2][iOS] Consecutive videos in full screen display only black
​https://bugs.webkit.org/show_bug.cgi?id=131316

Reviewed by Eric Carlson.

Update the MediaPlayer's full screen attributes whenever the underlying engine changes,
not just when the engine is initially created. Also, clear the videoLayer out of the
fullscreen layer when destroying the videoLayer.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyVideoLayer):

11:19 AM Changeset in webkit [166938] by commit-queue@webkit.org
  • 7 edits
    6 adds in trunk

[New Multicolumn] Child top margin sometimes ignored for column balancing
​https://bugs.webkit.org/show_bug.cgi?id=122754

Patch by Morten Stenshorne <​mstensho@opera.com> on 2014-04-08
Reviewed by David Hyatt.

Source/WebCore:

We need to set zero page logical height in LayoutState when column
height is unknown (when the columns haven't yet been
balanced). There's code that assumes that non-zero page height means
that page height is known. Lying about this makes the pagination code
believe that every top margin is adjacent to a column break, which
makes it eat and ignore all top margins.

This should be cleaned up, but it's easier to wait until the old
multicol code has been removed.

Tests: fast/multicol/break-in-scrollable.html

fast/multicol/newmulticol/leading-and-trailing-margin.html
fast/multicol/newmulticol/leading-margin.html

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::checkForPaginationLogicalHeightChange):

  • rendering/RenderFlowThread.h:
  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::isPageLogicalHeightKnown):

  • rendering/RenderMultiColumnFlowThread.h:

LayoutTests:

  • fast/multicol/break-in-scrollable-expected.html: Added.
  • fast/multicol/break-in-scrollable.html: Added.
  • fast/multicol/newmulticol/leading-and-trailing-margin-expected.html: Added.
  • fast/multicol/newmulticol/leading-and-trailing-margin.html: Added.
  • fast/multicol/newmulticol/leading-margin-expected.html: Added.
  • fast/multicol/newmulticol/leading-margin.html: Added.
11:06 AM Changeset in webkit [166937] by dino@apple.com
  • 6 edits in trunk/Source/WebCore

Allow elements to register for changes in page scale
​https://bugs.webkit.org/show_bug.cgi?id=131319

Reviewed by Eric Carlson.

Some parts of WebCore need to react to changes in the page
scale factor, such as resizing when the user zooms. A followup
patch will enable this for media controls - this simply lays
the groundwork.

At the moment we only allow HTMLMediaElements to register, but if
necessary this could be expanded in the future.

  • dom/Document.cpp: New methods to keep a list of HTMLMediaElements that

are interested in updates.
(WebCore::Document::registerForPageScaleFactorChangedCallbacks):
(WebCore::Document::unregisterForPageScaleFactorChangedCallbacks):
(WebCore::Document::pageScaleFactorChanged):

  • dom/Document.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::registerWithDocument): Add ourselves to the
the document's pageScale callback.
(WebCore::HTMLMediaElement::unregisterWithDocument): Remove ourselves from the
the document's pageScale callback.
(WebCore::HTMLMediaElement::setMediaControlsDependOnPageScaleFactor): Add/remove ourselves to/from
the callback if necessary.
(WebCore::HTMLMediaElement::pageScaleFactorChanged): The callback function. Empty for now.

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::mediaControlsDependOnPageScaleFactor): Accessor.

  • page/Page.cpp:

(WebCore::Page::setPageScaleFactor): Tell all documents that the user has zoomed.

11:04 AM Changeset in webkit [166936] by mitz@apple.com
  • 5 edits in trunk/Source/WebKit2

[Cocoa] Add a way to tell whether a WKWebProcessPlugInNodeHandle is a text-type HTML input element
​https://bugs.webkit.org/show_bug.cgi?id=131374

Reviewed by Anders Carlsson.

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h:
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:

(-[WKWebProcessPlugInNodeHandle isTextField]): Added this getter. Calls
InjectedBundleNodeHandle::isTextField.

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::isTextField): Added. Uses
WebCore::HTMLInputElement::isText, which is consistent with what
WebChromeClient::focusedElementChanged uses to decide whether to call didFocusTextField.

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
10:45 AM Changeset in webkit [166935] by mitz@apple.com
  • 5 edits in trunk/Source/WebKit2

[Cocoa] Add a _certificateChain property to WKWebProcessPlugInFrame
​https://bugs.webkit.org/show_bug.cgi?id=131370

Reviewed by Anders Carlsson.

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:

(-[WKWebProcessPlugInFrame _certificateChain]): Added this getter, which uses the new
WebFrame::certificateInfo.

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::certificateInfo): Added this getter.

  • WebProcess/WebPage/WebFrame.h:
10:36 AM Changeset in webkit [166934] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

[Cocoa] Add a bundle form delegate method corresponding to textDidChangeInTextField
​https://bugs.webkit.org/show_bug.cgi?id=131369

Reviewed by Anders Carlsson.

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFormDelegatePrivate.h: Declared

new delegate method.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]): Added an override
of API::InjectedBundle::FormClient::textDidChangeInTextField which calls the new delegate
method.

10:17 AM Changeset in webkit [166933] by mitz@apple.com
  • 11 edits
    2 adds in trunk/Source

../WebKit/mac: WebKit part of [Cocoa] Add WKFormDelegate
​https://bugs.webkit.org/show_bug.cgi?id=131343

Reviewed by Anders Carlsson.

  • MigrateHeaders.make: Added new WebKit2 headers to WEBKIT2_HEADERS.

../WebKit2: [Cocoa] Add WKFormDelegate
​https://bugs.webkit.org/show_bug.cgi?id=131343

Reviewed by Anders Carlsson.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _formDelegate]): Added this accessor.
(-[WKWebView _setFormDelegate:]): Ditto.

  • UIProcess/API/Cocoa/WKWebViewPrivate.h: Declared _formDelegate property.
  • UIProcess/API/Cocoa/_WKFormDelegate.h: Added.
  • UIProcess/API/Cocoa/_WKFormInputSession.h: Added.
  • UIProcess/ios/WKContentView.h: Moved _webView ivar into the @interface…
  • UIProcess/ios/WKContentView.mm: …from the @implementation.
  • UIProcess/ios/WKContentViewInteraction.h: Added _formInputSession ivar and

formAccessoryView property.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKFormInputSession initWithContentView:userObject:]): Added.
(-[WKFormInputSession dealloc]): Added.
(-[WKFormInputSession userObject]): Added.
(-[WKFormInputSession isValid]): Added.
(-[WKFormInputSession accessoryViewCustomButtonTitle]): Added.
(-[WKFormInputSession setAccessoryViewCustomButtonTitle:]): Added.
(-[WKFormInputSession invalidate]): Added.
(-[WKContentView cleanupInteraction]): Invalidate and release the input session.
(-[WKContentView formAccessoryView]): Added this accessor.
(-[WKContentView _startAssistingNode:userObject:]): Create an input session and message the
form delegate.
(-[WKContentView _stopAssistingNode]): Invalidate and release the input session.

  • WebKit2.xcodeproj/project.pbxproj: Added references to new files.
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFormDelegatePrivate.h: Added

comment.

9:47 AM Changeset in webkit [166932] by Brent Fulgham
  • 2 edits in trunk/Tools

Unreviewed gardening: Prevent users from attempting
to build with known invalid cURL.

  • Scripts/webkitdirs.pm:

(checkInstalledTools): Block build attempts with bad
Cygwin tool set.

9:40 AM Changeset in webkit [166931] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Compile error in TextureMapper.h
​https://bugs.webkit.org/show_bug.cgi?id=131360

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-04-08
Reviewed by Brent Fulgham.

The TextureMapper class has pure virtual methods, and cannot be instantiated.

  • platform/graphics/texmap/TextureMapper.h:

(WebCore::TextureMapper::platformCreateAccelerated):

9:26 AM Changeset in webkit [166930] by Brent Fulgham
  • 3 edits
    97 moves
    12 adds in trunk/LayoutTests

[WebVTT] Begin Enabling W3C VTT Tests
​https://bugs.webkit.org/show_bug.cgi?id=131345

Reviewed by Darin Adler.

Move a number of tests out of 'opera' into a new 'w3c' folder.

  • media/track/opera/interfaces/HTMLElement/HTMLMediaElement/addTextTrack-expected.txt: Removed.
  • media/track/opera/interfaces/HTMLElement/HTMLMediaElement/addTextTrack.html: Removed.
  • media/track/opera/interfaces/HTMLElement/HTMLMediaElement/textTracks-expected.txt: Removed.
  • media/track/opera/interfaces/HTMLElement/HTMLMediaElement/textTracks.html: Removed.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/default-expected.txt: Removed.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/default.html: Removed.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/label-expected.txt: Removed.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/label.html: Removed.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/readyState-expected.txt: Removed.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/readyState.html: Removed.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/srclang-expected.txt: Removed.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/srclang.html: Removed.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/track-expected.txt: Removed.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/track.html: Removed.
  • media/track/opera/interfaces/TextTrack/addCue-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrack/addCue.html: Removed.
  • media/track/opera/interfaces/TextTrack/constants-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrack/constants.html: Removed.
  • media/track/opera/interfaces/TextTrack/cues-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrack/cues.html: Removed.
  • media/track/opera/interfaces/TextTrack/kind-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrack/kind.html: Removed.
  • media/track/opera/interfaces/TextTrack/label-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrack/label.html: Removed.
  • media/track/opera/interfaces/TextTrack/language-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrack/language.html: Removed.
  • media/track/opera/interfaces/TextTrack/mode-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrack/mode.html: Removed.
  • media/track/opera/interfaces/TextTrack/oncuechange-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrack/oncuechange.html: Removed.
  • media/track/opera/interfaces/TextTrack/removeCue-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrack/removeCue.html: Removed.
  • media/track/opera/interfaces/TextTrackCue/align-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrackCue/align.html: Removed.
  • media/track/opera/interfaces/TextTrackCue/endTime-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrackCue/endTime.html: Removed.
  • media/track/opera/interfaces/TextTrackCue/id-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrackCue/id.html: Removed.
  • media/track/opera/interfaces/TextTrackCue/pauseOnExit-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrackCue/pauseOnExit.html: Removed.
  • media/track/opera/interfaces/TextTrackCue/startTime-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrackCue/startTime.html: Removed.
  • media/track/opera/interfaces/TextTrackCue/track-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrackCue/track.html: Removed.
  • media/track/opera/interfaces/TextTrackCueList/getCueById-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrackCueList/getCueById.html: Removed.
  • media/track/opera/interfaces/TextTrackCueList/length-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrackCueList/length.html: Removed.
  • media/track/opera/interfaces/TextTrackList/length-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrackList/length.html: Removed.
  • media/track/opera/interfaces/TextTrackList/onaddtrack-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrackList/onaddtrack.html: Removed.
  • media/track/opera/interfaces/TextTrackList/onremovetrack-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrackList/onremovetrack.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/2_tracks-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/2_tracks.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/align_end-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/align_end.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle_position_50-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle_position_50.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle_position_gt_50-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle_position_gt_50.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle_position_lt_50-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle_position_lt_50.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle_position_lt_50_size_gt_maximum_size-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle_position_lt_50_size_gt_maximum_size.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/align_start-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/align_start.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/audio_has_no_subtitles-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/audio_has_no_subtitles.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/basic-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/basic.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/decode_escaped_entities-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/decode_escaped_entities.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_align_position_line_size-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_align_position_line_size.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_align_position_line_size_while_paused-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_align_position_line_size_while_paused.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_text-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_text.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_text_while_paused-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_text_while_paused.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_remove_cue_while_paused-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_remove_cue_while_paused.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/media/background.gif: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/media/white.mp4: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/media/white.webm: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/one_line_cue_plus_wrapped_cue-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/one_line_cue_plus_wrapped_cue.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/size_50-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/size_50.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/support/2_cues_overlapping_completely_move_up.vtt: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/support/align_end_long.vtt: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/support/foo.vtt: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/support/refTestWait.js: Removed.
  • media/track/w3c: Added.
  • media/track/w3c/interfaces: Added.
  • media/track/w3c/interfaces/HTMLMediaElement: Added.
  • media/track/w3c/interfaces/HTMLMediaElement/addTextTrack-expected.txt: Copied from media/track/opera/interfaces/HTMLElement/HTMLMediaElement/addTextTrack-expected.txt.
  • media/track/w3c/interfaces/HTMLMediaElement/addTextTrack.html: Copied from media/track/opera/interfaces/HTMLElement/HTMLMediaElement/addTextTrack.html.
  • media/track/w3c/interfaces/HTMLMediaElement/textTracks-expected.txt: Copied from media/track/opera/interfaces/HTMLElement/HTMLMediaElement/textTracks-expected.txt.
  • media/track/w3c/interfaces/HTMLMediaElement/textTracks.html: Copied from media/track/opera/interfaces/HTMLElement/HTMLMediaElement/textTracks.html.
  • media/track/w3c/interfaces/HTMLTrackElement: Added.
  • media/track/w3c/interfaces/HTMLTrackElement/default-expected.txt: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/default-expected.txt.
  • media/track/w3c/interfaces/HTMLTrackElement/default.html: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/default.html.
  • media/track/w3c/interfaces/HTMLTrackElement/label-expected.txt: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/label-expected.txt.
  • media/track/w3c/interfaces/HTMLTrackElement/label.html: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/label.html.
  • media/track/w3c/interfaces/HTMLTrackElement/readyState-expected.txt: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/readyState-expected.txt.
  • media/track/w3c/interfaces/HTMLTrackElement/readyState.html: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/readyState.html.
  • media/track/w3c/interfaces/HTMLTrackElement/srclang-expected.txt: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/srclang-expected.txt.
  • media/track/w3c/interfaces/HTMLTrackElement/srclang.html: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/srclang.html.
  • media/track/w3c/interfaces/HTMLTrackElement/track-expected.txt: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/track-expected.txt.
  • media/track/w3c/interfaces/HTMLTrackElement/track.html: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/track.html.
  • media/track/w3c/interfaces/TextTrack: Added.
  • media/track/w3c/interfaces/TextTrack/addCue-expected.txt: Copied from media/track/opera/interfaces/TextTrack/addCue-expected.txt.
  • media/track/w3c/interfaces/TextTrack/addCue.html: Copied from media/track/opera/interfaces/TextTrack/addCue.html.
  • media/track/w3c/interfaces/TextTrack/constants-expected.txt: Copied from media/track/opera/interfaces/TextTrack/constants-expected.txt.
  • media/track/w3c/interfaces/TextTrack/constants.html: Copied from media/track/opera/interfaces/TextTrack/constants.html.
  • media/track/w3c/interfaces/TextTrack/cues-expected.txt: Copied from media/track/opera/interfaces/TextTrack/cues-expected.txt.
  • media/track/w3c/interfaces/TextTrack/cues.html: Copied from media/track/opera/interfaces/TextTrack/cues.html.
  • media/track/w3c/interfaces/TextTrack/kind-expected.txt: Copied from media/track/opera/interfaces/TextTrack/kind-expected.txt.
  • media/track/w3c/interfaces/TextTrack/kind.html: Copied from media/track/opera/interfaces/TextTrack/kind.html.
  • media/track/w3c/interfaces/TextTrack/label-expected.txt: Copied from media/track/opera/interfaces/TextTrack/label-expected.txt.
  • media/track/w3c/interfaces/TextTrack/label.html: Copied from media/track/opera/interfaces/TextTrack/label.html.
  • media/track/w3c/interfaces/TextTrack/language-expected.txt: Copied from media/track/opera/interfaces/TextTrack/language-expected.txt.
  • media/track/w3c/interfaces/TextTrack/language.html: Copied from media/track/opera/interfaces/TextTrack/language.html.
  • media/track/w3c/interfaces/TextTrack/mode-expected.txt: Copied from media/track/opera/interfaces/TextTrack/mode-expected.txt.
  • media/track/w3c/interfaces/TextTrack/mode.html: Copied from media/track/opera/interfaces/TextTrack/mode.html.
  • media/track/w3c/interfaces/TextTrack/oncuechange-expected.txt: Copied from media/track/opera/interfaces/TextTrack/oncuechange-expected.txt.
  • media/track/w3c/interfaces/TextTrack/oncuechange.html: Copied from media/track/opera/interfaces/TextTrack/oncuechange.html.
  • media/track/w3c/interfaces/TextTrack/removeCue-expected.txt: Copied from media/track/opera/interfaces/TextTrack/removeCue-expected.txt.
  • media/track/w3c/interfaces/TextTrack/removeCue.html: Copied from media/track/opera/interfaces/TextTrack/removeCue.html.
  • media/track/w3c/interfaces/TextTrackCue: Added.
  • media/track/w3c/interfaces/TextTrackCue/align-expected.txt: Copied from media/track/opera/interfaces/TextTrackCue/align-expected.txt.
  • media/track/w3c/interfaces/TextTrackCue/align.html: Copied from media/track/opera/interfaces/TextTrackCue/align.html.
  • media/track/w3c/interfaces/TextTrackCue/endTime-expected.txt: Copied from media/track/opera/interfaces/TextTrackCue/endTime-expected.txt.
  • media/track/w3c/interfaces/TextTrackCue/endTime.html: Copied from media/track/opera/interfaces/TextTrackCue/endTime.html.
  • media/track/w3c/interfaces/TextTrackCue/id-expected.txt: Copied from media/track/opera/interfaces/TextTrackCue/id-expected.txt.
  • media/track/w3c/interfaces/TextTrackCue/id.html: Copied from media/track/opera/interfaces/TextTrackCue/id.html.
  • media/track/w3c/interfaces/TextTrackCue/pauseOnExit-expected.txt: Copied from media/track/opera/interfaces/TextTrackCue/pauseOnExit-expected.txt.
  • media/track/w3c/interfaces/TextTrackCue/pauseOnExit.html: Copied from media/track/opera/interfaces/TextTrackCue/pauseOnExit.html.
  • media/track/w3c/interfaces/TextTrackCue/startTime-expected.txt: Copied from media/track/opera/interfaces/TextTrackCue/startTime-expected.txt.
  • media/track/w3c/interfaces/TextTrackCue/startTime.html: Copied from media/track/opera/interfaces/TextTrackCue/startTime.html.
  • media/track/w3c/interfaces/TextTrackCue/track-expected.txt: Copied from media/track/opera/interfaces/TextTrackCue/track-expected.txt.
  • media/track/w3c/interfaces/TextTrackCue/track.html: Copied from media/track/opera/interfaces/TextTrackCue/track.html.
  • media/track/w3c/interfaces/TextTrackCueList: Added.
  • media/track/w3c/interfaces/TextTrackCueList/getCueById-expected.txt: Copied from media/track/opera/interfaces/TextTrackCueList/getCueById-expected.txt.
  • media/track/w3c/interfaces/TextTrackCueList/getCueById.html: Copied from media/track/opera/interfaces/TextTrackCueList/getCueById.html.
  • media/track/w3c/interfaces/TextTrackCueList/length-expected.txt: Copied from media/track/opera/interfaces/TextTrackCueList/length-expected.txt.
  • media/track/w3c/interfaces/TextTrackCueList/length.html: Copied from media/track/opera/interfaces/TextTrackCueList/length.html.
  • media/track/w3c/interfaces/TextTrackList: Added.
  • media/track/w3c/interfaces/TextTrackList/length-expected.txt: Copied from media/track/opera/interfaces/TextTrackList/length-expected.txt.
  • media/track/w3c/interfaces/TextTrackList/length.html: Copied from media/track/opera/interfaces/TextTrackList/length.html.
  • media/track/w3c/interfaces/TextTrackList/onaddtrack-expected.txt: Copied from media/track/opera/interfaces/TextTrackList/onaddtrack-expected.txt.
  • media/track/w3c/interfaces/TextTrackList/onaddtrack.html: Copied from media/track/opera/interfaces/TextTrackList/onaddtrack.html.
  • media/track/w3c/interfaces/TextTrackList/onremovetrack-expected.txt: Copied from media/track/opera/interfaces/TextTrackList/onremovetrack-expected.txt.
  • media/track/w3c/interfaces/TextTrackList/onremovetrack.html: Copied from media/track/opera/interfaces/TextTrackList/onremovetrack.html.
  • media/track/w3c/track: Added.
  • media/track/w3c/track/webvtt: Added.
  • media/track/w3c/track/webvtt/2_tracks-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/2_tracks-ref.html.
  • media/track/w3c/track/webvtt/2_tracks.html: Copied from media/track/opera/track/webvtt/rendering/reftest/2_tracks.html.
  • media/track/w3c/track/webvtt/align_end-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_end-ref.html.
  • media/track/w3c/track/webvtt/align_end.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_end.html.
  • media/track/w3c/track/webvtt/align_middle-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle-ref.html.
  • media/track/w3c/track/webvtt/align_middle.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle.html.
  • media/track/w3c/track/webvtt/align_middle_position_50-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle_position_50-ref.html.
  • media/track/w3c/track/webvtt/align_middle_position_50.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle_position_50.html.
  • media/track/w3c/track/webvtt/align_middle_position_gt_50-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle_position_gt_50-ref.html.
  • media/track/w3c/track/webvtt/align_middle_position_gt_50.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle_position_gt_50.html.
  • media/track/w3c/track/webvtt/align_middle_position_lt_50-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle_position_lt_50-ref.html.
  • media/track/w3c/track/webvtt/align_middle_position_lt_50.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle_position_lt_50.html.
  • media/track/w3c/track/webvtt/align_middle_position_lt_50_size_gt_maximum_size-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle_position_lt_50_size_gt_maximum_size-ref.html.
  • media/track/w3c/track/webvtt/align_middle_position_lt_50_size_gt_maximum_size.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle_position_lt_50_size_gt_maximum_size.html.
  • media/track/w3c/track/webvtt/align_start-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_start-ref.html.
  • media/track/w3c/track/webvtt/align_start.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_start.html.
  • media/track/w3c/track/webvtt/audio_has_no_subtitles-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/audio_has_no_subtitles-ref.html.
  • media/track/w3c/track/webvtt/audio_has_no_subtitles.html: Copied from media/track/opera/track/webvtt/rendering/reftest/audio_has_no_subtitles.html.
  • media/track/w3c/track/webvtt/background.gif: Copied from media/track/opera/track/webvtt/rendering/reftest/media/background.gif.
  • media/track/w3c/track/webvtt/basic-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/basic-ref.html.
  • media/track/w3c/track/webvtt/basic.html: Copied from media/track/opera/track/webvtt/rendering/reftest/basic.html.
  • media/track/w3c/track/webvtt/decode_escaped_entities-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/decode_escaped_entities-ref.html.
  • media/track/w3c/track/webvtt/decode_escaped_entities.html: Copied from media/track/opera/track/webvtt/rendering/reftest/decode_escaped_entities.html.
  • media/track/w3c/track/webvtt/dom_override_cue_align_position_line_size-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_align_position_line_size-ref.html.
  • media/track/w3c/track/webvtt/dom_override_cue_align_position_line_size.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_align_position_line_size.html.
  • media/track/w3c/track/webvtt/dom_override_cue_align_position_line_size_while_paused-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_align_position_line_size_while_paused-ref.html.
  • media/track/w3c/track/webvtt/dom_override_cue_align_position_line_size_while_paused.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_align_position_line_size_while_paused.html.
  • media/track/w3c/track/webvtt/dom_override_cue_text-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_text-ref.html.
  • media/track/w3c/track/webvtt/dom_override_cue_text.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_text.html.
  • media/track/w3c/track/webvtt/dom_override_cue_text_while_paused-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_text_while_paused-ref.html.
  • media/track/w3c/track/webvtt/dom_override_cue_text_while_paused.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_text_while_paused.html.
  • media/track/w3c/track/webvtt/dom_override_remove_cue_while_paused-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_remove_cue_while_paused-ref.html.
  • media/track/w3c/track/webvtt/dom_override_remove_cue_while_paused.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_remove_cue_while_paused.html.
  • media/track/w3c/track/webvtt/media: Added.
  • media/track/w3c/track/webvtt/media/white.mp4: Copied from media/track/opera/track/webvtt/rendering/reftest/media/white.mp4.
  • media/track/w3c/track/webvtt/media/white.webm: Copied from media/track/opera/track/webvtt/rendering/reftest/media/white.webm.
  • media/track/w3c/track/webvtt/one_line_cue_plus_wrapped_cue-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/one_line_cue_plus_wrapped_cue-ref.html.
  • media/track/w3c/track/webvtt/one_line_cue_plus_wrapped_cue.html: Copied from media/track/opera/track/webvtt/rendering/reftest/one_line_cue_plus_wrapped_cue.html.
  • media/track/w3c/track/webvtt/size_50-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/size_50-ref.html.
  • media/track/w3c/track/webvtt/size_50.html: Copied from media/track/opera/track/webvtt/rendering/reftest/size_50.html.
  • media/track/w3c/track/webvtt/support: Added.
  • media/track/w3c/track/webvtt/support/2_cues_overlapping_completely_move_up.vtt: Copied from media/track/opera/track/webvtt/rendering/reftest/support/2_cues_overlapping_completely_move_up.vtt.
  • media/track/w3c/track/webvtt/support/align_end_long.vtt: Copied from media/track/opera/track/webvtt/rendering/reftest/support/align_end_long.vtt.
  • media/track/w3c/track/webvtt/support/foo.vtt: Copied from media/track/opera/track/webvtt/rendering/reftest/support/foo.vtt.
  • media/track/w3c/track/webvtt/support/refTestWait.js: Copied from media/track/opera/track/webvtt/rendering/reftest/support/refTestWait.js.
    • platform/eft/TestExpectations: Skip w3c tests.
    • platform/gtk/TestExpectations: Skip w3c tests.
9:19 AM Changeset in webkit [166929] by Alan Bujtas
  • 4 edits
    2 adds in trunk

Subpixel rendering: Slow paint path for inlines should snap to device pixels.
​https://bugs.webkit.org/show_bug.cgi?id=131259

Reviewed by Simon Fraser.

InlineTextBox::paint needs to round to the same device pixel position as SimpleLineLayout does.

Source/WebCore:

Test: fast/inline/hidpi-slow-path-text-on-subpixel-position.html

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):

  • rendering/TextPainter.h: Cleanup. No reason to have them as references here.

LayoutTests:

  • fast/inline/hidpi-slow-path-text-on-subpixel-position-expected.html: Added.
  • fast/inline/hidpi-slow-path-text-on-subpixel-position.html: Added.
9:09 AM Changeset in webkit [166928] by dbates@webkit.org
  • 4 edits in trunk/Source

Fallback to default storage session when there isn't a valid session ID
​https://bugs.webkit.org/show_bug.cgi?id=131326
<rdar://problem/16231679>

Reviewed by Alexey Proskuryakov.

Fixes and issue where we may use the wrong storage session after disabling
a private browsing session.

Currently WebKit1 and WebKit2 without NetworkProcess assume that there
is always a non-null private browsing storage session so long as the page
has a non-default session ID. Instead we should only use the private browsing
storage session when it's non-null and the page has a non-default session ID;
otherwise, we should use the default storage session. This change will make
the behavior in WebKit1 and WebKit2 without NetworkProcess consistent with
the behavior in WebKit2 with NetworkProcess.

Source/WebKit/mac:

  • WebCoreSupport/WebFrameNetworkingContext.mm:

(WebFrameNetworkingContext::storageSession):

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::WebFrameNetworkingContext::storageSession):

9:01 AM Changeset in webkit [166927] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

Keep 'webkitClosedCaptionsVisible' API in sync with captions display preferences
​https://bugs.webkit.org/show_bug.cgi?id=131344

Reviewed by Eric Carlson.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::configureTextTrackGroup) If we decide that captions should
be active (due to user preferences) make sure the 'webkitClosedCaptionsVisible' state
is turned on.

7:52 AM Changeset in webkit [166926] by Alan Bujtas
  • 3 edits
    2 adds in trunk

Subpixel rendering: Paint the filter effect result image on device pixel position.
​https://bugs.webkit.org/show_bug.cgi?id=131255

Reviewed by Simon Fraser.

This patch moves filter effect images from integral to device pixel position. However,
result images are still integral based.

Source/WebCore:

Test: css3/filters/hidpi-filter-is-on-subpixel-position.html

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRendererHelper::applyFilterEffect):

LayoutTests:

  • css3/filters/hidpi-filter-is-on-subpixel-position-expected.html: Added.
  • css3/filters/hidpi-filter-is-on-subpixel-position.html: Added.
7:50 AM Changeset in webkit [166925] by Alan Bujtas
  • 3 edits
    2 adds in trunk

Subpixel rendering: Make border images device pixel aware.
​https://bugs.webkit.org/show_bug.cgi?id=131209

Reviewed by Simon Fraser.

Snap border-image size and position to device pixels. It works both on generated and bitmap images.

Source/WebCore:

Test: fast/borders/hidpi-border-image-gradient-on-subpixels.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintNinePieceImage):

LayoutTests:

  • fast/borders/hidpi-border-image-gradient-on-subpixels-expected.html: Added.
  • fast/borders/hidpi-border-image-gradient-on-subpixels.html: Added.
5:21 AM WebKitGTK/KeepingTheTreeGreen edited by Andres Gomez
Added tanty shifts (diff)
5:09 AM Changeset in webkit [166924] by commit-queue@webkit.org
  • 9 edits in trunk

[SOUP] Control cookie management according ResourceRequest.allowCookies()
​https://bugs.webkit.org/show_bug.cgi?id=131026

Patch by Youenn Fablet <​youenn.fablet@crf.canon.fr> on 2014-04-08
Reviewed by Sergio Villar Senin.

Source/WebCore:

Added per soup-message disabling of cookie jar manager when related ResourceRequest does not allow cookies (e.g. some cross-origin requests).

Patch is covered by unskipped test http/tests/xmlhttprequest/cross-origin-cookie-storage.html.

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateSoupMessageMembers): Added disabling of cookie jar manager if cookies are not allowed.

Source/WebKit2:

Added setting of accept cookies policy for the current soup network session cookie jar and all tracked sessions.
Moved the implementation of cookie policy setting from WebCookieManager to WebFrameNetworkingContext.

  • WebProcess/Cookies/soup/WebCookieManagerSoup.cpp:

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy): Moved implementation to WebCookieManager::platformSetHTTPCookieAcceptPolicy.

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:

(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts): Moved implementation from WebCookieManager::platformSetHTTPCookieAcceptPolicy and set the cookie jar accept policy to the cookie jars of all sessions in addition to the default cookie jar.

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h: Added method prototype.

LayoutTests:

  • platform/efl/TestExpectations: Unskipped test http/tests/xmlhttprequest/cross-origin-cookie-storage.html.
  • platform/gtk/TestExpectations: Ditto.
5:05 AM Changeset in webkit [166923] by svillar@igalia.com
  • 3 edits
    4 adds in trunk

[CSS Grid Layout] Handle min/max height in the grid element
​https://bugs.webkit.org/show_bug.cgi?id=131302

Reviewed by Darin Adler.

Source/WebCore:

Removed a FIXME in the code as we're already handling min/max
height in the code. Added a couple of test cases to improve the
test coverage.

Merged from Blink r161876 by <​jchaffraix@chromium.org>

Tests: fast/css-grid-layout/flex-content-sized-columns-resize.html

fast/css-grid-layout/grid-element-min-max-height.html

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutGridItems):

LayoutTests:

Added test coverage for min/max height handling in the grid
item. Also added other test to cover a blind spot in our testing,
resizing of content sized columns with flexible breadths.

Merged from Blink r161876 by <​jchaffraix@chromium.org> and r166914 by <Manuel Rego Casasnovas>.

  • fast/css-grid-layout/flex-content-sized-columns-resize-expected.html: Added.
  • fast/css-grid-layout/flex-content-sized-columns-resize.html: Added.
  • fast/css-grid-layout/grid-element-min-max-height-expected.txt: Added.
  • fast/css-grid-layout/grid-element-min-max-height.html: Added.
3:58 AM WebKitGTK/KeepingTheTreeGreen edited by eocanha@igalia.com
(diff)
2:21 AM Changeset in webkit [166922] by mihnea@adobe.com
  • 3 edits in trunk/Source/WebCore

[CSSRegions] Remove unused RenderBox::clearRenderBoxRegionInfo
​https://bugs.webkit.org/show_bug.cgi?id=131352

Reviewed by Andrei Bucur.

No new tests, code clean-up.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::clearRenderBoxRegionInfo): Deleted.

  • rendering/RenderBox.h:
2:15 AM Changeset in webkit [166921] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Buildfix after r166917
​https://bugs.webkit.org/show_bug.cgi?id=131351

Patch by Zsolt Borbely <​zsborbely.u-szeged@partner.samsung.com> on 2014-04-08
Reviewed by Andrei Bucur.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::accessibleNameForNode):

1:58 AM Changeset in webkit [166920] by Darin Adler
  • 13 edits in trunk/Source/WebCore

Fix assertions triggered by CSS calc changes in r166860
​https://bugs.webkit.org/show_bug.cgi?id=131346

Reviewed by Andrei Bucur.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::getBorderRadiusCornerValues): Use isPercentNotCalculated() instead of
type() == Percent; no behavior change.
(WebCore::getBorderRadiusCornerValue): Ditto.
(WebCore::lineHeightFromStyle): Use isPercentNotCalculated() before code
that calls percent(), which won't work for a calculated length.

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyBorderRadius::applyValue): Use isNegative and isZero rather
than calling value() unconditionally. Should make calculated values work better.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::is100Percent): Use isPercentNotCalculated() before code
that calls percent(), which won't work for a calculated length.

  • platform/Length.cpp:

(WebCore::CalculationValueMap::deref): Use adoptRef here instead of calling deref
immediately, so the deref will happen after calling remove. This makes the code
work properly even if it's reentered inside the calculation value's destructor.

  • platform/Length.h:

(WebCore::Length::percent): Change assert to isPercentNotCalculated, since the
value function this calls only works for non-calculated values anyway.
(WebCore::Length::isPercentNotCalculated): Added.
(WebCore::Length::isPercent): Changed to call isPercentNotCalculated.
(WebCore::Length::isSpecified): Changed to call isPercent.

  • platform/graphics/transforms/TranslateTransformOperation.h:

(WebCore::TranslateTransformOperation::apply): Use isPercentNotCalculated()
instead of type() == Percent; no behavior change.

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn): Use isPercentNotCalculated()
before code that calls value() or percent(), which won't work for a calculated length.
(WebCore::AutoTableLayout::computeIntrinsicLogicalWidths): Ditto.
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth): Ditto.
(WebCore::AutoTableLayout::layout): Ditto.

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::layout): Ditto.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions): Ditto.

  • rendering/RenderTableSection.cpp:

(WebCore::updateLogicalHeightForCell): Ditto.
(WebCore::RenderTableSection::distributeExtraLogicalHeightToPercentRows): Ditto.
(WebCore::RenderTableSection::distributeExtraLogicalHeightToRows): Ditto.

  • rendering/style/RenderStyle.cpp:

(WebCore::requireTransformOrigin): Use modern for loop. Also marked function static,
since it's private to this file.
(WebCore::RenderStyle::applyTransform): Use isPercentNotCalculated() instead of
type() == Percent; no behavior change. Also use a modern for loop and auto& to avoid
a really long type name.

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computeIntrinsicRatioInformation): Use isPercentNotCalculated()
before code that calls percent(), which won't work for a calculated length.

  • platform/Length.h:

(WebCore::Length::percent):
(WebCore::Length::isPercentNotCalculated):
(WebCore::Length::isPercent):
(WebCore::Length::isSpecified):

  • platform/graphics/transforms/TranslateTransformOperation.h:

(WebCore::TranslateTransformOperation::apply):

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::computeIntrinsicLogicalWidths):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::layout):

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::layout):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions):

  • rendering/RenderTableSection.cpp:

(WebCore::updateLogicalHeightForCell):
(WebCore::RenderTableSection::distributeExtraLogicalHeightToPercentRows):
(WebCore::RenderTableSection::distributeExtraLogicalHeightToRows):

  • rendering/style/RenderStyle.cpp:

(WebCore::requireTransformOrigin):
(WebCore::RenderStyle::applyTransform):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computeIntrinsicRatioInformation):

1:15 AM Changeset in webkit [166919] by calvaris@igalia.com
  • 2 edits
    1 delete in trunk/Source/WebCore

[GTK] Remove media controls dead code
​https://bugs.webkit.org/show_bug.cgi?id=131300

Reviewed by Eric Carlson.

MediaControlsGtk.cpp is no longer used so we can remove it from
the repo.

No new tests needed.

  • PlatformGTK.cmake: Remove html/shadow/MediaControlsGtk.cpp from

compilation.

  • html/shadow/MediaControlsGtk.cpp: Removed.
1:13 AM Changeset in webkit [166918] by mihnea@adobe.com
  • 3 edits
    2 adds in trunk

[CSSRegions] Fixed positioned elements in named flows have fragmented content
​https://bugs.webkit.org/show_bug.cgi?id=130595

Reviewed by Darin Adler.

Source/WebCore:

Fixed positioned elements that have the named flow as parent are positioned
and sized relative to the viewport. Because of that, when the named flow
has an associated region chain, the fixed positioned elements should not
be fragmented.

By making a fixed positioned element with a named flow parent unsplittable
for fragmentation, we prevent this wrong behavior.

Test: fast/regions/fixed-pos-content-fragmented.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::isUnsplittableForPagination):

LayoutTests:

  • fast/regions/fixed-pos-content-fragmented-expected.html: Added.
  • fast/regions/fixed-pos-content-fragmented.html: Added.
1:05 AM WebKitGTK/KeepingTheTreeGreen edited by ltilve@igalia.com
(diff)
12:59 AM Changeset in webkit [166917] by Chris Fleizach
  • 3 edits
    2 adds in trunk

Regression: AX: image labels no longer exposed to AX API in SVG test case
​https://bugs.webkit.org/show_bug.cgi?id=131208

Reviewed by Daniel Bates.

Source/WebCore:

accessibleNameForNode should work on any Element, not just HTML elements.

Test: accessibility/svg-labelledby.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::accessibleNameForNode):

LayoutTests:

  • accessibility/svg-labelledby-expected.txt: Added.
  • accessibility/svg-labelledby.html: Added.
12:37 AM Changeset in webkit [166916] by Andres Gomez
  • 8 edits in trunk/Source

[GTK] [EFL] Build fails with GCC < 4.8.x
​https://bugs.webkit.org/show_bug.cgi?id=130585

Reviewed by Martin Robinson.

The behavior in lower versions of GCC seem to be related to
​http://www.open-std.org/jtc1/sc22/wg21/docs/lwg-active.html#2132.

Provided explicit casts for the failing ambiguous overloads.

Source/WebCore:

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::createBus):

  • platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:

(webKitMediaSrcChangeState):
(webKitMediaVideoSrcNeedDataCb):
(webKitMediaAudioSrcNeedDataCb):
(webKitMediaVideoSrcEnoughDataCb):
(webKitMediaAudioSrcEnoughDataCb):
(webKitMediaVideoSrcSeekDataCb):
(webKitMediaAudioSrcSeekDataCb):

  • platform/gtk/GtkDragAndDropHelper.cpp:

(WebCore::GtkDragAndDropHelper::handleDragLeave):

  • platform/gtk/SharedTimerGtk.cpp:

(WebCore::setSharedTimerFireInterval):

Source/WTF:

  • wtf/gtk/MainThreadGtk.cpp:

(WTF::scheduleDispatchFunctionsOnMainThread):

  • wtf/gtk/RunLoopGtk.cpp:

(WTF::RunLoop::wakeUp): Provided lambda with a RefPtr instead of
ref and de-referring.

12:14 AM Changeset in webkit [166915] by gyuyoung.kim@samsung.com
  • 9 edits in trunk/Source

Change NavigatorContentUtils client ownership from port side to NavigatorContentUtils
​https://bugs.webkit.org/show_bug.cgi?id=131299

Reviewed by Darin Adler.

EFL and GTK ports have managed own client of NavigatorContentUtils though it is only passed to
NavigatorContentUtils. The NavigatorContentUtils has used the client to call port functions. So,
there is no reason port implementation needs to manage the ownership. To manage the client is
unnecessary work in current implementation.

Source/WebCore:

No new tests, no behavior changes.

  • Modules/navigatorcontentutils/NavigatorContentUtils.cpp:

(WebCore::NavigatorContentUtils::create):
(WebCore::provideNavigatorContentUtilsTo):

  • Modules/navigatorcontentutils/NavigatorContentUtils.h:
  • Modules/navigatorcontentutils/NavigatorContentUtilsClient.h:

Source/WebKit/efl:

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

Source/WebKit/gtk:

  • webkit/webkitwebview.cpp:

(webkit_web_view_init):

  • webkit/webkitwebviewprivate.h:

Apr 7, 2014:

11:55 PM Changeset in webkit [166914] by gyuyoung.kim@samsung.com
  • 7 edits in trunk/Source/WebKit2

[WK2] Fix unused parameter compile warning
​https://bugs.webkit.org/show_bug.cgi?id=131260

Reviewed by Darin Adler.

Remove the arguments name without UNUSED_PARAM().

  • UIProcess/API/APIDownloadClient.h:

(API::DownloadClient::didReceiveData):
(API::DownloadClient::shouldDecodeSourceDataOfMIMEType):
(API::DownloadClient::decideDestinationWithSuggestedFilename):
(API::DownloadClient::didCreateDestination):

  • UIProcess/API/APIFindClient.h:

(API::FindClient::didCountStringMatches):
(API::FindClient::didFindString):

  • UIProcess/API/APIHistoryClient.h:

(API::HistoryClient::didPerformClientRedirect):
(API::HistoryClient::didPerformServerRedirect):
(API::HistoryClient::didUpdateHistoryTitle):

  • UIProcess/API/APILoaderClient.h:

(API::LoaderClient::didStartProvisionalLoadForFrame):
(API::LoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(API::LoaderClient::didFailProvisionalLoadWithErrorForFrame):
(API::LoaderClient::didCommitLoadForFrame):
(API::LoaderClient::didFinishLoadForFrame):
(API::LoaderClient::didFailLoadWithErrorForFrame):
(API::LoaderClient::didChangeBackForwardList):

  • UIProcess/API/APIPolicyClient.h:

(API::PolicyClient::decidePolicyForNavigationAction):
(API::PolicyClient::decidePolicyForNewWindowAction):
(API::PolicyClient::decidePolicyForResponse):
(API::PolicyClient::unableToImplementPolicy):

11:51 PM Changeset in webkit [166913] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[Mac] Allow com.apple.ViewBridge preferences reading in plug-in sandbox profile
​https://bugs.webkit.org/show_bug.cgi?id=131306
<rdar://problem/16359865>

Reviewed by Sam Weinig.

  • Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb: Do it.
11:09 PM Changeset in webkit [166912] by Martin Robinson
  • 2 edits in trunk/LayoutTests

Skipped some HighDPI tests for GTK+

  • platform/gtk/TestExpectations: GTK+ does not yet have HighDPI support.
11:02 PM Changeset in webkit [166911] by Martin Robinson
  • 7 edits
    11 moves
    5 adds
    30 deletes in trunk/LayoutTests

[GTK] Remove WebKit1 test results and merge TestExpectations files
​https://bugs.webkit.org/show_bug.cgi?id=131342

Merge all WebKit1 test expectations into the gtk directory and also merge the WebKit2
test expectations files into the GTK+ one, removing duplicate lines.

  • http/tests/security/resources/drag-drop-allowed-expected.txt: Added.
  • platform/gtk-wk1: Removed.
  • platform/gtk-wk2: Removed.
  • platform/gtk/TestExpectations: Merged in WebKit2 expectations.
  • platform/gtk/accessibility/file-upload-button-stringvalue-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/accessibility/file-upload-button-stringvalue-expected.txt.
  • platform/gtk/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt:
  • platform/gtk/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt:
  • platform/gtk/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt.
  • platform/gtk/http/tests/loading/basic-credentials-sent-automatically-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt.
  • platform/gtk/http/tests/misc/401-alternative-content-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/http/tests/misc/401-alternative-content-expected.txt.
  • platform/gtk/http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt.
  • platform/gtk/http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt.
  • platform/gtk/http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt.
  • platform/gtk/http/tests/security/401-logout/401-logout-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/http/tests/security/401-logout/401-logout-expected.txt.
  • platform/gtk/http/tests/xmlhttprequest/failed-auth-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/http/tests/xmlhttprequest/failed-auth-expected.txt.
  • platform/gtk/http/tests/xmlhttprequest/remember-bad-password-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/http/tests/xmlhttprequest/remember-bad-password-expected.txt.
  • platform/gtk/js/dom/global-constructors-attributes-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/js/dom/global-constructors-attributes-expected.txt.
  • platform/gtk/plugins/npruntime/object-from-destroyed-plugin-expected.txt:
  • platform/gtk/plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt:
  • platform/gtk/plugins/plugin-clip-subframe-expected.txt:
10:31 PM Changeset in webkit [166910] by ggaren@apple.com
  • 14 edits
    7 adds in trunk

Build bmalloc on Mac
​https://bugs.webkit.org/show_bug.cgi?id=131333

Reviewed by Mark Rowe.

.:

  • Source/Makefile:
  • WebKitBuild: Added.
  • WebKitBuild/Debug: Added.

Source/bmalloc:

  • Makefile: Added. For make clients.

These files are required for building any project in WebKit. I copied
them from WTF:

  • Configurations: Added.
  • Configurations/Base.xcconfig: Added.
  • Configurations/DebugRelease.xcconfig: Added.
  • Configurations/bmalloc.xcconfig: Added.
  • Configurations/iOS.xcconfig: Added.
  • Configurations/mbmalloc.xcconfig: Added.
  • bmalloc.xcodeproj/project.pbxproj: I removed per-project-file stuff

from here because everything is in .xcconfig files now.

I had to fix a bunch of minor warnings, since they're enabled in our
.xcconfig files:

  • bmalloc/AsyncTask.h:

(bmalloc::Function>::AsyncTask):

  • bmalloc/BAssert.h:
  • bmalloc/BoundaryTagInlines.h:

(bmalloc::validate):

  • bmalloc/Heap.cpp:

(bmalloc::Heap::Heap):
(bmalloc::Heap::allocateLarge):
(bmalloc::Heap::deallocateLarge):

  • bmalloc/Mutex.h:

(bmalloc::Mutex::Mutex): Deleted.

  • bmalloc/VMAllocate.h:

(bmalloc::vmValidate):

  • bmalloc/mbmalloc.cpp:

Tools:

  • Scripts/build-webkit: Add the bmalloc target if we're on Mac.

(Note: Just testing Mac is not good enough because in this
script 'Mac' means 'Mac or iOS'.)

9:47 PM Changeset in webkit [166909] by zoltan@webkit.org
  • 3 edits in trunk/Source/WebCore

[CSS Shapes] Simplify the parsing of width arguments for Inset shapes
​https://bugs.webkit.org/show_bug.cgi?id=131305

Reviewed by Andreas Kling.

This code introduces some helper functions for setting the size arguments of inset shapes. This change
also modifies the code to be the same as in Blink, so it helps us to keep the shapes code similar.

No new tests, no behavior change.

  • css/CSSBasicShapes.h:

(WebCore::CSSBasicShapeInset::updateShapeSize4Values):
(WebCore::CSSBasicShapeInset::updateShapeSize1Value):
(WebCore::CSSBasicShapeInset::updateShapeSize2Values):
(WebCore::CSSBasicShapeInset::updateShapeSize3Values):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseBasicShapeInset):

8:55 PM Changeset in webkit [166908] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Setters are just getters that take an extra argument and don't return a value
​https://bugs.webkit.org/show_bug.cgi?id=131336

Reviewed by Geoffrey Garen.

Other than that, they're totally the same thing.

This isn't as dumb as it sounds.

Most of the work in calling an accessor has to do with emitting the necessary checks for
figuring out whether we're calling the accessor we expected, followed by the boilerplate
needed for setting up a call inside of a stub. It makes sense for the code to be totally
common.

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::storeValue):
(JSC::AssemblyHelpers::moveTrustedValue):

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupResults):

  • jit/Repatch.cpp:

(JSC::kindFor):
(JSC::customFor):
(JSC::generateByIdStub):
(JSC::tryCacheGetByID):
(JSC::tryBuildGetByIDList):
(JSC::tryCachePutByID):
(JSC::tryBuildPutByIdList):
(JSC::generateGetByIdStub): Deleted.
(JSC::emitCustomSetterStub): Deleted.

  • runtime/JSCJSValue.h:

(JSC::JSValue::asValue):

  • runtime/PutPropertySlot.h:

(JSC::PutPropertySlot::cachedOffset):

8:49 PM Changeset in webkit [166907] by Stephanie Lewis
  • 2 edits in trunk/Source/WebKit2

Crash in com.apple.WebKit.Plugin.Development at com.apple.WebKit2: WebKit::PluginControllerProxy::pluginInstanceID
<rdar://problem/16479432>
​https://bugs.webkit.org/show_bug.cgi?id=131203

Reviewed by Geoff Garen.

pluginController was being removed before accessing the pluginInstanceID.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::removePluginControllerProxy):

7:46 PM Changeset in webkit [166906] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

More Mountain Lion build fix.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
7:12 PM Changeset in webkit [166905] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

[iOS][WK2] Implement the update of content offset on animated resize
​https://bugs.webkit.org/show_bug.cgi?id=131329

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-04-07
Reviewed by Tim Horton.

Compute a reasonable target offset on rotation. This goes in 3 steps:
1) Move the page so that the center does not move during scaling.
2) Limit the range to keep the page in scrollview without rubberbanding.
3) The horizontal content stays the same but the vertical area changes. When on the top or bottom

edge, stick to the edge.

The code is moved inside _beginAnimatedResizeToSize:obscuredInsets:minimumLayoutSizeOverride: so that we can tell
the WebProcess where the scroll position will be at the end of the animation.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _frameOrBoundsChangedFrom:]):
(-[WKWebView _updateVisibleContentRects]):
(-[WKWebView _beginAnimatedResizeToSize:obscuredInsets:minimumLayoutSizeOverride:]):

7:07 PM Changeset in webkit [166904] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

Mountain Lion build fix.

  • UIProcess/ios/PageClientImplIOS.mm:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
6:38 PM Changeset in webkit [166903] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Handle decoding of nil invocation arguments
​https://bugs.webkit.org/show_bug.cgi?id=131335
<rdar://problem/16528449>

Reviewed by Tim Horton.

  • Shared/APIArray.h:

Don't crash if the array element is null.

6:35 PM Changeset in webkit [166902] by Martin Robinson
  • 8 edits in trunk

fast/css3-text/css3-text-decoration/text-decoration-thickness.html fails on GTK
​https://bugs.webkit.org/show_bug.cgi?id=129957

Reviewed by Dean Jackson.

Source/WebCore:

Causes existing tests to pass.

  • platform/graphics/cairo/GraphicsContextCG.cpp: Use the now-shared computeLineBoundsAndAntialiasingModeForText.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: Align the Cairo version of text underline drawing with the CG version.
  • platform/graphics/GraphicsContext.h: Add computeLineBoundsAndAntialiasingModeForText.
  • platform/graphics/GraphicsContext.cpp: Ditto.

LayoutTests:

Unskipped tests and modified one test to use the platform-independent Ahem font.

  • fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-tall-underlines.html: We

need to use Ahem because Helvetica is not a platform-independent font.

  • platform/gtk/TestExpectations: Unskipped tests.
5:56 PM Changeset in webkit [166901] by Brian Burg
  • 12 edits
    4 moves
    3 adds in trunk/LayoutTests

Web Inspector: test helper files should be under LayoutTests/http/tests/inspector/
​https://bugs.webkit.org/show_bug.cgi?id=131324

Reviewed by Joseph Pecoraro.

Rearrange helper files used by full inspector tests. In their previous placement,
they were outside the http server root and couldn't be loaded from http tests.

  • http/tests/inspector/debugger/debugger-test.js: Renamed from LayoutTests/inspector/debugger/debugger-test.js.
  • http/tests/inspector/dom/shapes-test.js: Renamed from LayoutTests/inspector/dom/shapes-test.js.
  • http/tests/inspector/inspector-test.js: Renamed from LayoutTests/inspector/inspector-test.js.
  • http/tests/inspector/replay/replay-test.js: Renamed from LayoutTests/inspector/replay/replay-test.js.
  • inspector/debugger/probe-manager-add-remove-actions.html:
  • inspector/dom/content-flow-content-nodes.html:
  • inspector/dom/content-flow-content-removal.html:
  • inspector/dom/content-flow-list.html:
  • inspector/dom/content-node-region-info.html:
  • inspector/dom/highlight-shape-outside-margin.html:
  • inspector/dom/highlight-shape-outside.html:
  • inspector/page/main-frame-resource.html:
  • inspector/replay/javascript-date-now.html:
  • inspector/replay/javascript-random-seed.html:
  • inspector/test-harness-trivially-works.html:
5:39 PM Changeset in webkit [166900] by mitz@apple.com
  • 13 edits in trunk/Source/WebKit2

Add bundle client function corresponding to startAssistingNode
​https://bugs.webkit.org/show_bug.cgi?id=131332

Reviewed by Anders Carlsson.

  • UIProcess/PageClient.h: Added userData parameter to startAssistingNode.
  • UIProcess/WebPageProxy.h: Added message decoder parameter to startAssistingNode.
  • UIProcess/WebPageProxy.messages.in: Added message decoder parameter to StartAssistingNode.
  • UIProcess/ios/PageClientImplIOS.h: Updated startAssistingNode override.
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::startAssistingNode): Decode the user data into an NSObject and pass
it on to the content view.

  • UIProcess/ios/WKContentViewInteraction.h: Added userObject parameter to

-_startAssitingNode:.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _startAssistingNode:userObject:]): Added userObject parameter. We will pass
it to a future delegate method.

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::startAssistingNode): Decode the user data and pass it to the client.

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFormDelegatePrivate.h: Declared new

delegate method.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]): Added an implementation
of API::InjectedBundle::FormClient::willBeginInputSession which calls the new delegate
method, and encodes the user object into userData.

  • WebProcess/InjectedBundle/APIInjectedBundleFormClient.h:

(API::InjectedBundle::FormClient::willBeginInputSession): Added willBeginInputSession.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::elementDidFocus): Call willBeginInputSession and send the user data along
with the StartAssistingNode message to the UI process.

5:24 PM Changeset in webkit [166899] by jinwoo7.song@samsung.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Fixing the EFL build.

  • WebProcess/WebPage/CoordinatedGraphics/WebPageCoordinatedGraphics.cpp: Include the Document header from WebCore

to avoid operating on an incomplete type.

5:23 PM Changeset in webkit [166898] by ggaren@apple.com
  • 2 edits in trunk/Source/bmalloc

bmalloc: Fixed a leak in the per-thread cache
​https://bugs.webkit.org/show_bug.cgi?id=131330

Reviewed by Andreas Kling.

Remember to deallocate our line caches upon thread exit.

  • bmalloc/Deallocator.cpp:

(bmalloc::Deallocator::~Deallocator):

5:12 PM Changeset in webkit [166897] by ggaren@apple.com
  • 8 edits in trunk/Source/bmalloc

bmalloc: rolled out the tryLock experiment
​https://bugs.webkit.org/show_bug.cgi?id=131328

Reviewed by Andreas Kling.

It wasn't a speedup.

  • bmalloc.xcodeproj/project.pbxproj:
  • bmalloc/Allocator.cpp:

(bmalloc::Allocator::processSmallAllocatorLog):
(bmalloc::Allocator::processMediumAllocatorLog):

  • bmalloc/Deallocator.cpp:

(bmalloc::Deallocator::processObjectLog):
(bmalloc::Deallocator::deallocateSlowCase):
(bmalloc::Deallocator::deallocateSmallLine):
(bmalloc::Deallocator::deallocateMediumLine):

  • bmalloc/Deallocator.h:

(bmalloc::Deallocator::deallocateFastCase):

  • bmalloc/Heap.h:

(bmalloc::Heap::deallocateSmallLine):
(bmalloc::Heap::deallocateMediumLine):

  • bmalloc/Line.h:

(bmalloc::Line<Traits>::deref):

  • bmalloc/Page.h:

(bmalloc::Page<Traits>::deref):

5:07 PM Changeset in webkit [166896] by timothy_horton@apple.com
  • 4 edits in trunk/Source/WebKit2

[iOS WebKit2] WKPDFView fades in tiles, PDFs load very flashily
​https://bugs.webkit.org/show_bug.cgi?id=131325
<rdar://problem/16382960>

Reviewed by Anders Carlsson.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView scrollViewDidScroll:]):
Forward scroll events to the current custom content provider.

  • UIProcess/Cocoa/WKWebViewContentProvider.h:

Make content providers UIScrollViewDelegates (though we only forward didScroll for now).

  • UIProcess/ios/WKPDFView.mm:

(-[WKPDFView web_setContentProviderData:suggestedFilename:]):
(-[WKPDFView web_setMinimumSize:]):
(-[WKPDFView web_setScrollView:]):
(-[WKPDFView scrollViewDidScroll:]):
(-[WKPDFView _revalidateViews]):
(-[WKPDFView _computePageAndDocumentFrames]):
(-[WKPDFView layoutViews]): Deleted.
Keep track of each UIPDFPage, UIPDFPageView, and its frame (in unscaled/document coordinates).
Compute all the rects up front (and re-compute upon rotation, loading, etc.).
When scrolling, find all the pages that intersect the view (inflated by 1.5x in each
vertical direction), and ensure that pages that are inside that rect have
UIPDFPageViews installed, and ones that are outside that rect do not.
Use setUseBackingLayer to ensure that we have a low-resolution layer behind the
tiled layer to avoid flashiness.

5:04 PM Changeset in webkit [166895] by Beth Dakin
  • 4 edits in trunk/Source/WebCore

REGRESSION (r163194-r163227): Garbage tiles in overflow of RTL page with
background image
​https://bugs.webkit.org/show_bug.cgi?id=131323
-and corresponding-
<rdar://problem/16402013>

Reviewed by Tim Horton.

Returning the TiledBacking::bounds() for the
FrameView::extendedBackgroundRectForPainting() in convenient for ltr pages, but it
is simply incorrect in rtl. There is no easy way to map the rect into the right
coordinate space, so this patch re-works the code to use computations in
RenderView to get the right rect.

Call RenderView::unextendedBackgroundRect() and expand and move it based on the
TiledBacking’s margins.

  • page/FrameView.cpp:

(WebCore::FrameView::extendedBackgroundRectForPainting):

The logic that used to be in backgroundRect() has been moved to
unextendedBackgroundRect().

  • rendering/RenderView.cpp:

(WebCore::RenderView::unextendedBackgroundRect):
(WebCore::RenderView::backgroundRect):

  • rendering/RenderView.h:
5:01 PM Changeset in webkit [166894] by zoltan@webkit.org
  • 5 edits in trunk

[CSS Shapes] inset complex calc() args vanish in serialized computed style
​https://bugs.webkit.org/show_bug.cgi?id=129838

Reviewed by Bem Jones-Bey.

Source/WebCore:

We didn't pass the style parameter when setting the width members of CSSBasicShapeInset,
which lead to a 'should never reach asserttion' in CSSPrimitiveValue::init. This patch
adds the missing parameters to the call sites.

Extended existing parsing test script.

  • css/BasicShapeFunctions.cpp:

(WebCore::valueForBasicShape):

LayoutTests:

  • fast/shapes/parsing/parsing-shape-outside-expected.txt:
  • fast/shapes/parsing/parsing-test-utils.js:
4:54 PM Changeset in webkit [166893] by ggaren@apple.com
  • 55 adds in trunk/Source/bmalloc

bmalloc
​https://bugs.webkit.org/show_bug.cgi?id=131170

Reviewed by Andreas Kling.

Initial commit.

  • bmalloc: Added.
  • bmalloc.xcodeproj: Added.
  • bmalloc.xcodeproj/project.pbxproj: Added.
  • bmalloc/Algorithm.h: Added.

(bmalloc::max):
(bmalloc::min):
(bmalloc::mask):
(bmalloc::test):
(bmalloc::roundUpToMultipleOf):
(bmalloc::roundDownToMultipleOf):
(bmalloc::sizeOf):
(bmalloc::bitCount):
(bmalloc::isPowerOfTwo):

  • bmalloc/Allocator.cpp: Added.

(bmalloc::Allocator::Allocator):
(bmalloc::Allocator::~Allocator):
(bmalloc::Allocator::log):
(bmalloc::Allocator::processSmallAllocatorLog):
(bmalloc::Allocator::processMediumAllocatorLog):
(bmalloc::Allocator::allocateLarge):
(bmalloc::Allocator::allocateXLarge):
(bmalloc::Allocator::allocateMedium):
(bmalloc::Allocator::allocateSlowCase):

  • bmalloc/Allocator.h: Added.

(bmalloc::Allocator::smallAllocatorFor):
(bmalloc::Allocator::allocateFastCase):
(bmalloc::Allocator::allocate):

  • bmalloc/AsyncTask.cpp: Added.

(bmalloc::AsyncTask<Function>::runSlowCase):
(bmalloc::AsyncTask<Function>::pthreadEntryPoint):
(bmalloc::AsyncTask<Function>::entryPoint):

  • bmalloc/AsyncTask.h: Added.

(bmalloc::Function>::AsyncTask):
(bmalloc::Function>::join):
(bmalloc::Function>::run):
(bmalloc::Function>::runSlowCase):
(bmalloc::Function>::pthreadEntryPoint):
(bmalloc::Function>::entryPoint):

  • bmalloc/BAssert.h: Added.
  • bmalloc/BeginTag.h: Added.

(bmalloc::BeginTag::isInFreeList):

  • bmalloc/BoundaryTag.h: Added.

(bmalloc::BoundaryTag::isXLarge):
(bmalloc::BoundaryTag::setXLarge):
(bmalloc::BoundaryTag::isFree):
(bmalloc::BoundaryTag::setFree):
(bmalloc::BoundaryTag::isEnd):
(bmalloc::BoundaryTag::setEnd):
(bmalloc::BoundaryTag::hasPhysicalPages):
(bmalloc::BoundaryTag::setHasPhysicalPages):
(bmalloc::BoundaryTag::isNull):
(bmalloc::BoundaryTag::clear):
(bmalloc::BoundaryTag::size):
(bmalloc::BoundaryTag::setSize):
(bmalloc::BoundaryTag::prev):
(bmalloc::BoundaryTag::next):

  • bmalloc/BoundaryTagInlines.h: Added.

(bmalloc::validate):
(bmalloc::validatePrev):
(bmalloc::validateNext):
(bmalloc::BoundaryTag::init):
(bmalloc::BoundaryTag::mergeLargeLeft):
(bmalloc::BoundaryTag::mergeLargeRight):
(bmalloc::BoundaryTag::mergeLarge):
(bmalloc::BoundaryTag::deallocate):
(bmalloc::BoundaryTag::splitLarge):
(bmalloc::BoundaryTag::allocate):

  • bmalloc/Cache.cpp: Added.

(bmalloc::Cache::operator new):
(bmalloc::Cache::operator delete):
(bmalloc::Cache::Cache):
(bmalloc::Cache::allocateSlowCase):
(bmalloc::Cache::allocateSlowCaseNullCache):
(bmalloc::Cache::deallocateSlowCase):
(bmalloc::Cache::deallocateSlowCaseNullCache):

  • bmalloc/Cache.h: Added.

(bmalloc::Cache::allocator):
(bmalloc::Cache::deallocator):
(bmalloc::Cache::allocateFastCase):
(bmalloc::Cache::deallocateFastCase):
(bmalloc::Cache::allocate):
(bmalloc::Cache::deallocate):

  • bmalloc/Chunk.h: Added.

(bmalloc::Chunk::begin):
(bmalloc::Chunk::end):
(bmalloc::Chunk::lines):
(bmalloc::Chunk::pages):

  • bmalloc/Deallocator.cpp: Added.

(bmalloc::Deallocator::Deallocator):
(bmalloc::Deallocator::~Deallocator):
(bmalloc::Deallocator::deallocateLarge):
(bmalloc::Deallocator::deallocateXLarge):
(bmalloc::Deallocator::processObjectLog):
(bmalloc::Deallocator::deallocateSlowCase):
(bmalloc::Deallocator::deallocateSmallLine):
(bmalloc::Deallocator::allocateSmallLine):
(bmalloc::Deallocator::deallocateMediumLine):
(bmalloc::Deallocator::allocateMediumLine):

  • bmalloc/Deallocator.h: Added.

(bmalloc::Deallocator::deallocateFastCase):
(bmalloc::Deallocator::deallocate):

  • bmalloc/EndTag.h: Added.

(bmalloc::EndTag::operator=):

  • bmalloc/FixedVector.h: Added.

(bmalloc::FixedVector::begin):
(bmalloc::FixedVector::end):
(bmalloc::FixedVector::size):
(bmalloc::FixedVector::capacity):
(bmalloc::FixedVector::clear):
(bmalloc::FixedVector::isEmpty):
(bmalloc::Capacity>::FixedVector):
(bmalloc::Capacity>::operator):
(bmalloc::Capacity>::push):
(bmalloc::Capacity>::pop):
(bmalloc::Capacity>::shrink):

  • bmalloc/Heap.cpp: Added.

(bmalloc::sleep):
(bmalloc::Heap::Heap):
(bmalloc::Heap::concurrentScavenge):
(bmalloc::Heap::scavengeSmallPages):
(bmalloc::Heap::scavengeMediumPages):
(bmalloc::Heap::scavengeLargeRanges):
(bmalloc::Heap::allocateSmallLineSlowCase):
(bmalloc::Heap::allocateMediumLineSlowCase):
(bmalloc::Heap::allocateXLarge):
(bmalloc::Heap::deallocateXLarge):
(bmalloc::Heap::allocateLarge):
(bmalloc::Heap::deallocateLarge):

  • bmalloc/Heap.h: Added.

(bmalloc::Heap::deallocateSmallLine):
(bmalloc::Heap::allocateSmallLine):
(bmalloc::Heap::deallocateMediumLine):
(bmalloc::Heap::allocateMediumLine):

  • bmalloc/Inline.h: Added.
  • bmalloc/LargeChunk.h: Added.

(bmalloc::LargeChunk::begin):
(bmalloc::LargeChunk::end):
(bmalloc::LargeChunk::create):
(bmalloc::LargeChunk::get):
(bmalloc::LargeChunk::beginTag):
(bmalloc::LargeChunk::endTag):

  • bmalloc/Line.h: Added.

(bmalloc::Line<Traits>::begin):
(bmalloc::Line<Traits>::end):
(bmalloc::Line<Traits>::concurrentRef):
(bmalloc::Line<Traits>::deref):

  • bmalloc/MediumAllocator.h: Added.

(bmalloc::MediumAllocator::isNull):
(bmalloc::MediumAllocator::MediumAllocator):
(bmalloc::MediumAllocator::line):
(bmalloc::MediumAllocator::allocate):
(bmalloc::MediumAllocator::derefCount):
(bmalloc::MediumAllocator::refill):

  • bmalloc/MediumChunk.h: Added.
  • bmalloc/MediumLine.h: Added.
  • bmalloc/MediumPage.h: Added.
  • bmalloc/MediumTraits.h: Added.
  • bmalloc/Mutex.cpp: Added.

(bmalloc::Mutex::lockSlowCase):

  • bmalloc/Mutex.h: Added.

(bmalloc::Mutex::Mutex):
(bmalloc::Mutex::try_lock):
(bmalloc::Mutex::lock):
(bmalloc::Mutex::unlock):

  • bmalloc/ObjectType.cpp: Added.

(bmalloc::objectType):

  • bmalloc/ObjectType.h: Added.

(bmalloc::isSmallOrMedium):
(bmalloc::isSmall):

  • bmalloc/Page.h: Added.

(bmalloc::Page<Traits>::ref):
(bmalloc::Page<Traits>::deref):
(bmalloc::Page<Traits>::refCount):

  • bmalloc/PerProcess.h: Added.

(bmalloc::PerProcess::mutex):
(bmalloc::PerProcess<T>::getFastCase):
(bmalloc::PerProcess<T>::get):
(bmalloc::PerProcess<T>::getSlowCase):

  • bmalloc/PerThread.h: Added.

(bmalloc::PerThreadStorage<Cache>::get):
(bmalloc::PerThreadStorage<Cache>::init):
(bmalloc::PerThreadStorage::get):
(bmalloc::PerThreadStorage::init):
(bmalloc::PerThread<T>::getFastCase):
(bmalloc::PerThread<T>::get):
(bmalloc::PerThread<T>::destructor):
(bmalloc::PerThread<T>::getSlowCase):

  • bmalloc/Range.h: Added.

(bmalloc::Range::Range):
(bmalloc::Range::begin):
(bmalloc::Range::end):
(bmalloc::Range::size):
(bmalloc::Range::operator!):
(bmalloc::Range::operator<):

  • bmalloc/SegregatedFreeList.cpp: Added.

(bmalloc::SegregatedFreeList::SegregatedFreeList):
(bmalloc::SegregatedFreeList::insert):
(bmalloc::SegregatedFreeList::takeGreedy):
(bmalloc::SegregatedFreeList::take):

  • bmalloc/SegregatedFreeList.h: Added.
  • bmalloc/Sizes.h: Added.
  • bmalloc/SmallAllocator.h: Added.

(bmalloc::SmallAllocator::isNull):
(bmalloc::SmallAllocator::canAllocate):
(bmalloc::SmallAllocator::SmallAllocator):
(bmalloc::SmallAllocator::line):
(bmalloc::SmallAllocator::allocate):
(bmalloc::SmallAllocator::objectCount):
(bmalloc::SmallAllocator::derefCount):
(bmalloc::SmallAllocator::refill):

  • bmalloc/SmallChunk.h: Added.
  • bmalloc/SmallLine.h: Added.
  • bmalloc/SmallPage.h: Added.
  • bmalloc/SmallTraits.h: Added.
  • bmalloc/Syscall.h: Added.
  • bmalloc/VMAllocate.h: Added.

(bmalloc::vmSize):
(bmalloc::vmValidate):
(bmalloc::vmAllocate):
(bmalloc::vmDeallocate):
(bmalloc::vmDeallocatePhysicalPages):
(bmalloc::vmAllocatePhysicalPages):
(bmalloc::vmDeallocatePhysicalPagesSloppy):
(bmalloc::vmAllocatePhysicalPagesSloppy):

  • bmalloc/VMHeap.cpp: Added.

(bmalloc::VMHeap::VMHeap):
(bmalloc::VMHeap::allocateSmallChunk):
(bmalloc::VMHeap::allocateMediumChunk):
(bmalloc::VMHeap::allocateLargeChunk):

  • bmalloc/VMHeap.h: Added.

(bmalloc::VMHeap::allocateSmallPage):
(bmalloc::VMHeap::allocateMediumPage):
(bmalloc::VMHeap::allocateLargeRange):
(bmalloc::VMHeap::deallocateSmallPage):
(bmalloc::VMHeap::deallocateMediumPage):
(bmalloc::VMHeap::deallocateLargeRange):

  • bmalloc/Vector.h: Added.

(bmalloc::Vector::begin):
(bmalloc::Vector::end):
(bmalloc::Vector::size):
(bmalloc::Vector::capacity):
(bmalloc::Vector::last):
(bmalloc::Vector::pop):
(bmalloc::Vector<T>::Vector):
(bmalloc::Vector<T>::~Vector):
(bmalloc::Vector<T>::operator):
(bmalloc::Vector<T>::push):
(bmalloc::Vector<T>::pop):
(bmalloc::Vector<T>::shrink):
(bmalloc::Vector<T>::reallocateBuffer):
(bmalloc::Vector<T>::shrinkCapacity):
(bmalloc::Vector<T>::growCapacity):

  • bmalloc/XLargeChunk.h: Added.

(bmalloc::XLargeChunk::get):
(bmalloc::XLargeChunk::begin):
(bmalloc::XLargeChunk::XLargeChunk):
(bmalloc::XLargeChunk::create):
(bmalloc::XLargeChunk::destroy):
(bmalloc::XLargeChunk::range):
(bmalloc::XLargeChunk::size):

  • bmalloc/bmalloc.h: Added.

(bmalloc::api::malloc):
(bmalloc::api::free):
(bmalloc::api::realloc):

  • bmalloc/mbmalloc.cpp: Added.
4:51 PM Changeset in webkit [166892] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] MediaDocument should allow autoplay
​https://bugs.webkit.org/show_bug.cgi?id=131301

Reviewed by Jer Noble.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Don't add the RequireUserGestureForRateChange

behavior restriction when in a MediaDocument.

4:45 PM Changeset in webkit [166891] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Web Inspector: Hang in debuggable application after receiving WIRPermissionDenied
​https://bugs.webkit.org/show_bug.cgi?id=131321

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-04-07
Reviewed by Mark Rowe.

  • inspector/remote/RemoteInspector.mm:

(Inspector::RemoteInspector::xpcConnectionReceivedMessage):
Avoid attempting to take the same lock twice. Move the received message
lock grab after the WIRPermissionDenied branch, which takes the lock
inside RemoteInspector::stop.

4:00 PM Changeset in webkit [166890] by mitz@apple.com
  • 11 edits
    1 add in trunk/Source/WebKit2

Add API::InjectedBundle::FormClient
​https://bugs.webkit.org/show_bug.cgi?id=131317

Reviewed by Anders Carlsson.

  • WebKit2.xcodeproj/project.pbxproj: Added reference to new file.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetFormClient):

  • WebProcess/InjectedBundle/API/c/WKBundlePageFormClient.h:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]): Changed to define and
create a FormClient (which derives from API::InjectedBundle::FormClient and messages a
delegate), and set it as the form client.
(didFocusTextField): Deleted.
(willSubmitForm): Deleted.
(setUpFormClient): Deleted.

  • WebProcess/InjectedBundle/APIInjectedBundleFormClient.h: Added.

(API::InjectedBundle::FormClient::~FormClient):
(API::InjectedBundle::FormClient::didFocusTextField):
(API::InjectedBundle::FormClient::textFieldDidBeginEditing):
(API::InjectedBundle::FormClient::textFieldDidEndEditing):
(API::InjectedBundle::FormClient::textDidChangeInTextField):
(API::InjectedBundle::FormClient::textDidChangeInTextArea):
(API::InjectedBundle::FormClient::shouldPerformActionInTextField):
(API::InjectedBundle::FormClient::willSubmitForm):
(API::InjectedBundle::FormClient::willSendSubmitEvent):
(API::InjectedBundle::FormClient::didAssociateFormControls):
(API::InjectedBundle::FormClient::shouldNotifyOnFormChanges):

  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:

(WebKit::InjectedBundlePageFormClient::InjectedBundlePageFormClient): Added a constructor
from WKBundlePageFormClientBase.
(WebKit::toWKInputFieldActionType): Added helper to convert from internal enum to C SPI
enum.
(WebKit::InjectedBundlePageFormClient::shouldPerformActionInTextField): Use helper.

  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.h: Added inheritance from

API::InjectedBundle::FormClient, marked overrides as such.

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h: Removed unused forward

declarations.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::toInputFieldAction): Added helper to convert from C SPI enum to internal enum.
(WebKit::WebEditorClient::doTextFieldCommandFromEvent): Use helper.
(WebKit::WebEditorClient::textWillBeDeletedInTextField): Ditto.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Initialize m_formClient member.
(WebKit::WebPage::setInjectedBundleFormClient): Added. Updates m_formClient.
(WebKit::WebPage::close): Updated code to clear m_formClient.
(WebKit::WebPage::initializeInjectedBundleFormClient): Deleted.

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::injectedBundleFormClient): Updated return type.

3:21 PM Changeset in webkit [166889] by commit-queue@webkit.org
  • 39 edits in trunk/Source

Move to using std::unique_ptr for opengl, texmap, transforms and efl in WebCore/platform/graphics.
​https://bugs.webkit.org/show_bug.cgi?id=131276

Patch by Hyowon Kim <​hw1008.kim@samsung.com> on 2014-04-07
Reviewed by Darin Adler.

Source/WebCore:

Replace uses of OwnPtr and PassOwnPtr in code under WebCore/platform/graphics/
opengl, texmap, transforms and efl with std::unique_ptr.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::initializeNewContext):

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::create): Deleted.

  • platform/graphics/GraphicsContext3DPrivate.h:
  • platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::setContextLostCallback):
(WebCore::GraphicsContext3D::setErrorMessageCallback):

  • platform/graphics/efl/EvasGLContext.h:
  • platform/graphics/efl/EvasGLSurface.h:
  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::setContextLostCallback):
(WebCore::GraphicsContext3D::setErrorMessageCallback):

  • platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::create):
(WebCore::GraphicsContext3DPrivate::setContextLostCallback):

  • platform/graphics/efl/GraphicsContext3DPrivate.h:
  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::setContextLostCallback):
(WebCore::GraphicsContext3D::setErrorMessageCallback):

  • platform/graphics/opengl/Extensions3DOpenGLES.cpp:

(WebCore::Extensions3DOpenGLES::setEXTContextLostCallback):

  • platform/graphics/opengl/Extensions3DOpenGLES.h:
  • platform/graphics/opengl/GLPlatformContext.cpp:

(WebCore::createOffScreenContext):
(WebCore::GLPlatformContext::createContext):

  • platform/graphics/opengl/GLPlatformContext.h:
  • platform/graphics/opengl/GLPlatformSurface.cpp:

(WebCore::GLPlatformSurface::createOffScreenSurface):

  • platform/graphics/opengl/GLPlatformSurface.h:
  • platform/graphics/surfaces/efl/GraphicsSurfaceCommon.cpp:
  • platform/graphics/surfaces/egl/EGLSurface.cpp:

(WebCore::EGLOffScreenSurface::createOffScreenSurface):

  • platform/graphics/surfaces/egl/EGLSurface.h:
  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:
  • platform/graphics/texmap/TextureMapper.cpp:

(WebCore::TextureMapper::create):
(WebCore::TextureMapper::TextureMapper):

  • platform/graphics/texmap/TextureMapper.h:

(WebCore::TextureMapper::platformCreateAccelerated):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapper::platformCreateAccelerated):

  • platform/graphics/texmap/TextureMapperGL.h:

(WebCore::TextureMapperGL::create): Deleted.

  • platform/graphics/texmap/TextureMapperImageBuffer.h:

(WebCore::TextureMapperImageBuffer::TextureMapperImageBuffer):
(WebCore::TextureMapperImageBuffer::create): Deleted.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::purgeGLResources):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
  • platform/graphics/transforms/TransformState.cpp:

(WebCore::TransformState::operator=):
(WebCore::TransformState::applyTransform):

  • platform/graphics/transforms/TransformState.h:
  • platform/graphics/win/GraphicsContext3DWin.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::setContextLostCallback):
(WebCore::GraphicsContext3D::setErrorMessageCallback):

Source/WebKit/efl:

Replace uses of OwnPtr for TextureMapper in AcceleratedCompositingContextEfl with std::unique_ptr.

  • WebCoreSupport/AcceleratedCompositingContextEfl.h:

Source/WebKit/gtk:

Replace uses of OwnPtr for TextureMapper in AcceleratedCompositingContext with std::unique_ptr.

  • WebCoreSupport/AcceleratedCompositingContext.h:

Source/WebKit2:

Replace uses of OwnPtr for TextureMapper in LayerTreeHostGtk with std::unique_ptr.

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
3:11 PM Changeset in webkit [166888] by Joseph Pecoraro
  • 7 edits in trunk/Source/WebKit2

Make Mac only parts of TelephoneNumberOverlayController PLATFORM(MAC).

Unreviewed build fix for r166881.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::showTelephoneNumberMenu): Deleted.

  • WebProcess/WebPage/TelephoneNumberOverlayController.cpp:

(WebKit::TelephoneNumberOverlayController::drawRect):
(WebKit::TelephoneNumberOverlayController::mouseEvent):

  • WebProcess/WebPage/TelephoneNumberOverlayController.h:
  • WebProcess/WebPage/mac/TelephoneNumberOverlayControllerMac.mm:
2:55 PM Changeset in webkit [166887] by zandobersek@gmail.com
  • 4 edits in trunk/Source/WebKit2

Unreviewed. Fixing the GTK build.

  • WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp: Include the Document header from WebCore

to avoid operating on an incomplete type.

  • WebProcess/WebPage/TapHighlightController.cpp: Include the RenderElement instead of RenderObject

to make the RenderObject::style() inline accessible.

  • WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp: Include the Document header from WebCore
2:23 PM Changeset in webkit [166886] by timothy_horton@apple.com
  • 17 edits
    2 adds in trunk/Source

[iOS WebKit2] Make back-buffers purgeable when possible
​https://bugs.webkit.org/show_bug.cgi?id=131213
<rdar://problem/15373906>

Reviewed by Simon Fraser.

We should make back-buffers volatile when their owning
layer falls out of use (either stops being repainted or
is unparented), as they are inherently recreatable.

  • Shared/mac/RemoteLayerBackingStore.h:

(WebKit::RemoteLayerBackingStore::volatility):
(WebKit::RemoteLayerBackingStore::lastDisplayTime):
Add storage and a getter for the backing store's last paint time.
Add setter/getter for volatility of backing store.
Add RemoteLayerTreeContext param to constructor.

  • Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::RemoteLayerBackingStore):
(WebKit::RemoteLayerBackingStore::~RemoteLayerBackingStore):
Inform the RemoteLayerTreeContext when backing store
is created and destroyed. Since we only have a Context in
the Web process, this will only happen there.

(WebKit::RemoteLayerBackingStore::encode):
(WebKit::RemoteLayerBackingStore::decode):
Move some assertions out of #else blocks which are preceded by returns.

(WebKit::RemoteLayerBackingStore::display):
Update the last display time.
If the backing store was volatile, make it non-volatile.

(WebKit::RemoteLayerBackingStore::setVolatility):
Mark the relevant surfaces as volatile or not.
setVolatility:

  • fails and returns false if any surfaces weren't marked volatile because they were in use
  • marks the whole backing store for repaint if the front surface was purged
  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
Make it possible to remove the RemoteLayerBackingStore on layers
that went from drawing contents to not drawing contents.

  • UIProcess/ios/ViewGestureControllerIOS.mm:

(WebKit::ViewGestureController::beginSwipeGesture):
(WebKit::ViewGestureController::removeSwipeSnapshot):

  • UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::beginSwipeGesture):
(WebKit::ViewGestureController::removeSwipeSnapshot):

  • UIProcess/mac/ViewSnapshotStore.mm:

(WebKit::ViewSnapshotStore::recordSnapshot):
Adopt the new names from WebCore.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::recursiveBuildTransaction):
Clear the backing store if the layer doesn't want to draw contents anymore.

(WebKit::PlatformCALayerRemote::ensureBackingStore):

  • WebProcess/WebPage/mac/RemoteLayerTreeContext.h:

(WebKit::RemoteLayerTreeContext::backingStoreCollection):

  • WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::RemoteLayerTreeContext):
(WebKit::RemoteLayerTreeContext::backingStoreWasCreated):
(WebKit::RemoteLayerTreeContext::backingStoreWillBeDestroyed):
Keep a RemoteLayerBackingStoreCollection, which just keeps track
of all backing store (even unparented) created for layers in a
particular context. Forward backing store creation/deletion to it.
Remove a unused m_rootLayer member.

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
If any layers had backing store changes, start the timer
on the RemoteLayerBackingStoreCollection that will mark them
purgeable once they are no longer needed.

  • Shared/mac/RemoteLayerBackingStoreCollection.mm:
  • Shared/mac/RemoteLayerBackingStoreCollection.h:

Keep track of all backing store for our context.
When the timer fires, run through the backing store, finding
backing store that was last painted more than 1 second ago,
and mark them purgeable. If there was more recently-painted
backing store, let the timer fire again in another second;
otherwise, stop it.

  • WebCore.exp.in:
  • platform/graphics/cg/IOSurfacePool.cpp:

(WebCore::IOSurfacePool::takeSurface):
(WebCore::IOSurfacePool::markOlderSurfacesPurgeable):
(WebCore::IOSurfacePool::showPoolStatistics):

  • platform/graphics/cocoa/IOSurface.h:
  • platform/graphics/cocoa/IOSurface.mm:

(IOSurface::isVolatile):
(IOSurface::setIsVolatile):
Rename purgeability functions to match the system
and reduce confusion between purgeable memory
and volatile vs. non-volatile memory.

1:45 PM Changeset in webkit [166885] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Make it possible to disable some of the FTL's more interesting features
​https://bugs.webkit.org/show_bug.cgi?id=131312

Reviewed by Mark Hahnenberg.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::handlePutById):
(JSC::DFG::ByteCodeParser::parse):

  • runtime/Options.h:
1:34 PM Changeset in webkit [166884] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit2

Another build fix after r166879.

  • WebProcess/WebPage/mac/WebPageMac.mm:
1:26 PM Changeset in webkit [166883] by benjamin@webkit.org
  • 17 edits in trunk/Source/WebCore

Split CSS Selectors pseudo class and pseudo elements
​https://bugs.webkit.org/show_bug.cgi?id=131295

Reviewed by Andreas Kling.

Split pseudo class and pseudo element to make it clearer what pseudo types
are possible for a given match type.

Pseudo Element types are separated and Pseudo Class are left in place. The Pseudo Class
will have to be renamed too but that will be done separately to make this change smaller.

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::rewriteSpecifiersWithElementName):
(WebCore::CSSParser::rewriteSpecifiers):
Use a method isPseudoElementCueFunction() to abstract the #ifdef out of the parser.

  • css/CSSParserValues.cpp:

(WebCore::CSSParserSelector::parsePseudoElementSelector):

(WebCore::CSSParserSelector::parsePseudoElementCueFunctionSelector):
Rename to specify this is for the pseudo element cue function, not the pseudo element cue.

(WebCore::CSSParserSelector::parsePseudoClassAndCompatibilityElementSelector):
(WebCore::CSSParserSelector::parsePseudoCueFunctionSelector): Deleted.

  • css/CSSParserValues.h:

(WebCore::CSSParserSelector::isPseudoElementCueFunction):

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::specificityForOneSelector):
(WebCore::CSSSelector::pseudoId):
(WebCore::CSSSelector::parsePseudoElementType):
(WebCore::CSSSelector::operator==):

  • css/CSSSelector.h:

(WebCore::CSSSelector::pseudoType):
(WebCore::CSSSelector::setPseudoElementType):
(WebCore::CSSSelector::pseudoElementType):
(WebCore::CSSSelector::isUnknownPseudoElement):
(WebCore::CSSSelector::isCustomPseudoElement):
(WebCore::pseudoClassIsRelativeToSiblings):
(WebCore::CSSSelector::isSiblingSelector):

  • css/RuleFeature.cpp:

(WebCore::RuleFeatureSet::collectFeaturesFromSelector):

  • css/RuleSet.cpp:

(WebCore::determinePropertyWhitelistType):
(WebCore::RuleSet::findBestRuleSetAndAdd):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::matchRecursively):
(WebCore::SelectorChecker::checkOne):
(WebCore::SelectorChecker::checkScrollbarPseudoClass):
(WebCore::SelectorChecker::determineLinkMatchType):

  • css/SelectorPseudoClassAndCompatibilityElementMap.in:
  • css/SelectorPseudoElementTypeMap.in:
  • css/SelectorPseudoTypeMap.h:
  • css/makeSelectorPseudoClassAndCompatibilityElementMap.py:
  • css/makeSelectorPseudoElementsMap.py:

(enumerablePseudoType):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::getMatchedCSSRules):

  • rendering/style/RenderStyleConstants.h:

All the fullscreen pseudo types are pseudo class selectors. They should not have a pseudo ID.

1:20 PM Changeset in webkit [166882] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Tried to fix the Mac build.

  • WebProcess/Plugins/PDF/PDFPlugin.mm:
1:08 PM WebKitGTK/KeepingTheTreeGreen edited by Diego Pino Garcia
(diff)
1:05 PM Changeset in webkit [166881] by beidson@apple.com
  • 14 edits in trunk/Source/WebKit2

Handle clicks on DataDetectors UI for scanned phone numbers
<rdar://problem/16379588> and ​https://bugs.webkit.org/show_bug.cgi?id=131309

Reviewed by Tim Horton.

WebContextMenuItemDatas never need to know about a ContextMenu, so remove that concept.
Also add the concept of a selection handler for UIProcess-native menu items.

  • Shared/WebContextMenuItemData.cpp:

(WebKit::WebContextMenuItemData::WebContextMenuItemData):
(WebKit::WebContextMenuItemData::encode):
(WebKit::kitItems):
(WebKit::WebContextMenuItemData::decode):

  • Shared/WebContextMenuItemData.h:

(WebKit::WebContextMenuItemData::selectionHandler):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showContextMenu):
(WebKit::WebPageProxy::internalShowContextMenu): Make the decoder argument optional. Make consulting the client optional.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::showTelephoneNumberMenu):

  • UIProcess/mac/WebContextMenuProxyMac.mm:

(-[WKSelectionHandlerWrapper initWithSelectionHandler:std::]):
(-[WKSelectionHandlerWrapper executeSelectionHandler]):
(-[WKMenuTarget forwardContextMenuAction:]):
(WebKit::nsMenuItemVector):
(WebKit::WebContextMenuProxyMac::contextMenuItemSelected): If the represented object is a WKSelectionHandlerWrapper,

execute the selection handler. Do nothing else.

Instead of getting rects from ranges, creating highlights, and storing those highlights,
work in terms of a TelephoneNumberData object that wraps both a range and a highlight.
This makes it easier to track where the mouse is down and to know what phone number we should act on when clicked.

  • WebProcess/WebPage/TelephoneNumberOverlayController.cpp:

(WebKit::TelephoneNumberOverlayController::rectsForDrawing): Deleted.

  • WebProcess/WebPage/TelephoneNumberOverlayController.h:

(WebKit::TelephoneNumberData::create):
(WebKit::TelephoneNumberData::range):
(WebKit::TelephoneNumberData::highlight):
(WebKit::TelephoneNumberData::TelephoneNumberData):

  • WebProcess/WebPage/mac/TelephoneNumberOverlayControllerMac.mm:

(WebKit::TelephoneNumberOverlayController::drawRect):
(WebKit::TelephoneNumberOverlayController::handleTelephoneClick): Pass the phone number text and the point to WebPage.
(WebKit::TelephoneNumberOverlayController::mouseEvent):
(WebKit::TelephoneNumberOverlayController::clearMouseDownInformation):
(WebKit::TelephoneNumberOverlayController::clearHighlights):

  • WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::menuItemsWithUserData):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::handleTelephoneNumberClick): Message the phone number and coordinate to the UIProcess.

12:58 PM Changeset in webkit [166880] by Brian Burg
  • 12 edits
    1 add in trunk/Source/WebCore

Web Replay: detect possible replay divergence from unexpected DOM event dispatches
​https://bugs.webkit.org/show_bug.cgi?id=131193

Reviewed by Andreas Kling.

Add assertions to catch potential nondeterministic behavior.

The assertion added by this patch catches dispatched DOM events
that are triggered by nondeterministic event loop cycles. If we
did not capture an event loop input in the current event loop
cycle nor are we manually simulating an event loop input during
playback, then DOM events fired during the unordered cycle could
run JavaScript and diverge the execution.

During playback, we can assert that EventLoopInputDispatcher is dispatching
when a DOM event is be dispatched to a document that is being replayed.

During capturing, event loop inputs are captured rather than
dispatched, so we add some accounting to track what caused a DOM
event. To approximate the extent of computation triggered by an
event loop input, we add RAII helpers to call sites where event
loop inputs are captured.

The assertions are disabled by default until the most common
sources of nondeterminism are handled and playback errors are
gracefully surfaced to the user. <​https://webkit.org/b/131279>

No new tests. This patch adds extra assertions for debugging purposes.

  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorInstrumentation.cpp: Notify ReplayAgent of dispatched DOM event.

(WebCore::InspectorInstrumentation::willDispatchEventImpl):
(WebCore::InspectorInstrumentation::willDispatchEventOnWindowImpl):

  • inspector/InspectorReplayAgent.cpp: Forward dispatched DOM events to ReplayController.

(WebCore::InspectorReplayAgent::willDispatchEvent): Added.

  • inspector/InspectorReplayAgent.h:
  • replay/CapturingInputCursor.cpp:

(WebCore::CapturingInputCursor::CapturingInputCursor):
(WebCore::CapturingInputCursor::setWithinEventLoopInputExtent): Added.

  • replay/CapturingInputCursor.h:
  • replay/EventLoopInput.cpp: Added.

(WebCore::EventLoopInputExtent::EventLoopInputExtent): Added.
(WebCore::EventLoopInputExtent::~EventLoopInputExtent): Added.

  • replay/EventLoopInput.h:
  • replay/EventLoopInputDispatcher.h:

(WebCore::EventLoopInputDispatcher::isDispatching): Add a getter.

  • replay/ReplayController.cpp:

(WebCore::logDispatchedDOMEvent): Added. This is useful for understanding script-visible events.
(WebCore::ReplayController::willDispatchEvent): Added.

  • replay/ReplayController.h:
  • replay/UserInputBridge.cpp: Add extent helpers to call sites that capture inputs.

(WebCore::UserInputBridge::handleMousePressEvent):
(WebCore::UserInputBridge::handleMouseReleaseEvent):
(WebCore::UserInputBridge::handleMouseMoveEvent):
(WebCore::UserInputBridge::handleMouseMoveOnScrollbarEvent):
(WebCore::UserInputBridge::handleKeyEvent):
(WebCore::UserInputBridge::handleWheelEvent):
(WebCore::UserInputBridge::scrollRecursively):
(WebCore::UserInputBridge::logicalScrollRecursively):

12:44 PM Changeset in webkit [166879] by mitz@apple.com
  • 11 edits
    1 add in trunk/Source/WebKit2

Introduce API::InjectedBundle::PageUIClient
​https://bugs.webkit.org/show_bug.cgi?id=131310

Reviewed by Anders Carlsson.

  • WebKit2.xcodeproj/project.pbxproj: Added references to new files.
  • WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp: Added #include that

became necessary.

  • WebProcess/InjectedBundle/API/APIInjectedBundlePageUIClient.h: Added.

(API::InjectedBundle::PageUIClient::~PageUIClient):
(API::InjectedBundle::PageUIClient::willAddMessageToConsole):
(API::InjectedBundle::PageUIClient::willSetStatusbarText):
(API::InjectedBundle::PageUIClient::willRunJavaScriptAlert):
(API::InjectedBundle::PageUIClient::willRunJavaScriptConfirm):
(API::InjectedBundle::PageUIClient::willRunJavaScriptPrompt):
(API::InjectedBundle::PageUIClient::mouseDidMoveOverElement):
(API::InjectedBundle::PageUIClient::pageDidScroll):
(API::InjectedBundle::PageUIClient::shouldGenerateFileForUpload):
(API::InjectedBundle::PageUIClient::generateFileForUpload):
(API::InjectedBundle::PageUIClient::statusBarIsVisible):
(API::InjectedBundle::PageUIClient::menuBarIsVisible):
(API::InjectedBundle::PageUIClient::toolbarsAreVisible):
(API::InjectedBundle::PageUIClient::didReachApplicationCacheOriginQuota):
(API::InjectedBundle::PageUIClient::didExceedDatabaseQuota):
(API::InjectedBundle::PageUIClient::plugInStartLabelTitle):
(API::InjectedBundle::PageUIClient::plugInStartLabelSubtitle):
(API::InjectedBundle::PageUIClient::plugInExtraStyleSheet):
(API::InjectedBundle::PageUIClient::plugInExtraScript):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetUIClient): Changed to create an InjectedBundlePageUIClient and set it on
the WebPage.

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::InjectedBundlePageUIClient): Added constructor from
WKBundlePageUIClient.
(WebKit::toUIElementVisibility): Added helper to convert from C SPI enum to internal enum.
(WebKit::InjectedBundlePageUIClient::statusBarIsVisible): Changed to use the above.
(WebKit::InjectedBundlePageUIClient::menuBarIsVisible): Ditto.
(WebKit::InjectedBundlePageUIClient::toolbarsAreVisible): Ditto.

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h: Added inheritance from

API::InjectedBundle::PageUIClient, marked overrides as such.

  • WebProcess/Storage/StorageAreaMap.cpp: Added #include that became necessary.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::toolbarsVisible): Updated to use new internal enum.
(WebKit::WebChromeClient::statusbarVisible): Ditto.
(WebKit::WebChromeClient::menubarVisible): Ditto.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Initialized m_uiClient member.
(WebKit::WebPage::setInjectedBundleUIClient): Added. Updates m_uiClient.
(WebKit::WebPage::close): Updated for change in m_uiClient.
(WebKit::WebPage::pageDidScroll): Ditto.
(WebKit::WebPage::initializeInjectedBundleUIClient): Deleted.

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::injectedBundleUIClient): Updated return type.

  • WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm: Added #include that became

necessary.

12:37 PM WebKitGTK/KeepingTheTreeGreen edited by Adrian Perez de Castro
(diff)
12:37 PM Changeset in webkit [166878] by timothy@apple.com
  • 2 edits
    1 delete in trunk/Source/WebCore

Remove copy of combine-javascript-resources.pl that isn't used anymore
​https://bugs.webkit.org/show_bug.cgi?id=131307

Reviewed by Joseph Pecoraro.

  • WebCore.xcodeproj/project.pbxproj:
  • inspector/combine-javascript-resources.pl: Removed.
11:45 AM Changeset in webkit [166877] by fpizlo@apple.com
  • 214 edits
    53 moves
    2 adds in trunk

Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
​https://bugs.webkit.org/show_bug.cgi?id=130951

Reviewed by Geoffrey Garen.

Tools:

  • Scripts/run-javascriptcore-tests:

LayoutTests:

  • js/regress/ArrayBuffer-DataView-alloc-large-long-lived.html:
  • js/regress/ArrayBuffer-DataView-alloc-long-lived.html:
  • js/regress/ArrayBuffer-Int32Array-byteOffset.html:
  • js/regress/ArrayBuffer-Int8Array-alloc-huge-long-lived-expected.txt: Removed.
  • js/regress/ArrayBuffer-Int8Array-alloc-huge-long-lived.html: Removed.
  • js/regress/ArrayBuffer-Int8Array-alloc-large-long-lived-fragmented-expected.txt: Removed.
  • js/regress/ArrayBuffer-Int8Array-alloc-large-long-lived-fragmented.html: Removed.
  • js/regress/ArrayBuffer-Int8Array-alloc-large-long-lived.html:
  • js/regress/ArrayBuffer-Int8Array-alloc-long-lived-buffer.html:
  • js/regress/ArrayBuffer-Int8Array-alloc-long-lived.html:
  • js/regress/ArrayBuffer-Int8Array-alloc.html:
  • js/regress/DataView-custom-properties.html:
  • js/regress/Float32Array-matrix-mult.html:
  • js/regress/Float32Array-to-Float64Array-set.html:
  • js/regress/Float64Array-alloc-long-lived.html:
  • js/regress/Float64Array-to-Int16Array-set.html:
  • js/regress/HashMap-put-get-iterate-keys.html:
  • js/regress/HashMap-put-get-iterate.html:
  • js/regress/HashMap-string-put-get-iterate.html:
  • js/regress/Int16Array-alloc-long-lived.html:
  • js/regress/Int16Array-bubble-sort-with-byteLength.html:
  • js/regress/Int16Array-bubble-sort.html:
  • js/regress/Int16Array-load-int-mul.html:
  • js/regress/Int16Array-to-Int32Array-set.html:
  • js/regress/Int32Array-Int8Array-view-alloc.html:
  • js/regress/Int32Array-alloc-huge-expected.txt: Removed.
  • js/regress/Int32Array-alloc-huge-long-lived-expected.txt: Removed.
  • js/regress/Int32Array-alloc-huge-long-lived.html: Removed.
  • js/regress/Int32Array-alloc-huge.html: Removed.
  • js/regress/Int32Array-alloc-large-long-lived-expected.txt: Removed.
  • js/regress/Int32Array-alloc-large-long-lived.html: Removed.
  • js/regress/Int32Array-alloc-large.html:
  • js/regress/Int32Array-alloc-long-lived.html:
  • js/regress/Int32Array-alloc.html:
  • js/regress/Int8Array-alloc-long-lived.html:
  • js/regress/Int8Array-load-with-byteLength.html:
  • js/regress/Int8Array-load.html:
  • js/regress/adapt-to-double-divide.html:
  • js/regress/aliased-arguments-getbyval.html:
  • js/regress/allocate-big-object.html:
  • js/regress/arity-mismatch-inlining.html:
  • js/regress/array-access-polymorphic-structure.html:
  • js/regress/array-nonarray-polymorhpic-access.html:
  • js/regress/array-nonarray-polymorphic-access.html:
  • js/regress/array-prototype-every.html:
  • js/regress/array-prototype-filter-expected.txt: Removed.
  • js/regress/array-prototype-filter.html: Removed.
  • js/regress/array-prototype-forEach.html:
  • js/regress/array-prototype-map.html:
  • js/regress/array-prototype-some.html:
  • js/regress/array-with-double-add.html:
  • js/regress/array-with-double-increment.html:
  • js/regress/array-with-double-mul-add.html:
  • js/regress/array-with-double-sum.html:
  • js/regress/array-with-int32-add-sub.html:
  • js/regress/array-with-int32-or-double-sum.html:
  • js/regress/asmjs_bool_bug.html:
  • js/regress/assign-custom-setter-polymorphic.html:
  • js/regress/assign-custom-setter.html:
  • js/regress/basic-set.html:
  • js/regress/big-int-mul.html:
  • js/regress/boolean-test.html:
  • js/regress/branch-fold.html:
  • js/regress/by-val-generic.html:
  • js/regress/call-spread-apply.html:
  • js/regress/call-spread-call.html:
  • js/regress/call-spread-expected.txt: Removed.
  • js/regress/call-spread.html: Removed.
  • js/regress/captured-assignments.html:
  • js/regress/cast-int-to-double.html:
  • js/regress/cell-argument.html:
  • js/regress/cfg-simplify.html:
  • js/regress/chain-custom-getter-expected.txt: Removed.
  • js/regress/chain-custom-getter.html: Removed.
  • js/regress/chain-getter-access.html:
  • js/regress/cmpeq-obj-to-obj-other.html:
  • js/regress/constant-test.html:
  • js/regress/delay-tear-off-arguments-strictmode.html:
  • js/regress/destructuring-arguments-length-expected.txt: Removed.
  • js/regress/destructuring-arguments-length.html: Removed.
  • js/regress/destructuring-arguments.html:
  • js/regress/destructuring-swap.html:
  • js/regress/direct-arguments-getbyval.html:
  • js/regress/double-get-by-val-out-of-bounds.html:
  • js/regress/double-pollution-getbyval.html:
  • js/regress/double-pollution-putbyoffset.html:
  • js/regress/double-to-int32-typed-array-no-inline.html:
  • js/regress/double-to-int32-typed-array.html:
  • js/regress/double-to-uint32-typed-array-no-inline.html:
  • js/regress/double-to-uint32-typed-array.html:
  • js/regress/empty-string-plus-int.html:
  • js/regress/emscripten-cube2hash.html:
  • js/regress/emscripten-memops-expected.txt: Removed.
  • js/regress/emscripten-memops.html: Removed.
  • js/regress/external-arguments-getbyval.html:
  • js/regress/external-arguments-putbyval.html:
  • js/regress/fixed-typed-array-storage-var-index.html:
  • js/regress/fixed-typed-array-storage.html:
  • js/regress/fold-double-to-int.html:
  • js/regress/fold-strict-eq-expected.txt: Removed.
  • js/regress/fold-strict-eq.html: Removed.
  • js/regress/for-of-iterate-array-entries.html:
  • js/regress/for-of-iterate-array-keys.html:
  • js/regress/for-of-iterate-array-values.html:
  • js/regress/function-dot-apply.html:
  • js/regress/function-test.html:
  • js/regress/function-with-eval.html:
  • js/regress/get-by-id-chain-from-try-block.html:
  • js/regress/get-by-id-proto-or-self.html:
  • js/regress/get-by-id-self-or-proto.html:
  • js/regress/get-by-val-out-of-bounds.html:
  • js/regress/get_callee_monomorphic.html:
  • js/regress/get_callee_polymorphic.html:
  • js/regress/getter.html:
  • js/regress/global-var-const-infer-fire-from-opt.html:
  • js/regress/global-var-const-infer.html:
  • js/regress/imul-double-only.html:
  • js/regress/imul-int-only.html:
  • js/regress/imul-mixed.html:
  • js/regress/in-four-cases.html:
  • js/regress/in-one-case-false.html:
  • js/regress/in-one-case-true.html:
  • js/regress/in-two-cases.html:
  • js/regress/indexed-properties-in-objects.html:
  • js/regress/infer-closure-const-then-mov-no-inline.html:
  • js/regress/infer-closure-const-then-mov.html:
  • js/regress/infer-closure-const-then-put-to-scope-no-inline.html:
  • js/regress/infer-closure-const-then-put-to-scope.html:
  • js/regress/infer-closure-const-then-reenter-no-inline.html:
  • js/regress/infer-closure-const-then-reenter.html:
  • js/regress/infer-one-time-closure-ten-vars.html:
  • js/regress/infer-one-time-closure-two-vars.html:
  • js/regress/infer-one-time-closure.html:
  • js/regress/infer-one-time-deep-closure.html:
  • js/regress/inline-arguments-access.html:
  • js/regress/inline-arguments-aliased-access.html:
  • js/regress/inline-arguments-local-escape.html:
  • js/regress/inline-get-scoped-var.html:
  • js/regress/inlined-put-by-id-transition.html:
  • js/regress/int-or-other-abs-then-get-by-val.html:
  • js/regress/int-or-other-abs-zero-then-get-by-val.html:
  • js/regress/int-or-other-add-then-get-by-val.html:
  • js/regress/int-or-other-add.html:
  • js/regress/int-or-other-div-then-get-by-val.html:
  • js/regress/int-or-other-max-then-get-by-val.html:
  • js/regress/int-or-other-min-then-get-by-val.html:
  • js/regress/int-or-other-mod-then-get-by-val.html:
  • js/regress/int-or-other-mul-then-get-by-val.html:
  • js/regress/int-or-other-neg-then-get-by-val.html:
  • js/regress/int-or-other-neg-zero-then-get-by-val.html:
  • js/regress/int-or-other-sub-then-get-by-val.html:
  • js/regress/int-or-other-sub.html:
  • js/regress/int-overflow-local.html:
  • js/regress/int52-spill.html:
  • js/regress/integer-divide.html:
  • js/regress/integer-modulo.html:
  • js/regress/large-int-captured.html:
  • js/regress/large-int-neg.html:
  • js/regress/large-int.html:
  • js/regress/logical-not.html:
  • js/regress/lots-of-fields.html:
  • js/regress/make-indexed-storage.html:
  • js/regress/make-rope-cse.html:
  • js/regress/marsaglia-expected.txt: Removed.
  • js/regress/marsaglia-larger-ints.html:
  • js/regress/marsaglia-osr-entry.html:
  • js/regress/marsaglia.html: Removed.
  • js/regress/method-on-number.html:
  • js/regress/misc-strict-eq.html:
  • js/regress/negative-zero-divide.html:
  • js/regress/negative-zero-modulo.html:
  • js/regress/negative-zero-negate.html:
  • js/regress/nested-function-parsing-random-expected.txt: Removed.
  • js/regress/nested-function-parsing-random.html: Removed.
  • js/regress/nested-function-parsing.html:
  • js/regress/new-array-buffer-dead.html:
  • js/regress/new-array-buffer-push.html:
  • js/regress/new-array-dead.html:
  • js/regress/new-array-push.html:
  • js/regress/new-spread-expected.txt: Removed.
  • js/regress/new-spread.html: Removed.
  • js/regress/number-test.html:
  • js/regress/object-closure-call.html:
  • js/regress/object-test.html:
  • js/regress/poly-stricteq.html:
  • js/regress/polymorphic-get-by-id.html:
  • js/regress/polymorphic-put-by-id.html:
  • js/regress/polymorphic-structure.html:
  • js/regress/polyvariant-monomorphic-get-by-id.html:
  • js/regress/proto-custom-getter-expected.txt: Removed.
  • js/regress/proto-custom-getter.html: Removed.
  • js/regress/proto-getter-access.html:
  • js/regress/put-by-id.html:
  • js/regress/put-by-val-large-index-blank-indexing-type.html:
  • js/regress/put-by-val-machine-int.html:
  • js/regress/rare-osr-exit-on-local.html:
  • js/regress/register-pressure-from-osr.html:
  • js/regress/resources/regress-post.js: Removed.
  • js/regress/resources/regress-pre.js: Removed.
  • js/regress/script-tests/ArrayBuffer-Int8Array-alloc-huge-long-lived.js: Removed.
  • js/regress/script-tests/ArrayBuffer-Int8Array-alloc-large-long-lived-fragmented.js: Removed.
  • js/regress/script-tests/Int32Array-alloc-huge-long-lived.js: Removed.
  • js/regress/script-tests/Int32Array-alloc-huge.js: Removed.
  • js/regress/script-tests/Int32Array-alloc-large-long-lived.js: Removed.
  • js/regress/script-tests/array-prototype-filter.js: Removed.
  • js/regress/script-tests/call-spread.js: Removed.
  • js/regress/script-tests/chain-custom-getter.js: Removed.
  • js/regress/script-tests/destructuring-arguments-length.js: Removed.
  • js/regress/script-tests/emscripten-memops.js: Removed.
  • js/regress/script-tests/fold-strict-eq.js: Removed.
  • js/regress/script-tests/marsaglia.js: Removed.
  • js/regress/script-tests/nested-function-parsing-random.js: Removed.
  • js/regress/script-tests/new-spread.js: Removed.
  • js/regress/script-tests/proto-custom-getter.js: Removed.
  • js/regress/script-tests/simple-custom-getter.js: Removed.
  • js/regress/script-tests/variadic-closure-call.js: Removed.
  • js/regress/simple-activation-demo.html:
  • js/regress/simple-custom-getter-expected.txt: Removed.
  • js/regress/simple-custom-getter.html: Removed.
  • js/regress/simple-getter-access.html:
  • js/regress/slow-array-profile-convergence.html:
  • js/regress/slow-convergence.html:
  • js/regress/sparse-conditional.html:
  • js/regress/splice-to-remove.html:
  • js/regress/string-char-code-at.html:
  • js/regress/string-concat-object.html:
  • js/regress/string-concat-pair-object.html:
  • js/regress/string-concat-pair-simple.html:
  • js/regress/string-concat-simple.html:
  • js/regress/string-cons-repeat.html:
  • js/regress/string-cons-tower.html:
  • js/regress/string-equality.html:
  • js/regress/string-get-by-val-big-char.html:
  • js/regress/string-get-by-val-out-of-bounds-insane.html:
  • js/regress/string-get-by-val-out-of-bounds.html:
  • js/regress/string-get-by-val.html:
  • js/regress/string-hash.html:
  • js/regress/string-long-ident-equality.html:
  • js/regress/string-repeat-arith.html:
  • js/regress/string-sub.html:
  • js/regress/string-test.html:
  • js/regress/string-var-equality.html:
  • js/regress/structure-hoist-over-transitions.html:
  • js/regress/switch-char-constant.html:
  • js/regress/switch-char.html:
  • js/regress/switch-constant.html:
  • js/regress/switch-string-basic-big-var.html:
  • js/regress/switch-string-basic-big.html:
  • js/regress/switch-string-basic-var.html:
  • js/regress/switch-string-basic.html:
  • js/regress/switch-string-big-length-tower-var.html:
  • js/regress/switch-string-length-tower-var.html:
  • js/regress/switch-string-length-tower.html:
  • js/regress/switch-string-short.html:
  • js/regress/switch.html:
  • js/regress/tear-off-arguments-simple.html:
  • js/regress/tear-off-arguments.html:
  • js/regress/temporal-structure.html:
  • js/regress/to-int32-boolean.html:
  • js/regress/undefined-test.html:
  • js/regress/unprofiled-licm.html:
  • js/regress/variadic-closure-call-expected.txt: Removed.
  • js/regress/variadic-closure-call.html: Removed.
  • js/regress/weird-inlining-const-prop.html:
  • js/slow-stress: Added.
  • js/slow-stress/ArrayBuffer-Int8Array-alloc-huge-long-lived-expected.txt: Copied from LayoutTests/js/regress/ArrayBuffer-Int8Array-alloc-huge-long-lived-expected.txt.
  • js/slow-stress/ArrayBuffer-Int8Array-alloc-huge-long-lived.html: Copied from LayoutTests/js/regress/ArrayBuffer-Int8Array-alloc-huge-long-lived.html.
  • js/slow-stress/ArrayBuffer-Int8Array-alloc-large-long-lived-fragmented-expected.txt: Copied from LayoutTests/js/regress/ArrayBuffer-Int8Array-alloc-large-long-lived-fragmented-expected.txt.
  • js/slow-stress/ArrayBuffer-Int8Array-alloc-large-long-lived-fragmented.html: Copied from LayoutTests/js/regress/ArrayBuffer-Int8Array-alloc-large-long-lived-fragmented.html.
  • js/slow-stress/Int32Array-alloc-huge-expected.txt: Copied from LayoutTests/js/regress/Int32Array-alloc-huge-expected.txt.
  • js/slow-stress/Int32Array-alloc-huge-long-lived-expected.txt: Copied from LayoutTests/js/regress/Int32Array-alloc-huge-long-lived-expected.txt.
  • js/slow-stress/Int32Array-alloc-huge-long-lived.html: Copied from LayoutTests/js/regress/Int32Array-alloc-huge-long-lived.html.
  • js/slow-stress/Int32Array-alloc-huge.html: Copied from LayoutTests/js/regress/Int32Array-alloc-huge.html.
  • js/slow-stress/Int32Array-alloc-large-long-lived-expected.txt: Copied from LayoutTests/js/regress/Int32Array-alloc-large-long-lived-expected.txt.
  • js/slow-stress/Int32Array-alloc-large-long-lived.html: Copied from LayoutTests/js/regress/Int32Array-alloc-large-long-lived.html.
  • js/slow-stress/array-prototype-filter-expected.txt: Copied from LayoutTests/js/regress/array-prototype-filter-expected.txt.
  • js/slow-stress/array-prototype-filter.html: Copied from LayoutTests/js/regress/array-prototype-filter.html.
  • js/slow-stress/call-spread-expected.txt: Copied from LayoutTests/js/regress/call-spread-expected.txt.
  • js/slow-stress/call-spread.html: Copied from LayoutTests/js/regress/call-spread.html.
  • js/slow-stress/chain-custom-getter-expected.txt: Copied from LayoutTests/js/regress/chain-custom-getter-expected.txt.
  • js/slow-stress/chain-custom-getter.html: Copied from LayoutTests/js/regress/chain-custom-getter.html.
  • js/slow-stress/destructuring-arguments-length-expected.txt: Copied from LayoutTests/js/regress/destructuring-arguments-length-expected.txt.
  • js/slow-stress/destructuring-arguments-length.html: Copied from LayoutTests/js/regress/destructuring-arguments-length.html.
  • js/slow-stress/emscripten-memops-expected.txt: Copied from LayoutTests/js/regress/emscripten-memops-expected.txt.
  • js/slow-stress/emscripten-memops.html: Copied from LayoutTests/js/regress/emscripten-memops.html.
  • js/slow-stress/fold-strict-eq-expected.txt: Copied from LayoutTests/js/regress/fold-strict-eq-expected.txt.
  • js/slow-stress/fold-strict-eq.html: Copied from LayoutTests/js/regress/fold-strict-eq.html.
  • js/slow-stress/marsaglia-expected.txt: Copied from LayoutTests/js/regress/marsaglia-expected.txt.
  • js/slow-stress/marsaglia.html: Copied from LayoutTests/js/regress/marsaglia.html.
  • js/slow-stress/nested-function-parsing-random-expected.txt: Copied from LayoutTests/js/regress/nested-function-parsing-random-expected.txt.
  • js/slow-stress/nested-function-parsing-random.html: Copied from LayoutTests/js/regress/nested-function-parsing-random.html.
  • js/slow-stress/new-spread-expected.txt: Copied from LayoutTests/js/regress/new-spread-expected.txt.
  • js/slow-stress/new-spread.html: Copied from LayoutTests/js/regress/new-spread.html.
  • js/slow-stress/proto-custom-getter-expected.txt: Copied from LayoutTests/js/regress/proto-custom-getter-expected.txt.
  • js/slow-stress/proto-custom-getter.html: Copied from LayoutTests/js/regress/proto-custom-getter.html.
  • js/slow-stress/script-tests: Added.
  • js/slow-stress/script-tests/ArrayBuffer-Int8Array-alloc-huge-long-lived.js: Copied from LayoutTests/js/regress/script-tests/ArrayBuffer-Int8Array-alloc-huge-long-lived.js.
  • js/slow-stress/script-tests/ArrayBuffer-Int8Array-alloc-large-long-lived-fragmented.js: Copied from LayoutTests/js/regress/script-tests/ArrayBuffer-Int8Array-alloc-large-long-lived-fragmented.js.
  • js/slow-stress/script-tests/Int32Array-alloc-huge-long-lived.js: Copied from LayoutTests/js/regress/script-tests/Int32Array-alloc-huge-long-lived.js.
  • js/slow-stress/script-tests/Int32Array-alloc-huge.js: Copied from LayoutTests/js/regress/script-tests/Int32Array-alloc-huge.js.
  • js/slow-stress/script-tests/Int32Array-alloc-large-long-lived.js: Copied from LayoutTests/js/regress/script-tests/Int32Array-alloc-large-long-lived.js.
  • js/slow-stress/script-tests/array-prototype-filter.js: Copied from LayoutTests/js/regress/script-tests/array-prototype-filter.js.
  • js/slow-stress/script-tests/call-spread.js: Copied from LayoutTests/js/regress/script-tests/call-spread.js.
  • js/slow-stress/script-tests/chain-custom-getter.js: Copied from LayoutTests/js/regress/script-tests/chain-custom-getter.js.
  • js/slow-stress/script-tests/destructuring-arguments-length.js: Copied from LayoutTests/js/regress/script-tests/destructuring-arguments-length.js.
  • js/slow-stress/script-tests/emscripten-memops.js: Copied from LayoutTests/js/regress/script-tests/emscripten-memops.js.
  • js/slow-stress/script-tests/fold-strict-eq.js: Copied from LayoutTests/js/regress/script-tests/fold-strict-eq.js.
  • js/slow-stress/script-tests/marsaglia.js: Copied from LayoutTests/js/regress/script-tests/marsaglia.js.
  • js/slow-stress/script-tests/nested-function-parsing-random.js: Copied from LayoutTests/js/regress/script-tests/nested-function-parsing-random.js.
  • js/slow-stress/script-tests/new-spread.js: Copied from LayoutTests/js/regress/script-tests/new-spread.js.
  • js/slow-stress/script-tests/proto-custom-getter.js: Copied from LayoutTests/js/regress/script-tests/proto-custom-getter.js.
  • js/slow-stress/script-tests/simple-custom-getter.js: Copied from LayoutTests/js/regress/script-tests/simple-custom-getter.js.
  • js/slow-stress/script-tests/variadic-closure-call.js: Copied from LayoutTests/js/regress/script-tests/variadic-closure-call.js.
  • js/slow-stress/simple-custom-getter-expected.txt: Copied from LayoutTests/js/regress/simple-custom-getter-expected.txt.
  • js/slow-stress/simple-custom-getter.html: Copied from LayoutTests/js/regress/simple-custom-getter.html.
  • js/slow-stress/variadic-closure-call-expected.txt: Copied from LayoutTests/js/regress/variadic-closure-call-expected.txt.
  • js/slow-stress/variadic-closure-call.html: Copied from LayoutTests/js/regress/variadic-closure-call.html.
  • resources/regress-post.js: Copied from LayoutTests/js/regress/resources/regress-post.js.
  • resources/regress-pre.js: Copied from LayoutTests/js/regress/resources/regress-pre.js.
11:24 AM Changeset in webkit [166876] by mark.lam@apple.com
  • 9 edits
    3 adds in trunk

Date object needs to check for ES5 15.9.1.14 TimeClip limit.
<​https://webkit.org/b/131248>

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

The current Date object code does not adequately check for the ES5
15.9.1.14 TimeClip limit. As a result, some calculations can underflow
/ overflow and produce unexpected results.

For example, we were getting an assertion failure in
WTF::equivalentYearForDST() due int underflows in this function, which
in turn were due to an int overflow in WTF::msToYear().

This patch adds the needed checks, and adds some assertions to ensure
that the used values are sane.

The changes have no noticeable impact on benchmark results.

  • runtime/DateConstructor.cpp:

(JSC::callDate):

  • runtime/JSDateMath.cpp:

(JSC::localTimeOffset):
(JSC::gregorianDateTimeToMS):
(JSC::msToGregorianDateTime):
(JSC::parseDateFromNullTerminatedCharacters):
(JSC::parseDate):

  • runtime/JSDateMath.h:
  • parseDateFromNullTerminatedCharacters() does not need to be public. Made it a static function.
  • runtime/VM.cpp:

(JSC::VM::resetDateCache):

  • Changed cachedDateStringValue to use std::numeric_limits<double>::quiet_NaN() to be consistent with other Date code.

Source/WTF:

  • wtf/DateMath.cpp:
  • Moved the definition of maxECMAScriptTime to the .h file so that we can use it in other files as well.

(WTF::msToYear):

  • Removed a stale comment for parseDateFromNullTerminatedCharacters().
  • wtf/DateMath.h:

LayoutTests:

  • js/regress-131248-expected.txt: Added.
  • js/regress-131248.html: Added.
  • js/script-tests/regress-131248.js: Added.

(testDateFromSetDateAdjustement):
(testDateFromSetTimeWithMilliseconds):
(testDateFromString):

11:18 AM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com
(diff)
10:33 AM Changeset in webkit [166875] by svillar@igalia.com
  • 3 edits in trunk/LayoutTests

Unreviewed gardening for GTK.

Removed tests that have been actually passing in both release and
debug bots for some time.

  • platform/gtk-wk2/TestExpectations:
  • platform/gtk/TestExpectations:
10:15 AM Changeset in webkit [166874] by zoltan@webkit.org
  • 2 edits in trunk/Source/WebCore

[CSS Shapes] Clean up invalid FIXME
​https://bugs.webkit.org/show_bug.cgi?id=131304

Reviewed by Andreas Kling.

No new tests, no behavior change.

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):

9:30 AM Changeset in webkit [166873] by svillar@igalia.com
  • 2 edits in trunk/LayoutTests

Unreviewed update of GTK expectations.

Canvas composite tests with alpha are not working.

  • platform/gtk/TestExpectations:
5:34 AM Changeset in webkit [166872] by ryuan.choi@samsung.com
  • 20 edits
    3 deletes in trunk

[EFL] Turn on ENABLE_MEDIA_CONTROLS_SCRIPT
​https://bugs.webkit.org/show_bug.cgi?id=131257

Reviewed by Gyuyoung Kim.

.:

  • Source/cmake/OptionsEfl.cmake: Enable MEDIA_CONTROLS_SCRIPT

Source/WebCore:

no new tests. just rebased exisiting tests.

  • PlatformEfl.cmake: Added the media controls script associated files.
  • css/mediaControlsEfl.css: Removed.
  • css/mediaControlsEflFullscreen.css: Removed.
  • platform/efl/DefaultTheme/CMakeLists.txt:
  • platform/efl/DefaultTheme/default.edc:
  • platform/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/enterfullscreenbutton.png: Removed.
  • platform/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/exitfullscreenbutton.png: Removed.
  • platform/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreen_button.edc: Removed.
  • platform/efl/DefaultTheme/widget/mediacontrol/mutebutton/mute_button.edc: Removed.
  • platform/efl/DefaultTheme/widget/mediacontrol/mutebutton/mutebutton.png: Removed.
  • platform/efl/DefaultTheme/widget/mediacontrol/mutebutton/unmutebutton.png: Removed.
  • platform/efl/DefaultTheme/widget/mediacontrol/playpausebutton/pausebutton.png: Removed.
  • platform/efl/DefaultTheme/widget/mediacontrol/playpausebutton/playbutton.png: Removed.
  • platform/efl/DefaultTheme/widget/mediacontrol/playpausebutton/playpause_button.edc: Removed.
  • platform/efl/DefaultTheme/widget/mediacontrol/seekbackwardbutton/seekbackward_button.edc: Removed.
  • platform/efl/DefaultTheme/widget/mediacontrol/seekbackwardbutton/seekbackwardbutton.png: Removed.
  • platform/efl/DefaultTheme/widget/mediacontrol/seekforwardbutton/seekforward_button.edc: Removed.
  • platform/efl/DefaultTheme/widget/mediacontrol/seekforwardbutton/seekforwardbutton.png: Removed.
  • platform/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/closedcaption.png: Removed.
  • platform/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/closedcaption_disabled.png: Removed.
  • platform/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/toggle_captions_button.edc: Removed.
  • platform/efl/RenderThemeEfl.cpp:

(WebCore::toEdjeGroup):
(WebCore::RenderThemeEfl::RenderThemeEfl):
(WebCore::RenderThemeEfl::adjustSliderThumbSize):
(WebCore::RenderThemeEfl::mediaControlsStyleSheet): Modified to load bundle style sheet.
(WebCore::RenderThemeEfl::mediaControlsScript): Added to load bundle scripts.
(WebCore::RenderThemeEfl::emitMediaButtonSignal): Deleted.
(WebCore::RenderThemeEfl::extraMediaControlsStyleSheet): Deleted.
(WebCore::RenderThemeEfl::extraFullScreenStyleSheet): Deleted.
(WebCore::RenderThemeEfl::formatMediaControlsCurrentTime): Deleted.
(WebCore::RenderThemeEfl::hasOwnDisabledStateHandlingFor): Deleted.
(WebCore::RenderThemeEfl::paintMediaFullscreenButton): Deleted.
(WebCore::RenderThemeEfl::paintMediaMuteButton): Deleted.
(WebCore::RenderThemeEfl::paintMediaPlayButton): Deleted.
(WebCore::RenderThemeEfl::paintMediaSeekBackButton): Deleted.
(WebCore::RenderThemeEfl::paintMediaSeekForwardButton): Deleted.
(WebCore::RenderThemeEfl::paintMediaSliderTrack): Deleted.
(WebCore::RenderThemeEfl::paintMediaSliderThumb): Deleted.
(WebCore::RenderThemeEfl::paintMediaVolumeSliderContainer): Deleted.
(WebCore::RenderThemeEfl::paintMediaVolumeSliderTrack): Deleted.
(WebCore::RenderThemeEfl::paintMediaVolumeSliderThumb): Deleted.
(WebCore::RenderThemeEfl::paintMediaCurrentTime): Deleted.
(WebCore::RenderThemeEfl::supportsClosedCaptioning): Deleted.
(WebCore::RenderThemeEfl::paintMediaToggleClosedCaptionsButton): Deleted.

  • platform/efl/RenderThemeEfl.h:

LayoutTests:

Rebased tests.

  • platform/efl/TestExpectations:
  • platform/efl/media/audio-controls-rendering-expected.png:
  • platform/efl/media/audio-controls-rendering-expected.txt:
  • platform/efl/media/controls-after-reload-expected.png:
  • platform/efl/media/controls-after-reload-expected.txt:
  • platform/efl/media/controls-strict-expected.png:
  • platform/efl/media/controls-strict-expected.txt:
  • platform/efl/media/controls-styling-expected.png:
  • platform/efl/media/controls-styling-expected.txt:
  • platform/efl/media/controls-without-preload-expected.png:
  • platform/efl/media/controls-without-preload-expected.txt:
2:14 AM Changeset in webkit [166871] by svillar@igalia.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

Updated expectations for GTK. Added some more failing AX tests.

  • platform/gtk-wk2/TestExpectations:
1:52 AM Changeset in webkit [166870] by benjamin@webkit.org
  • 5 edits in trunk/Source/WebCore

CSS JIT: change the node flags directly instead of using function calls when possible
​https://bugs.webkit.org/show_bug.cgi?id=131292

Reviewed by Andreas Kling.

For historical reasons, changing the node flags was always done with function calls.
This patch changes those calls to modify the nodes directly.

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateDirectAdjacentTreeWalker):
(WebCore::SelectorCompiler::setNodeFlag):
(WebCore::SelectorCompiler::SelectorCodeGenerator::markParentElementIfResolvingStyle):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsFirstChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsLastChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsOnlyChild):
(WebCore::SelectorCompiler::markElementWithSetChildrenAffectedByLastChildRules): Deleted.
(WebCore::SelectorCompiler::markElementWithSetChildrenAffectedByFirstChildAndLastChildRules): Deleted.

  • dom/Element.cpp:

(WebCore::Element::setChildrenAffectedByFirstChildRules): Deleted.
(WebCore::Element::setChildrenAffectedByDirectAdjacentRules): Deleted.

  • dom/Element.h:
  • dom/Node.h:

(WebCore::Node::flagChildrenAffectedByFirstChildRulesFlag):
(WebCore::Node::flagChildrenAffectedByLastChildRulesFlag):
(WebCore::Node::flagChildrenAffectedByDirectAdjacentRulesFlag):

1:18 AM Changeset in webkit [166869] by k.czech@samsung.com
  • 2 edits in trunk/Source/WebCore

Remove unused header from PlatformSpeechSynthesizer.h
​https://bugs.webkit.org/show_bug.cgi?id=131103

Reviewed by Anders Carlsson.

Since WebSpeech has switched to use std::unique_ptr, we do not need to include PassOwnPtr.

No new tests. No behaviour change, just quick fix.

  • platform/PlatformSpeechSynthesizer.h:
12:55 AM Changeset in webkit [166868] by svillar@igalia.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

Updated expectations for GTK. Added some failing AX tests.

  • platform/gtk-wk2/TestExpectations:
Note: See TracTimeline for information about the timeline view.