Context Navigation

Add cmake build system support for YouCompleteMe. It should work regardless of
using make or ninja. In addition, autotools related code is removed since it's
not used anymore in WebKit.

Scripts/webkitdirs.pm:

(generateBuildSystemFromCMakeProject):

gtk/ycm_extra_conf.py:

(transform_relative_paths_to_absolute_paths):
(FlagsForFile):

8:51 PM Changeset in webkit [167481] by dbates@webkit.org

28 edits in trunk/Source

[iOS] Hook up screen.{availHeight, availWidth, height, width}
https://bugs.webkit.org/show_bug.cgi?id=131821
<rdar://problem/16413795>

Reviewed by Benjamin Poulain and Tim Horton.

Source/WebCore:
Implement support for screen.{availHeight, availWidth, height, width} in WebKit2 for iOS.

Additionally substitute "screenSize" for "viewporScreenSize" to make the code more understandable.

WebCore.exp.in: Export symbol for WebCore System Interface function

_wkGetViewportAvailableScreenSize.

dom/Document.cpp:

(WebCore::Document::processViewport): Modified to call Chrome::screenSize(); formerly it
called ChromeClient::viewportScreenSize().

page/Chrome.cpp:

(WebCore::Chrome::screenSize): Added; turns around and calls ChromeClient::screenSize().
(WebCore::Chrome::availableScreenSize): Added; turns around and calls ChromeClient::availableScreenSize().

page/Chrome.h:
page/ChromeClient.h:

(WebCore::ChromeClient::screenSize): Renamed; formerly named viewportScreenSize.
(WebCore::ChromeClient::availableScreenSize): Added; default implementation, which
returns the size of Chrome::windowRect().

page/ViewportConfiguration.cpp:

(WebCore::ViewportConfiguration::textDocumentParameters):

platform/HostWindow.h: Added declarations for availableScreenSize() and screenSize()

so that a caller (e.g. WebCore::screenRect()) can query for such screen information using
only the HostWindow interface. That is, a caller doesn't need to know about ChromeClient.

platform/ios/PlatformScreenIOS.mm:

(WebCore::screenRect): Modified to query HostWindow::screenSize() when computing the
screen rectangle in WebKit2 for iOS.
(WebCore::screenAvailableRect): Modified to query HostWindow::availableScreenSize()
when computing the available screen rectangle in WebKit2 for iOS.

platform/ios/WebCoreSystemInterfaceIOS.mm:
platform/mac/WebCoreSystemInterface.h:

Source/WebKit/ios:
Provide iOS-specific WebKit1 implementation for ChromeClient::availableScreenSize().

Additionally substitute "screenSize" for "viewporScreenSize" to make the code more understandable.

WebCoreSupport/WebChromeClientIOS.h:
WebCoreSupport/WebChromeClientIOS.mm:

(WebChromeClientIOS::screenSize): Renamed; formerly named viewportScreenSize.
(WebChromeClientIOS::availableScreenSize): Added; ASSERT_NOT_REACHED() as a widget
should consult it's associated WAKWindow for the available screen size.

Source/WebKit/mac:
Add declaration for WKGetViewportAvailableScreenSize() to return the available screen size.

Additionally substitute "ScreenSize" for "ViewportScreenSize" to make the code more understandable.

WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:
Implement WebKit2-specific support infrastructure.

Additionally substitute "screenSize" for "viewporScreenSize" to make the code more understandable.

Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode): Modified to encode the available screen size
creation parameter.
(WebKit::WebPageCreationParameters::decode): Modified to decode the available screen size
creation parameter.

Shared/WebPageCreationParameters.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters): Initialize the available screen size
parameter.

UIProcess/WebPageProxy.h:
UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::screenSize): Renamed; formerly named viewportScreenSize.
(WebKit::WebPageProxy::availableScreenSize): Added.

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::screenSize): Renamed; formerly named viewportScreenSize.
(WebKit::WebChromeClient::availableScreenSize): Added; turns around and calls WebPage::availableScreenSize().

WebProcess/WebCoreSupport/WebChromeClient.h:
WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Hook up WebKit System Interface function WKGetAvailableScreenSize.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Initialize available screen size instance variable.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::screenSize):
(WebKit::WebPage::availableScreenSize):

7:41 PM Changeset in webkit [167480] by Darin Adler

3 edits
4 adds in trunk

Source/WebCore: origin spoofing possible (HTTP Origin, postMessage event.origin) due to inappropriate URL escape sequence decoding
https://bugs.webkit.org/show_bug.cgi?id=131837
rdar://problem/15211936

Reviewed by Anders Carlsson and Dave Hyatt.

Tests: fast/dom/DOMURL/parsing.html

fast/dom/HTMLAnchorElement/anchor-element-href-parsing.html

platform/URL.cpp:

(WebCore::URL::host): Removed unnecessary call to decodeURLEscapeSequences, which caused
problems and was not needed.

LayoutTests: hostname extraction from a URL should not decode percent-escape sequences
https://bugs.webkit.org/show_bug.cgi?id=131837
rdar://problem/15211936

Reviewed by Anders Carlsson and Dave Hyatt.

fast/dom/DOMURL/parsing-expected.txt: Added.
fast/dom/DOMURL/parsing.html: Added.
fast/dom/HTMLAnchorElement/anchor-element-href-parsing-expected.txt: Added.
fast/dom/HTMLAnchorElement/anchor-element-href-parsing.html: Added.

7:35 PM Changeset in webkit [167479] by andersca@apple.com

2 edits in trunk/Tools

Fix build.

TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:

(-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
(-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):

7:11 PM Changeset in webkit [167478] by hyatt@apple.com

5 edits
2 adds in trunk

[New Multicolumn] Pagination mode messed up with non-inline axis and reversed direction.
https://bugs.webkit.org/show_bug.cgi?id=131811

Reviewed by Dean Jackson.

Source/WebCore:
Added fast/multicol/newmulticol/compare-with-old-impl/BottomToTop-tb.html

With block axis pagination mode, it is possible to set a column height that is not the same
as the available fill height for a block. The new multi-column code had the assumption that
the column height was the same as the amount of fill room you had available. This is not
the case.

To correct the issue, I added a member variable to RenderMultiColumnSet that stores the
available column height as a separate variable from the computed column height. This allows
the pagination API to specify a different column height that is not the same as the view's
content height.

Even though it isn't involved in the solution, I also patched pageOrViewLogicalHeight on
RenderView to work with the new column code as well.

rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::RenderMultiColumnSet):
(WebCore::RenderMultiColumnSet::setAndConstrainColumnHeight):
(WebCore::RenderMultiColumnSet::computeLogicalHeight):

rendering/RenderMultiColumnSet.h:
rendering/RenderView.cpp:

(WebCore::RenderView::pageOrViewLogicalHeight):

LayoutTests:

fast/multicol/newmulticol/compare-with-old-impl/BottomToTop-tb-expected.html: Added.
fast/multicol/newmulticol/compare-with-old-impl/BottomToTop-tb.html: Added.

7:04 PM Changeset in webkit [167477] by andersca@apple.com

2 edits in trunk/Source/WebCore

Build fix.

svg/animation/SMILTime.h:

6:42 PM Changeset in webkit [167476] by andersca@apple.com

5 edits in trunk

Remove unused API enums
https://bugs.webkit.org/show_bug.cgi?id=131836

Reviewed by Tim Horton.

Source/WebKit2:

UIProcess/API/Cocoa/WKNavigationDelegate.h:

(NS_ENUM):

UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction):
(WebKit::NavigationState::PolicyClient::decidePolicyForResponse):

Tools:

MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):

6:10 PM Changeset in webkit [167475] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/efl

[EFL][WK1] SSL Strict is set according to input parameter.
https://bugs.webkit.org/show_bug.cgi?id=131734.

Patch by Jeongeun Kim <je_julie.kim@samsung.com> on 2014-04-17
Reviewed by Gyuyoung Kim.

The param, 'enable', should be used for setting SSL-Strict.
If it is true, SSLStrict is set. Otherwise, SSLStrict is unset.

ewk/ewk_network.cpp:

(ewk_network_tls_certificate_check_set):

6:05 PM Changeset in webkit [167474] by Bem Jones-Bey

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r167384.

Sounds like this isn't the right fix, and causes generation to
run far too often.

Reverted changeset:

"Fix CodeGenerator.pm to only write files if the generated
content has changed"
https://bugs.webkit.org/show_bug.cgi?id=131756
http://trac.webkit.org/changeset/167384

5:51 PM Changeset in webkit [167473] by ryuan.choi@samsung.com

11 edits in trunk/Source/WebCore

Remove unnecessary MathExtras.h includes
https://bugs.webkit.org/show_bug.cgi?id=131789

Reviewed by Anders Carlsson.

platform/FileSystem.h:
platform/Scrollbar.h:
platform/animation/AnimationUtilities.h:
platform/audio/DenormalDisabler.h:
platform/graphics/Font.h:
platform/graphics/IntPoint.h: Included cmath instad of MathExtras.h.
platform/graphics/LayoutPoint.h:
platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
rendering/svg/SVGMarkerData.h:
svg/animation/SMILTime.h:

5:44 PM Changeset in webkit [167472] by Brent Fulgham

9 edits
2 adds in trunk

Make RenderLayerBacking get the timingFunction of the correct animation.
https://bugs.webkit.org/show_bug.cgi?id=100632

Source/WebCore:
Patch by Huang Dongsung <luxtella@company100.net> on 2014-04-16
Reviewed by Simon Fraser.

When an element has multiple animations that have different timingFunctions,
the progress of each animation should be calculated using its respective
timingFunction. But at this point, the timingFunction of the first animation is
only used in RenderLayerBacking::startAnimation(), regardless of how many
animations the element has.

getAnimationFromStyleByName() was introduced in r89462 so that the
timingFunction of the correct animation searched by its name would be
used. This patch moves the function to KeyframeValue::timingFunction()
so that RenderLayerBacking reuses this method.

Test: animations/keyframe-multiple-timing-functions-transform.html

page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::startAnimation):

rendering/style/KeyframeList.cpp:

(WebCore::KeyframeValue::timingFunction):
(WebCore):

rendering/style/KeyframeList.h:

(WebCore):
(KeyframeValue):

Source/WebKit2:
Reviewed by Simon Fraser.

Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(IPC::ArgumentCoder<GraphicsLayerAnimation>::decode): Update for new signatures for
FloatAnimationValue, TransformAnimationValue, etc.

LayoutTests:
Patch by Huang Dongsung <luxtella@company100.net> on 2014-04-16
Reviewed by Simon Fraser.

When an element on a compositing layer has multiple animations that have
different timingFunctions, the progress of each animation should be
calculated using its respective timingFunction in Accelerated
Compositing.

animations/keyframe-multiple-timing-functions-transform-expected.txt: Added.
animations/keyframe-multiple-timing-functions-transform.html: Added.

5:37 PM Changeset in webkit [167471] by gyuyoung.kim@samsung.com

2 edits in trunk/LayoutTests

Unreviewed, EFL gardening. Remove duplicated test case in EFL WK2 TestExpectations.

platform/efl-wk2/TestExpectations:

5:35 PM Changeset in webkit [167470] by gyuyoung.kim@samsung.com

2 edits in trunk/LayoutTests

Unreviewed, fix a test case path, which was moved to different folder.

platform/efl/TestExpectations:

5:01 PM Changeset in webkit [167469] by enrica@apple.com

10 edits in trunk/Source/WebKit2

[iOS WebKit2] support replacements for misspelled words.
https://bugs.webkit.org/show_bug.cgi?id=131827
<rdar://problem/16319657>

Reviewed by Benjamin Poulain.

This is the first part of the work to add support for replacements.
It handles _promptForReplace in canPerformAction to decide
whether to show the Replace button in the menu and add the
implementation of the replace action.

Shared/EditorState.cpp:

(WebKit::EditorState::encode):
(WebKit::EditorState::decode):

Shared/EditorState.h:

(WebKit::EditorState::EditorState):

UIProcess/WebPageProxy.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView selectedText]):
(-[WKContentView replaceText:withText:]):
(-[WKContentView _promptForReplace:]):
(-[WKContentView replace:]):
(-[WKContentView canPerformAction:withSender:]):
(-[WKContentView selectWordForReplacement]): This is called
by UIKit when the user taps on a mispelled word to select it.

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::replaceSelectedText):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::editorState):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::selectWithGesture): Removed m_shouldReturnWordForSelection.
We now return always the word corresponding to the caret selection or
the selected text up to a maximum of 200 characters.
(WebKit::WebPage::extendSelection):
(WebKit::WebPage::replaceSelectedText):

4:35 PM Changeset in webkit [167468] by Lucas Forschler

2 edits in tags/Safari-538.30/Source/WebCore

Merged r167460.

4:33 PM Changeset in webkit [167467] by fpizlo@apple.com

13 edits in trunk/Source/JavaScriptCore

InlineCallFrameSet should be refcounted
https://bugs.webkit.org/show_bug.cgi?id=131829

Reviewed by Geoffrey Garen.

And DFG::Plan should hold a ref to it. Previously it was owned by Graph until it
became owned by JITCode. Except that if we're "failing" to compile, JITCode may die.
Even as it dies, the GC may still want to scan the DFG::Plan, which leads to scanning
the DesiredWriteBarriers, which leads to scanning the InlineCallFrameSet.

So, just make the darn thing refcounted.

bytecode/InlineCallFrameSet.h:
dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

dfg/DFGCommonData.h:
dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::requiredRegisterCountForExit):

dfg/DFGGraph.h:
dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

dfg/DFGPlan.cpp:

(JSC::DFG::Plan::Plan):

dfg/DFGPlan.h:
dfg/DFGStackLayoutPhase.cpp:

(JSC::DFG::StackLayoutPhase::run):

ftl/FTLFail.cpp:

(JSC::FTL::fail):

ftl/FTLLink.cpp:

(JSC::FTL::link):

4:32 PM Changeset in webkit [167466] by akling@apple.com

14 edits in trunk/Source/WebCore

Rollout: Add a way to cache never-changing IDL attributes in the wrapper.
<https://webkit.org/b/131759>

This behavior may be observable from the web, so we can't do it this way.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

bindings/scripts/IDLAttributes.txt:
bindings/scripts/test/*:
dom/Element.idl:
dom/Node.idl:

4:29 PM Changeset in webkit [167465] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

[iOS] REGRESSION (r166975): WKPDFView is broken
https://bugs.webkit.org/show_bug.cgi?id=131828

Reviewed by Simon Fraser.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLayerTree:WebKit::]):
Bail from updating the scroll view parameters from the layer tree update
while it's being managed by a custom content view.
We'll get any changes again in the next commit after removing the custom
content view (and painting the new page) anyway, so this should be OK.

4:21 PM Changeset in webkit [167464] by akling@apple.com

2 edits in trunk/Source/WebCore

Cheesy Mountain Lion build fix.

platform/MemoryPressureHandler.h:

(WebCore::MemoryPressureHandler::ReliefLogger::logString):

4:06 PM Changeset in webkit [167463] by hyatt@apple.com

6 edits
2 adds in trunk

[New Multicolumn] Column rules don't respect the specified stacking order.
https://bugs.webkit.org/show_bug.cgi?id=131804

Reviewed by Beth Dakin.

Source/WebCore:
Added fast/multicol/newmulticol/compare_with_old_impl/column-rules-stacking.html

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::paintBoxDecorations):

rendering/RenderBlockFlow.h:

Override paintBoxDecorations for block flows so that we can iterate over our column sets
and paint their rules just after painting our background and border. We can't wait until
the child column sets paint their backgrounds, since that is specified as being above negative
z-index children. We have to pretend that the column sets don't exist as
far as column rule painting is concerned.

rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::paintObject): Deleted.

rendering/RenderMultiColumnSet.h:

Turn paintObject in RenderMultiColumnSet into an override that doesn't paint anything.

LayoutTests:

fast/multicol/newmulticol/compare-with-old-impl/column-rules-stacking-expected.html: Added.
fast/multicol/newmulticol/compare-with-old-impl/column-rules-stacking.html: Added.

4:04 PM Changeset in webkit [167462] by bshafiei@apple.com

7 edits
2 copies in tags/Safari-538.29.1/Source/WebKit2

Merged r167410.

4:01 PM Changeset in webkit [167461] by bshafiei@apple.com

2 edits in tags/Safari-538.29.1/Source/WebKit2

Merged r167386.

3:58 PM Changeset in webkit [167460] by Beth Dakin

2 edits in trunk/Source/WebCore

Hit-testing is incorrect for plugins inside iframes when there is a
topContentInset
https://bugs.webkit.org/show_bug.cgi?id=131826
-and corresponding-
<rdar://problem/16649996>

Reviewed by Tim Horton.

I missed one coordinate-conversion spot when getting hit-testing to work. Like
headerHeight() which also manipulates the location of the root layer,
topContentInset() has to be factored into all of these conversions.

page/FrameView.cpp:

(WebCore::FrameView::convertFromRenderer):

3:57 PM Changeset in webkit [167459] by bshafiei@apple.com

5 edits in tags/Safari-538.29.1/Source

Versioning.

3:50 PM Changeset in webkit [167458] by bshafiei@apple.com

1 copy in tags/Safari-538.29.1

New tag.

3:39 PM Changeset in webkit [167457] by psolanki@apple.com

2 edits in trunk/Source/WebKit2

_webProcessIdentifier should return 0 if the web process crashed
https://bugs.webkit.org/show_bug.cgi?id=131813
<rdar://problem/16650605>

Reviewed by Anders Carlsson.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _hasWebProcess]):

UIProcess/API/Cocoa/WKWebViewPrivate.h:

3:30 PM Changeset in webkit [167456] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

FTL::fail() should manage memory "correctly"
https://bugs.webkit.org/show_bug.cgi?id=131823
<rdar://problem/16384297>

Reviewed by Oliver Hunt.

ftl/FTLFail.cpp:

(JSC::FTL::fail):

3:25 PM Changeset in webkit [167455] by fpizlo@apple.com

2 edits
2 adds in trunk/Source/JavaScriptCore

Prediction propagator should correctly model Int52s flowing through arguments
https://bugs.webkit.org/show_bug.cgi?id=131822
<rdar://problem/16641408>

Reviewed by Oliver Hunt.

dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

tests/stress/int52-argument.js: Added.

(foo):

tests/stress/int52-variable.js: Added.

(foo):

2:32 PM Changeset in webkit [167454] by akling@apple.com

2 edits in trunk/Source/WebCore

Stub out MemoryPressureHandler::ReliefLogger on older OS X'es.

platform/cocoa/MemoryPressureHandlerCocoa.mm:

(WebCore::MemoryPressureHandler::ReliefLogger::platformLog):
(WebCore::MemoryPressureHandler::ReliefLogger::platformMemoryUsage):

2:10 PM Changeset in webkit [167453] by fpizlo@apple.com

4 edits in trunk/Source/WTF

Don't include CompilationThread.h from StringImpl.h
https://bugs.webkit.org/show_bug.cgi?id=131817

Reviewed by Simon Fraser.

wtf/CompilationThread.h:
wtf/StdLibExtras.h:
wtf/text/StringImpl.h:

2:05 PM Changeset in webkit [167452] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

REGRESSION: ASSERT(!typeInfo().hasImpureGetOwnPropertySlot()

typeInfo().newImpurePropertyFiresWatchpoints()) on jquery tests

https://bugs.webkit.org/show_bug.cgi?id=131798

Reviewed by Alexey Proskuryakov.

Some day, we will fix https://bugs.webkit.org/show_bug.cgi?id=131810 and some version
of this assertion can return. For now, it's not clear that the assertion is guarding
any truly undesirable behavior - so it should just go away and be replaced with a
FIXME.

bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeForStubInfo):

runtime/Structure.h:

(JSC::Structure::takesSlowPathInDFGForImpureProperty):

1:32 PM Changeset in webkit [167451] by krit@webkit.org

6 edits in trunk/Source/WebCore

Remove CANVAS_PATH where possible
https://bugs.webkit.org/show_bug.cgi?id=131788

Reviewed by Dean Jackson.

Since Firefox and Chrome ship the same interoperable subset of Path2D soon,
it is time to remove CANVAS_PATH where possible.

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::clip):
(WebCore::CanvasRenderingContext2D::isPointInStroke):

html/canvas/CanvasRenderingContext2D.h:
html/canvas/CanvasRenderingContext2D.idl:
html/canvas/DOMPath.h:
html/canvas/DOMPath.idl:

1:31 PM Changeset in webkit [167450] by b.long@cablelabs.com

3 edits in trunk/Source/WebCore

[GStreamer] Store TrackPrivateBaseGStreamer's label and language as AtomicStrings
https://bugs.webkit.org/show_bug.cgi?id=130404

Reviewed by Philippe Normand.

No new tests, this just makes things more efficient.

platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:

(WebCore::TrackPrivateBaseGStreamer::getLanguageCode):
(WebCore::TrackPrivateBaseGStreamer::getTag):

platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h:

1:25 PM Changeset in webkit [167449] by akling@apple.com

2 edits in trunk/Source/WebCore

Fix Cocoa build.

platform/cocoa/MemoryPressureHandlerCocoa.mm:

(WebCore::MemoryPressureHandler::ReliefLogger::platformMemoryUsage):

1:24 PM Changeset in webkit [167448] by cabanier@adobe.com

54 edits in trunk

[CSS Blending] Remove the -webkit- prefix for mix-blend-mode and isolation CSS properties
https://bugs.webkit.org/show_bug.cgi?id=131355

Reviewed by Dean Jackson.

Source/WebCore:
Removed webkit prefix from mix-blend-mode and isolation. These properties
never shipped and their spec is now in CR.

Covered by existing tests.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):

css/CSSPropertyNames.in:
css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):

LayoutTests:
Removed prefix from mix-blend-mode and isolation in layout tests.

css3/compositing/blend-mode-accelerated-with-multiple-stacking-contexts.html:
css3/compositing/blend-mode-ancestor-clipping-layer.html:
css3/compositing/blend-mode-background.html:
css3/compositing/blend-mode-blended-element-overlapping-composited-sibling-should-have-compositing-layer.html:
css3/compositing/blend-mode-isolated-group-1.html:
css3/compositing/blend-mode-isolated-group-2.html:
css3/compositing/blend-mode-isolated-group-3.html:
css3/compositing/blend-mode-layers.html:
css3/compositing/blend-mode-parent-of-composited-blended-has-layer.html:
css3/compositing/blend-mode-property-expected.txt:
css3/compositing/blend-mode-property-parsing-expected.txt:
css3/compositing/blend-mode-property-parsing-invalid-expected.txt:
css3/compositing/blend-mode-reflection.html:
css3/compositing/blend-mode-simple-composited.html:
css3/compositing/blend-mode-simple.html:
css3/compositing/blend-mode-transform-style-expected.txt:
css3/compositing/blend-mode-transform-style.html:
css3/compositing/blend-mode-with-accelerated-sibling.html:
css3/compositing/blend-mode-with-composited-descendant-should-have-layer.html:
css3/compositing/isolation-isolate-blended-child-expected.html:
css3/compositing/isolation-isolate-blended-child.html:
css3/compositing/isolation-parsing.html:
css3/compositing/script-tests/blend-mode-property-parsing-invalid.js:

(testInvalidFilterRule):

css3/compositing/script-tests/blend-mode-property-parsing.js:

(testBlendModeRule):

css3/compositing/script-tests/blend-mode-property.js:

(testblendmode):

css3/compositing/svg-blend-color-dodge.html:
css3/compositing/svg-blend-color.html:
css3/compositing/svg-blend-hard-light.html:
css3/compositing/svg-blend-hue.html:
css3/compositing/svg-blend-layer-blend.html:
css3/compositing/svg-blend-layer-clip-path.html:
css3/compositing/svg-blend-layer-filter.html:
css3/compositing/svg-blend-layer-opacity.html:
css3/compositing/svg-blend-layer-shadow.html:
css3/compositing/svg-blend-luminosity.html:
css3/compositing/svg-blend-multiply-alpha.html:
css3/compositing/svg-blend-multiply.html:
css3/compositing/svg-blend-saturation.html:
css3/compositing/svg-blend-screen.html:
css3/compositing/svg-blend-soft-light.html:
css3/compositing/svg-isolation-default-expected.html:
css3/compositing/svg-isolation-default.html:
css3/compositing/svg-isolation-isolated-group-expected.html:
css3/compositing/svg-isolation-isolated-group.html:
fast/repaint/blend-mode-isolate-stacking-context.html:
inspector-protocol/layers/layers-blending-compositing-reasons.html:
transitions/blendmode-transitions-expected.txt:
transitions/blendmode-transitions.html:

12:39 PM Changeset in webkit [167447] by ddkilzer@apple.com

3 edits in trunk/Source/WebCore

Tidy up isIsolatedInline() and highestContainingIsolateWithinRoot()
<http://webkit.org/b/131117>

Reviewed by Daniel Bates.

Based on review feedback for r166650.

rendering/InlineIterator.h:

(WebCore::isIsolatedInline):

Switch argument to a reference since it is never called with a nullptr.

(WebCore::highestContainingIsolateWithinRoot):

Switch first argument to a reference since it's never a nullptr.
Use nullptr for pointer initialization.
Switch while() loop to for() loop. Pass reference to isIsolatedInline().

(WebCore::numberOfIsolateAncestors):

Switch while() loop to for() loop. Pass reference to isIsolatedInline().
rendering/RenderBlockLineLayout.cpp:

(WebCore::constructBidiRunsForSegment):

Rename startObj to startObject.
No longer need to pass the address of startObject here.

12:27 PM Changeset in webkit [167446] by hyatt@apple.com

1 edit in trunk/Source/WebCore/platform/ios/SelectionRect.cpp

Fix build bustage.

12:19 PM Changeset in webkit [167445] by akling@apple.com

4 edits in trunk/Source/WebCore

Log number of bytes reclaimed at each step of memory pressure relief.
<https://webkit.org/b/131751>

Reviewed by Antti Koivisto.

platform/MemoryPressureHandler.h:
platform/MemoryPressureHandler.cpp:

(WebCore::MemoryPressureHandler::ReliefLogger::platformLog):
(WebCore::MemoryPressureHandler::ReliefLogger::platformMemoryUsage):
(WebCore::MemoryPressureHandler::ReliefLogger::ReliefLogger):
(WebCore::MemoryPressureHandler::ReliefLogger::~ReliefLogger):

platform/cocoa/MemoryPressureHandlerCocoa.mm:

(WebCore::MemoryPressureHandlerCocoa::ReliefLogger::platformMemoryUsage):
(WebCore::MemoryPressureHandlerCocoa::ReliefLogger::platformLog):

Add a simple RAII helper to check memory usage before and after
a block of code, and then dump the delta to system log.

(WebCore::MemoryPressureHandler::releaseMemory):

platform/cocoa/MemoryPressureHandlerCocoa.mm:

(WebCore::MemoryPressureHandler::platformReleaseMemory):

Use ReliefLogger to annotate the various attempts to reduce
our memory footprint. This will help us understand the efficiency
of our current strategy.

11:48 AM Changeset in webkit [167444] by hyatt@apple.com

9 edits in trunk/Source/WebCore

[New Multicolumn] columnNumberForOffset is not patched for new multicolumn code yet.
https://bugs.webkit.org/show_bug.cgi?id=131740

Reviewed by Enrica Casucci.

I took the opportunity to clean this code up while adding support for the new columns.
columnNumberForOffset only applied for paginated RenderViews and was really about
pages and not columns. It also only returns an actual page number if the columns are
block progressed (e.g., right-to-left vertical Japanese books).

Therefore I renamed columnNumberForOffset to pageNumberForBlockProgressionOffset and
moved it to RenderView.

I also renamed the member variable of SelectionRect to be pageNumber instead of
columnNumber in order to make it more obvious that this isn't about columns per se
(since the fact that we implemented RenderView's pagination mode using columns is an
implementation detail).

dom/Range.cpp:

(WebCore::coalesceSelectionRects):
(WebCore::Range::collectSelectionRects):

platform/ios/SelectionRect.h:

(WebCore::SelectionRect::pageNumber):
(WebCore::SelectionRect::columnNumber): Deleted.

rendering/RenderImage.cpp:

(WebCore::RenderImage::collectSelectionRects):

rendering/RenderObject.cpp:

(WebCore::RenderObject::collectSelectionRects):
(WebCore::RenderObject::columnNumberForOffset): Deleted.

rendering/RenderObject.h:
rendering/RenderText.cpp:

(WebCore::RenderText::collectSelectionRects):

rendering/RenderView.cpp:

(WebCore::RenderView::pageNumberForBlockProgressionOffset):

rendering/RenderView.h:

11:26 AM Changeset in webkit [167443] by Brent Fulgham

2 edits in trunk/Source/WebKit

[Win] Unreviewed 64-bit build fix.

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Do not

export 32-bit symbol in 64-bit build.

11:14 AM Changeset in webkit [167442] by Brent Fulgham

5 edits in trunk

[Win] A few final cleanups to the DataObject classes.
https://bugs.webkit.org/show_bug.cgi?id=131784

Reviewed by Anders Carlsson.

Source/WebCore:

platform/win/WCDataObject.cpp:

(WebCore::WCDataObject::clearData): Use 'last()' method.

Tools:

DumpRenderTree/win/DRTDataObject.cpp:

(DRTDataObject::clearData): Use 'last()' method.

DumpRenderTree/win/UIDelegate.cpp:

(DRTUndoStack::pop): Use 'takeLast()' method.

10:59 AM Changeset in webkit [167441] by jer.noble@apple.com

7 edits in trunk

Fullscreen media controls are unusable in pagination mode
https://bugs.webkit.org/show_bug.cgi?id=131705

Reviewed by Darin Adler.

Source/WebCore:
When pagination mode is enabled, the full screen media will (depending on the width of the
pagination columns) overflow its column, and hit testing will be clipped to the column. In extreme
cases, where the column width < 0.5 * media element width, the media controls will be entirely
unclickable.

Rather than making the RenderFullScreen a child of the full screen element's parent's renderer,
make it a child of the RenderView, putting it outside of the columns entirely. Always create and
insert the fullscreenRenderer's placeholder, using it as the remembered insertion point for the
fullscreen element's renderer when we exit full screen.

Drive-by fix: don't wrap the full screen element's renderer in webkitWillEnterFullScreenForElement();
it will just be re-wrapped in createRendererIfNeeded().

dom/Document.cpp:

(WebCore::Document::webkitWillEnterFullScreenForElement): Don't wrap the full screen element's renderer.
(WebCore::Document::setFullScreenRenderer): Call setPlaceholderStyle.

rendering/RenderFullScreen.cpp:

(WebCore::RenderFullScreenPlaceholder::willBeDestroyed): Call clearPlaceholder.
(WebCore::RenderFullScreen::wrapRenderer): Make fullscreenRenderer a child of the view().
(WebCore::RenderFullScreen::unwrapRenderer): Return the children to the parent of the placeholder().
(WebCore::RenderFullScreen::clearPlaceholder): Renamed from setPlaceholder().
(WebCore::RenderFullScreen::ensurePlaceholder): Added.
(WebCore::RenderFullScreen::setPlaceholderStyle): Renamed from createPlaceholder().
(WebCore::RenderFullScreen::setPlaceholder): Deleted.
(WebCore::RenderFullScreen::createPlaceholder): Deleted.

rendering/RenderFullScreen.h:

LayoutTests:

fullscreen/full-screen-no-style-sharing-expected.txt: Rebaselined.
fullscreen/video-cursor-auto-hide.html: Corrected test to move cursor

to the middle of the video element.

10:54 AM Changeset in webkit [167440] by jer.noble@apple.com

10 edits
2 adds in trunk

[MSE] Multiple initialization segments with same codecs in tracks fail validation.
https://bugs.webkit.org/show_bug.cgi?id=131768

Source/WebCore:
Additional initialization segments added to the same SourceBuffer with the same
codec values will fail validation. Update the validation check to add the correct
codec information for the initial segment, and check against the correct codecs during
the validation step.

Additionally, after validation, if successful update the Audio, Video, and TextTracks
for the SourceBuffer with the updated initialization segment information.

Reviewed by Eric Carlson.

Test: media/media-source/media-source-multiple-initialization-segments.html

Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::appendBufferTimerFired): m_source may have been cleared

as a result of the append, so check it before using.

(WebCore::SourceBuffer::sourceBufferPrivateDidEndStream): Call streamEndedWithError

instead of endOfStream as the latter is safe to call within an update.

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment): Ditto.

Update the track lists if validation succeeds.

(WebCore::SourceBuffer::validateInitializationSegment): Switch the audio and video

codec checks.

Add the ability for Audio, Video, and InbandTextTracks to replace their private tracks:

html/track/AudioTrack.cpp:

(WebCore::AudioTrack::AudioTrack): Call updateKindFromPrivate().
(WebCore::AudioTrack::setPrivate):
(WebCore::AudioTrack::updateKindFromPrivate): Split out from constructor.

html/track/AudioTrack.h:
html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::InbandTextTrack): Call updateKindFromPrivate().
(WebCore::InbandTextTrack::setPrivate):
(WebCore::InbandTextTrack::setMode): Split up into setModeInternal().
(WebCore::InbandTextTrack::setModeInternal): Broke out from setMode().
(WebCore::InbandTextTrack::updateKindFromPrivate): Split out from constructor.

html/track/InbandTextTrack.h:
html/track/TextTrack.h:

(WebCore::TextTrack::isInband): Added, returns false.

html/track/VideoTrack.cpp:

(WebCore::VideoTrack::VideoTrack): Call updateKindFromPrivate().
(WebCore::VideoTrack::setPrivate):
(WebCore::VideoTrack::updateKindFromPrivate): Split out from constructor.

html/track/VideoTrack.h:

LayoutTests:
Reviewed by Eric Carlson.

media/media-source/media-source-multiple-initialization-segments-expected.txt: Added.
media/media-source/media-source-multiple-initialization-segments.html: Added.

10:53 AM Changeset in webkit [167439] by hyatt@apple.com

3 edits
2 adds in trunk

[New Multicolumn] Column sets below spanners don't repaint properly.
https://bugs.webkit.org/show_bug.cgi?id=131778

Reviewed by Beth Dakin.

Source/WebCore:
Added fast/repaint/spanner-with-margins.html.

rendering/RenderBox.cpp:

(WebCore::RenderBox::computeRectForRepaint):
Turn off some code that was running for in-flow RenderFlowThreads that made no sense.
I'm not convinced the code is right for other types of RenderFlowThreads either,
but will leave that to the named flow thread experts. :)

LayoutTests:

fast/repaint/spanner-with-margin-expected.txt: Added.
fast/repaint/spanner-with-margin.html: Added.

10:52 AM Changeset in webkit [167438] by Martin Robinson

2 edits in trunk/LayoutTests

[GTK] [Gardening] Updates GTK test expectations

Patch by Eduardo Lima Mitev <elima@igalia.com> on 2014-04-17

platform/gtk/TestExpectations:
- Marked as flaky
  - fast/frames/frame-programmatic-noresize.html
  - fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize.html
  - fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false.html
- Removed because are passing now
  - fast/dom/gc-dom-tree-lifetime.html
  - http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html
  - editing/editability/ignored-content.html

10:41 AM Changeset in webkit [167437] by commit-queue@webkit.org

6 edits
5 adds in trunk

Catch up ruby and its tag omission rule changes in HTML5 CR Feb 2014
https://bugs.webkit.org/show_bug.cgi?id=131175

Patch by Koji Ishii <kojishi@gmail.com> on 2014-04-17
Reviewed by Darin Adler.

Source/WebCore:
Tests: html5lib/resources/ruby.dat

html5lib/resources/tests19.dat

This patch makes WebKit HTML parser to match to the tag omission rules of HTML5 CR Feb 2014:
http://www.w3.org/TR/2014/CR-html5-20140204/syntax.html#syntax-tag-omission
with the support for two new elements (rb, rtc) which were also defined in the spec:
http://www.w3.org/TR/2014/CR-html5-20140204/text-level-semantics.html#the-rb-element
http://www.w3.org/TR/2014/CR-html5-20140204/text-level-semantics.html#the-rtc-element
to better support use cases presented by W3C I18N WG:
http://www.w3.org/TR/ruby-use-cases/

html/HTMLTagNames.in: rb and rtc added as HTMLElement interfaces.
html/parser/HTMLConstructionSite.cpp:

(WebCore::hasImpliedEndTag): the spec says rb and rtc have implied end tags.

html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTagForInBody): rb and rtc added. rt excludes rtc from its implied end tags.

LayoutTests:
25 new test cases in 2 test files imported from pull requests to html5lib-tests,
with run- and expected-files generated.
All new tests pass with the changes included in this patch.

html5lib/generated/run-ruby-data-expected.txt: Added.
html5lib/generated/run-ruby-data.html: Added (generated by generate-test-wrappers.py)
html5lib/generated/run-ruby-write-expected.txt: Added.
html5lib/generated/run-ruby-write.html: Added (generated by generate-test-wrappers.py)
html5lib/resources/ruby.dat: Added from https://github.com/darobin/html5lib-tests/pull/1
html5lib/resources/tests19.dat: Updated from https://github.com/html5lib/html5lib-tests/pull/27

10:37 AM Changeset in webkit [167436] by Darin Adler

6 edits in trunk

Try to fix EFL and GTK builds.

Source/cmake/OptionsEfl.cmake: Add INDEXED_DATABASE_IN_WORKERS.
Source/cmake/OptionsGTK.cmake: Ditto.
Source/cmakeconfig.h.cmake: Ditto.

Source/WebCore/workers/WorkerGlobalScope.idl: Touch file to make it rebuild, assuming that module dependencies aren't working right with CMake. Tweaked formatting quite a bit while I was in here.

10:34 AM Changeset in webkit [167435] by ddkilzer@apple.com

2 edits in trunk/Source/JavaScriptCore

Blind attempt to fix Windows build after r166837
<http://webkit.org/b/131246>

Hoping to fix this build error:

warning MSB8027: Two or more files with the name of GCLogging.cpp will produce outputs to the same location. This can lead to an incorrect build result. The files involved are ..\heap\GCLogging.cpp, ..\heap\GCLogging.cpp.

JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Fix copy-paste

boo-boo by changing the GCLogging.cpp ClCompile entry to a
GCLogging.h ClInclude entry.

10:04 AM Changeset in webkit [167434] by ap@apple.com

2 edits in trunk/LayoutTests

Don't skip inspector/dom/content-flow-list.html and inspector/dom/content-flow-content-removal.html.

First, they no longer crash/assert. They fail most of the time, but that's tracked as bug 129817.

Second, skipping was ineffective anyway, because we had a preceding [ Pass Failure ]
entry for the same files.

TestExpectations:

10:01 AM Changeset in webkit [167433] by fpizlo@apple.com

4 edits
1 add in trunk/Source/JavaScriptCore

AI for GetLocal should match the DFG backend, and in this case, the best way to do that is to get rid of the "exit if empty prediction" thing since it's a vestige of a time long gone
https://bugs.webkit.org/show_bug.cgi?id=131764

Reviewed by Geoffrey Garen.

The attached test case can be made to not crash by deleting old code. It used to be
the case that the DFG needed empty prediction guards, for shady reasons. We fixed that
long ago. At this point, these guards just make life difficult. So get rid of them.

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

tests/stress/bug-131764.js: Added.

(test1):
(test2):

10:00 AM Changeset in webkit [167432] by Darin Adler

2 edits in trunk/Source/WTF

Use HashMap<unique_ptr> and Vector<unique_ptr> instead of deprecatedDeleteAllValues
https://bugs.webkit.org/show_bug.cgi?id=73757

Reviewed by Brent Fulgham.

wtf/Vector.h:

(WTF::deprecatedDeleteAllValues): Deleted.

9:58 AM Changeset in webkit [167431] by Darin Adler

2 edits in trunk/Source/WebKit2

Remove use of deprecatedDeleteAllValues in NPRemoteObjectMap::pluginDestroyed
https://bugs.webkit.org/show_bug.cgi?id=122496

Reviewed by Brent Fulgham.

Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::pluginDestroyed): Use new-style code and write the
deprecatedDeleteAllValues function out using a loop. Might be nice to return here
and use unique_ptr instead some day, but I tried that before and got it wrong, so
lets do that another time.

9:47 AM Changeset in webkit [167430] by Andres Gomez

3 edits in trunk/Tools

[Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
https://bugs.webkit.org/show_bug.cgi?id=131365

Reviewed by Brent Fulgham.

The cygwin installer is now downloading the wanted versions for
the local installation given to the setup wizard.

CygwinDownloader/cygwin-downloader.py:
CygwinDownloader/cygwin-downloader.zip:

9:45 AM Changeset in webkit [167429] by hyatt@apple.com

3 edits
2 adds in trunk

[New Multicolumn] REGRESSION: Column set styles don't update when zooming etc.
https://bugs.webkit.org/show_bug.cgi?id=131777

Reviewed by Enrica Casucci.

Source/WebCore:
Added fast/multicol/zoom-test.html

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::styleDidChange):
Put back in the code that propagates new styles to the flow thread and column sets
when styles change. This propagation was removed when the column span code landed.
This patch puts it back in but qualifies the types of objects that get styles
propagated to avoid accidentally propagating the wrong style to column spans.

LayoutTests:

fast/multicol/zoom-test-expected.html: Added.
fast/multicol/zoom-test.html: Added.

9:29 AM WebKitGTK/KeepingTheTreeGreen edited by elima@igalia.com

(diff)

8:45 AM WebKitGTK/KeepingTheTreeGreen edited by elima@igalia.com

(diff)

8:22 AM WebKitGTK/KeepingTheTreeGreen edited by elima@igalia.com

(diff)

8:19 AM WebKitGTK/KeepingTheTreeGreen edited by elima@igalia.com

(diff)

8:12 AM WebKitGTK/KeepingTheTreeGreen edited by elima@igalia.com

(diff)

8:05 AM 2014 Meeting Security Talk created by ddkilzer@apple.com

7:53 AM Changeset in webkit [167428] by commit-queue@webkit.org

9 edits
2 deletes in trunk/Source/WebKit

[EFL] Remove deprecated ewk_paint code.
https://bugs.webkit.org/show_bug.cgi?id=131266

Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2014-04-17
Reviewed by Gyuyoung Kim.

ewk_paint related code was deprecated since r166637.

Source/WebKit:

PlatformEfl.cmake: Remove ewk_paint_context.cpp

Source/WebKit/efl:

WebCoreSupport/AcceleratedCompositingContextEfl.cpp:
WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::invalidateRootView): Deleted.
(WebCore::ChromeClientEfl::invalidateContentsAndRootView): Deleted.
(WebCore::ChromeClientEfl::invalidateContentsForSlowScroll): Deleted.
(WebCore::ChromeClientEfl::scroll): Deleted.

WebCoreSupport/ChromeClientEfl.h:
WebCoreSupport/InspectorClientEfl.cpp:
ewk/ewk_paint_context.cpp: Removed.
ewk/ewk_paint_context_private.h: Removed.
ewk/ewk_view.cpp:

(_ewk_view_priv_del):
(_ewk_view_smart_calculate):
(ewk_view_smart_set):
(_ewk_view_repaints_resize): Deleted.
(_ewk_view_repaint_add): Deleted.
(_ewk_view_repaints_flush): Deleted.
(_ewk_view_smart_flush): Deleted.
(ewk_view_repaints_pop): Deleted.
(ewk_view_repaint_add): Deleted.
(ewk_view_paint): Deleted.
(ewk_view_paint_contents): Deleted.
(ewk_view_repaint): Deleted.
(ewk_view_scroll): Deleted.
(ewk_view_tiled_backing_store_invalidate): Deleted.

ewk/ewk_view_private.h:

7:52 AM WebKitGTK/KeepingTheTreeGreen edited by elima@igalia.com

(diff)

7:49 AM April 2014 Meeting edited by ddkilzer@apple.com

(diff)

7:48 AM Changeset in webkit [167427] by Darin Adler

16 edits in trunk

Add separate flag for IndexedDatabase in workers since the current implementation is not threadsafe
https://bugs.webkit.org/show_bug.cgi?id=131785
rdar://problem/16003108

Reviewed by Brady Eidson.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig: Added INDEXED_DATABASE_IN_WORKERS.

Source/WebCore:

Configurations/FeatureDefines.xcconfig: Added INDEXED_DATABASE_IN_WORKERS.

Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.cpp: Use the new conditional

instead of the old one.

Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.h: Ditto.
Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.idl: Ditto.

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig: Added INDEXED_DATABASE_IN_WORKERS.

Source/WebKit2:

Configurations/FeatureDefines.xcconfig: Added INDEXED_DATABASE_IN_WORKERS.

Source/WTF:

wtf/FeatureDefines.h: Added INDEXED_DATABASE_IN_WORKERS.

LayoutTests:

js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
js/dom/global-constructors-attributes-shared-worker-expected.txt:

Updated results since indexed database features are not on by default any more.

7:41 AM Changeset in webkit [167426] by commit-queue@webkit.org

2 edits in trunk/Tools

[GTK] Make run-webkit-tests always use WKTR
https://bugs.webkit.org/show_bug.cgi?id=131737

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2014-04-17
Reviewed by Darin Adler.

Now that the GTK+ port only has support for WebKit2, instruct
run-webkit-tests to always use WKTR. This avoids needing to pass
flag "-2" every time.

Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(_set_up_derived_options): Always set webkit_test_runner when
the platform is GTK+.

7:00 AM Changeset in webkit [167425] by mitz@apple.com

6 edits in trunk/Source

Source/WebCore: WebCore part of <rdar://problem/16601336> [Cocoa] _userInitiated is always NO in WKNavigationAction passed to -webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:
https://bugs.webkit.org/show_bug.cgi?id=131783

Reviewed by Tim Horton.

loader/NavigationAction.cpp:

(WebCore::NavigationAction::NavigationAction): Initialize m_processingUserGesture to
ScriptController::processingUserGesture() at the time the NavigationAction is constructed.

loader/NavigationAction.h:

Added boolean member variable m_processionUserGesture
(WebCore::NavigationAction::processingUserGesture): Added this getter.

Source/WebKit2: WebKit2 part of <rdar://problem/16601336> [Cocoa] _userInitiated is always NO in WKNavigationAction passed to -webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:
https://bugs.webkit.org/show_bug.cgi?id=131783

Reviewed by Tim Horton.

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createWindow): Set the isProcessingUserGesture field of
the NavigationActionData to the corresponding value in the NavigationAction.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Ditto.
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.

1:42 AM Changeset in webkit [167424] by commit-queue@webkit.org

13 edits
18 adds in trunk

[CSS Blending] Isolation descendant dependent flags are not updated correctly
https://bugs.webkit.org/show_bug.cgi?id=130892

Patch by Ion Rosca <Ion Rosca> on 2014-04-17
Reviewed by Dean Jackson.

Source/WebCore:
The isolation descendant dependent flag (m_hasUnisolatedBlendingDescendants)
will help us to determine if a layer should isolate blending descendants or not.
The m_hasUnisolatedBlendingDescendants flag should be set for layers that have blending descendant layers
not isolated by descendant stacking contexts.
An element isolatesBlending() if it has this flag set and creates stacking context.

Tests: css3/compositing/blend-mode-isolation-flags-append-non-stacking-context-blending.html

css3/compositing/blend-mode-isolation-flags-append-stacking-context-blending.html
css3/compositing/blend-mode-isolation-flags-remove-non-stacking-context-blending.html
css3/compositing/blend-mode-isolation-flags-remove-stacking-context-blending.html
css3/compositing/blend-mode-isolation-flags-turn-off-blending-no-isolation.html
css3/compositing/blend-mode-isolation-flags-turn-off-blending.html
css3/compositing/blend-mode-isolation-flags-turn-off-stacking-context.html
css3/compositing/blend-mode-isolation-flags-turn-on-blending.html
css3/compositing/blend-mode-isolation-flags-turn-on-stacking-context.html

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateBlendMode):
(WebCore::RenderLayer::updateAncestorChainHasBlendingDescendants):

When a layer has blending and it hasn't had it before, we set the isolation

flag for all its ancestors up to the first layer creating stacking context.
I removed the isComposited() check here. Isolation flags should be correct regardless
of compositing state. Moreover, if this method is called from styleChanged(),
the compositing state might not be accurate, it's going to be recalculated afterwards.
(WebCore::RenderLayer::dirtyAncestorChainHasBlendingDescendants):

When a layer doesn't have blending, but it used to have it before, we mark

the isolation flag as dirty for all its ancestors up to the first layer
creating stacking context. The isolation flags will be recalculated by
RenderLayer::updateDescendantDependentFlags.
(WebCore::RenderLayer::updateDescendantDependentFlags):

Evaluates if the layer has unisolated blending descendants by traversing

the layer subtree.
(WebCore::RenderLayer::addChild):

When adding a subtree that has blending or has some unisolated descendants,

we set the flag for all the ancestors, up to the stacking context layer.
(WebCore::RenderLayer::removeChild):

When removing a subtree that had blending or had some unisolated descendants,

we dirty the flag so that it could be reevaluated.
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::updateTransform):

rendering/RenderLayer.h:

Rename m_hasBlendedElementInChildStackingContext => m_hasUnisolatedBlendingDescendants

and m_hasBlendedElementInChildStackingContextStatusDirty => m_hasUnisolatedBlendingDescendantsStatusDirty,

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeCompositingRequirements):

Add an assert to make sure that if m_hasUnisolatedCompositedBlendingDescendants is true,

then m_hasUnisolatedBlendingDescendants is true as well.

LayoutTests:

css3/compositing/blend-mode-isolation-flags-append-non-stacking-context-blending.html: Added.
css3/compositing/blend-mode-isolation-flags-append-stacking-context-blending.html: Added.
css3/compositing/blend-mode-isolation-flags-remove-non-stacking-context-blending.html: Added.
css3/compositing/blend-mode-isolation-flags-remove-stacking-context-blending.html: Added.
css3/compositing/blend-mode-isolation-flags-turn-off-blending-no-isolation.html: Added.
css3/compositing/blend-mode-isolation-flags-turn-off-blending.html: Added.
css3/compositing/blend-mode-isolation-flags-turn-off-stacking-context.html: Added.
css3/compositing/blend-mode-isolation-flags-turn-on-blending.html: Added.
css3/compositing/blend-mode-isolation-flags-turn-on-stacking-context.html: Added.
platform/mac/css3/compositing/blend-mode-background-expected.txt:
platform/mac/css3/compositing/blend-mode-isolated-group-1-expected.txt:
platform/mac/css3/compositing/blend-mode-isolated-group-2-expected.txt:
platform/mac/css3/compositing/blend-mode-isolated-group-3-expected.txt:
platform/mac/css3/compositing/blend-mode-isolation-flags-append-non-stacking-context-blending-expected.txt: Added.
platform/mac/css3/compositing/blend-mode-isolation-flags-append-stacking-context-blending-expected.txt: Added.
platform/mac/css3/compositing/blend-mode-isolation-flags-remove-non-stacking-context-blending-expected.txt: Added.
platform/mac/css3/compositing/blend-mode-isolation-flags-remove-stacking-context-blending-expected.txt: Added.
platform/mac/css3/compositing/blend-mode-isolation-flags-turn-off-blending-expected.txt: Added.
platform/mac/css3/compositing/blend-mode-isolation-flags-turn-off-blending-no-isolation-expected.txt: Added.
platform/mac/css3/compositing/blend-mode-isolation-flags-turn-off-stacking-context-expected.txt: Added.
platform/mac/css3/compositing/blend-mode-isolation-flags-turn-on-blending-expected.txt: Added.
platform/mac/css3/compositing/blend-mode-isolation-flags-turn-on-stacking-context-expected.txt: Added.
platform/mac/css3/compositing/blend-mode-layers-expected.txt:
platform/mac/css3/compositing/blend-mode-reflection-expected.txt:
platform/mac/css3/compositing/blend-mode-simple-composited-expected.txt:
platform/mac/css3/compositing/blend-mode-simple-expected.txt:

12:55 AM WebKitGTK/KeepingTheTreeGreen edited by Adrian Perez de Castro

(diff)

12:33 AM Changeset in webkit [167423] by timothy_horton@apple.com

3 edits in trunk/Source/WebCore

Uninline blend(Color, Color) to get AnimationUtilities out of Color.h
https://bugs.webkit.org/show_bug.cgi?id=131781

Reviewed by Simon Fraser.

platform/graphics/Color.cpp:

(WebCore::blend):
Un-inline.

platform/graphics/Color.h:

No more AnimationUtilities.

12:23 AM Changeset in webkit [167422] by b.long@cablelabs.com

2 edits in trunk/Tools

[Gtk] Install ninja-build in Tools/gtk/install-dependencies
https://bugs.webkit.org/show_bug.cgi?id=131760

Reviewed by Philippe Normand.

gtk/install-dependencies: Install ninja-build when it's available.

12:12 AM Changeset in webkit [167421] by Lucas Forschler

5 edits in tags/Safari-538.30/Source

Versioning.

12:06 AM Changeset in webkit [167420] by Lucas Forschler

1 copy in tags/Safari-538.30

New Tag.

Apr 16, 2014:

10:58 PM Changeset in webkit [167419] by Lucas Forschler

1 delete in tags/Safari-538.30

Remove Tag.

10:31 PM Changeset in webkit [167418] by ap@apple.com

2 edits in trunk/Source/JavaScriptCore

Build fix after http://trac.webkit.org/changeset/167416 (Sink NaN sanitization)

dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::speculate):

10:02 PM Changeset in webkit [167417] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Extra error reporting for invalid value conversions
https://bugs.webkit.org/show_bug.cgi?id=131786

Rubber stamped by Ryosuke Niwa.

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::injectTypeConversionsForEdge):

9:57 PM Changeset in webkit [167416] by fpizlo@apple.com

11 edits
4 adds in trunk/Source/JavaScriptCore

Sink NaN sanitization to uses and remove it when it's unnecessary
https://bugs.webkit.org/show_bug.cgi?id=131419

Reviewed by Oliver Hunt.

This moves NaN purification to stores that could see an impure NaN.

5% speed-up on AsmBench, 50% speed-up on AsmBench/n-body. It is a regression on FloatMM
though, because of the other bug that causes that benchmark to box doubles in a loop.

bytecode/SpeculatedType.h:

(JSC::isInt32SpeculationForArithmetic):
(JSC::isMachineIntSpeculationForArithmetic):
(JSC::isDoubleSpeculation):
(JSC::isDoubleSpeculationForArithmetic):

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGAbstractValue.cpp:

(JSC::DFG::AbstractValue::fixTypeForRepresentation):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::injectTypeConversionsForEdge):

dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::mergeStateAtTail):

dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueRep):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):

dfg/DFGUseKind.h:

(JSC::DFG::typeFilterFor):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileValueRep):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):

runtime/PureNaN.h:
tests/stress/float32-array-nan-inlined.js: Added.

(foo):
(test):

tests/stress/float32-array-nan.js: Added.

(foo):
(test):

tests/stress/float64-array-nan-inlined.js: Added.

(foo):
(isBigEndian):
(test):

tests/stress/float64-array-nan.js: Added.

(foo):
(isBigEndian):
(test):

8:54 PM Changeset in webkit [167415] by benjamin@webkit.org

2 edits in trunk/Source/WebCore

Fix the build after r167412

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-04-16

platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):

8:48 PM Changeset in webkit [167414] by Lucas Forschler

5 edits in trunk/Source

Versioning.

8:44 PM Changeset in webkit [167413] by Lucas Forschler

1 copy in tags/Safari-538.30

New Tag.

8:28 PM Changeset in webkit [167412] by benjamin@webkit.org

2 edits in trunk/Source/WebKit2

[iOS][WK2] Fix the DidCommitLoad initial scrolling position
https://bugs.webkit.org/show_bug.cgi?id=131780

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-04-16
Reviewed by Jon Honeycutt.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLayerTree:]):
That code is older than _obscuredInsets and used the contentInsets as a workaround.

8:26 PM Changeset in webkit [167411] by benjamin@webkit.org

4 edits in trunk/Source

[iOS][WK2] Fix annoying scrolling bugs
https://bugs.webkit.org/show_bug.cgi?id=131722

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-04-16
Reviewed by Simon Fraser.

Source/WebCore:

platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):
Since ScrollingStateScrollingNode::setRequestedScrollPosition() was added, we see ScrollView::updateScrollbars()
keep changing the scroll position to incorrect values.

On iOS, the scrollbars are handled by the native UI, the code just compute incorrect scroll position. On WebKit1,
the code does not run because there is a platformWidget().

Just #ifdef the whole useless code.

Source/WebKit2:

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _scrollToContentOffset:WebCore::]):
We are scrolling at the wrong position when we have the "small obscured insets".

6:40 PM Changeset in webkit [167410] by barraclough@apple.com

7 edits
2 adds in trunk/Source/WebKit2

On iOS keep network process running using a process assertion rather than a boost
https://bugs.webkit.org/show_bug.cgi?id=131779

Reviewed by Benjamin Poulain.

UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::connectToService):

No need to leak a boost onto the NetworkProcess on iOS.

UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didFinishLaunching):

Take a ProcessAssertion on the NetworkProcess.

UIProcess/Shared/ChildProcessProxy.h:
- Added m_assertion.
UIProcess/WebProcessProxy.h:
- Removed m_assertion.
UIProcess/ios/ProcessAssertion.h: Added.
- Added - refactored from WebProcessProxy.h.
UIProcess/ios/ProcessAssertion.mm: Added.

(WebKit::ProcessAssertion::ProcessAssertion):
(WebKit::ProcessAssertion::setState):

Added - refactored from WebProcessProxyIOS.mm.

UIProcess/ios/WebProcessProxyIOS.mm:

(WebKit::WebProcessProxy::updateProcessState):

Code refactored out to ProcessAssertion.mm.

WebKit2.xcodeproj/project.pbxproj:
- Added files.

6:26 PM Changeset in webkit [167409] by benjamin@webkit.org

3 edits in trunk/Source/WebKit2

[iOS][WK2] Improve the approximation of the scroll position of the dynamic viewport size updates
https://bugs.webkit.org/show_bug.cgi?id=131720

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-04-16
Reviewed by Tim Horton.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _scrollToContentOffset:]):
The scrolling tree was forcing scroll at the wrong scale during the transition.

(-[WKWebView _setMinimumLayoutSizeOverride:]):
This was left out by accident. The WebProcess was getting the new layout size twice, making
WebPage::dynamicViewportSizeUpdate() very confused when the content size changes.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::dynamicViewportSizeUpdate):
Add scrolling adjustment for the dynamic relayout case:
-Sticky top and bottom like the UIProcess.
-Keep the same relative position of the unobscured rect's center.

Also fix a bug in the horizontal and vertical adjustments: the code was using the exposed rect
instead of the unobscured rect, which made the adjustments off by the size of the obscured insets.

The type is changed from double to float since ARMv7 has a grudge against double.

6:23 PM Changeset in webkit [167408] by benjamin@webkit.org

2 edits in trunk/Source/WebKit2

[iOS][WK2] Do not update the visible content rects when setting the same obscured insets multiple times
https://bugs.webkit.org/show_bug.cgi?id=131633

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-04-16
Reviewed by Darin Adler.

We should avoid computing the visible content rects when not needed.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _setObscuredInsets:]):

6:00 PM Changeset in webkit [167407] by Alexandru Chiculita

3 edits
2 adds in trunk

Improve performance of the RenderLayerCompositor::OverlapMap
https://bugs.webkit.org/show_bug.cgi?id=115063

Reviewed by Simon Fraser.

PerformanceTests:
Testing the performance of computing the overlap of 5000 layers.

Layout/layers_overlap_2d.html: Added. Using non-composited layers, to check

that the performance on the non-composited path is not changing with this patch.

Layout/layers_overlap_3d.html: Added. Records the time to do the layout of 5000

non-overlapping 3D layers.

Source/WebCore:
No new tests, no new functionality or behavior.

Do not use the OverlapMap in RenderLayerCompositor::computeCompositingRequirements if the layer already
has a 3D transform. This way we can avoid a potential expensive lookups when we know for sure the layer
is already supposed to be composited.

Also, added a bounding box of the overlap map, so that it can catch cases when the new layer is not overlapping
any of the previous layers. This is pretty common when having composited layers laid out in a vertical/horizontal list.

rendering/RenderLayerCompositor.cpp:

(OverlapMapContainer):
(WebCore::OverlapMapContainer::add):
(WebCore::OverlapMapContainer::overlapsLayers):
(WebCore::OverlapMapContainer::unite):
(WebCore):
(WebCore::RenderLayerCompositor::OverlapMap::add):
(WebCore::RenderLayerCompositor::OverlapMap::overlapsLayers):
(WebCore::RenderLayerCompositor::OverlapMap::pushCompositingContainer):
(WebCore::RenderLayerCompositor::OverlapMap::popCompositingContainer):
(RenderLayerCompositor::OverlapMap):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):

5:56 PM Changeset in webkit [167406] by Brian Burg

5 edits
2 adds in trunk

Web Replay: memoize fallback time values for document.lastModified
https://bugs.webkit.org/show_bug.cgi?id=131318

Reviewed by Joseph Pecoraro.

Source/WebCore:
If a document's Last-Modified header can't be found or used, then
document.lastModified is derived from the current system time or
from filesystem data, which is obviously nondeterministic.

It's better to handle this inside Document::lastModified rather than using
MemoizedDOMResult, because only the fallback case is nondeterministic.

Test: http/tests/inspector/replay/document-last-modified-fallback-value.html

The test is skipped for now, as it will be very flaky without the
functionality introduced by bugs 130728 and 129391.

dom/Document.cpp:

(WebCore::Document::lastModified): Save or reuse memoized fallback value.

replay/WebInputs.json: Add input DocumentLastModifiedDate.

LayoutTests:
Mark the new test as skipped until dependent functionality is landed.

http/tests/inspector/replay/document-last-modified-fallback-value.html: Added.

5:40 PM Changeset in webkit [167405] by Brent Fulgham

2 edits in trunk/Source/JavaScriptCore

[Win] Unreviewed Windows gardening. Restrict our new 'isinf' check
to 32-bit builds, and revise the comment to explain what we are
doing.

runtime/JSCJSValueInlines.h:

(JSC::JSValue::isMachineInt): Provide motivation for the new
'isinf' check for our 32-bit code path.

5:27 PM Changeset in webkit [167404] by hyatt@apple.com

6 edits in trunk/Source/WebCore

[New Multicolumn] Selection gets confused when the mouse is in the column gaps.
https://bugs.webkit.org/show_bug.cgi?id=131739

Reviewed by Enrica Casucci.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::selectionGaps):
Make sure not to paint selection gaps. This matches the old multi-column behavior. Even though
selection gaps *nearly* work with the new multi-column code, I am disabling them so that we
can turn them on without visual regressions.

(WebCore::isChildHitTestCandidate):
Don't allow in-flow RenderFlowThreads to be descended into from positionForPoint. We always want
to look only at the spanners and at the sets.

rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::nodeAtPoint):

rendering/RenderMultiColumnFlowThread.h:

Override nodeAtPoint to disallow the RenderMultiColumnFlowThread from being considered for hit
testing when no DOM node is found. It's better to just let RenderBlock's positionForPoint run
to drill back down into the appropriate column set.

rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::positionForPoint):
Implement positionForPoint for RenderMultiColumnSets. This is a straight-up port of the
old multi-column code's adjustPointToColumnContents function.

rendering/RenderMultiColumnSet.h:

Add override of positionForPoint.

4:59 PM Changeset in webkit [167403] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit/mac

Images dragged from WebKit1 on 2x displays are too big
https://bugs.webkit.org/show_bug.cgi?id=131775
<rdar://problem/15933525>

Reviewed by Simon Fraser.

WebCoreSupport/WebDragClient.mm:

(WebDragClient::startDrag):
Scale the drag image's logical size down by the device scale factor
in WebKit1 just like we do in WebKit2.

4:55 PM Changeset in webkit [167402] by dino@apple.com

3 edits
4 adds in trunk

MediaDocument on iOS should be full page
https://bugs.webkit.org/show_bug.cgi?id=131774

Reviewed by Jer Noble.

Source/WebCore:
A MediaDocument on iOS has two problems. It can't rely
on intrinsic size, since it doesn't load the content until
a user gesture. Secondly, on a small screen you want the
media to fill the page.

Add width/height 100% for iOS documents.

Test: platform/iphone-simulator/media/media-document-controls-size.html

html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):

LayoutTests:

platform/iphone-simulator/media/media-document-controls-size-expected.txt: Added.
platform/iphone-simulator/media/media-document-controls-size.html: Added.

4:53 PM Changeset in webkit [167401] by roger_fong@apple.com

7 edits in trunk

Add a way for layout tests to determine whether or not a plugin is snapshotted.
https://bugs.webkit.org/show_bug.cgi?id=131650.
<rdar://problem/16615528>

Reviewed by Dean Jackson.

testing/Internals.cpp:

(WebCore::Internals::isPluginSnapshotted):

testing/Internals.h:
testing/Internals.idl:

Adjust simple.html accordingly, more snapshotting test changes to come.

platform/mac-wk2/plugins/snapshotting/simple-expected.txt:
plugins/snapshotting/simple.html:

4:50 PM Changeset in webkit [167400] by Simon Fraser

2 edits in trunk/Source/WTF

Don't include CryptographicallyRandomNumber.h in StringImpl.h
https://bugs.webkit.org/show_bug.cgi?id=131772

Reviewed by Sam Weinig.

wtf/text/StringImpl.h:

4:46 PM Changeset in webkit [167399] by zandobersek@gmail.com

5 edits in trunk/Source/WebKit2

Make IPC::Arguments a variadic template
https://bugs.webkit.org/show_bug.cgi?id=131684

Reviewed by Darin Adler.

Make IPC::Arguments a variadic template that uses the template parameter pack to further
define the std::tuple ValueType and is used to define the std::tuple container of the
values passed into the container.

Platform/IPC/Arguments.h:

(IPC::Arguments::Arguments):
(IPC::Arguments::encode):
(IPC::Arguments::decode):
(IPC::Arguments0::encode): Deleted.
(IPC::Arguments0::decode): Deleted.
(IPC::Arguments1::Arguments1): Deleted.
(IPC::Arguments1::encode): Deleted.
(IPC::Arguments1::decode): Deleted.
(IPC::Arguments2::Arguments2): Deleted.
(IPC::Arguments2::encode): Deleted.
(IPC::Arguments2::decode): Deleted.
(IPC::Arguments3::Arguments3): Deleted.
(IPC::Arguments3::encode): Deleted.
(IPC::Arguments3::decode): Deleted.
(IPC::Arguments4::Arguments4): Deleted.
(IPC::Arguments4::encode): Deleted.
(IPC::Arguments4::decode): Deleted.
(IPC::Arguments5::Arguments5): Deleted.
(IPC::Arguments5::encode): Deleted.
(IPC::Arguments5::decode): Deleted.
(IPC::Arguments6::Arguments6): Deleted.
(IPC::Arguments6::encode): Deleted.
(IPC::Arguments6::decode): Deleted.
(IPC::Arguments7::Arguments7): Deleted.
(IPC::Arguments7::encode): Deleted.
(IPC::Arguments7::decode): Deleted.
(IPC::Arguments8::Arguments8): Deleted.
(IPC::Arguments8::encode): Deleted.
(IPC::Arguments8::decode): Deleted.
(IPC::Arguments10::Arguments10): Deleted.
(IPC::Arguments10::encode): Deleted.
(IPC::Arguments10::decode): Deleted.

Scripts/webkit2/LegacyMessages-expected.h:
Scripts/webkit2/Messages-expected.h:
Scripts/webkit2/messages.py: Clean up the code a bit.

(reply_parameter_type):
(arguments_type):
(reply_type):
(decode_type):
(arguments_type_old): Deleted.
(base_class): Deleted.
(delayed_reply_type): Deleted.

4:40 PM Changeset in webkit [167398] by timothy_horton@apple.com

8 edits
1 add
3 deletes in trunk/Source/WebKit2

Deduplicate LayerTreeContext
https://bugs.webkit.org/show_bug.cgi?id=131773

Reviewed by Simon Fraser.

There are three identical implementations, one for each platform, for no reason.

CMakeLists.txt:
PlatformEfl.cmake:
PlatformGTK.cmake:
Shared/LayerTreeContext.cpp: Renamed from Source/WebKit2/Shared/mac/LayerTreeContextMac.mm.

(WebKit::LayerTreeContext::LayerTreeContext):
(WebKit::LayerTreeContext::~LayerTreeContext):
(WebKit::LayerTreeContext::encode):
(WebKit::LayerTreeContext::decode):
(WebKit::LayerTreeContext::isEmpty):
(WebKit::operator==):

Shared/LayerTreeContext.h:

(WebKit::operator!=): Deleted.

Shared/efl/LayerTreeContextEfl.cpp: Removed.
Shared/gtk/LayerTreeContextGtk.cpp: Removed.
WebKit2.xcodeproj/project.pbxproj:
WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):

WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::initialize):

4:30 PM Changeset in webkit [167397] by fpizlo@apple.com

4 edits in trunk/Source/JavaScriptCore

Allocate the data section on the heap again for FTL on ARM64
https://bugs.webkit.org/show_bug.cgi?id=130156

Patch by Juergen Ributzka <juergen@apple.com> on 2014-04-16
Reviewed by Geoffrey Garen and Filip Pizlo.

ftl/FTLCompile.cpp:

(JSC::FTL::mmAllocateDataSection):

ftl/FTLDataSection.cpp:

(JSC::FTL::DataSection::DataSection):
(JSC::FTL::DataSection::~DataSection):

ftl/FTLDataSection.h:

4:07 PM Changeset in webkit [167396] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

Crash in CodeBlock::setOptimizationThresholdBasedOnCompilationResult() when the debugger activates.
<https://webkit.org/b/131747>

Reviewed by Filip Pizlo.

When the debugger is about to activate (e.g. enter stepping mode), it first
waits for all DFG compilations to complete. However, when the DFG completes,
if compilation is successful, it will install a new DFG codeBlock. The
CodeBlock installation process is required to register codeBlocks with the
debugger. Debugger::registerCodeBlock() will eventually call
CodeBlock::setSteppingMode() which may jettison the DFG codeBlock that we're
trying to install. Thereafter, chaos ensues.

This jettison'ing only happens because the debugger currently set its
m_steppingMode flag before waiting for compilation to complete. The fix is
simply to set that flag only after compilation is complete.

debugger/Debugger.cpp:

(JSC::Debugger::setSteppingMode):
(JSC::Debugger::registerCodeBlock):

3:54 PM Changeset in webkit [167395] by zoltan@webkit.org

5 edits in trunk/Source/WebCore

Vanish unnecessary includes from Shapes.{h|cpp}
https://bugs.webkit.org/show_bug.cgi?id=131762

Reviewed by Andreas Kling.

No new tests, no behavior change.

rendering/shapes/BoxShape.h:
rendering/shapes/Shape.cpp:
rendering/shapes/Shape.h:
rendering/shapes/ShapeOutsideInfo.h:

3:44 PM Changeset in webkit [167394] by fpizlo@apple.com

36 edits
1 add in trunk/Source/JavaScriptCore

Discern between NaNs that would be safe to tag and NaNs that need some purification before tagging
https://bugs.webkit.org/show_bug.cgi?id=131420

Reviewed by Oliver Hunt.

Rationalizes our handling of NaNs. We now have the notion of pureNaN(), or PNaN, which
replaces QNaN and represents a "safe" NaN for our tagging purposes. NaN purification now
goes through the purifyNaN() API.

SpeculatedType and its clients can now distinguish between a PureNaN and an ImpureNaN.

Prediction propagator is made slightly more cautious when dealing with NaNs. It doesn't
have to be too cautious since most prediction-based logic only cares about whether or not
a value could be an integer.

AI is made much more cautious when dealing with NaNs. We don't yet introduce ImpureNaN
anywhere in the compiler, but when we do, we ought to be able to trust AI to propagate it
soundly and precisely.

No performance change because this just unblocks
https://bugs.webkit.org/show_bug.cgi?id=131419.

API/JSValueRef.cpp:

(JSValueMakeNumber):
(JSValueToNumber):

JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/SpeculatedType.cpp:

(JSC::dumpSpeculation):
(JSC::speculationFromValue):
(JSC::typeOfDoubleSum):
(JSC::typeOfDoubleDifference):
(JSC::typeOfDoubleProduct):
(JSC::polluteDouble):
(JSC::typeOfDoubleQuotient):
(JSC::typeOfDoubleMinMax):
(JSC::typeOfDoubleNegation):
(JSC::typeOfDoubleAbs):
(JSC::typeOfDoubleFRound):
(JSC::typeOfDoubleBinaryOp):
(JSC::typeOfDoubleUnaryOp):

bytecode/SpeculatedType.h:
dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseCodeBlock):

dfg/DFGCriticalEdgeBreakingPhase.cpp:

(JSC::DFG::CriticalEdgeBreakingPhase::breakCriticalEdge):

dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::mergeStateAtTail):

dfg/DFGLoopPreHeaderCreationPhase.cpp:

(JSC::DFG::createPreHeader):

dfg/DFGNode.h:

(JSC::DFG::BranchTarget::BranchTarget):

dfg/DFGOSREntrypointCreationPhase.cpp:

(JSC::DFG::OSREntrypointCreationPhase::run):

dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::speculatedDoubleTypeForPrediction):
(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::emitAllocateJSArray):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::makePredictionForDoubleFormat):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::compilePutByVal):
(JSC::FTL::LowerDFGToLLVM::compileArrayPush):
(JSC::FTL::LowerDFGToLLVM::compileArrayPop):
(JSC::FTL::LowerDFGToLLVM::compileNewArrayWithSize):
(JSC::FTL::LowerDFGToLLVM::numberOrNotCellToInt32):
(JSC::FTL::LowerDFGToLLVM::allocateJSArray):

ftl/FTLValueFormat.cpp:

(JSC::FTL::reboxAccordingToFormat):

jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::purifyNaN):
(JSC::AssemblyHelpers::sanitizeDouble): Deleted.

jit/AssemblyHelpers.h:
jit/JITPropertyAccess.cpp:

(JSC::JIT::emitFloatTypedArrayGetByVal):

runtime/DateConstructor.cpp:

(JSC::constructDate):

runtime/DateInstanceCache.h:

(JSC::DateInstanceData::DateInstanceData):
(JSC::DateInstanceCache::reset):

runtime/ExceptionHelpers.cpp:

(JSC::TerminatedExecutionError::defaultValue):

runtime/JSArray.cpp:

(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::shiftCountWithAnyIndexingType):
(JSC::JSArray::sortVector):
(JSC::JSArray::compactForSorting):

runtime/JSArray.h:

(JSC::JSArray::create):
(JSC::JSArray::tryCreateUninitialized):

runtime/JSCJSValue.cpp:

(JSC::JSValue::toNumberSlowCase):

runtime/JSCJSValue.h:
runtime/JSCJSValueInlines.h:

(JSC::jsNaN):
(JSC::JSValue::JSValue):
(JSC::JSValue::getPrimitiveNumber):

runtime/JSGlobalObjectFunctions.cpp:

(JSC::parseInt):
(JSC::jsStrDecimalLiteral):
(JSC::toDouble):
(JSC::jsToNumber):
(JSC::parseFloat):

runtime/JSObject.cpp:

(JSC::JSObject::createInitialDouble):
(JSC::JSObject::convertUndecidedToDouble):
(JSC::JSObject::convertInt32ToDouble):
(JSC::JSObject::deletePropertyByIndex):
(JSC::JSObject::ensureLengthSlow):

runtime/MathObject.cpp:

(JSC::mathProtoFuncMax):
(JSC::mathProtoFuncMin):

runtime/PureNaN.h: Added.

(JSC::pureNaN):
(JSC::isImpureNaN):
(JSC::purifyNaN):

runtime/TypedArrayAdaptors.h:

(JSC::FloatTypedArrayAdaptor::toJSValue):

3:39 PM Changeset in webkit [167393] by timothy_horton@apple.com

8 edits in trunk/Source/WebKit2

Don't build LayerTreeHost on Mac (and clean it up)
https://bugs.webkit.org/show_bug.cgi?id=131769

Reviewed by Simon Fraser.

WebKit2.xcodeproj/project.pbxproj:

Don't include it in the project.

WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:

(WebKit::CoordinatedDrawingArea::updatePreferences):

WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::updatePreferences):

WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::setLayerHostingMode): Deleted.
(WebKit::LayerTreeHost::supportsAcceleratedCompositing): Deleted.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

WebProcess/WebPage/ios/WebPageIOS.mm:

Get rid of LayerTreeHost::supportsAcceleratedCompositing, which always returns true everywhere.
Remove some LayerTreeHost.h includes.
Remove LayerTreeHost::setLayerHostingMode, which is PLATFORM(COCOA) and not needed.

3:39 PM Changeset in webkit [167392] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

Enable system library calls in FTL for ARM64
https://bugs.webkit.org/show_bug.cgi?id=130154

Patch by Juergen Ributzka <juergen@apple.com> on 2014-04-16
Reviewed by Geoffrey Garen and Filip Pizlo.

ftl/FTLIntrinsicRepository.h:
ftl/FTLOutput.h:

(JSC::FTL::Output::doubleRem):
(JSC::FTL::Output::doubleSin):
(JSC::FTL::Output::doubleCos):

3:21 PM Changeset in webkit [167391] by akling@apple.com

3 edits in trunk/Source/WebCore

Revert direct caching of tagName and nodeName from r167383.

Ryosuke tells me this is not entirely safe, will need to rethink.

dom/Element.idl:
dom/Node.idl:

3:04 PM Changeset in webkit [167390] by Simon Fraser

2 edits in trunk/Source/WebKit2

Failing to decode a layer tree commit message resulted in silent and mysterious failure
https://bugs.webkit.org/show_bug.cgi?id=131766
<rdar://problem/16520894>

Reviewed by Sam Weinig.

If the message decode failed, we should have already marked the message as invalid.
Failing to do so indicates in a decode code coding error.

Platform/IPC/HandleMessage.h:

(IPC::handleMessage):
(IPC::handleMessageVariadic):
(IPC::handleMessageDelayed):

2:58 PM Changeset in webkit [167389] by commit-queue@webkit.org

2 edits in trunk/Tools

[Win] run-javascriptcore-tests fails to run.
https://bugs.webkit.org/show_bug.cgi?id=131761

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-04-16
Reviewed by Brent Fulgham.

Scripts/build-jsc: For now, don't try to build bmalloc on Windows.

2:53 PM Changeset in webkit [167388] by timothy_horton@apple.com

11 edits in trunk/Source/WebKit2

Minor include sanity in WebPage.h
https://bugs.webkit.org/show_bug.cgi?id=131752

Reviewed by Simon Fraser.

WebProcess/WebPage/WebPage.h:

Remove a bunch of unnecessary includes.
Un-indent some stuff.

WebProcess/WebCoreSupport/WebEditorClient.cpp:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
WebProcess/WebPage/FindController.cpp:
WebProcess/WebPage/WebPage.cpp:
WebProcess/WebPage/mac/WebPageMac.mm:

Add back more specific includes, into implementation files.

WebProcess/WebPage/WebUndoStep.cpp:

(WebKit::WebUndoStep::~WebUndoStep):

WebProcess/WebPage/WebUndoStep.h:

Add an out-of-line destructor.

2:50 PM Changeset in webkit [167387] by pmolnar.u-szeged@partner.samsung.com

3 edits in trunk/Source/WebCore

Improve security mitigation added in webkit r94001.
We missed the case where attachLine was called when we already had an inline box wrapper.
https://bugs.webkit.org/show_bug.cgi?id=127285

Reviewed by Brent Fulgham.

Merged from Blink: https://src.chromium.org/viewvc/blink?revision=150697&view=revision

rendering/RenderBox.cpp:

(WebCore::RenderBox::positionLineBox):

rendering/RenderBox.h:

(WebCore::RenderBox::setInlineBoxWrapper):

2:43 PM April 2014 Meeting edited by ddkilzer@webkit.org

(diff)

2:34 PM Changeset in webkit [167386] by barraclough@apple.com

2 edits in trunk/Source/WebKit2

REGRESSION: PCE.js is 20x slower in WebKit2 because timers are throttled
https://bugs.webkit.org/show_bug.cgi?id=131189

Unreviewed rollout of r166754

This change is no longer necessary.

UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::connectToService):

2:24 PM Changeset in webkit [167385] by b.long@cablelabs.com

2 edits in trunk

[GTK][CMAKE] build-webkit doesn't detect when the build fails
https://bugs.webkit.org/show_bug.cgi?id=130148

Reviewed by Martin Robinson.

Source/cmake/OptionsGTK.cmake: Replace CMake's automatic make -i with make -k, which still continues after errors, but correctly reports tha the build failed.

2:14 PM Changeset in webkit [167384] by Bem Jones-Bey

2 edits in trunk/Source/WebCore

Fix CodeGenerator.pm to only write files if the generated content has changed
https://bugs.webkit.org/show_bug.cgi?id=131756

Reviewed by Sam Weinig.

To improve build speed, don't touch generated files unless the newly
generated content is actually different.

bindings/scripts/CodeGenerator.pm:

(UpdateFile):

2:07 PM Changeset in webkit [167383] by akling@apple.com

14 edits in trunk/Source/WebCore

Add a way to cache never-changing IDL attributes in the wrapper.
<https://webkit.org/b/131759>

Some IDL attributes will always return the same value when queried
on an object, so let's have a way to avoid calling into C++ code
every time they are queried.

This patch adds a custom IDL thingy called "ReturnsCacheableValue"
which causes the code generator to emit code to cache the returned
value directly in the JS wrapper object.

Reviewed by Oliver Hunt.

bindings/scripts/IDLAttributes.txt:
bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

Add ReturnsCacheableValue custom attribute.

dom/Element.idl:
dom/Node.idl:

Annotate some attributes that return fully cacheable values.

bindings/scripts/test/*:

Rebaseline.

1:54 PM Changeset in webkit [167382] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

Fix JSC Debug Regressions on Windows
https://bugs.webkit.org/show_bug.cgi?id=131182

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-04-16
Reviewed by Brent Fulgham.

The cast static_cast<int64_t>(number) in JSValue::isMachineInt() can generate a floating point error,
and set the st floating point register tags, if the value of the number parameter is infinite.
If the st floating point register tags are not cleared, this can cause strange floating point behavior later on.
This can be avoided by checking for infinity first.

runtime/JSCJSValueInlines.h:

(JSC::JSValue::isMachineInt): Avoid floating point error by checking for infinity first.

runtime/Options.cpp:

(JSC::recomputeDependentOptions): Re-enable jit for Windows.

1:43 PM Changeset in webkit [167381] by noel.gordon@gmail.com

2 edits in trunk/Source/WebCore

Progressive JPEG outputScanlines() calls should handle failure
https://bugs.webkit.org/show_bug.cgi?id=116701

Reviewed by Brent Fulgham.

outputScanlines() can fail and delete |this|. Copy the decoder pointer
member and use that copy to detect and handle the failure case.

platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageReader::decode):

1:10 PM Changeset in webkit [167380] by oliver@apple.com

6 edits
3 adds in trunk

Simple ES6 feature:Array.prototype.fill
https://bugs.webkit.org/show_bug.cgi?id=131703

Reviewed by David Hyatt.

Source/JavaScriptCore:
Add support for Array.prototype.fill

builtins/Array.prototype.js:

(fill):

runtime/ArrayPrototype.cpp:

LayoutTests:
Add tests.

js/Object-getOwnPropertyNames-expected.txt:
js/array-fill-expected.txt: Added.
js/array-fill.html: Added.
js/script-tests/Object-getOwnPropertyNames.js:
js/script-tests/array-fill.js: Added.

1:02 PM Changeset in webkit [167379] by ap@apple.com

3 edits in trunk/Source/WebKit2

Updating tests after bug 131721, [GTK] Fix unused parameter warnings.

Scripts/webkit2/LegacyMessageReceiver-expected.cpp:

(WebKit::WebPage::didReceiveWebPageMessage):
(WebKit::WebPage::didReceiveSyncWebPageMessage):

Scripts/webkit2/MessageReceiver-expected.cpp:

(WebKit::WebPage::didReceiveMessage):
(WebKit::WebPage::didReceiveSyncMessage):

12:57 PM Changeset in webkit [167378] by barraclough@apple.com

2 edits in trunk/Source/WTF

Update to pthread QoS SPI
https://bugs.webkit.org/show_bug.cgi?id=131753

Rubber stamped by Benjamin Poulain

wtf/ThreadingPthreads.cpp:

(WTF::setCurrentThreadQOSUtility):

12:54 PM Changeset in webkit [167377] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[curl] Add WEB_TIMING support
https://bugs.webkit.org/show_bug.cgi?id=127555

Patch by Robert Sipka <sipka@inf.u-szeged.hu> on 2014-04-16
Reviewed by Brent Fulgham.

Access timing information related to navigation.

platform/network/curl/ResourceHandleManager.cpp:

(WebCore::milisecondsSinceRequest):
(WebCore::calculateWebTimingInformations):
(WebCore::sockoptfunction):
(WebCore::headerCallback):
(WebCore::ResourceHandleManager::downloadTimerCallback):
(WebCore::ResourceHandleManager::dispatchSynchronousJob):
(WebCore::ResourceHandleManager::initializeHandle):

12:37 PM Changeset in webkit [167376] by zoltan@webkit.org

2 edits in trunk/Source/WebCore

Cleanup header includes in ShapeOutsideInfo.h
https://bugs.webkit.org/show_bug.cgi?id=131750

Reviewed by Antti Koivisto.

Make the build faster by removing unnecessary header includes.

No new tests, no behavior change.

rendering/shapes/ShapeOutsideInfo.h:

12:12 PM Changeset in webkit [167375] by Simon Fraser

2 edits in trunk/Source/WebCore

Fix the iOS build.

platform/graphics/cg/BitmapImageCG.cpp:

(WebCore::BitmapImage::draw):

12:01 PM Changeset in webkit [167374] by ddkilzer@apple.com

1 edit
12 deletes in trunk/LayoutTests

Remove test results that match platform/mac results

Found using this shell script:

$ for F in find LayoutTests/platform/ios-sim -name \*-expected.txt; do \
T=echo $F | sed -e 's#platform/ios-sim/##'; \
M=echo $F | sed -e 's#platform/ios-sim/#platform/mac/#'; \
ML=echo $F | sed -e 's#platform/ios-sim/#platform/mac-mountainlion/#'; \
if [ -f $M -a ! -f $ML -a -z "diff -u $F $M 2> /dev/null" ]; then echo $F; fi; \
done

platform/ios-sim/fast/block/positioning/016-expected.txt: Removed.
platform/ios-sim/fast/block/positioning/025-expected.txt: Removed.
platform/ios-sim/fast/dom/icon-url-property-expected.txt: Removed.
platform/ios-sim/fast/hidpi/focus-rings-expected.txt: Removed.
platform/ios-sim/fast/multicol/shrink-to-column-height-for-pagination-expected.txt: Removed.
platform/ios-sim/fast/preloader/document-write-2-expected.txt: Removed.
platform/ios-sim/fast/preloader/script-expected.txt: Removed.
platform/ios-sim/fast/writing-mode/broken-ideograph-small-caps-expected.txt: Removed.
platform/ios-sim/fast/xsl/sort-locale-expected.txt: Removed.
platform/ios-sim/http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt: Removed.
platform/ios-sim/sputnik/Unicode/Unicode_320/S7.6_A2.2_T2-expected.txt: Removed.
platform/ios-sim/sputnik/Unicode/Unicode_320/S7.6_A5.2_T8-expected.txt: Removed.
platform/ios-sim/webarchive/loading/mainresource-null-mimetype-crash-expected.txt: Removed.

12:00 PM Changeset in webkit [167373] by ddkilzer@apple.com

1 edit
91 deletes in trunk/LayoutTests

Remove test results that match top-level results

Found using this shell script:

$ for F in find LayoutTests/platform/ios-sim -name \*-expected.txt; do \
T=echo $F | sed -e 's#platform/ios-sim/##'; \
M=echo $F | sed -e 's#platform/ios-sim/#platform/mac/#'; \
ML=echo $F | sed -e 's#platform/ios-sim/#platform/mac-mountainlion/#'; \
if [ ! -f $M -a ! -f $ML -a -f $T -a -z "diff -u $F $T 2> /dev/null" ]; then echo $F; fi; \
done

platform/ios-sim/compositing/layer-creation/no-compositing-for-sticky-expected.txt: Removed.
platform/ios-sim/editing/inserting/insert-3786362-fix-expected.txt: Removed.
platform/ios-sim/editing/inserting/insert-3907422-fix-expected.txt: Removed.
platform/ios-sim/editing/unsupported-content/table-delete-001-expected.txt: Removed.
platform/ios-sim/editing/unsupported-content/table-delete-003-expected.txt: Removed.
platform/ios-sim/fast/block/positioning/move-with-auto-width-expected.txt: Removed.
platform/ios-sim/fast/canvas/2d.backingStorePixelRatio-expected.txt: Removed.
platform/ios-sim/fast/canvas/2d.imageDataHD-expected.txt: Removed.
platform/ios-sim/fast/canvas/canvas-fillPath-shadow-expected.txt: Removed.
platform/ios-sim/fast/canvas/webgl/texture-npot-expected.txt: Removed.
platform/ios-sim/fast/css/MarqueeLayoutTest-expected.txt: Removed.
platform/ios-sim/fast/css/color-leakage-expected.txt: Removed.
platform/ios-sim/fast/css/font-face-multiple-remote-sources-expected.txt: Removed.
platform/ios-sim/fast/css/font-face-remote-expected.txt: Removed.
platform/ios-sim/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
platform/ios-sim/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
platform/ios-sim/fast/css/nested-layers-with-hover-expected.txt: Removed.
platform/ios-sim/fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail1-expected.txt: Removed.
platform/ios-sim/fast/dom/Window/window-postmessage-arrays-expected.txt: Removed.
platform/ios-sim/fast/dom/constructed-objects-prototypes-expected.txt: Removed.
platform/ios-sim/fast/dom/gc-10-expected.txt: Removed.
platform/ios-sim/fast/dom/tabindex-clamp-expected.txt: Removed.
platform/ios-sim/fast/dynamic/dirty-float-in-clean-line-expected.txt: Removed.
platform/ios-sim/fast/events/pageshow-pagehide-on-back-cached-with-frames-expected.txt: Removed.
platform/ios-sim/fast/forms/mailto/advanced-get-expected.txt: Removed.
platform/ios-sim/fast/forms/mailto/advanced-put-expected.txt: Removed.
platform/ios-sim/fast/forms/radio/indeterminate-radio-expected.txt: Removed.
platform/ios-sim/fast/forms/select-script-onchange-expected.txt: Removed.
platform/ios-sim/fast/forms/suggested-value-expected.txt: Removed.
platform/ios-sim/fast/history/timed-refresh-in-cached-frame-expected.txt: Removed.
platform/ios-sim/fast/lists/inline-before-content-after-list-marker-expected.txt: Removed.
platform/ios-sim/fast/media/media-query-list-07-expected.txt: Removed.
platform/ios-sim/fast/media/print-restores-previous-mediatype-expected.txt: Removed.
platform/ios-sim/fast/multicol/span/before-child-anonymous-column-block-expected.txt: Removed.
platform/ios-sim/fast/overflow/horizontal-scroll-after-back-expected.txt: Removed.
platform/ios-sim/fast/overflow/scrollbar-restored-expected.txt: Removed.
platform/ios-sim/fast/repaint/table-hover-on-link-expected.txt: Removed.
platform/ios-sim/fast/repaint/table-section-repaint-expected.txt: Removed.
platform/ios-sim/fast/ruby/floating-ruby-text-expected.txt: Removed.
platform/ios-sim/fast/ruby/overhang-horizontal-expected.txt: Removed.
platform/ios-sim/fast/ruby/overhang-horizontal-no-overlap1-expected.txt: Removed.
platform/ios-sim/fast/ruby/overhang-horizontal-no-overlap2-expected.txt: Removed.
platform/ios-sim/fast/ruby/positioned-ruby-text-expected.txt: Removed.
platform/ios-sim/fast/ruby/ruby-text-before-child-split-expected.txt: Removed.
platform/ios-sim/fast/table/empty-row-crash-expected.txt: Removed.
platform/ios-sim/fast/table/empty-section-crash-expected.txt: Removed.
platform/ios-sim/fast/table/inline-form-assert-expected.txt: Removed.
platform/ios-sim/fast/table/max-width-integer-overflow-expected.txt: Removed.
platform/ios-sim/fast/table/table-row-split2-expected.txt: Removed.
platform/ios-sim/fast/table/table-section-split2-expected.txt: Removed.
platform/ios-sim/fast/table/table-split-expected.txt: Removed.
platform/ios-sim/fast/table/table-split2-expected.txt: Removed.
platform/ios-sim/fast/text/apply-start-width-after-skipped-text-expected.txt: Removed.
platform/ios-sim/fast/text/justify-padding-distribution-expected.txt: Removed.
platform/ios-sim/fast/text/selection-painted-separately-expected.txt: Removed.
platform/ios-sim/fast/text/setData-dirty-lines-expected.txt: Removed.
platform/ios-sim/fast/text/soft-hyphen-2-expected.txt: Removed.
platform/ios-sim/fast/text/splitText-dirty-lines-expected.txt: Removed.
platform/ios-sim/fast/transforms/shadows-expected.txt: Removed.
platform/ios-sim/fast/workers/worker-close-more-expected.txt: Removed.
platform/ios-sim/fast/writing-mode/table-percent-width-quirk-expected.txt: Removed.
platform/ios-sim/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Removed.
platform/ios-sim/http/tests/appcache/abort-cache-onchecking-manifest-404-expected.txt: Removed.
platform/ios-sim/http/tests/cookies/simple-cookies-expired-expected.txt: Removed.
platform/ios-sim/http/tests/cookies/simple-cookies-max-age-expected.txt: Removed.
platform/ios-sim/http/tests/cookies/single-quoted-value-expected.txt: Removed.
platform/ios-sim/http/tests/misc/empty-urls-expected.txt: Removed.
platform/ios-sim/http/tests/multipart/load-last-non-html-frame-expected.txt: Removed.
platform/ios-sim/http/tests/navigation/post-goback1-expected.txt: Removed.
platform/ios-sim/http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked-expected.txt: Removed.
platform/ios-sim/http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt: Removed.
platform/ios-sim/http/tests/security/local-video-poster-from-remote-expected.txt: Removed.
platform/ios-sim/http/tests/security/sandboxed-iframe-modify-self-expected.txt: Removed.
platform/ios-sim/http/tests/security/video-poster-cross-origin-crash-expected.txt: Removed.
platform/ios-sim/http/tests/xmlhttprequest/chunked-progress-event-expectedLength-expected.txt: Removed.
platform/ios-sim/http/tests/xmlhttprequest/request-encoding2-expected.txt: Removed.
platform/ios-sim/http/tests/xmlhttprequest/upload-onloadend-event-after-load-expected.txt: Removed.
platform/ios-sim/http/tests/xmlhttprequest/upload-onprogress-event-expected.txt: Removed.
platform/ios-sim/http/tests/xmlhttprequest/upload-progress-events-expected.txt: Removed.
platform/ios-sim/media/csp-blocks-video-expected.txt: Removed.
platform/ios-sim/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Removed.
platform/ios-sim/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Removed.
platform/ios-sim/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Removed.
platform/ios-sim/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Removed.
platform/ios-sim/svg/as-image/image-respects-pageScaleFactor-change-expected.txt: Removed.
platform/ios-sim/svg/css/getComputedStyle-basic-expected.txt: Removed.
platform/ios-sim/svg/custom/baseval-animval-equality-expected.txt: Removed.
platform/ios-sim/svg/custom/dasharrayOrigin-expected.txt: Removed.
platform/ios-sim/svg/custom/getSubStringLength-expected.txt: Removed.
platform/ios-sim/svg/custom/pattern-scaling-expected.txt: Removed.
platform/ios-sim/svg/custom/svg-features-expected.txt: Removed.
platform/ios-sim/svg/dom/altGlyph-dom-expected.txt: Removed.
platform/ios-sim/svg/foreignObject/fO-parent-display-none-expected.txt: Removed.
platform/ios-sim/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt: Removed.
platform/ios-sim/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt: Removed.
platform/ios-sim/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt: Removed.
platform/ios-sim/svg/hittest/svg-ellipse-non-scale-stroke-expected.txt: Removed.

12:00 PM Changeset in webkit [167372] by ddkilzer@apple.com

2166 edits
1 copy
1126 adds
2 deletes in trunk/LayoutTests

<http://webkit.org/b/129171> Rebaseline LayoutTests for iOS

3206 files changed, 65535 insertions(+), 39972 deletions(-)

platform/ios-sim/Skipped: Clean up old items. Skip tests that

time out due to notifyDone() not being called.

11:59 AM Faster Build edited by Simon Fraser

(diff)

11:58 AM Faster Build created by Simon Fraser

11:57 AM April 2014 Meeting edited by Simon Fraser

(diff)

11:56 AM Changeset in webkit [167371] by ddkilzer@apple.com

1 edit
7742 adds in trunk/LayoutTests

Upstream iOS layout test results

7354 files changed, 367781 insertions(+)

platform/ios-sim: Add.

11:51 AM Changeset in webkit [167370] by Andres Gomez

3 edits in trunk/Tools

[Win] Pass default parameters to cygwin setup wizard
https://bugs.webkit.org/show_bug.cgi?id=131361

Reviewed by Brent Fulgham.

Added some parameters to the cygwin setup wizard so the user
doesn't really have to do any interaction.

CygwinDownloader/cygwin-downloader.py:
CygwinDownloader/cygwin-downloader.zip:

11:51 AM Changeset in webkit [167369] by ddkilzer@apple.com

1 edit
101 copies
5 adds
1 delete in trunk/LayoutTests

Rename LayoutTests/platformm/iphone-simulator => ios-sim

platform/ios-sim: Renamed from LayoutTests/platform/iphone-simulator.

11:49 AM Changeset in webkit [167368] by ap@apple.com

8 edits
2 adds in trunk

DataTransfer should cache its FileList
https://bugs.webkit.org/show_bug.cgi?id=131694

Reviewed by Darin Adler.

Source/WebCore:
Test: fast/events/data-transfer-files-attribute-identity.html

bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::readTerminal):

Switched to a new FileList constructor, CloneDeserializer doesn't really need to modify
the FileList with append().

dom/DataTransfer.h:
dom/DataTransfer.cpp:

(WebCore::DataTransfer::types): Added a FIXME.
(WebCore::DataTransfer::files): Changed to reuse a cached FileList. It's currently
easy, because we don't support DataTransferItemList. Once we do, making any changes
through it will also require updating the FileList in a way that doesn't replace
File objects for unchanged files.

fileapi/FileList.h:

(WebCore::FileList::create):
(WebCore::FileList::isEmpty):
(WebCore::FileList::FileList):
(WebCore::FileList::append):
(WebCore::FileList::clear):
Made non-const functions private, because neither DataTransfer nor FileInputType
expect the list to be modified without their knowledge. Added a new Vector based
constructor so that a FileList could be created without the use of append().

html/FileInputType.cpp: (WebCore::FileInputType::createFileList): Simplified

the code a little bit. FileInputType still needs to modify the list for clear(),
but doesn't need to add to it dynamically - unlike with DataTransfer, it's expected
to create a new FileList when it's modified.

LayoutTests:

fast/events/data-transfer-files-attribute-identity-expected.txt: Added.
fast/events/data-transfer-files-attribute-identity.html: Added.

platform/wk2/TestExpectations: Skipped the test, because WKTR doesn't support

file dragging yet.

11:32 AM Changeset in webkit [167367] by zoltan@webkit.org

2 edits in trunk/LayoutTests

Remove fast/parser/parser-yield-timing.html from skipped list
https://bugs.webkit.org/show_bug.cgi?id=131749

Reviewed by Darin Adler.

The test was originally skipped in Bug 89812 due to flakiness on Chromium
debug bots. I run the tests with huge iterations and I don't see
flakiness on Mavericks release/debug. Let's remove from skipped for now.

platform/mac/TestExpectations:

11:16 AM Changeset in webkit [167366] by Bem Jones-Bey

3 edits in trunk/LayoutTests

Remove references to Leopard and Snow Leopard from Windows TestExpectations

Filed new bugs to track each of these tests, so someone with a windows
build can try and see if the tests still fail.

Unreviewed.

platform/win/TestExpectations:
platform/wincairo/TestExpectations:

11:15 AM Changeset in webkit [167365] by Brent Fulgham

8 edits in trunk

[Win] Eliminate use of deleteAllValues in Windows Files
https://bugs.webkit.org/show_bug.cgi?id=131631

Reviewed by Darin Adler.

Source/WebCore:
Update to use std::unique_ptr for object lifetime. Get rid of
deleteAllValues now that it is no loner needed. Use ranged for
loops where possible.

platform/win/WCDataObject.cpp:

(WebCore::WCEnumFormatEtc::WCEnumFormatEtc):
(WebCore::WCDataObject::~WCDataObject):
(WebCore::WCDataObject::GetData):
(WebCore::WCDataObject::QueryGetData):
(WebCore::WCDataObject::SetData):
(WebCore::WCDataObject::clearData):

platform/win/WCDataObject.h:

Tools:
Switch to std::unique_ptr for memory lifetime. Get rid of
deleteAllValues now that it is no longer needed. Use ranged
for loops where possible.

DumpRenderTree/win/DRTDataObject.cpp:

(WCEnumFormatEtc::WCEnumFormatEtc):
(DRTDataObject::~DRTDataObject):
(DRTDataObject::GetData):
(DRTDataObject::QueryGetData):
(DRTDataObject::SetData):
(DRTDataObject::clearData):

DumpRenderTree/win/DRTDataObject.h:
DumpRenderTree/win/UIDelegate.cpp:

(DRTUndoObject::DRTUndoObject):
(DRTUndoObject::~DRTUndoObject):
(DRTUndoStack::~DRTUndoStack):
(DRTUndoStack::clear):
(DRTUndoStack::pop):
(DRTUndoManager::DRTUndoManager):
(DRTUndoManager::redo):
(DRTUndoManager::undo):
(UIDelegate::UIDelegate):
(UIDelegate::resetUndoManager):

DumpRenderTree/win/UIDelegate.h:

11:09 AM Changeset in webkit [167364] by mhahnenberg@apple.com

2 edits in trunk/Source/JavaScriptCore

[WebKit] Cleanup the build from uninitialized variable in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=131728

Reviewed by Darin Adler.

runtime/JSObject.cpp:

(JSC::JSObject::genericConvertDoubleToContiguous): Add a RELEASE_ASSERT on the
path we expect to never take. Also shut up confused compilers about uninitialized things.

11:08 AM April 2014 Meeting edited by rniwa@webkit.org

Add Web Components slides (diff)

11:06 AM Changeset in webkit [167363] by Simon Fraser

2 edits in trunk/Source/WebKit

Make Windows fail with a link error so I know what the new symbol is.

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

11:05 AM Changeset in webkit [167362] by abucur@adobe.com

1 edit in trunk/LayoutTests/platform/mac-wk2/TestExpectations

[mac][wk2] REGRESSION (Tiled Drawing): fast/layers/no-clipping-overflow-hidden-added-after-transform.html fails with tiled drawing
https://bugs.webkit.org/show_bug.cgi?id=122238

Unreviewed. The test passes now.

11:04 AM Changeset in webkit [167361] by Chris Fleizach

2 edits
2 adds in trunk

AX: Accessing a table cell with an invalid column header crashes
https://bugs.webkit.org/show_bug.cgi?id=131719

Reviewed by Darin Adler.

If no tableCell is available as a column/row header, then do not continue processing.

Test: accessibility/table-missing-column-header-crash.html

accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::columnHeaders):
(WebCore::AccessibilityTableCell::rowHeaders):

11:00 AM Changeset in webkit [167360] by b.long@cablelabs.com

7 edits in trunk/Source

[GTK] Fix unused parameter warnings
https://bugs.webkit.org/show_bug.cgi?id=131721

Reviewed by Darin Adler.

Source/WebCore:

bindings/js/JSMediaStreamCapabilitiesCustom.cpp:

(WebCore::toJS): Remove unused 'exec' parameter.

Source/WebKit2:

Scripts/webkit2/messages.py:

(generate_message_handler): Add UNUSED_PARAM() for a couple parameters which aren't always used.

Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<LinearTimingFunction>::decode): Remove unused parameters.

WebProcess/InjectedBundle/APIInjectedBundleFormClient.h:

(API::InjectedBundle::FormClient::textDidChangeInTextField): Same.
(API::InjectedBundle::FormClient::willSubmitForm): Same.
(API::InjectedBundle::FormClient::willSendSubmitEvent): Same.

WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::didReceiveSyncMessage): Same.

10:58 AM Changeset in webkit [167359] by commit-queue@webkit.org

2 edits in trunk/Tools

[GTK] Unreviewed GTK gardening.

Update list of skipped unit tests:

Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility

Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors

Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-04-16

Scripts/run-gtk-tests:

(TestRunner):

10:58 AM Changeset in webkit [167358] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Accidentally included some style-checker-testing changes in the last commit.

WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::attemptToUnlockPDF):
(WebKit::PDFPlugin::updatePageAndDeviceScaleFactors):

10:54 AM Changeset in webkit [167357] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Fix some style checker complaints in PDFPlugin
https://bugs.webkit.org/show_bug.cgi?id=131706

Reviewed by Darin Adler.

WebProcess/Plugins/PDF/PDFPlugin.mm:

(-[WKPDFPluginAccessibilityObject accessibilityAttributeValue:]):
(-[WKPDFPluginAccessibilityObject accessibilityAttributeValue:forParameter:]):
(-[WKPDFPluginAccessibilityObject accessibilityAttributeNames]):
(WebKit::PDFPlugin::attemptToUnlockPDF):
(WebKit::PDFPlugin::updatePageAndDeviceScaleFactors):
(WebKit::PDFPlugin::isEditingCommandEnabled):
(WebKit::PDFPlugin::nextMatchForString):
(WebKit::PDFPlugin::handleWheelEvent):
(WebKit::PDFPlugin::liveData):

10:50 AM Changeset in webkit [167356] by Simon Fraser

7 edits in trunk/Source/WebCore

Convert the boolean param of Image::startAnimation() to an enum
https://bugs.webkit.org/show_bug.cgi?id=131742

Reviewed by Tim Horton.

Use an enum to make the code more readable.

platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::startAnimation):

platform/graphics/BitmapImage.h:
platform/graphics/Image.cpp:

(WebCore::Image::drawTiled):

platform/graphics/Image.h:

(WebCore::Image::startAnimation):

svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::startAnimation):

svg/graphics/SVGImage.h:

10:48 AM Changeset in webkit [167355] by ggaren@apple.com

2 edits
2 adds in trunk/Source/WTF

WTF should have an optional mbmalloc target so we can benchmark FastMalloc
https://bugs.webkit.org/show_bug.cgi?id=131662

Reviewed by Darin Adler.

WTF.xcodeproj/project.pbxproj: Added the target.
wtf/mbmalloc.cpp: Added. Implements the libmbmalloc.dylib API required

by MallocBench.

10:48 AM Changeset in webkit [167354] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed, ARMv7 build fix after r167336.

assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::branchAdd32):

10:36 AM Changeset in webkit [167353] by hyatt@apple.com

3 edits
2 adds in trunk

Make sure to skip the RenderMultiColumnFlowThread when resolving percentage heights inside columns against
containing blocks. The flow thread's auto height should not interfere if a fixed height is specified on
an ancestor.

https://bugs.webkit.org/show_bug.cgi?id=131741

Reviewed by Simon Fraser.

Source/WebCore:
Added fast/multicol/percent-height.html.

rendering/RenderBox.cpp:

(WebCore::RenderBox::skipContainingBlockForPercentHeightCalculation):
Add an isInFlowRenderFlowThread check so that we skip those blocks and don't consider them at all
when resolving percentage heights.

LayoutTests:

fast/multicol/percent-height-expected.html: Added.
fast/multicol/percent-height.html: Added.

10:33 AM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com

(diff)

10:24 AM Changeset in webkit [167352] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

[WinCairo][cURL] Build fix for WinCairo build with USE(CURL).
https://bugs.webkit.org/show_bug.cgi?id=131614

Patch by Daewoong Jang <daewoong.jang@navercorp.com> on 2014-04-16
Reviewed by Brent Fulgham.

Build fix, no new tests needed.

platform/network/curl/CurlCacheEntry.cpp:

(WebCore::CurlCacheEntry::loadResponseHeaders):

platform/network/curl/CurlCacheManager.cpp:

(WebCore::CurlCacheManager::loadIndex):

platform/network/soup/ResourceError.h:
platform/network/soup/SocketStreamHandle.h:

10:19 AM Changeset in webkit [167351] by commit-queue@webkit.org

3 edits
2 adds in trunk

ASSERTION FAILED: x2 >= x1 in WebCore::RenderObject::drawLineForBoxSide
https://bugs.webkit.org/show_bug.cgi?id=127835

Source/WebCore:
In some cases when a negative margin and a positive padding are applied
together to the right and/or left side of the box, the logical width of
the borders can be set to a negative value, making the assertion fire.
The fix checks if the width or height of the box is negative, and if so,
it will not display the borders and shadows of the box.

Patch by Martin Hodovan <mhodovan@inf.u-szeged.hu> on 2014-04-16
Reviewed by Darin Adler.

Test: fast/css/padding-margin-negative-border.html

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder):

LayoutTests:
Added test demonstrates four cases:
Test #1: Negative upper margin + positive upper padding
Test #2: Negative right margin + positive right padding (used to fail)
Test #3: Negative bottom margin + positive bottom padding
Test #4: Negative left margin + positive left padding (used to fail)

Patch by Martin Hodovan <mhodovan@inf.u-szeged.hu> on 2014-04-16
Reviewed by Darin Adler.

fast/css/padding-margin-negative-border-expected.html: Added.
fast/css/padding-margin-negative-border.html: Added.

10:17 AM Changeset in webkit [167350] by timothy_horton@apple.com

4 edits in trunk/Tools

check-webkit-style doesn't check code style in .mm or .m files
https://bugs.webkit.org/show_bug.cgi?id=131708

Reviewed by Darin Adler.

Scripts/webkitpy/style/checker.py:
Scripts/webkitpy/style/checker_unittest.py:

(CheckerDispatcherDispatchTest.test_cpp_paths):
(CheckerDispatcherDispatchTest.test_text_paths):
Check .mm and .m files as C++.

Scripts/webkitpy/style/checkers/cpp.py:

(check_spacing):
Add an override for our ordinary "missing spaces around =" for @synthesize,
which should look like "@synthesize propertyName=_varName;"

Add an override for "missing space before {" for blocks' "^{".

Don't follow the "extra space before [" rule for Objective-C, because
it breaks this rule in a multitude of ways because of method calls.

(check_braces):
Don't complain about { not being on the end of the previous line if
the previous line starts with "- (" or "+ (", which would indicate a
Objective-C method definition.

10:07 AM Apr2014WebKitMeetingGrp-small-2.jpg attached to April 2014 Meeting by zoltan@webkit.org

10:04 AM April 2014 Meeting edited by zoltan@webkit.org

(diff)

10:03 AM Apr2014WebKitMeetingGrp-2.jpg attached to April 2014 Meeting by zoltan@webkit.org

9:52 AM Changeset in webkit [167349] by jer.noble@apple.com

3 edits
2 adds in trunk

[MSE] Seeks into buffered ranges will never complete.
https://bugs.webkit.org/show_bug.cgi?id=131717

Reviewed by Eric Carlson.

Source/WebCore:
Test: media/media-source/media-source-seek-complete.html

Run the SourceBuffer Monitoring step after initiating a seek.

Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateSeekToTime):

LayoutTests:

media/media-source/media-source-seek-complete-expected.txt: Added.
media/media-source/media-source-seek-complete.html: Added.

9:51 AM Changeset in webkit [167348] by Darin Adler

4 edits in trunk

Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
https://bugs.webkit.org/show_bug.cgi?id=131735

Reviewed by Alexey Proskuryakov.

Source/WTF:

wtf/Vector.h:

(WTF::Vector::takeLast): Added a missing std::move. All the other take functions have it.

Tools:

TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.

Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
is on the right. This can be confusing since our JavaScript test framework does it the opposite
way, but gtest works better this way.

8:38 AM April 2014 Meeting edited by dino@apple.com