Context Navigation

Tweak buildPattern() and buildTileImageTransform() to take RenderElement&
instead of RenderObject* since we know that these functions will always
be called with non-null RenderElement subclasses.

Reviewed by Sam Weinig.

rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::shouldTransformOnTextPainting):

rendering/svg/RenderSVGResourceContainer.h:
rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::RenderSVGResourceGradient::applyResource):

rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::buildPattern):
(WebCore::RenderSVGResourcePattern::applyResource):
(WebCore::RenderSVGResourcePattern::buildTileImageTransform):

rendering/svg/RenderSVGResourcePattern.h:

8:25 PM Changeset in webkit [168236] by benjamin@webkit.org

3 edits
2 adds in trunk

CSS JIT: optimize direct / indirect adjacent's traversal backtracking
https://bugs.webkit.org/show_bug.cgi?id=132319

Patch by Yusuke Suzuki <Yusuke Suzuki> on 2014-05-03
Reviewed by Benjamin Poulain.

Source/WebCore:
Since adjacent backtracking stack reference is pre-allocated
in prologue in http://trac.webkit.org/changeset/166834,
clearing stack phase is not needed. So we can drop
JumpToClearAdjacentTail from backtracking action and simplify
backtracking handling.
And optimize direct / indirect adjacent's traversal backtracking by
using appropriate backtracking height.

When solving adjacent traversal backtracking action,
1) When there's no descendant relation on the right, traversal
failure becomes global failure.
2) When tagNameMatchedBacktrackingStartHeightFromDescendant ==
heightFromDescendant + 1, the descendant backtracking starts with
the parent of the current element. So we can use the current element
and the backtracking action is JumpToDescendantTreeWalkerEntryPoint.
3) Otherwise, currently we take the conservative approach,
JumpToDescendantTail.

NOTE:
And if hasDescendantRelationOnTheRight is true and there's no child
fragment on the right, the backtracking element register is not
effective. So we should ensure that fragment doesn't use the
backtracking element register. Such a fragment fulfills the following
conditions. 1. tagNameMatchedBacktrackingStartHeightFromDescendant is
always 1 (tagNames.size(), that contains only descendant fragment) 2.
heightFromDescendant is always 0 (-- See
computeBacktrackingHeightFromDescendant implementation) Therefore such
a fragment's action always becomes
JumpToDescendantTreeWalkerEntryPoint. So we can ensure that the
backtracking element register is not used.

Test: fast/selectors/backtracking-adjacent.html

cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::solveDescendantBacktrackingActionForChild):
(WebCore::SelectorCompiler::solveAdjacentTraversalBacktrackingAction):
(WebCore::SelectorCompiler::solveBacktrackingAction):
(WebCore::SelectorCompiler::SelectorCodeGenerator::computeBacktrackingInformation):
(WebCore::SelectorCompiler::SelectorCodeGenerator::linkFailures):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateAdjacentBacktrackingTail):
(WebCore::SelectorCompiler::isAfterChildRelation): Deleted.

LayoutTests:

fast/selectors/backtracking-adjacent-expected.txt: Added.
fast/selectors/backtracking-adjacent.html: Added.

8:22 PM Changeset in webkit [168235] by akling@apple.com

2 edits in trunk/Source/WebCore

Clear the JSString cache when under memory pressure.
<https://webkit.org/b/132539>

The WeakGCMap used for fast mapping from StringImpl* to JSString*
can actually get pretty big, and if we find ourselves under memory
pressure, it's entirely inessential.

1.1 MB progression on Membuster3.

Reviewed by Sam Weinig.

platform/MemoryPressureHandler.cpp:

(WebCore::MemoryPressureHandler::releaseMemory):

6:55 PM Changeset in webkit [168234] by timothy_horton@apple.com

3 edits in trunk/Source/WebKit2

[iOS] REGRESSION (WebKit2): Page isn't clipped properly during back/forward swipe
https://bugs.webkit.org/show_bug.cgi?id=132538
<rdar://problem/16266027>

Reviewed by Simon Fraser.

UIProcess/ios/ViewGestureControllerIOS.mm:

(WebKit::ViewGestureController::beginSwipeGesture):
(WebKit::ViewGestureController::endSwipeGesture):

UIProcess/mac/ViewGestureController.h:

Add a clipping layer above the live swipe layer, which explicitly clips to bounds.

6:48 PM Changeset in webkit [168233] by benjamin@webkit.org

6 edits in trunk/Source/WebCore

[iOS][WK2] Support disabling speculative tiling
https://bugs.webkit.org/show_bug.cgi?id=132512

Reviewed by Tim Horton.

Move ScrollView::setScrollVelocity() and ScrollView::computeCoverageRect() to FrameView.
When speculative tiling is disabled, return an unmodified exposed rect.

Time/velocity adjusments are completely unnecessary at the moment since speculative tiling
is enabled as soon as the view scrolls.

WebCore.exp.in:
page/FrameView.cpp:

(WebCore::FrameView::setScrollVelocity):
(WebCore::FrameView::computeCoverageRect):

page/FrameView.h:
platform/ScrollView.h:
platform/ios/ScrollViewIOS.mm:

(WebCore::ScrollView::setScrollVelocity): Deleted.
(WebCore::ScrollView::computeCoverageRect): Deleted.

5:17 PM Changeset in webkit [168232] by psolanki@apple.com

19 edits in trunk/Source

Shortcircuit shouldUseCredentialStorage callback
https://bugs.webkit.org/show_bug.cgi?id=132308
<rdar://problem/16806708>

Reviewed by Alexey Proskuryakov.

If we are going to return true from the shouldUseCredentialStorage callback then we don't
really need to have CFNetwork/Foundation call us. We can just disable the callback and
CFNetwork will assume true. Add a separate subclass that implements this callback when we
need to return false. We can also eliminate the corresponding async callbacks. This avoids
pingponging between dispatch queue and main thread in the common case.

No new tests because no change in functionality.

Source/WebCore:

WebCore.exp.in:
platform/network/ResourceHandle.cpp:
platform/network/ResourceHandle.h:
platform/network/ResourceHandleClient.cpp:
platform/network/ResourceHandleClient.h:
platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::createCFURLConnection):
(WebCore::ResourceHandle::shouldUseCredentialStorage):

platform/network/cf/ResourceHandleCFURLConnectionDelegate.h:
platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:

(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::shouldUseCredentialStorage):

platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.h:
platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp:
platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.h:
platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::makeDelegate):
(WebCore::ResourceHandle::delegate):
(WebCore::ResourceHandle::platformLoadResourceSynchronously):
(WebCore::ResourceHandle::shouldUseCredentialStorage):

platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.h:
platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleWithCredentialStorageAsOperationQueueDelegate connectionShouldUseCredentialStorage:]):

platform/network/soup/ResourceHandleSoup.cpp:

Source/WebKit2:

NetworkProcess/NetworkResourceLoader.cpp: Remove shouldUseCredentialStorageAsync() callbacks.
NetworkProcess/NetworkResourceLoader.h:

5:13 PM Changeset in webkit [168231] by psolanki@apple.com

3 edits in trunk/Source/WebKit2

Reduce calls to CFURLCacheCopySharedURLCache
https://bugs.webkit.org/show_bug.cgi?id=132464
<rdar://problem/16806694>

Reviewed by Alexey Proskuryakov.

CFURLCacheCopySharedURLCache grabs a mutex and can sometimes block. Avoid that by stashing
the cache reference in a static.

NetworkProcess/NetworkResourceLoader.h: Coalesce ifdef'd code.
NetworkProcess/mac/NetworkResourceLoaderMac.mm:

(WebKit::NetworkResourceLoader::tryGetShareableHandleFromSharedBuffer):
(WebKit::NetworkResourceLoader::willCacheResponseAsync): Use more correct ifdef for
Foundation based callback.

3:16 PM Changeset in webkit [168230] by akling@apple.com

5 edits
2 adds in trunk

Invalidate scrollbars when custom scrollbar style changes dynamically.
<https://webkit.org/b/132529>

Source/WebCore:
Add a ScrollView::styleDidChange() and call that from RenderView::styleDidChange()
so that the scrollbars are sure to get repainted with potentially different style.

Reviewed by Antti Koivisto.

Test: fast/css/scrollbar-dynamic-style-change.html

platform/ScrollView.cpp:

(WebCore::ScrollView::styleDidChange):

platform/ScrollView.h:
rendering/RenderView.cpp:

(WebCore::RenderView::styleDidChange):

LayoutTests:
Reviewed by Antti Koivisto.

fast/css/scrollbar-dynamic-style-change-expected.html: Added.
fast/css/scrollbar-dynamic-style-change.html: Added.

1:46 PM Changeset in webkit [168229] by weinig@apple.com

9 edits
3 copies in trunk/Source/WebKit2

[Cocoa WebKit2] Add basic _WKWebsiteDataStore implementation
https://bugs.webkit.org/show_bug.cgi?id=132526

Reviewed by Anders Carlsson.

Renames WKSession to _WKWebsiteDataStore to better reflect its intended use (renaming the implementation object will come later).
Makes _WKWebsiteDataStore work as a wrapped Objective-C object.
Adds the ability to set a _WKWebsiteDataStore on the WKWebViewConfiguration.

Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

UIProcess/API/Cocoa/WKSession.h:
UIProcess/API/Cocoa/WKSession.mm:

(-[WKSession dealloc]): Deleted.
(-[WKSession ephemeral]): Deleted.
(-[WKSession API::]): Deleted.

UIProcess/API/Cocoa/WKSessionInternal.h:

(WebKit::wrapper): Deleted.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):

UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _websiteDataStore]):
(-[WKWebViewConfiguration _setWebsiteDataStore:]):

UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
UIProcess/API/Cocoa/_WKWebsiteDataStore.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKSession.h.
UIProcess/API/Cocoa/_WKWebsiteDataStore.mm: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKSession.mm.

(+[_WKWebsiteDataStore nonPersistentDataStore]):
(-[_WKWebsiteDataStore isNonPersistentDataStore]):
(-[WKSession ephemeral]): Deleted.

UIProcess/API/Cocoa/_WKWebsiteDataStoreInternal.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKSessionInternal.h.
WebKit2.xcodeproj/project.pbxproj:

1:32 PM Changeset in webkit [168228] by Simon Fraser

5 edits in trunk

[UI-side compositing] Assertion in PlatformCAFilters::setFiltersOnLayer with animated reference filter
https://bugs.webkit.org/show_bug.cgi?id=132528
<rdar://problem/16671660>

Reviewed by Tim Horton.

Source/WebKit2:
Allow PASSTHROUGH filters to be encoded and sent to the UI process; they can be set
on layers as the result of a filter animation using a reference filter, and just get
ignored anyway, but encoding them maintains consistency of the filters list.

Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<FilterOperation>::encode): Assert during encoding if
we try to encode a NONE or REFERENCE filter (to match the decoding assertions).
(IPC::decodeFilterOperation): Allow decoding of PASSTHROUGH filters. Have
trying to decode a NONE or REFERENCE filter mark the message as invalid.
(IPC::ArgumentCoder<IDBKeyData>::decode): Mark the message invalid when receiving
unexpected key types.

Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTextStream::operator<<): Have the logging not crash if
a filter is null (should never happen).

LayoutTests:
Make the animation duration a little longer to cause bug 132528 to reproduce more
reliably. The test does notifyDone() from an animation start event, so this doesn't
increase test duration.

css3/filters/crash-filter-animation-invalid-url.html:

1:32 PM Changeset in webkit [168227] by Simon Fraser

5 edits
2 adds in trunk

Very fuzzy layers under non-decompasable matrices
https://bugs.webkit.org/show_bug.cgi?id=132516
<rdar://problem/16717478>

Reviewed by Sam Weinig.

Source/WebCore:
r155977 added code to modify layer contentsScale based on a root-relative
scale, so that scaled-up layers remained sharp. It does this by decomposing
an accumulated matrix, but failed to test whether the decomposition
succeeded. This would result in contentsScale of 0, which is clamped to 0.1,
resulting in very fuzzy layers.

Fix by testing for success of decomposition.

Test: compositing/contents-scale/non-decomposable-matrix.html

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::maxScaleFromTransform):

platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::decompose2): Return early for identity matrices,
with fix for m11 and m22.
(WebCore::TransformationMatrix::decompose4): Return early for identity matrices.

platform/graphics/transforms/TransformationMatrix.h:

Make Decomposed2Type and Decomposed4Type into C++ structs.
(WebCore::TransformationMatrix::Decomposed2Type::operator==): Added to make it easier
to write code that asserts that decomposition is correct.
(WebCore::TransformationMatrix::Decomposed4Type::operator==): Ditto.

LayoutTests:
Compare scaling under non-decomposable and decomposable matrices.

compositing/contents-scale/non-decomposable-matrix-expected.html: Added.
compositing/contents-scale/non-decomposable-matrix.html: Added.

12:13 PM Changeset in webkit [168226] by Simon Fraser

2 edits in trunk/Source/WebCore

Fix crash in WebKit client app when zooming
https://bugs.webkit.org/show_bug.cgi?id=132475
<rdar://problem/16703405>

Reviewed by Tim Horton.

It's possible for a WebTiledBackingLayer CALayer to remain in the CALayer
hierarchy after we've called -invalidate on it, which clears the _tileController.
Project the getters against null derefs to handle this.

platform/graphics/ca/mac/WebTiledBackingLayer.mm:

(-[WebTiledBackingLayer isOpaque]):
(-[WebTiledBackingLayer acceleratesDrawing]):
(-[WebTiledBackingLayer contentsScale]):

11:52 AM Changeset in webkit [168225] by rakuco@webkit.org

2 edits in trunk

[CMake] Define SHOULD_INSTALL_JS_SHELL before including ports Options files.
https://bugs.webkit.org/show_bug.cgi?id=132525

Reviewed by Martin Robinson.

CMakeLists.txt: If OPTION() is called after Options${PORT}.cmake is included, it will

override whatever value a port may have set for it. The GTK+ port, for example, tries to set
it to SHOULD_INSTALL_JS_SHELL to ON by default, even though it did not happen before.

10:40 AM Changeset in webkit [168224] by bshafiei@apple.com

2 edits in tags/Safari-538.33.1/Source/bmalloc

Merged r168152.

10:36 AM Changeset in webkit [168223] by Alan Bujtas

1 edit
2 adds in trunk/LayoutTests

Subpixel rendering: Add hidpi fieldset/legend test case to check fieldset's cliprect when legend text is present.
https://bugs.webkit.org/show_bug.cgi?id=132524

Reviewed by Simon Fraser.

This is the hidpi test for r168221. (Fieldset legend has a horizontal line
through, when the fieldset is painted on odd device pixel position.)

fast/forms/hidpi-fieldset-on-subpixel-position-when-legend-is-present-expected.html: Added.
fast/forms/hidpi-fieldset-on-subpixel-position-when-legend-is-present.html: Added.

3:37 AM Changeset in webkit [168222] by Carlos Garcia Campos

2 edits in trunk/Source/WebCore

Unreviewed. Fix GTK+ build after r168209.

platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::write):

12:47 AM Changeset in webkit [168221] by Alan Bujtas

2 edits in trunk/Source/WebCore

Subpixel rendering: Fieldset legend has a horizontal line through, when the fieldset is painted on odd device pixel position.
https://bugs.webkit.org/show_bug.cgi?id=132521
<rdar://problem/16803305>

Reviewed by Simon Fraser.

Use device pixel snapping when the fieldset's border gets clipped out for the legend's text. It ensures that
the device pixel snapped border gets properly clipped out.

Existing fieldset tests cover it.

rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBoxDecorations):

May 2, 2014:

9:09 PM Changeset in webkit [168220] by Alan Bujtas

2 edits in trunk/LayoutTests

[Mac] Unreviewed gardening.

Cliprect does not cover textarea properly on certain subpixel positions.

platform/mac/TestExpectations:

6:16 PM Changeset in webkit [168219] by Alan Bujtas

9 edits in trunk/Source/WebCore

CodeCleanup: Remove *MaintainsPixelAlignment from GraphicsLayer*.
https://bugs.webkit.org/show_bug.cgi?id=132501

Reviewed by Simon Fraser.

WebCore.exp.in:
platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::GraphicsLayer):

platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::setMaintainsPixelAlignment): Deleted.
(WebCore::GraphicsLayer::maintainsPixelAlignment): Deleted.
(WebCore::GraphicsLayer::pixelAlignmentOffset): Deleted.

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateGeometry):
(WebCore::GraphicsLayerCA::computePixelAlignment):
(WebCore::GraphicsLayerCA::setMaintainsPixelAlignment): Deleted.

platform/graphics/ca/GraphicsLayerCA.h:
rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::createGraphicsLayer):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::keepLayersPixelAligned): Deleted.

rendering/RenderLayerCompositor.h:

6:15 PM Changeset in webkit [168218] by mrowe@apple.com

2 edits in trunk/Tools

<https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for

Reviewed by Dan Bernstein.

Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value

when determining which LLVM archive to extract.

6:15 PM Changeset in webkit [168217] by Simon Fraser

5 edits in trunk/Source/WebCore

[iOS WK2] Tiled layer content missing on pages with animated tiled layers
https://bugs.webkit.org/show_bug.cgi?id=132507
<rdar://problem/16765740>

Reviewed by Tim Horton.

Updating the tiling area of content TileControllers while
CSS animations are running depends on GraphicsLayerUpdater
triggering repeated layer flushes. With UI-side compositing, those
flushes were happening, but nothing triggered RemoteLayerTreeDrawingArea
to flush changes to the UI process.

Fix by having RenderLayerCompositor schedule a flush, rather
than just doing a flush, in response to GraphicsLayerUpdater.

Also change the name of the GraphicsLayerUpdaterClient function
to indicate that it suggests that a flush is required soon, rather than
that the flushing has to be synchronous.

platform/graphics/GraphicsLayerUpdater.cpp:

(WebCore::GraphicsLayerUpdater::displayRefreshFired):

platform/graphics/GraphicsLayerUpdater.h:
rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::flushLayersSoon):
(WebCore::RenderLayerCompositor::flushLayers): Deleted.

rendering/RenderLayerCompositor.h:

6:13 PM Changeset in webkit [168216] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Use displayNameForTrack instead of textTrack->label() for captions.
https://bugs.webkit.org/show_bug.cgi?id=131311

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-05-02
Reviewed by Darin Adler.

Use the same mechanism as the desktop to build the captions list so it has the correct
names in the correct order including none and automatic.

platform/ios/WebVideoFullscreenModelMediaElement.h:
platform/ios/WebVideoFullscreenModelMediaElement.mm:

(WebVideoFullscreenModelMediaElement::setMediaElement):
move legible track code into updateLegibleOptions()

(WebVideoFullscreenModelMediaElement::handleEvent):
updateLegibleOptions on addTrack and removeTrack

(WebVideoFullscreenModelMediaElement::selectLegibleMediaOption):
select the corresponding TextTrack on HTMLMediaElement.

(WebVideoFullscreenModelMediaElement::updateLegibleOptions):
use the same mechanism as desktop to build the captions menu.

6:12 PM Changeset in webkit [168215] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

CSS-based Media Controls Show Different times content longer than 1 hour.
https://bugs.webkit.org/show_bug.cgi?id=132443

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-05-02
Reviewed by Jer Noble.

Modules/mediacontrols/mediaControlsApple.css:

(audio::-webkit-media-controls-timeline-container .hour-long-time):
This class has a wider width for longer duration times.

Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.updateDuration):
Apply .hour-long-time class as appropriate.

(Controller.prototype.formatTime):
More robust formatting to handle hours.

Modules/mediacontrols/mediaControlsiOS.css:

(audio::-webkit-media-controls-timeline-container .hour-long-time):
This class has a wider width for longer duration times.

Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.formatTime):
More robust formatting to handle hours.

6:09 PM Changeset in webkit [168214] by jer.noble@apple.com

3 edits in trunk/Source/WebCore

[MSE][Mac] AVAssetTrack returns incorrect track size
https://bugs.webkit.org/show_bug.cgi?id=132469

Reviewed by Brent Fulgham.

platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::didParseStreamDataAsAsset): Remove the sizeChanged() notification.
(WebCore::SourceBufferPrivateAVFObjC::processCodedFrame): Cache the last parsed video frame size.
(WebCore::SourceBufferPrivateAVFObjC::naturalSize): Return the cached value.

5:19 PM Changeset in webkit [168213] by mitz@apple.com

4 edits
1 delete in trunk/Source/WebKit2

[Cocoa] Remove unused WKErrorRecoveryAttempting
https://bugs.webkit.org/show_bug.cgi?id=132503

Reviewed by Anders Carlsson.

UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(didFailProvisionalLoadWithErrorForFrame):
(didFailLoadWithErrorForFrame):
(createErrorWithRecoveryAttempter): Deleted.
(-[WKBrowsingContextController attemptRecoveryFromError:]): Deleted.

UIProcess/API/Cocoa/WKErrorRecoveryAttempting.m: Removed.
UIProcess/API/Cocoa/_WKFormDelegate.h:
WebKit2.xcodeproj/project.pbxproj:

5:05 PM Changeset in webkit [168212] by matthew_hanson@apple.com

6 edits
2 copies in branches/safari-537.76-branch

Merge r166420.

5:02 PM Changeset in webkit [168211] by Alan Bujtas

2 edits in trunk/Source/WebCore

Subpixel rendering[iOS]: Use pixelSnappedRoundedRectForPainting() to clip text area rect.
https://bugs.webkit.org/show_bug.cgi?id=132499
<rdar://problem/16631050>

Reviewed by Simon Fraser.

Snap to device pixels properly instead of relying on float arithmetics while converting from RoundedRect
to FloatRoundedRect. This is the second, cleanup part of the text-area decoration is off-by-one painting issue.

Currently not testable.

rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::paintTextFieldDecorations):

5:00 PM Changeset in webkit [168210] by enrica@apple.com

2 edits in trunk/Source/WebKit2

REGRESSION (WebKit2) Need to support reanalyze button for Chinese Traditional.
https://bugs.webkit.org/show_bug.cgi?id=132504
<rdar://problem/16778862>

Reviewed by Benjamin Poulain.

For traditional Chinese we support reanalyzing of the text to perform
transformations on the text based on the selected language and keyboard.
This is done by pressing the Reanalyze button on the system
menu. This patch adds the necessary code to canPerformAction to enable
the button when appropriate as well as the implementation of the action
itself.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _reanalyze:]):
(-[WKContentView canPerformAction:withSender:]):

4:57 PM Changeset in webkit [168209] by akling@apple.com

18 edits
3 deletes in trunk/Source/WebCore

Remove HistogramSupport.
<https://webkit.org/b/132354>

Prune some leftover Chromium gunk that no other ports ever used.

Reviewed by Simon Fraser.

CMakeLists.txt:
Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::transaction):

Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::openInternal):
(WebCore::IDBFactory::deleteDatabase):

Modules/indexeddb/IDBHistograms.h: Removed.
Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:

(WebCore::IDBBackingStoreLevelDB::open):
(WebCore::IDBBackingStoreLevelDB::openInMemory):
(WebCore::recordInternalError): Deleted.

Modules/indexeddb/leveldb/IDBBackingStoreTransactionLevelDB.cpp:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
css/CSSParser.cpp:

(WebCore::cssPropertyID):

dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::histogramMutationEventUsage): Deleted.

dom/ShadowRoot.cpp:
fileapi/Blob.cpp:
fileapi/WebKitBlobBuilder.cpp:

(WebCore::BlobBuilder::append):

history/PageCache.cpp:

(WebCore::logCanCacheFrameDecision):
(WebCore::logCanCachePageDecision):

platform/HistogramSupport.cpp: Removed.
platform/HistogramSupport.h: Removed.
platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::open):
(WebCore::histogramLevelDBError): Deleted.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateNeedsCompositedScrolling):

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):

4:48 PM Changeset in webkit [168208] by matthew_hanson@apple.com

5 edits in branches/safari-537.76-branch/Source

Merge r167548.

4:38 PM Changeset in webkit [168207] by beidson@apple.com

2 edits in trunk/Source/WebCore

Stop flipping the ImageControlsButton
<rdar://problem/16773238> and https://bugs.webkit.org/show_bug.cgi?id=132502

Reviewed by Tim Horton.

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintImageControlsButton):

4:36 PM Changeset in webkit [168206] by enrica@apple.com

2 edits in trunk/Source/WebKit2

REGRESSION (WebKit2) Need to support transliterate chinese button (简⇄繁) for Traditional Chinese.
https://bugs.webkit.org/show_bug.cgi?id=132500
<rdar://problem/16778870>

Reviewed by Benjamin Poulain.

For traditional Chinese we support the transliterate to simplified Chinese.
This is done by pressing the 简⇄繁 button on the system
menu. This patch adds the necessary code to canPerformAction to enable
the button when appropriate as well as the implementation of the action
itself.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _transliterateChinese:]):
(-[WKContentView canPerformAction:withSender:]):

4:11 PM Changeset in webkit [168205] by commit-queue@webkit.org

8 edits in trunk/Source

Fullscreen UI does not appear after WebProcess has crashed
https://bugs.webkit.org/show_bug.cgi?id=132442

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-05-02
Reviewed by Darin Adler.

Source/WebCore:
Clean up immediately when there is a WebProcess crash.

WebCore.exp.in:
platform/ios/WebVideoFullscreenInterfaceAVKit.h:
platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::invalidate):
Clean-up resources immediately.

Source/WebKit2:
Cleanup WebVideoFullscreenManagerProxy after a WebProcess crash.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::reattachToWebProcess):
recreate WebVideoFullscreenManagerProxy after a WebProcess crash.

(WebKit::WebPageProxy::resetState):
invalidate and release WebVideoFullscreenManagerProxy on crash.

UIProcess/ios/WebVideoFullscreenManagerProxy.h:
UIProcess/ios/WebVideoFullscreenManagerProxy.mm:

(WebKit::WebVideoFullscreenManagerProxy::~WebVideoFullscreenManagerProxy):
don't assume m_page is valid.

(WebKit::WebVideoFullscreenManagerProxy::invalidate):
do cleanup invalidation in reponse to a WebProcess crash.

3:56 PM Changeset in webkit [168204] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r168192.
https://bugs.webkit.org/show_bug.cgi?id=132498

Was not the correct fix (blurry!) (Requested by bfulgham_ on
#webkit).

Reverted changeset:

"[iOS] deviceScaleFactor is being double-applied when
rendering captions in full screen mode"
https://bugs.webkit.org/show_bug.cgi?id=132481
http://trac.webkit.org/changeset/168192

3:54 PM Changeset in webkit [168203] by benjamin@webkit.org

2 edits in trunk/Source/WebKit2

[iOS][WK2] More animation madness for when the extendedBackground is modified in an animation block
https://bugs.webkit.org/show_bug.cgi?id=132497

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-05-02
Reviewed by Beth Dakin.

UIProcess/API/Cocoa/WKWebView.mm:

(updateTopAndBottomExtendedBackgroundExclusionIfNecessary):
Do not early return when _extendedBackgroundExclusionInsets.left is empty. That way, if executed in an animation block,
the top of bottom view will animate from their current size to an empty width.

When creating the layer, set up their height without animation. Otherwise it is possible to see the height animating
while the left inset is animating.

(-[WKWebView _setExtendedBackgroundExclusionInsets:]):
When replacing the scrollview, make sure the frame and color are not animated. Otherwise the transition between
scrollView and _mainExtendedBackgroundView can be visible if _setExtendedBackgroundExclusionInsets: is invoked
in an animation block.

(-[WKWebView _endAnimatedResize]):
Nuke the top and bottom insets when possible. [WKWebView _endAnimatedResize] is unfrequent, so it is a good opportunity
to free the memory.

3:47 PM Changeset in webkit [168202] by jeremyj-wk@apple.com

1 edit in trunk/Tools/ChangeLog

Add Jeremy Jones as a committer. https://bugs.webkit.org/show_bug.cgi?id=132492

3:41 PM Changeset in webkit [168201] by ap@apple.com

7 edits in trunk/Source

Remove Blob contentDisposition handling
https://bugs.webkit.org/show_bug.cgi?id=132490

Reviewed by Sam Weinig.

Source/WebCore:
Dead code.

platform/network/BlobData.h:

(WebCore::BlobData::contentDisposition): Deleted.
(WebCore::BlobData::setContentDisposition): Deleted.

platform/network/BlobRegistryImpl.cpp:

(WebCore::BlobRegistryImpl::registerBlobURL):
(WebCore::BlobRegistryImpl::registerBlobURLForSlice):

platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::notifyResponseOnSuccess):

platform/network/BlobStorageData.h:

(WebCore::BlobStorageData::create):
(WebCore::BlobStorageData::contentType):
(WebCore::BlobStorageData::BlobStorageData):
(WebCore::BlobStorageData::contentDisposition): Deleted.

Source/WebKit2:

Shared/FileAPI/BlobRegistrationData.cpp:

(WebKit::BlobRegistrationData::encode):
(WebKit::BlobRegistrationData::decode):

3:39 PM Changeset in webkit [168200] by matthew_hanson@apple.com

3 edits in branches/safari-537.76-branch/Source/JavaScriptCore

Merge r167544.

3:38 PM Changeset in webkit [168199] by andersca@apple.com

4 edits in trunk/Source/WebCore

Implement FormData decoding using KeyedDecoder
https://bugs.webkit.org/show_bug.cgi?id=132494

Reviewed by Tim Horton.

platform/KeyedCoding.h:

(WebCore::KeyedDecoder::decodeEnum):

platform/network/FormData.cpp:

(WebCore::decodeElement):
(WebCore::FormData::decode):

platform/network/FormData.h:

3:37 PM Changeset in webkit [168198] by commit-queue@webkit.org

2 edits in trunk/Tools

Add Jeremy as a committer.
https://bugs.webkit.org/show_bug.cgi?id=132492

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-05-02
Reviewed by Jer Noble.

Add Jeremy Jones to the committers file.

Scripts/webkitpy/common/config/contributors.json:

3:24 PM Changeset in webkit [168197] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

"arm64 function not 4-byte aligned" warnings when building JSC
https://bugs.webkit.org/show_bug.cgi?id=132495

Reviewed by Geoffrey Garen.

Added ".align 4" for both ARM Thumb2 and ARM 64 to silence the linker.

llint/LowLevelInterpreter.cpp:

3:05 PM Changeset in webkit [168196] by benjamin@webkit.org

2 edits in trunk/Source/WebKit2

[iOS][WK2] Adapt the rubberband constraints when the page get smaller than the scrollview - insets
https://bugs.webkit.org/show_bug.cgi?id=132457

Reviewed by Enrica Casucci.

It is quite common for us to have a WKContentView that is scalled smaller than the WKWebView, content
insets included.

In those cases, update the constraints to fit the content properly in the view.

UIProcess/ios/WKScrollView.mm:

(valuesAreWithinOnePixel):
(-[WKScrollView _rubberBandOffsetForOffset:maxOffset:minOffset:range:outside:]):

3:04 PM Changeset in webkit [168195] by mrowe@apple.com

2 edits in trunk/Source/WebKit2

-[_WKThumbnailView _requestSnapshotIfNeeded] assumes that taking a snapshot will always succeed
<https://webkit.org/b/132489> / <rdar://problem/16704660>

Reviewed by Tim Horton.

UIProcess/API/Cocoa/_WKThumbnailView.mm:

(-[_WKThumbnailView _requestSnapshotIfNeeded]): Don't attempt to create a CGImageRef if we failed
to create a ShareableBitmap. This handles both the callback receiving a null Handle and a failure
within ShareableBitmap::create.

2:58 PM Changeset in webkit [168194] by matthew_hanson@apple.com

2 edits in branches/safari-537.76-branch/Source/JavaScriptCore

Merge r167354.

2:43 PM Changeset in webkit [168193] by beidson@apple.com

4 edits in trunk/Source/WebKit/mac

Implement new delegate method -sharingService:sourceFrameOnScreenForShareItem:.
<rdar://problem/16797425> and https://bugs.webkit.org/show_bug.cgi?id=132484

Reviewed by Tim Horton.

Misc/WebSharingServicePickerController.mm:

(-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):

WebCoreSupport/WebContextMenuClient.h:
WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::screenRectForHitTestNode):

2:39 PM Changeset in webkit [168192] by Brent Fulgham

2 edits in trunk/Source/WebCore

[iOS] deviceScaleFactor is being double-applied when rendering captions in full screen mode
https://bugs.webkit.org/show_bug.cgi?id=132481

Reviewed by Jer Noble.

html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Don't set the platform scale factor here. It is already
being accounted for in the createTextTrackRepresentationImage method.

2:28 PM Changeset in webkit [168191] by matthew_hanson@apple.com

7 edits in branches/safari-537.76-branch/Source/JavaScriptCore

Merge r167336.

2:24 PM Changeset in webkit [168190] by Simon Fraser

12 edits in trunk

[iOS WK2] Don't create backing store for -webkit-overflow-scrolling:touch that can't scroll
https://bugs.webkit.org/show_bug.cgi?id=132487
<rdar://problem/16758041>

Reviewed by Sam Weinig.

Source/WebCore:

Previously, -webkit-overflow-scrolling:touch would cause us to make compositing
layers for any element that had overflow: auto or scroll on either axis. This
created lots of backing store when not required.

Improve this to only create compositing for scrolling when there is actually
scrollable overflow. This makes things slightly more complex, because we can
only know when layout is up to date.

rendering/RenderBox.cpp:

(WebCore::RenderBox::computeRectForRepaint): usesCompositedScrolling() tells
us if we're actually doing composited overflow.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hasTouchScrollableOverflow):
(WebCore::RenderLayer::handleTouchEvent):

rendering/RenderLayer.h:
rendering/RenderLayerBacking.cpp:

(WebCore::layerOrAncestorIsTransformedOrUsingCompositedScrolling):
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Only update
scrolling and clipping layers if layout is not pending.
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::updateScrollingLayers): The caller calls
updateInternalHierarchy(), so no need to do it here.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForScrolling): We
can only determine that we're scrollable after layout.
(WebCore::isStickyInAcceleratedScrollingLayerOrViewport):
(WebCore::isMainFrameScrollingOrOverflowScrolling):

LayoutTests:

These are all progressions, and show that we make layers in fewer cases.

platform/ios-sim/compositing/overflow/iframe-inside-overflow-clipping-expected.txt:
platform/ios-sim/compositing/overflow/overflow-auto-with-touch-no-overflow-expected.txt:
platform/ios-sim/compositing/overflow/overflow-overlay-with-touch-no-overflow-expected.txt:
platform/ios-sim/compositing/overflow/overflow-scroll-with-touch-no-overflow-expected.txt:
platform/ios-sim/compositing/overflow/subpixel-overflow-expected.txt:

2:21 PM Changeset in webkit [168189] by mhahnenberg@apple.com

2 edits in trunk/Source/JavaScriptCore

Fix cloop build after r168178

bytecode/CodeBlock.cpp:

2:03 PM Changeset in webkit [168188] by andersca@apple.com

10 edits in trunk/Source

Clean up FormDataElement
https://bugs.webkit.org/show_bug.cgi?id=132483

Reviewed by Sam Weinig.

Source/WebCore:

platform/network/FormData.cpp:

(WebCore::FormData::FormData):
(WebCore::FormData::deepCopy):
(WebCore::FormData::expandDataStore):
(WebCore::FormData::flatten):
(WebCore::FormData::resolveBlobReferences):
(WebCore::FormData::generateFiles):
(WebCore::FormData::hasGeneratedFiles):
(WebCore::FormData::hasOwnedGeneratedFiles):
(WebCore::FormData::removeGeneratedFilesIfNeeded):
(WebCore::encodeElement):
(WebCore::decodeElement):

platform/network/FormData.h:

(WebCore::FormDataElement::FormDataElement):
(WebCore::operator==):

platform/network/cf/FormDataStreamCFNet.cpp:

(WebCore::advanceCurrentStream):
(WebCore::setHTTPBody):

platform/network/curl/FormDataStreamCurl.cpp:

(WebCore::FormDataStream::read):

platform/network/curl/ResourceHandleManager.cpp:

(WebCore::setupFormData):

platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::addFormElementsToSoupMessage):

Source/WebKit2:

NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::NetworkResourceLoader):

Shared/Network/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::encode):

1:53 PM Changeset in webkit [168187] by commit-queue@webkit.org

13 edits
1 add
2 deletes in trunk/Source/ThirdParty/ANGLE

Update ANGLE Windows build.
https://bugs.webkit.org/show_bug.cgi?id=132456

Patch by Alex Christensen <achristensen@webkit.org> on 2014-05-02
Reviewed by Brent Fulgham.

ANGLE.vcxproj/libEGLCommon.props:
ANGLE.vcxproj/libGLESv2.vcxproj:
ANGLE.vcxproj/libGLESv2.vcxproj.filters:
ANGLE.vcxproj/libGLESv2Common.props:
ANGLE.vcxproj/translator_common.vcxproj:
ANGLE.vcxproj/translator_common.vcxproj.filters:
ANGLE.vcxproj/translator_glsl.vcxproj:
ANGLE.vcxproj/translator_glsl.vcxproj.filters:
ANGLE.vcxproj/translator_hlsl.vcxproj:
ANGLE.vcxproj/translator_hlsl.vcxproj.filters:

Updated ANGLE build.

src/ANGLE.sln: Removed.
src/build_angle.gyp: Removed.
src/commit.h: Added.
changes.diff:
src/libGLESv2/Program.cpp:

(gl::InfoLog::append):
Fixed typo.

1:03 PM Changeset in webkit [168186] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

[iOS] Wireless playback button not blue when active
https://bugs.webkit.org/show_bug.cgi?id=132473

Reviewed by Simon Fraser.

The playback button's class was being set to 'undefined', due to Controller.ClassNames.active being undefined.

Modules/mediacontrols/mediaControlsApple.js:

1:00 PM Changeset in webkit [168185] by beidson@apple.com

5 edits in trunk/Source/WebKit/mac

Crash inside [WebSharingServicePickerController clear]
<rdar://problem/16791944> and https://bugs.webkit.org/show_bug.cgi?id=132477

Reviewed by Tim Horton.

Misc/WebSharingServicePickerController.h:
Misc/WebSharingServicePickerController.mm:

(-[WebSharingServicePickerController clear]): clear can be called twice, so null check _menuClient.

WebCoreSupport/WebContextMenuClient.h:
WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::~WebContextMenuClient): For a sanity check, call clear on the picker here.

12:54 PM Changeset in webkit [168184] by Brian Burg

2 edits in trunk/Tools

Hard to figure out how to run a single test with run-api-tests
https://bugs.webkit.org/show_bug.cgi?id=116332

Reviewed by Alexey Proskuryakov.

Scripts/run-api-tests: add two examples to the help message.

12:43 PM Changeset in webkit [168183] by ap@apple.com

10 edits in trunk/Source/WebCore

Don't abuse Blob deserialization constructor in WebSocket
https://bugs.webkit.org/show_bug.cgi?id=132478

Reviewed by Sam Weinig.

Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::send):
(WebCore::WebSocketChannel::enqueueBlobFrame): This is the important change -
Blob::create was called for no reason. If the blob came from a worker, it was
already cloned for cross-thread messaging, otherwise there is no reason to make
a new one.

fileapi/Blob.h:

(WebCore::Blob::deserialize):
(WebCore::Blob::create): Deleted.

fileapi/File.h:

(WebCore::File::deserialize):
(WebCore::File::create): Deleted.
Renamed a special case of "create" function to avoid explaining what it is for.

Modules/websockets/ThreadableWebSocketChannel.h:
Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::send):

Modules/websockets/WebSocketChannel.h:
Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::send): Print a full URL in LOG(),
not one shortened to 1024 characters.
(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSendBlob):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):

Modules/websockets/WorkerThreadableWebSocketChannel.h:
bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::readFile):
(WebCore::CloneDeserializer::readTerminal):

12:42 PM Changeset in webkit [168182] by matthew_hanson@apple.com

2 edits in branches/safari-537.76-branch/Source/WebCore

Merge r165053.

12:34 PM Changeset in webkit [168181] by andersca@apple.com

5 edits in trunk/Source

Add and implement KeyedDecoder::decodeBytes
https://bugs.webkit.org/show_bug.cgi?id=132479

Reviewed by Tim Horton.

Source/WebCore:

platform/KeyedCoding.h:

(WebCore::KeyedDecoder::decodeBytes):

Source/WebKit2:

Shared/cf/KeyedDecoder.cpp:

(WebKit::KeyedDecoder::decodeBytes):

Shared/cf/KeyedDecoder.h:

12:28 PM Changeset in webkit [168180] by Joseph Pecoraro

20 edits
1 copy
1 add in trunk/Source

[iOS] WebKit2 File Upload Support
https://bugs.webkit.org/show_bug.cgi?id=132024

Reviewed by Enrica Casucci.

Source/WebCore:

English.lproj/Localizable.strings:

New localized strings for <input type="file"> on iOS.

Source/WebKit2:

Configurations/WebKit2.xcconfig:

Include MobileCoreServices on iOS for kUTTypeImage/kUTTypeMovie.

WebKit2.xcodeproj/project.pbxproj:

Add new files.

UIProcess/WebOpenPanelResultListenerProxy.h:
UIProcess/WebOpenPanelResultListenerProxy.cpp:

(WebKit::filePathsFromFileURLs):
(WebKit::WebOpenPanelResultListenerProxy::chooseFiles):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::runOpenPanel):
(WebKit::WebPageProxy::didChooseFilesForOpenPanelWithDisplayStringAndIcon):

WebProcess/WebPage/WebOpenPanelResultListener.h:
WebProcess/WebPage/WebOpenPanelResultListener.cpp:

(WebKit::WebOpenPanelResultListener::didChooseFilesWithDisplayStringAndIcon):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didChooseFilesForOpenPanelWithDisplayStringAndIcon):
Message forwarding for choosing files and providing a display string and icon,
leading down to the existing WebCore FileChooser method.

UIProcess/PageClient.h:
UIProcess/ios/PageClientImplIOS.h:
UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::handleRunOpenPanel):
Add a default handler for file open panel on iOS.
Forwards to the content view.

UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView lastInteractionLocation]):
(-[WKContentView _webTouchEventsRecognized:]):
(-[WKContentView _highlightLongPressRecognized:]):
(-[WKContentView _longPressRecognized:]):
(-[WKContentView _singleTapRecognized:]):
(-[WKContentView _doubleTapRecognized:]):
(-[WKContentView _twoFingerDoubleTapRecognized:]):
Keep track of the last interaction location. This matches previous behavior
of showing the file upload popover where the user tapped, to handle
cases where the <input> is hidden.

(-[WKContentView _showRunOpenPanel:resultListener:]):
(-[WKContentView fileUploadPanelDidDismiss:]):
Handle showing the cleaning up after the file upload panel.

UIProcess/ios/forms/WKFileUploadPanel.h:
UIProcess/ios/forms/WKFileUploadPanel.mm: Added.

(squareCropRectForSize):
(squareImage):
(thumbnailSizedImageForImage):
(-[_WKFileUploadItem isVideo]):
(-[_WKFileUploadItem fileURL]):
(-[_WKFileUploadItem displayImage]):
(-[_WKImageFileUploadItem initWithFilePath:originalImage:]):
(-[_WKImageFileUploadItem isVideo]):
(-[_WKImageFileUploadItem fileURL]):
(-[_WKImageFileUploadItem displayImage]):
(-[_WKVideoFileUploadItem initWithFilePath:mediaURL:]):
(-[_WKVideoFileUploadItem isVideo]):
(-[_WKVideoFileUploadItem fileURL]):
(-[_WKVideoFileUploadItem displayImage]):
Helper class for each image picker selection. Knows how to get
a file URL and thumbnail display image for the item.

(-[WKFileUploadPanel initWithView:]):
(-[WKFileUploadPanel dealloc]):
(-[WKFileUploadPanel _dispatchDidDismiss]):
(-[WKFileUploadPanel _cancel]):
(-[WKFileUploadPanel _chooseFiles:displayString:iconImage:]):
Lifetime of the upload panel requires that either cancel or choose
must happen as we go through the file picking process.

(-[WKFileUploadPanel presentWithParameters:WebKit::resultListener:WebKit::]):
(-[WKFileUploadPanel dismiss]):
API to show or dismiss the panel.

(-[WKFileUploadPanel _dismissDisplayAnimated:]):
Helper to clean up the UI as it progresses or completes no matter the device idiom.

(-[WKFileUploadPanel _presentPopoverWithContentViewController:animated:]):
(-[WKFileUploadPanel _presentFullscreenViewController:animated:]):
UI presentation for the appropriate idiom.

(-[WKFileUploadPanel _mediaTypesForPickerSourceType:]):
(-[WKFileUploadPanel _showMediaSourceSelectionSheet]):
(-[WKFileUploadPanel _showPhotoPickerWithSourceType:]):
Showing the action sheet or image picker.

(-[WKFileUploadPanel popoverControllerDidDismissPopover:]):
(-[WKFileUploadPanel _willMultipleSelectionDelegateBeCalled]):
(-[WKFileUploadPanel imagePickerController:didFinishPickingMediaWithInfo:]):
(-[WKFileUploadPanel imagePickerController:didFinishPickingMultipleMediaWithInfo:]):
(-[WKFileUploadPanel imagePickerControllerDidCancel:]):
Action sheet or image picker handlers.

(-[WKFileUploadPanel _processMediaInfoDictionaries:successBlock:failureBlock:]):
(-[WKFileUploadPanel _processMediaInfoDictionaries:atIndex:processedResults:processedImageCount:processedVideoCount:successBlock:failureBlock:]):
(-[WKFileUploadPanel _uploadItemFromMediaInfo:successBlock:failureBlock:]):
(-[WKFileUploadPanel _displayStringForPhotos:videos:]):
Processing selections from the image picker to FileUploadItems.

12:01 PM Changeset in webkit [168179] by andersca@apple.com

2 edits in trunk/Source/WebKit

Remove unsuccessful build fix attempts
https://bugs.webkit.org/show_bug.cgi?id=132476

Reviewed by Dan Bernstein.

WebKit.xcodeproj/project.pbxproj:

11:52 AM Changeset in webkit [168178] by mhahnenberg@apple.com

11 edits
2 adds in trunk/Source/JavaScriptCore

Add a DFG function whitelist
https://bugs.webkit.org/show_bug.cgi?id=132437

Reviewed by Geoffrey Garen.

Often times when debugging, using bytecode ranges isn't enough to narrow down to the
particular DFG block that's causing issues. This patch adds the ability to whitelist
specific functions specified in a file to enable further filtering without having to recompile.

CMakeLists.txt:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:
dfg/DFGCapabilities.cpp:

(JSC::DFG::isSupported):
(JSC::DFG::mightInlineFunctionForCall):
(JSC::DFG::mightInlineFunctionForClosureCall):
(JSC::DFG::mightInlineFunctionForConstruct):

dfg/DFGFunctionWhitelist.cpp: Added.

(JSC::DFG::FunctionWhitelist::ensureGlobalWhitelist):
(JSC::DFG::FunctionWhitelist::FunctionWhitelist):
(JSC::DFG::FunctionWhitelist::parseFunctionNamesInFile):
(JSC::DFG::FunctionWhitelist::contains):

dfg/DFGFunctionWhitelist.h: Added.
runtime/Options.cpp:

(JSC::parse):
(JSC::Options::dumpOption):

runtime/Options.h:

11:46 AM Changeset in webkit [168177] by Simon Fraser

4 edits in trunk/Tools

Fix several memory leaks found by code inspection
https://bugs.webkit.org/show_bug.cgi?id=132472

Reviewed by Geoffrey Garen.

Fix memory leaks.

TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:

(TestWebKitAPI::TEST):

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::willSendRequestForFrame):

WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::changeWindowScaleIfNeeded):

11:12 AM Changeset in webkit [168176] by matthew_hanson@apple.com

8 edits
3 copies in branches/safari-537.76-branch

Merge r164917.

10:29 AM Changeset in webkit [168175] by Simon Fraser

4 edits in trunk/Source/WebKit2

[iOS WK2] Animations on vox.com look wrong
https://bugs.webkit.org/show_bug.cgi?id=132462
<rdar://problem/16731884>

Reviewed by Sam Weinig.

PlatformCALayerRemote was managing animations incorrectly; aninations
would stick around in m_properties.addedAnimations and get added a second
time by mistake.

Animations have to be managed a little differently to other properties,
since they are not steady-state things. A given commit has to send over
the added and removed animations, and then clear the layer properties.

Do this by adding PlatformCALayerRemote::didCommit(), which is called
after the layer properties have been encoded, and have it clear the lists
of added and removed animations.

removeAnimationForKey() also has to remove the animation from addedAnimations
so that an add/remove in the same commit doesn't send the animation to the
UI process.

WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::recursiveBuildTransaction):
(WebKit::PlatformCALayerRemote::didCommit):
(WebKit::PlatformCALayerRemote::removeAnimationForKey):

WebProcess/WebPage/mac/PlatformCALayerRemote.h:
WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::flushLayers):

10:29 AM Changeset in webkit [168174] by Simon Fraser

2 edits in trunk/Source/WebKit2

[iOS WK2] Can't scroll on gatesnotes.com
https://bugs.webkit.org/show_bug.cgi?id=132459
<rdar://problem/16770909>

Reviewed by Benjamin Poulain.

The custom UIView hit-testing code was finding views that were created by
the compositing code for clipping, above the UIScrollViews. We only ever
need to find UIScrollViews here for touch overflow-scrolling, so constrain
the hit-testing code to only return UIScrollViews.

UIProcess/ios/RemoteLayerTreeHostIOS.mm:

(-[UIView _recursiveFindDescendantScrollViewAtPoint:withEvent:]):
(-[UIView _findDescendantViewAtPoint:withEvent:]):
(-[UIView _recursiveFindDescendantViewAtPoint:withEvent:]): Deleted.

10:27 AM Changeset in webkit [168173] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

Unreviewed, rolling out r168150.
https://bugs.webkit.org/show_bug.cgi?id=132471

This test is still broken (Requested by ap on #webkit).

Reverted changeset:

"REGRESSION(r125251): It made svg/custom/use-instanceRoot-as-
event-target.xhtml assert and flakey"
https://bugs.webkit.org/show_bug.cgi?id=93812
http://trac.webkit.org/changeset/168150

10:23 AM Changeset in webkit [168172] by fpizlo@apple.com

5 edits
6 adds in trunk

DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
https://bugs.webkit.org/show_bug.cgi?id=132446

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:
Basically any arithmetic operation can turn an Int52 into an Int32 or vice-versa, and
our modeling of Int52Rep nodes is such that they can have either Int32 or Int52 type
to indicate a bound on the value. This is useful for knowing, for example, that
Int52Rep(Int32:) returns a value that cannot be outside the Int32 range. Also,
ValueRep(Int52Rep:) uses this to determine whether it may return a double or an int.
But this means that all arithmetic operations must be careful to note that they may
turn Int32 inputs into an Int52 output or vice-versa, as these new tests show.

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::makeSafe):

tests/stress/int52-ai-add-then-filter-int32.js: Added.

(foo):

tests/stress/int52-ai-mul-and-clean-neg-zero-then-filter-int32.js: Added.

(foo):

tests/stress/int52-ai-mul-then-filter-int32-directly.js: Added.

(foo):

tests/stress/int52-ai-mul-then-filter-int32.js: Added.

(foo):

tests/stress/int52-ai-neg-then-filter-int32.js: Added.

(foo):

tests/stress/int52-ai-sub-then-filter-int32.js: Added.

(foo):

Tools:
Test the FTL by default now that it's enabled by default.

Scripts/run-javascriptcore-tests:

9:19 AM Changeset in webkit [168171] by Chris Fleizach

5 edits in trunk/Source/WebCore

AX: WK2: iOS web page scrolling doesn't work with VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=132028

Reviewed by Mario Sanchez Prada.

With the AX tree residing in the WebProcess, scrolling needs to be implemented in
WebCore using accessibilityScroll: in order for accessibility clients to scroll through the AX API.

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::scrollViewAncestor):
(WebCore::AccessibilityObject::scrollToMakeVisibleWithSubFocus):

accessibility/AccessibilityObject.h:
accessibility/ios/WebAccessibilityObjectWrapperIOS.h:
accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper _accessibilityConvertPointToViewSpace:]):
(-[WebAccessibilityObjectWrapper _accessibilityScrollToVisible]):
(-[WebAccessibilityObjectWrapper accessibilityScroll:]):
(-[WebAccessibilityObjectWrapper postScrollStatusChangeNotification]):
(-[WebAccessibilityObjectWrapper _accessibilityScrollPosition]):
(-[WebAccessibilityObjectWrapper _accessibilityScrollSize]):
(-[WebAccessibilityObjectWrapper _accessibilityScrollVisibleRect]):

9:04 AM Changeset in webkit [168170] by commit-queue@webkit.org

9 edits in trunk/Source/WebInspectorUI

Web Inspector: CodeMirror 4 CSS mode new state data structure breaks helpers.
https://bugs.webkit.org/show_bug.cgi?id=132149

Patch by Jono Wells <jonowells@apple.com> on 2014-05-02
Reviewed by Joseph Pecoraro.

The update to CodeMirror 4 included dramatic changes to the CSS mode,
particularly the way it handles tokens. state.stack is gone, replaced
by state.context.

Tools/PrettyPrinting/CodeMirrorFormatters.js:
Tools/PrettyPrinting/codemirror.js:
UserInterface/External/CodeMirror/codemirror.js:
UserInterface/External/CodeMirror/livescript.js:
UserInterface/External/CodeMirror/runmode.js:

Updates from ToT CodeMirror.

UserInterface/Controllers/CodeMirrorCompletionController.js:

(WebInspector.CodeMirrorCompletionController.prototype._generateCSSCompletions):

UserInterface/Views/CodeMirrorAdditions.js:
UserInterface/Views/CodeMirrorFormatters.js: lastToken is null now for ":" characters.

Changes to match structural changes to the state object and changes to expected values of lastToken.

6:52 AM Changeset in webkit [168169] by jeremyj@apple.com

3 edits in trunk/Source/WebCore

Pause playback on exit fullscreen when inline playback not allowed.
https://bugs.webkit.org/show_bug.cgi?id=132450

Reviewed by Jer Noble.

Use correct method of determining if inline playback is allowed.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):
Use m_mediaSession->requiresFullscreenForVideoPlayback to detect if inline playback is allowed.

platform/ios/WebVideoFullscreenModelMediaElement.mm:

(WebVideoFullscreenModelMediaElement::requestExitFullscreen):
Prevent duplicate exit requests.

5:03 AM Changeset in webkit [168168] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

REGRESSION(r168118): [GTK] build broken due to shouldTrackVisitedLinks
https://bugs.webkit.org/show_bug.cgi?id=132447

Unreviewed GTK build fix.

shouldTrackVisitedLinks was removed on r168118.
Visited link coloring works as expected after this change.

Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-05-02

UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformInitializeWebProcess): Remove
shouldTrackVisitedLinks parameter.

2:35 AM Changeset in webkit [168167] by commit-queue@webkit.org

33 edits in trunk

[CSS Blending] Remove support for non-separable blend modes from background-blend-mode
https://bugs.webkit.org/show_bug.cgi?id=132327

Patch by Ion Rosca <Ion Rosca> on 2014-05-02
Reviewed by Dean Jackson.

Source/WebCore:
Removed support for non-separable background blend modes from the CSS parser.
Covered by existing tests.

css/CSSParser.cpp:

(WebCore::CSSParser::parseFillProperty):

LayoutTests:

css3/compositing/background-blend-mode-gif-color-2.html:
css3/compositing/background-blend-mode-gif-color.html:
css3/compositing/background-blend-mode-gradient-color.html:
css3/compositing/background-blend-mode-gradient-gradient.html:
css3/compositing/background-blend-mode-gradient-image.html:
css3/compositing/background-blend-mode-image-color.html:
css3/compositing/background-blend-mode-image-image.html:
css3/compositing/background-blend-mode-image-svg.html:
css3/compositing/background-blend-mode-multiple-background-layers.html:
css3/compositing/background-blend-mode-property-expected.txt:
css3/compositing/background-blend-mode-property-parsing-expected.txt:
css3/compositing/background-blend-mode-svg-color.html:
css3/compositing/effect-background-blend-mode-tiled.html:
css3/compositing/effect-background-blend-mode.html:
css3/compositing/script-tests/background-blend-mode-property-parsing.js:
css3/compositing/script-tests/background-blend-mode-property.js:
platform/mac/css3/compositing/background-blend-mode-gif-color-2-expected.png:
platform/mac/css3/compositing/background-blend-mode-gif-color-2-expected.txt:
platform/mac/css3/compositing/background-blend-mode-gif-color-expected.png:
platform/mac/css3/compositing/background-blend-mode-gif-color-expected.txt:
platform/mac/css3/compositing/background-blend-mode-gradient-color-expected.png:
platform/mac/css3/compositing/background-blend-mode-gradient-gradient-expected.png:
platform/mac/css3/compositing/background-blend-mode-gradient-image-expected.png:
platform/mac/css3/compositing/background-blend-mode-image-color-expected.png:
platform/mac/css3/compositing/background-blend-mode-image-color-expected.txt:
platform/mac/css3/compositing/background-blend-mode-image-image-expected.png:
platform/mac/css3/compositing/background-blend-mode-image-image-expected.txt:
platform/mac/css3/compositing/background-blend-mode-image-svg-expected.png:
platform/mac/css3/compositing/background-blend-mode-multiple-background-layers-expected.png:
platform/mac/css3/compositing/background-blend-mode-svg-color-expected.png:

1:59 AM Changeset in webkit [168166] by gyuyoung.kim@samsung.com