Timeline
May 7, 2014:
- 10:42 PM Changeset in webkit [168462] by
-
- 10 edits12 adds in trunk
[CSS Blending] Blending doesn't work if the parent stacking context is not a self painting layer
https://bugs.webkit.org/show_bug.cgi?id=130891
Patch by Ion Rosca <Ion Rosca> on 2014-05-07
Reviewed by Dean Jackson.
Source/WebCore:
The stacking context layers having unisolated blending descendants should be able
to create transparency layers or to become composited in order to restrict blending
content to accessing the information outside the current stacking context.
Some layers are not self painting layers and these layers cannot crate transparency
layers and cannot be composited, thus they are not able to isolate blending descendants
when it's required.
The solution in this patch is to make a layer isSelfPaintingLayer when
it needs to isolate blending descendants (hasUnisolatedBlendingDescendants).
Tests: css3/blending/blend-mode-isolation-accelerated-overflow-hidden.html
css3/blending/blend-mode-isolation-overflow-hidden.html
css3/blending/blend-mode-isolation-turn-off-self-painting-layer.html
css3/blending/blend-mode-isolation-turn-off-self-painting-layer1.html
css3/blending/blend-mode-isolation-turn-off-self-painting-layer2.html
css3/blending/blend-mode-isolation-turn-on-self-painting-layer.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateAncestorChainHasBlendingDescendants):
When hasUnisolatedBlendingDescendants is set we make sure that isSelfPaintingLayer flag is set too.
(WebCore::RenderLayer::updateDescendantDependentFlags):
The flags might be read or changed while walking the descendants, so we don't want to reset
them before traversing the tree.
(WebCore::RenderLayer::shouldBeSelfPaintingLayer):
Adding isolatesBlending() condition for a layer to be self painting.
- rendering/RenderLayer.h:
Removing ASSERT from hasUnisolatedBlendingDescendants(). It crashes in minibrowser
and in layout tests when painting contents. Similar bugs on other flags: #71044, #71277.
- rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::styleDidChange):
Telling ancestors that blend mode property has been removed from CSS when the layer for
this element is going to be removed; styleChanged will not be called anymore.
LayoutTests:
Removed position:relative which forced tests to avoid this bug.
- css3/blending/blend-mode-accelerated-parent-overflow-hidden.html:
- css3/blending/blend-mode-clip-accelerated-blending-canvas.html:
- css3/blending/blend-mode-clip-accelerated-blending-child.html:
- css3/blending/blend-mode-clip-accelerated-blending-with-siblings.html:
- css3/blending/blend-mode-clip-accelerated-transformed-blending.html:
New tests:
- css3/blending/blend-mode-isolation-accelerated-overflow-hidden-expected.txt: Added.
- css3/blending/blend-mode-isolation-accelerated-overflow-hidden.html: Added.
- css3/blending/blend-mode-isolation-overflow-hidden-expected.html: Added.
- css3/blending/blend-mode-isolation-overflow-hidden.html: Added.
- css3/blending/blend-mode-isolation-turn-off-self-painting-layer-expected.txt: Added.
- css3/blending/blend-mode-isolation-turn-off-self-painting-layer.html: Added.
- css3/blending/blend-mode-isolation-turn-off-self-painting-layer1-expected.txt: Added.
- css3/blending/blend-mode-isolation-turn-off-self-painting-layer1.html: Added.
- css3/blending/blend-mode-isolation-turn-off-self-painting-layer2-expected.txt: Added.
- css3/blending/blend-mode-isolation-turn-off-self-painting-layer2.html: Added.
- css3/blending/blend-mode-isolation-turn-on-self-painting-layer-expected.txt: Added.
- css3/blending/blend-mode-isolation-turn-on-self-painting-layer.html: Added.
- 9:10 PM Changeset in webkit [168461] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r168451.
https://bugs.webkit.org/show_bug.cgi?id=132670
Not a speed-up, just do what other compilers do. (Requested by
kling on #webkit).
Reverted changeset:
"[X86] Emit BT instruction for single-bit tests."
https://bugs.webkit.org/show_bug.cgi?id=132650
http://trac.webkit.org/changeset/168451
- 7:51 PM Changeset in webkit [168460] by
-
- 4 edits2 adds in trunk
Dragging text from one paragraph to another does not render as expected
https://bugs.webkit.org/show_bug.cgi?id=132633
Reviewed by Darin Adler and Ryosuke Niwa.
Source/WebCore:
When we are dragging and dropping into a content editable field, we detect
if we are trying to put a <p> into an existing <p>, and if so, split the
outer <p> and insert the new <p> as its sibling. However, the outer <p>
might not be editable, so we don't want to do any splitting and inserting
at that location.
Test: editing/pasteboard/drag-drop-paragraph-crasher.html
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::makeInsertedContentRoundTrippableWithHTMLTreeBuilder):
LayoutTests:
The problem occurs when dragging text that includes a <p> into an editable
area that has a <p> as a parent.
- editing/pasteboard/drag-drop-paragraph-crasher-expected.txt: Added.
- editing/pasteboard/drag-drop-paragraph-crasher.html: Added.
- 7:35 PM Changeset in webkit [168459] by
-
- 10 edits in trunk/Source
Source/JavaScriptCore: Make Executable::clearCode() actually clear all of the entrypoints, and
clean up some other FTL-related calling convention stuff.
<rdar://problem/16720172>
Rubber stamped by Mark Hahnenberg.
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGWorklist.cpp:
(JSC::DFG::Worklist::Worklist):
(JSC::DFG::Worklist::finishCreation):
(JSC::DFG::Worklist::create):
(JSC::DFG::ensureGlobalDFGWorklist):
(JSC::DFG::ensureGlobalFTLWorklist):
- dfg/DFGWorklist.h:
- heap/CodeBlockSet.cpp:
(JSC::CodeBlockSet::dump):
- heap/CodeBlockSet.h:
- runtime/Executable.cpp:
(JSC::ExecutableBase::clearCode):
Source/WTF: UNREACHABLE_FOR_PLATFORM() is meant to be a release crash.
Rubber stamped by Mark Hahnenberg..
- wtf/Assertions.h:
(UNREACHABLE_FOR_PLATFORM):
- 6:42 PM Changeset in webkit [168458] by
-
- 7 edits3 adds in trunk
[CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
https://bugs.webkit.org/show_bug.cgi?id=126022
Reviewed by Benjamin Poulain.
Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.
Source/WebCore:
When user is navigating back/forward to a page that has been scrolled and/or scaled, that page must be shown
with its last scroll position and scale factor. However, when fixed layout was enabled with CoordinatedGraphics
and TILED_BACKING_STORE, Page::setPageScaleFactor() doesn't send previous scroll position since r165652 and r165913.
This patch allows the Page::setPageScaleFactor() send stored position to WK2 implementation by calling delegatedScrollRequested()
directly when delegatesScrolling() is on.
- page/Page.cpp:
(WebCore::Page::setPageScaleFactor): TILED_BACKING_STORE and delegateScrolling are enabled, we pass new scroll position to WK2 though
delegateScrolling is disabled.
- platform/ScrollView.cpp: delegatedScrollRequested() call is moved from ScrollView::setScrollPosition() to Page::setPageScaleFactor().
(WebCore::ScrollView::setScrollPosition):
Source/WebKit2:
When user is navigating back/forward to a page that has been scrolled and/or scaled, that page must be shown
with its last scroll position and scale factor. However, when fixed layout was enabled with CoordinatedGraphics
and TILED_BACKING_STORE, Page::setPageScaleFactor() doesn't send previous scroll position since r165652 and r165913.
This patch allows the Page::setPageScaleFactor() send stored position to WK2 implementation.
- UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::didCommitLoadForMainFrame):
Tools:
Added an unit test case to check if scroll position and scale are restored properly.
- TestWebKitAPI/PlatformEfl.cmake:
- TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::didChangeContentsPosition):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
- TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.
- 6:30 PM Changeset in webkit [168457] by
-
- 3 edits2 adds in trunk
Using a fill pattern much larger than actual canvas reliably segfaults browser
https://bugs.webkit.org/show_bug.cgi?id=132635
Reviewed by Simon Fraser.
Source/WebCore:
Make sure that createPattern checks that the canvas it is about to use
as a source is valid.
Test: fast/canvas/pattern-too-large-to-create.html
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createPattern): Check that the source canvas has
an ok ImageBuffer.
LayoutTests:
Test case that makes a huge canvas and tries to create a pattern out of it.
- fast/canvas/pattern-too-large-to-create-expected.html: Added.
- fast/canvas/pattern-too-large-to-create.html: Added.
- 6:16 PM Changeset in webkit [168456] by
-
- 2 edits in trunk/Source/WebKit2
Put a better version of the assertion back, and add one when we ensureBackingStore.
Reviewed by Tim Horton.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::recursiveBuildTransaction):
(WebKit::PlatformCALayerRemote::ensureBackingStore):
- 5:48 PM Changeset in webkit [168455] by
-
- 2 edits in trunk/Source/WebKit2
This assertion was wrong and fired every time. Remove it.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::recursiveBuildTransaction):
- 5:20 PM Changeset in webkit [168454] by
-
- 2 edits in trunk/Source/WebKit
[Win] Unreviewed 64-bit build fix.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add
correct 64-bit symbol definitions.
- 5:07 PM Changeset in webkit [168453] by
-
- 3 edits in trunk/LayoutTests
REGRESSION (r161429?): Frequent crashes on media/track/media-element-enqueue-event-crash.html
https://bugs.webkit.org/show_bug.cgi?id=117756
Reviewed by Mark Hahnenberg.
Re-enabled this test because it doesn't seem to crash anymore.
- media/track/media-element-enqueue-event-crash.html: Reduced the number
of test runs because otherwise this test often times out.
- platform/mac/TestExpectations: Re-enable this test because I ran it
for about a minute on my Mac Pro without crashing.
- 4:28 PM Changeset in webkit [168452] by
-
- 7 edits in trunk/Source
Use system defaults for hardware jpeg decoding
https://bugs.webkit.org/show_bug.cgi?id=132661
<rdar://problem/11348201>
Reviewed by Tim Horton.
Remove code that explicitly disabled hardware image decoding. Let the system decide what to do.
Source/WebCore:
- WebCore.exp.in:
- platform/graphics/ImageSource.h:
(WebCore::ImageSource::acceleratedImageDecodingEnabled): Deleted.
(WebCore::ImageSource::setAcceleratedImageDecodingEnabled): Deleted.
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::imageSourceOptions):
Source/WebKit/mac:
- WebView/WebView.mm:
(+[WebView _setAcceleratedImageDecoding:]):
(+[WebView _acceleratedImageDecoding]): Deleted.
- WebView/WebViewPrivate.h:
- 4:22 PM Changeset in webkit [168451] by
-
- 3 edits in trunk/Source/JavaScriptCore
[X86] Emit BT instruction for single-bit tests.
<https://webkit.org/b/132650>
Implement test-bit-and-branch slightly more efficiently by using
BT + JC/JNC instead of TEST + JZ/JNZ when we're only testing for
a single bit.
Reviewed by Michael Saboff.
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::singleBitIndex):
(JSC::MacroAssemblerX86Common::branchTest32):
- assembler/X86Assembler.h:
(JSC::X86Assembler::bt_i8r):
(JSC::X86Assembler::bt_i8m):
- 4:06 PM Changeset in webkit [168450] by
-
- 1 copy in tags/Safari-537.76.3
New Tag.
- 4:02 PM Changeset in webkit [168449] by
-
- 2 edits in branches/safari-537.76-branch/LayoutTests/fast/forms
Remove unneccessary newline from layout tests.
- 3:48 PM Changeset in webkit [168448] by
-
- 6 edits2 adds in trunk
Use after free in WebCore::RenderObject::nextSibling / WebCore::RenderBoxModelObject::moveChildrenTo
https://bugs.webkit.org/show_bug.cgi?id=132625
Reviewed by David Hyatt.
Source/WebCore:
Fixed problem with dynamically inserting first letter elements.
Test: fast/multicol/newmulticol/first-letter-create.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::getFirstLetter):
(WebCore::RenderBlock::updateFirstLetter):
- rendering/RenderBlock.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::moveChildrenTo):
LayoutTests:
Added test for special case which might cause use after free.
- fast/multicol/newmulticol/first-letter-create-expected.html: Added.
- fast/multicol/newmulticol/first-letter-create.html: Added.
- 3:42 PM Changeset in webkit [168447] by
-
- 7 edits in trunk/Source
WK2: Programatic scroll requests during scroll or zoom animation to reveal focused element are ignored.
https://bugs.webkit.org/show_bug.cgi?id=132657
<rdar://problem/16468462>
Reviewed by Benjamin Poulain.
With the scrolling model we use on iOS, a programatic scroll
request can be received while we are still animating to reveal
Source/WebCore:
the focused input element. The WebProcess is unaware that the
scroll position is being changed in the UIProcess, and does not
honor the scroll request from JavaScript.
This is patch changes the behavior for clients using scroll delegates
to always send the scroll request to the UIProcess without checking
the current scroll position.
- page/FrameView.h:
- platform/ScrollView.cpp:
(WebCore::ScrollView::setScrollPosition):
- platform/ScrollView.h:
(WebCore::ScrollView::inProgrammaticScroll):
Source/WebKit2:
the focused input element. Changing the scroll offset while animating
leads to unpredictable results. We now cancel the animation if
a programatic scroll request is received.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _scrollToContentOffset:WebCore::]):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getAssistedNodeInformation):
- 3:15 PM Changeset in webkit [168446] by
-
- 5 edits in tags/Safari-538.34/Source/WebCore
Merged r168440.
- 3:15 PM Changeset in webkit [168445] by
-
- 2 edits in trunk/Source/WebKit2
[iOS WK2] Speculative fix for crash in PlatformCALayerRemote::recursiveBuildTransaction
https://bugs.webkit.org/show_bug.cgi?id=132666
Reviewed by Tim Horton.
Crash reports suggest that owner() can be null. Assert and protect
against this.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::recursiveBuildTransaction):
- 3:00 PM Changeset in webkit [168444] by
-
- 1 edit4 adds in branches/safari-537.76-branch/LayoutTests
Add layout tests that were not merged with r168098.
- 3:00 PM Changeset in webkit [168443] by
-
- 26 edits1 add in trunk/Source/JavaScriptCore
REGRESSION(r166678): Dromaeo/cssquery-dojo.html crashes regularly.
<https://webkit.org/b/131356>
Reviewed by Geoffrey Garen.
The issue is that GC needs to be made aware of writes to m_inferredValue
in the VariableWatchpointSet, but was not. As a result, if a JSCell*
is written to a VariableWatchpointSet m_inferredValue, and that JSCell
does not survive an eden GC shortly after, we will end up with a stale
JSCell pointer left in the m_inferredValue.
This issue can be detected more easily by running Dromaeo/cssquery-dojo.html
using DumpRenderTree with the VM heap in zombie mode.
The fix is to change VariableWatchpointSet m_inferredValue to type
WriteBarrier<Unknown> and ensure that VariableWatchpointSet::notifyWrite()
is executed by all the execution engines so that the WriteBarrier semantics
are honored.
We still check if the value to be written is the same as the one in the
inferredValue. We'll by-pass calling the slow path notifyWrite() if the
values are the same.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
- need to pass the symbolTable to prepareToWatch() because it will be needed for instantiating the VariableWatchpointSet in prepareToWatch().
- bytecode/VariableWatchpointSet.h:
(JSC::VariableWatchpointSet::VariableWatchpointSet):
- VariableWatchpointSet now tracks its owner symbol table for its m_inferredValue write barrier, and yes, m_inferredValue is now of type WriteBarrier<Unknown>.
(JSC::VariableWatchpointSet::inferredValue):
(JSC::VariableWatchpointSet::invalidate):
(JSC::VariableWatchpointSet::finalizeUnconditionally):
(JSC::VariableWatchpointSet::addressOfInferredValue):
(JSC::VariableWatchpointSet::notifyWrite): Deleted.
- bytecode/VariableWatchpointSetInlines.h: Added.
(JSC::VariableWatchpointSet::notifyWrite):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::cellConstant):
- Added an assert in case we try to make constants of zombified JSCells again.
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- We now let the slow path handle the cases when the VariableWatchpointSet is in state ClearWatchpoint and IsWatched, and the slow path will ensure that we handle the needed write barrier semantics correctly. We will by-pass the slow path if the value being written is the same as the inferred value.
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNotifyWrite):
- Let the slow path handle the cases when the VariableWatchpointSet is in state ClearWatchpoint and IsWatched. We will by-pass the slow path if the value being written is the same as the inferred value.
- heap/Heap.cpp:
(JSC::Zombify::operator()):
- Use a different value for the zombified bits (to distinguish it from 0xbbadbeef which is used everywhere else).
- heap/Heap.h:
(JSC::Heap::isZombified):
- Provide a convenience test function to check if JSCells are zombified. This is currently only used in an assertion in the DFG bytecode parser, but the intent it that we'll apply this test in other strategic places later to help with early detection of usage of GC'ed objects when we run in zombie mode.
- jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_captured_mov):
- jit/JITOperations.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitNotifyWrite):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitNotifyWrite):
(JSC::JIT::emitSlow_op_put_to_scope):
- Let the slow path for notifyWrite handle the cases when the VariableWatchpointSet is in state ClearWatchpoint and IsWatched. We will by-pass the slow path if the value being written is the same as the inferred value.
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- Let the slow path for notifyWrite handle the cases when the VariableWatchpointSet is in state ClearWatchpoint and IsWatched. We will by-pass the slow path if the value being written is the same as the inferred value.
- runtime/CommonSlowPaths.cpp:
- runtime/JSCJSValue.h: Fixed some typos in the comments.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::addGlobalVar):
(JSC::JSGlobalObject::addFunction):
- runtime/JSSymbolTableObject.h:
(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes):
- runtime/SymbolTable.cpp:
(JSC::SymbolTableEntry::prepareToWatch):
(JSC::SymbolTableEntry::notifyWriteSlow):
- runtime/SymbolTable.h:
(JSC::SymbolTableEntry::notifyWrite):
- 2:59 PM Changeset in webkit [168442] by
-
- 15 edits2 adds in trunk/Source
[Mac, iOS] REGRESSION: WK2 YouTube support
https://bugs.webkit.org/show_bug.cgi?id=132568
<rdar://problem/11464344>
Reviewed by Darin Adler.
Source/WebCore:
Move the custom YouTube loader code out of the WebFrameLoaderClient into a
PluginReplacement-based class.
- Modules/plugins/PluginReplacement.h:
(WebCore::PluginReplacement::supportsURL): New predicate so we can restrict
use of a plugin to a particular category of URLs.
- Modules/plugins/QuickTimePluginReplacement.mm:
(WebCore::QuickTimePluginReplacement): Updated for new registrar signature.
- Modules/plugins/YouTubePluginReplacement.h: Added.
(WebCore::YouTubePluginReplacement::parentElement):
- Modules/plugins/YouTubePluginReplacement.cpp: Added.
(WebCore::YouTubePluginReplacement::registerPluginReplacement):
(WebCore::YouTubePluginReplacement::create):
(WebCore::YouTubePluginReplacement::supportsMimeType):
(WebCore::YouTubePluginReplacement::supportsFileExtension):
(WebCore::kit):
(WebCore::YouTubePluginReplacement::YouTubePluginReplacement):
(WebCore::YouTubePluginReplacement::createElementRenderer):
(WebCore::objectForKey):
(WebCore::YouTubePluginReplacement::installReplacement):
(WebCore::createYouTubeURL):
(WebCore::processAndCreateYouTubeURL):
(WebCore::YouTubePluginReplacement::youTubeURL):
- WebCore.exp.in: Add new export from WebCore.
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLPlugInElement.cpp:
(WebCore::pluginReplacementForType): Update to also check that the URL is supported
by the plugin.
(WebCore::registeredPluginReplacements): Add new YouTubePluginReplacement to registry.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::createElementRenderer): Remove custom YouTube code
now that this logic is handled in the plugin replacement class.
(WebCore::HTMLPlugInImageElement::createShadowIFrameSubtree): Deleted.
- html/HTMLPlugInImageElement.h:
- html/shadow/YouTubeEmbedShadowElement.cpp:
(WebCore::YouTubeEmbedShadowElement::YouTubeEmbedShadowElement):
(WebCore::YouTubeEmbedShadowElement::shadowPseudoId): Use correct pseudoID for the
plugin replacement architecture.
- html/shadow/YouTubeEmbedShadowElement.h:
- platform/mac/WebCoreNSURLExtras.h:
- platform/mac/WebCoreNSURLExtras.mm:
(WebCore::unescapedQueryValue): Moved from WebKit/Misc/WebNSURLExtras.
(WebCore::queryKeysAndValues): Ditto.
Source/WebKit/mac:
- Misc/WebNSURLExtras.h:
- Misc/WebNSURLExtras.mm: Remove code that has been converted to C++
and added to YouTubePluginReplacement.cpp.
(-[NSURL _webkit_youTubeURL]):
(-[NSString _webkit_queryKeysAndValues]):
(createYouTubeURL): Deleted.
(-[NSString _webkit_unescapedQueryValue]): Deleted.
- 2:57 PM Changeset in webkit [168441] by
-
- 3 edits in trunk/Source/WebKit2
<rdar://problem/16831276> [iOS] Unparenting a WKWebView that’s loading pauses it
https://bugs.webkit.org/show_bug.cgi?id=132659
Reviewed by Tim Horton.
- UIProcess/Cocoa/NavigationState.h: Added a member variable.
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::didChangeIsLoading): When transitioning into loading state,
acquire a background activity token. When transitioning out of loading state, dispose of
the token.
- 2:49 PM Changeset in webkit [168440] by
-
- 5 edits in trunk/Source/WebCore
[iOS] Acclerated overflow-scrolling broken in WK1
https://bugs.webkit.org/show_bug.cgi?id=132665
<rdar://problem/16842909>
Reviewed by Tim Horton.
r168301 added a CALayer delegate to disable implicit animations,
but for some layers we wrap them in UIViews (which are themselves
layer delegates), so bad things happened.
Fix by falling back to setting the null actions dictionary for
layers with custom scrolling behavior.
- platform/graphics/GraphicsLayer.h:
- platform/graphics/ca/mac/PlatformCALayerMac.h:
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::updateCustomBehavior):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateScrollingLayers):
- 2:19 PM Changeset in webkit [168439] by
-
- 9 edits in trunk/Source
HTMLMediaElement should exitFullscreen when view is removed from the window.
https://bugs.webkit.org/show_bug.cgi?id=132506
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-05-07
Reviewed by Tim Horton.
Source/WebCore:
- platform/ios/WebVideoFullscreenControllerAVKit.h:
Add -requestExitFullscreen.
- platform/ios/WebVideoFullscreenControllerAVKit.mm:
(-[WebVideoFullscreenController requestExitFullscreen]):
Forward request onto WebVideoFullscreenModelMediaElement.
- platform/ios/WebVideoFullscreenModelMediaElement.mm:
(WebVideoFullscreenModelMediaElement::requestExitFullscreen):
Add some protection here since this may be called when not in fullscreen.
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView viewDidMoveToWindow]):
Request WebVideoFullscreenController to exitFullscreen when view is removed from the window.
Source/WebKit2:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewStateDidChange):
Request WebVideoFUllscreenManagerProxy to exitFullscreen when removed from the window.
- UIProcess/ios/WebVideoFullscreenManagerProxy.h:
Make requestExitFullscreen() public instead of private.
- 2:17 PM Changeset in webkit [168438] by
-
- 2 edits in trunk/Source/WebKit/mac
Image menu is offset by the amount the view is scrolled
<rdar://problem/16818966> and https://bugs.webkit.org/show_bug.cgi?id=132663
Reviewed by Tim Horton.
- WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::showContextMenu): Use FrameView::contentsToWindow instead of contentsToRoot,
and skip the [NSView convertPoint:toView:] step.
- 1:03 PM Changeset in webkit [168437] by
-
- 3 edits in trunk/Source/WebCore
Clean up the difference between painting focus rings and adding PDF annotations
https://bugs.webkit.org/show_bug.cgi?id=132638
Follow-up comments from Darin Adler.
- rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutline): Move "else if" to a separate "if" for clarity.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::paintFocusRing): Don't guard against outlineIsAuto(). ASSERT instead.
(WebCore::RenderObject::addPDFURLRect): Give "rect" variable a better name.
(WebCore::RenderObject::paintOutline): Move "else if" to a separate "if" for clarity.
- 12:59 PM Changeset in webkit [168436] by
-
- 3 edits2 deletes in branches/safari-537.76-branch
Rollout r168104.
- 11:57 AM Changeset in webkit [168435] by
-
- 19 edits in trunk/Source
Make blob size computation lazy
https://bugs.webkit.org/show_bug.cgi?id=132653
Reviewed by Anders Carlsson.
Source/WebCore:
- fileapi/Blob.cpp:
(WebCore::Blob::Blob):
(WebCore::Blob::size):
- fileapi/Blob.h:
(WebCore::Blob::size): Deleted.
- fileapi/File.cpp:
(WebCore::File::size): Deleted.
- fileapi/File.h:
- fileapi/ThreadableBlobRegistry.cpp:
(WebCore::ThreadableBlobRegistry::registerFileBlobURL):
(WebCore::ThreadableBlobRegistry::registerBlobURL):
(WebCore::ThreadableBlobRegistry::registerBlobURLForSlice):
(WebCore::ThreadableBlobRegistry::blobSize):
(WebCore::ThreadableBlobRegistry::unregisterBlobURL):
(WebCore::unregisterBlobURLTask): Deleted.
- fileapi/ThreadableBlobRegistry.h:
- platform/network/BlobData.cpp:
(WebCore::BlobData::appendData):
- platform/network/BlobRegistry.h:
- platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::registerBlobURL):
(WebCore::BlobRegistryImpl::registerBlobURLForSlice):
- platform/network/BlobRegistryImpl.h:
Source/WebKit2:
- NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:
(WebKit::NetworkBlobRegistry::registerBlobURL):
(WebKit::NetworkBlobRegistry::registerBlobURLForSlice):
(WebKit::NetworkBlobRegistry::blobSize):
- NetworkProcess/FileAPI/NetworkBlobRegistry.h:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::registerBlobURL):
(WebKit::NetworkConnectionToWebProcess::registerBlobURLForSlice):
(WebKit::NetworkConnectionToWebProcess::blobSize):
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- WebProcess/FileAPI/BlobRegistryProxy.cpp:
(WebKit::BlobRegistryProxy::registerBlobURL):
(WebKit::BlobRegistryProxy::registerBlobURLForSlice):
(WebKit::BlobRegistryProxy::blobSize):
- WebProcess/FileAPI/BlobRegistryProxy.h:
- 11:49 AM Changeset in webkit [168434] by
-
- 7 edits in trunk
WebKit1 is flashy when compositing layers come and go
https://bugs.webkit.org/show_bug.cgi?id=132655
Source/WebKit/mac:
Reviewed by Sam Weinig.
In r166117 I removed code to flush compositing layers in FrameView::paintContents(),
which caused problems when painting iframes. However, this removed a flush
that WebKit1 relied on to flush compositing layers when painting, which caused
flashing when compositing layers come and go, and broke WebView snapshotting
in some cases.
Fix by adding back compositing layer flushing, but this time in WebKit1's
-viewWillDraw code path. This allows removal of some flushing in DumpRenderTree.
- WebView/WebHTMLView.mm:
(-[WebHTMLView viewWillDraw]):
- WebView/WebView.mm:
(-[WebView _flushCompositingChanges]):
- WebView/WebViewInternal.h:
- WebView/WebViewPrivate.h:
Tools:
<rdar://problem/16830981&16788846>
Reviewed by Sam Weinig.
Revert the change from r166117.
- DumpRenderTree/mac/DumpRenderTree.mm:
(updateDisplay):
- 11:42 AM Changeset in webkit [168433] by
-
- 7 edits in trunk/Source
Add scrolling tree logging to RemoteLayerTree output
https://bugs.webkit.org/show_bug.cgi?id=132640
Reviewed by Beth Dakin.
Source/WebCore:
Support scrolling tree logging in the RemoteLayerTree log channel
output.
ScrollingStateTree::commit() unconditionally set treeStateClone->m_hasChangedProperties
to true, but we should set it based on original scrolling state tree's
m_hasChangedProperties.
We have to encode all of the scrolling state nodes anyway (they only encode
changed properties), but we can use this for future optimizations, and to
avoid spurious logging.
- WebCore.exp.in: Export a couple of things we need.
- page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::commit):
Source/WebKit2:
Support scrolling tree logging in the RemoteLayerTree log channel
output.
Encode/decode ScrollingStateTree::hasChangedProperties() so we can use
it to avoid logging. Log all the things.
- Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
(WebKit::RemoteScrollingCoordinatorTransaction::encode):
(WebKit::RemoteScrollingCoordinatorTransaction::decode):
(WebKit::RemoteScrollingTreeTextStream::RemoteScrollingTreeTextStream):
(WebKit::RemoteScrollingTreeTextStream::increaseIndent):
(WebKit::RemoteScrollingTreeTextStream::decreaseIndent):
(WebKit::RemoteScrollingTreeTextStream::writeIndent):
(WebKit::dumpProperty):
(WebKit::RemoteScrollingTreeTextStream::operator<<):
(WebKit::RemoteScrollingTreeTextStream::dump):
(WebKit::RemoteScrollingTreeTextStream::recursiveDumpNodes):
(WebKit::RemoteScrollingCoordinatorTransaction::description):
(WebKit::RemoteScrollingCoordinatorTransaction::dump):
- Shared/Scrolling/RemoteScrollingCoordinatorTransaction.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
- 11:32 AM Changeset in webkit [168432] by
-
- 5 edits2 adds in trunk
AX: aria-expanded changes are not communicated to clients
https://bugs.webkit.org/show_bug.cgi?id=132642
Reviewed by Mario Sanchez Prada.
Source/WebCore:
When aria-expanded changes on non list/tree items, send out a generic
AXExpandedChange notification.
Test: platform/mac/accessibility/expanded-notification.html
- accessibility/AXObjectCache.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::handleAriaExpandedChanged):
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
LayoutTests:
- platform/mac/accessibility/expanded-notification-expected.txt: Added.
- platform/mac/accessibility/expanded-notification.html: Added.
- 11:24 AM Changeset in webkit [168431] by
-
- 2 edits in trunk/Source/WebCore
Release build fix.
- platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypes):
Removed unused globals.
- 11:19 AM Changeset in webkit [168430] by
-
- 7 edits in trunk/Source/WebCore
Eliminate "well known MIME type" support
https://bugs.webkit.org/show_bug.cgi?id=132654
Reviewed by Anders Carlsson.
Vestiges of FileSystem API.
- dom/DataTransfer.cpp:
(WebCore::DataTransfer::files):
(WebCore::DataTransfer::hasFileOfType):
- fileapi/File.cpp:
(WebCore::File::File):
(WebCore::File::contentTypeFromFilePathOrName):
- fileapi/File.h:
- html/FileInputType.cpp:
(WebCore::FileInputType::createFileList):
- platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes):
(WebCore::findMimeType): Deleted.
(WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension): Deleted.
- platform/MIMETypeRegistry.h:
- 11:13 AM Changeset in webkit [168429] by
-
- 2 edits in trunk/Source/WebKit
Fix windows build.
- 10:29 AM Changeset in webkit [168428] by
-
- 4 edits2 adds in trunk
[HTML] Default argument to HTMLTableElement.insertRow() should be -1
https://bugs.webkit.org/show_bug.cgi?id=132651
Reviewed by Alexey Proskuryakov.
Source/WebCore:
HTMLTableElement.insertRow()'s argument default value should be -1, not 0,
as per the specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/tabular-data.html#htmltableelement
The new behavior matches the one of Firefox 29 and IE11, and soon Blink:
https://codereview.chromium.org/270213007/
Test: fast/dom/HTMLTableElement/insertRow-default-argument.html
- html/HTMLTableElement.h:
- html/HTMLTableElement.idl:
LayoutTests:
Add layout test to test that the default argument to HTMLTableElement.insertRow()
is -1.
- fast/dom/HTMLTableElement/insertRow-default-argument-expected.txt: Added.
- fast/dom/HTMLTableElement/insertRow-default-argument.html: Added.
- 9:17 AM Changeset in webkit [168427] by
-
- 22 edits in trunk
AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
https://bugs.webkit.org/show_bug.cgi?id=132622
Reviewed by Mario Sanchez Prada.
Source/WebCore:
The select text with criteria mechanism used through accessibility needs to support
a few more parameters to be complete (including capitalize, lowercase and uppercase).
Updated: accessibility/select-text.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::selectText):
- accessibility/AccessibilityObject.h:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(accessibilitySelectTextCriteriaForCriteriaParameterizedAttribute):
- rendering/RenderText.cpp:
(WebCore::makeCapitalized):
- rendering/RenderText.h:
Tools:
- DumpRenderTree/AccessibilityUIElement.cpp:
(selectTextWithCriteriaCallback):
(isEqualCallback):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::selectTextWithCriteria):
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::selectTextWithCriteria):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(selectTextParameterizedAttributeForCriteria):
(AccessibilityUIElement::selectTextWithCriteria):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::selectTextWithCriteria):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::selectTextWithCriteria):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::selectTextWithCriteria):
- WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::selectTextWithCriteria):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::selectTextParameterizedAttributeForCriteria):
(WTR::AccessibilityUIElement::selectTextWithCriteria):
LayoutTests:
- platform/mac/accessibility/select-text-expected.txt:
- platform/mac/accessibility/select-text.html:
- 8:07 AM WebKitGTK/2.4.x edited by
- (diff)
- 7:54 AM Changeset in webkit [168426] by
-
- 4 edits2 adds2 deletes in trunk/LayoutTests
Share mac/editing/spelling/editing-multiple-words-with-markers.html with other platforms
https://bugs.webkit.org/show_bug.cgi?id=132649
Reviewed by Ryosuke Niwa.
This test does not verify autocorrection feature which is only implemented
by Mac. Other WebKit ports might be interested in running it due to
verification of spelling markers after merging two misspelled words.
Additionally, add the test case confirming spelling markers
before any selection change.
Due to bug 125689, this test starts using asynchronous spellchecking.
- editing/spelling/editing-multiple-words-with-markers-expected.txt:
Renamed from platform/mac/editing/spelling/editing-multiple-words-with-markers-expected.txt
- editing/spelling/editing-multiple-words-with-markers.html:
Renamed from platform/mac/editing/spelling/editing-multiple-words-with-markers.html
- platform/gtk/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/win/TestExpectations:
Mark editing-multiple-words-with-markers.html as failing since those
platforms didn't turn on asynchronous spellchecking.
- 7:07 AM Changeset in webkit [168425] by
-
- 2 edits in trunk/Source/WebCore
DocumentLoader::dataReceived assertion failed
https://bugs.webkit.org/show_bug.cgi?id=132017
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-05-07
Reviewed by Brent Fulgham.
We need to call didReceiveResponse client method before the didReceiveData client method, otherwise we get a lot of asserts.
This patch also fixes frequent crashes in downloadTimerCallback method on page loading.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::calculateWebTimingInformations): Initialize local variables.
(WebCore::headerCallback): Call didReceiveResponse client method here instead of in downloadTimerCallback.
(WebCore::ResourceHandleManager::downloadTimerCallback): Remove call to didReceiveResponse method.
(WebCore::ResourceHandleManager::dispatchSynchronousJob): Removed empty line.
- 6:11 AM Changeset in webkit [168424] by
-
- 3 edits2 adds in trunk
REGRESSION: Animated GIF inside compositing layer never resumes animation when scrolled back into view
https://bugs.webkit.org/show_bug.cgi?id=132608
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/repaint/animation-after-layer-scroll.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):
Check if any animations need to be restarted after layer scroll.
LayoutTests:
- fast/repaint/animation-after-layer-scroll-expected.txt: Added.
- fast/repaint/animation-after-layer-scroll.html: Added.
- 4:44 AM Changeset in webkit [168423] by
-
- 25 edits in trunk/Source
GraphicsLayer::client() should return a reference.
https://bugs.webkit.org/show_bug.cgi?id=126372
Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2014-05-07
Reviewed by Simon Fraser.
GraphicsLayers always have a GraphicsLayerClient attached,
so make client() a reference and remove some unnecessary branches.
The author of the changes in the mac port is Andreas Kling <akling@apple.com>.
Source/WebCore:
- WebCore.exp.in:
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::GraphicsLayer):
(WebCore::GraphicsLayer::willBeDestroyed):
(WebCore::GraphicsLayer::paintGraphicsLayerContents):
(WebCore::GraphicsLayer::addRepaintRect):
(WebCore::dumpChildren):
(WebCore::GraphicsLayer::dumpProperties):
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::client):
(WebCore::GraphicsLayer::pageScaleFactor):
(WebCore::GraphicsLayer::deviceScaleFactor):
- platform/graphics/GraphicsLayerFactory.h:
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayer::create):
(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::initialize):
(WebCore::GraphicsLayerCA::platformCALayerAnimationStarted):
(WebCore::GraphicsLayerCA::computePositionRelativeToBase):
(WebCore::GraphicsLayerCA::flushCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerCA::computeVisibleRect):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::platformCALayerContentsScaleMultiplierForNewTiles):
(WebCore::GraphicsLayerCA::platformCALayerShouldAggressivelyRetainTiles):
(WebCore::GraphicsLayerCA::platformCALayerShouldTemporarilyRetainTileCohorts):
(WebCore::GraphicsLayerCA::updateContentsOpaque):
(WebCore::GraphicsLayerCA::updateContentsScale):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
(WebCore::GraphicsLayerCA::noteLayerPropertyChanged):
- platform/graphics/ca/GraphicsLayerCA.h:
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayer::create):
(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::notifyChange):
(WebCore::GraphicsLayerTextureMapper::commitLayerChanges):
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
- platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
(WebCore::CompositingCoordinator::createRootLayer):
(WebCore::CompositingCoordinator::createGraphicsLayer):
- platform/graphics/texmap/coordinated/CompositingCoordinator.h:
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::notifyFlushRequired):
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::computeTransformedVisibleRect):
(WebCore::CoordinatedGraphicsLayer::animationStartedTimerFired):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createGraphicsLayer):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateLayerForTopOverhangArea):
(WebCore::RenderLayerCompositor::updateLayerForBottomOverhangArea):
(WebCore::RenderLayerCompositor::updateLayerForHeader):
(WebCore::RenderLayerCompositor::updateLayerForFooter):
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
(WebCore::RenderLayerCompositor::ensureRootLayer):
Source/WebKit/win:
- WebView.cpp:
(WebView::setAcceleratedCompositing):
Source/WebKit2:
- WebProcess/WebPage/PageOverlayController.cpp:
(WebKit::PageOverlayController::initialize):
(WebKit::PageOverlayController::installPageOverlay):
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::initialize):
(WebKit::LayerTreeHostGtk::createPageOverlayLayer):
- WebProcess/WebPage/mac/GraphicsLayerCARemote.h:
- WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::createGraphicsLayer):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
- 4:23 AM WebKitGTK/2.4.x edited by
- (diff)
- 4:21 AM Changeset in webkit [168422] by
-
- 4 edits in releases/WebKitGTK/webkit-2.4
Merge r168417 - [SOUP] TLSErrors do not cause page load to fail when not ignored
https://bugs.webkit.org/show_bug.cgi?id=121548
Reviewed by Sergio Villar Senin.
Source/WebCore:
This only happens in case of redirection, when the initial URL is
an HTTPS site with an invalid certificate, that redirects to
another location. We are starting the redirection without checking
the TLS errors.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::sendRequestCallback): Check TLS errors before starting a
possible redirection.
Tools:
Add unit tests to check that the load fails with TLS errors in
case of a redirection.
- TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
(testTLSErrorsRedirect):
(httpsServerCallback):
(beforeAll):
- 3:59 AM Changeset in webkit [168421] by
-
- 3 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore
Merge r168351 - [Soup] Use std::unique_ptr<char[]> for the read buffer in SocketStreamHandle
https://bugs.webkit.org/show_bug.cgi?id=132559
Reviewed by Carlos Garcia Campos.
Manage the read buffer array through a std::unique_ptr<char[]> object.
This avoids handling with the raw pointer and also ensures that the memory
allocated with the new[] operator is deleted with the delete[] operator,
a problem exposed by the AddressSanitizer in WebSocket tests.
- platform/network/soup/SocketStreamHandle.h:
- platform/network/soup/SocketStreamHandleSoup.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::connected):
(WebCore::SocketStreamHandle::readBytes):
(WebCore::SocketStreamHandle::platformClose):
- 3:54 AM Changeset in webkit [168420] by
-
- 3 edits in trunk/Source/WebCore
[GStreamer] Corrected typo
https://bugs.webkit.org/show_bug.cgi?id=132609
Reviewed by Martin Robinson.
Corrected m_canFallBackToLastFinishedSeekPositon typo and
initialized in the constructor to prevent problems in the future.
No test needed.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
Initialized m_canFallBackToLastFinishedSeekPosition as false.
(WebCore::MediaPlayerPrivateGStreamer::playbackPosition):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::MediaPlayerPrivateGStreamer::asyncStateChangeDone):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
m_canFallBackToLastFinishedSeekPositon ->
m_canFallBackToLastFinishedSeekPosition
- 3:39 AM Changeset in webkit [168419] by
-
- 3 edits in trunk/Source/WebKit2
Cleanup the build from unused parameter in UIProcess Module
https://bugs.webkit.org/show_bug.cgi?id=131969
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-05-07
Reviewed by Csaba Osztrogonác.
Fixed unused parameter by omitting the parameter name
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageFindClient):
- UIProcess/WebFindClient.cpp:
(WebKit::WebFindClient::didFindString):
- 3:20 AM Changeset in webkit [168418] by
-
- 2 edits in trunk/Source/WebCore
Convert PassOwnPtr to unique_ptr in CrossThreadTask.h
https://bugs.webkit.org/show_bug.cgi?id=132605
Reviewed by Dirk Schulze.
- dom/CrossThreadTask.h: Converted.
- 3:11 AM Changeset in webkit [168417] by
-
- 4 edits in trunk
[SOUP] TLSErrors do not cause page load to fail when not ignored
https://bugs.webkit.org/show_bug.cgi?id=121548
Reviewed by Sergio Villar Senin.
Source/WebCore:
This only happens in case of redirection, when the initial URL is
an HTTPS site with an invalid certificate, that redirects to
another location. We are starting the redirection without checking
the TLS errors.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::sendRequestCallback): Check TLS errors before starting a
possible redirection.
Tools:
Add unit tests to check that the load fails with TLS errors in
case of a redirection.
- TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
(testTLSErrorsRedirect):
(httpsServerCallback):
(beforeAll):
- 2:56 AM Changeset in webkit [168416] by
-
- 129 edits3 deletes in trunk
[CSS Grid Layout] Remove runtime feature
https://bugs.webkit.org/show_bug.cgi?id=132382
Reviewed by Benjamin Poulain.
PerformanceTests:
Remove set of WebKitCSSGridLayoutEnabled preference.
- Layout/auto-grid-lots-of-data.html:
- Layout/fixed-grid-lots-of-data.html:
Source/WebCore:
Remove cssGridLayoutEnabled setting. Update methods using it accordingly.
- WebCore.order:
- css/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridTemplateShorthand):
(WebCore::CSSParser::parseGridAreaShorthand):
(WebCore::CSSParser::cssGridLayoutEnabled): Deleted.
- css/CSSParser.h:
- css/CSSParserMode.h:
- dom/Document.cpp:
(WebCore::Document::cssGridLayoutEnabled): Deleted.
- dom/Document.h:
- page/Settings.in:
Source/WebKit/efl:
Remove cssGridLayoutEnabled setting usage.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setCSSGridLayoutEnabled): Deleted.
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Source/WebKit/mac:
Remove cssGridLayoutEnabled setting usage.
- WebKit.order:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences cssGridLayoutEnabled]): Deleted.
(-[WebPreferences setCSSGridLayoutEnabled:]): Deleted.
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2:
Remove cssGridLayoutEnabled setting usage.
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetCSSGridLayoutEnabled): Deleted.
(WKPreferencesGetCSSGridLayoutEnabled): Deleted.
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsConstructed):
- UIProcess/gtk/ExperimentalFeatures.cpp:
- UIProcess/gtk/ExperimentalFeatures.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- mac/WebKit2.order:
Tools:
Remove cssGridLayoutEnabled setting usage.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
- DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::overridePreference):
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
LayoutTests:
Remove set of WebKitCSSGridLayoutEnabled preference.
Remove fast/css-grid-layout/grid-disabled.html patch as the setting is not available anymore.
- fast/css-grid-layout/anonymous-grid-items-expected.html:
- fast/css-grid-layout/anonymous-grid-items.html:
- fast/css-grid-layout/auto-content-resolution-columns.html:
- fast/css-grid-layout/auto-content-resolution-rows.html:
- fast/css-grid-layout/breadth-size-resolution-grid.html:
- fast/css-grid-layout/calc-resolution-grid-item.html:
- fast/css-grid-layout/containing-block-grids.html:
- fast/css-grid-layout/display-grid-set-get.html:
- fast/css-grid-layout/flex-and-minmax-content-resolution-columns.html:
- fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html:
- fast/css-grid-layout/flex-content-resolution-columns.html:
- fast/css-grid-layout/flex-content-resolution-rows.html:
- fast/css-grid-layout/flex-content-sized-column-use-available-width.html:
- fast/css-grid-layout/flex-content-sized-columns-resize.html:
- fast/css-grid-layout/floating-empty-grids.html:
- fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution.html:
- fast/css-grid-layout/grid-auto-columns-rows-get-set.html:
- fast/css-grid-layout/grid-auto-columns-rows-resolution.html:
- fast/css-grid-layout/grid-auto-columns-rows-update.html:
- fast/css-grid-layout/grid-auto-flow-get-set.html:
- fast/css-grid-layout/grid-auto-flow-resolution.html:
- fast/css-grid-layout/grid-auto-flow-update.html:
- fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
- fast/css-grid-layout/grid-columns-rows-get-set.html:
- fast/css-grid-layout/grid-container-change-named-grid-lines-recompute-child.html:
- fast/css-grid-layout/grid-disabled-expected.txt: Removed.
- fast/css-grid-layout/grid-disabled.html: Removed.
- fast/css-grid-layout/grid-dynamic-updates-relayout.html:
- fast/css-grid-layout/grid-element-border-grid-item.html:
- fast/css-grid-layout/grid-element-border-padding-grid-item.html:
- fast/css-grid-layout/grid-element-change-columns-repaint.html:
- fast/css-grid-layout/grid-element-change-rows-repaint.html:
- fast/css-grid-layout/grid-element-empty-row-column.html:
- fast/css-grid-layout/grid-element-min-max-height.html:
- fast/css-grid-layout/grid-element-min-max-width.html:
- fast/css-grid-layout/grid-element-padding-grid-item.html:
- fast/css-grid-layout/grid-element-padding-margin.html:
- fast/css-grid-layout/grid-element-repeat-get-set.html:
- fast/css-grid-layout/grid-element-shrink-to-fit.html:
- fast/css-grid-layout/grid-item-addition-auto-placement-update.html:
- fast/css-grid-layout/grid-item-addition-track-breadth-update.html:
- fast/css-grid-layout/grid-item-area-get-set.html:
- fast/css-grid-layout/grid-item-bad-named-area-auto-placement.html:
- fast/css-grid-layout/grid-item-bad-resolution-double-span.html:
- fast/css-grid-layout/grid-item-change-column-repaint.html:
- fast/css-grid-layout/grid-item-change-row-repaint.html:
- fast/css-grid-layout/grid-item-column-row-get-set.html:
- fast/css-grid-layout/grid-item-end-after-get-set.html:
- fast/css-grid-layout/grid-item-margin-auto-columns-rows.html:
- fast/css-grid-layout/grid-item-margin-resolution.html:
- fast/css-grid-layout/grid-item-multiple-minmax-content-resolution.html:
- fast/css-grid-layout/grid-item-named-grid-area-resolution.html:
- fast/css-grid-layout/grid-item-named-grid-line-resolution.html:
- fast/css-grid-layout/grid-item-negative-indexes.html:
- fast/css-grid-layout/grid-item-negative-integer-explicit-grid-resolution.html:
- fast/css-grid-layout/grid-item-negative-position-resolution.html:
- fast/css-grid-layout/grid-item-order-auto-flow-resolution.html:
- fast/css-grid-layout/grid-item-order-paint-order.html:
- fast/css-grid-layout/grid-item-position-changed-dynamic.html:
- fast/css-grid-layout/grid-item-removal-auto-placement-update.html:
- fast/css-grid-layout/grid-item-removal-track-breadth-update.html:
- fast/css-grid-layout/grid-item-spanning-resolution.html:
- fast/css-grid-layout/grid-item-start-before-get-set.html:
- fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html:
- fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html:
- fast/css-grid-layout/grid-preferred-logical-widths.html:
- fast/css-grid-layout/grid-strict-ordering-crash.html:
- fast/css-grid-layout/grid-template-areas-get-set.html:
- fast/css-grid-layout/grid-template-shorthand-get-set.html:
- fast/css-grid-layout/implicit-columns-auto-resolution.html:
- fast/css-grid-layout/implicit-position-dynamic-change.html:
- fast/css-grid-layout/implicit-rows-auto-resolution.html:
- fast/css-grid-layout/minmax-fixed-logical-height-only.html:
- fast/css-grid-layout/minmax-fixed-logical-width-only.html:
- fast/css-grid-layout/minmax-max-content-resolution-columns.html:
- fast/css-grid-layout/minmax-max-content-resolution-rows.html:
- fast/css-grid-layout/minmax-min-content-column-resolution-columns.html:
- fast/css-grid-layout/minmax-min-content-column-resolution-rows.html:
- fast/css-grid-layout/minmax-spanning-resolution-columns.html:
- fast/css-grid-layout/minmax-spanning-resolution-rows.html:
- fast/css-grid-layout/named-grid-line-get-set.html:
- fast/css-grid-layout/named-grid-lines-with-named-grid-areas-get-set.html:
- fast/css-grid-layout/named-grid-lines-with-named-grid-areas-resolution.html:
- fast/css-grid-layout/non-grid-columns-rows-get-set-multiple.html:
- fast/css-grid-layout/non-grid-columns-rows-get-set.html:
- fast/css-grid-layout/non-grid-element-repeat-get-set.html:
- fast/css-grid-layout/non-named-grid-line-get-set.html:
- fast/css-grid-layout/percent-grid-item-in-percent-grid-track-in-percent-grid.html:
- fast/css-grid-layout/percent-grid-item-in-percent-grid-track-update.html:
- fast/css-grid-layout/percent-grid-item-in-percent-grid-track.html:
- fast/css-grid-layout/percent-padding-margin-resolution-grid-item-update.html:
- fast/css-grid-layout/percent-padding-margin-resolution-grid-item.html:
- fast/css-grid-layout/percent-resolution-grid-item.html:
- fast/css-grid-layout/place-cell-by-index.html:
- fast/css-grid-layout/should-not-collapse-anonymous-blocks.html:
- ietestcenter/css3/grid/grid-column-002.htm:
- ietestcenter/css3/grid/testRunnerEnableGrid.js: Removed.
- 1:39 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 1:35 AM Changeset in webkit [168415] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed GTK gardening
Avoid duplicated expectations and remove failure flag for fixed
js/dom/basic-weakmap.html test.
Patch by Lorenzo Tilve <ltilve@igalia.com> on 2014-05-07
- platform/gtk/TestExpectations:
- 1:15 AM Changeset in webkit [168414] by
-
- 2 edits in trunk/Source/WebKit2
URTBF after r168393 to fix !IOS builds.
- Shared/WebEvent.h:
- 12:56 AM Changeset in webkit [168413] by
-
- 2 edits in trunk/Source/WebCore
Fix build errors for BlobDataItem after r168391.
https://bugs.webkit.org/show_bug.cgi?id=132643
Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2014-05-07
Reviewed by Carlos Garcia Campos.
Patch updates BlobDataItem params usage in ResourceHandleSoup.cpp
to be inline with r168391.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::blobIsOutOfDate): BlobDataItem class is updated in r168391.
Corresponding parameter changes are done to resolve build error.
(WebCore::addEncodedBlobItemToSoupMessageBody): BlobDataItem class is updated
in r168391. Corresponding parameter changes are done to resolve build error.
May 6, 2014:
- 11:07 PM Changeset in webkit [168412] by
-
- 3 edits in tags/Safari-538.34/Source/WebKit2
Merged r168411.
- 10:37 PM Changeset in webkit [168411] by
-
- 3 edits in trunk/Source/WebKit2
Followup to "Add WK2 SPI to prevent the previous back/forward item from remaining in the list"
<rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
Reviewed by NOBODY (My mistake while addressing previous review feedback)
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageLoaderClient): During review feedback, this client switched from default negative to default
positve, so when the client isn't implemented... return true instead of false.
- UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::addItem): Fix nonsensical comments while I'm at it.
- 10:18 PM Changeset in webkit [168410] by
-
- 5 edits1 add in trunk
Add Makefile targets for copying static libraries (LLVM and WKSI)
<http://webkit.org/b/132619>
Reviewed by Mark Rowe.
.:
- Makefile:
(MODULES): Add WebKitLibraries.
Tools:
- Scripts/copy-webkitlibraries-to-product-directory: Set a
sensible default for product directory if not specified on
either the command-line or in the environment (by Xcode) by
calling productDir() in webkitdirs.pm.
WebKitLibraries:
- Makefile: Added.
(libs): Install both LLVM and WKSI static libraries.
(all): Add dependency on 'libs' target.
(debug d): Set configuration, the call 'libs' target.
(release r): Ditto.
- 10:15 PM Changeset in webkit [168409] by
-
- 5 edits in trunk/Source
Versioning.
- 10:14 PM Changeset in webkit [168408] by
-
- 1 copy in tags/Safari-538.34
New Tag.
- 9:50 PM Changeset in webkit [168407] by
-
- 10 edits3 adds in trunk
Add WK2 SPI to prevent the previous back/forward item from remaining in the list
<rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
Reviewed by Sam Weinig.
Source/WebKit2:
Add new PageLoaderClient SPI to keep the current back/forward item from remaining in the list:
- UIProcess/API/APILoaderClient.h:
(API::LoaderClient::shouldKeepCurrentBackForwardListItemInList):
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageLoaderClient):
- UIProcess/API/C/WKPageLoaderClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::shouldKeepCurrentBackForwardListItemInList):
- UIProcess/WebPageProxy.h:
- UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::addItem): Use that SPI to determine whether we should insert the new item after
the previous item, or simply replace the previous item.
(WebKit::WebBackForwardList::goToItem): Use that SPI to determine whether the previous item stays or goes.
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
(TestWebKitAPI::itemURLLastComponentIsString):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::willGoToBackForwardListItem):
(TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
- TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions): Update for new client layout.
- 9:01 PM Changeset in webkit [168406] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewd build fix for C-LOOP after r168396.
- runtime/TestRunnerUtils.cpp:
(JSC::optimizeNextInvocation): Wrapped actual call inside #if ENABLE(JIT)
- 8:47 PM Changeset in webkit [168405] by
-
- 3 edits in trunk/Source/WebKit2
-[WKWebView isLoading] is NO immediately after -loadRequest: until the provisional load starts
https://bugs.webkit.org/show_bug.cgi?id=132639
Reviewed by Darin Adler.
- UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::commitChanges): Updated for change from isLoadingState to isLoading.
(WebKit::PageLoadState::isLoading): Renamed from isLoadingState, changed to take Data and
check whether there is a non-null pending API request URL. If so, return true.
- UIProcess/PageLoadState.h:
- 7:58 PM Changeset in webkit [168404] by
-
- 4 edits in trunk/Source/WebCore
Clean up the difference between painting focus rings and adding PDF annotations
https://bugs.webkit.org/show_bug.cgi?id=132638
Reviewed by Simon Fraser.
The code to add a PDF annotation when printing was called from
drawFocusRing, which is quite confusing. With just little movement
of code, we can detect an annotation and call addPDFURLRect in the
paint phase, and drawFocusRing becomes something that only
draws focus rings.
- rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutline): Split calls to drawFocusRing
and addPDFURLRect.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::paintFocusRing): Get rid of call to PDF.
(WebCore::RenderObject::addPDFURLRect): Change the signature so it
can be called externally, and calculates the rectangle itself.
(WebCore::RenderObject::paintOutline): Split the calls.
- rendering/RenderObject.h:
- 7:36 PM Changeset in webkit [168403] by
-
- 5 edits in branches/safari-537.60-branch/Source
Versioning.
- 7:34 PM Changeset in webkit [168402] by
-
- 1 copy in tags/Safari-537.60.17
New Tag.
- 7:29 PM Changeset in webkit [168401] by
-
- 25 edits in branches/safari-537.60-branch/Source
- 7:25 PM Changeset in webkit [168400] by
-
- 10 edits2 deletes in trunk
Calling createPattern with a broken image must throw an invalidstate error
https://bugs.webkit.org/show_bug.cgi?id=132407
Reviewed by Darin Adler.
Source/WebCore:
Updated createPattern so it throws an invalidState exception
if you pass it an image that is in the broken state.
Tests:
- canvas/philip/tests/2d.pattern.image.broken.html:
- canvas/philip/tests/2d.pattern.image.incomplete.empty.html:
- fast/canvas/canvas-empty-image-pattern.html:
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createPattern):
LayoutTests:
- canvas/philip/tests/2d.pattern.image.broken-expected.txt:
- canvas/philip/tests/2d.pattern.image.broken.html:
- canvas/philip/tests/2d.pattern.image.incomplete.empty-expected.txt:
- canvas/philip/tests/2d.pattern.image.incomplete.empty.html:
- fast/canvas/canvas-empty-image-pattern-expected.txt:
- fast/dom/gc-9-expected.txt:
- fast/dom/gc-9.html:
- platform/mac/canvas/philip/tests/2d.pattern.image.broken-expected.txt: Removed.
- platform/mac/canvas/philip/tests/2d.pattern.image.incomplete.empty-expected.txt: Removed.
- 6:44 PM Changeset in webkit [168399] by
-
- 3 edits in trunk/Source/WebCore
[iOS][Mac] Display sleeps while playing <video> content.
https://bugs.webkit.org/show_bug.cgi?id=132624
Reviewed by Darin Adler.
On iOS and Mac, create a DisplaySleepDisablerCocoa rather than an (no-op) DisplaySleepDisabler.
- platform/cocoa/DisplaySleepDisablerCocoa.cpp:
(WebCore::DisplaySleepDisabler::create):
- platform/cocoa/DisplaySleepDisablerCocoa.h:
- 6:41 PM Changeset in webkit [168398] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Allow focus rings to redraw themselves if necessary
https://bugs.webkit.org/show_bug.cgi?id=132593
Fix iOS build.
- platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::GraphicsContext::drawFocusRing): We no longer use the color parameter.
- 6:07 PM Changeset in webkit [168397] by
-
- 21 edits2 deletes in trunk/Source
[Mac] Allow focus rings to redraw themselves if necessary
https://bugs.webkit.org/show_bug.cgi?id=132593
Reviewed by Simon Fraser.
Source/WebCore:
Mac allows focus rings to change rendering over time. Expose this
functionality to WebKit by having the rendering code detect that
a focused element has asked to repaint itself, and also have
the FocusController object remember how long it has been since
an element was focused.
This patch removes WebCoreNSCellExtras, since a better version is
available in WebKitSystemInterface, and it was going to be cumbersome
to port the code from there into WebKit.
- WebCore.exp.in: Export _wkDrawFocusRingAtTime and _wkDrawCellFocusRingWithFrameAtTime.
- WebCore.xcodeproj/project.pbxproj: Remove WebCoreNSCellExtras.
- page/FocusController.cpp:
(WebCore::FocusController::FocusController): Initialize the repaint timer.
(WebCore::FocusController::~FocusController): Stop the repaint timer on deletion.
(WebCore::FocusController::setFocusedElement): Keep track of the current time when focused.
(WebCore::FocusController::focusedElementNeedsRepaint): Start the repaint timer.
(WebCore::FocusController::focusRepaintTimerFired): Ask the focused element to repaint itself.
(WebCore::FocusController::timeSinceFocusWasSet):
- page/FocusController.h: Expose timeSinceFocusWasSet() and focusedElementNeedsRepaint(), as
well as add the timer for repainting.
- platform/ControlStates.h: Add timeSinceControlWasFocused member variable, allowing the platform
code such as Theme to obtain the value from FocusController.
(WebCore::ControlStates::ControlStates):
(WebCore::ControlStates::timeSinceControlWasFocused):
(WebCore::ControlStates::setTimeSinceControlWasFocused):
- platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContext::drawFocusRing): New Mac-only method that uses timeOffset.
- platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::drawFocusRingToContext): No need to pass in color and radius - these are now
ignored in WKDrawFocusRing. However, I didn't want to change the signature of the
WKSI function.
(WebCore::drawFocusRingToContextAtTime): Call into the new method WKDrawFocusRingAtTime.
(WebCore::GraphicsContext::drawFocusRing): Color and radius no longer used.
- platform/mac/ThemeMac.mm:
(WebCore::checkboxMargins): Update the margins since our focus ring can be a lot bigger.
(WebCore::radioMargins): Ditto.
(WebCore::paintToggleButton): Drawing a focus ring might trigger a repaint too.
(WebCore::buttonMargins): Increase the margins.
(WebCore::paintButton): If our focus ring wants to be drawn again, set the ControlStates flag.
- platform/mac/WebCoreNSCellExtras.h: Removed.
- platform/mac/WebCoreNSCellExtras.m: Removed.
- platform/mac/WebCoreSystemInterface.h: Declare the new methods.
- platform/mac/WebCoreSystemInterface.mm:
- rendering/RenderElement.cpp:
(WebCore::RenderElement::initializeStyle): Expand the overflow rects by the maximum
focus ring width. This might be different from the current outline size.
(WebCore::RenderElement::setStyle): Ditto.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::paintFocusRing): If we're on Mac, use the new drawFocusRing method,
which sets a parameter to true if the focused element needs a repaint.
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::updateControlStatesForRenderer): Copy the value from FocusController
so that the platform Theme code can use it.
- rendering/RenderTheme.h:
(WebCore::RenderTheme::platformFocusRingMaxWidth): Add a way to get the maximum width
of a focus ring for the platform. This is used to extend the overflow rects.
- rendering/RenderThemeMac.h: Override the focus ring width.
- rendering/RenderThemeMac.mm: On newer versions of OS X, we have a larger focus ring.
(WebCore::RenderThemeMac::platformFocusRingMaxWidth):
(WebCore::RenderThemeMac::paintMenuList): If a menu is focused, and needs a repaint, mark
it as such.
Source/WebKit/mac:
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Add DrawFocusRingAtTime and DrawCellFocusRingWithFrameAtTime.
Source/WebKit2:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Add DrawFocusRingAtTime and DrawCellFocusRingWithFrameAtTime.
- 5:34 PM Changeset in webkit [168396] by
-
- 4 edits1 add in trunk/Source/JavaScriptCore
Add test for deleteAllCompiledCode
https://bugs.webkit.org/show_bug.cgi?id=132632
Reviewed by Phil Pizlo.
Added two new hooks to jsc, one to call Heap::deleteAllCompiledCode() and
the other to call CodeBlock::optimizeNextInvocation(). Used these two hooks
to write a test that will queue up loads of DFG compiles and then call
Heap::deleteAllCompiledCode() to make sure that it can handle compiled
code as well as code being compiled.
- jsc.cpp:
(GlobalObject::finishCreation):
(functionDeleteAllCompiledCode):
(functionOptimizeNextInvocation):
- runtime/TestRunnerUtils.cpp:
(JSC::optimizeNextInvocation):
- runtime/TestRunnerUtils.h:
- tests/stress/deleteAllCompiledCode.js: Added.
(functionList):
(runTest):
- 5:29 PM Changeset in webkit [168395] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/16833442> [iOS WebKit2]: Keep the order of contentView in _scrollView after rotation
https://bugs.webkit.org/show_bug.cgi?id=132634
Reviewed by Enrica Casucci.
Nice idea of Yongjun.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
(-[WKWebView _endAnimatedResize]):
- 5:17 PM Changeset in webkit [168394] by
-
- 2 edits in trunk/Source/WebKit2
Take WKView's topContentInset into account when docking Web Inspector to the right.
https://bugs.webkit.org/show_bug.cgi?id=132631
Reviewed by Joseph Pecoraro.
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::inspectedViewFrameDidChange): Subtract topContentInset
from the height of the frame for the Inspector.
- 5:01 PM Changeset in webkit [168393] by
-
- 7 edits in trunk/Source/WebKit2
[iOS][WK2] WebKit2 does not set CanPreventNativeGestures on the platform events
https://bugs.webkit.org/show_bug.cgi?id=132594
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-05-06
Reviewed by Simon Fraser.
Set CanPreventNativeGestures on the plaform event.
Change the tracking of WKContentView to be similar to WebPageProxy.
- Shared/WebEvent.h:
(WebKit::WebTouchEvent::WebTouchEvent):
(WebKit::WebTouchEvent::canPreventNativeGestures):
(WebKit::WebTouchEvent::setCanPreventNativeGestures):
- Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformTouchEvent::WebKit2PlatformTouchEvent):
- Shared/ios/WebTouchEventIOS.cpp:
(WebKit::WebTouchEvent::encode):
(WebKit::WebTouchEvent::decode):
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _webTouchEventsRecognized:]):
- 4:36 PM Changeset in webkit [168392] by
-
- 4 edits in trunk/Source/WebCore
[iOS] Animate AVPlayerLayer into and out of full screen
https://bugs.webkit.org/show_bug.cgi?id=132603
Reviewed by Simon Fraser.
Rather than synchronize animations across the WebProcess / UIProcess boundary, animate
the AVPlayerLayer into place by first resizing the full screen layer to occupy the
entire screen in the WebProcess, and use a sublayerTransform animation in the UIProcess
to scale the AVPlayer from its initial screen location, as well as back to its final screen
location.
- platform/graphics/GeometryUtilities.cpp:
(WebCore::largestRectWithAspectRatioInsideRect): Added utility method.
- platform/graphics/GeometryUtilities.h:
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(-[WebAVVideoLayer init]): Added, initialize video gravity and enable child layer masking.
(-[WebAVVideoLayer setBounds:]): Create a transform to scale the video area.
(WebVideoFullscreenInterfaceAVKit::enterFullscreen): Block implicit animations during setup.
(WebVideoFullscreenInterfaceAVKit::exitFullscreen): Reset the gravity to ResizeAspect
if necessary.
- 4:34 PM Changeset in webkit [168391] by
-
- 12 edits2 adds in trunk/Source/WebCore
Make BlobDataItem use a refcounted object for files
https://bugs.webkit.org/show_bug.cgi?id=132628
Reviewed by Anders Carlsson.
- CMakeLists.txt:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
Added BlobDataFileReference.{h|cpp}
- WebCore.exp.in: Removed unused exports.
- platform/network/BlobData.h:
(WebCore::BlobDataItem::offset):
(WebCore::BlobDataItem::BlobDataItem):
Use a wrapper class for files, not a path. Changed to be more class-like accordingly.
- platform/network/BlobData.cpp:
(WebCore::BlobData::appendData):
(WebCore::BlobData::appendFile):
(WebCore::BlobData::appendBlob): Deleted.
(WebCore::BlobData::BlobData): Deleted.
We never add blobs to BlobData, they are always resolved to data of file references.
Lots of very confusing code to delete.
- platform/network/BlobDataFileReference.h: Added.
- platform/network/BlobDataFileReference.cpp: Added.
(WebCore::BlobDataFileReference::size):
(WebCore::BlobDataFileReference::expectedModificationTime):
(WebCore::BlobDataFileReference::computeFileSystemData):
A unique reference to a file referenced by blob, to be preserved when you slice
or combine blobs.
- platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::appendStorageItems):
(WebCore::BlobRegistryImpl::registerFileBlobURL):
(WebCore::BlobRegistryImpl::registerBlobURL):
(WebCore::BlobRegistryImpl::blobSize):
- platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::getSizeForNext):
(WebCore::BlobResourceHandle::didGetSize):
(WebCore::BlobResourceHandle::readDataSync):
(WebCore::BlobResourceHandle::readFileSync):
(WebCore::BlobResourceHandle::readDataAsync):
(WebCore::BlobResourceHandle::readFileAsync):
- platform/network/BlobResourceHandle.h:
- platform/network/FormData.cpp:
(WebCore::appendBlobResolved):
Updated for BlobDataItem interface changes.
- 4:32 PM Changeset in webkit [168390] by
-
- 4 edits2 adds in trunk
[HTML] Default argument to HTMLTableRowElement.insertCell() should be -1
https://bugs.webkit.org/show_bug.cgi?id=132615
Reviewed by Darin Adler.
Source/WebCore:
HTMLTableRowElement.insertCell()'s argument default value should be -1, not
0, as per the specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/tabular-data.html#the-tr-element
The new behavior matches the one of Firefox 29 and IE11, and soon Blink:
https://codereview.chromium.org/263323004/
Test: fast/dom/HTMLTableRowElement/insertCell-default-argument.html
- html/HTMLTableRowElement.h:
- html/HTMLTableRowElement.idl:
LayoutTests:
Add layout test to test that the default argument to
HTMLTableRowElement.insertCell() is -1.
- fast/dom/HTMLTableRowElement/insertCell-default-argument-expected.txt: Added.
- fast/dom/HTMLTableRowElement/insertCell-default-argument.html: Added.
- 4:11 PM Changeset in webkit [168389] by
-
- 2 edits in trunk/Source/WebCore
Fix build.
- 3:53 PM Changeset in webkit [168388] by
-
- 13 edits2 adds in trunk/Source/WebKit2
[iOS][WK2] Add tap highlight on the simple UITapGestureRecognizer
https://bugs.webkit.org/show_bug.cgi?id=132623
<rdar://problem/16709507>
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-05-06
Reviewed by Enrica Casucci.
Add a low latency highlight for tap/click.
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::commitPotentialTapFailed):
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]):
(-[WKContentView _showTapHighlightWithColor:WebCore::quads:WebCore::topLeftRadius:WebCore::topRightRadius:WebCore::bottomLeftRadius:WebCore::bottomRightRadius:WebCore::]):
(-[WKContentView _didGetTapHighlightForRequest:color:WebCore::quads:WebCore::topLeftRadius:WebCore::topRightRadius:WebCore::bottomLeftRadius:WebCore::bottomRightRadius:WebCore::]):
(-[WKContentView _finishInteraction]):
(-[WKContentView _highlightLongPressRecognized:]):
(-[WKContentView _singleTapRecognized:]):
(-[WKContentView _singleTapDidReset:]):
(-[WKContentView _commitPotentialTapFailed]):
(-[WKContentView _singleTapCommited:]):
(-[WKContentView _attemptClickAtLocation:]):
- UIProcess/ios/WKSyntheticClickTapGestureRecognizer.h: Added.
- UIProcess/ios/WKSyntheticClickTapGestureRecognizer.m: Added.
(-[WKSyntheticClickTapGestureRecognizer setGestureRecognizedTarget:action:]):
(-[WKSyntheticClickTapGestureRecognizer setResetTarget:action:]):
(-[WKSyntheticClickTapGestureRecognizer setState:]):
(-[WKSyntheticClickTapGestureRecognizer reset]):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::potentialTapAtPosition):
(WebKit::WebPageProxy::commitPotentialTap):
(WebKit::WebPageProxy::cancelPotentialTap):
(WebKit::WebPageProxy::tapHighlightAtPosition):
(WebKit::WebPageProxy::commitPotentialTapFailed):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::handleSyntheticClick):
(WebKit::WebPage::handleTap):
(WebKit::WebPage::sendTapHighlightForNodeIfNecessary):
(WebKit::WebPage::potentialTapAtPosition):
(WebKit::WebPage::commitPotentialTap):
(WebKit::WebPage::cancelPotentialTap):
(WebKit::WebPage::tapHighlightAtPosition):
- 3:44 PM Changeset in webkit [168387] by
-
- 5 edits4 moves in trunk/Source/WebKit2
Put WebArchive and WebArchiveResource in the API namespace.
Rubber-stamped by Dan Bernstein.
- Shared/API/c/WKSharedAPICast.h:
- Shared/API/c/mac/WKWebArchive.cpp:
(WKWebArchiveGetTypeID):
(WKWebArchiveCreate):
(WKWebArchiveCreateWithData):
(WKWebArchiveCreateFromRange):
(WKWebArchiveCopyMainResource):
- Shared/API/c/mac/WKWebArchiveResource.cpp:
(WKWebArchiveResourceGetTypeID):
(WKWebArchiveResourceCreate):
- Shared/APIWebArchive.cpp: Renamed from Source/WebKit2/Shared/WebArchive.cpp.
(API::WebArchive::create):
(API::WebArchive::WebArchive):
(API::WebArchive::~WebArchive):
(API::WebArchive::mainResource):
(API::WebArchive::subresources):
(API::WebArchive::subframeArchives):
(API::releaseCFData):
(API::WebArchive::data):
(API::WebArchive::coreLegacyWebArchive):
- Shared/APIWebArchive.h: Renamed from Source/WebKit2/Shared/WebArchive.h.
- Shared/APIWebArchiveResource.cpp: Renamed from Source/WebKit2/Shared/WebArchiveResource.cpp.
(API::WebArchiveResource::create):
(API::WebArchiveResource::WebArchiveResource):
(API::WebArchiveResource::~WebArchiveResource):
(API::releaseCFData):
(API::WebArchiveResource::data):
(API::WebArchiveResource::URL):
(API::WebArchiveResource::MIMEType):
(API::WebArchiveResource::textEncoding):
(API::WebArchiveResource::coreArchiveResource):
- Shared/APIWebArchiveResource.h: Renamed from Source/WebKit2/Shared/WebArchiveResource.h.
- WebKit2.xcodeproj/project.pbxproj:
- 3:28 PM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 3:27 PM Changeset in webkit [168386] by
-
- 2 edits in trunk/Source/WebCore
Add missing line from r168384.
- dom/ContainerNode.h:
(WebCore::ChildNodesLazySnapshot::~ChildNodesLazySnapshot):
- 3:17 PM Changeset in webkit [168385] by
-
- 10 edits2 adds in trunk
Can't make a booking at virginamerica.com
https://bugs.webkit.org/show_bug.cgi?id=132626
Reviewed by Geoffrey Garen.
Source/WebCore:
Test: fast/dom/assign-to-prototype-accessor-on-prototype-should-be-silent.html
We can't throw an exception when a site incorrectly attempts
to use a dom property setter directly on the prototype as
there are sites that do this as compatibility workarounds
for old browsers. Instead we treat use of the setter on
the prototype object in the same way we do getters, and just
log a warning to the console.
- bindings/js/JSDOMBinding.cpp:
(WebCore::reportDeprecatedSetterError):
- bindings/js/JSDOMBinding.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::setJSTestInterfaceImplementsStr2):
(WebCore::setJSTestInterfaceImplementsStr3):
(WebCore::setJSTestInterfaceImplementsNode):
(WebCore::setJSTestInterfaceSupplementalStr2):
(WebCore::setJSTestInterfaceSupplementalStr3):
(WebCore::setJSTestInterfaceSupplementalNode):
- bindings/scripts/test/JS/JSTestNondeterministic.cpp:
(WebCore::setJSTestNondeterministicNondeterministicWriteableAttr):
(WebCore::setJSTestNondeterministicNondeterministicExceptionAttr):
(WebCore::setJSTestNondeterministicNondeterministicGetterExceptionAttr):
(WebCore::setJSTestNondeterministicNondeterministicSetterExceptionAttr):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjTestSubObjEnabledBySettingConstructor):
(WebCore::setJSTestObjEnumAttr):
(WebCore::setJSTestObjByteAttr):
(WebCore::setJSTestObjOctetAttr):
(WebCore::setJSTestObjShortAttr):
(WebCore::setJSTestObjUnsignedShortAttr):
(WebCore::setJSTestObjLongAttr):
(WebCore::setJSTestObjLongLongAttr):
(WebCore::setJSTestObjUnsignedLongLongAttr):
(WebCore::setJSTestObjStringAttr):
(WebCore::setJSTestObjTestObjAttr):
(WebCore::setJSTestObjXMLObjAttr):
(WebCore::setJSTestObjCreate):
(WebCore::setJSTestObjReflectedStringAttr):
(WebCore::setJSTestObjReflectedIntegralAttr):
(WebCore::setJSTestObjReflectedUnsignedIntegralAttr):
(WebCore::setJSTestObjReflectedBooleanAttr):
(WebCore::setJSTestObjReflectedURLAttr):
(WebCore::setJSTestObjReflectedCustomIntegralAttr):
(WebCore::setJSTestObjReflectedCustomBooleanAttr):
(WebCore::setJSTestObjReflectedCustomURLAttr):
(WebCore::setJSTestObjTypedArrayAttr):
(WebCore::setJSTestObjAttrWithGetterException):
(WebCore::setJSTestObjAttrWithSetterException):
(WebCore::setJSTestObjStringAttrWithGetterException):
(WebCore::setJSTestObjStringAttrWithSetterException):
(WebCore::setJSTestObjCustomAttr):
(WebCore::setJSTestObjWithScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAttribute):
(WebCore::setJSTestObjWithScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::setJSTestObjConditionalAttr1):
(WebCore::setJSTestObjConditionalAttr2):
(WebCore::setJSTestObjConditionalAttr3):
(WebCore::setJSTestObjConditionalAttr4Constructor):
(WebCore::setJSTestObjConditionalAttr5Constructor):
(WebCore::setJSTestObjConditionalAttr6Constructor):
(WebCore::setJSTestObjAnyAttribute):
(WebCore::setJSTestObjMutablePoint):
(WebCore::setJSTestObjImmutablePoint):
(WebCore::setJSTestObjStrawberry):
(WebCore::setJSTestObjStrictFloat):
(WebCore::setJSTestObjId):
(WebCore::setJSTestObjReplaceableAttribute):
(WebCore::setJSTestObjNullableLongSettableAttribute):
(WebCore::setJSTestObjNullableStringValue):
(WebCore::setJSTestObjAttributeWithReservedEnumType):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::setJSTestSerializedScriptValueInterfaceValue):
(WebCore::setJSTestSerializedScriptValueInterfaceCachedValue):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::setJSTestTypedefsUnsignedLongLongAttr):
(WebCore::setJSTestTypedefsImmutableSerializedScriptValue):
(WebCore::setJSTestTypedefsAttrWithGetterException):
(WebCore::setJSTestTypedefsAttrWithSetterException):
(WebCore::setJSTestTypedefsStringAttrWithGetterException):
(WebCore::setJSTestTypedefsStringAttrWithSetterException):
LayoutTests:
Add testcase to make sure that we are silently ignoring usage
of prototype setters and the prototype itself. We dump a warning
to the console as throwing an exception breaks sites that used
to rely on essentially no-op behavior.
- fast/dom/assign-to-prototype-accessor-on-prototype-should-be-silent-expected.txt: Added.
- fast/dom/assign-to-prototype-accessor-on-prototype-should-be-silent.html: Added.
- 3:16 PM Changeset in webkit [168384] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSString::toAtomicString() should return AtomicString.
<https://webkit.org/b/132627>
Remove premature optimization where I was trying to avoid refcount
churn when returning an already atomicized String.
Instead of using reinterpret_cast to mangle the String member into
a const AtomicString& return value, just return AtomicString.
Reviewed by Geoff Garen.
- runtime/JSString.h:
(JSC::JSString::toAtomicString):
- 3:13 PM Changeset in webkit [168383] by
-
- 2 edits in trunk/Source/WebCore
ChildNodesLazySnapshot::m_childNodes needs two heap allocations.
<https://webkit.org/b/132616>
This seems a bit silly, since ChildNodesLazySnapshot is always
allocated on the stack.
Change it to be a bool + a Vector instead of using the nullity
as a presence indicator. This way we also don't end up with an
out-of-line ~OwnPtr for the Vector.
Reviewed by Geoff Garen.
- dom/ContainerNode.h:
(WebCore::ChildNodesLazySnapshot::ChildNodesLazySnapshot):
(WebCore::ChildNodesLazySnapshot::nextNode):
(WebCore::ChildNodesLazySnapshot::takeSnapshot):
(WebCore::ChildNodesLazySnapshot::hasSnapshot):
- 3:11 PM Changeset in webkit [168382] by
-
- 11 edits1 delete in trunk/Source/WebCore
Eliminate BlobStorageData
https://bugs.webkit.org/show_bug.cgi?id=132617
Reviewed by Anders Carlsson.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- platform/network/BlobData.h:
(WebCore::BlobData::create):
(WebCore::BlobData::BlobData):
- platform/network/BlobRegistryImpl.cpp:
(WebCore::loadResourceSynchronously):
(WebCore::BlobRegistryImpl::appendStorageItems):
(WebCore::BlobRegistryImpl::registerFileBlobURL):
(WebCore::BlobRegistryImpl::registerBlobURL):
(WebCore::BlobRegistryImpl::registerBlobURLForSlice):
(WebCore::BlobRegistryImpl::getBlobDataFromURL):
(WebCore::BlobRegistryImpl::blobSize):
- platform/network/BlobRegistryImpl.h:
- platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::createAsync):
(WebCore::BlobResourceHandle::loadResourceSynchronously):
(WebCore::BlobResourceHandle::BlobResourceHandle):
(WebCore::BlobResourceHandle::doStart):
(WebCore::BlobResourceHandle::getSizeForNext):
(WebCore::BlobResourceHandle::didGetSize):
(WebCore::BlobResourceHandle::seek):
(WebCore::BlobResourceHandle::readSync):
(WebCore::BlobResourceHandle::readDataSync):
(WebCore::BlobResourceHandle::readFileSync):
(WebCore::BlobResourceHandle::readAsync):
(WebCore::BlobResourceHandle::readDataAsync):
(WebCore::BlobResourceHandle::readFileAsync):
(WebCore::BlobResourceHandle::notifyResponseOnSuccess):
- platform/network/BlobResourceHandle.h:
- platform/network/BlobStorageData.h: Removed.
- platform/network/FormData.cpp:
(WebCore::appendBlobResolved):
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::addEncodedBlobToSoupMessageBody):
- 2:45 PM Changeset in webkit [168381] by
-
- 2 edits in trunk/Source/WebCore
Fix the iOS build.
WebCore::Editor::replaceNodeFromPasteboard(WebCore::Node*, WTF::String const&) is Mac-only.
Also sort the export file.
- WebCore.exp.in:
- 2:35 PM Changeset in webkit [168380] by
-
- 40 edits in trunk
Begin Removal of Old Multi-Column Code.
https://bugs.webkit.org/show_bug.cgi?id=132480
Reviewed by Andreas Kling.
Source/WebCore:
- dom/Document.cpp:
(WebCore::Document::regionBasedColumnsEnabled): Deleted.
- dom/Document.h:
- page/FrameView.cpp:
(WebCore::updateLayerPositionFlags):
- page/Settings.in:
- rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::clearPaginationInformation):
(WebCore::LayoutState::addForcedColumnBreak): Deleted.
- rendering/LayoutState.h:
(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::isPaginatingColumns): Deleted.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::~RenderBlock):
(WebCore::RenderBlock::addChildToContinuation):
(WebCore::RenderBlock::addChild):
(WebCore::RenderBlock::addChildIgnoringContinuation):
(WebCore::RenderBlock::removeLeftoverAnonymousBlock):
(WebCore::canMergeContiguousAnonymousBlocks):
(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::recomputeLogicalWidth):
(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
(WebCore::RenderBlock::simplifiedLayout):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::offsetForContents):
(WebCore::RenderBlock::computeIntrinsicLogicalWidths):
(WebCore::RenderBlock::createAnonymousBoxWithSameTypeAs):
(WebCore::RenderBlock::childBoxIsUnsplittableForFragmentation):
(WebCore::RenderBlock::renderName):
(WebCore::RenderBlock::addChildToAnonymousColumnBlocks): Deleted.
(WebCore::RenderBlock::containingColumnsBlock): Deleted.
(WebCore::RenderBlock::splitFlow): Deleted.
(WebCore::RenderBlock::makeChildrenAnonymousColumnBlocks): Deleted.
(WebCore::RenderBlock::columnsBlockForSpanningElement): Deleted.
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): Deleted.
(WebCore::RenderBlock::updateLogicalWidthAndColumnWidth): Deleted.
(WebCore::RenderBlock::isTopLayoutOverflowAllowed): Deleted.
(WebCore::RenderBlock::isLeftLayoutOverflowAllowed): Deleted.
(WebCore::RenderBlock::paintColumnRules): Deleted.
(WebCore::RenderBlock::initialBlockOffsetForPainting): Deleted.
(WebCore::RenderBlock::blockDeltaForPaintingNextColumn): Deleted.
(WebCore::RenderBlock::paintColumnContents): Deleted.
(WebCore::ColumnRectIterator::ColumnRectIterator): Deleted.
(WebCore::ColumnRectIterator::advance): Deleted.
(WebCore::ColumnRectIterator::columnRect): Deleted.
(WebCore::ColumnRectIterator::hasMore): Deleted.
(WebCore::ColumnRectIterator::adjust): Deleted.
(WebCore::ColumnRectIterator::update): Deleted.
(WebCore::RenderBlock::hitTestColumns): Deleted.
(WebCore::RenderBlock::adjustForColumnRect): Deleted.
(WebCore::RenderBlock::availableLogicalWidth): Deleted.
(WebCore::RenderBlock::columnGap): Deleted.
(WebCore::RenderBlock::computeColumnCountAndWidth): Deleted.
(WebCore::RenderBlock::requiresColumns): Deleted.
(WebCore::RenderBlock::setComputedColumnCountAndWidth): Deleted.
(WebCore::RenderBlock::updateColumnProgressionFromStyle): Deleted.
(WebCore::RenderBlock::computedColumnWidth): Deleted.
(WebCore::RenderBlock::computedColumnCount): Deleted.
(WebCore::RenderBlock::columnInfo): Deleted.
(WebCore::RenderBlock::columnCount): Deleted.
(WebCore::RenderBlock::columnRectAt): Deleted.
(WebCore::RenderBlock::adjustPointToColumnContents): Deleted.
(WebCore::RenderBlock::adjustRectForColumns): Deleted.
(WebCore::RenderBlock::flipForWritingModeIncludingColumns): Deleted.
(WebCore::RenderBlock::adjustStartEdgeForWritingModeIncludingColumns): Deleted.
(WebCore::RenderBlock::adjustForColumns): Deleted.
(WebCore::RenderBlock::adjustIntrinsicLogicalWidthsForColumns): Deleted.
(WebCore::RenderBlock::paginationUnit): Deleted.
(WebCore::RenderBlock::createAnonymousColumnsWithParentRenderer): Deleted.
(WebCore::RenderBlock::createAnonymousColumnSpanWithParentRenderer): Deleted.
(WebCore::RenderBlock::computeLineGridPaginationOrigin): Deleted.
- rendering/RenderBlock.h:
(WebCore::RenderBlock::pixelSnappedLogicalRightOffsetForLine):
(WebCore::RenderBlock::createAnonymousBlock):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::createAnonymousColumnsBlock): Deleted.
(WebCore::RenderBlock::createAnonymousColumnSpanBlock): Deleted.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::adjustIntrinsicLogicalWidthsForColumns):
(WebCore::RenderBlockFlow::computeIntrinsicLogicalWidths):
(WebCore::RenderBlockFlow::recomputeLogicalWidthAndColumnWidth):
(WebCore::RenderBlockFlow::columnGap):
(WebCore::RenderBlockFlow::computeColumnCountAndWidth):
(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::inNormalFlow):
(WebCore::RenderBlockFlow::applyBeforeBreak):
(WebCore::RenderBlockFlow::applyAfterBreak):
(WebCore::RenderBlockFlow::updateMinimumPageHeight):
(WebCore::RenderBlockFlow::computeOverflow):
(WebCore::RenderBlockFlow::addOverhangingFloats):
(WebCore::RenderBlockFlow::hasOverhangingFloat):
(WebCore::RenderBlockFlow::relayoutForPagination):
(WebCore::RenderBlockFlow::checkForPaginationLogicalHeightChange):
(WebCore::RenderBlockFlow::requiresColumns):
(WebCore::RenderBlockFlow::setComputedColumnCountAndWidth):
(WebCore::RenderBlockFlow::updateColumnProgressionFromStyle):
(WebCore::RenderBlockFlow::computedColumnWidth):
(WebCore::RenderBlockFlow::computedColumnCount):
- rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::hasOverhangingFloats):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::layoutOverflowRectForPropagation):
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::adjustedPositionRelativeToOffsetParent):
(WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint):
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::canHaveBoxInfoInRegion):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
- rendering/RenderFlowThread.h:
- rendering/RenderGeometryMap.cpp:
(WebCore::canMapBetweenRenderers):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::computeRectForRepaint):
(WebCore::RenderInline::offsetFromContainer):
(WebCore::RenderInline::mapLocalToContainer):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::updatePagination):
(WebCore::accumulateOffsetTowardsAncestor):
(WebCore::RenderLayer::paintList):
(WebCore::RenderLayer::hitTestList):
(WebCore::checkContainingBlockChainForPagination): Deleted.
(WebCore::RenderLayer::useRegionBasedColumns): Deleted.
(WebCore::RenderLayer::paintPaginatedChildLayer): Deleted.
(WebCore::RenderLayer::paintChildLayerIntoColumns): Deleted.
(WebCore::RenderLayer::hitTestPaginatedChildLayer): Deleted.
(WebCore::RenderLayer::hitTestChildLayerColumns): Deleted.
- rendering/RenderLayer.h:
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::shouldCheckColumnBreaks):
- rendering/RenderMultiColumnFlowThread.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::computeRectForRepaint):
(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::pushMappingToContainer):
(WebCore::RenderObject::offsetFromContainer):
- rendering/RenderObject.h:
(WebCore::RenderObject::isAnonymousBlock):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(WebCore::RenderObject::hasColumns): Deleted.
(WebCore::RenderObject::setHasColumns): Deleted.
(WebCore::RenderObject::isAnonymousColumnsBlock): Deleted.
(WebCore::RenderObject::isAnonymousColumnSpanBlock): Deleted.
(WebCore::RenderObject::adjustForColumns): Deleted.
(WebCore::RenderObject::offsetForColumns): Deleted.
- rendering/RenderText.cpp:
(WebCore::RenderText::selectionRectForRepaint):
- rendering/RenderView.cpp:
(WebCore::RenderView::availableLogicalHeight):
(WebCore::RenderView::pageOrViewLogicalHeight):
(WebCore::RenderView::unextendedBackgroundRect):
(WebCore::RenderView::backgroundRect):
(WebCore::RenderView::shouldDisableLayoutStateForSubtree):
(WebCore::RenderView::pageNumberForBlockProgressionOffset):
(WebCore::RenderView::pageCount):
(WebCore::RenderView::paginationUnit): Deleted.
- rendering/RenderView.h:
(WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::push):
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::layout):
- style/StyleResolveForDocument.cpp:
(WebCore::Style::resolveForDocument):
LayoutTests:
- platform/mac/fast/multicol/client-rects-expected.png:
- platform/mac/fast/multicol/client-rects-expected.txt:
- platform/mac/fast/multicol/client-rects-spanners-complex-expected.png:
- platform/mac/fast/multicol/client-rects-spanners-complex-expected.txt:
- platform/mac/fast/multicol/client-rects-spanners-expected.png:
- platform/mac/fast/multicol/client-rects-spanners-expected.txt:
- platform/mac/fast/multicol/newmulticol/client-rects-expected.png:
- platform/mac/fast/multicol/newmulticol/client-rects-expected.txt:
- 2:32 PM Changeset in webkit [168379] by
-
- 2 edits in trunk/Source/WebKit
Put the symlink in the right place.
- WebKit.xcodeproj/project.pbxproj:
- 2:08 PM Changeset in webkit [168378] by
-
- 7 edits in trunk/Source
Don't select an image that is about to have its menu shown.
<rdar://problem/16807845> and https://bugs.webkit.org/show_bug.cgi?id=132579
Reviewed by Tim Horton.
Source/WebCore:
- WebCore.exp.in:
- editing/Editor.h:
- editing/mac/EditorMac.mm:
(WebCore::Editor::replaceNodeFromPasteboard): New method that first selects
the Node and then immediately pastes over it. Since it’s synchronous the
selection never has a chance to paint.
- html/shadow/mac/ImageControlsButtonElementMac.cpp:
(WebCore::ImageControlsButtonElementMac::defaultEventHandler): Don’t select the image.
Source/WebKit/mac:
- Misc/WebSharingServicePickerController.mm:
(-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
Call the new replaceNodeFromPasteboard API instead of readSelectionFromPasteboard.
- 1:19 PM Changeset in webkit [168377] by
-
- 5 edits in trunk
[Mac] make metadata cue attributes consistent
https://bugs.webkit.org/show_bug.cgi?id=132610
Reviewed by Jer Noble.
Source/WebCore:
No new tests, updated http/tests/media/track-in-band-hls-metadata.html.
- platform/mac/SerializedPlatformRepresentationMac.mm:
(WebCore::jsValueWithAVMetadataItemInContext): Don't include keys @dataTypeNamespace
or @pictureType, @dataType -> @type.
LayoutTests:
- http/tests/media/track-in-band-hls-metadata-expected.txt:
- http/tests/media/track-in-band-hls-metadata.html:
- 1:10 PM Changeset in webkit [168376] by
-
- 5 edits in trunk/Source/WebCore
"Flash of content without image" when pasting a raw image from the pasteboard
<rdar://problem/16826199> and https://bugs.webkit.org/show_bug.cgi?id=132612
Reviewed by Tim Horton.
Let an ArchiveResource be flagged as "should load immediately":
- loader/archive/ArchiveResource.cpp:
(WebCore::ArchiveResource::ArchiveResource):
- loader/archive/ArchiveResource.h:
(WebCore::ArchiveResource::setShouldLoadImmediately):
(WebCore::ArchiveResource::shouldLoadImmediately):
Set that flag on the ArchiveResource for the image.
Note we quite explicitly do this only in the "read a single image" from the pasteboard
case, because we don't want to do this synchronous step for multiple images at once
such as when pasting a WebArchive:
- editing/mac/EditorMac.mm:
(WebCore::Editor::WebContentReader::readImage):
When creating a new CachedResource, if there is an ArchiveResource that is set to
load immediately, populate the CachedResource immediately instead of scheduling a load:
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
- 12:48 PM Changeset in webkit [168375] by
-
- 2 edits in trunk/PerformanceTests
[CSSRegions] Enabled regions performance tests by default
https://bugs.webkit.org/show_bug.cgi?id=128244
Reviewed by Andreas Kling.
Enabled regions performance tests.
- Skipped:
- 12:28 PM Changeset in webkit [168374] by
-
- 1 edit in branches/safari-537.76-branch/LayoutTests/TestExpectations
Move Radar link into a comment.
- 12:15 PM Changeset in webkit [168373] by
-
- 7 edits4 deletes in trunk
Roll out r167889
Rubber stamped by Geoff Garen.
It broke some websites.
Source/JavaScriptCore:
- runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::create):
- runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::hasDeletedOffset):
(JSC::PropertyTable::hadDeletedOffset): Deleted.
- runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::removePropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition):
(JSC::Structure::pin):
(JSC::Structure::pinAndPreventTransitions): Deleted.
- runtime/Structure.h:
- runtime/StructureInlines.h:
(JSC::Structure::setEnumerationCache):
(JSC::Structure::propertyTable):
(JSC::Structure::checkOffsetConsistency):
(JSC::Structure::hadDeletedOffsets): Deleted.
- tests/stress/for-in-after-delete.js:
(foo): Deleted.
LayoutTests:
- js/regress/delete-a-few-properties-then-get-by-id-expected.txt:
- js/regress/delete-a-few-properties-then-get-by-id.html:
- js/regress/script-tests/delete-a-few-properties-then-get-by-id.js:
(MyObject): Deleted.
(foo): Deleted.
- 12:14 PM Changeset in webkit [168372] by
-
- 3 edits in trunk/Source/WebKit/mac
Move the WebKitLegacy header check to the right file
https://bugs.webkit.org/show_bug.cgi?id=132620
<rdar://problem/16815716>
Reviewed by Dan Bernstein.
- WebKitLegacy/MigrateHeadersFromWebKitLegacy.make:
- WebKitLegacy/WebKit.h:
- 11:32 AM Changeset in webkit [168371] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix for debug after r168367.
- platform/NotImplemented.cpp:
Added include NotImplemented.h.
- 11:30 AM Changeset in webkit [168370] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Removed unnecessary notImplemented.h includes.
https://bugs.webkit.org/show_bug.cgi?id=132587
Patch by Alex Christensen <achristensen@webkit.org> on 2014-05-06
Reviewed by Anders Carlsson.
- Modules/webdatabase/Database.cpp:
- accessibility/AccessibilityObject.cpp:
- bindings/js/Dictionary.h:
- bindings/js/SerializedScriptValue.cpp:
- html/HTMLMediaSession.cpp:
- html/ImageDocument.cpp:
- html/parser/HTMLFormattingElementList.cpp:
- loader/appcache/ApplicationCacheStorage.cpp:
- page/mac/EventHandlerMac.mm:
- platform/NotImplemented.cpp:
- platform/audio/ios/MediaSessionManagerIOS.mm:
- platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:
- platform/graphics/mac/GraphicsContext3DMac.mm:
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
- platform/ios/PlatformScreenIOS.mm:
- platform/mac/PlatformScreenMac.mm:
- platform/mac/WidgetMac.mm:
- platform/mediastream/MediaStreamTrackPrivate.cpp:
- platform/mediastream/mac/AVCaptureDeviceManager.mm:
- platform/mediastream/mac/AVMediaCaptureSource.mm:
- rendering/RenderGrid.cpp:
- workers/SharedWorkerGlobalScope.cpp:
- workers/WorkerGlobalScope.cpp:
- workers/WorkerMessagingProxy.cpp:
Removed notImplemented from list of includes.
- 11:30 AM Changeset in webkit [168369] by
-
- 21 edits in trunk/LayoutTests
[GTK] Unreviewed GTK gardening
Rebaseline affected tests by the modifications done to
inline SVG sizing behavior introduced on r168350.
Patch by Lorenzo Tilve <ltilve@igalia.com> on 2014-05-06
- platform/gtk/svg/custom/bug45331-expected.txt:
- platform/gtk/svg/custom/external-paintserver-reference-expected.txt:
- platform/gtk/svg/custom/junk-data-expected.txt:
- platform/gtk/svg/custom/linking-base-external-reference-expected.txt:
- platform/gtk/svg/custom/missing-xlink-expected.txt:
- platform/gtk/svg/custom/path-bad-data-expected.txt:
- platform/gtk/svg/custom/use-font-face-crash-expected.txt:
- platform/gtk/svg/foreignObject/svg-document-in-html-document-expected.txt:
- platform/gtk/svg/hixie/error/012-expected.txt:
- platform/gtk/svg/in-html/circle-expected.txt:
- platform/gtk/svg/transforms/animated-path-inside-transformed-html-expected.txt:
- platform/gtk/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
- platform/gtk/svg/wicd/rightsizing-grid-expected.txt:
- platform/gtk/svg/wicd/test-rightsizing-b-expected.txt:
- platform/gtk/svg/zoom/page/zoom-foreignObject-expected.txt:
- platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
- platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
- platform/gtk/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
- platform/gtk/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
- platform/gtk/svg/zoom/text/zoom-foreignObject-expected.txt:
- 11:16 AM Changeset in webkit [168368] by
-
- 4 edits in trunk/Source/WebKit
Put WebKitPluginHost.app in WebKitLegacy.framework
https://bugs.webkit.org/show_bug.cgi?id=132592
<rdar://problem/15920046>
Reviewed by Dan Bernstein.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::spawnPluginHost):
- 11:04 AM Changeset in webkit [168367] by
-
- 30 edits in trunk/Source
Removed unnecessary notImplemented.h includes.
https://bugs.webkit.org/show_bug.cgi?id=132587
Patch by Alex Christensen <achristensen@webkit.org> on 2014-05-06
Reviewed by Anders Carlsson.
Source/WebCore:
- Modules/webdatabase/Database.cpp:
- accessibility/AccessibilityObject.cpp:
- bindings/js/Dictionary.h:
- bindings/js/SerializedScriptValue.cpp:
- html/HTMLMediaSession.cpp:
- html/ImageDocument.cpp:
- html/parser/HTMLFormattingElementList.cpp:
- loader/appcache/ApplicationCacheStorage.cpp:
- page/mac/EventHandlerMac.mm:
- platform/NotImplemented.cpp:
- platform/audio/ios/MediaSessionManagerIOS.mm:
- platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:
- platform/graphics/mac/GraphicsContext3DMac.mm:
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
- platform/ios/PlatformScreenIOS.mm:
- platform/mac/PlatformScreenMac.mm:
- platform/mac/WidgetMac.mm:
- platform/mediastream/MediaStreamTrackPrivate.cpp:
- platform/mediastream/mac/AVCaptureDeviceManager.mm:
- platform/mediastream/mac/AVMediaCaptureSource.mm:
- rendering/RenderGrid.cpp:
- workers/SharedWorkerGlobalScope.cpp:
- workers/WorkerGlobalScope.cpp:
- workers/WorkerMessagingProxy.cpp:
Removed notImplemented from list of includes.
Source/WebKit2:
- UIProcess/ios/WKContentViewInteraction.mm:
- UIProcess/mac/WebContextMenuProxyMac.mm:
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
Removed notImplemented from list of includes.
- 10:58 AM Changeset in webkit [168366] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after http://trac.webkit.org/changeset/168364
- rendering/RenderLineBreak.cpp:
- 10:54 AM Changeset in webkit [168365] by
-
- 4 edits2 adds in trunk
[HTML] Default argument to HTMLTableSectionElement.insertRow() should be -1
https://bugs.webkit.org/show_bug.cgi?id=132570
Reviewed by Darin Adler.
Source/WebCore:
HTMLTableSectionElement.insertRow()'s argument default value should be -1, not
0, as per the specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/tabular-data.html#the-tbody-element
The new behavior matches the one of Firefox 29 and IE11, and soon Blink:
https://code.google.com/p/chromium/issues/detail?id=369803
Test: fast/dom/HTMLTableSectionElement/insertRow-default-argument.html
- html/HTMLTableSectionElement.h:
- html/HTMLTableSectionElement.idl:
LayoutTests:
Add layout test to test that the default argument to
HTMLTableSectionElement.insertRow() is -1.
- fast/dom/HTMLTableSectionElement/insertRow-default-argument-expected.txt: Added.
- fast/dom/HTMLTableSectionElement/insertRow-default-argument.html: Added.
- 10:49 AM Changeset in webkit [168364] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION(r155957): Selection rects are incorrect when the selection contains BR elements.
https://bugs.webkit.org/show_bug.cgi?id=132596
<rdar://problem/16692206>
Reviewed by Antti Koivisto.
This patch adds an implementation of collectSelectionRects to RenderLineBreak.
It uses the same logic used by RenderText to compute and annotate the returned rect
which is computed, like the caret rect, using information from the rootline box.
- rendering/RenderLineBreak.cpp:
(WebCore::RenderLineBreak::collectSelectionRects):
- rendering/RenderLineBreak.h:
- 10:30 AM Changeset in webkit [168363] by
-
- 6 edits in trunk
[CSS Regions] Optimize the number of regions invalidations
https://bugs.webkit.org/show_bug.cgi?id=132611
Reviewed by David Hyatt.
Source/WebCore:
It is possible to invalidate the region chain of a flow thread
during the layout of the region when its height is not final.
This patch places the check after the height of the region
is determined, reducing the number of invalidations.
Tests: Less invalidations and repaints in the repaint tests for
the flow threads.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::updateLogicalHeight):
- rendering/RenderNamedFlowFragment.cpp:
(WebCore::RenderNamedFlowFragment::layoutBlock):
(WebCore::RenderNamedFlowFragment::invalidateRegionIfNeeded):
- rendering/RenderNamedFlowFragment.h:
LayoutTests:
Because there are less region invalidations there are less repaints
of the flow threads.
- fast/regions/repaint/repaint-regions-overflow-expected.txt:
- 9:44 AM Changeset in webkit [168362] by
-
- 10 edits in trunk/Source/WebCore
[Extended Background] Respect repeat-x/repeat-y when creating margin tiles
https://bugs.webkit.org/show_bug.cgi?id=132534
Reviewed by Beth Dakin.
If the background image that is causing margin tiles only repeats in dimension only create
the tiles in that dimension.
- page/FrameView.cpp:
(WebCore::FrameView::updateExtendBackgroundIfNecessary):
(WebCore::FrameView::calculateExtendedBackgroundMode):
(WebCore::FrameView::updateTilesForExtendedBackgroundMode):
(WebCore::FrameView::setBackgroundExtendsBeyondPage): Deleted.
(WebCore::FrameView::needsExtendedBackgroundRectForPainting): Deleted.
(WebCore::FrameView::setHasExtendedBackgroundRectForPainting): Deleted.
- page/FrameView.h:
- page/Settings.cpp:
(WebCore::Settings::setBackgroundShouldExtendBeyondPage):
- platform/graphics/TiledBacking.h:
- platform/graphics/ca/mac/TileController.h:
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::hasHorizontalMargins):
(WebCore::TileController::hasVerticalMargins):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::styleWillChange):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::setTiledBackingHasMargins):
- rendering/RenderLayerBacking.h:
- 9:19 AM Changeset in webkit [168361] by
-
- 2 edits in trunk/Tools
Try to fix iOS build.
- DumpRenderTree/mac/TestRunnerMac.mm:
(-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
Updated since I changed testRunner into a pointer instead of a reference.
Updated argument names to avoid conflict with field names.
(-[APITestDelegateIPhone run]): Ditto.
(-[APITestDelegateIPhone _cleanUp]): Ditto.
- 9:17 AM Changeset in webkit [168360] by
-
- 7 edits2 adds in trunk
AX: VoiceOver does not announce text changes for content editable regions in Safari
https://bugs.webkit.org/show_bug.cgi?id=132577
Reviewed by Mario Sanchez Prada.
Source/WebCore:
When text or children are changed inside of a contenteditable region, we need to
convert those actions into AXValueChange notifications.
Test: accessibility/content-editable-set-inner-text-generates-axvalue-notification.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::childrenChanged):
(WebCore::AccessibilityNodeObject::hasContentEditableAttributeSet): Deleted.
- accessibility/AccessibilityNodeObject.h:
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::hasContentEditableAttributeSet):
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textChanged):
LayoutTests:
- accessibility/content-editable-set-inner-text-generates-axvalue-notification-expected.txt: Added.
- accessibility/content-editable-set-inner-text-generates-axvalue-notification.html: Added.
- 9:11 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 7:14 AM Changeset in webkit [168359] by
-
- 2 edits in trunk/Source/WebKit/mac
[iOS] Fix two more AdoptCF I missed in my last patch.
- WebView/WebHTMLView.mm:
(imageFromRect): Use adoptCF instead of AdoptCF.
- 7:04 AM Changeset in webkit [168358] by
-
- 7 edits in trunk
[SVG2] Share "on"- event attributes with HTMLElement
https://bugs.webkit.org/show_bug.cgi?id=132604
Reviewed by Mihnea Ovidenie.
Source/WebCore:
Share "on" event attribute parsing between SVGElement and HTMLElement.
Tests: fast/dom/script-tests/event-attribute-availability.js:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::populateEventNameForAttributeLocalNameMap):
(WebCore::populateEventNameForAttributeLocalNameMap): Deleted.
- html/HTMLElement.h: Make populateEventNameForAttributeLocalNameMap
public for use in SVGElement.
- svg/SVGElement.cpp: Use HTMLElement code to parse "on" event
attributes.
(WebCore::SVGElement::parseAttribute):
LayoutTests:
Test that the "on" event attributes supported by HTMLElement are
supported by SVGElement as well.
- fast/dom/event-attribute-availability-expected.txt:
- fast/dom/script-tests/event-attribute-availability.js:
- 6:34 AM Changeset in webkit [168357] by
-
- 5 edits in trunk
Unreviewed, rolling out r168304.
https://bugs.webkit.org/show_bug.cgi?id=132607
Broke the build (Requested by KaL on #webkit).
Reverted changeset:
"[GTK][CMake] Unable to do make install"
https://bugs.webkit.org/show_bug.cgi?id=130188
http://trac.webkit.org/changeset/168304
- 6:17 AM Changeset in webkit [168356] by
-
- 1 edit26 copies1 delete in trunk/LayoutTests
[CSS Blending] Rename all the tests css3/compositing to css3/blending
https://bugs.webkit.org/show_bug.cgi?id=132606
Patch by Ion Rosca <Ion Rosca> on 2014-05-06
Reviewed by Andrei Bucur.
- css3/blending: Renamed from LayoutTests/css3/compositing.
- 5:37 AM Changeset in webkit [168355] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: [CSS Regions] Add the regionOversetChange event to the iOS 7.0 WebInspector UI
https://bugs.webkit.org/show_bug.cgi?id=132566
Reviewed by Antti Koivisto.
The regionOversetChange event was missing from the iOS7 WebInspector.
- UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
- Versions/Inspector-iOS-7.0.json:
- 5:16 AM Changeset in webkit [168354] by
-
- 7 edits138 copies126 moves6 adds5 deletes in trunk/LayoutTests
[CSS Blending] Rename layout tests css3/compositing to css3/blending
https://bugs.webkit.org/show_bug.cgi?id=132578
Patch by Ion Rosca <Ion Rosca> on 2014-05-06
Reviewed by Andrei Bucur.
- css3/blending: Renamed from css3/compositing.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/ios-sim/css3/blending: Renamed from platform/ios-sim/css3/compositing
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- platform/mac/css3/blending: Renamed from platform/mac/css3/compositing.
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 3:58 AM Changeset in webkit [168353] by
-
- 2 edits in trunk/Source/WTF
There is no HW_AVAILCPU on FreeBSD, NetBSD, and OpenBSD
https://bugs.webkit.org/show_bug.cgi?id=132542
Reviewed by Michael Saboff.
Use sysconf() to get the number of processor cores.
- wtf/NumberOfCores.cpp:
(WTF::numberOfProcessorCores):
