Timeline

May 8, 2014:

11:19 PM Changeset in webkit [168522] by ap@apple.com

• 2 edits in trunk/LayoutTests

REGRESSION (r168518): Multiple tests for workers in blobs assert
​https://bugs.webkit.org/show_bug.cgi?id=132728

• platform/mac/TestExpectations: Skipped for now.

11:01 PM Changeset in webkit [168521] by rniwa@webkit.org

• 4 edits
  72 adds in trunk/PerformanceTests

DYEBench should use TodoMVC to test FlightJS for consistency
​https://bugs.webkit.org/show_bug.cgi?id=132727

Reviewed by Andreas Kling.

Add a test suite for the FlightJS version of TodoMVC, and disable FlightJS-MailClient by default.

I initially intended to include a wider variety of demo apps in DYEBench
but that's not happening any time soon so let us use TodoMVC for all frameworks for now.

We can add more demo apps in v2.

• DoYouEvenBench/Full.html: Increment the version to 0.10.
• DoYouEvenBench/InteractiveRunner.html: Don't check disabled suites by default.
• DoYouEvenBench/resources/tests.js:
• DoYouEvenBench/resources/todomvc/dependency-examples: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/.gitignore: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/.jshintrc: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js/app.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js/data: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js/data/stats.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js/data/todos.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js/main.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js/store.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js/ui: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js/ui/main_selector.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js/ui/new_item.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js/ui/stats.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js/ui/todo_list.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js/ui/toggle_all.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js/ui/with_filters.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js/utils.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/templates: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/templates/stats.html: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/templates/todo.html: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower.json: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/depot: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/depot/depot.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/es5-shim: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/es5-shim/es5-sham.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/es5-shim/es5-shim.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/flight: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/flight/lib: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/advice.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/base.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/component.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/compose.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/debug.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/index.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/logger.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/registry.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/utils.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/jquery: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/jquery/jquery.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/requirejs: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/requirejs-text: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/requirejs-text/text.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/requirejs/require.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/todomvc-common: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/todomvc-common/base.css: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/todomvc-common/base.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/todomvc-common/bg.png: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/index.html: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/karma.conf.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/package.json: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/readme.md: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/.jshintrc: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/fixture: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/fixture/footer.html: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/fixture/new_todo.html: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/fixture/toggle_all.html: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/mock: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/mock/datastore.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/spec: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/spec/data: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/spec/data/stats_spec.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/spec/data/todos_spec.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/spec/ui: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/spec/ui/new_item_spec.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/spec/ui/stats_spec.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/spec/ui/toggle_all_spec.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/test-main.js: Added.

10:32 PM Changeset in webkit [168520] by commit-queue@webkit.org

• 4 edits in trunk

[EFL] Enable MEDIA_STREAM for EFL port
​https://bugs.webkit.org/show_bug.cgi?id=132648

Patch by Praveen R Jadhav <​praveen.j@samsung.com> on 2014-05-08
Reviewed by Gyuyoung Kim.

Tools:
Script modified to enable MEDIA_STREAM for EFL build.

• Scripts/webkitperl/FeatureList.pm:

LayoutTests:
Updated webaudio test case expectation after enabling MEDIA_STREAM

• platform/efl/TestExpectations:

10:20 PM Changeset in webkit [168519] by Brent Fulgham

• 6 edits in trunk/Source/WebCore

Multiple (stacked) cues when shuttling through video while playing closed captions
​https://bugs.webkit.org/show_bug.cgi?id=132715
<rdar://problem/16795782>

Reviewed by Eric Carlson.

Tests: media/track/track-in-band-cues-added-once.html

• html/track/TextTrack.cpp:

(WebCore::TextTrack::hasCue): Revise to use a relaxed time equality.

• html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::isEqual): Ditto.
(WebCore::TextTrackCue::hasEquivalentStartTime): Added.

• html/track/TextTrackCue.h:

(WebCore::TextTrackCue::startTimeVariance): Added.

• html/track/TextTrackCueGeneric.h:
• html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGeneric::isEqual): Do not call the VTTCue::isEqual method from
this class, since cueType() will not equal VTTCue, and the equality will fail.

9:37 PM Changeset in webkit [168518] by ap@apple.com

• 15 edits
  2 adds in trunk/Source

Automatically zip document bundles used via File API
​https://bugs.webkit.org/show_bug.cgi?id=132713
<rdar://problem/13397892>

Reviewed by Anders Carlsson.

Source/WebCore:
Tests: fast/files/filereader-zip-bundle.html

http/tests/local/fileapi/upload-zip-bundle-as-blob.html

• FileMac.mm: Added.

(WebCore::File::shouldReplaceFile):
(WebCore::File::computeNameAndContentTypeForReplacedFile):
Added code that decides what to do with a bundle. We need this to happen in
WebProcess, because HTML5 dropzone depends on this, it needs to know file type
even before a File object can be created.

• WebCore.exp.in: Export new functions.

• WebCore.xcodeproj/project.pbxproj: Added new files.

• dom/DataTransfer.cpp: (WebCore::DataTransfer::hasFileOfType): Updated for File

interface change.

• fileapi/File.h:
• fileapi/File.cpp:

(WebCore::File::File):
(WebCore::File::computeNameAndContentType):
(WebCore::File::contentTypeForFile):
(WebCore::File::contentTypeFromFilePathOrName): Deleted.
Make it possible for a subclass to affect file name and content type calculation.

• platform/network/BlobDataFileReference.cpp:

(WebCore::BlobDataFileReference::BlobDataFileReference):
(WebCore::BlobDataFileReference::~BlobDataFileReference):
(WebCore::BlobDataFileReference::path):
(WebCore::BlobDataFileReference::size):
(WebCore::BlobDataFileReference::expectedModificationTime):
(WebCore::BlobDataFileReference::startTrackingModifications):

• platform/network/BlobDataFileReference.h:

(WebCore::BlobDataFileReference::path): Deleted.
(WebCore::BlobDataFileReference::BlobDataFileReference): Deleted.
Use original or replaced file, as appropriate.

• platform/network/mac/BlobDataFileReferenceMac.mm: Added.

(WebCore::BlobDataFileReference::generateReplacementFile): Implements generateReplacementFile().

• platform/network/FormData.h: Added a FIXME.

• xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send): Always use Blob code path

for blobs, don't unwrap them into a file path.

Source/WebKit2:

• NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: NetworkProcess

now uses FileCoordination (WebProcess already had this allowed).

• Shared/BlobDataFileReferenceWithSandboxExtension.h: Added final to the class.

Source/WTF:

• wtf/FeatureDefines.h: Added ENABLE_FILE_REPLACEMENT for Mac.

9:11 PM Changeset in webkit [168517] by fpizlo@apple.com

• 1 copy in branches/ftlopt

Create a branch for risky FTL enhancements

9:02 PM Changeset in webkit [168516] by Lucas Forschler

• 5 edits in branches/safari-538.34-branch/Source

Versioning.

8:59 PM Changeset in webkit [168515] by Lucas Forschler

• 1 copy in tags/Safari-538.34.1

New Tag.

7:26 PM Changeset in webkit [168514] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Occasional crash under AsyncScrollingCoordinator::frameViewRootLayerDidChange() on history navigation
​https://bugs.webkit.org/show_bug.cgi?id=132723

Reviewed by Sam Weinig.

Crash reports suggest that when we call AsyncScrollingCoordinator::frameViewRootLayerDidChange()
from HistoryController::restoreScrollPositionAndViewState(), the FrameView may not have a
scrolling node ID, which suggests that either the FrameView doesn't have a RenderView,
or compositing hasn't happened yet.

So if we enter AsyncScrollingCoordinator::frameViewRootLayerDidChange()
and the FrameView has no scrollLayerID, just return. We'll fix things up
when compositing kicks in later.

• page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::frameViewRootLayerDidChange):

6:08 PM Changeset in webkit [168513] by Simon Fraser

• 4 edits in trunk/Source

[iOS WK2] Bottom-relative position:fixed elements are misplaced on page load
​https://bugs.webkit.org/show_bug.cgi?id=132719
<rdar://problem/16860837>

Reviewed by Benjamin Poulain.

Source/WebCore:

Add a couple of functions, and sort.

• WebCore.exp.in:

Source/WebKit2:

If we haven't received visible rects from the web process, compute the
fixed position rect, but only after scale has been set.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::viewportConfigurationChanged):

6:06 PM Changeset in webkit [168512] by jer.noble@apple.com

• 15 edits in trunk/Source

[Mac, iOS] Add source application accounting to AVURLAsset.
​https://bugs.webkit.org/show_bug.cgi?id=132637

Reviewed by Eric Carlson.

Source/WebCore:
Properly account for the application responisble for data loading by passing the source
application identifier through to AVFoundation through AVURLAsset options.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

• html/HTMLMediaElement.h:
• platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::sourceApplicationIdentifier):

• platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerSourceApplicationIdentifier):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):

• platform/network/NetworkingContext.h:

Source/WebKit/mac:
Add accessor for sourceApplicationIdentifier.

• WebCoreSupport/WebFrameNetworkingContext.h:
• WebCoreSupport/WebFrameNetworkingContext.mm:

(WebFrameNetworkingContext::sourceApplicationIdentifier):

Source/WebKit2:
Add accessor for sourceApplicationIdentifier.

• NetworkProcess/RemoteNetworkingContext.h:
• NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::sourceApplicationIdentifier):

• WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
• WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::WebFrameNetworkingContext::sourceApplicationIdentifier):

5:30 PM Changeset in webkit [168511] by dfarler@apple.com

• 2 edits in trunk/Tools

old-run-webkit-tests: update strings for simulator devices and app name
​https://bugs.webkit.org/show_bug.cgi?id=132687

Reviewed by Darin Adler.

iPhone Retina (4-inch) -> iPhone 5
iPhone Retina (4-inch 64-bit) -> iPhone 5s

• Scripts/old-run-webkit-tests:

(installAndLaunchDumpToolAppUsingNotification):
(openIPhoneSimulator):
(quitIPhoneSimulator):
quit iOS Simulator, not iPhone Simulator.

5:22 PM Changeset in webkit [168510] by mhahnenberg@apple.com

• 3 edits
  1 add in trunk/Source/JavaScriptCore

Base case for get-by-id inline cache doesn't check for HasImpureGetOwnPropertySlot
​https://bugs.webkit.org/show_bug.cgi?id=132695

Reviewed by Filip Pizlo.

We check in the case where we're accessing something other than the base object (e.g. the prototype),
but we fail to do so for the base object.

• jit/Repatch.cpp:

(JSC::tryCacheGetByID):
(JSC::tryBuildGetByIDList):

• jsc.cpp: Added some infrastructure to support this test. We don't currently trigger this bug anywhere in WebKit

because all of the values that are returned that could be impure are set to uncacheable anyways.
(WTF::ImpureGetter::ImpureGetter):
(WTF::ImpureGetter::createStructure):
(WTF::ImpureGetter::create):
(WTF::ImpureGetter::finishCreation):
(WTF::ImpureGetter::getOwnPropertySlot):
(WTF::ImpureGetter::visitChildren):
(WTF::ImpureGetter::setDelegate):
(GlobalObject::finishCreation):
(functionCreateImpureGetter):
(functionSetImpureGetterDelegate):

• tests/stress/impure-get-own-property-slot-inline-cache.js: Added.

(foo):

5:22 PM Changeset in webkit [168509] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

[iOS WebKit2] Flush RemoteLayerBackingStore contexts on a secondary queue
​​https://bugs.webkit.org/show_bug.cgi?id=132667
<rdar://problem/16861454>

Rubber-stamped by Simon Fraser.

• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
Add a null check to fix a crash on layers which lose backing store.

5:21 PM Changeset in webkit [168508] by jer.noble@apple.com

• 11 edits in trunk/Source/WebCore

[MSE][Mac] Move AVStreamDataParser off-main-thread.
​https://bugs.webkit.org/show_bug.cgi?id=132698

Reviewed by Eric Carlson.

-[AVStreamDataParser appendStreamData:] can casue the main thread to hang when a
large amount of media data is appended at once. Move the actual parsing of data
to a background (synchronous) dispatch queue, and split SourceBuffer::appendBufferTimerFired
into two functions, the latter of which will be called after the background queue
completes.

• Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::appendBufferTimerFired): Split into sourceBufferPrivateAppendComplete.
(WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Split from appendBufferTimerFired.

• Modules/mediasource/SourceBuffer.h:
• platform/graphics/SourceBufferPrivate.h:
• platform/graphics/SourceBufferPrivateClient.h:
• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(-[WebAVStreamDataParserListener streamDataParser:didParseStreamDataAsAsset:]): Re-dispatch to the

web thread.

(-[WebAVStreamDataParserListener streamDataParser:didParseStreamDataAsAsset:withDiscontinuity:]): Ditto.
(-[WebAVStreamDataParserListener streamDataParser:didFailToParseStreamDataWithError:]): Ditto.
(-[WebAVStreamDataParserListener streamDataParser:didProvideMediaData:forTrackID:mediaType:flags:]): Ditto.
(-[WebAVStreamDataParserListener streamDataParser:didReachEndOfTrackWithTrackID:mediaType:]): Ditto.
(-[WebAVStreamDataParserListener streamDataParser:didProvideContentKeyRequestInitializationData:forTrackID:]): Ditto.
(WebCore::globalDataParserQueue): Added.
(WebCore::SourceBufferPrivateAVFObjC::append): Dispatch to the globalDataParserQueue.
(WebCore::SourceBufferPrivateAVFObjC::appendCompleted): Added.

• platform/mock/mediasource/MockSourceBufferPrivate.cpp:

(WebCore::MockSourceBufferPrivate::append): Adopt sourceBufferPrivateAppendComplete.

• platform/mock/mediasource/MockSourceBufferPrivate.h:

Update SourceBufferPrivateGStreamer to match the new append return value:

• platform/graphics/gstreamer/SourceBufferPrivateGStreamer.cpp:

(WebCore::SourceBufferPrivateGStreamer::append):

• platform/graphics/gstreamer/SourceBufferPrivateGStreamer.h:

5:07 PM Changeset in webkit [168507] by matthew_hanson@apple.com

• 5 edits in branches/safari-537.76-branch/Source

Versioning.

5:02 PM Changeset in webkit [168506] by matthew_hanson@apple.com

• 1 copy in tags/Safari-537.76.4

Versioning.

5:00 PM Changeset in webkit [168505] by matthew_hanson@apple.com

• 5 edits in branches/safari-537.76-branch/Source

Versioning.

4:38 PM Changeset in webkit [168504] by commit-queue@webkit.org

• 7 edits in trunk

Unreviewed, rolling out r168498.
​https://bugs.webkit.org/show_bug.cgi?id=132714

broke Mavericks WK2 (Requested by litherum on #webkit).

Reverted changeset:

"http/tests/security/xss-DENIED-xsl-document-redirect.xml
fails with NetworkProcess"
​https://bugs.webkit.org/show_bug.cgi?id=132523
​http://trac.webkit.org/changeset/168498

4:25 PM Changeset in webkit [168503] by Lucas Forschler

• 5 edits in branches/safari-537.75-branch/Source

Versioning.

4:23 PM Changeset in webkit [168502] by Lucas Forschler

• 1 copy in tags/Safari-537.75.15

New Tag.

4:02 PM Changeset in webkit [168501] by Lucas Forschler

• 2 edits in branches/safari-538.34-branch/Source/WebKit/mac

Merged r168500.

3:42 PM Changeset in webkit [168500] by andersca@apple.com

• 2 edits in trunk/Source/WebKit/mac

Use a different install name for WebKitLegacy.framework for staged framework builds
​https://bugs.webkit.org/show_bug.cgi?id=132711
<rdar://problem/16850620>

Reviewed by Dan Bernstein.

• Configurations/WebKitLegacy.xcconfig:

3:29 PM Changeset in webkit [168499] by Beth Dakin

• 2 edits in trunk/Source/WebKit2

REGRESSION (r168053): Phone number detection boxes are wrong when scrolled
​https://bugs.webkit.org/show_bug.cgi?id=132706
-and corresponding-
<rdar://problem/16787957>

Reviewed by Tim Horton.

We need to paint the boxes in Document coordinates. Range::boundingRect() was
giving us a point that took scroll position into account, and that’s not what we
want. Here we use Range::textQuads() instead so that we can get something in
Document coordinates, and then we need to convert that up to the main Document’s
coordinates.

• WebProcess/WebPage/mac/TelephoneNumberOverlayControllerMac.mm:

(WebKit::textQuadsToBoundingRectForRange):
(WebKit::TelephoneNumberOverlayController::drawRect):

The telephone click function wants a point in Window coordinates.
(WebKit::TelephoneNumberOverlayController::mouseEvent):

3:03 PM Changeset in webkit [168498] by mmaxfield@apple.com

• 7 edits in trunk

http/tests/security/xss-DENIED-xsl-document-redirect.xml fails with NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=132523

Reviewed by Alexey Proskuryakov.

Source/WebCore:
We should not manufacture a response in the event of an error during a
synchronous XHR. In addition, this test removes one place that is
sensitive to such a manufactured response.

Updates test expectations.

• platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::platformLoadResourceSynchronously): Do not
manufacture a response

• platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::platformLoadResourceSynchronously): Do not
manufacture a response

• xml/XSLTProcessorLibxslt.cpp:

(WebCore::docLoaderFunc): Only use the response's URL if no error
occurred.

LayoutTests:
Two tests have been rebaselined, and re-enable test that now passes

• fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt: The test describes

that success causes an ErrorHandler to run, but there was no ErrorHandler line in the
expected output. This now gets printed.

• http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt: Expecting logging

output on failed redirection

• platform/mac-wk2/TestExpectations: Re-enable test that now passes.

2:51 PM Changeset in webkit [168497] by fpizlo@apple.com

• 5 edits in trunk/Source

deleteAllCompiledCode() shouldn't use the suspension worklist
​https://bugs.webkit.org/show_bug.cgi?id=132708

Reviewed by Mark Hahnenberg.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::setOptimizationThresholdBasedOnCompilationResult):

• dfg/DFGPlan.cpp:

(JSC::DFG::Plan::isStillValid):

• heap/Heap.cpp:

(JSC::Heap::deleteAllCompiledCode):

2:29 PM Changeset in webkit [168496] by akling@apple.com

• 2 edits in trunk/Source/WebCore

[iOS] WebKit should listen to critical memory warnings.
<​https://webkit.org/b/132704>
<rdar://problem/16857112>

Listen for DISPATCH_MEMORYSTATUS_PRESSURE_CRITICAL in addition to
DISPATCH_MEMORYSTATUS_PRESSURE_WARN, since we may only get the critical
notification on some systems.

Reviewed by Gavin Barraclough.

• platform/cocoa/MemoryPressureHandlerCocoa.mm:

(WebCore::MemoryPressureHandler::install):

2:20 PM Changeset in webkit [168495] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Web Inspector: InspectorDOMAgent::getAccessibilityPropertiesForNode should gracefully handle bad node
​https://bugs.webkit.org/show_bug.cgi?id=132697

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-05-08
Reviewed by Timothy Hatcher.

• inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getAccessibilityPropertiesForNode):
Gracefully handle no node.

2:07 PM Changeset in webkit [168494] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Console error when launching Web Inspector "Mode htmlmixed failed to advance stream"
​https://bugs.webkit.org/show_bug.cgi?id=132703

Patch by Jono Wells <​jonowells@apple.com> on 2014-05-08
Reviewed by Timothy Hatcher.

The CodeMirror 4 update brought with it a change in the XML mode that
causes our XML mode extension to fail to consume empty paired quotes
correctly.

• UserInterface/Views/CodeMirrorAdditions.js:

Updated extendedXMLToken() to properly handle empty paired quotes.

1:56 PM Changeset in webkit [168493] by timothy_horton@apple.com

• 5 edits in trunk/Source/WebKit2

[iOS WebKit2] Flush RemoteLayerBackingStore contexts on a secondary queue
​https://bugs.webkit.org/show_bug.cgi?id=132667
<rdar://problem/15349483>

Reviewed by Darin Adler.

• Shared/mac/RemoteLayerBackingStore.h:
• Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::takeFrontContextPendingFlush):
(WebKit::RemoteLayerBackingStore::flush): Deleted.
Add takeFrontContextPendingFlush, which returns the painted-but-not-yet-flushed front context,
and drops our reference to it. This needs to be called on all backing store between paints.

• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:

(WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::hasFlushed):

• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::~RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
(WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::create):
(WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::BackingStoreFlusher):
(WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::flush):
(WebKit::flushBackingStoreChangesInTransaction): Deleted.
Flush backing store and send the layer tree commit to the UI process from a dispatch queue.
We will only ever have a single commit in flight at a time, and there's a new
RELEASE_ASSERT to ensure that is the case.
We package up the commit on the main thread; the queue calls CGContextFlush
on all of the newly painted contexts and then tosses the commit over to the UI process.
This is a win in many cases because the Web process main thread can go ahead
and do other non-painting tasks while the queue is blocked on painting.

1:41 PM Changeset in webkit [168492] by Lucas Forschler

• 2 edits in branches/safari-538.34-branch/Source/WebKit/mac

Merged r168482.

1:39 PM Changeset in webkit [168491] by Lucas Forschler

• 5 edits in branches/safari-538.34-branch

Merged r168477.

1:34 PM Changeset in webkit [168490] by matthew_hanson@apple.com

• 6 edits
  1 delete in branches/safari-537.76-branch

Rollout r168034.

1:28 PM Changeset in webkit [168489] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

[wk2] Don't use the XPC-based plugin process for Adobe Reader
​https://bugs.webkit.org/show_bug.cgi?id=132701
<rdar://problem/16792692>

Reviewed by Anders Carlsson.

• UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::shouldUseXPC):
Rename the debugging default to a more modern and accurate name.
Don't use XPC for Adobe Reader.

(WebKit::PluginProcessProxy::platformGetLaunchOptions):
Move the check for plugins that need an executable heap into shouldUseXPC.

1:20 PM Changeset in webkit [168488] by commit-queue@webkit.org

• 2 edits in trunk/Tools

REGRESSION(r168471): Update the builder names on the scheduler list.
​https://bugs.webkit.org/show_bug.cgi?id=132699

Patch by Carlos Alberto Lopez Perez <​clopez@igalia.com> on 2014-05-08
Reviewed by Martin Robinson.

On r168471 I missed to update the builder names for the GTK build
bots on the AnyBranchScheduler type scheduler list of bots.

• BuildSlaveSupport/build.webkit.org-config/config.json:

1:10 PM Changeset in webkit [168487] by benjamin@webkit.org

• 2 edits in trunk/Source/WebKit2

[iOS][WK2] Remove an incorrect assertion on asynchronous touch dispatch
​https://bugs.webkit.org/show_bug.cgi?id=132660

Reviewed by Enrica Casucci.

This assertion no longer make sense after r168393. Now the asynchronous behavior is maintained
until the last finger leaves the screen.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleTouchEventAsynchronously):

12:52 PM Changeset in webkit [168486] by Lucas Forschler

• 5 edits in branches/safari-538.34-branch/Source

Versioning.

12:40 PM Changeset in webkit [168485] by Lucas Forschler

• 1 copy in branches/safari-538.34-branch

New Branch.

12:40 PM Changeset in webkit [168484] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Selecting frame in debugger sidebar doesn't reveal code
​https://bugs.webkit.org/show_bug.cgi?id=132112

Patch by Jono Wells <​jonowells@apple.com> on 2014-05-08
Reviewed by Joseph Pecoraro.

WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar was checking
only one of the two content trees in the DebuggerSidebarPanel instance. Added
base getter elementIsSelected to NavigationSidebarPanel and extended it in
DebuggerSidebarPanel.

• UserInterface/Base/Main.js:

(WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar): modified logic to check selectedSidebarPanel.elementIsSelected.

• UserInterface/Views/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel.prototype.get elementIsSelected): Checks breakpoint and call stack trees.

• UserInterface/Views/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel.prototype.get elementIsSelected): Base implementation.

12:19 PM Changeset in webkit [168483] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebCore

Fix the iOS build after r168476.

• platform/graphics/mac/GraphicsContextMac.mm:

(WebCore::GraphicsContext::drawFocusRing):

12:15 PM Changeset in webkit [168482] by beidson@apple.com

• 2 edits in trunk/Source/WebKit/mac

Wrap a new class definition with has_include()
<rdar://problem/16852395> and ​https://bugs.webkit.org/show_bug.cgi?id=132694

Reviewed by Tim Horton.

• Misc/WebSharingServicePickerController.mm:

12:14 PM Changeset in webkit [168481] by Bem Jones-Bey

• 15 edits
  4 adds in trunk

[CSS Shapes] Shapes do not resolve dimensions specified in viewport units
​https://bugs.webkit.org/show_bug.cgi?id=124052

Reviewed by Dirk Schulze.

Source/WebCore:
Viewport unit resolution doesn't work unless the RenderView is passed
down into the floatValueForLength methods. All this does is plumb down
a RenderView in all of these cases.

Tests: css3/masking/clip-path-polygon-viewport-units.html

fast/shapes/shape-outside-floats/shape-outside-floats-viewport-units.html

• css/BasicShapeFunctions.cpp:

(WebCore::floatValueForCenterCoordinate):

• css/BasicShapeFunctions.h:
• css/LengthFunctions.cpp:

(WebCore::floatSizeForLengthSize):

• css/LengthFunctions.h:
• rendering/ClipPathOperation.h:

(WebCore::ShapeClipPathOperation::pathForReferenceRect):
(WebCore::BoxClipPathOperation::pathForReferenceRect):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::setupClipPath):

• rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape):

• rendering/shapes/Shape.h:
• rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::ShapeOutsideInfo::computedShape):

• rendering/style/BasicShapes.cpp:

(WebCore::BasicShapeCircle::floatValueForRadiusInBox):
(WebCore::BasicShapeCircle::path):
(WebCore::BasicShapeEllipse::floatValueForRadiusInBox):
(WebCore::BasicShapeEllipse::path):
(WebCore::BasicShapePolygon::path):
(WebCore::floatSizeForLengthSize):
(WebCore::BasicShapeInset::path):

• rendering/style/BasicShapes.h:
• rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

LayoutTests:

• css3/masking/clip-path-polygon-viewport-units-expected.html: Added.
• css3/masking/clip-path-polygon-viewport-units.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-viewport-units-expected.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-viewport-units.html: Added.

12:07 PM Changeset in webkit [168480] by fpizlo@apple.com

• 7 edits
  1 add in trunk/Source/JavaScriptCore

SSA conversion should delete PhantomLocals for captured variables
​https://bugs.webkit.org/show_bug.cgi?id=132693

Reviewed by Mark Hahnenberg.

• dfg/DFGCommon.cpp:

(JSC::DFG::startCrashing): Parallel JIT and a JIT bug means that we man dump IR in parallel. This is the workaround. This patch uses it in all of the places where we dump IR and crash.

• dfg/DFGCommon.h:
• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::injectTypeConversionsForEdge): Use the workaround.

• dfg/DFGLivenessAnalysisPhase.cpp:

(JSC::DFG::LivenessAnalysisPhase::run): Use the workaround.

• dfg/DFGSSAConversionPhase.cpp:

(JSC::DFG::SSAConversionPhase::run): Fix the bug - it's true that PhantomLocal for captured variables doesn't need anything done to it, but it's wrong that we didn't delete it outright.

• dfg/DFGValidate.cpp: Use the workaround.
• tests/stress/phantom-local-captured-but-not-flushed-to-ssa.js: Added.

(foo):
(bar):

12:03 PM Changeset in webkit [168479] by Brent Fulgham

• 3 edits in trunk/Source/WebCore

Cue display events may not be registered during page load.
​https://bugs.webkit.org/show_bug.cgi?id=132696
<rdar://problem/16652874>

Reviewed by Eric Carlson.

• Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.handleTextTrackAdd): Don't register
for 'cuechange' events anymore.
(Controller.prototype.handleTextTrackRemove): Ditto.
(Controller.prototype.updateCaptionContainer): Reduce CSS
churn by not adding/removing 'Hidden' class every time a
new cue is processed. Only do this when transitioning
track display state.
(Controller.prototype.handleTextTrackCueChange): Deleted.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateTextTrackDisplay): Call
'updateTextTrackContainer' directory when processing cues,
rather than trampolining through the JS layer.

11:33 AM Changeset in webkit [168478] by ap@apple.com

• 20 edits
  2 adds in trunk/Source

Make BlobDataFileReference manage its sandbox extension
​https://bugs.webkit.org/show_bug.cgi?id=132689

Reviewed by Anders Carlsson.

Source/WebCore:

• WebCore.exp.in: Export symbols that are now needed in WebKit2 to subclass BlobDataFileReference.

• fileapi/ThreadableBlobRegistry.cpp: (WebCore::ThreadableBlobRegistry::registerFileBlobURL):
• platform/network/BlobData.cpp: (WebCore::BlobData::appendFile):
• platform/network/BlobData.h: (WebCore::BlobDataItem::BlobDataItem):
• platform/network/BlobRegistry.h:
• platform/network/BlobRegistryImpl.cpp: (WebCore::BlobRegistryImpl::registerFileBlobURL):
• platform/network/BlobRegistryImpl.h:

BlobRegistry now takes a BlobDataFileReference and not a path, so that WebKit2
could pass objects that include sandbox extensions.

• platform/network/BlobDataFileReference.h:
• platform/network/BlobDataFileReference.cpp:

(WebCore::BlobDataFileReference::~BlobDataFileReference): Added a virtual destructor.
(WebCore::BlobDataFileReference::size): We now record the size and modification time right away, no need to lazily calculate them.
(WebCore::BlobDataFileReference::expectedModificationTime): Ditto.
(WebCore::BlobDataFileReference::startTrackingModifications): Record time and size
(since it's a single call). However, size calculation will become complicated again soon.
(WebCore::BlobDataFileReference::prepareForFileAccess): A hook for subclasses.
(WebCore::BlobDataFileReference::revokeFileAccess): Ditto.
(WebCore::BlobDataFileReference::computeFileSystemData): Deleted.

Source/WebKit2:

• CMakeLists.txt:
• PlatformGTK.cmake:
• WebKit2.xcodeproj/project.pbxproj:

Added BlobDataFileReferenceWithSandboxExtension.

• NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:

(WebKit::NetworkBlobRegistry::registerFileBlobURL):
(WebKit::NetworkBlobRegistry::registerBlobURL):
(WebKit::NetworkBlobRegistry::registerBlobURLForSlice):
(WebKit::NetworkBlobRegistry::unregisterBlobURL):
(WebKit::NetworkBlobRegistry::connectionToWebProcessDidClose):
(WebKit::NetworkBlobRegistry::filesInBlob):
(WebKit::NetworkBlobRegistry::sandboxExtensions): Deleted.

• NetworkProcess/FileAPI/NetworkBlobRegistry.h:

We no longer track sandbox extensions here. Instead, provide a way to get files
for a blob, which contain extensions and can allow access to themselves.

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::NetworkResourceLoader):
(WebKit::NetworkResourceLoader::consumeSandboxExtensions):
(WebKit::NetworkResourceLoader::invalidateSandboxExtensions):

• NetworkProcess/NetworkResourceLoader.h:

Allow/revoke access to files in blob, just like we do for explicitly passed extensions.

• Shared/BlobDataFileReferenceWithSandboxExtension.cpp: Added.

(WebKit::BlobDataFileReferenceWithSandboxExtension::BlobDataFileReferenceWithSandboxExtension):
(WebKit::BlobDataFileReferenceWithSandboxExtension::~BlobDataFileReferenceWithSandboxExtension):
(WebKit::BlobDataFileReferenceWithSandboxExtension::prepareForFileAccess):
(WebKit::BlobDataFileReferenceWithSandboxExtension::revokeFileAccess):

• Shared/BlobDataFileReferenceWithSandboxExtension.h: Added.

(WebKit::BlobDataFileReferenceWithSandboxExtension::create):
A subclass of BlobDataFileReference that also contains a sandbox extension. NetworkProcess
always uses it in BlobRegistryImpl.

• WebProcess/FileAPI/BlobRegistryProxy.cpp: (WebKit::BlobRegistryProxy::registerFileBlobURL):
• WebProcess/FileAPI/BlobRegistryProxy.h:

Updated for BlobRegistry interface changes. BlobRegistryProxy doesn't really need
a BlobDataFileReference here, as it only uses a path, but it needs to implement the same interface
as BlobRegistryImpl.

11:24 AM Changeset in webkit [168477] by beidson@apple.com

• 5 edits in trunk

"shouldKeepCurrentBackForwardListItemInList" API should pass clientInfo to the callback
<rdar://problem/16855357> and ​https://bugs.webkit.org/show_bug.cgi?id=132692

Reviewed by Tim Horton.

Source/WebKit2:

• UIProcess/API/C/WKPage.cpp:

(WKPageSetPageLoaderClient):

• UIProcess/API/C/WKPageLoaderClient.h:

Tools:

• TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:

(TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):

10:57 AM Changeset in webkit [168476] by cabanier@adobe.com

• 5 edits
  2 adds in trunk

Add support for drawFocusIfNeeded
​https://bugs.webkit.org/show_bug.cgi?id=132584

Reviewed by Dirk Schulze.

Source/WebCore:
The drawFocusIfNeeded API will draw a focus ring if the element that is passed
in is focused and a child element of the canvas.

Test: fast/canvas/draw-focus-if-needed.html

• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawFocusIfNeeded):

• html/canvas/CanvasRenderingContext2D.h:
• html/canvas/CanvasRenderingContext2D.idl:

LayoutTests:

• fast/canvas/draw-focus-if-needed-expected.txt: Added.
• fast/canvas/draw-focus-if-needed.html: Added.

10:50 AM Changeset in webkit [168475] by commit-queue@webkit.org

• 2 edits in trunk/Tools

REGRESSION(r168471): Duplicate builddirs broke the build master.
​https://bugs.webkit.org/show_bug.cgi?id=132688

Patch by Carlos Alberto Lopez Perez <​clopez@igalia.com> on 2014-05-08
Reviewed by Carlos Garcia Campos.

Rename the builddirs of the new GTK bots introduced on r168471 to
be unique. Otherwise the master will break.

• BuildSlaveSupport/build.webkit.org-config/config.json:

10:32 AM Changeset in webkit [168474] by Carlos Garcia Campos

• 2 edits in trunk/Tools

[GTK] webkitdom script assumes mkdir only fails because the directory already exists
​https://bugs.webkit.org/show_bug.cgi?id=132674

Reviewed by Philippe Normand.

Only ignore mkdir failure when exception is raised because the
file already exists and it's a directory.

• gtk/webkitdom.py:

(write_doc_files):

9:42 AM Changeset in webkit [168473] by Antti Koivisto

• 6 edits in trunk/Source

[iOS WebKit2] Can't activate text fields on Facebook
​https://bugs.webkit.org/show_bug.cgi?id=132682

Reviewed by Enrica Casucci.

Source/WebCore:

• page/DOMTimer.cpp:

(WebCore::DOMTimer::fired):

The isDocument() test here had reversed in the merge breaking content change observer callback.

Source/WebKit2:

• WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:

(WebKit::WebChromeClient::observedContentChange):

Implement content change observer callback.

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::handleSyntheticClick):

If the event gets canceled by a potential change (a started short-duration timer)
save the position and node so we can continue later.

(WebKit::WebPage::completePendingSyntheticClickForContentChangeObserver):

If it turns out the observed timer changed nothing continue the click event.

(WebKit::WebPage::completeSyntheticClick):

Factored click event dispatch part of handleSyntheticClick here.

9:19 AM Changeset in webkit [168472] by commit-queue@webkit.org

• 30 edits in trunk/LayoutTests

[CSS Blending] Removing -webkit- prefixes for mix-blend-mode and isolation from layout tests.
​https://bugs.webkit.org/show_bug.cgi?id=132680

Patch by Ion Rosca <Ion Rosca> on 2014-05-08
Reviewed by Mihnea Ovidenie.

• css3/blending/blend-mode-accelerated-parent-overflow-hidden.html:
• css3/blending/blend-mode-isolation-accelerated-overflow-hidden.html:
• css3/blending/blend-mode-isolation-flags-append-non-stacking-context-blending.html:
• css3/blending/blend-mode-isolation-flags-append-stacking-context-blending.html:
• css3/blending/blend-mode-isolation-flags-remove-non-stacking-context-blending.html:
• css3/blending/blend-mode-isolation-flags-remove-stacking-context-blending.html:
• css3/blending/blend-mode-isolation-flags-turn-off-blending-no-isolation.html:
• css3/blending/blend-mode-isolation-flags-turn-off-blending.html:
• css3/blending/blend-mode-isolation-flags-turn-off-stacking-context.html:
• css3/blending/blend-mode-isolation-flags-turn-on-blending.html:
• css3/blending/blend-mode-isolation-flags-turn-on-stacking-context.html:
• css3/blending/blend-mode-isolation-overflow-hidden.html:
• css3/blending/blend-mode-isolation-turn-off-self-painting-layer.html:
• css3/blending/blend-mode-isolation-turn-off-self-painting-layer1.html:
• css3/blending/blend-mode-isolation-turn-off-self-painting-layer2.html:
• css3/blending/blend-mode-isolation-turn-on-self-painting-layer.html:
• css3/blending/blend-mode-overflow.html:
• css3/blending/repaint/blend-mode-turn-off-isolation-no-effect.html:
• css3/blending/repaint/blend-mode-turn-off-isolation.html:
• css3/blending/svg-blend-color-burn.html:
• css3/blending/svg-blend-darken.html:
• css3/blending/svg-blend-difference.html:
• css3/blending/svg-blend-exclusion.html:
• css3/blending/svg-blend-layer-mask.html:
• css3/blending/svg-blend-lighten.html:
• css3/blending/svg-blend-normal.html:
• css3/blending/svg-blend-overlay.html:
• css3/blending/svg-isolation-default.html:
• css3/blending/svg-isolation-simple.html:

9:08 AM Changeset in webkit [168471] by commit-queue@webkit.org

• 10 edits in trunk/Tools

[WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
​https://bugs.webkit.org/show_bug.cgi?id=131358

Patch by Carlos Alberto Lopez Perez <​clopez@igalia.com> on 2014-05-08
Reviewed by Carlos Garcia Campos.

Current 64-bit GTK build bots (Release and Debug) not only test
the build, but run all tests. Split each one of the bots in
BuildOnly and TestWebKit2.

This will allow us to have a better overview of the status of
the GTK port.

Original patch from Sergio Villar Senin <​svillar@igalia.com>

• BuildSlaveSupport/build.webkit.org-config/config.json:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

• Scripts/webkitpy/port/builders.py:
• Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaselineTest.test_baseline_directory):

• TestResultServer/static-dashboards/builders.jsonp:
• TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(resetGlobals):

• TestResultServer/static-dashboards/loader_unittests.js:

5:26 AM Changeset in webkit [168470] by commit-queue@webkit.org

• 122 edits
  5 adds in trunk/LayoutTests

[EFL] Rebaseline after enabling new multi-column mode (r168046)
​https://bugs.webkit.org/show_bug.cgi?id=132679

Unreviewed gardening.

Patch by Krzysztof Wolanski <​k.wolanski@samsung.com> on 2014-05-08

• platform/efl/css3/unicode-bidi-isolate-basic-expected.png:
• platform/efl/css3/unicode-bidi-isolate-basic-expected.txt:
• platform/efl/fast/block/float/float-not-removed-from-next-sibling4-expected.png:
• platform/efl/fast/block/float/float-not-removed-from-next-sibling4-expected.txt:
• platform/efl/fast/line-grid/line-grid-inside-columns-expected.png:
• platform/efl/fast/line-grid/line-grid-inside-columns-expected.txt:
• platform/efl/fast/line-grid/line-grid-into-columns-expected.txt:
• platform/efl/fast/multicol/block-axis-horizontal-bt-expected.png:
• platform/efl/fast/multicol/block-axis-horizontal-bt-expected.txt:
• platform/efl/fast/multicol/block-axis-horizontal-tb-expected.png:
• platform/efl/fast/multicol/block-axis-horizontal-tb-expected.txt:
• platform/efl/fast/multicol/block-axis-vertical-lr-expected.png:
• platform/efl/fast/multicol/block-axis-vertical-lr-expected.txt:
• platform/efl/fast/multicol/block-axis-vertical-rl-expected.txt:
• platform/efl/fast/multicol/border-padding-pagination-expected.png:
• platform/efl/fast/multicol/border-padding-pagination-expected.txt:
• platform/efl/fast/multicol/client-rects-expected.png:
• platform/efl/fast/multicol/client-rects-expected.txt:
• platform/efl/fast/multicol/client-rects-spanners-complex-expected.txt: Added.
• platform/efl/fast/multicol/client-rects-spanners-expected.txt: Added.
• platform/efl/fast/multicol/column-break-with-balancing-expected.txt:
• platform/efl/fast/multicol/column-count-with-rules-expected.txt:
• platform/efl/fast/multicol/column-rules-expected.png:
• platform/efl/fast/multicol/column-rules-expected.txt:
• platform/efl/fast/multicol/column-rules-stacking-expected.txt:
• platform/efl/fast/multicol/columns-shorthand-parsing-expected.txt:
• platform/efl/fast/multicol/float-avoidance-expected.txt:
• platform/efl/fast/multicol/float-multicol-expected.txt:
• platform/efl/fast/multicol/float-paginate-complex-expected.txt:
• platform/efl/fast/multicol/float-paginate-empty-lines-expected.txt:
• platform/efl/fast/multicol/float-paginate-expected.txt:
• platform/efl/fast/multicol/layers-in-multicol-expected.txt:
• platform/efl/fast/multicol/layers-split-across-columns-expected.txt:
• platform/efl/fast/multicol/margin-collapse-expected.txt:
• platform/efl/fast/multicol/max-height-columns-block-expected.png:
• platform/efl/fast/multicol/max-height-columns-block-expected.txt:
• platform/efl/fast/multicol/nested-columns-expected.png:
• platform/efl/fast/multicol/nested-columns-expected.txt:
• platform/efl/fast/multicol/newmulticol/client-rects-expected.txt: Added.
• platform/efl/fast/multicol/overflow-across-columns-expected.png:
• platform/efl/fast/multicol/overflow-across-columns-expected.txt:
• platform/efl/fast/multicol/overflow-across-columns-percent-height-expected.png:
• platform/efl/fast/multicol/overflow-across-columns-percent-height-expected.txt:
• platform/efl/fast/multicol/overflow-unsplittable-expected.png:
• platform/efl/fast/multicol/overflow-unsplittable-expected.txt:
• platform/efl/fast/multicol/paginate-block-replaced-expected.txt:
• platform/efl/fast/multicol/pagination/BottomToTop-bt-expected.txt:
• platform/efl/fast/multicol/pagination/BottomToTop-lr-expected.txt:
• platform/efl/fast/multicol/pagination/BottomToTop-rl-expected.txt:
• platform/efl/fast/multicol/pagination/BottomToTop-tb-expected.txt:
• platform/efl/fast/multicol/pagination/LeftToRight-bt-expected.txt:
• platform/efl/fast/multicol/pagination/LeftToRight-lr-expected.txt:
• platform/efl/fast/multicol/pagination/LeftToRight-rl-expected.txt:
• platform/efl/fast/multicol/pagination/LeftToRight-tb-expected.txt:
• platform/efl/fast/multicol/pagination/RightToLeft-bt-expected.txt:
• platform/efl/fast/multicol/pagination/RightToLeft-lr-expected.txt:
• platform/efl/fast/multicol/pagination/RightToLeft-rl-expected.txt:
• platform/efl/fast/multicol/pagination/RightToLeft-tb-expected.txt:
• platform/efl/fast/multicol/pagination/TopToBottom-bt-expected.txt:
• platform/efl/fast/multicol/pagination/TopToBottom-lr-expected.txt:
• platform/efl/fast/multicol/pagination/TopToBottom-rl-expected.txt:
• platform/efl/fast/multicol/pagination/TopToBottom-tb-expected.txt:
• platform/efl/fast/multicol/positioned-split-expected.txt:
• platform/efl/fast/multicol/positive-leading-expected.png:
• platform/efl/fast/multicol/positive-leading-expected.txt:
• platform/efl/fast/multicol/scrolling-column-rules-expected.txt: Added.
• platform/efl/fast/multicol/scrolling-overflow-expected.png:
• platform/efl/fast/multicol/scrolling-overflow-expected.txt:
• platform/efl/fast/multicol/shrink-to-column-height-for-pagination-expected.txt:
• platform/efl/fast/multicol/single-line-expected.txt:
• platform/efl/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
• platform/efl/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt:
• platform/efl/fast/multicol/span/anonymous-split-block-crash-expected.png:
• platform/efl/fast/multicol/span/anonymous-split-block-crash-expected.txt:
• platform/efl/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
• platform/efl/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
• platform/efl/fast/multicol/span/clone-flexbox-expected.txt:
• platform/efl/fast/multicol/span/clone-summary-expected.txt:
• platform/efl/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
• platform/efl/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
• platform/efl/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
• platform/efl/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
• platform/efl/fast/multicol/span/span-as-nested-columns-child-expected.txt:
• platform/efl/fast/multicol/span/span-as-nested-inline-block-child-expected.txt:
• platform/efl/fast/multicol/span/span-margin-collapsing-expected.txt:
• platform/efl/fast/multicol/table-margin-collapse-expected.txt:
• platform/efl/fast/multicol/table-vertical-align-expected.txt:
• platform/efl/fast/multicol/unsplittable-inline-block-expected.txt:
• platform/efl/fast/multicol/vertical-lr/border-padding-pagination-expected.png:
• platform/efl/fast/multicol/vertical-lr/border-padding-pagination-expected.txt:
• platform/efl/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt:
• platform/efl/fast/multicol/vertical-lr/column-count-with-rules-expected.txt:
• platform/efl/fast/multicol/vertical-lr/column-rules-expected.png:
• platform/efl/fast/multicol/vertical-lr/column-rules-expected.txt:
• platform/efl/fast/multicol/vertical-lr/float-avoidance-expected.txt:
• platform/efl/fast/multicol/vertical-lr/float-multicol-expected.txt:
• platform/efl/fast/multicol/vertical-lr/float-paginate-complex-expected.txt:
• platform/efl/fast/multicol/vertical-lr/float-paginate-expected.txt:
• platform/efl/fast/multicol/vertical-lr/nested-columns-expected.png:
• platform/efl/fast/multicol/vertical-lr/nested-columns-expected.txt:
• platform/efl/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt:
• platform/efl/fast/multicol/vertical-rl/border-padding-pagination-expected.png:
• platform/efl/fast/multicol/vertical-rl/border-padding-pagination-expected.txt:
• platform/efl/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
• platform/efl/fast/multicol/vertical-rl/column-count-with-rules-expected.txt:
• platform/efl/fast/multicol/vertical-rl/column-rules-expected.png:
• platform/efl/fast/multicol/vertical-rl/column-rules-expected.txt:
• platform/efl/fast/multicol/vertical-rl/float-avoidance-expected.txt:
• platform/efl/fast/multicol/vertical-rl/float-multicol-expected.txt:
• platform/efl/fast/multicol/vertical-rl/float-paginate-complex-expected.txt:
• platform/efl/fast/multicol/vertical-rl/float-paginate-expected.txt:
• platform/efl/fast/multicol/vertical-rl/nested-columns-expected.txt:
• platform/efl/fast/multicol/vertical-rl/rule-style-expected.txt:
• platform/efl/fast/multicol/vertical-rl/unsplittable-inline-block-expected.txt:
• platform/efl/fast/overflow/paged-x-div-expected.txt:
• platform/efl/fast/overflow/paged-x-div-with-column-gap-expected.txt:
• platform/efl/fast/overflow/paged-x-on-root-expected.png:
• platform/efl/fast/overflow/paged-x-on-root-expected.txt:
• platform/efl/fast/overflow/paged-x-with-column-gap-expected.png:
• platform/efl/fast/overflow/paged-x-with-column-gap-expected.txt:
• platform/efl/fast/overflow/paged-y-div-expected.txt:
• platform/efl/fast/overflow/paged-y-on-root-expected.png:
• platform/efl/fast/overflow/paged-y-on-root-expected.txt:
• platform/efl/fast/repaint/multicol-repaint-expected.png:
• platform/efl/fast/repaint/multicol-repaint-expected.txt:

3:59 AM Changeset in webkit [168469] by svillar@igalia.com

• 58 edits in trunk/Source/WebCore

Replace DEPRECATED_DEFINE_STATIC_LOCAL by static NeverDestroyed<T> in svg/
​https://bugs.webkit.org/show_bug.cgi?id=132647

Reviewed by Darin Adler.

• svg/SVGAElement.cpp:

(WebCore::SVGAElement::isSupportedAttribute):

• svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::isSupportedAttribute):

• svg/SVGAnimateTransformElement.cpp:

(WebCore::SVGAnimateTransformElement::isSupportedAttribute):

• svg/SVGAnimatedLength.cpp:

(WebCore::sharedSVGLength):

• svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::isSupportedAttribute):

• svg/SVGCircleElement.cpp:

(WebCore::SVGCircleElement::isSupportedAttribute):

• svg/SVGClipPathElement.cpp:

(WebCore::SVGClipPathElement::isSupportedAttribute):

• svg/SVGComponentTransferFunctionElement.cpp:

(WebCore::SVGComponentTransferFunctionElement::isSupportedAttribute):

• svg/SVGCursorElement.cpp:

(WebCore::SVGCursorElement::isSupportedAttribute):

• svg/SVGElement.cpp:

(WebCore::SVGElement::instancesForElement):
(WebCore::SVGElement::childShouldCreateRenderer):

• svg/SVGEllipseElement.cpp:

(WebCore::SVGEllipseElement::isSupportedAttribute):

• svg/SVGFEBlendElement.cpp:

(WebCore::SVGFEBlendElement::isSupportedAttribute):

• svg/SVGFEColorMatrixElement.cpp:

(WebCore::SVGFEColorMatrixElement::isSupportedAttribute):

• svg/SVGFEComponentTransferElement.cpp:

(WebCore::SVGFEComponentTransferElement::isSupportedAttribute):

• svg/SVGFECompositeElement.cpp:

(WebCore::SVGFECompositeElement::isSupportedAttribute):

• svg/SVGFEConvolveMatrixElement.cpp:

(WebCore::SVGFEConvolveMatrixElement::isSupportedAttribute):

• svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::isSupportedAttribute):

• svg/SVGFEDisplacementMapElement.cpp:

(WebCore::SVGFEDisplacementMapElement::isSupportedAttribute):

• svg/SVGFEDropShadowElement.cpp:

(WebCore::SVGFEDropShadowElement::isSupportedAttribute):

• svg/SVGFEGaussianBlurElement.cpp:

(WebCore::SVGFEGaussianBlurElement::isSupportedAttribute):

• svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::isSupportedAttribute):

• svg/SVGFELightElement.cpp:

(WebCore::SVGFELightElement::isSupportedAttribute):

• svg/SVGFEMergeNodeElement.cpp:

(WebCore::SVGFEMergeNodeElement::isSupportedAttribute):

• svg/SVGFEMorphologyElement.cpp:

(WebCore::SVGFEMorphologyElement::isSupportedAttribute):

• svg/SVGFEOffsetElement.cpp:

(WebCore::SVGFEOffsetElement::isSupportedAttribute):

• svg/SVGFESpecularLightingElement.cpp:

(WebCore::SVGFESpecularLightingElement::isSupportedAttribute):

• svg/SVGFETileElement.cpp:

(WebCore::SVGFETileElement::isSupportedAttribute):

• svg/SVGFETurbulenceElement.cpp:

(WebCore::SVGFETurbulenceElement::isSupportedAttribute):

• svg/SVGFilterElement.cpp:

(WebCore::SVGFilterElement::isSupportedAttribute):
(WebCore::SVGFilterElement::childShouldCreateRenderer):

• svg/SVGFilterPrimitiveStandardAttributes.cpp:

(WebCore::SVGFilterPrimitiveStandardAttributes::isSupportedAttribute):

• svg/SVGForeignObjectElement.cpp:

(WebCore::SVGForeignObjectElement::isSupportedAttribute):

• svg/SVGGElement.cpp:

(WebCore::SVGGElement::isSupportedAttribute):

• svg/SVGGradientElement.cpp:

(WebCore::SVGGradientElement::isSupportedAttribute):

• svg/SVGGraphicsElement.cpp:

(WebCore::SVGGraphicsElement::isSupportedAttribute):

• svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::isSupportedAttribute):

• svg/SVGLength.cpp:

(WebCore::SVGLength::lengthModeForAnimatedLengthAttribute):

• svg/SVGLineElement.cpp:

(WebCore::SVGLineElement::isSupportedAttribute):

• svg/SVGLinearGradientElement.cpp:

(WebCore::SVGLinearGradientElement::isSupportedAttribute):

• svg/SVGMPathElement.cpp:

(WebCore::SVGMPathElement::isSupportedAttribute):

• svg/SVGMarkerElement.cpp:

(WebCore::SVGMarkerElement::isSupportedAttribute):

• svg/SVGMaskElement.cpp:

(WebCore::SVGMaskElement::isSupportedAttribute):

• svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::isSupportedAttribute):

• svg/SVGPatternElement.cpp:

(WebCore::SVGPatternElement::isSupportedAttribute):

• svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::isSupportedAttribute):

• svg/SVGRadialGradientElement.cpp:

(WebCore::SVGRadialGradientElement::isSupportedAttribute):

• svg/SVGRectElement.cpp:

(WebCore::SVGRectElement::isSupportedAttribute):

• svg/SVGScriptElement.cpp:

(WebCore::SVGScriptElement::isSupportedAttribute):

• svg/SVGStopElement.cpp:

(WebCore::SVGStopElement::isSupportedAttribute):

• svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::isSupportedAttribute):

• svg/SVGSymbolElement.cpp:

(WebCore::SVGSymbolElement::isSupportedAttribute):

• svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::isSupportedAttribute):

• svg/SVGTests.cpp:

(WebCore::SVGTests::attributeToPropertyMap):

• svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::textLengthAnimated):
(WebCore::SVGTextContentElement::isSupportedAttribute):

• svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::isSupportedAttribute):

• svg/SVGTextPositioningElement.cpp:

(WebCore::SVGTextPositioningElement::isSupportedAttribute):

• svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::isSupportedAttribute):
(WebCore::isDisallowedElement):

• svg/SVGViewElement.cpp:

(WebCore::SVGViewElement::isSupportedAttribute):

3:35 AM Changeset in webkit [168468] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

[CSS Blending] Replacing Unisolated with NotIsolated in variables and methods names
​https://bugs.webkit.org/show_bug.cgi?id=132677

Patch by Ion Rosca <Ion Rosca> on 2014-05-08
Reviewed by Dirk Schulze.

No new tests required.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateAncestorChainHasBlendingDescendants):
(WebCore::RenderLayer::dirtyAncestorChainHasBlendingDescendants):
(WebCore::RenderLayer::updateDescendantDependentFlags):
hasUnisolatedBlendingDescendants -> hasNotIsolatedBlendingDescendants
(WebCore::RenderLayer::addChild):
(WebCore::RenderLayer::removeChild):
(WebCore::RenderLayer::updateStackingContextsAfterStyleChange):

• rendering/RenderLayer.h:

m_hasUnisolatedBlendingDescendants -> m_hasNotIsolatedBlendingDescendants
m_hasUnisolatedBlendingDescendantsStatusDirty -> m_hasNotIsolatedBlendingDescendantsStatusDirty
hasUnisolatedBlendingDescendants() -> hasNotIsolatedBlendingDescendants()
hasUnisolatedBlendingDescendantsStatusDirty() -> hasNotIsolatedBlendingDescendantsStatusDirty()
m_hasUnisolatedCompositedBlendingDescendants -> m_hasNotIsolatedCompositedBlendingDescendants
hasUnisolatedCompositedBlendingDescendants() -> hasNotIsolatedCompositedBlendingDescendants()
setHasUnisolatedCompositedBlendingDescendants() -> setHasNotIsolatedCompositedBlendingDescendants

• rendering/RenderLayerCompositor.cpp:

(WebCore::CompositingState::CompositingState):
m_hasUnisolatedCompositedBlendingDescendants -> m_hasNotIsolatedCompositedBlendingDescendants
(WebCore::RenderLayerCompositor::computeCompositingRequirements):

3:28 AM Changeset in webkit [168467] by calvaris@igalia.com

• 7 edits
  5 adds
  1 delete in trunk

[GTK] Enable skipped http/tests/media/hls/video-controls-live-stream.html
​https://bugs.webkit.org/show_bug.cgi?id=132329

Reviewed by Eric Carlson.

Source/WebCore:
GTK port needed to define what happened with live stream media
controls. Now we disable and dim the timeline and tweak the
timers.

Test: http/tests/media/hls/video-controls-live-stream.html.

• Modules/mediacontrols/mediaControlsGtk.js:

(ControllerGtk.prototype.configureControls): Moved logic from
setControlsType and changed to use an early return.
(ControllerGtk.prototype.reconnectControls): Redefined to just
configure the controls.
(ControllerGtk.prototype.handlePlay): If stream is live we don't
activate the current time just in case.
(ControllerGtk.prototype.updateDuration): Calls the superclass and
sets timeline.max to 0.
(ControllerGtk.prototype.setControlsType): Deleted.
(ControllerGtk.prototype.setIsLive): Configures controls and
disables the timeline if stream is live.

• css/mediaControlsGtk.css:

(audio::-webkit-media-controls-timeline[disabled])
(video::-webkit-media-controls-timeline[disabled]): Dimmed the
timeline by setting opacity to 0.3.

LayoutTests:
Tweaked test, created GTK results, unskipped in GTK and moved the
current general expectations to be mac only.

• http/tests/media/hls/video-controls-live-stream-expected.txt:

Moved.

• http/tests/media/hls/video-controls-live-stream.html: Dump tree

and check status of the timelime.

• media/media-controls.js:

(dumpMediaControlsTree): Added to dump the shadow dom tree.

• platform/gtk/TestExpectations: Unskipped video-controls-live-stream.
• platform/gtk/http/tests/media/hls/video-controls-live-stream-expected.txt: Added.
• platform/mac/http/tests/media/hls/video-controls-live-stream-expected.txt:

Moved from
LayoutTests/http/tests/media/hls/video-controls-live-stream-expected.txt
and rebaselined.

1:42 AM Changeset in webkit [168466] by mihnea@adobe.com

• 1 edit
  2 adds in trunk/LayoutTests

[CSS Regions] Content overflowing a fixed positioned region is clipped
​https://bugs.webkit.org/show_bug.cgi?id=118607

Reviewed by Andrei Bucur.

Fixed by the overflow in regions work, add test to prevent future regressions.

• fast/regions/fixed-pos-region-overflow-content-expected.html: Added.
• fast/regions/fixed-pos-region-overflow-content.html: Added.

1:16 AM Changeset in webkit [168465] by commit-queue@webkit.org

• 3 edits
  4 adds in trunk

[CSS Blending] Changing isolation CSS property should not trigger repaint in RenderStyle::changeRequiresLayerRepaint
​https://bugs.webkit.org/show_bug.cgi?id=131436

Patch by Ion Rosca <Ion Rosca> on 2014-05-08
Reviewed by Dirk Schulze.

Source/WebCore:
The isolation:isolate property will create a stacking context. This is done in
StyleResolver::adjustRenderStyle where z-index is forced to 0.
If the element is already a stacking context for any other reason,
changing the isolation flag should not have any effect.

Tests: css3/blending/repaint/blend-mode-turn-off-isolation-no-effect.html

css3/blending/repaint/blend-mode-turn-off-isolation.html

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresLayerRepaint):
do not request repaint if isolation has changed.

LayoutTests:

• css3/blending/repaint/blend-mode-turn-off-isolation-expected.txt: Added.
• css3/blending/repaint/blend-mode-turn-off-isolation-no-effect-expected.txt: Added.
• css3/blending/repaint/blend-mode-turn-off-isolation-no-effect.html: Added.
• css3/blending/repaint/blend-mode-turn-off-isolation.html: Added.

1:05 AM Changeset in webkit [168464] by Manuel Rego Casasnovas

• 4 edits
  2 adds in trunk

REGRESSION (r167652): SelectionState is not set properly for non leaf objects in pages with regions
​https://bugs.webkit.org/show_bug.cgi?id=132493

Reviewed by David Hyatt.

Source/WebCore:
Non selection leaf elements were not included in the selection ranges,
that was causing that their selection state was not set properly and
when one of the element was removed as it was marked as SelectionNone
current selection was not removed.

Due to this fix, the regression detected in bug #131982 arose again.
Reverted changes from r167675 and reopened bug as previous fix was not
right. Updated TestExpectations accordingly.

Test: fast/regions/selection/crash-select-all.html

• rendering/RenderView.cpp:

(WebCore::RenderView::splitSelectionBetweenSubtrees): We need to include
non selection leafs in the range, otherwise we won't be marking
selection state of some elements properly.

LayoutTests:

• TestExpectations: Marked

fast/regions/cssom/region-range-for-box-crash.html as crashing on
debug due to regression detected in bug #131982.

• fast/regions/selection/crash-select-all-expected.txt: Added.
• fast/regions/selection/crash-select-all.html: Added.

12:57 AM Changeset in webkit [168463] by zoltan@webkit.org

• 3 edits
  4 adds in trunk

[CSS Shapes] Can't select content within the area of the floating box when clip-path is applied
​https://bugs.webkit.org/show_bug.cgi?id=131375

Reviewed by Dirk Schulze.

Source/WebCore:
According to ​http://www.w3.org/TR/css-masking-1/, the clipped part of the element should
not have pointer event dispatching. So add this logic to RenderBlock::nodeAtPoint. This
fixes the bug as it disallows selection on any clipped parts.

I implemented the proper selection for the various CSS box types and added testing
for them. Also, I made and run performance tests for exposing mouse events over the
clipped/non-clipped area, which results can be seen in bugzilla.

Based on the patch made by Rob Buis <​rob.buis@samsung.com>
Blink revision: ​http://src.chromium.org/viewvc/blink?view=revision&revision=172619

Tests: fast/masking/clip-path-selection.html

fast/shapes/shape-outside-floats/shape-outside-clip-path-selection.html

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::nodeAtPoint):

LayoutTests:

• fast/masking/clip-path-selection-expected.txt: Added.
• fast/masking/clip-path-selection.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-clip-path-selection-expected.txt: Added.
• fast/shapes/shape-outside-floats/shape-outside-clip-path-selection.html: Added.

May 7, 2014:

10:42 PM Changeset in webkit [168462] by commit-queue@webkit.org

• 10 edits
  12 adds in trunk

[CSS Blending] Blending doesn't work if the parent stacking context is not a self painting layer
​https://bugs.webkit.org/show_bug.cgi?id=130891

Patch by Ion Rosca <Ion Rosca> on 2014-05-07
Reviewed by Dean Jackson.

Source/WebCore:
The stacking context layers having unisolated blending descendants should be able
to create transparency layers or to become composited in order to restrict blending
content to accessing the information outside the current stacking context.
Some layers are not self painting layers and these layers cannot crate transparency
layers and cannot be composited, thus they are not able to isolate blending descendants
when it's required.

The solution in this patch is to make a layer isSelfPaintingLayer when
it needs to isolate blending descendants (hasUnisolatedBlendingDescendants).

Tests: css3/blending/blend-mode-isolation-accelerated-overflow-hidden.html

css3/blending/blend-mode-isolation-overflow-hidden.html
css3/blending/blend-mode-isolation-turn-off-self-painting-layer.html
css3/blending/blend-mode-isolation-turn-off-self-painting-layer1.html
css3/blending/blend-mode-isolation-turn-off-self-painting-layer2.html
css3/blending/blend-mode-isolation-turn-on-self-painting-layer.html

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateAncestorChainHasBlendingDescendants):
When hasUnisolatedBlendingDescendants is set we make sure that isSelfPaintingLayer flag is set too.
(WebCore::RenderLayer::updateDescendantDependentFlags):
The flags might be read or changed while walking the descendants, so we don't want to reset
them before traversing the tree.
(WebCore::RenderLayer::shouldBeSelfPaintingLayer):
Adding isolatesBlending() condition for a layer to be self painting.

• rendering/RenderLayer.h:

Removing ASSERT from hasUnisolatedBlendingDescendants(). It crashes in minibrowser
and in layout tests when painting contents. Similar bugs on other flags: #71044, #71277.

• rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::styleDidChange):
Telling ancestors that blend mode property has been removed from CSS when the layer for
this element is going to be removed; styleChanged will not be called anymore.

LayoutTests:
Removed position:relative which forced tests to avoid this bug.

• css3/blending/blend-mode-accelerated-parent-overflow-hidden.html:
• css3/blending/blend-mode-clip-accelerated-blending-canvas.html:
• css3/blending/blend-mode-clip-accelerated-blending-child.html:
• css3/blending/blend-mode-clip-accelerated-blending-with-siblings.html:
• css3/blending/blend-mode-clip-accelerated-transformed-blending.html:

New tests:

• css3/blending/blend-mode-isolation-accelerated-overflow-hidden-expected.txt: Added.
• css3/blending/blend-mode-isolation-accelerated-overflow-hidden.html: Added.
• css3/blending/blend-mode-isolation-overflow-hidden-expected.html: Added.
• css3/blending/blend-mode-isolation-overflow-hidden.html: Added.
• css3/blending/blend-mode-isolation-turn-off-self-painting-layer-expected.txt: Added.
• css3/blending/blend-mode-isolation-turn-off-self-painting-layer.html: Added.
• css3/blending/blend-mode-isolation-turn-off-self-painting-layer1-expected.txt: Added.
• css3/blending/blend-mode-isolation-turn-off-self-painting-layer1.html: Added.
• css3/blending/blend-mode-isolation-turn-off-self-painting-layer2-expected.txt: Added.
• css3/blending/blend-mode-isolation-turn-off-self-painting-layer2.html: Added.
• css3/blending/blend-mode-isolation-turn-on-self-painting-layer-expected.txt: Added.
• css3/blending/blend-mode-isolation-turn-on-self-painting-layer.html: Added.

9:10 PM Changeset in webkit [168461] by commit-queue@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r168451.
​https://bugs.webkit.org/show_bug.cgi?id=132670

Not a speed-up, just do what other compilers do. (Requested by
kling on #webkit).

Reverted changeset:

"[X86] Emit BT instruction for single-bit tests."
​https://bugs.webkit.org/show_bug.cgi?id=132650
​http://trac.webkit.org/changeset/168451

7:51 PM Changeset in webkit [168460] by mmaxfield@apple.com

• 4 edits
  2 adds in trunk

Dragging text from one paragraph to another does not render as expected
​https://bugs.webkit.org/show_bug.cgi?id=132633

Reviewed by Darin Adler and Ryosuke Niwa.

Source/WebCore:
When we are dragging and dropping into a content editable field, we detect
if we are trying to put a <p> into an existing <p>, and if so, split the
outer <p> and insert the new <p> as its sibling. However, the outer <p>
might not be editable, so we don't want to do any splitting and inserting
at that location.

Test: editing/pasteboard/drag-drop-paragraph-crasher.html

• editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::makeInsertedContentRoundTrippableWithHTMLTreeBuilder):

LayoutTests:
The problem occurs when dragging text that includes a <p> into an editable
area that has a <p> as a parent.

• editing/pasteboard/drag-drop-paragraph-crasher-expected.txt: Added.
• editing/pasteboard/drag-drop-paragraph-crasher.html: Added.

7:35 PM Changeset in webkit [168459] by fpizlo@apple.com

• 10 edits in trunk/Source

Source/JavaScriptCore: Make Executable::clearCode() actually clear all of the entrypoints, and
clean up some other FTL-related calling convention stuff.
<rdar://problem/16720172>

Rubber stamped by Mark Hahnenberg.

• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGWorklist.cpp:

(JSC::DFG::Worklist::Worklist):
(JSC::DFG::Worklist::finishCreation):
(JSC::DFG::Worklist::create):
(JSC::DFG::ensureGlobalDFGWorklist):
(JSC::DFG::ensureGlobalFTLWorklist):

• dfg/DFGWorklist.h:
• heap/CodeBlockSet.cpp:

(JSC::CodeBlockSet::dump):

• heap/CodeBlockSet.h:
• runtime/Executable.cpp:

(JSC::ExecutableBase::clearCode):

Source/WTF: UNREACHABLE_FOR_PLATFORM() is meant to be a release crash.

Rubber stamped by Mark Hahnenberg..

• wtf/Assertions.h:

(UNREACHABLE_FOR_PLATFORM):

6:42 PM Changeset in webkit [168458] by gyuyoung.kim@samsung.com

• 7 edits
  3 adds in trunk

[CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
​https://bugs.webkit.org/show_bug.cgi?id=126022

Reviewed by Benjamin Poulain.

Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.

Source/WebCore:
When user is navigating back/forward to a page that has been scrolled and/or scaled, that page must be shown
with its last scroll position and scale factor. However, when fixed layout was enabled with CoordinatedGraphics
and TILED_BACKING_STORE, Page::setPageScaleFactor() doesn't send previous scroll position since r165652 and r165913.

This patch allows the Page::setPageScaleFactor() send stored position to WK2 implementation by calling delegatedScrollRequested()
directly when delegatesScrolling() is on.

• page/Page.cpp:

(WebCore::Page::setPageScaleFactor): TILED_BACKING_STORE and delegateScrolling are enabled, we pass new scroll position to WK2 though
delegateScrolling is disabled.

• platform/ScrollView.cpp: delegatedScrollRequested() call is moved from ScrollView::setScrollPosition() to Page::setPageScaleFactor().

(WebCore::ScrollView::setScrollPosition):

Source/WebKit2:
When user is navigating back/forward to a page that has been scrolled and/or scaled, that page must be shown
with its last scroll position and scale factor. However, when fixed layout was enabled with CoordinatedGraphics
and TILED_BACKING_STORE, Page::setPageScaleFactor() doesn't send previous scroll position since r165652 and r165913.

This patch allows the Page::setPageScaleFactor() send stored position to WK2 implementation.

• UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::didCommitLoadForMainFrame):

Tools:
Added an unit test case to check if scroll position and scale are restored properly.

• TestWebKitAPI/PlatformEfl.cmake:
• TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.

(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::didChangeContentsPosition):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
• TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.

6:30 PM Changeset in webkit [168457] by dino@apple.com

• 3 edits
  2 adds in trunk

Using a fill pattern much larger than actual canvas reliably segfaults browser
​https://bugs.webkit.org/show_bug.cgi?id=132635

Reviewed by Simon Fraser.

Source/WebCore:
Make sure that createPattern checks that the canvas it is about to use
as a source is valid.

Test: fast/canvas/pattern-too-large-to-create.html

• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::createPattern): Check that the source canvas has
an ok ImageBuffer.

LayoutTests:
Test case that makes a huge canvas and tries to create a pattern out of it.

• fast/canvas/pattern-too-large-to-create-expected.html: Added.
• fast/canvas/pattern-too-large-to-create.html: Added.

6:16 PM Changeset in webkit [168456] by Simon Fraser

• 2 edits in trunk/Source/WebKit2

Put a better version of the assertion back, and add one when we ensureBackingStore.

Reviewed by Tim Horton.

• WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::recursiveBuildTransaction):
(WebKit::PlatformCALayerRemote::ensureBackingStore):

5:48 PM Changeset in webkit [168455] by Simon Fraser

• 2 edits in trunk/Source/WebKit2

This assertion was wrong and fired every time. Remove it.

• WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::recursiveBuildTransaction):

5:20 PM Changeset in webkit [168454] by Brent Fulgham

• 2 edits in trunk/Source/WebKit

[Win] Unreviewed 64-bit build fix.

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add

correct 64-bit symbol definitions.

5:07 PM Changeset in webkit [168453] by ggaren@apple.com

• 3 edits in trunk/LayoutTests

REGRESSION (r161429?): Frequent crashes on media/track/media-element-enqueue-event-crash.html
​https://bugs.webkit.org/show_bug.cgi?id=117756

Reviewed by Mark Hahnenberg.

Re-enabled this test because it doesn't seem to crash anymore.

• media/track/media-element-enqueue-event-crash.html: Reduced the number

of test runs because otherwise this test often times out.

• platform/mac/TestExpectations: Re-enable this test because I ran it

for about a minute on my Mac Pro without crashing.

4:28 PM Changeset in webkit [168452] by psolanki@apple.com

• 7 edits in trunk/Source

Use system defaults for hardware jpeg decoding
​https://bugs.webkit.org/show_bug.cgi?id=132661
<rdar://problem/11348201>

Reviewed by Tim Horton.

Remove code that explicitly disabled hardware image decoding. Let the system decide what to do.

Source/WebCore:

• WebCore.exp.in:
• platform/graphics/ImageSource.h:

(WebCore::ImageSource::acceleratedImageDecodingEnabled): Deleted.
(WebCore::ImageSource::setAcceleratedImageDecodingEnabled): Deleted.

• platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::imageSourceOptions):

Source/WebKit/mac:

• WebView/WebView.mm:

(+[WebView _setAcceleratedImageDecoding:]):
(+[WebView _acceleratedImageDecoding]): Deleted.

• WebView/WebViewPrivate.h:

4:22 PM Changeset in webkit [168451] by akling@apple.com

• 3 edits in trunk/Source/JavaScriptCore

[X86] Emit BT instruction for single-bit tests.
<​https://webkit.org/b/132650>

Implement test-bit-and-branch slightly more efficiently by using
BT + JC/JNC instead of TEST + JZ/JNZ when we're only testing for
a single bit.

Reviewed by Michael Saboff.

• assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::singleBitIndex):
(JSC::MacroAssemblerX86Common::branchTest32):

• assembler/X86Assembler.h:

(JSC::X86Assembler::bt_i8r):
(JSC::X86Assembler::bt_i8m):

4:06 PM Changeset in webkit [168450] by matthew_hanson@apple.com

• 1 copy in tags/Safari-537.76.3

New Tag.

4:02 PM Changeset in webkit [168449] by matthew_hanson@apple.com

• 2 edits in branches/safari-537.76-branch/LayoutTests/fast/forms

Remove unneccessary newline from layout tests.

3:48 PM Changeset in webkit [168448] by stavila@adobe.com

• 6 edits
  2 adds in trunk

Use after free in WebCore::RenderObject::nextSibling / WebCore::RenderBoxModelObject::moveChildrenTo
​https://bugs.webkit.org/show_bug.cgi?id=132625

Reviewed by David Hyatt.

Source/WebCore:
Fixed problem with dynamically inserting first letter elements.

Test: fast/multicol/newmulticol/first-letter-create.html

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::getFirstLetter):
(WebCore::RenderBlock::updateFirstLetter):

• rendering/RenderBlock.h:
• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::moveChildrenTo):

LayoutTests:
Added test for special case which might cause use after free.

• fast/multicol/newmulticol/first-letter-create-expected.html: Added.
• fast/multicol/newmulticol/first-letter-create.html: Added.

3:42 PM Changeset in webkit [168447] by enrica@apple.com

• 7 edits in trunk/Source

WK2: Programatic scroll requests during scroll or zoom animation to reveal focused element are ignored.
​https://bugs.webkit.org/show_bug.cgi?id=132657
<rdar://problem/16468462>

Reviewed by Benjamin Poulain.

With the scrolling model we use on iOS, a programatic scroll
request can be received while we are still animating to reveal

Source/WebCore:
the focused input element. The WebProcess is unaware that the
scroll position is being changed in the UIProcess, and does not
honor the scroll request from JavaScript.
This is patch changes the behavior for clients using scroll delegates
to always send the scroll request to the UIProcess without checking
the current scroll position.

• page/FrameView.h:
• platform/ScrollView.cpp:

(WebCore::ScrollView::setScrollPosition):

• platform/ScrollView.h:

(WebCore::ScrollView::inProgrammaticScroll):

Source/WebKit2:
the focused input element. Changing the scroll offset while animating
leads to unpredictable results. We now cancel the animation if
a programatic scroll request is received.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _scrollToContentOffset:WebCore::]):

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getAssistedNodeInformation):

3:15 PM Changeset in webkit [168446] by Lucas Forschler

• 5 edits in tags/Safari-538.34/Source/WebCore

Merged r168440.

3:15 PM Changeset in webkit [168445] by Simon Fraser

• 2 edits in trunk/Source/WebKit2

[iOS WK2] Speculative fix for crash in PlatformCALayerRemote::recursiveBuildTransaction
​https://bugs.webkit.org/show_bug.cgi?id=132666

Reviewed by Tim Horton.

Crash reports suggest that owner() can be null. Assert and protect
against this.

• WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::recursiveBuildTransaction):

3:00 PM Changeset in webkit [168444] by matthew_hanson@apple.com

• 1 edit
  4 adds in branches/safari-537.76-branch/LayoutTests

Add layout tests that were not merged with r168098.

3:00 PM Changeset in webkit [168443] by mark.lam@apple.com

• 26 edits
  1 add in trunk/Source/JavaScriptCore

REGRESSION(r166678): Dromaeo/cssquery-dojo.html crashes regularly.
<​https://webkit.org/b/131356>

Reviewed by Geoffrey Garen.

The issue is that GC needs to be made aware of writes to m_inferredValue
in the VariableWatchpointSet, but was not. As a result, if a JSCell*
is written to a VariableWatchpointSet m_inferredValue, and that JSCell
does not survive an eden GC shortly after, we will end up with a stale
JSCell pointer left in the m_inferredValue.

This issue can be detected more easily by running Dromaeo/cssquery-dojo.html
using DumpRenderTree with the VM heap in zombie mode.

The fix is to change VariableWatchpointSet m_inferredValue to type
WriteBarrier<Unknown> and ensure that VariableWatchpointSet::notifyWrite()
is executed by all the execution engines so that the WriteBarrier semantics
are honored.

We still check if the value to be written is the same as the one in the
inferredValue. We'll by-pass calling the slow path notifyWrite() if the
values are the same.

• JavaScriptCore.xcodeproj/project.pbxproj:
• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

• need to pass the symbolTable to prepareToWatch() because it will be needed for instantiating the VariableWatchpointSet in prepareToWatch().

• bytecode/VariableWatchpointSet.h:

(JSC::VariableWatchpointSet::VariableWatchpointSet):

• VariableWatchpointSet now tracks its owner symbol table for its m_inferredValue write barrier, and yes, m_inferredValue is now of type WriteBarrier<Unknown>.

(JSC::VariableWatchpointSet::inferredValue):
(JSC::VariableWatchpointSet::invalidate):
(JSC::VariableWatchpointSet::finalizeUnconditionally):
(JSC::VariableWatchpointSet::addressOfInferredValue):
(JSC::VariableWatchpointSet::notifyWrite): Deleted.

• bytecode/VariableWatchpointSetInlines.h: Added.

(JSC::VariableWatchpointSet::notifyWrite):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::cellConstant):

• Added an assert in case we try to make constants of zombified JSCells again.

• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• We now let the slow path handle the cases when the VariableWatchpointSet is in state ClearWatchpoint and IsWatched, and the slow path will ensure that we handle the needed write barrier semantics correctly. We will by-pass the slow path if the value being written is the same as the inferred value.

• ftl/FTLIntrinsicRepository.h:
• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNotifyWrite):

• Let the slow path handle the cases when the VariableWatchpointSet is in state ClearWatchpoint and IsWatched. We will by-pass the slow path if the value being written is the same as the inferred value.

• heap/Heap.cpp:

(JSC::Zombify::operator()):

• Use a different value for the zombified bits (to distinguish it from 0xbbadbeef which is used everywhere else).
• heap/Heap.h:

(JSC::Heap::isZombified):

• Provide a convenience test function to check if JSCells are zombified. This is currently only used in an assertion in the DFG bytecode parser, but the intent it that we'll apply this test in other strategic places later to help with early detection of usage of GC'ed objects when we run in zombie mode.

• jit/JITOpcodes.cpp:

(JSC::JIT::emitSlow_op_captured_mov):

• jit/JITOperations.h:
• jit/JITPropertyAccess.cpp:

(JSC::JIT::emitNotifyWrite):

• jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitNotifyWrite):
(JSC::JIT::emitSlow_op_put_to_scope):

• Let the slow path for notifyWrite handle the cases when the VariableWatchpointSet is in state ClearWatchpoint and IsWatched. We will by-pass the slow path if the value being written is the same as the inferred value.

• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:
• Let the slow path for notifyWrite handle the cases when the VariableWatchpointSet is in state ClearWatchpoint and IsWatched. We will by-pass the slow path if the value being written is the same as the inferred value.

• runtime/CommonSlowPaths.cpp:

• runtime/JSCJSValue.h: Fixed some typos in the comments.
• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::addGlobalVar):
(JSC::JSGlobalObject::addFunction):

• runtime/JSSymbolTableObject.h:

(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes):

• runtime/SymbolTable.cpp:

(JSC::SymbolTableEntry::prepareToWatch):
(JSC::SymbolTableEntry::notifyWriteSlow):

• runtime/SymbolTable.h:

(JSC::SymbolTableEntry::notifyWrite):

2:59 PM Changeset in webkit [168442] by Brent Fulgham

• 15 edits
  2 adds in trunk/Source

[Mac, iOS] REGRESSION: WK2 YouTube support
​https://bugs.webkit.org/show_bug.cgi?id=132568
<rdar://problem/11464344>

Reviewed by Darin Adler.

Source/WebCore:
Move the custom YouTube loader code out of the WebFrameLoaderClient into a
PluginReplacement-based class.

• Modules/plugins/PluginReplacement.h:

(WebCore::PluginReplacement::supportsURL): New predicate so we can restrict
use of a plugin to a particular category of URLs.

• Modules/plugins/QuickTimePluginReplacement.mm:

(WebCore::QuickTimePluginReplacement): Updated for new registrar signature.

• Modules/plugins/YouTubePluginReplacement.h: Added.

(WebCore::YouTubePluginReplacement::parentElement):

• Modules/plugins/YouTubePluginReplacement.cpp: Added.

(WebCore::YouTubePluginReplacement::registerPluginReplacement):
(WebCore::YouTubePluginReplacement::create):
(WebCore::YouTubePluginReplacement::supportsMimeType):
(WebCore::YouTubePluginReplacement::supportsFileExtension):
(WebCore::kit):
(WebCore::YouTubePluginReplacement::YouTubePluginReplacement):
(WebCore::YouTubePluginReplacement::createElementRenderer):
(WebCore::objectForKey):
(WebCore::YouTubePluginReplacement::installReplacement):
(WebCore::createYouTubeURL):
(WebCore::processAndCreateYouTubeURL):
(WebCore::YouTubePluginReplacement::youTubeURL):

• WebCore.exp.in: Add new export from WebCore.
• WebCore.xcodeproj/project.pbxproj:
• html/HTMLPlugInElement.cpp:

(WebCore::pluginReplacementForType): Update to also check that the URL is supported
by the plugin.
(WebCore::registeredPluginReplacements): Add new YouTubePluginReplacement to registry.

• html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::createElementRenderer): Remove custom YouTube code
now that this logic is handled in the plugin replacement class.
(WebCore::HTMLPlugInImageElement::createShadowIFrameSubtree): Deleted.

• html/HTMLPlugInImageElement.h:
• html/shadow/YouTubeEmbedShadowElement.cpp:

(WebCore::YouTubeEmbedShadowElement::YouTubeEmbedShadowElement):
(WebCore::YouTubeEmbedShadowElement::shadowPseudoId): Use correct pseudoID for the
plugin replacement architecture.

• html/shadow/YouTubeEmbedShadowElement.h:
• platform/mac/WebCoreNSURLExtras.h:
• platform/mac/WebCoreNSURLExtras.mm:

(WebCore::unescapedQueryValue): Moved from WebKit/Misc/WebNSURLExtras.
(WebCore::queryKeysAndValues): Ditto.

Source/WebKit/mac:

• Misc/WebNSURLExtras.h:
• Misc/WebNSURLExtras.mm: Remove code that has been converted to C++

and added to YouTubePluginReplacement.cpp.
(-[NSURL _webkit_youTubeURL]):
(-[NSString _webkit_queryKeysAndValues]):
(createYouTubeURL): Deleted.
(-[NSString _webkit_unescapedQueryValue]): Deleted.

2:57 PM Changeset in webkit [168441] by mitz@apple.com

• 3 edits in trunk/Source/WebKit2

<rdar://problem/16831276> [iOS] Unparenting a WKWebView that’s loading pauses it
​https://bugs.webkit.org/show_bug.cgi?id=132659

Reviewed by Tim Horton.

• UIProcess/Cocoa/NavigationState.h: Added a member variable.
• UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::didChangeIsLoading): When transitioning into loading state,
acquire a background activity token. When transitioning out of loading state, dispose of
the token.

2:49 PM Changeset in webkit [168440] by Simon Fraser

• 5 edits in trunk/Source/WebCore

[iOS] Acclerated overflow-scrolling broken in WK1
​https://bugs.webkit.org/show_bug.cgi?id=132665
<rdar://problem/16842909>

Reviewed by Tim Horton.

r168301 added a CALayer delegate to disable implicit animations,
but for some layers we wrap them in UIViews (which are themselves
layer delegates), so bad things happened.

Fix by falling back to setting the null actions dictionary for
layers with custom scrolling behavior.

• platform/graphics/GraphicsLayer.h:
• platform/graphics/ca/mac/PlatformCALayerMac.h:
• platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayerMac::updateCustomBehavior):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateScrollingLayers):

2:19 PM Changeset in webkit [168439] by commit-queue@webkit.org

• 9 edits in trunk/Source

HTMLMediaElement should exitFullscreen when view is removed from the window.
​https://bugs.webkit.org/show_bug.cgi?id=132506

Patch by Jeremy Jones <​jeremyj@apple.com> on 2014-05-07
Reviewed by Tim Horton.

Source/WebCore:

• platform/ios/WebVideoFullscreenControllerAVKit.h:

Add -requestExitFullscreen.

• platform/ios/WebVideoFullscreenControllerAVKit.mm:

(-[WebVideoFullscreenController requestExitFullscreen]):
Forward request onto WebVideoFullscreenModelMediaElement.

• platform/ios/WebVideoFullscreenModelMediaElement.mm:

(WebVideoFullscreenModelMediaElement::requestExitFullscreen):
Add some protection here since this may be called when not in fullscreen.

Source/WebKit/mac:

• WebView/WebView.mm:

(-[WebView viewDidMoveToWindow]):
Request WebVideoFullscreenController to exitFullscreen when view is removed from the window.

Source/WebKit2:

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::viewStateDidChange):
Request WebVideoFUllscreenManagerProxy to exitFullscreen when removed from the window.

• UIProcess/ios/WebVideoFullscreenManagerProxy.h:

Make requestExitFullscreen() public instead of private.

2:17 PM Changeset in webkit [168438] by beidson@apple.com

• 2 edits in trunk/Source/WebKit/mac

Image menu is offset by the amount the view is scrolled
<rdar://problem/16818966> and ​https://bugs.webkit.org/show_bug.cgi?id=132663

Reviewed by Tim Horton.

• WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::showContextMenu): Use FrameView::contentsToWindow instead of contentsToRoot,

and skip the [NSView convertPoint:toView:] step.

1:03 PM Changeset in webkit [168437] by dino@apple.com

• 3 edits in trunk/Source/WebCore

Clean up the difference between painting focus rings and adding PDF annotations
​https://bugs.webkit.org/show_bug.cgi?id=132638

Follow-up comments from Darin Adler.

• rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutline): Move "else if" to a separate "if" for clarity.

• rendering/RenderObject.cpp:

(WebCore::RenderObject::paintFocusRing): Don't guard against outlineIsAuto(). ASSERT instead.
(WebCore::RenderObject::addPDFURLRect): Give "rect" variable a better name.
(WebCore::RenderObject::paintOutline): Move "else if" to a separate "if" for clarity.

12:59 PM Changeset in webkit [168436] by Lucas Forschler

• 3 edits
  2 deletes in branches/safari-537.76-branch

Rollout r168104.

11:57 AM Changeset in webkit [168435] by ap@apple.com

• 19 edits in trunk/Source

Make blob size computation lazy
​https://bugs.webkit.org/show_bug.cgi?id=132653

Reviewed by Anders Carlsson.

Source/WebCore:

• fileapi/Blob.cpp:

(WebCore::Blob::Blob):
(WebCore::Blob::size):

• fileapi/Blob.h:

(WebCore::Blob::size): Deleted.

• fileapi/File.cpp:

(WebCore::File::size): Deleted.

• fileapi/File.h:
• fileapi/ThreadableBlobRegistry.cpp:

(WebCore::ThreadableBlobRegistry::registerFileBlobURL):
(WebCore::ThreadableBlobRegistry::registerBlobURL):
(WebCore::ThreadableBlobRegistry::registerBlobURLForSlice):
(WebCore::ThreadableBlobRegistry::blobSize):
(WebCore::ThreadableBlobRegistry::unregisterBlobURL):
(WebCore::unregisterBlobURLTask): Deleted.

• fileapi/ThreadableBlobRegistry.h:
• platform/network/BlobData.cpp:

(WebCore::BlobData::appendData):

• platform/network/BlobRegistry.h:
• platform/network/BlobRegistryImpl.cpp:

(WebCore::BlobRegistryImpl::registerBlobURL):
(WebCore::BlobRegistryImpl::registerBlobURLForSlice):

• platform/network/BlobRegistryImpl.h:

Source/WebKit2:

• NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:

(WebKit::NetworkBlobRegistry::registerBlobURL):
(WebKit::NetworkBlobRegistry::registerBlobURLForSlice):
(WebKit::NetworkBlobRegistry::blobSize):

• NetworkProcess/FileAPI/NetworkBlobRegistry.h:
• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::registerBlobURL):
(WebKit::NetworkConnectionToWebProcess::registerBlobURLForSlice):
(WebKit::NetworkConnectionToWebProcess::blobSize):

• NetworkProcess/NetworkConnectionToWebProcess.h:
• NetworkProcess/NetworkConnectionToWebProcess.messages.in:
• WebProcess/FileAPI/BlobRegistryProxy.cpp:

(WebKit::BlobRegistryProxy::registerBlobURL):
(WebKit::BlobRegistryProxy::registerBlobURLForSlice):
(WebKit::BlobRegistryProxy::blobSize):

• WebProcess/FileAPI/BlobRegistryProxy.h:

11:49 AM Changeset in webkit [168434] by Simon Fraser

• 7 edits in trunk

WebKit1 is flashy when compositing layers come and go
​https://bugs.webkit.org/show_bug.cgi?id=132655

Source/WebKit/mac:

Reviewed by Sam Weinig.

In r166117 I removed code to flush compositing layers in FrameView::paintContents(),
which caused problems when painting iframes. However, this removed a flush
that WebKit1 relied on to flush compositing layers when painting, which caused
flashing when compositing layers come and go, and broke WebView snapshotting
in some cases.

Fix by adding back compositing layer flushing, but this time in WebKit1's
-viewWillDraw code path. This allows removal of some flushing in DumpRenderTree.

• WebView/WebHTMLView.mm:

(-[WebHTMLView viewWillDraw]):

• WebView/WebView.mm:

(-[WebView _flushCompositingChanges]):

• WebView/WebViewInternal.h:
• WebView/WebViewPrivate.h:

Tools:
<rdar://problem/16830981&16788846>

Reviewed by Sam Weinig.

Revert the change from r166117.

• DumpRenderTree/mac/DumpRenderTree.mm:

(updateDisplay):

11:42 AM Changeset in webkit [168433] by Simon Fraser

• 7 edits in trunk/Source

Add scrolling tree logging to RemoteLayerTree output
​https://bugs.webkit.org/show_bug.cgi?id=132640

Reviewed by Beth Dakin.

Source/WebCore:

Support scrolling tree logging in the RemoteLayerTree log channel
output.

ScrollingStateTree::commit() unconditionally set treeStateClone->m_hasChangedProperties
to true, but we should set it based on original scrolling state tree's
m_hasChangedProperties.

We have to encode all of the scrolling state nodes anyway (they only encode
changed properties), but we can use this for future optimizations, and to
avoid spurious logging.

• WebCore.exp.in: Export a couple of things we need.
• page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::commit):

Source/WebKit2:

Support scrolling tree logging in the RemoteLayerTree log channel
output.

Encode/decode ScrollingStateTree::hasChangedProperties() so we can use
it to avoid logging. Log all the things.

• Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:

(WebKit::RemoteScrollingCoordinatorTransaction::encode):
(WebKit::RemoteScrollingCoordinatorTransaction::decode):
(WebKit::RemoteScrollingTreeTextStream::RemoteScrollingTreeTextStream):
(WebKit::RemoteScrollingTreeTextStream::increaseIndent):
(WebKit::RemoteScrollingTreeTextStream::decreaseIndent):
(WebKit::RemoteScrollingTreeTextStream::writeIndent):
(WebKit::dumpProperty):
(WebKit::RemoteScrollingTreeTextStream::operator<<):
(WebKit::RemoteScrollingTreeTextStream::dump):
(WebKit::RemoteScrollingTreeTextStream::recursiveDumpNodes):
(WebKit::RemoteScrollingCoordinatorTransaction::description):
(WebKit::RemoteScrollingCoordinatorTransaction::dump):

• Shared/Scrolling/RemoteScrollingCoordinatorTransaction.h:
• UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):

11:32 AM Changeset in webkit [168432] by Chris Fleizach

• 5 edits
  2 adds in trunk

AX: aria-expanded changes are not communicated to clients
​https://bugs.webkit.org/show_bug.cgi?id=132642

Reviewed by Mario Sanchez Prada.

Source/WebCore:
When aria-expanded changes on non list/tree items, send out a generic
AXExpandedChange notification.

Test: platform/mac/accessibility/expanded-notification.html

• accessibility/AXObjectCache.h:
• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::handleAriaExpandedChanged):

• accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

LayoutTests:

• platform/mac/accessibility/expanded-notification-expected.txt: Added.
• platform/mac/accessibility/expanded-notification.html: Added.

11:24 AM Changeset in webkit [168431] by ap@apple.com

• 2 edits in trunk/Source/WebCore

Release build fix.

• platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypes):

Removed unused globals.

11:19 AM Changeset in webkit [168430] by ap@apple.com

• 7 edits in trunk/Source/WebCore

Eliminate "well known MIME type" support
​https://bugs.webkit.org/show_bug.cgi?id=132654

Reviewed by Anders Carlsson.

Vestiges of FileSystem API.

• dom/DataTransfer.cpp:

(WebCore::DataTransfer::files):
(WebCore::DataTransfer::hasFileOfType):

• fileapi/File.cpp:

(WebCore::File::File):
(WebCore::File::contentTypeFromFilePathOrName):

• fileapi/File.h:
• html/FileInputType.cpp:

(WebCore::FileInputType::createFileList):

• platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypes):
(WebCore::findMimeType): Deleted.
(WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension): Deleted.

• platform/MIMETypeRegistry.h:

11:13 AM Changeset in webkit [168429] by oliver@apple.com

• 2 edits in trunk/Source/WebKit

Fix windows build.

10:29 AM Changeset in webkit [168428] by ch.dumez@samsung.com

• 4 edits
  2 adds in trunk

[HTML] Default argument to HTMLTableElement.insertRow() should be -1
​https://bugs.webkit.org/show_bug.cgi?id=132651

Reviewed by Alexey Proskuryakov.

Source/WebCore:
HTMLTableElement.insertRow()'s argument default value should be -1, not 0,
as per the specification:
​http://www.whatwg.org/specs/web-apps/current-work/multipage/tabular-data.html#htmltableelement

The new behavior matches the one of Firefox 29 and IE11, and soon Blink:
​https://codereview.chromium.org/270213007/

Test: fast/dom/HTMLTableElement/insertRow-default-argument.html

• html/HTMLTableElement.h:
• html/HTMLTableElement.idl:

LayoutTests:
Add layout test to test that the default argument to HTMLTableElement.insertRow()
is -1.

• fast/dom/HTMLTableElement/insertRow-default-argument-expected.txt: Added.
• fast/dom/HTMLTableElement/insertRow-default-argument.html: Added.

9:17 AM Changeset in webkit [168427] by Chris Fleizach

• 22 edits in trunk

AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
​https://bugs.webkit.org/show_bug.cgi?id=132622

Reviewed by Mario Sanchez Prada.

Source/WebCore:
The select text with criteria mechanism used through accessibility needs to support
a few more parameters to be complete (including capitalize, lowercase and uppercase).

Updated: accessibility/select-text.html

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::selectText):

• accessibility/AccessibilityObject.h:
• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(accessibilitySelectTextCriteriaForCriteriaParameterizedAttribute):

• rendering/RenderText.cpp:

(WebCore::makeCapitalized):

• rendering/RenderText.h:

Tools:

• DumpRenderTree/AccessibilityUIElement.cpp:

(selectTextWithCriteriaCallback):
(isEqualCallback):

• DumpRenderTree/AccessibilityUIElement.h:
• DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::selectTextWithCriteria):

• DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(AccessibilityUIElement::selectTextWithCriteria):

• DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(selectTextParameterizedAttributeForCriteria):
(AccessibilityUIElement::selectTextWithCriteria):

• DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::selectTextWithCriteria):

• WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::selectTextWithCriteria):

• WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
• WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
• WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::selectTextWithCriteria):

• WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:

(WTR::AccessibilityUIElement::selectTextWithCriteria):

• WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::selectTextParameterizedAttributeForCriteria):
(WTR::AccessibilityUIElement::selectTextWithCriteria):

LayoutTests:

• platform/mac/accessibility/select-text-expected.txt:
• platform/mac/accessibility/select-text.html:

8:07 AM WebKitGTK/2.4.x edited by berto@igalia.com

(diff)

7:54 AM Changeset in webkit [168426] by g.czajkowski@samsung.com

• 4 edits
  2 adds
  2 deletes in trunk/LayoutTests

Share mac/editing/spelling/editing-multiple-words-with-markers.html with other platforms
​https://bugs.webkit.org/show_bug.cgi?id=132649

Reviewed by Ryosuke Niwa.

This test does not verify autocorrection feature which is only implemented
by Mac. Other WebKit ports might be interested in running it due to
verification of spelling markers after merging two misspelled words.

Additionally, add the test case confirming spelling markers
before any selection change.

Due to bug 125689, this test starts using asynchronous spellchecking.

• editing/spelling/editing-multiple-words-with-markers-expected.txt:

Renamed from platform/mac/editing/spelling/editing-multiple-words-with-markers-expected.txt

• editing/spelling/editing-multiple-words-with-markers.html:

Renamed from platform/mac/editing/spelling/editing-multiple-words-with-markers.html

• platform/gtk/TestExpectations:
• platform/mac-wk2/TestExpectations:
• platform/win/TestExpectations:

Mark editing-multiple-words-with-markers.html as failing since those
platforms didn't turn on asynchronous spellchecking.

7:07 AM Changeset in webkit [168425] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

DocumentLoader::dataReceived assertion failed
​https://bugs.webkit.org/show_bug.cgi?id=132017

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-05-07
Reviewed by Brent Fulgham.

We need to call didReceiveResponse client method before the didReceiveData client method, otherwise we get a lot of asserts.
This patch also fixes frequent crashes in downloadTimerCallback method on page loading.

• platform/network/curl/ResourceHandleManager.cpp:

(WebCore::calculateWebTimingInformations): Initialize local variables.
(WebCore::headerCallback): Call didReceiveResponse client method here instead of in downloadTimerCallback.
(WebCore::ResourceHandleManager::downloadTimerCallback): Remove call to didReceiveResponse method.
(WebCore::ResourceHandleManager::dispatchSynchronousJob): Removed empty line.

6:11 AM Changeset in webkit [168424] by Antti Koivisto

• 3 edits
  2 adds in trunk

REGRESSION: Animated GIF inside compositing layer never resumes animation when scrolled back into view
​https://bugs.webkit.org/show_bug.cgi?id=132608

Reviewed by Simon Fraser.

Source/WebCore:
Test: fast/repaint/animation-after-layer-scroll.html

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo):

Check if any animations need to be restarted after layer scroll.

LayoutTests:

• fast/repaint/animation-after-layer-scroll-expected.txt: Added.
• fast/repaint/animation-after-layer-scroll.html: Added.

4:44 AM Changeset in webkit [168423] by commit-queue@webkit.org

• 25 edits in trunk/Source

GraphicsLayer::client() should return a reference.
​https://bugs.webkit.org/show_bug.cgi?id=126372

Patch by Hyowon Kim <​hw1008.kim@samsung.com> on 2014-05-07
Reviewed by Simon Fraser.

GraphicsLayers always have a GraphicsLayerClient attached,
so make client() a reference and remove some unnecessary branches.
The author of the changes in the mac port is Andreas Kling <​akling@apple.com>.

Source/WebCore:

• WebCore.exp.in:
• platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::GraphicsLayer):
(WebCore::GraphicsLayer::willBeDestroyed):
(WebCore::GraphicsLayer::paintGraphicsLayerContents):
(WebCore::GraphicsLayer::addRepaintRect):
(WebCore::dumpChildren):
(WebCore::GraphicsLayer::dumpProperties):

• platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::client):
(WebCore::GraphicsLayer::pageScaleFactor):
(WebCore::GraphicsLayer::deviceScaleFactor):

• platform/graphics/GraphicsLayerFactory.h:
• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayer::create):
(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::initialize):
(WebCore::GraphicsLayerCA::platformCALayerAnimationStarted):
(WebCore::GraphicsLayerCA::computePositionRelativeToBase):
(WebCore::GraphicsLayerCA::flushCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerCA::computeVisibleRect):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::platformCALayerContentsScaleMultiplierForNewTiles):
(WebCore::GraphicsLayerCA::platformCALayerShouldAggressivelyRetainTiles):
(WebCore::GraphicsLayerCA::platformCALayerShouldTemporarilyRetainTileCohorts):
(WebCore::GraphicsLayerCA::updateContentsOpaque):
(WebCore::GraphicsLayerCA::updateContentsScale):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
(WebCore::GraphicsLayerCA::noteLayerPropertyChanged):

• platform/graphics/ca/GraphicsLayerCA.h:
• platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayer::create):
(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::notifyChange):
(WebCore::GraphicsLayerTextureMapper::commitLayerChanges):

• platform/graphics/texmap/GraphicsLayerTextureMapper.h:
• platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:

(WebCore::CompositingCoordinator::createRootLayer):
(WebCore::CompositingCoordinator::createGraphicsLayer):

• platform/graphics/texmap/coordinated/CompositingCoordinator.h:
• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::notifyFlushRequired):
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::computeTransformedVisibleRect):
(WebCore::CoordinatedGraphicsLayer::animationStartedTimerFired):

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::createGraphicsLayer):

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateLayerForTopOverhangArea):
(WebCore::RenderLayerCompositor::updateLayerForBottomOverhangArea):
(WebCore::RenderLayerCompositor::updateLayerForHeader):
(WebCore::RenderLayerCompositor::updateLayerForFooter):
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
(WebCore::RenderLayerCompositor::ensureRootLayer):

Source/WebKit/win:

• WebView.cpp:

(WebView::setAcceleratedCompositing):

Source/WebKit2:

• WebProcess/WebPage/PageOverlayController.cpp:

(WebKit::PageOverlayController::initialize):
(WebKit::PageOverlayController::installPageOverlay):

• WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::initialize):
(WebKit::LayerTreeHostGtk::createPageOverlayLayer):

• WebProcess/WebPage/mac/GraphicsLayerCARemote.h:
• WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
• WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::createGraphicsLayer):

• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):

4:23 AM WebKitGTK/2.4.x edited by clopez@igalia.com

(diff)

4:21 AM Changeset in webkit [168422] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.4

Merge r168417 - [SOUP] TLSErrors do not cause page load to fail when not ignored
​https://bugs.webkit.org/show_bug.cgi?id=121548

Reviewed by Sergio Villar Senin.

Source/WebCore:
This only happens in case of redirection, when the initial URL is
an HTTPS site with an invalid certificate, that redirects to
another location. We are starting the redirection without checking
the TLS errors.

• platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sendRequestCallback): Check TLS errors before starting a
possible redirection.

Tools:
Add unit tests to check that the load fails with TLS errors in
case of a redirection.

• TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:

(testTLSErrorsRedirect):
(httpsServerCallback):
(beforeAll):

3:59 AM Changeset in webkit [168421] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

Merge r168351 - [Soup] Use std::unique_ptr<char[]> for the read buffer in SocketStreamHandle
​https://bugs.webkit.org/show_bug.cgi?id=132559

Reviewed by Carlos Garcia Campos.

Manage the read buffer array through a std::unique_ptr<char[]> object.
This avoids handling with the raw pointer and also ensures that the memory
allocated with the new[] operator is deleted with the delete[] operator,
a problem exposed by the AddressSanitizer in WebSocket tests.

• platform/network/soup/SocketStreamHandle.h:
• platform/network/soup/SocketStreamHandleSoup.cpp:

(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::connected):
(WebCore::SocketStreamHandle::readBytes):
(WebCore::SocketStreamHandle::platformClose):

3:54 AM Changeset in webkit [168420] by calvaris@igalia.com

• 3 edits in trunk/Source/WebCore

[GStreamer] Corrected typo
​https://bugs.webkit.org/show_bug.cgi?id=132609

Reviewed by Martin Robinson.

Corrected m_canFallBackToLastFinishedSeekPositon typo and
initialized in the constructor to prevent problems in the future.

No test needed.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
Initialized m_canFallBackToLastFinishedSeekPosition as false.
(WebCore::MediaPlayerPrivateGStreamer::playbackPosition):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::MediaPlayerPrivateGStreamer::asyncStateChangeDone):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

m_canFallBackToLastFinishedSeekPositon ->
m_canFallBackToLastFinishedSeekPosition

3:39 AM Changeset in webkit [168419] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit2

Cleanup the build from unused parameter in UIProcess Module
​https://bugs.webkit.org/show_bug.cgi?id=131969

Patch by Shivakumar JM <​shiva.jm@samsung.com> on 2014-05-07
Reviewed by Csaba Osztrogonác.

Fixed unused parameter by omitting the parameter name

• UIProcess/API/C/WKPage.cpp:

(WKPageSetPageFindClient):

• UIProcess/WebFindClient.cpp:

(WebKit::WebFindClient::didFindString):

3:20 AM Changeset in webkit [168418] by gyuyoung.kim@samsung.com

• 2 edits in trunk/Source/WebCore

Convert PassOwnPtr to unique_ptr in CrossThreadTask.h
​https://bugs.webkit.org/show_bug.cgi?id=132605

Reviewed by Dirk Schulze.

• dom/CrossThreadTask.h: Converted.

3:11 AM Changeset in webkit [168417] by Carlos Garcia Campos

• 4 edits in trunk

[SOUP] TLSErrors do not cause page load to fail when not ignored
​https://bugs.webkit.org/show_bug.cgi?id=121548

Reviewed by Sergio Villar Senin.

Source/WebCore:
This only happens in case of redirection, when the initial URL is
an HTTPS site with an invalid certificate, that redirects to
another location. We are starting the redirection without checking
the TLS errors.

• platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sendRequestCallback): Check TLS errors before starting a
possible redirection.

Tools:
Add unit tests to check that the load fails with TLS errors in
case of a redirection.

• TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:

(testTLSErrorsRedirect):
(httpsServerCallback):
(beforeAll):

2:56 AM Changeset in webkit [168416] by Manuel Rego Casasnovas

• 129 edits
  3 deletes in trunk

[CSS Grid Layout] Remove runtime feature
​https://bugs.webkit.org/show_bug.cgi?id=132382

Reviewed by Benjamin Poulain.

PerformanceTests:
Remove set of WebKitCSSGridLayoutEnabled preference.

• Layout/auto-grid-lots-of-data.html:
• Layout/fixed-grid-lots-of-data.html:

Source/WebCore:
Remove cssGridLayoutEnabled setting. Update methods using it accordingly.

• WebCore.order:
• css/CSSParser.cpp:

(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridTemplateShorthand):
(WebCore::CSSParser::parseGridAreaShorthand):
(WebCore::CSSParser::cssGridLayoutEnabled): Deleted.

• css/CSSParser.h:
• css/CSSParserMode.h:
• dom/Document.cpp:

(WebCore::Document::cssGridLayoutEnabled): Deleted.

• dom/Document.h:
• page/Settings.in:

Source/WebKit/efl:
Remove cssGridLayoutEnabled setting usage.

• WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setCSSGridLayoutEnabled): Deleted.

• WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/mac:
Remove cssGridLayoutEnabled setting usage.

• WebKit.order:
• WebView/WebPreferenceKeysPrivate.h:
• WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences cssGridLayoutEnabled]): Deleted.
(-[WebPreferences setCSSGridLayoutEnabled:]): Deleted.

• WebView/WebPreferencesPrivate.h:
• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:
Remove cssGridLayoutEnabled setting usage.

• Shared/WebPreferencesStore.h:
• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetCSSGridLayoutEnabled): Deleted.
(WKPreferencesGetCSSGridLayoutEnabled): Deleted.

• UIProcess/API/C/WKPreferencesRefPrivate.h:
• UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsConstructed):

• UIProcess/gtk/ExperimentalFeatures.cpp:
• UIProcess/gtk/ExperimentalFeatures.h:
• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

• mac/WebKit2.order:

Tools:
Remove cssGridLayoutEnabled setting usage.

• DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

• DumpRenderTree/efl/TestRunnerEfl.cpp:

(TestRunner::overridePreference):

• DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

LayoutTests:
Remove set of WebKitCSSGridLayoutEnabled preference.
Remove fast/css-grid-layout/grid-disabled.html patch as the setting is not available anymore.

• fast/css-grid-layout/anonymous-grid-items-expected.html:
• fast/css-grid-layout/anonymous-grid-items.html:
• fast/css-grid-layout/auto-content-resolution-columns.html:
• fast/css-grid-layout/auto-content-resolution-rows.html:
• fast/css-grid-layout/breadth-size-resolution-grid.html:
• fast/css-grid-layout/calc-resolution-grid-item.html:
• fast/css-grid-layout/containing-block-grids.html:
• fast/css-grid-layout/display-grid-set-get.html:
• fast/css-grid-layout/flex-and-minmax-content-resolution-columns.html:
• fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html:
• fast/css-grid-layout/flex-content-resolution-columns.html:
• fast/css-grid-layout/flex-content-resolution-rows.html:
• fast/css-grid-layout/flex-content-sized-column-use-available-width.html:
• fast/css-grid-layout/flex-content-sized-columns-resize.html:
• fast/css-grid-layout/floating-empty-grids.html:
• fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution.html:
• fast/css-grid-layout/grid-auto-columns-rows-get-set.html:
• fast/css-grid-layout/grid-auto-columns-rows-resolution.html:
• fast/css-grid-layout/grid-auto-columns-rows-update.html:
• fast/css-grid-layout/grid-auto-flow-get-set.html:
• fast/css-grid-layout/grid-auto-flow-resolution.html:
• fast/css-grid-layout/grid-auto-flow-update.html:
• fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
• fast/css-grid-layout/grid-columns-rows-get-set.html:
• fast/css-grid-layout/grid-container-change-named-grid-lines-recompute-child.html:
• fast/css-grid-layout/grid-disabled-expected.txt: Removed.
• fast/css-grid-layout/grid-disabled.html: Removed.
• fast/css-grid-layout/grid-dynamic-updates-relayout.html:
• fast/css-grid-layout/grid-element-border-grid-item.html:
• fast/css-grid-layout/grid-element-border-padding-grid-item.html:
• fast/css-grid-layout/grid-element-change-columns-repaint.html:
• fast/css-grid-layout/grid-element-change-rows-repaint.html:
• fast/css-grid-layout/grid-element-empty-row-column.html:
• fast/css-grid-layout/grid-element-min-max-height.html:
• fast/css-grid-layout/grid-element-min-max-width.html:
• fast/css-grid-layout/grid-element-padding-grid-item.html:
• fast/css-grid-layout/grid-element-padding-margin.html:
• fast/css-grid-layout/grid-element-repeat-get-set.html:
• fast/css-grid-layout/grid-element-shrink-to-fit.html:
• fast/css-grid-layout/grid-item-addition-auto-placement-update.html:
• fast/css-grid-layout/grid-item-addition-track-breadth-update.html:
• fast/css-grid-layout/grid-item-area-get-set.html:
• fast/css-grid-layout/grid-item-bad-named-area-auto-placement.html:
• fast/css-grid-layout/grid-item-bad-resolution-double-span.html:
• fast/css-grid-layout/grid-item-change-column-repaint.html:
• fast/css-grid-layout/grid-item-change-row-repaint.html:
• fast/css-grid-layout/grid-item-column-row-get-set.html:
• fast/css-grid-layout/grid-item-end-after-get-set.html:
• fast/css-grid-layout/grid-item-margin-auto-columns-rows.html:
• fast/css-grid-layout/grid-item-margin-resolution.html:
• fast/css-grid-layout/grid-item-multiple-minmax-content-resolution.html:
• fast/css-grid-layout/grid-item-named-grid-area-resolution.html:
• fast/css-grid-layout/grid-item-named-grid-line-resolution.html:
• fast/css-grid-layout/grid-item-negative-indexes.html:
• fast/css-grid-layout/grid-item-negative-integer-explicit-grid-resolution.html:
• fast/css-grid-layout/grid-item-negative-position-resolution.html:
• fast/css-grid-layout/grid-item-order-auto-flow-resolution.html:
• fast/css-grid-layout/grid-item-order-paint-order.html:
• fast/css-grid-layout/grid-item-position-changed-dynamic.html:
• fast/css-grid-layout/grid-item-removal-auto-placement-update.html:
• fast/css-grid-layout/grid-item-removal-track-breadth-update.html:
• fast/css-grid-layout/grid-item-spanning-resolution.html:
• fast/css-grid-layout/grid-item-start-before-get-set.html:
• fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html:
• fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html:
• fast/css-grid-layout/grid-preferred-logical-widths.html:
• fast/css-grid-layout/grid-strict-ordering-crash.html:
• fast/css-grid-layout/grid-template-areas-get-set.html:
• fast/css-grid-layout/grid-template-shorthand-get-set.html:
• fast/css-grid-layout/implicit-columns-auto-resolution.html:
• fast/css-grid-layout/implicit-position-dynamic-change.html:
• fast/css-grid-layout/implicit-rows-auto-resolution.html:
• fast/css-grid-layout/minmax-fixed-logical-height-only.html:
• fast/css-grid-layout/minmax-fixed-logical-width-only.html:
• fast/css-grid-layout/minmax-max-content-resolution-columns.html:
• fast/css-grid-layout/minmax-max-content-resolution-rows.html:
• fast/css-grid-layout/minmax-min-content-column-resolution-columns.html:
• fast/css-grid-layout/minmax-min-content-column-resolution-rows.html:
• fast/css-grid-layout/minmax-spanning-resolution-columns.html:
• fast/css-grid-layout/minmax-spanning-resolution-rows.html:
• fast/css-grid-layout/named-grid-line-get-set.html:
• fast/css-grid-layout/named-grid-lines-with-named-grid-areas-get-set.html:
• fast/css-grid-layout/named-grid-lines-with-named-grid-areas-resolution.html:
• fast/css-grid-layout/non-grid-columns-rows-get-set-multiple.html:
• fast/css-grid-layout/non-grid-columns-rows-get-set.html:
• fast/css-grid-layout/non-grid-element-repeat-get-set.html:
• fast/css-grid-layout/non-named-grid-line-get-set.html:
• fast/css-grid-layout/percent-grid-item-in-percent-grid-track-in-percent-grid.html:
• fast/css-grid-layout/percent-grid-item-in-percent-grid-track-update.html:
• fast/css-grid-layout/percent-grid-item-in-percent-grid-track.html:
• fast/css-grid-layout/percent-padding-margin-resolution-grid-item-update.html:
• fast/css-grid-layout/percent-padding-margin-resolution-grid-item.html:
• fast/css-grid-layout/percent-resolution-grid-item.html:
• fast/css-grid-layout/place-cell-by-index.html:
• fast/css-grid-layout/should-not-collapse-anonymous-blocks.html:
• ietestcenter/css3/grid/grid-column-002.htm:
• ietestcenter/css3/grid/testRunnerEnableGrid.js: Removed.

1:39 AM WebKitGTK/KeepingTheTreeGreen edited by ltilve@igalia.com

(diff)

1:35 AM Changeset in webkit [168415] by berto@igalia.com

• 2 edits in trunk/LayoutTests

[GTK] Unreviewed GTK gardening

Avoid duplicated expectations and remove failure flag for fixed
js/dom/basic-weakmap.html test.

Patch by Lorenzo Tilve <​ltilve@igalia.com> on 2014-05-07

• platform/gtk/TestExpectations:

1:15 AM Changeset in webkit [168414] by Csaba Osztrogonác

• 2 edits in trunk/Source/WebKit2

URTBF after r168393 to fix !IOS builds.

• Shared/WebEvent.h:

12:56 AM Changeset in webkit [168413] by Csaba Osztrogonác

• 2 edits in trunk/Source/WebCore

Fix build errors for BlobDataItem after r168391.
​https://bugs.webkit.org/show_bug.cgi?id=132643

Patch by Praveen R Jadhav <​praveen.j@samsung.com> on 2014-05-07
Reviewed by Carlos Garcia Campos.

Patch updates BlobDataItem params usage in ResourceHandleSoup.cpp
to be inline with r168391.

• platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::blobIsOutOfDate): BlobDataItem class is updated in r168391.
Corresponding parameter changes are done to resolve build error.
(WebCore::addEncodedBlobItemToSoupMessageBody): BlobDataItem class is updated
in r168391. Corresponding parameter changes are done to resolve build error.