Timeline

May 9, 2014:

11:48 PM Changeset in webkit [168573] by mitz@apple.com

• 2 edits in trunk/Source/WebKit2

[Cocoa] Remove a deprecated bundle form delegate method now that no one implements it
​https://bugs.webkit.org/show_bug.cgi?id=132769

Reviewed by Sam Weinig.

• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]):

10:14 PM Changeset in webkit [168572] by benjamin@webkit.org

• 2 edits in trunk/Source/WebKit2

[iOS][WK2] Fix bugs exposed by r168556
​https://bugs.webkit.org/show_bug.cgi?id=132768

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-05-09
Reviewed by Ryosuke Niwa.

Fix two bugs exposed by r168556.
1) We were only changing the page scale factor when the scale was not adjusted by live

resize. The idea was that the scale would either be the same (responsive content)
or that it would be defined by the next viewContentRectUpdate.

Now that we also send resize and scroll events, we must always update the scale since
it affects some APIs observable from JavaScript (like scrolling bounds).

2) Internally, Page's scaleFactor is stored as a float and not double. The rounding error

were causing us to send DynamicViewportUpdateChangedTarget() in cases were there is no change
of target.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::withinEpsilon):
(WebKit::WebPage::dynamicViewportSizeUpdate):

9:51 PM Changeset in webkit [168571] by ryuan.choi@samsung.com

• 2 edits in trunk/Source/WebKit2

[EFL][WK2] Close icondatabase when EwkFaviconDatabase is destroyed
​https://bugs.webkit.org/show_bug.cgi?id=132767

Reviewed by Gyuyoung Kim.

IconDatabase should be closed explicitly.

• UIProcess/API/efl/ewk_favicon_database.cpp:

(EwkFaviconDatabase::~EwkFaviconDatabase):

7:20 PM Changeset in webkit [168570] by dino@apple.com

• 2 edits in trunk/Source/WebCore

[fullscreen] cursor should auto-hide when over video
​https://bugs.webkit.org/show_bug.cgi?id=132758

Unreviewed followup based on test failure.

• css/fullscreen.css: Append the previous rule - video children of fullscreen elements.

7:18 PM Changeset in webkit [168569] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Another build fix.

• mac/MigrateHeadersToWebKit2.make:

Don't migrate the WKPreferences.h header, WebKit2 provides its own header.

7:09 PM Changeset in webkit [168568] by benjamin@webkit.org

• 4 edits in trunk/Source/WebKit2

[iOS][WK2] Reset the scroll position on the first frame after didCommitLoad
​https://bugs.webkit.org/show_bug.cgi?id=132765

Reviewed by Tim Horton.

Since WebCore does not update our scroll view on load, we need to do that ourself.

In case where we need to restore the state from the history, RemoteLayerTreeDrawingAreaProxy
will always invoke the scrolling after didCommitLayerTree() (since r167916).
Consequently, it is now safe again to reset the scroll position ourself on the first frame.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLoadForMainFrame]):
(-[WKWebView _didCommitLayerTree:WebKit::]):

• UIProcess/API/Cocoa/WKWebViewInternal.h:
• UIProcess/ios/WKContentView.mm:

(-[WKContentView _didCommitLoadForMainFrame]):

6:53 PM Changeset in webkit [168567] by matthew_hanson@apple.com

• 1 copy in tags/Safari-538.34.2

New Tag.

6:49 PM Changeset in webkit [168566] by andersca@apple.com

• 54 edits
  1 add in trunk/Source/WebKit2

Update availability macros
​https://bugs.webkit.org/show_bug.cgi?id=132763
<rdar://problem/15311800>

Reviewed by Dan Bernstein.

• Configurations/WebKit.xcconfig:
• Shared/API/Cocoa/WKBrowsingContextHandle.h:
• Shared/API/Cocoa/WKFoundation.h:
• Shared/API/Cocoa/_WKFrameHandle.h:
• Shared/API/Cocoa/_WKRemoteObjectInterface.h:
• Shared/API/Cocoa/_WKRemoteObjectRegistry.h:
• UIProcess/API/Cocoa/WKBackForwardList.h:
• UIProcess/API/Cocoa/WKBackForwardListItem.h:
• UIProcess/API/Cocoa/WKBackForwardListPrivate.h:
• UIProcess/API/Cocoa/WKBrowsingContextController.h:
• UIProcess/API/Cocoa/WKBrowsingContextGroup.h:
• UIProcess/API/Cocoa/WKConnection.h:
• UIProcess/API/Cocoa/WKFrameInfo.h:
• UIProcess/API/Cocoa/WKNavigation.h:
• UIProcess/API/Cocoa/WKNavigationAction.h:

(NS_ENUM):

• UIProcess/API/Cocoa/WKNavigationData.h:
• UIProcess/API/Cocoa/WKNavigationDelegate.h:

(NS_ENUM):

• UIProcess/API/Cocoa/WKNavigationResponse.h:
• UIProcess/API/Cocoa/WKPreferences.h:
• UIProcess/API/Cocoa/WKProcessGroup.h:
• UIProcess/API/Cocoa/WKProcessPool.h:
• UIProcess/API/Cocoa/WKScriptMessage.h:
• UIProcess/API/Cocoa/WKScriptMessageHandler.h:
• UIProcess/API/Cocoa/WKTypeRefWrapper.h:
• UIProcess/API/Cocoa/WKUIDelegate.h:
• UIProcess/API/Cocoa/WKUserContentController.h:
• UIProcess/API/Cocoa/WKWebView.h:
• UIProcess/API/Cocoa/WKWebViewConfiguration.h:
• UIProcess/API/Cocoa/WKWebViewPrivate.h:

(NS_OPTIONS):
(NS_ENUM):

• UIProcess/API/Cocoa/WKWindowFeatures.h:
• UIProcess/API/Cocoa/_WKActivatedElementInfo.h:

(NS_ENUM):

• UIProcess/API/Cocoa/_WKDownload.h:
• UIProcess/API/Cocoa/_WKElementAction.h:

(NS_ENUM):

• UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
• UIProcess/API/Cocoa/_WKScriptWorld.h:
• UIProcess/API/Cocoa/_WKThumbnailView.h:
• UIProcess/API/Cocoa/_WKVisitedLinkProvider.h:
• UIProcess/API/Cocoa/_WKWebsiteDataStore.h:
• WebKit2.xcodeproj/project.pbxproj:
• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h:
• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInHitTestResult.h:
• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h:
• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInPageGroup.h:
• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInScriptWorld.h:
• WebProcess/InjectedBundle/API/mac/WKDOMDocument.h:
• WebProcess/InjectedBundle/API/mac/WKDOMElement.h:
• WebProcess/InjectedBundle/API/mac/WKDOMNode.h:
• WebProcess/InjectedBundle/API/mac/WKDOMRange.h:
• WebProcess/InjectedBundle/API/mac/WKDOMText.h:
• WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.h:
• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h:
• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.h:
• mac/rewrite-availability-macros.sh: Added.

6:30 PM Changeset in webkit [168565] by Joseph Pecoraro

• 19 edits in trunk/Source

Web Inspector: Allow Remote Inspector to entitlement check UIProcess through WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=132409

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:
Proxy applications are applications which hold WebViews for other
applications. The WebProcess (Web Content Service) is a proxy application.
For legacy reasons we were supporting a scenario where proxy applications
could potentially host WebViews for more then one other application. That
was never the case for WebProcess and it is now a scenario we don't need
to worry about supporting.

With this change, a proxy application more naturally only holds WebViews
for a single parent / host application. The proxy process can set the
parent pid / audit_token data on the RemoteInspector singleton, and
that data will be sent on to webinspectord later on to be validated.
In the WebProcess<->UIProcess relationship that information is known
and set immediately. In the Legacy iOS case that information is set
soon after, but not immediately known at the point the WebView is created.

This allows us to simplify the RemoteInspectorDebuggable interface.
We no longer need a pid per-Debuggable.

• inspector/remote/RemoteInspector.h:
• inspector/remote/RemoteInspector.mm:

(Inspector::RemoteInspector::RemoteInspector):
(Inspector::RemoteInspector::setParentProcessInformation):
(Inspector::RemoteInspector::xpcConnectionReceivedMessage):
(Inspector::RemoteInspector::listingForDebuggable):
(Inspector::RemoteInspector::receivedProxyApplicationSetupMessage):
Handle new proxy application setup message, and provide an API
for a proxy application to set the parent process information.

• inspector/remote/RemoteInspectorConstants.h:

New setup and response message for proxy applications to pass
their parent / host application information to webinspectord.

• inspector/remote/RemoteInspectorDebuggable.cpp:

(Inspector::RemoteInspectorDebuggable::info):

• inspector/remote/RemoteInspectorDebuggable.h:

(Inspector::RemoteInspectorDebuggableInfo::RemoteInspectorDebuggableInfo):
(Inspector::RemoteInspectorDebuggableInfo::hasParentProcess): Deleted.
pid per debuggable is no longer needed.

Source/WebCore:

• inspector/InspectorClient.h:

(WebCore::InspectorClient::parentProcessIdentifier): Deleted.

• page/PageDebuggable.cpp:

(WebCore::PageDebuggable::parentProcessIdentifier): Deleted.

• page/PageDebuggable.h:

pid per debuggable is no longer needed.

Source/WebKit/mac:
Simplify the legacy iOS UIWebViewController case by passing on
the host process pid and audit_token.

• WebView/WebView.mm:

(-[WebView _setHostApplicationProcessIdentifier:auditToken:]):
(-[WebView setHostApplicationBundleId:name:]): Deleted.
(-[WebView hostApplicationBundleId]): Deleted.
(-[WebView hostApplicationName]): Deleted.

• WebView/WebViewData.h:
• WebView/WebViewData.mm:

(-[WebViewPrivate dealloc]):

• WebView/WebViewPrivate.h:

Source/WebKit2:

• WebProcess/WebCoreSupport/WebInspectorClient.h:
• WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::parentProcessIdentifier): Deleted.
pid per debuggable is no longer needed.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
Immediately pass the parent process pid and audit_token on
to the RemoteInspector singleton when the process is created
so that it can be sent to webinspectord.

6:23 PM Changeset in webkit [168564] by rniwa@webkit.org

• 2 edits in trunk/PerformanceTests

DYEBench should show 95th percentile right next to the mean with ±
​https://bugs.webkit.org/show_bug.cgi?id=132729

Reviewed by Darin Adler.

Before this patch, Full.html showed the 95th percentile delta for the arthemtic mean in a separate row
but this was confusing for some people. Show it right next to mean in the same row separated by ±.

• DoYouEvenBench/Full.html:

6:11 PM Changeset in webkit [168563] by enrica@apple.com

• 2 edits in trunk/Source/WebKit2

REGRESSION (WebKit2): Tapping in search field at wikipedia.org doesn’t bring up the keyboard.
​https://bugs.webkit.org/show_bug.cgi?id=132761
<rdar://problem/16857491>

Reviewed by Benjamin Poulain.

The interactionAssistant accessor should never create an instance of
UIWKTextInteractionAssistant, but simply return the value of _textInteractionAssistant.
The text interaction assistant should only be created when needed so that the rest of
the code could reliably check if we are interacting with text or not.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView interactionAssistant]):

6:10 PM Changeset in webkit [168562] by Simon Fraser

• 2 edits in trunk/Source/WebKit2

Fix some issues with scrolling tree logging
​https://bugs.webkit.org/show_bug.cgi?id=132762

Reviewed by Tim Horton.

Only dump viewport constraints when they change, and dump the primary layer on
scrolling nodes.

• Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:

(WebKit::RemoteScrollingTreeTextStream::dump): Dump the primary layer.

5:59 PM CommitQueue edited by clopez@igalia.com

Fix URL for commit queue status (diff)

5:38 PM Changeset in webkit [168561] by dino@apple.com

• 2 edits in trunk/Source/WebCore

[fullscreen] cursor should auto-hide when over video
​https://bugs.webkit.org/show_bug.cgi?id=132758

Reviewed by Brent Fulgham.

Cursors were not auto-hiding over fullscreen video. There was
a small error in the CSS we load for fullscreen content.

• css/fullscreen.css: Don't hide when video is a child of the fullscreen element - hide when it *is* the fullscreen element.

(video:-webkit-full-screen):
(:-webkit-full-screen video:hover): Deleted.

5:11 PM Changeset in webkit [168560] by Simon Fraser

• 5 edits in trunk/Source/WebKit2

[iOS WK2] Fixed elements can go outside the document on pinching
​https://bugs.webkit.org/show_bug.cgi?id=132759
<rdar://problem/16870835>

Reviewed by Benjamin Poulain.

Constrain the rect used to position fixed position objects when pinching (when
the scale goes below the minimumScale). Do so in such a way that there's a smooth
transition between rubber-banding and pinching.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _updateScrollViewBackground]): Use a nicer form for std::max<>.
(-[WKWebView _updateVisibleContentRects]): Pass the minimum scale.

• UIProcess/API/ios/WKViewIOS.mm:

(-[WKView _updateVisibleContentRects]): Ditto.

• UIProcess/ios/WKContentView.h:
• UIProcess/ios/WKContentView.mm:

(adjustedUnexposedEdge): Helper to adjust the left/top.
(adjustedUnexposedMaxEdge): Helper to adjust the right/bottom.
(fixedPositionRectFromExposedRect):
(-[WKContentView didUpdateVisibleRect:unobscuredRect:scale:minimumScale:inStableState:]):
(-[WKContentView didUpdateVisibleRect:unobscuredRect:scale:inStableState:]): Deleted.

5:08 PM Changeset in webkit [168559] by Alan Bujtas

• 7 edits in trunk/Source

Subpixel rendering[iOS]: Top bar on apple.com/support jiggles when the swoosh animates.
​https://bugs.webkit.org/show_bug.cgi?id=132750
<rdar://problem/16803281>

Reviewed by Simon Fraser.

This patch ensures that GraphicsLayer and RemoteLayerBackingStore have the same dimensions.

Remove integral enclosing when we set the size on RemoteLayerBackingStore. It makes the layer's size
different from the backingstore when the passed value is fractional.
We scale and integral round this value to size the shareable bitmap later. Rounding ensures that
the final size value matches what we calculated at GraphicsLayerCA::updateGeometry()

Currently not testable.

Source/WebCore:

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateGeometry):
(WebCore::GraphicsLayerCA::computePixelAlignment): include device scale factor to be able calculate the final content scale.

• platform/graphics/ca/GraphicsLayerCA.h:

Source/WebKit2:

• Shared/mac/RemoteLayerBackingStore.h:

(WebKit::RemoteLayerBackingStore::size):

• Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::ensureBackingStore):
(WebKit::RemoteLayerBackingStore::setNeedsDisplay): use enclosing here to ensure we cover the entire backing store.
(WebKit::RemoteLayerBackingStore::display):
(WebKit::RemoteLayerBackingStore::drawInContext):

• WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::updateBackingStore):

5:06 PM Changeset in webkit [168558] by mhahnenberg@apple.com

• 4 edits in trunk/Source

JSDOMWindow should disable property caching after a certain point
​https://bugs.webkit.org/show_bug.cgi?id=132751

Reviewed by Filip Pizlo.

Source/JavaScriptCore:
This is part of removing HasImpureGetOwnPropertySlot from JSDOMWindow. After the lookup in the static
hash table for JSDOMWindow fails we want to disable property caching even if the code that follows thinks
that it has provided a cacheable value.

• runtime/PropertySlot.h:

(JSC::PropertySlot::PropertySlot):
(JSC::PropertySlot::isCacheable):
(JSC::PropertySlot::disableCaching):

Source/WebCore:
No new tests.

This is part of removing HasImpureGetOwnPropertySlot from JSDOMWindow. After the lookup in the static
hash table for JSDOMWindow fails we want to disable property caching even if the code that follows thinks
that it has provided a cacheable value.

• bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlot):

4:13 PM Changeset in webkit [168557] by benjamin@webkit.org

• 2 edits in trunk/Source/WebCore

Fix the export file after r168556

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-05-09

• WebCore.exp.in: I forgot to fix the export file before landing.

4:08 PM Changeset in webkit [168556] by benjamin@webkit.org

• 16 edits in trunk/Source

[iOS][WK2] Set up the resize events
​https://bugs.webkit.org/show_bug.cgi?id=132726

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-05-09
Reviewed by Darin Adler and Simon Fraser.

Source/WebCore:
Let the WebKit2 layer override the size used for resize events.

• WebCore.exp.in:
• page/FrameView.cpp:

(WebCore::FrameView::layout):
(WebCore::FrameView::sizeForResizeEvent):
(WebCore::FrameView::sendResizeEventIfNeeded):
(WebCore::FrameView::setCustomSizeForResizeEvent):

• page/FrameView.h:

Source/WebKit2:
Wire the UI Process updates to FrameView to send the resize events appropriately.

• Shared/VisibleContentRectUpdateInfo.cpp:

(WebKit::VisibleContentRectUpdateInfo::encode):
(WebKit::VisibleContentRectUpdateInfo::decode):

• Shared/VisibleContentRectUpdateInfo.h:

(WebKit::VisibleContentRectUpdateInfo::VisibleContentRectUpdateInfo):
(WebKit::VisibleContentRectUpdateInfo::isChangingObscuredInsetsInteractively):

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _updateVisibleContentRects]):

• UIProcess/ios/WKContentView.h:
• UIProcess/ios/WKContentView.mm:

(-[WKContentView didUpdateVisibleRect:unobscuredRect:scale:inStableState:isChangingObscuredInsetsInteractively:]):
(-[WKContentView didUpdateVisibleRect:unobscuredRect:scale:inStableState:]): Deleted.
Pass down the status of the content insets with the view update to main frame's FrameView
when needed.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::dynamicViewportSizeUpdate):
On live resize, send the resize event, then the scroll events (if needed).

Since JavaScript now gets two chances to change the content (resize event + scroll event),
we query the actual scroll offset and scale for the DynamicViewportUpdateChangedTarget.

(WebKit::WebPage::viewportConfigurationChanged):
Define the custom size on load before the app gets a chance to send different rects.
If for some reason the app changes its mind about the insets, the content will be notified with a resize event.

(WebKit::WebPage::updateVisibleContentRects):
Send the resize event when the insets are stable.
Also move the scroll event after the resize event for consistency with live resize.

2:25 PM Changeset in webkit [168555] by benjamin@webkit.org

• 11 edits in trunk

[iOS] Switch geolocation to an explicit authorization query model
​https://bugs.webkit.org/show_bug.cgi?id=132717

Source/WebKit/ios:
<rdar://problem/16762390>

Reviewed by Sam Weinig.

WebGeolocationCoreLocationProvider is the general WebKit wrapper for CoreLocation.

The old model was to start WebGeolocationCoreLocationProvider and have the start fail or succeed.
The new model is to explicitely ask for authorization through "requestGeolocationAuthorization", and
listen to "geolocationAuthorizationGranted" and "geolocationAuthorizationDenied".

We assume the client of WebGeolocationCoreLocationProvider is well behaved and ask for authorization
before invoking "start".
If "start" is called and the authorization is not granted, we assume geolocation was reset since
the last time authorization was requested, and we reset the client.

WebGeolocationProviderIOS has been adapted to that model. Instead of doing the "warmup" sequence
to get the authorization, it queries WebGeolocationCoreLocationProvider explicitly.

• Misc/WebGeolocationCoreLocationProvider.h:
• Misc/WebGeolocationCoreLocationProvider.mm:

(-[WebGeolocationCoreLocationProvider createLocationManager]):
(-[WebGeolocationCoreLocationProvider dealloc]):
(-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]):
(isAuthorizationGranted):
(-[WebGeolocationCoreLocationProvider start]):
(-[WebGeolocationCoreLocationProvider stop]):
(-[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:]):
(-[WebGeolocationCoreLocationProvider setEnableHighAccuracy:]):
(-[WebGeolocationCoreLocationProvider handleExternalAuthorizationStatusChange:]): Deleted.

• Misc/WebGeolocationProviderIOS.mm:

(-[WebGeolocationProviderIOS suspend]):
(-[WebGeolocationProviderIOS resume]):
(-[WebGeolocationProviderIOS registerWebView:]):
(-[WebGeolocationProviderIOS unregisterWebView:]):
(-[WebGeolocationProviderIOS setEnableHighAccuracy:]):
(-[WebGeolocationProviderIOS initializeGeolocationForWebView:listener:]):
(-[WebGeolocationProviderIOS geolocationAuthorizationGranted]):
(-[WebGeolocationProviderIOS geolocationAuthorizationDenied]):
(-[WebGeolocationProviderIOS stopTrackingWebView:]):
(-[WebGeolocationProviderIOS resetGeolocation]):
(-[_WebCoreLocationUpdateThreadingProxy geolocationAuthorizationGranted]):
(-[_WebCoreLocationUpdateThreadingProxy geolocationAuthorizationDenied]):
(-[_WebCoreLocationUpdateThreadingProxy positionChanged:WebCore::]):
(-[_WebCoreLocationUpdateThreadingProxy errorOccurred:]):
(-[_WebCoreLocationUpdateThreadingProxy resetGeolocation]):
(-[WebGeolocationProviderIOS _startCoreLocationDelegate]): Deleted.
(-[WebGeolocationProviderIOS _stopCoreLocationDelegateIfNeeded]): Deleted.
(-[WebGeolocationProviderIOS cancelWarmUpForWebView:]): Deleted.
(-[WebGeolocationProviderIOS geolocationDelegateStarted]): Deleted.
(-[WebGeolocationProviderIOS geolocationDelegateUnableToStart]): Deleted.
(-[_WebCoreLocationUpdateThreadingProxy geolocationDelegateStarted]): Deleted.
(-[_WebCoreLocationUpdateThreadingProxy geolocationDelegateUnableToStart]): Deleted.

Source/WebKit/mac:

Reviewed by Sam Weinig.

Since there is no warmup code, WebGeolocationPolicyListener no longer need to know about the provider,
which is awesome :)

• WebCoreSupport/WebGeolocationClient.mm:

(-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
(-[WebGeolocationPolicyListener deny]):
(-[WebGeolocationProviderInitializationListener initializationAllowedWebView:]):
(-[WebGeolocationProviderInitializationListener initializationDeniedWebView:]):
(-[WebGeolocationPolicyListener initWithGeolocation:forWebView:provider:]): Deleted.
(-[WebGeolocationProviderInitializationListener initializationAllowedWebView:provider:]): Deleted.
(-[WebGeolocationProviderInitializationListener initializationDeniedWebView:provider:]): Deleted.

• WebView/WebViewPrivate.h:

Source/WebKit2:

Reviewed by Sam Weinig.

Switch WKGeolocationProviderIOS to use the new API of WebGeolocationCoreLocationProvider.

On WebKit2, the whole logic to track requesters is in WebGeolocationManagerProxy.

Without the warmup sequence, WKGeolocationProviderIOS becomes really dumb: it just provides
the two step authorization and forward the start/stop messages to the WebGeolocationCoreLocationProvider.

• UIProcess/ios/WKGeolocationProviderIOS.mm:

(-[WKGeolocationProviderIOS _stopUpdating]):
(-[WKGeolocationProviderIOS decidePolicyForGeolocationRequestFromOrigin:frame:request:window:]):
(-[WKGeolocationProviderIOS geolocationAuthorizationGranted]):
(-[WKGeolocationProviderIOS geolocationAuthorizationDenied]):
(-[WKWebAllowDenyPolicyListener initWithPermissionRequestProxy:]):
(-[WKWebAllowDenyPolicyListener deny]):
(-[WKGeolocationProviderIOS _stopUpdatingIfPossible]): Deleted.
(-[WKGeolocationProviderIOS geolocationDelegateStarted]): Deleted.
(-[WKGeolocationProviderIOS geolocationDelegateUnableToStart]): Deleted.
(-[WKGeolocationProviderIOS permissionDenied:]): Deleted.
(-[WKWebAllowDenyPolicyListener initWithProvider:permissionRequestProxy:]): Deleted.

Tools:

Reviewed by Sam Weinig.

• DumpRenderTree/mac/MockGeolocationProvider.mm:

(-[MockGeolocationProvider initializeGeolocationForWebView:listener:]):
(-[MockGeolocationProvider cancelWarmUpForWebView:]): Deleted.

2:24 PM Changeset in webkit [168554] by ap@apple.com

• 6 edits in trunk

REGRESSION (r168518): Multiple tests for workers in blobs assert
​https://bugs.webkit.org/show_bug.cgi?id=132728

Reviewed by Geoffrey Garen.

Source/WebCore:
Change File serialization to include name, so that we don't have to regenerate anything
on a secondary thread after deserialization.

Files and Blobs can't be stored persistently, because URLs are transient (IndexedDB
has an explicit check, and fails if there were any blob URLs). API doesn't have the
check, but given that anyone who tried to use these to serialize a File would fail,
it seems OK to change the format.

• bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::readFile):

• fileapi/File.cpp:

(WebCore::File::File):

• fileapi/File.h:

LayoutTests:

• platform/mac/TestExpectations: Unskip the tests.

2:20 PM Changeset in webkit [168553] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit2

Expose functions necessary for copying favicon between IconDatabases.
​https://bugs.webkit.org/show_bug.cgi?id=132709

Patch by Gordon Sheridan <​gordon_sheridan@apple.com> on 2014-05-09
Reviewed by Brady Eidson.

• UIProcess/API/C/WKIconDatabase.cpp:

(WKIconDatabaseSetIconURLForPageURL):
Add C API wrapper for WebIconDatabase::setIconURLForPageURL().

(WKIconDatabaseCopyIconURLForPageURL):
Add C API wrapper for WebIconDatabase::synchronousIconURLForPageURL().

• UIProcess/API/C/WKIconDatabase.h:

Added declarations for wrapper functions above.

2:01 PM Changeset in webkit [168552] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

Fix the iOS DRT build by including CG headers in WKPreferences.h, which uses CGFloat.

• UIProcess/API/Cocoa/WKPreferences.h:

1:57 PM Changeset in webkit [168551] by Brent Fulgham

• 3 edits in trunk/Source/WebKit2

{TelephoneNumber, Selection}ControllerMac implementations dosn't handle tiled drawing properly.
​https://bugs.webkit.org/show_bug.cgi?id=132746
<rdar://problem/16789588>

Reviewed by Tim Horton.

Don't try to draw the detector UI if no part of the selection bounds are inside
the current tile. Don't limit the detector UI to the bounds of this tile, or else
it will attempt to squeeze itself into the possibly small space available. Let it
draw as if it had the whole screen, and rely on the context clip region to
avoid overdrawing.

• WebProcess/WebPage/mac/TelephoneNumberOverlayControllerMac.mm:

(WebKit::TelephoneNumberOverlayController::drawRect): Correct tiled drawing behavior.

• WebProcess/WebPage/mac/SelectionOverlayControllerMac.mm:

(WebKit::SelectionOverlayController::drawRect): Ditto.

1:48 PM Changeset in webkit [168550] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Production build fix.

Reviewed by Dan Bernstein.

• Configurations/BaseTarget.xcconfig:

Add SDKROOT in front of UMBRELLA_FRAMEWORKS_DIR for OS X Production builds.

1:28 PM Changeset in webkit [168549] by akling@apple.com

• 2 edits in trunk/Source/JavaScriptCore

8.8% spent in Object.prototype.hasOwnProperty() on sbperftest.
<​https://webkit.org/b/132749>

Leverage the fast-resolve-to-AtomicString optimization for JSRopeString
in Object.prototype.* by using JSString::toIdentifier() in the cases where
we are converting JSString -> String -> Identifier.

This brings time spent in hasOwnProperty() from 8.8% to 1.3% on
"The Great HTML5 Gaming Performance Test: 2014 edition"
<​http://www.scirra.com/demos/c2/sbperftest/>

Reviewed by Oliver Hunt.

• runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncHasOwnProperty):
(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):

1:26 PM Changeset in webkit [168548] by mhahnenberg@apple.com

• 11 edits in trunk/Source

JSDOMWindow should have a WatchpointSet to fire on window close
​https://bugs.webkit.org/show_bug.cgi?id=132721

Reviewed by Filip Pizlo.

Source/JavaScriptCore:
This patch allows us to reset the inline caches that assumed they could skip
the first part of JSDOMWindow::getOwnPropertySlot that checks if the window has
been closed. This is part of getting rid of HasImpureGetOwnPropertySlot on JSDOMWindow.

PropertySlot now accepts a WatchpointSet which the inline cache code can look for
to see if it should create a new Watchpoint for that particular inline cache site.

• bytecode/Watchpoint.h:
• jit/Repatch.cpp:

(JSC::generateByIdStub):
(JSC::tryBuildGetByIDList):
(JSC::tryCachePutByID):
(JSC::tryBuildPutByIdList):

• runtime/PropertySlot.h:

(JSC::PropertySlot::PropertySlot):
(JSC::PropertySlot::watchpointSet):
(JSC::PropertySlot::setWatchpointSet):

Source/WebCore:
No new tests.

This patch allows us to reset the inline caches that assumed they could skip
the first part of JSDOMWindow::getOwnPropertySlot that checks if the window has
been closed. This is part of getting rid of HasImpureGetOwnPropertySlot on JSDOMWindow.

JSDOMWindowBase now has a WatchpointSet that the underlying DOMWindow fires when its
frame is cleared. In getOwnPropertySlot, we now pass this WatchpointSet to PropertySlot
which will shepherd it back up to the code that generates the inline cache (and the
Watchpoint for clearing it).

• bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::JSDOMWindowBase):
(WebCore::JSDOMWindowBase::fireFrameClearedWatchpointsForWindow):

• bindings/js/JSDOMWindowBase.h:
• bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlot):

• page/DOMWindow.cpp:

(WebCore::DOMWindow::frameDestroyed):

1:25 PM Changeset in webkit [168547] by dfarler@apple.com

• 3 edits in trunk/Tools

com.apple.iphonesimulator.startSession needs to pass "RuntimeIdentifier"
​https://bugs.webkit.org/show_bug.cgi?id=132718

Reviewed by David Kilzer.

The simulator may not be able to look up runtimes by SDK paths
and instead will map SDK versions to runtimes instead. In
com.apple.iphonesimulator.startSession notifications,
'runtimeIdentifier' (SDK version string) is preferred over
'sdkRoot' (SDK path) anyway. Include the 'runtimeIdentifier' key
when creating a new DRT or WKTR simulator session.

IPhoneSimulatorNotification.pm filters out keys for this
notification's userInfo with a hard-coded list. There's no harm
in including extra key-value pairs in an NSNotification userInfo
dictionary anyway and the simulator may again change its
userInfo schema for this notification.

• DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:

(postStartSessionNotification):

• Scripts/old-run-webkit-tests:

(installAndLaunchDumpToolAppUsingNotification):

1:16 PM Changeset in webkit [168546] by andersca@apple.com

• 2 edits in trunk/Tools

Another build fix.

• Scripts/build-webkit:

WebKit2 should always be built for OS X and iOS.

12:36 PM Changeset in webkit [168545] by andersca@apple.com

• 2 edits in trunk/Tools

Follow-up build fix.

• Scripts/build-webkit:

WebKit2 should no longer be built before WebKit.

12:31 PM Changeset in webkit [168544] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

[iOS WebKit2] Flush RemoteLayerBackingStore contexts on a secondary queue
​https://bugs.webkit.org/show_bug.cgi?id=132667
<rdar://problem/15349483>

• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::create):
Address a missed review comment about a missing std::move.

12:05 PM Changeset in webkit [168543] by commit-queue@webkit.org

• 13 edits
  1 copy
  29 adds in trunk

ASSERTION FAILED: object->style()->overflowX() == object->style()->overflowY()
​https://bugs.webkit.org/show_bug.cgi?id=121682

Patch by Zsolt Borbely <​zsborbely.u-szeged@partner.samsung.com> on 2014-05-09
Reviewed by Dirk Schulze.

Source/WebCore:
Add more overflow freedom to the SVG element:
-overflow-x and overflow-y for controlling each scrollbar independently is now supported
-overflow:scroll will display scrollbars regardless of the svg overflowing or not (as required by CSS)
-overflow:hidden will cause overflow to be clipped away and scrollbars to be hidden

Merged from Blink r172126 by <​ed@opera.com>

Tests: svg/W3C-SVG-1.1-SE/painting-marker-05-f.svg

svg/W3C-SVG-1.1-SE/painting-marker-06-f.svg
svg/animations/animate-viewport-overflow-2.html
svg/animations/animate-viewport-overflow.html
svg/in-html/overflow-repaint.html
svg/in-html/overflow-svg-root-attr.html
svg/in-html/overflow-svg-root-style.html
svg/in-html/overflow-svg-root.html
svg/overflow/overflow-on-outermost-svg-element-horizontal-auto.svg
svg/overflow/overflow-on-outermost-svg-element-vertical-auto.svg
svg/overflow/overflow-scroll-on-outermost-svg-element.svg
svg/overflow/overflow-x-hidden-on-outermost-svg-element-expected.svg
svg/overflow/overflow-x-hidden-on-outermost-svg-element.svg
svg/overflow/overflow-y-hidden-on-outermost-svg-element-expected.svg
svg/overflow/overflow-y-hidden-on-outermost-svg-element.svg

• css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):

• page/FrameView.cpp:

(WebCore::FrameView::applyOverflowToViewport):

• rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::layout):
(WebCore::RenderSVGRoot::shouldApplyViewportClip):
(WebCore::RenderSVGRoot::paintReplaced):
(WebCore::RenderSVGRoot::computeFloatRectForRepaint):

• rendering/svg/RenderSVGRoot.h:
• rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::isOverflowHidden):

LayoutTests:
Merge Blink r172126 by Erik Dahlström.

• platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt:
• platform/mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.png:
• platform/mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt:
• platform/mac/svg/text/non-bmp-positioning-lists-expected.txt: Added.
• svg/W3C-SVG-1.1-SE/painting-marker-05-f-expected.png: Added.
• svg/W3C-SVG-1.1-SE/painting-marker-05-f-expected.txt: Added.
• svg/W3C-SVG-1.1-SE/painting-marker-05-f.svg: Added.
• svg/W3C-SVG-1.1-SE/painting-marker-06-f-expected.png: Added.
• svg/W3C-SVG-1.1-SE/painting-marker-06-f-expected.txt: Added.
• svg/W3C-SVG-1.1-SE/painting-marker-06-f.svg: Added.
• svg/animations/animate-viewport-overflow-2-expected.txt: Added.
• svg/animations/animate-viewport-overflow-2.html: Added.
• svg/animations/animate-viewport-overflow-expected.txt: Added.
• svg/animations/animate-viewport-overflow.html: Added.
• svg/in-html/overflow-repaint-expected.txt: Added.
• svg/in-html/overflow-repaint.html: Added.
• svg/in-html/overflow-svg-root-attr-expected.html: Added.
• svg/in-html/overflow-svg-root-attr.html: Added.
• svg/in-html/overflow-svg-root-expected.html: Added.
• svg/in-html/overflow-svg-root-style-expected.html: Added.
• svg/in-html/overflow-svg-root-style.html: Added.
• svg/in-html/overflow-svg-root.html: Added.
• svg/overflow/overflow-on-outermost-svg-element-horizontal-auto-expected.html: Added.
• svg/overflow/overflow-on-outermost-svg-element-horizontal-auto.svg: Added.
• svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt:
• svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.png:
• svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt: Copied from LayoutTests/platform/mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt.
• svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible.xhtml:
• svg/overflow/overflow-on-outermost-svg-element-vertical-auto-expected.html: Added.
• svg/overflow/overflow-on-outermost-svg-element-vertical-auto.svg: Added.
• svg/overflow/overflow-scroll-on-outermost-svg-element-expected.txt: Added.
• svg/overflow/overflow-scroll-on-outermost-svg-element.svg: Added.
• svg/overflow/overflow-x-hidden-on-outermost-svg-element-expected.svg: Added.
• svg/overflow/overflow-x-hidden-on-outermost-svg-element.svg: Added.
• svg/overflow/overflow-y-hidden-on-outermost-svg-element-expected.svg: Added.
• svg/overflow/overflow-y-hidden-on-outermost-svg-element.svg: Added.

11:47 AM Changeset in webkit [168542] by ap@apple.com

• 2 edits in trunk/LayoutTests

REGRESSION (r168448): fast/multicol/newmulticol/first-letter-create.html is very flaky
​https://bugs.webkit.org/show_bug.cgi?id=132744

• TestExpectations: Marked as such.

11:39 AM Changeset in webkit [168541] by andersca@apple.com

• 236 edits
  7 copies
  2 adds
  1 delete in trunk

Rename WebKit2.framework to WebKit.framework
​https://bugs.webkit.org/show_bug.cgi?id=132743
<rdar://problem/15920046>

Reviewed by Dan Bernstein.

.:

• Source/Makefile:

Build WebKit.xcodeproj before WebKit2.xcodeproj.

• WebKit.xcworkspace/xcshareddata/xcschemes/:

Ditto.

Source/WebKit:

• WebKit.xcodeproj/project.pbxproj:

Remove the WebKit framework, it lives inside WebKit2 now.

Source/WebKit2:

• Configurations/BaseLegacyProcess.xcconfig:

Change INSTALL_PATH to WebKit.framework.

• Configurations/BaseTarget.xcconfig:

Change WEBKIT2_FRAMEWORKS_DIR to WEBKIT_FRAMEWORKS_DIR and add WEBKIT_LEGACY_PRIVATE_HEADERS_DIR.

• Configurations/BaseXPCService.xcconfig:

Change WebKit2.framework to WebKit.framework.

• Configurations/WebKit.xcconfig: Copied from Source/WebKit2/Configurations/WebKit2.xcconfig.

New configuration file for WebKit.framework. Re-export WebKitLegacy.framework.

• Configurations/WebKit2.xcconfig:

New configuration file for the WebKit2 shim framework. Re-export WebKit.framework.

• NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX.plist:

Update DYLD_INSERT_LIBRARIES to refer to WebKit.framework.

• PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist:

Update DYLD_INSERT_LIBRARIES to refer to WebKit.framework.

• Shared/API/Cocoa/WKBrowsingContextHandle.h:
• Shared/API/Cocoa/WKRenderingProgressEvents.h:

Update header imports.

• Shared/API/Cocoa/WebKit.h: Renamed from Source/WebKit/mac/WebKitLegacy/WebKit.h.

New umbrella header. Imports the modern WebKit API as well as the legacy API.

• Shared/API/Cocoa/WebKit.m: Renamed from Source/WebKit/mac/WebKitLegacy/WebKit.m.

Export install name symbols on iOS.

• Shared/API/Cocoa/WebKitPrivate.h: Renamed from Source/WebKit/mac/WebKitLegacy/WebKitPrivate.h.

New umbrella SPI header. Imports the modern WebKit SPI.

• Many headers:

Change WebKit2 includes to WebKit includes.

• Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:

(WebKit::XPCServiceEventHandler):
Change bundle identifiers from com.apple.WebKit2 to com.apple.WebKit.

• Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:

(WebKit::XPCServiceEventHandler):
Change bundle identifier from com.apple.WebKit2 to com.apple.WebKit.

• UIProcess/API/Cocoa/WKPreferences.h:

Stop including WKPreferencesRef.h, we have a WebKit2 header that handles this workaround for us now.

• UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::addDYLDEnvironmentAdditions):
(WebKit::connectToService):
(WebKit::createProcess):
(WebKit::ProcessLauncher::launchProcess):
Change bundle identifiers from com.apple.WebKit2 to com.apple.WebKit.

• UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::createPropertyListFile):
Change bundle identifiers from com.apple.WebKit2 to com.apple.WebKit.

• UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformDefaultDiskCacheDirectory):
Change bundle identifier from com.apple.WebKit2 to com.apple.WebKit.

• WebKit2.xcodeproj/project.pbxproj:

Copy the python message scripts to the WebKit2 framework.
Rename WebKit2.framework to WebKit.framework everywhere.
Add a new WebKit2 target that builds the shim WebKit2 framework.
Move the build script phase that migrates WebKitLegacy headers to WebKit.
Add a new build script phase that adds forwarding headers from WebKit2 to WebKit.

• WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist:

Update DYLD_INSERT_LIBRARIES to refer to WebKit.framework.

• mac/MigrateHeadersFromWebKitLegacy.make: Renamed from Source/WebKit/mac/WebKitLegacy/MigrateHeadersFromWebKitLegacy.make.

Move the makefile that migrates WebKitLegacy headers here. On OS X, it copies the header contents and on iOS it creates forarding headers.

• mac/MigrateHeadersToWebKit2.make:

New makefile that creates forwarding headers for the WebKit2 shim framework.

• mac/WKPreferences.h: Added.

Add WebKit2/WKPreferences.h header that imports WebKit2/WKPreferencesref.h.

• mac/WebKit2.m:

Skeleton for the WebKit2 shim framework.

• mac/Info-WebKit2.plist: Added.

New Info.plist file for the WebKit2 shim framework.

Tools:

• Scripts/check-for-inappropriate-files-in-framework:

Use PRODUCT_NAME instead of PROJECT_NAME when matching frameworks.
Change WebKit2 to WebKit.

• Scripts/check-for-webkit-framework-include-consistency:

Change WebKit to WebKitLegacy.

11:20 AM Changeset in webkit [168540] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Fix build warning (uninitialized variable) in DFGFixupPhase.cpp
​https://bugs.webkit.org/show_bug.cgi?id=132331

Patch by Tanay C <​tanay.c@samsung.com> on 2014-05-09
Reviewed by Darin Adler.

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::injectTypeConversionsForEdge):

11:19 AM Changeset in webkit [168539] by Lucas Forschler

• 2 edits in branches/safari-538.34-branch/Source/WebKit2

Merged r168499.

11:17 AM Changeset in webkit [168538] by Lucas Forschler

• 4 edits
  2 copies in branches/safari-538.34-branch

Merged r168460.

9:55 AM Changeset in webkit [168537] by Manuel Rego Casasnovas

• 2 edits in trunk/Tools

Remove GTK+ WK1 EWS from build.webkit.org/dashboard
​https://bugs.webkit.org/show_bug.cgi?id=132732

Reviewed by Alexey Proskuryakov.

GTK+ WK1 EWS was removed in r166427, so it shouldn't appear in the dashboard.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:

(EWS): Remove GTK+ WK1 EWS.

9:44 AM Changeset in webkit [168536] by jer.noble@apple.com

• 3 edits in trunk/Source/WebCore

[MSE][Mac] Destroy the AVStreamDataParser when the SourceBuffer is removed from its MediaSource.
​https://bugs.webkit.org/show_bug.cgi?id=132710

Reviewed by Eric Carlson.

The AVStreamDataParser should be destroyed when the SourceBuffer is removed, so that subsequent
SourceBuffers can utilize resources released by the parser on destruction.

• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(-[WebAVStreamDataParserListener invalidate]):
(-[WebAVStreamDataParserListener streamDataParser:didParseStreamDataAsAsset:]): Protect against _parent being invalidated.
(-[WebAVStreamDataParserListener streamDataParser:didParseStreamDataAsAsset:withDiscontinuity:]): Ditto.
(-[WebAVStreamDataParserListener streamDataParser:didFailToParseStreamDataWithError:]): Ditto.
(-[WebAVStreamDataParserListener streamDataParser:didProvideMediaData:forTrackID:mediaType:flags:]): Ditto.
(WebCore::SourceBufferPrivateAVFObjC::~SourceBufferPrivateAVFObjC): Call destroyParser();.
(WebCore::SourceBufferPrivateAVFObjC::removedFromMediaSource): Ditto.
(WebCore::SourceBufferPrivateAVFObjC::destroyParser): Call -[WebAVStreamDataParserListener invalidate].

9:29 AM Changeset in webkit [168535] by commit-queue@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

[Win] Crash when enabling DFG JIT.
​https://bugs.webkit.org/show_bug.cgi?id=132683

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-05-09
Reviewed by Geoffrey Garen.

On windows, using register GPRInfo::regT0 as parameter to e.g. JIT::storeDouble(..., GPRInfo::regT0)),
results in a call to JIT::storeDouble(FPRegisterID src, const void* address),
where the address parameter gets the value of GPRInfo::regT0, which is 0 (eax on Windows).
This causes the register to be written to address 0, hence the crash.

• dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit): Use address in regT0 as parameter.

• dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit): Ditto.

9:15 AM Changeset in webkit [168534] by abucur@adobe.com

• 4 edits in trunk/Source/WebCore

[CSS Regions] 1-2% performance regression in html5-full-render after r168286
​https://bugs.webkit.org/show_bug.cgi?id=132672

Reviewed by Mihnea Ovidenie.

The patch optimizes the search of regions when there's a single region in the chain.
There's no need to execute advanced search logic, we can directly return that region.

Tests: No function change, no tests.

• rendering/RenderBlock.cpp:

(WebCore::canComputeRegionRangeForBox):

• rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::regionAtBlockOffset):
(WebCore::RenderFlowThread::hasCachedRegionRangeForBox): Renamed from hasRegionRangeForBox to
better suggest what the function does.
(WebCore::RenderFlowThread::getRegionRangeForBox):
(WebCore::RenderFlowThread::hasRegionRangeForBox): Deleted.

• rendering/RenderFlowThread.h:

8:54 AM Changeset in webkit [168533] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

[EME] Call suspendIfNeeded() in the MediaKeySession create() method to avoid an ASSERT.
​https://bugs.webkit.org/show_bug.cgi?id=132712

Reviewed by Eric Carlson.

All ActiveDOMObject subclasses must call suspendIfNeeded() immediately after creation.

• Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::MediaKeySession):

8:08 AM Changeset in webkit [168532] by commit-queue@webkit.org

• 3 edits
  2 adds
  3 deletes in trunk/LayoutTests

[CSS Blending] Move background-blend-mode tests from fast/repaint to css3/blending and remove the -webkit- prefix
​https://bugs.webkit.org/show_bug.cgi?id=132741

Patch by Ion Rosca <Ion Rosca> on 2014-05-09
Reviewed by Mihnea Ovidenie.

Remove the -webkit prefix from comments:

• css3/blending/background-blend-mode-property-expected.txt:
• css3/blending/script-tests/background-blend-mode-property.js:

Move the background-blend-mode test from fast/repaint to css3/blending.
This is not required to be a repaint test. It works well as a regular reftest too.

• css3/blending/background-blend-mode-image-color-dynamic-expected.html: Added.
• css3/blending/background-blend-mode-image-color-dynamic.html: Added.
• fast/repaint/background-blend-mode-image-color-dynamic-expected.html: Removed.
• fast/repaint/background-blend-mode-image-color-dynamic.html: Removed.
• fast/repaint/resources/ducky.png: Removed.

7:59 AM WebKitGTK/2.2.x edited by vjaquez@igalia.com

(diff)

7:56 AM Changeset in webkit [168531] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

Unreviewed. Another attempt to fix Windows build after r168528.

• platform/graphics/win/FontWin.cpp:

(WebCore::Font::adjustSelectionRectForComplexText):

7:42 AM Changeset in webkit [168530] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r167094): JSC crashes on ARM Traditional
​https://bugs.webkit.org/show_bug.cgi?id=132738

Patch by Martin Hodovan <​mhodovan.u-szeged@partner.samsung.com> on 2014-05-09
Reviewed by Zoltan Herczeg.

PC is two instructions ahead of the current instruction
on ARM Traditional, so the distance is 8 bytes not 2.

• llint/LowLevelInterpreter.asm:

7:35 AM Changeset in webkit [168529] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

Unreviewed build fix for Win after r168528.

• platform/graphics/win/FontWin.cpp:

(WebCore::Font::adjustSelectionRectForComplexText):

7:20 AM Changeset in webkit [168528] by Alan Bujtas

• 18 edits
  5 adds in trunk

REGRESSION (r168095): 1-pixel gap between adjacent selection inlines
​https://bugs.webkit.org/show_bug.cgi?id=132474
<rdar://problem/16797394>

Reviewed by David Hyatt.

This patch changes text selection rectangle calculation from integral to device
pixel snapping. It ensures that selection rect painting matches box boundaries for inline elements.
Directional rounding (horizontal only atm) is moved out from Font class and now accessible
to all the painting code. RTL snapping strategy is changed from floor to round to match ltr behavior.
However this patch does not address all the integral snapping across inline elements. There are
a few places where we still calculate enclosing rects where snapping is sufficient.

Source/WebCore:
Test: fast/inline/hidpi-pixel-gap-between-adjacent-selection-inlines.html

• platform/LayoutUnit.h:

(WebCore::roundToDevicePixel): added fudge factor to change rounding direction as directed.

• platform/graphics/Font.cpp:

(WebCore::Font::adjustSelectionRectForText):
(WebCore::Font::selectionRectForText): Deleted.

• platform/graphics/Font.h:
• platform/graphics/FontFastPath.cpp:

(WebCore::Font::adjustSelectionRectForSimpleText): removed directional rounding.
(WebCore::Font::selectionRectForSimpleText): Deleted.

• platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawHighlightForText): Deleted.

• platform/graphics/GraphicsContext.h:
• platform/graphics/LayoutPoint.h:

(WebCore::roundedForPainting):

• platform/graphics/LayoutRect.h:

(WebCore::directionalPixelSnappedForPainting): Snap top right corner for rtl direction.

• platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:

(WebCore::Font::adjustSelectionRectForComplexText):
(WebCore::Font::selectionRectForComplexText): Deleted.

• platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::adjustSelectionRectForComplexText): removed directional rounding.
(WebCore::Font::selectionRectForComplexText): Deleted.

• platform/graphics/win/FontWin.cpp:

(WebCore::Font::adjustSelectionRectForComplexText):
(WebCore::Font::selectionRectForComplexText): Deleted.

• rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::selectionRect):
(WebCore::EllipsisBox::paintSelection):

• rendering/InlineTextBox.cpp:

(WebCore::integralEnclosingRectForSelection): helper to address enclosing empty rect problem.
(WebCore::InlineTextBox::localSelectionRect):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDocumentMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
(WebCore::InlineTextBox::positionForOffset):

• rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::selectionRectForTextFragment):

LayoutTests:

• fast/inline/hidpi-pixel-gap-between-adjacent-selection-inlines-expected.html: Added.
• fast/inline/hidpi-pixel-gap-between-adjacent-selection-inlines.html: Added.
• platform/mac/editing/selection/mixed-editability-10-expected.txt: progression.
• platform/mac/fast/forms/cursor-at-editable-content-boundary-expected.txt: progression.
• platform/mac/platform/mac/editing/input/caret-primary-bidi-expected.txt: Added. change in rounding strategy.
• platform/mac/svg/text/caret-in-svg-text-expected.txt: Added. progression + change in rounding strategy.

6:34 AM Changeset in webkit [168527] by Csaba Osztrogonác

• 2 edits in trunk/Tools

Add new u-szeged contributors.

Patch by Eva Balazsfalvi <​evab.u-szeged@partner.samsung.com> on 2014-05-09
Reviewed by Csaba Osztrogonác.

• Scripts/webkitpy/common/config/contributors.json:

5:49 AM Changeset in webkit [168526] by Carlos Garcia Campos

• 3 edits in trunk/Tools

REGRESSION(CMAKE): [GTK] run-gtk-tests doesn't set the right injected bundle path
​https://bugs.webkit.org/show_bug.cgi?id=132736

Reviewed by Philippe Normand.

There are two problems, the path returned by common.library_build_path() is wrong when
common.binary_build_path() has previously been called, and the test is still looking for
the .la instead of .so

• TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:

(TestWebKitAPI::Util::createInjectedBundlePath): Use .so instead
of .la as extension of the injected bundle library.

• gtk/common.py:

(binary_build_path): Remove unused global variable and add a new
one for binary_build_dir instead of sharing the same global
variable for library_build_path and binary_build_path.

5:49 AM Changeset in webkit [168525] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[WK2] Make generate-forwarding-headers.pl work after WebKit2.framework -> WebKit.framework rename
​https://bugs.webkit.org/show_bug.cgi?id=132733

Patch by Martin Hodovan <​mhodovan.u-szeged@partner.samsung.com> on 2014-05-09
Reviewed by Csaba Osztrogonác.

Rewrite framework's directory name to WebKit2 if the framework is WebKit (former WebKit2)
and then collect headers inside the fixed framework directory and generate forwarding
headers point to the fixed directory.

Leave WebKit2 in @frameworks list during the transition. It can be removed
once <WebKit2/foo.h> style includes were renamed to <WebKit/foo.h> everywhere.

• Scripts/generate-forwarding-headers.pl:

(collectFameworkHeaderPaths):
(createForwardingHeadersForFramework):

3:58 AM Changeset in webkit [168524] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

ASSERTION FAILED: !m_code

m_code == defaultExceptionCode

in WebCore::constructQualifiedName
​https://bugs.webkit.org/show_bug.cgi?id=132343

'Remove bad assertion in SVGSMILElement's constructQualifiedName() by passing
IGNORE_EXCEPTION instead ASSERT_NO_EXCEPTION to Document::parseQualifiedName().
The constructQualifiedName() function handles parseQualifiedName() failures
propertly by returning early so there is no reason to assert on parsing
failures.'

Blink merge: ​http://src.chromium.org/viewvc/blink?view=revision&revision=173564
Based on the patch made by Christophe Dumez <​ch.dumez@samsung.com>.

Patch by Martin Hodovan <​mhodovan@inf.u-szeged.hu> on 2014-05-09
Reviewed by Dirk Schulze.

Source/WebCore:
Test: svg/custom/bad-attributeName-crash.html

• svg/animation/SVGSMILElement.cpp:

(WebCore::constructQualifiedName):

LayoutTests:

• svg/custom/bad-attributeName-crash-expected.txt: Added.
• svg/custom/bad-attributeName-crash.html: Added.

12:10 AM Changeset in webkit [168523] by berto@igalia.com

• 4 edits in trunk/Source

jsmin.py license header confusing, mentions non-free license
​https://bugs.webkit.org/show_bug.cgi?id=123665

Reviewed by Darin Adler.

Pull the most recent version from upstream, which has a clear
license.

Source/JavaScriptCore:

• inspector/scripts/jsmin.py:

Source/WebInspectorUI:

• Scripts/jsmin.py:

May 8, 2014:

11:19 PM Changeset in webkit [168522] by ap@apple.com

• 2 edits in trunk/LayoutTests

REGRESSION (r168518): Multiple tests for workers in blobs assert
​https://bugs.webkit.org/show_bug.cgi?id=132728

• platform/mac/TestExpectations: Skipped for now.

11:01 PM Changeset in webkit [168521] by rniwa@webkit.org

• 4 edits
  72 adds in trunk/PerformanceTests

DYEBench should use TodoMVC to test FlightJS for consistency
​https://bugs.webkit.org/show_bug.cgi?id=132727

Reviewed by Andreas Kling.

Add a test suite for the FlightJS version of TodoMVC, and disable FlightJS-MailClient by default.

I initially intended to include a wider variety of demo apps in DYEBench
but that's not happening any time soon so let us use TodoMVC for all frameworks for now.

We can add more demo apps in v2.

• DoYouEvenBench/Full.html: Increment the version to 0.10.
• DoYouEvenBench/InteractiveRunner.html: Don't check disabled suites by default.
• DoYouEvenBench/resources/tests.js:
• DoYouEvenBench/resources/todomvc/dependency-examples: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/.gitignore: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/.jshintrc: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js/app.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js/data: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js/data/stats.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js/data/todos.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js/main.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js/store.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js/ui: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js/ui/main_selector.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js/ui/new_item.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js/ui/stats.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js/ui/todo_list.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js/ui/toggle_all.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js/ui/with_filters.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/js/utils.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/templates: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/templates/stats.html: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/app/templates/todo.html: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower.json: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/depot: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/depot/depot.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/es5-shim: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/es5-shim/es5-sham.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/es5-shim/es5-shim.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/flight: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/flight/lib: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/advice.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/base.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/component.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/compose.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/debug.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/index.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/logger.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/registry.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/utils.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/jquery: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/jquery/jquery.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/requirejs: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/requirejs-text: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/requirejs-text/text.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/requirejs/require.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/todomvc-common: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/todomvc-common/base.css: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/todomvc-common/base.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/todomvc-common/bg.png: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/index.html: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/karma.conf.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/package.json: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/readme.md: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/.jshintrc: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/fixture: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/fixture/footer.html: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/fixture/new_todo.html: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/fixture/toggle_all.html: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/mock: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/mock/datastore.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/spec: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/spec/data: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/spec/data/stats_spec.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/spec/data/todos_spec.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/spec/ui: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/spec/ui/new_item_spec.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/spec/ui/stats_spec.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/spec/ui/toggle_all_spec.js: Added.
• DoYouEvenBench/resources/todomvc/dependency-examples/flight/test/test-main.js: Added.

10:32 PM Changeset in webkit [168520] by commit-queue@webkit.org

• 4 edits in trunk

[EFL] Enable MEDIA_STREAM for EFL port
​https://bugs.webkit.org/show_bug.cgi?id=132648

Patch by Praveen R Jadhav <​praveen.j@samsung.com> on 2014-05-08
Reviewed by Gyuyoung Kim.

Tools:
Script modified to enable MEDIA_STREAM for EFL build.

• Scripts/webkitperl/FeatureList.pm:

LayoutTests:
Updated webaudio test case expectation after enabling MEDIA_STREAM

• platform/efl/TestExpectations:

10:20 PM Changeset in webkit [168519] by Brent Fulgham

• 6 edits in trunk/Source/WebCore

Multiple (stacked) cues when shuttling through video while playing closed captions
​https://bugs.webkit.org/show_bug.cgi?id=132715
<rdar://problem/16795782>

Reviewed by Eric Carlson.

Tests: media/track/track-in-band-cues-added-once.html

• html/track/TextTrack.cpp:

(WebCore::TextTrack::hasCue): Revise to use a relaxed time equality.

• html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::isEqual): Ditto.
(WebCore::TextTrackCue::hasEquivalentStartTime): Added.

• html/track/TextTrackCue.h:

(WebCore::TextTrackCue::startTimeVariance): Added.

• html/track/TextTrackCueGeneric.h:
• html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGeneric::isEqual): Do not call the VTTCue::isEqual method from
this class, since cueType() will not equal VTTCue, and the equality will fail.

9:37 PM Changeset in webkit [168518] by ap@apple.com

• 15 edits
  2 adds in trunk/Source

Automatically zip document bundles used via File API
​https://bugs.webkit.org/show_bug.cgi?id=132713
<rdar://problem/13397892>

Reviewed by Anders Carlsson.

Source/WebCore:
Tests: fast/files/filereader-zip-bundle.html

http/tests/local/fileapi/upload-zip-bundle-as-blob.html

• FileMac.mm: Added.

(WebCore::File::shouldReplaceFile):
(WebCore::File::computeNameAndContentTypeForReplacedFile):
Added code that decides what to do with a bundle. We need this to happen in
WebProcess, because HTML5 dropzone depends on this, it needs to know file type
even before a File object can be created.

• WebCore.exp.in: Export new functions.

• WebCore.xcodeproj/project.pbxproj: Added new files.

• dom/DataTransfer.cpp: (WebCore::DataTransfer::hasFileOfType): Updated for File

interface change.

• fileapi/File.h:
• fileapi/File.cpp:

(WebCore::File::File):
(WebCore::File::computeNameAndContentType):
(WebCore::File::contentTypeForFile):
(WebCore::File::contentTypeFromFilePathOrName): Deleted.
Make it possible for a subclass to affect file name and content type calculation.

• platform/network/BlobDataFileReference.cpp:

(WebCore::BlobDataFileReference::BlobDataFileReference):
(WebCore::BlobDataFileReference::~BlobDataFileReference):
(WebCore::BlobDataFileReference::path):
(WebCore::BlobDataFileReference::size):
(WebCore::BlobDataFileReference::expectedModificationTime):
(WebCore::BlobDataFileReference::startTrackingModifications):

• platform/network/BlobDataFileReference.h:

(WebCore::BlobDataFileReference::path): Deleted.
(WebCore::BlobDataFileReference::BlobDataFileReference): Deleted.
Use original or replaced file, as appropriate.

• platform/network/mac/BlobDataFileReferenceMac.mm: Added.

(WebCore::BlobDataFileReference::generateReplacementFile): Implements generateReplacementFile().

• platform/network/FormData.h: Added a FIXME.

• xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send): Always use Blob code path

for blobs, don't unwrap them into a file path.

Source/WebKit2:

• NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: NetworkProcess

now uses FileCoordination (WebProcess already had this allowed).

• Shared/BlobDataFileReferenceWithSandboxExtension.h: Added final to the class.

Source/WTF:

• wtf/FeatureDefines.h: Added ENABLE_FILE_REPLACEMENT for Mac.

9:11 PM Changeset in webkit [168517] by fpizlo@apple.com

• 1 copy in branches/ftlopt

Create a branch for risky FTL enhancements

9:02 PM Changeset in webkit [168516] by Lucas Forschler

• 5 edits in branches/safari-538.34-branch/Source

Versioning.

8:59 PM Changeset in webkit [168515] by Lucas Forschler

• 1 copy in tags/Safari-538.34.1

New Tag.

7:26 PM Changeset in webkit [168514] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Occasional crash under AsyncScrollingCoordinator::frameViewRootLayerDidChange() on history navigation
​https://bugs.webkit.org/show_bug.cgi?id=132723

Reviewed by Sam Weinig.

Crash reports suggest that when we call AsyncScrollingCoordinator::frameViewRootLayerDidChange()
from HistoryController::restoreScrollPositionAndViewState(), the FrameView may not have a
scrolling node ID, which suggests that either the FrameView doesn't have a RenderView,
or compositing hasn't happened yet.

So if we enter AsyncScrollingCoordinator::frameViewRootLayerDidChange()
and the FrameView has no scrollLayerID, just return. We'll fix things up
when compositing kicks in later.

• page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::frameViewRootLayerDidChange):

6:08 PM Changeset in webkit [168513] by Simon Fraser

• 4 edits in trunk/Source

[iOS WK2] Bottom-relative position:fixed elements are misplaced on page load
​https://bugs.webkit.org/show_bug.cgi?id=132719
<rdar://problem/16860837>

Reviewed by Benjamin Poulain.

Source/WebCore:

Add a couple of functions, and sort.

• WebCore.exp.in:

Source/WebKit2:

If we haven't received visible rects from the web process, compute the
fixed position rect, but only after scale has been set.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::viewportConfigurationChanged):

6:06 PM Changeset in webkit [168512] by jer.noble@apple.com

• 15 edits in trunk/Source

[Mac, iOS] Add source application accounting to AVURLAsset.
​https://bugs.webkit.org/show_bug.cgi?id=132637

Reviewed by Eric Carlson.

Source/WebCore:
Properly account for the application responisble for data loading by passing the source
application identifier through to AVFoundation through AVURLAsset options.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

• html/HTMLMediaElement.h:
• platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::sourceApplicationIdentifier):

• platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerSourceApplicationIdentifier):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):

• platform/network/NetworkingContext.h:

Source/WebKit/mac:
Add accessor for sourceApplicationIdentifier.

• WebCoreSupport/WebFrameNetworkingContext.h:
• WebCoreSupport/WebFrameNetworkingContext.mm:

(WebFrameNetworkingContext::sourceApplicationIdentifier):

Source/WebKit2:
Add accessor for sourceApplicationIdentifier.

• NetworkProcess/RemoteNetworkingContext.h:
• NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::sourceApplicationIdentifier):

• WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
• WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::WebFrameNetworkingContext::sourceApplicationIdentifier):

5:30 PM Changeset in webkit [168511] by dfarler@apple.com

• 2 edits in trunk/Tools

old-run-webkit-tests: update strings for simulator devices and app name
​https://bugs.webkit.org/show_bug.cgi?id=132687

Reviewed by Darin Adler.

iPhone Retina (4-inch) -> iPhone 5
iPhone Retina (4-inch 64-bit) -> iPhone 5s

• Scripts/old-run-webkit-tests:

(installAndLaunchDumpToolAppUsingNotification):
(openIPhoneSimulator):
(quitIPhoneSimulator):
quit iOS Simulator, not iPhone Simulator.

5:22 PM Changeset in webkit [168510] by mhahnenberg@apple.com

• 3 edits
  1 add in trunk/Source/JavaScriptCore

Base case for get-by-id inline cache doesn't check for HasImpureGetOwnPropertySlot
​https://bugs.webkit.org/show_bug.cgi?id=132695

Reviewed by Filip Pizlo.

We check in the case where we're accessing something other than the base object (e.g. the prototype),
but we fail to do so for the base object.

• jit/Repatch.cpp:

(JSC::tryCacheGetByID):
(JSC::tryBuildGetByIDList):

• jsc.cpp: Added some infrastructure to support this test. We don't currently trigger this bug anywhere in WebKit

because all of the values that are returned that could be impure are set to uncacheable anyways.
(WTF::ImpureGetter::ImpureGetter):
(WTF::ImpureGetter::createStructure):
(WTF::ImpureGetter::create):
(WTF::ImpureGetter::finishCreation):
(WTF::ImpureGetter::getOwnPropertySlot):
(WTF::ImpureGetter::visitChildren):
(WTF::ImpureGetter::setDelegate):
(GlobalObject::finishCreation):
(functionCreateImpureGetter):
(functionSetImpureGetterDelegate):

• tests/stress/impure-get-own-property-slot-inline-cache.js: Added.

(foo):

5:22 PM Changeset in webkit [168509] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

[iOS WebKit2] Flush RemoteLayerBackingStore contexts on a secondary queue
​​https://bugs.webkit.org/show_bug.cgi?id=132667
<rdar://problem/16861454>

Rubber-stamped by Simon Fraser.

• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
Add a null check to fix a crash on layers which lose backing store.

5:21 PM Changeset in webkit [168508] by jer.noble@apple.com

• 11 edits in trunk/Source/WebCore

[MSE][Mac] Move AVStreamDataParser off-main-thread.
​https://bugs.webkit.org/show_bug.cgi?id=132698

Reviewed by Eric Carlson.

-[AVStreamDataParser appendStreamData:] can casue the main thread to hang when a
large amount of media data is appended at once. Move the actual parsing of data
to a background (synchronous) dispatch queue, and split SourceBuffer::appendBufferTimerFired
into two functions, the latter of which will be called after the background queue
completes.

• Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::appendBufferTimerFired): Split into sourceBufferPrivateAppendComplete.
(WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Split from appendBufferTimerFired.

• Modules/mediasource/SourceBuffer.h:
• platform/graphics/SourceBufferPrivate.h:
• platform/graphics/SourceBufferPrivateClient.h:
• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(-[WebAVStreamDataParserListener streamDataParser:didParseStreamDataAsAsset:]): Re-dispatch to the

web thread.

(-[WebAVStreamDataParserListener streamDataParser:didParseStreamDataAsAsset:withDiscontinuity:]): Ditto.
(-[WebAVStreamDataParserListener streamDataParser:didFailToParseStreamDataWithError:]): Ditto.
(-[WebAVStreamDataParserListener streamDataParser:didProvideMediaData:forTrackID:mediaType:flags:]): Ditto.
(-[WebAVStreamDataParserListener streamDataParser:didReachEndOfTrackWithTrackID:mediaType:]): Ditto.
(-[WebAVStreamDataParserListener streamDataParser:didProvideContentKeyRequestInitializationData:forTrackID:]): Ditto.
(WebCore::globalDataParserQueue): Added.
(WebCore::SourceBufferPrivateAVFObjC::append): Dispatch to the globalDataParserQueue.
(WebCore::SourceBufferPrivateAVFObjC::appendCompleted): Added.

• platform/mock/mediasource/MockSourceBufferPrivate.cpp:

(WebCore::MockSourceBufferPrivate::append): Adopt sourceBufferPrivateAppendComplete.

• platform/mock/mediasource/MockSourceBufferPrivate.h:

Update SourceBufferPrivateGStreamer to match the new append return value:

• platform/graphics/gstreamer/SourceBufferPrivateGStreamer.cpp:

(WebCore::SourceBufferPrivateGStreamer::append):

• platform/graphics/gstreamer/SourceBufferPrivateGStreamer.h:

5:07 PM Changeset in webkit [168507] by matthew_hanson@apple.com

• 5 edits in branches/safari-537.76-branch/Source

Versioning.

5:02 PM Changeset in webkit [168506] by matthew_hanson@apple.com

• 1 copy in tags/Safari-537.76.4

Versioning.

5:00 PM Changeset in webkit [168505] by matthew_hanson@apple.com

• 5 edits in branches/safari-537.76-branch/Source

Versioning.

4:38 PM Changeset in webkit [168504] by commit-queue@webkit.org

• 7 edits in trunk

Unreviewed, rolling out r168498.
​https://bugs.webkit.org/show_bug.cgi?id=132714

broke Mavericks WK2 (Requested by litherum on #webkit).

Reverted changeset:

"http/tests/security/xss-DENIED-xsl-document-redirect.xml
fails with NetworkProcess"
​https://bugs.webkit.org/show_bug.cgi?id=132523
​http://trac.webkit.org/changeset/168498

4:25 PM Changeset in webkit [168503] by Lucas Forschler

• 5 edits in branches/safari-537.75-branch/Source

Versioning.

4:23 PM Changeset in webkit [168502] by Lucas Forschler

• 1 copy in tags/Safari-537.75.15

New Tag.

4:02 PM Changeset in webkit [168501] by Lucas Forschler

• 2 edits in branches/safari-538.34-branch/Source/WebKit/mac

Merged r168500.

3:42 PM Changeset in webkit [168500] by andersca@apple.com

• 2 edits in trunk/Source/WebKit/mac

Use a different install name for WebKitLegacy.framework for staged framework builds
​https://bugs.webkit.org/show_bug.cgi?id=132711
<rdar://problem/16850620>

Reviewed by Dan Bernstein.

• Configurations/WebKitLegacy.xcconfig:

3:29 PM Changeset in webkit [168499] by Beth Dakin

• 2 edits in trunk/Source/WebKit2

REGRESSION (r168053): Phone number detection boxes are wrong when scrolled
​https://bugs.webkit.org/show_bug.cgi?id=132706
-and corresponding-
<rdar://problem/16787957>

Reviewed by Tim Horton.

We need to paint the boxes in Document coordinates. Range::boundingRect() was
giving us a point that took scroll position into account, and that’s not what we
want. Here we use Range::textQuads() instead so that we can get something in
Document coordinates, and then we need to convert that up to the main Document’s
coordinates.

• WebProcess/WebPage/mac/TelephoneNumberOverlayControllerMac.mm:

(WebKit::textQuadsToBoundingRectForRange):
(WebKit::TelephoneNumberOverlayController::drawRect):

The telephone click function wants a point in Window coordinates.
(WebKit::TelephoneNumberOverlayController::mouseEvent):

3:03 PM Changeset in webkit [168498] by mmaxfield@apple.com

• 7 edits in trunk

http/tests/security/xss-DENIED-xsl-document-redirect.xml fails with NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=132523

Reviewed by Alexey Proskuryakov.

Source/WebCore:
We should not manufacture a response in the event of an error during a
synchronous XHR. In addition, this test removes one place that is
sensitive to such a manufactured response.

Updates test expectations.

• platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::platformLoadResourceSynchronously): Do not
manufacture a response

• platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::platformLoadResourceSynchronously): Do not
manufacture a response

• xml/XSLTProcessorLibxslt.cpp:

(WebCore::docLoaderFunc): Only use the response's URL if no error
occurred.

LayoutTests:
Two tests have been rebaselined, and re-enable test that now passes

• fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt: The test describes

that success causes an ErrorHandler to run, but there was no ErrorHandler line in the
expected output. This now gets printed.

• http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt: Expecting logging

output on failed redirection

• platform/mac-wk2/TestExpectations: Re-enable test that now passes.

2:51 PM Changeset in webkit [168497] by fpizlo@apple.com

• 5 edits in trunk/Source

deleteAllCompiledCode() shouldn't use the suspension worklist
​https://bugs.webkit.org/show_bug.cgi?id=132708

Reviewed by Mark Hahnenberg.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::setOptimizationThresholdBasedOnCompilationResult):

• dfg/DFGPlan.cpp:

(JSC::DFG::Plan::isStillValid):

• heap/Heap.cpp:

(JSC::Heap::deleteAllCompiledCode):

2:29 PM Changeset in webkit [168496] by akling@apple.com

• 2 edits in trunk/Source/WebCore

[iOS] WebKit should listen to critical memory warnings.
<​https://webkit.org/b/132704>
<rdar://problem/16857112>

Listen for DISPATCH_MEMORYSTATUS_PRESSURE_CRITICAL in addition to
DISPATCH_MEMORYSTATUS_PRESSURE_WARN, since we may only get the critical
notification on some systems.

Reviewed by Gavin Barraclough.

• platform/cocoa/MemoryPressureHandlerCocoa.mm:

(WebCore::MemoryPressureHandler::install):

2:20 PM Changeset in webkit [168495] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Web Inspector: InspectorDOMAgent::getAccessibilityPropertiesForNode should gracefully handle bad node
​https://bugs.webkit.org/show_bug.cgi?id=132697

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-05-08
Reviewed by Timothy Hatcher.

• inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getAccessibilityPropertiesForNode):
Gracefully handle no node.

2:07 PM Changeset in webkit [168494] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Console error when launching Web Inspector "Mode htmlmixed failed to advance stream"
​https://bugs.webkit.org/show_bug.cgi?id=132703

Patch by Jono Wells <​jonowells@apple.com> on 2014-05-08
Reviewed by Timothy Hatcher.

The CodeMirror 4 update brought with it a change in the XML mode that
causes our XML mode extension to fail to consume empty paired quotes
correctly.

• UserInterface/Views/CodeMirrorAdditions.js:

Updated extendedXMLToken() to properly handle empty paired quotes.

1:56 PM Changeset in webkit [168493] by timothy_horton@apple.com

• 5 edits in trunk/Source/WebKit2

[iOS WebKit2] Flush RemoteLayerBackingStore contexts on a secondary queue
​https://bugs.webkit.org/show_bug.cgi?id=132667
<rdar://problem/15349483>

Reviewed by Darin Adler.

• Shared/mac/RemoteLayerBackingStore.h:
• Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::takeFrontContextPendingFlush):
(WebKit::RemoteLayerBackingStore::flush): Deleted.
Add takeFrontContextPendingFlush, which returns the painted-but-not-yet-flushed front context,
and drops our reference to it. This needs to be called on all backing store between paints.

• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:

(WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::hasFlushed):

• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::~RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
(WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::create):
(WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::BackingStoreFlusher):
(WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::flush):
(WebKit::flushBackingStoreChangesInTransaction): Deleted.
Flush backing store and send the layer tree commit to the UI process from a dispatch queue.
We will only ever have a single commit in flight at a time, and there's a new
RELEASE_ASSERT to ensure that is the case.
We package up the commit on the main thread; the queue calls CGContextFlush
on all of the newly painted contexts and then tosses the commit over to the UI process.
This is a win in many cases because the Web process main thread can go ahead
and do other non-painting tasks while the queue is blocked on painting.

1:41 PM Changeset in webkit [168492] by Lucas Forschler

• 2 edits in branches/safari-538.34-branch/Source/WebKit/mac

Merged r168482.

1:39 PM Changeset in webkit [168491] by Lucas Forschler

• 5 edits in branches/safari-538.34-branch

Merged r168477.

1:34 PM Changeset in webkit [168490] by matthew_hanson@apple.com

• 6 edits
  1 delete in branches/safari-537.76-branch

Rollout r168034.

1:28 PM Changeset in webkit [168489] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

[wk2] Don't use the XPC-based plugin process for Adobe Reader
​https://bugs.webkit.org/show_bug.cgi?id=132701
<rdar://problem/16792692>

Reviewed by Anders Carlsson.

• UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::shouldUseXPC):
Rename the debugging default to a more modern and accurate name.
Don't use XPC for Adobe Reader.

(WebKit::PluginProcessProxy::platformGetLaunchOptions):
Move the check for plugins that need an executable heap into shouldUseXPC.

1:20 PM Changeset in webkit [168488] by commit-queue@webkit.org

• 2 edits in trunk/Tools

REGRESSION(r168471): Update the builder names on the scheduler list.
​https://bugs.webkit.org/show_bug.cgi?id=132699

Patch by Carlos Alberto Lopez Perez <​clopez@igalia.com> on 2014-05-08
Reviewed by Martin Robinson.

On r168471 I missed to update the builder names for the GTK build
bots on the AnyBranchScheduler type scheduler list of bots.

• BuildSlaveSupport/build.webkit.org-config/config.json:

1:10 PM Changeset in webkit [168487] by benjamin@webkit.org

• 2 edits in trunk/Source/WebKit2

[iOS][WK2] Remove an incorrect assertion on asynchronous touch dispatch
​https://bugs.webkit.org/show_bug.cgi?id=132660

Reviewed by Enrica Casucci.

This assertion no longer make sense after r168393. Now the asynchronous behavior is maintained
until the last finger leaves the screen.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleTouchEventAsynchronously):

12:52 PM Changeset in webkit [168486] by Lucas Forschler

• 5 edits in branches/safari-538.34-branch/Source

Versioning.

12:40 PM Changeset in webkit [168485] by Lucas Forschler

• 1 copy in branches/safari-538.34-branch

New Branch.

12:40 PM Changeset in webkit [168484] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Selecting frame in debugger sidebar doesn't reveal code
​https://bugs.webkit.org/show_bug.cgi?id=132112

Patch by Jono Wells <​jonowells@apple.com> on 2014-05-08
Reviewed by Joseph Pecoraro.

WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar was checking
only one of the two content trees in the DebuggerSidebarPanel instance. Added
base getter elementIsSelected to NavigationSidebarPanel and extended it in
DebuggerSidebarPanel.

• UserInterface/Base/Main.js:

(WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar): modified logic to check selectedSidebarPanel.elementIsSelected.

• UserInterface/Views/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel.prototype.get elementIsSelected): Checks breakpoint and call stack trees.

• UserInterface/Views/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel.prototype.get elementIsSelected): Base implementation.

12:19 PM Changeset in webkit [168483] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebCore

Fix the iOS build after r168476.

• platform/graphics/mac/GraphicsContextMac.mm:

(WebCore::GraphicsContext::drawFocusRing):

12:15 PM Changeset in webkit [168482] by beidson@apple.com

• 2 edits in trunk/Source/WebKit/mac

Wrap a new class definition with has_include()
<rdar://problem/16852395> and ​https://bugs.webkit.org/show_bug.cgi?id=132694

Reviewed by Tim Horton.

• Misc/WebSharingServicePickerController.mm:

12:14 PM Changeset in webkit [168481] by Bem Jones-Bey

• 15 edits
  4 adds in trunk

[CSS Shapes] Shapes do not resolve dimensions specified in viewport units
​https://bugs.webkit.org/show_bug.cgi?id=124052

Reviewed by Dirk Schulze.

Source/WebCore:
Viewport unit resolution doesn't work unless the RenderView is passed
down into the floatValueForLength methods. All this does is plumb down
a RenderView in all of these cases.

Tests: css3/masking/clip-path-polygon-viewport-units.html

fast/shapes/shape-outside-floats/shape-outside-floats-viewport-units.html

• css/BasicShapeFunctions.cpp:

(WebCore::floatValueForCenterCoordinate):

• css/BasicShapeFunctions.h:
• css/LengthFunctions.cpp:

(WebCore::floatSizeForLengthSize):

• css/LengthFunctions.h:
• rendering/ClipPathOperation.h:

(WebCore::ShapeClipPathOperation::pathForReferenceRect):
(WebCore::BoxClipPathOperation::pathForReferenceRect):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::setupClipPath):

• rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape):

• rendering/shapes/Shape.h:
• rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::ShapeOutsideInfo::computedShape):

• rendering/style/BasicShapes.cpp:

(WebCore::BasicShapeCircle::floatValueForRadiusInBox):
(WebCore::BasicShapeCircle::path):
(WebCore::BasicShapeEllipse::floatValueForRadiusInBox):
(WebCore::BasicShapeEllipse::path):
(WebCore::BasicShapePolygon::path):
(WebCore::floatSizeForLengthSize):
(WebCore::BasicShapeInset::path):

• rendering/style/BasicShapes.h:
• rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

LayoutTests:

• css3/masking/clip-path-polygon-viewport-units-expected.html: Added.
• css3/masking/clip-path-polygon-viewport-units.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-viewport-units-expected.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-viewport-units.html: Added.

12:07 PM Changeset in webkit [168480] by fpizlo@apple.com

• 7 edits
  1 add in trunk/Source/JavaScriptCore

SSA conversion should delete PhantomLocals for captured variables
​https://bugs.webkit.org/show_bug.cgi?id=132693

Reviewed by Mark Hahnenberg.

• dfg/DFGCommon.cpp:

(JSC::DFG::startCrashing): Parallel JIT and a JIT bug means that we man dump IR in parallel. This is the workaround. This patch uses it in all of the places where we dump IR and crash.

• dfg/DFGCommon.h:
• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::injectTypeConversionsForEdge): Use the workaround.

• dfg/DFGLivenessAnalysisPhase.cpp:

(JSC::DFG::LivenessAnalysisPhase::run): Use the workaround.

• dfg/DFGSSAConversionPhase.cpp:

(JSC::DFG::SSAConversionPhase::run): Fix the bug - it's true that PhantomLocal for captured variables doesn't need anything done to it, but it's wrong that we didn't delete it outright.

• dfg/DFGValidate.cpp: Use the workaround.
• tests/stress/phantom-local-captured-but-not-flushed-to-ssa.js: Added.

(foo):
(bar):

12:03 PM Changeset in webkit [168479] by Brent Fulgham

• 3 edits in trunk/Source/WebCore

Cue display events may not be registered during page load.
​https://bugs.webkit.org/show_bug.cgi?id=132696
<rdar://problem/16652874>

Reviewed by Eric Carlson.

• Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.handleTextTrackAdd): Don't register
for 'cuechange' events anymore.
(Controller.prototype.handleTextTrackRemove): Ditto.
(Controller.prototype.updateCaptionContainer): Reduce CSS
churn by not adding/removing 'Hidden' class every time a
new cue is processed. Only do this when transitioning
track display state.
(Controller.prototype.handleTextTrackCueChange): Deleted.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateTextTrackDisplay): Call
'updateTextTrackContainer' directory when processing cues,
rather than trampolining through the JS layer.

11:33 AM Changeset in webkit [168478] by ap@apple.com

• 20 edits
  2 adds in trunk/Source

Make BlobDataFileReference manage its sandbox extension
​https://bugs.webkit.org/show_bug.cgi?id=132689

Reviewed by Anders Carlsson.

Source/WebCore:

• WebCore.exp.in: Export symbols that are now needed in WebKit2 to subclass BlobDataFileReference.

• fileapi/ThreadableBlobRegistry.cpp: (WebCore::ThreadableBlobRegistry::registerFileBlobURL):
• platform/network/BlobData.cpp: (WebCore::BlobData::appendFile):
• platform/network/BlobData.h: (WebCore::BlobDataItem::BlobDataItem):
• platform/network/BlobRegistry.h:
• platform/network/BlobRegistryImpl.cpp: (WebCore::BlobRegistryImpl::registerFileBlobURL):
• platform/network/BlobRegistryImpl.h:

BlobRegistry now takes a BlobDataFileReference and not a path, so that WebKit2
could pass objects that include sandbox extensions.

• platform/network/BlobDataFileReference.h:
• platform/network/BlobDataFileReference.cpp:

(WebCore::BlobDataFileReference::~BlobDataFileReference): Added a virtual destructor.
(WebCore::BlobDataFileReference::size): We now record the size and modification time right away, no need to lazily calculate them.
(WebCore::BlobDataFileReference::expectedModificationTime): Ditto.
(WebCore::BlobDataFileReference::startTrackingModifications): Record time and size
(since it's a single call). However, size calculation will become complicated again soon.
(WebCore::BlobDataFileReference::prepareForFileAccess): A hook for subclasses.
(WebCore::BlobDataFileReference::revokeFileAccess): Ditto.
(WebCore::BlobDataFileReference::computeFileSystemData): Deleted.

Source/WebKit2:

• CMakeLists.txt:
• PlatformGTK.cmake:
• WebKit2.xcodeproj/project.pbxproj:

Added BlobDataFileReferenceWithSandboxExtension.

• NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:

(WebKit::NetworkBlobRegistry::registerFileBlobURL):
(WebKit::NetworkBlobRegistry::registerBlobURL):
(WebKit::NetworkBlobRegistry::registerBlobURLForSlice):
(WebKit::NetworkBlobRegistry::unregisterBlobURL):
(WebKit::NetworkBlobRegistry::connectionToWebProcessDidClose):
(WebKit::NetworkBlobRegistry::filesInBlob):
(WebKit::NetworkBlobRegistry::sandboxExtensions): Deleted.

• NetworkProcess/FileAPI/NetworkBlobRegistry.h:

We no longer track sandbox extensions here. Instead, provide a way to get files
for a blob, which contain extensions and can allow access to themselves.

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::NetworkResourceLoader):
(WebKit::NetworkResourceLoader::consumeSandboxExtensions):
(WebKit::NetworkResourceLoader::invalidateSandboxExtensions):

• NetworkProcess/NetworkResourceLoader.h:

Allow/revoke access to files in blob, just like we do for explicitly passed extensions.

• Shared/BlobDataFileReferenceWithSandboxExtension.cpp: Added.

(WebKit::BlobDataFileReferenceWithSandboxExtension::BlobDataFileReferenceWithSandboxExtension):
(WebKit::BlobDataFileReferenceWithSandboxExtension::~BlobDataFileReferenceWithSandboxExtension):
(WebKit::BlobDataFileReferenceWithSandboxExtension::prepareForFileAccess):
(WebKit::BlobDataFileReferenceWithSandboxExtension::revokeFileAccess):

• Shared/BlobDataFileReferenceWithSandboxExtension.h: Added.

(WebKit::BlobDataFileReferenceWithSandboxExtension::create):
A subclass of BlobDataFileReference that also contains a sandbox extension. NetworkProcess
always uses it in BlobRegistryImpl.

• WebProcess/FileAPI/BlobRegistryProxy.cpp: (WebKit::BlobRegistryProxy::registerFileBlobURL):
• WebProcess/FileAPI/BlobRegistryProxy.h:

Updated for BlobRegistry interface changes. BlobRegistryProxy doesn't really need
a BlobDataFileReference here, as it only uses a path, but it needs to implement the same interface
as BlobRegistryImpl.

11:24 AM Changeset in webkit [168477] by beidson@apple.com

• 5 edits in trunk

"shouldKeepCurrentBackForwardListItemInList" API should pass clientInfo to the callback
<rdar://problem/16855357> and ​https://bugs.webkit.org/show_bug.cgi?id=132692

Reviewed by Tim Horton.

Source/WebKit2:

• UIProcess/API/C/WKPage.cpp:

(WKPageSetPageLoaderClient):

• UIProcess/API/C/WKPageLoaderClient.h:

Tools:

• TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:

(TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):

10:57 AM Changeset in webkit [168476] by cabanier@adobe.com

• 5 edits
  2 adds in trunk

Add support for drawFocusIfNeeded
​https://bugs.webkit.org/show_bug.cgi?id=132584

Reviewed by Dirk Schulze.

Source/WebCore:
The drawFocusIfNeeded API will draw a focus ring if the element that is passed
in is focused and a child element of the canvas.

Test: fast/canvas/draw-focus-if-needed.html

• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawFocusIfNeeded):

• html/canvas/CanvasRenderingContext2D.h:
• html/canvas/CanvasRenderingContext2D.idl:

LayoutTests:

• fast/canvas/draw-focus-if-needed-expected.txt: Added.
• fast/canvas/draw-focus-if-needed.html: Added.

10:50 AM Changeset in webkit [168475] by commit-queue@webkit.org

• 2 edits in trunk/Tools

REGRESSION(r168471): Duplicate builddirs broke the build master.
​https://bugs.webkit.org/show_bug.cgi?id=132688

Patch by Carlos Alberto Lopez Perez <​clopez@igalia.com> on 2014-05-08
Reviewed by Carlos Garcia Campos.

Rename the builddirs of the new GTK bots introduced on r168471 to
be unique. Otherwise the master will break.

• BuildSlaveSupport/build.webkit.org-config/config.json:

10:32 AM Changeset in webkit [168474] by Carlos Garcia Campos

• 2 edits in trunk/Tools

[GTK] webkitdom script assumes mkdir only fails because the directory already exists
​https://bugs.webkit.org/show_bug.cgi?id=132674

Reviewed by Philippe Normand.

Only ignore mkdir failure when exception is raised because the
file already exists and it's a directory.

• gtk/webkitdom.py:

(write_doc_files):

9:42 AM Changeset in webkit [168473] by Antti Koivisto

• 6 edits in trunk/Source

[iOS WebKit2] Can't activate text fields on Facebook
​https://bugs.webkit.org/show_bug.cgi?id=132682

Reviewed by Enrica Casucci.

Source/WebCore:

• page/DOMTimer.cpp:

(WebCore::DOMTimer::fired):

The isDocument() test here had reversed in the merge breaking content change observer callback.

Source/WebKit2:

• WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:

(WebKit::WebChromeClient::observedContentChange):

Implement content change observer callback.

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::handleSyntheticClick):

If the event gets canceled by a potential change (a started short-duration timer)
save the position and node so we can continue later.

(WebKit::WebPage::completePendingSyntheticClickForContentChangeObserver):

If it turns out the observed timer changed nothing continue the click event.

(WebKit::WebPage::completeSyntheticClick):

Factored click event dispatch part of handleSyntheticClick here.

9:19 AM Changeset in webkit [168472] by commit-queue@webkit.org

• 30 edits in trunk/LayoutTests

[CSS Blending] Removing -webkit- prefixes for mix-blend-mode and isolation from layout tests.
​https://bugs.webkit.org/show_bug.cgi?id=132680

Patch by Ion Rosca <Ion Rosca> on 2014-05-08
Reviewed by Mihnea Ovidenie.

• css3/blending/blend-mode-accelerated-parent-overflow-hidden.html:
• css3/blending/blend-mode-isolation-accelerated-overflow-hidden.html:
• css3/blending/blend-mode-isolation-flags-append-non-stacking-context-blending.html:
• css3/blending/blend-mode-isolation-flags-append-stacking-context-blending.html:
• css3/blending/blend-mode-isolation-flags-remove-non-stacking-context-blending.html:
• css3/blending/blend-mode-isolation-flags-remove-stacking-context-blending.html:
• css3/blending/blend-mode-isolation-flags-turn-off-blending-no-isolation.html:
• css3/blending/blend-mode-isolation-flags-turn-off-blending.html:
• css3/blending/blend-mode-isolation-flags-turn-off-stacking-context.html:
• css3/blending/blend-mode-isolation-flags-turn-on-blending.html:
• css3/blending/blend-mode-isolation-flags-turn-on-stacking-context.html:
• css3/blending/blend-mode-isolation-overflow-hidden.html:
• css3/blending/blend-mode-isolation-turn-off-self-painting-layer.html:
• css3/blending/blend-mode-isolation-turn-off-self-painting-layer1.html:
• css3/blending/blend-mode-isolation-turn-off-self-painting-layer2.html:
• css3/blending/blend-mode-isolation-turn-on-self-painting-layer.html:
• css3/blending/blend-mode-overflow.html:
• css3/blending/repaint/blend-mode-turn-off-isolation-no-effect.html:
• css3/blending/repaint/blend-mode-turn-off-isolation.html:
• css3/blending/svg-blend-color-burn.html:
• css3/blending/svg-blend-darken.html:
• css3/blending/svg-blend-difference.html:
• css3/blending/svg-blend-exclusion.html:
• css3/blending/svg-blend-layer-mask.html:
• css3/blending/svg-blend-lighten.html:
• css3/blending/svg-blend-normal.html:
• css3/blending/svg-blend-overlay.html:
• css3/blending/svg-isolation-default.html:
• css3/blending/svg-isolation-simple.html:

9:08 AM Changeset in webkit [168471] by commit-queue@webkit.org

• 10 edits in trunk/Tools

[WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
​https://bugs.webkit.org/show_bug.cgi?id=131358

Patch by Carlos Alberto Lopez Perez <​clopez@igalia.com> on 2014-05-08
Reviewed by Carlos Garcia Campos.

Current 64-bit GTK build bots (Release and Debug) not only test
the build, but run all tests. Split each one of the bots in
BuildOnly and TestWebKit2.

This will allow us to have a better overview of the status of
the GTK port.

Original patch from Sergio Villar Senin <​svillar@igalia.com>

• BuildSlaveSupport/build.webkit.org-config/config.json:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

• Scripts/webkitpy/port/builders.py:
• Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaselineTest.test_baseline_directory):

• TestResultServer/static-dashboards/builders.jsonp:
• TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(resetGlobals):

• TestResultServer/static-dashboards/loader_unittests.js:

5:26 AM Changeset in webkit [168470] by commit-queue@webkit.org

• 122 edits
  5 adds in trunk/LayoutTests

[EFL] Rebaseline after enabling new multi-column mode (r168046)
​https://bugs.webkit.org/show_bug.cgi?id=132679

Unreviewed gardening.

Patch by Krzysztof Wolanski <​k.wolanski@samsung.com> on 2014-05-08

• platform/efl/css3/unicode-bidi-isolate-basic-expected.png:
• platform/efl/css3/unicode-bidi-isolate-basic-expected.txt:
• platform/efl/fast/block/float/float-not-removed-from-next-sibling4-expected.png:
• platform/efl/fast/block/float/float-not-removed-from-next-sibling4-expected.txt:
• platform/efl/fast/line-grid/line-grid-inside-columns-expected.png:
• platform/efl/fast/line-grid/line-grid-inside-columns-expected.txt:
• platform/efl/fast/line-grid/line-grid-into-columns-expected.txt:
• platform/efl/fast/multicol/block-axis-horizontal-bt-expected.png:
• platform/efl/fast/multicol/block-axis-horizontal-bt-expected.txt:
• platform/efl/fast/multicol/block-axis-horizontal-tb-expected.png:
• platform/efl/fast/multicol/block-axis-horizontal-tb-expected.txt:
• platform/efl/fast/multicol/block-axis-vertical-lr-expected.png:
• platform/efl/fast/multicol/block-axis-vertical-lr-expected.txt:
• platform/efl/fast/multicol/block-axis-vertical-rl-expected.txt:
• platform/efl/fast/multicol/border-padding-pagination-expected.png:
• platform/efl/fast/multicol/border-padding-pagination-expected.txt:
• platform/efl/fast/multicol/client-rects-expected.png:
• platform/efl/fast/multicol/client-rects-expected.txt:
• platform/efl/fast/multicol/client-rects-spanners-complex-expected.txt: Added.
• platform/efl/fast/multicol/client-rects-spanners-expected.txt: Added.
• platform/efl/fast/multicol/column-break-with-balancing-expected.txt:
• platform/efl/fast/multicol/column-count-with-rules-expected.txt:
• platform/efl/fast/multicol/column-rules-expected.png:
• platform/efl/fast/multicol/column-rules-expected.txt:
• platform/efl/fast/multicol/column-rules-stacking-expected.txt:
• platform/efl/fast/multicol/columns-shorthand-parsing-expected.txt:
• platform/efl/fast/multicol/float-avoidance-expected.txt:
• platform/efl/fast/multicol/float-multicol-expected.txt:
• platform/efl/fast/multicol/float-paginate-complex-expected.txt:
• platform/efl/fast/multicol/float-paginate-empty-lines-expected.txt:
• platform/efl/fast/multicol/float-paginate-expected.txt:
• platform/efl/fast/multicol/layers-in-multicol-expected.txt:
• platform/efl/fast/multicol/layers-split-across-columns-expected.txt:
• platform/efl/fast/multicol/margin-collapse-expected.txt:
• platform/efl/fast/multicol/max-height-columns-block-expected.png:
• platform/efl/fast/multicol/max-height-columns-block-expected.txt:
• platform/efl/fast/multicol/nested-columns-expected.png:
• platform/efl/fast/multicol/nested-columns-expected.txt:
• platform/efl/fast/multicol/newmulticol/client-rects-expected.txt: Added.
• platform/efl/fast/multicol/overflow-across-columns-expected.png:
• platform/efl/fast/multicol/overflow-across-columns-expected.txt:
• platform/efl/fast/multicol/overflow-across-columns-percent-height-expected.png:
• platform/efl/fast/multicol/overflow-across-columns-percent-height-expected.txt:
• platform/efl/fast/multicol/overflow-unsplittable-expected.png:
• platform/efl/fast/multicol/overflow-unsplittable-expected.txt:
• platform/efl/fast/multicol/paginate-block-replaced-expected.txt:
• platform/efl/fast/multicol/pagination/BottomToTop-bt-expected.txt:
• platform/efl/fast/multicol/pagination/BottomToTop-lr-expected.txt:
• platform/efl/fast/multicol/pagination/BottomToTop-rl-expected.txt:
• platform/efl/fast/multicol/pagination/BottomToTop-tb-expected.txt:
• platform/efl/fast/multicol/pagination/LeftToRight-bt-expected.txt:
• platform/efl/fast/multicol/pagination/LeftToRight-lr-expected.txt:
• platform/efl/fast/multicol/pagination/LeftToRight-rl-expected.txt:
• platform/efl/fast/multicol/pagination/LeftToRight-tb-expected.txt:
• platform/efl/fast/multicol/pagination/RightToLeft-bt-expected.txt:
• platform/efl/fast/multicol/pagination/RightToLeft-lr-expected.txt:
• platform/efl/fast/multicol/pagination/RightToLeft-rl-expected.txt:
• platform/efl/fast/multicol/pagination/RightToLeft-tb-expected.txt:
• platform/efl/fast/multicol/pagination/TopToBottom-bt-expected.txt:
• platform/efl/fast/multicol/pagination/TopToBottom-lr-expected.txt:
• platform/efl/fast/multicol/pagination/TopToBottom-rl-expected.txt:
• platform/efl/fast/multicol/pagination/TopToBottom-tb-expected.txt:
• platform/efl/fast/multicol/positioned-split-expected.txt:
• platform/efl/fast/multicol/positive-leading-expected.png:
• platform/efl/fast/multicol/positive-leading-expected.txt:
• platform/efl/fast/multicol/scrolling-column-rules-expected.txt: Added.
• platform/efl/fast/multicol/scrolling-overflow-expected.png:
• platform/efl/fast/multicol/scrolling-overflow-expected.txt:
• platform/efl/fast/multicol/shrink-to-column-height-for-pagination-expected.txt:
• platform/efl/fast/multicol/single-line-expected.txt:
• platform/efl/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
• platform/efl/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt:
• platform/efl/fast/multicol/span/anonymous-split-block-crash-expected.png:
• platform/efl/fast/multicol/span/anonymous-split-block-crash-expected.txt:
• platform/efl/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
• platform/efl/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
• platform/efl/fast/multicol/span/clone-flexbox-expected.txt:
• platform/efl/fast/multicol/span/clone-summary-expected.txt:
• platform/efl/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
• platform/efl/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
• platform/efl/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
• platform/efl/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
• platform/efl/fast/multicol/span/span-as-nested-columns-child-expected.txt:
• platform/efl/fast/multicol/span/span-as-nested-inline-block-child-expected.txt:
• platform/efl/fast/multicol/span/span-margin-collapsing-expected.txt:
• platform/efl/fast/multicol/table-margin-collapse-expected.txt:
• platform/efl/fast/multicol/table-vertical-align-expected.txt:
• platform/efl/fast/multicol/unsplittable-inline-block-expected.txt:
• platform/efl/fast/multicol/vertical-lr/border-padding-pagination-expected.png:
• platform/efl/fast/multicol/vertical-lr/border-padding-pagination-expected.txt:
• platform/efl/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt:
• platform/efl/fast/multicol/vertical-lr/column-count-with-rules-expected.txt:
• platform/efl/fast/multicol/vertical-lr/column-rules-expected.png:
• platform/efl/fast/multicol/vertical-lr/column-rules-expected.txt:
• platform/efl/fast/multicol/vertical-lr/float-avoidance-expected.txt:
• platform/efl/fast/multicol/vertical-lr/float-multicol-expected.txt:
• platform/efl/fast/multicol/vertical-lr/float-paginate-complex-expected.txt:
• platform/efl/fast/multicol/vertical-lr/float-paginate-expected.txt:
• platform/efl/fast/multicol/vertical-lr/nested-columns-expected.png:
• platform/efl/fast/multicol/vertical-lr/nested-columns-expected.txt:
• platform/efl/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt:
• platform/efl/fast/multicol/vertical-rl/border-padding-pagination-expected.png:
• platform/efl/fast/multicol/vertical-rl/border-padding-pagination-expected.txt:
• platform/efl/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
• platform/efl/fast/multicol/vertical-rl/column-count-with-rules-expected.txt:
• platform/efl/fast/multicol/vertical-rl/column-rules-expected.png:
• platform/efl/fast/multicol/vertical-rl/column-rules-expected.txt:
• platform/efl/fast/multicol/vertical-rl/float-avoidance-expected.txt:
• platform/efl/fast/multicol/vertical-rl/float-multicol-expected.txt:
• platform/efl/fast/multicol/vertical-rl/float-paginate-complex-expected.txt:
• platform/efl/fast/multicol/vertical-rl/float-paginate-expected.txt:
• platform/efl/fast/multicol/vertical-rl/nested-columns-expected.txt:
• platform/efl/fast/multicol/vertical-rl/rule-style-expected.txt:
• platform/efl/fast/multicol/vertical-rl/unsplittable-inline-block-expected.txt:
• platform/efl/fast/overflow/paged-x-div-expected.txt:
• platform/efl/fast/overflow/paged-x-div-with-column-gap-expected.txt:
• platform/efl/fast/overflow/paged-x-on-root-expected.png:
• platform/efl/fast/overflow/paged-x-on-root-expected.txt:
• platform/efl/fast/overflow/paged-x-with-column-gap-expected.png:
• platform/efl/fast/overflow/paged-x-with-column-gap-expected.txt:
• platform/efl/fast/overflow/paged-y-div-expected.txt:
• platform/efl/fast/overflow/paged-y-on-root-expected.png:
• platform/efl/fast/overflow/paged-y-on-root-expected.txt:
• platform/efl/fast/repaint/multicol-repaint-expected.png:
• platform/efl/fast/repaint/multicol-repaint-expected.txt:

3:59 AM Changeset in webkit [168469] by svillar@igalia.com

• 58 edits in trunk/Source/WebCore

Replace DEPRECATED_DEFINE_STATIC_LOCAL by static NeverDestroyed<T> in svg/
​https://bugs.webkit.org/show_bug.cgi?id=132647

Reviewed by Darin Adler.

• svg/SVGAElement.cpp:

(WebCore::SVGAElement::isSupportedAttribute):

• svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::isSupportedAttribute):

• svg/SVGAnimateTransformElement.cpp:

(WebCore::SVGAnimateTransformElement::isSupportedAttribute):

• svg/SVGAnimatedLength.cpp:

(WebCore::sharedSVGLength):

• svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::isSupportedAttribute):

• svg/SVGCircleElement.cpp:

(WebCore::SVGCircleElement::isSupportedAttribute):

• svg/SVGClipPathElement.cpp:

(WebCore::SVGClipPathElement::isSupportedAttribute):

• svg/SVGComponentTransferFunctionElement.cpp:

(WebCore::SVGComponentTransferFunctionElement::isSupportedAttribute):

• svg/SVGCursorElement.cpp:

(WebCore::SVGCursorElement::isSupportedAttribute):

• svg/SVGElement.cpp:

(WebCore::SVGElement::instancesForElement):
(WebCore::SVGElement::childShouldCreateRenderer):

• svg/SVGEllipseElement.cpp:

(WebCore::SVGEllipseElement::isSupportedAttribute):

• svg/SVGFEBlendElement.cpp:

(WebCore::SVGFEBlendElement::isSupportedAttribute):

• svg/SVGFEColorMatrixElement.cpp:

(WebCore::SVGFEColorMatrixElement::isSupportedAttribute):

• svg/SVGFEComponentTransferElement.cpp:

(WebCore::SVGFEComponentTransferElement::isSupportedAttribute):

• svg/SVGFECompositeElement.cpp:

(WebCore::SVGFECompositeElement::isSupportedAttribute):

• svg/SVGFEConvolveMatrixElement.cpp:

(WebCore::SVGFEConvolveMatrixElement::isSupportedAttribute):

• svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::isSupportedAttribute):

• svg/SVGFEDisplacementMapElement.cpp:

(WebCore::SVGFEDisplacementMapElement::isSupportedAttribute):

• svg/SVGFEDropShadowElement.cpp:

(WebCore::SVGFEDropShadowElement::isSupportedAttribute):

• svg/SVGFEGaussianBlurElement.cpp:

(WebCore::SVGFEGaussianBlurElement::isSupportedAttribute):

• svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::isSupportedAttribute):

• svg/SVGFELightElement.cpp:

(WebCore::SVGFELightElement::isSupportedAttribute):

• svg/SVGFEMergeNodeElement.cpp:

(WebCore::SVGFEMergeNodeElement::isSupportedAttribute):

• svg/SVGFEMorphologyElement.cpp:

(WebCore::SVGFEMorphologyElement::isSupportedAttribute):

• svg/SVGFEOffsetElement.cpp:

(WebCore::SVGFEOffsetElement::isSupportedAttribute):

• svg/SVGFESpecularLightingElement.cpp:

(WebCore::SVGFESpecularLightingElement::isSupportedAttribute):

• svg/SVGFETileElement.cpp:

(WebCore::SVGFETileElement::isSupportedAttribute):

• svg/SVGFETurbulenceElement.cpp:

(WebCore::SVGFETurbulenceElement::isSupportedAttribute):

• svg/SVGFilterElement.cpp:

(WebCore::SVGFilterElement::isSupportedAttribute):
(WebCore::SVGFilterElement::childShouldCreateRenderer):

• svg/SVGFilterPrimitiveStandardAttributes.cpp:

(WebCore::SVGFilterPrimitiveStandardAttributes::isSupportedAttribute):

• svg/SVGForeignObjectElement.cpp:

(WebCore::SVGForeignObjectElement::isSupportedAttribute):

• svg/SVGGElement.cpp:

(WebCore::SVGGElement::isSupportedAttribute):

• svg/SVGGradientElement.cpp:

(WebCore::SVGGradientElement::isSupportedAttribute):

• svg/SVGGraphicsElement.cpp:

(WebCore::SVGGraphicsElement::isSupportedAttribute):

• svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::isSupportedAttribute):

• svg/SVGLength.cpp:

(WebCore::SVGLength::lengthModeForAnimatedLengthAttribute):

• svg/SVGLineElement.cpp:

(WebCore::SVGLineElement::isSupportedAttribute):

• svg/SVGLinearGradientElement.cpp:

(WebCore::SVGLinearGradientElement::isSupportedAttribute):

• svg/SVGMPathElement.cpp:

(WebCore::SVGMPathElement::isSupportedAttribute):

• svg/SVGMarkerElement.cpp:

(WebCore::SVGMarkerElement::isSupportedAttribute):

• svg/SVGMaskElement.cpp:

(WebCore::SVGMaskElement::isSupportedAttribute):

• svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::isSupportedAttribute):

• svg/SVGPatternElement.cpp:

(WebCore::SVGPatternElement::isSupportedAttribute):

• svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::isSupportedAttribute):

• svg/SVGRadialGradientElement.cpp:

(WebCore::SVGRadialGradientElement::isSupportedAttribute):

• svg/SVGRectElement.cpp:

(WebCore::SVGRectElement::isSupportedAttribute):

• svg/SVGScriptElement.cpp:

(WebCore::SVGScriptElement::isSupportedAttribute):

• svg/SVGStopElement.cpp:

(WebCore::SVGStopElement::isSupportedAttribute):

• svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::isSupportedAttribute):

• svg/SVGSymbolElement.cpp:

(WebCore::SVGSymbolElement::isSupportedAttribute):

• svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::isSupportedAttribute):

• svg/SVGTests.cpp:

(WebCore::SVGTests::attributeToPropertyMap):

• svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::textLengthAnimated):
(WebCore::SVGTextContentElement::isSupportedAttribute):

• svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::isSupportedAttribute):

• svg/SVGTextPositioningElement.cpp:

(WebCore::SVGTextPositioningElement::isSupportedAttribute):

• svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::isSupportedAttribute):
(WebCore::isDisallowedElement):

• svg/SVGViewElement.cpp:

(WebCore::SVGViewElement::isSupportedAttribute):

3:35 AM Changeset in webkit [168468] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

[CSS Blending] Replacing Unisolated with NotIsolated in variables and methods names
​https://bugs.webkit.org/show_bug.cgi?id=132677

Patch by Ion Rosca <Ion Rosca> on 2014-05-08
Reviewed by Dirk Schulze.

No new tests required.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateAncestorChainHasBlendingDescendants):
(WebCore::RenderLayer::dirtyAncestorChainHasBlendingDescendants):
(WebCore::RenderLayer::updateDescendantDependentFlags):
hasUnisolatedBlendingDescendants -> hasNotIsolatedBlendingDescendants
(WebCore::RenderLayer::addChild):
(WebCore::RenderLayer::removeChild):
(WebCore::RenderLayer::updateStackingContextsAfterStyleChange):

• rendering/RenderLayer.h:

m_hasUnisolatedBlendingDescendants -> m_hasNotIsolatedBlendingDescendants
m_hasUnisolatedBlendingDescendantsStatusDirty -> m_hasNotIsolatedBlendingDescendantsStatusDirty
hasUnisolatedBlendingDescendants() -> hasNotIsolatedBlendingDescendants()
hasUnisolatedBlendingDescendantsStatusDirty() -> hasNotIsolatedBlendingDescendantsStatusDirty()
m_hasUnisolatedCompositedBlendingDescendants -> m_hasNotIsolatedCompositedBlendingDescendants
hasUnisolatedCompositedBlendingDescendants() -> hasNotIsolatedCompositedBlendingDescendants()
setHasUnisolatedCompositedBlendingDescendants() -> setHasNotIsolatedCompositedBlendingDescendants

• rendering/RenderLayerCompositor.cpp:

(WebCore::CompositingState::CompositingState):
m_hasUnisolatedCompositedBlendingDescendants -> m_hasNotIsolatedCompositedBlendingDescendants
(WebCore::RenderLayerCompositor::computeCompositingRequirements):

3:28 AM Changeset in webkit [168467] by calvaris@igalia.com

• 7 edits
  5 adds
  1 delete in trunk

[GTK] Enable skipped http/tests/media/hls/video-controls-live-stream.html
​https://bugs.webkit.org/show_bug.cgi?id=132329

Reviewed by Eric Carlson.

Source/WebCore:
GTK port needed to define what happened with live stream media
controls. Now we disable and dim the timeline and tweak the
timers.

Test: http/tests/media/hls/video-controls-live-stream.html.

• Modules/mediacontrols/mediaControlsGtk.js:

(ControllerGtk.prototype.configureControls): Moved logic from
setControlsType and changed to use an early return.
(ControllerGtk.prototype.reconnectControls): Redefined to just
configure the controls.
(ControllerGtk.prototype.handlePlay): If stream is live we don't
activate the current time just in case.
(ControllerGtk.prototype.updateDuration): Calls the superclass and
sets timeline.max to 0.
(ControllerGtk.prototype.setControlsType): Deleted.
(ControllerGtk.prototype.setIsLive): Configures controls and
disables the timeline if stream is live.

• css/mediaControlsGtk.css:

(audio::-webkit-media-controls-timeline[disabled])
(video::-webkit-media-controls-timeline[disabled]): Dimmed the
timeline by setting opacity to 0.3.

LayoutTests:
Tweaked test, created GTK results, unskipped in GTK and moved the
current general expectations to be mac only.

• http/tests/media/hls/video-controls-live-stream-expected.txt:

Moved.

• http/tests/media/hls/video-controls-live-stream.html: Dump tree

and check status of the timelime.

• media/media-controls.js:

(dumpMediaControlsTree): Added to dump the shadow dom tree.

• platform/gtk/TestExpectations: Unskipped video-controls-live-stream.
• platform/gtk/http/tests/media/hls/video-controls-live-stream-expected.txt: Added.
• platform/mac/http/tests/media/hls/video-controls-live-stream-expected.txt:

Moved from
LayoutTests/http/tests/media/hls/video-controls-live-stream-expected.txt
and rebaselined.

1:42 AM Changeset in webkit [168466] by mihnea@adobe.com

• 1 edit
  2 adds in trunk/LayoutTests

[CSS Regions] Content overflowing a fixed positioned region is clipped
​https://bugs.webkit.org/show_bug.cgi?id=118607

Reviewed by Andrei Bucur.

Fixed by the overflow in regions work, add test to prevent future regressions.

• fast/regions/fixed-pos-region-overflow-content-expected.html: Added.
• fast/regions/fixed-pos-region-overflow-content.html: Added.

1:16 AM Changeset in webkit [168465] by commit-queue@webkit.org

• 3 edits
  4 adds in trunk

[CSS Blending] Changing isolation CSS property should not trigger repaint in RenderStyle::changeRequiresLayerRepaint
​https://bugs.webkit.org/show_bug.cgi?id=131436

Patch by Ion Rosca <Ion Rosca> on 2014-05-08
Reviewed by Dirk Schulze.

Source/WebCore:
The isolation:isolate property will create a stacking context. This is done in
StyleResolver::adjustRenderStyle where z-index is forced to 0.
If the element is already a stacking context for any other reason,
changing the isolation flag should not have any effect.

Tests: css3/blending/repaint/blend-mode-turn-off-isolation-no-effect.html

css3/blending/repaint/blend-mode-turn-off-isolation.html

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresLayerRepaint):
do not request repaint if isolation has changed.

LayoutTests:

• css3/blending/repaint/blend-mode-turn-off-isolation-expected.txt: Added.
• css3/blending/repaint/blend-mode-turn-off-isolation-no-effect-expected.txt: Added.
• css3/blending/repaint/blend-mode-turn-off-isolation-no-effect.html: Added.
• css3/blending/repaint/blend-mode-turn-off-isolation.html: Added.

1:05 AM Changeset in webkit [168464] by Manuel Rego Casasnovas

• 4 edits
  2 adds in trunk

REGRESSION (r167652): SelectionState is not set properly for non leaf objects in pages with regions
​https://bugs.webkit.org/show_bug.cgi?id=132493

Reviewed by David Hyatt.

Source/WebCore:
Non selection leaf elements were not included in the selection ranges,
that was causing that their selection state was not set properly and
when one of the element was removed as it was marked as SelectionNone
current selection was not removed.

Due to this fix, the regression detected in bug #131982 arose again.
Reverted changes from r167675 and reopened bug as previous fix was not
right. Updated TestExpectations accordingly.

Test: fast/regions/selection/crash-select-all.html

• rendering/RenderView.cpp:

(WebCore::RenderView::splitSelectionBetweenSubtrees): We need to include
non selection leafs in the range, otherwise we won't be marking
selection state of some elements properly.

LayoutTests:

• TestExpectations: Marked

fast/regions/cssom/region-range-for-box-crash.html as crashing on
debug due to regression detected in bug #131982.

• fast/regions/selection/crash-select-all-expected.txt: Added.
• fast/regions/selection/crash-select-all.html: Added.

12:57 AM Changeset in webkit [168463] by zoltan@webkit.org

• 3 edits
  4 adds in trunk

[CSS Shapes] Can't select content within the area of the floating box when clip-path is applied
​https://bugs.webkit.org/show_bug.cgi?id=131375

Reviewed by Dirk Schulze.

Source/WebCore:
According to ​http://www.w3.org/TR/css-masking-1/, the clipped part of the element should
not have pointer event dispatching. So add this logic to RenderBlock::nodeAtPoint. This
fixes the bug as it disallows selection on any clipped parts.

I implemented the proper selection for the various CSS box types and added testing
for them. Also, I made and run performance tests for exposing mouse events over the
clipped/non-clipped area, which results can be seen in bugzilla.

Based on the patch made by Rob Buis <​rob.buis@samsung.com>
Blink revision: ​http://src.chromium.org/viewvc/blink?view=revision&revision=172619

Tests: fast/masking/clip-path-selection.html

fast/shapes/shape-outside-floats/shape-outside-clip-path-selection.html

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::nodeAtPoint):

LayoutTests:

• fast/masking/clip-path-selection-expected.txt: Added.
• fast/masking/clip-path-selection.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-clip-path-selection-expected.txt: Added.
• fast/shapes/shape-outside-floats/shape-outside-clip-path-selection.html: Added.