Timeline

May 12, 2014:

11:41 PM WebKitGTK/2.4.x edited by Carlos Garcia Campos

(diff)

11:40 PM Changeset in webkit [168676] by mark.lam@apple.com

• 9 edits
  8 adds in trunk

WebKit2 on iOS needs to capture the main thread's floating point environment.
<​https://webkit.org/b/132755>

Reviewed by Geoffrey Garen.

Source/WebCore:
For iOS, WorkerThread::workerThread() expects to be able to initialize the
worker thread's floating point environment to be the same as the one in the
main thread. The FP env of the main thread is expected to have been captured
in the mainThreadFEnv global. On WebKit2 for iOS, we neglected to initialize
mainThreadFEnv.

We now introduce a FloatingPointEnvironment class that will encapsulate the main
thread (aka "UIThread") fenv, and we'll call FloatingPointEnv::saveMainThreadEnvironment()
from ChildProcess::platformInitialize() to ensure that the FloatingPointEnvironment
singleton instance is initialized properly for WebKit2.

In the ChildProcess::platformInitialize(), we also need to initialize the ARMv7
FP env to support denormalized numbers. We'll do this before calling
saveMainThreadEnvironment().

Tests: fast/workers/worker-floating-point.html

js/floating-point-denormalized.html

• WebCore.exp.in:
• WebCore.xcodeproj/project.pbxproj:
• platform/ios/wak/FloatingPointEnvironment.cpp: Added.

(WebCore::FloatingPointEnvironment::env):
(WebCore::FloatingPointEnvironment::FloatingPointEnvironment):
(WebCore::FloatingPointEnvironment::enableDenormalSupport):
(WebCore::FloatingPointEnvironment::saveMainThreadEnvironment):
(WebCore::FloatingPointEnvironment::propagateMainThreadEnvironment):

• platform/ios/wak/FloatingPointEnvironment.h: Added.
• platform/ios/wak/WebCoreThread.h:
• platform/ios/wak/WebCoreThread.mm:

(RunWebThread):
(StartWebThread):

• workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread):

Source/WebKit2:

• Shared/mac/ChildProcessMac.mm:

(WebKit::ChildProcess::platformInitialize):

• Call FloatingPointEnv::enableNeededFloatingPointModes() to initialize the ARMv7 FP env to support denormalized numbers.
• Call FloatingPointEnv::saveMainThreadEnvironment() to capture the main thread fp env.

LayoutTests:

• fast/workers/resources/worker-floating-point.js: Added.

(runTest1):
(doDiv):
(runTest2):

• fast/workers/worker-floating-point-expected.txt: Added.
• fast/workers/worker-floating-point.html: Added.
• js/floating-point-denormalized-expected.txt: Added.
• js/floating-point-denormalized.html: Added.
• js/script-tests/floating-point-denormalized.js: Added.

11:38 PM WebKitGTK/2.4.x edited by Carlos Garcia Campos

(diff)

11:14 PM Changeset in webkit [168675] by gyuyoung.kim@samsung.com

• 2 edits
  3 adds in trunk/Source/WebKit2

[EFL][WK2] Fix ewk_view_navigation test in EWK2ViewTest
​https://bugs.webkit.org/show_bug.cgi?id=132817

Reviewed by Dirk Schulze.

To load test html pages, call ewk_view_uri_set() instead of EWK2UnitTestServer.
Besides this patch adds test html page for ewk_view_navigation unit test.

• UIProcess/API/efl/tests/resources/Page1.html: Added.
• UIProcess/API/efl/tests/resources/Page2.html: Added.
• UIProcess/API/efl/tests/resources/Page3.html: Added.
• UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

11:04 PM Changeset in webkit [168674] by krit@webkit.org

• 22 edits
  6 adds in trunk

SVG root element accepts background color but fails to repaint it
​https://bugs.webkit.org/show_bug.cgi?id=63153

Reviewed by Dean Jackson.

Source/WebCore:
This is back ported from Blink. Don't know the exact commit though.
The patch checks if the SVGSVGElement is an outermost root element.
If it is, mark the whole element for repaint.

Test: svg/custom/svg-root-background.html

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateHasBoxDecorations):
(WebCore::RenderBoxModelObject::updateFromStyle):

• rendering/RenderBoxModelObject.h:
• rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::RenderSVGRoot):
(WebCore::RenderSVGRoot::layout):
(WebCore::RenderSVGRoot::paintReplaced):
(WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):

This is a simple optimization by taking the necessary parts
from RenderReplaced and SVGRenderSupport.

• rendering/svg/RenderSVGRoot.h:

LayoutTests:
Check that background color updates if the size of an outermost
root SVG element changes.

• svg/custom/svg-root-background-expected.png: Added.
• svg/custom/svg-root-background-expected.txt: Added.
• svg/custom/svg-root-background.html: Added.

10:00 PM Changeset in webkit [168673] by Lucas Forschler

• 5 edits in branches/safari-538.34-branch/Source

Versioning.

9:58 PM Changeset in webkit [168672] by Lucas Forschler

• 1 copy in tags/Safari-538.34.3

New Tag.

9:53 PM Changeset in webkit [168671] by Brent Fulgham

• 2 edits in trunk/Source/WebKit

[Win] Unreviewed build fix after r168668.

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add

missing export symbols.

9:32 PM Changeset in webkit [168670] by Simon Fraser

• 3 edits in trunk/Source/WebCore

[iOS] Fixed items are sometimes clipped after rubber-banding
​https://bugs.webkit.org/show_bug.cgi?id=132851
<rdar://problem/16870790>

Reviewed by Benjamin Poulain.

On iOS fixed-position layers would get clipped to the document rect,
but with rubber-banding, we can now have a custom fixed postion rect
that extends outside the document rect.

Another issue was that we would un-composite fixed elements sometimes
when scrolling fast, again because they could fall outside of the document rect.

A final issue was that pinching could reveal parts of fixed elements that should
lie outside the viewport, rather than clipping the layers.

Fix by converting both call points to use viewportConstrainedVisibleContentRect()
rather than viewportConstrainedExtentRect(). On non-iOS platforms these are
the same, but on iOS viewportConstrainedVisibleContentRect() uses the
custom fixed position rect, which is the correct rect to intersect with.

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateCompositedBounds):

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

8:19 PM Changeset in webkit [168669] by jpfau@apple.com

• 2 edits in trunk/LayoutTests

Unreviewed, fix mismatched test expectation.

• webgl/many-contexts-expected.txt:

7:25 PM Changeset in webkit [168668] by jhoneycutt@apple.com

• 31 edits
  7 adds in trunk

Don't dispatch 'beforeload' event inside FrameView::layout()

​https://bugs.webkit.org/show_bug.cgi?id=132621
<rdar://problem/15661470>

This merges Blink revision 162073 with minor renaming and style
changes. From that commit:

Executing JavaScript code inside FrameView::layout() is problematic.
e.g. an assertion failure tested in fast/events/beforeload-assertion.html.
We should avoid it.

This CL makes 'beforeload' event dispatching for plugins and iframes asynchronous,
except plugin access from JavaScript code (HTMLPlugInElement::
renderWidgetForJSBindings).

Reviewed by Brent Fulgham.

Source/WebCore:
Tests: fast/events/beforeload-assertion.html

fast/events/beforeload-iframe-crash.html
fast/events/beforeload-input-time-crash.html

• WebCore.exp.in:
• dom/Document.cpp:

(WebCore::Document::updateLayoutIgnorePendingStylesheets):

• dom/Document.h:
• html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::renderWidgetForJSBindings):

• html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::renderWidgetForJSBindings):

• html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::renderWidgetForJSBindings):

• page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::updateEmbeddedObjectsTimerFired):
(WebCore::FrameView::flushAnyPendingPostLayoutTasks):
(WebCore::FrameView::performPostLayoutTasks):

• page/FrameView.h:
• testing/Internals.cpp:

(WebCore::Internals::updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks):

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

• compositing/plugins/composited-plugin.html:
• compositing/plugins/no-backing-store.html:
• fast/dom/beforeload/flash-before-load.html:
• fast/events/beforeload-assertion-expected.txt: Added.
• fast/events/beforeload-assertion.html: Added.
• fast/events/beforeload-iframe-crash-expected.txt: Added.
• fast/events/beforeload-iframe-crash.html: Added.
• fast/events/beforeload-input-time-crash-expected.txt: Added.
• fast/events/beforeload-input-time-crash.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-data.html:
• http/tests/security/contentSecurityPolicy/1.1/plugintypes-nourl-blocked.html:
• http/tests/security/contentSecurityPolicy/object-src-no-url-allowed.html:
• http/tests/security/contentSecurityPolicy/object-src-no-url-blocked.html:
• http/tests/security/contentSecurityPolicy/object-src-none-allowed.html:
• http/tests/security/contentSecurityPolicy/object-src-none-blocked.html:
• http/tests/security/contentSecurityPolicy/resources/multiple-iframe-plugin-test.js:

(testImpl.iframe.onload):
(testImpl):

• http/tests/security/mixedContent/insecure-plugin-in-iframe.html:
• platform/mac/plugins/supports-carbon-event-model.html:
• plugins/get-user-agent-with-null-npp-from-npp-new.html:
• plugins/mouse-click-plugin-clears-selection.html:
• plugins/netscape-plugin-map-data-to-src.html:
• plugins/no-mime-with-valid-extension.html:
• plugins/plugin-initiate-popup-window.html:
• plugins/windowless_plugin_paint_test.html:
• resources/plugin.js: Added.

(runAfterPluginLoad):

6:29 PM Changeset in webkit [168667] by roger_fong@apple.com

• 2 edits in trunk/LayoutTests

Unreviewed. Adjust expected result for test added in r168666.

• webgl/many-contexts-expected.txt:

6:07 PM Changeset in webkit [168666] by roger_fong@apple.com

• 4 edits
  2 adds in trunk

Limit number of active graphics contexts per web process.
​https://bugs.webkit.org/show_bug.cgi?id=132833.
<rdar://problem/16888459>

Reviewed by Dean Jackson.

Test: webgl/many-contexts.html

• platform/graphics/GraphicsContext3D.h:
• platform/graphics/mac/GraphicsContext3DMac.mm: Limit number of active contexts to 16.

(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::~GraphicsContext3D):

• webgl/many-contexts-expected.txt: Added.
• webgl/many-contexts.html: Added.

5:32 PM Changeset in webkit [168665] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Build fix fix.

• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::contentShadowLayerForFrameView):

5:29 PM Changeset in webkit [168664] by Brent Fulgham

• 6 edits in trunk/Source/WebCore

DataDetectorUI doesn't update with resize
​https://bugs.webkit.org/show_bug.cgi?id=132830
<rdar://problem/16871179>

Reviewed by Simon Fraser.

• editing/Editor.cpp:

(WebCore::Editor::scanSelectionForTelephoneNumbers): Add public, no-argument
version that can be called after layout changes.
(WebCore::Editor::didLayout): Reprocess telephone number data
since Ranges will have changed.

• editing/Editor.h:
• editing/FrameSelection.cpp:

(WebCore::FrameSelection::updateDataDetectorsForSelection): Added.

• editing/FrameSelection.h:
• page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks): Ask the FrameSelection to update the
Range information for selected phone numbers.

5:27 PM Changeset in webkit [168663] by gyuyoung.kim@samsung.com

• 2 edits in trunk/Source/WebKit2

Unreviewed, EFL build fix since r168625.

• UIProcess/efl/WebContextEfl.cpp:

(WebKit::WebContext::platformDefaultLocalStorageDirectory): Remove const keyword.

5:21 PM Changeset in webkit [168662] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Fix the iOS build.

• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::contentShadowLayerForFrameView):

5:14 PM Changeset in webkit [168661] by Simon Fraser

• 5 edits in trunk/Source

[iOS WK2] Fuzzy tiles on some sites on loading
​https://bugs.webkit.org/show_bug.cgi?id=132847
<rdar://problem/16816178>

Reviewed by Benjamin Poulain.

Source/WebCore:

Export WebCore::TileController::contentsScale() const

• WebCore.exp.in:

Source/WebKit2:

PlatformCALayerRemoteTiledBacking overrode setContentsScale() but not contentsScale(),
causing us to early-return from GraphicsLayerCA::updateContentsScale() and leave the
scale wrong. Fix by overriding contentsScale() also.

• WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.cpp:

(WebKit::PlatformCALayerRemoteTiledBacking::contentsScale):

• WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.h:

5:13 PM Changeset in webkit [168660] by Simon Fraser

• 3 edits in trunk/Source/WebCore

Add debug dumping for ViewportConfiguration
​https://bugs.webkit.org/show_bug.cgi?id=132843

Reviewed by Benjamin Poulain.

Add some TextStream-based dumping for ViewportConfiguration.

• page/ViewportConfiguration.cpp:

(WebCore::ViewportConfiguration::updateConfiguration):
(WebCore::ViewportConfigurationTextStream::ViewportConfigurationTextStream):
(WebCore::ViewportConfigurationTextStream::increaseIndent):
(WebCore::ViewportConfigurationTextStream::decreaseIndent):
(WebCore::dumpProperty):
(WebCore::ViewportConfigurationTextStream::writeIndent):
(WebCore::ViewportConfigurationTextStream::operator<<):
(WebCore::ViewportConfiguration::description):
(WebCore::ViewportConfiguration::dump):

• page/ViewportConfiguration.h:

5:11 PM Changeset in webkit [168659] by Lucas Forschler

• 2 edits in branches/safari-538.34-branch/Source/WebCore

Merged r168658.

5:05 PM Changeset in webkit [168658] by beidson@apple.com

• 2 edits in trunk/Source/WebCore

Followup to "Teach Editor to support more direct replacement of a Node"
<rdar://problem/16817952> and ​https://bugs.webkit.org/show_bug.cgi?id=132834

Pair programmed and pair reviewed by Brady Eidson and Darin Adler.

• editing/mac/EditorMac.mm:

(WebCore::maybeCopyNodeAttributesToFragment):
(WebCore::Editor::replaceNodeFromPasteboard):

4:31 PM Changeset in webkit [168657] by timothy_horton@apple.com

• 4 edits in trunk/Source/WebKit2

Triple-buffer RemoteLayerBackingStore
​https://bugs.webkit.org/show_bug.cgi?id=132786
<rdar://problem/16877498>

Reviewed by Simon Fraser.

We need three buffers because we're currently unable to synchronize
with the render server to swap when they're not in use, so we were
throwing surfaces away far too frequently.

This hugely reduces time spent in IOSurface::create on various repaint benchmarks.

• Shared/mac/RemoteLayerBackingStore.h:

(WebKit::RemoteLayerBackingStore::hasFrontBuffer):
(WebKit::RemoteLayerBackingStore::volatility): Deleted.

• Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::RemoteLayerBackingStore):
(WebKit::RemoteLayerBackingStore::clearBackingStore):
(WebKit::RemoteLayerBackingStore::encode):
(WebKit::RemoteLayerBackingStore::decode):
(WebKit::RemoteLayerBackingStore::swapToValidFrontBuffer):
(WebKit::RemoteLayerBackingStore::display):
(WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer):
(WebKit::RemoteLayerBackingStore::setBufferVolatility):
(WebKit::RemoteLayerBackingStore::Buffer::discard):
(WebKit::RemoteLayerBackingStore::setVolatility): Deleted.

• Shared/mac/RemoteLayerBackingStoreCollection.mm:

(WebKit::RemoteLayerBackingStoreCollection::purgeabilityTimerFired):
Put the ShareableBitmap/IOSurface and a volatility bit in a Buffer struct.
Also factor out "throw away this buffer and put it in the pool" into Buffer::discard().
We keep a volatility bit because querying IOSurface purgeability is expensive,
and we have a guarantee that any changes will happen in the Web process
and go through this class (the lack of this guarantee in most cases is why I'm not
putting this bit in WebCore::IOSurface itself).

Make it so that each buffer's volatility can be adjusted individually
by setBufferVolatility(), and adopt in RemoteLayerBackingStoreCollection.

Add a third buffer, m_secondaryBackBuffer, which will swap with the back buffer
before swapping front and back if the back buffer (soon to be the front buffer)
is still in use by the render server. This means that we will almost never
have to throw away a surface because it's in use (and conversely never need
to make a new surface).

Adjust RemoteLayerBackingStoreCollection to make secondary back surfaces purgeable
more aggressively than others.

4:29 PM Changeset in webkit [168656] by andersca@apple.com

• 2 edits in trunk/Source/WebKit

Don't make a Frameworks symlink inside WebKitLegacy.framework
​https://bugs.webkit.org/show_bug.cgi?id=132842
<rdar://problem/16886939>

Reviewed by Dan Bernstein.

• WebKit.xcodeproj/project.pbxproj:

4:21 PM Changeset in webkit [168655] by Beth Dakin

• 9 edits in trunk/Source/WebCore

Content shadow layer needs to move in sync with the content layer
​https://bugs.webkit.org/show_bug.cgi?id=132841
-and corresponding-
<rdar://problem/16641115>

Reviewed by Simon Fraser.

Now that the root content layer moves a little bit (for y scroll positions between
0 and topContentInset), the shadow layer needs to move along with it since the
shadow layer should always have the same position as the root content layer.

Set the root state node’s shadow layer, and update the position whenever the root
content layer’s position is updated.

• page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::frameViewRootLayerDidChange):
(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll):

Fetch the compositor’s layerForContentShadow().

• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::contentShadowLayerForFrameView):

• page/scrolling/ScrollingCoordinator.h:

Hook up the contentShadowLayer in the state node.

• page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::setContentShadowLayer):

Hook it up in the ScrollingTreeNode as well. Move the layer whenever the m
_scrolledContentsLayer is moved.

• page/scrolling/ScrollingStateScrollingNode.h:
• page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:
• page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::updateBeforeChildren):
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):

The shadow layer needs an anchor point now that we are moving it around.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):

4:17 PM Changeset in webkit [168654] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

REGRESSION (r165972): Can't type into text fields in Flash
​https://bugs.webkit.org/show_bug.cgi?id=132840
<rdar://problem/16671969>

Reviewed by Anders Carlsson.

• UIProcess/API/mac/WKView.mm: (-[WKView inputContext]): Restore a function that

got accidentally lost when adding async text input code.

4:02 PM Changeset in webkit [168653] by Chris Fleizach

• 8 edits in trunk/Source/WebKit2

AX: .js dialogs shown in unload while AX is running crash WebKit.
​https://bugs.webkit.org/show_bug.cgi?id=123828

Reviewed by Anders Carlsson.

Utilize platform API to inform AX clients when the WebProcess will suspend and resume.
This allows us to avoid having special behavior for accessibility when the WebProcess needs
to wait on a reply.

• Platform/IPC/Connection.cpp:

(IPC::Connection::waitForSyncReply):

• Platform/IPC/Connection.h:
• Platform/IPC/mac/ConnectionMac.cpp:

(IPC::Connection::willSendSyncMessage):
(IPC::Connection::didReceiveSyncReply):

• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::runBeforeUnloadConfirmPanel):
(WebKit::WebChromeClient::runJavaScriptAlert):
(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):
(WebKit::WebChromeClient::print):
(WebKit::WebChromeClient::exceededDatabaseQuota):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):

4:01 PM Changeset in webkit [168652] by Lucas Forschler

• 11 edits in branches/safari-538.34-branch/Source/WebCore

Merged r168650.

3:57 PM Changeset in webkit [168651] by krit@webkit.org

• 3 edits
  2 adds in trunk

<svg> with opacity and compositing double-applies its opacity
​https://bugs.webkit.org/show_bug.cgi?id=116856

Reviewed by Simon Fraser.

Source/WebCore:
The opacity is applied by the compositor. However, all SVG elements
create transparency layers on their own to apply opacity. So did
SVGSVGElement.

Added a check if the current element has a compositing layer and skip
creating transparency layer if it has.

Test: svg/custom/composited-svg-with-opacity.html

• rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

LayoutTests:
Test that opacity is not applied twice for composited inline SVG.

• svg/custom/composited-svg-with-opacity-expected.html: Added.
• svg/custom/composited-svg-with-opacity.html: Added.

3:47 PM Changeset in webkit [168650] by beidson@apple.com

• 11 edits in trunk/Source/WebCore

Teach Editor to support more direct replacement of a Node
<rdar://problem/16817952> and ​https://bugs.webkit.org/show_bug.cgi?id=132834

Reviewed by Enrica Casucci.

The new method "Editor::replaceNodeFromPasteboard" has the intent that the new DocumentFragment
from the pasteboard is as similar to the old Node as possible.

In practice, the new DocumentFragment:
1 - Can represent a single node that's missing various attributes the original Node had.
2 - Can be an unwanted fragment of arbitrary depth when the replacement happens inside Mail.app

This fixes both of these issues.

Add a MailBlockquoteHandling enum class for various Editor operations to pass through to the
ReplaceSelectionCommand:

• editing/Editor.cpp:

(WebCore::Editor::handleTextEvent):
(WebCore::Editor::pasteAsFragment):
(WebCore::Editor::pasteWithPasteboard):
(WebCore::Editor::replaceSelectionWithFragment):

• editing/Editor.h:

• dom/TextEvent.cpp:

(WebCore::TextEvent::createForPlainTextPaste):
(WebCore::TextEvent::createForFragmentPaste):
(WebCore::TextEvent::TextEvent):

• dom/TextEvent.h:

(WebCore::TextEvent::mailBlockquoteHandling):

• editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand):
(WebCore::ReplaceSelectionCommand::doApply): Consider whether or not this particular Editor

operation was meant to give special consideration to Mail's Blockquotes.

• editing/ReplaceSelectionCommand.h:

• editing/efl/EditorEfl.cpp:

(WebCore::Editor::pasteWithPasteboard):

• editing/ios/EditorIOS.mm:

(WebCore::Editor::pasteWithPasteboard):

• editing/mac/EditorMac.mm:

(WebCore::Editor::pasteWithPasteboard):
(WebCore::Editor::readSelectionFromPasteboard):
(WebCore::maybeCopyNodeAttributesToFragment): If the new DocumentFragment represents a single HTML node

with the same tag name is the original HTML node, copy over most attributes from the original node.

(WebCore::Editor::replaceNodeFromPasteboard): Create the fragment, run it through maybeCopyNodeAttributesToFragment.

• WebCore.exp.in:

3:21 PM Changeset in webkit [168649] by commit-queue@webkit.org

• 14 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r168642.
​https://bugs.webkit.org/show_bug.cgi?id=132839

Broke ARM build (Requested by jpfau on #webkit).

Reverted changeset:

"[Win] Enum type with value zero is compatible with void*,
potential cause of crashes."
​https://bugs.webkit.org/show_bug.cgi?id=132772
​http://trac.webkit.org/changeset/168642

3:19 PM Changeset in webkit [168648] by Brent Fulgham

• 2 edits in trunk/Source/WebInspectorUI

[Win] Correct Cygwin Path Confusion in WebInspectorUI Build
​https://bugs.webkit.org/show_bug.cgi?id=132826

Reviewed by Joseph Pecoraro.

• Scripts/copy-user-interface-resources.pl: If the build is running

under Cygwin, be sure to use '/usr/bin/python', instead of just
'python' to avoid build errors.

2:38 PM Changeset in webkit [168647] by achristensen@apple.com

• 25 edits
  1 delete in trunk/Source

Progress on web timing.
​https://bugs.webkit.org/show_bug.cgi?id=132574

Reviewed by Alexey Proskuryakov.

Source/WebCore:

• CMakeLists.txt:

Removed ResourceLoadTiming.cpp.

• WebCore.exp.in:

Added linker symbols for ResourceLoadTiming.

• WebCore.xcodeproj/project.pbxproj:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:

Removed ResourceLoadTiming.cpp.

• inspector/InspectorResourceAgent.cpp:

(WebCore::buildObjectForTiming):

• inspector/protocol/Network.json:

Updated ResourceTiming structure.

• loader/DocumentLoadTiming.cpp:

(WebCore::DocumentLoadTiming::setNavigationStart):

• loader/DocumentLoadTiming.h: Deleted unused setNavigationStart function.
• page/Performance.idl:

Updated spec URL.

• page/PerformanceResourceTiming.cpp:

(WebCore::PerformanceResourceTiming::domainLookupStart):
(WebCore::PerformanceResourceTiming::domainLookupEnd):
(WebCore::PerformanceResourceTiming::connectStart):
(WebCore::PerformanceResourceTiming::secureConnectionStart):
(WebCore::PerformanceResourceTiming::responseEnd):
Updated ResourceLoadTiming member variable names.
(WebCore::PerformanceResourceTiming::responseStart):

• page/PerformanceResourceTiming.h:
• page/PerformanceResourceTiming.idl:

Deleted responseStart because it is not in the spec.

• page/PerformanceTiming.cpp:

(WebCore::PerformanceTiming::domainLookupStart):
(WebCore::PerformanceTiming::domainLookupEnd):
(WebCore::PerformanceTiming::connectStart):
(WebCore::PerformanceTiming::secureConnectionStart):
(WebCore::PerformanceTiming::requestStart):
(WebCore::PerformanceTiming::responseStart):
Updated ResourceLoadTiming member variable names.
(WebCore::PerformanceTiming::resourceLoadTimeRelativeToAbsolute):
Use navigationStart as base for resource load times.

• page/PerformanceTiming.idl:

Updated spec URL.

• platform/network/HTTPParsers.h:

Removed unused class declarations.

• platform/network/ResourceHandle.h:

Moved soup request time from ResourceLoadTiming to ResourceHandle.

• platform/network/ResourceLoadTiming.cpp: Removed.
• platform/network/ResourceLoadTiming.h:

(WebCore::ResourceLoadTiming::deepCopy):
(WebCore::ResourceLoadTiming::operator==):
(WebCore::ResourceLoadTiming::ResourceLoadTiming):
Updated ResourceLoadTiming member variable names.

• platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::createNSURLConnection):
Collect timing data.

• platform/network/mac/WebCoreResourceHandleAsDelegate.mm:

(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):

• platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):
Save timing data to a ResourceLoadTiming on the ResourceResponse.

• platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::gotHeadersCallback):
(WebCore::restartedCallback):
(WebCore::milisecondsSinceRequest):
(WebCore::ResourceHandle::didStartRequest):
(WebCore::networkEventCallback):
(WebCore::createSoupMessageForHandleAndRequest):
(WebCore::ResourceHandle::sendPendingRequest):
Updated ResourceLoadTiming member variable names.
(WebCore::wroteBodyCallback): Deleted.

Source/WebKit2:

• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<ResourceResponse>::encode):
(IPC::ArgumentCoder<ResourceResponse>::decode):
Transfer ResourceLoadTiming values if they exist.

2:34 PM Changeset in webkit [168646] by mitz@apple.com

• 3 edits in trunk/Source/WebKit2

[Cocoa] Expose WebPage::usesEphemeralSession to the bundle
​https://bugs.webkit.org/show_bug.cgi?id=132836

Reviewed by Anders Carlsson.

• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController _usesNonPersistentWebsiteDataStore]):

• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:

2:18 PM Changeset in webkit [168645] by krit@webkit.org

• 10 edits
  16 adds in trunk

SVG outline property is broken and inefficient
​https://bugs.webkit.org/show_bug.cgi?id=113666

Reviewed by Dean Jackson.

Source/WebCore:
"[SVG2] css 'outline' property should apply to svg elements

The 'outline' property was only partially working in SVG before
this patch, this makes it work on text and text content child
elements too.

This makes SVG render the outlines as part of the foreground paint
phase.

Partly based on Florin Malita's webkit patch ​https://bugs.webkit.org/show_bug.cgi?id=113666#c12."

Tests: svg/custom/outline-stacking-expected.svg

svg/custom/outline-stacking.svg
svg/custom/rgba-color-outline.svg
svg/text/text-outline-expected.svg
svg/text/text-outline-rgba.html
svg/text/text-outline.html
svg/text/textpath-outline-expected.svg
svg/text/textpath-outline.svg
svg/text/tspan-multiple-outline.svg
svg/text/tspan-outline-2-expected.svg
svg/text/tspan-outline-2.svg
svg/text/tspan-outline-expected.svg
svg/text/tspan-outline.html

• rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::paint): Draw outline in forground

paint phase.

• rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::paint): Draw outline in forground

paint phase.

• rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paintReplaced): Pass paint offset.

• rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::paint): Draw outline in forground

paint phase.

• rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::paint): Draw outline in forground

paint phase.

• rendering/svg/SVGInlineFlowBox.cpp:

(WebCore::SVGInlineFlowBox::paint): Pass paint offset.

• rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paint): Draw outline in forground

paint phase.

• rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::paint): Pass paint offset.

LayoutTests:
Test stacking for outline properties. 'outline' should
not draw above overlapping content anymore.
Test outline drawing for text elements.

• svg/custom/outline-stacking-expected.svg: Added.
• svg/custom/outline-stacking.svg: Added.
• svg/custom/rgba-color-outline-expected.html: Added.
• svg/custom/rgba-color-outline.svg: Added.
• svg/text/text-outline-expected.svg: Added.
• svg/text/text-outline-rgba-expected.html: Added.
• svg/text/text-outline-rgba.html: Added.
• svg/text/text-outline.html: Added.
• svg/text/textpath-outline-expected.svg: Added.
• svg/text/textpath-outline.svg: Added.
• svg/text/tspan-multiple-outline-expected.html: Added.
• svg/text/tspan-multiple-outline.svg: Added.
• svg/text/tspan-outline-2-expected.svg: Added.
• svg/text/tspan-outline-2.svg: Added.
• svg/text/tspan-outline-expected.svg: Added.
• svg/text/tspan-outline.html: Added.

2:07 PM Changeset in webkit [168644] by Lucas Forschler

• 19 edits in branches/safari-538.34-branch/Source

Merged r168565.

2:06 PM Changeset in webkit [168643] by Beth Dakin

• 2 edits in trunk/Source/WebCore

Layer for bottom overhang area needs to be offset by the topContentInset
​https://bugs.webkit.org/show_bug.cgi?id=132835
-and corresponding-
<rdar://problem/16641115>

Reviewed by Simon Fraser.

Push this layer down by the topContentInset in addition to the root layer height,
footer height, and header height.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateLayerForBottomOverhangArea):

1:42 PM Changeset in webkit [168642] by commit-queue@webkit.org

• 14 edits in trunk/Source/JavaScriptCore

[Win] Enum type with value zero is compatible with void*, potential cause of crashes.
​https://bugs.webkit.org/show_bug.cgi?id=132772

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-05-12
Reviewed by Geoffrey Garen.

Using the MSVC compiler, an instance of an enum type with value zero, is compatible with void* (see bug 132683 for a code example).
This has caused crashes on Windows on two occasions (bug 132683, and bug 121001).
This patch tries to prevent these type of crashes by using a type with explicit constructors instead of void*.
The void* parameter in the loadDouble and storeDouble methods are replaced with TrustedImmPtr.

• assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::loadDouble):
(JSC::MacroAssemblerARM::storeDouble):

• assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::loadDouble):
(JSC::MacroAssemblerARM64::storeDouble):

• assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::loadDouble):
(JSC::MacroAssemblerARMv7::storeDouble):

• assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::loadDouble):
(JSC::MacroAssemblerMIPS::storeDouble):

• assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::loadDouble):
(JSC::MacroAssemblerSH4::storeDouble):

• assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::storeDouble):

• assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::absDouble):
(JSC::MacroAssemblerX86Common::negateDouble):
(JSC::MacroAssemblerX86Common::loadDouble):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::silentFill):
(JSC::DFG::compileClampDoubleToByte):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::compile):

• jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::purifyNaN):

• jit/JITInlines.h:

(JSC::JIT::emitLoadDouble):

• jit/JITPropertyAccess.cpp:

(JSC::JIT::emitFloatTypedArrayGetByVal):

• jit/ThunkGenerators.cpp:

(JSC::floorThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::powThunkGenerator):

1:31 PM Changeset in webkit [168641] by jhoneycutt@apple.com

• 6 edits in trunk

REGRESSION (r167818): editing/inserting/typing-space-to-trigger-smart-link.html fails on WebKit1 bots

<​https://bugs.webkit.org/show_bug.cgi?id=132207>
<rdar://problem/16730393>

Source/WebCore:
Reverts the previous workaround in favor of a more specific fix for the
null dereference.

Reviewed by Darin Adler.

• editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
Check whether the run's start and end are still in the document, as
removeConflictingInlineStyleFromRun() may have removed them.

• editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::apply):
Reverted previous workaround.
(WebCore::ApplyEditCommand::ReentrancyGuard::isRecursiveCall): Deleted.
(WebCore::ApplyEditCommand::ReentrancyGuard::Scope::Scope): Deleted.
(WebCore::ApplyEditCommand::ReentrancyGuard::Scope::~Scope): Deleted.

LayoutTests:
Reviewed by Darin Adler.

• editing/apply-style-iframe-crash-expected.txt:

Rebased test result has one fewer new line.

• platform/mac-wk1/TestExpectations:

Remove test from list of expected failures.

1:16 PM Changeset in webkit [168640] by zandobersek@gmail.com

• 10 edits in trunk/Source/WebCore

Clean up CrossThreadTask
​https://bugs.webkit.org/show_bug.cgi?id=132800

Reviewed by Darin Adler.

Remove the createCallbackTask overloads and the related CrossThreadTask helper classes.

Instead, have one simple CrossThreadTask class that derives from ScriptExecutionContext::Task.
Its templated constructor takes in the method and the variadic pack of parameters. The cross-thread
copies of the parameters are then bound to that method and the resulting bind expression is used to
initialize the base class. The bind expression is constructed with a placeholder for the
ScriptExecutionContext* parameter that's provided through ScriptExecutionContext::Task::performTask().

• Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::didConnect):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryData):
(WebCore::ThreadableWebSocketChannelClientWrapper::didUpdateBufferedAmount):
(WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshake):
(WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageError):
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):

• Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::WorkerThreadableWebSocketChannel::Peer::bufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didConnect):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveMessage):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveBinaryData):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didUpdateBufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didStartClosingHandshake):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveMessageError):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::initialize):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::close):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::fail):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):

• dom/CrossThreadTask.h:

(WebCore::CrossThreadTask::CrossThreadTask):
(WebCore::CrossThreadTask1::CrossThreadTask1): Deleted.
(WebCore::CrossThreadTask1::performTask): Deleted.
(WebCore::CrossThreadTask2::CrossThreadTask2): Deleted.
(WebCore::CrossThreadTask2::performTask): Deleted.
(WebCore::CrossThreadTask3::CrossThreadTask3): Deleted.
(WebCore::CrossThreadTask3::performTask): Deleted.
(WebCore::CrossThreadTask4::CrossThreadTask4): Deleted.
(WebCore::CrossThreadTask4::performTask): Deleted.
(WebCore::CrossThreadTask5::CrossThreadTask5): Deleted.
(WebCore::CrossThreadTask5::performTask): Deleted.
(WebCore::CrossThreadTask6::CrossThreadTask6): Deleted.
(WebCore::CrossThreadTask6::performTask): Deleted.
(WebCore::CrossThreadTask7::CrossThreadTask7): Deleted.
(WebCore::CrossThreadTask7::performTask): Deleted.
(WebCore::CrossThreadTask8::CrossThreadTask8): Deleted.
(WebCore::CrossThreadTask8::performTask): Deleted.
(WebCore::createCallbackTask): Deleted.

• fileapi/FileReader.cpp:

(WebCore::FileReader::abort):

• loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
(WebCore::WorkerThreadableLoader::MainThreadBridge::destroy):
(WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFailAccessControlCheck):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):

• loader/WorkerThreadableLoader.h:
• loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::removeRequestFromCache):
(WebCore::MemoryCache::removeRequestFromSessionCaches):

• workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::postExceptionToWorkerObject):
(WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject):

• workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::workerObjectDestroyed):
(WebCore::WorkerMessagingProxy::connectToInspector):
(WebCore::WorkerMessagingProxy::disconnectFromInspector):
(WebCore::WorkerMessagingProxy::sendMessageToInspector):

1:13 PM Changeset in webkit [168639] by commit-queue@webkit.org

• 15 edits
  3 copies
  3 adds in trunk

Implement EXT_shader_texture_lod in WebGL.
​https://bugs.webkit.org/show_bug.cgi?id=128985
<rdar://problem/16111396>

Source/WebCore:
Based on Chromium patch by ​bajones@chromium.org.
​https://src.chromium.org/viewvc/blink?revision=171465&view=revision

Patch by Alex Christensen <​achristensen@webkit.org> on 2014-05-12
Reviewed by Dean Jackson.

Test: webgl/conformance/extensions/ext-shader-texture-lod.html

• CMakeLists.txt:
• DerivedSources.cpp:
• DerivedSources.make:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:

Added new EXTShaderTextureLOD files.

• bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):
Added EXTShaderTextureLOD.

• html/canvas/EXTShaderTextureLOD.cpp: Added.

(WebCore::EXTShaderTextureLOD::EXTShaderTextureLOD):
(WebCore::EXTShaderTextureLOD::~EXTShaderTextureLOD):
(WebCore::EXTShaderTextureLOD::getName):

• html/canvas/EXTShaderTextureLOD.h: Added.
• html/canvas/EXTShaderTextureLOD.idl: Added.
• html/canvas/WebGLExtension.h:

Added EXTShaderTextureLODName.

• html/canvas/WebGLObject.cpp:

Removed unused inclusion of EXTTextureFilterAnisotropic.h.

• html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
Added EXT_shader_texture_lod.

• html/canvas/WebGLRenderingContext.h:

Added a EXTShaderTextureLOD member variable.

LayoutTests:
Based on Firefox patch by Vladimir Vukicevic.
​https://bug965848.bugzilla.mozilla.org/attachment.cgi?id=8367994

Patch by Alex Christensen <​achristensen@webkit.org> on 2014-05-12
Reviewed by Dean Jackson.

• webgl/conformance/extensions/ext-shader-texture-lod-expected.txt: Added.
• webgl/conformance/extensions/ext-shader-texture-lod.html: Added.
• webgl/resources/webgl_test_files/conformance/extensions/ext-shader-texture-lod.html: Added.

12:54 PM Changeset in webkit [168638] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

REGRESSION(168625): [GTK] build broken due to WKContextSetLocalStorageDirectory
​https://bugs.webkit.org/show_bug.cgi?id=132831

Unreviewed GTK build fix.

Patch by Carlos Alberto Lopez Perez <​clopez@igalia.com> on 2014-05-12

• UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformDefaultLocalStorageDirectory):
This is now a static member function.

12:53 PM Changeset in webkit [168637] by andersca@apple.com

• 5 edits in trunk/Source/WebKit2

WKWebViewConfiguration should fill in the blanks
​https://bugs.webkit.org/show_bug.cgi?id=132832
<rdar://problem/16886408>

Reviewed by Dan Bernstein.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):

• UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration _validate]):

• UIProcess/API/Cocoa/WKWebViewConfigurationInternal.h:

12:47 PM Changeset in webkit [168636] by mhock@apple.com

• 3 edits
  2 adds in trunk

Disallow drag and drop of non-displayable resources.
​https://bugs.webkit.org/show_bug.cgi?id=132745
<rdar://problem/10562662>

Reviewed by Alexey Proskuryakov.

Source/WebCore:
Test: http/tests/security/drag-drop-local-file.html

• page/DragController.cpp:

(WebCore::DragController::startDrag):

LayoutTests:

• http/tests/security/drag-drop-local-file-expected.txt: Added.
• http/tests/security/drag-drop-local-file.html: Added.

12:23 PM Changeset in webkit [168635] by fpizlo@apple.com

• 7 edits
  9 adds in branches/ftlopt

jsSubstring() should be lazy
​https://bugs.webkit.org/show_bug.cgi?id=132556

Reviewed by Andreas Kling.

Source/JavaScriptCore:
jsSubstring() is now lazy by using a special rope that is a substring instead of a
concatenation. To make this patch super simple, we require that a substring's base is
never a rope. Hence, when resolving a rope, we either go down a non-recursive substring
path, or we go down a concatenation path which may see exactly one level of substrings in
its fibers.

This is up to a 50% speed-up on microbenchmarks and a 10% speed-up on Octane/regexp.

Relanding this with assertion fixes.

• heap/MarkedBlock.cpp:

(JSC::MarkedBlock::specializedSweep):

• runtime/JSString.cpp:

(JSC::JSRopeString::visitFibers):
(JSC::JSRopeString::resolveRopeInternal8):
(JSC::JSRopeString::resolveRopeInternal16):
(JSC::JSRopeString::clearFibers):
(JSC::JSRopeString::resolveRope):
(JSC::JSRopeString::resolveRopeSlowCase8):
(JSC::JSRopeString::resolveRopeSlowCase):

• runtime/JSString.h:

(JSC::JSRopeString::finishCreation):
(JSC::JSRopeString::append):
(JSC::JSRopeString::create):
(JSC::JSRopeString::offsetOfFibers):
(JSC::JSRopeString::fiber):
(JSC::JSRopeString::substringBase):
(JSC::JSRopeString::substringOffset):
(JSC::JSRopeString::notSubstringSentinel):
(JSC::JSRopeString::substringSentinel):
(JSC::JSRopeString::isSubstring):
(JSC::JSRopeString::setIsSubstring):
(JSC::jsSubstring):

• runtime/RegExpMatchesArray.cpp:

(JSC::RegExpMatchesArray::reifyAllProperties):

• runtime/StringPrototype.cpp:

(JSC::stringProtoFuncSubstring):

LayoutTests:
These tests get 35-50% faster.

• js/regress/script-tests/substring-concat-weird.js: Added.

(foo):

• js/regress/script-tests/substring-concat.js: Added.

(foo):

• js/regress/script-tests/substring.js: Added.

(foo):

• js/regress/substring-concat-expected.txt: Added.
• js/regress/substring-concat-weird-expected.txt: Added.
• js/regress/substring-concat-weird.html: Added.
• js/regress/substring-concat.html: Added.
• js/regress/substring-expected.txt: Added.
• js/regress/substring.html: Added.

12:20 PM Changeset in webkit [168634] by Lucas Forschler

• 1 edit in branches/safari-538.34-branch/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationResponsePrivate.h

Branch build fix after r168581.

11:35 AM Changeset in webkit [168633] by Lucas Forschler

• 3 edits in branches/safari-538.34-branch/Source/WebKit2

Merged r168582.

11:33 AM Changeset in webkit [168632] by Lucas Forschler

• 6 edits
  1 copy in branches/safari-538.34-branch/Source/WebKit2

Merged r168581.

11:26 AM Changeset in webkit [168631] by akling@apple.com

• 2 edits in trunk/Source/JavaScriptCore

0.4% of PLT3 in JSCell::structure() below JSObject::visitChildren().
<​https://webkit.org/b/132828>
<rdar://problem/16886285>

Reviewed by Michael Saboff.

• runtime/JSObject.cpp:

(JSC::JSObject::visitButterfly):
(JSC::JSObject::visitChildren):

Use JSCell::structure(VM&) to reduce the number of hoops we jump
through to find Structures during marking.

11:19 AM Changeset in webkit [168630] by stavila@adobe.com

• 4 edits in trunk/LayoutTests

fast/multicol/newmulticol/first-letter-create.html is very flaky
​https://bugs.webkit.org/show_bug.cgi?id=132744

Reviewed by Antti Koivisto.

Modified test to not display anything as its only purpose is to ensure it doesn't crash.

• TestExpectations:
• fast/multicol/newmulticol/first-letter-create-expected.html:
• fast/multicol/newmulticol/first-letter-create.html:

11:18 AM Changeset in webkit [168629] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

WKWebView should default to _backgroundExtendsBeyondPage = YES
​https://bugs.webkit.org/show_bug.cgi?id=132829
<rdar://problem/16886364>

Reviewed by Beth Dakin.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):

11:12 AM Changeset in webkit [168628] by andersca@apple.com

• 6 edits in trunk/Source/WebKit2

Pass local storage directory to StorageManager::create
​https://bugs.webkit.org/show_bug.cgi?id=132827

Reviewed by Tim Horton.

Since we know the local storage directory at creation time and we know it never changes,
we can get rid of setLocalStorageDirectory and just pass the local storage directory at creation time.

• UIProcess/Storage/LocalStorageDatabaseTracker.cpp:

(WebKit::LocalStorageDatabaseTracker::create):
(WebKit::LocalStorageDatabaseTracker::LocalStorageDatabaseTracker):
(WebKit::LocalStorageDatabaseTracker::~LocalStorageDatabaseTracker):
(WebKit::LocalStorageDatabaseTracker::setLocalStorageDirectory): Deleted.
(WebKit::LocalStorageDatabaseTracker::setLocalStorageDirectoryInternal): Deleted.

• UIProcess/Storage/LocalStorageDatabaseTracker.h:
• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::create):
(WebKit::StorageManager::StorageManager):
(WebKit::StorageManager::setLocalStorageDirectory): Deleted.

• UIProcess/Storage/StorageManager.h:
• UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):

11:08 AM Changeset in webkit [168627] by Lucas Forschler

• 5 edits in branches/safari-538.34-branch/Source

Versioning.

11:00 AM Changeset in webkit [168626] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

WinCairo buildfix after r168611
​https://bugs.webkit.org/show_bug.cgi?id=132825

Patch by Jozsef Berta <​jberta.u-szeged@partner.samsung.com> on 2014-05-12
Reviewed by Darin Adler.

• platform/network/curl/CurlDownload.cpp:

(WebCore::CurlDownloadManager::downloadThread):
(WebCore::CurlDownload::didReceiveHeader):
(WebCore::CurlDownload::didReceiveData):

10:56 AM Changeset in webkit [168625] by andersca@apple.com

• 15 edits in trunk

Replace WKContextSetLocalStorageDirectory with a context configuration getter/setter
​https://bugs.webkit.org/show_bug.cgi?id=132809

Reviewed by Dan Bernstein.

Source/WebKit2:

• UIProcess/API/C/WKContext.cpp:

(WKContextSetLocalStorageDirectory): Deleted.

• UIProcess/API/C/WKContextConfigurationRef.cpp:

(WKContextConfigurationCopyLocalStorageDirectory):
(WKContextConfigurationSetLocalStorageDirectory):

• UIProcess/API/C/WKContextConfigurationRef.h:

Add getters and setters for the local storage directory.

• UIProcess/API/C/WKContextPrivate.h:

Remove WKContextSetLocalStorageDirectory.

• UIProcess/API/Cocoa/WKProcessGroup.mm:

(-[WKProcessGroup initWithInjectedBundleURL:]):
Call WebContext::applyPlatformSpecificConfigurationDefaults.

• UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _initWithConfiguration:]):
Call WebContext::applyPlatformSpecificConfigurationDefaults (for now).

• UIProcess/APIContextConfiguration.cpp:

(API::ContextConfiguration::webContextConfiguration):
Set the local storage. Also, call WebContext::applyPlatformSpecificConfigurationDefaults.

• UIProcess/APIContextConfiguration.h:

(API::ContextConfiguration::injectedBundlePath):
This should be const.

(API::ContextConfiguration::localStorageDirectory):
(API::ContextConfiguration::setLocalStorageDirectory):
Add getter and setter.

• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::setLocalStorageDirectory):
ASSERT that the path isn't null.

• UIProcess/WebContext.cpp:

(WebKit::WebContext::applyPlatformSpecificConfigurationDefaults):
New helper function that will fill in platform specific defaults for empty parameters.

(WebKit::WebContext::WebContext):
Get the local storage directory from the configuration.

(WebKit::WebContext::setLocalStorageDirectory): Deleted.
(WebKit::WebContext::localStorageDirectory): Deleted.
These are no longer needed.

• UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformDefaultLocalStorageDirectory):
This should be a static member function.

Tools:

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):
Set the local storage directory using WKContextConfigurationSetLocalStorageDirectory.

10:56 AM Changeset in webkit [168624] by Antti Koivisto

• 3 edits
  2 adds in trunk

REGRESSION (r159560): Text clips on tile border if line-height < font-size
​https://bugs.webkit.org/show_bug.cgi?id=132822

Reviewed by Andreas Kling.

Source/WebCore:

The first line of simple line layout run range was miscomputed.

Test: fast/text/simple-lines-range-low-line-height.html

• rendering/SimpleLineLayoutResolver.h:

(WebCore::SimpleLineLayout::RunResolver::lineIndexForHeight):

Lines may overlap if line-height < font-size. Apply different adjustment when searching for range begin
so that overflowing earlier lines are taken into account.

(WebCore::SimpleLineLayout::RunResolver::rangeForRect):

LayoutTests:

• fast/text/simple-lines-range-low-line-height-expected.html: Added.
• fast/text/simple-lines-range-low-line-height.html: Added.

9:04 AM Changeset in webkit [168623] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

Typo fix in generate-forwarding-headers
​https://bugs.webkit.org/show_bug.cgi?id=132820

Patch by Martin Hodovan <​mhodovan.u-szeged@partner.samsung.com> on 2014-05-12
Reviewed by Anders Carlsson.

• Scripts/generate-forwarding-headers.pl:

(collectFrameworkHeaderPaths):

9:00 AM Changeset in webkit [168622] by commit-queue@webkit.org

• 18 edits in trunk/LayoutTests

[EFL] Rebaseline after adding tests in r168350
​https://bugs.webkit.org/show_bug.cgi?id=132824

Unreviewed gardening.

Patch by Krzysztof Wolanski <​k.wolanski@samsung.com> on 2014-05-12

• platform/efl/TestExpectations:
• platform/efl/fast/multicol/client-rects-expected.txt:
• platform/efl/fast/multicol/client-rects-spanners-complex-expected.txt:
• platform/efl/fast/multicol/client-rects-spanners-expected.txt:
• platform/efl/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
• platform/efl/fast/multicol/span/span-margin-collapsing-expected.txt:
• platform/efl/svg/zoom/page/zoom-foreignObject-expected.txt:
• platform/efl/svg/zoom/page/zoom-svg-as-relative-image-expected.png:
• platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
• platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
• platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
• platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
• platform/efl/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
• platform/efl/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
• platform/efl/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
• platform/efl/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
• platform/efl/svg/zoom/text/zoom-foreignObject-expected.txt:

8:23 AM Changeset in webkit [168621] by stavila@adobe.com

• 4 edits
  2 adds in trunk

Invalid information remaining in lineToRegion map of RenderFlowThread.
​https://bugs.webkit.org/show_bug.cgi?id=132690

Reviewed by Antti Koivisto.

Source/WebCore:
Test: fast/multicol/newmulticol/lines-region-map-crash.html

• rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::deleteLines):

• rendering/RenderFlowThread.h:

LayoutTests:
Added test for crash caused by invalid information in the lineToRegion map.

• fast/multicol/newmulticol/lines-region-map-crash-expected.html: Added.
• fast/multicol/newmulticol/lines-region-map-crash.html: Added.

7:30 AM Changeset in webkit [168620] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/efl

[EFL][WK1] Enable region based columns
​https://bugs.webkit.org/show_bug.cgi?id=132646

Patch by Krzysztof Wolanski <​k.wolanski@samsung.com> on 2014-05-12
Reviewed by Gyuyoung Kim.

Enable new multi-column mode as it was enabled in WK2 (r168046).

• ewk/ewk_view.cpp:

(_ewk_view_priv_new):

5:48 AM Changeset in webkit [168619] by pmolnar.u-szeged@partner.samsung.com

• 2 edits in trunk/Source/WebKit2

[EFL] TLSErrors do not cause page load to fail when not ignored
​https://bugs.webkit.org/show_bug.cgi?id=131104

Reviewed by Gyuyoung Kim.

Added EFL unit test for the bug ​https://bugs.webkit.org/show_bug.cgi?id=121548

• UIProcess/API/efl/tests/test_ewk2_ssl.cpp: Added new test: ewk_ssl_bad_cert_redirect_https_to_http

4:58 AM Changeset in webkit [168618] by Csaba Osztrogonác

• 2 edits in trunk/Source/JavaScriptCore

[cmake] Add missing FTL source files to the build system.

Patch by László Langó <​llango.u-szeged@partner.samsung.com> on 2014-05-12
Reviewed by Csaba Osztrogonác.

• CMakeLists.txt:

4:32 AM Changeset in webkit [168617] by Carlos Garcia Campos

• 2 edits in trunk

Unreviewed. Bump version numbers.

• Source/cmake/OptionsGTK.cmake:

2:35 AM WebKitGTK/KeepingTheTreeGreen edited by eocanha@igalia.com

(diff)

2:20 AM Changeset in webkit [168616] by commit-queue@webkit.org

• 14 edits
  13 adds
  2 deletes in trunk/LayoutTests

[CSS Blending] Adjust blending pixel test expectations
​https://bugs.webkit.org/show_bug.cgi?id=132737

Patch by Ion Rosca <Ion Rosca> on 2014-05-12
Reviewed by Mihnea Ovidenie.

Changing failing gif file with with one pixel base64 data and make them different for the two tests,
otherwise they might get cached and the gif animation is shared among multiple tests.
Changing the incorrect expectations for *gif-color-2* and adjusting test expectation for *gif-color-1*

• css3/blending/background-blend-mode-gif-color-2.html:
• css3/blending/background-blend-mode-gif-color.html:
• css3/blending/resources/squares.gif: Removed.
• platform/mac/css3/blending/background-blend-mode-gif-color-2-expected.png:
• platform/mac/css3/blending/background-blend-mode-gif-color-expected.png:

• platform/mac-wk1/TestExpectations:

The background-blend-mode-gif-color-2 does not pass on WK1: the git animation doesn't get started.

• platform/mac/TestExpectations: Adding bugs to the excepted blending tests.

Adjusting this test to avoid scrollbars. Adjusting test expectations.

• css3/blending/blend-mode-overflow-expected.txt: Removed.
• css3/blending/blend-mode-overflow.html:
• platform/mac/css3/blending/blend-mode-overflow-expected.png:
• platform/mac/css3/blending/blend-mode-overflow-expected.txt:

Adding pixel expectations for newly added tests:

• platform/mac/css3/blending/blend-mode-isolation-flags-append-non-stacking-context-blending-expected.png: Added.
• platform/mac/css3/blending/blend-mode-isolation-flags-append-stacking-context-blending-expected.png: Added.
• platform/mac/css3/blending/blend-mode-isolation-flags-remove-non-stacking-context-blending-expected.png: Added.
• platform/mac/css3/blending/blend-mode-isolation-flags-remove-stacking-context-blending-expected.png: Added.
• platform/mac/css3/blending/blend-mode-isolation-flags-turn-off-blending-expected.png: Added.
• platform/mac/css3/blending/blend-mode-isolation-flags-turn-off-blending-no-isolation-expected.png: Added.
• platform/mac/css3/blending/blend-mode-isolation-flags-turn-off-stacking-context-expected.png: Added.
• platform/mac/css3/blending/blend-mode-isolation-flags-turn-on-blending-expected.png: Added.
• platform/mac/css3/blending/blend-mode-isolation-flags-turn-on-stacking-context-expected.png: Added.
• platform/mac/css3/blending/blend-mode-isolation-turn-off-self-painting-layer-expected.png: Added.
• platform/mac/css3/blending/blend-mode-isolation-turn-off-self-painting-layer1-expected.png: Added.
• platform/mac/css3/blending/blend-mode-isolation-turn-off-self-painting-layer2-expected.png: Added.
• platform/mac/css3/blending/blend-mode-isolation-turn-on-self-painting-layer-expected.png: Added.

Adjusting pixel tests after removing non separable blend modes.

• platform/mac/css3/blending/blend-mode-simple-composited-expected.png:
• platform/mac/css3/blending/blend-mode-simple-expected.png:
• platform/mac/css3/blending/effect-background-blend-mode-expected.png:
• platform/mac/css3/blending/effect-background-blend-mode-tiled-expected.png:

1:57 AM Changeset in webkit [168615] by Carlos Garcia Campos

• 3 edits in trunk/Tools

REGRESSION(CMAKE): [GTK] JavaScriptCore API tests are not built anymore
​https://bugs.webkit.org/show_bug.cgi?id=132739

Reviewed Anders Carlsson.

• TestWebKitAPI/CMakeLists.txt: Add missing includes required by

the JSC unit tests.

• TestWebKitAPI/PlatformGTK.cmake: Bring back JavaScriptCore unit tests.

1:46 AM Changeset in webkit [168614] by Carlos Garcia Campos

• 1 copy in releases/WebKitGTK/webkit-2.4.2

Tagging the WebKitGTK+ 2.4.2 release

1:02 AM Changeset in webkit [168613] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.4

Unreviewed. Update NEWS and Versions.m4 for 2.4.2 release.

.:

• Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

• NEWS: Added release notes for 2.4.2.

12:23 AM Changeset in webkit [168612] by benjamin@webkit.org

• 1 edit
  8 adds in trunk/Websites/webkit.org

Add potential illustrations for a potential future blog post about the viewport meta tag

• blog-files/simple-viewport-configuration: Added.
• blog-files/simple-viewport-configuration/860_viewport.html: Added.
• blog-files/simple-viewport-configuration/blog_with_viewport.png: Added.
• blog-files/simple-viewport-configuration/blog_without_viewport.png: Added.
• blog-files/simple-viewport-configuration/default_viewport.html: Added.
• blog-files/simple-viewport-configuration/horizontal_design.html: Added.
• blog-files/simple-viewport-configuration/inspector.png: Added.
• blog-files/simple-viewport-configuration/report_size.js: Added.

12:04 AM Changeset in webkit [168611] by zandobersek@gmail.com

• 3 edits in trunk/Source/WebCore

Clean up MainThreadTask
​https://bugs.webkit.org/show_bug.cgi?id=132799

Reviewed by Darin Adler.

Only have one simple MainThreadTask class that derives from std::function<void ()>.
Its templated constructor takes in the method and a variadic pack of parameters.
The cross-thread copies of the parameter are then bound to the given method through
std::bind(), with the resulting bind expression used to initialize the base
std::function<void ()> class.

The WebCore::callOnMainThread() functions and the helper classes are removed in favor
of passing MainThreadTask rvalues directly to WTF::callOnMainThread().

• fileapi/AsyncFileStream.cpp:

(WebCore::AsyncFileStream::startOnFileThread):
(WebCore::AsyncFileStream::stopOnFileThread):
(WebCore::AsyncFileStream::getSizeOnFileThread):
(WebCore::AsyncFileStream::openForReadOnFileThread):
(WebCore::AsyncFileStream::openForWriteOnFileThread):
(WebCore::AsyncFileStream::readOnFileThread):
(WebCore::AsyncFileStream::writeOnFileThread):
(WebCore::AsyncFileStream::truncateOnFileThread):

• platform/MainThreadTask.h:

(WebCore::MainThreadTask::MainThreadTask):
(WebCore::MainThreadTaskBase::MainThreadTaskBase): Deleted.
(WebCore::MainThreadTaskBase::~MainThreadTaskBase): Deleted.
(WebCore::MainThreadTask1::create): Deleted.
(WebCore::MainThreadTask1::MainThreadTask1): Deleted.
(WebCore::MainThreadTask2::create): Deleted.
(WebCore::MainThreadTask2::MainThreadTask2): Deleted.
(WebCore::MainThreadTask3::create): Deleted.
(WebCore::MainThreadTask3::MainThreadTask3): Deleted.
(WebCore::MainThreadTask4::create): Deleted.
(WebCore::MainThreadTask4::MainThreadTask4): Deleted.
(WebCore::MainThreadTask5::create): Deleted.
(WebCore::MainThreadTask5::MainThreadTask5): Deleted.
(WebCore::MainThreadTask6::create): Deleted.
(WebCore::MainThreadTask6::MainThreadTask6): Deleted.
(WebCore::MainThreadTask7::create): Deleted.
(WebCore::MainThreadTask7::MainThreadTask7): Deleted.
(WebCore::MainThreadTask8::create): Deleted.
(WebCore::MainThreadTask8::MainThreadTask8): Deleted.
(WebCore::executeMainThreadTask): Deleted.
(WebCore::callOnMainThread): Deleted.

12:01 AM Changeset in webkit [168610] by zandobersek@gmail.com

• 6 edits
  1 delete in trunk/Source/WebCore

Simplify FileThread::Task usage
​https://bugs.webkit.org/show_bug.cgi?id=132798

Reviewed by Darin Adler.

Remove the createFileThreadTask functions and the related FileThreadTask helper classes.

Instead, the FileThread::Task class now has a templated constructor that takes in a pointer
to the object instance, a method, and a variadic pack of parameters. The pointer and the
cross-thread copies of all the parameters are then bound to the given method through std::bind().

Instead of createFileThreadTask, std::make_unique<>() should be used to construct unique pointers
that wrap FileThread::Task objects.

• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• fileapi/AsyncFileStream.cpp:

(WebCore::AsyncFileStream::create):
(WebCore::AsyncFileStream::stop):
(WebCore::AsyncFileStream::getSize):
(WebCore::AsyncFileStream::openForRead):
(WebCore::AsyncFileStream::openForWrite):
(WebCore::AsyncFileStream::close):
(WebCore::AsyncFileStream::read):
(WebCore::AsyncFileStream::write):
(WebCore::AsyncFileStream::truncate):

• fileapi/FileThread.h:

(WebCore::FileThread::Task::Task):
(WebCore::FileThread::Task::performTask):
(WebCore::FileThread::Task::~Task): Deleted.

• fileapi/FileThreadTask.h: Removed.

May 11, 2014:

11:30 PM Changeset in webkit [168609] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit2

Expose a function to copy favicon data without image conversion.
​https://bugs.webkit.org/show_bug.cgi?id=132805

Patch by Gordon Sheridan <​gordon_sheridan@apple.com> on 2014-05-11
Reviewed by Darin Adler.

• UIProcess/API/C/WKIconDatabase.cpp:

(WKIconDatabaseCopyIconDataForPageURL):
Add a function to copy the data from the image of a favicon for an associated page url.

• UIProcess/API/C/WKIconDatabase.h:

Declare WKIconDatabaseCopyIconDataForPageURL.

11:21 PM Changeset in webkit [168608] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

REGRESSION(r168603): [GTK] Build broken.
​https://bugs.webkit.org/show_bug.cgi?id=132810

Patch by Seongjun Kim <​isAir@company100.com> on 2014-05-11
Reviewed by Carlos Garcia Campos.

• UIProcess/API/gtk/WebKitWebContext.cpp:

(createDefaultWebContext):
Construct a WebContextConfiguration object and pass it to WebContext::create.

9:54 PM Changeset in webkit [168607] by benjamin@webkit.org

• 2 edits in trunk/Source/WebCore

Do not create a temporary string to append the SVGLength's unit
​https://bugs.webkit.org/show_bug.cgi?id=132807

Reviewed by Geoffrey Garen.

• svg/SVGLength.cpp:

(WebCore::lengthTypeToString):
The caller just append the string to a number string. The function
lengthTypeToString() was creating a new WTF::String from scratch,
copied the characters to make a new string, and destroyed the WTF::String.

Instead, just append the string literal.

9:23 PM Changeset in webkit [168606] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

CSS JIT: reduce cost of computing backtracking height
​https://bugs.webkit.org/show_bug.cgi?id=132546

Patch by Yusuke Suzuki <Yusuke Suzuki> on 2014-05-11
Reviewed by Benjamin Poulain.

Because compiler previously compute backtracking height for
previous child fragment, by leveraging this, we can limit the
maxPrefixSize for computeBacktrackingHeightFromDescendant.

For example, consider selector "c>a>b>d>a>b e"'s descendant chain,
"c>a>b>d>a>b".

At the <a> position, we have matching pattern [b, a, d, b, a] and
calculate the backtracking height by following method.

pattern: [b, a, d, b, a]
candidate0: [b, a, d, b] => Not matched.
candidate1: [b, a, d] => Not matched.
candidate2: [b, a] => Matched against the pattern.

At this time, first candidate0's pattern size is pattern.size() - 1.
And get backtracking height from descendant 3, that is
pattern.size() - candidate.size(), 5 - 2.

And next, at the <c> position, we calcucate the backtracking height
for this pattern.

pattern: [b, a, d, b, a, c]
candidate0: [b, a, d, b, a] => Not matched.
candidate1: [b, a, d, b] => Not matched.
candidate2: [b, a, d] => Not matched.
candidate3: [b, a] => Not matched.
candidate4: [b] => Not matched.
candidate5: [] => Matched against the pattern.

Then, we get the backtracking height, which is 6 (6 - 0).
However, in the above case, we already know that attempts from candidate0
to candidate1 always fail, since parts of these are already tested at
the <b> position trial and we know they don't match.

So in this case, we should start this computation from candidate2,
such as,

pattern: [b, a, d, b, a, c]
candidate2: [b, a, d] => Not matched.
candidate3: [b, a] => Not matched.
candidate4: [b] => Not matched.
candidate5: [] => Matched against the pattern.

We can start computation with candidate size
pattern.size() - previousChildFragmentBacktrackingHeight.
In this example, pattern.size() is 6 and
previousChildFragmentBacktrackingHeight is 3, so candidate size is
3, that is candidate2.

• cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::computeBacktrackingStartHeightFromDescendant):
(WebCore::SelectorCompiler::computeBacktrackingHeightFromDescendant):

5:08 PM Changeset in webkit [168605] by andersca@apple.com

• 5 edits in trunk/Source/WebKit2

Remove local storage directory and sandbox extension from WebProcessCreationParameters
​https://bugs.webkit.org/show_bug.cgi?id=132808

Reviewed by Beth Dakin.

• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

• Shared/WebProcessCreationParameters.h:
• UIProcess/WebContext.cpp:

(WebKit::WebContext::createNewWebProcess):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

4:44 PM Changeset in webkit [168604] by ljaehun.lim@samsung.com

• 2 edits in trunk/Source/WebKit2

Unreviewed, CMake build fix after r168603

Add APIContextConfiguration.cpp and WKContextConfigurationRef.cpp to the source list.

• CMakeLists.txt:

3:12 PM Changeset in webkit [168603] by andersca@apple.com

• 13 edits
  4 adds in trunk

Add a WKContextConfigurationRef object and make the injected bundle path part of the configuration
​https://bugs.webkit.org/show_bug.cgi?id=132806

Source/WebKit2:
<rdar://problem/16830143>

Reviewed by Beth Dakin.

Many setters on WKContextRef really only make sense to set early on, so move to a pattern where we create a
configuration object, a WKContextConfiguration which WKContexts can be created from. Add the injected bundle path
as a configuration property. More setters will follow.

• Shared/API/c/WKBase.h:

Add WKContextConfigurationRef.

• Shared/APIObject.h:

Add ContextConfiguration enum declaration.

• UIProcess/API/C/WKAPICast.h:

Handle WKContextConfigurationRef.

• UIProcess/API/C/WKContext.cpp:

(WKContextCreate):
Create an empty WKContextConfigurationRef object and pass it to WKContextCreateWithConfiguration.

(WKContextCreateWithInjectedBundlePath):
Create a WKContextConfigurationRef object, set its bundle path and pass the configuration to WKContextCreateWithConfiguration.

(WKContextCreateWithConfiguration):
Convert the WKContextConfigurationRef object to a WebContextConfiguration and pass it to WebContext::create.

• UIProcess/API/C/WKContext.h:

Add WKContextCreateWithConfiguration.

• UIProcess/API/C/WKContextConfigurationRef.cpp: Added.

(WKContextConfigurationCreate):
Create an API::ContextConfiguration object.

(WKContextConfigurationCopyInjectedBundlePath):
Return the injected bundle path.

(WKContextConfigurationSetInjectedBundlePath):
Set the injected bundle path.

• UIProcess/API/C/WKContextConfigurationRef.h: Added.

New C SPI header.

• UIProcess/API/Cocoa/WKProcessGroup.mm:

(-[WKProcessGroup initWithInjectedBundleURL:]):
Construct a WebContextConfiguration object and pass it to WebContext::Create.

• UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _initWithConfiguration:]):
Construct a WebContextConfiguration object and pass it to WebContext::Create.

• UIProcess/APIContextConfiguration.cpp: Added.

New API::ContextConfiguration object.

(API::ContextConfiguration::webContextConfiguration):
Construct a WebContextConfiguration struct from our current configuration.

• UIProcess/APIContextConfiguration.h: Added.

• UIProcess/WebContext.cpp:

(WebKit::WebContext::create):
Pass the WebContextConfiguration to the constructor.

(WebKit::WebContext::WebContext):
Set the injected bundle path from the WebContextConfiguration object.

• UIProcess/WebContext.h:

Change the WebContext constructor and create function to take a WebContextConfiguration object.

• WebKit2.xcodeproj/project.pbxproj:

Add new files.

Tools:

Reviewed by Beth Dakin.

Migrate to WKContextConfiguration.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

2:02 PM Changeset in webkit [168602] by Beth Dakin

• 7 edits in trunk/Source/WebCore

Headers and footers are not positioned correctly with topContentInset
​https://bugs.webkit.org/show_bug.cgi?id=132787
-and corresponding-
<rdar://problem/16641115>

Reviewed by Tim Horton.

Headers and footers need to take the inset into account, and they also need to
factor in the fact that the root layer moves around now too.

The existing yPositionForRootContentLayer() is actually the right calculation for
the header layer. The root content layer wants that value, but pushed down by the
header height. Now there are static functions for both of them and the footer to
avoid duplicated code in the three spots where we need this information.

• page/FrameView.cpp:

(WebCore::FrameView::yPositionForHeaderLayer):
(WebCore::FrameView::yPositionForRootContentLayer):
(WebCore::FrameView::yPositionForFooterLayer):

• page/FrameView.h:

Use the static functions to compute the layer positions.

• page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll):

How did headers ever work with this bug?? I don’t know. We need to return that
layer.

• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::headerLayerForFrameView):

Use the static functions to compute the layer positions.

• page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateRootLayerPosition):
(WebCore::RenderLayerCompositor::updateLayerForHeader):
(WebCore::RenderLayerCompositor::updateLayerForFooter):

12:46 PM Changeset in webkit [168601] by Alan Bujtas

• 16 edits in trunk/Source/WebCore

Subpixel rendering[iOS]: <select> decoration is misaligned when the renderer is on subpixel position.
​https://bugs.webkit.org/show_bug.cgi?id=132779
<rdar://problem/16631071>

Reviewed by Simon Fraser.

Push <select> theme decoration's rect to device pixel position to ensure
that the theme bounds are aligned with the renderer's bounds. (in painting terms)
However, as the decoration code paints multiple items, they all need to use snapped
final coordinates for painting : tracked here ​https://bugs.webkit.org/show_bug.cgi?id=132780
This patch also changes the padding values for <select> [iOS] to compensate for the integer
truncation that happened before subpixel.

Not testable.

• css/html.css:

(select):

• platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintMenuListButtonDecorations):

• platform/efl/RenderThemeEfl.h:
• platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::paintMenuListButtonDecorations):

• platform/gtk/RenderThemeGtk.h:
• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paintDecorations):

• rendering/RenderTheme.h:

(WebCore::RenderTheme::paintMenuListButtonDecorations):

• rendering/RenderThemeIOS.h:
• rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::paintMenuListButtonDecorations):

• rendering/RenderThemeMac.h:
• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMenuListButtonDecorations):

• rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::paintMenuListButtonDecorations):

• rendering/RenderThemeSafari.h:
• rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::paintMenuList):
(WebCore::RenderThemeWin::paintMenuListButtonDecorations):

• rendering/RenderThemeWin.h:

12:10 PM Changeset in webkit [168600] by zandobersek@gmail.com

• 20 edits in trunk/Source/WebCore

Move Source/WebCore/workers/ code to std::unique_ptr
​https://bugs.webkit.org/show_bug.cgi?id=132401

Reviewed by Darin Adler.

Replace uses of OwnPtr and PassOwnPtr in code under Source/WebCore/workers (and related places)
with std::unique_ptr.

• bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::setTimeout):
(WebCore::JSDOMWindow::setInterval):

• bindings/js/JSWorkerGlobalScopeCustom.cpp:

(WebCore::JSWorkerGlobalScope::setTimeout):
(WebCore::JSWorkerGlobalScope::setInterval):

• bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::create):

• bindings/js/ScheduledAction.h:
• page/DOMTimer.cpp:

(WebCore::DOMTimer::DOMTimer):
(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):
(WebCore::DOMTimer::didStop):

• page/DOMTimer.h:
• page/DOMWindow.cpp:

(WebCore::DOMWindow::setTimeout):
(WebCore::DOMWindow::setInterval):

• page/DOMWindow.h:
• workers/WorkerEventQueue.h:
• workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::WorkerGlobalScope):
(WebCore::WorkerGlobalScope::setTimeout):
(WebCore::WorkerGlobalScope::setInterval):

• workers/WorkerGlobalScope.h:

(WebCore::WorkerGlobalScope::clearScript):

• workers/WorkerLoaderProxy.h:
• workers/WorkerMessagingProxy.h:
• workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::WorkerRunLoop):

• workers/WorkerRunLoop.h:
• workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::loadSynchronously):
(WebCore::WorkerScriptLoader::loadAsynchronously):
(WebCore::WorkerScriptLoader::createResourceRequest):

• workers/WorkerScriptLoader.h:
• workers/WorkerThread.cpp:

(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::workerThread):
(WebCore::WorkerThreadStartupData::create): Deleted.

• workers/WorkerThread.h:

10:35 AM Changeset in webkit [168599] by mmaxfield@apple.com

• 6 edits in trunk

[Mac] [iOS] Underlines are too low
​https://bugs.webkit.org/show_bug.cgi?id=132770

Reviewed by Darin Adler.

Source/WebCore:
computeUnderlineOffset() inside InlineTextBox.cpp lowers underlines from text
baseline by a value that is proportional to the font size. However, this
lowering was done a second time in
GraphicsContext::computeLineBoundsAndAntialiasingModeForText(). This patch
removes this second, platform-dependent lowering.

This duplication was caused by merging iOS into open source, where iOS used
the GraphicsContext approach and open source used the InlineTextBox approach.

Covered by fast/css3-text/css3-text-decoration/text-decoration-thickness.html.

• platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::computeLineBoundsAndAntialiasingModeForText): Remove
redundant lowering code

• rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration): Clean up textDecorationThickness
variable

LayoutTests:
See per-file descriptions.

• fast/css3-text/css3-text-decoration/text-decoration-style-double-space-scales.html: Made

test more robust so it does not barely clip underlines, but rather gives them a couple
pixels of wiggle room.

• fast/css3-text/css3-text-decoration/text-decoration-thickness.html: Not only does this test

underline thickness, but it also tests underline position. Updated this test to not expect
incorrect results.

2:42 AM Changeset in webkit [168598] by Antti Koivisto

• 5 edits
  4 adds in trunk

Text with simple line layout not getting pushed below float when there is not enough space for it
​https://bugs.webkit.org/show_bug.cgi?id=126991

Reviewed by Andreas Kling.

Source/WebCore:
Tests: fast/text/simple-lines-intruding-wide-float-dynamic.html

fast/text/simple-lines-intruding-wide-float.html

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::markLinesDirtyInBlockRange):

Invalidate the line layout path when floats change. We need to check SimpleLineLayout::canUseFor again as
intruding floats may make this flow ineligible to use the path.

• rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::floatingObjectSet):

• rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

Test the top positions of all floats for case that would push text below the float instead of just testing
the first line. We may have floats in the middle of the paragraph too.

LayoutTests:

• fast/text/simple-lines-intruding-wide-float-dynamic-expected.html: Added.
• fast/text/simple-lines-intruding-wide-float-dynamic.html: Added.
• fast/text/simple-lines-intruding-wide-float-expected.html: Added.
• fast/text/simple-lines-intruding-wide-float.html: Added.

12:47 AM WebKitGTK/2.4.x edited by Carlos Garcia Campos

(diff)

12:47 AM Changeset in webkit [168597] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.4/Source

Merge r168523 - jsmin.py license header confusing, mentions non-free license
​https://bugs.webkit.org/show_bug.cgi?id=123665

Reviewed by Darin Adler.

Pull the most recent version from upstream, which has a clear
license.

Source/JavaScriptCore:

• inspector/scripts/jsmin.py:

Source/WebInspectorUI:

• Scripts/jsmin.py:

12:01 AM Changeset in webkit [168596] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

WinCairo crashes on acid3 test
​https://bugs.webkit.org/show_bug.cgi?id=131364

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-05-11
Reviewed by Brent Fulgham.

When the 304 (Not-modified) response is received, the Curl backend should look up the cached response,
and call the client method didReceiveResponse with the cached response, instead of the 304 response.
Otherwise the response will contain an empty MIME type, which causes the request to be cancelled, and the client deleted.
When the Curl cache manager then accesses the client afterwards, it is deleted, and we crash.

• platform/network/curl/CurlCacheManager.cpp:

(WebCore::CurlCacheManager::didReceiveResponse): Return early if request is cancelled.
(WebCore::CurlCacheManager::getCachedResponse): Added method to get cached response.

• platform/network/curl/CurlCacheManager.h: Ditto.
• platform/network/curl/ResourceHandleManager.cpp:

(WebCore::headerCallback): When 304 response is received, look up cached response, and use it.