Context Navigation

← Previous Period
Next Period →

Timeline

May 16, 2014:

11:23 PM Changeset in webkit [168992] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/efl

[EFL] Build break after 168978.
https://bugs.webkit.org/show_bug.cgi?id=133012.

Patch by Piotr Grad <p.grad@samsung.com> on 2014-05-16
Reviewed by Simon Fraser.

ewk/ewk_view.cpp:

(_ewk_view_priv_new):

10:41 PM Changeset in webkit [168991] by jer.noble@apple.com

4 edits in trunk/Source/WebCore

[Mac][MSE] setCurrentTime() goes down fastSeek path in MediaPlayerPrivateMediaSourceAVFObjC.
https://bugs.webkit.org/show_bug.cgi?id=133023

Reviewed by Eric Carlson.

When seeking a MSE video, do not go down the fastSeekForMediaTime() path if the
seek resulted from a setCurrentTime() call. The logic can lead to attempted seeks
before buffered ranges.

platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal):

platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h:
platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:

(WebCore::MediaSourcePrivateAVFObjC::seekToTime):

7:11 PM Changeset in webkit [168990] by matthew_hanson@apple.com

5 edits in branches/safari-538.34-branch/Source

Versioning

6:42 PM Changeset in webkit [168989] by matthew_hanson@apple.com

1 copy in tags/Safari-538.34.41

Create Safari-538.34.41 tag.

6:30 PM Changeset in webkit [168988] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[GTK] Build break after 168978.
https://bugs.webkit.org/show_bug.cgi?id=133012.

Patch by Piotr Grad <p.grad@samsung.com> on 2014-05-16
Reviewed by Simon Fraser.

UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsConstructed):

6:18 PM Changeset in webkit [168987] by Simon Fraser

2 edits in trunk/LayoutTests

Fix a straggler.

Remove call to internals.settings.setRegionBasedColumnsEnabled(true).

fast/repaint/spanner-with-margin.html:

5:29 PM Changeset in webkit [168986] by Simon Fraser

2 edits in trunk/Source/WebKit2

Put back a symbol removed in r168978 that Safari needs, but deprecate it.

Reviewed by Anders Carlsson.

Shared/API/c/WKDeprecatedFunctions.cpp:

(WKPreferencesSetRegionBasedColumnsEnabled):
(WKPreferencesGetRegionBasedColumnsEnabled):

5:06 PM Changeset in webkit [168985] by Simon Fraser

269 edits in trunk/LayoutTests

Remove calls to internals.settings.setRegionBasedColumnsEnabled(true);
in tests.

Some of these tests may now be no-ops, but I haven't found a convenient
way to know which ones.

fast/multicol/break-in-columns-before-spanner-expected.html:
fast/multicol/break-in-columns-before-spanner.html:
fast/multicol/break-in-scrollable-expected.html:
fast/multicol/break-in-scrollable.html:
fast/multicol/client-rects-spanners-complex.html:
fast/multicol/client-rects-spanners.html:
fast/multicol/inline-children-crash.html:
fast/multicol/mixed-opacity-fixed-test.html:
fast/multicol/mixed-opacity-test.html:
fast/multicol/mixed-positioning-stacking-order.html:
fast/multicol/multicol-li-crash.html:
fast/multicol/newmulticol/adjacent-spanners.html:
fast/multicol/newmulticol/avoid-column-break-inside.html:
fast/multicol/newmulticol/balance-images.html:
fast/multicol/newmulticol/balance-maxheight1.html:
fast/multicol/newmulticol/balance-maxheight2.html:
fast/multicol/newmulticol/balance1.html:
fast/multicol/newmulticol/balance10.html:
fast/multicol/newmulticol/balance2.html:
fast/multicol/newmulticol/balance3.html:
fast/multicol/newmulticol/balance4.html:
fast/multicol/newmulticol/balance5.html:
fast/multicol/newmulticol/balance6.html:
fast/multicol/newmulticol/balance7.html:
fast/multicol/newmulticol/balance8.html:
fast/multicol/newmulticol/balance9.html:
fast/multicol/newmulticol/block-becomes-spanner-expected.html:
fast/multicol/newmulticol/block-becomes-spanner.html:
fast/multicol/newmulticol/break-after-expected.html:
fast/multicol/newmulticol/break-after.html:
fast/multicol/newmulticol/break-before.html:
fast/multicol/newmulticol/breaks-2-columns-3-no-balancing.html:
fast/multicol/newmulticol/breaks-2-columns-3.html:
fast/multicol/newmulticol/breaks-3-columns-3.html:
fast/multicol/newmulticol/cell-shrinkback.html:
fast/multicol/newmulticol/change-spanner-display-expected.html:
fast/multicol/newmulticol/change-spanner-display.html:
fast/multicol/newmulticol/change-spanner-parent-display-expected.html:
fast/multicol/newmulticol/change-spanner-parent-display.html:
fast/multicol/newmulticol/client-rects.html:
fast/multicol/newmulticol/clipping-expected.html:
fast/multicol/newmulticol/clipping-overflow-hidden-expected.html:
fast/multicol/newmulticol/clipping-overflow-hidden.html:
fast/multicol/newmulticol/clipping-top-overflow-expected.html:
fast/multicol/newmulticol/clipping-top-overflow.html:
fast/multicol/newmulticol/clipping.html:
fast/multicol/newmulticol/column-rules-fixed-height.html:
fast/multicol/newmulticol/columns-shorthand-parsing.html:
fast/multicol/newmulticol/compare-with-old-impl/BottomToTop-tb.html:
fast/multicol/newmulticol/compare-with-old-impl/LeftToRight-tb.html:
fast/multicol/newmulticol/compare-with-old-impl/anonymous-block-split-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/before-child-anonymous-column-block.html:
fast/multicol/newmulticol/compare-with-old-impl/clone-before-after-content-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/clone-block-children-inline-mismatch-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/clone-flexbox.html:
fast/multicol/newmulticol/compare-with-old-impl/clone-summary.html:
fast/multicol/newmulticol/compare-with-old-impl/column-rules-stacking.html:
fast/multicol/newmulticol/compare-with-old-impl/column-span-inside-multicol-webkit-box.html:
fast/multicol/newmulticol/compare-with-old-impl/continuation-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/double-merge-anonymous-block-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/empty-anonymous-block-split-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/float-not-removed-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/hit-test-above-or-below.html:
fast/multicol/newmulticol/compare-with-old-impl/hit-test-block-axis-flipped.html:
fast/multicol/newmulticol/compare-with-old-impl/hit-test-end-of-column-with-line-height.html:
fast/multicol/newmulticol/compare-with-old-impl/hit-test-end-of-column.html:
fast/multicol/newmulticol/compare-with-old-impl/hit-test-float.html:
fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-between-pages-flipped.html:
fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-between-pages.html:
fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-block-axis.html:
fast/multicol/newmulticol/compare-with-old-impl/list-multi-column-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/multicol-with-child-renderLayer-for-input-expected.html:
fast/multicol/newmulticol/compare-with-old-impl/multicol-with-child-renderLayer-for-input.html:
fast/multicol/newmulticol/compare-with-old-impl/overflow-content.html:
fast/multicol/newmulticol/compare-with-old-impl/positioned-child-not-removed-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/positioned-objects-not-removed-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/recursive-split-flow-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/removal-of-multicol-span-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/remove-child-split-flow-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/runin-continuation-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/shrink-to-column-height-for-pagination.html:
fast/multicol/newmulticol/compare-with-old-impl/span-as-nested-inline-block-child.html:
fast/multicol/newmulticol/compare-with-old-impl/split-flow-anonymous-wrapper-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/split-inline-wrong-post-block-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/table-multi-column-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/textbox-not-removed-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/update-after-content-before-child-crash.html:
fast/multicol/newmulticol/direct-child-column-span-all.html:
fast/multicol/newmulticol/fixed-height-fill-auto-expected.html:
fast/multicol/newmulticol/fixed-height-fill-auto.html:
fast/multicol/newmulticol/fixed-height-fill-balance-2.html:
fast/multicol/newmulticol/fixed-height-fill-balance-expected.html:
fast/multicol/newmulticol/fixed-height-fill-balance.html:
fast/multicol/newmulticol/float-avoidance.html:
fast/multicol/newmulticol/float-multicol.html:
fast/multicol/newmulticol/float-paginate-complex.html:
fast/multicol/newmulticol/float-paginate-empty-lines.html:
fast/multicol/newmulticol/float-paginate.html:
fast/multicol/newmulticol/hide-box-horizontal-bt-expected.html:
fast/multicol/newmulticol/hide-box-horizontal-bt.html:
fast/multicol/newmulticol/hide-box-vertical-lr-expected.html:
fast/multicol/newmulticol/hide-box-vertical-lr.html:
fast/multicol/newmulticol/hide-box-vertical-rl-expected.html:
fast/multicol/newmulticol/hide-box-vertical-rl.html:
fast/multicol/newmulticol/insert-row-content1-expected.html:
fast/multicol/newmulticol/insert-row-content1.html:
fast/multicol/newmulticol/insert-row-content2-expected.html:
fast/multicol/newmulticol/insert-row-content2.html:
fast/multicol/newmulticol/insert-row-content3-expected.html:
fast/multicol/newmulticol/insert-row-content3.html:
fast/multicol/newmulticol/insert-row-content4-expected.html:
fast/multicol/newmulticol/insert-row-content4.html:
fast/multicol/newmulticol/insert-row-content5-expected.html:
fast/multicol/newmulticol/insert-row-content5.html:
fast/multicol/newmulticol/insert-row-content6-expected.html:
fast/multicol/newmulticol/insert-row-content6.html:
fast/multicol/newmulticol/insert-row-content7-expected.html:
fast/multicol/newmulticol/insert-row-content7.html:
fast/multicol/newmulticol/insert-row-content8-expected.html:
fast/multicol/newmulticol/insert-row-content8.html:
fast/multicol/newmulticol/insert-row-content9-expected.html:
fast/multicol/newmulticol/insert-row-content9.html:
fast/multicol/newmulticol/insert-spanner-child1-expected.html:
fast/multicol/newmulticol/insert-spanner-child1.html:
fast/multicol/newmulticol/insert-spanner-child2-expected.html:
fast/multicol/newmulticol/insert-spanner-child2.html:
fast/multicol/newmulticol/insert-spanner-child3-expected.html:
fast/multicol/newmulticol/insert-spanner-child3.html:
fast/multicol/newmulticol/insert-spanner1-expected.html:
fast/multicol/newmulticol/insert-spanner1.html:
fast/multicol/newmulticol/insert-spanner2-expected.html:
fast/multicol/newmulticol/insert-spanner2.html:
fast/multicol/newmulticol/insert-spanner3-expected.html:
fast/multicol/newmulticol/insert-spanner3.html:
fast/multicol/newmulticol/insert-spanner4-expected.html:
fast/multicol/newmulticol/insert-spanner4.html:
fast/multicol/newmulticol/insert-spanner5-expected.html:
fast/multicol/newmulticol/insert-spanner5.html:
fast/multicol/newmulticol/insert-spanner6-expected.html:
fast/multicol/newmulticol/insert-spanner6.html:
fast/multicol/newmulticol/insert-spanner7-expected.html:
fast/multicol/newmulticol/insert-spanner7.html:
fast/multicol/newmulticol/insert-spanner8-expected.html:
fast/multicol/newmulticol/insert-spanner8.html:
fast/multicol/newmulticol/layers-in-multicol.html:
fast/multicol/newmulticol/layers-split-across-columns.html:
fast/multicol/newmulticol/leading-and-trailing-margin-expected.html:
fast/multicol/newmulticol/leading-and-trailing-margin.html:
fast/multicol/newmulticol/leading-margin.html:
fast/multicol/newmulticol/line-grid-inside-columns.html:
fast/multicol/newmulticol/line-grid-into-columns.html:
fast/multicol/newmulticol/multicol-with-spanner-becomes-regular-block.html:
fast/multicol/newmulticol/orphans-and-widows-balance.html:
fast/multicol/newmulticol/positioned-split.html:
fast/multicol/newmulticol/positioned-with-constrained-height.html:
fast/multicol/newmulticol/progression-reverse-overflow.html:
fast/multicol/newmulticol/progression-reverse.html:
fast/multicol/newmulticol/remove-row-content1-expected.html:
fast/multicol/newmulticol/remove-row-content1.html:
fast/multicol/newmulticol/remove-row-content2-expected.html:
fast/multicol/newmulticol/remove-row-content2.html:
fast/multicol/newmulticol/remove-row-content3-expected.html:
fast/multicol/newmulticol/remove-row-content3.html:
fast/multicol/newmulticol/remove-row-content4-expected.html:
fast/multicol/newmulticol/remove-row-content4.html:
fast/multicol/newmulticol/remove-row-content5-expected.html:
fast/multicol/newmulticol/remove-row-content5.html:
fast/multicol/newmulticol/remove-row-content6-expected.html:
fast/multicol/newmulticol/remove-row-content6.html:
fast/multicol/newmulticol/remove-row-content7-expected.html:
fast/multicol/newmulticol/remove-row-content7.html:
fast/multicol/newmulticol/remove-row-content8-expected.html:
fast/multicol/newmulticol/remove-row-content8.html:
fast/multicol/newmulticol/remove-row-content9-expected.html:
fast/multicol/newmulticol/remove-row-content9.html:
fast/multicol/newmulticol/remove-spanner1-expected.html:
fast/multicol/newmulticol/remove-spanner1.html:
fast/multicol/newmulticol/remove-spanner2-expected.html:
fast/multicol/newmulticol/remove-spanner2.html:
fast/multicol/newmulticol/remove-spanner3-expected.html:
fast/multicol/newmulticol/remove-spanner3.html:
fast/multicol/newmulticol/remove-spanner4-expected.html:
fast/multicol/newmulticol/remove-spanner4.html:
fast/multicol/newmulticol/remove-spanner5-expected.html:
fast/multicol/newmulticol/remove-spanner5.html:
fast/multicol/newmulticol/remove-spanner6-expected.html:
fast/multicol/newmulticol/remove-spanner6.html:
fast/multicol/newmulticol/single-line.html:
fast/multicol/newmulticol/sole-spanner.html:
fast/multicol/newmulticol/span-between-text-expected.html:
fast/multicol/newmulticol/span-between-text.html:
fast/multicol/newmulticol/spanner-becomes-regular-block-expected.html:
fast/multicol/newmulticol/spanner-becomes-regular-block.html:
fast/multicol/newmulticol/spanner-first-expected.html:
fast/multicol/newmulticol/spanner-first.html:
fast/multicol/newmulticol/spanner-img-expected.html:
fast/multicol/newmulticol/spanner-img.html:
fast/multicol/newmulticol/spanner-inline-block-expected.html:
fast/multicol/newmulticol/spanner-inline-block.html:
fast/multicol/newmulticol/spanner-last-expected.html:
fast/multicol/newmulticol/spanner-last.html:
fast/multicol/newmulticol/spanner-nested-dynamic-expected.html:
fast/multicol/newmulticol/spanner-nested-dynamic.html:
fast/multicol/newmulticol/spanner-nested-expected.html:
fast/multicol/newmulticol/spanner-nested.html:
fast/multicol/newmulticol/spanner-pseudo-after1-expected.html:
fast/multicol/newmulticol/spanner-pseudo-after1.html:
fast/multicol/newmulticol/spanner-pseudo-after2-expected.html:
fast/multicol/newmulticol/spanner-pseudo-after2.html:
fast/multicol/newmulticol/spanner-pseudo-after3-expected.html:
fast/multicol/newmulticol/spanner-pseudo-after3.html:
fast/multicol/newmulticol/spanner-pseudo-after4-expected.html:
fast/multicol/newmulticol/spanner-pseudo-after4.html:
fast/multicol/newmulticol/spanner-pseudo-before-after1-expected.html:
fast/multicol/newmulticol/spanner-pseudo-before-after1.html:
fast/multicol/newmulticol/spanner-pseudo-before-after2-expected.html:
fast/multicol/newmulticol/spanner-pseudo-before-after2.html:
fast/multicol/newmulticol/spanner-pseudo-before-after3-expected.html:
fast/multicol/newmulticol/spanner-pseudo-before-after3.html:
fast/multicol/newmulticol/spanner-pseudo-before-after4-expected.html:
fast/multicol/newmulticol/spanner-pseudo-before-after4.html:
fast/multicol/newmulticol/spanner-pseudo-before1-expected.html:
fast/multicol/newmulticol/spanner-pseudo-before1.html:
fast/multicol/newmulticol/spanner-pseudo-before2-expected.html:
fast/multicol/newmulticol/spanner-pseudo-before2.html:
fast/multicol/newmulticol/spanner-pseudo-before3-expected.html:
fast/multicol/newmulticol/spanner-pseudo-before3.html:
fast/multicol/newmulticol/spanner-pseudo-before4-expected.html:
fast/multicol/newmulticol/spanner-pseudo-before4.html:
fast/multicol/newmulticol/spanner-table-expected.html:
fast/multicol/newmulticol/spanner-table.html:
fast/multicol/newmulticol/spanner-with-margin-expected.html:
fast/multicol/newmulticol/spanner-with-margin.html:
fast/multicol/newmulticol/spanner1-expected.html:
fast/multicol/newmulticol/spanner1.html:
fast/multicol/newmulticol/spanner2-expected.html:
fast/multicol/newmulticol/spanner2.html:
fast/multicol/newmulticol/spanner3-expected.html:
fast/multicol/newmulticol/spanner3.html:
fast/multicol/newmulticol/spanner4-expected.html:
fast/multicol/newmulticol/spanner4.html:
fast/multicol/newmulticol/spanner5-expected.html:
fast/multicol/newmulticol/spanner5.html:
fast/multicol/newmulticol/spanner6-expected.html:
fast/multicol/newmulticol/spanner6.html:
fast/multicol/newmulticol/spanner7-expected.html:
fast/multicol/newmulticol/spanner7.html:
fast/multicol/newmulticol/spanner8-expected.html:
fast/multicol/newmulticol/spanner8.html:
fast/multicol/newmulticol/spanner9-expected.html:
fast/multicol/newmulticol/spanner9.html:
fast/multicol/newmulticol/trailing-margin-with-spanner-expected.html:
fast/multicol/newmulticol/trailing-margin-with-spanner.html:
fast/multicol/newmulticol/trailing-margin-with-spanner2-expected.html:
fast/multicol/newmulticol/trailing-margin-with-spanner2.html:
fast/multicol/newmulticol/unresolvable-percent-height-2.html:
fast/multicol/newmulticol/unresolvable-percent-height.html:
fast/multicol/newmulticol/unresolvable-percent-max-height-2.html:
fast/multicol/newmulticol/unresolvable-percent-max-height.html:
fast/multicol/offset-top-left.html:
fast/multicol/percent-height.html:
fast/multicol/positioned-outside-of-columns.html:
fast/multicol/scrolling-column-rules.html:
fast/multicol/tall-float-expected.html:
fast/multicol/tall-float.html:
fast/multicol/transform-inside-opacity.html:
fast/multicol/zoom-test-expected.html:
fast/multicol/zoom-test.html:

4:28 PM Changeset in webkit [168984] by oliver@apple.com

9 edits in trunk/Source/WebKit2

Separate enabling sandbox extensions from the WEB_PROCESS_SANDBOX flag
https://bugs.webkit.org/show_bug.cgi?id=133016

Reviewed by Alexey Proskuryakov.

Add a distinct SANDBOX_EXTENSIONS flag to guard sandbox extensions
and switch over to it in the places that extensions are used.

Shared/SandboxExtension.h:
Shared/mac/SandboxExtensionMac.mm:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChooseFilesForOpenPanel):

WebKit2Prefix.h:
WebProcess/WebPage/WebPage.cpp:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

3:09 PM Changeset in webkit [168983] by msaboff@apple.com

4 edits
1 add in trunk/Source/JavaScriptCore

Crash in JSC::Yarr::YarrGenerator<(JSC::Yarr::YarrJITCompileMode)0>::generatePatternCharacterFixed() due to WTF::CrashOnOverflow::overflowed + 9
https://bugs.webkit.org/show_bug.cgi?id=133009

Reviewed by Oliver Hunt.

If we determine that any alternative requires a minumum match size greater than
INT_MAX, we handle the match in the interpreter.

Check to see if the pattern has unsigned lengths before invoking YARR JIT.

runtime/RegExp.cpp:

(JSC::RegExp::compile):
(JSC::RegExp::compileMatchOnly):

tests/stress/large-regexp.js: New test added.

Set m_containsUnsignedLengthPattern flag if any alternative's minimum length
doesn't fit in an int.

yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::setupDisjunctionOffsets):

Clear new m_containsUnsignedLengthPattern flag.

yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPattern::YarrPattern):

yarr/YarrPattern.h:

(JSC::Yarr::YarrPattern::reset):
(JSC::Yarr::YarrPattern::containsUnsignedLengthPattern):

2:55 PM Changeset in webkit [168982] by benjamin@webkit.org

2 edits in trunk/Source/WebKit2

[iOS][WK2] Add a heuristic to set the right horizontal offset on rotation for responsive websites
https://bugs.webkit.org/show_bug.cgi?id=132937
<rdar://problem/16710097>

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-05-16
Reviewed by Simon Fraser.

When responsive websites have the content size lay out larger than the minimal layout size,
we should not keep the relative horizontal position into view,
many of those websites have all the content on the left.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::dynamicViewportSizeUpdate):

2:47 PM Changeset in webkit [168981] by benjamin@webkit.org

2 edits in trunk/Source/WebKit2

[iOS][WK2] On dynamic resize, the content offset is contrained to the old content size
https://bugs.webkit.org/show_bug.cgi?id=132972

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-05-16
Reviewed by Simon Fraser.

When we set the content offset, UIScrollView limits the value to the current valid range for
content size. Since the content size was only updated after the animation, when the first frame
comes in, the content offset would sometimes be limited to a smaller rect that the actual content.

To fix this, set the expected future content size before changing the offset.

During the animation, the content size could have changed arbitrarily. At the end of the animation,
we take the actual frame and set the definite content size.
Any update after that will be regular updates through didCommitLayer.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _beginAnimatedResizeWithUpdates:]):
(-[WKWebView _endAnimatedResize]):

2:39 PM Changeset in webkit [168980] by benjamin@webkit.org

2 edits in trunk/Source/WebCore

[iOS] ScrollView::visibleContentRectInternal is bypassing the iOS code for unobscuredContentRect
https://bugs.webkit.org/show_bug.cgi?id=133008

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-05-16
Reviewed by Simon Fraser.

platform/ScrollView.cpp:

(WebCore::ScrollView::visibleContentRectInternal):
ScrollView::visibleContentRectInternal() was calling the internal implementation of visibleContentRect().
That was skipping the iOS implementation and getting the framerect directly. That size is invalid on iOS
when the exposed rect and unobscured rect are not the same.

2:32 PM Changeset in webkit [168979] by jer.noble@apple.com

3 edits
2 adds in trunk

[Mac] naturalSize not updated when preload=metadata
https://bugs.webkit.org/show_bug.cgi?id=132994

Reviewed by Eric Carlson.

Source/WebCore:
Test: media/video-load-preload-metadata-naturalsize.html

When preload=metadata, we never create an AVPlayerItem, and therefore never receive a
presentationSize KVO. When an AVAsset informs us that its tracks have changed, and there
is no AVPlayerItem, recalculate presentation size based on the first video track's natural
size.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged):

platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal):

LayoutTests:

media/video-load-preload-metadata-naturalsize-expected.txt: Added.
media/video-load-preload-metadata-naturalsize.html: Added.

2:16 PM Changeset in webkit [168978] by Simon Fraser

12 edits in trunk/Source

Remove "region-based columns" prefs
https://bugs.webkit.org/show_bug.cgi?id=133006
<rdar://problem/16945824>

Reviewed by Dave Hyatt.

Remove "region-based columns" prefs and related code, since this is only
way to render columns now.

Source/WebCore:

page/Settings.in:

Source/WebKit/mac:

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences setRegionBasedColumnsEnabled:]): Deleted.
(-[WebPreferences regionBasedColumnsEnabled]): Deleted.

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

Shared/WebPreferencesStore.h:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetRegionBasedColumnsEnabled): Deleted.
(WKPreferencesGetRegionBasedColumnsEnabled): Deleted.

UIProcess/API/C/WKPreferencesRefPrivate.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

1:53 PM Changeset in webkit [168977] by Antti Koivisto

4 edits in trunk/Source/WebCore

Link search area for touch events is too large in some cases
https://bugs.webkit.org/show_bug.cgi?id=132988
<rdar://problem/16917843>

Reviewed by Simon Fraser.

page/ios/FrameIOS.mm:

(WebCore::Frame::qualifyingNodeAtViewportLocation):

Adjust the search area to screen ppi.
Remove cut-off at scale 1. This made us pick physically far-away elements when zoomed in.

platform/PlatformScreen.h:
platform/ios/PlatformScreenIOS.mm:

(WebCore::mobileGestaltFloatValue):
(WebCore::screenPPIFactor):

Figure out screens physical PPI relative to a base.

1:46 PM Changeset in webkit [168976] by Brent Fulgham

3 edits in trunk/Source/WebKit2

Work around bug in Silverlight
https://bugs.webkit.org/show_bug.cgi?id=133004

Reviewed by Anders Carlsson.

PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:

(WebKit::PluginProcessMainDelegate::doPreInitializationWork): Add low-resolution flag
to user defaults prior to NSApplication invocation. This code was moved from
PluginProcess::platformInitializeProcess.

PluginProcess/mac/PluginProcessMac.mm:

(WebKit::PluginProcess::platformInitializeProcess): Move low-resolution flag
setting to PluginProcessMainDelegate.

12:53 PM Changeset in webkit [168975] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Added some flaky tests to TestExpectations.

Patch by Enrique Ocaña González <eocanha@igalia.com> on 2014-05-16

platform/gtk/TestExpectations:

12:45 PM Changeset in webkit [168974] by jer.noble@apple.com

6 edits in trunk/Source/WebCore

[MSE] Crash at WebCore::SourceBuffer::~SourceBuffer + 110
https://bugs.webkit.org/show_bug.cgi?id=132973

Reviewed by Eric Carlson.

Change SourceBuffer::m_private into a Ref<>, and add an assertion to
SourceBufferPrivateAVFObjC's destructor if its client has not been cleared.

Eliminate unnecessary churn in MediaSourcePrivateAVFObjC by having the predicate
functor take bare pointers, rather than a PassRefPtr.

The underlying problem seems to be in WebAVStreamDataParserListener. RefPtrs were
being created off the main thread to a non-thread safe ref counted class. In some
situations, this would result in double decrementing the ref, which would cause an
early destruction of the underlying object. Instead replace these RefPtr strong
pointers with explicit weak ones. Ensure the parser and its delegate are not freed
before the append operation completes by passing strong pointers into the async
append operation lambda.

There were a few places where we weren't null checking m_mediaSource before using it,
and at least one place where we weren't clearing m_mediaSource.

Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::SourceBuffer): Use Ref instead of RefPtr.
(WebCore::SourceBuffer::appendBufferTimerFired): Ditto.

Modules/mediasource/SourceBuffer.h:
platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:

(WebCore::MediaSourcePrivateAVFObjCHasAudio): Take a bare pointer, instead of a PassRefPtr.
(WebCore::MediaSourcePrivateAVFObjCHasVideo): Ditto.

platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:

(WebCore::MediaSourcePrivateAVFObjC::removeSourceBuffer): Clear the back pointer when removing a buffer.

platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(-[WebAVStreamDataParserListener initWithParser:parent:WebCore::]): Use WeakPtr instead of RefPtr.
(-[WebAVStreamDataParserListener invalidate]): Ditto.
(-[WebAVStreamDataParserListener streamDataParser:didParseStreamDataAsAsset:]): Ditto.
(-[WebAVStreamDataParserListener streamDataParser:didParseStreamDataAsAsset:withDiscontinuity:]): Ditto.
(-[WebAVStreamDataParserListener streamDataParser:didFailToParseStreamDataWithError:]): Ditto.
(-[WebAVStreamDataParserListener streamDataParser:didProvideMediaData:forTrackID:mediaType:flags:]): Ditto.
(-[WebAVStreamDataParserListener streamDataParser:didReachEndOfTrackWithTrackID:mediaType:]): Ditto.
(-[WebAVStreamDataParserListener streamDataParser:didProvideContentKeyRequestInitializationData:forTrackID:]): Ditto.
(WebCore::SourceBufferPrivateAVFObjC::~SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::append): Ditto.

12:21 PM WebKitGTK/KeepingTheTreeGreen edited by eocanha@igalia.com

(diff)

12:01 PM Changeset in webkit [168973] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

[Gtk] media/media-blocked-by-beforeload.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=89811

Patch by Piotr Grad <p.grad@samsung.com> on 2014-05-16
Reviewed by Eric Carlson.

Problem is that we cannot predict when 'error' event would be called,
because is called async on 'source' element. Solution is to not log
'loadedmetadata' and 'loadstart' events.

media/media-blocked-by-beforeload-expected.txt:
media/media-blocked-by-beforeload.html:

11:47 AM Changeset in webkit [168972] by Alan Bujtas

3 edits
2 adds in trunk

Subpixel rendering: Push named flows in region to device pixel when painting.
https://bugs.webkit.org/show_bug.cgi?id=132986

Reviewed by Simon Fraser.

Remove integral rounding when named flow sets the painting offset on the graphics context.
Use device pixel snapping instead to ensure that we can paint on odd device pixel positions on retina displays.

Source/WebCore:
Test: fast/regions/hidpi-region-with-auto-margin-on-subpixel-position.html

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

LayoutTests:

fast/regions/hidpi-region-with-auto-margin-on-subpixel-position-expected.html: Added.
fast/regions/hidpi-region-with-auto-margin-on-subpixel-position.html: Added.

11:26 AM Changeset in webkit [168971] by stavila@adobe.com

3 edits in trunk/Source/WebCore

[CSS Regions] Add ASSERT to make sure using the flowThread cache does not return incorrect results
https://bugs.webkit.org/show_bug.cgi?id=132906

Reviewed by Simon Fraser.

If flowThreadContainingBlock() is called on an object which is in a different
flow thread than the one currently being laid out, this method will return an incorrect
result. I added an assertion for that to make sure we catch and treat any such scenarios.
For the moment, this assertion is only validated for regions, as multicol still has some issues.

No new tests required.

rendering/RenderObject.cpp:

(WebCore::RenderObject::locateFlowThreadContainingBlockNoCache):
(WebCore::RenderObject::locateFlowThreadContainingBlock):

rendering/RenderObject.h:

10:07 AM Changeset in webkit [168970] by mhock@apple.com

5 edits
2 adds in trunk

MemoryCache::addImageToCache should return the result of add().
https://bugs.webkit.org/show_bug.cgi?id=132928
<rdar://problem/16651547>

Reviewed by Alexey Proskuryakov.

Source/WebCore:
API test: WebKit1.MemoryCacheADdImageToCache (MemoryCacheAddImageToCacheIOS.mm)

loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::addImageToCache):

Tools:

TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Added.

(TestWebKitAPI::TEST):

9:34 AM Changeset in webkit [168969] by dfarler@apple.com

2 edits in trunk/Tools

old-run-webkit-tests: allow specifying a simulator app path
https://bugs.webkit.org/show_bug.cgi?id=132975

Reviewed by Anders Carlsson.

Scripts/old-run-webkit-tests:

(openIPhoneSimulator):
Add new --simulator-app command line parameter for specifying the
absolute path to the simulator app to launch before starting a
session.

7:35 AM Changeset in webkit [168968] by commit-queue@webkit.org

6 edits in trunk/Tools

[webkitpy] In case of multiple bug rollout, all bugs should be reopened, not only the oldest one
https://bugs.webkit.org/show_bug.cgi?id=131363

Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-05-16
Reviewed by Csaba Osztrogonác.

Scripts/webkitpy/common/checkout/checkout_mock.py:
Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:

(MockBugzilla):

Scripts/webkitpy/tool/commands/download_unittest.py:

(test_create_rollout_multiple_revision_with_one_resolved):
(test_create_rollout_multiple_resolved):
(test_rollout_two_revisions):
(test_rollout_multiple_revisions):
(test_rollout_multiple_revisions_with_a_missing_bug_id):

Scripts/webkitpy/tool/steps/createbug.py:

(CreateBug.run):

Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:

(ReopenBugAfterRollout.run):

6:22 AM Changeset in webkit [168967] by abucur@adobe.com

23 edits in trunk/Source/WebCore

[CSS Regions] Reduce the RenderRegion invasiveness in rendering code
https://bugs.webkit.org/show_bug.cgi?id=132121

Reviewed by Antti Koivisto.

Remove the RenderRegion / RenderNamedFlowFragment parameters and fields from
the painting / hit testing data structures and use a stateful approach to
correctly handle regions.

When painting or hit testing, the current flow thread is saved along the current
region. They are accessed through the |currentRenderNamedFlowFragment| helper
method on RenderObject or RenderLayer.

The patch also changes a bunch of 0s to nullptrs.

Tests: No new tests, no functional change.

html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):

rendering/HitTestLocation.cpp:

(WebCore::HitTestLocation::HitTestLocation):
(WebCore::HitTestLocation::operator=):

rendering/HitTestLocation.h:

(WebCore::HitTestLocation::region): Deleted.

rendering/HitTestResult.h:
rendering/PaintInfo.h:

(WebCore::PaintInfo::PaintInfo):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paint):
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::nodeAtPoint):

rendering/RenderBox.cpp:

(WebCore::RenderBox::nodeAtPoint):
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::pushContentsClip):

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintMaskForTextFillBox):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):

rendering/RenderBoxModelObject.h:
rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintLayerByApplyingTransform):
(WebCore::RenderLayer::collectFragments):
(WebCore::RenderLayer::updatePaintingInfoForFragments):
(WebCore::RenderLayer::paintTransformedLayerIntoFragments):
(WebCore::RenderLayer::paintBackgroundForFragments):
(WebCore::RenderLayer::paintForegroundForFragmentsWithPhase):
(WebCore::RenderLayer::paintOutlineForFragments):
(WebCore::RenderLayer::paintMaskForFragments):
(WebCore::RenderLayer::hitTest):
(WebCore::RenderLayer::hitTestFixedLayersInNamedFlows):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestTransformedLayerInFragments):
(WebCore::RenderLayer::mapLayerClipRectsToFragmentationLayer):
(WebCore::RenderLayer::calculateClipRects):

rendering/RenderLayer.h:
rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateCompositedBounds):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::addToOverlapMap):
(WebCore::RenderLayerCompositor::clippedByAncestor):

rendering/RenderObject.cpp:

(WebCore::RenderObject::currentRenderNamedFlowFragment):

rendering/RenderObject.h:
rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::shouldPaint):

rendering/RenderReplica.cpp:

(WebCore::RenderReplica::paint):

rendering/RenderTable.cpp:

(WebCore::RenderTable::nodeAtPoint):

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::nodeAtPoint):

rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers):

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::paint):

rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paintReplaced):

4:56 AM Changeset in webkit [168966] by berto@igalia.com

4 edits in trunk

RTCDtmfSender default values need to be updated.
https://bugs.webkit.org/show_bug.cgi?id=132952

Patch by Kiran <kiran.guduru@samsung.com> on 2014-05-16
Reviewed by Eric Carlson.

Source/WebCore:
The default ToneDuration and ToneGap values are modified in the updated spec.
So these values need to be updated.

Test: fast/mediastream/RTCPeerConnection-dtmf.html.

Modules/mediastream/RTCDTMFSender.cpp:

LayoutTests:
Added checks to test default, min value interToneGap
and duration and max value for duration.
(Spec does not specify any max value for inTertoneGap)

fast/mediastream/RTCPeerConnection-dtmf.html:

2:02 AM Changeset in webkit [168965] by Lucas Forschler

6 edits in branches/safari-538.34.5-branch/Source/WebCore

Merged r168886.

2:00 AM Changeset in webkit [168964] by Lucas Forschler

2 edits in branches/safari-538.34.5-branch/Source/WebKit2

Merged r168862.

1:57 AM Changeset in webkit [168963] by Lucas Forschler

3 edits in branches/safari-538.34.5-branch/Source/WebKit2

Merged r168848.

1:54 AM Changeset in webkit [168962] by Lucas Forschler

26 edits
1 copy in branches/safari-538.34.5-branch/Source/JavaScriptCore

Merged r168776.

1:53 AM Changeset in webkit [168961] by Csaba Osztrogonác

244 edits in trunk

[WK2] Change the remaining framework includes from WebKit2 to WebKit
https://bugs.webkit.org/show_bug.cgi?id=132956

Patch by Martin Hodovan <mhodovan.u-szeged@partner.samsung.com> on 2014-05-16
Reviewed by Sam Weinig.

Source/WebKit2:

NetworkProcess/unix/NetworkProcessMainUnix.cpp:
NetworkProcess/unix/NetworkProcessMainUnix.h:
PluginProcess/unix/PluginProcessMainUnix.h:
Shared/API/c/cairo/WKImageCairo.h:
Shared/API/c/cf/WKURLRequestCF.h:
Shared/API/c/cf/WKURLResponseCF.h:
Shared/API/c/efl/WKArrayEfl.cpp:
Shared/API/c/efl/WKArrayEfl.h:
UIProcess/API/C/CoordinatedGraphics/WKView.h:
UIProcess/API/C/WKBatteryManager.h:
UIProcess/API/C/WKBatteryStatus.h:
UIProcess/API/C/WKGrammarDetail.h:
UIProcess/API/C/WKTextChecker.h:
UIProcess/API/C/WKVibration.h:
UIProcess/API/C/WKViewportAttributes.h:
UIProcess/API/C/cairo/WKIconDatabaseCairo.h:
UIProcess/API/C/efl/WKAPICastEfl.h:
UIProcess/API/C/efl/WKColorPickerResultListener.h:
UIProcess/API/C/efl/WKEventEfl.h:
UIProcess/API/C/efl/WKPageEfl.h:
UIProcess/API/C/efl/WKPopupItem.h:
UIProcess/API/C/efl/WKPopupMenuListener.h:
UIProcess/API/C/efl/WKViewEfl.cpp:
UIProcess/API/C/efl/WKViewEfl.h:
UIProcess/API/C/gtk/WKFullScreenClientGtk.h:
UIProcess/API/C/gtk/WKInspectorClientGtk.h:
UIProcess/API/C/gtk/WKView.h:
UIProcess/API/C/gtk/WKViewPrivate.h:
UIProcess/API/C/soup/WKContextSoup.h:
UIProcess/API/C/soup/WKCookieManagerSoup.h:
UIProcess/API/C/soup/WKSoupCustomProtocolRequestManager.h:
UIProcess/API/C/soup/WKSoupRequestManager.h:
UIProcess/API/Cocoa/WKErrorRecoveryAttempting.h:
UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.h:
UIProcess/API/cpp/efl/WKEinaSharedString.cpp:
UIProcess/API/cpp/efl/WKEinaSharedString.h:
UIProcess/API/efl/EwkView.cpp:
UIProcess/API/efl/EwkView.h:
UIProcess/API/efl/EwkViewCallbacks.h:
UIProcess/API/efl/GestureRecognizer.h:
UIProcess/API/efl/ewk_application_cache_manager_private.h:
UIProcess/API/efl/ewk_auth_request_private.h:
UIProcess/API/efl/ewk_back_forward_list_item_private.h:
UIProcess/API/efl/ewk_back_forward_list_private.h:
UIProcess/API/efl/ewk_context_menu_item.cpp:
UIProcess/API/efl/ewk_context_private.h:
UIProcess/API/efl/ewk_cookie_manager_private.h:
UIProcess/API/efl/ewk_database_manager_private.h:
UIProcess/API/efl/ewk_error_private.h:
UIProcess/API/efl/ewk_favicon_database_private.h:
UIProcess/API/efl/ewk_file_chooser_request_private.h:
UIProcess/API/efl/ewk_page_group_private.h:
UIProcess/API/efl/ewk_popup_menu_item_private.h:
UIProcess/API/efl/ewk_popup_menu_private.h:
UIProcess/API/efl/ewk_security_origin_private.h:
UIProcess/API/efl/ewk_settings_private.h:
UIProcess/API/efl/ewk_storage_manager_private.h:
UIProcess/API/efl/ewk_view.cpp:
UIProcess/API/efl/ewk_view_private.h:
UIProcess/API/efl/ewk_window_features_private.h:
UIProcess/API/efl/tests/InjectedBundle/injected_bundle_sample.cpp:
UIProcess/API/efl/tests/test_ewk2_eina_shared_string.cpp:
UIProcess/API/gtk/WebKitDownloadClient.cpp:
UIProcess/API/gtk/WebKitPrivate.h:
UIProcess/CoordinatedGraphics/WKCoordinatedSceneAPICast.h:
UIProcess/efl/BatteryProvider.h:
UIProcess/efl/ContextHistoryClientEfl.h:
UIProcess/efl/DownloadManagerEfl.h:
UIProcess/efl/FindClientEfl.h:
UIProcess/efl/FormClientEfl.h:
UIProcess/efl/PageLoadClientEfl.h:
UIProcess/efl/PagePolicyClientEfl.h:
UIProcess/efl/PageUIClientEfl.h:
UIProcess/efl/RequestManagerClientEfl.h:
UIProcess/efl/TextCheckerClientEfl.h:
UIProcess/efl/VibrationClientEfl.h:
UIProcess/efl/ViewClientEfl.cpp:
UIProcess/efl/ViewClientEfl.h:
UIProcess/efl/WebInspectorProxyEfl.cpp:
WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:
WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp:
WebProcess/efl/SeccompFiltersWebProcessEfl.cpp:
WebProcess/efl/SeccompFiltersWebProcessEfl.h:
WebProcess/efl/WebProcessMainEfl.cpp:
WebProcess/efl/WebProcessMainEfl.h:
WebProcess/gtk/WebGtkInjectedBundleMain.cpp:
WebProcess/gtk/WebProcessMainGtk.cpp:
WebProcess/gtk/WebProcessMainGtk.h:
mac/WKPreferences.h:

Tools:

MiniBrowser/MiniBrowserWebProcessPlugIn.h:
MiniBrowser/mac/AppDelegate.m:
MiniBrowser/mac/WK2BrowserWindowController.m:
TestWebKitAPI/InjectedBundleController.h:
TestWebKitAPI/InjectedBundleMain.cpp:
TestWebKitAPI/JavaScriptTest.cpp:
TestWebKitAPI/PlatformUtilities.h:
TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp:
TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
TestWebKitAPI/Tests/WebKit2/Find.cpp:
TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm:
TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
TestWebKitAPI/config.h:
TestWebKitAPI/efl/PlatformWebView.cpp:
TestWebKitAPI/mac/JavaScriptTestMac.mm:
TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
TestWebKitAPI/mac/PlatformWebViewMac.mm:
TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
TestWebKitAPI/mac/WebKitAgnosticTest.mm:
WebKitTestRunner/EventSenderProxy.h:
WebKitTestRunner/GeolocationProviderMock.cpp:
WebKitTestRunner/GeolocationProviderMock.h:
WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
WebKitTestRunner/InjectedBundle/EventSendingController.h:
WebKitTestRunner/InjectedBundle/GCController.cpp:
WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
WebKitTestRunner/InjectedBundle/InjectedBundle.h:
WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
WebKitTestRunner/InjectedBundle/TestRunner.cpp:
WebKitTestRunner/InjectedBundle/TestRunner.h:
WebKitTestRunner/InjectedBundle/TextInputController.cpp:
WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
WebKitTestRunner/PlatformWebView.h:
WebKitTestRunner/StringFunctions.h:
WebKitTestRunner/TestController.cpp:
WebKitTestRunner/TestController.h:
WebKitTestRunner/TestInvocation.cpp:
WebKitTestRunner/TestInvocation.h:
WebKitTestRunner/WebKitTestRunnerPrefix.h:
WebKitTestRunner/WebNotificationProvider.cpp:
WebKitTestRunner/WebNotificationProvider.h:
WebKitTestRunner/WorkQueueManager.cpp:
WebKitTestRunner/cairo/TestInvocationCairo.cpp:
WebKitTestRunner/cg/TestInvocationCG.cpp:
WebKitTestRunner/cocoa/CrashReporterInfo.mm:
WebKitTestRunner/config.h:
WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
WebKitTestRunner/ios/PlatformWebViewIOS.mm:
WebKitTestRunner/ios/TestControllerIOS.mm:
WebKitTestRunner/mac/EventSenderProxy.mm:
WebKitTestRunner/mac/PlatformWebViewMac.mm:
WebKitTestRunner/mac/TestControllerMac.mm:

1:48 AM Changeset in webkit [168960] by Lucas Forschler

2 edits in branches/safari-538.34.5-branch/Source/WebKit2

Merged r168768.

1:44 AM Changeset in webkit [168959] by Lucas Forschler

2 edits in branches/safari-538.34.5-branch/Source/WebKit2

Merged r168724.

1:43 AM Changeset in webkit [168958] by Lucas Forschler

2 edits in branches/safari-538.34.5-branch/Source/WebKit2

Merged r168694.

1:42 AM Changeset in webkit [168957] by Lucas Forschler

2 edits in branches/safari-538.34.5-branch/Source/WebKit2

Merged r168691.

1:41 AM Changeset in webkit [168956] by Lucas Forschler

7 edits in branches/safari-538.34.5-branch/Source/WebKit2

Merged r168690.

1:39 AM Changeset in webkit [168955] by Lucas Forschler

5 edits in branches/safari-538.34.5-branch/Source/WebKit2

Merged r168637.

1:37 AM Changeset in webkit [168954] by Lucas Forschler

2 edits in branches/safari-538.34.5-branch/Source/WebKit2

Merged r168629.

1:35 AM Changeset in webkit [168953] by Lucas Forschler

54 edits
1 copy in branches/safari-538.34.5-branch/Source/WebKit2

Merged r168566.

1:26 AM Changeset in webkit [168952] by Lucas Forschler

6 edits in branches/safari-538.34.5-branch/Source

Merged r168473.

1:22 AM Changeset in webkit [168951] by Lucas Forschler

2 edits in branches/safari-538.34.5-branch/Source/WebCore

Merged r168873.

1:21 AM Changeset in webkit [168950] by Lucas Forschler

8 edits in branches/safari-538.34.5-branch/Source

Merged r168882.

1:03 AM Changeset in webkit [168949] by Lucas Forschler

2 edits in branches/safari-538.34.5-branch/Source/WebCore

Merged r168882.

12:56 AM Changeset in webkit [168948] by Lucas Forschler

2 edits in branches/safari-538.34.5-branch/Source/WebCore

Merged r168758.

12:53 AM Changeset in webkit [168947] by Lucas Forschler

6 edits in branches/safari-538.34.5-branch/Source/WebCore

Merged r168755.

12:52 AM Changeset in webkit [168946] by Lucas Forschler

12 edits in branches/safari-538.34.5-branch/Source

Merged r168744.

12:47 AM Changeset in webkit [168945] by matthew_hanson@apple.com

2 edits in branches/safari-538.34-branch/Source/WebCore

Merge r168777.

12:46 AM Changeset in webkit [168944] by Lucas Forschler

3 edits in branches/safari-538.34.5-branch/Source/WebCore

Merged r168670.

12:42 AM Changeset in webkit [168943] by Lucas Forschler

5 edits in branches/safari-538.34.5-branch/Source

Merged r168661.

12:39 AM Changeset in webkit [168942] by matthew_hanson@apple.com

26 edits
1 copy in branches/safari-538.34-branch/Source/JavaScriptCore

Merge r168776.

12:37 AM Changeset in webkit [168941] by Lucas Forschler

4 edits in branches/safari-538.34.5-branch/Source/WebKit2

Merged r168568.

12:35 AM Changeset in webkit [168940] by Lucas Forschler

2 edits in branches/safari-538.34.5-branch/Source/WebKit2

Merged r168563.

12:33 AM Changeset in webkit [168939] by Lucas Forschler

11 edits in branches/safari-538.34.5-branch

Merged r168555.

12:28 AM Changeset in webkit [168938] by Lucas Forschler

6 edits in branches/safari-538.34.5-branch/Source/WebCore

Merged r168519.

12:24 AM Changeset in webkit [168937] by Lucas Forschler

2 edits in branches/safari-538.34.5-branch/Source/WebCore

Merged r168514.

12:15 AM Changeset in webkit [168936] by Lucas Forschler

2 edits in branches/safari-538.34.5-branch/Source/WebKit2

Merged r168572.

12:14 AM Changeset in webkit [168935] by Lucas Forschler

2 edits in branches/safari-538.34.5-branch/Source/WebCore

Merged r168557.

12:13 AM Changeset in webkit [168934] by Lucas Forschler

16 edits in branches/safari-538.34.5-branch/Source

Merged r168556.

12:12 AM Changeset in webkit [168933] by Lucas Forschler

4 edits in branches/safari-538.34.5-branch/Source

Merged r168513.

12:08 AM Changeset in webkit [168932] by Lucas Forschler

5 edits in branches/safari-538.34.5-branch/Source

Merged r168497.

12:06 AM Changeset in webkit [168931] by Lucas Forschler

10 edits in branches/safari-538.34.5-branch/Source

Merged r168459.

12:00 AM Changeset in webkit [168930] by matthew_hanson@apple.com

2 edits in branches/safari-538.34-branch/Source/WebKit2

Merge r168745.

May 15, 2014:

11:58 PM Changeset in webkit [168929] by matthew_hanson@apple.com

2 edits in branches/safari-538.34-branch/Source/WebKit/mac

Merge r168913.

11:52 PM Changeset in webkit [168928] by Lucas Forschler

7 edits in branches/safari-538.34.5-branch/Source

Merged r168452.

11:51 PM Changeset in webkit [168927] by matthew_hanson@apple.com

2 edits in branches/safari-538.34-branch/Source/WebCore

Merge r168870.

11:47 PM Changeset in webkit [168926] by Lucas Forschler

7 edits in branches/safari-538.34.5-branch/Source

Merged r168447.

10:21 PM Changeset in webkit [168925] by gyuyoung.kim@samsung.com

4 edits in trunk

[EFL][WK2] Skip failing unit tests
https://bugs.webkit.org/show_bug.cgi?id=132979

Reviewed by Daniel Bates.

Source/WebKit2:

PlatformEfl.cmake: Skip failing unit tests for now.

Tools:

TestWebKitAPI/PlatformEfl.cmake: Skip failing unit tests for now.

9:51 PM Changeset in webkit [168924] by dbates@webkit.org

2 edits in trunk/Source/WebCore

Attempt to fix the Apple Mavericks Release, Apple MountainLion Release,
Apple MountainLion Release (32-bit Build), EFL, and GTK builds following
<http://trac.webkit.org/changeset/168921> (https://bugs.webkit.org/show_bug.cgi?id=132669)

dom/ContainerNode.cpp: Include SVGElement.h for the definition of Node::hasTagName(const SVGQualifiedName&).

9:44 PM Changeset in webkit [168923] by Lucas Forschler

5 edits in branches/safari-538.34.5-branch/Source

Versioning.

9:32 PM Changeset in webkit [168922] by Lucas Forschler

1 copy in branches/safari-538.34.5-branch

New Branch

9:30 PM Changeset in webkit [168921] by dbates@webkit.org

11 edits
24 adds in trunk

ASSERT_NOT_REACHED() in DocumentOrderedMap::get() when removing SVG subtree
https://bugs.webkit.org/show_bug.cgi?id=132669
<rdar://problem/14931432>

Reviewed by Brent Fulgham and Ryosuke Niwa.

Source/WebCore:
Fixes an assertion failure when removing an SVG element with a duplicate id.

When removing an SVG element with id A we synchronously instruct each element that references A
to find the first element with id A, call this N, from the document root and register itself to
either receive subsequent notifications from N (say, there is another element with id A) or as
waiting for an element with id A (say, N = nullptr; => we removed the last element with id A from
the document). Because the elements that reference A perform this operation synchronously when
removing an element they consult an transient state of the DocumentOrderedMap when querying for the
element with id A.

Without loss of generality, let E, E_1, E_2, and E_3 be elements, where E_1, E_2, E_3 are children
of E in that order and E_1.id = E_2.id = A and E_3.href = #A (that is, it references an element
with id A). Suppose we remove E then we remove E_1, update DocumentOrderedMap to decrement its count
for id A, and notify E_3 to look for an element with id A. This leads to an assertion failure since
DocumentOrderedMap expects to find an element with id A, E_2, but cannot find such an element when
traversing from the document root because E was unlinked from the document root (i.e. E_2 is in a
disjoint subtree).

Tests: svg/custom/change-id-of-use-during-removal.html

svg/custom/remove-subtree-including-path-with-duplicate-id-referenced-by-later-textpath.html
svg/custom/remove-subtree-including-text-with-duplicate-id-referenced-by-later-tref.html
svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-earlier-use.html
svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-later-animate.html
svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-later-feimage.html
svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-later-mpath.html
svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-later-use.html
svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-later-use2.html
svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-use-in-different-subtree.html
svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-use-with-duplicate-id-in-different-subtree.html
svg/custom/remove-use-with-duplicate-id-referenced-by-later-use.html

dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChild): Call SVGDocumentExtensions::rebuildElements() after we remove
a DOM subtree so that applicable SVG elements can update their referenced element when the DocumentOrderedMap
is in a stable-state.
(WebCore::ContainerNode::removeChildren): Ditto.

svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::rebuildElements): Added; notifies SVG elements that their href attribute
changed so that they query the DocumentOrderedMap for the element they reference by id in their href attribute.
(WebCore::SVGDocumentExtensions::clearTargetDependencies): Added; Called from removing
an SVG element S from the DOM. Appends all elements that reference the id of S to the end of a Vector of
elements to be rebuilt (when SVGDocumentExtensions::rebuildElements() is called) and notifies these elements
that have been marked to be rebuilt so that they can invalidate their state (e.g. stop animating).
(WebCore::SVGDocumentExtensions::rebuildAllElementReferencesForTarget): Changed to take its argument by reference
(since it's always non-null) and simplified logic to synchronously notify SVG updates that their referenced element
may have changed. Calling SVGElement::svgAttributeChanged() on an element E should at most remove the dependencies
of E.

svg/SVGDocumentExtensions.h:
svg/SVGElement.cpp:

(WebCore::SVGElement::~SVGElement): Substitute "*this" for "this" as SVGDocumentExtensions::rebuildAllElementReferencesForTarget()
now takes a reference instead of a pointer.
(WebCore::SVGElement::removedFrom): Modified to call SVGDocumentExtensions::clearTargetDependencies().
(WebCore::SVGElement::attributeChanged): Substitute "*this" for "this" as SVGDocumentExtensions::rebuildAllElementReferencesForTarget()
now takes a reference instead of a pointer.

svg/SVGElement.h:

(WebCore::SVGElement::callClearTarget): Added; calls through to private virtual SVGElement::clearTarget().
(WebCore::SVGElement::clearTarget): Added.

svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::clearTarget): Added.

svg/SVGTRefElement.h:
svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::clearTarget): Added.

svg/animation/SVGSMILElement.h:

LayoutTests:
Add tests to ensure that we don't cause an assertion failure when removing an SVG element with a duplicate id.

svg/custom/change-id-of-use-during-removal-expected.txt: Added.
svg/custom/change-id-of-use-during-removal.html: Added.
svg/custom/remove-subtree-including-path-with-duplicate-id-referenced-by-later-textpath-expected.txt: Added.
svg/custom/remove-subtree-including-path-with-duplicate-id-referenced-by-later-textpath.html: Added.
svg/custom/remove-subtree-including-text-with-duplicate-id-referenced-by-later-tref-expected.txt: Added.
svg/custom/remove-subtree-including-text-with-duplicate-id-referenced-by-later-tref.html: Added.
svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-earlier-use-expected.txt: Added.
svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-earlier-use.html: Added.
svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-later-animate-expected.txt: Added.
svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-later-animate.html: Added.
svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-later-feimage-expected.txt: Added.
svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-later-feimage.html: Added.
svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-later-mpath-expected.txt: Added.
svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-later-mpath.html: Added.
svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-later-use-expected.txt: Added.
svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-later-use.html: Added.
svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-later-use2-expected.txt: Added.
svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-later-use2.html: Added.
svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-use-in-different-subtree-expected.txt: Added.
svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-use-in-different-subtree.html: Added.
svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-use-with-duplicate-id-in-different-subtree-expected.html: Added.
svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-use-with-duplicate-id-in-different-subtree.html: Added.
svg/custom/remove-use-with-duplicate-id-referenced-by-later-use-expected.html: Added.
svg/custom/remove-use-with-duplicate-id-referenced-by-later-use.html: Added.

8:56 PM Changeset in webkit [168920] by Simon Fraser

10 edits in trunk/Source

[iOS WK2] When zoomed, fixed elements jump at the start of a scroll, and jump back at the end.
https://bugs.webkit.org/show_bug.cgi?id=132978
<rdar://problem/16894428>

Reviewed by Benjamin Poulain.

Source/WebCore:

This was the actual cause of the bug; r168560 changed the rect passed in here
to be the customFixedPositionRect rather than the unobscured rect, but we
used it to call FrameView::rectForViewportConstrainedObjects() which gave back
another bogus rect. So just use the rect passed in.

page/scrolling/ios/ScrollingTreeScrollingNodeIOS.mm:

(WebCore::ScrollingTreeScrollingNodeIOS::updateLayersAfterViewportChange):

Source/WebKit2:

Move the static function fixedPositionRectFromExposedRect() to a member function on
WebPageProxy so we can call it from more places. Also never give WebCore a customFixedPosition
rect that extends past the document bounds, but allow rubber-banding/pinching in the UI process to
move fixed elements outside the document.

UIProcess/PageClient.h: Need to expose minimumZoomScale() and contentsSize() to WebPageProxy.
UIProcess/WebPageProxy.h:
UIProcess/ios/PageClientImplIOS.h:
UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::minimumZoomScale):
(WebKit::PageClientImpl::contentsSize):

UIProcess/ios/WKContentView.mm:

(-[WKContentView didUpdateVisibleRect:unobscuredRect:unobscuredRectInScrollViewCoordinates:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:]):
Pass the computeCustomFixedPositionRect(ConstrainedToDocumentRect) to WebCore, but use computeCustomFixedPositionRect()
for the ScrollingCoordinator update.
(adjustedUnexposedEdge): Deleted.
(adjustedUnexposedMaxEdge): Deleted.
(fixedPositionRectFromExposedRect): Deleted.

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::adjustedUnexposedEdge):
(WebKit::adjustedUnexposedMaxEdge):
(WebKit::WebPageProxy::computeCustomFixedPositionRect):

UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree): This fixes some flashing when the scrolling tree
was being updated while scrolling; we now pass the correct rect.

8:32 PM Changeset in webkit [168919] by commit-queue@webkit.org

22 edits in trunk/Source/WebInspectorUI

Web Inspector: Should remove JSDoc comment blocks.
https://bugs.webkit.org/show_bug.cgi?id=132984

Patch by Jono Wells <jonowells@apple.com> on 2014-05-15
Reviewed by Timothy Hatcher.

Remove JSDoc comment blocks. These are no longer necessary.

UserInterface/Base/Main.js:
UserInterface/Base/Object.js:
UserInterface/Controllers/DOMTreeManager.js:
UserInterface/Models/CSSCompletions.js:
UserInterface/Models/DOMNode.js:
UserInterface/Models/SourceMap.js:
UserInterface/Protocol/InspectorBackend.js:
UserInterface/Protocol/RemoteObject.js:
UserInterface/Views/ApplicationCacheFrameContentView.js:
UserInterface/Views/ConsoleMessage.js:
UserInterface/Views/ConsoleMessageImpl.js:
UserInterface/Views/ContextMenu.js:
UserInterface/Views/DOMTreeElement.js:
UserInterface/Views/DOMTreeOutline.js:
UserInterface/Views/DOMTreeUpdater.js:
UserInterface/Views/DataGrid.js:
UserInterface/Views/DatabaseContentView.js:
UserInterface/Views/EditingSupport.js:
UserInterface/Views/ObjectPropertiesSection.js:
UserInterface/Views/Popover.js:
UserInterface/Views/TreeOutline.js:

JSDoc style comment blocks removed.

5:11 PM Changeset in webkit [168918] by mrowe@apple.com

3 edits in trunk/Source/WebKit2

<https://webkit.org/b/132976> Move discovery of sharing services off the main thread

Discovery of sharing services can require disk access and IPC. Since the interface to
ServicesController is already asynchronous, we can easily perform the discovery on a
background queue. This can eliminate tens to hundreds of milliseconds worth of work
from the main thread when creating the first web process.

Reviewed by Brady Eidson.

UIProcess/mac/ServicesController.h:
UIProcess/mac/ServicesController.mm:

(WebKit::ServicesController::ServicesController):
(WebKit::ServicesController::refreshExistingServices): Bail out early if we're already
in the process of refreshing the services. Kick the discovery over to a background queue,
with it hopping back to the main queue to update the actual state and notify any contexts
that were interested.

5:02 PM Changeset in webkit [168917] by mitz@apple.com

2 edits in trunk/Source/WebKit2

Fixed a typo in a comment and updated previous change log entry.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::elementDidFocus):

4:46 PM Changeset in webkit [168916] by mitz@apple.com

2 edits in trunk/Source/WebKit2

[iOS] www.wikipedia.org is loading much slower due to FormClient::willBeginInputSession
https://bugs.webkit.org/show_bug.cgi?id=132974

Reviewed by Enrica Casucci.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::elementDidFocus): Don’t call FormClient::willBeginInputSession if the
focus isn’t user-initiated, because in that case the UI process will bail out of
-_startAssistingNode:userIsInteracting:userObject: before creating an input session and
calling the -_webView:didStartInputSession:.

4:28 PM Changeset in webkit [168915] by dbates@webkit.org

14 edits
12 adds in trunk

SVG element may reference arbitrary DOM element before running its insertion logic
https://bugs.webkit.org/show_bug.cgi?id=132757
<rdar://problem/15703817>

Reviewed by Ryosuke Niwa.

Source/WebCore:
Fixes an issue where an SVG element may reference an arbitrary DOM element e before e finished being
inserted in the tree.

Currently when an SVG element A is inserted into a document we use document.getElementById() to find the
element B it references (if any). If A is inserted before B and B has the same id as a later element in
the document then A can find B before B is notified that its been inserted into the document (i.e. before
Element::insertedFrom() is called on B). Instead, A should call document.getElementById() only after
cessation of the insertion operation that inserted it to ensure that all inserted nodes (including B)
processed their insertion-specific logic.

Tests: svg/custom/reparent-animate-element.html

svg/custom/reparent-feimage-element.html
svg/custom/reparent-mpath-element.html
svg/custom/reparent-textpath-element.html
svg/custom/reparent-tref-element.html
svg/custom/reparent-use-element.html

svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::insertedInto): Return InsertionShouldCallDidNotifySubtreeInsertions so that
we are called back to resolve our target element (i.e. call SVGFEImageElement::buildPendingResources())
after the subtree we're in is inserted.
(WebCore::SVGFEImageElement::didNotifySubtreeInsertions): Added; turns around and calls SVGFEImageElement::buildPendingResources().

svg/SVGFEImageElement.h:
svg/SVGMPathElement.cpp:

(WebCore::SVGMPathElement::insertedInto): Return InsertionShouldCallDidNotifySubtreeInsertions so that
we are called back to resolve our target element (i.e. call SVGMPathElement::buildPendingResources())
after the subtree we're in is inserted.
(WebCore::SVGMPathElement::didNotifySubtreeInsertions): Added; turns around and calls SVGMPathElement::buildPendingResources().

svg/SVGMPathElement.h:
svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::insertedInto): Return InsertionShouldCallDidNotifySubtreeInsertions so that
we are called back to resolve our target element (i.e. call SVGTRefElement::buildPendingResources())
after the subtree we're in is inserted.
(WebCore::SVGTRefElement::didNotifySubtreeInsertions): Added; turns around and calls SVGTRefElement::buildPendingResources().

svg/SVGTRefElement.h:
svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::insertedInto): Return InsertionShouldCallDidNotifySubtreeInsertions so that
we are called back to resolve our target element (i.e. call SVGTextPathElement::buildPendingResources())
after the subtree we're in is inserted.
(WebCore::SVGTextPathElement::didNotifySubtreeInsertions): Added; turns around and calls SVGTextPathElement::buildPendingResources().

svg/SVGTextPathElement.h:
svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::insertedInto): Return InsertionShouldCallDidNotifySubtreeInsertions so that
we are called back to resolve our target element (i.e. call SVGUseElement::buildPendingResources()) after its subtree is
inserted.
(WebCore::SVGUseElement::didNotifySubtreeInsertions): Added; turns around and calls SVGUseElement::buildPendingResources().

svg/SVGUseElement.h:
svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::insertedInto): Return InsertionShouldCallDidNotifySubtreeInsertions so that
we are called back to resolve our target element (i.e. call SVGSMILElement::buildPendingResources())
after the subtree we're in is inserted.
(WebCore::SVGSMILElement::didNotifySubtreeInsertions): Added; turns around and calls SVGSMILElement::buildPendingResources().

svg/animation/SVGSMILElement.h:

LayoutTests:
Add tests to ensure that we don't cause an assertion failure when re-parenting an SVG subtree that
contains an element with a duplicate id.

svg/custom/reparent-animate-element-expected.txt: Added.
svg/custom/reparent-animate-element.html: Added.
svg/custom/reparent-feimage-element-expected.txt: Added.
svg/custom/reparent-feimage-element.html: Added.
svg/custom/reparent-mpath-element-expected.txt: Added.
svg/custom/reparent-mpath-element.html: Added.
svg/custom/reparent-textpath-element-expected.txt: Added.
svg/custom/reparent-textpath-element.html: Added.
svg/custom/reparent-tref-element-expected.txt: Added.
svg/custom/reparent-tref-element.html: Added.
svg/custom/reparent-use-element-expected.txt: Added.
svg/custom/reparent-use-element.html: Added.

4:03 PM Changeset in webkit [168914] by mhahnenberg@apple.com

6 edits
4 adds in trunk

JSDOMWindow should not claim HasImpureGetOwnPropertySlot
https://bugs.webkit.org/show_bug.cgi?id=132918

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

jit/Repatch.cpp:

(JSC::tryRepatchIn): We forgot to check for watchpoints when repatching "in".

Source/WebCore:
Tests: js/cached-window-properties.html

js/cached-window-prototype-properties.html

We now correctly handle the impurity of JSDOMWindow's custom getOwnPropertySlot without needing the
blanket HasImpureGetOwnPropertySlot. We do this through the use of watchpoints and by explicitly forbidding
any caching beyond a certain point using PropertySlot::disableCaching. Getting rid of this flag will allow
us to cache many properties/methods on both the JSDOMWindow and its prototype, which are very commonly used
across the web.

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlot):

bindings/scripts/CodeGeneratorJS.pm:

(HasComplexGetOwnProperty):
(InterfaceRequiresAttributesOnInstance):
(InstanceOverridesGetOwnPropertySlot):
(GenerateHeader):

LayoutTests:
We now correctly handle the impurity of JSDOMWindow's custom getOwnPropertySlot without needing the
blanket HasImpureGetOwnPropertySlot. We do this through the use of watchpoints and by explicitly forbidding
any caching beyond a certain point using PropertySlot::disableCaching. Getting rid of this flag will allow
us to cache many properties/methods on both the JSDOMWindow and its prototype, which are very commonly used
across the web.

These tests trigger inline caching of window and window prototype properties.

js/cached-window-properties-expected.txt: Added.
js/cached-window-properties.html: Added.
js/cached-window-prototype-properties-expected.txt: Added.
js/cached-window-prototype-properties.html: Added.

2:27 PM Changeset in webkit [168913] by beidson@apple.com

2 edits in trunk/Source/WebKit/mac

Crash in [WebSharingServicePickerController clear]
<rdar://problem/16879073> and https://bugs.webkit.org/show_bug.cgi?id=132968

Reviewed by Tim Horton.

Misc/WebSharingServicePickerController.mm:

(-[WebSharingServicePickerController clear]): Add a RetainPtr protector so this object

isn’t dealloc’ed partway through.

2:20 PM Changeset in webkit [168912] by Simon Fraser

2 edits in trunk/Source/WebKit/mac

Initialize the WebKitRegionBasedColumnsEnabled pref on iOS WK1
https://bugs.webkit.org/show_bug.cgi?id=132969

Reviewed by Dan Bernstein.

Move this outside the #if !PLATFORM(IOS) block.

WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

2:20 PM Changeset in webkit [168911] by Simon Fraser

2 edits in trunk/Source/WebKit/mac

Clean up -[WebView _preferencesChanged]
https://bugs.webkit.org/show_bug.cgi?id=132967

Reviewed by Sam Weinig.

-[WebView _preferencesChanged] was a horrible mess of #ifdefs. Clean this up by
moving all the #if PLATFORM() code together, and moving all the feature-define related
settings to the end.

No behavior changes, checked by diffing the resulting Settings with and without
the patch, on OS X and iOS.

WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

2:17 PM Changeset in webkit [168910] by ddkilzer@apple.com

3 edits in trunk/Tools

[iOS] Support TestWebKitAPI in the iOS Simulator
<http://webkit.org/b/129535>
<rdar://problem/16203529>

Reviewed by Daniel Bates.

Scripts/run-api-tests:

(runTest):
(listAllTests):

Extract common arguments into local variable.
Use xcrun to find the sim tool in order to invoke

TestWebKitAPI properly in the iOS Simulator.

Scripts/webkitdirs.pm:

(argumentsForConfiguration): Set --device or --sim as
appropriate to fix buildTestTool() in run-api-tests.

2:00 PM Changeset in webkit [168909] by ap@apple.com

4 edits in trunk/Source/WebCore

NetworkProcess crashes at ResourceHandle::continueDidReceiveResponse
https://bugs.webkit.org/show_bug.cgi?id=132966
<rdar://problem/16373694>

Reviewed by Brady Eidson.

Covered by many fast/files tests.

platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::continueDidReceiveResponse):
platform/network/BlobResourceHandle.h:
platform/network/ResourceHandle.h:

Don't call delegate's continueDidReceiveResponse when loading a blob:// URL,
the delegate is null. On the Mac, we used to lazily create it, which was also wrong,
but at least not observable.

1:58 PM Changeset in webkit [168908] by ap@apple.com

2 edits
8 adds in trunk/LayoutTests

Automatically zip document bundles used via File API
https://bugs.webkit.org/show_bug.cgi?id=132713
<rdar://problem/13397892>

Actually land the tests.

fast/files/filereader-zip-bundle-expected.txt: Added.
fast/files/filereader-zip-bundle.html: Added.
fast/files/resources/document.rtfd: Added.
fast/files/resources/document.rtfd/TXT.rtf: Added.
http/tests/local/fileapi/resources/document.rtfd: Added.
http/tests/local/fileapi/resources/document.rtfd/TXT.rtf: Added.
http/tests/local/fileapi/upload-zip-bundle-as-blob-expected.txt: Added.
http/tests/local/fileapi/upload-zip-bundle-as-blob.html: Added.
platform/wk2/TestExpectations:

1:03 PM Changeset in webkit [168907] by benjamin@webkit.org

2 edits in trunk/Source/WebKit2

[iOS][WK2] WKWebView sends invalid content offsets at the end of animated resize
https://bugs.webkit.org/show_bug.cgi?id=132941
<rdar://problem/16921557>

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-05-15
Reviewed by Tim Horton.

Since we cannot change the scale and content inset simultaneously while accounting for the obscured insets,
we end up with invalid contentOffsets.

To work around the problem, change the content scale outside of UIScrollView to ensure none of the side effect
happens.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _endAnimatedResize]):

12:45 PM Changeset in webkit [168906] by timothy_horton@apple.com

2 edits in trunk/Tools

Fix a logging typo in copy-webkitlibraries-to-product-directory

Reviewed by Dean Jackson.

Scripts/copy-webkitlibraries-to-product-directory:

12:17 PM Changeset in webkit [168905] by commit-queue@webkit.org

23 edits in trunk/Source/WebCore

Unreviewed, rolling out r168899.
https://bugs.webkit.org/show_bug.cgi?id=132965

Broke some compositing regions tests on Mavericks (Requested
by mihnea_ on #webkit).

Reverted changeset:

"[CSS Regions] Reduce the RenderRegion invasiveness in
rendering code"
https://bugs.webkit.org/show_bug.cgi?id=132121
http://trac.webkit.org/changeset/168899

12:15 PM Changeset in webkit [168904] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

WebKit2 View Gestures (Zoom): Document size changes during zoom gesture cause erratic scrolling
https://bugs.webkit.org/show_bug.cgi?id=132944
<rdar://problem/15769454>

Reviewed by Simon Fraser.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
If a layer flush occurs and we have an active transient zoom,
re-apply the transient zoom to the relevant platform layers, because
WebCore might have overwritten the relevant layer properties.

(WebKit::TiledCoreAnimationDrawingArea::applyTransientZoomToPage):
Reset m_transientZoomScale before flushLayers() so that we don't
re-apply the transient zoom when we're actually trying to commit it.

11:42 AM Changeset in webkit [168903] by commit-queue@webkit.org

11 edits in trunk/Source

Add pointer lock to features without enabling it.
https://bugs.webkit.org/show_bug.cgi?id=132961

Patch by Alex Christensen <achristensen@webkit.org> on 2014-05-15
Reviewed by Sam Weinig.

Configurations/FeatureDefines.xcconfig:

Added ENABLE_POINTER_LOCK to list of features.

Source/WebCore:

WebCore.exp.in:

Added linker symbols which differ with pointer lock enabled.

WebCore.xcodeproj/project.pbxproj:

Added PointerLockController.cpp to build.

Source/WebKit/mac:

WebView/WebPDFView.mm:

(-[WebPDFView PDFViewWillClickOnLink:withURL:]):
Added extra parameters needed when pointer lock is enabled.

11:28 AM Changeset in webkit [168902] by mhahnenberg@apple.com

9 edits in trunk

Move subframe name getter lookup later in JSDOMWindow::getOwnPropertySlot
https://bugs.webkit.org/show_bug.cgi?id=132922

Reviewed by Geoffrey Garen.

Source/WebCore:
No new tests.

In JSDOMWindow::getOwnPropertySlot, we currently look for the property on the JSDOMWindow,
then we search the window's subframes for name getters, then we look in the window's prototype
chain. Apparently we were doing the lookup in this order to be compatible with Mozilla, but
Mozilla no longer implements this behavior. Instead, they do the lookup on the prototype before
looking for subframe name getters. We should change this to match Mozilla. This has the convenient
side effect of allowing us to cache lookups in the window's prototype chain.

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlot):

LayoutTests:
In JSDOMWindow::getOwnPropertySlot, we currently look for the property on the JSDOMWindow,
then we search the window's subframes for name getters, then we look in the window's prototype
chain. Apparently we were doing the lookup in this order to be compatible with Mozilla, but
Mozilla no longer implements this behavior. Instead, they do the lookup on the prototype before
looking for subframe name getters. We should change this to match Mozilla. This has the convenient
side effect of allowing us to cache lookups in the window's prototype chain.

fast/dom/Window/window-function-frame-getter-precedence-expected.txt: Rebaseline to account

for change in behavior.

fast/dom/Window/window-function-frame-getter-precedence.html:
http/tests/security/document-all-expected.txt: Rebaseline due to the presenece of a security check

that was previously not done with the old behavior.

http/tests/security/window-named-proto-expected.txt: Ditto.
http/tests/security/window-named-valueOf-expected.txt: Ditto.
http/tests/security/xss-DENIED-window-name-alert.html: Changed test so it actually tests named getters.

10:48 AM Changeset in webkit [168901] by Simon Fraser

23 edits in trunk/Source

[UI-side compositing] Fix copying animations between layers, and pausing them
https://bugs.webkit.org/show_bug.cgi?id=132943
<rdar://problem/16906369&16906541>

Reviewed by Tim Horton.

Source/WebCore:

Pass the animation key back to animationStarted(), though this isn't used
when animations are running in-process.

platform/graphics/ca/PlatformCALayer.h:
platform/graphics/ca/mac/PlatformCALayerMac.h:
platform/graphics/ca/mac/PlatformCALayerMac.mm:

(-[WebAnimationDelegate animationDidStart:]):
(PlatformCALayerMac::animationStarted):

platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayerWin::animationStarted):

platform/graphics/ca/win/PlatformCALayerWin.h:

Source/WebKit2:

Fix PlatformCAAnimationRemote to support animation copying, and to record
the beginTime for implicitly started animations. This fixes animation pausing,
and copying of animations between layers when they go between tiled and non-tiled.

This requires sending the animation key back through animationDidStart() so that
we can record this beginTime on the PlatformCAAnimationRemote in the web process.
This path doesn't set the "hasExplicitBeginTime" flag.

PlatformCAAnimationRemote also now stores a hash of active animations, so that
it can implement animationForKey(), and record the beginTime.

UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::acceleratedAnimationDidStart):

UIProcess/mac/RemoteLayerTreeHost.h:
UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::animationDidStart): Grovel for the key for this
animation; sadly CA doesn't give us an easier way.

WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::acceleratedAnimationDidStart):

WebProcess/WebPage/DrawingArea.messages.in:
WebProcess/WebPage/mac/PlatformCAAnimationRemote.h:
WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:

(-[WKAnimationDelegate animationDidStart:]):
(WebKit::PlatformCAAnimationRemote::copy):
(WebKit::PlatformCAAnimationRemote::copyTimingFunctionFrom):
(WebKit::PlatformCAAnimationRemote::copyFromValueFrom):
(WebKit::PlatformCAAnimationRemote::copyToValueFrom):
(WebKit::PlatformCAAnimationRemote::copyValuesFrom):
(WebKit::PlatformCAAnimationRemote::copyKeyTimesFrom):
(WebKit::PlatformCAAnimationRemote::copyTimingFunctionsFrom):
(WebKit::addAnimationToLayer):

WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::addAnimationForKey):
(WebKit::PlatformCALayerRemote::removeAnimationForKey):
(WebKit::PlatformCALayerRemote::animationForKey):
(WebKit::PlatformCALayerRemote::animationStarted):

WebProcess/WebPage/mac/PlatformCALayerRemote.h:
WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::animationDidStart):

WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::acceleratedAnimationDidStart):

10:18 AM Changeset in webkit [168900] by ddkilzer@apple.com

2 edits
1 move
1 add in trunk/Tools

TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac
<http://webkit.org/b/132959>

Reviewed by Dan Bernstein.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add

Cocoa directory to project and move URLExtras.mm into it.

TestWebKitAPI/Tests/Cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/URLExtras.mm.

9:43 AM Changeset in webkit [168899] by abucur@adobe.com

23 edits in trunk/Source/WebCore

[CSS Regions] Reduce the RenderRegion invasiveness in rendering code
https://bugs.webkit.org/show_bug.cgi?id=132121

Reviewed by Antti Koivisto.

Remove the RenderRegion / RenderNamedFlowFragment parameters and fields from
the painting / hit testing data structures and use a stateful approach to
correctly handle regions.

When painting or hit testing, the current flow thread is saved along the current
region. They are accessed through the |currentRenderNamedFlowFragment| helper
method on RenderObject or RenderLayer.

The patch also changes a bunch of 0s to nullptrs.

Tests: No new tests, no functional change.

html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):

rendering/HitTestLocation.cpp:

(WebCore::HitTestLocation::HitTestLocation):
(WebCore::HitTestLocation::operator=):

rendering/HitTestLocation.h:

(WebCore::HitTestLocation::region): Deleted.

rendering/HitTestResult.h:
rendering/PaintInfo.h:

(WebCore::PaintInfo::PaintInfo):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paint):
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::nodeAtPoint):

rendering/RenderBox.cpp:

(WebCore::RenderBox::nodeAtPoint):
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::pushContentsClip):

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintMaskForTextFillBox):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):

rendering/RenderBoxModelObject.h:
rendering/RenderLayer.cpp:

rendering/RenderLayer.h:
rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateCompositedBounds):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::addToOverlapMap):
(WebCore::RenderLayerCompositor::clippedByAncestor):

rendering/RenderObject.cpp:

(WebCore::RenderObject::currentRenderNamedFlowFragment):

rendering/RenderObject.h:
rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::shouldPaint):

rendering/RenderReplica.cpp:

(WebCore::RenderReplica::paint):

rendering/RenderTable.cpp:

(WebCore::RenderTable::nodeAtPoint):

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::nodeAtPoint):

rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers):

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::paint):

rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paintReplaced):

9:35 AM Changeset in webkit [168898] by Simon Fraser

8 edits in trunk/Source

Clean up "has non-zero begin time" terminology in animations
https://bugs.webkit.org/show_bug.cgi?id=132942

Reviewed by Tim Horton.

Change the "non-zero beginTime" terminology in the platform CA animations
code to "explicit beginTime": this flag really means that we explicitly set
the beginTime of the animation, rather than let CA set the beginTime when
committing the animation. This flag is used for animations with negative
delay, and when pausing.

Source/WebCore:

The WKNonZeroBeginTimeFlag key was spread across PlatformCALayerMac and PlatformCAAnimationMac,
so hide it behind getter/setter functions.

Remove lots of m_layer.get() in PlatformCAAnimationMac.

platform/graphics/ca/mac/PlatformCAAnimationMac.h:
platform/graphics/ca/mac/PlatformCAAnimationMac.mm:

(WebCore::hasExplicitBeginTime):
(WebCore::setHasExplicitBeginTime):
(PlatformCAAnimationMac::copy):
(PlatformCAAnimationMac::keyPath):
(PlatformCAAnimationMac::beginTime):
(PlatformCAAnimationMac::setBeginTime):
(PlatformCAAnimationMac::duration):
(PlatformCAAnimationMac::setDuration):
(PlatformCAAnimationMac::speed):
(PlatformCAAnimationMac::setSpeed):
(PlatformCAAnimationMac::timeOffset):
(PlatformCAAnimationMac::setTimeOffset):
(PlatformCAAnimationMac::repeatCount):
(PlatformCAAnimationMac::setRepeatCount):
(PlatformCAAnimationMac::autoreverses):
(PlatformCAAnimationMac::setAutoreverses):
(PlatformCAAnimationMac::fillMode):
(PlatformCAAnimationMac::setFillMode):
(PlatformCAAnimationMac::setTimingFunction):
(PlatformCAAnimationMac::copyTimingFunctionFrom):
(PlatformCAAnimationMac::isRemovedOnCompletion):
(PlatformCAAnimationMac::setRemovedOnCompletion):
(PlatformCAAnimationMac::isAdditive):
(PlatformCAAnimationMac::setAdditive):
(PlatformCAAnimationMac::valueFunction):
(PlatformCAAnimationMac::setValueFunction):
(hasNonZeroBeginTimeFlag): Deleted.
(setNonZeroBeginTimeFlag): Deleted.

platform/graphics/ca/mac/PlatformCALayerMac.mm:

(-[WebAnimationDelegate animationDidStart:]):

Source/WebKit2:

Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTextStream::operator<<):

WebProcess/WebPage/mac/PlatformCAAnimationRemote.h:
WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:

(-[WKAnimationDelegate animationDidStart:]):
(WebKit::PlatformCAAnimationRemote::Properties::encode):
(WebKit::PlatformCAAnimationRemote::Properties::decode):
(WebKit::PlatformCAAnimationRemote::setBeginTime):
(WebKit::addAnimationToLayer):

8:18 AM Changeset in webkit [168897] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Unreviewed, rolling out r168893.
https://bugs.webkit.org/show_bug.cgi?id=132957

Lots of media tests still come to crash on EFL layout test
(Requested by gyuyoung on #webkit).

Reverted changeset:

"LayoutTests: Unreviewed EFL gardening. Unskip media test both
EFL WK1 and WK2."
http://trac.webkit.org/changeset/168893

1:51 AM Changeset in webkit [168896] by commit-queue@webkit.org

4 edits
2 adds in trunk/LayoutTests

[EFL] Add new test expectations after r168544
https://bugs.webkit.org/show_bug.cgi?id=132908

Unreviewed gardening

Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2014-05-15

platform/efl/TestExpectations:
platform/efl/svg/foreignObject/svg-document-in-html-document-expected.txt:
platform/efl/svg/text/small-fonts-in-html5-expected.txt:
platform/efl/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Added.
platform/efl/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Added.

1:09 AM Changeset in webkit [168895] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

[iOS] Incremental updates during scroll-to-top shouldn’t count as “stable” updates
https://bugs.webkit.org/show_bug.cgi?id=132934

Reviewed by Simon Fraser.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _updateVisibleContentRects]):
If we're in a scroll-to-top programmatic scroll, the update is not stable.
The last event comes in with _isScrollingToTop false, so we do our stable update.

1:06 AM Changeset in webkit [168894] by Carlos Garcia Campos

9 edits in trunk

[GTK] Compile all installed resources as GResources
https://bugs.webkit.org/show_bug.cgi?id=131099

Reviewed by Philippe Normand.

Source/WebCore:

PlatformGTK.cmake: Do not install the resources.
platform/audio/gtk/AudioBusGtk.cpp:

(WebCore::AudioBus::loadPlatformResource): Load the audio resource
from GResources and use createBusFromInMemoryAudioFile().

platform/graphics/Image.h: Remove unsued function loadPlatformThemeIcon.
platform/graphics/gtk/ImageGtk.cpp:

(WebCore::loadImageFromGResource): Load the given icon name from GResources.
(WebCore::loadResourceSharedBuffer): Use char* instead of CString.
(WebCore::loadMissingImageIconFromTheme): Try to load the missing
icon from the current GTK icon theme.
(WebCore::Image::loadPlatformResource): Call
loadMissingImageIconFromTheme for missing icon or
loadImageFromGResource for any other icon name.
(WebCore::getPathToImageResource): Deleted.
(WebCore::getThemeIconFileName): Deleted.
(WebCore::loadImageFromFile): Deleted.
(WebCore::Image::loadPlatformThemeIcon): Deleted.

Source/WebKit2:
It avoids conflicts with old WebKit versions, and resources are
always found even without installing or using environment variables.

PlatformGTK.cmake: Add rules to write the xml file with the

resources depending on the configure options and to generate and
build the GResources file.

Tools:

Scripts/webkitpy/port/gtk.py:

(GtkPort.setup_environ_for_server): Removed now unneeded
AUDIO_RESOURCES_PATH env var.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed