Context Navigation

← Previous Period
Next Period →

Timeline

May 17, 2014:

11:11 PM Changeset in webkit [169007] by mjs@apple.com

3 edits
4 adds in trunk

Don't attempt to update id or name for nodes that are already removed
https://bugs.webkit.org/show_bug.cgi?id=133041

Reviewed by Sam Weinig.

Source/WebCore:

Tests: fast/dom/remove-element-with-id-that-was-inserted-on-DOMNodeRemoved.html

fast/dom/remove-element-with-name-that-was-inserted-on-DOMNodeRemoved.html

dom/Element.cpp:

(WebCore::Element::removedFrom): Skip updating ids and names for an element not
in a treescope, as we already do for elements not in a document.

LayoutTests:

Test originally by Dan Bates.

fast/dom/remove-element-with-id-that-was-inserted-on-DOMNodeRemoved-expected.txt: Added.
fast/dom/remove-element-with-id-that-was-inserted-on-DOMNodeRemoved.html: Added.
fast/dom/remove-element-with-name-that-was-inserted-on-DOMNodeRemoved-expected.txt: Added.
fast/dom/remove-element-with-name-that-was-inserted-on-DOMNodeRemoved.html: Added.

10:29 PM Changeset in webkit [169006] by ap@apple.com

11 edits in trunk

REGRESSION (NetworkProcess): Trying to use appcache fallback crashes in ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache
https://bugs.webkit.org/show_bug.cgi?id=133007
<rdar://problem/13702706>

appcache tests often fail on the Mac WebKit2 bot
https://bugs.webkit.org/show_bug.cgi?id=82061

Reviewed by Maciej Stachowiak.

Source/WebCore:
Covered by existing tests, which this patch enables.

WebCore.exp.in: Export ResourceLoader::cancel(const ResourceError&). It used

to be virtual, but marking subclasses final has resulted in the compiler calling
it directly from WebKitLegacy framework. Seeing that no subclass overrides it,
I then made it non-virtual.
Also export ApplicationCacheHost functions that are now used from WebKit2.

loader/ResourceLoader.h: Made the class abstract (as I didn't realize at first

that it's always either a SubresourceLoader or a NetscapePlugInStreamLoader).
Made ResourceHandleClient functions private, as they should never be called other
than via a ResourceHandleClient pointer.

loader/NetscapePlugInStreamLoader.h:
loader/SubresourceLoader.h:

Marked these final.

loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willSwitchToSubstituteResource):

Added a function to be called when switching to a substitute resource. We still
need a ResourceLoader at this point, as substitute resource will be delivered through
it, but we don't want it to continue its current load.

loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache):
Call the ResourceLoader function instead of using handle, which is null when
using out of process networking.

Source/WebKit2:

WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::willSendRequest):
(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo):
(WebKit::WebResourceLoader::didFailResourceLoad):
Perform the same appcache checks that ResourceHandleClient implementation in ResourceLoader
does. We should eventually come up with a way to share the code. Perhaps add a class that
isolates ResourceLoader from networking details? But ResourceLoader was itself supposed
to be the class that isolates DocumentLoader from networking details. So, unsure.

LayoutTests:

platform/mac-wk2/TestExpectations: Let's enable all the appcache tests (except

for a couple that fail), and see what happens on bots. I don't see any reason
why WebKit2 would be any more flaky than WebKit1 here.

8:44 PM Changeset in webkit [169005] by fpizlo@apple.com

7 edits in branches/ftlopt/Source/JavaScriptCore

[ftlopt] InlineCallFrame::isCall should be an enumeration
https://bugs.webkit.org/show_bug.cgi?id=133034

Reviewed by Sam Weinig.

Once we start inlining getters and setters, we'll want InlineCallFrame to be able to tell
us that the inlined call was a getter call or a setter call. Initially I thought I would
have a new field called "kind" that would have components NormalCall, GetterCall, and
SetterCall. But that doesn't make sense, because for GetterCall and SetterCall, isCall
would have to be true. Hence, It makes more sense to have one enumeration that is Call,
Construct, GetterCall, or SetterCall. This patch is a first step towards this.

It's interesting that isClosureCall should probably still be separate, since getter and
setter inlining could inline closure calls.

bytecode/CodeBlock.h:

(JSC::baselineCodeBlockForInlineCallFrame):

bytecode/CodeOrigin.cpp:

(JSC::InlineCallFrame::dumpInContext):
(WTF::printInternal):

bytecode/CodeOrigin.h:

(JSC::InlineCallFrame::kindFor):
(JSC::InlineCallFrame::specializationKindFor):
(JSC::InlineCallFrame::InlineCallFrame):
(JSC::InlineCallFrame::specializationKind):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

dfg/DFGOSRExitPreparation.cpp:

(JSC::DFG::prepareCodeOriginForOSRExit):

runtime/Arguments.h:

(JSC::Arguments::finishCreation):

7:05 PM Changeset in webkit [169004] by akling@apple.com

2 edits in trunk/Source/WebCore

We shouldn't make a ScrollingThread on iOS.
<https://webkit.org/b/133038>
<rdar://problem/16947589>

Don't call ScrollingThred::dispatch() from the pressure relief
code on iOS since that will end up instantiating a scrolling thread
which we'd otherwise never have.

Reviewed by Sam Weinig.

platform/MemoryPressureHandler.cpp:

(WebCore::MemoryPressureHandler::releaseMemory):

6:43 PM Changeset in webkit [169003] by jaepark@webkit.org

4 edits in trunk/Source/WebKit2

[EFL] Remove m_contentPosition from PageViewportControllerClientEfl
https://bugs.webkit.org/show_bug.cgi?id=132774

Reviewed by Anders Carlsson.

m_contentPosition is not used anywhere. So, this patch removes
m_contentPosition and reduces one unnecessary assignment in
setViewportPosition. Also, it renames contentsPoint to contentsPosition.

UIProcess/PageViewportControllerClient.h:
UIProcess/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::setViewportPosition):

UIProcess/efl/PageViewportControllerClientEfl.h:

5:40 PM Changeset in webkit [169002] by Alan Bujtas

10 edits in trunk

Subpixel rendering: Add subpixelCSSOMElementMetricsEnabled to WK1 WebPreferences.
https://bugs.webkit.org/show_bug.cgi?id=133029

Reviewed by Simon Fraser.

Source/WebKit/mac:
To match the WK2 preferences API.

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences subpixelCSSOMElementMetricsEnabled]):
(-[WebPreferences setSubpixelCSSOMElementMetricsEnabled:]):

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Tools:
Added a menu item to toggle subpixelCSSOMElementMetricsEnabled's value. However
toggling it on a WK2 window needs restart.
Adding dynamic toggle to WK2 requires a WebPreferences SPI. It's not worth cluttering
the WebPreferences just to support this temporary toggle.

MiniBrowser/mac/BrowserWindowController.h:
MiniBrowser/mac/MainMenu.xib:
MiniBrowser/mac/WK1BrowserWindowController.m:

(-[WK1BrowserWindowController validateMenuItem:]):
(-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
(-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):

MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController validateMenuItem:]):
(-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
(-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):

5:38 PM Changeset in webkit [169001] by ddkilzer@apple.com

3 edits in trunk/Source/WebKit2

Need a way to get a WKPageRef from a WKWebView
<http://webkit.org/b/133015>

Reviewed by Benjamin Poulain.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _pageRef]): Added.

UIProcess/API/Cocoa/WKWebViewPrivate.h:

(-[WKWebView _pageRef]): Added declaration.

4:24 PM Changeset in webkit [169000] by andersca@apple.com

3 edits in trunk/Source/WebKit2

Give user scripts custom URLs
https://bugs.webkit.org/show_bug.cgi?id=133035

Reviewed by Beth Dakin.

UIProcess/API/Cocoa/WKUserContentController.mm:

(-[WKUserContentController addUserScript:]):
Create a user-script:<number> URL for user scripts.

UIProcess/API/Cocoa/WKUserScript.h:

Move the init method after the properties.

3:31 PM Changeset in webkit [168999] by andersca@apple.com

16 edits in trunk

Replace WKContextSetDatabaseDirectory with two WKContextConfiguration parameters
https://bugs.webkit.org/show_bug.cgi?id=133033
<rdar://problem/16830143>

Reviewed by Sam Weinig.

Source/WebKit2:

Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

Shared/WebProcessCreationParameters.h:

Rename databaseDirectory to webSQLDatabaseDirectory to better indicate the directory type.

UIProcess/API/C/WKContext.cpp:

(WKContextSetDatabaseDirectory): Deleted.
This is no longer needed.

UIProcess/API/C/WKContextConfigurationRef.cpp:

(WKContextConfigurationCopyIndexedDBDatabaseDirectory):
(WKContextConfigurationSetIndexedDBDatabaseDirectory):
(WKContextConfigurationCopyWebSQLDatabaseDirectory):
(WKContextConfigurationSetWebSQLDatabaseDirectory):

UIProcess/API/C/WKContextConfigurationRef.h:

Add setters and getters.

UIProcess/API/C/WKContextPrivate.h:

Remove WKContextSetDatabaseDirectory.

UIProcess/APIContextConfiguration.cpp:

(API::ContextConfiguration::webContextConfiguration):
Set m_indexedDBDatabaseDirectory and m_webSQLDatabaseDirectory on the configuration.

UIProcess/APIContextConfiguration.h:

(API::ContextConfiguration::indexedDBDatabaseDirectory):
(API::ContextConfiguration::setIndexedDBDatabaseDirectory):
(API::ContextConfiguration::webSQLDatabaseDirectory):
(API::ContextConfiguration::setWebSQLDatabaseDirectory):
Add getters and setters to the C++ part of WKContextConfigurationRef.

UIProcess/WebContext.cpp:

(WebKit::WebContext::applyPlatformSpecificConfigurationDefaults):
Set webSQLDatabaseDirectory and indexedDBDatabaseDirectory.

(WebKit::WebContext::WebContext):
Initialize m_webSQLDatabaseDirectory and m_indexedDBDatabaseDirectory.

(WebKit::WebContext::ensureDatabaseProcess):
Set parameters.indexedDatabaseDirectory from m_indexedDBDatabaseDirectory.

(WebKit::WebContext::createNewWebProcess):
Set parameters.webSQLDatabaseDirectory from m_webSQLDatabaseDirectory.

UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformDefaultWebSQLDatabaseDirectory):
Rename this to indicate that it's about WebSQL databases.

(WebKit::WebContext::platformDefaultIndexedDBDatabaseDirectory):
Add this.

WebProcess/WebCoreSupport/WebDatabaseManager.cpp:

(WebKit::WebDatabaseManager::initialize):
Update for WebProcessCreationParameters rename.

WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):
Update for WebProcessCreationParameters rename.

Tools:
Set up the WebSQL and IndexedDB directories.

WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

2:49 PM Changeset in webkit [168998] by Brent Fulgham

2 edits in trunk/Source/WebKit2

[Phone Number Detection] drop-down menu in the phone number detection box doesn't appear.
https://bugs.webkit.org/show_bug.cgi?id=133024

Reviewed by Sam Weinig.

WebProcess/WebPage/mac/TelephoneNumberOverlayControllerMac.mm:

(WebKit::TelephoneNumberOverlayController::drawRect): Don't clear the set of found phone numbers each
time we call drawRect. This gets called ~9 times per screen refresh, so end up with no active
phone numbers to interact with.

2:42 PM Changeset in webkit [168997] by ap@apple.com

2 edits in trunk/Source/WebKit2

NetworkProcess can repeatedly crash handling Blob messages after any unrelated crash
https://bugs.webkit.org/show_bug.cgi?id=133032
<rdar://problem/16951630>

Reviewed by Geoffrey Garen.

Replaced assertions with runtime checks. This can happen if NetworkProcess previously
crashed for any unrelated reason.

NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:

(WebKit::NetworkBlobRegistry::registerBlobURL):
(WebKit::NetworkBlobRegistry::registerBlobURLForSlice):
(WebKit::NetworkBlobRegistry::unregisterBlobURL):

2:36 PM Changeset in webkit [168996] by commit-queue@webkit.org

4 edits
2 adds in trunk

Setting playback rate on video with media controller is not ignored.
https://bugs.webkit.org/show_bug.cgi?id=129048

Patch by Piotr Grad <p.grad@samsung.com> on 2014-05-17
Reviewed by Jer Noble.

Source/WebCore:
Replaced queries for m_playbackRate with effectivePlaybackRate()
which includes media controller playback rate.

Test: media/video-controller-child-rate.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

html/HTMLMediaElement.h:

LayoutTests:

media/video-controller-child-rate-expected.txt: Added.
media/video-controller-child-rate.html: Added.

1:14 PM Changeset in webkit [168995] by andersca@apple.com

2 edits in trunk/Source/WebKit2

-[WKWebView dealloc] should close the page
https://bugs.webkit.org/show_bug.cgi?id=133031
<rdar://problem/16929815>

Reviewed by Simon Fraser.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView dealloc]):

12:57 PM Changeset in webkit [168994] by andersca@apple.com

27 edits
6 copies
5 adds in trunk/Source

Expose WKUserScript as API
https://bugs.webkit.org/show_bug.cgi?id=133017
<rdar://problem/16948059>

Reviewed by Sam Weinig.

Source/WebCore:

WebCore.exp.in:

Export symbols.

WebCore.xcodeproj/project.pbxproj:

Change UserContentController.h to be a private header.

page/Page.cpp:

(WebCore::Page::Page):
Set m_userContentController from the page configuration and add it if it's not null.

page/Page.h:

Add UserContentController to PageClients.

page/PageGroup.cpp:

(WebCore::PageGroup::addPage):
Only try to add a user content controller if the page doesn't already have one.

(WebCore::PageGroup::removePage):
Only try to remove the user content controller if it's the group one.

Source/WebKit2:

DerivedSources.make:

Add WebUserContentController.

Shared/API/Cocoa/WebKit.h:

Add WKUserScript.h

Shared/API/c/WKSharedAPICast.h:

(WebKit::toUserScriptInjectionTime):
Update for WKUserScriptInjectionTime -> _WKUserScriptInjectionTime rename.

Shared/API/c/WKUserScriptInjectionTime.h:

Rename WKUserScriptInjectionTime to _WKUserScriptInjectionTime to free up the name for the Objective-C API

Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
Encode the user content controller ID.

(WebKit::WebPageCreationParameters::decode):
Decode the user content controller ID.

Shared/WebPageCreationParameters.h:

Add userContentControllerID.

UIProcess/API/C/WKPageGroup.cpp:

(WKPageGroupAddUserScript):
Update for WKUserScriptInjectionTime -> _WKUserScriptInjectionTime rename.

UIProcess/API/C/WKPageGroup.h:

Update for WKUserScriptInjectionTime -> _WKUserScriptInjectionTime rename.

UIProcess/API/Cocoa/WKBrowsingContextGroup.h:

Update for WKUserScriptInjectionTime -> _WKUserScriptInjectionTime rename.

UIProcess/API/Cocoa/WKBrowsingContextGroup.mm:

(-[WKBrowsingContextGroup addUserScript:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:injectionTime:mainFrameOnly:]):
Update for WKUserScriptInjectionTime -> _WKUserScriptInjectionTime rename.

UIProcess/API/Cocoa/WKUserContentController.h:

Add new methods.

UIProcess/API/Cocoa/WKUserContentController.mm:

(-[WKUserContentController init]):
Create the WebUserContentControllerProxy object and user scripts array.

(-[WKUserContentController userScripts]):
Return the user scripts array.

(toWebCoreUserScriptInjectionTime):
Helper for converting from a WKUserScriptInjectionTime enum to WebCore::UserScriptInjectionTime.

(-[WKUserContentController addUserScript:]):
Call through to the _userContentControllerProxy object.

(-[WKUserContentController removeAllUserScripts]):
Call through to the _userContentControllerProxy object.

UIProcess/API/Cocoa/WKUserContentControllerInternal.h: Added.

Add WebUserContentControllerProxy ivar.

UIProcess/API/Cocoa/WKUserScript.h: Added.

Add new header.

UIProcess/API/Cocoa/WKUserScript.mm:

(-[WKUserScript initWithSource:injectionTime:forMainFrameOnly:]):
Initialize the WKUserScript object.

(-[WKUserScript source]):
(-[WKUserScript injectionTime]):
(-[WKUserScript isForMainFrameOnly]):
Add getters.

(-[WKUserScript copyWithZone:]):
Since WKUserScript is immutable, just return a retained object.

UIProcess/API/Cocoa/WKUserScriptInternal.h:

Add ivars.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):
Set the user content controller from the configuration.

UIProcess/UserContent/WebUserContentControllerProxy.cpp: Added.

(WebKit::generateIdentifier):
Return a unique identifier.

(WebKit::WebUserContentControllerProxy::create):
Return a new WebUserContentControllerProxy object.

(WebKit::WebUserContentControllerProxy::WebUserContentControllerProxy):
Initialize m_identifier.

(WebKit::WebUserContentControllerProxy::~WebUserContentControllerProxy):
Add destructor.

(WebKit::WebUserContentControllerProxy::addProcess):
Add the process to the m_processes set. If it's the first time doing so, add the user scripts we know about.

(WebKit::WebUserContentControllerProxy::removeProcess):
Remove the process from m_processes.

(WebKit::WebUserContentControllerProxy::addUserScript):
Add the user script and let all the web processes know that it was added.

(WebKit::WebUserContentControllerProxy::removeAllUserScripts):
Remove all user scripts and tell all the web processes about it.

UIProcess/UserContent/WebUserContentControllerProxy.h:

Add new class.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
If the process is already running, add it to the user content controller.

(WebKit::WebPageProxy::close):
If the process is running, remove it from the user content controller.

(WebKit::WebPageProxy::connectionWillOpen):
Add the process to the user content controller.

(WebKit::WebPageProxy::resetStateAfterProcessExited):
Remove the process from the user content controller.

(WebKit::WebPageProxy::creationParameters):
Pass along the user content controller ID when creating the web page.

UIProcess/WebPageProxy.h:

Add a WebUserContentControllerProxy object to the web page configuration.

WebKit2.xcodeproj/project.pbxproj:

Add new files.

WebProcess/InjectedBundle/API/c/WKBundle.cpp:
WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:

Update for WKUserScriptInjectionTime -> _WKUserScriptInjectionTime rename.

WebProcess/UserContent/WebUserContentController.cpp: Added.

New class that manages a WebCore::UserContentController object.

(WebKit::WebUserContentController::getOrCreate):
Look up (or create) a WebUserContentController object given its identifier.

(WebKit::WebUserContentController::WebUserContentController):
Add ourselves as a message receiver.

(WebKit::WebUserContentController::~WebUserContentController):
Remove ourselves as a message receiver.

(WebKit::WebUserContentController::addUserScripts):
Add all passed in user scripts to the WebCore user content controller object.

(WebKit::WebUserContentController::removeAllUserScripts):
Remove all user scripts from the WebCore user content controller object.

WebProcess/UserContent/WebUserContentController.messages.in: Added.

Add new messages file.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
Get a WebUserContentController object and pass it along to WebCore.

WebProcess/WebPage/WebPage.h:

Add WebUserContentController member.

3:08 AM Changeset in webkit [168993] by akling@apple.com

7 edits in trunk/Source/WebCore

REGRESSION (r166422): All RenderBox objects grew 104 bytes from adding repaint timers.
<https://webkit.org/b/133027>
<rdar://problem/16867410>

Instead of storing a rarely-used repaint timer on every RenderBox, store one
on the RenderView, and keep a hash set of renderers needing repaint.

Renderers get a flag tracking whether they have a pending lazy repaint.
This way we can avoid hash lookups in the common case.

Also added a static assertion to catch RenderBox growing in the future.

Reviewed by Antti Koivisto.

rendering/RenderBox.cpp:

(WebCore::SameSizeAsRenderBox::~SameSizeAsRenderBox):
(WebCore::RenderBox::RenderBox):
(WebCore::RenderBox::~RenderBox):
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::layoutOverflowRectForPropagation):

rendering/RenderBox.h:
rendering/RenderElement.cpp:

(WebCore::RenderElement::RenderElement):

rendering/RenderElement.h:

(WebCore::RenderElement::setRenderBoxNeedsLazyRepaint):
(WebCore::RenderElement::renderBoxNeedsLazyRepaint):

rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::RenderView::scheduleLazyRepaint):
(WebCore::RenderView::unscheduleLazyRepaint):
(WebCore::RenderView::lazyRepaintTimerFired):

rendering/RenderView.h:

May 16, 2014:

11:23 PM Changeset in webkit [168992] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/efl

[EFL] Build break after 168978.
https://bugs.webkit.org/show_bug.cgi?id=133012.

Patch by Piotr Grad <p.grad@samsung.com> on 2014-05-16
Reviewed by Simon Fraser.

ewk/ewk_view.cpp:

(_ewk_view_priv_new):

10:41 PM Changeset in webkit [168991] by jer.noble@apple.com

4 edits in trunk/Source/WebCore

[Mac][MSE] setCurrentTime() goes down fastSeek path in MediaPlayerPrivateMediaSourceAVFObjC.
https://bugs.webkit.org/show_bug.cgi?id=133023

Reviewed by Eric Carlson.

When seeking a MSE video, do not go down the fastSeekForMediaTime() path if the
seek resulted from a setCurrentTime() call. The logic can lead to attempted seeks
before buffered ranges.

platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal):

platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h:
platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:

(WebCore::MediaSourcePrivateAVFObjC::seekToTime):

7:11 PM Changeset in webkit [168990] by matthew_hanson@apple.com

5 edits in branches/safari-538.34-branch/Source

Versioning

6:42 PM Changeset in webkit [168989] by matthew_hanson@apple.com

1 copy in tags/Safari-538.34.41

Create Safari-538.34.41 tag.

6:30 PM Changeset in webkit [168988] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[GTK] Build break after 168978.
https://bugs.webkit.org/show_bug.cgi?id=133012.

Patch by Piotr Grad <p.grad@samsung.com> on 2014-05-16
Reviewed by Simon Fraser.

UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsConstructed):

6:18 PM Changeset in webkit [168987] by Simon Fraser

2 edits in trunk/LayoutTests

Fix a straggler.

Remove call to internals.settings.setRegionBasedColumnsEnabled(true).

fast/repaint/spanner-with-margin.html:

5:29 PM Changeset in webkit [168986] by Simon Fraser

2 edits in trunk/Source/WebKit2

Put back a symbol removed in r168978 that Safari needs, but deprecate it.

Reviewed by Anders Carlsson.

Shared/API/c/WKDeprecatedFunctions.cpp:

(WKPreferencesSetRegionBasedColumnsEnabled):
(WKPreferencesGetRegionBasedColumnsEnabled):

5:06 PM Changeset in webkit [168985] by Simon Fraser

269 edits in trunk/LayoutTests

Remove calls to internals.settings.setRegionBasedColumnsEnabled(true);
in tests.

Some of these tests may now be no-ops, but I haven't found a convenient
way to know which ones.

fast/multicol/break-in-columns-before-spanner-expected.html:
fast/multicol/break-in-columns-before-spanner.html:
fast/multicol/break-in-scrollable-expected.html:
fast/multicol/break-in-scrollable.html:
fast/multicol/client-rects-spanners-complex.html:
fast/multicol/client-rects-spanners.html:
fast/multicol/inline-children-crash.html:
fast/multicol/mixed-opacity-fixed-test.html:
fast/multicol/mixed-opacity-test.html:
fast/multicol/mixed-positioning-stacking-order.html:
fast/multicol/multicol-li-crash.html:
fast/multicol/newmulticol/adjacent-spanners.html:
fast/multicol/newmulticol/avoid-column-break-inside.html:
fast/multicol/newmulticol/balance-images.html:
fast/multicol/newmulticol/balance-maxheight1.html:
fast/multicol/newmulticol/balance-maxheight2.html:
fast/multicol/newmulticol/balance1.html:
fast/multicol/newmulticol/balance10.html:
fast/multicol/newmulticol/balance2.html:
fast/multicol/newmulticol/balance3.html:
fast/multicol/newmulticol/balance4.html:
fast/multicol/newmulticol/balance5.html:
fast/multicol/newmulticol/balance6.html:
fast/multicol/newmulticol/balance7.html:
fast/multicol/newmulticol/balance8.html:
fast/multicol/newmulticol/balance9.html:
fast/multicol/newmulticol/block-becomes-spanner-expected.html:
fast/multicol/newmulticol/block-becomes-spanner.html:
fast/multicol/newmulticol/break-after-expected.html:
fast/multicol/newmulticol/break-after.html:
fast/multicol/newmulticol/break-before.html:
fast/multicol/newmulticol/breaks-2-columns-3-no-balancing.html:
fast/multicol/newmulticol/breaks-2-columns-3.html:
fast/multicol/newmulticol/breaks-3-columns-3.html:
fast/multicol/newmulticol/cell-shrinkback.html:
fast/multicol/newmulticol/change-spanner-display-expected.html:
fast/multicol/newmulticol/change-spanner-display.html:
fast/multicol/newmulticol/change-spanner-parent-display-expected.html:
fast/multicol/newmulticol/change-spanner-parent-display.html:
fast/multicol/newmulticol/client-rects.html:
fast/multicol/newmulticol/clipping-expected.html:
fast/multicol/newmulticol/clipping-overflow-hidden-expected.html:
fast/multicol/newmulticol/clipping-overflow-hidden.html:
fast/multicol/newmulticol/clipping-top-overflow-expected.html:
fast/multicol/newmulticol/clipping-top-overflow.html:
fast/multicol/newmulticol/clipping.html:
fast/multicol/newmulticol/column-rules-fixed-height.html:
fast/multicol/newmulticol/columns-shorthand-parsing.html:
fast/multicol/newmulticol/compare-with-old-impl/BottomToTop-tb.html:
fast/multicol/newmulticol/compare-with-old-impl/LeftToRight-tb.html:
fast/multicol/newmulticol/compare-with-old-impl/anonymous-block-split-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/before-child-anonymous-column-block.html:
fast/multicol/newmulticol/compare-with-old-impl/clone-before-after-content-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/clone-block-children-inline-mismatch-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/clone-flexbox.html:
fast/multicol/newmulticol/compare-with-old-impl/clone-summary.html:
fast/multicol/newmulticol/compare-with-old-impl/column-rules-stacking.html:
fast/multicol/newmulticol/compare-with-old-impl/column-span-inside-multicol-webkit-box.html:
fast/multicol/newmulticol/compare-with-old-impl/continuation-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/double-merge-anonymous-block-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/empty-anonymous-block-split-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/float-not-removed-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/hit-test-above-or-below.html:
fast/multicol/newmulticol/compare-with-old-impl/hit-test-block-axis-flipped.html:
fast/multicol/newmulticol/compare-with-old-impl/hit-test-end-of-column-with-line-height.html:
fast/multicol/newmulticol/compare-with-old-impl/hit-test-end-of-column.html:
fast/multicol/newmulticol/compare-with-old-impl/hit-test-float.html:
fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-between-pages-flipped.html:
fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-between-pages.html:
fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-block-axis.html:
fast/multicol/newmulticol/compare-with-old-impl/list-multi-column-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/multicol-with-child-renderLayer-for-input-expected.html:
fast/multicol/newmulticol/compare-with-old-impl/multicol-with-child-renderLayer-for-input.html:
fast/multicol/newmulticol/compare-with-old-impl/overflow-content.html:
fast/multicol/newmulticol/compare-with-old-impl/positioned-child-not-removed-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/positioned-objects-not-removed-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/recursive-split-flow-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/removal-of-multicol-span-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/remove-child-split-flow-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/runin-continuation-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/shrink-to-column-height-for-pagination.html:
fast/multicol/newmulticol/compare-with-old-impl/span-as-nested-inline-block-child.html:
fast/multicol/newmulticol/compare-with-old-impl/split-flow-anonymous-wrapper-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/split-inline-wrong-post-block-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/table-multi-column-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/textbox-not-removed-crash.html:
fast/multicol/newmulticol/compare-with-old-impl/update-after-content-before-child-crash.html:
fast/multicol/newmulticol/direct-child-column-span-all.html:
fast/multicol/newmulticol/fixed-height-fill-auto-expected.html:
fast/multicol/newmulticol/fixed-height-fill-auto.html:
fast/multicol/newmulticol/fixed-height-fill-balance-2.html:
fast/multicol/newmulticol/fixed-height-fill-balance-expected.html:
fast/multicol/newmulticol/fixed-height-fill-balance.html:
fast/multicol/newmulticol/float-avoidance.html:
fast/multicol/newmulticol/float-multicol.html:
fast/multicol/newmulticol/float-paginate-complex.html:
fast/multicol/newmulticol/float-paginate-empty-lines.html:
fast/multicol/newmulticol/float-paginate.html:
fast/multicol/newmulticol/hide-box-horizontal-bt-expected.html:
fast/multicol/newmulticol/hide-box-horizontal-bt.html:
fast/multicol/newmulticol/hide-box-vertical-lr-expected.html:
fast/multicol/newmulticol/hide-box-vertical-lr.html:
fast/multicol/newmulticol/hide-box-vertical-rl-expected.html:
fast/multicol/newmulticol/hide-box-vertical-rl.html:
fast/multicol/newmulticol/insert-row-content1-expected.html:
fast/multicol/newmulticol/insert-row-content1.html:
fast/multicol/newmulticol/insert-row-content2-expected.html:
fast/multicol/newmulticol/insert-row-content2.html:
fast/multicol/newmulticol/insert-row-content3-expected.html:
fast/multicol/newmulticol/insert-row-content3.html:
fast/multicol/newmulticol/insert-row-content4-expected.html:
fast/multicol/newmulticol/insert-row-content4.html:
fast/multicol/newmulticol/insert-row-content5-expected.html:
fast/multicol/newmulticol/insert-row-content5.html:
fast/multicol/newmulticol/insert-row-content6-expected.html:
fast/multicol/newmulticol/insert-row-content6.html:
fast/multicol/newmulticol/insert-row-content7-expected.html:
fast/multicol/newmulticol/insert-row-content7.html:
fast/multicol/newmulticol/insert-row-content8-expected.html:
fast/multicol/newmulticol/insert-row-content8.html:
fast/multicol/newmulticol/insert-row-content9-expected.html:
fast/multicol/newmulticol/insert-row-content9.html:
fast/multicol/newmulticol/insert-spanner-child1-expected.html:
fast/multicol/newmulticol/insert-spanner-child1.html:
fast/multicol/newmulticol/insert-spanner-child2-expected.html:
fast/multicol/newmulticol/insert-spanner-child2.html:
fast/multicol/newmulticol/insert-spanner-child3-expected.html:
fast/multicol/newmulticol/insert-spanner-child3.html:
fast/multicol/newmulticol/insert-spanner1-expected.html:
fast/multicol/newmulticol/insert-spanner1.html:
fast/multicol/newmulticol/insert-spanner2-expected.html:
fast/multicol/newmulticol/insert-spanner2.html:
fast/multicol/newmulticol/insert-spanner3-expected.html:
fast/multicol/newmulticol/insert-spanner3.html:
fast/multicol/newmulticol/insert-spanner4-expected.html:
fast/multicol/newmulticol/insert-spanner4.html:
fast/multicol/newmulticol/insert-spanner5-expected.html:
fast/multicol/newmulticol/insert-spanner5.html:
fast/multicol/newmulticol/insert-spanner6-expected.html:
fast/multicol/newmulticol/insert-spanner6.html:
fast/multicol/newmulticol/insert-spanner7-expected.html:
fast/multicol/newmulticol/insert-spanner7.html:
fast/multicol/newmulticol/insert-spanner8-expected.html:
fast/multicol/newmulticol/insert-spanner8.html:
fast/multicol/newmulticol/layers-in-multicol.html:
fast/multicol/newmulticol/layers-split-across-columns.html:
fast/multicol/newmulticol/leading-and-trailing-margin-expected.html:
fast/multicol/newmulticol/leading-and-trailing-margin.html:
fast/multicol/newmulticol/leading-margin.html:
fast/multicol/newmulticol/line-grid-inside-columns.html:
fast/multicol/newmulticol/line-grid-into-columns.html:
fast/multicol/newmulticol/multicol-with-spanner-becomes-regular-block.html:
fast/multicol/newmulticol/orphans-and-widows-balance.html:
fast/multicol/newmulticol/positioned-split.html:
fast/multicol/newmulticol/positioned-with-constrained-height.html:
fast/multicol/newmulticol/progression-reverse-overflow.html:
fast/multicol/newmulticol/progression-reverse.html:
fast/multicol/newmulticol/remove-row-content1-expected.html:
fast/multicol/newmulticol/remove-row-content1.html:
fast/multicol/newmulticol/remove-row-content2-expected.html:
fast/multicol/newmulticol/remove-row-content2.html:
fast/multicol/newmulticol/remove-row-content3-expected.html:
fast/multicol/newmulticol/remove-row-content3.html:
fast/multicol/newmulticol/remove-row-content4-expected.html:
fast/multicol/newmulticol/remove-row-content4.html:
fast/multicol/newmulticol/remove-row-content5-expected.html:
fast/multicol/newmulticol/remove-row-content5.html:
fast/multicol/newmulticol/remove-row-content6-expected.html:
fast/multicol/newmulticol/remove-row-content6.html:
fast/multicol/newmulticol/remove-row-content7-expected.html:
fast/multicol/newmulticol/remove-row-content7.html:
fast/multicol/newmulticol/remove-row-content8-expected.html:
fast/multicol/newmulticol/remove-row-content8.html:
fast/multicol/newmulticol/remove-row-content9-expected.html:
fast/multicol/newmulticol/remove-row-content9.html:
fast/multicol/newmulticol/remove-spanner1-expected.html:
fast/multicol/newmulticol/remove-spanner1.html:
fast/multicol/newmulticol/remove-spanner2-expected.html:
fast/multicol/newmulticol/remove-spanner2.html:
fast/multicol/newmulticol/remove-spanner3-expected.html:
fast/multicol/newmulticol/remove-spanner3.html:
fast/multicol/newmulticol/remove-spanner4-expected.html:
fast/multicol/newmulticol/remove-spanner4.html:
fast/multicol/newmulticol/remove-spanner5-expected.html:
fast/multicol/newmulticol/remove-spanner5.html:
fast/multicol/newmulticol/remove-spanner6-expected.html:
fast/multicol/newmulticol/remove-spanner6.html:
fast/multicol/newmulticol/single-line.html:
fast/multicol/newmulticol/sole-spanner.html:
fast/multicol/newmulticol/span-between-text-expected.html:
fast/multicol/newmulticol/span-between-text.html:
fast/multicol/newmulticol/spanner-becomes-regular-block-expected.html:
fast/multicol/newmulticol/spanner-becomes-regular-block.html:
fast/multicol/newmulticol/spanner-first-expected.html:
fast/multicol/newmulticol/spanner-first.html:
fast/multicol/newmulticol/spanner-img-expected.html:
fast/multicol/newmulticol/spanner-img.html:
fast/multicol/newmulticol/spanner-inline-block-expected.html:
fast/multicol/newmulticol/spanner-inline-block.html:
fast/multicol/newmulticol/spanner-last-expected.html:
fast/multicol/newmulticol/spanner-last.html:
fast/multicol/newmulticol/spanner-nested-dynamic-expected.html:
fast/multicol/newmulticol/spanner-nested-dynamic.html:
fast/multicol/newmulticol/spanner-nested-expected.html:
fast/multicol/newmulticol/spanner-nested.html:
fast/multicol/newmulticol/spanner-pseudo-after1-expected.html:
fast/multicol/newmulticol/spanner-pseudo-after1.html:
fast/multicol/newmulticol/spanner-pseudo-after2-expected.html:
fast/multicol/newmulticol/spanner-pseudo-after2.html:
fast/multicol/newmulticol/spanner-pseudo-after3-expected.html:
fast/multicol/newmulticol/spanner-pseudo-after3.html:
fast/multicol/newmulticol/spanner-pseudo-after4-expected.html:
fast/multicol/newmulticol/spanner-pseudo-after4.html:
fast/multicol/newmulticol/spanner-pseudo-before-after1-expected.html:
fast/multicol/newmulticol/spanner-pseudo-before-after1.html:
fast/multicol/newmulticol/spanner-pseudo-before-after2-expected.html:
fast/multicol/newmulticol/spanner-pseudo-before-after2.html:
fast/multicol/newmulticol/spanner-pseudo-before-after3-expected.html:
fast/multicol/newmulticol/spanner-pseudo-before-after3.html:
fast/multicol/newmulticol/spanner-pseudo-before-after4-expected.html:
fast/multicol/newmulticol/spanner-pseudo-before-after4.html:
fast/multicol/newmulticol/spanner-pseudo-before1-expected.html:
fast/multicol/newmulticol/spanner-pseudo-before1.html:
fast/multicol/newmulticol/spanner-pseudo-before2-expected.html:
fast/multicol/newmulticol/spanner-pseudo-before2.html:
fast/multicol/newmulticol/spanner-pseudo-before3-expected.html:
fast/multicol/newmulticol/spanner-pseudo-before3.html:
fast/multicol/newmulticol/spanner-pseudo-before4-expected.html:
fast/multicol/newmulticol/spanner-pseudo-before4.html:
fast/multicol/newmulticol/spanner-table-expected.html:
fast/multicol/newmulticol/spanner-table.html:
fast/multicol/newmulticol/spanner-with-margin-expected.html:
fast/multicol/newmulticol/spanner-with-margin.html:
fast/multicol/newmulticol/spanner1-expected.html:
fast/multicol/newmulticol/spanner1.html:
fast/multicol/newmulticol/spanner2-expected.html:
fast/multicol/newmulticol/spanner2.html:
fast/multicol/newmulticol/spanner3-expected.html:
fast/multicol/newmulticol/spanner3.html:
fast/multicol/newmulticol/spanner4-expected.html:
fast/multicol/newmulticol/spanner4.html:
fast/multicol/newmulticol/spanner5-expected.html:
fast/multicol/newmulticol/spanner5.html:
fast/multicol/newmulticol/spanner6-expected.html:
fast/multicol/newmulticol/spanner6.html:
fast/multicol/newmulticol/spanner7-expected.html:
fast/multicol/newmulticol/spanner7.html:
fast/multicol/newmulticol/spanner8-expected.html:
fast/multicol/newmulticol/spanner8.html:
fast/multicol/newmulticol/spanner9-expected.html:
fast/multicol/newmulticol/spanner9.html:
fast/multicol/newmulticol/trailing-margin-with-spanner-expected.html:
fast/multicol/newmulticol/trailing-margin-with-spanner.html:
fast/multicol/newmulticol/trailing-margin-with-spanner2-expected.html:
fast/multicol/newmulticol/trailing-margin-with-spanner2.html:
fast/multicol/newmulticol/unresolvable-percent-height-2.html:
fast/multicol/newmulticol/unresolvable-percent-height.html:
fast/multicol/newmulticol/unresolvable-percent-max-height-2.html:
fast/multicol/newmulticol/unresolvable-percent-max-height.html:
fast/multicol/offset-top-left.html:
fast/multicol/percent-height.html:
fast/multicol/positioned-outside-of-columns.html:
fast/multicol/scrolling-column-rules.html:
fast/multicol/tall-float-expected.html:
fast/multicol/tall-float.html:
fast/multicol/transform-inside-opacity.html:
fast/multicol/zoom-test-expected.html:
fast/multicol/zoom-test.html:

4:28 PM Changeset in webkit [168984] by oliver@apple.com

9 edits in trunk/Source/WebKit2

Separate enabling sandbox extensions from the WEB_PROCESS_SANDBOX flag
https://bugs.webkit.org/show_bug.cgi?id=133016

Reviewed by Alexey Proskuryakov.

Add a distinct SANDBOX_EXTENSIONS flag to guard sandbox extensions
and switch over to it in the places that extensions are used.

Shared/SandboxExtension.h:
Shared/mac/SandboxExtensionMac.mm:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChooseFilesForOpenPanel):

WebKit2Prefix.h:
WebProcess/WebPage/WebPage.cpp:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

3:09 PM Changeset in webkit [168983] by msaboff@apple.com

4 edits
1 add in trunk/Source/JavaScriptCore

Crash in JSC::Yarr::YarrGenerator<(JSC::Yarr::YarrJITCompileMode)0>::generatePatternCharacterFixed() due to WTF::CrashOnOverflow::overflowed + 9
https://bugs.webkit.org/show_bug.cgi?id=133009

Reviewed by Oliver Hunt.

If we determine that any alternative requires a minumum match size greater than
INT_MAX, we handle the match in the interpreter.

Check to see if the pattern has unsigned lengths before invoking YARR JIT.

runtime/RegExp.cpp:

(JSC::RegExp::compile):
(JSC::RegExp::compileMatchOnly):

tests/stress/large-regexp.js: New test added.

Set m_containsUnsignedLengthPattern flag if any alternative's minimum length
doesn't fit in an int.

yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::setupDisjunctionOffsets):

Clear new m_containsUnsignedLengthPattern flag.

yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPattern::YarrPattern):

yarr/YarrPattern.h:

(JSC::Yarr::YarrPattern::reset):
(JSC::Yarr::YarrPattern::containsUnsignedLengthPattern):

2:55 PM Changeset in webkit [168982] by benjamin@webkit.org

2 edits in trunk/Source/WebKit2

[iOS][WK2] Add a heuristic to set the right horizontal offset on rotation for responsive websites
https://bugs.webkit.org/show_bug.cgi?id=132937
<rdar://problem/16710097>

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-05-16
Reviewed by Simon Fraser.

When responsive websites have the content size lay out larger than the minimal layout size,
we should not keep the relative horizontal position into view,
many of those websites have all the content on the left.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::dynamicViewportSizeUpdate):

2:47 PM Changeset in webkit [168981] by benjamin@webkit.org

2 edits in trunk/Source/WebKit2

[iOS][WK2] On dynamic resize, the content offset is contrained to the old content size
https://bugs.webkit.org/show_bug.cgi?id=132972

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-05-16
Reviewed by Simon Fraser.

When we set the content offset, UIScrollView limits the value to the current valid range for
content size. Since the content size was only updated after the animation, when the first frame
comes in, the content offset would sometimes be limited to a smaller rect that the actual content.

To fix this, set the expected future content size before changing the offset.

During the animation, the content size could have changed arbitrarily. At the end of the animation,
we take the actual frame and set the definite content size.
Any update after that will be regular updates through didCommitLayer.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _beginAnimatedResizeWithUpdates:]):
(-[WKWebView _endAnimatedResize]):

2:39 PM Changeset in webkit [168980] by benjamin@webkit.org

2 edits in trunk/Source/WebCore

[iOS] ScrollView::visibleContentRectInternal is bypassing the iOS code for unobscuredContentRect
https://bugs.webkit.org/show_bug.cgi?id=133008

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-05-16
Reviewed by Simon Fraser.

platform/ScrollView.cpp:

(WebCore::ScrollView::visibleContentRectInternal):
ScrollView::visibleContentRectInternal() was calling the internal implementation of visibleContentRect().
That was skipping the iOS implementation and getting the framerect directly. That size is invalid on iOS
when the exposed rect and unobscured rect are not the same.

2:32 PM Changeset in webkit [168979] by jer.noble@apple.com

3 edits
2 adds in trunk

[Mac] naturalSize not updated when preload=metadata
https://bugs.webkit.org/show_bug.cgi?id=132994

Reviewed by Eric Carlson.

Source/WebCore:
Test: media/video-load-preload-metadata-naturalsize.html

When preload=metadata, we never create an AVPlayerItem, and therefore never receive a
presentationSize KVO. When an AVAsset informs us that its tracks have changed, and there
is no AVPlayerItem, recalculate presentation size based on the first video track's natural
size.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged):

platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal):

LayoutTests:

media/video-load-preload-metadata-naturalsize-expected.txt: Added.
media/video-load-preload-metadata-naturalsize.html: Added.

2:16 PM Changeset in webkit [168978] by Simon Fraser

12 edits in trunk/Source

Remove "region-based columns" prefs
https://bugs.webkit.org/show_bug.cgi?id=133006
<rdar://problem/16945824>

Reviewed by Dave Hyatt.

Remove "region-based columns" prefs and related code, since this is only
way to render columns now.

Source/WebCore:

page/Settings.in:

Source/WebKit/mac:

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences setRegionBasedColumnsEnabled:]): Deleted.
(-[WebPreferences regionBasedColumnsEnabled]): Deleted.

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

Shared/WebPreferencesStore.h:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetRegionBasedColumnsEnabled): Deleted.
(WKPreferencesGetRegionBasedColumnsEnabled): Deleted.

UIProcess/API/C/WKPreferencesRefPrivate.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

1:53 PM Changeset in webkit [168977] by Antti Koivisto

4 edits in trunk/Source/WebCore

Link search area for touch events is too large in some cases
https://bugs.webkit.org/show_bug.cgi?id=132988
<rdar://problem/16917843>

Reviewed by Simon Fraser.

page/ios/FrameIOS.mm:

(WebCore::Frame::qualifyingNodeAtViewportLocation):

Adjust the search area to screen ppi.
Remove cut-off at scale 1. This made us pick physically far-away elements when zoomed in.

platform/PlatformScreen.h:
platform/ios/PlatformScreenIOS.mm:

(WebCore::mobileGestaltFloatValue):
(WebCore::screenPPIFactor):

Figure out screens physical PPI relative to a base.

1:46 PM Changeset in webkit [168976] by Brent Fulgham

3 edits in trunk/Source/WebKit2

Work around bug in Silverlight
https://bugs.webkit.org/show_bug.cgi?id=133004

Reviewed by Anders Carlsson.

PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:

(WebKit::PluginProcessMainDelegate::doPreInitializationWork): Add low-resolution flag
to user defaults prior to NSApplication invocation. This code was moved from
PluginProcess::platformInitializeProcess.

PluginProcess/mac/PluginProcessMac.mm:

(WebKit::PluginProcess::platformInitializeProcess): Move low-resolution flag
setting to PluginProcessMainDelegate.

12:53 PM Changeset in webkit [168975] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Added some flaky tests to TestExpectations.

Patch by Enrique Ocaña González <eocanha@igalia.com> on 2014-05-16

platform/gtk/TestExpectations:

12:45 PM Changeset in webkit [168974] by jer.noble@apple.com

6 edits in trunk/Source/WebCore

[MSE] Crash at WebCore::SourceBuffer::~SourceBuffer + 110
https://bugs.webkit.org/show_bug.cgi?id=132973

Reviewed by Eric Carlson.

Change SourceBuffer::m_private into a Ref<>, and add an assertion to
SourceBufferPrivateAVFObjC's destructor if its client has not been cleared.

Eliminate unnecessary churn in MediaSourcePrivateAVFObjC by having the predicate
functor take bare pointers, rather than a PassRefPtr.

The underlying problem seems to be in WebAVStreamDataParserListener. RefPtrs were
being created off the main thread to a non-thread safe ref counted class. In some
situations, this would result in double decrementing the ref, which would cause an
early destruction of the underlying object. Instead replace these RefPtr strong
pointers with explicit weak ones. Ensure the parser and its delegate are not freed
before the append operation completes by passing strong pointers into the async
append operation lambda.

There were a few places where we weren't null checking m_mediaSource before using it,
and at least one place where we weren't clearing m_mediaSource.

Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::SourceBuffer): Use Ref instead of RefPtr.
(WebCore::SourceBuffer::appendBufferTimerFired): Ditto.

Modules/mediasource/SourceBuffer.h:
platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:

(WebCore::MediaSourcePrivateAVFObjCHasAudio): Take a bare pointer, instead of a PassRefPtr.
(WebCore::MediaSourcePrivateAVFObjCHasVideo): Ditto.

platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:

(WebCore::MediaSourcePrivateAVFObjC::removeSourceBuffer): Clear the back pointer when removing a buffer.

platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(-[WebAVStreamDataParserListener initWithParser:parent:WebCore::]): Use WeakPtr instead of RefPtr.
(-[WebAVStreamDataParserListener invalidate]): Ditto.
(-[WebAVStreamDataParserListener streamDataParser:didParseStreamDataAsAsset:]): Ditto.
(-[WebAVStreamDataParserListener streamDataParser:didParseStreamDataAsAsset:withDiscontinuity:]): Ditto.
(-[WebAVStreamDataParserListener streamDataParser:didFailToParseStreamDataWithError:]): Ditto.
(-[WebAVStreamDataParserListener streamDataParser:didProvideMediaData:forTrackID:mediaType:flags:]): Ditto.
(-[WebAVStreamDataParserListener streamDataParser:didReachEndOfTrackWithTrackID:mediaType:]): Ditto.
(-[WebAVStreamDataParserListener streamDataParser:didProvideContentKeyRequestInitializationData:forTrackID:]): Ditto.
(WebCore::SourceBufferPrivateAVFObjC::~SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::append): Ditto.

12:21 PM WebKitGTK/KeepingTheTreeGreen edited by eocanha@igalia.com

(diff)

12:01 PM Changeset in webkit [168973] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

[Gtk] media/media-blocked-by-beforeload.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=89811

Patch by Piotr Grad <p.grad@samsung.com> on 2014-05-16
Reviewed by Eric Carlson.

Problem is that we cannot predict when 'error' event would be called,
because is called async on 'source' element. Solution is to not log
'loadedmetadata' and 'loadstart' events.

media/media-blocked-by-beforeload-expected.txt:
media/media-blocked-by-beforeload.html:

11:47 AM Changeset in webkit [168972] by Alan Bujtas

3 edits
2 adds in trunk

Subpixel rendering: Push named flows in region to device pixel when painting.
https://bugs.webkit.org/show_bug.cgi?id=132986

Reviewed by Simon Fraser.

Remove integral rounding when named flow sets the painting offset on the graphics context.
Use device pixel snapping instead to ensure that we can paint on odd device pixel positions on retina displays.

Source/WebCore:
Test: fast/regions/hidpi-region-with-auto-margin-on-subpixel-position.html

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

LayoutTests:

fast/regions/hidpi-region-with-auto-margin-on-subpixel-position-expected.html: Added.
fast/regions/hidpi-region-with-auto-margin-on-subpixel-position.html: Added.

11:26 AM Changeset in webkit [168971] by stavila@adobe.com

3 edits in trunk/Source/WebCore

[CSS Regions] Add ASSERT to make sure using the flowThread cache does not return incorrect results
https://bugs.webkit.org/show_bug.cgi?id=132906

Reviewed by Simon Fraser.

If flowThreadContainingBlock() is called on an object which is in a different
flow thread than the one currently being laid out, this method will return an incorrect
result. I added an assertion for that to make sure we catch and treat any such scenarios.
For the moment, this assertion is only validated for regions, as multicol still has some issues.

No new tests required.

rendering/RenderObject.cpp:

(WebCore::RenderObject::locateFlowThreadContainingBlockNoCache):
(WebCore::RenderObject::locateFlowThreadContainingBlock):

rendering/RenderObject.h:

10:07 AM Changeset in webkit [168970] by mhock@apple.com

5 edits
2 adds in trunk

MemoryCache::addImageToCache should return the result of add().
https://bugs.webkit.org/show_bug.cgi?id=132928
<rdar://problem/16651547>

Reviewed by Alexey Proskuryakov.

Source/WebCore:
API test: WebKit1.MemoryCacheADdImageToCache (MemoryCacheAddImageToCacheIOS.mm)

loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::addImageToCache):

Tools:

TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Added.

(TestWebKitAPI::TEST):

9:34 AM Changeset in webkit [168969] by dfarler@apple.com

2 edits in trunk/Tools

old-run-webkit-tests: allow specifying a simulator app path
https://bugs.webkit.org/show_bug.cgi?id=132975

Reviewed by Anders Carlsson.

Scripts/old-run-webkit-tests:

(openIPhoneSimulator):
Add new --simulator-app command line parameter for specifying the
absolute path to the simulator app to launch before starting a
session.

7:35 AM Changeset in webkit [168968] by commit-queue@webkit.org

6 edits in trunk/Tools

[webkitpy] In case of multiple bug rollout, all bugs should be reopened, not only the oldest one
https://bugs.webkit.org/show_bug.cgi?id=131363

Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-05-16
Reviewed by Csaba Osztrogonác.

Scripts/webkitpy/common/checkout/checkout_mock.py:
Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:

(MockBugzilla):

Scripts/webkitpy/tool/commands/download_unittest.py:

(test_create_rollout_multiple_revision_with_one_resolved):
(test_create_rollout_multiple_resolved):
(test_rollout_two_revisions):
(test_rollout_multiple_revisions):
(test_rollout_multiple_revisions_with_a_missing_bug_id):

Scripts/webkitpy/tool/steps/createbug.py:

(CreateBug.run):

Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:

(ReopenBugAfterRollout.run):

6:22 AM Changeset in webkit [168967] by abucur@adobe.com

23 edits in trunk/Source/WebCore

[CSS Regions] Reduce the RenderRegion invasiveness in rendering code
https://bugs.webkit.org/show_bug.cgi?id=132121

Reviewed by Antti Koivisto.

Remove the RenderRegion / RenderNamedFlowFragment parameters and fields from
the painting / hit testing data structures and use a stateful approach to
correctly handle regions.

When painting or hit testing, the current flow thread is saved along the current
region. They are accessed through the |currentRenderNamedFlowFragment| helper
method on RenderObject or RenderLayer.

The patch also changes a bunch of 0s to nullptrs.

Tests: No new tests, no functional change.

html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):

rendering/HitTestLocation.cpp:

(WebCore::HitTestLocation::HitTestLocation):
(WebCore::HitTestLocation::operator=):

rendering/HitTestLocation.h:

(WebCore::HitTestLocation::region): Deleted.

rendering/HitTestResult.h:
rendering/PaintInfo.h:

(WebCore::PaintInfo::PaintInfo):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paint):
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::nodeAtPoint):

rendering/RenderBox.cpp:

(WebCore::RenderBox::nodeAtPoint):
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::pushContentsClip):

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintMaskForTextFillBox):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):

rendering/RenderBoxModelObject.h:
rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintLayerByApplyingTransform):
(WebCore::RenderLayer::collectFragments):
(WebCore::RenderLayer::updatePaintingInfoForFragments):
(WebCore::RenderLayer::paintTransformedLayerIntoFragments):
(WebCore::RenderLayer::paintBackgroundForFragments):
(WebCore::RenderLayer::paintForegroundForFragmentsWithPhase):
(WebCore::RenderLayer::paintOutlineForFragments):
(WebCore::RenderLayer::paintMaskForFragments):
(WebCore::RenderLayer::hitTest):
(WebCore::RenderLayer::hitTestFixedLayersInNamedFlows):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestTransformedLayerInFragments):
(WebCore::RenderLayer::mapLayerClipRectsToFragmentationLayer):
(WebCore::RenderLayer::calculateClipRects):

rendering/RenderLayer.h:
rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateCompositedBounds):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::addToOverlapMap):
(WebCore::RenderLayerCompositor::clippedByAncestor):

rendering/RenderObject.cpp:

(WebCore::RenderObject::currentRenderNamedFlowFragment):

rendering/RenderObject.h:
rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::shouldPaint):

rendering/RenderReplica.cpp:

(WebCore::RenderReplica::paint):

rendering/RenderTable.cpp:

(WebCore::RenderTable::nodeAtPoint):

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::nodeAtPoint):

rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers):

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::paint):

rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paintReplaced):

4:56 AM Changeset in webkit [168966] by berto@igalia.com

4 edits in trunk

RTCDtmfSender default values need to be updated.
https://bugs.webkit.org/show_bug.cgi?id=132952

Patch by Kiran <kiran.guduru@samsung.com> on 2014-05-16
Reviewed by Eric Carlson.

Source/WebCore:
The default ToneDuration and ToneGap values are modified in the updated spec.
So these values need to be updated.

Test: fast/mediastream/RTCPeerConnection-dtmf.html.

Modules/mediastream/RTCDTMFSender.cpp:

LayoutTests:
Added checks to test default, min value interToneGap
and duration and max value for duration.
(Spec does not specify any max value for inTertoneGap)

fast/mediastream/RTCPeerConnection-dtmf.html:

2:02 AM Changeset in webkit [168965] by Lucas Forschler

6 edits in branches/safari-538.34.5-branch/Source/WebCore

Merged r168886.

2:00 AM Changeset in webkit [168964] by Lucas Forschler

2 edits in branches/safari-538.34.5-branch/Source/WebKit2

Merged r168862.

1:57 AM Changeset in webkit [168963] by Lucas Forschler

3 edits in branches/safari-538.34.5-branch/Source/WebKit2

Merged r168848.

1:54 AM Changeset in webkit [168962] by Lucas Forschler

26 edits
1 copy in branches/safari-538.34.5-branch/Source/JavaScriptCore

Merged r168776.

1:53 AM Changeset in webkit [168961] by Csaba Osztrogonác

244 edits in trunk

[WK2] Change the remaining framework includes from WebKit2 to WebKit
https://bugs.webkit.org/show_bug.cgi?id=132956

Patch by Martin Hodovan <mhodovan.u-szeged@partner.samsung.com> on 2014-05-16
Reviewed by Sam Weinig.

Source/WebKit2:

NetworkProcess/unix/NetworkProcessMainUnix.cpp:
NetworkProcess/unix/NetworkProcessMainUnix.h:
PluginProcess/unix/PluginProcessMainUnix.h:
Shared/API/c/cairo/WKImageCairo.h:
Shared/API/c/cf/WKURLRequestCF.h:
Shared/API/c/cf/WKURLResponseCF.h:
Shared/API/c/efl/WKArrayEfl.cpp:
Shared/API/c/efl/WKArrayEfl.h:
UIProcess/API/C/CoordinatedGraphics/WKView.h:
UIProcess/API/C/WKBatteryManager.h:
UIProcess/API/C/WKBatteryStatus.h:
UIProcess/API/C/WKGrammarDetail.h:
UIProcess/API/C/WKTextChecker.h:
UIProcess/API/C/WKVibration.h:
UIProcess/API/C/WKViewportAttributes.h:
UIProcess/API/C/cairo/WKIconDatabaseCairo.h:
UIProcess/API/C/efl/WKAPICastEfl.h:
UIProcess/API/C/efl/WKColorPickerResultListener.h:
UIProcess/API/C/efl/WKEventEfl.h:
UIProcess/API/C/efl/WKPageEfl.h:
UIProcess/API/C/efl/WKPopupItem.h:
UIProcess/API/C/efl/WKPopupMenuListener.h:
UIProcess/API/C/efl/WKViewEfl.cpp:
UIProcess/API/C/efl/WKViewEfl.h:
UIProcess/API/C/gtk/WKFullScreenClientGtk.h:
UIProcess/API/C/gtk/WKInspectorClientGtk.h:
UIProcess/API/C/gtk/WKView.h:
UIProcess/API/C/gtk/WKViewPrivate.h:
UIProcess/API/C/soup/WKContextSoup.h:
UIProcess/API/C/soup/WKCookieManagerSoup.h:
UIProcess/API/C/soup/WKSoupCustomProtocolRequestManager.h:
UIProcess/API/C/soup/WKSoupRequestManager.h:
UIProcess/API/Cocoa/WKErrorRecoveryAttempting.h:
UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.h:
UIProcess/API/cpp/efl/WKEinaSharedString.cpp:
UIProcess/API/cpp/efl/WKEinaSharedString.h:
UIProcess/API/efl/EwkView.cpp:
UIProcess/API/efl/EwkView.h:
UIProcess/API/efl/EwkViewCallbacks.h:
UIProcess/API/efl/GestureRecognizer.h:
UIProcess/API/efl/ewk_application_cache_manager_private.h:
UIProcess/API/efl/ewk_auth_request_private.h:
UIProcess/API/efl/ewk_back_forward_list_item_private.h:
UIProcess/API/efl/ewk_back_forward_list_private.h:
UIProcess/API/efl/ewk_context_menu_item.cpp:
UIProcess/API/efl/ewk_context_private.h:
UIProcess/API/efl/ewk_cookie_manager_private.h:
UIProcess/API/efl/ewk_database_manager_private.h:
UIProcess/API/efl/ewk_error_private.h:
UIProcess/API/efl/ewk_favicon_database_private.h:
UIProcess/API/efl/ewk_file_chooser_request_private.h:
UIProcess/API/efl/ewk_page_group_private.h:
UIProcess/API/efl/ewk_popup_menu_item_private.h:
UIProcess/API/efl/ewk_popup_menu_private.h:
UIProcess/API/efl/ewk_security_origin_private.h:
UIProcess/API/efl/ewk_settings_private.h:
UIProcess/API/efl/ewk_storage_manager_private.h:
UIProcess/API/efl/ewk_view.cpp:
UIProcess/API/efl/ewk_view_private.h:
UIProcess/API/efl/ewk_window_features_private.h:
UIProcess/API/efl/tests/InjectedBundle/injected_bundle_sample.cpp:
UIProcess/API/efl/tests/test_ewk2_eina_shared_string.cpp:
UIProcess/API/gtk/WebKitDownloadClient.cpp:
UIProcess/API/gtk/WebKitPrivate.h:
UIProcess/CoordinatedGraphics/WKCoordinatedSceneAPICast.h:
UIProcess/efl/BatteryProvider.h:
UIProcess/efl/ContextHistoryClientEfl.h:
UIProcess/efl/DownloadManagerEfl.h:
UIProcess/efl/FindClientEfl.h:
UIProcess/efl/FormClientEfl.h:
UIProcess/efl/PageLoadClientEfl.h:
UIProcess/efl/PagePolicyClientEfl.h:
UIProcess/efl/PageUIClientEfl.h:
UIProcess/efl/RequestManagerClientEfl.h:
UIProcess/efl/TextCheckerClientEfl.h:
UIProcess/efl/VibrationClientEfl.h:
UIProcess/efl/ViewClientEfl.cpp:
UIProcess/efl/ViewClientEfl.h:
UIProcess/efl/WebInspectorProxyEfl.cpp:
WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:
WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp:
WebProcess/efl/SeccompFiltersWebProcessEfl.cpp:
WebProcess/efl/SeccompFiltersWebProcessEfl.h:
WebProcess/efl/WebProcessMainEfl.cpp:
WebProcess/efl/WebProcessMainEfl.h:
WebProcess/gtk/WebGtkInjectedBundleMain.cpp:
WebProcess/gtk/WebProcessMainGtk.cpp:
WebProcess/gtk/WebProcessMainGtk.h:
mac/WKPreferences.h:

Tools:

MiniBrowser/MiniBrowserWebProcessPlugIn.h:
MiniBrowser/mac/AppDelegate.m:
MiniBrowser/mac/WK2BrowserWindowController.m:
TestWebKitAPI/InjectedBundleController.h:
TestWebKitAPI/InjectedBundleMain.cpp:
TestWebKitAPI/JavaScriptTest.cpp:
TestWebKitAPI/PlatformUtilities.h:
TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp:
TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
TestWebKitAPI/Tests/WebKit2/Find.cpp:
TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm:
TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
TestWebKitAPI/config.h:
TestWebKitAPI/efl/PlatformWebView.cpp:
TestWebKitAPI/mac/JavaScriptTestMac.mm:
TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
TestWebKitAPI/mac/PlatformWebViewMac.mm:
TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
TestWebKitAPI/mac/WebKitAgnosticTest.mm:
WebKitTestRunner/EventSenderProxy.h:
WebKitTestRunner/GeolocationProviderMock.cpp:
WebKitTestRunner/GeolocationProviderMock.h:
WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
WebKitTestRunner/InjectedBundle/EventSendingController.h:
WebKitTestRunner/InjectedBundle/GCController.cpp:
WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
WebKitTestRunner/InjectedBundle/InjectedBundle.h:
WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
WebKitTestRunner/InjectedBundle/TestRunner.cpp:
WebKitTestRunner/InjectedBundle/TestRunner.h:
WebKitTestRunner/InjectedBundle/TextInputController.cpp:
WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
WebKitTestRunner/PlatformWebView.h:
WebKitTestRunner/StringFunctions.h:
WebKitTestRunner/TestController.cpp:
WebKitTestRunner/TestController.h:
WebKitTestRunner/TestInvocation.cpp:
WebKitTestRunner/TestInvocation.h:
WebKitTestRunner/WebKitTestRunnerPrefix.h:
WebKitTestRunner/WebNotificationProvider.cpp:
WebKitTestRunner/WebNotificationProvider.h:
WebKitTestRunner/WorkQueueManager.cpp:
WebKitTestRunner/cairo/TestInvocationCairo.cpp:
WebKitTestRunner/cg/TestInvocationCG.cpp:
WebKitTestRunner/cocoa/CrashReporterInfo.mm:
WebKitTestRunner/config.h:
WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
WebKitTestRunner/ios/PlatformWebViewIOS.mm:
WebKitTestRunner/ios/TestControllerIOS.mm:
WebKitTestRunner/mac/EventSenderProxy.mm:
WebKitTestRunner/mac/PlatformWebViewMac.mm:
WebKitTestRunner/mac/TestControllerMac.mm:

1:48 AM Changeset in webkit [168960] by Lucas Forschler