⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 22, 2014:

11:45 PM Changeset in webkit [169252] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WTF

Add the partial specialization for VectorTraits<std::unique_ptr<P>>
​https://bugs.webkit.org/show_bug.cgi?id=133083

Reviewed by Andreas Kling.

  • wtf/VectorTraits.h: Like for RefPtr<P>, OwnPtr<P> and Ref<P>, the partial

specialization for VectorTraits<std::unique_ptr<P>> should exist and should
inherit from SimpleClassVector.

11:44 PM Changeset in webkit [169251] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Have the decoded element in VectorArgumentCoder::decode() moved into Vector::append()
​https://bugs.webkit.org/show_bug.cgi?id=133082

Reviewed by Andreas Kling.

  • Platform/IPC/ArgumentCoders.h: Move the decoded element into the Vector::append() call.

This enforces a move instead of a copy if the decoded element's type is move-constructible.

11:43 PM Changeset in webkit [169250] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Move the passed-in Vector<Attachment> in MessageDecoder constructor down into ArgumentDecoder
​https://bugs.webkit.org/show_bug.cgi?id=133080

Reviewed by Andreas Kling.

  • Platform/IPC/MessageDecoder.cpp:

(IPC::MessageDecoder::MessageDecoder): The Vector<Attachment> object was passed in by value.
Move it into the ArgumentDecoder constructor as it is not used elsewhere in this constructor
and produces a copy otherwise.

11:36 PM Changeset in webkit [169249] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Curl] Crash when exceeding maximum cache limit.
​https://bugs.webkit.org/show_bug.cgi?id=133185

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-05-22
Reviewed by Brent Fulgham.

When the maximum cache limit is exceeded, I get a crash.
This happens when deleting cache entries, because a reference to the url string object in the LRU list
is used as a parameter to invalidateCacheEntry(), when called from makeRoomForNewEntry().
When the string is removed from the LRU list in makeRoomForNewEntry(), the string is deleted.
Next, the string is accessed again to remove the url from the index, and we crash.

This can be fixed by removing the string from the LRU list after it is removed from the index.

Fixing the crash also revealed an infinite loop problem.
If the url for some reason only exist in the LRU list, and not in the index,
we will inifitely loop in makeRoomForNewEntry(), trying to remove this url from the cache, but never succeeding.
This can be fixed by removing the url from the LRU list, also when it's not in the index.

  • platform/network/curl/CurlCacheManager.cpp:

(WebCore::CurlCacheManager::makeRoomForNewEntry): Avoid infinite loop by checking if there are more cache entries to remove.
(WebCore::CurlCacheManager::invalidateCacheEntry): Avoid crash and infinite loop by removing url from LRU list last.

10:18 PM Changeset in webkit [169248] by Simon Fraser
  • 4 edits
    2 adds in trunk

Make viewport units work in CSS gradients
​https://bugs.webkit.org/show_bug.cgi?id=133204
<rdar://problem/17012259>

Source/WebCore:

Reviewed by Tim Horton.

Make viewport percentage lengths work in gradients.

Test: fast/gradients/viewport-units-gradient.html

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::addStops):
(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::createGradient):

  • css/CSSGradientValue.h:

LayoutTests:

Reviewed by Tim Horton.

Make viewport percentage lengths work in gradients.

  • fast/gradients/viewport-units-gradient-expected.html: Added.
  • fast/gradients/viewport-units-gradient.html: Added.
9:34 PM Changeset in webkit [169247] by benjamin@webkit.org
  • 2 edits in trunk/Tools

Add Yusuke Suzuki to the list of contributors (for real)

Wrong section...

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-05-22

  • Scripts/webkitpy/common/config/contributors.json:
9:30 PM Changeset in webkit [169246] by benjamin@webkit.org
  • 2 edits in trunk/Tools

Add Yusuke Suzuki to the list of contributors

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-05-22

  • Scripts/webkitpy/common/config/contributors.json:
9:13 PM Changeset in webkit [169245] by benjamin@webkit.org
  • 27 edits in trunk/Source

[iOS][WK2] Add support for minimal-ui viewports
​https://bugs.webkit.org/show_bug.cgi?id=133162

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-05-22
Reviewed by Simon Fraser.

Source/WebCore:
Add support for minimal-ui directly into the Viewport configuration.

ViewportConfiguration knows about two kinds of layout size in scrollview coordinates:
-normal size
-minimal ui size.

Initially, the page is initialized with resetMinimalUI() and starts with a normal layout.

At any time before the main resource is loaded, the Web page can update its viewport meta tag
to include minimal-ui. The viewport configuration is updated immediately to reflect the minimal-ui
layout size. Any layout after that takes minimal-ui into account.

  • WebCore.exp.in:
  • css/LengthFunctions.cpp:

(WebCore::minimumValueForLength):
(WebCore::floatValueForLength):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::viewportPercentageValue):

  • dom/ViewportArguments.h:

(WebCore::ViewportArguments::operator==):

  • page/FrameView.cpp:

(WebCore::FrameView::setViewportSizeForCSSViewportUnits):
(WebCore::FrameView::viewportSizeForCSSViewportUnits):
(WebCore::FrameView::setViewportSize): Deleted.
(WebCore::FrameView::viewportSize): Deleted.

  • page/FrameView.h:
  • page/ViewportConfiguration.cpp:

(WebCore::ViewportConfiguration::ViewportConfiguration):
(WebCore::ViewportConfiguration::setMinimumLayoutSize):
(WebCore::ViewportConfiguration::setMinimumLayoutSizeForMinimalUI):
(WebCore::ViewportConfiguration::activeMinimumLayoutSizeInScrollViewCoordinates):
(WebCore::ViewportConfiguration::resetMinimalUI):
(WebCore::ViewportConfiguration::pageWillRenderFirstFrame):
(WebCore::ViewportConfiguration::initialScale):
(WebCore::ViewportConfiguration::minimumScale):
(WebCore::ViewportConfiguration::updateConfiguration):
(WebCore::ViewportConfiguration::layoutWidth):
(WebCore::ViewportConfiguration::layoutHeight):
(WebCore::ViewportConfiguration::description):

  • page/ViewportConfiguration.h:

(WebCore::ViewportConfiguration::minimumLayoutSizeForMinimalUI):
(WebCore::ViewportConfiguration::usesMinimalUI):

  • rendering/RenderView.cpp:

(WebCore::RenderView::viewportSizeForCSSViewportUnits):
(WebCore::RenderView::viewportSize): Deleted.

  • rendering/RenderView.h:

Source/WebKit2:
In the WebKit2 layers, we have two parts to minimal-ui.
-In WebPage, we need to get the values from the UIProcess and setup the ViewportConfiguration.

Another part is freezing the state on page load.

-In the UIProcess, we need to get the right information for layout and styling, and we need to tell

the UI clients about minimal-ui changes.

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _setUsesMinimalUI:]):
(-[WKWebView _usesMinimalUI]):
(-[WKWebView _didCommitLayerTree:WebKit::]):
(-[WKWebView _frameOrBoundsChanged]):
(-[WKWebView _minimumLayoutSizeOverride]):
(-[WKWebView _setMinimumLayoutSizeOverride:]):
(-[WKWebView _minimumLayoutSizeOverrideForMinimalUI]):
(-[WKWebView _setMinimumLayoutSizeOverrideForMinimalUI:]):
(-[WKWebView _largestUnobscuredSizeOverride]):
(-[WKWebView _setMaximumUnobscuredSizeOverride:]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
(setViewportConfigurationMinimumLayoutSize): Deleted.

  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::setUsesMinimalUI):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::dynamicViewportSizeUpdate):
(WebKit::WebPageProxy::setViewportConfigurationMinimumLayoutSizeForMinimalUI):
(WebKit::WebPageProxy::setMaximumUnobscuredSize):
(WebKit::WebPageProxy::setUsesMinimalUI):
(WebKit::WebPageProxy::setMinimumLayoutSizeForMinimalUI): Deleted.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::didCommitLoad):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::setViewportConfigurationMinimumLayoutSizeForMinimalUI):
(WebKit::WebPage::setMaximumUnobscuredSize):
(WebKit::WebPage::willFlushLayers):
(WebKit::WebPage::dynamicViewportSizeUpdate):
(WebKit::WebPage::viewportConfigurationChanged):
(WebKit::WebPage::updateViewportSizeForCSSViewportUnits):
(WebKit::WebPage::setMinimumLayoutSizeForMinimalUI): Deleted.

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::flushLayers):

9:06 PM Changeset in webkit [169244] by rniwa@webkit.org
  • 4 edits
    2 deletes in trunk

Can't type in status in facebook.com on iOS Safari because keyboard disappears
​https://bugs.webkit.org/show_bug.cgi?id=133196

Reviewed by Geoffrey Garen.

Source/WebCore:
Fixed the bug by rolling out r156252.

When the user taps on the status on facebook.com, the page focuses a textarea,
which is then made momentarily invisible by setting display:none.
The page then removes display:none later and expects the textarea to be still focused.

With r156252, the focus is removed after the page sets display:none and the keyboard disappears.
Since the focus is never reset on the textarea, the user can never type in anything.

The specification may need to change here given that this (rather odd) behavior/expectation exists
on one of the most popular websites on the Web.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::recalcStyle):
(WebCore::Document::updateLayout):
(WebCore::Document::resetHiddenFocusElementSoon): Deleted.
(WebCore::Document::resetHiddenFocusElementTimer): Deleted.

  • dom/Document.h:

LayoutTests:
Removed the test added by r156252.

  • fast/dom/HTMLDocument/active-element-gets-unfocusable-expected.txt: Removed.
  • fast/dom/HTMLDocument/active-element-gets-unfocusable.html: Removed.
8:59 PM Changeset in webkit [169243] by mmaxfield@apple.com
  • 9 edits in trunk

http/tests/security/xss-DENIED-xsl-document-redirect.xml fails with NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=132523

Patch by Myles C. Maxfield <​mmaxfield@apple.com> on 2014-05-22
Reviewed by Alexey Proskuryakov.

Source/WebCore:
We should not manufacture a response in the event of an error during a
synchronous XHR. In addition, this test removes two places that are
sensitive to such a manufactured response.

Updates test expectations.

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest): Don't inspect a
loader response if there is an error

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::platformLoadResourceSynchronously): Do not
manufacture a response

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::platformLoadResourceSynchronously): Do not
manufacture a response

  • xml/XSLTProcessorLibxslt.cpp:

(WebCore::docLoaderFunc): Only use the response's URL if no error
occurred.

LayoutTests:
Two tests have been rebaselined, and re-enable test that now passes. Because of
r23889, synchronous XHRs for file: URLs purposely don't invoke error handlers.

  • fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt: Updated

incorrect test description

  • fast/xmlhttprequest/resources/xmlhttprequest-nonexistent-file-real.html: Ditto
  • platform/mac-wk2/TestExpectations: Re-enable test that now passes.
8:31 PM Changeset in webkit [169242] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed typo fix.

Reviewed by NOBODY.

No new tests.

  • platform/graphics/mac/FontMac.mm:

(WebCore::Font::dashesForIntersectionsWithRect): Accidentally said run.length() instead of glyphBuffer.size().

8:27 PM Changeset in webkit [169241] by msaboff@apple.com
  • 3 edits in trunk/Tools

Eliminate n/total progress update from run-jsc-stress-tests output to file
​https://bugs.webkit.org/show_bug.cgi?id=133191

Reviewed by Geoffrey Garen.

Changed progressMeter setting to be based on stdout being a tty instead of
stdin. Unified the processing of output from the shell runner to match the
same processing as is used by the makefile runner. As part of this, the
shell runner script was simplified. It now forwards the output of each
test_script just like the Makefile and doesn't provide its own progress.

  • Scripts/jsc-stress-test-helpers/shell-runner.sh:
  • Scripts/run-jsc-stress-tests:
8:16 PM Changeset in webkit [169240] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

[iOS][WK2] Reset the special action-target of WKSyntheticClickTapGestureRecognizer on destruction
​https://bugs.webkit.org/show_bug.cgi?id=133165
<rdar://problem/16283914>

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-05-22
Reviewed by Andy Estes.

It is unclear why, but the WKSyntheticClickTapGestureRecognizer sometimes survives its own view
and is reset after WKContentView was destructed.
This patch cleans up the target-action on destruction to avoid accessing a destructed object.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView cleanupInteraction]):

7:24 PM Changeset in webkit [169239] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

Do not force a layout when changing the FixedLayoutSize in WebPage
​https://bugs.webkit.org/show_bug.cgi?id=133167

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-05-22
Reviewed by Andreas Kling.

WebPage::setFixedLayoutSize was forcing a layout immediately after changing the layout size on FrameView.
This is forcing plenty of extra layouts since the fixed layout size is one of many properties updated on the FrameView.

FrameView marks that layout is needed. It is not clear why a layout was performed immediately.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setFixedLayoutSize):

6:47 PM Changeset in webkit [169238] by dburkart@apple.com
  • 6 edits
    1 delete in branches/safari-537.77-branch

Revert r169216.

6:36 PM Changeset in webkit [169237] by akling@apple.com
  • 5 edits in trunk/Source

[iOS WebKit2] Web process should try to shrink its memory footprint when going into background.
<​https://webkit.org/b/133197>
<rdar://problem/17011561>

Source/WebCore:
Make releaseMemory() public so we can call it from the process-will-suspend callback.

Reviewed by Gavin Barraclough.

  • WebCore.exp.in:
  • platform/MemoryPressureHandler.h:

Source/WebKit2:
Try to free up as much memory as possible before going into background.

Reviewed by Gavin Barraclough.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::processWillSuspend):

6:34 PM Changeset in webkit [169236] by akling@apple.com
  • 10 edits in trunk/Source

Hook up a setting for showing detailed logging during memory pressure relief.
<​https://webkit.org/b/133194>

Source/WebCore:
Make the pressure relief logger opt-in. Also make it flush memory back to the
OS (for both malloc and FastMalloc) to get more accurate numbers at each step.

Reviewed by Gavin Barraclough.

  • WebCore.exp.in:
  • platform/MemoryPressureHandler.cpp:
  • platform/MemoryPressureHandler.h:

(WebCore::MemoryPressureHandler::ReliefLogger::ReliefLogger):
(WebCore::MemoryPressureHandler::ReliefLogger::~ReliefLogger):
(WebCore::MemoryPressureHandler::ReliefLogger::setLoggingEnabled):

  • platform/cocoa/MemoryPressureHandlerCocoa.mm:

(WebCore::MemoryPressureHandler::ReliefLogger::platformMemoryUsage):

Source/WebKit2:
Plumb through the same setting that we used for detailed logging in WK1.

Reviewed by Gavin Barraclough.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

6:29 PM Changeset in webkit [169235] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Don't scan for phone numbers in editable regions
<rdar://problem/16949846> and ​https://bugs.webkit.org/show_bug.cgi?id=133192

Reviewed by Enrica Casucci.

No new tests (Currently untested WK2-only feature)

  • editing/Editor.cpp:

(WebCore::Editor::scanRangeForTelephoneNumbers): Skip the range if the Node is editable.

6:04 PM Changeset in webkit [169234] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Captions layout incorrectly in fullscreen.
​https://bugs.webkit.org/show_bug.cgi?id=133175

Patch by Jeremy Jones <​jeremyj@apple.com> on 2014-05-22
Reviewed by Eric Carlson.

When doing layout for fullscreen, geometry should be absolute so it is not influenced
by the rest of the page. This change adds style for CSSPropertyPosition, CSSPropertyLeft,
and CSSPropertyTop.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateDisplay):
Refactor style changes into updateStyleForTextTrackRepresentation().
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired):
Refactor style changes into updateStyleForTextTrackRepresentation().
(WebCore::MediaControlTextTrackContainerElement::clearTextTrackRepresentation):
Refactor style changes into updateStyleForTextTrackRepresentation().
(WebCore::MediaControlTextTrackContainerElement::updateStyleForTextTrackRepresentation):
Consolidate style changes here. Include the two existing and three new style changes.

  • html/shadow/MediaControlElements.h:

Declare updateStyleForTextTrackRepresentation().

5:40 PM Changeset in webkit [169233] by aestes@apple.com
  • 4 edits in trunk/Source/WebKit2

[iOS] Send shareable resources to QuickLook if enabled
​https://bugs.webkit.org/show_bug.cgi?id=133189
<rdar://problem/17003995>

Reviewed by Brady Eidson.

Like we do for didReceiveData(), we need to pass an incoming ShareableResource to QuickLook if a QuickLook
handle exists.

  • Shared/ShareableResource.cpp:

(WebKit::ShareableResource::Handle::tryWrapInCFData): Return the shared resource in a CFDataRef.
(WebKit::ShareableResource::Handle::tryWrapInSharedBuffer): Implemented in terms of tryWrapInCFData().

  • Shared/ShareableResource.h:
  • WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::didReceiveResource): If a QuickLook handle exists, send the shareable resource to
it via a CFDataRef.

5:39 PM Changeset in webkit [169232] by Simon Fraser
  • 4 edits in trunk/LayoutTests

Fix the compositing/transitions/transform-on-large-layer.html test
​https://bugs.webkit.org/show_bug.cgi?id=133195

Reviewed by Dean Jackson.

This test used window resize when it doesn't need to and was flakey.

  • compositing/transitions/transform-on-large-layer.html:
  • platform/efl/TestExpectations:
  • platform/mac/TestExpectations:
5:31 PM Changeset in webkit [169231] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-538.34.46

Create Safari-538.34.46 tag.

5:02 PM Changeset in webkit [169230] by dburkart@apple.com
  • 3 edits
    4 copies in branches/safari-537.77-branch

Merged r169007. <rdar://problem/16975427>

4:57 PM Changeset in webkit [169229] by Simon Fraser
  • 13 edits in trunk

REGRESSION (r155977): Very stuttery 3D css animation on jtechcommunications.com
​https://bugs.webkit.org/show_bug.cgi?id=133179
<rdar://problem/16864666>

Reviewed by Dean Jackson.

Source/WebCore:

Revert code added in r155977 to try to pick a good contentsScale for layers
based on a root-relative transform. This resulted in pages with too much
backing store, and too many cases where layers repainted during animations,
causing stutter.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::flushCompositingState):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::updateContentsOpaque):
(WebCore::GraphicsLayerCA::updateAnimations):
(WebCore::GraphicsLayerCA::appendToUncommittedAnimations):
(WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerCA::setTransformAnimationKeyframes):
(WebCore::GraphicsLayerCA::updateContentsScale):
(WebCore::clampedContentsScaleForScale): Deleted.
(WebCore::maxScaleFromTransform): Deleted.
(WebCore::GraphicsLayerCA::updateRootRelativeScale): Deleted.
(WebCore::GraphicsLayerCA::getTransformFromAnimationsWithMaxScaleImpact): Deleted.

  • platform/graphics/ca/GraphicsLayerCA.h:

LayoutTests:

Rebaseline.

  • compositing/contents-scale/animating-expected.txt:
  • compositing/contents-scale/rounded-contents-scale-expected.txt:
  • compositing/contents-scale/scaled-ancestor-expected.txt:
  • compositing/contents-scale/simple-scale-expected.txt:
  • compositing/contents-scale/z-translate-expected.txt:
  • platform/mac/compositing/overflow/composited-scrolling-paint-phases-expected.txt:
  • platform/mac/compositing/tiling/rotated-tiled-clamped-expected.txt:
  • platform/mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
  • platform/mac/compositing/visible-rect/nested-transform-expected.txt:
4:50 PM Changeset in webkit [169228] by Lucas Forschler
  • 14 edits
    12 copies in branches/safari-537.77-branch

Merged r168915. <rdar://problem/16975506>

4:43 PM Changeset in webkit [169227] by dburkart@apple.com
  • 9 edits in branches/safari-537.77-branch/Source/WebCore

Merged r167856. <rdar://problem/16975541>

4:34 PM Changeset in webkit [169226] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-537.77-branch

Merged r168636. <rdar://problem/16975423>

3:43 PM Changeset in webkit [169225] by Lucas Forschler
  • 12 edits in branches/safari-537.77-branch/Source

Merged r166741. <rdar://problem/16975484>

3:08 PM Changeset in webkit [169224] by dburkart@apple.com
  • 2 edits in branches/safari-537.77-branch/Source/WebCore

Merged r167851. <rdar://problem/16975552>

2:46 PM Changeset in webkit [169223] by mhock@apple.com
  • 12 edits in trunk/Source

[iOS] Enable -apple-system- styled elements to respond to system font size changes.
​https://bugs.webkit.org/show_bug.cgi?id=133186
<rdar://problem/16583782>

Reviewed by Enrica Casucci.

Source/WebCore:

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderThemeIOS.h:
  • rendering/RenderThemeIOS.mm:

(WebCore::_contentSizeCategory):
(WebCore::RenderThemeIOS::contentSizeCategory):
(WebCore::RenderThemeIOS::setContentSizeCategory):

Source/WebKit2:

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):
(-[WKWebView _contentSizeCategoryDidChange:]):
(-[WKWebView _contentSizeCategory]):

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::contentSizeCategoryDidChange):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::contentSizeCategoryDidChange):

2:45 PM Changeset in webkit [169222] by dburkart@apple.com
  • 5 edits in branches/safari-537.77-branch

Merged r168641. <rdar://problem/16975502>

2:40 PM Changeset in webkit [169221] by mark.lam@apple.com
  • 3 edits
    2 adds in trunk

REGRESSION(r154797): Debugger crashes when stepping over an uncaught exception.
<​https://webkit.org/b/133182>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:
Before r154797, we used to clear the VM exception before calling into the
debugger. After r154797, we don't. This patch will restore this clearing
of the exception before calling into the debugger.

Also added assertions after returning from calls into the debugger to
ensure that the debugger did not introduce any exceptions.

  • interpreter/Interpreter.cpp:

(JSC::unwindCallFrame):
(JSC::Interpreter::unwind):
(JSC::Interpreter::debug):

  • Fixed the assertion here. Interpreter::debug() should never be called with a pending exception. Debugger callbacks for exceptions should be handled by Interpreter::unwind() and Interpreter::unwindCallFrame().

LayoutTests:

  • inspector-protocol/debugger/regress-133182-expected.txt: Added.
  • inspector-protocol/debugger/regress-133182.html: Added.
2:37 PM Changeset in webkit [169220] by dburkart@apple.com
  • 3 edits
    2 copies in branches/safari-537.77-branch

Merged r167818. <rdar://problem/16975502>

2:35 PM Changeset in webkit [169219] by Lucas Forschler
  • 15 edits in branches/safari-537.77-branch/Source

Merged r167635. <rdar://problem/16975536>

2:16 PM Changeset in webkit [169218] by dburkart@apple.com
  • 4 edits in branches/safari-537.77-branch/Source/WebCore

Merged r167264. <rdar://problem/16975518>

2:11 PM Changeset in webkit [169217] by msaboff@apple.com
  • 2 edits in trunk/Tools

Add option to run-jsc-stress-tests to use installed jsc
​https://bugs.webkit.org/show_bug.cgi?id=133102

Reviewed by Geoffrey Garen.

Added --no-copy option to not copy a JavaScriptCore framework, but use the one
provied with the --jsc option.

  • Scripts/run-jsc-stress-tests:
2:10 PM Changeset in webkit [169216] by dburkart@apple.com
  • 6 edits
    1 copy in branches/safari-537.77-branch

Merged r166628. <rdar://problem/16975444>

1:56 PM Changeset in webkit [169215] by dburkart@apple.com
  • 1 edit in branches/safari-537.77-branch/LayoutTests/ChangeLog

Fix borked ChangeLog merge from r169213.

1:35 PM Changeset in webkit [169214] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS] Add CFBundleAllowMixedLocalizations to WebContentService
​https://bugs.webkit.org/show_bug.cgi?id=133187
<rdar://problem/16561084>

Reviewed by Tim Horton.

  • WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist:

We already had it in WebContentService.Development, just not here.

1:14 PM Changeset in webkit [169213] by dburkart@apple.com
  • 6 edits
    2 copies in branches/safari-537.77-branch

Merged r166628.

1:00 PM Changeset in webkit [169212] by dburkart@apple.com
  • 3 edits in branches/safari-537.77-branch/Source/WebCore

Merged r165206.

12:37 PM Changeset in webkit [169211] by dburkart@apple.com
  • 2 edits in branches/safari-537.77-branch/Source/JavaScriptCore

Merged r165162.

12:06 PM Changeset in webkit [169210] by matthew_hanson@apple.com
  • 8 edits in branches/safari-538.34-branch/Source/WebCore

Merge r169209. <rdar://problem/16933311>

11:25 AM Changeset in webkit [169209] by jer.noble@apple.com
  • 8 edits in trunk/Source/WebCore

[MSE] Stored samples are not freed when SourceBuffer is removed from MediaSource
​https://bugs.webkit.org/show_bug.cgi?id=133174

Reviewed by Eric Carlson.

Clear out stored MediaSamples from SourceBuffer's TrackBuffer storage when
aborting loading. Also, report the memory cost of those samples, so that the
SourceBuffer will be GCd more readily.

Add a mechanism for reporting the size of a MediaSample:

  • Modules/mediasource/SourceBuffer.h:
  • platform/MediaSample.h:
  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
  • platform/mock/mediasource/MockSourceBufferPrivate.cpp:

Track the memory usage of a SampleMap when adding and removing samples, as well
as allowing the SampleMap to be cleared wholesale:

  • Modules/mediasource/SampleMap.cpp:

(WebCore::SampleMap::clear): Release all stored MediaSamples.
(WebCore::SampleMap::addSample): Update m_totalSize.
(WebCore::SampleMap::removeSample): Ditto.

  • Modules/mediasource/SampleMap.h:

(WebCore::SampleMap::SampleMap): Initialize m_totalSize.
(WebCore::SampleMap::sizeInBytes): Simple accessor.

Clear the stored samples when loading is aborted, and report the extra memory
cost

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::SourceBuffer): Initialize m_reportedExtraMemoryCost.
(WebCore::SourceBuffer::removedFromMediaSource): Clear all stored samples.
(WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Call reportExtraMemoryCost().
(WebCore::SourceBuffer::reportExtraMemoryCost): Inform the vm of the new

extra memory cost incurred by the object.

11:23 AM Changeset in webkit [169208] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS][WK2] Application cache is broken
​https://bugs.webkit.org/show_bug.cgi?id=133172
<rdar://problem/16994593>

Reviewed by Andy Estes.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformDefaultApplicationCacheDirectory): Use a proper
path for application cache database (same as WebKit1).

11:03 AM Changeset in webkit [169207] by enrica@apple.com
  • 4 edits in trunk/Source

REGRESSION (WebKit2): Keyboard should have Search button in duckduckgo.com.
​https://bugs.webkit.org/show_bug.cgi?id=133183
<rdar://problem/17004207>

Reviewed by Geoff Garen.

Source/WebCore:
Adding new export.

  • WebCore.exp.in:

Source/WebKit2:
The keyboard type should be search if the input type is search
or if it is text and it is inside a form with an action and either
name, id or title contain the word search. This matches the
heuristics we have in WK1 for iOS.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getAssistedNodeInformation):

10:09 AM Changeset in webkit [169206] by Lucas Forschler
  • 5 edits
    2 copies in branches/safari-537.77-branch

Merged r164950. <rdar://problem/16975484>

10:00 AM Changeset in webkit [169205] by Lucas Forschler
  • 3 edits in branches/safari-537.77-branch/Source/WebCore

Merged r157816. <rdar://problem/16975484>

9:50 AM Changeset in webkit [169204] by Lucas Forschler
  • 2 edits in branches/safari-537.77-branch/Source/WTF

Merged r157717. <rdar://problem/16975484>

9:23 AM Changeset in webkit [169203] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

REGRESSION(r163712): [GTK] Misspelling and grammar underline marks are no longer drawn
​https://bugs.webkit.org/show_bug.cgi?id=133047

Reviewed by Darin Adler.

Change two conditions changed by mistake in r163712.

  • editing/TextCheckingHelper.cpp:

(WebCore::findMisspellings): Enter the loop also when wordStart is 0.
(WebCore::TextCheckingHelper::findFirstMisspelling): Skip the work
when the text is a single character. Also reworked it to use a for
loop to improve the readability.

8:51 AM Changeset in webkit [169202] by Michał Pakuła vel Rutka
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed EFL gardening

Add test expectations for failing tests.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/editing/apply-style-iframe-crash-expected.txt: Added after r168641.
8:46 AM Changeset in webkit [169201] by Lucas Forschler
  • 9 edits
    2 deletes in branches/safari-537.77-branch/Source/WebCore

Merged r155315.

8:37 AM WebKitGTK/2.4.x edited by Carlos Garcia Campos
(diff)
7:57 AM Changeset in webkit [169200] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Video is resumed with old playback rate.
​https://bugs.webkit.org/show_bug.cgi?id=132905

Patch by Piotr Grad <​p.grad@samsung.com> on 2014-05-22
Reviewed by Philippe Normand.

Source/WebCore:
Setting '0' playback rate is causing pipeline to pause.
GStreamer player impl. exposed this information to upper layers but it should not.
Solution is to hidden such situation behind m_playbackRatePause flag.

Test: media/video-paused-0-rate.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::play):
(WebCore::MediaPlayerPrivateGStreamer::pause):
(WebCore::MediaPlayerPrivateGStreamer::doSeek):
(WebCore::MediaPlayerPrivateGStreamer::updatePlaybackRate):
(WebCore::MediaPlayerPrivateGStreamer::paused):
(WebCore::MediaPlayerPrivateGStreamer::setRate):
(WebCore::MediaPlayerPrivateGStreamer::updateStates):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

LayoutTests:

  • media/video-paused-0-rate-expected.txt: Added.
  • media/video-paused-0-rate.html: Added.
6:05 AM Changeset in webkit [169199] by Antti Koivisto
  • 6 edits
    4 adds in trunk

Text markers don't paint on simple lines
​https://bugs.webkit.org/show_bug.cgi?id=133177

Reviewed by Anders Carlsson.

Source/WebCore:

Marker painting code does not yet support simple lines.

Tests: fast/text/mark-matches-rendering-simple-lines.html

fast/text/mark-matches-rendering.html

  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::addMarker):

Force text blocks with markers to use line boxes.

  • testing/Internals.cpp:

(WebCore::Internals::setMarkedTextMatchesAreHighlighted):

Expose this so we can make reftests for marker rendering.

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

  • fast/text/mark-matches-rendering-expected.html: Added.
  • fast/text/mark-matches-rendering-simple-lines-expected.html: Added.
  • fast/text/mark-matches-rendering-simple-lines.html: Added.
  • fast/text/mark-matches-rendering.html: Added.
5:16 AM WebKitGTK/2.4.x edited by Carlos Garcia Campos
(diff)
5:16 AM Changeset in webkit [169198] by Carlos Garcia Campos
  • 6 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

Merge r168060 - [GStreamer] Use GstMetaVideo
​https://bugs.webkit.org/show_bug.cgi?id=132247

Reviewed by Philippe Normand.

In WebKitVideoSink we announce the usage of GstMetaVideo, but we do
not use it when handling the video frames. This might break
some decoders and filters that rely on buffer's meta, rather
that in the caps structures.

This patch enables the use of GstMetaVideo through the GstVideoFrame
API. And it is used everywhere the buffer mapping is required.

Also this patch changes to nullptr where zeros were used.

Also, compile conditionally the video buffer conversion when it is
ARGB/BGRA, since it is only required for the Cairo backend.

No new tests, already covered by current tests.

  • platform/graphics/gstreamer/GStreamerUtilities.cpp:

(WebCore::getVideoSizeAndFormatFromCaps): init the GstVideoInfo before
used and remove caps fixate check since it is done by
gst_video_info_from_caps().

  • platform/graphics/gstreamer/ImageGStreamer.h:
  • platform/graphics/gstreamer/ImageGStreamerCairo.cpp:

(ImageGStreamer::ImageGStreamer): use GstVideoFrame for buffer mapping
and unmapping.
(ImageGStreamer::~ImageGStreamer): ditto.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture): ditto.
(WebCore::MediaPlayerPrivateGStreamerBase::currentVideoSinkCaps):
return nullptr if failed.

  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkitVideoSinkRender): rely on GstVideoInfo rather than on the
caps. Use GstVideoFrame for buffer mapping and unmapping. Add guards
for buffer transformation, since it's only used by Cairo.
(webkitVideoSinkDispose): remove glib version guards.
(webkitVideoSinkSetCaps): update the value of the private
GstVideoInfo.

5:01 AM Changeset in webkit [169197] by commit-queue@webkit.org
  • 1 edit
    8 adds
    2 deletes in trunk/LayoutTests

[CSS Grid Layout] Split the grid-item-margin-auto-columns-rows.html test.
​https://bugs.webkit.org/show_bug.cgi?id=131064

Patch by Javier Fernandez <​jfernandez@igalia.com> on 2014-05-22
Reviewed by Benjamin Poulain.

Splitting the "grid-item-margin-auto-columns-rows" into different writing-modes
related tests, so besides increasing clarity, it makes it fit in the 800x600 viewport.

  • fast/css-grid-layout/grid-item-margin-auto-columns-rows-expected.html: Removed.
  • fast/css-grid-layout/grid-item-margin-auto-columns-rows.html: Removed.
  • fast/css-grid-layout/grid-item-margin-auto-columns-rows-horizontal-ltr-expected.html: Added.
  • fast/css-grid-layout/grid-item-margin-auto-columns-rows-horizontal-ltr.html: Added.
  • fast/css-grid-layout/grid-item-margin-auto-columns-rows-horizontal-rtl-expected.html: Added.
  • fast/css-grid-layout/grid-item-margin-auto-columns-rows-horizontal-rtl.html: Added.
  • fast/css-grid-layout/grid-item-margin-auto-columns-rows-vertical-ltr-expected.html: Added.
  • fast/css-grid-layout/grid-item-margin-auto-columns-rows-vertical-ltr.html: Added.
  • fast/css-grid-layout/grid-item-margin-auto-columns-rows-vertical-rtl-expected.html: Added.
  • fast/css-grid-layout/grid-item-margin-auto-columns-rows-vertical-rtl.html: Added.
5:00 AM WebKitGTK/2.4.x edited by Carlos Garcia Campos
(diff)
4:59 AM Changeset in webkit [169196] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-2.4

Merge r169112 - [GTK] WebKitWebPage::send-request always pass a valid pointer for redirected response
​https://bugs.webkit.org/show_bug.cgi?id=133119

Reviewed by Sergio Villar Senin.

Source/WebKit2:
The problem is that we were checking whether the passed in
WKURLResponseRef is NULL or not, but it's always a valid object
that can contain a NULL WebCore::ResourceResponse.

  • WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:

(willSendRequestForFrame): Pass NULL as redirect-response
parameter of WebKitWebPage::send-request signal when the
WebCore::ResourceResponse of the passed in WKURLResponseRef is NULL.

Tools:
Check that redirect response parameter of
WebKitWebPage::send-request signal is NULL when not redirecting
and a valid WebKitURIResponse object when redirecting.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:

(testWebResourceSendRequest):
(serverCallback):

  • TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:

(sendRequestCallback):

4:54 AM Changeset in webkit [169195] by Manuel Rego Casasnovas
  • 3 edits in trunk/Source/WebCore

[CSS Grid Layout] Guard RenderObject::isRenderGrid() method
​https://bugs.webkit.org/show_bug.cgi?id=132380

Reviewed by Benjamin Poulain.

Guard RenderObject::isRenderGrid() method under ENABLE_CSS_GRID_LAYOUT compilation flag.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidthInRegion):

  • rendering/RenderObject.h:
3:53 AM WebKitGTK/2.4.x edited by Carlos Garcia Campos
(diff)
3:52 AM Changeset in webkit [169194] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4

[Stable] Typo in ReadCommandLineArguments.m4
​https://bugs.webkit.org/show_bug.cgi?id=132816

Patch by Milan Crha <​mcrha@redhat.com> on 2014-05-22
Reviewed by Carlos Garcia Campos.

  • Source/autotools/ReadCommandLineArguments.m4:
3:37 AM Changeset in webkit [169193] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/JavaScriptCore

Merge r169094 - operationOptimize() should defer the GC for a while.
<​https://webkit.org/b/133103>

Reviewed by Filip Pizlo.

Currently, operationOptimize() only defers the GC until its end. As a result,
a GC may be triggered just before we return from operationOptimize(), and it may
jettison the optimize codeBlock that we're planning to OSR enter into when we
return from this function. This is because the OSR entry on-ramp code hasn't
been executed yet, and hence, there is not yet a reference to this new codeBlock
from the stack, and there won't be until we've had a chance to return out of
operationOptimize() to run the OSR entry on-ramp code.

This issue is now fixed by using DeferGCForAWhile instead of DeferGC. This
ensures that the GC will be deferred until after the OSR entry on-ramp can be
executed.

  • jit/JITOperations.cpp:
2:52 AM Changeset in webkit [169192] by Carlos Garcia Campos
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-2.4

Merge r168460 - Dragging text from one paragraph to another does not render as expected
​https://bugs.webkit.org/show_bug.cgi?id=132633

Reviewed by Darin Adler and Ryosuke Niwa.

Source/WebCore:
When we are dragging and dropping into a content editable field, we detect
if we are trying to put a <p> into an existing <p>, and if so, split the
outer <p> and insert the new <p> as its sibling. However, the outer <p>
might not be editable, so we don't want to do any splitting and inserting
at that location.

Test: editing/pasteboard/drag-drop-paragraph-crasher.html

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::makeInsertedContentRoundTrippableWithHTMLTreeBuilder):

LayoutTests:
The problem occurs when dragging text that includes a <p> into an editable
area that has a <p> as a parent.

  • editing/pasteboard/drag-drop-paragraph-crasher-expected.txt: Added.
  • editing/pasteboard/drag-drop-paragraph-crasher.html: Added.
2:22 AM WebKitGTK/2.4.x edited by vjaquez@igalia.com
fix style (diff)
2:15 AM WebKitGTK/2.4.x edited by vjaquez@igalia.com
add "[GStreamer] Use GstMetaVideo" (diff)
1:09 AM Changeset in webkit [169191] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Tools

Unreviewed. Fix the build after r168707.

  • Scripts/webkitdirs.pm:

(buildAutotoolsProject): Fix merge conflicts not handled in r168707.

May 21, 2014:

11:44 PM Changeset in webkit [169190] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit

[Win64] Unreviewed build fix.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Corrected 64-bit linker symbol.

11:12 PM Changeset in webkit [169189] by Antti Koivisto
  • 6 edits
    2 adds in trunk

REGRESSION(r167870): Crash in simple line layout code with :after
​https://bugs.webkit.org/show_bug.cgi?id=133155

Source/WebCore:
<rdar://problem/16977696>

Reviewed by Darin Adler.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=132241 in a safer way.
The underline behavior is tested by the existing fast/text/simple-lines-hover-underline.html

Test: fast/text/simple-lines-hover-after.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::invalidateLineLayoutPath): Deleted.

Move to RenderBlockFlow.

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::invalidateLineLayoutPath):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::styleDidChange):

Invalidate layout if style changes in a manner that makes us ineligible to use the simple line layout path.

(WebCore::RenderBlockFlow::invalidateLineLayoutPath):

Drop the simple line layout on path invalidation if it exists. It may not be valid anymore.
Also invalidate the layout if this happens so we'll reconstruct the lines later.

(WebCore::RenderBlockFlow::simpleLineLayout): Deleted.
(WebCore::RenderBlockFlow::ensureLineBoxes):
(WebCore::RenderBlockFlow::createLineBoxes): Deleted.

Revert some of the changes made it r167870.

  • rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::simpleLineLayout):

Add strong validity assert.

LayoutTests:

Reviewed by Darin Adler.

  • fast/text/simple-lines-hover-after-expected.html: Added.
  • fast/text/simple-lines-hover-after.html: Added.
9:11 PM Changeset in webkit [169188] by fpizlo@apple.com
  • 8 edits
    5 adds in branches/ftlopt

[ftlopt] DFG::clobberize should be blind to the effects of GC
​https://bugs.webkit.org/show_bug.cgi?id=133166

Source/JavaScriptCore:
Reviewed by Goeffrey Garen.

Move the computation of where GCs happen to DFG::doesGC().

Large (>5x) speed-up on programs that do loop-invariant string concatenations.

  • CMakeLists.txt:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGAbstractHeap.h:
  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):
(JSC::DFG::clobberizeForAllocation): Deleted.

  • dfg/DFGDoesGC.cpp: Added.

(JSC::DFG::doesGC):

  • dfg/DFGDoesGC.h: Added.
  • dfg/DFGStoreBarrierElisionPhase.cpp:

(JSC::DFG::StoreBarrierElisionPhase::handleNode):
(JSC::DFG::StoreBarrierElisionPhase::couldCauseGC): Deleted.

LayoutTests:
Reviewed by Geoffrey Garen.

  • js/regress/hoist-make-rope-expected.txt: Added.
  • js/regress/hoist-make-rope.html: Added.
  • js/regress/script-tests/hoist-make-rope.js: Added.

(foo):

8:52 PM Changeset in webkit [169187] by matthew_hanson@apple.com
  • 5 edits in branches/safari-538.34-branch/Source

Versioning.

8:25 PM Changeset in webkit [169186] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-538.34.45

New Tag.

6:55 PM Changeset in webkit [169185] by fpizlo@apple.com
  • 2 edits in branches/ftlopt/Source/JavaScriptCore

Merge trunk r169184 to ftlopt.

2014-05-21 Filip Pizlo <​fpizlo@apple.com>


Store barrier elision should run after DCE in both the DFG path and the FTL path
​https://bugs.webkit.org/show_bug.cgi?id=129718


Rubber stamped by Mark Hahnenberg.


  • dfg/DFGPlan.cpp: (JSC::DFG::Plan::compileInThreadImpl):
6:36 PM Changeset in webkit [169184] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Store barrier elision should run after DCE in both the DFG path and the FTL path
​https://bugs.webkit.org/show_bug.cgi?id=129718

Rubber stamped by Mark Hahnenberg.

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

6:18 PM Changeset in webkit [169183] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] two media control button strings are not localized
​https://bugs.webkit.org/show_bug.cgi?id=133160

Reviewed by Geoffrey Garen.

  • English.lproj/mediaControlsLocalizedStrings.js:
5:56 PM Changeset in webkit [169182] by matthew_hanson@apple.com
  • 2 edits in tags/Safari-538.36/Source/WebKit2

Merge r169180. <rdar://problem/16982059>

5:12 PM Changeset in webkit [169181] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk

[EFL] Add include path of compact_unwind_encoding.h if FTL JIT is enabled
​https://bugs.webkit.org/show_bug.cgi?id=132907

Patch by Zsolt Borbely <​zsborbely.u-szeged@partner.samsung.com> on 2014-05-21
Reviewed by Gyuyoung Kim.

.:

  • Source/cmake/FindLIBCXXABI.cmake: Added.
  • Source/cmake/OptionsEfl.cmake:

Source/JavaScriptCore:

  • CMakeLists.txt:

Tools:
We need the mach-o/compact_unwind_encoding.h header from libc++abi-dev package
in JavaScriptCore/ftl/FTLUnwindInfo.cpp when FTL JIT is enabled.

  • efl/install-dependencies:
5:11 PM Changeset in webkit [169180] by oliver@apple.com
  • 2 edits in trunk/Source/WebKit2

Only enable sandbox extensions on mac.

3:03 PM Changeset in webkit [169179] by dburkart@apple.com
  • 7 edits in branches/safari-538.34-branch/Source

Merged r169151.

2:50 PM Changeset in webkit [169178] by Alan Bujtas
  • 2 edits in trunk/LayoutTests

Unreviewed Mac gardening after r169161.

  • platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed-expected.txt:
2:35 PM Changeset in webkit [169177] by dino@apple.com
  • 2 edits
    1 add in trunk/Source/WebCore

[iOS] Update some of the media controls buttons to be bigger
​https://bugs.webkit.org/show_bug.cgi?id=133158
<rdar://problem/16475828>

Reviewed by Simon Fraser.

The buttons in the media controls on iOS are too small
to be comfortably pressed. Make them the size of the controls
panel and the expected iOS button size (44x44px).

The artwork for the buttons now includes the padding. I've
added a file from which you can edit the artwork, then
copy it into the CSS (because editing directly in CSS is
a huge pain).

So far just the play/pause and fullscreen button have been
updated. There will be a follow-up patch to fix the remaining
buttons and the scrubber.

  • Modules/mediacontrols/assets-apple-iOS.svg: Added.
  • Modules/mediacontrols/mediaControlsiOS.css:

(audio::-webkit-media-controls-panel):
(audio::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-play-button:active):
(audio::-webkit-media-controls-play-button.paused):
(audio::-webkit-media-controls-fullscreen-button:active):
(@media only screen and (-webkit-min-device-pixel-ratio: 2)): Deleted.

1:52 PM Changeset in webkit [169176] by oliver@apple.com
  • 5 edits
    2 adds in trunk/Source/WebKit2

[iOS] Enable sandboxing for the database process
​https://bugs.webkit.org/show_bug.cgi?id=132963

Reviewed by Alexey Proskuryakov.

Simply ensure that the database process is running in a tight
sandbox. As part of this i've separated out ChildProcessIOS
and ensures that the database process loads a custom sandbox.

  • Configurations/WebKit.xcconfig:
  • DatabaseProcess/ios/DatabaseProcessIOS.mm:

(WebKit::DatabaseProcess::initializeSandbox):

  • DatabaseProcess/ios/com.apple.WebKit.DatabasesIOS.sb: Added.
  • Shared/ios/ChildProcessIOS.mm: Added.

Essentially cloned from the Mac version, only all the OSX
specific logic has been stripped.
(WebKit::ChildProcess::setApplicationIsDaemon):
(WebKit::ChildProcess::platformInitialize):
(WebKit::ChildProcess::initializeSandbox):
(WebKit::ChildProcess::setQOS):

  • Shared/mac/ChildProcessMac.mm:

Remove all the IOS ifdefs.
(WebKit::ChildProcess::setApplicationIsDaemon):
(WebKit::ChildProcess::platformInitialize):
(WebKit::ChildProcess::initializeSandbox):
(WebKit::ChildProcess::setQOS):

  • WebKit2.xcodeproj/project.pbxproj:
1:39 PM Changeset in webkit [169175] by aestes@apple.com
  • 17 edits
    1 copy
    1 add in trunk/Source/WebKit2

[iOS] Create a UIPrintFormatter for WKWebView
​https://bugs.webkit.org/show_bug.cgi?id=133005

Reviewed by Tim Horton.

Implemented a UIPrintFormatter subclass to support printing WKWebViews using UIPrintInteractionController.
Overrode -_recalcPageCount: to synchronously ask the web process to lay out for printing and return the number
of page rects. The web process returns the page rects immediately and then starts rendering the page to a PDF,
returning the PDF data to the UI process asynchronously. When UIPrintInteractionController later calls our
overridden -drawInRect:forPageAtIndex:, we block and wait for the PDF data to be returned. Since
UIPrintInteractionController draws each page after a delay, it's possible that the web process has already
returned the PDF data to us by the time we print the first page.

  • Shared/WebPreferencesStore.h: Correctly initialized shouldPrintBackgrounds for iOS.
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _dataForDisplayedPDF]): Now that WKPDFView vends its CGPDFDocument directly, extract its data here.
(-[WKWebView _printFormatterClass]): Tell UIView which UIPrintFormatter to alloc.
(-[WKWebView _computePageCountAndStartDrawingToPDFWithPrintInfo:WebKit::firstPage:computedTotalScaleFactor:]):
If we're displaying a PDF, return its page count directly. Otherwise, synchronously ask the web process to
compute page rects for printing and then return the number of rects.
(-[WKWebView _endPrinting]): Cleared state and sent the WebPage::EndPrinting message to the web process.
(-[WKWebView _printedDocument]): If we're displaying a PDF, return its data directly. Otherwise, if we haven't
received PDF data from the web process yet, wait for it indefinitely (there's no sensible timeout to use here
since failing to receive the data results in printing some number of blank pages).
(-[WKWebView _setPrintedDocument:]): Set the CGPDFDocument received from the web process.

  • UIProcess/API/Cocoa/WKWebViewInternal.h: Declared methods called by WKWebViewPrintFormatter.
  • UIProcess/PageClient.h: Declared didFinishDrawingPagesToPDF.
  • UIProcess/WKWebViewPrintFormatter.h: Added.
  • UIProcess/WKWebViewPrintFormatter.mm: Added.

(-[WKWebViewPrintFormatter dealloc]): Cleared state and called -[WKWebView _endPrinting].
(-[WKWebViewPrintFormatter webView]): Returned the WKWebView for this print formatter.
(-[WKWebViewPrintFormatter _recalcPageCount]): Set up a PrintInfo object given the formatter's content rect
and called -_computePageCountAndStartDrawingToPDFWithPrintInfo:...
(-[WKWebViewPrintFormatter rectForPageAtIndex:]): Called -_recalcIfNecessary and then returned the rect from
-_pageContentRect.
(-[WKWebViewPrintFormatter drawInRect:forPageAtIndex:]): Taught to draw the given page of the printed PDF
document into the given rect and context provided to us.

  • UIProcess/WebPageProxy.h: Declared didFinishDrawingPagesToPDF.
  • UIProcess/WebPageProxy.messages.in: Added DidFinishDrawingPagesToPDF. Made this a delayed syncrhonous message

so that additoinal work could be performed after sending the response.

  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::didFinishDrawingPagesToPDF): Created a CGPDFDocument from the data sent to us by the
web process and called -[WKWebView _setPrintedDocument:].

  • UIProcess/ios/WKPDFView.h:
  • UIProcess/ios/WKPDFView.mm:

(-[WKPDFView pdfDocument]): Returned the underlying CGPDFDocument.
(-[WKPDFView documentData]): Deleted.

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::didFinishDrawingPagesToPDF):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::computePagesForPrinting): Changed to call computePagesForPrintingImpl.
(WebKit::WebPage::computePagesForPrintingImpl): Moved the common logic of computePagesForPrinting to here so it
could be called by computePagesForPrintingAndStartDrawingToPDF.
(WebKit::WebPage::drawPagesToPDF): Changed to call drawPagesToPDFImpl
(WebKit::WebPage::drawPagesToPDFImpl): Moved the common logic of drawPagesToPDF to here so it could be called
by computePagesForPrintingAndStartDrawingToPDF.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::computePagesForPrintingAndStartDrawingToPDF): Computed page rects and returned them as a
synchronous response. Afterwards called drawPagesToPDFImpl() and returned the PDF data by sending
WebPageProxy::DidFinishDrawingPagesToPDF.

12:48 PM Changeset in webkit [169174] by Lucas Forschler
  • 7 edits in tags/Safari-538.36/Source

Merged r169151.

12:45 PM Changeset in webkit [169173] by roger_fong@apple.com
  • 7 edits in trunk/LayoutTests

Unreviewed. Actually enable snapshot tests on mac wk2.

​https://bugs.webkit.org/show_bug.cgi?id=131871

  • platform/mac-wk1/TestExpectations: Skip them here.
  • platform/mac/TestExpectations: Unskip them here.

Some slight modifications to some of the tests to reduce flakiness of tests.

  • plugins/snapshotting/autoplay-dominant.html:
  • plugins/snapshotting/autoplay-plugin-blocked-by-image.html:
  • plugins/snapshotting/autoplay-plugin-mostly-blocked-by-image.html:
  • plugins/snapshotting/snapshot-plugin-not-quite-blocked-by-image.html:
11:22 AM Changeset in webkit [169172] by Michał Pakuła vel Rutka
  • 7 edits in trunk

[EFL] Turn on ENABLE_CSS_FILTERS
​https://bugs.webkit.org/show_bug.cgi?id=133153

Reviewed by Gyuyoung Kim.

.:

  • Source/cmake/OptionsEfl.cmake: Enable CSS_FILTERS as default option value.

Source/WebKit2:
Make WebKit2 compile after r166741 when CSS_FILTERS are enabled.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(IPC::ArgumentCoder<WebCore::FilterOperations>::decode):

LayoutTests:
Remove failure test expectations for tests passing after turning on CSS_FILTERS.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
11:18 AM Changeset in webkit [169171] by dburkart@apple.com
  • 5 edits in branches/safari-538.34-branch/Source/WebKit2

Merged r169170.

10:37 AM Changeset in webkit [169170] by beidson@apple.com
  • 5 edits in trunk/Source/WebKit2

Special handling of telephone number detection menu.
<rdar://problem/16967971> and ​https://bugs.webkit.org/show_bug.cgi?id=133143

Reviewed by Geoff Garen.

Add a bool to ContextMenuContextData to represent telephone number menus:

  • Shared/ContextMenuContextData.cpp:

(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::operator=):
(WebKit::ContextMenuContextData::encode):
(WebKit::ContextMenuContextData::decode):

  • Shared/ContextMenuContextData.h:

(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::isTelephoneNumberContext):

  • UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::showContextMenu): If the menu is a telephone

number menu then display it using a specific AppKit API.

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::showTelephoneNumberMenu): Filter the array of menu items

through a new WKSI call, and then show it using a telephone number context.

10:30 AM Changeset in webkit [169169] by matthew_hanson@apple.com
  • 5 edits in branches/safari-538.34-branch/Source

Versioning.

10:22 AM Changeset in webkit [169168] by bshafiei@apple.com
  • 5 edits in branches/safari-538.34.5-branch/Source

Versioning.

10:04 AM Changeset in webkit [169167] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

[Mac] REGRESSION (Async text input): Asian text input doesn't work in Flash
​https://bugs.webkit.org/show_bug.cgi?id=133128
<rdar://problem/16890920>

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _interpretKeyEvent:completionHandler:]): Added a separate code path for
plug-in input. Before async text input, we used to provide a nil input context due
to having _data->_interpretKeyEventsParameters while this function was executing,
and thus took a shortcut. The new behavior is different from pre-async in that
we don't collect commands at all, but I couldn't find any case where that mattered.
(-[WKView inputContext]): The _collectedKeypressCommands check was not a correct
replacement for _interpretKeyEventsParameters one, because this variable is not
always set within -_interpretKeyEvent:completionHandler:.

  • UIProcess/mac/WKTextInputWindowController.mm:

(-[WKTextInputPanel _interpretKeyEvent:usingLegacyCocoaTextInput:string:]):
While at it, fixed a separate issue with Cangjie predictive input. We shouldn't
keep prediction pop-up on screen after hiding the bottom input window.

9:56 AM Changeset in webkit [169166] by Alan Bujtas
  • 2 edits in trunk/LayoutTests

Unreviewed Mac gardening after r169161.

  • platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed-expected.txt:
9:39 AM Changeset in webkit [169165] by Martin Robinson
  • 16 edits in trunk

[CMake] Improve handling of LIB_INSTALL_DIR, EXEC_INSTALL_DIR, and LIBEXEC_INSTALL_DIR
​https://bugs.webkit.org/show_bug.cgi?id=132819

Reviewed by Carlos Garcia Campos.

.:

  • CMakeLists.txt: Hard-code CMAKE_ARCHIVE_OUTPUT_DIRECTORY etc, so that we can accept absolute paths for LIB_INSTALL_DIR

and friends.

  • Source/cmake/OptionsCommon.cmake: Get rid of LIB_SUFFIX and try to make all path variables absolute. Also set

CMAKE_ARCHIVE_OUTPUT_DIRECTORY, etc using the last path component of LIB_INSTALL_DIR, etc, so that absolute paths
are supported.

  • Source/cmake/OptionsGTK.cmake: Ditto. Also get rid of all pkg-config specific variables.

Source/JavaScriptCore:

  • javascriptcoregtk.pc.in: Instead of using the special pkg-config variables,

use the common CMake ones directly.

Source/WebKit/efl:

  • EWebKitConfig.cmake.in: LIB_INSTALL_DIR is always absolute now, so we don't need

to prefix it with the prefix.

  • ewebkit.pc.in: Instead of hard-coding the path to the library installation directory use LIB_INSTALL_DIR.

Source/WebKit2:

  • PlatformEfl.cmake: No need to prefix EXEC_INSTALL_DIR with the prefix any longer.
  • PlatformGtk.cmake: No longer use CMAKE_INSTALL_FULL_FOO variables, instead using the WebKit-specific ones.
  • efl/EWebKit2Config.cmake.in: Ditto.
  • efl/ewebkit2.pc.in: Instead of hard-coding the path to the library installation directory use LIB_INSTALL_DIR.
  • webkit2gtk-web-extension.pc.in: No longer use the pkg-config only variables. Instead use

the common CMake ones.

  • webkit2gtk.pc.in: Ditto.
9:33 AM Changeset in webkit [169164] by fpizlo@apple.com
  • 6 edits in trunk

Unreviewed, roll out ​http://trac.webkit.org/changeset/169159.

This was a unilateral change and wasn't properly reviewed.

PerformanceTests/SunSpider:

  • profiler-test.yaml:

Source/JavaScriptCore:

  • tests/mozilla/mozilla-tests.yaml:

LayoutTests:

  • js/script-tests/function-apply-many-args.js:
9:19 AM Changeset in webkit [169163] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

REGRESSION(r168625): [GTK] Assertion failure in LocalStorageDatabaseTracker
​https://bugs.webkit.org/show_bug.cgi?id=133118

Reviewed by Philippe Normand.

Call WebContext::applyPlatformSpecificConfigurationDefaults() to
initialize the WebContextConfiguration before creating the default WebContext.

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(createDefaultWebContext):

9:14 AM Changeset in webkit [169162] by graouts@webkit.org
  • 7 edits in trunk

Array.prototype.find and findIndex should skip holes
​https://bugs.webkit.org/show_bug.cgi?id=132658

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:
Skip holes in the array when iterating such that callback isn't called.

  • builtins/Array.prototype.js:

(find):
(findIndex):

LayoutTests:

  • js/array-find-expected.txt:
  • js/array-findIndex-expected.txt:
  • js/script-tests/array-find.js:
  • js/script-tests/array-findIndex.js:
9:06 AM Changeset in webkit [169161] by Alan Bujtas
  • 6 edits in trunk/Source/WebCore

Garbage when rubber-banding at the right edge of a page zoomed to non-integral scale.
​https://bugs.webkit.org/show_bug.cgi?id=133139
<rdar://problem/16503353>

Reviewed by Simon Fraser.

Do not pixel align the root content layer. The alignment code expands the graphics's layer size
which makes the right and bottom tiles bigger than the content.
Painting the body's background color produces pixel cracks, because the content can not
fill the expanded tiles completely.

Not testable.

  • platform/graphics/GraphicsLayerClient.h:

(WebCore::GraphicsLayerClient::needsPixelAligment):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateGeometry):
(WebCore::GraphicsLayerCA::computePixelAlignment):

  • platform/graphics/ca/mac/TileGrid.mm:

(WebCore::TileGrid::rectForTileIndex):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::needsPixelAligment):

  • rendering/RenderLayerBacking.h:
8:31 AM Changeset in webkit [169160] by stavila@adobe.com
  • 3 edits
    2 adds in trunk

REGRESSION (r168046): Invalid layout in WebCore::RenderBox::containingBlockLogicalWidthForPositioned
​https://bugs.webkit.org/show_bug.cgi?id=132933

Reviewed by Darin Adler.

Source/WebCore:
Invalid layout is performed when calling containingBlockLogicalWidthForPositioned for a RenderTableSection object.

Test: fast/multicol/newmulticol/table-section-crash.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):

LayoutTests:
Added test for crash caused by invalid layout for RenderTableSection.

  • fast/multicol/newmulticol/table-section-crash-expected.txt: Added.
  • fast/multicol/newmulticol/table-section-crash.html: Added.
7:56 AM Changeset in webkit [169159] by commit-queue@webkit.org
  • 6 edits in trunk

REGRESSION(r169092 and r169102): Skip failing JSC tests on ARM64 properly
​https://bugs.webkit.org/show_bug.cgi?id=133149

Patch by Eva Balazsfalvi <​evab.u-szeged@partner.samsung.com> on 2014-05-21
Reviewed by Csaba Osztrogonác.

PerformanceTests/SunSpider:

  • profiler-test.yaml:

Source/JavaScriptCore:

  • tests/mozilla/mozilla-tests.yaml:

LayoutTests:

  • js/script-tests/function-apply-many-args.js:
7:43 AM Changeset in webkit [169158] by Michał Pakuła vel Rutka
  • 36 edits in trunk/LayoutTests

Unreviewed EFL gardening

Rebaseline test expectations after r169048.

  • platform/efl/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/efl/css1/text_properties/text_indent-expected.txt:
  • platform/efl/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
  • platform/efl/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/efl/css2.1/t100801-c544-valgn-00-a-ag-expected.txt:
  • platform/efl/css2.1/t100801-c544-valgn-02-d-agi-expected.txt:
  • platform/efl/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
  • platform/efl/css2.1/t100801-c544-valgn-04-d-agi-expected.txt:
  • platform/efl/css2.1/t1601-c547-indent-00-b-a-expected.txt:
  • platform/efl/fast/block/float/026-expected.txt:
  • platform/efl/fast/block/float/028-expected.txt:
  • platform/efl/fast/css/empty-pseudo-class-expected.txt:
  • platform/efl/fast/css/first-child-pseudo-class-expected.txt:
  • platform/efl/fast/css/first-of-type-pseudo-class-expected.txt:
  • platform/efl/fast/css/last-child-pseudo-class-expected.txt:
  • platform/efl/fast/css/last-of-type-pseudo-class-expected.txt:
  • platform/efl/fast/css/only-child-pseudo-class-expected.txt:
  • platform/efl/fast/css/only-of-type-pseudo-class-expected.txt:
  • platform/efl/fast/line-grid/line-align-left-edges-expected.txt:
  • platform/efl/fast/multicol/column-count-with-rules-expected.txt:
  • platform/efl/fast/multicol/float-multicol-expected.txt:
  • platform/efl/fast/multicol/layers-in-multicol-expected.txt:
  • platform/efl/fast/multicol/vertical-lr/float-multicol-expected.txt:
  • platform/efl/fast/multicol/vertical-rl/float-multicol-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-1-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-10-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-2-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-3-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-4-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-5-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-6-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-7-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-8-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-9-expected.txt:
  • platform/efl/fast/text/whitespace/024-expected.txt:
6:08 AM Changeset in webkit [169157] by Gustavo Noronha Silva
  • 2 edits in trunk

[CMake] Support building with Debug Fission
​https://bugs.webkit.org/show_bug.cgi?id=131177

Reviewed by Philippe Normand.

  • Source/cmake/OptionsCommon.cmake: add a DEBUG_FISSION option to enable usage

of ​http://gcc.gnu.org/wiki/DebugFission.

5:01 AM Changeset in webkit [169156] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

REGRESSION(r169092): It broke run-jsc-stress tests on non Mac platforms
​https://bugs.webkit.org/show_bug.cgi?id=133145

Patch by Eva Balazsfalvi <​evab.u-szeged@partner.samsung.com> on 2014-05-21
Reviewed by Csaba Osztrogonác.

  • Scripts/run-jsc-stress-tests:
4:55 AM Changeset in webkit [169155] by jinwoo7.song@samsung.com
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed EFL gardening.

  • platform/efl/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Added.

Rebaseline after r169048.

4:03 AM WebKitGTK/KeepingTheTreeGreen edited by ltilve@igalia.com
(diff)
2:28 AM Changeset in webkit [169154] by berto@igalia.com
  • 2 edits
    1 add in trunk/LayoutTests

[GTK] Unreviewed GTK gardening

Patch by Lorenzo Tilve <​ltilve@igalia.com> on 2014-05-21

  • platform/gtk/TestExpectations: Report and mark new tests failing.
  • platform/gtk/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Added.

Rebaseline after r169048.

2:11 AM Changeset in webkit [169153] by simon.pena@samsung.com
  • 2 edits in trunk/Source/WebCore

[EFL] Ensure EGLOffScreenContext::initialize calls platformMakeCurrent on the surface
​https://bugs.webkit.org/show_bug.cgi?id=124832

Reviewed by Antonio Gomes.

The original code was only calling platformMakeCurrent when the
GL_EXT_robustness extension is supported: the alternate code path
would only create a context, but it wouldn't make that context
current. This patch ensures platformMakeCurrent is also called for
the alternate code path, and, if it fails to make the context
current, will destroy the context. Effectively, this makes both
code paths behave in the same way.

  • platform/graphics/surfaces/egl/EGLContext.cpp:

(WebCore::EGLOffScreenContext::initialize):

1:12 AM Changeset in webkit [169152] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WebKit2] Cleanup the build from unused variable in WebProcess module
​https://bugs.webkit.org/show_bug.cgi?id=133062

Patch by Shivakumar JM <​shiva.jm@samsung.com> on 2014-05-21
Reviewed by Csaba Osztrogonác.

Fix unused parameter by using UNUSED_PARAM macro

  • WebProcess/UserContent/WebUserContentController.cpp:

(WebKit::WebUserContentController::addUserScriptMessageHandlers):
(WebKit::WebUserContentController::removeUserScriptMessageHandler):

Note: See TracTimeline for information about the timeline view.