Context Navigation

← Previous Period
Next Period →

Timeline

May 29, 2014:

7:11 PM Changeset in webkit [169482] by dburkart@apple.com

5 edits in branches/safari-537.77-branch/Source

Bump versioning to 537.77.3

5:56 PM Changeset in webkit [169481] by dburkart@apple.com

1 copy in tags/Safari-537.77.2

New TaG

5:52 PM Changeset in webkit [169480] by achristensen@apple.com

2 edits in trunk/Source/WTF

Enable css jit by default on arm64.
https://bugs.webkit.org/show_bug.cgi?id=133246
<rdar://problem/17073407>

Reviewed by Benjamin Poulain.

wtf/Platform.h:

Added arm64 to list of supported architectures.

5:25 PM Changeset in webkit [169479] by achristensen@apple.com

4 edits in trunk/Source/WebCore

Prepare css jit for arm64 and other architectures.
https://bugs.webkit.org/show_bug.cgi?id=133394

Reviewed by Benjamin Poulain.

cssjit/FunctionCall.h:

(WebCore::FunctionCall::swapArguments):

cssjit/RegisterAllocator.h:

Use a designated temporary register on arm64 to prevent using a deallocated argument register to swap argument registers in.

cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
Added assertion to make sure there are enough registers.

5:15 PM Changeset in webkit [169478] by benjamin@webkit.org

14 edits in trunk/Source/WebCore

CSS JIT: add support for the pseudo classes :hover and :active
https://bugs.webkit.org/show_bug.cgi?id=133295

Reviewed by Andreas Kling.

This patch adds compilation support for :hover and :active. The code generation of both of them is trivial,
most of the patch is improving the infrastructure and safety.

The document compatibility mode is moved to its own typed enum. This ensure the values are exclusives and
the native type is known (unsigned char here). The values are changes to binary flags to take advantage of
test-and-branch on ARM64 (not used explicitely, it is automatically generated by the MacroAssembler).

The other important refactoring is the code updating the flags on RenderStyle::NonInheritedFlags.
The code was duplicated in some places so it is move into its own function addFlagToElementStyleFromContext().

The generators themself are very simple. First we check the quirks-mode exceptions, that is generally excluded
at compile time because the conditions are almost never met, even in strict mode.
Then we have two cases: style resolution and query selector. Almost everything is just function calls.

cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorFragment::SelectorFragment):
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::addFlagToElementStyleFromContext):
(WebCore::SelectorCompiler::fragmentOnlyMatchesLinksInQuirksMode):
(WebCore::SelectorCompiler::getDocument):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSpecialFailureInQuirksModeForActiveAndHoverIfNeeded):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::elementIsActive):
(WebCore::SelectorCompiler::elementIsActiveForStyleResolution):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsActive):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsFirstChild):
(WebCore::SelectorCompiler::elementIsHovered):
(WebCore::SelectorCompiler::elementIsHoveredForStyleResolution):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsHovered):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsLastChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsOnlyChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):

dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::setCompatibilityMode):
(WebCore::Document::implicitOpen):
(WebCore::Document::cloneDataFromDocument):

dom/Document.h:

(WebCore::Document::compatibilityModeMemoryOffset):
(WebCore::Document::inQuirksMode):
(WebCore::Document::inLimitedQuirksMode):
(WebCore::Document::inNoQuirksMode):
(WebCore::Document::compatibilityMode): Deleted.

html/ImageDocument.cpp:

(WebCore::ImageDocument::ImageDocument):

html/MediaDocument.cpp:

(WebCore::MediaDocument::MediaDocument):

html/PluginDocument.cpp:

(WebCore::PluginDocument::PluginDocument):

html/TextDocument.cpp:

(WebCore::TextDocument::TextDocument):

html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::setDefaultCompatibilityMode):
(WebCore::HTMLConstructionSite::setCompatibilityMode):
(WebCore::HTMLConstructionSite::setCompatibilityModeFromDoctype):
(WebCore::HTMLConstructionSite::insertDoctype):

html/parser/HTMLConstructionSite.h:
loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::replaceDocument):

loader/SinkDocument.cpp:

(WebCore::SinkDocument::SinkDocument):

page/ios/FrameIOS.mm:

(WebCore::Frame::initWithSimpleHTMLDocument):

rendering/style/RenderStyle.h:

5:09 PM Changeset in webkit [169477] by andersca@apple.com

2 edits in trunk/Source/WebKit2

-[WKProcessPoolConfiguration setCachePartitionedURLSchemes:] should do a deep copy
https://bugs.webkit.org/show_bug.cgi?id=133393

Reviewed by Dan Bernstein.

UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:

(-[_WKProcessPoolConfiguration setCachePartitionedURLSchemes:]):

4:56 PM Changeset in webkit [169476] by jpfau@apple.com

2 edits in branches/safari-537.77-branch/Source/WebCore

Build fix for Mavericks

WebCore.exp.in:

4:52 PM Changeset in webkit [169475] by jhoneycutt@apple.com

34 edits
7 adds in trunk

Roll r168668 back in.

<https://bugs.webkit.org/show_bug.cgi?id=132621>

Reviewed by Brent Fulgham.

Source/WebCore:
Tests: fast/events/beforeload-assertion.html

fast/events/beforeload-iframe-crash.html
fast/events/beforeload-input-time-crash.html

WebCore.exp.in:
dom/Document.cpp:

(WebCore::Document::updateLayoutIgnorePendingStylesheets):

dom/Document.h:
html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::renderWidgetForJSBindings):

html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::renderWidgetForJSBindings):

html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::renderWidgetForJSBindings):

page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::updateEmbeddedObjectsTimerFired):
(WebCore::FrameView::flushAnyPendingPostLayoutTasks):
(WebCore::FrameView::performPostLayoutTasks):

page/FrameView.h:
testing/Internals.cpp:

(WebCore::Internals::updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks):

testing/Internals.h:
testing/Internals.idl:

Source/WebKit:

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

LayoutTests:

compositing/plugins/composited-plugin.html:
compositing/plugins/no-backing-store.html:
fast/dom/beforeload/flash-before-load.html:
fast/events/beforeload-assertion-expected.txt: Added.
fast/events/beforeload-assertion.html: Added.
fast/events/beforeload-iframe-crash-expected.txt: Added.
fast/events/beforeload-iframe-crash.html: Added.
fast/events/beforeload-input-time-crash-expected.txt: Added.
fast/events/beforeload-input-time-crash.html: Added.
http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-data.html:
http/tests/security/contentSecurityPolicy/1.1/plugintypes-nourl-blocked.html:
http/tests/security/contentSecurityPolicy/object-src-no-url-allowed.html:
http/tests/security/contentSecurityPolicy/object-src-no-url-blocked.html:
http/tests/security/contentSecurityPolicy/object-src-none-allowed.html:
http/tests/security/contentSecurityPolicy/object-src-none-blocked.html:
http/tests/security/contentSecurityPolicy/resources/multiple-iframe-plugin-test.js:

(testImpl.iframe.onload):
(testImpl):

http/tests/security/mixedContent/insecure-plugin-in-iframe.html:
platform/mac/plugins/supports-carbon-event-model.html:
platform/mac/plugins/testplugin-onnew-onpaint.html:
plugins/get-user-agent-with-null-npp-from-npp-new.html:
plugins/mouse-click-plugin-clears-selection.html:
plugins/netscape-plugin-map-data-to-src.html:
plugins/no-mime-with-valid-extension.html:
plugins/plugin-initiate-popup-window.html:
plugins/windowless_plugin_paint_test.html:
resources/plugin.js: Added.

(runAfterPluginLoad):

4:41 PM Changeset in webkit [169474] by mmaxfield@apple.com

6 edits in trunk

Support -apple-system-font on OS X
https://bugs.webkit.org/show_bug.cgi?id=133382

Source/WebCore:
Reviewed by Simon Fraser.

Guard on both family names: "-apple-system-font" and "-webkit-system-font"

Test: platform/mac/fast/text/systemFont.html

platform/mac/WebFontCache.mm:

(+[WebFontCache internalFontWithFamily:traits:weight:size:]):

LayoutTests:
This test makes sure that -apple-system-font is rendered the same way as -webkit-system-font.

Reviewed by Simon Fraser.

platform/mac-mountainlion/platform/mac/fast/text/systemFont-expected.txt: Updated.
platform/mac/fast/text/systemFont.html: Tests -apple-system-font in addition to -webkit-system-font.
platform/mac/platform/mac/fast/text/systemFont-expected.txt: Updated.

4:24 PM Changeset in webkit [169473] by jpfau@apple.com

2 edits in branches/safari-537.77-branch/Source/WebCore

Build fix

WebCore.exp.in:

4:04 PM Changeset in webkit [169472] by ap@apple.com

3 edits
3 adds in trunk

Loading <object> from WebArchive crashes
https://bugs.webkit.org/show_bug.cgi?id=133386
<rdar://problem/13345509>

Reviewed by Brady Eidson.

Source/WebCore:
Test: webarchive/loading/object.html

This (a) fixes the crash, and (b) avoids the crash.

loader/DocumentLoader.cpp: (WebCore::DocumentLoader::continueAfterContentPolicy):

Some types of substitute data - such as WebArchive - don't contain HTTP result codes,
so let's not drop to <object> fallback content when status is 0.
And if the load somehow failed anyway, don't crash by trying to deliver substitute data
to a finished loader.

LayoutTests:

webarchive/loading/object-expected.txt: Added.
webarchive/loading/object.html: Added.
webarchive/loading/resources/object.webarchive: Added.

4:00 PM Changeset in webkit [169471] by rniwa@webkit.org

2 edits in trunk/Websites/perf.webkit.org

Add an instruction on how to backup the database.
https://bugs.webkit.org/show_bug.cgi?id=133391

Rubber-stamped by Andreas Kling.

Install.md:

3:50 PM Changeset in webkit [169470] by matthew_hanson@apple.com

2 edits in tags/Safari-538.37/Source/WebKit2

Merge r169468. <rdar://problem/17067920>

3:47 PM Changeset in webkit [169469] by dburkart@apple.com

6 edits
1 copy in branches/safari-537.77-branch

Merge r166628.

3:26 PM Changeset in webkit [169468] by mark.lam@apple.com

2 edits in trunk/Source/WebKit2

Restoring FloatingPointEnvironment initialization that was accidentally rolled out by r169176.
<https://webkit.org/b/133389>

Rubber stamped by Oliver Hunt.

Shared/ios/ChildProcessIOS.mm:

(WebKit::ChildProcess::platformInitialize):

3:10 PM Changeset in webkit [169467] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[iOS WebGL] Fix depth buffer clearing issue.
https://bugs.webkit.org/show_bug.cgi?id=133388

Patch by Alex Christensen <achristensen@webkit.org> on 2014-05-29
Reviewed by Dean Jackson.

No new tests, but this fixes webgl/1.0.1/conformance/canvas/buffer-preserve-test.html.

platform/graphics/mac/WebGLLayer.mm:

(-[WebGLLayer display]):

platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::prepareTexture):
Moved marking the layer as composited from the mac-only prepareTexture to
the end of [WebGLLayer display] which is called by mac and iOS.

2:47 PM Changeset in webkit [169466] by enrica@apple.com

4 edits in trunk/Source/WebKit2

Need to notify the keyboard about every KeyDown event.
https://bugs.webkit.org/show_bug.cgi?id=133383
<rdar://problem/16633975>

Reviewed by Benjamin Poulain.

A key down will generate most of the time a call to the keyboard to add input or delete.
But the event could be handled by JavaScript and its default prevented.
We need to notify the keyboard in every case to allow updating its internal state about what has been typed.

UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::doneWithKeyEvent):

UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _didHandleKeyEvent:]):

2:44 PM Changeset in webkit [169465] by matthew_hanson@apple.com

17 edits in trunk/Source/WebKit2

Roll out r169439. <rdar://problem/17069364>

2:38 PM Changeset in webkit [169464] by jpfau@apple.com

2 edits in branches/safari-537.77-branch/Source/WebCore

Workaround for <rdar://problem/16848509>

Reviewed by David Kilzer.

platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::doUpdatePlatformRequest):

2:37 PM Changeset in webkit [169463] by matthew_hanson@apple.com

17 edits in tags/Safari-538.37/Source/WebKit2

Roll out r169439.

1:23 PM Changeset in webkit [169462] by timothy@apple.com

2 edits in trunk/Source/WebInspectorUI

Fix an exception in InspectorBackend.Command.prototype.supports.

https://bugs.webkit.org/show_bug.cgi?id=133384

Reviewed by Joseph Pecoraro.

UserInterface/Protocol/InspectorBackend.js:

(InspectorBackend.Command.prototype.supports): Use some not any.

1:14 PM Changeset in webkit [169461] by commit-queue@webkit.org

2 edits in trunk/Tools

[GTK] Add a WebKit2 Performance bot.
https://bugs.webkit.org/show_bug.cgi?id=132862

Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-05-29
Reviewed by Csaba Osztrogonác.

This adds a GTK WebKit2 perf bot.

BuildSlaveSupport/build.webkit.org-config/config.json:

1:01 PM Changeset in webkit [169460] by mitz@apple.com

4 edits in trunk/Source/WebKit2

[Cocoa] Can’t recover from subframe load errors
https://bugs.webkit.org/show_bug.cgi?id=133385

Reviewed by Anders Carlsson.

UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h: Declared new delegate method.
UIProcess/Cocoa/NavigationState.h: Added flag in m_navigationDelegateMethods struct.
UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::setNavigationDelegate): Initialize
webViewNavigationDidFailProvisionalLoadInSubframeWithError flag in the delegate methods
struct.
(WebKit::NavigationState::LoaderClient::didFailProvisionalLoadWithErrorForFrame): If the
error occurred in a subframe, invoke the new delegate method.

11:40 AM Changeset in webkit [169459] by mark.lam@apple.com

2 edits in trunk/LayoutTests

Gardening: marking js/primitive-property-access-edge-cases.html as crashy.
<https://webkit.org/b/133356>

Not reviewed.

TestExpectations:

11:38 AM Changeset in webkit [169458] by ggaren@apple.com

2 edits in trunk/Source/WebKit2

Added a missing @result to WKPreferences headerdoc
https://bugs.webkit.org/show_bug.cgi?id=133381

Reviewed by Dan Bernstein.

UIProcess/API/Cocoa/WKPreferences.h:

11:24 AM Changeset in webkit [169457] by ap@apple.com

10 edits
2 adds in trunk/Source/WebKit2

[Mac] Always use plug-in sandbox with sandboxed clients
https://bugs.webkit.org/show_bug.cgi?id=133358
<rdar://problem/15637695>

Reviewed by Anders Carlsson.

PluginProcess/mac/PluginProcessMac.mm: (WebKit::PluginProcess::initializeSandbox):

Refuse to start if parent process is sandboxed, and plug-in process is not going to be.
None of this should run in normal case, because there are also checks on UI process side.

Shared/Plugins/PluginModuleInfo.h:
Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

(WebKit::NetscapePluginModule::getPluginInfo):
Added a member to PluginModuleInfo, telling whether the plug-in has a sandbox profile.

Shared/Plugins/Netscape/mac/PluginInformationMac.mm:

(WebKit::getPlatformPluginModuleInformation): Use the new PluginModuleInfo member,
we no longer need to check the file system here.

WebKit2.xcodeproj/project.pbxproj:
Shared/mac/SandboxUtilities.h: Added.
Shared/mac/SandboxUtilities.cpp: Added. (WebKit::processIsSandboxed):

This code is simple, but include magic is not. Moved it to a separate file to
avoid repeating.

UIProcess/API/C/mac/WKContextPrivateMac.mm: Removed an unused include.

UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::shouldUsePlugin): Don't use unsandboxed plug-ins in
sandboxed applications.

UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::platformGetLaunchOptions): Don't ever pass disable-sandbox
from sandboxed processes.

Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:

(WebKit::XPCServiceInitializerDelegate::isClientSandboxed):
Use the new shared code in SandboxUtilities.h.

11:19 AM Changeset in webkit [169456] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Crash loading skydrive.com (assertion under RemoteLayerTreeDisplayRefreshMonitor)
https://bugs.webkit.org/show_bug.cgi?id=133370
<rdar://problem/17061361>

Reviewed by Anders Carlsson.

WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::didUpdate):
Copy the set of refresh monitors so that we don't try to mutate the list we're iterating,
and don't try to fire refresh monitors that were removed in a previous iteration of the loop.

11:06 AM Changeset in webkit [169455] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

REGRESSION (iOS WebKit2): Find-in-Page doesn't work in subframes
https://bugs.webkit.org/show_bug.cgi?id=133372
<rdar://problem/17045070>

Reviewed by Simon Fraser.

WebProcess/WebPage/ios/FindControllerIOS.mm:

(WebKit::FindController::willFindString):
(WebKit::FindController::didFailToFindString):
(WebKit::FindController::didHideFindIndicator):
Flip ignoreCompositionSelectionChange and updateAppearanceEnabled on all
frames, not just the main frame, because the found string can be in a subframe.
Ideally we would flip it on/off for each frame as we move the selection between them,
but would require a lot of work (and the overhead of touching each frame shouldn't be significant).

10:49 AM Changeset in webkit [169454] by mark.lam@apple.com

2 edits in trunk/LayoutTests

Gardening: marking js/primitive-property-access-edge-cases.html as flaky.
<https://webkit.org/b/133356>

Not reviewed.

TestExpectations:

10:40 AM Changeset in webkit [169453] by mitz@apple.com

2 edits in trunk/Tools

Fixed the WebKitTestRunner build after r169452.

WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::initialize):

10:27 AM Changeset in webkit [169452] by mitz@apple.com

7 edits in trunk/Source/WebKit2

WKBundleActivateMacFontAscentHack is unused
https://bugs.webkit.org/show_bug.cgi?id=133379

Reviewed by Anders Carlsson.

WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleActivateMacFontAscentHack): Deleted.

WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
WebProcess/InjectedBundle/InjectedBundle.h:
WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:

(WebKit::InjectedBundle::activateMacFontAscentHack): Deleted.

WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:

(WebKit::InjectedBundle::activateMacFontAscentHack): Deleted.

WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::activateMacFontAscentHack): Deleted.

10:09 AM Changeset in webkit [169451] by matthew_hanson@apple.com

5 edits in trunk/Source

Versioning.

9:41 AM Changeset in webkit [169450] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Perserve caption selection in fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=133350

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-05-29
Reviewed by Eric Carlson.

Use the logic from the inline player to calculate the selected caption index.

html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::mediaControlsHost):
Expose mediaControlsHost() for use by WebVideoFullscreenModelMediaElement.

platform/ios/WebVideoFullscreenModelMediaElement.mm:

(WebVideoFullscreenModelMediaElement::updateLegibleOptions):
Use logic from buildCaptionsMenu from mediaControlsApple.js.

9:26 AM Changeset in webkit [169449] by commit-queue@webkit.org

3 edits
2 adds in trunk

Use correct version of requiresFullscreenForVideoPlayback().
https://bugs.webkit.org/show_bug.cgi?id=133331

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-05-29
Reviewed by Eric Carlson.

Source/WebCore:
Test: media/video-fullscreeen-only-controls.html

Update the last place not yet using m_mediaSession->requiresFullscreenForVideoPlayback.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):
switch to media session version for requriesFullscreenForVideoPlayback.

LayoutTests:

media/video-fullscreeen-only-controls-expected.txt: Added.
media/video-fullscreeen-only-controls.html: Added. Make sure video element

controls show even when not specified if inline playback is restricted.

9:10 AM Changeset in webkit [169448] by ap@apple.com

3 edits
1 add in trunk/Source/WebKit2

Add a sandbox profile for com.apple.appstore.CodeRedeemerNetscapePlugin
https://bugs.webkit.org/show_bug.cgi?id=133360

Reviewed by Sam Weinig.

Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb: Looks like

anyone using camera would need access to CoreMedia preferences.

Resources/PlugInSandboxProfiles/com.apple.appstore.CodeRedeemerNetscapePlugin.sb: Added.

WebKit2.xcodeproj/project.pbxproj: Added the profile.

9:09 AM Changeset in webkit [169447] by fpizlo@apple.com

4 edits
1 add in trunk/Source

DFG::DCEPhase inserts into an insertion set in reverse, causing hilarious basic block corruption if you kill a lot of NewArrays
https://bugs.webkit.org/show_bug.cgi?id=133368

Reviewed by Mark Lam.

Source/JavaScriptCore:

dfg/DFGDCEPhase.cpp:

(JSC::DFG::DCEPhase::fixupBlock): Loop in the right order so that we insert in the right order.

tests/stress/new-array-dead.js: Added.

(foo):

Source/WTF:

wtf/Insertion.h:

(WTF::executeInsertions): This algorithm is only correct if insertions are added in the right order. Assert that the order is right.

9:05 AM Changeset in webkit [169446] by Carlos Garcia Campos

4 edits in trunk/Source

[GTK] Add support for HiDPI icons
https://bugs.webkit.org/show_bug.cgi?id=133377

Reviewed by Martin Robinson.

Source/WebCore:
Use the GTK+ missing icon at 16 or 32 size depending on the device
scale factor.

platform/graphics/gtk/ImageGtk.cpp:

(WebCore::loadMissingImageIconFromTheme):
(WebCore::Image::loadPlatformResource):

Source/WebKit2:

PlatformGTK.cmake: Compile also the @2x versions for the builtin icons.

8:10 AM Changeset in webkit [169445] by Carlos Garcia Campos

12 edits in trunk/Source

[GTK] Add HighDPI support for non-accelerated compositing contents
https://bugs.webkit.org/show_bug.cgi?id=131562

Patch by Owen Taylor <otaylor@redhat.com> on 2014-05-29
Reviewed by Anders Carlsson.

Source/WebCore:
No new tests. This will be tested once we have the proper dependencies in the WebKit testing
JHBuild.

platform/cairo/WidgetBackingStore.h:

(WebCore::WidgetBackingStore::WidgetBackingStore): Accept a device scale argument.

platform/cairo/WidgetBackingStoreCairo.cpp: Use the device scale argument to make the surface the proper size and set the surface device scale.
platform/cairo/WidgetBackingStoreCairo.h: Accept a device scale argument.
platform/graphics/cairo/CairoUtilities.cpp: Add a new helper to set the device scale if Cairo built against is new enough.
platform/graphics/cairo/CairoUtilities.h:
platform/gtk/GtkVersioning.h: Add the HAVE_GTK_SCALE_FACTOR macro.
platform/gtk/WidgetBackingStoreGtkX11.cpp: Use the device scale argument to make the surface the proper size and set the surface device scale.
platform/gtk/WidgetBackingStoreGtkX11.h: Accept a device scale argument.

Source/WebKit2:

UIProcess/API/gtk/WebKitWebViewBase.cpp:

(deviceScaleFactorChanged): Added this callback to pass scale changes to the page proxy.
(webkitWebViewBaseCreateWebPage): Attach the callback to the notify signal.

UIProcess/WebPageProxy.cpp:
UIProcess/cairo/BackingStoreCairo.cpp:

(WebKit::WebPageProxy::setCustomDeviceScaleFactor): Do not set a
custom device scale factor for cairo when it's not supported.
(WebKit::createBackingStoreForGTK): Pass the scale factor to the WebCore backing store.
(WebKit::BackingStore::incorporateUpdate): Ditto.

3:33 AM Changeset in webkit [169444] by Carlos Garcia Campos

8 edits in trunk/Source/WebKit2

[GTK] Use GMainLoopSource for idle and timeout sources in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=130081

Reviewed by Martin Robinson.

Platform/WorkQueue.h:
Platform/gtk/WorkQueueGtk.cpp:

(WorkQueue::registerSocketEventHandler): Stop pretending it's
possible to register a socket event handler for more than one
descriptor.
(WorkQueue::unregisterSocketEventHandler):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfter):

Shared/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::DownloadClient):
(WebKit::DownloadClient::~DownloadClient):
(WebKit::DownloadClient::didReceiveData):
(WebKit::DownloadClient::handleResponse):
(WebKit::DownloadClient::handleResponseLater):

UIProcess/Plugins/gtk/PluginInfoCache.cpp:

(WebKit::PluginInfoCache::PluginInfoCache):
(WebKit::PluginInfoCache::~PluginInfoCache):
(WebKit::PluginInfoCache::saveToFile):
(WebKit::PluginInfoCache::updatePluginInfo):

UIProcess/Plugins/gtk/PluginInfoCache.h:
WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::LayerTreeHostGtk):
(WebKit::LayerTreeHostGtk::layerFlushTimerFired):
(WebKit::LayerTreeHostGtk::scheduleLayerFlush):
(WebKit::LayerTreeHostGtk::cancelPendingLayerFlush):

WebProcess/WebPage/gtk/LayerTreeHostGtk.h:

2:38 AM Changeset in webkit [169443] by Carlos Garcia Campos

3 edits in trunk

[WK2][GTK] ASSERTION FAILED: m_status == Scheduled in GMainLoopSource
https://bugs.webkit.org/show_bug.cgi?id=131220

Reviewed by Philippe Normand.

Unskip inspector-protocol/dom/remove-multiple-nodes.html.

platform/gtk/TestExpectations:

May 28, 2014:

11:56 PM Changeset in webkit [169442] by matthew_hanson@apple.com

1 copy in tags/Safari-538.37

New Tag.

9:06 PM Changeset in webkit [169441] by yoon@igalia.com

2 edits in trunk/Tools

Unreviewed. Update my email addresses in contributors.json.

Scripts/webkitpy/common/config/contributors.json:

8:22 PM Changeset in webkit [169440] by Brent Fulgham

10 edits in trunk/Source/WebCore

Captions during HLS playback flash/are difficult to readily
https://bugs.webkit.org/show_bug.cgi?id=133365
<rdar://problem/16584132>

Reviewed by Eric Carlson.

Correct two problems:

Add new logic to handle cues that are identical to existing cues, except that they cover a slightly later moment in playback. For example, a cue encoding device might emit a cue at 24 fps, with many of the cues containing the same content but covering only 1/24th of a second.

Rather than hiding and displaying our cues at the cue encoding rate, we should
simply continue to display the same cue as long as the content is unchanged.

The cue "isEqual" logic for TextTrackCueGeneric improperly short-circuited the VTTCue isEqual logic. This was done to avoid a false failure due to the cue type being 'generic' rather than 'vtt', but incorrectly treated cues with non-matching text as equal.

html/track/DataCue.cpp:

(WebCore::DataCue::cueContentsMatch): Move cue comparison code to new method that
doesn't check that the 'type' of the cue is identical.
(WebCore::DataCue::isEqual): Modified to use new 'cueContentsMatch' method.
(WebCore::DataCue::isStartOfCue): Confirms cues match except for start and end times.

html/track/DataCue.h:
html/track/TextTrack.cpp:

(WebCore::TextTrack::hasCue): Modify to check if a new cue is simply a continuation
of an existing cue.

html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::cueContentsMatch): New method containing the equality code
that used to live in 'isEqual'.
(WebCore::TextTrackCue::isEqual): Modified to use new 'cueContentsMatch' method.
(WebCore::TextTrackCue::isStartOfCue): Confirms cues match except for start and
end times.

html/track/TextTrackCue.h:
html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGeneric::cueContentsMatch): New method containing the equality
code that used to live in 'isEqual'.
(WebCore::TextTrackCueGeneric::isEqual): Modified to use new 'cueContentsMatch' method.
(WebCore::TextTrackCueGeneric::isStartOfCue): Confirms cues match except for start and
end times.

html/track/TextTrackCueGeneric.h:
html/track/VTTCue.cpp:

(WebCore::VTTCue::cueContentsMatch): New method containing the equality code that
used to live in 'isEqual'.
(WebCore::VTTCue::isEqual): Modified to use new 'cueContentsMatch' method.
(WebCore::VTTCue::isStartOfCue): Confirms cues match except for start and end times.

html/track/VTTCue.h:

6:41 PM Changeset in webkit [169439] by barraclough@apple.com

17 edits in trunk/Source/WebKit2

viewStateDidChange should always fully update ViewState
https://bugs.webkit.org/show_bug.cgi?id=133159

Reviewed by Anders Carlson.

Currently WebPageProxy::viewStateDidChange is passed a mask of bits to update.

This has the following negative consequences:

– WKWebView implicitly requires more detailed knowledge of the internal implementation of the PageClient.
– Updates may unnecessarily be split over multiple IPC messages.
– In order to support partial updates we make multiple virtual function calls to PageClient, which then makes duplicate objc calls.

Better to just always update the entire ViewState.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView didMoveToWindow]):

removed argument to viewStateDidChange.

UIProcess/API/gtk/PageClientImpl.cpp:

UIProcess/API/gtk/PageClientImpl.h:
- merged isViewWindowActive/isViewFocused/isViewVisible/isViewInWindow to viewState.
UIProcess/API/mac/WKView.mm:

(-[WKView becomeFirstResponder]):
(-[WKView resignFirstResponder]):
(-[WKView viewDidMoveToWindow]):
(-[WKView _windowDidBecomeKey:]):
(-[WKView _windowDidResignKey:]):
(-[WKView _windowDidMiniaturize:]):
(-[WKView _windowDidDeminiaturize:]):
(-[WKView _windowDidOrderOffScreen:]):
(-[WKView _windowDidOrderOnScreen:]):
(-[WKView _windowDidChangeOcclusionState:]):
(-[WKView viewDidHide]):
(-[WKView viewDidUnhide]):
(-[WKView _activeSpaceDidChange:]):
(-[WKView _setThumbnailView:]):
(-[WKView endDeferringViewInWindowChanges]):
(-[WKView endDeferringViewInWindowChangesSync]):

removed argument to viewStateDidChange.

UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::viewState):
(WebKit::WebView::isViewWindowActive): Deleted.
(WebKit::WebView::isViewFocused): Deleted.
(WebKit::WebView::isViewVisible): Deleted.
(WebKit::WebView::isViewInWindow): Deleted.

UIProcess/CoordinatedGraphics/WebView.h:
- merged isViewWindowActive/isViewFocused/isViewVisible/isViewInWindow to viewState.
UIProcess/PageClient.h:

(WebKit::PageClient::isViewVisibleOrOccluded): Deleted.
(WebKit::PageClient::isVisuallyIdle): Deleted.

merged isViewVisibleOrOccluded/isVisuallyIdle to subclass viewState methods.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):

updateViewState -> PageClient::viewState

(WebKit::WebPageProxy::viewStateDidChange):

argument removed; updateViewState -> PageClient::viewState.

(WebKit::WebPageProxy::setCursor):

call isViewWindowActive on WebPageProxy, rather than PageClient.

(WebKit::WebPageProxy::updateBackingStoreDiscardableState):

call isViewWindowActive on WebPageProxy, rather than PageClient.

(WebKit::WebPageProxy::updateViewState): Deleted.

removed - viewState method moved to PageClient.

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::isViewWindowActive):

added missing implementation.

(WebKit::WebPageProxy::isViewVisible):

removed argument to viewStateDidChange.

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::windowServerConnectionStateChanged):

removed argument to viewStateDidChange.

UIProcess/ios/PageClientImplIOS.h:
UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::viewState):
(WebKit::PageClientImpl::isViewWindowActive): Deleted.
(WebKit::PageClientImpl::isViewFocused): Deleted.
(WebKit::PageClientImpl::isViewVisible): Deleted.
(WebKit::PageClientImpl::isViewInWindow): Deleted.
(WebKit::PageClientImpl::isViewVisibleOrOccluded): Deleted.
(WebKit::PageClientImpl::isVisuallyIdle): Deleted.

merged isViewWindowActive/isViewFocused/isViewVisible/isViewInWindow to viewState.

UIProcess/ios/WKContentView.mm:

(-[WKContentView didMoveToWindow]):
(-[WKContentView _applicationDidEnterBackground:]):
(-[WKContentView _applicationWillEnterForeground:]):

removed argument to viewStateDidChange.

UIProcess/mac/PageClientImpl.h:
UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::viewState):
(WebKit::PageClientImpl::showCorrectionPanel):
(WebKit::PageClientImpl::showDictationAlternativeUI):
(WebKit::PageClientImpl::isViewWindowActive): Deleted.
(WebKit::PageClientImpl::isViewFocused): Deleted.
(WebKit::PageClientImpl::isViewVisibleOrOccluded): Deleted.
(WebKit::PageClientImpl::isVisuallyIdle): Deleted.

merged isViewWindowActive/isViewFocused/isViewVisible/isViewInWindow to viewState.

4:26 PM Changeset in webkit [169438] by oliver@apple.com

10 edits in trunk/Source/WebCore

Whoops, update bindings tests results.

4:14 PM Changeset in webkit [169437] by jpfau@apple.com

4 edits in trunk/Source/WebKit2

Add Obj-C API for cache partitioned URL schemes
https://bugs.webkit.org/show_bug.cgi?id=133361
<rdar://problem/17035415>

Reviewed by Anders Carlsson.

UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _initWithConfiguration:]):

UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:

(-[_WKProcessPoolConfiguration cachePartitionedURLSchemes]):
(-[_WKProcessPoolConfiguration setCachePartitionedURLSchemes:]):
(-[_WKProcessPoolConfiguration copyWithZone:]):

3:54 PM Changeset in webkit [169436] by weinig@apple.com

2 edits in trunk/Source/WebKit2

[iOS WebKit2] Sometimes Safari gets into a limbo state after web process crash
<rdar://problem/17029526>
https://bugs.webkit.org/show_bug.cgi?id=133362

Reviewed by Dan Bernstein.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
Remove unnecessary initialization of a unique_ptr.

(WebKit::WebPageProxy::reattachToWebProcess):
Move calls to update the view state and activity tokens to after we have swapped in the new process.

(WebKit::WebPageProxy::resetStateAfterProcessExited):
Clear the activity token on process exit.

2:48 PM Changeset in webkit [169435] by timothy_horton@apple.com

3 edits in trunk/Source/WebKit2

Add WKWebView SPI to forcefully kill the associated Web process
https://bugs.webkit.org/show_bug.cgi?id=133357

Reviewed by Anders Carlsson.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _killWebContentProcess]):

UIProcess/API/Cocoa/WKWebViewPrivate.h:

2:28 PM Changeset in webkit [169434] by mhock@apple.com

2 edits in trunk/LayoutTests

Marking test as flaky pending further review.
https://bugs.webkit.org/show_bug.cgi?id=133351

Unreviewed gardening.

TestExpectations:

Skip css3/viewport-percentage-lengths/viewport-percentage-lengths-relative-font-size.html

1:54 PM Changeset in webkit [169433] by oliver@apple.com

14 edits in trunk

Make DOM properties exposed as instance properties use the base object instead of |this|
https://bugs.webkit.org/show_bug.cgi?id=133353

Reviewed by Geoffrey Garen.

Source/WebCore:
Make the bindings generator emit code that uses the base object for
a property, rather than the this object. This means that attributes
that we need to be treated as instance properties will match their old
instance-based behaviour.

bindings/scripts/CodeGeneratorJS.pm:

(InterfaceRequiresAttributesOnInstanceForCompatibility):
(InterfaceRequiresAttributesOnInstance):
(GetCastingHelperForBaseObject):
(GenerateImplementation):

bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::jsTestActiveDOMObjectExcitingAttr):

bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::jsTestExceptionName):

bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::jsTestInterfaceImplementsStr3):
(WebCore::jsTestInterfaceSupplementalStr3):
(WebCore::setJSTestInterfaceConstructorImplementsStaticAttr):
(WebCore::setJSTestInterfaceImplementsStr2):
(WebCore::setJSTestInterfaceImplementsStr3):
(WebCore::setJSTestInterfaceImplementsNode):
(WebCore::setJSTestInterfaceConstructorSupplementalStaticAttr):
(WebCore::setJSTestInterfaceSupplementalStr2):
(WebCore::setJSTestInterfaceSupplementalStr3):
(WebCore::setJSTestInterfaceSupplementalNode):

bindings/scripts/test/JS/JSTestNondeterministic.cpp:

(WebCore::setJSTestNondeterministicNondeterministicWriteableAttr):
(WebCore::setJSTestNondeterministicNondeterministicExceptionAttr):
(WebCore::setJSTestNondeterministicNondeterministicGetterExceptionAttr):
(WebCore::setJSTestNondeterministicNondeterministicSetterExceptionAttr):
(WebCore::setJSTestSerializedScriptValueInterfaceCachedValue):

bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::jsTestTypedefsConstructorTestSubObj):
(WebCore::setJSTestTypedefsUnsignedLongLongAttr):
(WebCore::setJSTestTypedefsImmutableSerializedScriptValue):
(WebCore::setJSTestTypedefsAttrWithGetterException):
(WebCore::setJSTestTypedefsAttrWithSetterException):
(WebCore::setJSTestTypedefsStringAttrWithGetterException):
(WebCore::setJSTestTypedefsStringAttrWithSetterException):

LayoutTests:
Update tests to cover change in expected behaviour.

js/dom/dom-as-prototype-assignment-exception-expected.txt:
js/dom/dom-attributes-on-mismatch-type-expected.txt:
js/dom/dom-attributes-on-mismatch-type.html:
js/dom/script-tests/dom-as-prototype-assignment-exception.js:

1:26 PM Changeset in webkit [169432] by mitz@apple.com

2 edits in trunk/Source/WebKit2

[Cocoa] Crash when trying to decode an instance of a class inheriting from WKObject
https://bugs.webkit.org/show_bug.cgi?id=133355

Reviewed by Anders Carlsson.

Shared/Cocoa/WKObject.mm:

(-[WKObject classForCoder]): Override this NSObject method to forward to the
target object.
(-[WKObject classForKeyedArchiver]): Ditto.

12:41 PM Changeset in webkit [169431] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix not-x86 32-bit.

llint/LowLevelInterpreter32_64.asm:

12:34 PM Changeset in webkit [169430] by Simon Fraser

5 edits in trunk/Source

[iOS WK2] Improve behavior of position:fixed inside accelerated overflow-scroll
https://bugs.webkit.org/show_bug.cgi?id=133352

Reviewed by Tim Horton.

Source/WebCore:
When adjusting layers inside accelerated overflow-scroll, pass a delta
down to descendant nodes. Fix behavior of sticky nodes inside fixed nodes
inside overflow scroll (sticky should only be affected if the parent node
is a scrolling node).

page/scrolling/mac/ScrollingTreeFixedNode.mm:

(WebCore::ScrollingTreeFixedNode::updateLayersAfterAncestorChange): Just remove
some .get()

page/scrolling/mac/ScrollingTreeStickyNode.mm:

(WebCore::ScrollingTreeStickyNode::updateLayersAfterAncestorChange): Remove .get()s.
We never care about the cumulative delta here, because sticky nodes only respond to
changes in their direct scrolling ancestors. Only adjust the layer if the parent
is a scrolling node.

Source/WebKit2:
Pass the correct delta down to descendant nodes.

UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:

(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateChildNodesAfterScroll):

12:21 PM Changeset in webkit [169429] by jhoneycutt@apple.com

2 edits
2 adds in trunk/Tools

Need an API test for bug #133193 (r169315)
<https://bugs.webkit.org/show_bug.cgi?id=133324>

This adds an API test that ensures that calling "stop loading" during a
"did fail provisional load" callback doesn't crash.

Reviewed by Andy Estes.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Add new files to project.

TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: Added.

(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
If the message is the "test done" message, record that.
(TestWebKitAPI::setInjectedBundleClient):
Register a function for the "did receive message from injected bundle"
callback.
(TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
Assert that we received the message from the injected bundle, and set
'done' to finish the test.
(TestWebKitAPI::TEST):
Create a WebView, register a page loader client for the "did fail
provisional load" callback, and load a non-existent resource.

TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: Added.

(TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::StopLoadingDuringDidFailProvisionalLoadTest):
(TestWebKitAPI::didFailProvisionalLoadWithErrorForFrameCallback):
Tell the StopLoadingDuringDidFailProvisionalLoadTest object that the
provisional load failed.
(TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didCreatePage):
Register a page loader client for the "did fail provisional load"
callback.
(TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didFailProvisionalLoad):
Call WKBundlePageStopLoading() during the callback. This not crashing
is what we're ensuring with this test.

11:59 AM Changeset in webkit [169428] by fpizlo@apple.com

3 edits
2 adds in trunk/Source/JavaScriptCore

Arrayify neglects to inform the clobberizer that it might fire watchpoints
https://bugs.webkit.org/show_bug.cgi?id=133340

Reviewed by Mark Lam.

dfg/DFGClobberize.h:

(JSC::DFG::clobberize): Be honest.

llint/LowLevelInterpreter32_64.asm: Profile the object, not its structure.
tests/stress/arrayify-fires-watchpoint.js: Added.

(foo):
(test):
(makeObjectArray):

tests/stress/arrayify-structure-bad-test.js: Added.

(foo):
(test):

11:31 AM Changeset in webkit [169427] by Chris Fleizach

2 edits
2 adds in trunk

AX: WebKit does not recognize ARIA 1.1 tables
https://bugs.webkit.org/show_bug.cgi?id=133163

Reviewed by Darin Adler.

The AXObjectCache code that determines which object to create based on the role needs to be token fallback aware.

Test: accessibility/table-fallback-roles-expose-element-attributes.html

accessibility/AXObjectCache.cpp:

(WebCore::nodeHasRole):

11:07 AM Changeset in webkit [169426] by aestes@apple.com

3 edits in trunk/Source/WebKit2

[iOS] REGRESSION (r168388): DidNotHandleTapAsClick not sent when commitPotentialTap() fails
https://bugs.webkit.org/show_bug.cgi?id=133349

Reviewed by Benjamin Poulain.

WebPage::commitPotentialTap() fails when a recognized single tap cannot be sent as a synthetic click event.
We should send WebPageProxy::DidNotHandleTapAsClick in these cases.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::commitPotentialTap):
(WebKit::WebPage::commitPotentialTapFailed):

9:38 AM Changeset in webkit [169425] by stavila@adobe.com

4 edits
2 adds in trunk

REGRESSION (r168046): Invalid layout in multicol
https://bugs.webkit.org/show_bug.cgi?id=133322

Reviewed by Antti Koivisto.

Source/WebCore:
In some situations, deleting the line boxes of a multicol element causes the line to region
link to become invalid.

Test: fast/multicol/newmulticol/multicol-inside-multicol.html

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::clearLinesToRegionMap):
(WebCore::RenderFlowThread::deleteLines):
(WebCore::RenderFlowThread::willBeDestroyed):

rendering/RenderFlowThread.h:

LayoutTests:

fast/multicol/newmulticol/multicol-inside-multicol-expected.html: Added.
fast/multicol/newmulticol/multicol-inside-multicol.html: Added.

9:22 AM Changeset in webkit [169424] by commit-queue@webkit.org

8 edits in trunk/Source/WebKit2

Unreviewed, rolling out r169423.
https://bugs.webkit.org/show_bug.cgi?id=133348

It makes a lot of tests crash in assert (Requested by KaL on
#webkit).

Reverted changeset:

"[GTK] Use GMainLoopSource for idle and timeout sources in
WebKit2"
https://bugs.webkit.org/show_bug.cgi?id=130081
http://trac.webkit.org/changeset/169423

8:34 AM Changeset in webkit [169423] by Carlos Garcia Campos

8 edits in trunk/Source/WebKit2

[GTK] Use GMainLoopSource for idle and timeout sources in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=130081

Reviewed by Martin Robinson.

Platform/WorkQueue.h:
Platform/gtk/WorkQueueGtk.cpp:

Shared/Downloads/soup/DownloadSoup.cpp:

UIProcess/Plugins/gtk/PluginInfoCache.cpp:

(WebKit::PluginInfoCache::PluginInfoCache):
(WebKit::PluginInfoCache::~PluginInfoCache):
(WebKit::PluginInfoCache::saveToFile):
(WebKit::PluginInfoCache::updatePluginInfo):

UIProcess/Plugins/gtk/PluginInfoCache.h:
WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::LayerTreeHostGtk):
(WebKit::LayerTreeHostGtk::layerFlushTimerFired):
(WebKit::LayerTreeHostGtk::scheduleLayerFlush):
(WebKit::LayerTreeHostGtk::cancelPendingLayerFlush):

WebProcess/WebPage/gtk/LayerTreeHostGtk.h:

7:28 AM Changeset in webkit [169422] by mitz@apple.com

7 edits in trunk/Source/WebKit2

[Cocoa] Can't use bundle-defined classes for bundle parameters
https://bugs.webkit.org/show_bug.cgi?id=133339

Reviewed by Anders Carlsson.

Ensure that bundle parameters are decoded only after the injected bundle is loaded.

WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::create): Moved the definition from the header to here, added the
lagacy initializationUserData as a parameter, and made this function set the sandbox
extension and load the bundle.
(WebKit::InjectedBundle::InjectedBundle): Removed call to platformInitialize.

WebProcess/InjectedBundle/InjectedBundle.h:

(WebKit::InjectedBundle::setSandboxExtension): Deleted.

WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::initialize): Renamed the load function to this, and added the
creation parameters as a parameter. Moved code to initialize the bundle paramters from
platformInitialize to here. Changed the class passed to -decodeObjectOfClass:forKey: to
NSObject, to allow arbitrary types in the values, and added an assertion that the
top-level object is a dictionary.
(WebKit::InjectedBundle::platformInitialize): Deleted.

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess): Changed to pass the legacy initialization user
data to InjectedBundle::create() and removed code to separately set the sandbox extension
and load the bundle, which is now done by create().

6:28 AM Changeset in webkit [169421] by berto@igalia.com