Timeline
May 30, 2014:
- 10:12 PM Changeset in webkit [169502] by
-
- 2 edits1 add in trunk/PerformanceTests
DYEBench spits out 404 errors for learn.json
https://bugs.webkit.org/show_bug.cgi?id=133416
Reviewed by Oliver Hunt.
Add an empty learn.json file so that it won't cause a 404 error when hosted on a http server.
Bumped the version number to 0.12.
- DoYouEvenBench/Full.html:
- DoYouEvenBench/resources/todomvc/learn.json:
- 5:56 PM Changeset in webkit [169501] by
-
- 8 edits in trunk/Source/WebKit2
[iOS][WK2] When a page does not finish rotation before the end of the animation, synchronize explicitely
https://bugs.webkit.org/show_bug.cgi?id=133364
<rdar://problem/17026333>
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-05-30
Reviewed by Sam Weinig.
When a page that does layout on rotation does not respond before the end of the animation, we end up with
a completely inconsistent state on the UIProcess (because it is unware of the new states).
The perfect way to fix this would be to make animated resize transactional and have the WebProcess resolve
conflicts. That is very complicated and the issue is uncommon, so this patch does not do that.
This patch force the synchronization whenever we finish the animation before we heard back
from the WebProcess.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _endAnimatedResize]):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::resetState):
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::dynamicViewportSizeUpdate):
(WebKit::WebPageProxy::synchronizeDynamicViewportUpdate):
(WebKit::WebPageProxy::dynamicViewportUpdateChangedTarget):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::dynamicViewportSizeUpdate):
(WebKit::WebPage::synchronizeDynamicViewportUpdate):
- 5:12 PM Changeset in webkit [169500] by
-
- 12 edits in trunk/Source
REGRESSION (WebKit2): space space to insert period doesn't work in web forms.
https://bugs.webkit.org/show_bug.cgi?id=133413
<rdar://problem/16948333>
Reviewed by Benjamin Poulain.
Source/WebCore:
Adding utility functions and their exports.
- WebCore.exp.in:
- editing/TextIterator.cpp:
(WebCore::plainTextReplacingNoBreakSpace):
- editing/TextIterator.h:
- editing/VisibleUnits.cpp:
(WebCore::charactersAroundPosition):
(WebCore::characterBeforePosition): Deleted.
- editing/VisibleUnits.h:
Source/WebKit2:
iOS TextInput needs to know about content surrounding the
current position while editing. Since we don't want to
query this information synchronously when asked, we cache it
as part of the EditorState. EditorState now contains a vector of
three characters representing the content after, before and two
position before the caret position.
The patch also replaces all calls to plainText with plainTextReplacingNoBreakSpace
to work well with iOS text input.
- Shared/EditorState.cpp:
(WebKit::EditorState::encode):
(WebKit::EditorState::decode):
- Shared/EditorState.h:
(WebKit::EditorState::EditorState):
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _characterInRelationToCaretSelection:]):
(+[WKAutocorrectionContext autocorrectionContextWithData:markedText:selectedText:afterText:selectedRangeInMarkedText:]):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::requestDictationContext):
(WebKit::WebPage::replaceSelectedText):
(WebKit::WebPage::replaceDictatedText):
(WebKit::WebPage::requestAutocorrectionData):
(WebKit::WebPage::syncApplyAutocorrection):
(WebKit::computeAutocorrectionContext):
- 4:10 PM Changeset in webkit [169499] by
-
- 1 copy in tags/Safari-537.77.3
Tagging it
- 4:03 PM Changeset in webkit [169498] by
-
- 2 edits in trunk/Source/WebCore
Cleanup temporary setting of image interpolation quality in GraphicsContext::drawImage*
https://bugs.webkit.org/show_bug.cgi?id=133407
Reviewed by Darin Adler.
Add helper class to set/reset image interpolation quality value.
No change in functionality.
- platform/graphics/GraphicsContext.cpp:
(WebCore::InterpolationQualityMaintainer::InterpolationQualityMaintainer):
(WebCore::InterpolationQualityMaintainer::~InterpolationQualityMaintainer):
(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawTiledImage):
(WebCore::GraphicsContext::drawImageBuffer):
- 2:51 PM Changeset in webkit [169497] by
-
- 2 edits in trunk/Source/WebKit2
Fixed the build by adding back a declaration I deleted by accident :(.
Unreviewed.
- UIProcess/API/Cocoa/WKWebView.h:
- 2:41 PM Changeset in webkit [169496] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
Fixed some ChangeLog grammar.
- 2:41 PM Changeset in webkit [169495] by
-
- 16 edits in trunk/Source/WebKit2
Unreviewed, rolling in r169490.
I change a non-ASCII apostrophe to ASCII.
Restored changeset:
"Some more copy-editing of the Modern WebKit headerdoc"
https://bugs.webkit.org/show_bug.cgi?id=133408
http://trac.webkit.org/changeset/169490
- UIProcess/API/Cocoa/WKBackForwardList.h:
- UIProcess/API/Cocoa/WKBackForwardListItem.h:
- UIProcess/API/Cocoa/WKFrameInfo.h:
- UIProcess/API/Cocoa/WKNavigation.h:
- UIProcess/API/Cocoa/WKNavigationAction.h:
(NS_ENUM):
- UIProcess/API/Cocoa/WKNavigationDelegate.h:
(NS_ENUM):
- UIProcess/API/Cocoa/WKNavigationResponse.h:
- UIProcess/API/Cocoa/WKPreferences.h:
- UIProcess/API/Cocoa/WKProcessPool.h:
- UIProcess/API/Cocoa/WKScriptMessage.h:
- UIProcess/API/Cocoa/WKScriptMessageHandler.h:
- UIProcess/API/Cocoa/WKUIDelegate.h:
- UIProcess/API/Cocoa/WKUserContentController.h:
- UIProcess/API/Cocoa/WKWebView.h:
- UIProcess/API/Cocoa/WKWebViewConfiguration.h:
- 2:25 PM Changeset in webkit [169494] by
-
- 2 edits in branches/safari-537.77-branch/Source/WebCore
Supplementary build fix for <rdar://problem/16848509>, borrowed from <rdar://problem/16701806>.
- 2:07 PM Changeset in webkit [169493] by
-
- 16 edits in trunk/Source/WebKit2
Unreviewed, rolling out r169490.
It broke the build with a mysterious warning about ASCII
Reverted changeset:
"Some more copy-editing of the Modern WebKit headerdoc"
https://bugs.webkit.org/show_bug.cgi?id=133408
http://trac.webkit.org/changeset/169490
- 1:59 PM Changeset in webkit [169492] by
-
- 2 edits in trunk/Source/WebCore
Support -apple-system-font on OS X
https://bugs.webkit.org/show_bug.cgi?id=133382
Addressing post-review comments.
- platform/mac/WebFontCache.mm:
(+[WebFontCache internalFontWithFamily:traits:weight:size:]):
- 12:26 PM Changeset in webkit [169491] by
-
- 2 edits in trunk/Source/WebCore
Remove repetitive header in HTMLInputElement.cpp
https://bugs.webkit.org/show_bug.cgi?id=133376
Patch by Prashant Hiremath <hiremathprashants@gmail.com> on 2014-05-30
Reviewed by Anders Carlsson.
It is just removal repeative headers hence no test needed.
- html/HTMLInputElement.cpp:
- 12:11 PM Changeset in webkit [169490] by
-
- 16 edits in trunk/Source/WebKit2
Some more copy-editing of the Modern WebKit headerdoc
https://bugs.webkit.org/show_bug.cgi?id=133408
Reviewed by Beth Dakin.
A copy-editor suggested some edits to the headerdoc for clarity,
style, and formatting.
I reviewed the edits and accepted about 80% of them.
- UIProcess/API/Cocoa/WKBackForwardList.h:
- UIProcess/API/Cocoa/WKBackForwardListItem.h:
- UIProcess/API/Cocoa/WKFrameInfo.h:
- UIProcess/API/Cocoa/WKNavigation.h:
- UIProcess/API/Cocoa/WKNavigationAction.h:
(NS_ENUM):
- UIProcess/API/Cocoa/WKNavigationDelegate.h:
(NS_ENUM):
- UIProcess/API/Cocoa/WKNavigationResponse.h:
- UIProcess/API/Cocoa/WKPreferences.h:
- UIProcess/API/Cocoa/WKProcessPool.h:
- UIProcess/API/Cocoa/WKScriptMessage.h:
- UIProcess/API/Cocoa/WKScriptMessageHandler.h:
- UIProcess/API/Cocoa/WKUIDelegate.h:
- UIProcess/API/Cocoa/WKUserContentController.h:
- UIProcess/API/Cocoa/WKWebView.h:
- UIProcess/API/Cocoa/WKWebViewConfiguration.h:
- 11:19 AM Changeset in webkit [169489] by
-
- 2 edits in trunk/Tools
Change run-jsc-stress-tests to not resolve jsc path locally when creating a bundle
https://bugs.webkit.org/show_bug.cgi?id=133409
Reviewed by Filip Pizlo.
Handle creating a tarball the same way as running remote when processing
paths in prepareBundle.
- Scripts/run-jsc-stress-tests:
- 9:49 AM Changeset in webkit [169488] by
-
- 4 edits in trunk/LayoutTests
[GTK] Don't use logAccessibilityEvents() in aria-slider-required-attributes.html
https://bugs.webkit.org/show_bug.cgi?id=133405
Reviewed by Chris Fleizach.
Change the test to use addNotificationListener() instead.
- platform/gtk/TestExpectations: Removed failure expectation
- platform/gtk/accessibility/aria-slider-required-attributes-expected.txt: Updated
- platform/gtk/accessibility/aria-slider-required-attributes.html: Updated
- 9:47 AM Changeset in webkit [169487] by
-
- 6 edits in trunk
[ATK] Deprecate usage of logAccessibilityEvents() in layout tests
https://bugs.webkit.org/show_bug.cgi?id=132280
Reviewed by Chris Fleizach.
Tools:
Remove implementation of logAccessibilityEvents() for ATK based
ports, as this has proved to be a flaky method of checking that
ATK events are being properly emitted. Instead, it's better to use
the addNotificationListener() functions and provide a JS callback
to check that the right events are being emmitted from the tests.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
(WTR::AccessibilityController::logAccessibilityEvents): Replaced
with dummy implementation.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
(WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Removed
LayoutTests:
Removed 36 flaky expectations from TestExpectations for tests that
were ocassionally showing the output of logAccessibilityEvents()
even if they did not make use of that feature (thus the flakiness).
- platform/gtk/TestExpectations: Updated.
- 8:43 AM Changeset in webkit [169486] by
-
- 3 edits in trunk/Source/WebKit2
Crash loading skydrive.com (assertion under RemoteLayerTreeDisplayRefreshMonitor)
https://bugs.webkit.org/show_bug.cgi?id=133370
<rdar://problem/17061361>
Reviewed by Darin Adler.
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::willDestroyDisplayRefreshMonitor):
(WebKit::RemoteLayerTreeDrawingArea::didUpdate):
Post-landing review comments from Darin noted that checking if the
DrawingArea's m_displayRefreshMonitors contains the monitor in the
list to notify is insufficient, because a new one could have been
added with the same address. Instead, copy the HashSet, removing
at random from it and firing didUpdateLayers, but *also* removing
from it in the willDestroyDisplayRefreshMonitor callback.
This is very similar to what DisplayRefreshMonitor itself does internally
(we don't have to duplicate its code to avoid re-entry because it is
already impossible to re-enter didUpdate).
- 8:20 AM Changeset in webkit [169485] by
-
- 3 edits in trunk/Tools
[ATK] Deprecate usage of logAccessibilityEvents() in layout tests
https://bugs.webkit.org/show_bug.cgi?id=132280
Rubber stamped by Carlos Garcia Campos.
Fix two small issues with previous patch (r169483), that caused some tests to break.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
(WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Removed
duplicated entry.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::setSelectedTextRange): Fix boolean condition.
- 7:16 AM Changeset in webkit [169484] by
-
- 7 edits in trunk/Source/WebCore
Remove redundant GraphicsContext::drawImage() function.
https://bugs.webkit.org/show_bug.cgi?id=133347
Reviewed by Simon Fraser.
There are 2 GraphicsContext::drawImage functions with very similar parameter list. This looks
to be a source of confusion and results in passing unneeded parameters.
No change in functionality.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::drawImageToContext):
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImage):
- platform/graphics/GraphicsContext.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::paint):
- platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::updateContents):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintNinePieceImage):
- 3:58 AM Changeset in webkit [169483] by
-
- 10 edits6 adds in trunk
Tools: [ATK] Added new accessibility signal: text-caret-moved.
Make AccessibilityUIElement.setSelectedTextRange work
as atk_text_set_caret_offset when given offset == 0.
https://bugs.webkit.org/show_bug.cgi?id=132527
Patch by Jarek Czekalski <Jarek Czekalski> on 2014-05-30
Reviewed by Mario Sanchez Prada.
text-caret-moved signal in accessibilityController is needed to
implement tests from Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c
as LayoutTests. Add the signal to the controller.
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
- WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(setSelectedTextRange): Change return type to bool.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(setSelectedTextRange): Call atk_text_set_caret_offset and return bool.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
(axObjectEventListener): Add notification name AXTextCaretMoved, allow
for extra arguments passed to handler and use it for text-caret-moved offset.
(WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
Connect callback to new listener for ATK:AtkText:text-caret-moved.
Refactor so that failures be reported.
Initialize atk interfaces before trying to connect to them, see
https://bugzilla.gnome.org/show_bug.cgi?id=729922
(WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
Simplify code by using a vector in place of dozen variables.
- DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
Comment about not synchronizing with accessibilityController.
LayoutTests: [ATK] Convert caret offset tests from testatk.c.
https://bugs.webkit.org/show_bug.cgi?id=132527
Patch by Jarek Czekalski <Jarek Czekalski> on 2014-05-30
Reviewed by Mario Sanchez Prada.
The tests are replicated from testatk.c file, functions
testWebkitAtkCaretOffsets()
testWebkitAtkCaretOffsetsAndExtranousWhiteSpaces()
The file was present in webkit1. Removed from trunk in r166977, so
the last version was
https://trac.webkit.org/browser/trunk/Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c?rev=166976
What could not be verified in the same way:
- Whether element implements ATK_TEXT. If setCaretOffset
succeeds, it confirms that element is text as well. But in cases
when setCaretOffset must fail I see no way to confirm it is text
element.
- Whether position is correct through a call to
atk_text_get_caret_offset. text-caret-moved signal value is
tested instead.
Anyway these cases don't look crucial, so they are skipped.
- platform/gtk/resources/atk-helpers.js: Added.
(setCaretOffset): Added.
- platform/gtk/accessibility/caret-offsets-and-extraneous-white-spaces-expected.txt: Added.
- platform/gtk/accessibility/caret-offsets-and-extraneous-white-spaces.html: Added.
- platform/gtk/accessibility/caret-offsets-expected.txt: Added.
- platform/gtk/accessibility/caret-offsets.html: Added.
May 29, 2014:
- 7:11 PM Changeset in webkit [169482] by
-
- 5 edits in branches/safari-537.77-branch/Source
Bump versioning to 537.77.3
- 5:56 PM Changeset in webkit [169481] by
-
- 1 copy in tags/Safari-537.77.2
New TaG
- 5:52 PM Changeset in webkit [169480] by
-
- 2 edits in trunk/Source/WTF
Enable css jit by default on arm64.
https://bugs.webkit.org/show_bug.cgi?id=133246
<rdar://problem/17073407>
Reviewed by Benjamin Poulain.
- wtf/Platform.h:
Added arm64 to list of supported architectures.
- 5:25 PM Changeset in webkit [169479] by
-
- 4 edits in trunk/Source/WebCore
Prepare css jit for arm64 and other architectures.
https://bugs.webkit.org/show_bug.cgi?id=133394
Reviewed by Benjamin Poulain.
- cssjit/FunctionCall.h:
(WebCore::FunctionCall::swapArguments):
- cssjit/RegisterAllocator.h:
Use a designated temporary register on arm64 to prevent using a deallocated argument register to swap argument registers in.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
Added assertion to make sure there are enough registers.
- 5:15 PM Changeset in webkit [169478] by
-
- 14 edits in trunk/Source/WebCore
CSS JIT: add support for the pseudo classes :hover and :active
https://bugs.webkit.org/show_bug.cgi?id=133295
Reviewed by Andreas Kling.
This patch adds compilation support for :hover and :active. The code generation of both of them is trivial,
most of the patch is improving the infrastructure and safety.
The document compatibility mode is moved to its own typed enum. This ensure the values are exclusives and
the native type is known (unsigned char here). The values are changes to binary flags to take advantage of
test-and-branch on ARM64 (not used explicitely, it is automatically generated by the MacroAssembler).
The other important refactoring is the code updating the flags on RenderStyle::NonInheritedFlags.
The code was duplicated in some places so it is move into its own function addFlagToElementStyleFromContext().
The generators themself are very simple. First we check the quirks-mode exceptions, that is generally excluded
at compile time because the conditions are almost never met, even in strict mode.
Then we have two cases: style resolution and query selector. Almost everything is just function calls.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorFragment::SelectorFragment):
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::addFlagToElementStyleFromContext):
(WebCore::SelectorCompiler::fragmentOnlyMatchesLinksInQuirksMode):
(WebCore::SelectorCompiler::getDocument):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSpecialFailureInQuirksModeForActiveAndHoverIfNeeded):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::elementIsActive):
(WebCore::SelectorCompiler::elementIsActiveForStyleResolution):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsActive):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsFirstChild):
(WebCore::SelectorCompiler::elementIsHovered):
(WebCore::SelectorCompiler::elementIsHoveredForStyleResolution):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsHovered):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsLastChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsOnlyChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::setCompatibilityMode):
(WebCore::Document::implicitOpen):
(WebCore::Document::cloneDataFromDocument):
- dom/Document.h:
(WebCore::Document::compatibilityModeMemoryOffset):
(WebCore::Document::inQuirksMode):
(WebCore::Document::inLimitedQuirksMode):
(WebCore::Document::inNoQuirksMode):
(WebCore::Document::compatibilityMode): Deleted.
- html/ImageDocument.cpp:
(WebCore::ImageDocument::ImageDocument):
- html/MediaDocument.cpp:
(WebCore::MediaDocument::MediaDocument):
- html/PluginDocument.cpp:
(WebCore::PluginDocument::PluginDocument):
- html/TextDocument.cpp:
(WebCore::TextDocument::TextDocument):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::setDefaultCompatibilityMode):
(WebCore::HTMLConstructionSite::setCompatibilityMode):
(WebCore::HTMLConstructionSite::setCompatibilityModeFromDoctype):
(WebCore::HTMLConstructionSite::insertDoctype):
- html/parser/HTMLConstructionSite.h:
- loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::replaceDocument):
- loader/SinkDocument.cpp:
(WebCore::SinkDocument::SinkDocument):
- page/ios/FrameIOS.mm:
(WebCore::Frame::initWithSimpleHTMLDocument):
- rendering/style/RenderStyle.h:
- 5:09 PM Changeset in webkit [169477] by
-
- 2 edits in trunk/Source/WebKit2
-[WKProcessPoolConfiguration setCachePartitionedURLSchemes:] should do a deep copy
https://bugs.webkit.org/show_bug.cgi?id=133393
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:
(-[_WKProcessPoolConfiguration setCachePartitionedURLSchemes:]):
- 4:56 PM Changeset in webkit [169476] by
-
- 2 edits in branches/safari-537.77-branch/Source/WebCore
Build fix for Mavericks
- WebCore.exp.in:
- 4:52 PM Changeset in webkit [169475] by
-
- 34 edits7 adds in trunk
Roll r168668 back in.
<https://bugs.webkit.org/show_bug.cgi?id=132621>
Reviewed by Brent Fulgham.
Source/WebCore:
Tests: fast/events/beforeload-assertion.html
fast/events/beforeload-iframe-crash.html
fast/events/beforeload-input-time-crash.html
- WebCore.exp.in:
- dom/Document.cpp:
(WebCore::Document::updateLayoutIgnorePendingStylesheets):
- dom/Document.h:
- html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::renderWidgetForJSBindings):
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::renderWidgetForJSBindings):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::renderWidgetForJSBindings):
- page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::updateEmbeddedObjectsTimerFired):
(WebCore::FrameView::flushAnyPendingPostLayoutTasks):
(WebCore::FrameView::performPostLayoutTasks):
- page/FrameView.h:
- testing/Internals.cpp:
(WebCore::Internals::updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
LayoutTests:
- compositing/plugins/composited-plugin.html:
- compositing/plugins/no-backing-store.html:
- fast/dom/beforeload/flash-before-load.html:
- fast/events/beforeload-assertion-expected.txt: Added.
- fast/events/beforeload-assertion.html: Added.
- fast/events/beforeload-iframe-crash-expected.txt: Added.
- fast/events/beforeload-iframe-crash.html: Added.
- fast/events/beforeload-input-time-crash-expected.txt: Added.
- fast/events/beforeload-input-time-crash.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-data.html:
- http/tests/security/contentSecurityPolicy/1.1/plugintypes-nourl-blocked.html:
- http/tests/security/contentSecurityPolicy/object-src-no-url-allowed.html:
- http/tests/security/contentSecurityPolicy/object-src-no-url-blocked.html:
- http/tests/security/contentSecurityPolicy/object-src-none-allowed.html:
- http/tests/security/contentSecurityPolicy/object-src-none-blocked.html:
- http/tests/security/contentSecurityPolicy/resources/multiple-iframe-plugin-test.js:
(testImpl.iframe.onload):
(testImpl):
- http/tests/security/mixedContent/insecure-plugin-in-iframe.html:
- platform/mac/plugins/supports-carbon-event-model.html:
- platform/mac/plugins/testplugin-onnew-onpaint.html:
- plugins/get-user-agent-with-null-npp-from-npp-new.html:
- plugins/mouse-click-plugin-clears-selection.html:
- plugins/netscape-plugin-map-data-to-src.html:
- plugins/no-mime-with-valid-extension.html:
- plugins/plugin-initiate-popup-window.html:
- plugins/windowless_plugin_paint_test.html:
- resources/plugin.js: Added.
(runAfterPluginLoad):
- 4:41 PM Changeset in webkit [169474] by
-
- 6 edits in trunk
Support -apple-system-font on OS X
https://bugs.webkit.org/show_bug.cgi?id=133382
Source/WebCore:
Reviewed by Simon Fraser.
Guard on both family names: "-apple-system-font" and "-webkit-system-font"
Test: platform/mac/fast/text/systemFont.html
- platform/mac/WebFontCache.mm:
(+[WebFontCache internalFontWithFamily:traits:weight:size:]):
LayoutTests:
This test makes sure that -apple-system-font is rendered the same way as -webkit-system-font.
Reviewed by Simon Fraser.
- platform/mac-mountainlion/platform/mac/fast/text/systemFont-expected.txt: Updated.
- platform/mac/fast/text/systemFont.html: Tests -apple-system-font in addition to -webkit-system-font.
- platform/mac/platform/mac/fast/text/systemFont-expected.txt: Updated.
- 4:24 PM Changeset in webkit [169473] by
-
- 2 edits in branches/safari-537.77-branch/Source/WebCore
Build fix
- WebCore.exp.in:
- 4:04 PM Changeset in webkit [169472] by
-
- 3 edits3 adds in trunk
Loading <object> from WebArchive crashes
https://bugs.webkit.org/show_bug.cgi?id=133386
<rdar://problem/13345509>
Reviewed by Brady Eidson.
Source/WebCore:
Test: webarchive/loading/object.html
This (a) fixes the crash, and (b) avoids the crash.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::continueAfterContentPolicy):
Some types of substitute data - such as WebArchive - don't contain HTTP result codes,
so let's not drop to <object> fallback content when status is 0.
And if the load somehow failed anyway, don't crash by trying to deliver substitute data
to a finished loader.
LayoutTests:
- webarchive/loading/object-expected.txt: Added.
- webarchive/loading/object.html: Added.
- webarchive/loading/resources/object.webarchive: Added.
- 4:00 PM Changeset in webkit [169471] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Add an instruction on how to backup the database.
https://bugs.webkit.org/show_bug.cgi?id=133391
Rubber-stamped by Andreas Kling.
- Install.md:
- 3:50 PM Changeset in webkit [169470] by
-
- 2 edits in tags/Safari-538.37/Source/WebKit2
Merge r169468. <rdar://problem/17067920>
- 3:47 PM Changeset in webkit [169469] by
-
- 6 edits1 copy in branches/safari-537.77-branch
Merge r166628.
- 3:26 PM Changeset in webkit [169468] by
-
- 2 edits in trunk/Source/WebKit2
Restoring FloatingPointEnvironment initialization that was accidentally rolled out by r169176.
<https://webkit.org/b/133389>
Rubber stamped by Oliver Hunt.
- Shared/ios/ChildProcessIOS.mm:
(WebKit::ChildProcess::platformInitialize):
- 3:10 PM Changeset in webkit [169467] by
-
- 3 edits in trunk/Source/WebCore
[iOS WebGL] Fix depth buffer clearing issue.
https://bugs.webkit.org/show_bug.cgi?id=133388
Patch by Alex Christensen <achristensen@webkit.org> on 2014-05-29
Reviewed by Dean Jackson.
No new tests, but this fixes webgl/1.0.1/conformance/canvas/buffer-preserve-test.html.
- platform/graphics/mac/WebGLLayer.mm:
(-[WebGLLayer display]):
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::prepareTexture):
Moved marking the layer as composited from the mac-only prepareTexture to
the end of [WebGLLayer display] which is called by mac and iOS.
- 2:47 PM Changeset in webkit [169466] by
-
- 4 edits in trunk/Source/WebKit2
Need to notify the keyboard about every KeyDown event.
https://bugs.webkit.org/show_bug.cgi?id=133383
<rdar://problem/16633975>
Reviewed by Benjamin Poulain.
A key down will generate most of the time a call to the keyboard to add input or delete.
But the event could be handled by JavaScript and its default prevented.
We need to notify the keyboard in every case to allow updating its internal state about what has been typed.
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::doneWithKeyEvent):
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _didHandleKeyEvent:]):
- 2:44 PM Changeset in webkit [169465] by
-
- 17 edits in trunk/Source/WebKit2
Roll out r169439. <rdar://problem/17069364>
- 2:38 PM Changeset in webkit [169464] by
-
- 2 edits in branches/safari-537.77-branch/Source/WebCore
Workaround for <rdar://problem/16848509>
Reviewed by David Kilzer.
- platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
- 2:37 PM Changeset in webkit [169463] by
-
- 17 edits in tags/Safari-538.37/Source/WebKit2
Roll out r169439.
- 1:23 PM Changeset in webkit [169462] by
-
- 2 edits in trunk/Source/WebInspectorUI
Fix an exception in InspectorBackend.Command.prototype.supports.
https://bugs.webkit.org/show_bug.cgi?id=133384
Reviewed by Joseph Pecoraro.
- UserInterface/Protocol/InspectorBackend.js:
(InspectorBackend.Command.prototype.supports): Use some not any.
- 1:14 PM Changeset in webkit [169461] by
-
- 2 edits in trunk/Tools
[GTK] Add a WebKit2 Performance bot.
https://bugs.webkit.org/show_bug.cgi?id=132862
Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-05-29
Reviewed by Csaba Osztrogonác.
This adds a GTK WebKit2 perf bot.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 1:01 PM Changeset in webkit [169460] by
-
- 4 edits in trunk/Source/WebKit2
[Cocoa] Can’t recover from subframe load errors
https://bugs.webkit.org/show_bug.cgi?id=133385
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h: Declared new delegate method.
- UIProcess/Cocoa/NavigationState.h: Added flag in m_navigationDelegateMethods struct.
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::setNavigationDelegate): Initialize
webViewNavigationDidFailProvisionalLoadInSubframeWithError flag in the delegate methods
struct.
(WebKit::NavigationState::LoaderClient::didFailProvisionalLoadWithErrorForFrame): If the
error occurred in a subframe, invoke the new delegate method.
- 11:40 AM Changeset in webkit [169459] by
-
- 2 edits in trunk/LayoutTests
Gardening: marking js/primitive-property-access-edge-cases.html as crashy.
<https://webkit.org/b/133356>
Not reviewed.
- 11:38 AM Changeset in webkit [169458] by
-
- 2 edits in trunk/Source/WebKit2
Added a missing @result to WKPreferences headerdoc
https://bugs.webkit.org/show_bug.cgi?id=133381
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKPreferences.h:
- 11:24 AM Changeset in webkit [169457] by
-
- 10 edits2 adds in trunk/Source/WebKit2
[Mac] Always use plug-in sandbox with sandboxed clients
https://bugs.webkit.org/show_bug.cgi?id=133358
<rdar://problem/15637695>
Reviewed by Anders Carlsson.
- PluginProcess/mac/PluginProcessMac.mm: (WebKit::PluginProcess::initializeSandbox):
Refuse to start if parent process is sandboxed, and plug-in process is not going to be.
None of this should run in normal case, because there are also checks on UI process side.
- Shared/Plugins/PluginModuleInfo.h:
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::NetscapePluginModule::getPluginInfo):
Added a member to PluginModuleInfo, telling whether the plug-in has a sandbox profile.
- Shared/Plugins/Netscape/mac/PluginInformationMac.mm:
(WebKit::getPlatformPluginModuleInformation): Use the new PluginModuleInfo member,
we no longer need to check the file system here.
- WebKit2.xcodeproj/project.pbxproj:
- Shared/mac/SandboxUtilities.h: Added.
- Shared/mac/SandboxUtilities.cpp: Added. (WebKit::processIsSandboxed):
This code is simple, but include magic is not. Moved it to a separate file to
avoid repeating.
- UIProcess/API/C/mac/WKContextPrivateMac.mm: Removed an unused include.
- UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::shouldUsePlugin): Don't use unsandboxed plug-ins in
sandboxed applications.
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::platformGetLaunchOptions): Don't ever pass disable-sandbox
from sandboxed processes.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:
(WebKit::XPCServiceInitializerDelegate::isClientSandboxed):
Use the new shared code in SandboxUtilities.h.
- 11:19 AM Changeset in webkit [169456] by
-
- 2 edits in trunk/Source/WebKit2
Crash loading skydrive.com (assertion under RemoteLayerTreeDisplayRefreshMonitor)
https://bugs.webkit.org/show_bug.cgi?id=133370
<rdar://problem/17061361>
Reviewed by Anders Carlsson.
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::didUpdate):
Copy the set of refresh monitors so that we don't try to mutate the list we're iterating,
and don't try to fire refresh monitors that were removed in a previous iteration of the loop.
- 11:06 AM Changeset in webkit [169455] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (iOS WebKit2): Find-in-Page doesn't work in subframes
https://bugs.webkit.org/show_bug.cgi?id=133372
<rdar://problem/17045070>
Reviewed by Simon Fraser.
- WebProcess/WebPage/ios/FindControllerIOS.mm:
(WebKit::FindController::willFindString):
(WebKit::FindController::didFailToFindString):
(WebKit::FindController::didHideFindIndicator):
Flip ignoreCompositionSelectionChange and updateAppearanceEnabled on all
frames, not just the main frame, because the found string can be in a subframe.
Ideally we would flip it on/off for each frame as we move the selection between them,
but would require a lot of work (and the overhead of touching each frame shouldn't be significant).
- 10:49 AM Changeset in webkit [169454] by
-
- 2 edits in trunk/LayoutTests
Gardening: marking js/primitive-property-access-edge-cases.html as flaky.
<https://webkit.org/b/133356>
Not reviewed.
- 10:40 AM Changeset in webkit [169453] by
-
- 2 edits in trunk/Tools
Fixed the WebKitTestRunner build after r169452.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::initialize):
- 10:27 AM Changeset in webkit [169452] by
-
- 7 edits in trunk/Source/WebKit2
WKBundleActivateMacFontAscentHack is unused
https://bugs.webkit.org/show_bug.cgi?id=133379
Reviewed by Anders Carlsson.
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleActivateMacFontAscentHack): Deleted.
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.h:
- WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:
(WebKit::InjectedBundle::activateMacFontAscentHack): Deleted.
- WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
(WebKit::InjectedBundle::activateMacFontAscentHack): Deleted.
- WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
(WebKit::InjectedBundle::activateMacFontAscentHack): Deleted.
- 10:09 AM Changeset in webkit [169451] by
-
- 5 edits in trunk/Source
Versioning.
- 9:41 AM Changeset in webkit [169450] by
-
- 3 edits in trunk/Source/WebCore
Perserve caption selection in fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=133350
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-05-29
Reviewed by Eric Carlson.
Use the logic from the inline player to calculate the selected caption index.
- html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::mediaControlsHost):
Expose mediaControlsHost() for use by WebVideoFullscreenModelMediaElement.
- platform/ios/WebVideoFullscreenModelMediaElement.mm:
(WebVideoFullscreenModelMediaElement::updateLegibleOptions):
Use logic from buildCaptionsMenu from mediaControlsApple.js.
- 9:26 AM Changeset in webkit [169449] by
-
- 3 edits2 adds in trunk
Use correct version of requiresFullscreenForVideoPlayback().
https://bugs.webkit.org/show_bug.cgi?id=133331
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-05-29
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/video-fullscreeen-only-controls.html
Update the last place not yet using m_mediaSession->requiresFullscreenForVideoPlayback.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
switch to media session version for requriesFullscreenForVideoPlayback.
LayoutTests:
- media/video-fullscreeen-only-controls-expected.txt: Added.
- media/video-fullscreeen-only-controls.html: Added. Make sure video element
controls show even when not specified if inline playback is restricted.
- 9:10 AM Changeset in webkit [169448] by
-
- 3 edits1 add in trunk/Source/WebKit2
Add a sandbox profile for com.apple.appstore.CodeRedeemerNetscapePlugin
https://bugs.webkit.org/show_bug.cgi?id=133360
Reviewed by Sam Weinig.
- Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb: Looks like
anyone using camera would need access to CoreMedia preferences.
- Resources/PlugInSandboxProfiles/com.apple.appstore.CodeRedeemerNetscapePlugin.sb: Added.
- WebKit2.xcodeproj/project.pbxproj: Added the profile.
- 9:09 AM Changeset in webkit [169447] by
-
- 4 edits1 add in trunk/Source
DFG::DCEPhase inserts into an insertion set in reverse, causing hilarious basic block corruption if you kill a lot of NewArrays
https://bugs.webkit.org/show_bug.cgi?id=133368
Reviewed by Mark Lam.
Source/JavaScriptCore:
- dfg/DFGDCEPhase.cpp:
(JSC::DFG::DCEPhase::fixupBlock): Loop in the right order so that we insert in the right order.
- tests/stress/new-array-dead.js: Added.
(foo):
Source/WTF:
- wtf/Insertion.h:
(WTF::executeInsertions): This algorithm is only correct if insertions are added in the right order. Assert that the order is right.
- 9:05 AM Changeset in webkit [169446] by
-
- 4 edits in trunk/Source
[GTK] Add support for HiDPI icons
https://bugs.webkit.org/show_bug.cgi?id=133377
Reviewed by Martin Robinson.
Source/WebCore:
Use the GTK+ missing icon at 16 or 32 size depending on the device
scale factor.
- platform/graphics/gtk/ImageGtk.cpp:
(WebCore::loadMissingImageIconFromTheme):
(WebCore::Image::loadPlatformResource):
Source/WebKit2:
- PlatformGTK.cmake: Compile also the @2x versions for the builtin icons.
- 8:10 AM Changeset in webkit [169445] by
-
- 12 edits in trunk/Source
[GTK] Add HighDPI support for non-accelerated compositing contents
https://bugs.webkit.org/show_bug.cgi?id=131562
Patch by Owen Taylor <otaylor@redhat.com> on 2014-05-29
Reviewed by Anders Carlsson.
Source/WebCore:
No new tests. This will be tested once we have the proper dependencies in the WebKit testing
JHBuild.
- platform/cairo/WidgetBackingStore.h:
(WebCore::WidgetBackingStore::WidgetBackingStore): Accept a device scale argument.
- platform/cairo/WidgetBackingStoreCairo.cpp: Use the device scale argument to make the surface the proper size and set the surface device scale.
- platform/cairo/WidgetBackingStoreCairo.h: Accept a device scale argument.
- platform/graphics/cairo/CairoUtilities.cpp: Add a new helper to set the device scale if Cairo built against is new enough.
- platform/graphics/cairo/CairoUtilities.h:
- platform/gtk/GtkVersioning.h: Add the HAVE_GTK_SCALE_FACTOR macro.
- platform/gtk/WidgetBackingStoreGtkX11.cpp: Use the device scale argument to make the surface the proper size and set the surface device scale.
- platform/gtk/WidgetBackingStoreGtkX11.h: Accept a device scale argument.
Source/WebKit2:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(deviceScaleFactorChanged): Added this callback to pass scale changes to the page proxy.
(webkitWebViewBaseCreateWebPage): Attach the callback to the notify signal.
- UIProcess/WebPageProxy.cpp:
- UIProcess/cairo/BackingStoreCairo.cpp:
(WebKit::WebPageProxy::setCustomDeviceScaleFactor): Do not set a
custom device scale factor for cairo when it's not supported.
(WebKit::createBackingStoreForGTK): Pass the scale factor to the WebCore backing store.
(WebKit::BackingStore::incorporateUpdate): Ditto.
- 3:33 AM Changeset in webkit [169444] by
-
- 8 edits in trunk/Source/WebKit2
[GTK] Use GMainLoopSource for idle and timeout sources in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=130081
Reviewed by Martin Robinson.
- Platform/WorkQueue.h:
- Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::registerSocketEventHandler): Stop pretending it's
possible to register a socket event handler for more than one
descriptor.
(WorkQueue::unregisterSocketEventHandler):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfter):
- Shared/Downloads/soup/DownloadSoup.cpp:
(WebKit::DownloadClient::DownloadClient):
(WebKit::DownloadClient::~DownloadClient):
(WebKit::DownloadClient::didReceiveData):
(WebKit::DownloadClient::handleResponse):
(WebKit::DownloadClient::handleResponseLater):
- UIProcess/Plugins/gtk/PluginInfoCache.cpp:
(WebKit::PluginInfoCache::PluginInfoCache):
(WebKit::PluginInfoCache::~PluginInfoCache):
(WebKit::PluginInfoCache::saveToFile):
(WebKit::PluginInfoCache::updatePluginInfo):
- UIProcess/Plugins/gtk/PluginInfoCache.h:
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::LayerTreeHostGtk):
(WebKit::LayerTreeHostGtk::layerFlushTimerFired):
(WebKit::LayerTreeHostGtk::scheduleLayerFlush):
(WebKit::LayerTreeHostGtk::cancelPendingLayerFlush):
- WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
- 2:38 AM Changeset in webkit [169443] by
-
- 3 edits in trunk
[WK2][GTK] ASSERTION FAILED: m_status == Scheduled in GMainLoopSource
https://bugs.webkit.org/show_bug.cgi?id=131220
Reviewed by Philippe Normand.
Unskip inspector-protocol/dom/remove-multiple-nodes.html.
- platform/gtk/TestExpectations:
