Timeline
Jun 7, 2014:
- 4:25 PM Changeset in webkit [169681] by
-
- 5 edits in trunk/Source/WebCore
Regression r168397 - Form layout is incorrect on OS X Yosemite
https://bugs.webkit.org/show_bug.cgi?id=133612
<rdar://problem/16850492>
<rdar://problem/17016914>
Reviewed by Anders Carlson.
Revision 168397 introduced a new animated style of form controls. Part of
it included extending the margins for the controls to take into account the
focus ring that animates in from a large radius to a small radius. This
caused two problems:
- the incorrect margins broke many layouts
- despite increased margins, there were still some areas that did not repaint correctly.
Restore the old margins and (temporarily) turn off focus ring animation.
Bad layout is much worse than a missing animation. Another benefit
of this is that we will use less memory.
- platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::drawFocusRingToContextAtTime): Pass in a time far far far in the future to
get the static rendering.
- platform/mac/ThemeMac.mm:
(WebCore::checkboxMargins): Restore correct margins.
(WebCore::radioMargins): Ditto.
(WebCore::drawCellFocusRing): New method that calls WKSI with a future time.
(WebCore::paintToggleButton): Call the new wrapper.
(WebCore::buttonMargins): Restore correct margins.
(WebCore::paintButton): Call the new wrapper.
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMenuList): Use a future time.
(WebCore::RenderThemeMac::platformFocusRingMaxWidth): Deleted. Use old outline value.
- 1:32 PM Changeset in webkit [169680] by
-
- 3 edits2 deletes in trunk/Source/WebKit2
Get rid of _WKScriptWorld
https://bugs.webkit.org/show_bug.cgi?id=133610
Reviewed by Dan Bernstein.
- Shared/API/Cocoa/WebKitPrivate.h:
- UIProcess/API/Cocoa/_WKScriptWorld.h: Removed.
- UIProcess/API/Cocoa/_WKScriptWorld.mm: Removed.
- WebKit2.xcodeproj/project.pbxproj:
- 1:17 PM Changeset in webkit [169679] by
-
- 16 edits in trunk/Source
HTTPHeaderMap should not derive from HashMap
https://bugs.webkit.org/show_bug.cgi?id=133392
Reviewed by Darin Adler.
Source/WebCore:
Use a HashMap member variable instead.
- WebCore.exp.in:
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived):
- platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::copyData):
(WebCore::HTTPHeaderMap::adopt):
(WebCore::HTTPHeaderMap::get):
(WebCore::HTTPHeaderMap::set):
(WebCore::HTTPHeaderMap::add):
(WebCore::HTTPHeaderMap::contains):
(WebCore::HTTPHeaderMap::find):
(WebCore::HTTPHeaderMap::remove):
(WebCore::HTTPHeaderMap::keys):
- platform/network/HTTPHeaderMap.h:
(WebCore::HTTPHeaderMap::isEmpty):
(WebCore::HTTPHeaderMap::size):
(WebCore::HTTPHeaderMap::clear):
(WebCore::HTTPHeaderMap::begin):
(WebCore::HTTPHeaderMap::end):
(WebCore::HTTPHeaderMap::operator==):
(WebCore::HTTPHeaderMap::operator!=):
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::adopt):
- platform/network/ResourceRequestBase.h:
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::adopt):
- platform/network/ResourceResponseBase.h:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):
Source/WebKit2:
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<HTTPHeaderMap>::encode):
(IPC::ArgumentCoder<HTTPHeaderMap>::decode):
- 12:56 PM Changeset in webkit [169678] by
-
- 2 edits in tags/Safari-538.39.1/Source/WebKit2
Merged r169672.
- 12:51 PM Changeset in webkit [169677] by
-
- 5 edits in tags/Safari-538.39.1/Source
Versioning.
- 12:49 PM Changeset in webkit [169676] by
-
- 1 copy in tags/Safari-538.39.1
New tag.
- 6:29 AM Changeset in webkit [169675] by
-
- 5 edits in trunk/Source/WebCore
Use C++11 lambdas to construct FileThread::Task objects
https://bugs.webkit.org/show_bug.cgi?id=133079
Reviewed by Darin Adler.
Have FileThread::Task constructor take in a std::function<void ()>-like object
as the second parameter. Much like with ScriptExecutionContext::Task, the idea here
is to use inlined C++11 lambdas in FileThread::postTask() calls. Because FileThread::Task
also requires an instance pointer, a brace-init list is passed to these calls, passing
in the instance pointer as the first parameter and the C++11 lambda as the second.
FileThread::postTask() now takes in a FileThread::Task rvalue and moves it onto the heap
and into the queue.
In AsyncFileStream.cpp, calls to FileThread::postTask() are updated to use C++11 lambdas.
Uses of MainThreadTask are also replaced by C++11 lambdas. This modernizes the code and
removes a lot of helper functions.
FileThread::Task doesn't use CrossThreadCopier anymore. Instead, we manually produce
thread-safe copies as necessary. At the moment this approach produces another copy when
passing the freshly-copied object into the lambda, but this will be avoidable once we
make C++14 and the lambda capture expression support mandatory.
- fileapi/AsyncFileStream.cpp:
(WebCore::AsyncFileStream::create):
(WebCore::AsyncFileStream::stop):
(WebCore::AsyncFileStream::getSize):
(WebCore::AsyncFileStream::openForRead):
(WebCore::AsyncFileStream::openForWrite):
(WebCore::AsyncFileStream::close):
(WebCore::AsyncFileStream::read):
(WebCore::AsyncFileStream::write):
(WebCore::AsyncFileStream::truncate):
(WebCore::didStart): Deleted.
(WebCore::AsyncFileStream::startOnFileThread): Deleted.
(WebCore::derefProxyOnMainThread): Deleted.
(WebCore::AsyncFileStream::stopOnFileThread): Deleted.
(WebCore::didGetSize): Deleted.
(WebCore::AsyncFileStream::getSizeOnFileThread): Deleted.
(WebCore::didOpen): Deleted.
(WebCore::AsyncFileStream::openForReadOnFileThread): Deleted.
(WebCore::AsyncFileStream::openForWriteOnFileThread): Deleted.
(WebCore::AsyncFileStream::closeOnFileThread): Deleted.
(WebCore::didRead): Deleted.
(WebCore::AsyncFileStream::readOnFileThread): Deleted.
(WebCore::didWrite): Deleted.
(WebCore::AsyncFileStream::writeOnFileThread): Deleted.
(WebCore::didTruncate): Deleted.
(WebCore::AsyncFileStream::truncateOnFileThread): Deleted.
- fileapi/AsyncFileStream.h:
- fileapi/FileThread.cpp:
(WebCore::FileThread::postTask):
- fileapi/FileThread.h:
(WebCore::FileThread::Task::Task):
- 6:10 AM Changeset in webkit [169674] by
-
- 3 edits in trunk/Source/WebCore
Pass C++11 lambdas to callOnMainThread() calls in IconDatabase
https://bugs.webkit.org/show_bug.cgi?id=133374
Reviewed by Darin Adler.
Use C++11 lambads to inline the main thread tasks into the calling code,
modernizing the look of the code and removing a few static methods and
classes that were used as helpers.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::scheduleOrDeferSyncTimer):
(WebCore::IconDatabase::performURLImport):
(WebCore::IconDatabase::dispatchDidImportIconURLForPageURLOnMainThread):
(WebCore::IconDatabase::dispatchDidImportIconDataForPageURLOnMainThread):
(WebCore::IconDatabase::dispatchDidRemoveAllIconsOnMainThread):
(WebCore::IconDatabase::dispatchDidFinishURLImportOnMainThread):
(WebCore::IconDatabase::notifyPendingLoadDecisionsOnMainThread): Deleted.
(WebCore::IconDatabase::performScheduleOrDeferSyncTimer): Deleted.
(WebCore::IconDatabase::performScheduleOrDeferSyncTimerOnMainThread): Deleted.
(WebCore::ClientWorkItem::ClientWorkItem): Deleted.
(WebCore::ClientWorkItem::~ClientWorkItem): Deleted.
(WebCore::ImportedIconURLForPageURLWorkItem::ImportedIconURLForPageURLWorkItem): Deleted.
(WebCore::ImportedIconURLForPageURLWorkItem::~ImportedIconURLForPageURLWorkItem): Deleted.
(WebCore::ImportedIconURLForPageURLWorkItem::performWork): Deleted.
(WebCore::ImportedIconDataForPageURLWorkItem::ImportedIconDataForPageURLWorkItem): Deleted.
(WebCore::ImportedIconDataForPageURLWorkItem::~ImportedIconDataForPageURLWorkItem): Deleted.
(WebCore::ImportedIconDataForPageURLWorkItem::performWork): Deleted.
(WebCore::RemovedAllIconsWorkItem::RemovedAllIconsWorkItem): Deleted.
(WebCore::RemovedAllIconsWorkItem::performWork): Deleted.
(WebCore::FinishedURLImport::FinishedURLImport): Deleted.
(WebCore::FinishedURLImport::performWork): Deleted.
(WebCore::performWorkItem): Deleted.
- loader/icon/IconDatabase.h:
- 6:06 AM Changeset in webkit [169673] by
-
- 4 edits in trunk/Source/WebCore
Replace uses of CrossThreadTask in DefaultSharedWorkerRepository, WorkerMessagingProxy with C++11 lambdas
https://bugs.webkit.org/show_bug.cgi?id=133375
Reviewed by Darin Adler.
Uses of CrossThreadTask in the two classes are replaced with C++11 lambdas.
The necessary cross-thread copies are created manually and passed into the
lambdas by value, removing the need for CrossThreadTask and its use of CrossThreadCopier.
Remove the explicit use of this pointer in some lambdas -- it is captured automatically when
capturing by value, so enforcing its capturing through explicit use is not necessary.
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::postExceptionToWorkerObject):
(WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject):
(WebCore::postExceptionTask): Deleted.
(WebCore::postConsoleMessageTask): Deleted.
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::workerObjectDestroyed):
(WebCore::WorkerMessagingProxy::notifyNetworkStateChange):
(WebCore::WorkerMessagingProxy::connectToInspector):
(WebCore::WorkerMessagingProxy::disconnectFromInspector):
(WebCore::WorkerMessagingProxy::sendMessageToInspector):
(WebCore::WorkerMessagingProxy::postMessageToPageInspector):
(WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
(WebCore::WorkerMessagingProxy::reportPendingActivity):
(WebCore::postConsoleMessageTask): Deleted.
(WebCore::WorkerMessagingProxy::workerObjectDestroyedInternal): Deleted.
(WebCore::connectToWorkerGlobalScopeInspectorTask): Deleted.
(WebCore::disconnectFromWorkerGlobalScopeInspectorTask): Deleted.
(WebCore::dispatchOnInspectorBackendTask): Deleted.
- workers/WorkerMessagingProxy.h:
- 2:21 AM Changeset in webkit [169672] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] Fix a path used for sandbox profiles
https://bugs.webkit.org/show_bug.cgi?id=133602
<rdar://problem/17212011>
Reviewed by David Kilzer.
- WebKit2.xcodeproj/project.pbxproj:
- 1:10 AM Changeset in webkit [169671] by
-
- 2 edits4 adds in trunk/LayoutTests
Add tests for dynamic changes in msqrt/mroot
https://bugs.webkit.org/show_bug.cgi?id=133557
Reviewed by Chris Fleizach.
This patch adds some tests to verify that a MathML msqrt/mroot element to which we applied dynamic additions and removals of children renders the same as its static equivalent and that no crashes happen.
Unfortunately, the existing code does not handle them very well so they are skipped until we do the refactoring of bug 119038.
- TestExpectations: skip the tests.
- mathml/roots-addChild-expected.html: Added.
- mathml/roots-addChild.html: Added.
- mathml/roots-removeChild-expected.html: Added.
- mathml/roots-removeChild.html: Added.
Jun 6, 2014:
- 6:29 PM Changeset in webkit [169670] by
-
- 9 edits in trunk
Scheme of content utils should be compared in an ASCII case-insensitive manner
https://bugs.webkit.org/show_bug.cgi?id=133502
Reviewed by Darin Adler.
Source/WebCore:
According to spec, scheme must be compared in an ASCII case-insensitive manner by user agents.
Covered by existing tests.
- Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
(WebCore::isProtocolWhitelisted):
LayoutTests:
Tests are updated to compare protocol in ASCII case-insensitive manner.
- fast/dom/NavigatorContentUtils/register-protocol-handler-expected.txt:
- fast/dom/NavigatorContentUtils/register-protocol-handler.html:
- fast/dom/NavigatorContentUtils/unregister-protocol-handler-expected.txt:
- fast/dom/NavigatorContentUtils/unregister-protocol-handler.html:
- platform/efl/fast/dom/NavigatorContentUtils/register-protocol-handler-expected.txt:
- platform/efl/fast/dom/NavigatorContentUtils/unregister-protocol-handler-expected.txt:
- 5:30 PM Changeset in webkit [169669] by
-
- 7 edits in trunk/Source/WebKit2
REGRESSION (iOS WebKit2): backspace key does not repeat beyond a single word.
https://bugs.webkit.org/show_bug.cgi?id=133593
<rdar://problem/16352228>
Reviewed by Benjamin Poulain.
We need to provide a way for the keyboard layer to select from
the current position to the beginning of the word moving backwards
and implement the method to know when we have reached the beginning of the document.
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView selectWordBackward]):
(-[WKContentView _selectionAtDocumentStart]):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::selectWordBackward):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::selectWordBackward):
- 4:56 PM Changeset in webkit [169668] by
-
- 11 edits in trunk/Source
Indexed getters should return values directly on the PropertySlot.
<https://webkit.org/b/133586>
Source/JavaScriptCore:
Remove PropertySlot's custom index mode.
Reviewed by Darin Adler.
- runtime/JSObject.h:
(JSC::PropertySlot::getValue):
- runtime/PropertySlot.h:
(JSC::PropertySlot::setCustomIndex): Deleted.
Source/WebCore:
Make indexed getters more efficient by using PropertySlot::setValue()
to pass the value directly back through the slot, instead of giving it
a function pointer that JSC would then immediately call back through
to retrieve the value.
The function pointer approach would make sense if we did inline caching
of indexed getters but since we currently don't, this is pure overhead.
Reviewed by Darin Adler.
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::getOwnPropertySlotDelegate):
(WebCore::cssPropertyGetterPixelOrPosPrefixCallback): Deleted.
(WebCore::cssPropertyGetterCallback): Deleted.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
(WebCore::indexGetter): Deleted.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateHeader):
(GetIndexedGetterExpression):
(GenerateImplementation):
- bridge/runtime_array.cpp:
(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::getOwnPropertySlotByIndex):
(JSC::RuntimeArray::indexGetter): Deleted.
- bridge/runtime_array.h:
- 4:32 PM Changeset in webkit [169667] by
-
- 2 edits in tags/Safari-538.39/Source/WebCore
Merge r169665. <rdar://problem/15840022>
- 4:18 PM Changeset in webkit [169666] by
-
- 3 edits in trunk/Source/WebCore
GenericCueData elements prematurely removed
https://bugs.webkit.org/show_bug.cgi?id=133588
Reviewed by Eric Carlson.
Add a 'removeCompletedCues' method instead of using the 'resetCueValues' method
after processing new cues. We do not want to reset cue state if we have pending
cues that are being extended by future updates (such as paint-on cues).
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::processCue): Call new 'removeCompletedCues' method.
(WebCore::InbandTextTrackPrivateAVF::removeCompletedCues): Added.
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
- 4:07 PM Changeset in webkit [169665] by
-
- 2 edits in trunk/Source/WebCore
Initialize a char* that needs to be initialized.
<rdar://problem/15840022> and https://bugs.webkit.org/show_bug.cgi?id=133585
Reviewed by Mark Rowe.
r152134 (erroneously) removed this initialization.
- platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::prepare): tail should start out initialized to 0.
- 3:06 PM Changeset in webkit [169664] by
-
- 8 edits in trunk/Source/WebKit2
Adopt the new UIAlertController API to replace UIActionSheet.
https://bugs.webkit.org/show_bug.cgi?id=133582
<rdar://problem/16845223>
Reviewed by Joseph Pecoraro.
UIActionSheet is deprecated. We need to move out action sheets
implementation to UIAlertView.
- UIProcess/API/Cocoa/_WKElementAction.h:
- UIProcess/API/Cocoa/_WKElementAction.mm:
- UIProcess/ios/WKActionSheet.h:
- UIProcess/ios/WKActionSheet.mm:
(-[WKActionSheet presentSheetFromRect:]):
(-[WKActionSheet doneWithSheet]):
(-[WKActionSheet willRotate]):
(-[WKActionSheet updateSheetPosition]):
(-[WKActionSheet _didRotateAndLayout]):
(-[WKActionSheet didRotate]):
- UIProcess/ios/WKActionSheetAssistant.h:
- UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant _createSheetWithElementActions:showLinkTitle:]):
(-[WKActionSheetAssistant showImageSheet]):
(-[WKActionSheetAssistant showLinkSheet]):
(-[WKActionSheetAssistant showDataDetectorsSheet]):
(-[WKActionSheetAssistant cleanupSheet]):
(-[WKActionSheetAssistant actionSheet:clickedButtonAtIndex:]): Deleted.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _longPressRecognized:]):
- 2:43 PM Changeset in webkit [169663] by
-
- 2 edits in trunk/Source/WebKit2
Should boost ChildProcesses on iOS
https://bugs.webkit.org/show_bug.cgi?id=133583
Reviewed by Sam Weinig.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::connectToService):
- boost all child processes on iOS.
- 2:08 PM Changeset in webkit [169662] by
-
- 2 edits in trunk/Tools
32-bit build fix.
- WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
- 2:07 PM Changeset in webkit [169661] by
-
- 7 edits in tags/Safari-538.39/Source
Rollout r169656. <rdar://problem/17095692>
- 2:04 PM Changeset in webkit [169660] by
-
- 3 edits in trunk/Source/WebCore
[iOS] Support pasting HTML
https://bugs.webkit.org/show_bug.cgi?id=133581
<rdar://problem/17070305>
Reviewed by Enrica Casucci.
We can probably share a lot of code between Mac and iOS here, but for now, just
implement the unimplemented functions.
- editing/ios/EditorIOS.mm: (WebCore::Editor::WebContentReader::readHTML):
Implemented based on WebArchive reading code above, and on Mac version of readHTML.
Unlike on Mac, we don't need to support Microsoft CF_HTML format, as nothing
generates it.
- platform/ios/PasteboardIOS.mm:
(WebCore::Pasteboard::read):
(WebCore::Pasteboard::supportedPasteboardTypes):
Added HTML support, as the second preferred format after WebArchive.
- 1:59 PM Changeset in webkit [169659] by
-
- 4 edits in trunk/Tools
Fix builds on 10.8; -firstObject isn't declared on NSArray there.
- DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
- DumpRenderTree/mac/EventSendingController.mm:
(-[EventSendingController mouseScrollByX:andY:continuously:]):
(-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
- WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
- 1:34 PM Changeset in webkit [169658] by
-
- 5 edits in trunk/Source/WebKit2
Build fix after <http://trac.webkit.org/changeset/169655>.
The SPIs used do not exist on Mac, limit the code to iOS.
- Shared/Authentication/mac/AuthenticationManager.mac.mm:
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<Credential>::encode):
(IPC::ArgumentCoder<Credential>::decode):
- Shared/cf/ArgumentCodersCF.cpp:
(IPC::typeFromCFTypeRef):
(IPC::encode):
(IPC::decode):
- Shared/cf/ArgumentCodersCF.h:
- 1:07 PM Changeset in webkit [169657] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the build after http://trac.webkit.org/changeset/169655
Unfortunately, the fix is very fragile, and will likely not work for some SDKs
or possibly local headers - all OS versions have multiple SecBase.h headers with
different definitions for SecIdentityRef.
We'll see.
- WebCore.exp.in:
- 12:57 PM Changeset in webkit [169656] by
-
- 7 edits in tags/Safari-538.39/Source
Merge r169655. <rdar://problem/17095692>
- 12:04 PM Changeset in webkit [169655] by
-
- 7 edits in trunk/Source
Source/WebCore: WebCore part of <rdar://problem/17095692> [iOS] Client-certificate authentication isn’t working
https://bugs.webkit.org/show_bug.cgi?id=133527
Reviewed by Darin Adler.
- WebCore.exp.in: Exported some Credential member functions.
Source/WebKit2: <rdar://problem/17095692> [iOS] Client-certificate authentication isn’t working
https://bugs.webkit.org/show_bug.cgi?id=133527
Reviewed by Darin Adler.
- Configurations/Network-iOS.entitlements: Enabled the Network process to access the keys
needed to create identities to authenticate with.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<Credential>::encode): Encode the credential type, and if it is a client
certificate, encode the identity and the certificates.
(IPC::ArgumentCoder<Credential>::decode): Decode the credential type. If it is a client
certificate, decode the identity and the certificates and use the proper Credential
constructor.
- Shared/cf/ArgumentCodersCF.cpp:
(IPC::typeFromCFTypeRef): Handle SecIdentityRef.
(IPC::encode): Encode an identity by encoding its certificate and a persistent reference to
its key.
(IPC::decode): Decode a certificate and a persistent reference to a key, find the key, and
create an identity.
- Shared/cf/ArgumentCodersCF.h:
- 11:37 AM Changeset in webkit [169654] by
-
- 3 edits in trunk/Source/WebCore
[iOS WebGL] Float texture extension has a slightly different name
https://bugs.webkit.org/show_bug.cgi?id=133580
<rdar://problem/17113451>
Reviewed by Brady Eidson.
Floating point textures were not available on iOS, because we were
looking for the wrong extension.
Covered by the Khronos test (and in LayoutTests):
conformance/extensions/oes-texture-float.html
- platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::supportsExtension): Look for GL_OES_texture_float
as well as GL_ARB_texture_float.
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::texImage2D): Increase the set of things skipped
on PLATFORM(IOS) since they are supported natively there.
- 11:00 AM Changeset in webkit [169653] by
-
- 5 edits in trunk/Source
Versioning.
- 10:59 AM Changeset in webkit [169652] by
-
- 2 edits in tags/Safari-538.39/Source/WebCore
Add UNUSED_PARAM when GRID is off.
- 10:57 AM Changeset in webkit [169651] by
-
- 7 edits in trunk
REGRESSION: Hit testing of composited elements is broken in new multicolumn layout.
https://bugs.webkit.org/show_bug.cgi?id=133522 (<rdar://problem/17060556>)
Reviewed by Simon Fraser.
Source/WebCore:
Hit testing for the new columns doesn't care about compositing but does still
need a pagination layer set to work. The old column code didn't care about this
because it was top down (and wrong). The new code lets each layer paint and hit
test its own fragments, so having a pagination layer set suddenly becomes relevant
for composited layers.
The solution is to cache whether or not the pagination layer crosses a compositing
boundary, and then to force call sites of enclosingPaginationLayer to pass an argument
indicating whether compositing layers should be included. Typically painting wants to
exclude them but hit testing wants to include them.
- page/FrameView.cpp:
(WebCore::updateLayerPositionFlags):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::updatePagination):
(WebCore::transparencyClipBox):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::enclosingPaginationLayerInSubtree):
(WebCore::RenderLayer::collectFragments):
(WebCore::RenderLayer::paintTransformedLayerIntoFragments):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestTransformedLayerInFragments):
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayer.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
LayoutTests:
- compositing/columns/hittest-composited-in-paginated-expected.txt:
- 10:41 AM Changeset in webkit [169650] by
-
- 18 edits in trunk
Latched scrolling tests are flakey on Mavericks
https://bugs.webkit.org/show_bug.cgi?id=133578
<rdar://problem/17180591>
Reviewed by Brent Fulgham.
Tools:
The latched scrolling tests rely on synthetic mousewheel events whose coordinates can
be wrong on machines with more than one screen. This is because we use
[NSScreen mainScreen] when computing the global coordinates of the events, but
[NSScreen mainScreen] returns the screen with the key window, not the first screen.
So replace calls to [NSScreen mainScreen] with [[NSScreen screens] firstObject]. Also
add comments clarifying why the coordinate math works (which is not obvious given
the events have no target window).
Some scrolling tests also dispatched events outside the 800x600 test window, so
fix those tests, and add logging that will appear in test output when this happens.
- DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
- DumpRenderTree/mac/EventSendingController.mm:
(-[EventSendingController mouseScrollByX:andY:continuously:]):
(-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
- WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::continuousMouseScrollBy):
(WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
LayoutTests:
Fix these tests to not dispatch events outside the window, and correct some of the wording
in the tests.
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-div-expected.txt:
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-div-with-handler-expected.txt:
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-div-with-handler.html:
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-div.html:
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-mainframe-with-handler.html:
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-mainframe.html:
- platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-mainframe.html:
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-mainframe-with-handler.html:
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-mainframe.html:
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select-expected.txt:
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select-with-handler-expected.txt:
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select-with-handler.html:
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select.html:
- 9:54 AM Changeset in webkit [169649] by
-
- 2 edits in trunk/LayoutTests
Run passing WebGL tests on Windows.
https://bugs.webkit.org/show_bug.cgi?id=133563
Patch by Alex Christensen <achristensen@webkit.org> on 2014-06-06
Reviewed by Brent Fulgham.
- platform/win/TestExpectations:
Replaced all WebGL tests with lists of failing and crashing tests to fix.
- 9:33 AM Changeset in webkit [169648] by
-
- 7 edits in trunk
[MediaStream] 'get' prefix is missing for capabilities and constraints.
https://bugs.webkit.org/show_bug.cgi?id=133573
Patch by Kiran <kiran.guduru@samsung.com> on 2014-06-06
Reviewed by Eric Carlson.
Source/WebCore:
Modified the existing MediaStreamTrack.html to test the changes.
As per the Media Capture and Streams spec method names constreaints and
capabilities should be prefixed by 'get'. So updated the method names.
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::getConstraints):
(WebCore::MediaStreamTrack::getCapabilities):
(WebCore::MediaStreamTrack::constraints): Deleted.
(WebCore::MediaStreamTrack::capabilities): Deleted.
- Modules/mediastream/MediaStreamTrack.h:
- Modules/mediastream/MediaStreamTrack.idl:
LayoutTests:
- fast/mediastream/MediaStreamTrack-expected.txt:
- fast/mediastream/MediaStreamTrack.html:
- 9:20 AM Changeset in webkit [169647] by
-
- 4 edits in trunk/Source/WebCore
REGRESSION(169440): Repro crash when playing a video with captions
https://bugs.webkit.org/show_bug.cgi?id=133459
<rdar://problem/17079081>
Reviewed by Eric Carlson.
The change I made in r169440 introduced a crash for paint-on captions. This
resolves the problem as follows:
- No longer attempt to modify the start/endTime in the TextTrack implementation.
- Check for extensions to existing cues when we are about to add new arriving cues. If they extend a current pending cue, don't set an end-time for the pending cue, and throw away the new duplicate. Otherwise set the end time as previously and continue.
- html/track/TextTrack.cpp:
(WebCore::TextTrack::hasCue): Remove 'doesExtendCue' case since this is
no longer possible.
- platform/graphics/InbandTextTrackPrivateClient.h:
(WebCore::GenericCueData::doesExtendCueData): Added.
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::processCue): Check for cues extending
other cues and handle appropriately.
- 9:19 AM Changeset in webkit [169646] by
-
- 4 edits1 copy in trunk/LayoutTests
[GTK] Layout Test accessibility/table-fallback-roles-expose-element-attributes.html is failing
https://bugs.webkit.org/show_bug.cgi?id=133519
Reviewed by Chris Fleizach.
Adapted test to play nicely with the different types of
accessibility hierarchies exposed for Mac and ATK.
- accessibility/table-fallback-roles-expose-element-attributes.html:
Updated text to print information of cells from every platform but
only print information of their children in the Mac.
- accessibility/table-fallback-roles-expose-element-attributes-expected.txt:
Updated expectation to match ATK platforms (GTK & EFL).
- platform/mac/accessibility/table-fallback-roles-expose-element-attributes-expected.txt:
Copied from LayoutTests/accessibility/table-fallback-roles-expose-element-attributes-expected.txt.
- platform/gtk/TestExpectations: Removed expected failure.
- 8:49 AM Changeset in webkit [169645] by
-
- 4 edits in trunk/Source/WebCore
ROLLOUT: r169630: Caused a retain cycle.
https://bugs.webkit.org/show_bug.cgi?id=133463
<rdar://problem/17098100>
Rolling out this change as it introduced a retain cycle.
- Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::setControllerJSObject): Deleted.
- Modules/mediacontrols/MediaControlsHost.h:
(WebCore::MediaControlsHost::controllerJSValue):
(WebCore::MediaControlsHost::setControllerJSValue):
(WebCore::MediaControlsHost::controllerJSObject): Deleted.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
- 12:37 AM Changeset in webkit [169644] by
-
- 1 edit7 adds in trunk/LayoutTests
Add test references for horizontal stretchy operators.
https://bugs.webkit.org/show_bug.cgi?id=72828
Unreviewed Win and EFL gardening.
- platform/efl/mathml/opentype/horizontal-LatinModern-expected.txt: Added.
- platform/efl/mathml/opentype/horizontal-LatinModern-munderover-expected.txt: Added.
- platform/efl/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Added.
- platform/win/mathml/opentype/horizontal-LatinModern-expected.txt: Added.
- platform/win/mathml/opentype/horizontal-LatinModern-munderover-expected.txt: Added.
- platform/win/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Added.
- 12:26 AM Changeset in webkit [169643] by
-
- 1 edit3 adds in trunk/LayoutTests
Add test references for horizontal stretchy operators.
https://bugs.webkit.org/show_bug.cgi?id=72828
Unreviewed Mac gardening.
- platform/mac/mathml/horizontal-LatinModern-expected.txt: Added.
- platform/mac/mathml/horizontal-LatinModern-munderover-expected.txt: Added.
- platform/mac/mathml/opentype-stretchy-horizontal-expected.txt: Added.
- 12:19 AM Changeset in webkit [169642] by
-
- 8 edits in tags/Safari-538.39/Source
Custom patch for <rdar://problem/16650338>.
- 12:08 AM Changeset in webkit [169641] by
-
- 6 edits in releases/WebKitGTK/webkit-2.2
Merge r154727 - [Soup] WebTiming information not shown in the inspector
https://bugs.webkit.org/show_bug.cgi?id=118395
Reviewed by Martin Robinson.
Source/WebCore:
WebTiming information was not correctly provided to WebCore
because the gotHeadersCallback was incorrectly resetting the
original ResourceResponse (which had the ResourceLoadTiming
object) instead of simply updating their contents using the
SoupMessage.
No new test required as this feature is already covered by the
existing webtiming tests. In any case this change includes a fix
for the http/tests/misc/webtiming-ssl.php test which was not
failing even if it should because it was not correct.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::gotHeadersCallback):
(WebCore::restartedCallback): restartedCallback should be
available only if WEB_TIMING is defined.
(WebCore::createSoupMessageForHandleAndRequest): Ditto.
LayoutTests:
Fixed the webiming-ssl.php test that was incorrectly considering a
FAIL as the expected result. It was probably just a legacy
decision which came from the times where DRT was responsible of
reporting WebTiming information.
Also added a new test that fails due to wkb.ug/103927. It was not
detected before because there were no timing information in the
response.
- http/tests/misc/resources/webtiming-ssl.html:
- http/tests/misc/webtiming-ssl-expected.txt:
- platform/gtk/TestExpectations: added
http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_attribute_order.html.
