Timeline
Jun 12, 2014:
- 11:40 PM Changeset in webkit [169931] by
-
- 10 edits3 deletes in trunk
[GTK] Remove all deprecated API from GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=133728
Reviewed by Martin Robinson.
Source/WebCore:
Remove all deprecated symbols from the GObject DOM bindings,
keeping the deprecation infraestructure for future API breaks.
- PlatformGTK.cmake: Remove WebKitDOMDeprecated files from the
build.
- bindings/gobject/WebKitDOMDeprecated.cpp: Removed.
- bindings/gobject/WebKitDOMDeprecated.h: Removed.
- bindings/gobject/WebKitDOMDeprecated.symbols: Removed.
- bindings/gobject/webkitdom.symbols: Updated to the current API.
- bindings/scripts/CodeGeneratorGObject.pm:
(SkipFunction): Remove exceptions for deprecated API.
(GetFunctionDeprecationInformation): Ditto.
(GetEffectiveFunctionName): Ditto.
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
(webkit_dom_test_event_target_dispatch_event): Deleted.
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.symbols:
- dom/Element.idl: Remove GObject exception.
Tools:
- gtk/webkitdom.py:
(WebKitDOMDocGenerator): Remove all deleted classes from the list.
(WebKitDOMDocGeneratorSections.init): Fix a typo in member initialization.
- 9:56 PM Changeset in webkit [169930] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix assertions under JSC::setNeverInline() when running js tests in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=133840
Reviewed by Filip Pizlo.
Fix ASSERT(exec->vm().currentThreadIsHoldingAPILock()); under JSC::setNeverInline()
when running DFG tests.
- API/JSCTestRunnerUtils.cpp:
(JSC::numberOfDFGCompiles):
(JSC::setNeverInline):
- 9:20 PM Changeset in webkit [169929] by
-
- 2 edits in trunk/Source/WebKit2
[iOS][WK2] Do not update the viewport configuration on load until the first viewport arguments is received
https://bugs.webkit.org/show_bug.cgi?id=133719
<rdar://problem/17008149>
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-06-12
Reviewed by Simon Fraser.
When pages are loaded from the page cache, we were updating the viewport to the initial values
in WebPage::dynamicViewportSizeUpdate(), then update the viewport again when the page's viewport argument
are received.
The problem is that was messing up with text autosizing. The page would relayout with the default viewport
configuration, adopt the text autosizing parameters from that size, then remain in that state when
the actual viewport configuration would be set.
With this patch, the viewport configuration is updated from the values in WebCore instead of with default values.
For new documents, this is strictly equivalent. For documents coming from the page cache, the values are from
the previous state of the page, which ensure we do not restart negotiating a viewport configuration from scratch.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didCommitLoad):
- 8:58 PM Changeset in webkit [169928] by
-
- 17 edits in trunk
Subpixel rendering: Make <input type=> and <button> elements' decoration subpixel aware.
https://bugs.webkit.org/show_bug.cgi?id=133812
<rdar://problem/17286309>
Reviewed by Simon Fraser.
Enable <input type=> and <button> decoration painting on subpixel positions.
The theme size is still integral, but its position is snapped to device pixels.
Theme's label, the InlineTextBox is already subpixel position aware.
webkit.org/b/132005 tracks the rest of the themes.
Source/WebCore:
Not testable.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::boundingBoxForQuads): Keep integral snapping for now.
- platform/Theme.h:
(WebCore::Theme::paint):
(WebCore::Theme::inflateControlPaintRect):
- platform/mac/ThemeMac.h:
- platform/mac/ThemeMac.mm:
(WebCore::inflateRect):
(WebCore::configureToggleButton):
(WebCore::sharedRadioCell):
(WebCore::sharedCheckboxCell):
(WebCore::paintToggleButton):
(WebCore::setUpButtonCell):
(WebCore::button):
(WebCore::paintButton):
(WebCore::paintStepper):
(WebCore::ThemeMac::inflateControlPaintRect):
(WebCore::ThemeMac::paint):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addVisualOverflowFromTheme): Keep integral snapping for now.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::addRegionsVisualOverflowFromTheme): Keep integral snapping for now.
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::adjustRepaintRect):
- rendering/RenderTheme.h:
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::adjustRepaintRect):
LayoutTests:
- platform/mac-mountainlion/compositing/contents-opaque/control-layer-expected.txt:
- platform/mac/compositing/contents-opaque/control-layer-expected.txt:
- 6:53 PM Changeset in webkit [169927] by
-
- 4 edits in trunk/Source
[Win] Avoid fork bomb during build
https://bugs.webkit.org/show_bug.cgi?id=133837
<rdar://problem/17296034>
Reviewed by Tim Horton.
- JavaScriptCore.vcxproj/build-generated-files.sh: Use a
reasonable default value when the 'num-cpus' script is not available.
../WebCore:
- WebCore.vcxproj/build-generated-files.sh: Use a reasonable
default value when the 'num-cpus' script is not available.
- 6:49 PM Changeset in webkit [169926] by
-
- 13 edits in trunk/Source
Add support for thread/WorkQueue QoS
https://bugs.webkit.org/show_bug.cgi?id=130688
Reviewed by Anders Carlson & Simon Fraser.
Source/WebCore:
WebCore's ScrollingThread should be UserInteractive.
- page/scrolling/ScrollingThread.cpp:
(WebCore::ScrollingThread::threadCallback):
- ScrollingThread should be UserInteractive
Source/WebKit2:
The EventDispatcher's WorkQueue should be UserInteractive.
- Platform/WorkQueue.cpp:
(WorkQueue::create):
- pass QOS to constructor.
(WorkQueue::WorkQueue):
- pass QOS to platformInitialize.
- Platform/WorkQueue.h:
- added enum, arguments.
- Platform/efl/WorkQueueEfl.cpp:
(WorkQueue::platformInitialize):
- has extra argument.
- Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::platformInitialize):
- has extra argument.
- Platform/mac/WorkQueueMac.cpp:
(platformQOS):
- map from enum to platform type.
(WorkQueue::platformInitialize):
- set the QoS of the dispatch queue.
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::EventDispatcher):
- EventDispatcher's WorkQueue should be UserInteractive.
- config.h:
- added HAVE_QOS_CLASSES
Source/WTF:
Add the ability to mark threads as UserInteractive.
- wtf/Threading.cpp:
(WTF::setCurrentThreadIsUserInteractive):
- added method to set QoS of current thread to UserInteractive.
- wtf/Threading.h:
- added declaration.
- 5:55 PM Changeset in webkit [169925] by
-
- 2 edits in trunk/Tools
[iOS] Fix the view being half offscreen in WebKitTestRunner on iOS
https://bugs.webkit.org/show_bug.cgi?id=133835
Reviewed by Tim Horton.
Don't do the _fakeOrigin stuff when -initWithFrame: is calling -setFrame:
- WebKitTestRunner/ios/PlatformWebViewIOS.mm:
(-[WebKitTestRunnerWindow initWithFrame:]):
(-[WebKitTestRunnerWindow setFrame:]):
- 5:55 PM Changeset in webkit [169924] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] Tiny hack to fix WebKitTestRunner view visibility
https://bugs.webkit.org/show_bug.cgi?id=133833
Reviewed by Tim Horton.
PageClientImplIOS in WebKitTestRunner has a null m_webView, so isViewInWindow
was returning false, which confused things.
Fix by falling back to a check on the content view if the m_webView is nil.
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::isViewVisible):
(WebKit::PageClientImpl::isViewInWindow):
- 5:27 PM Changeset in webkit [169923] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Build fix after r169919.
- WebCore.xcodeproj/project.pbxproj: The 'TileController.h' file must be a private header.
- 5:07 PM Changeset in webkit [169922] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Speculative build fix after r169921.
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::destroyRenderers):
- 4:49 PM Changeset in webkit [169921] by
-
- 2 edits in trunk/Source/WebCore
[MSE][Mac] Stop observing the sample buffer renderers when destroying them.
https://bugs.webkit.org/show_bug.cgi?id=133831
Reviewed by Beth Dakin.
Release our retain on our AVSampleBufferDisplayLayer and AVSampleBufferAudioRenderer by stopping
our observation of its properties when removing them from the SourceBufferPrivateAVFObjC object.
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::destroyRenderers):
- 4:30 PM Changeset in webkit [169920] by
-
- 7 edits in trunk/Source/JavaScriptCore
Remove some dead / unused code.
<https://webkit.org/b/133828>
Reviewed by Filip Pizlo.
- builtins/BuiltinExecutables.cpp:
(JSC::BuiltinExecutables::createBuiltinExecutable):
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedFunctionExecutable::create):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::makeFunction):
- parser/Parser.h:
(JSC::DepthManager::DepthManager): Deleted.
(JSC::DepthManager::~DepthManager): Deleted.
- runtime/CodeCache.cpp:
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
- 4:10 PM Changeset in webkit [169919] by
-
- 2 edits4 moves in trunk/Source/WebCore
Correct file locations after r169914. These should have been
in platform/graphics/ca.
Rubberstamped by Tim Horton.
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/ca/TileController.cpp: Copied from platform/graphics/ca/mac/TileController.cpp.
- platform/graphics/ca/TileController.h: Copied from platform/graphics/ca/mac/TileController.h.
- platform/graphics/ca/TileGrid.cpp: Copied from platform/graphics/ca/mac/TileGrid.cpp.
- platform/graphics/ca/TileGrid.h: Copied from platform/graphics/ca/mac/TileGrid.h.
- platform/graphics/ca/mac/TileController.cpp: Removed.
- platform/graphics/ca/mac/TileController.h: Removed.
- platform/graphics/ca/mac/TileGrid.cpp: Removed.
- platform/graphics/ca/mac/TileGrid.h: Removed.
- 3:48 PM Changeset in webkit [169918] by
-
- 2 edits in tags/Safari-538.40/Source/WebCore
Merged r169917.
- 3:44 PM Changeset in webkit [169917] by
-
- 2 edits in trunk/Source/WebCore
Fix the build after r169913.
- loader/HistoryController.cpp:
(WebCore::HistoryController::restoreScrollPositionAndViewState):
- 3:41 PM Changeset in webkit [169916] by
-
- 3 edits in tags/Safari-538.40/Source/WebCore
Merged r169913. <rdar://problem/17032752>
- 3:36 PM Changeset in webkit [169915] by
-
- 2 edits in trunk/Source/WebCore
Collect correct web timing data from CFNetwork.
https://bugs.webkit.org/show_bug.cgi?id=133824
<rdar://problem/17273654>
Patch by Alex Christensen <achristensen@webkit.org> on 2014-06-12
Reviewed by Simon Fraser.
Covered by existing web timing tests.
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::getConnectionTimingData):
Use _kCFNTimingDataFetchStart as the reference start time key.
- 3:34 PM Changeset in webkit [169914] by
-
- 5 edits2 moves in trunk/Source/WebCore
Convert TileController and TileGrid from ObjC to C++
https://bugs.webkit.org/show_bug.cgi?id=133819
<rdar://problem/17291841>
Reviewed by Tim Horton.
Convert TileGrid.mm and TileController.mm into C++ implementations. This required creating a 'frameForLayer'
wrapper to call the 'frame' method of the CALayer object.
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/ca/mac/TileController.cpp: Copied from platform/graphics/ca/mac/TileController.mm.
(WebCore::TileController::blankPixelCountForTiles):
- platform/graphics/ca/mac/TileController.mm: Removed.
- platform/graphics/ca/mac/TileGrid.cpp: Copied from platform/graphics/ca/mac/TileGrid.mm.
- platform/graphics/ca/mac/TileGrid.h:
- platform/graphics/ca/mac/TileGrid.mm: Removed.
- platform/graphics/mac/WebLayer.h:
- platform/graphics/mac/WebLayer.mm:
(WebCore::frameForLayer): Wrapper function to hide ObjC call from C++ compilation unit.
- 3:24 PM Changeset in webkit [169913] by
-
- 3 edits in trunk/Source/WebCore
[iOS WK2] Fix crash on back/foward swipe
https://bugs.webkit.org/show_bug.cgi?id=133826
<rdar://problem/17032752>
Reviewed by Tim Horton.
AsyncScrollingCoordinator::frameViewForScrollingNode() would crash with a null root
state node, because HistoryController::restoreScrollPositionAndViewState() tried
to restore scroll position (via restoreViewState()) before hooking up the scrolling
coordinator.
Fix by doing the scrollingCoordinator->frameViewRootLayerDidChange() before
calling restoreViewState().
Also add a defensive null-check on the root state node in updateScrollPositionAfterAsyncScrollTimerFired().
- loader/HistoryController.cpp:
(WebCore::HistoryController::restoreScrollPositionAndViewState):
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::frameViewForScrollingNode):
- 2:21 PM Changeset in webkit [169912] by
-
- 3 edits in trunk/Source/WebKit2
Add SPI for image controls and service controls preferences.
<rdar://problem/17292209> and https://bugs.webkit.org/show_bug.cgi?id=133820
Reviewed by Anders Carlsson.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetServiceControlsEnabled):
(WKPreferencesGetServiceControlsEnabled):
(WKPreferencesSetImageControlsEnabled):
(WKPreferencesGetImageControlsEnabled):
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- 1:54 PM Changeset in webkit [169911] by
-
- 2 edits in trunk/Source/WebCore
Add a space after the comma.
- platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::add):
- 1:40 PM Changeset in webkit [169910] by
-
- 2 edits in trunk/Source/WebKit2
[Mac] Allow reading com.apple.universalaccess preferences
https://bugs.webkit.org/show_bug.cgi?id=133817
<rdar://problem/17028261>
Reviewed by Anders Carlsson.
- WebProcess/com.apple.WebProcess.sb.in:
- 1:34 PM Changeset in webkit [169909] by
-
- 5 edits in trunk/Source/WebKit/win
[Win] Avoid crashes in code that converted CFDictionaries to HashMap
https://bugs.webkit.org/show_bug.cgi?id=133813
<rdar://problem/17291647>
Reviewed by Tim Horton.
- WebHistory.cpp: Add empty string checks to avoid crashes in
hash function.
(WebHistory::removeItem):
(WebHistory::addItem):
(WebHistory::visitedURL):
(WebHistory::itemForURL):
(WebHistory::removeItemForURLString):
(WebHistory::itemForURLString):
- WebPreferences.cpp: Ditto.
(WebPreferences::getInstanceForIdentifier):
(WebPreferences::setInstance):
(WebPreferences::removeReferenceForIdentifier):
- WebView.cpp: Ditto. Also convert OwnPtr uses in this file
to std::unique_ptr.
(WebView::close):
(WebView::handleMouseEvent):
(WebView::registerEmbeddedViewMIMEType):
(WebView::shouldUseEmbeddedView):
(WebView::enterFullscreenForNode):
(WebView::fullScreenController):
- WebView.h:
- 1:23 PM Changeset in webkit [169908] by
-
- 2 edits in trunk/Source/WebKit2
Fix build.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<HTTPHeaderMap>::decode):
(CoreIPC::ArgumentCoder<ResourceRequest>::decode):
- 12:56 PM Changeset in webkit [169907] by
-
- 3 edits in trunk/LayoutTests
[GTK] Unreviewed GTK gardening.
Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-06-12
- platform/gtk/TestExpectations: Report and mark new failures and
timeouts.
- platform/gtk/fast/forms/placeholder-position-expected.txt:
Rebaseline test after r169780.
- 12:50 PM Changeset in webkit [169906] by
-
- 6 edits in trunk/Source/WebCore
Move header value merging to HTTPHeaderMap
https://bugs.webkit.org/show_bug.cgi?id=133815
Reviewed by Andreas Kling.
- platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::set):
(WebCore::HTTPHeaderMap::add):
- platform/network/HTTPHeaderMap.h:
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::addHTTPHeaderField):
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::addHTTPHeaderField):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::setRequestHeaderInternal):
- 12:07 PM Changeset in webkit [169905] by
-
- 2 edits in trunk/Source/WebKit2
Fixed a harmless error message when rewrite-availability-macros.sh is run in a clean build.
Rubber-stamped by Anders Carlsson.
- mac/rewrite-availability-macros.sh:
- 11:50 AM Changeset in webkit [169904] by
-
- 12 edits1 add in trunk/Source/WebCore
Add ShapeValue.cpp and move ShapeValue::isImageValid() there
https://bugs.webkit.org/show_bug.cgi?id=133809
Reviewed by Antti Koivisto.
This gets rid of CachedImage.h (and ResourceRequest and friends) from RenderStyle.h.
- CMakeLists.txt:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::shapePropertyValue):
- css/CSSCrossfadeValue.cpp:
- css/CSSFilterImageValue.cpp:
- css/StyleResolver.h:
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):
- rendering/ShapeValue.cpp: Added.
(WebCore::ShapeValue::isImageValid):
- rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::referenceBox):
(WebCore::ShapeOutsideInfo::computedShape):
(WebCore::ShapeOutsideInfo::isEnabledFor):
- rendering/style/ShapeValue.h:
(WebCore::ShapeValue::type):
(WebCore::ShapeValue::setImage):
(WebCore::ShapeValue::ShapeValue):
(WebCore::ShapeValue::isImageValid): Deleted.
- 11:38 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 11:37 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 11:22 AM Changeset in webkit [169903] by
-
- 5 edits in trunk/Source/JavaScriptCore
Move structureHasRareData out of TypeInfo
https://bugs.webkit.org/show_bug.cgi?id=133800
Reviewed by Andreas Kling.
StructureHasRareData was originally put in TypeInfo to avoid making Structure bigger,
but we have a few spare bits in Structure so it would be nice to remove this hack.
- runtime/JSTypeInfo.h:
(JSC::TypeInfo::newImpurePropertyFiresWatchpoints):
(JSC::TypeInfo::structureHasRareData): Deleted.
- runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::allocateRareData):
(JSC::Structure::cloneRareDataFrom):
- runtime/Structure.h:
(JSC::Structure::previousID):
(JSC::Structure::objectToStringValue):
(JSC::Structure::setObjectToStringValue):
(JSC::Structure::setPreviousID):
(JSC::Structure::clearPreviousID):
(JSC::Structure::previous):
(JSC::Structure::rareData):
- runtime/StructureInlines.h:
(JSC::Structure::setEnumerationCache):
(JSC::Structure::enumerationCache):
- 10:42 AM Changeset in webkit [169902] by
-
- 9 edits6 adds in branches/ftlopt
[ftlopt] DFG get_by_id should inline chain accesses with a slightly polymorphic base
https://bugs.webkit.org/show_bug.cgi?id=133751
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::appendVariant):
(JSC::GetByIdStatus::computeForStubInfo):
- bytecode/GetByIdVariant.cpp:
(JSC::GetByIdVariant::attemptToMerge):
- bytecode/GetByIdVariant.h:
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::emitPrototypeChecks):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::handlePutById):
- runtime/IntendedStructureChain.cpp:
(JSC::IntendedStructureChain::IntendedStructureChain):
(JSC::IntendedStructureChain::isStillValid):
(JSC::IntendedStructureChain::isNormalized):
(JSC::IntendedStructureChain::terminalPrototype):
(JSC::IntendedStructureChain::operator==):
(JSC::IntendedStructureChain::visitChildren):
(JSC::IntendedStructureChain::dumpInContext):
(JSC::IntendedStructureChain::chain): Deleted.
- runtime/IntendedStructureChain.h:
(JSC::IntendedStructureChain::prototype):
(JSC::IntendedStructureChain::operator!=):
(JSC::IntendedStructureChain::head): Deleted.
LayoutTests:
- js/regress/poly-chain-access-expected.txt: Added.
- js/regress/poly-chain-access-simpler-expected.txt: Added.
- js/regress/poly-chain-access-simpler.html: Added.
- js/regress/poly-chain-access.html: Added.
- js/regress/script-tests/poly-chain-access-simpler.js: Added.
- js/regress/script-tests/poly-chain-access.js: Added.
- 10:33 AM Changeset in webkit [169901] by
-
- 2 edits in tags/Safari-538.40/Source/WTF
Merged r169900.
- 9:35 AM Changeset in webkit [169900] by
-
- 2 edits in trunk/Source/WTF
Fix Mac after r169880.
This revision added a C++ comment to Platform.h, which breaks sandbox profile
preprocessing.
Also, I do not believe that this comment was entirely accurate - we've always used
this technique with GCC, so there has to be more to it. So, I just removed the comment.
- wtf/Platform.h:
- 9:13 AM Changeset in webkit [169899] by
-
- 6 edits in branches/safari-537.60-branch/Source
Unreviewed build fix. (Merge r167685)
Source/JavaScriptCore:
- DerivedSources.make: Specify path to Perl/Python to avoid
build failures under Python 2.7+.
Source/WebCore:
- DerivedSources.make: Specify path to Perl/Python to avoid
build failures under Python 2.7+.
Source/WTF:
- WTF.vcxproj/WTFGenerated.make: Specify path to Perl/Python
to avoid build failures under Python 2.7+.
- 7:53 AM Changeset in webkit [169898] by
-
- 11 edits in trunk/Source/WebCore
Subpixel rendering: Make <select> element's decoration subpixel aware.
https://bugs.webkit.org/show_bug.cgi?id=133781
<rdar://problem/17272083>
Reviewed by Simon Fraser.
Enable <select> decoration painting on subpixel positions.
The theme size is still integral, but its position is snapped to device pixels.
Theme's label, the InlineTextBox is already subpixel position aware.
webkit.org/b/132005 tracks the rest of the themes.
Not testable.
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
- rendering/RenderTheme.h:
(WebCore::RenderTheme::paintMenuList):
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
(WebCore::inflateRect):
(WebCore::RenderThemeMac::adjustRepaintRect):
(WebCore::RenderThemeMac::paintMenuList):
(WebCore::RenderThemeMac::progressBarRectForBounds):
(WebCore::RenderThemeMac::setPopupButtonCellState):
(WebCore::RenderThemeMac::inflateRect): Deleted.
- 7:09 AM Changeset in webkit [169897] by
-
- 2 edits in trunk/Source/WebCore
[MSE][Mac] Crash in MediaSourcePrivateAVFObjC::naturalSize()
https://bugs.webkit.org/show_bug.cgi?id=133789
Reviewed by Eric Carlson.
Add null-check to proctect against being queried for the naturalSize before we have a
m_mediaSourcePrivate.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::naturalSize):
- 7:07 AM Changeset in webkit [169896] by
-
- 2 edits in trunk/Source/WebCore
[GTK] fails to build with --disable-webgl --disable-accelerated-compositing
https://bugs.webkit.org/show_bug.cgi?id=131267
Reviewed by Philippe Normand.
Add missing headers needed for Float32Array::create().
- Modules/webaudio/AudioBuffer.cpp:
- 7:06 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 7:04 AM Changeset in webkit [169895] by
-
- 5 edits in trunk/Source
Versioning.
- 7:03 AM Changeset in webkit [169894] by
-
- 1 copy in tags/Safari-538.40
New Tag.
- 6:25 AM WebKitGTK/2.4.x edited by
- changed bug id to trac changset (diff)
- 5:53 AM Changeset in webkit [169893] by
-
- 2 edits in trunk/Tools
[GTK] Performance tests should be always ran with WKTR.
https://bugs.webkit.org/show_bug.cgi?id=133780
Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-06-12
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.init): Enable webkit_test_runner when port
is GTK.
- 5:47 AM Changeset in webkit [169892] by
-
- 4 edits in trunk
[GTK] REGRESSION: application name is not correctly appended to the UA
https://bugs.webkit.org/show_bug.cgi?id=133793
Reviewed by Carlos Garcia Campos.
Source/WebCore:
We must use a blank to separate the default UA provided by WebKitGtk
from the application name coming from the public API.
Added an extra test case to the API tests to catch regressions.
- platform/gtk/UserAgentGtk.cpp:
(WebCore::standardUserAgent):
Tools:
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
(testWebKitSettingsUserAgent):
- 5:41 AM Changeset in webkit [169891] by
-
- 3 edits in trunk/Source/WebCore
WorkerRunLoop::Task::performTask should take in WorkerGlobalScope* to avoid downcasting
https://bugs.webkit.org/show_bug.cgi?id=133616
Reviewed by Andreas Kling.
- workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::Task::performTask): Demand the context parameter to be a pointer
to WorkerGlobalScope instead of ScriptExecutionContext, avoiding an unnecessary downcast.
In the future this complete code path should use a reference to WorkerGlobalScope instead
of a pointer.
- workers/WorkerRunLoop.h:
- 5:03 AM WebKitGTK/2.4.x edited by
- (diff)
- 4:39 AM Changeset in webkit [169890] by
-
- 4 edits in trunk/LayoutTests
[EFL] Change expectations for three failing js/dom layout tests.
https://bugs.webkit.org/show_bug.cgi?id=133743
Unreviewed EFL gardening.
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2014-06-12
- platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-shared-worker-expected.txt:
- 3:10 AM Changeset in webkit [169889] by
-
- 2 edits3 adds in trunk/Source/JavaScriptCore
Allow enum guards to be generated from the replay json files
https://bugs.webkit.org/show_bug.cgi?id=133399
Patch by Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com> on 2014-06-12
Reviewed by Csaba Osztrogonác.
- replay/scripts/CodeGeneratorReplayInputs.py:
(Type.init):
(InputsModel.parse_type_with_framework_name):
(Generator.generate_header):
(Generator.generate_implementation):
- replay/scripts/tests/expected/generate-enum-with-guard.json-TestReplayInputs.cpp: Added.
(Test::HandleWheelEvent::HandleWheelEvent):
(Test::HandleWheelEvent::~HandleWheelEvent):
(JSC::InputTraits<Test::HandleWheelEvent>::type):
(JSC::InputTraits<Test::HandleWheelEvent>::encode):
(JSC::InputTraits<Test::HandleWheelEvent>::decode):
(JSC::EncodingTraits<WebCore::PlatformWheelEventPhase>::encodeValue):
(JSC::EncodingTraits<WebCore::PlatformWheelEventPhase>::decodeValue):
- replay/scripts/tests/expected/generate-enum-with-guard.json-TestReplayInputs.h: Added.
(JSC::InputTraits<Test::HandleWheelEvent>::queue):
(Test::HandleWheelEvent::platformEvent):
- replay/scripts/tests/generate-enum-with-guard.json: Added.
- 2:41 AM Changeset in webkit [169888] by
-
- 2 edits in trunk/LayoutTests
[EFL] Change expectations for three failing layout tests.
https://bugs.webkit.org/show_bug.cgi?id=133738
Unreviewed EFL layout tests gardening.
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2014-06-12
- platform/efl/TestExpectations:
- 2:25 AM Changeset in webkit [169887] by
-
- 4 edits in trunk
[GTK] Unsupported browser in www.icloud.com
https://bugs.webkit.org/show_bug.cgi?id=133403
Reviewed by Martin Robinson.
Source/WebCore:
We claim to be Safari (among others) to ensure maximum
compatibility with existing web sites. Valid Safari UA strings do
always (since Safari 3.0) contain the string "Version/X" before
the "Safari/X" part. We were wrongly only adding it in very
specific cases and we were placing it at the wrong position as it
must precede the "Safari/X" part.
From now on we unconditionally prepend the "Version/X" string to
the "Safari/X" part as we always claim to be Safari. This makes
the NeedsSafariVersion6 quirk invalid. This not only fixes
"unsupported browser" issues in icloud.com, but also in
globalforestwatch.com and live.com among many others.
Apart from that I'm bumping the Safari Version in the UA to 8.0 as
we're already claiming to be "Safari/538.35"" which corresponds to
Safari 8 beta.
- platform/gtk/UserAgentGtk.cpp:
(WebCore::buildUserAgentString):
(WebCore::standardUserAgentForURL):
Tools:
- TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
(TestWebKitAPI::TEST): removed a test for the NeedsSafariVersion6
quirk that was removed.
- 1:50 AM Changeset in webkit [169886] by
-
- 13 edits in trunk/Source/JavaScriptCore
Unreviewed. Fix GTK+ build after r169823.
Include StructureInlines.h in a few more files to fix linking
issues due to JSC::Structure::get undefined symbol.
- runtime/ArrayIteratorConstructor.cpp:
- runtime/ArrayIteratorPrototype.cpp:
- runtime/JSConsole.cpp:
- runtime/JSMapIterator.cpp:
- runtime/JSSet.cpp:
- runtime/JSSetIterator.cpp:
- runtime/JSWeakMap.cpp:
- runtime/MapIteratorPrototype.cpp:
- runtime/MapPrototype.cpp:
- runtime/SetIteratorPrototype.cpp:
- runtime/SetPrototype.cpp:
- runtime/WeakMapPrototype.cpp:
- 1:01 AM Changeset in webkit [169885] by
-
- 2 edits in trunk/Source/JavaScriptCore
[EFL] One more URTBF after r169823 to make ARM64 build happy too.
- runtime/JSMap.cpp:
- 12:37 AM Changeset in webkit [169884] by
-
- 4 edits in trunk/Source/WebKit2
[GTK] Remove view mode API
https://bugs.webkit.org/show_bug.cgi?id=133725
Reviewed by Martin Robinson.
It currently does nothing because support for view source mode was
removed from WebCore.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewSetProperty):
(webkitWebViewGetProperty):
(webkit_web_view_class_init):
(webkit_web_view_set_view_mode): Deleted.
(webkit_web_view_get_view_mode): Deleted.
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
- 12:25 AM Changeset in webkit [169883] by
-
- 5 edits in trunk/Source
Avoid creating a CFData when checking if a resource is file backed
https://bugs.webkit.org/show_bug.cgi?id=133783
Reviewed by Andreas Kling.
Source/WebCore:
Export SharedBuffer::hasPlatformData().
No new tests because no functional changes.
- WebCore.exp.in:
- platform/SharedBuffer.h:
Source/WebKit2:
When a resource is file backed, we have it as a single CFDataRef in SharedBuffer. Add an
early return in tryGetShareableHandleFromSharedBuffer() so we don't end up creating a new
CFDataRef if we don't already have one in SharedBuffer. If we had to create a CFDataRef, the
it can't have been a file backed resource.
- NetworkProcess/mac/NetworkResourceLoaderMac.mm:
(WebKit::NetworkResourceLoader::tryGetShareableHandleFromSharedBuffer):
Jun 11, 2014:
- 11:36 PM Changeset in webkit [169882] by
-
- 3 edits in tags/Safari-538.39.41/WebKitLibraries
Rolling out r169873
- 11:36 PM Changeset in webkit [169881] by
-
- 2 edits in trunk/Source/WebKit2
Fix build break on EFL and GTK ports since r169820
https://bugs.webkit.org/show_bug.cgi?id=133786
Reviewed by Philippe Normand.
ENABLE_PRIMARY_SNAPSHOTTED_PLUGIN_HEURISTIC macro are missing in PluginView::pluginSnapshotTimerFired().
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::pluginSnapshotTimerFired):
- 11:18 PM Changeset in webkit [169880] by
-
- 5 edits in trunk/Source
[EFL][GTK] Ultimate fix not to have build failures
in the future because of "#if TARGET_OS_IPHONE" guards.
Unreviewed buildfix.
Source/WebKit2:
Revert the previous wrong fix attempt r169879.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
- WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
Source/WTF:
- wtf/Platform.h: Define TARGET_OS_IPHONE to 0 on EFL and GTK.
- 10:45 PM Changeset in webkit [169879] by
-
- 3 edits in trunk/Source/WebKit2
Fix build break on EFL port since r169869
https://bugs.webkit.org/show_bug.cgi?id=133785
Unreviewed, fix a build break on EFL port.
Patch by Gyuyoung Kim <gyuyoung.kim@samsung.com> on 2014-06-11
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: Use defined(TARGET_OS_IPHONE).
- WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: ditto.
- 10:22 PM Changeset in webkit [169878] by
-
- 2 edits in trunk
Unreviewed, rolling out r169877.
https://bugs.webkit.org/show_bug.cgi?id=133784
rollout wrong build fix approach for EFL port (Requested by
gyuyoung on #webkit).
Reverted changeset:
"Unreviewed, EFL build fix since r169869."
http://trac.webkit.org/changeset/169877
- 10:03 PM Changeset in webkit [169877] by
-
- 2 edits in trunk
Unreviewed, EFL build fix since r169869.
Additionally literal-suffix is removed in EFL compile flag, because it is duplicated.
- Source/cmake/WebKitHelpers.cmake: Treat undef error as build warning.
- 8:24 PM Changeset in webkit [169876] by
-
- 2 edits in tags/Safari-538.39.41/Source/WebCore
Re-merged r169855. <rdar://problem/16746383>
- 8:12 PM Changeset in webkit [169875] by
-
- 2 edits in tags/Safari-538.39.41/Source/WebCore
Re-merged r169843. <rdar://problem/16746383>
- 8:09 PM Changeset in webkit [169874] by
-
- 11 edits in tags/Safari-538.39.41/Source/WebCore
Re-merged r169830. <rdar://problem/16746383>
- 7:55 PM Changeset in webkit [169873] by
-
- 3 edits in tags/Safari-538.39.41/WebKitLibraries
Re-merged r169817. <rdar://problem/17009091>
- 7:24 PM Changeset in webkit [169872] by
-
- 4 edits2 adds in trunk
SVGGlyphToPathTranslator ASSERTs when encountering a missing glyph in an SVG font
https://bugs.webkit.org/show_bug.cgi?id=133528
Reviewed by Simon Fraser.
Source/WebCore:
Turns out this assertion is benign. We can take an early out of advance() (which
is then handled properly by Font::dashesForIntersectionsWithRect()
Test: svg/custom/skip-underline-missing-glyph.html
- platform/graphics/mac/FontMac.mm:
(WebCore::Font::dashesForIntersectionsWithRect): Rather than skip partial results,
don't skip anything at all to be consistent.
- rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGGlyphToPathTranslator::advance): Take an early out to avoid an ASSERT.
LayoutTests:
Make sure that no ASSERT occurs in this situation. In addition, make sure that the
whole element doesn't get skip:ink gaps. This will need to be updated when we
support SVG + non-SVG mixed runs.
- svg/custom/skip-underline-missing-glyph-expected.html: Added
- svg/custom/skip-underline-missing-glyph.html: Added
- 7:11 PM Changeset in webkit [169871] by
-
- 3 edits in tags/Safari-538.39.41/WebKitLibraries
Roll out changes from 17009091
- 7:10 PM Changeset in webkit [169870] by
-
- 12 edits in tags/Safari-538.39.41/Source/WebCore
Roll out changes for 16746383.
- 7:03 PM Changeset in webkit [169869] by
-
- 14 edits in trunk
[iOS WK2] Give WebKitTestRunner a viewport configuration with initial scale=1 for testing
https://bugs.webkit.org/show_bug.cgi?id=133779
Reviewed by Benjamin Poulain.
Source/WebCore:
Add a "testing" viewport configuration with initial scale of 1.
- WebCore.exp.in:
- page/ViewportConfiguration.cpp:
(WebCore::ViewportConfiguration::testingParameters):
- page/ViewportConfiguration.h:
Source/WebKit2:
Support a custom viewport configuration for testing, on iOS.
- UIProcess/API/ios/WKViewIOS.mm:
(-[WKView _frameOrBoundsChanged]): Call setViewportConfigurationMinimumLayoutSize()
just as WKWebView does.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetUseTestingViewportConfiguration): New SPI to set a viewport config for testing.
- WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: Ditto.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::setUseTestingViewportConfiguration):
(WebKit::WebPage::isUsingTestingViewportConfiguration):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::resetViewportDefaultConfiguration):
Tools:
Tell the WebPage to use the testing viewport configuration from the injected bundle.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessage): Code cleanup.
- WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
(WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Call WKBundlePageSetUseTestingViewportConfiguration()
on iOS.
- 5:46 PM Changeset in webkit [169868] by
-
- 2 edits in trunk/Source/WebCore
Keep CFDataRefs in SharedBuffer instead of merging them
https://bugs.webkit.org/show_bug.cgi?id=133775
Reviewed by Alexey Proskuryakov.
Instead of merging the CFDataRefs into one buffer, save them in as CFDataRefs in
SharedBuffer. They will get merged when code calls buffer() later on.
No new tests because no functional changes.
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::handleDataArray):
- 5:39 PM Performance Tests edited by
- Update ports and links (diff)
- 5:32 PM Changeset in webkit [169867] by
-
- 2 edits in trunk/Source/WebKit/mac
WebFrameNetworkContext should not have a sourceApplicationIdentifier in WK1.
https://bugs.webkit.org/show_bug.cgi?id=133772
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-06-11
Reviewed by Jer Noble.
Return empty string from sourceApplicationIdentifier for WK1.
- WebCoreSupport/WebFrameNetworkingContext.mm:
(WebFrameNetworkingContext::sourceApplicationIdentifier):
- 5:30 PM Changeset in webkit [169866] by
-
- 4 edits in trunk
editing/selection/selection-in-iframe-removed-crash.html or selection-invalid-offset.html crashes intermittently
https://bugs.webkit.org/show_bug.cgi?id=111521
<rdar://problem/15159351>
Reviewed by Brady Eidson.
Source/WebCore:
Covered by existing tests.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::commitData): Bail out if the
load was canceled from under receivedFirstData(). Since this is where we commit the
load, there are ample opportunities for scripts or clients to do anything.
LayoutTests:
- platform/mac/TestExpectations: Removed expectations for the tests.
- 5:30 PM Changeset in webkit [169865] by
-
- 3 edits in tags/Safari-538.39.41/Source/WebCore
Merged r169855.
- 5:25 PM Changeset in webkit [169864] by
-
- 15 edits in branches/ftlopt/Source/JavaScriptCore
Readded native calling to the FTL and Split the DFG nodes
Call and Construct into NativeCall and NativeConstruct
to better represent their semantics.
https://bugs.webkit.org/show_bug.cgi?id=133660
Reviewed by Filip Pizlo.
- dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects): Added NativeCall and NativeConstruct case
- dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::addCall): added NativeCall case. (JSC::DFG::ByteCodeParser::handleCall): set to return NativeCall or NativeConstruct instead of Call or Construct in the presence of a native function.
- dfg/DFGClobberize.h: (JSC::DFG::clobberize): added NativeCall and NativeConstruct case.
- dfg/DFGDoesGC.cpp: (JSC::DFG::doesGC): added NativeCall and NativeConstruct case.
- dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): added NativeCall and NativeConstruct case.
- dfg/DFGNode.h: (JSC::DFG::Node::hasHeapPrediction): added NativeCall and NativeConstruct case. (JSC::DFG::Node::canBeKnownFunction): changed to NativeCall and NativeConstruct. (JSC::DFG::Node::hasKnownFunction): changed to NativeCall and NativeConstruct.
- dfg/DFGNodeType.h: added NativeCall and NativeConstruct.
- dfg/DFGPredictionPropagationPhase.cpp: (JSC::DFG::PredictionPropagationPhase::propagate): added NativeCall and NativeConstruct case.
- dfg/DFGSafeToExecute.h: (JSC::DFG::safeToExecute): added NativeCall and NativeConstruct case.
- dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::emitCall): ditto (JSC::DFG::SpeculativeJIT::compile): ditto
- dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::emitCall): ditto (JSC::DFG::SpeculativeJIT::compile): ditto
- ftl/FTLCapabilities.cpp: (JSC::FTL::canCompile): ditto
- ftl/FTLLowerDFGToLLVM.cpp: (JSC::FTL::LowerDFGToLLVM::lower): ditto (JSC::FTL::LowerDFGToLLVM::compileNode): ditto. (JSC::FTL::LowerDFGToLLVM::compileNativeCallOrConstruct): Added. (JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct): removed NativeCall and NativeConstruct functionality. (JSC::FTL::LowerDFGToLLVM::didOverflowStack): added NativeCall and NativeConstruct case.
- runtime/JSCJSValue.h: added JS_EXPORT_PRIVATE to toInteger as it is apparently needed.
Patch by Matthew Mirman <mmirman@apple.com> on 2014-06-11
- 5:14 PM Changeset in webkit [169863] by
-
- 10 edits in trunk/Source/WebKit2
Remove unused VisibleContentRectUpdateInfo update ID
https://bugs.webkit.org/show_bug.cgi?id=133777
Reviewed by Benjamin Poulain.
Remove some unused code.
- Shared/VisibleContentRectUpdateInfo.cpp:
(WebKit::VisibleContentRectUpdateInfo::encode):
(WebKit::VisibleContentRectUpdateInfo::decode):
- Shared/VisibleContentRectUpdateInfo.h:
(WebKit::VisibleContentRectUpdateInfo::VisibleContentRectUpdateInfo):
(WebKit::operator==):
(WebKit::VisibleContentRectUpdateInfo::updateID): Deleted.
- Shared/mac/RemoteLayerTreeTransaction.h:
(WebKit::RemoteLayerTreeTransaction::setLastVisibleContentRectUpdateID): Deleted.
(WebKit::RemoteLayerTreeTransaction::lastVisibleContentRectUpdateID): Deleted.
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::nextVisibleContentRectUpdateID): Deleted.
(WebKit::WebPageProxy::lastVisibleContentRectUpdateID): Deleted.
- UIProcess/ios/WKContentView.mm:
(-[WKContentView didUpdateVisibleRect:unobscuredRect:unobscuredRectInScrollViewCoordinates:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:]):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::willCommitLayerTree):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::updateVisibleContentRects):
- 5:14 PM Changeset in webkit [169862] by
-
- 3 edits2 adds in trunk
Subpixel rendering: RenderBox's content clipping should clip on device pixel boundary.
https://bugs.webkit.org/show_bug.cgi?id=133767
<rdar://problem/17272365>
Reviewed by Simon Fraser.
Push RenderBox's content clipping to device pixel boundaries. Integral snapping makes
content cut off prematurely.
Source/WebCore:
Test: fast/inline-block/hidpi-margin-top-with-subpixel-value-and-overflow-hidden.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::pushContentsClip):
LayoutTests:
- fast/inline-block/hidpi-margin-top-with-subpixel-value-and-overflow-hidden-expected.html: Added.
- fast/inline-block/hidpi-margin-top-with-subpixel-value-and-overflow-hidden.html: Added.
- 4:57 PM Changeset in webkit [169861] by
-
- 4 edits in trunk/Source/WebCore
Remove XHRReplayData::addHeader
https://bugs.webkit.org/show_bug.cgi?id=133776
Reviewed by Antti Koivisto.
Just pass the HTTP header map to XHRReplayData::create directly.
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::willLoadXHR):
- inspector/NetworkResourcesData.cpp:
(WebCore::XHRReplayData::create):
(WebCore::XHRReplayData::XHRReplayData):
(WebCore::XHRReplayData::addHeader): Deleted.
- inspector/NetworkResourcesData.h:
- 4:53 PM Changeset in webkit [169860] by
-
- 5 edits in branches/safari-537.60-branch/Source
Versioning.
- 4:49 PM Changeset in webkit [169859] by
-
- 1 copy in tags/Safari-537.60.18
New Tag.
- 4:43 PM Changeset in webkit [169858] by
-
- 5 edits in tags/Safari-538.39.41/Source
Version bump.
- 4:42 PM Changeset in webkit [169857] by
-
- 2 edits in tags/Safari-538.39.41/Source/WebCore
Merge r169843.
- 4:17 PM Changeset in webkit [169856] by
-
- 3 edits in branches/safari-537.60-branch/Source/WebCore
Merge r169842.
2014-06-11 Brent Fulgham <Brent Fulgham>
[Win] Avoid deadlock with AVFoundation
https://bugs.webkit.org/show_bug.cgi?id=133762
<rdar://problem/17128248>
Reviewed by Eric Carlson.
Always invoke our notifications asynchronously so that we do not
execute long-running code while holding the AVFWrapper map mutex
lock. AVFoundationCF callbacks can deadlock if we call into AVF
while holding this lock.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification):
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: (WebCore::AVFWrapper::legibleOutputCallback): Correct bad assertion.
- 4:12 PM Changeset in webkit [169855] by
-
- 3 edits in trunk/Source/WebCore
Fix the Mac build.
- WebCore.exp.in: Exported ZN7WebCore19ResourceRequestBase15setHTTPReferrerERKN3WTF6StringE
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm: Moved ivar declarations to @interface to account for the 32-bit legacy runtime.
- 4:06 PM Changeset in webkit [169854] by
-
- 3 edits2 adds in trunk/Source/WebKit2
[Cocoa] Move CompletionHandlerCallChecker into a separate file
https://bugs.webkit.org/show_bug.cgi?id=133774
Reviewed by Anders Carlsson.
- Shared/Cocoa/CompletionHandlerCallChecker.h: Added.
- Shared/Cocoa/CompletionHandlerCallChecker.mm: Added.
(WebKit::CompletionHandlerCallChecker::create):
(WebKit::CompletionHandlerCallChecker::CompletionHandlerCallChecker):
(WebKit::CompletionHandlerCallChecker::~CompletionHandlerCallChecker):
(WebKit::CompletionHandlerCallChecker::didCallCompletionHandler):
(WebKit::CompletionHandlerCallChecker::classImplementingDelegateMethod):
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::CompletionHandlerCallChecker::create): Deleted.
(WebKit::CompletionHandlerCallChecker::~CompletionHandlerCallChecker): Deleted.
(WebKit::CompletionHandlerCallChecker::didCallCompletionHandler): Deleted.
(WebKit::CompletionHandlerCallChecker::CompletionHandlerCallChecker): Deleted.
(WebKit::CompletionHandlerCallChecker::classImplementingDelegateMethod): Deleted.
- WebKit2.xcodeproj/project.pbxproj:
- 3:55 PM Changeset in webkit [169853] by
-
- 4 edits in trunk/Source/JavaScriptCore
Inline caching should try to flatten uncacheable dictionaries
https://bugs.webkit.org/show_bug.cgi?id=133683
Reviewed by Geoffrey Garen.
There exists a body of JS code that deletes properties off of objects (especially function/constructor objects),
which puts them into an uncacheable dictionary state. This prevents all future inline caching for these objects.
If properties are deleted out of the object during its initialization, we can enable caching for that object by
attempting to flatten it when we see we're trying to do inline caching with that object. We then record that we
performed this flattening optimization in the object's Structure. If it ever re-enters the uncacheable dictionary
state then we can just give up on caching that object.
In refactoring some of the code in tryCacheGetById and tryBuildGetByIdList to reduce some duplication, I added
the InlineCacheAction enum, a new way to indicate the success or failure of an inline caching attempt. I changed
the other inline caching functions to return this enum rather than the opaque booleans that we were previously
returning.
- jit/Repatch.cpp:
(JSC::actionForCell):
(JSC::tryCacheGetByID):
(JSC::repatchGetByID):
(JSC::tryBuildGetByIDList):
(JSC::buildGetByIDList):
(JSC::tryCachePutByID):
(JSC::repatchPutByID):
(JSC::tryBuildPutByIdList):
(JSC::buildPutByIdList):
(JSC::tryRepatchIn):
(JSC::repatchIn):
- runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::flattenDictionaryStructure):
- runtime/Structure.h:
(JSC::Structure::hasBeenFlattenedBefore):
- 3:52 PM Changeset in webkit [169852] by
-
- 3 edits in trunk/Source/WebCore
Make FrameView 8 bytes smaller
https://bugs.webkit.org/show_bug.cgi?id=133771
Reviewed by Anders Carlsson.
m_borderX and m_borderY were historical cruft.
- page/FrameView.cpp:
(WebCore::FrameView::reset):
- page/FrameView.h:
- 3:49 PM Changeset in webkit [169851] by
-
- 6 edits in trunk/Source/WebKit2
[iOS] Clear UIProcess visual state after WebProcess crash
https://bugs.webkit.org/show_bug.cgi?id=133664
<rdar://problem/16952742>
Reviewed by Benjamin Poulain.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didRelaunchProcess]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::didRelaunchProcess):
- UIProcess/mac/RemoteLayerTreeHost.h:
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::~RemoteLayerTreeHost):
(WebKit::RemoteLayerTreeHost::clearLayers):
- 3:47 PM Changeset in webkit [169850] by
-
- 2 edits in trunk/Source/WebKit2
Implement swipeWithEvent for non-fluid swipes
https://bugs.webkit.org/show_bug.cgi?id=133766
<rdar://problem/17126889>
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.mm:
(-[WKView swipeWithEvent:]):
On non-fluid swipes, go back or forward depending on the swipe direction.
- 3:41 PM Changeset in webkit [169849] by
-
- 3 edits3 adds in trunk
WindowFeatures arguments shoud ignore invalid characters in values
<http://webkit.org/b/133703>
<rdar://problem/17254118>
Reviewed by Andy Estes.
Source/WebCore:
Test: fast/dom/Window/window-property-invalid-characters-ignored.html
- page/WindowFeatures.cpp:
(WebCore::WindowFeatures::WindowFeatures): Set |length| based on
|buffer|, not |features|. Switch to using a for loop. Switch
to unsigned types since we are working with positive offsets
into a String.
LayoutTests:
- fast/dom/Window/resources/window-property-invalid-characters-ignored.html: Added.
- fast/dom/Window/window-property-invalid-characters-ignored-expected.txt: Added.
- fast/dom/Window/window-property-invalid-characters-ignored.html: Added.
- 3:40 PM Changeset in webkit [169848] by
-
- 3 edits2 adds in trunk
Viewport arguments should ignore invalid characters in values
<http://webkit.org/b/133555>
<rdar://problem/17179650>
Reviewed by Daniel Bates.
Source/WebCore:
Test: fast/viewport/viewport-warnings-7.html
- dom/Document.cpp:
(WebCore::Document::processArguments): Set |length| based on
|buffer|, not |features|. Switch to using a for loop. Switch
to unsigned types since we are working with positive offsets
into a String.
LayoutTests:
- fast/viewport/viewport-warnings-7-expected.txt: Added.
- fast/viewport/viewport-warnings-7.html: Added.
- 3:34 PM Changeset in webkit [169847] by
-
- 3 edits in trunk/Source/WebCore
Move some HTTP header field accessors to ResourceRequestBase.cpp
https://bugs.webkit.org/show_bug.cgi?id=133773
Reviewed by Andreas Kling.
This will avoid having to include HTTPHeaderNames.h from ResourceRequestBase.h.
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::httpContentType):
(WebCore::ResourceRequestBase::setHTTPContentType):
(WebCore::ResourceRequestBase::httpReferrer):
(WebCore::ResourceRequestBase::setHTTPReferrer):
(WebCore::ResourceRequestBase::httpOrigin):
(WebCore::ResourceRequestBase::setHTTPOrigin):
(WebCore::ResourceRequestBase::httpUserAgent):
(WebCore::ResourceRequestBase::setHTTPUserAgent):
(WebCore::ResourceRequestBase::httpAccept):
(WebCore::ResourceRequestBase::setHTTPAccept):
- platform/network/ResourceRequestBase.h:
(WebCore::ResourceRequestBase::httpContentType): Deleted.
(WebCore::ResourceRequestBase::setHTTPContentType): Deleted.
(WebCore::ResourceRequestBase::httpReferrer): Deleted.
(WebCore::ResourceRequestBase::setHTTPReferrer): Deleted.
(WebCore::ResourceRequestBase::httpOrigin): Deleted.
(WebCore::ResourceRequestBase::setHTTPOrigin): Deleted.
(WebCore::ResourceRequestBase::httpUserAgent): Deleted.
(WebCore::ResourceRequestBase::setHTTPUserAgent): Deleted.
(WebCore::ResourceRequestBase::httpAccept): Deleted.
(WebCore::ResourceRequestBase::setHTTPAccept): Deleted.
- 3:31 PM Changeset in webkit [169846] by
-
- 3 edits in trunk/Source/WebKit2
[Cocoa] Xcode cannot infer that the WebKit target implicitly depends on WebCore.framework
https://bugs.webkit.org/show_bug.cgi?id=133765
Reviewed by Anders Carlsson.
- Configurations/WebKit.xcconfig: Move linking against WebCore from OTHER_LDFLAGS here...
- WebKit2.xcodeproj/project.pbxproj: ...to the Link Binary With Libraries build phase here.
- 3:08 PM Changeset in webkit [169845] by
-
- 7 edits in trunk/Tools
WTR cleanup: push per-test viewport configuration into TestController, where platforms can customize it
https://bugs.webkit.org/show_bug.cgi?id=133770
Reviewed by Anders Carlsson.
Push the per-test view configuration up to TestController, so that platforms
can modify the behavior. This also allows platform-specific changes (e.g.
for threaded scrolling) to made without #ifefs.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::updateWebViewSizeForTest):
(WTR::TestController::updateWindowScaleForTest):
(WTR::shouldUseFixedLayout):
(WTR::TestController::updateLayoutTypeForTest):
(WTR::TestController::platformConfigureViewForTest):
(WTR::TestController::configureViewForTest):
- WebKitTestRunner/TestController.h:
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
(WTR::sizeWebViewForCurrentTest): Deleted.
(WTR::changeWindowScaleIfNeeded): Deleted.
(WTR::shouldUseThreadedScrolling): Deleted.
(WTR::updateThreadedScrollingForCurrentTest): Deleted.
(WTR::shouldUseFixedLayout): Deleted.
(WTR::updateLayoutType): Deleted.
- WebKitTestRunner/TestInvocation.h:
(WTR::TestInvocation::pathOrURL):
- WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::shouldMakeViewportFlexible):
(WTR::TestController::platformConfigureViewForTest):
- WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::shouldUseThreadedScrolling):
(WTR::TestController::platformConfigureViewForTest):
- 3:01 PM Changeset in webkit [169844] by
-
- 4 edits in trunk/Source/WebCore
Remove some more unneeded member functions from HTTPHeaderMap
https://bugs.webkit.org/show_bug.cgi?id=133768
Reviewed by Simon Fraser.
- loader/CrossOriginAccessControl.cpp:
(WebCore::createAccessControlPreflightRequest):
- platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::find): Deleted.
(WebCore::HTTPHeaderMap::keys): Deleted.
- platform/network/HTTPHeaderMap.h:
- 2:57 PM Changeset in webkit [169843] by
-
- 2 edits in trunk/Source/WebCore
Unreviwed Mac release build fix; mark the keyPath parameter as unused.
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(-[WebAVSampleBufferErrorListener observeValueForKeyPath:ofObject:change:context:]):
- 2:49 PM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 2:43 PM Changeset in webkit [169842] by
-
- 2 edits in trunk/Source/WebCore
[Win] Avoid deadlock with AVFoundation
https://bugs.webkit.org/show_bug.cgi?id=133762
<rdar://problem/17128248>
Reviewed by Eric Carlson.
Always invoke our notifications asynchronously so that we do not
execute long-running code while holding the AVFWrapper map mutex
lock. AVFoundationCF callbacks can deadlock if we call into AVF
while holding this lock.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification):
- 2:42 PM Changeset in webkit [169841] by
-
- 2 edits in trunk/Source/WebCore
[CMake] One more URTBF after r169826.
- CMakeLists.txt: Generate files to the proper place.
- 2:38 PM Changeset in webkit [169840] by
-
- 2 edits in trunk/Tools
[EFL] Add dependencies packages to efl install-dependencies file
https://bugs.webkit.org/show_bug.cgi?id=133720
Reviewed by Csaba Osztrogonác.
After r169785, EFL port starts to use efl 1.9 ver. EFL port needs to
install doxygen and libssl-dev because efl 1.9 depends on those libraries.
- efl/install-dependencies:
- 2:33 PM Changeset in webkit [169839] by
-
- 2 edits in trunk/Source/WebCore
[CMake]URTBF after r169826.
- CMakeLists.txt: Typo fix.
- 2:32 PM Changeset in webkit [169838] by
-
- 11 edits in tags/Safari-538.39.41/Source/WebCore
Merge r169830.
- 2:29 PM Changeset in webkit [169837] by
-
- 2 edits in trunk/Tools
Unreviewed. Moving myself to the list of reviewers.
- Scripts/webkitpy/common/config/contributors.json:
- 2:28 PM Changeset in webkit [169836] by
-
- 4 edits in trunk/Source/WebCore
Get rid of an unneeded HTTPHeaderMap::remove overload
https://bugs.webkit.org/show_bug.cgi?id=133763
Reviewed by Andreas Kling.
Change HTTPHeaderMap::remove to return whether an entry was removed or not and simplify
ResourceRequestBase::clearHTTPAuthorization.
- platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::remove):
- platform/network/HTTPHeaderMap.h:
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::clearHTTPAuthorization):
- 2:28 PM Changeset in webkit [169835] by
-
- 3 edits in tags/Safari-538.39.41/WebKitLibraries
Update WKSI for <rdar://problem/17009091>.
Rubber stamped by Eric Carlson.
- libWebKitSystemInterfaceMavericks.a:
- libWebKitSystemInterfaceMountainLion.a:
- 2:28 PM Changeset in webkit [169834] by
-
- 2 edits in trunk/Source/JavaScriptCore
[EFL] URTBF after r169823.
- bindings/ScriptValue.cpp: Missing include added.
- 2:21 PM Changeset in webkit [169833] by
-
- 1 copy in tags/Safari-538.39.41
Tagging.
- 2:11 PM Changeset in webkit [169832] by
-
- 2 edits9 adds in trunk/LayoutTests
[iOS] Enable fast/viewport tests
<http://webkit.org/b/133754>
Reviewed by Andy Estes.
- platform/ios-sim/Skipped:
- Stop skipping fast/viewport tests.
- platform/ios-sim/fast/viewport/viewport-legacy-handheldfriendly-expected.txt: Added.
- platform/ios-sim/fast/viewport/viewport-legacy-mobileoptimized-2-expected.txt: Added.
- platform/ios-sim/fast/viewport/viewport-legacy-mobileoptimized-3-expected.txt: Added.
- platform/ios-sim/fast/viewport/viewport-legacy-mobileoptimized-expected.txt: Added.
- platform/ios-sim/fast/viewport/viewport-legacy-ordering-5-expected.txt: Added.
- platform/ios-sim/fast/viewport/viewport-legacy-ordering-6-expected.txt: Added.
- platform/ios-sim/fast/viewport/viewport-legacy-xhtmlmp-expected.txt: Added.
- platform/ios-sim/fast/viewport/viewport-legacy-xhtmlmp-remove-and-add-expected.txt: Added.
- iOS never supported these "legacy" viewport modes, so add platform-specific results with current behavior.
- 2:04 PM Changeset in webkit [169831] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove an unnecessary asObject(this) call inside JSObject::fastGetOwnPropertySlot.
Rubber-stamped by Andreas Kling.
- runtime/JSObject.h:
(JSC::JSObject::fastGetOwnPropertySlot):
- 2:02 PM Changeset in webkit [169830] by
-
- 11 edits in trunk/Source/WebCore
[EME][Mac] Propagate errors from AVSampleBufferDisplayLayer through to MSE
https://bugs.webkit.org/show_bug.cgi?id=133747
Reviewed by Eric Carlson.
Abstract out the delivery of errors in MediaKeySession into its own method, which can be triggered by
CDMSession objects through the CDMSessionClient interface:
- Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::keyRequestTimerFired):
(WebCore::MediaKeySession::addKeyTimerFired):
(WebCore::MediaKeySession::sendMessage):
(WebCore::MediaKeySession::sendError):
- Modules/encryptedmedia/MediaKeySession.h:
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveRenderingError):
- Modules/mediasource/SourceBuffer.h:
- platform/graphics/SourceBufferPrivateClient.h:
- platform/graphics/CDMSession.h:
Add an Objective-C object which can listen for error KVO notifications:
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
(WebCore::SourceBufferPrivateAVFObjCErrorClient::~SourceBufferPrivateAVFObjCErrorClient):
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(-[WebAVSampleBufferErrorListener initWithParent:WebCore::]):
(-[WebAVSampleBufferErrorListener dealloc]):
(-[WebAVSampleBufferErrorListener invalidate]):
(-[WebAVSampleBufferErrorListener beginObservingLayer:]):
(-[WebAVSampleBufferErrorListener stopObservingLayer:]):
(-[WebAVSampleBufferErrorListener beginObservingRenderer:]):
(-[WebAVSampleBufferErrorListener stopObservingRenderer:]):
(-[WebAVSampleBufferErrorListener observeValueForKeyPath:ofObject:change:context:]):
(-[WebAVSampleBufferErrorListener layerFailedToDecode:]):
(WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):
(WebCore::SourceBufferPrivateAVFObjC::registerForErrorNotifications):
(WebCore::SourceBufferPrivateAVFObjC::unregisterForErrorNotifications):
(WebCore::SourceBufferPrivateAVFObjC::layerDidReceiveError):
(WebCore::SourceBufferPrivateAVFObjC::rendererDidReceiveError):
Register for the new error notifications:
- platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
(WebCore::CDMSessionMediaSourceAVFObjC::~CDMSessionMediaSourceAVFObjC): Moved to source file.
- platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
(WebCore::CDMSessionMediaSourceAVFObjC::CDMSessionMediaSourceAVFObjC): Register for error notifications.
(WebCore::CDMSessionMediaSourceAVFObjC::~CDMSessionMediaSourceAVFObjC): Unregister for error notifications.
(WebCore::CDMSessionMediaSourceAVFObjC::layerDidReceiveError): Pass through to CDMSessionClient.
(WebCore::CDMSessionMediaSourceAVFObjC::rendererDidReceiveError): Ditto.
- 1:49 PM Changeset in webkit [169829] by
-
- 2 edits in trunk/Source/WebCore
Don't force CharacterData to override getOwnPropertySlot.
<https://webkit.org/b/133717>
This was preventing us from taking the GetByVal fast path for Text nodes
since they inherit from CharacterData and having a "length" attribute
meant we gave them a custom getOwnPropertySlot, despite not actually
needing it for anything.
Reviewed by Anders Carlsson.
- bindings/scripts/CodeGeneratorJS.pm:
(AttributeShouldBeOnInstance):
- 1:46 PM Changeset in webkit [169828] by
-
- 2 edits in trunk/LayoutTests
inspector-protocol/debugger/breakpoint-action-detach.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=133761
- TestExpectations: Skipped it. Updated bug number for another inspector-protocol
test while at it.
- 1:43 PM Changeset in webkit [169827] by
-
- 3 edits in trunk/Source/WebKit2
[wk2] Don't dispatch view state changes immediately
https://bugs.webkit.org/show_bug.cgi?id=133713
Reviewed by Simon Fraser.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::viewStateDidChange):
(WebKit::WebPageProxy::dispatchViewStateChange):
(WebKit::WebPageProxy::updateViewState): Deleted.
- UIProcess/WebPageProxy.h:
On PLATFORM(COCOA), wait until just before CA is going to commit the UI process layer
tree to dispatch view state changes to the Web process. This avoids sending multiple
view state change messages to the Web process within one run-loop cycle, for example
when a view is moved around in the view hierarchy but the view state otherwise remains the same.
- 1:42 PM Changeset in webkit [169826] by
-
- 5 edits2 adds in trunk/Source/WebCore
Add a script that generates a gperf hash for HTTP header names
https://bugs.webkit.org/show_bug.cgi?id=133760
Reviewed by Andreas Kling.
This is the first step towards getting rid of AtomicString from HTTPHeaderMap.
- CMakeLists.txt:
- DerivedSources.make:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/network/HTTPHeaderNames.in: Added.
- platform/network/create-http-header-name-table: Added.
(HTTPHeaderName):
- 1:37 PM Changeset in webkit [169825] by
-
- 3 edits in trunk/Source/WebKit2
Make it possible for waitForAndDispatchImmediately to bail if a sync message comes in from the other direction
https://bugs.webkit.org/show_bug.cgi?id=133708
Reviewed by Anders Carlsson.
- Platform/IPC/Connection.cpp:
(IPC::WaitForMessageState):
(IPC::Connection::Connection):
(IPC::Connection::waitForMessage):
(IPC::Connection::processIncomingMessage):
(IPC::Connection::connectionDidClose):
- Platform/IPC/Connection.h:
(IPC::Connection::waitForAndDispatchImmediately):
Remove the waitForMessageMap, and assert that we're only ever waiting for one message at a time.
This simplifies this code a bit, and we never wait on more than one message at a time, so it was unnecessary.
Add a flag to waitForAndDispatchImmediately, InterruptWaitingIfSyncMessageArrives, which will cause
waitForAndDispatchImmediately to bail if a sync message arrives, to avoid pointlessly blocking both processes
for the entire timeout.
- 1:21 PM Changeset in webkit [169824] by
-
- 6 edits in trunk/Source
Turning on DUMP_PROPERTYMAP_STATS causes a build failure
https://bugs.webkit.org/show_bug.cgi?id=133673
Reviewed by Andreas Kling.
Source/JavaScriptCore:
Rewrote the property map statistics code because the old code wasn't building,
and it was also mixing numbers for lookups and insertions/removals.
New logging code records the number of calls to PropertyTable::find (finds) and
PropertyTable::get/PropertyTable::findWithString separately so that we can quantify
the number of probing during updates and lookups.
- jsc.cpp:
- runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::find):
(JSC::PropertyTable::get):
(JSC::PropertyTable::findWithString):
(JSC::PropertyTable::add):
(JSC::PropertyTable::remove):
(JSC::PropertyTable::reinsert):
(JSC::PropertyTable::rehash):
- runtime/Structure.cpp:
(JSC::PropertyMapStatisticsExitLogger::PropertyMapStatisticsExitLogger):
(JSC::PropertyMapStatisticsExitLogger::~PropertyMapStatisticsExitLogger):
Source/WTF:
Added DEFINE_GLOBAL_FOR_LOGGING to allow running a destructor in logging code
that needs to be enabled in release builds (e.g. for JavaScriptCore).
- wtf/StdLibExtras.h:
- 1:16 PM Changeset in webkit [169823] by
-
- 5 edits in trunk/Source/JavaScriptCore
Always inline JSValue::get() and Structure::get().
<https://webkit.org/b/133755>
Reviewed by Ryosuke Niwa.
These functions get really hot, so ask the compiler to be more
aggressive about inlining them.
~28% speed-up on Ryosuke's microbenchmark for accessing nextSibling
through GetByVal.
- runtime/JSArrayIterator.cpp:
- runtime/JSCJSValue.cpp:
- runtime/JSCJSValueInlines.h:
(JSC::JSValue::get):
- runtime/JSPromiseDeferred.cpp:
- runtime/StructureInlines.h:
(JSC::Structure::get):
- 1:15 PM Changeset in webkit [169822] by
-
- 2 edits in trunk/Source/JavaScriptCore
Structure::get should instantiate DeferGC only when materializing property map
https://bugs.webkit.org/show_bug.cgi?id=133727
Rubber-stamped by Andreas Kling.
Make materializePropertyMapIfNecessary always inline.
This is ~12% improvement on the microbenchmark attached in the bug.
- runtime/Structure.h:
(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::materializePropertyMapIfNecessaryForPinning):
- 1:13 PM Changeset in webkit [169821] by
-
- 2 edits in trunk/Source/WebKit2
Restrict database process profile
https://bugs.webkit.org/show_bug.cgi?id=133750
Reviewed by Alexey Proskuryakov.
Make the sandbox profile much more restrictive.
- Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb:
- 12:59 PM Changeset in webkit [169820] by
-
- 5 edits in trunk/Source/WebKit2
Don't snapshot offscreen plugins that would normally be considered primary plugins after they are moved in view.
https://bugs.webkit.org/show_bug.cgi?id=133667.
<rdar://problem/16743250>
Reviewed by Tim Horton.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::PluginView):
(WebKit::PluginView::pluginSnapshotTimerFired):
Set the display state to Playing if the following is true:
The plugin in question is large enough to be considered the primary snapshot and either:
a) The maximum number of snapshot retries has been reached and no good snapshot has been found.
b) The plugin is moved to be on-screen while the snapshot attempts are in progress.
- WebProcess/Plugins/PluginView.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::plugInIntersectsSearchRect): Re-factor out intersection logic.
(WebKit::WebPage::plugInIsPrimarySize): Re-factor out primary plugin size logic.
(WebKit::WebPage::determinePrimarySnapshottedPlugIn): Use the above two methods here.
- WebProcess/WebPage/WebPage.h:
- 12:55 PM Changeset in webkit [169819] by
-
- 2 edits in branches/ftlopt/Source/JavaScriptCore
Ensured Native Calls and Construct and associated checks
are only emitted during ftl mode.
https://bugs.webkit.org/show_bug.cgi?id=133718
Patch by Matthew Mirman <mmirman@apple.com> on 2014-06-11
Reviewed by Filip Pizlo.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall): Added check for ftl mode
before attaching the native function to Call or Construct.
- 12:49 PM Changeset in webkit [169818] by
-
- 7 edits in trunk/Source/WebKit2
Move more WKPreferences to WKWebViewConfiguration
https://bugs.webkit.org/show_bug.cgi?id=133756
<rdar://problem/17271468>
Reviewed by Tim Horton.
- UIProcess/API/Cocoa/WKPreferences.h:
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences setMinimumFontSize:]):
(-[WKPreferences suppressesIncrementalRendering]): Deleted.
(-[WKPreferences setSuppressesIncrementalRendering:]): Deleted.
(-[WKPreferences allowsInlineMediaPlayback]): Deleted.
(-[WKPreferences setAllowsInlineMediaPlayback:]): Deleted.
(-[WKPreferences mediaPlaybackRequiresUserAction]): Deleted.
(-[WKPreferences setMediaPlaybackRequiresUserAction:]): Deleted.
(-[WKPreferences mediaPlaybackAllowsAirPlay]): Deleted.
(-[WKPreferences setMediaPlaybackAllowsAirPlay:]): Deleted.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
- UIProcess/API/Cocoa/WKWebViewConfiguration.h:
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration copyWithZone:]):
- WebKit2.xcodeproj/project.pbxproj:
- 12:31 PM Changeset in webkit [169817] by
-
- 3 edits in trunk/WebKitLibraries
Update WKSI for <rdar://problem/17009091>.
Rubber stamped by Eric Carlson.
- libWebKitSystemInterfaceMavericks.a:
- libWebKitSystemInterfaceMountainLion.a:
- 12:29 PM Changeset in webkit [169816] by
-
- 5 edits in trunk/Source/JavaScriptCore
Structure::get should instantiate DeferGC only when materializing property map
https://bugs.webkit.org/show_bug.cgi?id=133727
Reviewed by Geoffrey Garen.
DeferGC instances in Structure::get was added in http://trac.webkit.org/r157539 in order to avoid
collecting the property table newly created by materializePropertyMapIfNecessary since GC can happen
when GCSafeConcurrentJITLocker goes out of scope.
However, always instantiating DeferGC inside Structure::get introduced a new performance bottleneck
in JSObject::getPropertySlot because frequently incrementing and decrementing a counter in vm.m_heap
and running a release assertion inside Heap::incrementDeferralDepth() is expensive.
Work around this by instantiating DeferGC only when we're actually calling materializePropertyMap,
and immediately storing a pointer to the newly created property table in the stack before DeferGC
goes out of scope so that the property table will be marked.
This shows 13-16% improvement on the microbenchmark attached in the bug.
- runtime/JSCJSValue.cpp:
- runtime/JSObject.h:
(JSC::JSObject::fastGetOwnPropertySlot):
- runtime/Structure.h:
(JSC::Structure::materializePropertyMapIfNecessary):
- runtime/StructureInlines.h:
(JSC::Structure::get):
- 11:40 AM Changeset in webkit [169815] by
-
- 3 edits in trunk/Source/JavaScriptCore
Some JSValue::get() micro-optimzations.
<https://webkit.org/b/133739>
Tighten some of the property lookup code to improve performance of the
eagerly reified prototype attributes:
- Instead of converting the property name to an integer at every step in the prototype chain, move that to a separate pass at the end since it should be a rare case.
- Cache the StructureIDTable in a local instead of fetching it from the Heap on every step.
- Make fillCustomGetterPropertySlot inline. It was out-of-lined based on the assumption that clients would mostly be cacheable GetByIds, and it gets pretty hot (~1%) in GetByVal.
- Pass the Structure directly to fillCustomGetterPropertySlot instead of refetching it from the StructureIDTable.
Reviewed by Geoff Garen.
- runtime/JSObject.cpp:
(JSC::JSObject::fillCustomGetterPropertySlot): Deleted.
- runtime/JSObject.h:
(JSC::JSObject::inlineGetOwnPropertySlot):
(JSC::JSObject::fillCustomGetterPropertySlot):
(JSC::JSObject::getOwnPropertySlot):
(JSC::JSObject::fastGetOwnPropertySlot):
(JSC::JSObject::getPropertySlot):
(JSC::JSObject::getOwnPropertySlotSlow): Deleted.
- 11:36 AM Changeset in webkit [169814] by
-
- 3 edits in trunk/Source/WebCore
ROLLOUT: r153510: Broke Table borders on Wikipedia
https://bugs.webkit.org/show_bug.cgi?id=132802
<rdar://problem/16792562>
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintCollapsedBorders):
(WebCore::RenderTableCell::alignLeftRightBorderPaintRect): Deleted.
(WebCore::RenderTableCell::alignTopBottomBorderPaintRect): Deleted.
- rendering/RenderTableCell.h:
- 11:06 AM Changeset in webkit [169813] by
-
- 2 edits in trunk/Source/WebKit2
WebKit2 iOS: Unable to open UI menu for "open in new tab" for links on yahoo.com.
https://bugs.webkit.org/show_bug.cgi?id=133749
<rdar://problem/17165992>
Reviewed by Brady Eidson.
The URL returned to the UIProcess as string needs to be encoded.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation):
- 10:44 AM Changeset in webkit [169812] by
-
- 7 edits in trunk/Source/WebKit2
Move suppressesIncrementalRendering to WKWebViewConfiguration
https://bugs.webkit.org/show_bug.cgi?id=133707
<rdar://problem/17271468>
Reviewed by Sam Weinig.
- UIProcess/API/Cocoa/WKPreferences.h:
Get rid of suppressesIncrementalRendering.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
Set the suppressesIncrementalRenderingKey key in webPageConfiguration.preferenceValues.
- UIProcess/API/Cocoa/WKWebViewConfiguration.h:
Add suppressesIncrementalRendering.
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration copyWithZone:]):
Assign suppressesIncrementalRendering.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
Copy webPageConfiguration.preferenceValues to m_configurationPreferenceValues.
(WebKit::WebPageProxy::preferencesStore):
If m_configurationPreferenceValues is empty, just return m_preferences->store(). Otherwise,
copy the store and apply the configuration preference values.
(WebKit::WebPageProxy::preferencesDidChange):
Call preferencesStore() so we'll get the configuration preference values as well.
(WebKit::WebPageProxy::creationParameters):
Ditto.
- UIProcess/WebPageProxy.h:
- 10:27 AM Changeset in webkit [169811] by
-
- 6 edits in trunk/Source/WebCore
[Curl] Empty headers in request response.
https://bugs.webkit.org/show_bug.cgi?id=133483
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-06-11
Reviewed by Brent Fulgham.
When a request is taken from the cache, its cached response headers are empty, if the cache entry was created in the same session.
It is only when the cache entry is loaded from disc, that the response headers are properly set.
We need to set the cached response headers in both cases.
There is also an issue if two jobs are loading the same url at the same time.
Both jobs will then write to the cache content file, and create invalid content.
This can be fixed by only letting the first request write to the content file.
- platform/network/curl/CurlCacheEntry.cpp:
(WebCore::CurlCacheEntry::CurlCacheEntry):
(WebCore::CurlCacheEntry::isLoading): Added method to check if cache entry is loading the content.
(WebCore::CurlCacheEntry::saveResponseHeaders): Set the cached response headers when response is saved.
(WebCore::CurlCacheEntry::invalidate): To be on the safe side, close content file when entry is invalidated.
(WebCore::CurlCacheEntry::parseResponseHeaders): Made parameter const.
- platform/network/curl/CurlCacheEntry.h: Keep track of which job is creating this cache entry.
(WebCore::CurlCacheEntry::getJob):
- platform/network/curl/CurlCacheManager.cpp:
(WebCore::CurlCacheManager::loadIndex): When cache entry is loaded from disc, there is no associated job.
(WebCore::CurlCacheManager::didReceiveResponse): Bail out if cache entry is already currently loading,
otherwise associate this job with the new cache entry.
(WebCore::CurlCacheManager::didFinishLoading): Changed parameter type.
(WebCore::CurlCacheManager::isCached): Don't report the url as cached if it's currently loading content.
(WebCore::CurlCacheManager::didReceiveData): Don't write to the content file if the entry is not associated with the job.
(WebCore::CurlCacheManager::didFail): Changed parameter type.
- platform/network/curl/CurlCacheManager.h: Changed parameter type.
- platform/network/curl/ResourceHandleManager.cpp: Ditto.
(WebCore::writeCallback):
(WebCore::ResourceHandleManager::downloadTimerCallback):
- 10:03 AM Changeset in webkit [169810] by
-
- 19 edits in trunk/Source/WebCore
REGRESSION (r133705): Layout Test js/dom/webidl-type-mapping.html is failing
https://bugs.webkit.org/show_bug.cgi?id=133736
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
Turns out we can't remove the HashTable yet after all, as JavaScriptCore
relies on hasSetterOrReadonlyProperties bit to make put work correctly. We
can, however, skip creating the table, and just use the value array during
reification.
- 9:12 AM Changeset in webkit [169809] by
-
- 2 edits in trunk/Source/WebCore
AX: iOS: VoiceOver ignores input type = date in Safari on iOS7
https://bugs.webkit.org/show_bug.cgi?id=133709
Reviewed by Mario Sanchez Prada.
The date field on iOS appears as a popup button, which is not a type we had encountered for <input> types.
This returns an appropriate role in that case.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- 8:37 AM Changeset in webkit [169808] by
-
- 2 edits in trunk/Tools
[EFL] Drop to maintain EFL 32bit release bot
https://bugs.webkit.org/show_bug.cgi?id=133710
Reviewed by Csaba Osztrogonác.
- BuildSlaveSupport/build.webkit.org-config/config.json: Removed EFL 32bit bot.
- 8:36 AM Changeset in webkit [169807] by
-
- 4 edits2 adds in trunk/Source/WebKit2
Wrap NSURLRequest in bundle API
https://bugs.webkit.org/show_bug.cgi?id=133732
<rdar://problem/17267217>
Reviewed by Andreas Kling.
Patch by Dan Bernstein.
We don't want to construct actual NSURLRequests in the web process side unless really needed as it is slow.
- Shared/Cocoa/APIObject.mm:
(API::Object::newObject):
- Shared/Cocoa/WKNSURLRequest.h: Added.
(WebKit::wrapper):
- Shared/Cocoa/WKNSURLRequest.mm: Added.
Add a wrapper object that initializes the underlying NSURLRequest on-demand.
(-[WKNSURLRequest _web_createTarget]):
(-[WKNSURLRequest URL]):
(-[WKNSURLRequest copyWithZone:]):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(willSendRequestForFrame):
(didInitiateLoadForResource):
- 7:42 AM Changeset in webkit [169806] by
-
- 1 edit1 add2 deletes in trunk/LayoutTests
[GTK] Unreviewed GTK gardening
Add missing GTK expectations file after test added at r169390, and removed specific
ones for tests now passing with default ones after r169403.
Patch by Lorenzo Tilve <ltilve@igalia.com> on 2014-06-11
- platform/gtk/fast/dom/webtiming-document-open-expected.txt: Removed.
- platform/gtk/fast/dom/webtiming-navigate-within-document-expected.txt: Removed.
- platform/gtk/fast/multicol/pagination/nested-transforms-expected.txt: Added.
- 7:30 AM Changeset in webkit [169805] by
-
- 10 edits in trunk/Source/WebKit2
<rdar://problem/17218629> [Cocoa] WKWebView’s canGoBack and canGoForward properties are not KVO-compliant
https://bugs.webkit.org/show_bug.cgi?id=133722
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/WKBrowsingContextController.mm: Added no-op overrides of new
PageLoadStateObserver member functions.
- UIProcess/API/Cocoa/WKWebView.h: Documented the canGoBack and canGoForward properties as
being KVO-compliant.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView canGoBack]): Changed to get the return value from the page load state.
(-[WKWebView canGoForward]): Ditto.
- UIProcess/Cocoa/NavigationState.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::willChangeCanGoBack): Override this new PageLoadStateObserver
member function by sending the appropriate KVO change message to the WKWebView.
(WebKit::NavigationState::didChangeCanGoBack): Ditto.
(WebKit::NavigationState::willChangeCanGoForward): Ditto.
(WebKit::NavigationState::didChangeCanGoForward): Ditto.
- UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::commitChanges): Check for changes to canGoBack and canGoForward
and call the observers if needed.
(WebKit::PageLoadState::canGoBack): Added. Returns the value from the committed state.
(WebKit::PageLoadState::setCanGoBack): Added. Sets the value in the uncommitted state.
(WebKit::PageLoadState::canGoForward): Added. Returns the value from the committed state.
(WebKit::PageLoadState::setCanGoForward): Added. Sets the value in the uncommitted state.
- UIProcess/PageLoadState.h:
(WebKit::PageLoadState::Data::Data): Added canGoBack and canGoForward boolean members.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChangeBackForwardList): Update the page load state with the new
state of canGoBack and canGoForward.
- UIProcess/WebPageProxy.h: Removed unused member variables m_canGoBack and m_canGoForward.
- 5:50 AM Changeset in webkit [169804] by
-
- 2 edits in trunk/LayoutTests
[EFL] Updated expectations for accessibility/lists.html test
https://bugs.webkit.org/show_bug.cgi?id=132818
Patch by Rohit Kumar <kumar.rohit@samsung.com> on 2014-06-11
Reviewed by Mario Sanchez Prada.
- platform/efl-wk1/accessibility/lists-expected.txt:
- 5:22 AM Changeset in webkit [169803] by
-
- 3 edits in trunk/Source/WebKit2
Avoid Vector copies in WebNotificationManagerProxy::providerDidCloseNotifications(), FindController::findStringMatches()
https://bugs.webkit.org/show_bug.cgi?id=133676
Reviewed by Andreas Kling.
- UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::providerDidCloseNotifications): Move the newly-created
Vector object into the HashMap<>::add() call.
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::findStringMatches): Movethe newly-create Vector object into the
Vector<>::append() call.
- 5:20 AM Changeset in webkit [169802] by
-
- 2 edits in trunk/Source/WebCore
Avoid FontGlyphsCacheKey copy in FontGlyphsCacheEntry constructor
https://bugs.webkit.org/show_bug.cgi?id=133674
Reviewed by Andreas Kling.
- platform/graphics/Font.cpp:
(WebCore::FontGlyphsCacheEntry::FontGlyphsCacheEntry): The FontGlyphsCacheKey
variable is already passed-in as an rvalue reference, so it should be moved
into the constructor of the corresponding member variable instead of copied.
- 4:56 AM Changeset in webkit [169801] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][WK2] Add missing test cases for EWK2ViewTest.
https://bugs.webkit.org/show_bug.cgi?id=133715
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-06-11
Reviewed by Gyuyoung Kim.
Add missing test cases for ewk_view.h APIs, ewk_view_stop(), ewk_view_html_string_load(), ewk_view_theme_get(),
ewk_view_feed_touch_event(), ewk_view_text_find_highlight_clear(), ewk_view_text_find(), ewk_view_text_matches_count(),
ewk_view_page_contents_get(), ewk_view_script_execute().
- PlatformEfl.cmake:
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
- 3:46 AM Changeset in webkit [169800] by
-
- 2 edits in trunk/Source/WebCore
Fix the build after after r169789 on platforms that build with -Wunused-const-variable
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHashTable): Don't create the value array if it'll never be used.
- 12:38 AM Changeset in webkit [169799] by
-
- 15 edits1 add in trunk
[GTK] Use a different user agent string depending on the site
https://bugs.webkit.org/show_bug.cgi?id=132681
Reviewed by Anders Carlsson.
Source/WebCore:
We have changed the user agent string several times to try to fix
broken websites that require specific things in the UA string to
properly work. But everytime we change the UA string to fix a
website we break others. We could use different UA string
depending on the website. UserAgentGtk code has also been cleaned
up, using NeverDestroyed instead of DEPRECATED_DEFINE_STATIC_LOCAL
and avoiding unneeded conversions to UTF-8.
- platform/gtk/UserAgentGtk.cpp:
(WebCore::UserAgentQuirks::UserAgentQuirks): New helper private
class to handle user agent quirks.
(WebCore::UserAgentQuirks::add):
(WebCore::UserAgentQuirks::contains):
(WebCore::UserAgentQuirks::isEmpty):
(WebCore::platformForUAString): Bring back this method that was
removed to always pretend to be Macintosh.
(WebCore::platformVersionForUAString): Return a different platform
version depending on the actual platform.
(WebCore::versionForUAString): Return the WebKit version.
(WebCore::buildUserAgentString): Helper function to build the user
agent taking into account the UserAgentQuirks received.
(WebCore::standardUserAgentStatic): Standard user agent string
when no quirks are present.
(WebCore::standardUserAgent):
(WebCore::standardUserAgentForURL): New method that returns the
user agent string for the given URL.
- platform/gtk/UserAgentGtk.h:
Source/WebKit2:
- UIProcess/API/gtk/WebKitSettings.cpp:
(webkit_settings_class_init): Enable site specific quirks setting
by default.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::userAgent): Pass the given URL to WebPage.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::userAgent): Try to get the user agent for the
URL received falling back to the current one otherwise.
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::platformUserAgent): Added.
- WebProcess/WebPage/efl/WebPageEfl.cpp:
(WebKit::WebPage::platformUserAgent): Return null String.
- WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformUserAgent): Use WebCore::standardUserAgentForURL() when site specific quirks
setting is enabled.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::platformUserAgent): Return null String.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformUserAgent): Return null String.
Tools:
Add a unit test to check user agent quirks.
- TestWebKitAPI/PlatformGTK.cmake:
- TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp: Added.
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
(testWebKitSettings): Site specific quirks setting is now enabled
by default.
- 12:13 AM Changeset in webkit [169798] by
-
- 2 edits in trunk
Unreviewed, EFL build fix. Treat literal-suffix error as build warning.
- Source/cmake/WebKitHelpers.cmake:
- 12:02 AM Changeset in webkit [169797] by
-
- 4 edits in trunk/Source
[Win] Unreviewed build fix.
Source/WebCore:
- platform/network/curl/ResourceRequest.h:
Include missing PassOwnPtr.h.
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Fixed 64-bit linker symbol.
