Context Navigation

← Previous Period
Next Period →

Timeline

Jun 14, 2014:

7:10 PM Changeset in webkit [169987] by mitz@apple.com

5 edits in trunk/Source/WebKit2

Replace StringImpl* callback parameters with const String&
https://bugs.webkit.org/show_bug.cgi?id=133922

Reviewed by Sam Weinig.

UIProcess/API/C/WKPage.cpp:

(toGenericCallbackFunction): Added this helper function to wrap a WKStringRef-returning
API callback in a generic const String&-returning callback.
(WKPageRenderTreeExternalRepresentation):
(WKPageGetSourceForFrame):
(WKPageGetContentsAsString):
(WKPageGetBytecodeProfile):
(WKPageValidateCommand):

UIProcess/API/mac/WKView.mm:

(-[WKView validateUserInterfaceItem:]):
(-[WKView startSpeaking:]):

UIProcess/WebPageProxy.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _define:]):
(-[WKContentView applyAutocorrection:toString:withCompletionHandler:]):

5:07 PM Changeset in webkit [169986] by mitz@apple.com

2 edits in trunk/Source/WebKit2

Additional iOS build fix.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _define:]):
(selectionChangedWithGesture):
(selectionChangedWithTouch):
(-[WKContentView changeSelectionWithGestureAt:withGesture:withState:]):
(-[WKContentView changeSelectionWithTouchAt:withSelectionTouch:baseIsStart:]):
(-[WKContentView changeSelectionWithTouchesFrom:to:withGesture:withState:]):
(-[WKContentView applyAutocorrection:toString:withCompletionHandler:]):

4:32 PM Changeset in webkit [169985] by mitz@apple.com

2 edits in trunk/Source/WebKit2

iOS build fix.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):

4:11 PM Changeset in webkit [169984] by mitz@apple.com

14 edits in trunk/Source/WebKit2

Get rid of GenericAPICallback
https://bugs.webkit.org/show_bug.cgi?id=133909

Reviewed by Sam Weinig.

In preparation for passing callbacks as functions, replace GenericAPICallback::create, which
returned a GenericCallback, with a function template that returns an appropriate callback
function.

UIProcess/API/C/WKApplicationCacheManager.cpp:

(WKApplicationCacheManagerGetApplicationCacheOrigins):

UIProcess/API/C/WKContext.cpp:

(WKContextGetStatistics):
(WKContextGetStatisticsWithOptions):

UIProcess/API/C/WKCookieManager.cpp:

(WKCookieManagerGetHostnamesWithCookies):
(WKCookieManagerGetHTTPCookieAcceptPolicy):

UIProcess/API/C/WKDatabaseManager.cpp:

(WKDatabaseManagerGetDatabasesByOrigin):
(WKDatabaseManagerGetDatabaseOrigins):

UIProcess/API/C/WKFrame.cpp:

(WKFrameGetMainResourceData):
(WKFrameGetResourceData):
(WKFrameGetWebArchive):

UIProcess/API/C/WKKeyValueStorageManager.cpp:

(WKKeyValueStorageManagerGetKeyValueStorageOrigins):
(WKKeyValueStorageManagerGetStorageDetailsByOrigin):

UIProcess/API/C/WKMediaCacheManager.cpp:

(WKMediaCacheManagerGetHostnamesWithMediaCache):

UIProcess/API/C/WKOriginDataManager.cpp:

(WKOriginDataManagerGetOrigins):

UIProcess/API/C/WKPage.cpp:

(WKPageRunJavaScriptInMainFrame):
(WKPageRenderTreeExternalRepresentation):
(WKPageGetSourceForFrame):
(WKPageGetContentsAsString):
(WKPageGetBytecodeProfile):
(WKPageGetSelectionAsWebArchiveData):
(WKPageGetContentsAsMHTMLData):
(WKPageDrawPagesToPDF):

UIProcess/API/C/WKPluginSiteDataManager.cpp:

(WKPluginSiteDataManagerGetSitesWithData):

UIProcess/API/C/WKResourceCacheManager.cpp:

(WKResourceCacheManagerGetCacheOrigins):

UIProcess/GenericCallback.h:

(WebKit::toGenericCallbackFunction): Added. Given a C SPI callback function, returns a generic
callback function that wraps it.

3:44 PM Changeset in webkit [169983] by mitz@apple.com

2 edits in trunk/Source/WebKit2

Reverted the last change, which broken the Mac build.

UIProcess/GenericCallback.h:

(WebKit::invalidateCallbackMap):

2:59 PM Changeset in webkit [169982] by mitz@apple.com

2 edits in trunk/Source/WebKit2

Tried to fix the GTK build.

UIProcess/GenericCallback.h:

(WebKit::invalidateCallbackMap):

2:35 PM Changeset in webkit [169981] by andersca@apple.com

2 edits in trunk/Source/WebCore

Simplify ResourceRequest constructors
https://bugs.webkit.org/show_bug.cgi?id=133911

Reviewed by Sam Weinig.

platform/network/cf/ResourceRequest.h:

(WebCore::ResourceRequest::ResourceRequest):

1:57 PM Changeset in webkit [169980] by benjamin@webkit.org

2 edits in trunk/Source/WebCore

Fix the ARM64 build

cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::addFlagsToElementStyleFromContext):

1:38 PM Changeset in webkit [169979] by weinig@apple.com

12 edits in trunk/Source

Store DOM constants directly in the JS object rather than jumping through a custom accessor
https://bugs.webkit.org/show_bug.cgi?id=133898

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

runtime/Lookup.h:

(JSC::HashTableValue::attributes):
Switch attributes to be stored as an unsigned rather than an unsigned char, since there is no difference in memory use
and will make adding more flags possibles.

(JSC::HashTableValue::propertyGetter):
(JSC::HashTableValue::propertyPutter):
Change assertion to use BuiltinOrFunctionOrConstant.

(JSC::HashTableValue::constantInteger):
Added.

(JSC::getStaticPropertySlot):
(JSC::getStaticValueSlot):
Use PropertySlot::setValue() for constants during static lookup.

(JSC::reifyStaticProperties):
Put the constant directly on the object when eagerly reifying.

runtime/PropertySlot.h:

Add ConstantInteger flag and BuiltinOrFunctionOrConstant helper.

Source/WebCore:
Instead of implementing constants as custom accessors that just happen to return a value,
we now store the constant directly in the HashTableValue array (where the GetValueFunc used
to be).

For the case where the constant is accessed via the static table (still in use for instances and some prototypes), the static lookup function will set the value on the property slot, instead of passing a function pointer.
For the case where the constant is eagerly reified (most prototypes and all constructors) the constant is put directly in the object.

In micro benchmarks this looks to be around a 4x speedup on the use of DOM constants.

This also removes support for constant strings in IDL, which we had no uses of.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
Remove code to generate forward declaration of constant accessor functions.

(GenerateImplementation):
Remove code to generate implementation of constant accessor functions.

(GenerateHashTableValueArray):
Plant the constant directly in the value array.

bindings/scripts/IDLParser.pm:

(parseConstValue):
Remove support for constant strings.

bindings/scripts/test/JS/JSTestInterface.cpp:
bindings/scripts/test/JS/JSTestInterface.h:
bindings/scripts/test/JS/JSTestObj.cpp:
bindings/scripts/test/JS/JSTestObj.h:
bindings/scripts/test/ObjC/DOMTestObj.h:
bindings/scripts/test/TestObj.idl:

Update test results.

1:33 PM Changeset in webkit [169978] by andersca@apple.com

3 edits in trunk/Source/WebCore

Simplify Document::processHttpEquiv
https://bugs.webkit.org/show_bug.cgi?id=133910

Reviewed by Andreas Kling.

dom/Document.cpp:

(WebCore::Document::processHttpEquiv):

platform/network/HTTPHeaderNames.in:

12:39 PM Changeset in webkit [169977] by akling@apple.com

2 edits in trunk/Source/WebCore

GCController should return FastMalloc memory to the system.
<https://webkit.org/b/133884>

Reviewed by Anders Carlsson.

Speculative test fix; I'm kinda suspecting that some tests are reporting
more memory used because we did a GC but didn't get around to returning
free pages to the system yet.

bindings/js/GCController.cpp:

(WebCore::GCController::garbageCollectNow):

12:13 PM Changeset in webkit [169976] by zandobersek@gmail.com

4 edits in trunk/Source/WebCore

Generate HTTP header names that are required by WebKitWebSrc
https://bugs.webkit.org/show_bug.cgi?id=133906

Reviewed by Anders Carlsson.

WebKitWebSrc implementation sets icy-metadata and transferMode.dlna HTTP headers
on ResourceRequest objects. The two headers are added to HTTPHeaderNames.in, and
a small tweak is added to the generator script to avoid the dot in the second
header's name (which would otherwise generate invalid C++).

platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcStart):

platform/network/HTTPHeaderNames.in:
platform/network/create-http-header-name-table:

12:10 PM Changeset in webkit [169975] by andersca@apple.com

5 edits in trunk/Source/WebCore

Replace some uses of ResourceRequestBase::addHTTPHeaderField with setHTTPHeaderField
https://bugs.webkit.org/show_bug.cgi?id=133907

Reviewed by Andreas Kling.

Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::clientHandshakeRequest):

platform/network/HTTPHeaderNames.in:
platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::applyBasicAuthorizationHeader):

platform/network/mac/ResourceHandleMac.mm:

(WebCore::applyBasicAuthorizationHeader):

10:49 AM Changeset in webkit [169974] by andersca@apple.com

15 edits in trunk/Source/WebCore

Add a ResourceRequestBase::setHTTPHeaderField overload that takes a HTTPHeaderName
https://bugs.webkit.org/show_bug.cgi?id=133881

Reviewed by Sam Weinig.

WebCore.exp.in:
fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::start):

inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::willSendRequest):

loader/CrossOriginAccessControl.cpp:

(WebCore::createAccessControlPreflightRequest):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::addExtraFieldsToRequest):

loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):

loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::createResourceHandle):

loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

page/EventSource.cpp:

(WebCore::EventSource::connect):

platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::doStart):

platform/network/HTTPHeaderNames.in:
platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::httpHeaderField):
(WebCore::ResourceRequestBase::setHTTPHeaderField):
(WebCore::ResourceRequestBase::httpContentType):
(WebCore::ResourceRequestBase::setHTTPContentType):
(WebCore::ResourceRequestBase::httpReferrer):
(WebCore::ResourceRequestBase::setHTTPReferrer):
(WebCore::ResourceRequestBase::httpOrigin):
(WebCore::ResourceRequestBase::setHTTPOrigin):
(WebCore::ResourceRequestBase::httpUserAgent):
(WebCore::ResourceRequestBase::setHTTPUserAgent):
(WebCore::ResourceRequestBase::httpAccept):
(WebCore::ResourceRequestBase::setHTTPAccept):

platform/network/ResourceRequestBase.h:
platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::willSendRequest):

10:43 AM Changeset in webkit [169973] by msaboff@apple.com

6 edits in trunk/Source/JavaScriptCore

operationCreateArguments could cause a GC during OSR exit
https://bugs.webkit.org/show_bug.cgi?id=133905

Reviewed by Filip Pizlo.

Defer GC via new wrapper functions for operationCreateArguments and operationCreateInlinedArguments
for use by OSR exit stubs.

dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::ArgumentsRecoveryGenerator::generateFor):

dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
jit/JITOperations.cpp:
jit/JITOperations.h:

10:40 AM Changeset in webkit [169972] by Simon Fraser

5 edits
6 adds in trunk

Masks disappear when layers become tiled
https://bugs.webkit.org/show_bug.cgi?id=133892
<rdar://problem/17309793>

Reviewed by Tim Horton.

Source/WebCore:
There were several problems with tiled mask layers.

First, when a layer became tiled it failed to re-apply the platform layer
for its mask; fixed by adding MaskLayerChanged to the set of flags in
swapFromOrToTiledLayer().

Secondly, in CA, a mask layer's superlayer is the layer which is it masking,
so the if (oldLayer->superlayer())... code in swapFromOrToTiledLayer() would
erroneously try to swap out a sublayer on the superlayer with the mask.

Thirdly, the mask layer is updated after its host layer, but when the mask layer
become tiled, there was no code that updated the mask platform layer on its
host layer. Fix by:

setting a bit on a layer to note that it's being used as a mask.
setting the parent of such a layer to its host layer (mimicking CA)
when the mask becomes tiled, dirtying the MaskLayerChanged bit on its parent and adding a clause to commitLayerChangesAfterSublayers() to update the mask layer.

Finally, ASSERTION FAILED: owningGraphicsLayer()->isCommittingChanges() would
fire because we failed to set the m_isCommittingChanges flag while committing
the mask layer. Fix by moving the TemporaryChange<bool> that sets this flag
into commitLayerChangesBeforeSublayers() and commitLayerChangesAfterSublayers().

Also used safe casts in more places in GraphicsLayerCA.

Tests: compositing/masks/become-tiled-mask.html

compositing/masks/cease-tiled-mask.html
compositing/masks/tiled-mask.html

platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::GraphicsLayer):
(WebCore::GraphicsLayer::removeFromParent):
(WebCore::GraphicsLayer::setMaskLayer):

platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::setIsMaskLayer):
(WebCore::GraphicsLayer::isMaskLayer):
(WebCore::GraphicsLayer::setMaskLayer): Deleted.

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::removeFromParent):
(WebCore::GraphicsLayerCA::setMaskLayer):
(WebCore::GraphicsLayerCA::recursiveVisibleRectChangeRequiresFlush):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::commitLayerChangesAfterSublayers):
(WebCore::GraphicsLayerCA::updateSublayerList):
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
(WebCore::GraphicsLayerCA::updateMaskLayer):
(WebCore::GraphicsLayerCA::replicatedLayerRoot):
(WebCore::GraphicsLayerCA::createFilterAnimationsFromKeyframes):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
(WebCore::GraphicsLayerCA::propagateLayerChangeToReplicas):
(WebCore::GraphicsLayerCA::fetchCloneLayers):

LayoutTests:
Tests for masking as they go into and out of tiled mode.

compositing/masks/become-tiled-mask-expected.html: Added.
compositing/masks/become-tiled-mask.html: Added.
compositing/masks/cease-tiled-mask-expected.html: Added.
compositing/masks/cease-tiled-mask.html: Added.
compositing/masks/tiled-mask-expected.html: Added.
compositing/masks/tiled-mask.html: Added.

10:12 AM Changeset in webkit [169971] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Fix build.

UIProcess/API/mac/WKView.mm:

(-[WKView selectedRangeWithCompletionHandler:]):
(-[WKView markedRangeWithCompletionHandler:]):
(-[WKView hasMarkedTextWithCompletionHandler:]):
(-[WKView attributedSubstringForProposedRange:completionHandler:]):
(-[WKView firstRectForCharacterRange:completionHandler:]):
(-[WKView characterIndexForPoint:completionHandler:]):

9:06 AM Changeset in webkit [169970] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[Curl] Compile errors related to http headers.
https://bugs.webkit.org/show_bug.cgi?id=133901

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-06-14
Reviewed by Brent Fulgham.

Http headers should now be specified with an enum, not a string.

platform/network/curl/CurlCacheEntry.cpp:

(WebCore::CurlCacheEntry::parseResponseHeaders):

platform/network/curl/MultipartHandle.cpp:

(WebCore::MultipartHandle::didReceiveResponse):

8:53 AM Changeset in webkit [169969] by zandobersek@gmail.com

4 edits in trunk/Source/WebKit2

Unreviewed build fix for the GTK+ port.
Fixing the callback lambda parameters after r169962.

UIProcess/API/gtk/WebKitPrintOperation.cpp:

(webkitPrintOperationPrintPagesForFrame):

UIProcess/API/gtk/WebKitWebResource.cpp:

(webkit_web_resource_get_data):

UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_can_execute_editing_command):
(webkit_web_view_run_javascript):
(resourcesStreamReadCallback):
(webkit_web_view_save):
(webkit_web_view_save_to_file):

8:43 AM Changeset in webkit [169968] by Brent Fulgham

2 edits in trunk/Source/WebCore

Unreviewed build fix after r169960.

platform/graphics/ca/PlatformCALayer.cpp: Add missing include

for snprintf on Windows.

3:18 AM Changeset in webkit [169967] by gyuyoung.kim@samsung.com

2 edits in trunk

[EFL] Remove duplicated compiler flag
https://bugs.webkit.org/show_bug.cgi?id=133838

Reviewed by Anders Carlsson.

In r169798, literal-suffix was added for EFL port in order to fix build break. However,
it added to common compiler options. So, it is duplicated.

Source/cmake/WebKitHelpers.cmake:

2:04 AM Changeset in webkit [169966] by Csaba Osztrogonác

6 edits in trunk/Source

Source/WebCore: URTBF after r169943 and r169946.

platform/network/HTTPHeaderMap.h: Removed maybe accidental deletion of the only one add function.
platform/network/HTTPHeaderNames.in: Added Sec-WebSocket-Key.

Source/WebKit2: URTBF after r169943 and r169946, use the format of set/get.

UIProcess/InspectorServer/WebInspectorServer.cpp:

(WebKit::WebInspectorServer::didReceiveUnrecognizedHTTPRequest):

UIProcess/InspectorServer/WebSocketServerConnection.cpp:

(WebKit::WebSocketServerConnection::readHTTPMessage):
(WebKit::WebSocketServerConnection::upgradeToWebSocketServerConnection):

1:01 AM Changeset in webkit [169965] by fred.wang@free.fr

20 edits
10 deletes in trunk

Unreviewed, rolling out r169963.
https://bugs.webkit.org/show_bug.cgi?id=133899

Assertion in mathml/roots-removeChild.html (Requested by fredw
on #webkit).

Reverted changeset:

"Draw radicals with glyphs for better rendering"
https://bugs.webkit.org/show_bug.cgi?id=119038
http://trac.webkit.org/changeset/169963

Patch by Commit Queue <commit-queue@webkit.org> on 2014-06-14

Jun 13, 2014:

11:31 PM Changeset in webkit [169964] by akling@apple.com

2 edits in trunk/Source/WebKit2

REGRESSION (r167635): Reference leak in NetworkResourceLoader while loads are being deferred.
<https://webkit.org/b/133894>
<rdar://problem/17312299>

Don't self-ref() in start() until we actually start; if page loads are being
deferred, start() will be called again once deferral stops.

This was causing us to leak the entire NetworkResourceLoader object graph.

Reviewed by Brady Eidson.

NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::start):

11:18 PM Changeset in webkit [169963] by fred.wang@free.fr

20 edits
10 adds in trunk

Draw radicals with glyphs for better rendering
https://bugs.webkit.org/show_bug.cgi?id=119038

Reviewed by Chris Fleizach.

Source/WebCore:
We rewrite RenderMathMLRoot in order to fix bugs with SVG transforms and dynamic modification of children and allow drawing with an OpenType MATH table.
The drawing of the radical sign (without the top bar) is now moved to a RenderMathMLRadicalOperator class inheriting from RenderMathMLOperator.
This class fallbacks to the original drawing with graphic primitives if an OpenType MATH table is not available.

Tests: mathml/opentype/roots-LatinModern.html

mathml/presentation/mroot-transform.html

CMakeLists.txt: add files to build system.
WebCore.vcxproj/WebCore.vcxproj: ditto.
WebCore.vcxproj/WebCore.vcxproj.filters: ditto.
WebCore.xcodeproj/project.pbxproj: ditto
css/mathml.css: remove rules for msqrt/mroot. The "script level" in mroot is not incremented by 2 as specified in the spec.

(math, mrow, mfenced, merror, mphantom, mstyle, menclose):
(mroot > *:last-child):
(math, mrow, mfenced, msqrt, mroot, merror, mphantom, mstyle, menclose): Deleted.
(msqrt > *): Deleted.
(mroot): Deleted. This rule was causing bug 126516.
(mroot > * + *): Deleted.

rendering/RenderObject.h: Add two new isRenderMathML* functions for dynamic casting.

(WebCore::RenderObject::isRenderMathMLRadicalOperator):
(WebCore::RenderObject::isRenderMathMLRootWrapper):

rendering/mathml/RenderMathMLOperator.cpp: Accept a set of operator dictionary flags, all disabled by default. This is to allow anonymous radicas, which don't have any flag.

isFencedOperator() is now replaced with the more general isAnonymous() since we allow anonymous radical operator fors msqrt/mroot.
(WebCore::RenderMathMLOperator::RenderMathMLOperator):
(WebCore::RenderMathMLOperator::setOperatorFlagFromAttribute):
(WebCore::RenderMathMLOperator::setOperatorPropertiesFromOpDictEntry):
(WebCore::RenderMathMLOperator::SetOperatorProperties):
(WebCore::RenderMathMLOperator::updateTokenContent):

rendering/mathml/RenderMathMLOperator.h: Allow class to be overriden, redefine the anonymous constructor, remove isFencedOperator().
rendering/mathml/RenderMathMLRadicalOperator.cpp: Added.

(WebCore::RenderMathMLRadicalOperator::RenderMathMLRadicalOperator):
(WebCore::RenderMathMLRadicalOperator::stretchTo):
(WebCore::RenderMathMLRadicalOperator::SetOperatorProperties):
(WebCore::RenderMathMLRadicalOperator::computePreferredLogicalWidths):
(WebCore::RenderMathMLRadicalOperator::computeLogicalHeight):
(WebCore::RenderMathMLRadicalOperator::paint):
(WebCore::RenderMathMLRadicalOperator::trailingSpaceError):

rendering/mathml/RenderMathMLRadicalOperator.h: Added.
rendering/mathml/RenderMathMLRoot.cpp: Rewritten. Some parts to use graphic primitives are moved to RenderMathMLRadicalOperator.cpp.

(WebCore::RenderMathMLRoot::RenderMathMLRoot):
(WebCore::RenderMathMLRoot::baseWrapper):
(WebCore::RenderMathMLRoot::radicalWrapper):
(WebCore::RenderMathMLRoot::indexWrapper):
(WebCore::RenderMathMLRoot::radicalOperator):
(WebCore::RenderMathMLRoot::restructureWrappers):
(WebCore::RenderMathMLRoot::addChild):
(WebCore::RenderMathMLRoot::styleDidChange):
(WebCore::RenderMathMLRoot::updateFromElement):
(WebCore::RenderMathMLRoot::updateStyle):
(WebCore::RenderMathMLRoot::firstLineBaseline):
(WebCore::RenderMathMLRoot::layout):
(WebCore::RenderMathMLRoot::paint):
(WebCore::RenderMathMLRootWrapper::createAnonymousWrapper):
(WebCore::RenderMathMLRootWrapper::removeChildWithoutRestructuring):
(WebCore::RenderMathMLRootWrapper::removeChild):
(WebCore::RenderMathMLRoot::paddingTop): Deleted.
(WebCore::RenderMathMLRoot::paddingBottom): Deleted.
(WebCore::RenderMathMLRoot::paddingLeft): Deleted.
(WebCore::RenderMathMLRoot::paddingRight): Deleted.
(WebCore::RenderMathMLRoot::paddingBefore): Deleted.
(WebCore::RenderMathMLRoot::paddingAfter): Deleted.
(WebCore::RenderMathMLRoot::paddingStart): Deleted.
(WebCore::RenderMathMLRoot::paddingEnd): Deleted.
(WebCore::RenderMathMLRoot::index): Deleted.

rendering/mathml/RenderMathMLRoot.h: Rewritten.

(WebCore::RenderMathMLRootWrapper::RenderMathMLRootWrapper):

LayoutTests:
We update the reference for some tests with radicals and enable the tests for addition/removal of children in an msqrt/mroot element.
We also add a test for bug 126516 (SVG transforms not applied to mroot) and a new test for radical drawing using an OpenType MATH table.

TestExpectations: enable the tests for addition/removal of children.
mathml/opentype/roots-LatinModern.html: Added.
mathml/presentation/mroot-transform-expected.html: Added.
mathml/presentation/mroot-transform.html: Added.
platform/efl/TestExpectations: mark failures for bad references.
platform/efl/mathml/opentype/roots-LatinModern-expected.txt: Added.
platform/gtk/mathml/opentype/roots-LatinModern-expected.png: Added.
platform/gtk/mathml/opentype/roots-LatinModern-expected.txt: Added.
platform/gtk/mathml/presentation/mo-stretch-expected.png: update reference.
platform/gtk/mathml/presentation/mo-stretch-expected.txt: update reference.
platform/gtk/mathml/presentation/roots-expected.png: update reference.
platform/gtk/mathml/presentation/roots-expected.txt: update reference.
platform/mac/TestExpectations: mark failures for bad references.
platform/mac/mathml/opentype/roots-LatinModern-expected.txt: Added.
platform/win/TestExpectations: mark failures for bad references.
platform/win/mathml/opentype/roots-LatinModern-expected.txt: Added.

10:32 PM Changeset in webkit [169962] by mitz@apple.com

10 edits in trunk/Source/WebKit2

Make GenericCallback variadic
https://bugs.webkit.org/show_bug.cgi?id=133897

Reviewed by Sam Weinig.

Also eliminated legacy callback functions and all CallbackBase derived classes outside of
GenericCallback.h.

UIProcess/API/C/WKPage.cpp:

(WKPageValidateCommand): Changed legacy callback (with leading bool parameter) into modern
callback (with trailing error parameter).
(WKPageComputePagesForPrinting): Ditto.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _getWebArchiveDataWithCompletionHandler:]): Ditto.
(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]): Ditto.

UIProcess/API/Cocoa/_WKThumbnailView.mm:

(-[_WKThumbnailView _requestSnapshotIfNeeded]): Ditto.

UIProcess/API/mac/WKView.mm:

(-[WKView validateUserInterfaceItem:]): Ditto.
(-[WKView startSpeaking:]): Ditto.

UIProcess/AutoCorrectionCallback.h: Replaced CallbackBase derived classes with

GenericCallback specializations.

UIProcess/GenericCallback.h:
Made GenericCallback variadic:

(WebKit::GenericCallback::performCallbackWithReturnValue):
(WebKit::GenericCallback::invalidate):
(WebKit::GenericAPICallback::create):

Replaced CallbackBase derived classes with GenericCallback specializations:

(WebKit::GenericCallback::create): Deleted.
(WebKit::ComputedPagesCallback::create): Deleted.
(WebKit::ComputedPagesCallback::~ComputedPagesCallback): Deleted.
(WebKit::ComputedPagesCallback::performCallbackWithReturnValue): Deleted.
(WebKit::ComputedPagesCallback::invalidate): Deleted.
(WebKit::ComputedPagesCallback::ComputedPagesCallback): Deleted.
(WebKit::ImageCallback::create): Deleted.
(WebKit::ImageCallback::~ImageCallback): Deleted.
(WebKit::ImageCallback::performCallbackWithReturnValue): Deleted.
(WebKit::ImageCallback::invalidate): Deleted.
(WebKit::ImageCallback::ImageCallback): Deleted.

UIProcess/WebPageProxy.h: Replaced CallbackBase derived classes with GenericCallback

specializations.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView requestAutocorrectionRectsForString:withCompletionHandler:]): Changed
legacy callback (with leading bool parameter) into modern callback (with trailing error
parameter).
(-[WKContentView requestDictationContext:]): Ditto.
(-[WKContentView requestAutocorrectionContextWithCompletionHandler:]): Ditto.

UIProcess/mac/WKPrintingView.mm:

(-[WKPrintingView _preparePDFDataForPrintingOnSecondaryThread]): Ditto.
(-[WKPrintingView _askPageToComputePageRects]): Ditto.
(-[WKPrintingView _drawPreview:]): Ditto.

10:09 PM Changeset in webkit [169961] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Unreviewed; fix the build.

Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::drawInContext):

7:59 PM Changeset in webkit [169960] by Brent Fulgham

9 edits in trunk/Source/WebCore

Move utility functions from WebLayer to PlatformCALayer
https://bugs.webkit.org/show_bug.cgi?id=133887
<rdar://problem/17309622>

Reviewed by Simon Fraser.

Move some utility functions from WebLayer.h/.mm to PlatformCALayer.
Provide ObjC implementation in PlatformCALayerMac. A future patch will
provide corresponding Windows versions.

WebCore.exp.in:
platform/graphics/ca/PlatformCALayer.cpp:

(WebCore::PlatformCALayer::drawRepaintIndicator):

platform/graphics/ca/PlatformCALayer.h:
platform/graphics/ca/TileController.cpp:

(WebCore::TileController::blankPixelCountForTiles):

platform/graphics/ca/TileGrid.cpp:

(WebCore::TileGrid::platformCALayerPaintContents):

platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::collectRectsToPaint):
(PlatformCALayer::drawLayerContents):
(PlatformCALayer::frameForLayer):

platform/graphics/mac/WebLayer.h:
platform/graphics/mac/WebLayer.mm:

(-[WebLayer drawInContext:]):
(WebCore::collectRectsToPaint): Deleted.
(WebCore::drawLayerContents): Deleted.
(WebCore::drawRepaintIndicator): Deleted.
(WebCore::frameForLayer): Deleted.

5:35 PM Changeset in webkit [169959] by achristensen@apple.com

4 edits in trunk/Source

Unreviewed disabling css jit on armv7. It's not quite ready yet.

Source/WebCore:

cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::modulo):
Removed extra comma.

Source/WTF:

wtf/Platform.h:

Disable css jit on armv7.

5:18 PM Changeset in webkit [169958] by achristensen@apple.com

2 edits in trunk/Source/WTF

Enable css jit for armv7 on iOS.
https://bugs.webkit.org/show_bug.cgi?id=133890
<rdar://problem/17310631>

Reviewed by Andreas Kling.

wtf/Platform.h:

Enable css jit for ARM thumb on iOS.

5:04 PM Changeset in webkit [169957] by mhock@apple.com

2 edits in trunk/Source/WebKit2

Clean up layers in RemoteLayerTreeHost::clearLayers().
https://bugs.webkit.org/show_bug.cgi?id=133888

Reviewed by Tim Horton.

UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::clearLayers):

4:37 PM CommitterTips edited by akling@apple.com

(diff)

4:37 PM Changeset in webkit [169956] by achristensen@apple.com

2 edits in trunk/Source/WebCore

Make css jit compile on armv7.
https://bugs.webkit.org/show_bug.cgi?id=133889

Reviewed by Benjamin Poulain.

cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::moduloHelper):
(WebCore::SelectorCompiler::SelectorCodeGenerator::modulo):
Implement modulo using a function call for now.

4:01 PM Changeset in webkit [169955] by andersca@apple.com

5 edits in trunk/Source/WebCore

Use the callOnMainThread version that takes an std::function in BlobResourceHandle::start()
https://bugs.webkit.org/show_bug.cgi?id=133886

Reviewed by Andreas Kling.

Also replace a couple of NSAutoreleasePools with @autoreleasepool and an OwnPtr with an std::unique_ptr.

page/scrolling/mac/ScrollingThreadMac.mm:

(WebCore::ScrollingThread::threadRunLoopSourceCallback):

platform/mac/SharedTimerMac.mm:

(WebCore::PowerObserver::PowerObserver):
(WebCore::timerFired):
(WebCore::setSharedTimerFireInterval):
(WebCore::PowerObserver::create): Deleted.
(WebCore::PowerObserver::didReceiveSystemPowerNotification): Deleted.

platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::start):
(WebCore::delayedStartBlobResourceHandle): Deleted.

platform/network/BlobResourceHandle.h:

3:52 PM Changeset in webkit [169954] by weinig@apple.com

36 edits in trunk/Source/WebCore

Constructors should eagerly reify their properties too
https://bugs.webkit.org/show_bug.cgi?id=133822

Reviewed by Andreas Kling.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorDeclaration):
Constructors should never need to use the lazy property HashTable, so we can just
remove its getOwnPropertySlot completely.

(ConstructorHasProperties):
Add helper to determine if we need to reify any properties.

(GenerateConstructorHelperMethods):
Reify if needed, and remove the implementation of getOwnPropertySlot.

bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
bindings/scripts/test/JS/JSTestActiveDOMObject.h:
bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
bindings/scripts/test/JS/JSTestEventConstructor.cpp:
bindings/scripts/test/JS/JSTestEventConstructor.h:
bindings/scripts/test/JS/JSTestEventTarget.cpp:
bindings/scripts/test/JS/JSTestEventTarget.h:
bindings/scripts/test/JS/JSTestException.cpp:
bindings/scripts/test/JS/JSTestException.h:
bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
bindings/scripts/test/JS/JSTestInterface.cpp:
bindings/scripts/test/JS/JSTestInterface.h:
bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
bindings/scripts/test/JS/JSTestNamedConstructor.h:
bindings/scripts/test/JS/JSTestNode.cpp:
bindings/scripts/test/JS/JSTestNode.h:
bindings/scripts/test/JS/JSTestNondeterministic.cpp:
bindings/scripts/test/JS/JSTestNondeterministic.h:
bindings/scripts/test/JS/JSTestObj.cpp:
bindings/scripts/test/JS/JSTestObj.h:
bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
bindings/scripts/test/JS/JSTestTypedefs.cpp:
bindings/scripts/test/JS/JSTestTypedefs.h:
bindings/scripts/test/JS/JSattribute.cpp:
bindings/scripts/test/JS/JSattribute.h:
bindings/scripts/test/JS/JSreadonly.cpp:
bindings/scripts/test/JS/JSreadonly.h:

Update tests.

3:26 PM Changeset in webkit [169953] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Make css jit allocator smarter.
https://bugs.webkit.org/show_bug.cgi?id=133834

Patch by Alex Christensen <achristensen@webkit.org> on 2014-06-13
Reviewed by Benjamin Poulain.

cssjit/RegisterAllocator.h:

(WebCore::RegisterAllocator::allocateRegister):
(WebCore::RegisterAllocator::deallocateRegister):
(WebCore::RegisterAllocator::reserveCalleeSavedRegisters):
(WebCore::LocalRegister::LocalRegister):
(WebCore::RegisterAllocator::RegisterAllocator):
Use a Deque for the registers. Allocate from the front and deallocate to the back to cycle the register usage.
(WebCore::RegisterAllocator::allocateRegisterWithPreference):
(WebCore::LocalRegisterWithPreference::LocalRegisterWithPreference):
Added the ability to specify that we prefer a certain register if it is available while allocating.
These functions always return a register. It is just a different register than preferred if the preferred register is not available.

cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributeValueExactMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributeFunctionCallValueMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsActive):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsHovered):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):
Whenever we are allocating a register for the second argument, we should specify that we
prefer to have argumentGPR1 to reduce register swapping when preparing for a function call.
This cannot be done for argumentGPR0 because elementAddressRegister is argumentGPR0 and it is always allocated.

3:24 PM Changeset in webkit [169952] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

set setUsesExternalPlaybackWhileExternalScreenIsActive based on fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=133829

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-06-13
Reviewed by Eric Carlson.

When playing inline and external screen is active, don't use external playback.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:

declare updateDisableExternalPlayback()

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
call updateDisableExternalPlayback when player is created
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenLayer):
call updateDisableExternalPlayback when fullscreen mode changes
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateDisableExternalPlayback):
update setUsesExternalPlaybackWhileExternalScreenIsActive based on fullscreen mode

3:18 PM Changeset in webkit [169951] by mhahnenberg@apple.com

4 edits in trunk/Source

OSR exit should barrier the Executables for all InlineCallFrames, not just those on the stack at the time of exit
https://bugs.webkit.org/show_bug.cgi?id=133880

Reviewed by Filip Pizlo.

Source/JavaScriptCore:
We could have exited due to a value received from an inlined block that's no longer on
the stack, so we should just barrier all InlineCallFrames.

dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::adjustAndJumpToTarget):

Source/WTF:

wtf/Bag.h:

(WTF::Bag::iterator::operator!=): Add != to the Bag iterator so we can use it in range-based iteration.

2:49 PM Changeset in webkit [169950] by fpizlo@apple.com

20 edits
8 adds
2 deletes in branches/ftlopt

[ftlopt] A DFG inlined ById access variant should not speak of a chain, but only of what structures to test the base for, whether to use a constant as an alternate base for the actual access, and what structures to check on what additional cell constants
https://bugs.webkit.org/show_bug.cgi?id=133821

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

This allows us to efficiently cache accesses that differ only in the prototypes on the path
from the base to the prototype that has the field.

It also simplifies a bunch of code - IntendedStructureChain is now just an intermediate
data structure.

CMakeLists.txt:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/ConstantStructureCheck.cpp: Added.

(JSC::ConstantStructureCheck::dumpInContext):
(JSC::ConstantStructureCheck::dump):
(JSC::structureFor):
(JSC::areCompatible):
(JSC::mergeInto):

bytecode/ConstantStructureCheck.h: Added.

(JSC::ConstantStructureCheck::ConstantStructureCheck):
(JSC::ConstantStructureCheck::operator!):
(JSC::ConstantStructureCheck::constant):
(JSC::ConstantStructureCheck::structure):

bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeForStubInfo):

bytecode/GetByIdVariant.cpp:

(JSC::GetByIdVariant::GetByIdVariant):
(JSC::GetByIdVariant::operator=):
(JSC::GetByIdVariant::attemptToMerge):
(JSC::GetByIdVariant::dumpInContext):

bytecode/GetByIdVariant.h:

(JSC::GetByIdVariant::constantChecks):
(JSC::GetByIdVariant::alternateBase):
(JSC::GetByIdVariant::GetByIdVariant): Deleted.
(JSC::GetByIdVariant::chain): Deleted.

bytecode/PutByIdVariant.cpp:

(JSC::PutByIdVariant::dumpInContext):

bytecode/PutByIdVariant.h:

(JSC::PutByIdVariant::transition):
(JSC::PutByIdVariant::constantChecks):
(JSC::PutByIdVariant::structureChain): Deleted.

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::emitChecks):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::handlePutById):
(JSC::DFG::ByteCodeParser::cellConstantWithStructureCheck): Deleted.
(JSC::DFG::ByteCodeParser::structureChainIsStillValid): Deleted.
(JSC::DFG::ByteCodeParser::emitPrototypeChecks): Deleted.

dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::emitGetByOffset):
(JSC::DFG::ConstantFoldingPhase::emitPutByOffset):
(JSC::DFG::ConstantFoldingPhase::addStructureTransitionCheck):

dfg/DFGDesiredStructureChains.cpp: Removed.
dfg/DFGDesiredStructureChains.h: Removed.
dfg/DFGGraph.h:

(JSC::DFG::Graph::watchpoints):
(JSC::DFG::Graph::chains): Deleted.

dfg/DFGPlan.cpp:

(JSC::DFG::Plan::isStillValid):
(JSC::DFG::Plan::checkLivenessAndVisitChildren):
(JSC::DFG::Plan::cancel):

dfg/DFGPlan.h:
ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileMultiGetByOffset):

runtime/IntendedStructureChain.cpp:

(JSC::IntendedStructureChain::gatherChecks):

runtime/IntendedStructureChain.h:

(JSC::IntendedStructureChain::at):
(JSC::IntendedStructureChain::operator[]):

LayoutTests:

js/regress/poly-chain-access-different-prototypes-expected.txt: Added.
js/regress/poly-chain-access-different-prototypes-simple-expected.txt: Added.
js/regress/poly-chain-access-different-prototypes-simple.html: Added.
js/regress/poly-chain-access-different-prototypes.html: Added.
js/regress/script-tests/poly-chain-access-different-prototypes-simple.js: Added.
js/regress/script-tests/poly-chain-access-different-prototypes.js: Added.

2:30 PM Changeset in webkit [169949] by fpizlo@apple.com

8 edits in branches/ftlopt/Source/JavaScriptCore

[ftlopt] Constant folding and strength reduction should work in SSA
https://bugs.webkit.org/show_bug.cgi?id=133839

Reviewed by Oliver Hunt.

dfg/DFGAtTailAbstractState.cpp:

(JSC::DFG::AtTailAbstractState::AtTailAbstractState):
(JSC::DFG::AtTailAbstractState::forNode):

dfg/DFGAtTailAbstractState.h:
dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::convertToConstant):

dfg/DFGIntegerCheckCombiningPhase.cpp:

(JSC::DFG::IntegerCheckCombiningPhase::rangeKeyAndAddend): Fix an unrelated regression that this uncovered.

dfg/DFGLICMPhase.cpp:

(JSC::DFG::LICMPhase::LICMPhase):

dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

2:13 PM Changeset in webkit [169948] by Brent Fulgham

2 edits
4 moves in trunk/Source/WebCore

Convert LayerPool and TileCoverageMap from ObjC to C++
https://bugs.webkit.org/show_bug.cgi?id=133862
<rdar://problem/17302883>

Reviewed by Simon Fraser.

This just moves two ObjC files from the mac subdirectory to the parent and
revises the project to build them as C++.

WebCore.xcodeproj/project.pbxproj:
platform/graphics/ca/LayerPool.cpp: Copied from platform/graphics/ca/mac/LayerPool.mm.
platform/graphics/ca/LayerPool.h: Copied from platform/graphics/ca/mac/LayerPool.h.
platform/graphics/ca/TileCoverageMap.cpp: Copied from platform/graphics/ca/mac/TileCoverageMap.mm.
platform/graphics/ca/TileCoverageMap.h: Copied from platform/graphics/ca/mac/TileCoverageMap.h.
platform/graphics/ca/mac/LayerPool.h: Removed.
platform/graphics/ca/mac/LayerPool.mm: Removed.
platform/graphics/ca/mac/TileCoverageMap.h: Removed.
platform/graphics/ca/mac/TileCoverageMap.mm: Removed.

1:43 PM Changeset in webkit [169947] by commit-queue@webkit.org

7 edits in trunk/Source

Make css jit compile for armv7.
https://bugs.webkit.org/show_bug.cgi?id=133596

Patch by Alex Christensen <achristensen@webkit.org> on 2014-06-13
Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

assembler/MacroAssembler.h:

Use branchPtr on ARM_THUMB2.

assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::addPtrNoFlags):
(JSC::MacroAssemblerARMv7::or32):
(JSC::MacroAssemblerARMv7::test32):
(JSC::MacroAssemblerARMv7::branch):
(JSC::MacroAssemblerARMv7::branchPtr):
Added macros necessary for css jit.

Source/WebCore:

cssjit/FunctionCall.h:

(WebCore::FunctionCall::swapArguments):
Implemented for ARM_THUMB2 and removed allocator hack.

cssjit/RegisterAllocator.h:

Added list of ARM_THUMB2 general purpose registers.
(WebCore::RegisterAllocator::isValidRegister):
Added ARM register range and corrected ARM64 register range now that r15 is tempRegister.

cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::compile):
Return CannotCompile if compiling fails because of lack of registers.
(WebCore::SelectorCompiler::SelectorCodeGenerator::generatePrologue):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateEpilogue):
Implemented for ARM_THUMB2.
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
Return false if the selector cannot be compiled because of lack of registers.
(WebCore::SelectorCompiler::SelectorCodeGenerator::addFlagsToElementStyleFromContext):
Added code using 32-bit operations and used macro assembler for 64-bit operations.
(WebCore::SelectorCompiler::SelectorCodeGenerator::modulo):
Implemented for APPLE_ARMV7S, where sdiv is not a template in the assembler.
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributesMatching):
Use addPtr instead of add64.

1:37 PM Changeset in webkit [169946] by andersca@apple.com

9 edits in trunk/Source

Add a HTTPHeaderMap::get overload that takes an HTTPHeaderName
https://bugs.webkit.org/show_bug.cgi?id=133877

Reviewed by Andreas Kling.

Source/WebCore:

Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::serverWebSocketProtocol):
(WebCore::WebSocketHandshake::serverSetCookie):
(WebCore::WebSocketHandshake::serverSetCookie2):
(WebCore::WebSocketHandshake::serverUpgrade):
(WebCore::WebSocketHandshake::serverConnection):
(WebCore::WebSocketHandshake::serverWebSocketAccept):

WebCore.exp.in:
platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::get):

platform/network/HTTPHeaderMap.h:
platform/network/HTTPHeaderNames.in:
plugins/PluginView.cpp:

(WebCore::PluginView::handlePost):

Source/WebKit2:

WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::parsePostBuffer):

1:34 PM Changeset in webkit [169945] by fred.wang@free.fr

20 edits
10 deletes in trunk

Unreviewed, rolling out r169939.
https://bugs.webkit.org/show_bug.cgi?id=133878

This patch raises assertions on mac (Requested by fredw on
#webkit).

Reverted changeset:

"Draw radicals with glyphs for better rendering"
https://bugs.webkit.org/show_bug.cgi?id=119038
http://trac.webkit.org/changeset/169939

Patch by Commit Queue <commit-queue@webkit.org> on 2014-06-13

12:54 PM Changeset in webkit [169944] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix ARMv7.

assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::abortWithReason):

12:35 PM Changeset in webkit [169943] by andersca@apple.com

6 edits in trunk/Source/WebCore

Add a HTTPHeaderMap::set overload that takes a HTTPHeaderName
https://bugs.webkit.org/show_bug.cgi?id=133874

Reviewed by Tim Horton.

platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::set):

platform/network/HTTPHeaderMap.h:
platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):

platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):

11:56 AM Changeset in webkit [169942] by fpizlo@apple.com

8 edits in trunk/Source/JavaScriptCore

Even better diagnostics from DFG traps
https://bugs.webkit.org/show_bug.cgi?id=133836

Reviewed by Oliver Hunt.

We now stuff the DFG::NodeType into a register before bailing. Also made the
DFGBailed abort reason a bit more specific. As planned, the new abort reasons use
different numbers than any previous abort reasons.

assembler/AbortReason.h:
assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::abortWithReason):

assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::abortWithReason):

assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::abortWithReason):

assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::abortWithReason):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::bail):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):

dfg/DFGSpeculativeJIT.h:

11:56 AM Changeset in webkit [169941] by andersca@apple.com

5 edits in trunk/Source/WebCore

Add a HTTPHeaderMap::find overload that takes a HTTPHeaderName
https://bugs.webkit.org/show_bug.cgi?id=133872

Reviewed by Andreas Kling.

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived):

platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::get):
(WebCore::HTTPHeaderMap::find):

platform/network/HTTPHeaderMap.h:
platform/network/HTTPHeaderNames.in:

11:48 AM Changeset in webkit [169940] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Added some flaky and failing tests to TestExpectations.

Patch by Enrique Ocaña González <eocanha@igalia.com> on 2014-06-13

platform/gtk/TestExpectations:

11:14 AM WebKitGTK/KeepingTheTreeGreen edited by eocanha@igalia.com

(diff)

11:08 AM Changeset in webkit [169939] by fred.wang@free.fr

20 edits
10 adds in trunk

Draw radicals with glyphs for better rendering
https://bugs.webkit.org/show_bug.cgi?id=119038

Reviewed by Chris Fleizach.

Tests: mathml/opentype/roots-LatinModern.html

mathml/presentation/mroot-transform.html

CMakeLists.txt: add files to build system.
WebCore.vcxproj/WebCore.vcxproj: ditto.
WebCore.vcxproj/WebCore.vcxproj.filters: ditto.
WebCore.xcodeproj/project.pbxproj: ditto
css/mathml.css: remove rules for msqrt/mroot. The "script level" in mroot is not incremented by 2 as specified in the spec.

rendering/RenderObject.h: Add two new isRenderMathML* functions for dynamic casting.

(WebCore::RenderObject::isRenderMathMLRadicalOperator):
(WebCore::RenderObject::isRenderMathMLRootWrapper):

rendering/mathml/RenderMathMLOperator.cpp: Accept a set of operator dictionary flags, all disabled by default. This is to allow anonymous radicas, which don't have any flag.

rendering/mathml/RenderMathMLOperator.h: Allow class to be overriden, redefine the anonymous constructor, remove isFencedOperator().
rendering/mathml/RenderMathMLRadicalOperator.cpp: Added.

rendering/mathml/RenderMathMLRadicalOperator.h: Added.
rendering/mathml/RenderMathMLRoot.cpp: Rewritten. Some parts to use graphic primitives are moved to RenderMathMLRadicalOperator.cpp.

rendering/mathml/RenderMathMLRoot.h: Rewritten.

(WebCore::RenderMathMLRootWrapper::RenderMathMLRootWrapper):

TestExpectations: enable the tests for addition/removal of children.
mathml/opentype/roots-LatinModern.html: Added.
mathml/presentation/mroot-transform-expected.html: Added.
mathml/presentation/mroot-transform.html: Added.
platform/efl/TestExpectations: mark failures for bad references.
platform/efl/mathml/opentype/roots-LatinModern-expected.txt: Added.
platform/gtk/mathml/opentype/roots-LatinModern-expected.png: Added.
platform/gtk/mathml/opentype/roots-LatinModern-expected.txt: Added.
platform/gtk/mathml/presentation/mo-stretch-expected.png: update reference.
platform/gtk/mathml/presentation/mo-stretch-expected.txt: update reference.
platform/gtk/mathml/presentation/roots-expected.png: update reference.
platform/gtk/mathml/presentation/roots-expected.txt: update reference.
platform/mac/TestExpectations: mark failures for bad references.
platform/mac/mathml/opentype/roots-LatinModern-expected.txt: Added.
platform/win/TestExpectations: mark failures for bad references.
platform/win/mathml/opentype/roots-LatinModern-expected.txt: Added.

11:04 AM Changeset in webkit [169938] by mitz@apple.com

5 edits in trunk/Source/WebKit2

[iOS] Networking process always decodes keys
https://bugs.webkit.org/show_bug.cgi?id=133863

Reviewed by Anders Carlsson.

Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:

(WebKit::XPCServiceInitializer): Call checkEntitlements on iOS, too.

Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:

(WebKit::XPCServiceInitializerDelegate::checkEntitlements): On iOS, allow decoding keys
if the application has the appropriate keychain access group.

Shared/cf/ArgumentCodersCF.cpp:

(IPC::setAllowsDecodingSecKeyRef): Added. Sets static bool.
(IPC::decode): Check the secKeyRefDecodingAllowed bool before decoding a key.

Shared/cf/ArgumentCodersCF.h:

10:33 AM Changeset in webkit [169937] by andersca@apple.com

10 edits in trunk/Source

Add overloads of HTTPHeaderMap::find and remove that take enums
https://bugs.webkit.org/show_bug.cgi?id=133823

Reviewed by Sam Weinig.

Source/WebCore:

WebCore.exp.in:

Update symbols.

WebCore.xcodeproj/project.pbxproj:

Make HTTPHeaderNames.h private.

platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::contains):
Convert the enum value to a string and call the contains overload that takes a string.

(WebCore::HTTPHeaderMap::remove):
Convert the enum value to a string and call the remove overload that takes a string.

platform/network/HTTPHeaderMap.h:

Add new overloads taking HTTPHeaderName and mark the versions taking string literals as deleted.

platform/network/HTTPHeaderNames.in:

Add new header names.

platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::clearHTTPAuthorization):
(WebCore::ResourceRequestBase::clearHTTPContentType):
(WebCore::ResourceRequestBase::clearHTTPReferrer):
(WebCore::ResourceRequestBase::clearHTTPOrigin):
(WebCore::ResourceRequestBase::clearHTTPUserAgent):
(WebCore::ResourceRequestBase::clearHTTPAccept):
Update functions to use HTTPHeaderName enums.

(WebCore::ResourceRequestBase::isConditional):
(WebCore::ResourceRequestBase::makeUnconditional):
Simplify these.

Source/WebKit2:

WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::parsePostBuffer):
Update for WebCore changes.

10:32 AM WebKitGTK/KeepingTheTreeGreen edited by ltilve@igalia.com

(diff)

9:35 AM WebKitGTK/2.4.x edited by sergio@webkit.org

UA bug: replaced link for trunk by link for stable (diff)

9:12 AM Changeset in webkit [169936] by commit-queue@webkit.org

3 edits
2 adds in trunk

Source/WebCore: [ATK] Fix text inside "span" block in "a" block was not accessible.
https://bugs.webkit.org/show_bug.cgi?id=132349

Patch by Jarek Czekalski <Jarek Czekalski> on 2014-06-13
Reviewed by Mario Sanchez Prada.

accessibility/atk/WebKitAccessibleWrapperAtk.cpp: Add link role to the list of roles whose objects always expose atk_text interface.

LayoutTests: [ATK] Add test for accessibility of text inside "span" block in "a" block.
https://bugs.webkit.org/show_bug.cgi?id=132349

Patch by Jarek Czekalski <Jarek Czekalski> on 2014-06-13
Reviewed by Mario Sanchez Prada.

platform/gtk/accessibility/text-in-span-block-in-a-block-expected.txt: Added.
platform/gtk/accessibility/text-in-span-block-in-a-block.html: Added.

7:25 AM WebKitGTK/2.4.x edited by vjaquez@igalia.com

point to the changesets rather than the bugs (diff)

6:33 AM Changeset in webkit [169935] by berto@igalia.com

2 edits in trunk/Source/WebCore

[GTK] GLContextEGL.cpp: conflicting declaration 'typedef ptrdiff_t GLintptr'
https://bugs.webkit.org/show_bug.cgi?id=133550

Reviewed by Gustavo Noronha Silva.

Cairo includes some definitions from GLX that conflict with the
ones provided by our GLES2 headers (GLintptr, GLsizeiptr).

Since GLContextEGL doesn't use any GLX functions we can safely
disable the inclusion of those functions in that source file.

platform/graphics/egl/GLContextEGL.cpp:

6:09 AM Changeset in webkit [169934] by Manuel Rego Casasnovas

12 edits
2 adds in trunk/Source/WebCore

[CSS Grid Layout] Introduce an explicit type for resolved grid positions
https://bugs.webkit.org/show_bug.cgi?id=131732

Reviewed by Sergio Villar Senin.

We were using simple size_t integers to represent resolved grid
positions in our internal data structures. This change allows us to
clarify the code, avoid potential off by one mistakes, and move the
resolving code to a central place.

A new class GridResolvedPosition has been created and the related
methods have been moved there from RenderGrid.
GridSpan is now defined by two GridResolvedPosition, so all the code
using it has been modified to adapt it to GridResolvedPosition.

No new tests as it is already covered by current tests
(fast/css-grid-layout/).

CMakeLists.txt:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
css/CSSGridTemplateAreasValue.cpp:

(WebCore::stringForPosition):

css/CSSParser.cpp:

(WebCore::CSSParser::parseGridTemplateAreasRow):

css/StyleResolver.cpp:

(WebCore::createImplicitNamedGridLinesFromGridArea):

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::computeNormalizedFractionBreadth):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
(WebCore::RenderGrid::insertItemIntoGrid):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator):
(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid):
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
(WebCore::RenderGrid::autoPlacementMajorAxisDirection):
(WebCore::RenderGrid::autoPlacementMinorAxisDirection):
(WebCore::RenderGrid::gridAreaBreadthForChild):
(WebCore::RenderGrid::findChildLogicalPosition):
(WebCore::RenderGrid::explicitGridColumnCount): Deleted.
(WebCore::RenderGrid::explicitGridRowCount): Deleted.
(WebCore::isColumnSide): Deleted.
(WebCore::isStartSide): Deleted.
(WebCore::RenderGrid::explicitGridSizeForSide): Deleted.
(WebCore::RenderGrid::resolveGridPositionsFromAutoPlacementPosition): Deleted.
(WebCore::gridLinesForSide): Deleted.
(WebCore::implicitNamedGridLineForSide): Deleted.
(WebCore::isNonExistentNamedLineOrArea): Deleted.
(WebCore::RenderGrid::adjustGridPositionsFromStyle): Deleted.
(WebCore::RenderGrid::resolveGridPositionsFromStyle): Deleted.
(WebCore::RenderGrid::resolveNamedGridLinePositionFromStyle): Deleted.
(WebCore::RenderGrid::resolveGridPositionFromStyle): Deleted.
(WebCore::RenderGrid::resolveGridPositionAgainstOppositePosition): Deleted.
(WebCore::RenderGrid::resolveNamedGridLinePositionAgainstOppositePosition): Deleted.
(WebCore::firstNamedGridLineBeforePosition): Deleted.
(WebCore::RenderGrid::resolveRowStartColumnStartNamedGridLinePositionAgainstOppositePosition): Deleted.
(WebCore::RenderGrid::resolveRowEndColumnEndNamedGridLinePositionAgainstOppositePosition): Deleted.

rendering/RenderGrid.h:
rendering/style/GridCoordinate.h:

(WebCore::GridSpan::GridSpan):
(WebCore::GridSpan::operator==):

rendering/style/GridPosition.h:

(WebCore::GridPosition::adjustGridPositionForRowEndColumnEndSide): Deleted.
(WebCore::GridPosition::adjustGridPositionForSide): Deleted.

rendering/style/GridResolvedPosition.cpp: Added.

(WebCore::isColumnSide):
(WebCore::isStartSide):
(WebCore::explicitGridSizeForSide):
(WebCore::GridResolvedPosition::resolveGridPositionsFromAutoPlacementPosition):
(WebCore::gridLinesForSide):
(WebCore::implicitNamedGridLineForSide):
(WebCore::isNonExistentNamedLineOrArea):
(WebCore::GridResolvedPosition::adjustGridPositionsFromStyle):
(WebCore::GridResolvedPosition::resolveGridPositionsFromStyle):
(WebCore::GridResolvedPosition::resolveNamedGridLinePositionFromStyle):
(WebCore::GridResolvedPosition::resolveGridPositionFromStyle):
(WebCore::GridResolvedPosition::resolveGridPositionAgainstOppositePosition):
(WebCore::GridResolvedPosition::resolveNamedGridLinePositionAgainstOppositePosition):
(WebCore::firstNamedGridLineBeforePosition):
(WebCore::GridResolvedPosition::resolveRowStartColumnStartNamedGridLinePositionAgainstOppositePosition):
(WebCore::GridResolvedPosition::resolveRowEndColumnEndNamedGridLinePositionAgainstOppositePosition):

rendering/style/GridResolvedPosition.h: Added.

(WebCore::GridResolvedPosition::adjustGridPositionForRowEndColumnEndSide):
(WebCore::GridResolvedPosition::adjustGridPositionForSide):
(WebCore::GridResolvedPosition::GridResolvedPosition):
(WebCore::GridResolvedPosition::operator++):
(WebCore::GridResolvedPosition::operator==):
(WebCore::GridResolvedPosition::operator<):
(WebCore::GridResolvedPosition::operator>):
(WebCore::GridResolvedPosition::operator<=):
(WebCore::GridResolvedPosition::operator>=):
(WebCore::GridResolvedPosition::toInt):
(WebCore::GridResolvedPosition::next):

5:58 AM WebKitGTK/2.4.x edited by berto@igalia.com