Timeline

Jun 20, 2014:

11:04 PM Changeset in webkit [170232] by fred.wang@free.fr

• 6 edits
  23 moves
  1 add
  11 deletes in trunk/LayoutTests

Remove latinmodern-math.woff from LayoutTests/mathml/opentype
​https://bugs.webkit.org/show_bug.cgi?id=134094

Reviewed by Martin Robinson.

We remove latinmodern-math.woff from the source and make mathml/opentype/*LatinModern* tests not font-specific, so that each platform will use whatever OpenType MATH is available.
Until bug 133604 is fixed and Latin Modern Math installed on the Linux bots, the tests are marked as failed. More generally, we need to fix bug 133603.
The test mathml/opentype/roots-LatinModern is removed since it will duplicate mathml/presentation/roots.xhtml when OpenType MATH fonts are available.

• mathml/opentype/LICENSE-LatinModern.txt: Removed.
• mathml/opentype/horizontal-munderover.html: Renamed from LayoutTests/mathml/opentype/horizontal-LatinModern-munderover.html.
• mathml/opentype/horizontal.html: Renamed from LayoutTests/mathml/opentype/horizontal-LatinModern.html.
• mathml/opentype/large-operators-LatinModern.html: Removed.
• mathml/opentype/large-operators.html: Added.
• mathml/opentype/latinmodern-math.woff: Removed.
• mathml/opentype/opentype-stretchy-horizontal.html:
• mathml/opentype/roots-LatinModern.html: Removed.
• mathml/opentype/vertical.html: Renamed from LayoutTests/mathml/opentype/vertical-LatinModern.html.
• platform/efl/TestExpectations:
• platform/efl/mathml/opentype/horizontal-expected.txt: Renamed from LayoutTests/platform/efl/mathml/opentype/horizontal-LatinModern-expected.txt.
• platform/efl/mathml/opentype/horizontal-munderover-expected.txt: Renamed from LayoutTests/platform/efl/mathml/opentype/horizontal-LatinModern-munderover-expected.txt.
• platform/efl/mathml/opentype/large-operators-expected.png: Renamed from LayoutTests/platform/gtk/mathml/opentype/large-operators-LatinModern-expected.png.
• platform/efl/mathml/opentype/large-operators-expected.txt: Renamed from LayoutTests/platform/efl/mathml/opentype/large-operators-LatinModern-expected.txt.
• platform/efl/mathml/opentype/roots-LatinModern-expected.txt: Removed.
• platform/efl/mathml/opentype/vertical-expected.png: Renamed from LayoutTests/platform/gtk/mathml/opentype/vertical-LatinModern-expected.png.
• platform/efl/mathml/opentype/vertical-expected.txt: Renamed from LayoutTests/platform/efl/mathml/opentype/vertical-LatinModern-expected.txt.
• platform/gtk/TestExpectations:
• platform/gtk/mathml/opentype/horizontal-expected.png: Renamed from LayoutTests/platform/gtk/mathml/opentype/horizontal-LatinModern-expected.png.
• platform/gtk/mathml/opentype/horizontal-expected.txt: Renamed from LayoutTests/platform/gtk/mathml/opentype/horizontal-LatinModern-expected.txt.
• platform/gtk/mathml/opentype/horizontal-munderover-expected.png: Renamed from LayoutTests/platform/gtk/mathml/opentype/horizontal-LatinModern-munderover-expected.png.
• platform/gtk/mathml/opentype/horizontal-munderover-expected.txt: Renamed from LayoutTests/platform/gtk/mathml/opentype/horizontal-LatinModern-munderover-expected.txt.
• platform/gtk/mathml/opentype/large-operators-expected.png: Renamed from LayoutTests/platform/efl/mathml/opentype/large-operators-LatinModern-expected.png.
• platform/gtk/mathml/opentype/large-operators-expected.txt: Renamed from LayoutTests/platform/gtk/mathml/opentype/large-operators-LatinModern-expected.txt.
• platform/gtk/mathml/opentype/roots-LatinModern-expected.png: Removed.
• platform/gtk/mathml/opentype/roots-LatinModern-expected.txt: Removed.
• platform/gtk/mathml/opentype/vertical-expected.png: Renamed from LayoutTests/platform/efl/mathml/opentype/vertical-LatinModern-expected.png.
• platform/gtk/mathml/opentype/vertical-expected.txt: Renamed from LayoutTests/platform/gtk/mathml/opentype/vertical-LatinModern-expected.txt.
• platform/mac-wk2/mathml/opentype/large-operators-LatinModern-expected.txt: Removed.
• platform/mac-wk2/mathml/opentype/vertical-LatinModern-expected.txt: Removed.
• platform/mac/TestExpectations:
• platform/mac/mathml/opentype/horizontal-expected.txt: Renamed from LayoutTests/platform/mac/mathml/opentype/horizontal-LatinModern-expected.txt.
• platform/mac/mathml/opentype/horizontal-munderover-expected.txt: Renamed from LayoutTests/platform/mac/mathml/opentype/horizontal-LatinModern-munderover-expected.txt.
• platform/mac/mathml/opentype/large-operators-expected.txt: Renamed from LayoutTests/platform/mac/mathml/opentype/large-operators-LatinModern-expected.txt.
• platform/mac/mathml/opentype/roots-LatinModern-expected.txt: Removed.
• platform/mac/mathml/opentype/vertical-expected.txt: Renamed from LayoutTests/platform/mac/mathml/opentype/vertical-LatinModern-expected.txt.
• platform/win/TestExpectations:
• platform/win/mathml/opentype/horizontal-expected.txt: Renamed from LayoutTests/platform/win/mathml/opentype/horizontal-LatinModern-expected.txt.
• platform/win/mathml/opentype/horizontal-munderover-expected.txt: Renamed from LayoutTests/platform/win/mathml/opentype/horizontal-LatinModern-munderover-expected.txt.
• platform/win/mathml/opentype/roots-LatinModern-expected.txt: Removed.

11:00 PM Changeset in webkit [170231] by ryuan.choi@samsung.com

• 1 edit
  1 delete in trunk/LayoutTests

[EFL] Remove WebKit1 test results
​https://bugs.webkit.org/show_bug.cgi?id=134137

Reviewed by Daniel Bates.

• platform/efl-wk1: Removed entire directory which contains the WebKit1 EFL test results.

10:53 PM Changeset in webkit [170230] by ryuan.choi@samsung.com

• 3 edits
  2 copies
  3 deletes in trunk/Tools

[EFL] Remove DumpRenderTree/efl and EWebLauncher
​https://bugs.webkit.org/show_bug.cgi?id=134138

Reviewed by Gyuyoung Kim.

DumpRenderTree/efl and EWebLauncher are not necessary anymore because WebKit1 EFL will be removed.

• CMakeLists.txt:
• DumpRenderTree/PlatformEfl.cmake: Removed.
• DumpRenderTree/efl: Removed entire directory.
• EWebLauncher: Ditto.
• WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Renamed from Tools/DumpRenderTree/efl/FontManagement.cpp.

(buildPath):
(getCoreFontFiles):
(addFontDirectory):
(addFontFiles):
(getCustomBuildDir):
(getPlatformFontsPath):
(addFontsToEnvironment):

• WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Renamed from Tools/DumpRenderTree/efl/FontManagement.h.
• WebKitTestRunner/PlatformEfl.cmake:

10:09 PM Changeset in webkit [170229] by gyuyoung.kim@samsung.com

• 2 edits in trunk/Source/WebCore

Unreviewed EFL build fix since r170224.

Add retainPlatformLayer() and releasePlatformLayer() in ScrollingStateNodeCoordinatedGraphics.cpp
as well. Thouse functions were missed in r170224.

• page/scrolling/ScrollingStateNode.h:
• page/scrolling/coordinatedgraphics/ScrollingStateNodeCoordinatedGraphics.cpp:

(WebCore::LayerRepresentation::retainPlatformLayer):
(WebCore::LayerRepresentation::releasePlatformLayer):

8:10 PM Changeset in webkit [170228] by dino@apple.com

• 38 edits in trunk

[Mac] Margins for new form controls need tweaking
​https://bugs.webkit.org/show_bug.cgi?id=134135
<rdar://problem/17262164>

Reviewed by Sam Weinig.

Source/WebCore:
With the newer animated controls in OS X Yosemite, we need
to tweak the fudge-factor margins for positioning. In a recent
patch I added another fudge, which I'm removing with this. I'm
not sure where the older values came from, but I've checked with
the latest AppKit sources and am using the sizes they implement
for the controls.

This will rebaseline a lot of tests, since I've made small tweaks
to the form layout.

• platform/mac/ThemeMac.mm:

(WebCore::checkboxMargins): New margin amounts.
(WebCore::radioSizes): New sizes.
(WebCore::radioMargins): New margin amounts.
(WebCore::paintToggleButton): No need to call the positioning fudge any more.
(WebCore::checkboxOffsets): Deleted.
(WebCore::radioOffsets): Deleted.

LayoutTests:
Rebaseline a bunch of results since some <input> dimensions
changed slightly.

• platform/mac/css1/box_properties/acid_test-expected.png:
• platform/mac/css1/box_properties/acid_test-expected.txt:
• platform/mac/css2.1/t09-c5526c-display-00-e-expected.png:
• platform/mac/css2.1/t09-c5526c-display-00-e-expected.txt:
• platform/mac/fast/block/basic/011-expected.png:
• platform/mac/fast/block/basic/011-expected.txt:
• platform/mac/fast/block/margin-collapse/103-expected.png:
• platform/mac/fast/block/margin-collapse/103-expected.txt:
• platform/mac/fast/forms/basic-inputs-expected.png:
• platform/mac/fast/forms/basic-inputs-expected.txt:
• platform/mac/fast/forms/box-shadow-override-expected.png:
• platform/mac/fast/forms/box-shadow-override-expected.txt:
• platform/mac/fast/forms/form-element-geometry-expected.png:
• platform/mac/fast/forms/form-element-geometry-expected.txt:
• platform/mac/fast/forms/formmove-expected.txt:
• platform/mac/fast/forms/formmove2-expected.png:
• platform/mac/fast/forms/formmove2-expected.txt:
• platform/mac/fast/forms/input-appearance-height-expected.png:
• platform/mac/fast/forms/input-appearance-height-expected.txt:
• platform/mac/fast/forms/input-value-expected.png:
• platform/mac/fast/forms/input-value-expected.txt:
• platform/mac/fast/inline/positionedLifetime-expected.txt:
• platform/mac/fast/replaced/replaced-breaking-expected.png:
• platform/mac/fast/replaced/replaced-breaking-expected.txt:
• platform/mac/fast/replaced/width100percent-radio-expected.txt:
• platform/mac/http/tests/navigation/javascriptlink-frames-expected.png:
• platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
• platform/mac/tables/mozilla/bugs/bug1318-expected.png:
• platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
• platform/mac/tables/mozilla/bugs/bug4527-expected.png:
• platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
• platform/mac/tables/mozilla_expected_failures/core/captions1-expected.png:
• platform/mac/tables/mozilla_expected_failures/core/captions1-expected.txt:
• platform/mac/tables/mozilla_expected_failures/core/captions2-expected.png:
• platform/mac/tables/mozilla_expected_failures/core/captions2-expected.txt:

7:33 PM Changeset in webkit [170227] by benjamin@webkit.org

• 2 edits in trunk/Source/WebCore

Fix css jit on armv7.
​https://bugs.webkit.org/show_bug.cgi?id=134143
<rdar://problem/17348060>

Patch by Alex Christensen <​achristensen@webkit.org> on 2014-06-20
Reviewed by Benjamin Poulain.

This fixes the acid3 test.

• cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::addFlagsToElementStyleFromContext):
Correct high and low bits.

5:11 PM Changeset in webkit [170226] by andersca@apple.com

• 4 edits in trunk/Source/WebKit2

Implement more of LegacySessionStateDecoder
​https://bugs.webkit.org/show_bug.cgi?id=134145

Reviewed by Sam Weinig.

• Shared/SessionState.h:
• UIProcess/mac/LegacySessionStateCoding.cpp:

(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntry):
(WebKit::HistoryEntryDataDecoder::HistoryEntryDataDecoder):
(WebKit::HistoryEntryDataDecoder::finishDecoding):
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntryData):

• UIProcess/mac/LegacySessionStateCoding.h:

4:48 PM Changeset in webkit [170225] by andersca@apple.com

• 5 edits in trunk/Source/WebKit2

Implement more of LegacySessionStateDecoder
​https://bugs.webkit.org/show_bug.cgi?id=134144

Reviewed by Sam Weinig.

• Shared/SessionState.cpp:

(WebKit::BackForwardListState::encode):
(WebKit::SessionState::encode): Deleted.

• Shared/SessionState.h:
• UIProcess/mac/LegacySessionStateCoding.cpp:

(WebKit::LegacySessionStateDecoder::decodeSessionState):
(WebKit::LegacySessionStateDecoder::decodeSessionHistory):
(WebKit::LegacySessionStateDecoder::decodeV0SessionHistory):
(WebKit::LegacySessionStateDecoder::decodeV1SessionHistory):
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntries):
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntry):

• UIProcess/mac/LegacySessionStateCoding.h:

4:44 PM Changeset in webkit [170224] by Beth Dakin

• 5 edits
  1 move
  1 add in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=134117
Unreproducible crashes under WebCore::ScrollingTree::updateTreeFromStateNode()
from messaging a deleted Obj-C object
-and corresponding-
<rdar://problem/17149252>

Reviewed by Simon Fraser.

This is a speculative fix. It makes LayerRepresentation retain m_platformLayer.

• WebCore.exp.in:
• page/scrolling/ScrollingStateNode.h:

(WebCore::LayerRepresentation::LayerRepresentation):
(WebCore::LayerRepresentation::~LayerRepresentation):
(WebCore::LayerRepresentation::operator=):
(WebCore::LayerRepresentation::operator==):
(WebCore::LayerRepresentation::operator ==): Deleted.

Make this ASSERT an ASSERT_WITH_SECURITY_IMPLICATION

• page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::updateTreeFromStateNode):

Moved ScrollingStateNodeMac.mm, which was empty anyway, to cocoa/
ScrollingStateNode.mm so that iOS can use it too.

• page/scrolling/cocoa: Added.
• page/scrolling/cocoa/ScrollingStateNode.mm: Copied from page/scrolling/mac/ScrollingStateNodeMac.mm.

Actual implementation for retain and release.
(WebCore::LayerRepresentation::retainPlatformLayer):
(WebCore::LayerRepresentation::releasePlatformLayer):

Deleted.

• page/scrolling/mac/ScrollingStateNodeMac.mm: Removed.

4:40 PM Changeset in webkit [170223] by ryuan.choi@samsung.com

• 2 edits in trunk/Source/WebKit2

Unreviewed. build fix for the cmake based ports since r170188

• CMakeLists.txt: Added LegacySessionState.cpp in source list.

4:37 PM Changeset in webkit [170222] by mitz@apple.com

• 4 edits in trunk/Source/WebKit2

[Cocoa] No way to get the main frame’s main resource’s data
​https://bugs.webkit.org/show_bug.cgi?id=134113

Reviewed by Sam Weinig.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _getMainResourceDataWithCompletionHandler:]): Added. Calls
WebPageProxy::getMainResourceDataOfFrame and invokes the completion handler form the
callback.

• UIProcess/API/Cocoa/WKWebViewPrivate.h: Declared new method.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getMainResourceDataOfFrame): Made it safe to pass a NULL frame into
this function.

4:21 PM Changeset in webkit [170221] by Alan Bujtas

• 2 edits in trunk/Tools

Name moving. Unreviewed.

• Scripts/webkitpy/common/config/contributors.json:

3:57 PM Changeset in webkit [170220] by Alan Bujtas

• 6 edits in trunk/Source/WebCore

Introduce RenderLayer::offsetFromAncestorLayer() to make convertToLayerCoords() calls with
LayoutPoint(0, 0) as parameter more explicit.
​https://bugs.webkit.org/show_bug.cgi?id=134092

Reviewed by Simon Fraser.

Most of the RenderLayer::convertToLayerCoords() callers are only interested in
the offset from the ancestor layer by passing LayoutPoint(0, 0) as the coordinate to convert.
Introducing offsetFromAncestorLayer() makes those calls more explicit/self-explanatory.
It helps simplifying the callsite's code.

No change in functionality.

• rendering/RenderGeometryMap.cpp:

(WebCore::RenderGeometryMap::mapToContainer):
(WebCore::RenderGeometryMap::pushMappingsToAncestor):
(WebCore::RenderGeometryMap::push):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::computeOffsetFromRoot):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::expandClipRectForRegionAndReflection):
(WebCore::expandClipRectForDescendantsAndReflection):
(WebCore::transparencyClipBox):
(WebCore::RenderLayer::convertToPixelSnappedLayerCoords):
(WebCore::accumulateOffsetTowardsAncestor):
(WebCore::RenderLayer::convertToLayerCoords):
(WebCore::RenderLayer::offsetFromAncestorLayer):
(WebCore::RenderLayer::clipToRect):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintLayerByApplyingTransform):
(WebCore::RenderLayer::collectFragments):
(WebCore::RenderLayer::paintTransformedLayerIntoFragments):
(WebCore::RenderLayer::createLocalTransformState):
(WebCore::RenderLayer::hitTestTransformedLayerInFragments):
(WebCore::RenderLayer::calculateClipRects):

• rendering/RenderLayer.h:
• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateCompositedBounds):
(WebCore::RenderLayerBacking::updateGeometry):

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::repaintInCompositedAncestor):

3:46 PM Changeset in webkit [170219] by andersca@apple.com

• 7 edits
  6 copies in trunk/Source/WebKit2

Introduce a WKSessionStateRef object
​https://bugs.webkit.org/show_bug.cgi?id=134136

Reviewed by Tim Horton.

WKSessionStateRef is going to hold session state, making it possible to migrate state from one
webpage to another without having to do any serialization/deserialization.

• Shared/API/c/WKBase.h:
• Shared/APIObject.h:
• Shared/SessionState.cpp:

(WebKit::SessionState::encode):

• Shared/SessionState.h:
• UIProcess/API/APISessionState.cpp: Added.

(API::SessionState::create):
(API::SessionState::SessionState):
(API::SessionState::~SessionState):

• UIProcess/API/APISessionState.h:
• UIProcess/API/C/WKAPICast.h:
• UIProcess/API/C/WKSessionStateRef.cpp:

(WKSessionStateCreateFromData):

• UIProcess/API/C/WKSessionStateRef.h:
• UIProcess/mac/LegacySessionStateCoding.cpp:

(WebKit::LegacySessionStateDecoder::LegacySessionStateDecoder):
(WebKit::LegacySessionStateDecoder::~LegacySessionStateDecoder):
(WebKit::LegacySessionStateDecoder::decodeSessionState):

• UIProcess/mac/LegacySessionStateCoding.h:
• WebKit2.xcodeproj/project.pbxproj:

3:42 PM Changeset in webkit [170218] by enrica@apple.com

• 4 edits in trunk/Source/WebKit2

iOS WebKit2: selection handles become too large when zooming a page.
​https://bugs.webkit.org/show_bug.cgi?id=134084
<rdar://problem/16799164>

Reviewed by Benjamin Poulain.

Since the document view is zoomed, we add a subview that has the inverse transform
of the document view. This new view becomes the root for the selection hierarchy.
The new view has zero size, not to interfere with the existing gestures on the WKContenView
therefore we implement hitTest to detect interaction with the selection elements.

• UIProcess/ios/WKContentView.mm:

(-[WKContentView didUpdateVisibleRect:unobscuredRect:unobscuredRectInScrollViewCoordinates:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:]):

• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView unscaledView]):
(-[WKContentView inverseScale]):
(-[WKContentView _updateUnscaledView]):
(-[WKContentView hitTest:withEvent:::]):
(-[WKContentView selectedTextRange]):

3:40 PM Changeset in webkit [170217] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

Snapshotting WKThumbnailViews should not tell Web processes backing unparented WKViews that they're in window
​https://bugs.webkit.org/show_bug.cgi?id=134134
<rdar://problem/17402119>

Reviewed by Anders Carlsson.

• UIProcess/API/mac/WKView.mm:

(-[WKView _setThumbnailView:]):
Re-evaluating our in-window state is only useful if we're going to use the live layer tree;
snapshots can be taken of unparented views with no trouble. Plus, doing so sets off a chain of
expensive things in the Web process which we can avoid if using snapshots.

3:38 PM Changeset in webkit [170216] by timothy_horton@apple.com

• 3 edits in trunk/Source/WebKit2

WKThumbnailView should only use live layer trees before the snapshot arrives for parented WKViews
​https://bugs.webkit.org/show_bug.cgi?id=134129
<rdar://problem/17401591>

Reviewed by Anders Carlsson.

• UIProcess/API/Cocoa/_WKThumbnailView.mm:

(-[_WKThumbnailView initWithFrame:fromWKView:]):
Add a white background to WKThumbnailView, so that if we have no snapshot and no layer tree,
the view isn't transparent.

• UIProcess/API/mac/WKView.mm:

(-[WKView _updateThumbnailViewLayer]):
We currently pull the live layer tree into the WKThumbnailView even in snapshot mode,
before the snapshot arrives, to avoid flashing when transitioning a live WKView to a thumbnail view.
This is, however, not useful for unparented WKViews, because their layer tree will be detached
and we'll flash anyway. So, only do that when the WKView is parented.

3:27 PM Changeset in webkit [170215] by mhahnenberg@apple.com

• 5 edits in branches/ftlopt/Source/JavaScriptCore

Merge r169903 to the branch.

2014-06-12 Mark Hahnenberg <​mhahnenberg@apple.com>

Move structureHasRareData out of TypeInfo
​https://bugs.webkit.org/show_bug.cgi?id=133800

Reviewed by Andreas Kling.

StructureHasRareData was originally put in TypeInfo to avoid making Structure bigger,
but we have a few spare bits in Structure so it would be nice to remove this hack.

• runtime/JSTypeInfo.h: (JSC::TypeInfo::newImpurePropertyFiresWatchpoints): (JSC::TypeInfo::structureHasRareData): Deleted.
• runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::allocateRareData): (JSC::Structure::cloneRareDataFrom):
• runtime/Structure.h: (JSC::Structure::previousID): (JSC::Structure::objectToStringValue): (JSC::Structure::setObjectToStringValue): (JSC::Structure::setPreviousID): (JSC::Structure::clearPreviousID): (JSC::Structure::previous): (JSC::Structure::rareData):
• runtime/StructureInlines.h: (JSC::Structure::setEnumerationCache): (JSC::Structure::enumerationCache):

3:10 PM Changeset in webkit [170214] by ggaren@apple.com

• 3 edits in trunk/Source/WebKit2

WebKit delegate methods should document their default behaviors
​https://bugs.webkit.org/show_bug.cgi?id=134132

Reviewed by Dan Bernstein.

• UIProcess/API/Cocoa/WKNavigationDelegate.h:
• UIProcess/API/Cocoa/WKUIDelegate.h:

3:06 PM Changeset in webkit [170213] by Simon Fraser

• 2 edits in trunk/Source/WebKit2

Fix lots of WK2 test crashes.

We don't always have a ScrollingCoordinator.

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::flushLayers):

3:05 PM Changeset in webkit [170212] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Always use XPC on iOS
​https://bugs.webkit.org/show_bug.cgi?id=134130

Reviewed by Sam Weinig.

• UIProcess/ios/WebProcessProxyIOS.mm:

(WebKit::WebProcessProxy::platformGetLaunchOptions):
(WebKit::shouldUseXPC): Deleted.

3:00 PM Changeset in webkit [170211] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Fix build.

• Shared/SessionState.cpp:

2:55 PM Changeset in webkit [170210] by andersca@apple.com

• 3 edits in trunk/Source/WebKit2

Add ArgumentEncoder support to PageState and friends
​https://bugs.webkit.org/show_bug.cgi?id=134128

Reviewed by Andreas Kling.

Change the classes to structs, get rid of the constructors/destructors
and add encode member functions.

• Shared/SessionState.cpp:

(WebKit::HTTPBody::Element::encode):
(WebKit::HTTPBody::encode):
(WebKit::FrameState::encode):
(WebKit::PageState::encode):
(WebKit::HTTPBody::Element::Element): Deleted.
(WebKit::HTTPBody::Element::~Element): Deleted.
(WebKit::FrameState::FrameState): Deleted.
(WebKit::FrameState::~FrameState): Deleted.
(WebKit::PageState::PageState): Deleted.
(WebKit::PageState::~PageState): Deleted.

• Shared/SessionState.h:

(WebKit::HTTPBody::Element::type): Deleted.

2:36 PM Changeset in webkit [170209] by andersca@apple.com

• 4 edits in trunk/Source

Add encoding and decoding support for WTF::Optional
​https://bugs.webkit.org/show_bug.cgi?id=134125

Reviewed by Andreas Kling.

Source/WebKit2:

• Platform/IPC/ArgumentCoders.h:

(IPC::ArgumentCoder<WTF::Optional<T>>::encode):
(IPC::ArgumentCoder<WTF::Optional<T>>::decode):

Source/WTF:

• wtf/Optional.h:

(WTF::Optional::operator=):

2:21 PM Changeset in webkit [170208] by mmaxfield@apple.com

• 4 edits
  30 deletes in trunk/Source/WebCore

Removing dead code in platform/graphics/gpu
​https://bugs.webkit.org/show_bug.cgi?id=134065

Reviewed by Simon Fraser.

No new tests because there is no behavior change.

• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/gpu/LoopBlinnClassifier.cpp: Removed.
• platform/graphics/gpu/LoopBlinnClassifier.h: Removed.
• platform/graphics/gpu/LoopBlinnConstants.h: Removed.
• platform/graphics/gpu/LoopBlinnLocalTriangulator.cpp: Removed.
• platform/graphics/gpu/LoopBlinnLocalTriangulator.h: Removed.
• platform/graphics/gpu/LoopBlinnMathUtils.cpp: Removed.
• platform/graphics/gpu/LoopBlinnMathUtils.h: Removed.
• platform/graphics/gpu/LoopBlinnPathCache.cpp: Removed.
• platform/graphics/gpu/LoopBlinnPathCache.h: Removed.
• platform/graphics/gpu/LoopBlinnPathProcessor.h: Removed.
• platform/graphics/gpu/LoopBlinnShader.cpp: Removed.
• platform/graphics/gpu/LoopBlinnShader.h: Removed.
• platform/graphics/gpu/LoopBlinnSolidFillShader.cpp: Removed.
• platform/graphics/gpu/LoopBlinnSolidFillShader.h: Removed.
• platform/graphics/gpu/LoopBlinnTextureCoords.cpp: Removed.
• platform/graphics/gpu/LoopBlinnTextureCoords.h: Removed.
• platform/graphics/gpu/Shader.cpp: Removed.
• platform/graphics/gpu/Shader.h: Removed.
• platform/graphics/gpu/SharedGraphicsContext3D.cpp: Removed.
• platform/graphics/gpu/SharedGraphicsContext3D.h: Removed.
• platform/graphics/gpu/mac/DrawingBufferMac.mm: Removed.
• platform/graphics/gpu/opencl/FilterContextOpenCL.cpp: Removed.
• platform/graphics/gpu/opencl/FilterContextOpenCL.h: Removed.
• platform/graphics/gpu/opencl/OpenCLFEColorMatrix.cpp: Removed.
• platform/graphics/gpu/opencl/OpenCLFEFlood.cpp: Removed.
• platform/graphics/gpu/opencl/OpenCLFEImage.cpp: Removed.
• platform/graphics/gpu/opencl/OpenCLFEMerge.cpp: Removed.
• platform/graphics/gpu/opencl/OpenCLFESourceAlpha.cpp: Removed.
• platform/graphics/gpu/opencl/OpenCLFESourceGraphic.cpp: Removed.
• platform/graphics/gpu/opencl/OpenCLFETurbulence.cpp: Removed.
• platform/graphics/gpu/opencl/OpenCLHandle.h: Removed.

2:17 PM Changeset in webkit [170207] by mmaxfield@apple.com

• 3 edits
  3 adds in trunk

[iOS] Support Khmer and Lao fallback fonts
​https://bugs.webkit.org/show_bug.cgi?id=134114

Reviewed by Enrica Casucci.

Source/WebCore:
iOS has fonts which have glyphs for the Khmer and Lao languages.

This patch also does a little refactoring of the language-specific fallback
font path to increase readability.

Test: fast/text/khmer-lao-font.html

• platform/graphics/ios/FontCacheIOS.mm:

(WebCore::languageSpecificFallbackFont):
(WebCore::FontCache::systemFallbackForCharacters):

LayoutTests:
Simply dump the render tree of a page that includes Khmer and Lao text. The success
of this test depends on font font metrics being different than system fallback font
(which just shows rectangles instead of glyphs).

• fast/text/khmer-lao-font.html: Added.
• platform/ios-sim/fast/text/khmer-lao-font-expected.txt: Added.
• platform/mac/fast/text/khmer-lao-font-expected.txt: Added.

2:08 PM Changeset in webkit [170206] by jfernandez@igalia.com

• 2 edits in trunk/Tools

Unreviewed. Adding myself to committers.

• Scripts/webkitpy/common/config/contributors.json:

2:03 PM Changeset in webkit [170205] by andersca@apple.com

• 4 edits in trunk/Source

Give NPAPI post requests a default content type
​https://bugs.webkit.org/show_bug.cgi?id=134120

Reviewed by Andreas Kling.

Source/WebCore:

• WebCore.exp.in:

Source/WebKit2:

• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::loadURL):

2:00 PM Changeset in webkit [170204] by Simon Fraser

• 2 edits in trunk/Source/WebKit2

Always commit the scrolling tree when we flush layers
​https://bugs.webkit.org/show_bug.cgi?id=134115

Reviewed by Beth Dakin.

The scrolling state tree contains bare pointers to GraphicsLayers, which get
converted to CALayers at commit time. To avoid a window of time where those
GraphicsLayer pointers go stale, commit the scrolling tree whenever we flush the
compositing layer tree.

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::flushLayers):

1:56 PM Changeset in webkit [170203] by Simon Fraser

• 4 edits
  2 adds in trunk

REGRESSION (r169972): fix issue when removing masks from compositing layers
​https://bugs.webkit.org/show_bug.cgi?id=134118
<rdar://problem/17366654>

Reviewed by Dean Jackson.

Source/WebCore:
After r169972 when removing the mask, we could destroy the mask
layer before the call into m_graphicsLayer->setMaskLayer(), which would
try to call functions on the old mask. Fix by clearing the mask layer
on the GraphicsLayer before the mask layer gets destroyed.

Test: compositing/masks/toggle-mask.html

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::RenderLayerBacking::updateMaskLayer):

• rendering/RenderLayerBacking.h:

LayoutTests:
Test that toggles the mask on a composited element.

• compositing/masks/toggle-mask-expected.txt: Added.
• compositing/masks/toggle-mask.html: Added.

1:54 PM Changeset in webkit [170202] by andersca@apple.com

• 2 edits in trunk/Source/WTF

Add copy/move constructors and assignment operators to WTF::Optional
​https://bugs.webkit.org/show_bug.cgi?id=134119

Reviewed by Andreas Kling.

• wtf/Optional.h:

(WTF::Optional::Optional):
(WTF::Optional::operator=):

1:48 PM Changeset in webkit [170201] by akling@apple.com

• 4 edits in trunk/Source

[Cocoa] Release freed up blocks from the JS heap after simulated memory pressure.
<​https://webkit.org/b/134112>

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

• heap/BlockAllocator.h:

Source/WebCore:

• platform/cocoa/MemoryPressureHandlerCocoa.mm:

(WebCore::MemoryPressureHandler::install):

1:36 PM Changeset in webkit [170200] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

Remove redundant RenderLayer::computeOffsetFromRoot() function.
​https://bugs.webkit.org/show_bug.cgi?id=134088

Reviewed by Benjamin Poulain.

No change in functionality.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::computeOffsetFromRoot): Deleted.

• rendering/RenderLayer.h:

1:22 PM Changeset in webkit [170199] by Yusuke Suzuki

• 2 edits in trunk/Tools

Unreviewed. Adding myself to committers.

• Scripts/webkitpy/common/config/contributors.json:

12:16 PM Changeset in webkit [170198] by Simon Fraser

• 11 edits
  6 adds in trunk

[iOS WebKit2] Make -webkit-overflow-scrolling:touch work in iframes (breaks MSWord previews)
​https://bugs.webkit.org/show_bug.cgi?id=134085

Source/WebCore:
<rdar://problem/16440586>

Reviewed by Tim Horton.

When nodes were detached from the scrolling tree, we would previously throw away
all descendant nodes, expecting that they would be re-attached as we walk the compositing
layer tree in RenderLayerCompositor.

However, this doesn't work across frame boundaries; the subframe may never update
its compositing layers again, so would lose all its scrolling nodes.

Fix by having ScrollingStateTree::detachNode() by default set aside subframe nodes
into a hash map. On reattach, we'll look in the hash map and pull out an existing node
(with its children intact) if possible.

Tests: platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor.html

platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor.html
platform/mac-wk2/tiled-drawing/scrolling/frames/remove-coordinated-frame.html

• page/scrolling/ScrollingStateNode.cpp:

(WebCore::ScrollingStateNode::ScrollingStateNode):

• page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::attachNode):
(WebCore::ScrollingStateTree::detachNode):
(WebCore::ScrollingStateTree::clear):
(WebCore::ScrollingStateTree::removeNodeAndAllDescendants):
(WebCore::ScrollingStateTree::recursiveNodeWillBeRemoved):

• page/scrolling/ScrollingStateTree.h:
• page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::commitNewTreeState): Go back to removing the deleted
nodes from m_nodeMap first.
(WebCore::ScrollingTree::removeDestroyedNodes): There is no need for this to
actually make use of ScrollingTreeNode* any more; the ASSERT(!node->parent())
is bogus because it can fire when whole subtrees are removed, and to clear the
latched node we just need the ID.

Source/WebKit2:
<rdar://problem/16440586>

Reviewed by Tim Horton.

Add some debug-only assertions that check that the number of nodes we encoded is
the expected number.

• Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:

(WebKit::encodeNodeAndDescendants):
(WebKit::RemoteScrollingCoordinatorTransaction::encode):

LayoutTests:

Reviewed by Tim Horton.

Tests that add and remove a fixed container of a scroll-coordinated iframe.

• platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-expected.txt:
• platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor-expected.txt: Added.
• platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor.html: Added.
• platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-in-fixed-expected.txt:
• platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor-expected.txt: Added.
• platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor.html: Added.
• platform/mac-wk2/tiled-drawing/scrolling/frames/remove-coordinated-frame-expected.txt: Added.
• platform/mac-wk2/tiled-drawing/scrolling/frames/remove-coordinated-frame.html: Added.
• platform/mac-wk2/tiled-drawing/scrolling/frames/resources/doc-with-sticky.html:

12:14 PM Changeset in webkit [170197] by Simon Fraser

• 9 edits in trunk/Source

Handle scrolling tree modifications which remove intermediate nodes
​https://bugs.webkit.org/show_bug.cgi?id=134082

Reviewed by Tim Horton.

When updating the scrolling tree from the state tree, we failed to maintain
the children arrays correctly. Fix by removing all children on scrolling nodes,
and allowing the calls on children to add them back. A temporary hash map
keeps the nodes alive.

The state tree's m_nodesRemovedSinceLastCommit was also made into a HashSet,
to make it easier to handle removal followed by re-insertion.

Source/WebCore:

• WebCore.exp.in:
• page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::attachNode): If a node is (possibly re-)added,
remove it from m_nodesRemovedSinceLastCommit.remove.
(WebCore::ScrollingStateTree::willRemoveNode):
(WebCore::ScrollingStateTree::setRemovedNodes):

• page/scrolling/ScrollingStateTree.h:

(WebCore::ScrollingStateTree::removedNodes):

• page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::commitNewTreeState):
(WebCore::ScrollingTree::updateTreeFromStateNode): Clean up to have only one call
to updateBeforeChildren(), and remove all children from the scrolling node
before visiting state children.
(WebCore::ScrollingTree::removeDestroyedNodes): It was very wrong to assume
that all non-root nodes were parented in the root! Now we don't need to
remove from the parent anyway.

• page/scrolling/ScrollingTree.h:
• page/scrolling/ScrollingTreeNode.h:

(WebCore::ScrollingTreeNode::children):

Source/WebKit2:

• Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:

(WebKit::RemoteScrollingCoordinatorTransaction::decode):
(WebKit::RemoteScrollingTreeTextStream::dump):

12:14 PM Changeset in webkit [170196] by Simon Fraser

• 29 edits in trunk/Source

Make ScrollingTreeNodes refounted, for easier tree reconfiguration
​https://bugs.webkit.org/show_bug.cgi?id=134075

Reviewed by Tim Horton.

Make ScrollingTreeNode be ref-counted.

Source/WebCore:

• page/scrolling/AsyncScrollingCoordinator.h:
• page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::handleWheelEvent):
(WebCore::ScrollingTree::updateTreeFromStateNode):

• page/scrolling/ScrollingTree.h:

(WebCore::ScrollingTree::rootNode):

• page/scrolling/ScrollingTreeNode.cpp:

(WebCore::ScrollingTreeNode::appendChild):

• page/scrolling/ScrollingTreeNode.h:
• page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::createNode):

• page/scrolling/ThreadedScrollingTree.h:
• page/scrolling/ios/ScrollingCoordinatorIOS.h:
• page/scrolling/ios/ScrollingCoordinatorIOS.mm:

(WebCore::ScrollingCoordinatorIOS::createScrollingTreeNode):

• page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.h:
• page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.mm:

(WebCore::ScrollingTreeFrameScrollingNodeIOS::create):

• page/scrolling/ios/ScrollingTreeIOS.cpp:

(WebCore::ScrollingTreeIOS::createNode):

• page/scrolling/ios/ScrollingTreeIOS.h:
• page/scrolling/mac/ScrollingCoordinatorMac.h:
• page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::createScrollingTreeNode):

• page/scrolling/mac/ScrollingTreeFixedNode.h:
• page/scrolling/mac/ScrollingTreeFixedNode.mm:

(WebCore::ScrollingTreeFixedNode::create):

• page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h:
• page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:

(WebCore::ScrollingTreeFrameScrollingNodeMac::create):

• page/scrolling/mac/ScrollingTreeStickyNode.h:
• page/scrolling/mac/ScrollingTreeStickyNode.mm:

(WebCore::ScrollingTreeStickyNode::create):

Source/WebKit2:

• UIProcess/Scrolling/RemoteScrollingTree.cpp:

(WebKit::RemoteScrollingTree::createNode):

• UIProcess/Scrolling/RemoteScrollingTree.h:
• UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.h:
• UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:

(WebKit::ScrollingTreeOverflowScrollingNodeIOS::create):

• WebProcess/Scrolling/RemoteScrollingCoordinator.h:
• WebProcess/Scrolling/RemoteScrollingCoordinator.mm:

(WebKit::RemoteScrollingCoordinator::createScrollingTreeNode):

12:05 PM Changeset in webkit [170195] by mitz@apple.com

• 3 edits in trunk/Source/WebKit2

[Cocoa] No way to get the MIME type of the main frame
​https://bugs.webkit.org/show_bug.cgi?id=134111

Reviewed by Anders Carlsson.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _MIMEType]): Added. Returns the MIME type of the main frame, or nil.

• UIProcess/API/Cocoa/WKWebViewPrivate.h:

11:32 AM Changeset in webkit [170194] by timothy_horton@apple.com

• 8 edits in trunk/Tools

Make WebKit2 more accessible in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=134099

Reviewed by Anders Carlsson.

• MiniBrowser/mac/AppDelegate.h:
• MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate newWindow:]):
(-[BrowserAppDelegate applicationDidFinishLaunching:]):
(-[BrowserAppDelegate toggleUseWebKit2ByDefault:]):
(-[BrowserAppDelegate _useWebKit2ByDefault]):
(-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
(-[BrowserAppDelegate validateMenuItem:]):

• MiniBrowser/mac/MainMenu.xib:

Add a "Use WebKit2 By Default" menu item to the top of the Debug menu.
When switched on, Cmd-N will make WebKit2 windows (and the default window will be WebKit2).
Make the non-default new-window menu item always show up, because people often don't find it
when you have to press option to have it show up.

• MiniBrowser/mac/BrowserWindowController.h:
• MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController initWithWindow:]):

• MiniBrowser/mac/WK1BrowserWindowController.m:

(-[WK1BrowserWindowController validateMenuItem:]):

• MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController validateMenuItem:]):
Use the cached [menuItem action] like the earlier cases do.

11:29 AM Changeset in webkit [170193] by enrica@apple.com

• 3 edits in trunk/Source/WebCore

iOS build fix after ​http://trac.webkit.org/changeset/170167.

Reviewed by Geoff Garen.

• bindings/js/JSDeviceMotionEventCustom.cpp:
• bindings/js/JSDeviceOrientationEventCustom.cpp:

10:58 AM Changeset in webkit [170192] by Joseph Pecoraro

• 2 edits in trunk/Source/WebKit2

[iOS]: Overrelease of RetainPtr object in file upload
​https://bugs.webkit.org/show_bug.cgi?id=134072

Reviewed by Brady Eidson.

This ivar is a RetainPtr, the release will be done automatically
for us when we assign to nil or destruct.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView fileUploadPanelDidDismiss:]):

10:57 AM Changeset in webkit [170191] by andersca@apple.com

• 2 edits
  2 adds in trunk/Source/WebKit2

Begin stubbing out new session state classes
​https://bugs.webkit.org/show_bug.cgi?id=134110

Reviewed by Geoffrey Garen.

The basic idea is that these classes will replace the data blobs representing HistoryItems
that we currently send back and forth between the web and UI processes.

• Shared/SessionState.cpp: Added.

(WebKit::HTTPBody::Element::Element):
(WebKit::HTTPBody::Element::~Element):
(WebKit::FrameState::FrameState):
(WebKit::FrameState::~FrameState):
(WebKit::PageState::PageState):
(WebKit::PageState::~PageState):

• Shared/SessionState.h: Added.

(WebKit::HTTPBody::Element::type):

• WebKit2.xcodeproj/project.pbxproj:

10:25 AM Changeset in webkit [170190] by psolanki@apple.com

• 2 edits in trunk/Source/WebCore

Enable synchronous willSendRequest on iOS
​https://bugs.webkit.org/show_bug.cgi?id=134081
<rdar://problem/17350927>

Reviewed by Andreas Kling.

We lost the call to make willSendrequest callbacks be synchronous if possible during code
refactoring. The call is present in ResourceHandleMac.mm but that code is not called when
we use the CFNetwork based loader. Call the SPI in setupRequest().

No new tests because existing tests should cover this functionality.

• platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:

(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::setupRequest):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willSendRequest):

10:20 AM Changeset in webkit [170189] by dbates@webkit.org

• 4 edits in trunk/Tools

Teach run-{safari, webkit-app} about iOS Simulator
​https://bugs.webkit.org/show_bug.cgi?id=133986

Reviewed by David Kilzer.

Extract the logic from old-run-webkit-tests to install and launch {DumpRenderTree, WebKitTestRunnerApp}.app
into general-purpose routines in webkitdirs.pm so that they can be used both by script old-run-webkit-tests
and run-safari.

• Scripts/old-run-webkit-tests:

(installAndLaunchDumpToolAppUsingNotification): Extracted logic to install and launch {DumpRenderTree,
WebKitTestRunnerApp}.app into webkitdirs::installAndLaunchIOSWebKitAppInSimulator() and modified code
to call it.
(openIPhoneSimulator): Deleted; moved logic to webkitdirs::openIOSSimulator().
(quitIPhoneSimulator): Deleted; moved logic to webkitdirs::quitIOSSimulator().

• Scripts/run-webkit-app: Modified to call runIOSWebKitApp() when the iOS simulator SDK is used

(say, by specifying the optional command-line argument --simulator). For now, die() with an error
when the iOS device SDK is used as we don't support launching an app on the device at this time.

• Scripts/webkitdirs.pm:

(xcodeSDKVersion): Added.
(setupIOSWebKitEnvironment): Added.
(installedMobileSafariBundle): Added.
(mobileSafariBundle): Added.
(plistPathFromBundle): Added.
(appIdentiferFromBundle): Added.
(appDisplayNameFromBundle): Added.
(loadIPhoneSimulatorNotificationIfNeeded): Added.
(openIOSSimulator): Added.
(quitIOSSimulator): Added.
(iosSimulatorDeviceByName): Added.
(iosSimulatorRuntime): Added.
(findOrCreateSimulatorForIOSDevice): Added.
(runIOSWebKitAppInSimulator): Added.
(installAndLaunchIOSWebKitAppInSimulator): Added.
(runIOSWebKitApp): Added.
(runSafari): Modified to call runIOSWebKitAppInSimulator() the iOS simulator SDK is used. For now,
die() with an error when the iOS device SDK is used as we don't support launching Safari on the
device at this time.

10:16 AM Changeset in webkit [170188] by andersca@apple.com

• 8 edits
  2 moves in trunk/Source/WebKit2

Rename SessionState to LegacySessionState
​https://bugs.webkit.org/show_bug.cgi?id=134107

Reviewed by Dan Bernstein.

• Shared/LegacySessionState.cpp: Renamed from Source/WebKit2/Shared/SessionState.cpp.

(IPC::ArgumentCoder<RefPtr<T>>::encode):
(IPC::ArgumentCoder<RefPtr<T>>::decode):
(WebKit::LegacySessionState::LegacySessionState):
(WebKit::LegacySessionState::isEmpty):
(WebKit::LegacySessionState::encode):
(WebKit::LegacySessionState::decode):

• Shared/LegacySessionState.h: Renamed from Source/WebKit2/Shared/SessionState.h.

(WebKit::LegacySessionState::list):
(WebKit::LegacySessionState::currentIndex):

• Shared/WebPageCreationParameters.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):

• UIProcess/cf/WebPageProxyCF.cpp:

(WebKit::WebPageProxy::restoreFromSessionStateData):

• WebKit2.xcodeproj/project.pbxproj:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::restoreSession):
(WebKit::WebPage::restoreSessionAndNavigateToCurrentItem):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

9:35 AM Changeset in webkit [170187] by andersca@apple.com

• 4 edits
  2 adds in trunk

Add WTF::Optional class
​https://bugs.webkit.org/show_bug.cgi?id=134083

Reviewed by Andreas Kling.

Source/WTF:

• WTF.xcodeproj/project.pbxproj:
• wtf/Optional.h: Added.

(WTF::Optional::Optional):
(WTF::Optional::~Optional):
(WTF::Optional::operator bool):
(WTF::Optional::value):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WTF/Optional.cpp: Added.

(TestWebKitAPI::TEST):

8:39 AM Changeset in webkit [170186] by Ion Rosca

• 2 edits in trunk/Tools

Adding myself to Commiters list.

6:47 AM Changeset in webkit [170185] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Document the underlying types of the WKWindowFeatures rect properties
​https://bugs.webkit.org/show_bug.cgi?id=134103

Reviewed by Dan Bernstein.

• UIProcess/API/Cocoa/WKWindowFeatures.h:

3:24 AM Changeset in webkit [170184] by Carlos Garcia Campos

• 3 edits in trunk/Source/WebCore

[GTK] Do not build quota files when QUOTA is disabled
​https://bugs.webkit.org/show_bug.cgi?id=134101

Reviewed by Philippe Normand.

• CMakeLists.txt: Remove exception for GTK+ that is no longer

required since r170173.

• PlatformGTK.cmake: Generate GObject DOM bindings for Quota when enabled.

1:49 AM Changeset in webkit [170183] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebKit2

PluginProcessMainUnix should only scan for plugins when X11 plugin architecture is enabled
​https://bugs.webkit.org/show_bug.cgi?id=134098

Reviewed by Carlos Garcia Campos.

• PluginProcess/unix/PluginProcessMainUnix.cpp: Guard the call to NetscapePluginModule::scanPlugin()

with PLUGIN_ARCHITECTURE(X11) since the declaration has the same build guard. In case the X11 plugin
architecture is not enabled the program exits with EXIT_FAILURE.

1:28 AM Changeset in webkit [170182] by Manuel Rego Casasnovas

• 4 edits in trunk/Source/WebCore

[CSS Grid Layout] Add GridSpan::iterator
​https://bugs.webkit.org/show_bug.cgi?id=134058

Reviewed by Bem Jones-Bey.

Once that GridResolvedPosition has been introduced in r169934, this
patch adds a GridSpan::iterator which allows to simplify the loops over
GridResolvedPositions.
From now on we could use range-based for loops.

No new tests as it is already covered by current tests
(fast/css-grid-layout/).

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computeNormalizedFractionBreadth): Change loop to
ranged-based for.
(WebCore::RenderGrid::insertItemIntoGrid): Ditto.
(WebCore::RenderGrid::gridAreaBreadthForChild): Ditto.

• rendering/style/GridCoordinate.h: Define GridSpan::iterator.

(WebCore::GridSpan::begin): Return resolved initial position.
(WebCore::GridSpan::end): Return next to resolved final position.

• rendering/style/GridResolvedPosition.h:

(WebCore::GridResolvedPosition::operator*): Add operator required by
range-based for loops.
(WebCore::GridResolvedPosition::operator!=): Add not equal operator.

12:55 AM Changeset in webkit [170181] by Csaba Osztrogonác

• 2 edits in trunk/Tools

[EFL] Add gstreamer as dependecy of EFL after r169785
​https://bugs.webkit.org/show_bug.cgi?id=134066

Patch by Eva Balazsfalvi <​evab.u-szeged@partner.samsung.com> on 2014-06-20
Reviewed by Gyuyoung Kim.

• efl/jhbuild.modules:

12:35 AM Changeset in webkit [170180] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

Unreviewed. Fix GTK+ debug build after r170174.

• bindings/gobject/WebKitDOMNodeFilter.cpp:

(WebKit::nodeFilterObjectDestroyedCallback):

12:33 AM Changeset in webkit [170179] by timothy_horton@apple.com

• 15 edits in trunk/Source

LayerPool’d PlatformCALayerRemote/RemoteLayerBackingStore can have stale context pointers
​https://bugs.webkit.org/show_bug.cgi?id=134050
<rdar://problem/17315114>

Reviewed by Simon Fraser.

• WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::recursiveBuildTransaction):
(WebKit::PlatformCALayerRemote::layerPool):

• WebProcess/WebPage/mac/PlatformCALayerRemote.h:
• WebProcess/WebPage/mac/RemoteLayerTreeContext.h:

(WebKit::RemoteLayerTreeContext::layerPool):

• WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::buildTransaction):
Ensure that layers being committed are always in the context that is committing them.
Use a LayerPool per RemoteLayerTreeContext, to avoid moving layers between contexts.

• WebCore.exp.in:
• WebCore.xcodeproj/project.pbxproj:
• platform/cocoa/MemoryPressureHandlerCocoa.mm:

(WebCore::MemoryPressureHandler::platformReleaseMemory):
Drain all LayerPools upon memory pressure.

• platform/graphics/ca/LayerPool.cpp:

(WebCore::LayerPool::LayerPool):
(WebCore::LayerPool::~LayerPool):
(WebCore::LayerPool::allLayerPools):
(WebCore::LayerPool::sharedPool): Deleted.

• platform/graphics/ca/LayerPool.h:
• platform/graphics/ca/PlatformCALayer.cpp:

(WebCore::PlatformCALayer::createCompatibleLayerWithSize):
Add createCompatibleLayerWithSize, which optionally tries to take said layer from the LayerPool.

(WebCore::PlatformCALayer::moveToLayerPool):
Add moveToLayerPool, which moves the layer to the LayerPool.

(WebCore::PlatformCALayer::layerPool):
The LayerPool for each layer is obtained via PlatformCALayer::layerPool(), which subclasses can override for special behaviors.
The base class uses a global LayerPool.

• platform/graphics/ca/PlatformCALayer.h:
• platform/graphics/ca/TileController.cpp:

(WebCore::TileController::createTileLayer):

• platform/graphics/ca/TileGrid.cpp:

(WebCore::TileGrid::removeTiles):

12:31 AM Changeset in webkit [170178] by timothy_horton@apple.com

• 4 edits in trunk/Source/WebKit2

WKContentViewInteraction isn't cleaned up when the Web Content process crashes
​https://bugs.webkit.org/show_bug.cgi?id=134080
<rdar://problem/17387652> and <rdar://problem/16848360>

Reviewed by Benjamin Poulain.

• UIProcess/ios/WKContentView.mm:

(-[WKContentView _processDidExit]):
Tear down WKContentViewInteraction when the process crashes.

(-[WKContentView _didRelaunchProcess]):
Set WKContentViewInteraction back up when the process is relaunched.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView cleanupInteraction]):
Clear the SmartMagnificationController, which is a message receiver and thus must be re-created with the new page.
Remove all gesture recognizers from the content view.
Clear _fileUploadPanel, else we'll get an assert the next time we try to open one.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::resetStateAfterProcessExited):
Give the PageClient a chance to clean up *before* we clean up internals;
it is at a higher level and some cleanup depends on WebPageProxy members
not having been cleared yet.

12:10 AM Changeset in webkit [170177] by ryuan.choi@samsung.com

• 3 edits in trunk/Tools

[EFL] Merge url_utils.c to MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=134095

Reviewed by Csaba Osztrogonác.

url_utils.c is simple code to share between EWebLauncher and MiniBrowser.
This patch removes the dependency of url_utils.c from MiniBrowser to drop WebKit1 EFL port.

• MiniBrowser/efl/CMakeLists.txt:

Remove the EWebLauncher/ from the includes and url_utils.h from the source lists.

• MiniBrowser/efl/main.c:

(has_scheme): Copied from url_utils.c
(url_from_user_input): Ditto.

12:00 AM Changeset in webkit [170176] by Csaba Osztrogonác

• 4 edits in trunk/Tools

Fix webkitpy tests after EFL WK1 buildbot and EWS removal - r170172.

Patch by Eva Balazsfalvi <​evab.u-szeged@partner.samsung.com> on 2014-06-19
Reviewed by Csaba Osztrogonác.

• Scripts/webkitpy/common/config/ports_unittest.py:

(DeprecatedPortTest.test_gtk_wk2_port):
(DeprecatedPortTest.test_efl_port): Deleted.

• Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

(TestExpectationsTestCase.test_determine_port_from_expectations_path):

• Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaselineExpectations.test_rebaseline_expectations):

Jun 19, 2014:

11:52 PM Changeset in webkit [170175] by ryuan.choi@samsung.com

• 4 edits in trunk

[EFL][CMAKE] Disable WebKit1 build as a default
​https://bugs.webkit.org/show_bug.cgi?id=134093

Reviewed by Gyuyoung Kim.

.:
Disable WebKit1 build and enable WebKit2 build for the EFL port.

• Source/cmake/OptionsEfl.cmake:

Tools:

• CMakeLists.txt:

11:44 PM Changeset in webkit [170174] by Carlos Garcia Campos

• 7 edits
  8 adds in trunk

[GTK] webkit_dom_document_create_tree_walker impossible to use due to WebKitDOMNodeFilter
​https://bugs.webkit.org/show_bug.cgi?id=93002

Reviewed by Gustavo Noronha Silva.

Source/WebCore:
Add custom implementation of WebKitDOMNodeFilter to expose it as
an interface instead of a class.

• PlatformGTK.cmake: Add new files to compilation.
• bindings/gobject/GObjectNodeFilterCondition.cpp: Added.

(WebCore::GObjectNodeFilterCondition::~GObjectNodeFilterCondition):
Reset the NodeFilter WebCore object associated to the
WebKitDOMNodeFilter object.
(WebCore::GObjectNodeFilterCondition::acceptNode): Call webkit_dom_node_filter_accept_node().

• bindings/gobject/GObjectNodeFilterCondition.h: Added.

(WebCore::GObjectNodeFilterCondition::create): Create a new
GObjectNodeFilterCondition for the given WebKitDOMNodeFilter.
(WebCore::GObjectNodeFilterCondition::GObjectNodeFilterCondition):

• bindings/gobject/WebKitDOMNodeFilter.cpp: Added.

(webkit_dom_node_filter_default_init):
(webkit_dom_node_filter_accept_node):
(WebKit::nodeFilterMap): Map NodeFilter WebCore objects to
WebKitDOMNodeFilter objects.
(WebKit::nodeFilterObjectDestroyedCallback): Remove the node
filter form the map when the WebKitDOMNodeFilter objecrt is destroyed.
(WebKit::kit): Return the WebKitDOMNodeFilter object for the given
NodeFilter WebCore object.
(WebKit::core): Get or create a NodeFilter WebCore object
associated to the given WebKitDOMNodeFilter.

• bindings/gobject/WebKitDOMNodeFilter.h: Added.
• bindings/gobject/WebKitDOMNodeFilter.symbols: Added.
• bindings/gobject/WebKitDOMNodeFilterPrivate.h: Added.
• bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunction): Add exceptions for NodeFilter parameters since
the core method returns a PassRefPtr.

Tools:
Add unit tests to check WebKitDOMNodefilter API used from both
TreeWalker and NodeIterator.

• Scripts/webkitpy/style/checker.py: Add exceptions for GTK+

public headers and add WebKitDOMNodeFilter to the list of exceptions.

• TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add new files to compilation.
• TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp: Added.

(webkitNodeFilterAcceptNode):
(webkitNodeFilterDOMNodeFilterIfaceInit):
(webkit_node_filter_init):
(webkit_node_filter_class_init):
(WebKitDOMNodeFilterTest::create):
(WebKitDOMNodeFilterTest::webPageFromArgs):
(WebKitDOMNodeFilterTest::testTreeWalker):
(WebKitDOMNodeFilterTest::testNodeIterator):
(WebKitDOMNodeFilterTest::runTest):
(registerTests):

• TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp: Added.

(runTest):
(testWebKitDOMNodeFilterTreeWalker):
(testWebKitDOMNodeFilterNodeIterator):
(beforeAll):
(afterAll):

• gtk/webkitdom.py:

(WebKitDOMDocGeneratorSections.init):
(WebKitDOMDocGeneratorSections._symbol_list):
(WebKitDOMDocGeneratorSections.write_section):

11:24 PM Changeset in webkit [170173] by Carlos Garcia Campos

• 29 edits in trunk

[GTK] Limit the amount of API exposed to GObject DOM bindings API
​https://bugs.webkit.org/show_bug.cgi?id=133726

Reviewed by Gustavo Noronha Silva.

Source/WebCore:
Split the GObject DOM bindings API into stable and unstable. The
unstable API is not included in the main webkitdom.h file, so that
to use it users have to include the headers individually and
define a macro WEBKIT_DOM_USE_UNSTABLE_API. For unstable methods
of stable classes we generate a {ClassName}Unstable.h header file
containing the unstable API. From now on we only keep backwards
compatibility for the stable API.

• PlatformGTK.cmake: Split GObject DOM bindings related variables

into Stable and Unstable. Add also

• bindings/gobject/WebKitDOMCustom.cpp:

(webkit_dom_html_media_element_set_current_time): Deleted.
(webkit_dom_text_track_get_kind): Deleted.
(webkit_dom_text_track_get_mode): Deleted.
(webkit_dom_text_track_set_mode): Deleted.

• bindings/gobject/WebKitDOMCustom.h:
• bindings/gobject/WebKitDOMCustom.symbols: Remove custom symbols

added due to API changes.

• bindings/gobject/WebKitDOMPrivate.h: Include webkitdomdefines-unstable.h.
• bindings/gobject/webkitdom.symbols: Remove all unstable symbols.
• bindings/scripts/CodeGeneratorGObject.pm:

(SkipFunction): Do not skip webkit_dom_html_media_element_set_current_time anymore.
(GenerateHeader): Only force single header include for stable
headers and add WEBKIT_DOM_USE_UNSTABLE_API #ifdef to unstable headers.
(GenerateFunction): Only add stable symbols to the symbols
array. Add function prototypes to main header or unstable header
depending on whether it's an unstable symbol for a stable class or
not. Also add Stability gtk-doc tag to unstable methods.
(GenerateEndHeader): Add required #endifs
(WriteData): Write also an Unstable.h header when appropriate and
only generate a symbols file for stable classes.
(ReadStableSymbols): Read the stable symbols for the current class.
(GenerateInterface): Call ReadStableSymbols.

• bindings/scripts/gobject-generate-headers.pl: Generate webkitdomdefines-unstable.h.
• bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h:
• bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
• bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h:
• bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.h:
• bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:
• bindings/scripts/test/GObject/WebKitDOMTestException.h:
• bindings/scripts/test/GObject/WebKitDOMTestGenerateIsReachable.h:
• bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
• bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
• bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.h:
• bindings/scripts/test/GObject/WebKitDOMTestNode.h:
• bindings/scripts/test/GObject/WebKitDOMTestNondeterministic.h:
• bindings/scripts/test/GObject/WebKitDOMTestObj.h:
• bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.h:
• bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
• bindings/scripts/test/GObject/WebKitDOMTestTypedefs.h:
• bindings/scripts/test/GObject/WebKitDOMattribute.h:
• bindings/scripts/test/GObject/WebKitDOMreadonly.h:

Tools:
Don't make fatal finding files without a .symbols file, since now
only the stable DOM API has .symbols files.

• gtk/webkitdom.py:

(get_all_webkitdom_symbol_files):

7:56 PM Changeset in webkit [170172] by gyuyoung.kim@samsung.com

• 8 edits in trunk/Tools

Remove efl wk1 buildbot and ews
​https://bugs.webkit.org/show_bug.cgi?id=134089

Reviewed by Benjamin Poulain.

EFL WK1 is not supported anymore. Removed all bots for EFL WK1 bots.

• BuildSlaveSupport/build.webkit.org-config/config.json:
• QueueStatusServer/config/queues.py:
• Scripts/webkitpy/common/config/ews.json:
• Scripts/webkitpy/common/config/ports.py:

(DeprecatedPort.port):
(QtWK2Port.run_webkit_tests_command):
(EflPort): Deleted.
(EflPort.build_webkit_command): Deleted.

• Scripts/webkitpy/port/builders.py:
• TestResultServer/static-dashboards/flakiness_dashboard.js:
• TestResultServer/static-dashboards/loader_unittests.js:

7:12 PM Changeset in webkit [170171] by achristensen@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed fix after r170130.

• JavaScriptCore.vcxproj/libllvmForJSC/libllvmForJSC.vcxproj:

Corrected directory so it can find common.props when opening Visual Studio.

6:39 PM Changeset in webkit [170170] by mitz@apple.com

• 3 edits in trunk/Source/WebKit2

Removed unused SPI -[WKWebView _runJavaScriptInMainFrame:].

Rubber-stamped by Simon Fraser.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _runJavaScriptInMainFrame:]): Deleted.

• UIProcess/API/Cocoa/WKWebViewPrivate.h:

6:31 PM Changeset in webkit [170169] by akling@apple.com

• 2 edits in trunk/Source/WebCore

When simulating memory pressure, GC *after* releasing WebCore resources.

Since clearing the page cache is likely to create lots of garbage, defer the
synchronous GC until after the WebCore pressure relief, so we can see the
effect of clearing out all those pages.

Rubber-stamped by Gavin Barraclough.

• platform/cocoa/MemoryPressureHandlerCocoa.mm:

(WebCore::MemoryPressureHandler::install):

5:49 PM Changeset in webkit [170168] by mitz@apple.com

• 5 edits in trunk/Source/WebKit2

Use a single map for all callback types in WebPageProxy
​https://bugs.webkit.org/show_bug.cgi?id=134069

Reviewed by Tim Horton.

• UIProcess/GenericCallback.h:

(WebKit::CallbackMap::take):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::printFinishedCallback):
(WebKit::WebPageProxy::resetState):
(WebKit::WebPageProxy::drawPagesForPrinting):

• UIProcess/WebPageProxy.h:
• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::attributedSubstringForCharacterRangeAsync):
(WebKit::WebPageProxy::attributedStringForCharacterRangeCallback):

4:42 PM Changeset in webkit [170167] by weinig@apple.com

• 86 edits in trunk/Source/WebCore

Move generate prototype and constructor classes into the generated implementation files
​https://bugs.webkit.org/show_bug.cgi?id=134054

Reviewed by Oliver Hunt.

In an effort to reduce the size of the generated bindings headers, which is important
as the generated headers get included in a lot of places, this patch moves the prototype
and constructor declarations from the header to implementation file. This works because,
for the most part, no code cares about the prototype or constructors except the instance.

There are a few exceptions which had to be accounted for:

• The global objects (JSDOMWindow and JSWorkerGlobalScope) need to have their prototypes available during initialization, so they remain in the header.
• JSLocation requires customizing some aspects of the prototype behavior, so its prototype, and any future class that uses JSCustomNamedGetterOnPrototype or JSCustomDefineOwnPropertyOnPrototype, remains in the header.
• A few classes had custom constructor functions. Instead of keeping the entire constructor in the header, I opted for pulling just the static constructor function into the header, and modifying the custom constructors to use the DOMConstructorObject type as the callee, since the more specific type was unnecessary.

As a result of making these changes, I was also able to remove the #include of JSDOMBinding.h from
all the headers, which brought in quite a bit.

• bindings/js/JSAudioContextCustom.cpp:

(WebCore::constructJSAudioContext):
(WebCore::JSAudioContextConstructor::constructJSAudioContext): Deleted.

• bindings/js/JSBlobCustom.cpp:

(WebCore::constructJSBlob):
(WebCore::JSBlobConstructor::constructJSBlob): Deleted.

• bindings/js/JSCryptoCustom.cpp:
• bindings/js/JSDOMFormDataCustom.cpp:

(WebCore::constructJSDOMFormData):
(WebCore::JSDOMFormDataConstructor::constructJSDOMFormData): Deleted.

• bindings/js/JSDOMMimeTypeArrayCustom.cpp:
• bindings/js/JSDOMPluginArrayCustom.cpp:
• bindings/js/JSDOMPluginCustom.cpp:
• bindings/js/JSDataCueCustom.cpp:

(WebCore::constructJSDataCue):
(WebCore::JSDataCueConstructor::constructJSDataCue): Deleted.

• bindings/js/JSDataTransferCustom.cpp:
• bindings/js/JSEventCustom.cpp:
• bindings/js/JSFileReaderCustom.cpp:
• bindings/js/JSHistoryCustom.cpp:
• bindings/js/JSIDBAnyCustom.cpp:
• bindings/js/JSIDBDatabaseCustom.cpp:
• bindings/js/JSIDBObjectStoreCustom.cpp:
• bindings/js/JSImageConstructor.cpp:

(WebCore::JSImageConstructor::finishCreation):

• bindings/js/JSImageDataCustom.cpp:
• bindings/js/JSInspectorFrontendHostCustom.cpp:
• bindings/js/JSLocationCustom.cpp:
• bindings/js/JSMessagePortCustom.cpp:
• bindings/js/JSMutationObserverCustom.cpp:

(WebCore::constructJSMutationObserver):
(WebCore::JSMutationObserverConstructor::constructJSMutationObserver): Deleted.

• bindings/js/JSSQLResultSetRowListCustom.cpp:
• bindings/js/JSSQLTransactionSyncCustom.cpp:
• bindings/js/JSSVGLengthCustom.cpp:
• bindings/js/JSSharedWorkerCustom.cpp:

(WebCore::constructJSSharedWorker):
(WebCore::JSSharedWorkerConstructor::constructJSSharedWorker): Deleted.

• bindings/js/JSStorageCustom.cpp:
• bindings/js/JSUserMessageHandlersNamespaceCustom.cpp:
• bindings/js/JSWebKitPointCustom.cpp:

(WebCore::constructJSWebKitPoint):
(WebCore::JSWebKitPointConstructor::constructJSWebKitPoint): Deleted.

• bindings/js/JSWorkerCustom.cpp:

(WebCore::constructJSWorker):
(WebCore::JSWorkerConstructor::constructJSWorker): Deleted.

• bindings/js/SerializedScriptValue.cpp:
• bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(GeneratePrototypeDeclaration):
(GenerateConstructorDeclaration):
(GenerateConstructorHelperMethods):
(HeaderNeedsPrototypeDeclaration):

• bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
• bindings/scripts/test/JS/JSTestActiveDOMObject.h:
• bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
• bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
• bindings/scripts/test/JS/JSTestEventConstructor.cpp:
• bindings/scripts/test/JS/JSTestEventConstructor.h:
• bindings/scripts/test/JS/JSTestEventTarget.cpp:
• bindings/scripts/test/JS/JSTestEventTarget.h:
• bindings/scripts/test/JS/JSTestException.cpp:
• bindings/scripts/test/JS/JSTestException.h:
• bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
• bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
• bindings/scripts/test/JS/JSTestInterface.cpp:
• bindings/scripts/test/JS/JSTestInterface.h:
• bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
• bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
• bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
• bindings/scripts/test/JS/JSTestNamedConstructor.h:
• bindings/scripts/test/JS/JSTestNode.cpp:
• bindings/scripts/test/JS/JSTestNode.h:
• bindings/scripts/test/JS/JSTestNondeterministic.cpp:
• bindings/scripts/test/JS/JSTestNondeterministic.h:
• bindings/scripts/test/JS/JSTestObj.cpp:
• bindings/scripts/test/JS/JSTestObj.h:
• bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
• bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
• bindings/scripts/test/JS/JSTestTypedefs.cpp:
• bindings/scripts/test/JS/JSTestTypedefs.h:
• bindings/scripts/test/JS/JSattribute.cpp:
• bindings/scripts/test/JS/JSattribute.h:
• bindings/scripts/test/JS/JSreadonly.cpp:
• bindings/scripts/test/JS/JSreadonly.h:

3:57 PM Changeset in webkit [170166] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Another build fix attempt.

• Shared/API/Cocoa/WKFoundation.h:

3:50 PM Changeset in webkit [170165] by mitz@apple.com

• 3 edits in trunk/Source/WebKit2

[iOS] Legacy processes are installed inside WebKit.framework
​https://bugs.webkit.org/show_bug.cgi?id=134079

Reviewed by Anders Carlsson.

• Configurations/All.xcconfig: Exclude the legacy processes on iOS so they don’t get copied.
• Configurations/BaseLegacyProcess.xcconfig: Set SKIP_INSTALL to YES on iOS.

3:23 PM Changeset in webkit [170164] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

It's OS X, not OSX...

• Shared/API/Cocoa/WKFoundation.h:

3:15 PM Changeset in webkit [170163] by Antti Koivisto

• 4 edits in trunk/Source/WebKit2

Unfreeze the layer tree on DidFirstVisuallyNonEmptyLayout
​https://bugs.webkit.org/show_bug.cgi?id=134073

Reviewed by Simon Fraser.

DidFirstLayout is too early and we usually get a blank page. This doesn't match the existing iOS behavior either.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidLayout):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

3:04 PM Changeset in webkit [170162] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Try to fix the Mavericks build.

• Shared/API/Cocoa/WKFoundation.h:

2:51 PM Changeset in webkit [170161] by fpizlo@apple.com

• 2 edits in branches/ftlopt/Source/JavaScriptCore

[ftlopt] StructureSet::onlyStructure() should return nullptr if it's not a singleton (instead of asserting)
​https://bugs.webkit.org/show_bug.cgi?id=134077

Reviewed by Sam Weinig.

This makes StructureSet and StructureAbstractValue more consistent and fixes a debug assert
in the abstract interpreter.

• bytecode/StructureSet.h:

(JSC::StructureSet::onlyStructure):

1:54 PM Changeset in webkit [170160] by weinig@apple.com

• 3 edits in trunk/Source/WebKit2

[Cocoa] Need SPI to determine if the WKWebView is displaying a standalone image
​https://bugs.webkit.org/show_bug.cgi?id=134071

Reviewed by Anders Carlsson.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _isDisplayingStandaloneImageDocument]):

• UIProcess/API/Cocoa/WKWebViewPrivate.h:

1:47 PM Changeset in webkit [170159] by fpizlo@apple.com

• 1 edit
  6 adds in branches/ftlopt/LayoutTests

[ftlopt] LICM should be able to hoist CheckStructure even if the loop clobbers structures so long as the structures being checked are watchable
​https://bugs.webkit.org/show_bug.cgi?id=134056

Unreviewed, just landing the test cases for this attempted optimization. The test cases
will still be valid once we find a smart way of doing this optimization.

• js/regress/hoist-poly-check-structure-effectful-loop-expected.txt: Added.
• js/regress/hoist-poly-check-structure-effectful-loop.html: Added.
• js/regress/hoist-poly-check-structure-expected.txt: Added.
• js/regress/hoist-poly-check-structure.html: Added.
• js/regress/script-tests/hoist-poly-check-structure-effectful-loop.js: Added.

(foo):
(test):

• js/regress/script-tests/hoist-poly-check-structure.js: Added.

(foo):
(test):

12:59 PM Changeset in webkit [170158] by mitz@apple.com

• 5 edits in trunk/Source/WebKit2

Use a single map for all callback types in WebPageProxy
​https://bugs.webkit.org/show_bug.cgi?id=134069

Reviewed by Anders Carlsson.

• UIProcess/GenericCallback.h:

(WebKit::CallbackBase::as): Added. Performs a dynamic cast to a specific callback type.
(WebKit::CallbackBase::CallbackBase): Added a type parameter, which is used to initialize
the new m_type member.
(WebKit::GenericCallback::GenericCallback): Pass the type to the base class constructor.
(WebKit::GenericCallback::type): Added. Returns a unique type.
(WebKit::GenericCallback::invalidate): Now virtual.

(WebKit::CallbackMap::put): Adds the callback to the map.
(WebKit::CallbackMap::take): Removes the callback from the map, and dynamically casts it to
the specified type.
(WebKit::CallbackMap::invalidate): Invalidates the map.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::validateCommand):
(WebKit::WebPageProxy::runJavaScriptInMainFrame):
(WebKit::WebPageProxy::getRenderTreeExternalRepresentation):
(WebKit::WebPageProxy::getSourceForFrame):
(WebKit::WebPageProxy::getContentsAsString):
(WebKit::WebPageProxy::getBytecodeProfile):
(WebKit::WebPageProxy::getSelectionOrContentsAsString):
(WebKit::WebPageProxy::getSelectionAsWebArchiveData):
(WebKit::WebPageProxy::getMainResourceDataOfFrame):
(WebKit::WebPageProxy::getResourceDataFromFrame):
(WebKit::WebPageProxy::getWebArchiveOfFrame):
(WebKit::WebPageProxy::forceRepaint):
(WebKit::WebPageProxy::clearLoadDependentCallbacks):
(WebKit::WebPageProxy::voidCallback):
(WebKit::WebPageProxy::dataCallback):
(WebKit::WebPageProxy::imageCallback):
(WebKit::WebPageProxy::stringCallback):
(WebKit::WebPageProxy::scriptValueCallback):
(WebKit::WebPageProxy::computedPagesCallback):
(WebKit::WebPageProxy::validateCommandCallback):
(WebKit::WebPageProxy::unsignedCallback):
(WebKit::WebPageProxy::editingRangeCallback):
(WebKit::WebPageProxy::rectForCharacterRangeCallback):
(WebKit::WebPageProxy::resetState):
(WebKit::WebPageProxy::computePagesForPrinting):
(WebKit::WebPageProxy::drawRectToImage):
(WebKit::WebPageProxy::drawPagesToPDF):
(WebKit::WebPageProxy::getMarkedRangeAsync):
(WebKit::WebPageProxy::getSelectedRangeAsync):
(WebKit::WebPageProxy::characterIndexForPointAsync):
(WebKit::WebPageProxy::firstRectForCharacterRangeAsync):
(WebKit::WebPageProxy::takeSnapshot):

• UIProcess/WebPageProxy.h:
• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::gestureCallback):
(WebKit::WebPageProxy::touchesCallback):
(WebKit::WebPageProxy::autocorrectionDataCallback):
(WebKit::WebPageProxy::dictationContextCallback):
(WebKit::WebPageProxy::autocorrectionContextCallback):
(WebKit::WebPageProxy::selectWithGesture):
(WebKit::WebPageProxy::updateSelectionWithTouches):
(WebKit::WebPageProxy::requestAutocorrectionData):
(WebKit::WebPageProxy::applyAutocorrection):
(WebKit::WebPageProxy::requestDictationContext):
(WebKit::WebPageProxy::requestAutocorrectionContext):
(WebKit::WebPageProxy::selectWithTwoTouches):

12:51 PM Changeset in webkit [170157] by andersca@apple.com

• 5 edits in trunk/Source/WebKit2

No way to handle HTTP Authentication with WKWebView
​https://bugs.webkit.org/show_bug.cgi?id=134067
<rdar://problem/17317874>

Reviewed by Dan Bernstein.

Add a public webView:didReceiveAuthenticationChallenge:completionHandler: delegate method and get rid of the SPI.

• Shared/API/Cocoa/WKFoundation.h:
• UIProcess/API/Cocoa/WKNavigationDelegate.h:
• UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
• UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::setNavigationDelegate):
(WebKit::NavigationState::LoaderClient::didReceiveAuthenticationChallengeInFrame):

12:23 PM Changeset in webkit [170156] by roger_fong@apple.com

• 6 edits in trunk/Source/WebKit2

Don't kill the UIProcess until all local storage transactions have been committed.
​https://bugs.webkit.org/show_bug.cgi?id=134042.
<rdar://problem/16660724>.

Reviewed by Anders Carlsson.

• UIProcess/API/mac/WKView.mm: Add a listener for the application will terminate notification.

(-[WKView _applicationWillTerminate:]):
(-[WKView initWithFrame:context:configuration:webView:]):

• UIProcess/WebContext.cpp: Calls code in StorageManager to cleanup local storage transactions upon application termination.

(WebKit::WebContext::applicationWillTerminate):

• UIProcess/WebContext.h:

• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::applicationWillTerminate):
Dispatch local storage cleanup task to background thread and make sure the UIProcess can't exit early.

• UIProcess/Storage/StorageManager.h:

11:56 AM Changeset in webkit [170155] by oliver@apple.com

• 2 edits in trunk/Source/WebKit2

2014-06-19 Oliver Hunt <​oliver@apple.com>

Switch to using the process parameters during initialisation
to determine whether we hsould be using the network process.

RS=Sam Weinig

• WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess):

11:33 AM Changeset in webkit [170154] by psolanki@apple.com

• 6 edits in trunk/Source/WebKit2

Copy SharedBuffer data into IPC message directly
​https://bugs.webkit.org/show_bug.cgi?id=133920

Reviewed by Anders Carlsson.

When data array callbacks are enabled, we currently merge all the CFDataRefs in SharedBuffer
into one contiguous memory buffer when creating IPC::DataReference. This patch creates a
subclass of DataReference that uses SharedBuffer::getSomeData() to copy the data directly
into the IPC message.

• NetworkProcess/AsynchronousNetworkLoaderClient.cpp:

(WebKit::AsynchronousNetworkLoaderClient::didReceiveBuffer):

• Platform/IPC/ArgumentEncoder.cpp:

(IPC::ArgumentEncoder::reserve): Added.
(IPC::ArgumentEncoder::grow):

• Platform/IPC/ArgumentEncoder.h:
• Platform/IPC/DataReference.cpp:

(IPC::SharedBufferDataReference::encode):

• Platform/IPC/DataReference.h:

(IPC::DataReference::~DataReference):

10:53 AM Changeset in webkit [170153] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[Curl] Compile errors related to http header field names.
​https://bugs.webkit.org/show_bug.cgi?id=134029

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-06-19
Reviewed by Brent Fulgham.

Http header field names should now be specified with an enum, not a string.

• platform/network/curl/MultipartHandle.cpp:

(WebCore::MultipartHandle::didReceiveResponse):

• platform/network/curl/ResourceHandleManager.cpp:

(WebCore::getProtectionSpace):

10:48 AM Changeset in webkit [170152] by ddkilzer@apple.com

• 3 edits in trunk/Tools

check-webkit-style does not understand Obj-C literal syntax for NSDictionary
<​http://webkit.org/b/134061>

Reviewed by Dan Bernstein.

• Scripts/webkitpy/style/checkers/cpp.py:

(check_spacing): Ignore '@' immediately before '{'.

• Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTest.test_spacing_before_braces): Add unit test for
'^{{' block syntax and '@{' Objective-C liternal NSDitionary
syntax.}

10:41 AM Changeset in webkit [170151] by andersca@apple.com

• 2 edits in trunk/Source/WebCore

Put the divider in the right place.

• DerivedSources.make:

10:41 AM Changeset in webkit [170150] by andersca@apple.com

• 2 edits in trunk/Source/WebCore

Address a review comment from Darin.

• inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::willLoadXHR):

10:29 AM Changeset in webkit [170149] by andersca@apple.com

• 2 edits in trunk/Source/WebKit/win

Try to fix Windows build.

• WebFrame.h:

10:29 AM Changeset in webkit [170148] by andersca@apple.com

• 3 edits in trunk/Source/WebCore

Simplify two HistoryController member functions
​https://bugs.webkit.org/show_bug.cgi?id=134064

Reviewed by Dan Bernstein.

Remove the FrameLoadType parameter from recursiveSetProvisionalItem,
use early returns and modern loops.

• loader/HistoryController.cpp:

(WebCore::HistoryController::goToItem):
(WebCore::HistoryController::recursiveSetProvisionalItem):
(WebCore::HistoryController::recursiveGoToItem):

• loader/HistoryController.h:

9:32 AM Changeset in webkit [170147] by Dániel Bátyai

• 56 edits in trunk

Remove ENABLE(LLINT) and ENABLE(LLINT_C_LOOP) guards
​https://bugs.webkit.org/show_bug.cgi?id=130389

Reviewed by Mark Lam.

Removed ENABLE(LLINT) since we always build with it, and changed ENABLE(LLINT_C_LOOP)
into !ENABLE(JIT) since they are mutually exclusive.

.:

• Source/cmake/OptionsEfl.cmake:
• Source/cmake/OptionsGTK.cmake:
• Source/cmake/WebKitFeatures.cmake:
• Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

• CMakeLists.txt:
• assembler/MacroAssemblerCodeRef.h:

(JSC::MacroAssemblerCodePtr::createLLIntCodePtr):
(JSC::MacroAssemblerCodeRef::createLLIntCodeRef):

• assembler/MaxFrameExtentForSlowPathCall.h:
• bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeFromLLInt):

• bytecode/CodeBlock.cpp:

(JSC::dumpStructure):
(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::propagateTransitions):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::unlinkCalls):
(JSC::CodeBlock::unlinkIncomingCalls):
(JSC::CodeBlock::linkIncomingCall):
(JSC::CodeBlock::frameRegisterCount):

• bytecode/CodeBlock.h:
• bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):

• bytecode/Opcode.h:

(JSC::padOpcodeName):

• bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):

• heap/Heap.cpp:

(JSC::Heap::gatherJSStackRoots):

• interpreter/Interpreter.cpp:

(JSC::Interpreter::initialize):
(JSC::Interpreter::isOpcode):

• interpreter/Interpreter.h:

(JSC::Interpreter::getOpcodeID):

• interpreter/JSStack.cpp:

(JSC::JSStack::JSStack):
(JSC::JSStack::committedByteCount):

• interpreter/JSStack.h:
• interpreter/JSStackInlines.h:

(JSC::JSStack::ensureCapacityFor):
(JSC::JSStack::topOfFrameFor):
(JSC::JSStack::setStackLimit):

• jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):

• jit/JIT.h:

(JSC::JIT::compileCTINativeCall):

• jit/JITExceptions.h:
• jit/JITThunks.cpp:

(JSC::JITThunks::ctiNativeCall):
(JSC::JITThunks::ctiNativeConstruct):

• llint/LLIntCLoop.cpp:
• llint/LLIntCLoop.h:
• llint/LLIntData.cpp:

(JSC::LLInt::initialize):
(JSC::LLInt::Data::performAssertions):

• llint/LLIntData.h:

(JSC::LLInt::Data::performAssertions): Deleted.

• llint/LLIntEntrypoint.cpp:
• llint/LLIntEntrypoint.h:
• llint/LLIntExceptions.cpp:
• llint/LLIntExceptions.h:
• llint/LLIntOfflineAsmConfig.h:
• llint/LLIntOffsetsExtractor.cpp:

(JSC::LLIntOffsetsExtractor::dummy):

• llint/LLIntOpcode.h:
• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

• llint/LLIntSlowPaths.h:
• llint/LLIntThunks.cpp:
• llint/LLIntThunks.h:
• llint/LowLevelInterpreter.cpp:
• llint/LowLevelInterpreter.h:
• runtime/CommonSlowPaths.cpp:
• runtime/CommonSlowPaths.h:
• runtime/ErrorHandlingScope.cpp:

(JSC::ErrorHandlingScope::ErrorHandlingScope):
(JSC::ErrorHandlingScope::~ErrorHandlingScope):

• runtime/Executable.cpp:

(JSC::setupLLInt):

• runtime/InitializeThreading.cpp:

(JSC::initializeThreading):

• runtime/JSCJSValue.h:
• runtime/JSCJSValueInlines.h:
• runtime/Options.cpp:

(JSC::recomputeDependentOptions):

• runtime/VM.cpp:

(JSC::VM::VM):
(JSC::sanitizeStackForVM):

• runtime/VM.h:

(JSC::VM::canUseJIT): Deleted.

Source/WTF:

• wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveAndCommit):

• wtf/Platform.h:

9:22 AM Changeset in webkit [170146] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebCore

MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL() leaks an NSMutableArray
<​http://webkit.org/b/134052>

Reviewed by Eric Carlson.

Fixes the following static analyzer warning:

WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:688:43: warning: Potential leak of an object stored into 'outOfBandTracks'

NSMutableArray* outOfBandTracks = [[NSMutableArray alloc] init];

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
Use RetainPtr<NSMutableArray> to prevent a leak. Use
Objective-C literals to clean up the code.

2:14 AM Changeset in webkit [170145] by mario.prada@samsung.com

• 3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Updated text expectations after r170138.

• platform/gtk/accessibility/image-map2-expected.txt: Updated.
• platform/gtk/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt: Updated.

12:25 AM Changeset in webkit [170144] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[EFL] Add expectations for failing svg/wicd/rightsizing-grid.xhtml layout test
​https://bugs.webkit.org/show_bug.cgi?id=133982

Unreviewed gardening.

Patch by Rohit Kumar <​kumar.rohit@samsung.com> on 2014-06-19

• platform/efl/TestExpectations: