Timeline
Jun 21, 2014:
- 10:52 PM Changeset in webkit [170260] by
-
- 2 edits in trunk/Tools
Disable gamepad feature on EFL and GTK ports by default
https://bugs.webkit.org/show_bug.cgi?id=134169
Reviewed by Brady Eidson.
EFL and GTK ports disabled Gamepad feature now. Besides current implementation
was treated to 'deprecated' status.
ENABLE_GAMEPAD_DEPRECATED is disabled for now. There is build break on EFL port.
- Scripts/webkitperl/FeatureList.pm:
- 10:50 PM Changeset in webkit [170259] by
-
- 2 edits in trunk/Source/WebCore
createCairoGLSurface should take in a FloatSize reference as its first parameter
https://bugs.webkit.org/show_bug.cgi?id=134159
Reviewed by Martin Robinson.
The ImageBuffer constructor operates with a FloatSize reference, which is also
passed to createCairoGLSurface when accelerated 2D canvas support is enabled.
That function should take in a reference to the same type.
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::createCairoGLSurface):
- 10:46 PM Changeset in webkit [170258] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Fixing the GTK+ build after r170253.
- UIProcess/API/gtk/WebKitSettings.cpp:
(_WebKitSettingsPrivate::_WebKitSettingsPrivate): WebPreferences::create()
now takes an additional String argument.
- 4:55 PM Changeset in webkit [170257] by
-
- 46 edits3 adds in trunk
[Mac] Margins for new form controls need tweaking
https://bugs.webkit.org/show_bug.cgi?id=134135
<rdar://problem/17262164>
Reviewed by Sam Weinig.
Source/WebCore:
Take 2 of this patch. Only the mac-mountainlion LayoutTest
results are different from the first attempt.
With the newer animated controls in OS X Yosemite, we need
to tweak the fudge-factor margins for positioning. In a recent
patch I added another fudge, which I'm removing with this. I'm
not sure where the older values came from, but I've checked with
the latest AppKit sources and am using the sizes they implement
for the controls.
This will rebaseline a lot of tests, since I've made small tweaks
to the form layout.
- platform/mac/ThemeMac.mm:
(WebCore::checkboxMargins): New margin amounts.
(WebCore::radioSizes): New sizes.
(WebCore::radioMargins): New margin amounts.
(WebCore::paintToggleButton): No need to call the positioning fudge any more.
(WebCore::checkboxOffsets): Deleted.
(WebCore::radioOffsets): Deleted.
LayoutTests:
Take 2 of this patch adds some Mountain Lion results.
Rebaseline a bunch of results since some <input> dimensions
changed slightly.
- platform/mac-mountainlion/fast/block/margin-collapse/103-expected.txt:
- platform/mac-mountainlion/fast/forms/basic-inputs-expected.png: Added.
- platform/mac-mountainlion/fast/forms/basic-inputs-expected.txt:
- platform/mac-mountainlion/fast/forms/box-shadow-override-expected.txt:
- platform/mac-mountainlion/fast/forms/form-element-geometry-expected.png: Added.
- platform/mac-mountainlion/fast/forms/form-element-geometry-expected.txt:
- platform/mac-mountainlion/fast/forms/input-appearance-height-expected.txt:
- platform/mac-mountainlion/fast/forms/input-value-expected.txt:
- platform/mac-mountainlion/fast/replaced/replaced-breaking-expected.txt:
- platform/mac-mountainlion/http/tests/navigation/javascriptlink-frame-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug4527-expected.txt:
- platform/mac/css1/box_properties/acid_test-expected.png:
- platform/mac/css1/box_properties/acid_test-expected.txt:
- platform/mac/css2.1/t09-c5526c-display-00-e-expected.png:
- platform/mac/css2.1/t09-c5526c-display-00-e-expected.txt:
- platform/mac/fast/block/basic/011-expected.png:
- platform/mac/fast/block/basic/011-expected.txt:
- platform/mac/fast/block/margin-collapse/103-expected.png:
- platform/mac/fast/block/margin-collapse/103-expected.txt:
- platform/mac/fast/forms/basic-inputs-expected.png:
- platform/mac/fast/forms/basic-inputs-expected.txt:
- platform/mac/fast/forms/box-shadow-override-expected.png:
- platform/mac/fast/forms/box-shadow-override-expected.txt:
- platform/mac/fast/forms/form-element-geometry-expected.png:
- platform/mac/fast/forms/form-element-geometry-expected.txt:
- platform/mac/fast/forms/formmove-expected.txt:
- platform/mac/fast/forms/formmove2-expected.png:
- platform/mac/fast/forms/formmove2-expected.txt:
- platform/mac/fast/forms/input-appearance-height-expected.png:
- platform/mac/fast/forms/input-appearance-height-expected.txt:
- platform/mac/fast/forms/input-value-expected.png:
- platform/mac/fast/forms/input-value-expected.txt:
- platform/mac/fast/inline/positionedLifetime-expected.txt:
- platform/mac/fast/replaced/replaced-breaking-expected.png:
- platform/mac/fast/replaced/replaced-breaking-expected.txt:
- platform/mac/fast/replaced/width100percent-radio-expected.txt:
- platform/mac/http/tests/navigation/javascriptlink-frames-expected.png:
- platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1318-expected.png:
- platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4527-expected.png:
- platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/captions1-expected.png:
- platform/mac/tables/mozilla_expected_failures/core/captions1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/captions2-expected.png:
- platform/mac/tables/mozilla_expected_failures/core/captions2-expected.txt:
- 4:27 PM Changeset in webkit [170256] by
-
- 39 edits in trunk/Source
Remove static tables for bindings that use eager reification
https://bugs.webkit.org/show_bug.cgi?id=134126
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
- runtime/JSObject.cpp:
(JSC::JSObject::putDirectCustomAccessor):
- runtime/Structure.h:
(JSC::Structure::setHasCustomGetterSetterProperties):
Change setHasCustomGetterSetterProperties to behave like setHasGetterSetterProperties, and set
the m_hasReadOnlyOrGetterSetterPropertiesExcludingProto bit if the property is not proto.
Without this, JSObject::put() won't think there are any setters on the prototype chain of an
object that has no static lookup table and uses eagerly reified custom getter/setter properties.
Source/WebCore:
This shaves about 1MB off of WebCore's .o files.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorHelperMethods):
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
- bindings/scripts/test/JS/JSTestActiveDOMObject.h:
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
- bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
- bindings/scripts/test/JS/JSTestEventConstructor.h:
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
- bindings/scripts/test/JS/JSTestEventTarget.h:
- bindings/scripts/test/JS/JSTestException.cpp:
- bindings/scripts/test/JS/JSTestException.h:
- bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
- bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestInterface.h:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
- bindings/scripts/test/JS/JSTestNamedConstructor.h:
- bindings/scripts/test/JS/JSTestNode.cpp:
- bindings/scripts/test/JS/JSTestNode.h:
- bindings/scripts/test/JS/JSTestNondeterministic.cpp:
- bindings/scripts/test/JS/JSTestNondeterministic.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
- bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
- bindings/scripts/test/JS/JSTestTypedefs.h:
- bindings/scripts/test/JS/JSattribute.cpp:
- bindings/scripts/test/JS/JSattribute.h:
- bindings/scripts/test/JS/JSreadonly.cpp:
- bindings/scripts/test/JS/JSreadonly.h:
- 3:33 PM Changeset in webkit [170255] by
-
- 2 edits in trunk/Source/WebKit/mac
Tried to fix the iOS build after r170235.
- WebView/WebView.mm:
- 3:25 PM Changeset in webkit [170254] by
-
- 3 edits in trunk/Source/WebKit2
CallbackMap::put should be able to take an unwrapped function
https://bugs.webkit.org/show_bug.cgi?id=134104
Reviewed by Anders Carlsson.
- UIProcess/GenericCallback.h:
(WebKit::CallbackMap::put): Added an overload that takes a function and creates and puts a
callback. Changed both overloads of put() to return the callback ID.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::validateCommand):
(WebKit::WebPageProxy::runJavaScriptInMainFrame):
(WebKit::WebPageProxy::getRenderTreeExternalRepresentation):
(WebKit::WebPageProxy::getSourceForFrame):
(WebKit::WebPageProxy::getContentsAsString):
(WebKit::WebPageProxy::getBytecodeProfile):
(WebKit::WebPageProxy::getContentsAsMHTMLData):
(WebKit::WebPageProxy::getSelectionOrContentsAsString):
(WebKit::WebPageProxy::getSelectionAsWebArchiveData):
(WebKit::WebPageProxy::getMainResourceDataOfFrame):
(WebKit::WebPageProxy::getResourceDataFromFrame):
(WebKit::WebPageProxy::getWebArchiveOfFrame):
(WebKit::WebPageProxy::getMarkedRangeAsync):
(WebKit::WebPageProxy::getSelectedRangeAsync):
(WebKit::WebPageProxy::characterIndexForPointAsync):
(WebKit::WebPageProxy::firstRectForCharacterRangeAsync):
(WebKit::WebPageProxy::takeSnapshot):
- 3:02 PM Changeset in webkit [170253] by
-
- 11 edits in trunk/Source/WebKit2
Make it possible to override debug preferences on a per-identifier basis as well as globally
https://bugs.webkit.org/show_bug.cgi?id=134164
Reviewed by Dan Bernstein.
- Shared/WebPreferencesDefinitions.h:
- Shared/WebPreferencesKeys.cpp:
- Shared/WebPreferencesKeys.h:
- Shared/WebPreferencesStore.cpp:
(WebKit::defaults):
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesCreate):
(WKPreferencesCreateWithIdentifier):
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences init]):
- UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::WebPageGroup):
- UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::create):
(WebKit::WebPreferences::createWithLegacyDefaults):
(WebKit::WebPreferences::WebPreferences):
- UIProcess/WebPreferences.h:
- UIProcess/mac/WebPreferencesMac.mm:
(WebKit::makeKey):
(WebKit::debugUserDefaultsValue):
(WebKit::setDebugBoolValueIfInUserDefaults):
(WebKit::WebPreferences::platformInitializeStore):
- 2:01 PM Changeset in webkit [170252] by
-
- 2 edits in trunk/Source/WebKit2
Begin work on decoding form data
https://bugs.webkit.org/show_bug.cgi?id=134163
Reviewed by Sam Weinig.
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::HistoryEntryDataDecoder::operator>>):
(WebKit::HistoryEntryDataDecoder::isValid):
(WebKit::isValidEnum):
(WebKit::decodeFormDataElement):
(WebKit::decodeFormData):
(WebKit::decodeBackForwardTreeNode):
- 1:05 PM Changeset in webkit [170251] by
-
- 2 edits in trunk/Source/WebKit2
Only initialize WebPreferences from NSUserDefaults if there's an identifier
https://bugs.webkit.org/show_bug.cgi?id=134162
Reviewed by Sam Weinig.
We don't want to allow changing preferences by registering user defaults.
- UIProcess/mac/WebPreferencesMac.mm:
(WebKit::makeKey):
(WebKit::WebPreferences::platformInitializeStore):
- 12:41 PM Changeset in webkit [170250] by
-
- 2 edits in trunk/Source/WebKit2
Begin work on decoding the back/forward tree
https://bugs.webkit.org/show_bug.cgi?id=134161
Reviewed by Sam Weinig.
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntries):
(WebKit::HistoryEntryDataDecoder::operator>>):
(WebKit::HistoryEntryDataDecoder::decodeArithmeticType):
(WebKit::HistoryEntryDataDecoder::bufferIsLargeEnoughToContain):
(WebKit::decodeBackForwardTreeNode):
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntryData):
(WebKit::HistoryEntryDataDecoder::decode): Deleted.
- 12:07 PM Changeset in webkit [170249] by
-
- 22 edits9 moves1 add in trunk
Gamepad API - Deprecate the existing implementation
https://bugs.webkit.org/show_bug.cgi?id=134108
Reviewed by Timothy Hatcher.
-Add new "GAMEPAD_DEPRECATED" build flag, moving the existing implementation to use it
.:
-Add the "Deprecated" suffix to some implementation files
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
-Move some implementation files into a "deprecated" subdirectory.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
-Move some implementation files into a "deprecated" subdirectory.
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- PlatformGTK.cmake:
- Modules/gamepad/deprecated/Gamepad.cpp: Renamed from Source/WebCore/Modules/gamepad/Gamepad.cpp.
- Modules/gamepad/deprecated/Gamepad.h: Renamed from Source/WebCore/Modules/gamepad/Gamepad.h.
- Modules/gamepad/deprecated/Gamepad.idl: Renamed from Source/WebCore/Modules/gamepad/Gamepad.idl.
- Modules/gamepad/deprecated/GamepadList.cpp: Renamed from Source/WebCore/Modules/gamepad/GamepadList.cpp.
- Modules/gamepad/deprecated/GamepadList.h: Renamed from Source/WebCore/Modules/gamepad/GamepadList.h.
- Modules/gamepad/deprecated/GamepadList.idl: Renamed from Source/WebCore/Modules/gamepad/GamepadList.idl.
- Modules/gamepad/deprecated/NavigatorGamepad.cpp: Renamed from Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp.
- Modules/gamepad/deprecated/NavigatorGamepad.h: Renamed from Source/WebCore/Modules/gamepad/NavigatorGamepad.h.
- Modules/gamepad/deprecated/NavigatorGamepad.idl: Renamed from Source/WebCore/Modules/gamepad/NavigatorGamepad.idl.
- platform/Gamepads.h:
- platform/efl/GamepadsEfl.cpp:
- platform/gtk/GamepadsGtk.cpp:
- platform/linux/GamepadDeviceLinux.cpp:
- platform/linux/GamepadDeviceLinux.h:
Source/WebKit/mac:
-Move some implementation files into a "deprecated" subdirectory.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
-Move some implementation files into a "deprecated" subdirectory.
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
-Move some implementation files into a "deprecated" subdirectory.
- wtf/FeatureDefines.h:
- 11:52 AM Changeset in webkit [170248] by
-
- 2 edits in trunk/Source/WebKit2
Implement more of HistoryEntryDataDecoder
https://bugs.webkit.org/show_bug.cgi?id=134146
Reviewed by Sam Weinig.
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::HistoryEntryDataDecoder::HistoryEntryDataDecoder):
(WebKit::HistoryEntryDataDecoder::operator>>):
(WebKit::HistoryEntryDataDecoder::decode):
(WebKit::HistoryEntryDataDecoder::decodeFixedLengthData):
(WebKit::HistoryEntryDataDecoder::alignBufferPosition):
(WebKit::HistoryEntryDataDecoder::alignedBuffer):
(WebKit::HistoryEntryDataDecoder::alignedBufferIsLargeEnoughToContain):
(WebKit::HistoryEntryDataDecoder::markInvalid):
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntryData):
- 11:27 AM Changeset in webkit [170247] by
-
- 2 edits in trunk/Source/WebCore
Mark TextRun's constructors as explicit
https://bugs.webkit.org/show_bug.cgi?id=134124
Reviewed by Sam Weinig.
After r170072, nobody is implicitly converting a string to a TextRun. Therefore,
we can make the constructors explicit.
No new tests because there is no behavior change.
- platform/graphics/TextRun.h:
(WebCore::TextRun::TextRun):
- 9:24 AM Changeset in webkit [170246] by
-
- 25 edits6 moves in trunk
Unreviewed, rolling out r170244.
https://bugs.webkit.org/show_bug.cgi?id=134157
GTK/EFL bindings generator works differently, making this
patch not work there. Will fix entire patch after a rollout.
(Requested by bradee-oh on #webkit).
Reverted changeset:
"Gamepad API - Deprecate the existing implementation"
https://bugs.webkit.org/show_bug.cgi?id=134108
http://trac.webkit.org/changeset/170244
- 8:55 AM Changeset in webkit [170245] by
-
- 2 edits in trunk/Source/WebCore
Fix the mismatched header build guards in WebKitDOMNodeFilterPrivate.h
which are throwing compilation warnings when building with Clang.
- bindings/gobject/WebKitDOMNodeFilterPrivate.h:
- 8:43 AM Changeset in webkit [170244] by
-
- 25 edits6 moves in trunk
Gamepad API - Deprecate the existing implementation
https://bugs.webkit.org/show_bug.cgi?id=134108
Reviewed by Timothy Hatcher.
-Add new "GAMEPAD_DEPRECATED" build flag, moving the existing implementation to use it
-Add the "Deprecated" suffix to some implementation files
.:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- CMakeLists.txt:
- PlatformGTK.cmake:
- Configurations/FeatureDefines.xcconfig:
- Modules/gamepad/GamepadDeprecated.cpp: Renamed from Source/WebCore/Modules/gamepad/Gamepad.cpp.
- Modules/gamepad/GamepadDeprecated.h: Renamed from Source/WebCore/Modules/gamepad/Gamepad.h.
- Modules/gamepad/GamepadDeprecated.idl: Renamed from Source/WebCore/Modules/gamepad/Gamepad.idl.
- Modules/gamepad/GamepadList.cpp:
- Modules/gamepad/GamepadList.h:
- Modules/gamepad/GamepadList.idl:
- Modules/gamepad/NavigatorGamepadDeprecated.cpp: Renamed from Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp.
- Modules/gamepad/NavigatorGamepadDeprecated.h: Renamed from Source/WebCore/Modules/gamepad/NavigatorGamepad.h.
- Modules/gamepad/NavigatorGamepadDeprecated.idl: Renamed from Source/WebCore/Modules/gamepad/NavigatorGamepad.idl.
- platform/Gamepads.h:
- platform/efl/GamepadsEfl.cpp:
- platform/gtk/GamepadsGtk.cpp:
- platform/linux/GamepadDeviceLinux.cpp:
- platform/linux/GamepadDeviceLinux.h:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
- 8:06 AM Changeset in webkit [170243] by
-
- 6 edits in trunk/Source/WebKit2
[CoordinatedGraphics][WK2][EFL] Page is moved to (0,0) position before rendering content
https://bugs.webkit.org/show_bug.cgi?id=133300
Reviewed by Csaba Osztrogonác.
When new page is loaded, PageViewportController::didCommitLoad() calls PageViewportController::syncVisibleContents()
with initial position via applyPositionAfterRenderingContents() before starting to render
new page by PageViewportController::didRenderFrame(). This call flow causes that webview shows
incomplete tiles to the user during a few milliseconds. To fix showing incomplete tiles during
the page loading, this patch adds a flag so that we don't show the incomplete tiles until showing
new page.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
- UIProcess/API/efl/EwkView.h:
(EwkView::setWaitingForNewPage):
(EwkView::waitingForNewPage):
- UIProcess/efl/PageLoadClientEfl.cpp:
(WebKit::PageLoadClientEfl::didCommitLoadForFrame):
- UIProcess/efl/PageViewportControllerClientEfl.cpp:
(WebKit::PageViewportControllerClientEfl::didChangeVisibleContents):
- UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::didRenderFrame):
(WebKit::ViewClientEfl::didCompletePageTransition):
- 8:02 AM Changeset in webkit [170242] by
-
- 38 edits in trunk
Unreviewed, rolling out r170228.
https://bugs.webkit.org/show_bug.cgi?id=134155
Caused 9 layout test failures on Mountain Lion
http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK2%20(Tests)/builds/19216
(Requested by bradee-oh on #webkit).
Reverted changeset:
"[Mac] Margins for new form controls need tweaking"
https://bugs.webkit.org/show_bug.cgi?id=134135
http://trac.webkit.org/changeset/170228
- 7:59 AM Changeset in webkit [170241] by
-
- 3 edits in trunk/Source/WebCore
[Mac] Create and attach the AVPlayerLayer to the AVPlayer immediately if the media element is <video>.
https://bugs.webkit.org/show_bug.cgi?id=134131
Reviewed by Eric Carlson.
The AVPlayer uses the presence of an AVPlayerLayer to decide which alternate to display in the case of
HLS streams with audio-only alternates. To give the AVPlayer the most information with which to make its
decision, always create and attach an AVPlayerLayer before attaching an AVPlayerItem to the AVPlayerLayer.
In addition, retrieve the <video> element bounds and create an AVPlayerLayer with a matching size, so that
the AVPlayer can choose an alternate with the correct dimensions.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasLayerRenderer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformLayer):
- 7:55 AM Changeset in webkit [170240] by
-
- 25 edits in trunk/Source/WebInspectorUI
Web Inspector: UI fonts should pull from system fonts automatically to whatever degree possible
https://bugs.webkit.org/show_bug.cgi?id=133966
Reviewed by Timothy Hatcher.
Updated font families to use -webkit-system-font, and set this on the body to be
inherited. Also made sure that popovers use Menlo as the default. Updated
autocompletions with system font names.
- UserInterface/Models/CSSKeywordCompletions.js: Updated completions with available system fonts.
- UserInterface/Controllers/CodeMirrorGradientEditingController.css:
- UserInterface/Views/Breakpoint.css:
- UserInterface/Views/ButtonNavigationItem.css:
- UserInterface/Views/ButtonToolbarItem.css:
- UserInterface/Views/CSSStyleDeclarationSection.css:
- UserInterface/Views/CSSStyleDeclarationTextEditor.css:
- UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
- UserInterface/Views/CodeMirrorOverrides.css:
- UserInterface/Views/DataGrid.css:
- UserInterface/Views/DebuggerDashboardView.css:
- UserInterface/Views/DetailsSection.css:
- UserInterface/Views/FindBanner.css:
- UserInterface/Views/GoToLineDialog.css:
- UserInterface/Views/HierarchicalPathComponent.css:
- UserInterface/Views/Main.css:
- UserInterface/Views/NavigationSidebarPanel.css:
- UserInterface/Views/ProbeSetDataGrid.css:
- UserInterface/Views/RulesStyleDetailsPanel.css:
- UserInterface/Views/ScopeBar.css:
- UserInterface/Views/SourceCodeTextEditor.css:
- UserInterface/Views/TimelineDataGrid.css:
- UserInterface/Views/TimelineRuler.css:
- UserInterface/Views/TimelineSidebarPanel.css:
Changes to fonts. Set default font stack to -webkit-system-font, sans-serif. Default size is
11px. Only changes to this default size or changes to the font (to Menlo, monospace usually) remain.
- 7:52 AM Changeset in webkit [170239] by
-
- 2 edits in trunk/Source/WebCore
Implement ios -[WAKWindow convertBaseToScreen:]
https://bugs.webkit.org/show_bug.cgi?id=134053
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-06-21
Reviewed by Eric Carlson.
- platform/ios/wak/WAKWindow.mm:
(-[WAKWindow convertBaseToScreen:]):
Traverse layer hierarchy and convert point.
(-[WAKWindow convertScreenToBase:]):
Traverse layer hierarchy and convert point.
- 7:51 AM Changeset in webkit [170238] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Esc in quick console no longer toggles console drawer
https://bugs.webkit.org/show_bug.cgi?id=134068
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-06-21
Reviewed by Timothy Hatcher.
For Escape to toggle console behavior we were relying on the Escape
keyboard event to propagate up to the window and be handled by
QuickConsole's global keyboard shortcut. With CodeMirror 4, all
editors have a default "Esc" key handler to reduce multiple selections
to a single selection. Unfortunately this always prevents default,
which our keyboard shortcut respects and doesn't toggle the console.
Workaround this by putting a specific handler for when a Console
Prompt is empty and the Escape key is triggered. This does not go
through the normal ConsolePrompt delegate because the delegate
is never the QuickConsole, it is actually the JavaScript log.
- UserInterface/Views/ConsolePrompt.js:
(WebInspector.ConsolePrompt):
(WebInspector.ConsolePrompt.prototype.set escapeKeyHandlerWhenEmpty):
(WebInspector.ConsolePrompt.prototype._handleEscapeKey):
- UserInterface/Views/QuickConsole.js:
(WebInspector.QuickConsole.this.prompt.escapeKeyHandlerWhenEmpty):
(WebInspector.QuickConsole):
- 7:43 AM Changeset in webkit [170237] by
-
- 2 edits in trunk/Source/WebKit2
Commit queue has been failing due to a build failure in WKFoundation.h
https://bugs.webkit.org/show_bug.cgi?id=134152
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2014-06-21
Reviewed by Csaba Osztrogonác.
Landed by Brady Eidson.
The build failure was caused by WKFoundation.h erroneously redefining
NSURLSessionAuthChallengeDisposition even when building with 10.9 SDK.
The availability of this type depends on the version of SDK,
not the target operating system.
- Shared/API/Cocoa/WKFoundation.h:
- 1:53 AM Changeset in webkit [170236] by
-
- 2 edits1 add in trunk/Tools
[Inspector][EFL] Can't resume a special break point on EFL inspector
https://bugs.webkit.org/show_bug.cgi?id=129294
Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-06-21
Reviewed by Gyuyoung Kim.
Patch our EFL 1.9 with the fix landed in upstream EFL 1.10
by Ryuan Choi - <https://phab.enlightenment.org/D790>
- efl/jhbuild.modules:
- efl/patches/ecore.patch: Added.
- 1:49 AM Changeset in webkit [170235] by
-
- 39 edits in trunk
Removing PAGE_VISIBILITY_API compile guard.
https://bugs.webkit.org/show_bug.cgi?id=133844
Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-06-21
Reviewed by Gavin Barraclough.
.:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
No new tests because no functional changes.
- Configurations/FeatureDefines.xcconfig:
- Modules/vibration/NavigatorVibration.cpp:
(WebCore::NavigatorVibration::vibrate):
- dom/Document.cpp:
(WebCore::Document::hidden):
- dom/Document.h:
- dom/Document.idl:
- dom/Element.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::registerWithDocument):
(WebCore::HTMLMediaElement::unregisterWithDocument):
(WebCore::HTMLMediaElement::parseAttribute):
- html/HTMLMediaElement.h:
- page/Page.cpp:
(WebCore::Page::setIsVisibleInternal):
(WebCore::Page::visibilityState):
(WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged):
- page/Page.h:
- page/PageVisibilityState.cpp:
- page/PageVisibilityState.h:
- page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setHiddenPageCSSAnimationSuspensionEnabled):
- page/Settings.h:
- platform/audio/MediaSession.cpp:
(WebCore::MediaSession::updateClientDataBuffering):
- platform/audio/MediaSession.h:
Source/WebKit/efl:
- ewk/ewk_view.cpp:
(ewk_view_visibility_state_set):
(ewk_view_visibility_state_get):
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
(-[WebView _visibilityState]):
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.props:
- win/tools/vsprops/FeatureDefinesCairo.props:
- 1:46 AM Changeset in webkit [170234] by
-
- 2 edits in trunk/Source/JavaScriptCore
ARM traditional buildfix after r169942.
https://bugs.webkit.org/show_bug.cgi?id=134100
Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-06-21
Reviewed by Zoltan Herczeg.
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::abortWithReason): Added.
- 1:07 AM Changeset in webkit [170233] by
-
- 2 edits in trunk/Source/WebCore
[GTK][EFL] Use OpenType MATH fonts by default.
https://bugs.webkit.org/show_bug.cgi?id=133604
Reviewed by Chris Fleizach.
In order to support stretching of horizontal operators and large
operators in display mode as well as to improve the drawing of radicals,
we need to use an OpenType MATH table. This commit makes the MathML code
try "Latin Modern Math" first, which is an OpenType version of Knuth's
popular Computer Modern font and is packaged with most TeX
distributions (e.g. TeX Live on Linux). This should work well on the
EFL & GTK ports for which the initial OpenType MATH support has been
tested. Other ports will be handled later.
No new tests. This is already tested in LayoutTests/mathml/opentype/.
- css/mathml.css:
(math): Add "Latin Modern Math" as the first font-family of the <math> element.
Jun 20, 2014:
- 11:04 PM Changeset in webkit [170232] by
-
- 6 edits23 moves1 add11 deletes in trunk/LayoutTests
Remove latinmodern-math.woff from LayoutTests/mathml/opentype
https://bugs.webkit.org/show_bug.cgi?id=134094
Reviewed by Martin Robinson.
We remove latinmodern-math.woff from the source and make mathml/opentype/*LatinModern* tests not font-specific, so that each platform will use whatever OpenType MATH is available.
Until bug 133604 is fixed and Latin Modern Math installed on the Linux bots, the tests are marked as failed. More generally, we need to fix bug 133603.
The test mathml/opentype/roots-LatinModern is removed since it will duplicate mathml/presentation/roots.xhtml when OpenType MATH fonts are available.
- mathml/opentype/LICENSE-LatinModern.txt: Removed.
- mathml/opentype/horizontal-munderover.html: Renamed from LayoutTests/mathml/opentype/horizontal-LatinModern-munderover.html.
- mathml/opentype/horizontal.html: Renamed from LayoutTests/mathml/opentype/horizontal-LatinModern.html.
- mathml/opentype/large-operators-LatinModern.html: Removed.
- mathml/opentype/large-operators.html: Added.
- mathml/opentype/latinmodern-math.woff: Removed.
- mathml/opentype/opentype-stretchy-horizontal.html:
- mathml/opentype/roots-LatinModern.html: Removed.
- mathml/opentype/vertical.html: Renamed from LayoutTests/mathml/opentype/vertical-LatinModern.html.
- platform/efl/TestExpectations:
- platform/efl/mathml/opentype/horizontal-expected.txt: Renamed from LayoutTests/platform/efl/mathml/opentype/horizontal-LatinModern-expected.txt.
- platform/efl/mathml/opentype/horizontal-munderover-expected.txt: Renamed from LayoutTests/platform/efl/mathml/opentype/horizontal-LatinModern-munderover-expected.txt.
- platform/efl/mathml/opentype/large-operators-expected.png: Renamed from LayoutTests/platform/gtk/mathml/opentype/large-operators-LatinModern-expected.png.
- platform/efl/mathml/opentype/large-operators-expected.txt: Renamed from LayoutTests/platform/efl/mathml/opentype/large-operators-LatinModern-expected.txt.
- platform/efl/mathml/opentype/roots-LatinModern-expected.txt: Removed.
- platform/efl/mathml/opentype/vertical-expected.png: Renamed from LayoutTests/platform/gtk/mathml/opentype/vertical-LatinModern-expected.png.
- platform/efl/mathml/opentype/vertical-expected.txt: Renamed from LayoutTests/platform/efl/mathml/opentype/vertical-LatinModern-expected.txt.
- platform/gtk/TestExpectations:
- platform/gtk/mathml/opentype/horizontal-expected.png: Renamed from LayoutTests/platform/gtk/mathml/opentype/horizontal-LatinModern-expected.png.
- platform/gtk/mathml/opentype/horizontal-expected.txt: Renamed from LayoutTests/platform/gtk/mathml/opentype/horizontal-LatinModern-expected.txt.
- platform/gtk/mathml/opentype/horizontal-munderover-expected.png: Renamed from LayoutTests/platform/gtk/mathml/opentype/horizontal-LatinModern-munderover-expected.png.
- platform/gtk/mathml/opentype/horizontal-munderover-expected.txt: Renamed from LayoutTests/platform/gtk/mathml/opentype/horizontal-LatinModern-munderover-expected.txt.
- platform/gtk/mathml/opentype/large-operators-expected.png: Renamed from LayoutTests/platform/efl/mathml/opentype/large-operators-LatinModern-expected.png.
- platform/gtk/mathml/opentype/large-operators-expected.txt: Renamed from LayoutTests/platform/gtk/mathml/opentype/large-operators-LatinModern-expected.txt.
- platform/gtk/mathml/opentype/roots-LatinModern-expected.png: Removed.
- platform/gtk/mathml/opentype/roots-LatinModern-expected.txt: Removed.
- platform/gtk/mathml/opentype/vertical-expected.png: Renamed from LayoutTests/platform/efl/mathml/opentype/vertical-LatinModern-expected.png.
- platform/gtk/mathml/opentype/vertical-expected.txt: Renamed from LayoutTests/platform/gtk/mathml/opentype/vertical-LatinModern-expected.txt.
- platform/mac-wk2/mathml/opentype/large-operators-LatinModern-expected.txt: Removed.
- platform/mac-wk2/mathml/opentype/vertical-LatinModern-expected.txt: Removed.
- platform/mac/TestExpectations:
- platform/mac/mathml/opentype/horizontal-expected.txt: Renamed from LayoutTests/platform/mac/mathml/opentype/horizontal-LatinModern-expected.txt.
- platform/mac/mathml/opentype/horizontal-munderover-expected.txt: Renamed from LayoutTests/platform/mac/mathml/opentype/horizontal-LatinModern-munderover-expected.txt.
- platform/mac/mathml/opentype/large-operators-expected.txt: Renamed from LayoutTests/platform/mac/mathml/opentype/large-operators-LatinModern-expected.txt.
- platform/mac/mathml/opentype/roots-LatinModern-expected.txt: Removed.
- platform/mac/mathml/opentype/vertical-expected.txt: Renamed from LayoutTests/platform/mac/mathml/opentype/vertical-LatinModern-expected.txt.
- platform/win/TestExpectations:
- platform/win/mathml/opentype/horizontal-expected.txt: Renamed from LayoutTests/platform/win/mathml/opentype/horizontal-LatinModern-expected.txt.
- platform/win/mathml/opentype/horizontal-munderover-expected.txt: Renamed from LayoutTests/platform/win/mathml/opentype/horizontal-LatinModern-munderover-expected.txt.
- platform/win/mathml/opentype/roots-LatinModern-expected.txt: Removed.
- 11:00 PM Changeset in webkit [170231] by
-
- 1 edit1 delete in trunk/LayoutTests
[EFL] Remove WebKit1 test results
https://bugs.webkit.org/show_bug.cgi?id=134137
Reviewed by Daniel Bates.
- platform/efl-wk1: Removed entire directory which contains the WebKit1 EFL test results.
- 10:53 PM Changeset in webkit [170230] by
-
- 3 edits2 copies3 deletes in trunk/Tools
[EFL] Remove DumpRenderTree/efl and EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=134138
Reviewed by Gyuyoung Kim.
DumpRenderTree/efl and EWebLauncher are not necessary anymore because WebKit1 EFL will be removed.
- CMakeLists.txt:
- DumpRenderTree/PlatformEfl.cmake: Removed.
- DumpRenderTree/efl: Removed entire directory.
- EWebLauncher: Ditto.
- WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Renamed from Tools/DumpRenderTree/efl/FontManagement.cpp.
(buildPath):
(getCoreFontFiles):
(addFontDirectory):
(addFontFiles):
(getCustomBuildDir):
(getPlatformFontsPath):
(addFontsToEnvironment):
- WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Renamed from Tools/DumpRenderTree/efl/FontManagement.h.
- WebKitTestRunner/PlatformEfl.cmake:
- 10:09 PM Changeset in webkit [170229] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed EFL build fix since r170224.
Add retainPlatformLayer() and releasePlatformLayer() in ScrollingStateNodeCoordinatedGraphics.cpp
as well. Thouse functions were missed in r170224.
- page/scrolling/ScrollingStateNode.h:
- page/scrolling/coordinatedgraphics/ScrollingStateNodeCoordinatedGraphics.cpp:
(WebCore::LayerRepresentation::retainPlatformLayer):
(WebCore::LayerRepresentation::releasePlatformLayer):
- 8:10 PM Changeset in webkit [170228] by
-
- 38 edits in trunk
[Mac] Margins for new form controls need tweaking
https://bugs.webkit.org/show_bug.cgi?id=134135
<rdar://problem/17262164>
Reviewed by Sam Weinig.
Source/WebCore:
With the newer animated controls in OS X Yosemite, we need
to tweak the fudge-factor margins for positioning. In a recent
patch I added another fudge, which I'm removing with this. I'm
not sure where the older values came from, but I've checked with
the latest AppKit sources and am using the sizes they implement
for the controls.
This will rebaseline a lot of tests, since I've made small tweaks
to the form layout.
- platform/mac/ThemeMac.mm:
(WebCore::checkboxMargins): New margin amounts.
(WebCore::radioSizes): New sizes.
(WebCore::radioMargins): New margin amounts.
(WebCore::paintToggleButton): No need to call the positioning fudge any more.
(WebCore::checkboxOffsets): Deleted.
(WebCore::radioOffsets): Deleted.
LayoutTests:
Rebaseline a bunch of results since some <input> dimensions
changed slightly.
- platform/mac/css1/box_properties/acid_test-expected.png:
- platform/mac/css1/box_properties/acid_test-expected.txt:
- platform/mac/css2.1/t09-c5526c-display-00-e-expected.png:
- platform/mac/css2.1/t09-c5526c-display-00-e-expected.txt:
- platform/mac/fast/block/basic/011-expected.png:
- platform/mac/fast/block/basic/011-expected.txt:
- platform/mac/fast/block/margin-collapse/103-expected.png:
- platform/mac/fast/block/margin-collapse/103-expected.txt:
- platform/mac/fast/forms/basic-inputs-expected.png:
- platform/mac/fast/forms/basic-inputs-expected.txt:
- platform/mac/fast/forms/box-shadow-override-expected.png:
- platform/mac/fast/forms/box-shadow-override-expected.txt:
- platform/mac/fast/forms/form-element-geometry-expected.png:
- platform/mac/fast/forms/form-element-geometry-expected.txt:
- platform/mac/fast/forms/formmove-expected.txt:
- platform/mac/fast/forms/formmove2-expected.png:
- platform/mac/fast/forms/formmove2-expected.txt:
- platform/mac/fast/forms/input-appearance-height-expected.png:
- platform/mac/fast/forms/input-appearance-height-expected.txt:
- platform/mac/fast/forms/input-value-expected.png:
- platform/mac/fast/forms/input-value-expected.txt:
- platform/mac/fast/inline/positionedLifetime-expected.txt:
- platform/mac/fast/replaced/replaced-breaking-expected.png:
- platform/mac/fast/replaced/replaced-breaking-expected.txt:
- platform/mac/fast/replaced/width100percent-radio-expected.txt:
- platform/mac/http/tests/navigation/javascriptlink-frames-expected.png:
- platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1318-expected.png:
- platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4527-expected.png:
- platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/captions1-expected.png:
- platform/mac/tables/mozilla_expected_failures/core/captions1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/captions2-expected.png:
- platform/mac/tables/mozilla_expected_failures/core/captions2-expected.txt:
- 7:33 PM Changeset in webkit [170227] by
-
- 2 edits in trunk/Source/WebCore
Fix css jit on armv7.
https://bugs.webkit.org/show_bug.cgi?id=134143
<rdar://problem/17348060>
Patch by Alex Christensen <achristensen@webkit.org> on 2014-06-20
Reviewed by Benjamin Poulain.
This fixes the acid3 test.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::addFlagsToElementStyleFromContext):
Correct high and low bits.
- 5:11 PM Changeset in webkit [170226] by
-
- 4 edits in trunk/Source/WebKit2
Implement more of LegacySessionStateDecoder
https://bugs.webkit.org/show_bug.cgi?id=134145
Reviewed by Sam Weinig.
- Shared/SessionState.h:
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntry):
(WebKit::HistoryEntryDataDecoder::HistoryEntryDataDecoder):
(WebKit::HistoryEntryDataDecoder::finishDecoding):
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntryData):
- UIProcess/mac/LegacySessionStateCoding.h:
- 4:48 PM Changeset in webkit [170225] by
-
- 5 edits in trunk/Source/WebKit2
Implement more of LegacySessionStateDecoder
https://bugs.webkit.org/show_bug.cgi?id=134144
Reviewed by Sam Weinig.
- Shared/SessionState.cpp:
(WebKit::BackForwardListState::encode):
(WebKit::SessionState::encode): Deleted.
- Shared/SessionState.h:
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::LegacySessionStateDecoder::decodeSessionState):
(WebKit::LegacySessionStateDecoder::decodeSessionHistory):
(WebKit::LegacySessionStateDecoder::decodeV0SessionHistory):
(WebKit::LegacySessionStateDecoder::decodeV1SessionHistory):
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntries):
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntry):
- UIProcess/mac/LegacySessionStateCoding.h:
- 4:44 PM Changeset in webkit [170224] by
-
- 5 edits1 move1 add in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=134117
Unreproducible crashes under WebCore::ScrollingTree::updateTreeFromStateNode()
from messaging a deleted Obj-C object
-and corresponding-
<rdar://problem/17149252>
Reviewed by Simon Fraser.
This is a speculative fix. It makes LayerRepresentation retain m_platformLayer.
- WebCore.exp.in:
- page/scrolling/ScrollingStateNode.h:
(WebCore::LayerRepresentation::LayerRepresentation):
(WebCore::LayerRepresentation::~LayerRepresentation):
(WebCore::LayerRepresentation::operator=):
(WebCore::LayerRepresentation::operator==):
(WebCore::LayerRepresentation::operator ==): Deleted.
Make this ASSERT an ASSERT_WITH_SECURITY_IMPLICATION
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::updateTreeFromStateNode):
Moved ScrollingStateNodeMac.mm, which was empty anyway, to cocoa/
ScrollingStateNode.mm so that iOS can use it too.
- page/scrolling/cocoa: Added.
- page/scrolling/cocoa/ScrollingStateNode.mm: Copied from page/scrolling/mac/ScrollingStateNodeMac.mm.
Actual implementation for retain and release.
(WebCore::LayerRepresentation::retainPlatformLayer):
(WebCore::LayerRepresentation::releasePlatformLayer):
Deleted.
- page/scrolling/mac/ScrollingStateNodeMac.mm: Removed.
- 4:40 PM Changeset in webkit [170223] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. build fix for the cmake based ports since r170188
- CMakeLists.txt: Added LegacySessionState.cpp in source list.
- 4:37 PM Changeset in webkit [170222] by
-
- 4 edits in trunk/Source/WebKit2
[Cocoa] No way to get the main frame’s main resource’s data
https://bugs.webkit.org/show_bug.cgi?id=134113
Reviewed by Sam Weinig.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _getMainResourceDataWithCompletionHandler:]): Added. Calls
WebPageProxy::getMainResourceDataOfFrame and invokes the completion handler form the
callback.
- UIProcess/API/Cocoa/WKWebViewPrivate.h: Declared new method.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getMainResourceDataOfFrame): Made it safe to pass a NULL frame into
this function.
- 4:21 PM Changeset in webkit [170221] by
-
- 2 edits in trunk/Tools
Name moving. Unreviewed.
- Scripts/webkitpy/common/config/contributors.json:
- 3:57 PM Changeset in webkit [170220] by
-
- 6 edits in trunk/Source/WebCore
Introduce RenderLayer::offsetFromAncestorLayer() to make convertToLayerCoords() calls with
LayoutPoint(0, 0) as parameter more explicit.
https://bugs.webkit.org/show_bug.cgi?id=134092
Reviewed by Simon Fraser.
Most of the RenderLayer::convertToLayerCoords() callers are only interested in
the offset from the ancestor layer by passing LayoutPoint(0, 0) as the coordinate to convert.
Introducing offsetFromAncestorLayer() makes those calls more explicit/self-explanatory.
It helps simplifying the callsite's code.
No change in functionality.
- rendering/RenderGeometryMap.cpp:
(WebCore::RenderGeometryMap::mapToContainer):
(WebCore::RenderGeometryMap::pushMappingsToAncestor):
(WebCore::RenderGeometryMap::push):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::computeOffsetFromRoot):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::expandClipRectForRegionAndReflection):
(WebCore::expandClipRectForDescendantsAndReflection):
(WebCore::transparencyClipBox):
(WebCore::RenderLayer::convertToPixelSnappedLayerCoords):
(WebCore::accumulateOffsetTowardsAncestor):
(WebCore::RenderLayer::convertToLayerCoords):
(WebCore::RenderLayer::offsetFromAncestorLayer):
(WebCore::RenderLayer::clipToRect):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintLayerByApplyingTransform):
(WebCore::RenderLayer::collectFragments):
(WebCore::RenderLayer::paintTransformedLayerIntoFragments):
(WebCore::RenderLayer::createLocalTransformState):
(WebCore::RenderLayer::hitTestTransformedLayerInFragments):
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateCompositedBounds):
(WebCore::RenderLayerBacking::updateGeometry):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::repaintInCompositedAncestor):
- 3:46 PM Changeset in webkit [170219] by
-
- 7 edits6 copies in trunk/Source/WebKit2
Introduce a WKSessionStateRef object
https://bugs.webkit.org/show_bug.cgi?id=134136
Reviewed by Tim Horton.
WKSessionStateRef is going to hold session state, making it possible to migrate state from one
webpage to another without having to do any serialization/deserialization.
- Shared/API/c/WKBase.h:
- Shared/APIObject.h:
- Shared/SessionState.cpp:
(WebKit::SessionState::encode):
- Shared/SessionState.h:
- UIProcess/API/APISessionState.cpp: Added.
(API::SessionState::create):
(API::SessionState::SessionState):
(API::SessionState::~SessionState):
- UIProcess/API/APISessionState.h:
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKSessionStateRef.cpp:
(WKSessionStateCreateFromData):
- UIProcess/API/C/WKSessionStateRef.h:
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::LegacySessionStateDecoder::LegacySessionStateDecoder):
(WebKit::LegacySessionStateDecoder::~LegacySessionStateDecoder):
(WebKit::LegacySessionStateDecoder::decodeSessionState):
- UIProcess/mac/LegacySessionStateCoding.h:
- WebKit2.xcodeproj/project.pbxproj:
- 3:42 PM Changeset in webkit [170218] by
-
- 4 edits in trunk/Source/WebKit2
iOS WebKit2: selection handles become too large when zooming a page.
https://bugs.webkit.org/show_bug.cgi?id=134084
<rdar://problem/16799164>
Reviewed by Benjamin Poulain.
Since the document view is zoomed, we add a subview that has the inverse transform
of the document view. This new view becomes the root for the selection hierarchy.
The new view has zero size, not to interfere with the existing gestures on the WKContenView
therefore we implement hitTest to detect interaction with the selection elements.
- UIProcess/ios/WKContentView.mm:
(-[WKContentView didUpdateVisibleRect:unobscuredRect:unobscuredRectInScrollViewCoordinates:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:]):
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView unscaledView]):
(-[WKContentView inverseScale]):
(-[WKContentView _updateUnscaledView]):
(-[WKContentView hitTest:withEvent:::]):
(-[WKContentView selectedTextRange]):
- 3:40 PM Changeset in webkit [170217] by
-
- 2 edits in trunk/Source/WebKit2
Snapshotting WKThumbnailViews should not tell Web processes backing unparented WKViews that they're in window
https://bugs.webkit.org/show_bug.cgi?id=134134
<rdar://problem/17402119>
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.mm:
(-[WKView _setThumbnailView:]):
Re-evaluating our in-window state is only useful if we're going to use the live layer tree;
snapshots can be taken of unparented views with no trouble. Plus, doing so sets off a chain of
expensive things in the Web process which we can avoid if using snapshots.
- 3:38 PM Changeset in webkit [170216] by
-
- 3 edits in trunk/Source/WebKit2
WKThumbnailView should only use live layer trees before the snapshot arrives for parented WKViews
https://bugs.webkit.org/show_bug.cgi?id=134129
<rdar://problem/17401591>
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/_WKThumbnailView.mm:
(-[_WKThumbnailView initWithFrame:fromWKView:]):
Add a white background to WKThumbnailView, so that if we have no snapshot and no layer tree,
the view isn't transparent.
- UIProcess/API/mac/WKView.mm:
(-[WKView _updateThumbnailViewLayer]):
We currently pull the live layer tree into the WKThumbnailView even in snapshot mode,
before the snapshot arrives, to avoid flashing when transitioning a live WKView to a thumbnail view.
This is, however, not useful for unparented WKViews, because their layer tree will be detached
and we'll flash anyway. So, only do that when the WKView is parented.
- 3:27 PM Changeset in webkit [170215] by
-
- 5 edits in branches/ftlopt/Source/JavaScriptCore
Merge r169903 to the branch.
2014-06-12 Mark Hahnenberg <mhahnenberg@apple.com>
Move structureHasRareData out of TypeInfo
https://bugs.webkit.org/show_bug.cgi?id=133800
Reviewed by Andreas Kling.
StructureHasRareData was originally put in TypeInfo to avoid making Structure bigger,
but we have a few spare bits in Structure so it would be nice to remove this hack.
- runtime/JSTypeInfo.h: (JSC::TypeInfo::newImpurePropertyFiresWatchpoints): (JSC::TypeInfo::structureHasRareData): Deleted.
- runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::allocateRareData): (JSC::Structure::cloneRareDataFrom):
- runtime/Structure.h: (JSC::Structure::previousID): (JSC::Structure::objectToStringValue): (JSC::Structure::setObjectToStringValue): (JSC::Structure::setPreviousID): (JSC::Structure::clearPreviousID): (JSC::Structure::previous): (JSC::Structure::rareData):
- runtime/StructureInlines.h: (JSC::Structure::setEnumerationCache): (JSC::Structure::enumerationCache):
- 3:10 PM Changeset in webkit [170214] by
-
- 3 edits in trunk/Source/WebKit2
WebKit delegate methods should document their default behaviors
https://bugs.webkit.org/show_bug.cgi?id=134132
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKNavigationDelegate.h:
- UIProcess/API/Cocoa/WKUIDelegate.h:
- 3:06 PM Changeset in webkit [170213] by
-
- 2 edits in trunk/Source/WebKit2
Fix lots of WK2 test crashes.
We don't always have a ScrollingCoordinator.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
- 3:05 PM Changeset in webkit [170212] by
-
- 2 edits in trunk/Source/WebKit2
Always use XPC on iOS
https://bugs.webkit.org/show_bug.cgi?id=134130
Reviewed by Sam Weinig.
- UIProcess/ios/WebProcessProxyIOS.mm:
(WebKit::WebProcessProxy::platformGetLaunchOptions):
(WebKit::shouldUseXPC): Deleted.
- 3:00 PM Changeset in webkit [170211] by
-
- 2 edits in trunk/Source/WebKit2
Fix build.
- Shared/SessionState.cpp:
- 2:55 PM Changeset in webkit [170210] by
-
- 3 edits in trunk/Source/WebKit2
Add ArgumentEncoder support to PageState and friends
https://bugs.webkit.org/show_bug.cgi?id=134128
Reviewed by Andreas Kling.
Change the classes to structs, get rid of the constructors/destructors
and add encode member functions.
- Shared/SessionState.cpp:
(WebKit::HTTPBody::Element::encode):
(WebKit::HTTPBody::encode):
(WebKit::FrameState::encode):
(WebKit::PageState::encode):
(WebKit::HTTPBody::Element::Element): Deleted.
(WebKit::HTTPBody::Element::~Element): Deleted.
(WebKit::FrameState::FrameState): Deleted.
(WebKit::FrameState::~FrameState): Deleted.
(WebKit::PageState::PageState): Deleted.
(WebKit::PageState::~PageState): Deleted.
- Shared/SessionState.h:
(WebKit::HTTPBody::Element::type): Deleted.
- 2:36 PM Changeset in webkit [170209] by
-
- 4 edits in trunk/Source
Add encoding and decoding support for WTF::Optional
https://bugs.webkit.org/show_bug.cgi?id=134125
Reviewed by Andreas Kling.
Source/WebKit2:
- Platform/IPC/ArgumentCoders.h:
(IPC::ArgumentCoder<WTF::Optional<T>>::encode):
(IPC::ArgumentCoder<WTF::Optional<T>>::decode):
Source/WTF:
- wtf/Optional.h:
(WTF::Optional::operator=):
- 2:21 PM Changeset in webkit [170208] by
-
- 4 edits30 deletes in trunk/Source/WebCore
Removing dead code in platform/graphics/gpu
https://bugs.webkit.org/show_bug.cgi?id=134065
Reviewed by Simon Fraser.
No new tests because there is no behavior change.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/gpu/LoopBlinnClassifier.cpp: Removed.
- platform/graphics/gpu/LoopBlinnClassifier.h: Removed.
- platform/graphics/gpu/LoopBlinnConstants.h: Removed.
- platform/graphics/gpu/LoopBlinnLocalTriangulator.cpp: Removed.
- platform/graphics/gpu/LoopBlinnLocalTriangulator.h: Removed.
- platform/graphics/gpu/LoopBlinnMathUtils.cpp: Removed.
- platform/graphics/gpu/LoopBlinnMathUtils.h: Removed.
- platform/graphics/gpu/LoopBlinnPathCache.cpp: Removed.
- platform/graphics/gpu/LoopBlinnPathCache.h: Removed.
- platform/graphics/gpu/LoopBlinnPathProcessor.h: Removed.
- platform/graphics/gpu/LoopBlinnShader.cpp: Removed.
- platform/graphics/gpu/LoopBlinnShader.h: Removed.
- platform/graphics/gpu/LoopBlinnSolidFillShader.cpp: Removed.
- platform/graphics/gpu/LoopBlinnSolidFillShader.h: Removed.
- platform/graphics/gpu/LoopBlinnTextureCoords.cpp: Removed.
- platform/graphics/gpu/LoopBlinnTextureCoords.h: Removed.
- platform/graphics/gpu/Shader.cpp: Removed.
- platform/graphics/gpu/Shader.h: Removed.
- platform/graphics/gpu/SharedGraphicsContext3D.cpp: Removed.
- platform/graphics/gpu/SharedGraphicsContext3D.h: Removed.
- platform/graphics/gpu/mac/DrawingBufferMac.mm: Removed.
- platform/graphics/gpu/opencl/FilterContextOpenCL.cpp: Removed.
- platform/graphics/gpu/opencl/FilterContextOpenCL.h: Removed.
- platform/graphics/gpu/opencl/OpenCLFEColorMatrix.cpp: Removed.
- platform/graphics/gpu/opencl/OpenCLFEFlood.cpp: Removed.
- platform/graphics/gpu/opencl/OpenCLFEImage.cpp: Removed.
- platform/graphics/gpu/opencl/OpenCLFEMerge.cpp: Removed.
- platform/graphics/gpu/opencl/OpenCLFESourceAlpha.cpp: Removed.
- platform/graphics/gpu/opencl/OpenCLFESourceGraphic.cpp: Removed.
- platform/graphics/gpu/opencl/OpenCLFETurbulence.cpp: Removed.
- platform/graphics/gpu/opencl/OpenCLHandle.h: Removed.
- 2:17 PM Changeset in webkit [170207] by
-
- 3 edits3 adds in trunk
[iOS] Support Khmer and Lao fallback fonts
https://bugs.webkit.org/show_bug.cgi?id=134114
Reviewed by Enrica Casucci.
Source/WebCore:
iOS has fonts which have glyphs for the Khmer and Lao languages.
This patch also does a little refactoring of the language-specific fallback
font path to increase readability.
Test: fast/text/khmer-lao-font.html
- platform/graphics/ios/FontCacheIOS.mm:
(WebCore::languageSpecificFallbackFont):
(WebCore::FontCache::systemFallbackForCharacters):
LayoutTests:
Simply dump the render tree of a page that includes Khmer and Lao text. The success
of this test depends on font font metrics being different than system fallback font
(which just shows rectangles instead of glyphs).
- fast/text/khmer-lao-font.html: Added.
- platform/ios-sim/fast/text/khmer-lao-font-expected.txt: Added.
- platform/mac/fast/text/khmer-lao-font-expected.txt: Added.
- 2:08 PM Changeset in webkit [170206] by
-
- 2 edits in trunk/Tools
Unreviewed. Adding myself to committers.
- Scripts/webkitpy/common/config/contributors.json:
- 2:03 PM Changeset in webkit [170205] by
-
- 4 edits in trunk/Source
Give NPAPI post requests a default content type
https://bugs.webkit.org/show_bug.cgi?id=134120
Reviewed by Andreas Kling.
Source/WebCore:
- WebCore.exp.in:
Source/WebKit2:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::loadURL):
- 2:00 PM Changeset in webkit [170204] by
-
- 2 edits in trunk/Source/WebKit2
Always commit the scrolling tree when we flush layers
https://bugs.webkit.org/show_bug.cgi?id=134115
Reviewed by Beth Dakin.
The scrolling state tree contains bare pointers to GraphicsLayers, which get
converted to CALayers at commit time. To avoid a window of time where those
GraphicsLayer pointers go stale, commit the scrolling tree whenever we flush the
compositing layer tree.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
- 1:56 PM Changeset in webkit [170203] by
-
- 4 edits2 adds in trunk
REGRESSION (r169972): fix issue when removing masks from compositing layers
https://bugs.webkit.org/show_bug.cgi?id=134118
<rdar://problem/17366654>
Reviewed by Dean Jackson.
Source/WebCore:
After r169972 when removing the mask, we could destroy the mask
layer before the call into m_graphicsLayer->setMaskLayer(), which would
try to call functions on the old mask. Fix by clearing the mask layer
on the GraphicsLayer before the mask layer gets destroyed.
Test: compositing/masks/toggle-mask.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::RenderLayerBacking::updateMaskLayer):
- rendering/RenderLayerBacking.h:
LayoutTests:
Test that toggles the mask on a composited element.
- compositing/masks/toggle-mask-expected.txt: Added.
- compositing/masks/toggle-mask.html: Added.
- 1:54 PM Changeset in webkit [170202] by
-
- 2 edits in trunk/Source/WTF
Add copy/move constructors and assignment operators to WTF::Optional
https://bugs.webkit.org/show_bug.cgi?id=134119
Reviewed by Andreas Kling.
- wtf/Optional.h:
(WTF::Optional::Optional):
(WTF::Optional::operator=):
- 1:48 PM Changeset in webkit [170201] by
-
- 4 edits in trunk/Source
[Cocoa] Release freed up blocks from the JS heap after simulated memory pressure.
<https://webkit.org/b/134112>
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
- heap/BlockAllocator.h:
Source/WebCore:
- platform/cocoa/MemoryPressureHandlerCocoa.mm:
(WebCore::MemoryPressureHandler::install):
- 1:36 PM Changeset in webkit [170200] by
-
- 3 edits in trunk/Source/WebCore
Remove redundant RenderLayer::computeOffsetFromRoot() function.
https://bugs.webkit.org/show_bug.cgi?id=134088
Reviewed by Benjamin Poulain.
No change in functionality.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::computeOffsetFromRoot): Deleted.
- rendering/RenderLayer.h:
- 1:22 PM Changeset in webkit [170199] by
-
- 2 edits in trunk/Tools
Unreviewed. Adding myself to committers.
- Scripts/webkitpy/common/config/contributors.json:
- 12:16 PM Changeset in webkit [170198] by
-
- 11 edits6 adds in trunk
[iOS WebKit2] Make -webkit-overflow-scrolling:touch work in iframes (breaks MSWord previews)
https://bugs.webkit.org/show_bug.cgi?id=134085
Source/WebCore:
<rdar://problem/16440586>
Reviewed by Tim Horton.
When nodes were detached from the scrolling tree, we would previously throw away
all descendant nodes, expecting that they would be re-attached as we walk the compositing
layer tree in RenderLayerCompositor.
However, this doesn't work across frame boundaries; the subframe may never update
its compositing layers again, so would lose all its scrolling nodes.
Fix by having ScrollingStateTree::detachNode() by default set aside subframe nodes
into a hash map. On reattach, we'll look in the hash map and pull out an existing node
(with its children intact) if possible.
Tests: platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor.html
platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor.html
platform/mac-wk2/tiled-drawing/scrolling/frames/remove-coordinated-frame.html
- page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::ScrollingStateNode):
- page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::attachNode):
(WebCore::ScrollingStateTree::detachNode):
(WebCore::ScrollingStateTree::clear):
(WebCore::ScrollingStateTree::removeNodeAndAllDescendants):
(WebCore::ScrollingStateTree::recursiveNodeWillBeRemoved):
- page/scrolling/ScrollingStateTree.h:
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::commitNewTreeState): Go back to removing the deleted
nodes from m_nodeMap first.
(WebCore::ScrollingTree::removeDestroyedNodes): There is no need for this to
actually make use of ScrollingTreeNode* any more; the ASSERT(!node->parent())
is bogus because it can fire when whole subtrees are removed, and to clear the
latched node we just need the ID.
Source/WebKit2:
<rdar://problem/16440586>
Reviewed by Tim Horton.
Add some debug-only assertions that check that the number of nodes we encoded is
the expected number.
- Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
(WebKit::encodeNodeAndDescendants):
(WebKit::RemoteScrollingCoordinatorTransaction::encode):
LayoutTests:
Reviewed by Tim Horton.
Tests that add and remove a fixed container of a scroll-coordinated iframe.
- platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-expected.txt:
- platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor.html: Added.
- platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-in-fixed-expected.txt:
- platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor.html: Added.
- platform/mac-wk2/tiled-drawing/scrolling/frames/remove-coordinated-frame-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/scrolling/frames/remove-coordinated-frame.html: Added.
- platform/mac-wk2/tiled-drawing/scrolling/frames/resources/doc-with-sticky.html:
- 12:14 PM Changeset in webkit [170197] by
-
- 9 edits in trunk/Source
Handle scrolling tree modifications which remove intermediate nodes
https://bugs.webkit.org/show_bug.cgi?id=134082
Reviewed by Tim Horton.
When updating the scrolling tree from the state tree, we failed to maintain
the children arrays correctly. Fix by removing all children on scrolling nodes,
and allowing the calls on children to add them back. A temporary hash map
keeps the nodes alive.
The state tree's m_nodesRemovedSinceLastCommit was also made into a HashSet,
to make it easier to handle removal followed by re-insertion.
Source/WebCore:
- WebCore.exp.in:
- page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::attachNode): If a node is (possibly re-)added,
remove it from m_nodesRemovedSinceLastCommit.remove.
(WebCore::ScrollingStateTree::willRemoveNode):
(WebCore::ScrollingStateTree::setRemovedNodes):
- page/scrolling/ScrollingStateTree.h:
(WebCore::ScrollingStateTree::removedNodes):
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::commitNewTreeState):
(WebCore::ScrollingTree::updateTreeFromStateNode): Clean up to have only one call
to updateBeforeChildren(), and remove all children from the scrolling node
before visiting state children.
(WebCore::ScrollingTree::removeDestroyedNodes): It was very wrong to assume
that all non-root nodes were parented in the root! Now we don't need to
remove from the parent anyway.
- page/scrolling/ScrollingTree.h:
- page/scrolling/ScrollingTreeNode.h:
(WebCore::ScrollingTreeNode::children):
Source/WebKit2:
- Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
(WebKit::RemoteScrollingCoordinatorTransaction::decode):
(WebKit::RemoteScrollingTreeTextStream::dump):
- 12:14 PM Changeset in webkit [170196] by
-
- 29 edits in trunk/Source
Make ScrollingTreeNodes refounted, for easier tree reconfiguration
https://bugs.webkit.org/show_bug.cgi?id=134075
Reviewed by Tim Horton.
Make ScrollingTreeNode be ref-counted.
Source/WebCore:
- page/scrolling/AsyncScrollingCoordinator.h:
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::handleWheelEvent):
(WebCore::ScrollingTree::updateTreeFromStateNode):
- page/scrolling/ScrollingTree.h:
(WebCore::ScrollingTree::rootNode):
- page/scrolling/ScrollingTreeNode.cpp:
(WebCore::ScrollingTreeNode::appendChild):
- page/scrolling/ScrollingTreeNode.h:
- page/scrolling/ThreadedScrollingTree.cpp:
(WebCore::ThreadedScrollingTree::createNode):
- page/scrolling/ThreadedScrollingTree.h:
- page/scrolling/ios/ScrollingCoordinatorIOS.h:
- page/scrolling/ios/ScrollingCoordinatorIOS.mm:
(WebCore::ScrollingCoordinatorIOS::createScrollingTreeNode):
- page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.h:
- page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.mm:
(WebCore::ScrollingTreeFrameScrollingNodeIOS::create):
- page/scrolling/ios/ScrollingTreeIOS.cpp:
(WebCore::ScrollingTreeIOS::createNode):
- page/scrolling/ios/ScrollingTreeIOS.h:
- page/scrolling/mac/ScrollingCoordinatorMac.h:
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::createScrollingTreeNode):
- page/scrolling/mac/ScrollingTreeFixedNode.h:
- page/scrolling/mac/ScrollingTreeFixedNode.mm:
(WebCore::ScrollingTreeFixedNode::create):
- page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h:
- page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
(WebCore::ScrollingTreeFrameScrollingNodeMac::create):
- page/scrolling/mac/ScrollingTreeStickyNode.h:
- page/scrolling/mac/ScrollingTreeStickyNode.mm:
(WebCore::ScrollingTreeStickyNode::create):
Source/WebKit2:
- UIProcess/Scrolling/RemoteScrollingTree.cpp:
(WebKit::RemoteScrollingTree::createNode):
- UIProcess/Scrolling/RemoteScrollingTree.h:
- UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.h:
- UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::create):
- WebProcess/Scrolling/RemoteScrollingCoordinator.h:
- WebProcess/Scrolling/RemoteScrollingCoordinator.mm:
(WebKit::RemoteScrollingCoordinator::createScrollingTreeNode):
- 12:05 PM Changeset in webkit [170195] by
-
- 3 edits in trunk/Source/WebKit2
[Cocoa] No way to get the MIME type of the main frame
https://bugs.webkit.org/show_bug.cgi?id=134111
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _MIMEType]): Added. Returns the MIME type of the main frame, or nil.
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- 11:32 AM Changeset in webkit [170194] by
-
- 8 edits in trunk/Tools
Make WebKit2 more accessible in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=134099
Reviewed by Anders Carlsson.
- MiniBrowser/mac/AppDelegate.h:
- MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate newWindow:]):
(-[BrowserAppDelegate applicationDidFinishLaunching:]):
(-[BrowserAppDelegate toggleUseWebKit2ByDefault:]):
(-[BrowserAppDelegate _useWebKit2ByDefault]):
(-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
(-[BrowserAppDelegate validateMenuItem:]):
- MiniBrowser/mac/MainMenu.xib:
Add a "Use WebKit2 By Default" menu item to the top of the Debug menu.
When switched on, Cmd-N will make WebKit2 windows (and the default window will be WebKit2).
Make the non-default new-window menu item always show up, because people often don't find it
when you have to press option to have it show up.
- MiniBrowser/mac/BrowserWindowController.h:
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController initWithWindow:]):
- MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController validateMenuItem:]):
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController validateMenuItem:]):
Use the cached [menuItem action] like the earlier cases do.
- 11:29 AM Changeset in webkit [170193] by
-
- 3 edits in trunk/Source/WebCore
iOS build fix after http://trac.webkit.org/changeset/170167.
Reviewed by Geoff Garen.
- bindings/js/JSDeviceMotionEventCustom.cpp:
- bindings/js/JSDeviceOrientationEventCustom.cpp:
- 10:58 AM Changeset in webkit [170192] by
-
- 2 edits in trunk/Source/WebKit2
[iOS]: Overrelease of RetainPtr object in file upload
https://bugs.webkit.org/show_bug.cgi?id=134072
Reviewed by Brady Eidson.
This ivar is a RetainPtr, the release will be done automatically
for us when we assign to nil or destruct.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView fileUploadPanelDidDismiss:]):
- 10:57 AM Changeset in webkit [170191] by
-
- 2 edits2 adds in trunk/Source/WebKit2
Begin stubbing out new session state classes
https://bugs.webkit.org/show_bug.cgi?id=134110
Reviewed by Geoffrey Garen.
The basic idea is that these classes will replace the data blobs representing HistoryItems
that we currently send back and forth between the web and UI processes.
- Shared/SessionState.cpp: Added.
(WebKit::HTTPBody::Element::Element):
(WebKit::HTTPBody::Element::~Element):
(WebKit::FrameState::FrameState):
(WebKit::FrameState::~FrameState):
(WebKit::PageState::PageState):
(WebKit::PageState::~PageState):
- Shared/SessionState.h: Added.
(WebKit::HTTPBody::Element::type):
- WebKit2.xcodeproj/project.pbxproj:
- 10:25 AM Changeset in webkit [170190] by
-
- 2 edits in trunk/Source/WebCore
Enable synchronous willSendRequest on iOS
https://bugs.webkit.org/show_bug.cgi?id=134081
<rdar://problem/17350927>
Reviewed by Andreas Kling.
We lost the call to make willSendrequest callbacks be synchronous if possible during code
refactoring. The call is present in ResourceHandleMac.mm but that code is not called when
we use the CFNetwork based loader. Call the SPI in setupRequest().
No new tests because existing tests should cover this functionality.
- platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::setupRequest):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willSendRequest):
- 10:20 AM Changeset in webkit [170189] by
-
- 4 edits in trunk/Tools
Teach run-{safari, webkit-app} about iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=133986
Reviewed by David Kilzer.
Extract the logic from old-run-webkit-tests to install and launch {DumpRenderTree, WebKitTestRunnerApp}.app
into general-purpose routines in webkitdirs.pm so that they can be used both by script old-run-webkit-tests
and run-safari.
- Scripts/old-run-webkit-tests:
(installAndLaunchDumpToolAppUsingNotification): Extracted logic to install and launch {DumpRenderTree,
WebKitTestRunnerApp}.app into webkitdirs::installAndLaunchIOSWebKitAppInSimulator() and modified code
to call it.
(openIPhoneSimulator): Deleted; moved logic to webkitdirs::openIOSSimulator().
(quitIPhoneSimulator): Deleted; moved logic to webkitdirs::quitIOSSimulator().
- Scripts/run-webkit-app: Modified to call runIOSWebKitApp() when the iOS simulator SDK is used
(say, by specifying the optional command-line argument --simulator). For now, die() with an error
when the iOS device SDK is used as we don't support launching an app on the device at this time.
- Scripts/webkitdirs.pm:
(xcodeSDKVersion): Added.
(setupIOSWebKitEnvironment): Added.
(installedMobileSafariBundle): Added.
(mobileSafariBundle): Added.
(plistPathFromBundle): Added.
(appIdentiferFromBundle): Added.
(appDisplayNameFromBundle): Added.
(loadIPhoneSimulatorNotificationIfNeeded): Added.
(openIOSSimulator): Added.
(quitIOSSimulator): Added.
(iosSimulatorDeviceByName): Added.
(iosSimulatorRuntime): Added.
(findOrCreateSimulatorForIOSDevice): Added.
(runIOSWebKitAppInSimulator): Added.
(installAndLaunchIOSWebKitAppInSimulator): Added.
(runIOSWebKitApp): Added.
(runSafari): Modified to call runIOSWebKitAppInSimulator() the iOS simulator SDK is used. For now,
die() with an error when the iOS device SDK is used as we don't support launching Safari on the
device at this time.
- 10:16 AM Changeset in webkit [170188] by
-
- 8 edits2 moves in trunk/Source/WebKit2
Rename SessionState to LegacySessionState
https://bugs.webkit.org/show_bug.cgi?id=134107
Reviewed by Dan Bernstein.
- Shared/LegacySessionState.cpp: Renamed from Source/WebKit2/Shared/SessionState.cpp.
(IPC::ArgumentCoder<RefPtr<T>>::encode):
(IPC::ArgumentCoder<RefPtr<T>>::decode):
(WebKit::LegacySessionState::LegacySessionState):
(WebKit::LegacySessionState::isEmpty):
(WebKit::LegacySessionState::encode):
(WebKit::LegacySessionState::decode):
- Shared/LegacySessionState.h: Renamed from Source/WebKit2/Shared/SessionState.h.
(WebKit::LegacySessionState::list):
(WebKit::LegacySessionState::currentIndex):
- Shared/WebPageCreationParameters.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
- UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::WebPageProxy::restoreFromSessionStateData):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::restoreSession):
(WebKit::WebPage::restoreSessionAndNavigateToCurrentItem):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 9:35 AM Changeset in webkit [170187] by
-
- 4 edits2 adds in trunk
Add WTF::Optional class
https://bugs.webkit.org/show_bug.cgi?id=134083
Reviewed by Andreas Kling.
Source/WTF:
- WTF.xcodeproj/project.pbxproj:
- wtf/Optional.h: Added.
(WTF::Optional::Optional):
(WTF::Optional::~Optional):
(WTF::Optional::operator bool):
(WTF::Optional::value):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/Optional.cpp: Added.
(TestWebKitAPI::TEST):
- 8:39 AM Changeset in webkit [170186] by
-
- 2 edits in trunk/Tools
Adding myself to Commiters list.
- 6:47 AM Changeset in webkit [170185] by
-
- 2 edits in trunk/Source/WebKit2
Document the underlying types of the WKWindowFeatures rect properties
https://bugs.webkit.org/show_bug.cgi?id=134103
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKWindowFeatures.h:
- 3:24 AM Changeset in webkit [170184] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Do not build quota files when QUOTA is disabled
https://bugs.webkit.org/show_bug.cgi?id=134101
Reviewed by Philippe Normand.
- CMakeLists.txt: Remove exception for GTK+ that is no longer
required since r170173.
- PlatformGTK.cmake: Generate GObject DOM bindings for Quota when enabled.
- 1:49 AM Changeset in webkit [170183] by
-
- 2 edits in trunk/Source/WebKit2
PluginProcessMainUnix should only scan for plugins when X11 plugin architecture is enabled
https://bugs.webkit.org/show_bug.cgi?id=134098
Reviewed by Carlos Garcia Campos.
- PluginProcess/unix/PluginProcessMainUnix.cpp: Guard the call to NetscapePluginModule::scanPlugin()
with PLUGIN_ARCHITECTURE(X11) since the declaration has the same build guard. In case the X11 plugin
architecture is not enabled the program exits with EXIT_FAILURE.
- 1:28 AM Changeset in webkit [170182] by
-
- 4 edits in trunk/Source/WebCore
[CSS Grid Layout] Add GridSpan::iterator
https://bugs.webkit.org/show_bug.cgi?id=134058
Reviewed by Bem Jones-Bey.
Once that GridResolvedPosition has been introduced in r169934, this
patch adds a GridSpan::iterator which allows to simplify the loops over
GridResolvedPositions.
From now on we could use range-based for loops.
No new tests as it is already covered by current tests
(fast/css-grid-layout/).
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeNormalizedFractionBreadth): Change loop to
ranged-based for.
(WebCore::RenderGrid::insertItemIntoGrid): Ditto.
(WebCore::RenderGrid::gridAreaBreadthForChild): Ditto.
- rendering/style/GridCoordinate.h: Define GridSpan::iterator.
(WebCore::GridSpan::begin): Return resolved initial position.
(WebCore::GridSpan::end): Return next to resolved final position.
- rendering/style/GridResolvedPosition.h:
(WebCore::GridResolvedPosition::operator*): Add operator required by
range-based for loops.
(WebCore::GridResolvedPosition::operator!=): Add not equal operator.
- 12:55 AM Changeset in webkit [170181] by
-
- 2 edits in trunk/Tools
[EFL] Add gstreamer as dependecy of EFL after r169785
https://bugs.webkit.org/show_bug.cgi?id=134066
Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-06-20
Reviewed by Gyuyoung Kim.
- efl/jhbuild.modules:
- 12:35 AM Changeset in webkit [170180] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix GTK+ debug build after r170174.
- bindings/gobject/WebKitDOMNodeFilter.cpp:
(WebKit::nodeFilterObjectDestroyedCallback):
- 12:33 AM Changeset in webkit [170179] by
-
- 15 edits in trunk/Source
LayerPool’d PlatformCALayerRemote/RemoteLayerBackingStore can have stale context pointers
https://bugs.webkit.org/show_bug.cgi?id=134050
<rdar://problem/17315114>
Reviewed by Simon Fraser.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::recursiveBuildTransaction):
(WebKit::PlatformCALayerRemote::layerPool):
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
- WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
(WebKit::RemoteLayerTreeContext::layerPool):
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::buildTransaction):
Ensure that layers being committed are always in the context that is committing them.
Use a LayerPool per RemoteLayerTreeContext, to avoid moving layers between contexts.
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- platform/cocoa/MemoryPressureHandlerCocoa.mm:
(WebCore::MemoryPressureHandler::platformReleaseMemory):
Drain all LayerPools upon memory pressure.
- platform/graphics/ca/LayerPool.cpp:
(WebCore::LayerPool::LayerPool):
(WebCore::LayerPool::~LayerPool):
(WebCore::LayerPool::allLayerPools):
(WebCore::LayerPool::sharedPool): Deleted.
- platform/graphics/ca/LayerPool.h:
- platform/graphics/ca/PlatformCALayer.cpp:
(WebCore::PlatformCALayer::createCompatibleLayerWithSize):
Add createCompatibleLayerWithSize, which optionally tries to take said layer from the LayerPool.
(WebCore::PlatformCALayer::moveToLayerPool):
Add moveToLayerPool, which moves the layer to the LayerPool.
(WebCore::PlatformCALayer::layerPool):
The LayerPool for each layer is obtained via PlatformCALayer::layerPool(), which subclasses can override for special behaviors.
The base class uses a global LayerPool.
- platform/graphics/ca/PlatformCALayer.h:
- platform/graphics/ca/TileController.cpp:
(WebCore::TileController::createTileLayer):
- platform/graphics/ca/TileGrid.cpp:
(WebCore::TileGrid::removeTiles):
- 12:31 AM Changeset in webkit [170178] by
-
- 4 edits in trunk/Source/WebKit2
WKContentViewInteraction isn't cleaned up when the Web Content process crashes
https://bugs.webkit.org/show_bug.cgi?id=134080
<rdar://problem/17387652> and <rdar://problem/16848360>
Reviewed by Benjamin Poulain.
- UIProcess/ios/WKContentView.mm:
(-[WKContentView _processDidExit]):
Tear down WKContentViewInteraction when the process crashes.
(-[WKContentView _didRelaunchProcess]):
Set WKContentViewInteraction back up when the process is relaunched.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView cleanupInteraction]):
Clear the SmartMagnificationController, which is a message receiver and thus must be re-created with the new page.
Remove all gesture recognizers from the content view.
Clear _fileUploadPanel, else we'll get an assert the next time we try to open one.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::resetStateAfterProcessExited):
Give the PageClient a chance to clean up *before* we clean up internals;
it is at a higher level and some cleanup depends on WebPageProxy members
not having been cleared yet.
- 12:10 AM Changeset in webkit [170177] by
-
- 3 edits in trunk/Tools
[EFL] Merge url_utils.c to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=134095
Reviewed by Csaba Osztrogonác.
url_utils.c is simple code to share between EWebLauncher and MiniBrowser.
This patch removes the dependency of url_utils.c from MiniBrowser to drop WebKit1 EFL port.
- MiniBrowser/efl/CMakeLists.txt:
Remove the EWebLauncher/ from the includes and url_utils.h from the source lists.
- MiniBrowser/efl/main.c:
(has_scheme): Copied from url_utils.c
(url_from_user_input): Ditto.
- 12:00 AM Changeset in webkit [170176] by
-
- 4 edits in trunk/Tools
Fix webkitpy tests after EFL WK1 buildbot and EWS removal - r170172.
Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-06-19
Reviewed by Csaba Osztrogonác.
- Scripts/webkitpy/common/config/ports_unittest.py:
(DeprecatedPortTest.test_gtk_wk2_port):
(DeprecatedPortTest.test_efl_port): Deleted.
- Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase.test_determine_port_from_expectations_path):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineExpectations.test_rebaseline_expectations):
