Timeline
Jun 22, 2014:
- 9:28 PM Changeset in webkit [170282] by
-
- 5 edits in trunk/Source/WebCore
Make offset from ancestor computation explicit by moving it to the callers.
https://bugs.webkit.org/show_bug.cgi?id=134168.
Reviewed by Simon Fraser.
Explicit offset computation helps code reading and less error-prone than passing
the offset pointer and compute it locally when it is null.
No change in functionality.
- rendering/RenderLayer.cpp:
(WebCore::transparencyClipBox):
(WebCore::performOverlapTests):
(WebCore::RenderLayer::setupClipPath):
(WebCore::RenderLayer::setupFilters):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::collectFragments):
(WebCore::RenderLayer::updatePaintingInfoForFragments):
(WebCore::RenderLayer::paintTransformedLayerIntoFragments):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestTransformedLayerInFragments):
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayer.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
- rendering/RenderTreeAsText.cpp:
(WebCore::writeLayers):
- 8:46 PM Changeset in webkit [170281] by
-
- 5 edits in trunk/Source
Versioning.
- 8:42 PM Changeset in webkit [170280] by
-
- 1 copy in tags/Safari-538.42
New Tag.
- 7:25 PM Changeset in webkit [170279] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION(r170163): It made everything crash on EFL
https://bugs.webkit.org/show_bug.cgi?id=134097
Unreviewed EFL layout test and perforamcne crash fix.
- WebProcess/WebPage/WebPage.cpp: Add a null check for m_mainFrame.
(WebKit::WebPage::didCompletePageTransition):
- 7:15 PM Changeset in webkit [170278] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed EFL build fix since r170274. Use reference for m_webPage member variable.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:
(WebKit::CoordinatedDrawingArea::CoordinatedDrawingArea):
(WebKit::CoordinatedDrawingArea::setNeedsDisplay):
(WebKit::CoordinatedDrawingArea::setNeedsDisplayInRect):
(WebKit::CoordinatedDrawingArea::forceRepaint):
(WebKit::CoordinatedDrawingArea::updatePreferences):
(WebKit::CoordinatedDrawingArea::mainFrameContentSizeChanged):
(WebKit::CoordinatedDrawingArea::layerHostDidFlushLayers):
(WebKit::CoordinatedDrawingArea::updateBackingStoreState):
(WebKit::CoordinatedDrawingArea::sendDidUpdateBackingStoreState):
(WebKit::CoordinatedDrawingArea::suspendPainting):
(WebKit::CoordinatedDrawingArea::resumePainting):
(WebKit::CoordinatedDrawingArea::enterAcceleratedCompositingMode):
(WebKit::CoordinatedDrawingArea::display):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:
- 6:32 PM Changeset in webkit [170277] by
-
- 3 edits in trunk/Source/WebKit2
[iOS][wk2] Swiping back sometimes results in a missing (not blank) swipe snapshot
https://bugs.webkit.org/show_bug.cgi?id=134181
Reviewed by Benjamin Poulain.
- UIProcess/ios/ViewGestureControllerIOS.mm:
(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::endSwipeGesture):
(WebKit::ViewGestureController::setRenderTreeSize):
(WebKit::ViewGestureController::removeSwipeSnapshot):
- UIProcess/mac/ViewGestureController.h:
Make it explicit that we should only remove the swipe snapshot when a
big-enough render tree size arrives *after the swipe ends*.
- 6:19 PM Changeset in webkit [170276] by
-
- 1 edit1 add in trunk/LayoutTests
REGRESSION (r170257) http/tests/navigation/javascriptlink-frames.html fails on MountainLion
https://bugs.webkit.org/show_bug.cgi?id=134182
Unreviewed gardening.
- platform/mac-mountainlion/TestExpectations: Added, skip the test.
- 6:02 PM Changeset in webkit [170275] by
-
- 13 edits9 adds in branches/ftlopt
[ftlopt] Fold GetById/PutById to MultiGetByOffset/GetByOffset or MultiPutByOffset/PutByOffset, which implies handling non-singleton sets
https://bugs.webkit.org/show_bug.cgi?id=134090
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
This pretty much finishes off the work to eliminate the special-casing of singleton
structure sets by making it possible to fold GetById and PutById to various polymorphic
forms of the ByOffset nodes.
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeForStubInfo):
(JSC::GetByIdStatus::computeFor):
- bytecode/GetByIdStatus.h:
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
- bytecode/PutByIdStatus.h:
- bytecode/PutByIdVariant.h:
(JSC::PutByIdVariant::constantChecks):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::emitPutByOffset):
(JSC::DFG::ConstantFoldingPhase::addChecks):
- dfg/DFGNode.h:
(JSC::DFG::Node::convertToMultiGetByOffset):
(JSC::DFG::Node::convertToMultiPutByOffset):
- dfg/DFGSpeculativeJIT64.cpp: Also convert all release assertions to DFG assertions in this file, because I was hitting some of them while debugging.
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Strict):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt52):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGStructureAbstractValue.h:
(JSC::DFG::StructureAbstractValue::set):
LayoutTests:
- js/regress/fold-get-by-id-to-multi-get-by-offset-expected.txt: Added.
- js/regress/fold-get-by-id-to-multi-get-by-offset-rare-int-expected.txt: Added.
- js/regress/fold-get-by-id-to-multi-get-by-offset-rare-int.html: Added.
- js/regress/fold-get-by-id-to-multi-get-by-offset.html: Added.
- js/regress/fold-put-by-id-to-multi-put-by-offset-expected.txt: Added.
- js/regress/fold-put-by-id-to-multi-put-by-offset.html: Added.
- js/regress/script-tests/fold-get-by-id-to-multi-get-by-offset-rare-int.js: Added.
(foo):
(fu):
(bar):
(.bar):
(Number):
- js/regress/script-tests/fold-get-by-id-to-multi-get-by-offset.js: Added.
(foo):
(fu):
(bar):
(.bar):
(Number):
- js/regress/script-tests/fold-put-by-id-to-multi-put-by-offset.js: Added.
(foo):
(fu):
(bar):
(.bar):
- 5:51 PM Changeset in webkit [170274] by
-
- 22 edits in trunk/Source/WebKit2
Thread some references through the remote layer tree code
https://bugs.webkit.org/show_bug.cgi?id=134177
Reviewed by Zalan Bujtas.
A first pass at references for never-null things (first pass because I didn't touch the collections).
Things that aren't straightforward reference-threading:
- Shared/mac/RemoteLayerBackingStoreCollection.h:
- Shared/mac/RemoteLayerBackingStoreCollection.mm:
Remove the unimplemented/nonexistant RemoteLayerBackingStoreCollection::create.
Make RemoteLayerBackingStoreCollection constructor not take a context, because m_context is never used.
- WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
Factor out grabbing the PlatformLayerID in a few places.
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
Use WebPage::mainFrameView() instead of WebPage::corePage()->mainFrame().view().
- Shared/mac/RemoteLayerTreeTransaction.h:
- Shared/mac/RemoteLayerTreeTransaction.mm:
- WebProcess/WebPage/DrawingArea.cpp:
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/mac/GraphicsLayerCARemote.h:
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
- WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:
- WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:om):
- WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.cpp:
- WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.h:
- Shared/mac/RemoteLayerBackingStore.mm:
References.
- 5:34 PM Changeset in webkit [170273] by
-
- 5 edits in trunk/Source/WebCore
Transition layer offsets from LayoutPoint to LayoutSize.
https://bugs.webkit.org/show_bug.cgi?id=134156
Reviewed by Simon Fraser.
Use better representation for offset values.
No change in functionality.
- platform/graphics/LayoutSize.h:
(WebCore::roundedForPainting):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::fragmentsBoundingBox):
- rendering/RenderLayer.cpp:
(WebCore::expandClipRectForDescendantsAndReflection):
(WebCore::RenderLayer::convertToLayerCoords):
(WebCore::computeReferenceBox):
(WebCore::RenderLayer::setupClipPath):
(WebCore::RenderLayer::setupFilters):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintLayerByApplyingTransform):
(WebCore::RenderLayer::collectFragments):
(WebCore::RenderLayer::updatePaintingInfoForFragments):
(WebCore::RenderLayer::paintTransformedLayerIntoFragments):
(WebCore::RenderLayer::createLocalTransformState):
(WebCore::RenderLayer::hitTestTransformedLayerInFragments):
(WebCore::RenderLayer::hitTestLayerByApplyingTransform):
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayer.h:
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::collectLayerFragments):
- 5:13 PM Changeset in webkit [170272] by
-
- 2 edits in trunk/Source/WebCore
Attempted iOS build fix.
- platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::~GraphicsContext3D): Cast to WebGLLayer.
- 5:00 PM Changeset in webkit [170271] by
-
- 4 edits in trunk/Source/WebCore
[Apple] WebGL layer may use GC3D after free with remote layer hosting
https://bugs.webkit.org/show_bug.cgi?id=134179
<rdar://problem/17412931>
Reviewed by Tim Horton.
With remote layer hosting, a WebGLLayer may attempt to draw after
the GraphicsContext3D has been destroyed. We need to make sure
the GC3D tells the WebGLLayer that it is no longer valid.
While here, I changed some return 0 to return nullptr, the
name of the ObjC property member from m_context to _context,
and removed some unnecessary .get() calls.
This is tested by run-webkit-tests with the --remote-layer-tree
option.
- platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::GraphicsContext3D): No need for .get().
(WebCore::GraphicsContext3D::~GraphicsContext3D): Set the context reference on WebGLLayer
to be null.
(WebCore::GraphicsContext3D::setRenderbufferStorageFromDrawable): No need for .get().
- platform/graphics/mac/WebGLLayer.h: Set the context reference on WebGLLayer
to be null.
- platform/graphics/mac/WebGLLayer.mm:
(-[WebGLLayer initWithGraphicsContext3D:]): Rename m_context to _context.
(-[WebGLLayer copyCGLPixelFormatForDisplayMask:]): Check for null.
(-[WebGLLayer copyCGLContextForPixelFormat:]): Rename to _context.
(-[WebGLLayer drawInCGLContext:pixelFormat:forLayerTime:displayTime:]): Check for null.
(-[WebGLLayer copyImageSnapshotWithColorSpace:]): Ditto.
(-[WebGLLayer display]): Ditto.
- 11:35 AM Changeset in webkit [170270] by
-
- 4 edits3 adds in trunk
[WK2] Frameset frames are not scrollable after loading (and should be)
https://bugs.webkit.org/show_bug.cgi?id=134151
<rdar://problem/17403365>
Reviewed by Dan Bates.
Source/WebCore:
When loading a <frameset>, we could end up with an empty non-fast-scrollable
region for the main frame, because after the initial frameset document layout,
nothing updated the non-fast scrollable region as the subframes added their
scrollable areas to the the main frame's scrollable area set.
Fix by having addScrollableArea() and removeScrollableArea() trigger an update
of the non-fast scrollable region.
Test: platform/mac-wk2/tiled-drawing/scrolling/frames/frameset-frame-scrollability.html
- page/FrameView.cpp:
(WebCore::FrameView::addScrollableArea):
(WebCore::FrameView::removeScrollableArea):
(WebCore::FrameView::scrollableAreaSetChanged):
- page/FrameView.h:
LayoutTests:
Frameset test that dumps the scrolling tree.
- platform/mac-wk2/tiled-drawing/scrolling/frames/frameset-frame-scrollability.html: Added.
- platform/mac-wk2/tiled-drawing/scrolling/frames/resources/scrollable-page.html: Added.
- 11:21 AM Changeset in webkit [170269] by
-
- 8 edits in trunk/Source/WebKit2
Replace a couple of uses of bind with lambdas
https://bugs.webkit.org/show_bug.cgi?id=134172
Reviewed by Sam Weinig.
- Platform/IPC/Connection.cpp:
(IPC::Connection::postConnectionDidCloseOnConnectionWorkQueue):
(IPC::Connection::connectionDidClose):
(IPC::Connection::dispatchMessage):
(IPC::Connection::dispatchConnectionDidClose): Deleted.
- Platform/IPC/Connection.h:
- Shared/Plugins/NPObjectProxy.cpp:
(WebKit::NPObjectProxy::NP_Deallocate):
- UIProcess/Storage/LocalStorageDatabase.cpp:
(WebKit::LocalStorageDatabase::scheduleDatabaseUpdate):
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::pluginThreadAsyncCall):
(WebKit::NetscapePlugin::handlePluginThreadAsyncCall): Deleted.
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::forceRepaintAsync):
(WebKit::TiledCoreAnimationDrawingArea::dispatchAfterEnsuringUpdatedScrollPosition):
- 11:09 AM Changeset in webkit [170268] by
-
- 36 edits in trunk/Source/WebCore
Unreviewed, rolling out r170265.
https://bugs.webkit.org/show_bug.cgi?id=134174
Broke editing tests (Requested by litherum on #webkit).
Reverted changeset:
"Use unsigneds instead of ints for indexes into a string in
text layout code"
https://bugs.webkit.org/show_bug.cgi?id=133592
http://trac.webkit.org/changeset/170265
- 11:06 AM Changeset in webkit [170267] by
-
- 11 edits in trunk
Have scrollingTreeAsText() dump the non-fast-scrollable region
https://bugs.webkit.org/show_bug.cgi?id=134149
Reviewed by Sam Weinig.
Source/WebCore:
Dump the non-fast-scrollable region (as an array of rects).
- WebCore.exp.in:
- page/scrolling/ScrollingStateFrameScrollingNode.cpp:
(WebCore::ScrollingStateFrameScrollingNode::dumpProperties):
Source/WebKit2:
Dump the non-fast-scrollable region (as an array of rects).
- Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
(WebKit::RemoteScrollingTreeTextStream::dump):
LayoutTests:
Rebaselined.
- platform/mac-wk2/tiled-drawing/scrolling/fixed/fixed-in-overflow-expected.txt:
- platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-expected.txt:
- platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor-expected.txt:
- platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-in-fixed-expected.txt:
- platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor-expected.txt:
- 10:49 AM Changeset in webkit [170266] by
-
- 2 edits in trunk
Disable gamepad feature on EFL and GTK ports by default
https://bugs.webkit.org/show_bug.cgi?id=134169
Reviewed by Brady Eidson.
- Source/cmake/OptionsEfl.cmake: Disable ENABLE_GAMEPAD_DEPRECATED.
- 10:17 AM Changeset in webkit [170265] by
-
- 36 edits in trunk/Source/WebCore
Use unsigneds instead of ints for indexes into a string in text layout code
https://bugs.webkit.org/show_bug.cgi?id=133592
Reviewed by Zalan Bujtas.
Migrate much of the text-handling code to use unsigneds for indexes into a string.
No new tests because there is no behavior change.
- WebCore.exp.in:
- platform/graphics/Font.cpp:
(WebCore::Font::drawText):
(WebCore::Font::drawEmphasisMarks):
(WebCore::Font::adjustSelectionRectForText):
(WebCore::computeUnderlineType):
- platform/graphics/Font.h:
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::getGlyphsAndAdvancesForSimpleText):
(WebCore::Font::drawSimpleText):
(WebCore::Font::drawEmphasisMarksForSimpleText):
(WebCore::Font::drawGlyphBuffer):
(WebCore::Font::drawEmphasisMarks):
(WebCore::Font::adjustSelectionRectForSimpleText):
- platform/graphics/GlyphBuffer.h:
(WebCore::GlyphBuffer::size):
(WebCore::GlyphBuffer::glyphs):
(WebCore::GlyphBuffer::advances):
(WebCore::GlyphBuffer::fontDataAt):
(WebCore::GlyphBuffer::advanceAt):
(WebCore::GlyphBuffer::offsetAt):
(WebCore::GlyphBuffer::reverse):
(WebCore::GlyphBuffer::offsetInString):
(WebCore::GlyphBuffer::swap):
- platform/graphics/GraphicsContext.cpp:
(WebCore::TextRunIterator::atEnd):
- platform/graphics/Latin1TextIterator.h:
(WebCore::Latin1TextIterator::Latin1TextIterator):
(WebCore::Latin1TextIterator::currentCharacter):
- platform/graphics/SimpleFontData.h:
- platform/graphics/SurrogatePairAwareTextIterator.cpp:
(WebCore::SurrogatePairAwareTextIterator::SurrogatePairAwareTextIterator):
- platform/graphics/SurrogatePairAwareTextIterator.h:
(WebCore::SurrogatePairAwareTextIterator::currentCharacter):
- platform/graphics/TextRun.h:
(WebCore::TextRun::length):
(WebCore::TextRun::charactersLength):
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::glyphDataForCharacter):
(WebCore::applyFontTransforms):
(WebCore::WidthIterator::advanceInternal):
(WebCore::WidthIterator::advance):
(WebCore::WidthIterator::advanceOneCharacter):
- platform/graphics/WidthIterator.h:
- platform/graphics/cairo/FontCairo.cpp:
(WebCore::Font::drawGlyphs):
- platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
(WebCore::Font::adjustSelectionRectForComplexText):
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::setNormalizedBuffer):
- platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::adjustSelectionRectForComplexText):
(WebCore::Font::getGlyphsAndAdvancesForComplexText):
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
- platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
- platform/graphics/win/FontCGWin.cpp:
(WebCore::Font::drawGlyphs):
- platform/graphics/win/FontWin.cpp:
(WebCore::Font::adjustSelectionRectForComplexText):
(WebCore::Font::getGlyphsAndAdvancesForComplexText):
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
- platform/graphics/wince/FontWinCE.cpp:
(WebCore::Font::drawGlyphs):
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
(WebCore::Font::selectionRectForComplexText):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::isSelected):
(WebCore::InlineTextBox::selectionState):
(WebCore::adjustCharactersAndLengthForHyphen):
(WebCore::InlineTextBox::localSelectionRect):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::selectionStartEnd):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDocumentMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
(WebCore::InlineTextBox::paintCompositionUnderline):
(WebCore::InlineTextBox::positionForOffset):
(WebCore::InlineTextBox::constructTextRun):
- rendering/InlineTextBox.h:
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::getStringToRender):
- rendering/RenderCombineText.h:
- rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::positionForOffset):
(WebCore::SVGInlineTextBox::localSelectionRect):
(WebCore::SVGInlineTextBox::paintSelectionBackground):
(WebCore::SVGInlineTextBox::mapStartEndPositionsIntoFragmentCoordinates):
(WebCore::SVGInlineTextBox::paintText):
- rendering/svg/SVGInlineTextBox.h:
- rendering/svg/SVGTextMetricsBuilder.cpp:
(WebCore::SVGTextMetricsBuilder::currentCharacterStartsSurrogatePair):
(WebCore::SVGTextMetricsBuilder::advance):
- rendering/svg/SVGTextQuery.cpp:
(WebCore::SVGTextQuery::mapStartEndPositionsIntoFragmentCoordinates):
(WebCore::SVGTextQuery::modifyStartEndPositionsRespectingLigatures):
(WebCore::SVGTextQuery::subStringLengthCallback):
(WebCore::SVGTextQuery::startPositionOfCharacterCallback):
(WebCore::SVGTextQuery::endPositionOfCharacterCallback):
(WebCore::SVGTextQuery::rotationOfCharacterCallback):
(WebCore::SVGTextQuery::extentOfCharacterCallback):
(WebCore::SVGTextQuery::characterNumberAtPositionCallback):
- rendering/svg/SVGTextQuery.h:
- rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGGlyphToPathTranslator::SVGGlyphToPathTranslator):
(WebCore::SVGTextRunRenderingContext::glyphDataForCharacter):
- rendering/svg/SVGTextRunRenderingContext.h:
- svg/SVGFontData.cpp:
(WebCore::SVGFontData::applySVGGlyphSelection):
- svg/SVGFontData.h:
- 9:58 AM Changeset in webkit [170264] by
-
- 3 edits in trunk/Source/WebKit2
Add IPC decoding support to BackForwardListState
https://bugs.webkit.org/show_bug.cgi?id=134171
Reviewed by Dan Bernstein.
- Shared/SessionState.cpp:
(WebKit::isValidEnum):
(WebKit::HTTPBody::Element::decode):
(WebKit::HTTPBody::decode):
(WebKit::FrameState::decode):
(WebKit::PageState::decode):
(WebKit::BackForwardListState::decode):
- Shared/SessionState.h:
- 9:47 AM Changeset in webkit [170263] by
-
- 2 edits in trunk/Source/WebKit2
Address a review comment.
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::HistoryEntryDataDecoder::markInvalid):
(WebKit::decodeFormDataElement):
- 9:34 AM Changeset in webkit [170262] by
-
- 2 edits in trunk/Source/WebKit2
Implement the rest of back forward tree decoding
https://bugs.webkit.org/show_bug.cgi?id=134166
Reviewed by Sam Weinig.
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::HistoryEntryDataDecoder::operator>>):
(WebKit::decodeFormDataElement):
(WebKit::decodeFormData):
(WebKit::decodeBackForwardTreeNode):
- 9:33 AM Changeset in webkit [170261] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] WKWebViewConfiguration.allowsInlineMediaPlayback has no effect
https://bugs.webkit.org/show_bug.cgi?id=134170
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]): Fixed a typo.
Jun 21, 2014:
- 10:52 PM Changeset in webkit [170260] by
-
- 2 edits in trunk/Tools
Disable gamepad feature on EFL and GTK ports by default
https://bugs.webkit.org/show_bug.cgi?id=134169
Reviewed by Brady Eidson.
EFL and GTK ports disabled Gamepad feature now. Besides current implementation
was treated to 'deprecated' status.
ENABLE_GAMEPAD_DEPRECATED is disabled for now. There is build break on EFL port.
- Scripts/webkitperl/FeatureList.pm:
- 10:50 PM Changeset in webkit [170259] by
-
- 2 edits in trunk/Source/WebCore
createCairoGLSurface should take in a FloatSize reference as its first parameter
https://bugs.webkit.org/show_bug.cgi?id=134159
Reviewed by Martin Robinson.
The ImageBuffer constructor operates with a FloatSize reference, which is also
passed to createCairoGLSurface when accelerated 2D canvas support is enabled.
That function should take in a reference to the same type.
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::createCairoGLSurface):
- 10:46 PM Changeset in webkit [170258] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Fixing the GTK+ build after r170253.
- UIProcess/API/gtk/WebKitSettings.cpp:
(_WebKitSettingsPrivate::_WebKitSettingsPrivate): WebPreferences::create()
now takes an additional String argument.
- 4:55 PM Changeset in webkit [170257] by
-
- 46 edits3 adds in trunk
[Mac] Margins for new form controls need tweaking
https://bugs.webkit.org/show_bug.cgi?id=134135
<rdar://problem/17262164>
Reviewed by Sam Weinig.
Source/WebCore:
Take 2 of this patch. Only the mac-mountainlion LayoutTest
results are different from the first attempt.
With the newer animated controls in OS X Yosemite, we need
to tweak the fudge-factor margins for positioning. In a recent
patch I added another fudge, which I'm removing with this. I'm
not sure where the older values came from, but I've checked with
the latest AppKit sources and am using the sizes they implement
for the controls.
This will rebaseline a lot of tests, since I've made small tweaks
to the form layout.
- platform/mac/ThemeMac.mm:
(WebCore::checkboxMargins): New margin amounts.
(WebCore::radioSizes): New sizes.
(WebCore::radioMargins): New margin amounts.
(WebCore::paintToggleButton): No need to call the positioning fudge any more.
(WebCore::checkboxOffsets): Deleted.
(WebCore::radioOffsets): Deleted.
LayoutTests:
Take 2 of this patch adds some Mountain Lion results.
Rebaseline a bunch of results since some <input> dimensions
changed slightly.
- platform/mac-mountainlion/fast/block/margin-collapse/103-expected.txt:
- platform/mac-mountainlion/fast/forms/basic-inputs-expected.png: Added.
- platform/mac-mountainlion/fast/forms/basic-inputs-expected.txt:
- platform/mac-mountainlion/fast/forms/box-shadow-override-expected.txt:
- platform/mac-mountainlion/fast/forms/form-element-geometry-expected.png: Added.
- platform/mac-mountainlion/fast/forms/form-element-geometry-expected.txt:
- platform/mac-mountainlion/fast/forms/input-appearance-height-expected.txt:
- platform/mac-mountainlion/fast/forms/input-value-expected.txt:
- platform/mac-mountainlion/fast/replaced/replaced-breaking-expected.txt:
- platform/mac-mountainlion/http/tests/navigation/javascriptlink-frame-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug4527-expected.txt:
- platform/mac/css1/box_properties/acid_test-expected.png:
- platform/mac/css1/box_properties/acid_test-expected.txt:
- platform/mac/css2.1/t09-c5526c-display-00-e-expected.png:
- platform/mac/css2.1/t09-c5526c-display-00-e-expected.txt:
- platform/mac/fast/block/basic/011-expected.png:
- platform/mac/fast/block/basic/011-expected.txt:
- platform/mac/fast/block/margin-collapse/103-expected.png:
- platform/mac/fast/block/margin-collapse/103-expected.txt:
- platform/mac/fast/forms/basic-inputs-expected.png:
- platform/mac/fast/forms/basic-inputs-expected.txt:
- platform/mac/fast/forms/box-shadow-override-expected.png:
- platform/mac/fast/forms/box-shadow-override-expected.txt:
- platform/mac/fast/forms/form-element-geometry-expected.png:
- platform/mac/fast/forms/form-element-geometry-expected.txt:
- platform/mac/fast/forms/formmove-expected.txt:
- platform/mac/fast/forms/formmove2-expected.png:
- platform/mac/fast/forms/formmove2-expected.txt:
- platform/mac/fast/forms/input-appearance-height-expected.png:
- platform/mac/fast/forms/input-appearance-height-expected.txt:
- platform/mac/fast/forms/input-value-expected.png:
- platform/mac/fast/forms/input-value-expected.txt:
- platform/mac/fast/inline/positionedLifetime-expected.txt:
- platform/mac/fast/replaced/replaced-breaking-expected.png:
- platform/mac/fast/replaced/replaced-breaking-expected.txt:
- platform/mac/fast/replaced/width100percent-radio-expected.txt:
- platform/mac/http/tests/navigation/javascriptlink-frames-expected.png:
- platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1318-expected.png:
- platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4527-expected.png:
- platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/captions1-expected.png:
- platform/mac/tables/mozilla_expected_failures/core/captions1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/captions2-expected.png:
- platform/mac/tables/mozilla_expected_failures/core/captions2-expected.txt:
- 4:27 PM Changeset in webkit [170256] by
-
- 39 edits in trunk/Source
Remove static tables for bindings that use eager reification
https://bugs.webkit.org/show_bug.cgi?id=134126
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
- runtime/JSObject.cpp:
(JSC::JSObject::putDirectCustomAccessor):
- runtime/Structure.h:
(JSC::Structure::setHasCustomGetterSetterProperties):
Change setHasCustomGetterSetterProperties to behave like setHasGetterSetterProperties, and set
the m_hasReadOnlyOrGetterSetterPropertiesExcludingProto bit if the property is not proto.
Without this, JSObject::put() won't think there are any setters on the prototype chain of an
object that has no static lookup table and uses eagerly reified custom getter/setter properties.
Source/WebCore:
This shaves about 1MB off of WebCore's .o files.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorHelperMethods):
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
- bindings/scripts/test/JS/JSTestActiveDOMObject.h:
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
- bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
- bindings/scripts/test/JS/JSTestEventConstructor.h:
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
- bindings/scripts/test/JS/JSTestEventTarget.h:
- bindings/scripts/test/JS/JSTestException.cpp:
- bindings/scripts/test/JS/JSTestException.h:
- bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
- bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestInterface.h:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
- bindings/scripts/test/JS/JSTestNamedConstructor.h:
- bindings/scripts/test/JS/JSTestNode.cpp:
- bindings/scripts/test/JS/JSTestNode.h:
- bindings/scripts/test/JS/JSTestNondeterministic.cpp:
- bindings/scripts/test/JS/JSTestNondeterministic.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
- bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
- bindings/scripts/test/JS/JSTestTypedefs.h:
- bindings/scripts/test/JS/JSattribute.cpp:
- bindings/scripts/test/JS/JSattribute.h:
- bindings/scripts/test/JS/JSreadonly.cpp:
- bindings/scripts/test/JS/JSreadonly.h:
- 3:33 PM Changeset in webkit [170255] by
-
- 2 edits in trunk/Source/WebKit/mac
Tried to fix the iOS build after r170235.
- WebView/WebView.mm:
- 3:25 PM Changeset in webkit [170254] by
-
- 3 edits in trunk/Source/WebKit2
CallbackMap::put should be able to take an unwrapped function
https://bugs.webkit.org/show_bug.cgi?id=134104
Reviewed by Anders Carlsson.
- UIProcess/GenericCallback.h:
(WebKit::CallbackMap::put): Added an overload that takes a function and creates and puts a
callback. Changed both overloads of put() to return the callback ID.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::validateCommand):
(WebKit::WebPageProxy::runJavaScriptInMainFrame):
(WebKit::WebPageProxy::getRenderTreeExternalRepresentation):
(WebKit::WebPageProxy::getSourceForFrame):
(WebKit::WebPageProxy::getContentsAsString):
(WebKit::WebPageProxy::getBytecodeProfile):
(WebKit::WebPageProxy::getContentsAsMHTMLData):
(WebKit::WebPageProxy::getSelectionOrContentsAsString):
(WebKit::WebPageProxy::getSelectionAsWebArchiveData):
(WebKit::WebPageProxy::getMainResourceDataOfFrame):
(WebKit::WebPageProxy::getResourceDataFromFrame):
(WebKit::WebPageProxy::getWebArchiveOfFrame):
(WebKit::WebPageProxy::getMarkedRangeAsync):
(WebKit::WebPageProxy::getSelectedRangeAsync):
(WebKit::WebPageProxy::characterIndexForPointAsync):
(WebKit::WebPageProxy::firstRectForCharacterRangeAsync):
(WebKit::WebPageProxy::takeSnapshot):
- 3:02 PM Changeset in webkit [170253] by
-
- 11 edits in trunk/Source/WebKit2
Make it possible to override debug preferences on a per-identifier basis as well as globally
https://bugs.webkit.org/show_bug.cgi?id=134164
Reviewed by Dan Bernstein.
- Shared/WebPreferencesDefinitions.h:
- Shared/WebPreferencesKeys.cpp:
- Shared/WebPreferencesKeys.h:
- Shared/WebPreferencesStore.cpp:
(WebKit::defaults):
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesCreate):
(WKPreferencesCreateWithIdentifier):
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences init]):
- UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::WebPageGroup):
- UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::create):
(WebKit::WebPreferences::createWithLegacyDefaults):
(WebKit::WebPreferences::WebPreferences):
- UIProcess/WebPreferences.h:
- UIProcess/mac/WebPreferencesMac.mm:
(WebKit::makeKey):
(WebKit::debugUserDefaultsValue):
(WebKit::setDebugBoolValueIfInUserDefaults):
(WebKit::WebPreferences::platformInitializeStore):
- 2:01 PM Changeset in webkit [170252] by
-
- 2 edits in trunk/Source/WebKit2
Begin work on decoding form data
https://bugs.webkit.org/show_bug.cgi?id=134163
Reviewed by Sam Weinig.
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::HistoryEntryDataDecoder::operator>>):
(WebKit::HistoryEntryDataDecoder::isValid):
(WebKit::isValidEnum):
(WebKit::decodeFormDataElement):
(WebKit::decodeFormData):
(WebKit::decodeBackForwardTreeNode):
- 1:05 PM Changeset in webkit [170251] by
-
- 2 edits in trunk/Source/WebKit2
Only initialize WebPreferences from NSUserDefaults if there's an identifier
https://bugs.webkit.org/show_bug.cgi?id=134162
Reviewed by Sam Weinig.
We don't want to allow changing preferences by registering user defaults.
- UIProcess/mac/WebPreferencesMac.mm:
(WebKit::makeKey):
(WebKit::WebPreferences::platformInitializeStore):
- 12:41 PM Changeset in webkit [170250] by
-
- 2 edits in trunk/Source/WebKit2
Begin work on decoding the back/forward tree
https://bugs.webkit.org/show_bug.cgi?id=134161
Reviewed by Sam Weinig.
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntries):
(WebKit::HistoryEntryDataDecoder::operator>>):
(WebKit::HistoryEntryDataDecoder::decodeArithmeticType):
(WebKit::HistoryEntryDataDecoder::bufferIsLargeEnoughToContain):
(WebKit::decodeBackForwardTreeNode):
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntryData):
(WebKit::HistoryEntryDataDecoder::decode): Deleted.
- 12:07 PM Changeset in webkit [170249] by
-
- 22 edits9 moves1 add in trunk
Gamepad API - Deprecate the existing implementation
https://bugs.webkit.org/show_bug.cgi?id=134108
Reviewed by Timothy Hatcher.
-Add new "GAMEPAD_DEPRECATED" build flag, moving the existing implementation to use it
.:
-Add the "Deprecated" suffix to some implementation files
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
-Move some implementation files into a "deprecated" subdirectory.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
-Move some implementation files into a "deprecated" subdirectory.
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- PlatformGTK.cmake:
- Modules/gamepad/deprecated/Gamepad.cpp: Renamed from Source/WebCore/Modules/gamepad/Gamepad.cpp.
- Modules/gamepad/deprecated/Gamepad.h: Renamed from Source/WebCore/Modules/gamepad/Gamepad.h.
- Modules/gamepad/deprecated/Gamepad.idl: Renamed from Source/WebCore/Modules/gamepad/Gamepad.idl.
- Modules/gamepad/deprecated/GamepadList.cpp: Renamed from Source/WebCore/Modules/gamepad/GamepadList.cpp.
- Modules/gamepad/deprecated/GamepadList.h: Renamed from Source/WebCore/Modules/gamepad/GamepadList.h.
- Modules/gamepad/deprecated/GamepadList.idl: Renamed from Source/WebCore/Modules/gamepad/GamepadList.idl.
- Modules/gamepad/deprecated/NavigatorGamepad.cpp: Renamed from Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp.
- Modules/gamepad/deprecated/NavigatorGamepad.h: Renamed from Source/WebCore/Modules/gamepad/NavigatorGamepad.h.
- Modules/gamepad/deprecated/NavigatorGamepad.idl: Renamed from Source/WebCore/Modules/gamepad/NavigatorGamepad.idl.
- platform/Gamepads.h:
- platform/efl/GamepadsEfl.cpp:
- platform/gtk/GamepadsGtk.cpp:
- platform/linux/GamepadDeviceLinux.cpp:
- platform/linux/GamepadDeviceLinux.h:
Source/WebKit/mac:
-Move some implementation files into a "deprecated" subdirectory.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
-Move some implementation files into a "deprecated" subdirectory.
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
-Move some implementation files into a "deprecated" subdirectory.
- wtf/FeatureDefines.h:
- 11:52 AM Changeset in webkit [170248] by
-
- 2 edits in trunk/Source/WebKit2
Implement more of HistoryEntryDataDecoder
https://bugs.webkit.org/show_bug.cgi?id=134146
Reviewed by Sam Weinig.
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::HistoryEntryDataDecoder::HistoryEntryDataDecoder):
(WebKit::HistoryEntryDataDecoder::operator>>):
(WebKit::HistoryEntryDataDecoder::decode):
(WebKit::HistoryEntryDataDecoder::decodeFixedLengthData):
(WebKit::HistoryEntryDataDecoder::alignBufferPosition):
(WebKit::HistoryEntryDataDecoder::alignedBuffer):
(WebKit::HistoryEntryDataDecoder::alignedBufferIsLargeEnoughToContain):
(WebKit::HistoryEntryDataDecoder::markInvalid):
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntryData):
- 11:27 AM Changeset in webkit [170247] by
-
- 2 edits in trunk/Source/WebCore
Mark TextRun's constructors as explicit
https://bugs.webkit.org/show_bug.cgi?id=134124
Reviewed by Sam Weinig.
After r170072, nobody is implicitly converting a string to a TextRun. Therefore,
we can make the constructors explicit.
No new tests because there is no behavior change.
- platform/graphics/TextRun.h:
(WebCore::TextRun::TextRun):
- 9:24 AM Changeset in webkit [170246] by
-
- 25 edits6 moves in trunk
Unreviewed, rolling out r170244.
https://bugs.webkit.org/show_bug.cgi?id=134157
GTK/EFL bindings generator works differently, making this
patch not work there. Will fix entire patch after a rollout.
(Requested by bradee-oh on #webkit).
Reverted changeset:
"Gamepad API - Deprecate the existing implementation"
https://bugs.webkit.org/show_bug.cgi?id=134108
http://trac.webkit.org/changeset/170244
- 8:55 AM Changeset in webkit [170245] by
-
- 2 edits in trunk/Source/WebCore
Fix the mismatched header build guards in WebKitDOMNodeFilterPrivate.h
which are throwing compilation warnings when building with Clang.
- bindings/gobject/WebKitDOMNodeFilterPrivate.h:
- 8:43 AM Changeset in webkit [170244] by
-
- 25 edits6 moves in trunk
Gamepad API - Deprecate the existing implementation
https://bugs.webkit.org/show_bug.cgi?id=134108
Reviewed by Timothy Hatcher.
-Add new "GAMEPAD_DEPRECATED" build flag, moving the existing implementation to use it
-Add the "Deprecated" suffix to some implementation files
.:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- CMakeLists.txt:
- PlatformGTK.cmake:
- Configurations/FeatureDefines.xcconfig:
- Modules/gamepad/GamepadDeprecated.cpp: Renamed from Source/WebCore/Modules/gamepad/Gamepad.cpp.
- Modules/gamepad/GamepadDeprecated.h: Renamed from Source/WebCore/Modules/gamepad/Gamepad.h.
- Modules/gamepad/GamepadDeprecated.idl: Renamed from Source/WebCore/Modules/gamepad/Gamepad.idl.
- Modules/gamepad/GamepadList.cpp:
- Modules/gamepad/GamepadList.h:
- Modules/gamepad/GamepadList.idl:
- Modules/gamepad/NavigatorGamepadDeprecated.cpp: Renamed from Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp.
- Modules/gamepad/NavigatorGamepadDeprecated.h: Renamed from Source/WebCore/Modules/gamepad/NavigatorGamepad.h.
- Modules/gamepad/NavigatorGamepadDeprecated.idl: Renamed from Source/WebCore/Modules/gamepad/NavigatorGamepad.idl.
- platform/Gamepads.h:
- platform/efl/GamepadsEfl.cpp:
- platform/gtk/GamepadsGtk.cpp:
- platform/linux/GamepadDeviceLinux.cpp:
- platform/linux/GamepadDeviceLinux.h:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
- 8:06 AM Changeset in webkit [170243] by
-
- 6 edits in trunk/Source/WebKit2
[CoordinatedGraphics][WK2][EFL] Page is moved to (0,0) position before rendering content
https://bugs.webkit.org/show_bug.cgi?id=133300
Reviewed by Csaba Osztrogonác.
When new page is loaded, PageViewportController::didCommitLoad() calls PageViewportController::syncVisibleContents()
with initial position via applyPositionAfterRenderingContents() before starting to render
new page by PageViewportController::didRenderFrame(). This call flow causes that webview shows
incomplete tiles to the user during a few milliseconds. To fix showing incomplete tiles during
the page loading, this patch adds a flag so that we don't show the incomplete tiles until showing
new page.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
- UIProcess/API/efl/EwkView.h:
(EwkView::setWaitingForNewPage):
(EwkView::waitingForNewPage):
- UIProcess/efl/PageLoadClientEfl.cpp:
(WebKit::PageLoadClientEfl::didCommitLoadForFrame):
- UIProcess/efl/PageViewportControllerClientEfl.cpp:
(WebKit::PageViewportControllerClientEfl::didChangeVisibleContents):
- UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::didRenderFrame):
(WebKit::ViewClientEfl::didCompletePageTransition):
- 8:02 AM Changeset in webkit [170242] by
-
- 38 edits in trunk
Unreviewed, rolling out r170228.
https://bugs.webkit.org/show_bug.cgi?id=134155
Caused 9 layout test failures on Mountain Lion
http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK2%20(Tests)/builds/19216
(Requested by bradee-oh on #webkit).
Reverted changeset:
"[Mac] Margins for new form controls need tweaking"
https://bugs.webkit.org/show_bug.cgi?id=134135
http://trac.webkit.org/changeset/170228
- 7:59 AM Changeset in webkit [170241] by
-
- 3 edits in trunk/Source/WebCore
[Mac] Create and attach the AVPlayerLayer to the AVPlayer immediately if the media element is <video>.
https://bugs.webkit.org/show_bug.cgi?id=134131
Reviewed by Eric Carlson.
The AVPlayer uses the presence of an AVPlayerLayer to decide which alternate to display in the case of
HLS streams with audio-only alternates. To give the AVPlayer the most information with which to make its
decision, always create and attach an AVPlayerLayer before attaching an AVPlayerItem to the AVPlayerLayer.
In addition, retrieve the <video> element bounds and create an AVPlayerLayer with a matching size, so that
the AVPlayer can choose an alternate with the correct dimensions.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasLayerRenderer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformLayer):
- 7:55 AM Changeset in webkit [170240] by
-
- 25 edits in trunk/Source/WebInspectorUI
Web Inspector: UI fonts should pull from system fonts automatically to whatever degree possible
https://bugs.webkit.org/show_bug.cgi?id=133966
Reviewed by Timothy Hatcher.
Updated font families to use -webkit-system-font, and set this on the body to be
inherited. Also made sure that popovers use Menlo as the default. Updated
autocompletions with system font names.
- UserInterface/Models/CSSKeywordCompletions.js: Updated completions with available system fonts.
- UserInterface/Controllers/CodeMirrorGradientEditingController.css:
- UserInterface/Views/Breakpoint.css:
- UserInterface/Views/ButtonNavigationItem.css:
- UserInterface/Views/ButtonToolbarItem.css:
- UserInterface/Views/CSSStyleDeclarationSection.css:
- UserInterface/Views/CSSStyleDeclarationTextEditor.css:
- UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
- UserInterface/Views/CodeMirrorOverrides.css:
- UserInterface/Views/DataGrid.css:
- UserInterface/Views/DebuggerDashboardView.css:
- UserInterface/Views/DetailsSection.css:
- UserInterface/Views/FindBanner.css:
- UserInterface/Views/GoToLineDialog.css:
- UserInterface/Views/HierarchicalPathComponent.css:
- UserInterface/Views/Main.css:
- UserInterface/Views/NavigationSidebarPanel.css:
- UserInterface/Views/ProbeSetDataGrid.css:
- UserInterface/Views/RulesStyleDetailsPanel.css:
- UserInterface/Views/ScopeBar.css:
- UserInterface/Views/SourceCodeTextEditor.css:
- UserInterface/Views/TimelineDataGrid.css:
- UserInterface/Views/TimelineRuler.css:
- UserInterface/Views/TimelineSidebarPanel.css:
Changes to fonts. Set default font stack to -webkit-system-font, sans-serif. Default size is
11px. Only changes to this default size or changes to the font (to Menlo, monospace usually) remain.
- 7:52 AM Changeset in webkit [170239] by
-
- 2 edits in trunk/Source/WebCore
Implement ios -[WAKWindow convertBaseToScreen:]
https://bugs.webkit.org/show_bug.cgi?id=134053
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-06-21
Reviewed by Eric Carlson.
- platform/ios/wak/WAKWindow.mm:
(-[WAKWindow convertBaseToScreen:]):
Traverse layer hierarchy and convert point.
(-[WAKWindow convertScreenToBase:]):
Traverse layer hierarchy and convert point.
- 7:51 AM Changeset in webkit [170238] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Esc in quick console no longer toggles console drawer
https://bugs.webkit.org/show_bug.cgi?id=134068
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-06-21
Reviewed by Timothy Hatcher.
For Escape to toggle console behavior we were relying on the Escape
keyboard event to propagate up to the window and be handled by
QuickConsole's global keyboard shortcut. With CodeMirror 4, all
editors have a default "Esc" key handler to reduce multiple selections
to a single selection. Unfortunately this always prevents default,
which our keyboard shortcut respects and doesn't toggle the console.
Workaround this by putting a specific handler for when a Console
Prompt is empty and the Escape key is triggered. This does not go
through the normal ConsolePrompt delegate because the delegate
is never the QuickConsole, it is actually the JavaScript log.
- UserInterface/Views/ConsolePrompt.js:
(WebInspector.ConsolePrompt):
(WebInspector.ConsolePrompt.prototype.set escapeKeyHandlerWhenEmpty):
(WebInspector.ConsolePrompt.prototype._handleEscapeKey):
- UserInterface/Views/QuickConsole.js:
(WebInspector.QuickConsole.this.prompt.escapeKeyHandlerWhenEmpty):
(WebInspector.QuickConsole):
- 7:43 AM Changeset in webkit [170237] by
-
- 2 edits in trunk/Source/WebKit2
Commit queue has been failing due to a build failure in WKFoundation.h
https://bugs.webkit.org/show_bug.cgi?id=134152
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2014-06-21
Reviewed by Csaba Osztrogonác.
Landed by Brady Eidson.
The build failure was caused by WKFoundation.h erroneously redefining
NSURLSessionAuthChallengeDisposition even when building with 10.9 SDK.
The availability of this type depends on the version of SDK,
not the target operating system.
- Shared/API/Cocoa/WKFoundation.h:
- 1:53 AM Changeset in webkit [170236] by
-
- 2 edits1 add in trunk/Tools
[Inspector][EFL] Can't resume a special break point on EFL inspector
https://bugs.webkit.org/show_bug.cgi?id=129294
Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-06-21
Reviewed by Gyuyoung Kim.
Patch our EFL 1.9 with the fix landed in upstream EFL 1.10
by Ryuan Choi - <https://phab.enlightenment.org/D790>
- efl/jhbuild.modules:
- efl/patches/ecore.patch: Added.
- 1:49 AM Changeset in webkit [170235] by
-
- 39 edits in trunk
Removing PAGE_VISIBILITY_API compile guard.
https://bugs.webkit.org/show_bug.cgi?id=133844
Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-06-21
Reviewed by Gavin Barraclough.
.:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
No new tests because no functional changes.
- Configurations/FeatureDefines.xcconfig:
- Modules/vibration/NavigatorVibration.cpp:
(WebCore::NavigatorVibration::vibrate):
- dom/Document.cpp:
(WebCore::Document::hidden):
- dom/Document.h:
- dom/Document.idl:
- dom/Element.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::registerWithDocument):
(WebCore::HTMLMediaElement::unregisterWithDocument):
(WebCore::HTMLMediaElement::parseAttribute):
- html/HTMLMediaElement.h:
- page/Page.cpp:
(WebCore::Page::setIsVisibleInternal):
(WebCore::Page::visibilityState):
(WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged):
- page/Page.h:
- page/PageVisibilityState.cpp:
- page/PageVisibilityState.h:
- page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setHiddenPageCSSAnimationSuspensionEnabled):
- page/Settings.h:
- platform/audio/MediaSession.cpp:
(WebCore::MediaSession::updateClientDataBuffering):
- platform/audio/MediaSession.h:
Source/WebKit/efl:
- ewk/ewk_view.cpp:
(ewk_view_visibility_state_set):
(ewk_view_visibility_state_get):
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
(-[WebView _visibilityState]):
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.props:
- win/tools/vsprops/FeatureDefinesCairo.props:
- 1:46 AM Changeset in webkit [170234] by
-
- 2 edits in trunk/Source/JavaScriptCore
ARM traditional buildfix after r169942.
https://bugs.webkit.org/show_bug.cgi?id=134100
Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-06-21
Reviewed by Zoltan Herczeg.
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::abortWithReason): Added.
- 1:07 AM Changeset in webkit [170233] by
-
- 2 edits in trunk/Source/WebCore
[GTK][EFL] Use OpenType MATH fonts by default.
https://bugs.webkit.org/show_bug.cgi?id=133604
Reviewed by Chris Fleizach.
In order to support stretching of horizontal operators and large
operators in display mode as well as to improve the drawing of radicals,
we need to use an OpenType MATH table. This commit makes the MathML code
try "Latin Modern Math" first, which is an OpenType version of Knuth's
popular Computer Modern font and is packaged with most TeX
distributions (e.g. TeX Live on Linux). This should work well on the
EFL & GTK ports for which the initial OpenType MATH support has been
tested. Other ports will be handled later.
No new tests. This is already tested in LayoutTests/mathml/opentype/.
- css/mathml.css:
(math): Add "Latin Modern Math" as the first font-family of the <math> element.
